RE: [PATCH] drm/dp_mst: Remove VCPI while disabling topology mgr

2019-12-02 Thread Lin, Wayne
> -Original Message- > From: Lyude Paul > Sent: Tuesday, December 3, 2019 8:03 AM > To: Lin, Wayne ; dri-devel@lists.freedesktop.org; > amd-...@lists.freedesktop.org > Cc: Kazlauskas, Nicholas ; Wentland, Harry > ; Zuo, Jerry > Subject: Re: [PATCH] drm/dp_mst: Remove VCPI while disablin

Re: [PATCH v1 07/26] drm/panel: remove get_timings

2019-12-02 Thread Maxime Ripard
Hi, On Mon, Dec 02, 2019 at 08:32:11PM +0100, Sam Ravnborg wrote: > There was no users - so remove it. > The callback was implemented in two drivers - deleted. > > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Laurent Pinchart > Cc: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime R

Re: [PATCH] ARM: dts: am335x-evm: Use drm simple-panel instead of tilcdc-panel

2019-12-02 Thread Laurent Pinchart
Hi Jyri, Thank you for the patch. On Mon, Dec 02, 2019 at 08:57:29PM +0200, Jyri Sarha wrote: > Move to use the new drm panel support in tilcdc together with added > "tfc,s9700rtwv43tr-01b"-panel support in drm panel-simple. > > Signed-off-by: Jyri Sarha > Reviewed-by: Tomi Valkeinen > --- > "

Re: [PATCH v1 0/26] drm/panel infrastructure + backlight update

2019-12-02 Thread Laurent Pinchart
Hi Sam, On Mon, Dec 02, 2019 at 08:32:04PM +0100, Sam Ravnborg wrote: > This patchset include a couple of different > things - all related to panels. > > - The panel callbacks are optional - so drop error if > callback is not present. > > - Add support for backlight in drm_panel. > This all

Re: [PATCH v1 25/26] drm/panel: tpo-td028ttec1: use drm_panel backlight support

2019-12-02 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:29PM +0100, Sam Ravnborg wrote: > Use the backlight support in drm_panel to simplify the driver > > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Sam Ravnborg Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/pane

Re: [PATCH v1 13/26] drm/panel: lvds: use drm_panel backlight support

2019-12-02 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:17PM +0100, Sam Ravnborg wrote: > Use the backlight support in drm_panel to simplify the driver > > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Sam Ravnborg Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/pane

Re: [PATCH v1 08/26] drm/panel: drop drm_device from drm_panel

2019-12-02 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:12PM +0100, Sam Ravnborg wrote: > The panel drivers used drm_panel.drm for two purposes: > 1) Argument to drm_mode_duplicate() > 2) drm->dev was used in error messages > > The first usage is replaced with drm_connector.dev > - drm_co

[PATCH v2 6/6] drm/mediatek: apply CMDQ control flow

2019-12-02 Thread Bibby Hsieh
Unlike other SoCs, MT8183 does not have "shadow" registers for performaing an atomic video mode set or page flip at vblank/vsync. The CMDQ (Commend Queue) in MT8183 is used to help update all relevant display controller registers with critical time limation. Signed-off-by: YT Shen Signed-off-by:

[PATCH v2 4/6] drm/mediatek: remove unused external function

2019-12-02 Thread Bibby Hsieh
layer_on and layer_off both are unused external function, remove them from mtk_ddp_comp_funcs structure. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 -- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 16 2 files changed, 18 deletions(-) diff -

[PATCH v2 3/6] drm/mediatek: update cursors by using async atomic update

2019-12-02 Thread Bibby Hsieh
Support to async updates of cursors by using the new atomic interface for that. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 33 drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 + drivers/gpu/drm/mediatek/mtk_drm_plane.c | 50

[PATCH v2 1/6] drm/mediatek: use DRM core's atomic commit helper

2019-12-02 Thread Bibby Hsieh
The DRM core atomic helper now supports asynchronous commits natively. The custom drm implementation isn't needed anymore, remove it. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 86 ++ drivers/gpu/drm/mediatek/mtk_drm_drv.h

[PATCH v2 2/6] drm/mediatek: handle events when enabling/disabling crtc

2019-12-02 Thread Bibby Hsieh
The driver currently handles vblank events only when updating planes on an already enabled CRTC. The atomic update API however allows requesting an event when enabling or disabling a CRTC. This currently leads to event objects being leaked in the kernel and to events not being sent out. Fix it. Si

[PATCH v2 0/6] drm/mediatek: fix cursor issue and apply CMDQ in MTK DRM

2019-12-02 Thread Bibby Hsieh
The CMDQ (Command Queue) in MT8183 is used to help update all relevant display controller registers with critical time limation. This patch add cmdq interface in ddp_comp interface, let all ddp_comp interface can support cpu/cmdq function at the same time. These patches also can fixup cursor movin

[PATCH v2 5/6] drm/mediatek: support CMDQ interface in ddp component

2019-12-02 Thread Bibby Hsieh
The CMDQ (Command Queue) in MT8183 is used to help update all relevant display controller registers with critical time limation. This patch add cmdq interface in ddp_comp interface, let all ddp_comp interface can support cpu/cmdq function at the same time. Signed-off-by: YT Shen Signed-off-by: CK

Re: [PATCH v1, 2/2] drm/mediatek: Fix external display vblank timeout issue

2019-12-02 Thread CK Hu
Hi, Yongqiang: I would like the title could clearly express what does this patch do. I think what this patch do is to implement prepare/unprepare interface for dpi driver. And you could describe why do this in commit message. On Wed, 2019-11-27 at 09:17 +0800, yongqiang@mediatek.com wrote: >

Re: [PATCH v1 07/26] drm/panel: remove get_timings

2019-12-02 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:11PM +0100, Sam Ravnborg wrote: > There was no users - so remove it. > The callback was implemented in two drivers - deleted. This looks good to me, so Reviewed-by: Laurent Pinchart but I'll let Thierry decide if he prefers keepin

Re: [PATCH v1 06/26] drm/panel: decouple connector from drm_panel

2019-12-02 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:10PM +0100, Sam Ravnborg wrote: > To facilitate that connector creation will be moved > to display drivers, decouple the drm_connector from drm_panel. "To facilitate moving connector creation to display drivers, ..." > Add a connect

Re: [PATCH v2 1/2] drm/komeda: Update the chip identify

2019-12-02 Thread james qian wang (Arm Technology China)
On Mon, Dec 02, 2019 at 11:07:54AM +, Mihail Atanassov wrote: > On Thursday, 21 November 2019 08:17:39 GMT james qian wang (Arm Technology > China) wrote: > > 1. Drop komeda-CORE product id comparison and put it into the d71_identify > > 2. Update pipeline node DT-binding: > >(a). Skip the

Re: [PATCH v1 05/26] drm/panel: add drm_connector argument to get_modes()

2019-12-02 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:09PM +0100, Sam Ravnborg wrote: > Today the bridge creates the drm_connector, but that is planned > to be moved to the display drivers. > To facilitate this, update drm_panel_funcs.get_modes() to > take drm_connector as an argument. >

Re: [PATCH v2 2/2] drm/komeda: Enable new product D32 support

2019-12-02 Thread james qian wang (Arm Technology China)
On Mon, Dec 02, 2019 at 11:07:52AM +, Mihail Atanassov wrote: > On Thursday, 21 November 2019 08:17:45 GMT james qian wang (Arm Technology > China) wrote: > > D32 is simple version of D71, the difference is: > > - Only has one pipeline > > - Drop the periph block and merge it to GCU > > > > v

Re: [PATCH v1 04/26] drm: get drm_bridge_panel connector via helper

2019-12-02 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:08PM +0100, Sam Ravnborg wrote: > The drm_connector created by drm_panel_bridge was accessed > via drm_panel.connector. > Avoid the detour around drm_panel by providing a simple get method. > This avoids direct access to the connector

Re: [PATCH v1 03/26] drm/panel: simple: use drm_panel backlight support

2019-12-02 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:07PM +0100, Sam Ravnborg wrote: > Use drm_panel infrastructure for backlight. > Replace direct calls with drm_panel_*() calls > to utilize the drm_panel support. > > Signed-off-by: Sam Ravnborg > cc: Laurent Pinchart > Cc: Thierry

Re: [PATCH v11 4/7] drm/sun4i: dsi: Handle bus clock explicitly

2019-12-02 Thread Jagan Teki
On Thu, Nov 28, 2019 at 11:21 PM Maxime Ripard wrote: > > On Sat, Nov 23, 2019 at 01:20:21AM +0530, Jagan Teki wrote: > > > > Please have a look at this snippet, I have used your second > > > > suggestions. let me know if you have any comments? > > > > > > > > diff --git a/drivers/gpu/drm/sun4i/su

Re: [PATCH v1 02/26] drm/panel: add backlight support

2019-12-02 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:06PM +0100, Sam Ravnborg wrote: > Panels often supports backlight as specified in a device tree. > Update the drm_panel infrastructure to support this to > simplify the drivers. > > With this the panel driver just needs to add the fo

Re: [PATCH v1 01/26] drm/drm_panel: no error when no callback

2019-12-02 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:05PM +0100, Sam Ravnborg wrote: > The callbacks in drm_panel_funcs are optional, so do not > return an error just because no callback is assigned. Unless I'm mistaken the callbacks are not documented as optional. Should this be fixed

Re: [PATCH v1 6/6] drm/mediatek: apply CMDQ control flow

2019-12-02 Thread CK Hu
Hi, Bibby: On Tue, 2019-12-03 at 13:58 +0800, Bibby Hsieh wrote: > On Tue, 2019-12-03 at 09:38 +0800, CK Hu wrote: > > Hi, Bibby: > > > > On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > > > Unlike other SoCs, MT8183 does not have "shadow" > > > registers for performaing an atomic video mo

Re: [01/30] drm: Introduce drm_bridge_init()

2019-12-02 Thread james qian wang (Arm Technology China)
On Mon, Dec 02, 2019 at 09:49:35AM +0100, Daniel Vetter wrote: > On Mon, Dec 02, 2019 at 05:55:06AM +, james qian wang (Arm Technology > China) wrote: > > On Tue, Nov 26, 2019 at 01:15:59PM +, Mihail Atanassov wrote: > > > A simple convenience function to initialize the struct drm_bridge.

Re: [PATCH v1 6/6] drm/mediatek: apply CMDQ control flow

2019-12-02 Thread Bibby Hsieh
On Tue, 2019-12-03 at 09:38 +0800, CK Hu wrote: > Hi, Bibby: > > On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > > Unlike other SoCs, MT8183 does not have "shadow" > > registers for performaing an atomic video mode > > set or page flip at vblank/vsync. > > > > The CMDQ (Commend Queue) in

Re: [PATCH v1, 1/2] drm/mediatek: Fixup external display black screen issue

2019-12-02 Thread CK Hu
Hi, Yongqiang: On Wed, 2019-11-27 at 09:17 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > Problem: > overlay hangup when external display hotplut test > > Fix: > disable overlay when crtc disable I think you do two things in this patch. The first is to config layer before c

Re: [PATCH v2] drm/mediatek: add ctm property support

2019-12-02 Thread CK Hu
Hi, Yongqiang: On Mon, 2019-12-02 at 17:03 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > add ctm property support > > Change-Id: I8111da7b309b1809c6302e7748dd9fd06dc97bde Remove this Change-Id. > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc

Re: [PATCH 22/30] drm/exynos: mic: Use drm_bridge_init()

2019-12-02 Thread Inki Dae
19. 11. 26. 오후 10:16에 Mihail Atanassov 이(가) 쓴 글: > No functional change: no logic depends on driver_private being NULL, so > it's safe to set it earlier in exynos_mic_probe. Acked-by: Inki Dae And tested this patch on TM2 and TM2E boards. Tested-by: Inki Dae Thanks, Inki Dae > > Signed-off-b

[PATCH v2] drm/dp_mst: Correct the bug in drm_dp_update_payload_part1()

2019-12-02 Thread Wayne Lin
[Why] If the payload_state is DP_PAYLOAD_DELETE_LOCAL in series, current code doesn't delete the payload at current index and just move the index to next one after shuffling payloads. [How] Drop the i++ increasing part in for loop head and decide whether to increase the index or not according to p

RE: [PATCH] drm/dp_mst: Correct the bug in drm_dp_update_payload_part1()

2019-12-02 Thread Lin, Wayne
> -Original Message- > From: Lyude Paul > Sent: Tuesday, December 3, 2019 8:23 AM > To: Lin, Wayne ; dri-devel@lists.freedesktop.org; > amd-...@lists.freedesktop.org > Cc: Kazlauskas, Nicholas ; Wentland, Harry > ; Zuo, Jerry > Subject: Re: [PATCH] drm/dp_mst: Correct the bug in > drm_d

Re: [PATCH v1 5/6] drm/mediatek: support CMDQ interface in ddp component

2019-12-02 Thread CK Hu
Hi, Bibby: On Tue, 2019-12-03 at 10:56 +0800, CK Hu wrote: > Hi, Bibby: > > On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > > The CMDQ (Command Queue) in MT8183 is used to help > > update all relevant display controller registers > > with critical time limation. > > This patch add cmdq in

Re: [PATCH v1 5/6] drm/mediatek: support CMDQ interface in ddp component

2019-12-02 Thread CK Hu
Hi, Bibby: On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > The CMDQ (Command Queue) in MT8183 is used to help > update all relevant display controller registers > with critical time limation. > This patch add cmdq interface in ddp_comp interface, > let all ddp_comp interface can support cp

Re: [PATCH 2/5] udmabuf: allow userspace to set map attributes

2019-12-02 Thread Gurchetan Singh
On Thu, Nov 28, 2019 at 3:48 AM Gerd Hoffmann wrote: > > Hi, > > > diff --git a/include/uapi/linux/udmabuf.h b/include/uapi/linux/udmabuf.h > > index 46b6532ed855..f90831f2bb0d 100644 > > --- a/include/uapi/linux/udmabuf.h > > +++ b/include/uapi/linux/udmabuf.h > > @@ -6,6 +6,8 @@ > > #include

Re: [PATCH v1 6/6] drm/mediatek: apply CMDQ control flow

2019-12-02 Thread CK Hu
Hi, Bibby: On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > Unlike other SoCs, MT8183 does not have "shadow" > registers for performaing an atomic video mode > set or page flip at vblank/vsync. > > The CMDQ (Commend Queue) in MT8183 is used to help > update all relevant display controller

[PATCH 3/4] udmabuf: separate out creating/destroying scatter-table

2019-12-02 Thread Gurchetan Singh
These are nice functions and can be re-used. Signed-off-by: Gurchetan Singh --- drivers/dma-buf/udmabuf.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index f0bf3ba7441e..0a610e09ae23 100644

[PATCH 4/4] udmabuf: implement begin_cpu_access/end_cpu_access hooks

2019-12-02 Thread Gurchetan Singh
With the misc device, we should end up using the result of get_arch_dma_ops(..) or dma-direct ops. This can allow us to have WC mappings in the guest after synchronization. Signed-off-by: Gurchetan Singh --- drivers/dma-buf/udmabuf.c | 39 +++ 1 file changed,

[PATCH 1/4] udmabuf: use cache_sgt_mapping option

2019-12-02 Thread Gurchetan Singh
The GEM prime helpers do it, so should we. It's also possible to make it optional later. Signed-off-by: Gurchetan Singh --- drivers/dma-buf/udmabuf.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index 9de539c1d

[PATCH 2/4] udmabuf: add a pointer to the miscdevice in dma-buf private data

2019-12-02 Thread Gurchetan Singh
Will be used later. v2: rename 'udmabuf_misc' to 'device' (kraxel) Signed-off-by: Gurchetan Singh --- drivers/dma-buf/udmabuf.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index be15eb6b0586..f0bf3ba7441e

Re: [PATCH] drm/dp_mst: Correct the bug in drm_dp_update_payload_part1()

2019-12-02 Thread Lyude Paul
On Mon, 2019-12-02 at 11:58 +0800, Wayne Lin wrote: > [Why] > If the payload_state is DP_PAYLOAD_DELETE_LOCAL in series, current > code doesn't delete the payload at current index and just move the > index to next one after shuffling payloads. > > [How] > After shuffling payloads, decide whether t

Re: [PATCH] drm/dp_mst: Remove VCPI while disabling topology mgr

2019-12-02 Thread Lyude Paul
I'm, not entirely sure what this patch is trying to accomplish. I'm guessing maybe we're leaving stale VCPI allocations from the previous topology enablement and then somehow trying to use those again when allocating payloads? The patch looks correct at least. If this patch is fixing an issue, suc

Re: [PATCH v6] drm/panel: Add generic DSI display controller YAML bindings

2019-12-02 Thread Rob Herring
On Thu, Nov 28, 2019 at 3:07 AM Linus Walleij wrote: > > This adds a starting point for processing and defining generic > bindings used by DSI display controllers and panels attached to > the virtual DSI ports. > > Cc: Stephan Gerhold > Cc: devicet...@vger.kernel.org > Suggested-by: Rob Herring

Re: [PATCH] drm/amd/display: remove redundant assignment to variable v_total

2019-12-02 Thread Alex Deucher
Applied. thanks! Alex On Mon, Dec 2, 2019 at 10:47 AM Colin King wrote: > > From: Colin Ian King > > The variable v_total is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-

Re: [PATCH 0/4] drm/amd/display: Remove unneeded semicolon

2019-12-02 Thread Alex Deucher
Applied the series. Thanks! Alex On Thu, Nov 28, 2019 at 9:46 AM Harry Wentland wrote: > > Series is > Reviewed-by: Harry Wentland > > Harry > > On 2019-11-27 9:31 p.m., zhengbin wrote: > > zhengbin (4): > > drm/amd/display: Remove unneeded semicolon in bios_parser.c > > drm/amd/display: R

Re: [PATCH 0/5] drm/amd/powerplay: Remove unneeded variable

2019-12-02 Thread Alex Deucher
Applied the series. Thanks! Alex On Wed, Nov 27, 2019 at 12:42 PM zhengbin wrote: > > zhengbin (5): > drm/amd/powerplay: Remove unneeded variable 'result' in smu10_hwmgr.c > drm/amd/powerplay: Remove unneeded variable 'result' in vega10_hwmgr.c > drm/amd/powerplay: Remove unneeded variabl

Re: [PATCH][next] drm/amd/display: fix double assignment to msg_id field

2019-12-02 Thread Alex Deucher
Applied. thanks! Alex On Wed, Nov 27, 2019 at 11:51 AM Harry Wentland wrote: > > On 2019-11-20 12:22 p.m., Colin King wrote: > > From: Colin Ian King > > > > The msg_id field is being assigned twice. Fix this by replacing the second > > assignment with an assignment to msg_size. > > > > Addres

Re: [PATCH] drm/radeon: fix r1xx/r2xx register checker for POT textures

2019-12-02 Thread Alex Deucher
Ping? Alex On Tue, Nov 26, 2019 at 9:43 AM Alex Deucher wrote: > > Shift and mask were reversed. Noticed by chance. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/radeon/r100.c | 4 ++-- > drivers/gpu/drm/radeon/r200.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >

Re: [PATCH v1 0/26] drm/panel infrastructure + backlight update

2019-12-02 Thread Sam Ravnborg
Hi Jeffrey. > > drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- > > How come the diff stat in the cover letter here indicates a change to > this file, yet I cannot find a change to this file in any of the > patches? What am I missing? This file is patched in "[PATCH v1 06/26] drm/p

Re: [Intel-gfx] [RFC 03/13] drm/i915/svm: Runtime (RT) allocator support

2019-12-02 Thread Niranjan Vishwanathapura
On Thu, Nov 28, 2019 at 02:12:30PM +0200, Joonas Lahtinen wrote: Quoting Niranjan Vishwanathapura (2019-11-27 21:23:56) >We should try to have the uAPI as final as early as possible. The >change process is harder the later it is done, even for RFC :) > >On the same note, I'm inclined to have I91

Re: [PATCH v1] drm/msm: add support for 2.4.1 DSI version for sc7180 soc

2019-12-02 Thread Rob Clark
On Thu, Nov 28, 2019 at 11:05 PM Harigovindan P wrote: > > Changes in v1: > -Modify commit text to indicate DSI version and SOC detail(Jeffrey > Hugo). > -Splitting visionox panel driver code out into a > different patch(set), since panel drivers are merged into >

Re: [RFC 00/13] drm/i915/svm: Add SVM support

2019-12-02 Thread Niranjan Vishwanathapura
On Tue, Nov 26, 2019 at 04:03:21PM +0200, Joonas Lahtinen wrote: Quoting Niranjana Vishwanathapura (2019-11-22 22:57:21) Shared Virtual Memory (SVM) allows the programmer to use a single virtual address space which will be shared between threads executing on CPUs and GPUs. It abstracts away from

[PATCH v8 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2019-12-02 Thread Guido Günther
This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 SoCs. It adds support for the i.MX8MQ but the same IP can be found on e.g. the i.MX8QXP. It has been tested on the Librem 5 devkit using mxsfb. Signed-off-by: Guido Günther Co-developed-by: Robert Chiras Signed-off-b

[PATCH v8 1/2] dt-bindings: display/bridge: Add binding for NWL mipi dsi host controller

2019-12-02 Thread Guido Günther
The Northwest Logic MIPI DSI IP core can be found in NXPs i.MX8 SoCs. Signed-off-by: Guido Günther Tested-by: Robert Chiras Reviewed-by: Rob Herring --- .../bindings/display/bridge/nwl-dsi.yaml | 203 ++ 1 file changed, 203 insertions(+) create mode 100644 Documentation/

[PATCH v8 0/2] drm: bridge: Add NWL MIPI DSI host controller support

2019-12-02 Thread Guido Günther
This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 SoCs. It adds support for the i.MX8MQ but the same IP core can also be found on e.g. i.MX8QXP. I added the necessary hooks to support other imx8 variants but since I only have imx8mq boards to test I omitted the platform

[PATCH v4 2/4] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields

2019-12-02 Thread Adrian Ratiu
Register existence, address/offsets, field layouts, reserved bits and so on differ between MIPI-DSI versions and between SoC vendor boards. Despite these differences the hw IP and protocols are mostly the same so the generic driver can be made to compensate these differences. The current Rockchip

[PATCH v4 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver

2019-12-02 Thread Adrian Ratiu
atest linux-next tree, next-20191202. v3 -> v4: * Added commmit message to dt-binding patch (Neil) * Converted the dt-binding to yaml dt-schema format (Neil) * Small DT node + driver fixes (Rob) * Renamed platform driver to reflect it's only for i.MX v6 (Fabio) * Added small panel e

[PATCH v1 24/26] drm/panel: sitronix-st7789v: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 37 ++- 1 file changed, 4 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-s

[PATCH v1 25/26] drm/panel: tpo-td028ttec1: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-tpo-td028ttec1.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-tpo-td0

[PATCH v1 26/26] drm/panel: tpo-tpg110: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Linus Walleij Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-tpo-tpg110.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v1 15/26] drm/panel: osd-osd101t2587-53ts: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- .../drm/panel/panel-osd-osd101t2587-53ts.c| 24 +++ 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-o

[PATCH v4 4/4] dt-bindings: display: add i.MX6 MIPI DSI host controller doc

2019-12-02 Thread Adrian Ratiu
This provides an example DT binding for the MIPI DSI host controller present on the i.MX6 SoC based on Synopsis DesignWare v1.01 IP. Cc: Rob Herring Cc: Neil Armstrong Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- .../display/imx/fsl,mipi-dsi-imx6.y

[PATCH v1 22/26] drm/panel: sharp-ls043t1le01: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- .../gpu/drm/panel/panel-sharp-ls043t1le01.c | 20 +++ 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-s

[PATCH v1 07/26] drm/panel: remove get_timings

2019-12-02 Thread Sam Ravnborg
There was no users - so remove it. The callback was implemented in two drivers - deleted. Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Laurent Pinchart Cc: Sam Ravnborg Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/panel/panel-seiko-4

[PATCH v1 23/26] drm/panel: sitronix-st7701: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Jagan Teki Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-sitronix-st7701.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/panel

[PATCH v1 09/26] drm/panel: feiyang-fy07024di26a30d: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Jagan Teki Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v4 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap

2019-12-02 Thread Adrian Ratiu
Convert the common bridge code and the two rockchip & stm drivers which currently use it to the regmap API in anticipation for further changes to make it more generic and add older DSI host controller support as found on i.mx6 based devices. The regmap becomes an internal state of the bridge. No f

[PATCH v1 18/26] drm/panel: rocktech-jh057n00900: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver. While touching the include files sort them and divide them up in blocks. Signed-off-by: Sam Ravnborg Cc: "Guido Günther" Cc: Purism Kernel Team Cc: Thierry Reding Cc: Sam Ravnborg --- .../drm/panel/panel-rocktech-jh057n00900.c

[PATCH v1 11/26] drm/panel: innolux-p079zca: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 28 ++- 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-i

[PATCH v4 3/4] drm: imx: Add i.MX 6 MIPI DSI host driver

2019-12-02 Thread Adrian Ratiu
This adds support for the Synopsis DesignWare MIPI DSI v1.01 host controller which is embedded in i.MX 6 SoCs. Based on following patches, but updated/extended to work with existing support found in the kernel: - drm: imx: Support Synopsys DesignWare MIPI DSI host controller Signed-off-by: Liu

[PATCH v1 21/26] drm/panel: sharp-lq101r1sx01: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- .../gpu/drm/panel/panel-sharp-lq101r1sx01.c | 21 +++ 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-s

[PATCH v1 06/26] drm/panel: decouple connector from drm_panel

2019-12-02 Thread Sam Ravnborg
To facilitate that connector creation will be moved to display drivers, decouple the drm_connector from drm_panel. Add a connector argument to drm_panel_get_modes() All users of drm_panel_get_modes() already had the connector available, so updating users was trivial. With this patch drm_panel no

[PATCH v1 20/26] drm/panel: seiko-43wvf1g: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 36 - 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-s

[PATCH v1 16/26] drm/panel: panasonic-vvx10f034n00: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- .../drm/panel/panel-panasonic-vvx10f034n00.c | 45 +++ 1 file changed, 6 insertions(+), 39 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-p

[PATCH v1 01/26] drm/drm_panel: no error when no callback

2019-12-02 Thread Sam Ravnborg
The callbacks in drm_panel_funcs are optional, so do not return an error just because no callback is assigned. Signed-off-by: Sam Ravnborg Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/drm_panel.c | 35 +++

[PATCH v1 12/26] drm/panel: kingdisplay-kd097d04: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- .../drm/panel/panel-kingdisplay-kd097d04.c| 28 ++- 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-k

[PATCH v1 13/26] drm/panel: lvds: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-lvds.c | 40 -- 1 file changed, 5 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-l

[PATCH v1 17/26] drm/panel: raydium-rm68200: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-raydium-rm68200.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-raydi

[PATCH v1 19/26] drm/panel: ronbo-rb070d30: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-ronbo-rb070d30.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ro

[PATCH v1 02/26] drm/panel: add backlight support

2019-12-02 Thread Sam Ravnborg
Panels often supports backlight as specified in a device tree. Update the drm_panel infrastructure to support this to simplify the drivers. With this the panel driver just needs to add the following to the probe() function: err = drm_panel_of_backlight(panel); if (err) return

[PATCH v1 05/26] drm/panel: add drm_connector argument to get_modes()

2019-12-02 Thread Sam Ravnborg
Today the bridge creates the drm_connector, but that is planned to be moved to the display drivers. To facilitate this, update drm_panel_funcs.get_modes() to take drm_connector as an argument. All panel drivers implementing get_modes() are updated. Signed-off-by: Sam Ravnborg Cc: Thierry Reding

[PATCH v1 08/26] drm/panel: drop drm_device from drm_panel

2019-12-02 Thread Sam Ravnborg
The panel drivers used drm_panel.drm for two purposes: 1) Argument to drm_mode_duplicate() 2) drm->dev was used in error messages The first usage is replaced with drm_connector.dev - drm_connector is already connected to a drm_device and we have a valid connector The second usage is replaced wi

[PATCH v1 14/26] drm/panel: olimex-lcd-olinuxino: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Stefan Mavrodiev Cc: Thierry Reding Cc: Sam Ravnborg --- .../gpu/drm/panel/panel-olimex-lcd-olinuxino.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers

[PATCH v1 10/26] drm/panel: ilitek-ili9881c: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use the backlight support in drm_panel to simplify the driver Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-i

[PATCH v1 03/26] drm/panel: simple: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use drm_panel infrastructure for backlight. Replace direct calls with drm_panel_*() calls to utilize the drm_panel support. Signed-off-by: Sam Ravnborg cc: Laurent Pinchart Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-simple.c | 50 ++-- 1 file c

[PATCH v1 04/26] drm: get drm_bridge_panel connector via helper

2019-12-02 Thread Sam Ravnborg
The drm_connector created by drm_panel_bridge was accessed via drm_panel.connector. Avoid the detour around drm_panel by providing a simple get method. This avoids direct access to the connector field in drm_panel in the two users. Update pl111 and tve200 to use the new helper. Signed-off-by: Sam

[PATCH v1 0/26] drm/panel infrastructure + backlight update

2019-12-02 Thread Sam Ravnborg
This patchset include a couple of different things - all related to panels. - The panel callbacks are optional - so drop error if callback is not present. - Add support for backlight in drm_panel. This allows us to make much simpler backlight support to most panels. The patchset include

RE: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2019-12-02 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Hi Andrey, Seems this patch is still not in amd-staging-drm-next? Best wishes Emily Deng >-Original Message- >From: Deng, Emily >Sent: Tuesday, November 26, 2019 4:41 PM >To: Grodzovsky, Andrey >Cc: dri-devel@lists.freedesktop.o

Re: [PATCH RFC v4 02/16] cgroup: Introduce cgroup for drm subsystem

2019-12-02 Thread Tejun Heo
On Fri, Nov 29, 2019 at 01:00:36AM -0500, Kenny Ho wrote: > On Tue, Oct 1, 2019 at 10:31 AM Michal Koutný wrote: > > On Thu, Aug 29, 2019 at 02:05:19AM -0400, Kenny Ho wrote: > > > +struct cgroup_subsys drm_cgrp_subsys = { > > > + .css_alloc = drmcg_css_alloc, > > > + .css_free

[RESEND 0/2] Changes for DP 1.4 Compliance test 4.2.2.6

2019-12-02 Thread Jerry (Fangzhi) Zuo
Unlike DP 1.2 Compliance test 4.2.2.6, DP 1.4 requires to calculate real CRC value of the last edid data block, and write it back. Current edid CRC calculate routine adds the last CRC byte, and check if non-zero or not. Need to return the actual CRC value when corruption is detected. [For CI] Res

[RESEND 1/2] drm: Add support for DP 1.4 Compliance edid corruption test 4.2.2.6

2019-12-02 Thread Jerry (Fangzhi) Zuo
DP 1.4 edid corruption test requires source DUT to write calculated CRC, not the corrupted CRC from reference sink. Return the calculated CRC back, and initiate the required sequence. -v2: Have separate routine for returning real CRC -v3: Rewrite checksum computation routine to avoid duplicated

[RESEND 2/2] drm/amd/display: Hook up drm interface for DP 1.4 edid corruption test

2019-12-02 Thread Jerry (Fangzhi) Zuo
-v3: Rename to avoid confusion Signed-off-by: Jerry (Fangzhi) Zuo Reviewed-by: Harry Wentland --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 35 +- 1 file changed, 7 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helper

Re: [DPU PATCH v3 3/5] drm/msm/dp: add displayPort driver support

2019-12-02 Thread Rob Clark
On Mon, Dec 2, 2019 at 5:48 AM Chandan Uddaraju wrote: > > Add the needed displayPort files to enable DP driver > on msm target. > > "dp_display" module is the main module that calls into > other sub-modules. "dp_drm" file represents the interface > between DRM framework and DP driver. > > changes

[PATCH] ARM: dts: am335x-evm: Use drm simple-panel instead of tilcdc-panel

2019-12-02 Thread Jyri Sarha
Move to use the new drm panel support in tilcdc together with added "tfc,s9700rtwv43tr-01b"-panel support in drm panel-simple. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen --- "tfc,s9700rtwv43tr-01b" in panel-simple has been in for some time now so it is about time to get this in too.

Re: [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n

2019-12-02 Thread Lyude Paul
Reviewed-by: Lyude Paul I'll go ahead and push this to drm-misc-next, thanks! On Mon, 2019-12-02 at 16:20 +0100, Geert Uytterhoeven wrote: > On Mon, Dec 2, 2019 at 2:41 PM Guenter Roeck wrote: > > On systems with STACKTRACE_SUPPORT=n, we get: > > > > WARNING: unmet direct dependencies detected

Re: [PATCH] drm/mcde: Fix vertical resolution bugs

2019-12-02 Thread kbuild test robot
Hi Linus, I love your patch! Yet something to improve: [auto build test ERROR on drm-exynos/exynos-drm-next] [also build test ERROR on v5.4 next-20191202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '-

Re: [PATCH libdrm v3] modetest: Use floating vrefresh while dumping mode

2019-12-02 Thread Ville Syrjälä
On Mon, Dec 02, 2019 at 06:22:56PM +0100, Neil Armstrong wrote: > On 02/12/2019 18:12, Ville Syrjälä wrote: > > On Mon, Dec 02, 2019 at 03:27:51AM -0800, Devarsh Thakkar wrote: > >> Add function to derive floating value of vertical > >> refresh rate from drm mode using pixel clock, > >> horizontal

[PATCH] drm: remove no longer used .master_{create, destroy} callbacks

2019-12-02 Thread Emil Velikov
From: Emil Velikov Up-to recently the only driver which required these was vmwgfx. With commit 9c84aeba67cc ("drm/vmwgfx: Kill unneeded legacy security features") the driver no longer sets them, so we can drop the unused infra. Cc: Thomas Hellstrom Cc: Daniel Vetter Signed-off-by: Emil Veliko

Re: [PATCH] drm/mcde: Fix vertical resolution bugs

2019-12-02 Thread kbuild test robot
Hi Linus, I love your patch! Yet something to improve: [auto build test ERROR on drm-exynos/exynos-drm-next] [also build test ERROR on v5.4 next-20191202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '-

  1   2   >