Re: [PATCH] drm: Funnel drm logs to tracepoints

2019-12-03 Thread Pekka Paalanen
On Tue, 3 Dec 2019 22:20:14 +0100 Daniel Vetter wrote: > On Tue, Dec 3, 2019 at 8:10 PM Sean Paul wrote: > > > > On Thu, Oct 17, 2019 at 10:22:16AM +0300, Pekka Paalanen wrote: > > > On Wed, 16 Oct 2019 15:23:45 +0200 > > > Thomas Zimmermann wrote: > > > > > > > Hi > > > > > > > > Am 16.10.

Re: [PATCH 3/4] drm/mgag200: Add workaround for HW that does not support 'startadd'

2019-12-03 Thread Thomas Zimmermann
Hi John Am 03.12.19 um 18:55 schrieb John Donnelly: > Hi , > > See below , > > >> On Nov 26, 2019, at 3:50 AM, Thomas Zimmermann wrote: >> >> Hi >> >> Am 26.11.19 um 10:37 schrieb Daniel Vetter: >>> On Tue, Nov 26, 2019 at 08:25:44AM +0100, Thomas Zimmermann wrote: There's at least one sy

Re: [Intel-gfx] [PATCH v3 04/12] video: fbdev: uvesafb: modify the static fb_ops directly

2019-12-03 Thread Jani Nikula
On Tue, 03 Dec 2019, Daniel Vetter wrote: > On Tue, Dec 03, 2019 at 06:38:46PM +0200, Jani Nikula wrote: >> Avoid modifying the fb_ops via info->fbops to let us make the pointer >> const in the future. >> >> Cc: linux-fb...@vger.kernel.org >> Signed-off-by: Jani Nikula >> --- >> drivers/video/f

Re: [PATCH v2 3/6] drm/mediatek: update cursors by using async atomic update

2019-12-03 Thread CK Hu
Hi, Bibby: You move the mutex protection to [PATCH v2 6/6] drm/mediatek: apply CMDQ control flow, but the race condition exist in this patch. So you should move that back in this patch. Regards, CK On Tue, 2019-12-03 at 15:10 +0800, Bibby Hsieh wrote: > Support to async updates of cursors by usi

Re: [PATCH v2 4/6] drm/mediatek: remove unused external function

2019-12-03 Thread CK Hu
Hi, Bibby: On Tue, 2019-12-03 at 15:10 +0800, Bibby Hsieh wrote: > layer_on and layer_off both are unused external function, > remove them from mtk_ddp_comp_funcs structure. > Reviewed-by: CK Hu > Signed-off-by: Bibby Hsieh > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 -- > drive

Re: [PATCH 01/11] drm/i915: Fix sha_text population code

2019-12-03 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: ee5e5e7a5e0f ("drm/i915: Add HDCP framework + base implementation"). The bot has tested the following trees: v5.4.1, v5.3.14, v4.19.87. v5.4.1: Build OK! v5.3.14: Build OK! v4.19.

Re: [PATCH 1/2] PM / runtime: Allow drivers to override runtime PM behaviour on sleep

2019-12-03 Thread Rafael J. Wysocki
On Fri, Nov 29, 2019 at 1:07 PM Thierry Reding wrote: > > On Fri, Nov 29, 2019 at 11:22:08AM +0100, Rafael J. Wysocki wrote: > > [cut] Sorry for the delay. First off, let me note that I have seen your most recent patches and thanks for taking the feedback into account, much appreciated! Nevert

[PATCH v2] drm/i915: Assume 100% brightness when not in DPCD control mode

2019-12-03 Thread Lyude Paul
Currently we always determine the initial panel brightness level by simply reading the value from DP_EDP_BACKLIGHT_BRIGHTNESS_MSB/LSB. This seems wrong though, because if the panel is not currently in DPCD control mode there's not really any reason why there would be any brightness value programmed

Re: [PATCH v8 16/17] drm/dp_mst: Add helper to trigger modeset on affected DSC MST CRTCs

2019-12-03 Thread kbuild test robot
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20191203] [cannot apply to drm-intel/for-linux-next linus/master v5.4-rc8 v5.4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to

Re: KASAN: slab-out-of-bounds Read in fbcon_get_font

2019-12-03 Thread Daniel Vetter
On Tue, Dec 3, 2019 at 11:25 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:76bb8b05 Merge tag 'kbuild-v5.5' of git://git.kernel.org/p.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=10bfe282e0 > kernel config:

Re: [PATCH v1] drm/msm: add support for 2.4.1 DSI version for sc7180 soc

2019-12-03 Thread Rob Clark
On Tue, Dec 3, 2019 at 2:22 PM Matthias Kaehlcke wrote: > > Hi, > > On Fri, Nov 29, 2019 at 12:35:05PM +0530, Harigovindan P wrote: > > Changes in v1: > > -Modify commit text to indicate DSI version and SOC detail(Jeffrey > > Hugo). > > -Splitting visionox panel driver code out into a

Re: [PATCH v1] drm/msm: add support for 2.4.1 DSI version for sc7180 soc

2019-12-03 Thread Matthias Kaehlcke
Hi, On Fri, Nov 29, 2019 at 12:35:05PM +0530, Harigovindan P wrote: > Changes in v1: > -Modify commit text to indicate DSI version and SOC detail(Jeffrey > Hugo). > -Splitting visionox panel driver code out into a >different patch(set), since panel drivers are merged into >

Re: [PATCH 1/6] dt-bindings: display/ingenic: Add compatible string for JZ4770

2019-12-03 Thread Rob Herring
On Tue, 19 Nov 2019 15:17:31 +0100, Paul Cercueil wrote: > Add a compatible string for the LCD controller found in the JZ4770 SoC. > > Signed-off-by: Paul Cercueil > --- > Documentation/devicetree/bindings/display/ingenic,lcd.txt | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring

Re: [PATCH v8 11/17] drm/dp_mst: Add DSC enablement helpers to DRM

2019-12-03 Thread kbuild test robot
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20191203] [cannot apply to drm-intel/for-linux-next linus/master v5.4-rc8 v5.4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to

[Bug 201957] amdgpu: ring gfx timeout

2019-12-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 Łukasz Żarnowiecki (luk...@zarnowiecki.pl) changed: What|Removed |Added CC||luk...@zarnow

Re: [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n

2019-12-03 Thread Lyude Paul
On Tue, 2019-12-03 at 10:33 +0100, Daniel Vetter wrote: > On Mon, Dec 02, 2019 at 01:49:47PM -0500, Lyude Paul wrote: > > Reviewed-by: Lyude Paul > > > > I'll go ahead and push this to drm-misc-next, thanks! > > drm-misc-next-fixes since it's in the merge window. drm-misc-next is for > 5.6 alrea

Re: [PATCH 0/3] drm/omap: fix am4 evm lcd

2019-12-03 Thread Laurent Pinchart
Hi Adam, On Mon, Dec 02, 2019 at 07:24:09AM -0600, Adam Ford wrote: > On Mon, Dec 2, 2019 at 7:13 AM Laurent Pinchart wrote: > > On Thu, Nov 14, 2019 at 11:39:47AM +0200, Tomi Valkeinen wrote: > > > Hi Tony, Thierry, Laurent, > > > > > > After the recent change of moving from omapdrm specific pane

Re: [PATCH] drm: Funnel drm logs to tracepoints

2019-12-03 Thread Daniel Vetter
On Tue, Dec 3, 2019 at 8:10 PM Sean Paul wrote: > > On Thu, Oct 17, 2019 at 10:22:16AM +0300, Pekka Paalanen wrote: > > On Wed, 16 Oct 2019 15:23:45 +0200 > > Thomas Zimmermann wrote: > > > > > Hi > > > > > > Am 16.10.19 um 15:05 schrieb Pekka Paalanen: > > > > > > specifically be available in pr

Re: [PATCH v8 02/17] drm/dp_mst: Parse FEC capability on MST ports

2019-12-03 Thread kbuild test robot
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20191203] [cannot apply to drm-intel/for-linux-next linus/master v5.4-rc8 v5.4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to

RE: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2019-12-03 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Hi Andrey, Thanks very much. Best wishes Emily Deng From: Grodzovsky, Andrey Sent: Tuesday, December 3, 2019 12:33 PM To: Deucher, Alexander ; Deng, Emily Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Koenig, Chris

[pull] amdgpu, amdkfd, radeon drm-next-5.5

2019-12-03 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.5. The following changes since commit acc61b8929365e63a3e8c8c8913177795aa45594: Merge tag 'drm-next-5.5-2019-11-22' of git://people.freedesktop.org/~agd5f/linux into drm-next (2019-11-26 08:40:23 +1000) are available in the Git repository at: git://people.fre

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2019-12-03 Thread Andrey Grodzovsky
Turns out Steven's patch was already in so i just cherry-picked the change from drm-next-misc Emily - it's in. Andrey On 12/3/19 2:59 PM, Deucher, Alexander wrote: [AMD Official Use Only - Internal Distribution Only] Cherry pick whatever dependencies you need or pick the older version

Re: [PATCH v1 00/15] PHY: Update Cadence Torrent PHY driver with reconfiguration

2019-12-03 Thread Jyri Sarha
Yuti, you have phy maintainer (Kishon) in cc, but you do not have linux-ker...@vger.kernel.org list mentioned under "GENERIC PHY FRAMEWORK" entry in the MAINTAINERS file [1]. Please add that to the recipient list in the next round. Best regards, Jyri [1] https://www.kernel.org/doc/linux/MAINTAINE

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2019-12-03 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Cherry pick whatever dependencies you need or pick the older version of the patch. Either way works. Alex From: Grodzovsky, Andrey Sent: Tuesday, December 3, 2019 2:57 PM To: Deucher, Alexander ; Deng, Emily

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2019-12-03 Thread Andrey Grodzovsky
I don't think i can apply this patch 'as is' as this has dependency on patch by Steven which also wasn't applied yet - 588b982 Steven Price    6 weeks ago    drm: Don't free jobs in wait_event_interruptible() Andrey On 12/3/19 2:44 PM, Deucher, Alexander wrote: [AMD Official Use Only

RE: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2019-12-03 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Hi Alex, When we will cherry pick those patches to drm-next? >-Original Message- >From: Grodzovsky, Andrey >Sent: Tuesday, December 3, 2019 11:10 AM >To: Deng, Emily ; Deucher, Alexander > >Cc: dri-devel@lists.freedesktop.org; amd-

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2019-12-03 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Please go ahead an apply whatever version is necessary for amd-staging-drm-next. Alex From: Grodzovsky, Andrey Sent: Tuesday, December 3, 2019 2:10 PM To: Deng, Emily ; Deucher, Alexander Cc: dri-devel@lists

Re: [PATCH v1 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2019-12-03 Thread Jyri Sarha
On 03/12/2019 19:31, kbuild test robot wrote: > Hi Yuti, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on drm-exynos/exynos-drm-next] > [also build test ERROR on v5.4 next-20191203] > [if your patch is applied to the wrong git tree, ple

Re: [RFC 06/13] drm/i915/svm: Page table mirroring support

2019-12-03 Thread Niranjan Vishwanathapura
On Tue, Nov 26, 2019 at 06:32:52PM +, Jason Gunthorpe wrote: On Mon, Nov 25, 2019 at 11:33:27AM -0500, Jerome Glisse wrote: On Fri, Nov 22, 2019 at 11:33:12PM +, Jason Gunthorpe wrote: > On Fri, Nov 22, 2019 at 12:57:27PM -0800, Niranjana Vishwanathapura wrote: [...] > > +static int >

Re: [RFC 06/13] drm/i915/svm: Page table mirroring support

2019-12-03 Thread Niranjan Vishwanathapura
On Tue, Nov 26, 2019 at 06:45:14PM +, Jason Gunthorpe wrote: On Mon, Nov 25, 2019 at 08:32:58AM -0800, Niranjan Vishwanathapura wrote: > And putting the cpu PFN of a ZONE_DEVICE device page into > sg_dma_address still looks very wrong to me The below call in patch 7 does convert any cpu PFN

Re: [PATCH v12 2/7] dt-bindings: sun6i-dsi: Add A64 DPHY compatible (w/ A31 fallback)

2019-12-03 Thread Rob Herring
On Tue, Dec 03, 2019 at 07:18:11PM +0530, Jagan Teki wrote: > The MIPI DSI PHY controller on Allwinner A64 is similar > on the one on A31. > > Add A64 compatible and append A31 compatible as fallback. > > Signed-off-by: Jagan Teki > --- > Changes for v12: > - none > > .../bindings/phy/allwinne

Re: [PATCH] drm: Funnel drm logs to tracepoints

2019-12-03 Thread Sean Paul
On Thu, Oct 17, 2019 at 10:22:16AM +0300, Pekka Paalanen wrote: > On Wed, 16 Oct 2019 15:23:45 +0200 > Thomas Zimmermann wrote: > > > Hi > > > > Am 16.10.19 um 15:05 schrieb Pekka Paalanen: > > > > specifically be available in production. So a new file in some fs > > > somewhere it should be, a

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2019-12-03 Thread Andrey Grodzovsky
Yes - Christian just pushed it to drm-next-misc - I guess Alex/Christian didn't pull to amd-staging-drm-next yet. Andrey On 12/2/19 2:24 PM, Deng, Emily wrote: [AMD Official Use Only - Internal Distribution Only] Hi Andrey, Seems this patch is still not in amd-staging-drm-next? Best wis

Re: [PATCH] drm/tilcdc: Switch to using GPIO descriptors

2019-12-03 Thread Jyri Sarha
On 03/12/2019 15:09, Linus Walleij wrote: > The TI LCDC picks a GPIO line from the device tree to use > for DPMS power on/off. We can switch this to use a GPIO > descriptor pretty easily. Make sure to request the GPIO > "as is" so that the DPMS state that we start (boot) in is > preserved. > Hmmm

Re: [PATCH v4 00/11] drm: Add support for bus-format negotiation

2019-12-03 Thread Laurent Pinchart
Hi Boris, On Tue, Dec 03, 2019 at 03:15:04PM +0100, Boris Brezillon wrote: > This patch series aims at adding support for runtime bus-format > negotiation between all elements of the > 'encoder -> bridges -> connector/display' section of the pipeline. > > In order to support that, we need drm bri

Re: [PATCH v4 08/11] drm/bridge: Add a drm_bridge_state object

2019-12-03 Thread Laurent Pinchart
Hi Boris, Thank you for the patch. On Tue, Dec 03, 2019 at 03:15:12PM +0100, Boris Brezillon wrote: > One of the last remaining objects to not have its atomic state. > > This is being motivated by our attempt to support runtime bus-format > negotiation between elements of the bridge chain. > Thi

Re: [PATCH v4 07/11] drm/bridge: Clarify the atomic enable/disable hooks semantics

2019-12-03 Thread Laurent Pinchart
Hi Boris, Thanks for the patch. On Tue, Dec 03, 2019 at 03:15:11PM +0100, Boris Brezillon wrote: > The [pre_]enable/[post_]disable hooks are passed the old atomic state. > Update the doc and rename the arguments to make it clear. > > Signed-off-by: Boris Brezillon > Reviewed-by: Laurent Pinchar

Re: [PATCH 3/4] drm/mgag200: Add workaround for HW that does not support 'startadd'

2019-12-03 Thread John Donnelly
Hi , See below , > On Nov 26, 2019, at 3:50 AM, Thomas Zimmermann wrote: > > Hi > > Am 26.11.19 um 10:37 schrieb Daniel Vetter: >> On Tue, Nov 26, 2019 at 08:25:44AM +0100, Thomas Zimmermann wrote: >>> There's at least one system that does not interpret the value of >>> the device's 'startadd

Re: [PATCH] drm/panel: rpi: Drop unused GPIO includes

2019-12-03 Thread Sam Ravnborg
Hi Linus. On Tue, Dec 03, 2019 at 04:26:55PM +0100, Linus Walleij wrote: > The Rpi panel driver doesn't use any symbols from these > GPIO includes so just drop them. > > Cc: Eric Anholt > Signed-off-by: Linus Walleij > --- > drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 2 -- > 1 fil

[PATCH 11/11] drm/i915: Add HDCP 1.4 support for MST connectors

2019-12-03 Thread Sean Paul
From: Sean Paul Now that all the groundwork has been laid, we can turn on HDCP 1.4 over MST. Everything except for toggling the HDCP signalling and HDCP 2.2 support is the same as the DP case, so we'll re-use those callbacks Signed-off-by: Sean Paul --- drivers/gpu/drm/i915/display/intel_dp_ms

[PATCH 10/11] drm/i915: Expose HDCP shim functions from dp for use by dp_mst

2019-12-03 Thread Sean Paul
From: Sean Paul These functions are all the same for dp and dp_mst, so expose them for use by the dp_mst hdcp implementation. Signed-off-by: Sean Paul --- .../drm/i915/display/intel_display_types.h| 22 +++ drivers/gpu/drm/i915/display/intel_dp.c | 14 ++-- 2

[PATCH 09/11] drm/i915: Use ddi_update_pipe in intel_dp_mst

2019-12-03 Thread Sean Paul
From: Sean Paul In order to act upon content_protection property changes, we'll need to implement the .update_pipe() hook. We can re-use intel_ddi_update_pipe for this Signed-off-by: Sean Paul --- drivers/gpu/drm/i915/display/intel_ddi.c| 9 + drivers/gpu/drm/i915/display/intel_dp.

[PATCH 03/11] drm/i915: Disable HDCP signalling on transcoder disable

2019-12-03 Thread Sean Paul
From: Sean Paul Currently we rely on intel_hdcp_disable() to disable HDCP signalling in the DDI Function Control register. This patch adds a safety net by also clearing the bit when we disable the transcoder. Once we have HDCP over MST and disappearing connectors, we want to make sure that the s

[PATCH 04/11] drm/i915: Don't WARN on HDCP toggle if get_hw_state returns false

2019-12-03 Thread Sean Paul
From: Sean Paul Now that we can rely on transcoder disable to toggle signalling off, it's less of a catastrophe if get_hw_state() returns false. Once we enable MST, this will be a valid exit path and we want to make sure we're not spamming the logs needlessly. Signed-off-by: Sean Paul --- dri

[PATCH 02/11] drm/i915: Intercept Aksv writes in the aux hooks

2019-12-03 Thread Sean Paul
From: Sean Paul Instead of hand rolling the transfer ourselves in the hdcp hook, inspect aux messages and add the aksv flag in the aux transfer hook. IIRC, this was the original implementation and folks wanted this hack to be isolated to the hdcp code, which makes sense. However in testing an L

[PATCH 06/11] drm/i915: Factor out hdcp->value assignments

2019-12-03 Thread Sean Paul
From: Sean Paul This is a bit of housecleaning for a future patch. Instead of sprinkling hdcp->value assignments and prop_work scheduling everywhere, introduce a function to do it for us. Signed-off-by: Sean Paul --- drivers/gpu/drm/i915/display/intel_hdcp.c | 67 --- 1 fil

[PATCH 08/11] drm/i915: Support DP MST in enc_to_dig_port() function

2019-12-03 Thread Sean Paul
From: Sean Paul Although DP_MST fake encoders are not subclassed from digital ports, they are associated with them. Support these encoders. Signed-off-by: Sean Paul --- .../drm/i915/display/intel_display_types.h| 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) dif

[PATCH 07/11] drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it

2019-12-03 Thread Sean Paul
From: Sean Paul This patch is required for HDCP over MST. If a port is being used for multiple HDCP streams, we don't want to fully disable HDCP on a port if one of them is disabled. Instead, we just disable the HDCP signalling on that particular pipe and exit early. The last pipe to disable HDCP

[PATCH 05/11] drm/i915: Change toggle_signalling() argument to connector

2019-12-03 Thread Sean Paul
From: Sean Paul HDCP over MST requires us to toggle ddi signalling. Since we'll want to toggle signalling on the pipe associated with the fake encoder as opposed to the digital port's base, we need to get it from connector. This patch converts all existing callers and implementations to use conn

[PATCH 00/11] drm/i915: Add support for HDCP 1.4 over MST connectors

2019-12-03 Thread Sean Paul
From: Sean Paul Hey all, As the subject says, this set adds support for HDCP 1.4 over MST. Most of the set is plumbing and refactor to allow the MST support to slot in organically. I stubbed out HDCP 2.2 support since I don't have a means of testing it. If no one picks up the slack, I can come b

[PATCH 01/11] drm/i915: Fix sha_text population code

2019-12-03 Thread Sean Paul
From: Sean Paul This patch fixes a few bugs: 1- We weren't taking into account sha_leftovers when adding multiple ksvs to sha_text. As such, we were or'ing the end of ksv[j - 1] with the beginning of ksv[j] 2- In the sha_leftovers == 2 and sha_leftovers == 3 case, bstatus was being pla

Re: [PATCH 3/3] drm/tegra: Implement correct DMA-BUF semantics

2019-12-03 Thread Daniel Vetter
On Tue, Dec 03, 2019 at 06:33:08PM +0100, Daniel Vetter wrote: > On Tue, Dec 03, 2019 at 05:32:03PM +0100, Thierry Reding wrote: > > From: Thierry Reding > > > > DMA-BUF requires that each device that accesses a DMA-BUF attaches to it > > separately. To do so the host1x_bo_pin() and host1x_bo_unp

Re: [PATCH 3/3] drm/tegra: Implement correct DMA-BUF semantics

2019-12-03 Thread Daniel Vetter
On Tue, Dec 03, 2019 at 05:32:03PM +0100, Thierry Reding wrote: > From: Thierry Reding > > DMA-BUF requires that each device that accesses a DMA-BUF attaches to it > separately. To do so the host1x_bo_pin() and host1x_bo_unpin() functions > need to be reimplemented so that they can return a mappi

Re: [PATCH v1 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2019-12-03 Thread kbuild test robot
Hi Yuti, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-exynos/exynos-drm-next] [also build test ERROR on v5.4 next-20191203] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '-

Re: FAILED - [PATCH v2 3/3] drm/mgag200: Add workaround for HW that does not support 'startadd'

2019-12-03 Thread John Donnelly
Hello Sasha and Thomas , This particular patch has failed on one class of servers that has a slightly different Sun Vendor. ID for the BMC video device: I will follow up with additional details in the review comments for the original message,. > On Nov 28, 2019, at 8:23 AM, Sasha Levi

Re: [PATCH 2/3] drm/cma-helper: Use sgt_dma_contiguous() helper

2019-12-03 Thread Daniel Vetter
On Tue, Dec 03, 2019 at 05:32:02PM +0100, Thierry Reding wrote: > From: Thierry Reding > > Functionality to count the number of contiguous DMA chunks in an SG > table has been added to the scatterlist library. Use this functionality > to replace an open-coded version in the GEM/CMA helpers. > >

[RESEND][PATCH v16 5/5] kselftests: Add dma-heap test

2019-12-03 Thread John Stultz
Add very trivial allocation and import test for dma-heaps, utilizing the vgem driver as a test importer. A good chunk of this code taken from: tools/testing/selftests/android/ion/ionmap_test.c Originally by Laura Abbott Cc: Benjamin Gaignard Cc: Sumit Semwal Cc: Liam Mark Cc: Pratik Patel

[RESEND][PATCH v16 0/5] DMA-BUF Heaps (destaging ION)

2019-12-03 Thread John Stultz
Just wanted to resend v16. This patchset implements per-heap devices which can be opened directly and then an ioctl is used to allocate a dmabuf from the heap. The interface is similar, but much simpler then IONs, only providing an ALLOC ioctl. Also, I've provided relatively simple system and cm

[RESEND][PATCH v16 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-12-03 Thread John Stultz
This adds a CMA heap, which allows userspace to allocate a dma-buf of contiguous memory out of a CMA region. This code is an evolution of the Android ION implementation, so thanks to its original author and maintainters: Benjamin Gaignard, Laura Abbott, and others! NOTE: This patch only adds th

[RESEND][PATCH v16 1/5] dma-buf: Add dma-buf heaps framework

2019-12-03 Thread John Stultz
From: "Andrew F. Davis" This framework allows a unified userspace interface for dma-buf exporters, allowing userland to allocate specific types of memory for use in dma-buf sharing. Each heap is given its own device node, which a user can allocate a dma-buf fd from using the DMA_HEAP_IOC_ALLOC.

[RESEND][PATCH v16 2/5] dma-buf: heaps: Add heap helpers

2019-12-03 Thread John Stultz
Add generic helper dmabuf ops for dma heaps, so we can reduce the amount of duplicative code for the exported dmabufs. This code is an evolution of the Android ION implementation, so thanks to its original authors and maintainters: Rebecca Schultz Zavin, Colin Cross, Laura Abbott, and others! C

[RESEND][PATCH v16 3/5] dma-buf: heaps: Add system heap to dmabuf heaps

2019-12-03 Thread John Stultz
This patch adds system heap to the dma-buf heaps framework. This allows applications to get a page-allocator backed dma-buf for non-contiguous memory. This code is an evolution of the Android ION implementation, so thanks to its original authors and maintainters: Rebecca Schultz Zavin, Colin Cr

Re: [PATCH] drm/radeon: fix r1xx/r2xx register checker for POT textures

2019-12-03 Thread Michel Dänzer
On 2019-11-26 3:43 p.m., Alex Deucher wrote: > Shift and mask were reversed. Noticed by chance. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/radeon/r100.c | 4 ++-- > drivers/gpu/drm/radeon/r200.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/

Re: [PATCH v3 07/12] video: fbdev: intelfb: use const pointer for fb_ops

2019-12-03 Thread Daniel Vetter
On Tue, Dec 03, 2019 at 06:38:49PM +0200, Jani Nikula wrote: > Use const for fb_ops to let us make the fbops struct const in the > future. > > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/video/fbdev/intelfb/intelfb.h | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [Intel-gfx] [PATCH v3 04/12] video: fbdev: uvesafb: modify the static fb_ops directly

2019-12-03 Thread Daniel Vetter
On Tue, Dec 03, 2019 at 06:38:46PM +0200, Jani Nikula wrote: > Avoid modifying the fb_ops via info->fbops to let us make the pointer > const in the future. > > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/video/fbdev/uvesafb.c | 4 ++-- > 1 file changed, 2 inserti

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2019-12-03 Thread Benjamin Gaignard
Le sam. 30 nov. 2019 à 14:24, Benjamin Gaignard a écrit : > > Fix the warnings that show up with W=1. > They are all about unused but set variables. > If functions returns are not used anymore make them void. > > Signed-off-by: Benjamin Gaignard > --- > CC: Jani Nikula > > changes in version 3:

Re: [Intel-gfx] [PATCH v3 03/12] video: fbdev: nvidia: modify the static fb_ops directly

2019-12-03 Thread Daniel Vetter
On Tue, Dec 03, 2019 at 06:38:45PM +0200, Jani Nikula wrote: > Avoid modifying the fb_ops via info->fbops to let us make the pointer > const in the future. > > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/video/fbdev/nvidia/nvidia.c | 20 +++- > 1

Re: [PATCH v3 02/12] video: fbdev: mb862xx: modify the static fb_ops directly

2019-12-03 Thread Daniel Vetter
On Tue, Dec 03, 2019 at 06:38:44PM +0200, Jani Nikula wrote: > Avoid modifying the fb_ops via info->fbops to let us make the pointer > const in the future. Drop the unnecessary EXPORT_SYMBOL() while at it. > > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/video/fbd

Re: [PATCH] drm/modes: remove unused variables

2019-12-03 Thread Benjamin Gaignard
Le mer. 20 nov. 2019 à 00:29, Benjamin Gaignard a écrit : > > When compiling with W=1 few warnings about unused variables show up. > This patch removes all the involved variables. > Gentle ping to reviewers. Thanks, Benjamin > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/drm_modes.

Re: [PATCH] drm/fb-cma-helpers: Fix include issue

2019-12-03 Thread Benjamin Gaignard
Le mer. 20 nov. 2019 à 00:28, Benjamin Gaignard a écrit : > > Exported functions prototypes are missing in drm_fb_cma_helper.c > Include drm_fb_cma_helper to fix that issue. > Gentle ping to reviewers. Thanks, Benjamin > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/drm_fb_cma_helpe

Re: [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing

2019-12-03 Thread Benjamin Gaignard
Le mer. 20 nov. 2019 à 00:28, Benjamin GAIGNARD a écrit : > > > On 11/19/19 7:53 PM, Souza, Jose wrote: > > On Tue, 2019-11-19 at 13:58 +0100, Benjamin Gaignard wrote: > >> Include drm_crtc_helper_internal.h to provide > >> drm_connector_get_single_encoder > >> prototype. > >> > >> Fixes: a92462d6

Re: [PATCH v3 01/12] video: fbdev: atyfb: modify the static fb_ops directly

2019-12-03 Thread Daniel Vetter
On Tue, Dec 03, 2019 at 06:38:43PM +0200, Jani Nikula wrote: > Avoid modifying the fb_ops via info->fbops to let us make the pointer > const in the future. > > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/video/fbdev/aty/atyfb.h | 2 +- > drivers/video/fbd

Re: [PATCH 0/4] consistently use dma_resv locking wrappers

2019-12-03 Thread Daniel Vetter
On Mon, Nov 25, 2019 at 10:43:52AM +0100, Daniel Vetter wrote: > Hi all, > > This is prep work for some dma_resv series I'm tinkering with, but I > figured good to split this out since good idea to land this no matter what > exactly I'll end up creating in dma_resv. With these everything in > driv

Re: [Intel-gfx] [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info

2019-12-03 Thread Jani Nikula
On Tue, 03 Dec 2019, Jani Nikula wrote: > This is v3 of https://patchwork.freedesktop.org/series/70198/. > > 0day reported some build failures, and I needed to add patches 1-5 and 7 Should be, patches 1-4 and 7. > to address them. Patch 8 was amended accordingly (dropped some consts), > but the

Re: [PATCH v12 3/7] drm/sun4i: dsi: Add has_mod_clk quirk

2019-12-03 Thread Jagan Teki
On Tue, Dec 3, 2019 at 8:09 PM Chen-Yu Tsai wrote: > > On Tue, Dec 3, 2019 at 9:48 PM Jagan Teki wrote: > > > > As per the user manual, look like mod clock is not mandatory > > for all Allwinner MIPI DSI controllers, it is connected to > > CLK_DSI_SCLK for A31 and not available in A64. > > > > So

[PATCH v3 11/12] samples: vfio-mdev: constify fb ops

2019-12-03 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. v2: fix typo (Christophe de Dinechin) Cc: Kirti Wankhede Cc: k...@vger.kernel.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- samples/vfio-mdev/mdpy-fb.c | 2 +- 1 file changed, 1 in

[PATCH v3 09/12] HID: picoLCD: constify fb ops

2019-12-03 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. v2: fix typo (Christophe de Dinechin) Cc: Bruno Prémont Cc: linux-in...@vger.kernel.org Reviewed-by: Daniel Vetter Acked-by: Bruno Prémont Signed-off-by: Jani Nikula --- drivers/hid/hid-picolcd_f

[PATCH v3 07/12] video: fbdev: intelfb: use const pointer for fb_ops

2019-12-03 Thread Jani Nikula
Use const for fb_ops to let us make the fbops struct const in the future. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/intelfb/intelfb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/intelfb/intelfb.h b/drivers/vide

[PATCH v3 06/12] drm: constify fb ops across all drivers

2019-12-03 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. Cc: dri-devel@lists.freedesktop.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c| 2 +- drivers/gpu/drm/armada/armada_fbdev.c

[PATCH v3 12/12] auxdisplay: constify fb ops

2019-12-03 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. Cc: Miguel Ojeda Sandonis Cc: Robin van der Gracht Reviewed-by: Daniel Vetter Reviewed-by: Miguel Ojeda Acked-by: Robin van der Gracht Signed-off-by: Jani Nikula --- drivers/auxdisplay/cfag12864

[PATCH v3 10/12] media: constify fb ops across all drivers

2019-12-03 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. Remove the redundant fbops assignments while at it. v2: - actually add const in vivid - fix typo (Christophe de Dinechin) Cc: Hans Verkuil Cc: Andy Walls Cc: linux-me...@vger.kernel.org Cc: ivtv-de

[PATCH v3 08/12] video: constify fb ops across all drivers

2019-12-03 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. This does not cover all drivers; some actually modify the fbops struct, for example to adjust for different configurations, and others do more involved things that I'd rather not touch in practically o

[PATCH v3 01/12] video: fbdev: atyfb: modify the static fb_ops directly

2019-12-03 Thread Jani Nikula
Avoid modifying the fb_ops via info->fbops to let us make the pointer const in the future. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/aty/atyfb.h | 2 +- drivers/video/fbdev/aty/atyfb_base.c| 6 +++--- drivers/video/fbdev/aty/mach64_cursor.c |

[PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info

2019-12-03 Thread Jani Nikula
This is v3 of https://patchwork.freedesktop.org/series/70198/. 0day reported some build failures, and I needed to add patches 1-5 and 7 to address them. Patch 8 was amended accordingly (dropped some consts), but the other patches remain the same from v2, except the ones I merged already. BR, Jani

[PATCH v3 04/12] video: fbdev: uvesafb: modify the static fb_ops directly

2019-12-03 Thread Jani Nikula
Avoid modifying the fb_ops via info->fbops to let us make the pointer const in the future. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/uvesafb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/

[PATCH v3 05/12] video: fbdev: make fbops member of struct fb_info a const pointer

2019-12-03 Thread Jani Nikula
Now that we no longer modify the fbops, or hold non-const pointers to it, we can make it const. After this, we can start making the fbops const all over the place. Cc: linux-fb...@vger.kernel.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- include/linux/fb.h | 2 +- 1 file changed

[PATCH v3 03/12] video: fbdev: nvidia: modify the static fb_ops directly

2019-12-03 Thread Jani Nikula
Avoid modifying the fb_ops via info->fbops to let us make the pointer const in the future. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/nvidia/nvidia.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/video/fb

[PATCH v3 02/12] video: fbdev: mb862xx: modify the static fb_ops directly

2019-12-03 Thread Jani Nikula
Avoid modifying the fb_ops via info->fbops to let us make the pointer const in the future. Drop the unnecessary EXPORT_SYMBOL() while at it. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/mb862xx/mb862xxfb.h | 2 +- drivers/video/fbdev/mb862xx/mb862xxfb

Re: [PATCH 4/5] drm: msm: a6xx: fix debug bus register configuration

2019-12-03 Thread Rob Clark
On Tue, Dec 3, 2019 at 7:23 AM Sharat Masetty wrote: > > Fix the cx debugbus related register configuration, to collect accurate > bus data during gpu snapshot. This helps with complete snapshot dump > and also complete proper GPU recovery. > > Signed-off-by: Sharat Masetty fwiw, this one we alr

[PATCH 3/3] drm/tegra: Implement correct DMA-BUF semantics

2019-12-03 Thread Thierry Reding
From: Thierry Reding DMA-BUF requires that each device that accesses a DMA-BUF attaches to it separately. To do so the host1x_bo_pin() and host1x_bo_unpin() functions need to be reimplemented so that they can return a mapping, which either represents an attachment or a map of the driver's own GEM

[PATCH 2/3] drm/cma-helper: Use sgt_dma_contiguous() helper

2019-12-03 Thread Thierry Reding
From: Thierry Reding Functionality to count the number of contiguous DMA chunks in an SG table has been added to the scatterlist library. Use this functionality to replace an open-coded version in the GEM/CMA helpers. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_gem_cma_helper.c | 22

[PATCH 1/3] lib/scatterlist: Add contiguous DMA chunks helpers

2019-12-03 Thread Thierry Reding
From: Thierry Reding Add a few helpers to count the number of contiguous DMA chunks found in an SG table. This is useful to determine whether or not a mapping can be used by drivers whose devices need contiguous memory. Signed-off-by: Thierry Reding --- include/linux/scatterlist.h | 11 +++

[PATCH] drm/tegra: output: Implement system suspend/resume

2019-12-03 Thread Thierry Reding
From: Thierry Reding Implement generic system suspend/resume functions that can be used with any output type. Currently this only implements disabling and enabling of the IRQ functionality across system suspend/resume. This prevents an interrupt from happening before the display driver has fully

[PATCH v9] drm/dp_mst: Add PBN calculation for DSC modes

2019-12-03 Thread mikita.lipski
From: David Francis With DSC, bpp can be fractional in multiples of 1/16. Change drm_dp_calc_pbn_mode to reflect this, adding a new parameter bool dsc. When this parameter is true, treat the bpp parameter as having units not of bits per pixel, but 1/16 of a bit per pixel v2: Don't add separate

[PATCH 1/2] gpu: host1x: Rename "parent" to "host"

2019-12-03 Thread Thierry Reding
From: Thierry Reding Rename the host1x clients' parent to "host" because that more closely describes what it is. The parent can be confused with the parent device in terms of the device hierarchy. Subsequent patches will add a new member that refers to the parent in that hierarchy. Signed-off-by

[PATCH 2/2] drm/tegra: Do not implement runtime PM

2019-12-03 Thread Thierry Reding
From: Thierry Reding The Tegra DRM driver heavily relies on the implementations for runtime suspend/resume to be called at specific times. Unfortunately, there are some cases where that doesn't work. One example is if the user disables runtime PM for a given subdevice. Another example is that the

[PATCH v2 6/9] drm/tegra: vic: Export module device table

2019-12-03 Thread Thierry Reding
From: Thierry Reding Export the module device table to ensure the VIC compatible strings are listed in the module's aliases table. This in turn causes the driver to be automatically loaded on boot if VIC is the only enabled subdevice of the logical host1x DRM device. Reviewed-by: Daniel Vetter

[PATCH v2 7/9] drm/tegra: Silence expected errors on IOMMU attach

2019-12-03 Thread Thierry Reding
From: Thierry Reding Subdevices may not be hooked up to an IOMMU via device tree. Detect such situations and avoid confusing users by not emitting an error message. Reviewed-by: Daniel Vetter Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 2 +- drivers/gpu/drm/tegra/drm.c | 4

[PATCH v2 8/9] drm/tegra: sor: Make the +5V HDMI supply optional

2019-12-03 Thread Thierry Reding
From: Thierry Reding The SOR supports multiple display modes, but only when driving an HDMI monitor does it make sense to control the +5V power supply. eDP and DP don't need this, so make it optional. This fixes a crash observed during system suspend/resume. Reviewed-by: Daniel Vetter Signed-o

[PATCH v2 9/9] drm/tegra: Run hub cleanup on ->remove()

2019-12-03 Thread Thierry Reding
From: Thierry Reding The call to tegra_display_hub_cleanup() that takes care of disabling the window groups is missing from the driver's ->remove() callback. Call it to make sure the runtime PM reference counts for the display controllers are balanced. Signed-off-by: Thierry Reding --- drivers

  1   2   3   >