[PATCH] drm/komeda: Add runtime_pm support

2019-12-11 Thread james qian wang (Arm Technology China)
- Add pm_runtime_get/put to crtc_enable/disable along with the real display usage - Add runtime_get/put to register_show, since register_show() will access register, need to wakeup HW. - For the case that PM is not enabled or configured, manually wakeup HW Signed-off-by: james qian wang (Arm T

[PATCH v2 2/3] drm/vram-helper: Remove BO device from public interface

2019-12-11 Thread Thomas Zimmermann
TTM is an implementation detail of the VRAM helpers and therefore shouldn't be exposed to the callers. There's only one correct value for the BO device anyway, which is the one stored in the DRM device. So remove struct ttm_bo_device from the VRAM-helper interface and use the device's VRAM manager

[PATCH v2 1/3] drm/vram-helper: Remove interruptible flag from public interface

2019-12-11 Thread Thomas Zimmermann
The flag 'interruptible', which is passed to various functions, is always set to be false. Remove it and hard-code the value. Signed-off-by: Thomas Zimmermann Suggested-by: Daniel Vetter --- drivers/gpu/drm/ast/ast_mode.c | 2 +- drivers/gpu/drm/drm_gem_vram_helper.c | 17 ++

[PATCH v2 3/3] drm/vram-helper: Support struct drm_driver.gem_create_object

2019-12-11 Thread Thomas Zimmermann
Drivers that what to allocate VRAM GEM objects with additional fields can now do this by implementing struct drm_driver.gem_create_object. v2: * only cast to gbo within if branch; set gbo directly in else branch Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram

[PATCH v2 0/3] drm/vram-helper: Various cleanups

2019-12-11 Thread Thomas Zimmermann
A number of cleanups that I wanted to apply for some time. The first two patches simplify the public interface. The third patch adds support for struct drm_driver.gem_create_object. All tested by running fbdev, X11 and Weston on ast HW. v2: * make drm_gem_vram_create() still work if GEM ob

[PATCH] drm/komeda: Add event handling for EMPTY/FULL

2019-12-11 Thread james qian wang (Arm Technology China)
EMPTY/FULL are HW input/output FIFO condition identifer, which are useful information for addressing the problem, so expose them. Signed-off-by: james qian wang (Arm Technology China) --- drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 13 - drivers/gpu/drm/arm/display/komeda/d71

Re: [PATCH v9 23/25] mm/gup: track FOLL_PIN pages

2019-12-11 Thread John Hubbard
On 12/11/19 3:28 AM, Jan Kara wrote: ... The patch looks mostly good to me now. Just a few smaller comments below. Suggested-by: Jan Kara Suggested-by: Jérôme Glisse Reviewed-by: Jan Kara Reviewed-by: Jérôme Glisse Reviewed-by: Ira Weiny I think you inherited here the Reviewed-by tags f

Re: [PATCH 3/3] drm/vram-helper: Support struct drm_driver.gem_create_object

2019-12-11 Thread Thomas Zimmermann
Hi Sam Am 11.12.19 um 20:11 schrieb Sam Ravnborg: > Hi Thomas, > > On Wed, Dec 11, 2019 at 07:08:32PM +0100, Thomas Zimmermann wrote: >> Drivers that what to allocate VRAM GEM objects with additional fields >> can now do this by implementing struct drm_driver.gem_create_object. >> >> Signed-off-b

[Bug 204241] amdgpu fails to resume from suspend

2019-12-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 --- Comment #45 from crab2...@gmail.com --- Kernel 5.4.2 and kernel 5.3 is affected. I switch to kernel 5.2.19 and do not have this issue. -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH] drm/mediatek: Fix can't get component for external display plane.

2019-12-11 Thread CK Hu
Hi, Pi-Hsun: On Mon, 2019-12-02 at 13:24 +0800, CK Hu wrote: > Hi, Pi-Hsun: > > > On Wed, 2019-11-27 at 18:04 +0800, Pi-Hsun Shih wrote: > > From: Yongqiang Niu > > > > The original logic is ok for primary display, but will not find out > > component for external display. > > > > For example,

Re: [PATCH] drm/mediatek: Check return value of mtk_drm_ddp_comp_for_plane.

2019-12-11 Thread CK Hu
Hi, Pi-Hsun: On Fri, 2019-11-22 at 15:58 +0800, CK Hu wrote: > Hi, Pi-Hsun: > > On Mon, 2019-11-18 at 14:18 +0800, Pi-Hsun Shih wrote: > > The mtk_drm_ddp_comp_for_plane can return NULL, but the usage doesn't > > check for it. Add check for it. > > Reviewed-by: CK Hu > Applied to mediatek-drm

Re: [PATCH 1/2] Return from mtk_ovl_layer_config after mtk_ovl_layer_off

2019-12-11 Thread CK Hu
Hi, Mark: On Wed, 2019-12-11 at 10:49 -0500, Mark Yacoub wrote: > drm/mediatek: return if plane pending state is disabled. > > If the plane pending state is disabled, call mtk_ovl_layer_off then > return. > This guarantees that that the state is valid for all operations when the > pending state i

Re: [PATCH 2/2] Turn off Alpha bit when plane format has no alpha

2019-12-11 Thread CK Hu
Hi, Mark: On Wed, 2019-12-11 at 10:49 -0500, Mark Yacoub wrote: > drm/mediatek: Add OVL_CON_ALPHA only when the plane format has_alpha. > > This change enables XR24 format to be displayed as an overlay on top of > the primary plane. Reviewed-by: CK Hu > > Suggested-by: Sean Paul > To: CK Hu

RE: [RESEND PATCH 5/5] drm/amdgpu: Switch from system_highpri_wq to system_unbound_wq

2019-12-11 Thread Ma, Le
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Le Ma Regards, Ma Le -Original Message- From: Andrey Grodzovsky Sent: Thursday, December 12, 2019 4:39 AM To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Cc: Deucher, Alexander ; Ma, Le ; Zhang, Hawk

RE: [RESEND PATCH 4/5] Subject: drm/amdgpu: Redo XGMI reset synchronization.

2019-12-11 Thread Ma, Le
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Andrey Grodzovsky Sent: Thursday, December 12, 2019 4:39 AM To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Cc: Deucher, Alexander ; Ma, Le ; Zhang, Hawking ; Quan, Evan ; Grodzovsky, A

RE: [RESEND PATCH 3/5] drm/amdgpu: Add task barrier to XGMI hive.

2019-12-11 Thread Ma, Le
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Le Ma Regards, Ma Le -Original Message- From: Andrey Grodzovsky Sent: Thursday, December 12, 2019 4:39 AM To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Cc: Deucher, Alexander ; Ma, Le ; Zhang, Hawk

RE: [RESEND PATCH 1/5] drm/amdgpu: reverts commit b01245ff54db66073b104ac9d9fbefb7b264b36d.

2019-12-11 Thread Ma, Le
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Andrey Grodzovsky Sent: Thursday, December 12, 2019 4:39 AM To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Cc: Deucher, Alexander ; Ma, Le ; Zhang, Hawking ; Quan, Evan ; Grodzovsky, And

RE: [RESEND PATCH 2/5] drm: Add Reusable task barrier.

2019-12-11 Thread Ma, Le
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Andrey Grodzovsky Sent: Thursday, December 12, 2019 4:39 AM To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Cc: Deucher, Alexander ; Ma, Le ; Zhang, Hawking ; Quan, Evan ; Grodzovsky, A

Re: [PATCH 1/1] drm/dp: get/set phy compliance pattern

2019-12-11 Thread Manasi Navare
Did you look at the build failure here? The build fails for amdgpu that uses the old #define of DP_TEST_PHY_PATTERN So you will have to send a patch for the amdgpu wherever they are using the older #define along with this with correct explanation that name changed to match the spec. Manasi On Mo

Re: [Intel-gfx] [PATCH] drm/i915/display: cleanup intel_bw_state on i915 module removal

2019-12-11 Thread Lucas De Marchi
On Wed, Dec 11, 2019 at 12:10:41PM +0530, Bharadiya,Pankaj wrote: On Tue, Dec 10, 2019 at 09:57:39PM -0800, Lucas De Marchi wrote: On Mon, Dec 09, 2019 at 08:09:02PM +0530, Pankaj Bharadiya wrote: >intel_bw_state allocated memory is not getting freed even after >module removal. > >kmemleak repor

Re: [PATCH v3 06/50] drm/bridge: dumb-vga-dac: Rename internal symbols to simple-bridge

2019-12-11 Thread Laurent Pinchart
Hi Sam, (CC'ing Maxime) On Wed, Dec 11, 2019 at 10:13:18PM +0100, Sam Ravnborg wrote: > On Wed, Dec 11, 2019 at 12:57:06AM +0200, Laurent Pinchart wrote: > > The dumb-vga-dac driver is a simple DRM bridge driver for simple VGA > > DACs that don't require configuration. Other non-VGA bridges fall

Re: [PATCH 1/1] drm/dp: get/set phy compliance pattern

2019-12-11 Thread Manasi Navare
On Mon, Nov 18, 2019 at 11:55:55PM +0530, Animesh Manna wrote: > During phy compliance auto test mode source need to read > requested test pattern from sink through DPCD. After processing > the request source need to set the pattern. So set/get method > added in drm layer as it is DP protocol. You

[pull] amdgpu, amdkfd, radeon drm-next-5.6

2019-12-11 Thread Alex Deucher
Hi Dave, Daniel, Kicking off 5.6 with new stuff from AMD. There is a UAPI addition. We added a new firmware for display, and this just adds the version query to our existing firmware query interface. UMDs like mesa use this interface to query things like CP or UVD firmware versions to see what

Re: [PATCH v9 10/25] mm/gup: introduce pin_user_pages*() and FOLL_PIN

2019-12-11 Thread John Hubbard
On 12/11/19 12:57 PM, Jonathan Corbet wrote: > On Tue, 10 Dec 2019 18:53:03 -0800 > John Hubbard wrote: > >> Introduce pin_user_pages*() variations of get_user_pages*() calls, >> and also pin_longterm_pages*() variations. > > Just a couple of nits on the documentation patch > >> +++ b/Documenta

[PATCH 1/2] drm: Handle connector tile support only for modes that match tile size

2019-12-11 Thread Manasi Navare
DRM Fb driver expects multiple CRTCs if it sees connector->has_tile is set, but we need to handle tile support and look for multiple CRTCs only for the modes that match the tile size. The other modes should be able to be displayed without tile support or uisng single CRTC. This patch adds the chec

[PATCH 2/2] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-12-11 Thread Manasi Navare
In case of tiled displays, if we hotplug just one connector, fbcon currently just selects the preferred mode and if it is tiled mode then that becomes a problem if rest of the tiles are not present. So in the fbdev driver on hotplug when we probe the client modeset, if we dont find all the connecto

[PULL] drm-misc-fixes

2019-12-11 Thread Sean Paul
Hi Dave and Daniel, A couple patches from -misc-fixes. drm-misc-fixes-2019-12-11: - Expand dma-buf MAINTAINER scope - Fix mode matching for drivers not using picture_aspect_ratio Cheers, Sean The following changes since commit 6645d42d79d33e8a9fe262660a75d5f4556bbea9: dma-buf: Fix memory

Re: [Nouveau] [PATCH 3/3] drm/nouveau: Support NVIDIA format modifiers

2019-12-11 Thread Ilia Mirkin
On Wed, Dec 11, 2019 at 4:04 PM James Jones wrote: > > Allow setting the block layout of a nouveau FB > object using DRM format modifiers. When > specified, the format modifier block layout and > kind overrides the GEM buffer's implicit layout > and kind. The specified format modifier is > valid

Re: [PATCH v3 06/50] drm/bridge: dumb-vga-dac: Rename internal symbols to simple-bridge

2019-12-11 Thread Sam Ravnborg
On Wed, Dec 11, 2019 at 12:57:06AM +0200, Laurent Pinchart wrote: > The dumb-vga-dac driver is a simple DRM bridge driver for simple VGA > DACs that don't require configuration. Other non-VGA bridges fall in a > similar category, and would benefit from a common driver. Prepare for > this by renamin

[PATCH 3/3] drm/nouveau: Support NVIDIA format modifiers

2019-12-11 Thread James Jones
Allow setting the block layout of a nouveau FB object using DRM format modifiers. When specified, the format modifier block layout and kind overrides the GEM buffer's implicit layout and kind. The specified format modifier is validated against he list of modifiers supported by the target display

[PATCH 2/3] drm/nouveau: Check framebuffer size against bo

2019-12-11 Thread James Jones
Make sure framebuffer dimensions and tiling parameters will not result in accesses beyond the end of the GEM buffer they are bound to. Signed-off-by: James Jones --- drivers/gpu/drm/nouveau/nouveau_display.c | 93 +++ 1 file changed, 93 insertions(+) diff --git a/drivers/gpu

[PATCH 0/3] drm/nouveau: Support NVIDIA format modifiers

2019-12-11 Thread James Jones
This series modifies the NV5x+ nouveau display backends to advertise appropriate format modifiers on their display planes in atomic mode setting blobs. Corresponding modifications to Mesa/userspace are available here: https://gitlab.freedesktop.org/cubanismo/mesa/tree/nouveau_work But those need

[PATCH 1/3] drm/nouveau: Add format mod prop to base/ovly/nvdisp

2019-12-11 Thread James Jones
Advertise support for the full list of format modifiers supported by each class of NVIDIA desktop GPU display hardware. Stash the array of modifiers in the nouveau_display struct for use when validating userspace framebuffer creation requests, which will be supportd in a subsequent change. Signed

Re: [PATCH 0/3] drm/nouveau: Support NVIDIA format modifiers

2019-12-11 Thread James Jones
Please ignore the tegra diff on the bottom of this. I never fail to find a way to mess up git-send-email. -James On 12/11/19 12:59 PM, James Jones wrote: This series modifies the NV5x+ nouveau display backends to advertise appropriate format modifiers on their display planes in atomic mode se

[PATCH v3] drm: Generalized NV Block Linear DRM format mod

2019-12-11 Thread James Jones
Builds upon the existing NVIDIA 16Bx2 block linear format modifiers by adding more "fields" to the existing parameterized DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK format modifier macro that allow fully defining a unique-across- all-NVIDIA-hardware bit layout using a minimal set of fields and values. The

Re: [PATCH v9 10/25] mm/gup: introduce pin_user_pages*() and FOLL_PIN

2019-12-11 Thread Jonathan Corbet
On Tue, 10 Dec 2019 18:53:03 -0800 John Hubbard wrote: > Introduce pin_user_pages*() variations of get_user_pages*() calls, > and also pin_longterm_pages*() variations. Just a couple of nits on the documentation patch > +++ b/Documentation/core-api/pin_user_pages.rst > @@ -0,0 +1,232 @@ > +.. S

[RESEND PATCH 5/5] drm/amdgpu: Switch from system_highpri_wq to system_unbound_wq

2019-12-11 Thread Andrey Grodzovsky
This is to avoid queueing jobs to same CPU during XGMI hive reset because there is a strict timeline for when the reset commands must reach all the GPUs in the hive. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[RESEND PATCH 2/5] drm: Add Reusable task barrier.

2019-12-11 Thread Andrey Grodzovsky
It is used to synchronize N threads at a rendevouz point before execution of critical code that has to be started by all the threads at approximatly the same time. Signed-off-by: Andrey Grodzovsky --- include/drm/task_barrier.h | 106 + 1 file changed,

[RESEND PATCH 4/5] Subject: drm/amdgpu: Redo XGMI reset synchronization.

2019-12-11 Thread Andrey Grodzovsky
Use task barrier in XGMI hive to synchronize ASIC resets across devices in XGMI hive. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 42 +- 1 file changed, 36 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amd

[RESEND PATCH 3/5] drm/amdgpu: Add task barrier to XGMI hive.

2019-12-11 Thread Andrey Grodzovsky
Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c index 61d13d8..5cf920d 10064

[RESEND PATCH 1/5] drm/amdgpu: reverts commit b01245ff54db66073b104ac9d9fbefb7b264b36d.

2019-12-11 Thread Andrey Grodzovsky
In preparation for doing XGMI reset synchronization using task barrier. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 76 +- 2 files changed, 12 insertions(+), 66 deletions(-) diff

Re: [PATCH] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-12-11 Thread Sam Ravnborg
Hi Jerry. > Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI > panel. Thanks for your persistence with this driver. Unfortunately the driver no longer builds after the drm_panel work we committed earlier this week to drm-misc-next. > > V9: > - Adjust init code, make the

Re: [PATCH 3/3] drm/vram-helper: Support struct drm_driver.gem_create_object

2019-12-11 Thread Sam Ravnborg
Hi Thomas, On Wed, Dec 11, 2019 at 07:08:32PM +0100, Thomas Zimmermann wrote: > Drivers that what to allocate VRAM GEM objects with additional fields > can now do this by implementing struct drm_driver.gem_create_object. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_gem_vram_

Re: [PATCH] drm/modes: Support video parameters with only reflect option

2019-12-11 Thread Stephan Gerhold
On Wed, Dec 11, 2019 at 07:10:46PM +0100, Maxime Ripard wrote: > Hi Stephan, > > On Tue, Dec 10, 2019 at 11:42:37AM +0100, Stephan Gerhold wrote: > > On Tue, Dec 10, 2019 at 11:20:46AM +0100, Maxime Ripard wrote: > > > Hi, > > > > > > On Mon, Dec 09, 2019 at 07:32:54PM +0100, Stephan Gerhold wrote

Re: [PATCH 3/3] virtio-gpu: use damage info for display updates.

2019-12-11 Thread Chia-I Wu
On Wed, Dec 11, 2019 at 12:42 AM Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_plane.c | 41 +++--- > 1 file changed, 24 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c > b/drivers/gpu/drm/

Re: [PATCH 1/3] drm/virtio: skip set_scanout if framebuffer didn't change

2019-12-11 Thread Chia-I Wu
On Wed, Dec 11, 2019 at 12:42 AM Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_plane.c | 31 ++ > 1 file changed, 17 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c > b/drivers/gpu/drm/

Re: [PATCH] drm/modes: Support video parameters with only reflect option

2019-12-11 Thread Maxime Ripard
Hi Stephan, On Tue, Dec 10, 2019 at 11:42:37AM +0100, Stephan Gerhold wrote: > On Tue, Dec 10, 2019 at 11:20:46AM +0100, Maxime Ripard wrote: > > Hi, > > > > On Mon, Dec 09, 2019 at 07:32:54PM +0100, Stephan Gerhold wrote: > > > At the moment, video mode parameters like video=540x960,reflect_x, >

[PATCH 0/3] drm/vram-helper: Various cleanups

2019-12-11 Thread Thomas Zimmermann
A number of cleanups that I wanted to apply for some time. The first two patches simplify the public interface. The third patch adds support for struct drm_driver.gem_create_object. All tested by running fbdev, X11 and Weston on ast HW. Thomas Zimmermann (3): drm/vram-helper: Remove interruptibl

[PATCH 1/3] drm/vram-helper: Remove interruptible flag from public interface

2019-12-11 Thread Thomas Zimmermann
The flag 'interruptible', which is passed to various functions, is always set to be false. Remove it and hard-code the value. Signed-off-by: Thomas Zimmermann Suggested-by: Daniel Vetter --- drivers/gpu/drm/ast/ast_mode.c | 2 +- drivers/gpu/drm/drm_gem_vram_helper.c | 17 ++

[PATCH 2/3] drm/vram-helper: Remove BO device from public interface

2019-12-11 Thread Thomas Zimmermann
TTM is an implementation detail of the VRAM helpers and therefore shouldn't be exposed to the callers. There's only one correct value for the BO device anyway, which is the one stored in the DRM device. So remove struct ttm_bo_device from the VRAM-helper interface and use the device's VRAM manager

[PATCH 3/3] drm/vram-helper: Support struct drm_driver.gem_create_object

2019-12-11 Thread Thomas Zimmermann
Drivers that what to allocate VRAM GEM objects with additional fields can now do this by implementing struct drm_driver.gem_create_object. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/dr

Re: Question about MSM Driver

2019-12-11 Thread Rob Clark
On Wed, Dec 11, 2019 at 6:22 AM ggermanres wrote: > > Hello. > > I have question about MSM Driver. > > I using Dragonboard 410 with ili9881 display. This is hobby project. This > display from xiaomi redmi 3x/4x. I made PCB board for connect them. I changed > dts, created panel driver (this all o

Re: [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-12-11 Thread Hans de Goede
Hi, On 11-12-2019 01:24, Linus Walleij wrote: On Mon, Dec 2, 2019 at 4:49 PM Hans de Goede wrote: There is only one problem, currently is is not possible to unregister a mapping added with pinctrl_register_mappings and the i915 driver is typically a module which can be unloaded and I believe

Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Teclast X89 tablet

2019-12-11 Thread Hans de Goede
Hi, I know these kinda patches are sorta trivial, still I prefer to get an Acked-by before pushing this to drm-misc-next. Can someone review this please? Alternative I guess we could agree that pushing patches which just add a dmi quirk to drm_panel_orientation_quirks.c is ok when the patch has

Re: [PATCH v3 12/13] drm/connector: Split out orientation quirk detection (v2)

2019-12-11 Thread Hans de Goede
Hi All, Can I get a review or Acked-by from someone for this patch please? The other patches in this series all have acks and it would be nice if I can push this to drm-misc-next... Regards, Hans On 18-11-2019 16:51, Hans de Goede wrote: From: Derek Basehore Not every platform needs quirk

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-11 Thread Hans de Goede
Hi Lee, On 10-12-2019 09:51, Lee Jones wrote: On Tue, 19 Nov 2019, Hans de Goede wrote: At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 different PWM controllers for controlling the LCD's backlight brightness. Either the one integrated into the PMIC or the one integrate

Re: [PATCH 1/2] drm/komeda: Add basic support for D77

2019-12-11 Thread Mihail Atanassov
Hi Tiannan, Thanks for the patch. On Wednesday, 11 December 2019 10:30:09 GMT Tiannan Zhu (Arm Technology China) wrote: > Make komeda driver can recongise D77, D77 is arm latest display > product, compare with D71, D77 support some new features: > 1. Crossbar: adjust every plane's zorder > 2. AT

Re: [PATCH] drm/komeda: Correct d71 register block counting

2019-12-11 Thread Mihail Atanassov
On Tuesday, 10 December 2019 06:10:34 GMT james qian wang (Arm Technology China) wrote: > Per HW, d71->num_blocks includes reserved blocks but no PERIPH block, > correct the block counting accordingly. > D71 happens to only have one reserved block and periph block, which > hides this counting erro

Re: [PATCH v3 2/2] drm/komeda: Enable new product D32 support

2019-12-11 Thread Mihail Atanassov
On Tuesday, 10 December 2019 08:48:51 GMT james qian wang (Arm Technology China) wrote: > D32 is simple version of D71, the difference is: > - Only has one pipeline > - Drop the periph block and merge it to GCU > > v2: Rebase. > v3: Isolate the block counting fix to a new patch I would've expect

Re: [PATCH] drm/dp_mst: clear time slots for ports invalid

2019-12-11 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.4.2, v5.3.15, v4.19.88, v4.14.158, v4.9.206, v4.4.206. v5.4.2: Failed to apply!

Re: [PATCH][next] drm/i915/display: remove duplicated assignment to pointer crtc_state

2019-12-11 Thread Ville Syrjälä
On Tue, Dec 10, 2019 at 02:45:35PM +, Colin King wrote: > From: Colin Ian King > > Pointer crtc_state is being assigned twice, one of these is redundant > and can be removed. > > Addresses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/i915

Re: [PATCH][next] drm/i915: remove redundant checks for a null fb pointer

2019-12-11 Thread Ville Syrjälä
On Tue, Dec 10, 2019 at 02:23:49PM +, Colin King wrote: > From: Colin Ian King > > A prior check and return when pointer fb is null makes > subsequent null checks on fb redundant. Remove the redundant > null checks. > > Addresses-Coverity: ("Logically dead code") > Signed-off-by: Colin Ian

Re: [PATCH v2] video: hdmi: indicate applicability in avi infoframe log

2019-12-11 Thread Ville Syrjälä
On Wed, Dec 11, 2019 at 10:48:42AM +0100, Johan Korsnes wrote: > When logging the AVI InfoFrame, clearly indicate whether or not > attributes are active/"in effect". The specification is given in > CTA-861-G Section 6.4: Format of Version 2, 3 & 4 AVI InfoFrames. > > Attribute BytesReq

Re: [PATCH libdrm v4] modetest: Use floating vrefresh while dumping mode

2019-12-11 Thread Ville Syrjälä
On Tue, Dec 03, 2019 at 06:37:36AM -0800, Devarsh Thakkar wrote: > Add function to derive floating value of vertical > refresh rate from drm mode using pixel clock, > horizontal total size and vertical total size. > > Use this function to find suitable mode having vrefresh > value which is matchin

Re: [PATCH] drm/edid: Increase size of VDB and CMDB bitmaps to 256 bits

2019-12-11 Thread Ville Syrjälä
On Tue, Dec 10, 2019 at 02:10:48PM -0800, Thomas Anderson wrote: > CEA-861-G adds modes up to 219, so increase the size of the > maps in preparation for adding the new modes to drm_edid.c. > > Signed-off-by: Thomas Anderson Thanks. lgtm. Pushed to drm-misc-next. PS. I do wonder a bit if we shou

[PATCH AUTOSEL 5.4 109/134] drm/amdgpu: Call find_vma under mmap_sem

2019-12-11 Thread Sasha Levin
From: Jason Gunthorpe [ Upstream commit a9ae8731e6e52829a935d81a65d7f925cb95dbac ] find_vma() must be called under the mmap_sem, reorganize this code to do the vma check after entering the lock. Further, fix the unlocked use of struct task_struct's mm, instead use the mm from hmm_mirror which h

[PATCH 5.3 073/105] drm: damage_helper: Fix race checking plane->state->fb

2019-12-11 Thread Greg Kroah-Hartman
From: Sean Paul commit 354c2d310082d1c384213ba76c3757dd3cd8755d upstream. Since the dirtyfb ioctl doesn't give us any hints as to which plane is scanning out the fb it's marking as damaged, we need to loop through planes to find it. Currently we just reach into plane state and check, but that c

[PATCH 5.4 55/92] drm: damage_helper: Fix race checking plane->state->fb

2019-12-11 Thread Greg Kroah-Hartman
From: Sean Paul commit 354c2d310082d1c384213ba76c3757dd3cd8755d upstream. Since the dirtyfb ioctl doesn't give us any hints as to which plane is scanning out the fb it's marking as damaged, we need to loop through planes to find it. Currently we just reach into plane state and check, but that c

Re: [PATCH] drm/gma500: globle no more!

2019-12-11 Thread Jani Nikula
On Wed, 11 Dec 2019, Daniel Vetter wrote: > globle, goblin, moblin? > > It's dead code, we lucked out. Oh, sad to see it go. The oldest reference to globle_dev I could find was from 2011. Acked-by: Jani Nikula > > Cc: Ville Syrjälä > Cc: Jani Nikula > Signed-off-by: Daniel Vetter > --- > d

Re: [PATCH v2] drm/panfrost: Add the panfrost_gem_mapping concept

2019-12-11 Thread Rob Herring
On Wed, Dec 11, 2019 at 6:38 AM Steven Price wrote: > > On 10/12/2019 23:08, Rob Herring wrote: > > From: Boris Brezillon > > > > With the introduction of per-FD address space, the same BO can be mapped > > in different address space if the BO is globally visible (GEM_FLINK) > > and opened in dif

Re: [PATCH v3 1/4] drm: add pgprot callback to drm_gem_object_funcs

2019-12-11 Thread Thomas Zimmermann
Hi Am 11.12.19 um 13:38 schrieb Daniel Vetter: > On Wed, Dec 11, 2019 at 01:19:53PM +0100, Gerd Hoffmann wrote: >> The callback allows drivers and helpers to tweak pgprot for mappings. >> This is especially helpful when using shmem helpers. It allows drivers >> to switch mappings from writecombin

Re: [PATCH v2 1/2] drm/shmem: add support for per object caching attributes

2019-12-11 Thread Gerd Hoffmann
Hi, > btw on why udl does this: Imported bo are usually rendered by real hw, and > reading it uncached/wc is the more defensive setting. It would be kinda > nice if dma-buf would expose this, but I fear dma-api maintainers would > murder us if we even just propose that ... so it's a mess right n

Re: [PATCH v2 1/2] drm/shmem: add support for per object caching attributes

2019-12-11 Thread Thomas Zimmermann
Hi Am 11.12.19 um 13:36 schrieb Daniel Vetter: > > The udl use-case should be covered already, simply set the flag correctly > at create/import time? It's per-object ... The original udl gem code did this. It was additional state for something that was detectable from the value of import_attach.

Re: [PATCH v3 1/4] drm: add pgprot callback to drm_gem_object_funcs

2019-12-11 Thread Gerd Hoffmann
> > + /** > > +* @pgprot: > > +* > > +* Tweak pgprot as needed, typically used to set cache bits. > > +* > > +* This callback is optional. > > +* > > +* If unset drm_gem_pgprot_wc() will be used. > > +*/ > > + pgprot_t (*pgprot)(struct drm_gem_object *obj, pgprot

Re: [PATCH v2] drm/panfrost: Add the panfrost_gem_mapping concept

2019-12-11 Thread Steven Price
On 10/12/2019 23:08, Rob Herring wrote: > From: Boris Brezillon > > With the introduction of per-FD address space, the same BO can be mapped > in different address space if the BO is globally visible (GEM_FLINK) > and opened in different context or if the dmabuf is self-imported. The > current im

Re: [PATCH v3 1/4] drm: add pgprot callback to drm_gem_object_funcs

2019-12-11 Thread Daniel Vetter
On Wed, Dec 11, 2019 at 01:19:53PM +0100, Gerd Hoffmann wrote: > The callback allows drivers and helpers to tweak pgprot for mappings. > This is especially helpful when using shmem helpers. It allows drivers > to switch mappings from writecombine (default) to something else (cached > for example)

Re: [PATCH v2 1/2] drm/shmem: add support for per object caching attributes

2019-12-11 Thread Daniel Vetter
On Wed, Dec 11, 2019 at 11:07:25AM +0100, Thomas Zimmermann wrote: > > > Am 11.12.19 um 10:58 schrieb Thomas Zimmermann: > > Hi Gerd > > > > Am 11.12.19 um 09:18 schrieb Gerd Hoffmann: > >> Add caching field to drm_gem_shmem_object to specify the cachine > >> attributes for mappings. Add helper

[PATCH v3 1/4] drm: add pgprot callback to drm_gem_object_funcs

2019-12-11 Thread Gerd Hoffmann
The callback allows drivers and helpers to tweak pgprot for mappings. This is especially helpful when using shmem helpers. It allows drivers to switch mappings from writecombine (default) to something else (cached for example) on a per-object base without having to supply their own mmap() and vmap

[PATCH v3 2/4] drm/shmem: add support for per object caching flags.

2019-12-11 Thread Gerd Hoffmann
Use drm_gem_pgprot_wc() as pgprot callback in drm_gem_shmem_funcs. Use drm_gem_pgprot() to update pgprot caching flags. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/drm_gem_shmem_helper.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_

[PATCH v3 3/4] drm/virtio: fix mmap page attributes

2019-12-11 Thread Gerd Hoffmann
virtio-gpu uses cached mappings, set virtio_gpu_gem_funcs.pgprot accordingly. Reported-by: Gurchetan Singh Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_object.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virt

[PATCH v3 0/4] drm/virtio: fix mmap page attributes

2019-12-11 Thread Gerd Hoffmann
v3: switch to drm_gem_object_funcs callback. v2: make shmem helper caching configurable. Gerd Hoffmann (4): drm: add pgprot callback to drm_gem_object_funcs drm/shmem: add support for per object caching flags. drm/virtio: fix mmap page attributes drm/udl: simplify gem object mapping. inc

[PATCH v3 4/4] drm/udl: simplify gem object mapping.

2019-12-11 Thread Gerd Hoffmann
With shmem helpers allowing to update pgprot caching flags via drm_gem_object_funcs.pgprot we can just use that and ditch our own implementations of mmap() and vmap(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/udl/udl_gem.c | 62 --- 1 file changed, 7 inser

[PATCH v2] drm: Remove drm_bridge->dev

2019-12-11 Thread Mihail Atanassov
As suggested in [1], the 'dev' field is a bit repetitive, since it 1:1 follows the setting and NULLing of the 'encoder' field. Therefore, use drm_bridge->encoder->dev in place of drm_bridge->dev. [1] https://patchwork.freedesktop.org/patch/343824/ v2: - fix checkpatch complaint about unnecessary

[PATCH] drm/gma500: globle no more!

2019-12-11 Thread Daniel Vetter
globle, goblin, moblin? It's dead code, we lucked out. Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: Daniel Vetter --- drivers/gpu/drm/gma500/mdfld_intel_display.c | 23 1 file changed, 23 deletions(-) diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drive

Re: [PATCH RFC 4/8] drm/sprd: add Unisoc's drm display controller driver

2019-12-11 Thread Emil Velikov
On Wed, 11 Dec 2019 at 09:18, tang pengchuan wrote: > > Hi > > Emil Velikov 于2019年12月11日周三 上午1:14写道: >> >> Hi Kevin, >> >> On Tue, 10 Dec 2019 at 08:41, Kevin Tang wrote: >> > >> > From: Kevin Tang >> > >> > Adds DPU(Display Processor Unit) support for the Unisoc's display >> > subsystem. >> >

Re: [PATCH v9 23/25] mm/gup: track FOLL_PIN pages

2019-12-11 Thread Jan Kara
On Tue 10-12-19 18:53:16, John Hubbard wrote: > Add tracking of pages that were pinned via FOLL_PIN. > > As mentioned in the FOLL_PIN documentation, callers who effectively set > FOLL_PIN are required to ultimately free such pages via unpin_user_page(). > The effect is similar to FOLL_GET, and may

Re: [PATCH v3 12/12] auxdisplay: constify fb ops

2019-12-11 Thread Jani Nikula
On Tue, 10 Dec 2019, Miguel Ojeda wrote: > On Mon, Dec 9, 2019 at 3:04 PM Jani Nikula wrote: >> >> On Tue, 03 Dec 2019, Jani Nikula wrote: >> > Now that the fbops member of struct fb_info is const, we can start >> > making the ops const as well. >> > >> > Cc: Miguel Ojeda Sandonis >> > Cc: Robi

Re: [v3,3/4] drm/edid: Throw away the dummy VIC 0 cea mode

2019-12-11 Thread Ville Syrjälä
On Tue, Dec 10, 2019 at 03:18:54PM -0800, Tom Anderson wrote: > On Wed, Sep 25, 2019 at 04:55:01PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Now that the cea mode handling is not 100% tied to the single > > array the dummy VIC 0 mode is pretty much pointles. Throw it > > out. >

Re: [PATCH] drm: remove drm_bridge->dev

2019-12-11 Thread Mihail Atanassov
Hi, On Wednesday, 11 December 2019 07:38:29 GMT Thomas Zimmermann wrote: > Hi > > Am 10.12.19 um 16:11 schrieb Mihail Atanassov: > > As suggested in [1], the 'dev' field is a bit repetitive, since it 1:1 > > follows the setting and NULLing of the 'encoder' field. Therefore, use > > drm_bridge->en

Re: [PATCH v3 04/50] drm/bridge: Add connector-related bridge operations and data

2019-12-11 Thread Mihail Atanassov
Hi Laurent, On Tuesday, 10 December 2019 22:57:04 GMT Laurent Pinchart wrote: > To support implementation of DRM connectors on top of DRM bridges > instead of by bridges, the drm_bridge needs to expose new operations and > data: > > - Output detection, hot-plug notification, mode retrieval and ED

Re: [PATCH v9 20/25] powerpc: book3s64: convert to pin_user_pages() and put_user_page()

2019-12-11 Thread Jan Kara
On Tue 10-12-19 18:53:13, John Hubbard wrote: > 1. Convert from get_user_pages() to pin_user_pages(). > > 2. As required by pin_user_pages(), release these pages via > put_user_page(). > > Cc: Jan Kara > Signed-off-by: John Hubbard The patch looks good to me. You can add: Reviewed-by: Jan Kar

Re: [PATCH] drm/vmwgfx: prevent memory leak in vmw_context_define

2019-12-11 Thread Thomas Hellstrom
On 9/25/19 6:46 AM, Navid Emamdoost wrote: > In vmw_context_define if vmw_context_init fails the allocated resource > should be unreferenced. The goto label was fixed. > > Signed-off-by: Navid Emamdoost > --- > drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [PATCH] drm/vmwgfx: prevent memory leak in vmw_cmdbuf_res_add

2019-12-11 Thread Thomas Hellstrom
On 9/25/19 6:38 AM, Navid Emamdoost wrote: > In vmw_cmdbuf_res_add if drm_ht_insert_item fails the allocated memory > for cres should be released. > > Signed-off-by: Navid Emamdoost > --- > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > d

Re: [PATCH v2 1/2] drm/shmem: add support for per object caching attributes

2019-12-11 Thread Thomas Zimmermann
Am 11.12.19 um 10:58 schrieb Thomas Zimmermann: > Hi Gerd > > Am 11.12.19 um 09:18 schrieb Gerd Hoffmann: >> Add caching field to drm_gem_shmem_object to specify the cachine >> attributes for mappings. Add helper function to tweak pgprot >> accordingly. Switch vmap and mmap functions to the ne

Re: [PATCH v2 1/2] drm/shmem: add support for per object caching attributes

2019-12-11 Thread Thomas Zimmermann
Am 11.12.19 um 10:58 schrieb Thomas Zimmermann: > > What do you think about turning this function into a callback in struct > shmem_funcs? The default implementation would be for WC, virtio would s/shmem_funcs/drm_gem_object_funcs > use CACHED. The individual implementations could still be loc

Re: [PATCH v2 1/2] drm/shmem: add support for per object caching attributes

2019-12-11 Thread Thomas Zimmermann
Hi Gerd Am 11.12.19 um 09:18 schrieb Gerd Hoffmann: > Add caching field to drm_gem_shmem_object to specify the cachine > attributes for mappings. Add helper function to tweak pgprot > accordingly. Switch vmap and mmap functions to the new helper. > > Set caching to write-combine when creating t

[PATCH v2] video: hdmi: indicate applicability in avi infoframe log

2019-12-11 Thread Johan Korsnes
When logging the AVI InfoFrame, clearly indicate whether or not attributes are active/"in effect". The specification is given in CTA-861-G Section 6.4: Format of Version 2, 3 & 4 AVI InfoFrames. Attribute BytesRequirement Ext. Colorimetry EC0..EC2 Colorimetry (C0,C1) set to Extended.

Re: linux-next: build failure after merge of the drm-intel tree

2019-12-11 Thread Jani Nikula
On Tue, 10 Dec 2019, Stephen Rothwell wrote: > Hi all, > > [Just adding Dave Airlie to the cc list] > > On Tue, 10 Dec 2019 09:39:57 +1100 Stephen Rothwell > wrote: >> >> After merging the drm-intel tree, today's linux-next build (x86_64 >> allmodconfig) failed like this: FYI, I've now backmerg

Re: [PATCH 4/5] Revert "drm/atmel-hlcdc: allow selecting a higher pixel-clock than requested"

2019-12-11 Thread Peter Rosin
On 2019-12-10 15:59, claudiu.bez...@microchip.com wrote: > > > On 10.12.2019 16:11, Peter Rosin wrote: >> On 2019-12-10 14:24, Claudiu Beznea wrote: >>> This reverts commit f6f7ad3234613f6f7f27c25036aaf078de07e9b0. >>> ("drm/atmel-hlcdc: allow selecting a higher pixel-clock than requested") >>> b

Re: [PATCH v3 12/12] auxdisplay: constify fb ops

2019-12-11 Thread Miguel Ojeda
On Mon, Dec 9, 2019 at 3:04 PM Jani Nikula wrote: > > On Tue, 03 Dec 2019, Jani Nikula wrote: > > Now that the fbops member of struct fb_info is const, we can start > > making the ops const as well. > > > > Cc: Miguel Ojeda Sandonis > > Cc: Robin van der Gracht > > Reviewed-by: Daniel Vetter >

  1   2   >