Re: [PATCH v11 00/25] mm/gup: track dma-pinned pages: FOLL_PIN

2019-12-20 Thread John Hubbard
On 12/20/19 4:51 PM, Dan Williams wrote: > On Fri, Dec 20, 2019 at 4:41 PM John Hubbard wrote: >> >> On 12/20/19 4:33 PM, Dan Williams wrote: >> ... I believe there might be also a different solution for this: For transparent huge pages, we could find a space in 'struct page' of the

Re: [PATCH v11 00/25] mm/gup: track dma-pinned pages: FOLL_PIN

2019-12-20 Thread Dan Williams
On Fri, Dec 20, 2019 at 4:41 PM John Hubbard wrote: > > On 12/20/19 4:33 PM, Dan Williams wrote: > ... > >> I believe there might be also a different solution for this: For > >> transparent huge pages, we could find a space in 'struct page' of the > >> second page in the huge page for proper pin c

Re: [PATCH v11 00/25] mm/gup: track dma-pinned pages: FOLL_PIN

2019-12-20 Thread John Hubbard
On 12/20/19 4:33 PM, Dan Williams wrote: ... >> I believe there might be also a different solution for this: For >> transparent huge pages, we could find a space in 'struct page' of the >> second page in the huge page for proper pin counter and just account pins >> there so we'd have full width of

Re: [PATCH v11 00/25] mm/gup: track dma-pinned pages: FOLL_PIN

2019-12-20 Thread Dan Williams
On Fri, Dec 20, 2019 at 1:22 AM Jan Kara wrote: > > On Thu 19-12-19 12:30:31, John Hubbard wrote: > > On 12/19/19 5:26 AM, Leon Romanovsky wrote: > > > On Mon, Dec 16, 2019 at 02:25:12PM -0800, John Hubbard wrote: > > > > Hi, > > > > > > > > This implements an API naming change (put_user_page*() -

Re: [PATCH v11 00/25] mm/gup: track dma-pinned pages: FOLL_PIN

2019-12-20 Thread Dan Williams
On Fri, Dec 20, 2019 at 5:34 AM Jason Gunthorpe wrote: > > On Thu, Dec 19, 2019 at 01:13:54PM -0800, John Hubbard wrote: > > On 12/19/19 1:07 PM, Jason Gunthorpe wrote: > > > On Thu, Dec 19, 2019 at 12:30:31PM -0800, John Hubbard wrote: > > > > On 12/19/19 5:26 AM, Leon Romanovsky wrote: > > > > >

Re: [PATCH] drm/dp_mst: clear time slots for ports invalid

2019-12-20 Thread Lyude Paul
Mhh-I think I understand the problem you're trying to solve here but I think this solution might be a bit overkill. When I did the rework of topology references for ports, I made it so that we can guarantee memory access to a port without it needing to be a valid part of the topology. As well, all

Re: [git pull] drm fixes for 5.5-rc3 (resend with cc)

2019-12-20 Thread pr-tracker-bot
The pull request you sent on Sat, 21 Dec 2019 09:58:23 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2019-12-21 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a7c88728da3bc68c5b3815332d084244303fd254 Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [PATCH v11 00/25] mm/gup: track dma-pinned pages: FOLL_PIN

2019-12-20 Thread John Hubbard
On 12/20/19 1:21 AM, Jan Kara wrote: ... >> So, ideas and next steps: >> >> 1. Assuming that you *are* hitting this, I think I may have to fall back to >> implementing the "deferred" part of this design, as part of this series, >> after >> all. That means: >> >> For the pin/unpin calls at least,

[git pull] drm fixes for 5.5-rc3 (resend with cc)

2019-12-20 Thread Dave Airlie
Hey Linus, (Linus pointed out I forgot to cc everyone). Probably the last one before Christmas, I'll see if there is much demand over next few weeks for more fixes, I expect it'll be quiet enough. This has one exynos fix, and a bunch of i915 core and i915 GVT fixes. Dave. drm-fixes-2019-12-21:

Re: [PATCH v11 00/25] mm/gup: track dma-pinned pages: FOLL_PIN

2019-12-20 Thread John Hubbard
On 12/20/19 10:29 AM, Leon Romanovsky wrote: ... >> $ ./build.sh >> $ build/bin/run_tests.py >> >> If you get things that far I think Leon can get a reproduction for you > > I'm not so optimistic about that. > OK, I'm going to proceed for now on the assumption that I've got an overflow problem t

Re: [PATCH] dt-bindings: display: Convert raydium,rm68200 panel to DT schema

2019-12-20 Thread Rob Herring
On Fri, Dec 20, 2019 at 03:54:20PM +0100, Yannick Fertre wrote: > From: Yannick Fertré > > Convert the raydium,rm68200 panel binding to DT schema. > > Signed-off-by: Yannick Fertre > --- > .../bindings/display/panel/raydium,rm68200.txt | 25 - > .../bindings/display/panel/raydium,r

Re: [PATCH v11 00/25] mm/gup: track dma-pinned pages: FOLL_PIN

2019-12-20 Thread John Hubbard
On 12/20/19 10:48 AM, Leon Romanovsky wrote: ... >> test_query_qp (tests.test_qp.QPTest) ... ok >> test_rdmacm_sync_traffic (tests.test_rdmacm.CMTestCase) ... skipped 'No >> devices with net interface' >> >> == >> FAIL: test_query

Re: [PATCH v9 14/18] drm/amd/display: Add PBN per slot calculation for DSC

2019-12-20 Thread Leo
On 2019-12-13 3:08 p.m., mikita.lip...@amd.com wrote: > From: Mikita Lipski > > [why] > Need to calculate VCPI slots differently for DSC > to take in account current link rate, link count > and FEC. > [how] > Add helper to get pbn_div from dc_link > > Cc: Harry Wentland > Cc: Lyude Paul > S

Re: [PATCH v4 3/3] drm/panel: add panel driver for Xinpeng XPP055C272 panels

2019-12-20 Thread Heiko Stuebner
Hi Sam, Am Dienstag, 17. Dezember 2019, 23:29:06 CET schrieb Heiko Stuebner: > From: Heiko Stuebner > > Base on the somewhat similar Rocktech driver but adapted for > panel-specific init of the XPP055C272. > > changes in v3: > - remove wrong negative sync flags from display-mode to fix a displa

[Bug 204241] amdgpu fails to resume from suspend

2019-12-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 --- Comment #50 from Ulf Winkelvos (u...@winkelvos.de) --- I tried to bisect this issue in the past days, but it is almost impossible to track it down, as it is so hard to reproduce it reliably. It seems that 5.2 is "better", the close the commits

Re: [PATCH] drm: of: Fix linking when CONFIG_OF is not set

2019-12-20 Thread Chris Wilson
Quoting Laurent Pinchart (2019-12-19 10:37:03) > The new helper drm_of_lvds_get_dual_link_pixel_order() introduced in > commit 6529007522de has a fallback stub when CONFIG_OF is not set, but > the stub is declared in drm_of.h without a static inline. This causes > multiple definitions of the functi

Re: [PATCH] drm/of: Add missing static inline to get_dual_link_pixel_order stub

2019-12-20 Thread Laurent Pinchart
Hi Chris, Thank you for the patch. On Fri, Dec 20, 2019 at 09:38:16PM +, Chris Wilson wrote: > Mark up the stub drm_of_lvds_get_dual_link_pixel_order() as being a > static inline to avoid a double definition. > > Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order") > Si

Re: [PATCH v9 10/18] drm/dp_mst: Manually overwrite PBN divider for calculating timeslots

2019-12-20 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2019-12-13 at 15:08 -0500, mikita.lip...@amd.com wrote: > From: Mikita Lipski > > [why] > For DSC case we cannot use topology manager's PBN divider > variable. The default divider does not take FEC into account. > Therefore the driver has to calculate its own div

Re: [PATCH v9 15/18] drm/amd/display: MST DSC compute fair share

2019-12-20 Thread Lyude Paul
Acked-by: Lyude Paul On Fri, 2019-12-13 at 15:08 -0500, mikita.lip...@amd.com wrote: > From: David Francis > > If there is limited link bandwidth on a MST network, > it must be divided fairly between the streams on that network > > Implement an algorithm to determine the correct DSC config > f

Re: [PATCH v9 14/18] drm/amd/display: Add PBN per slot calculation for DSC

2019-12-20 Thread Lyude Paul
Acked-by: Lyude Paul On Fri, 2019-12-13 at 15:08 -0500, mikita.lip...@amd.com wrote: > From: Mikita Lipski > > [why] > Need to calculate VCPI slots differently for DSC > to take in account current link rate, link count > and FEC. > [how] > Add helper to get pbn_div from dc_link > > Cc: Harry W

Re: [PATCH v9 16/18] drm/amd/display: Recalculate VCPI slots for new DSC connectors

2019-12-20 Thread Lyude Paul
So I reviewed this already but realized I made a very silly mistake, comments down below: On Fri, 2019-12-13 at 15:08 -0500, mikita.lip...@amd.com wrote: > From: Mikita Lipski > > [why] > Since for DSC MST connector's PBN is claculated differently > due to compression, we have to recalculate bot

[PATCH] drm/of: Add missing static inline to get_dual_link_pixel_order stub

2019-12-20 Thread Chris Wilson
Mark up the stub drm_of_lvds_get_dual_link_pixel_order() as being a static inline to avoid a double definition. Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order") Signed-off-by: Chris Wilson Cc: Fabrizio Castro Cc: Laurent Pinchart --- include/drm/drm_of.h | 5 +++-- 1

Re: [PATCH v9 01/18] drm/dp_mst: Add PBN calculation for DSC modes

2019-12-20 Thread Lyude Paul
Actually, one comment on this that should be very simple to add On Fri, 2019-12-13 at 15:08 -0500, mikita.lip...@amd.com wrote: > From: David Francis > > With DSC, bpp can be fractional in multiples of 1/16. > > Change drm_dp_calc_pbn_mode to reflect this, adding a new > parameter bool dsc. Whe

Re: [Freedreno] [PATCH 5/5] drm/msm/a6xx: Add support for using system cache(LLC)

2019-12-20 Thread Jordan Crouse
On Fri, Dec 20, 2019 at 03:40:59PM +0530, smase...@codeaurora.org wrote: > On 2019-12-20 01:28, Jordan Crouse wrote: > >On Thu, Dec 19, 2019 at 06:44:46PM +0530, Sharat Masetty wrote: > >>The last level system cache can be partitioned to 32 different slices > >>of which GPU has two slices prealloca

Re: [PATCH v2] drm/amd/display: Reduce HDMI pixel encoding if max clock is exceeded

2019-12-20 Thread Alex Deucher
On Fri, Dec 20, 2019 at 10:10 AM Tom Anderson wrote: > > Ping. Is there any action required to get this landed? Looks good to me, but I'd like to hear from the display guys. Alex > > On Tue, Dec 10, 2019 at 10:59:24AM -0800, Tom Anderson wrote: > > Friendly ping. > > > > On Mon, Dec 02, 2019

Re: [PATCH] drm/amdgpu: Remove unneeded variable 'ret' in navi10_ih.c

2019-12-20 Thread Alex Deucher
On Fri, Dec 20, 2019 at 10:10 AM Ma Feng wrote: > > Fixes coccicheck warning: > > drivers/gpu/drm/amd/amdgpu/navi10_ih.c:113:5-8: Unneeded variable: "ret". > Return "0" on line 182 > > Reported-by: Hulk Robot > Signed-off-by: Ma Feng Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu

Re: [PATCH] drm/amdgpu: Remove unneeded variable 'ret' in amdgpu_device.c

2019-12-20 Thread Alex Deucher
On Fri, Dec 20, 2019 at 10:10 AM Ma Feng wrote: > > Fixes coccicheck warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1036:5-8: Unneeded variable: > "ret". Return "0" on line 1079 > > Reported-by: Hulk Robot > Signed-off-by: Ma Feng Applied. thanks! Alex > --- > drivers/gpu/drm/amd/

Re: [PATCH v11 00/25] mm/gup: track dma-pinned pages: FOLL_PIN

2019-12-20 Thread Leon Romanovsky
On Thu, Dec 19, 2019 at 02:58:43PM -0800, John Hubbard wrote: > On 12/19/19 1:07 PM, Jason Gunthorpe wrote: > ... > > > 3. It would be nice if I could reproduce this. I have a two-node mlx5 > > > Infiniband > > > test setup, but I have done only the tiniest bit of user space IB coding, > > > so >

Re: [PATCH v11 00/25] mm/gup: track dma-pinned pages: FOLL_PIN

2019-12-20 Thread Leon Romanovsky
On Thu, Dec 19, 2019 at 05:07:43PM -0400, Jason Gunthorpe wrote: > On Thu, Dec 19, 2019 at 12:30:31PM -0800, John Hubbard wrote: > > On 12/19/19 5:26 AM, Leon Romanovsky wrote: > > > On Mon, Dec 16, 2019 at 02:25:12PM -0800, John Hubbard wrote: > > > > Hi, > > > > > > > > This implements an API nam

Re: [PATCH] drm/dp_mst: clear time slots for ports invalid

2019-12-20 Thread Lyude Paul
Hi! I will try to review this patch today, must have gotten lost in the noise On Fri, 2019-12-20 at 01:46 +, Lin, Wayne wrote: > [AMD Official Use Only - Internal Distribution Only] > > Pinged. > Hi, can someone help to review please. > > Thanks a lot. > > Regards, > Wayne > >

Why eglGetDisplay(EGL_DEFAULT_DISPLAY) returns EGL_NO_DISPLAY?

2019-12-20 Thread TAEHO NAM
Hi, I'm new to dri-devel and sorry if this question doesn't fit here. In my code, the case 1 of getting eglDisplay using EGL_DEFAULT_DISPLAY failed, but, the case 2 succeeded. // Case 1 egl_.display = eglGetDisplay (EGL_DEFAULT_DISPLAY); // Case 2 struct gbm_device * gbm_device_; gbm_device_ = gb

[PATCH v5 1/5] dt-bindings: display: ti, k2g-dss: Add dt-schema yaml binding

2019-12-20 Thread Jyri Sarha
Add dt-schema yaml bindig for K2G DSS, an ultra-light version of TI Keystone Display SubSystem. Version history: v2: no change v3: - Add ports node - Add includes to dts example - reindent dts example v4: - Add descriptions to reg and clocks properties - Remove minItems when its val

[PATCH v5 5/5] MAINTAINERS: add entry for tidss

2019-12-20 Thread Jyri Sarha
Add entry for tidss DRM driver. Version history: v2: no change v3: - Move tidss entry after omapdrm - Add "T: git git://anongit.freedesktop.org/drm/drm-misc" v4: no change v5: no change Signed-off-by: Jyri Sarha --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) dif

[PATCH v5 3/5] dt-bindings: display: ti, j721e-dss: Add dt-schema yaml binding

2019-12-20 Thread Jyri Sarha
Add dt-schema yaml bindig for J721E DSS, J721E version TI Keystone Display SubSystem. Version history: v2: no change v3: - reg-names: "wp" -> "wb" - Add ports node - Add includes to dts example - reindent dts example v4: - Add descriptions to reg, clocks, and interrups properties

[PATCH v5 0/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2019-12-20 Thread Jyri Sarha
Changes since v4: - itemize named resource property descriptions in dt binding - fix wp to wb in the ti,j721e-dss reg property description - remove fifo underflow irq handling, it is not an error and it should be used for debug purposes only - memory tuning, prefetch plane fifo up to high-thresho

[PATCH v5 2/5] dt-bindings: display: ti, am65x-dss: Add dt-schema yaml binding

2019-12-20 Thread Jyri Sarha
Add dt-schema yaml bindig for AM65x DSS, AM65x version TI Keystone Display SubSystem. Version history: v2: no change v3: - Add ports node - use allOf in ti,am65x-oldi-io-ctrl to add both $ref and maxItems - Add includes to dts example - reindent dts example v4: - Add descriptions to

[PATCH v5 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2019-12-20 Thread Jyri Sarha
This patch adds a new DRM driver for Texas Instruments DSS IPs used on Texas Instruments Keystone K2G, AM65x, and J721e SoCs. The new DSS IP is a major change to the older DSS IP versions, which are supported by the omapdrm driver. While on higher level the Keystone DSS resembles the older DSS vers

Re: [PATCH] drm/bridge/synopsys: dsi: use mipi_dsi_device to find panel or bridge

2019-12-20 Thread Yannick FERTRE
Hello Heiko, I test with success your patch on a board stm32mp1 with a panel raydium rm68200. I need more time to test with a HDMI bridge  like ad7533. Best regards Yannick Fertré On 12/17/19 11:41 PM, Heiko Stuebner wrote: > From: Heiko Stuebner > > Right now the dsi driver uses drm_of_find

[Bug 205915] AMDGPU: Screen flicker after resume from suspend

2019-12-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205915 --- Comment #3 from onil (o...@pm.me) --- Problem only occurs when dpm_force_performance_level is set to "low" before suspend. if dpm_force_performance_level is "auto" or "high" there is no flickering after resume from suspend. -- You are receiv

Re: [PATCH next] drm/amd/display: make some symbols static

2019-12-20 Thread Harry Wentland
On 2019-12-20 1:55 a.m., Chen Zhou wrote: > Make some structs and functions static to fix build warnings, parts of > warnings are as follows: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:744:21: > warning: symbol 'dce110_clock_source_create' was not declared. Should

[PATCH] dt-bindings: display: Convert raydium, rm68200 panel to DT schema

2019-12-20 Thread Yannick Fertre
From: Yannick Fertré Convert the raydium,rm68200 panel binding to DT schema. Signed-off-by: Yannick Fertre --- .../bindings/display/panel/raydium,rm68200.txt | 25 - .../bindings/display/panel/raydium,rm68200.yaml| 61 ++ 2 files changed, 61 insertions(+), 2

[PATCH] dt-bindings: display: Convert orisetech, otm8009a panel to DT schema

2019-12-20 Thread Yannick Fertre
From: Yannick Fertré Convert the orisetech,otm8009a panel binding to DT schema. Signed-off-by: Yannick Fertre --- .../bindings/display/panel/orisetech,otm8009a.txt | 23 .../bindings/display/panel/orisetech,otm8009a.yaml | 62 ++ 2 files changed, 62 insertions(+),

[PATCH AUTOSEL 4.14 10/19] drm/nouveau: Move the declaration of struct nouveau_conn_atom up a bit

2019-12-20 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 37a68eab4cd92b507c9e8afd760fdc18e4fecac6 ] Place the declaration of struct nouveau_conn_atom above that of struct nouveau_connector. This commit makes no changes to the moved block what so ever, it just moves it up a bit. This is a preparation patch to fix

[PATCH AUTOSEL 4.19 03/34] drm/amdgpu: add check before enabling/disabling broadcast mode

2019-12-20 Thread Sasha Levin
From: Guchun Chen [ Upstream commit 6e807535dae5dbbd53bcc5e81047a20bf5eb08ea ] When security violation from new vbios happens, data fabric is risky to stop working. So prevent the direct access to DF mmFabricConfigAccessControl from the new vbios and onwards. Signed-off-by: Guchun Chen Reviewe

[PATCH AUTOSEL 4.19 23/34] drm/nouveau: Move the declaration of struct nouveau_conn_atom up a bit

2019-12-20 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 37a68eab4cd92b507c9e8afd760fdc18e4fecac6 ] Place the declaration of struct nouveau_conn_atom above that of struct nouveau_connector. This commit makes no changes to the moved block what so ever, it just moves it up a bit. This is a preparation patch to fix

[PATCH AUTOSEL 4.19 05/34] drm/amd/display: Fixed kernel panic when booting with DP-to-HDMI dongle

2019-12-20 Thread Sasha Levin
From: David Galiffi [ Upstream commit a51d9f8fe756beac51ce26ef54195da00a260d13 ] [Why] In dc_link_is_dp_sink_present, if dal_ddc_open fails, then dal_gpio_destroy_ddc is called, destroying pin_data and pin_clock. They are created only on dc_construct, and next aux access will cause a panic. [Ho

[PATCH AUTOSEL 4.19 04/34] drm/amdgpu: add cache flush workaround to gfx8 emit_fence

2019-12-20 Thread Sasha Levin
From: Pierre-Eric Pelloux-Prayer [ Upstream commit bf26da927a1cd57c9deb2db29ae8cf276ba8b17b ] The same workaround is used for gfx7. Both PAL and Mesa use it for gfx8 too, so port this commit to gfx_v8_0_ring_emit_fence_gfx. Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Alex Deucher S

[PATCH AUTOSEL 5.4 36/52] drm/nouveau: Move the declaration of struct nouveau_conn_atom up a bit

2019-12-20 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 37a68eab4cd92b507c9e8afd760fdc18e4fecac6 ] Place the declaration of struct nouveau_conn_atom above that of struct nouveau_connector. This commit makes no changes to the moved block what so ever, it just moves it up a bit. This is a preparation patch to fix

[PATCH AUTOSEL 5.4 07/52] drm/amd/display: Map DSC resources 1-to-1 if numbers of OPPs and DSCs are equal

2019-12-20 Thread Sasha Levin
From: Nikola Cornij [ Upstream commit a1fc44b609b4e9c0941f0e4a1fc69d367af5ab69 ] [why] On ASICs where number of DSCs is the same as OPPs there's no need for DSC resource management. Mappping 1-to-1 fixes mode-set- or S3- -related issues for such platforms. [how] Map DSC resources 1-to-1 to pipe

[PATCH AUTOSEL 5.4 09/52] drm/amd/display: Change the delay time before enabling FEC

2019-12-20 Thread Sasha Levin
From: "Leo (Hanghong) Ma" [ Upstream commit 28fa24ad14e8f7d23c62283eaf9c79b4fd165c16 ] [why] DP spec requires 1000 symbols delay between the end of link training and enabling FEC in the stream. Currently we are using 1 miliseconds delay which is not accurate. [how] One lane RBR should have the

[PATCH AUTOSEL 5.4 37/52] drm/nouveau: Fix drm-core using atomic code-paths on pre-nv50 hardware

2019-12-20 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 64d17f25dcad518461ccf0c260544e1e379c5b35 ] We do not support atomic modesetting on pre-nv50 hardware, but until now our connector code was setting drm_connector->state on pre-nv50 hardware. This causes the core to enter atomic modesetting paths in at least:

[PATCH AUTOSEL 5.4 38/52] drm/nouveau/kms/nv50-: fix panel scaling

2019-12-20 Thread Sasha Levin
From: Ben Skeggs [ Upstream commit 3d1890ef8023e61934e070021b06cc9f417260c0 ] Under certain circumstances, encoder atomic_check() can be entered without adjusted_mode having been reset to the same as mode, which confuses the scaling logic and can lead to a misprogrammed display. Fix this by che

[PATCH AUTOSEL 5.4 10/52] drm/amd/display: Reset steer fifo before unblanking the stream

2019-12-20 Thread Sasha Levin
From: Nikola Cornij [ Upstream commit 87de6cb2f28153bc74d0a001ca099c29453e145f ] [why] During mode transition steer fifo could overflow. Quite often it recovers by itself, but sometimes it doesn't. [how] Add steer fifo reset before unblanking the stream. Also add a short delay when resetting di

[PATCH AUTOSEL 5.4 08/52] drm/amd/display: Fixed kernel panic when booting with DP-to-HDMI dongle

2019-12-20 Thread Sasha Levin
From: David Galiffi [ Upstream commit a51d9f8fe756beac51ce26ef54195da00a260d13 ] [Why] In dc_link_is_dp_sink_present, if dal_ddc_open fails, then dal_gpio_destroy_ddc is called, destroying pin_data and pin_clock. They are created only on dc_construct, and next aux access will cause a panic. [Ho

[PATCH AUTOSEL 5.4 06/52] drm/amdgpu: add cache flush workaround to gfx8 emit_fence

2019-12-20 Thread Sasha Levin
From: Pierre-Eric Pelloux-Prayer [ Upstream commit bf26da927a1cd57c9deb2db29ae8cf276ba8b17b ] The same workaround is used for gfx7. Both PAL and Mesa use it for gfx8 too, so port this commit to gfx_v8_0_ring_emit_fence_gfx. Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Alex Deucher S

[PATCH AUTOSEL 5.4 11/52] drm/amd/display: update dispclk and dppclk vco frequency

2019-12-20 Thread Sasha Levin
From: Eric Yang [ Upstream commit 44ce6c3dc8479bb3ed68df13b502b0901675e7d6 ] Value obtained from DV is not allowing 8k60 CTA mode with DSC to pass, after checking real value being used in hw, find out that correct value is 3600, which will allow that mode. Signed-off-by: Eric Yang Reviewed-by:

[PATCH AUTOSEL 5.4 01/52] drm/mcde: dsi: Fix invalid pointer dereference if panel cannot be found

2019-12-20 Thread Sasha Levin
From: Stephan Gerhold [ Upstream commit c131280c03bd1c225c2e64e9ef75873ffca3d96e ] The "panel" pointer is not reset to NULL if of_drm_find_panel() returns an error. Therefore we later assume that a panel was found, and try to dereference the error pointer, resulting in: mcde-dsi a0351000.ds

[PATCH AUTOSEL 5.4 04/52] drm/amdgpu: add check before enabling/disabling broadcast mode

2019-12-20 Thread Sasha Levin
From: Guchun Chen [ Upstream commit 6e807535dae5dbbd53bcc5e81047a20bf5eb08ea ] When security violation from new vbios happens, data fabric is risky to stop working. So prevent the direct access to DF mmFabricConfigAccessControl from the new vbios and onwards. Signed-off-by: Guchun Chen Reviewe

[PATCH AUTOSEL 5.4 05/52] drm/amdgpu: add header line for power profile on Arcturus

2019-12-20 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 14891c316ca7e15d81dba78f30fb630e3f9ee2c9 ] So the output is consistent with other asics. Reviewed-by: Evan Quan Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 5 + 1 file changed, 5 insertion

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2019-12-20 Thread Benjamin Gaignard
Le lun. 16 déc. 2019 à 09:28, Benjamin Gaignard a écrit : > > Le mer. 4 déc. 2019 à 17:47, Jani Nikula a > écrit : > > > > On Thu, 28 Nov 2019, Benjamin Gaignard wrote: > > > Fix the warnings that show up with W=1. > > > They are all about unused but set variables. > > > If functions returns ar

Re: [Spice-devel] [PATCH 4/4] drm/qxl: add drm_driver.release callback.

2019-12-20 Thread Gerd Hoffmann
On Fri, Dec 20, 2019 at 07:09:20AM -0500, Frediano Ziglio wrote: > > > > Move final cleanups to qxl_drm_release() callback. > > Can you explain in the commit why this is better or preferable? It gets called when the drm device refcount goes down to zero. It's needed for a proper cleanup in the c

Re: [PATCH] drm/stm: ltdc: move pinctrl to encoder mode set

2019-12-20 Thread Benjamin Gaignard
Le lun. 2 déc. 2019 à 18:19, Philippe CORNU a écrit : > > Dear Yannick, > Thank you for your patch, > > Acked-by: Philippe Cornu > Applied on drm-misc-next, Thanks, Benjamin > Philippe :-) > > On 11/27/19 11:23 AM, Yannick Fertre wrote: > > From: Yannick Fertré > > > > The pin control must be

Re: [Spice-devel] [PATCH 4/4] drm/qxl: add drm_driver.release callback.

2019-12-20 Thread Frediano Ziglio
> > Move final cleanups to qxl_drm_release() callback. Can you explain in the commit why this is better or preferable? > Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). I suppose this is to replace the former manual cleanup calls, which were moved to qxl_drm_release, I think this cou

[PATCH 2/4] drm/cirrus: add drm_driver.release callback.

2019-12-20 Thread Gerd Hoffmann
Move final cleanups from cirrus_pci_remove() to the new callback. Add drm_atomic_helper_shutdown() call to cirrus_pci_remove(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/cirrus/cirrus.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH 1/4] drm/bochs: add drm_driver.release callback.

2019-12-20 Thread Gerd Hoffmann
From: Gurchetan Singh Move bochs_unload call from bochs_remove() to the new bochs_release() callback. Also call drm_dev_unregister() first in bochs_remove(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_drv.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff

[PATCH 4/4] drm/qxl: add drm_driver.release callback.

2019-12-20 Thread Gerd Hoffmann
Move final cleanups to qxl_drm_release() callback. Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). Reorder calls in qxl_device_fini(). Cleaning up gem & ttm might trigger qxl commands, so we should do that before releaseing command rings. Signed-off-by: Gerd Hoffmann --- drivers/gpu

[PATCH 0/4] drm: add release callbacks to qemu drivers.

2019-12-20 Thread Gerd Hoffmann
Gerd Hoffmann (3): drm/cirrus: add drm_driver.release callback. drm/virtio: add drm_driver.release callback. drm/qxl: add drm_driver.release callback. Gurchetan Singh (1): drm/bochs: add drm_driver.release callback. drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + drivers/gpu/drm/bochs/bo

[PATCH 3/4] drm/virtio: add drm_driver.release callback.

2019-12-20 Thread Gerd Hoffmann
Split virtio_gpu_deinit(), move the drm shutdown and release to virtio_gpu_release(). Also free vbufs in case we can't queue them. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + drivers/gpu/drm/virtio/virtgpu_drv.c | 4 drivers/gpu/drm/virtio/virtgpu_kms.c | 5

[PATCH 12/15] drm/fb: Extend format_info member arrays to handle four planes

2019-12-20 Thread Imre Deak
From: Dhinakaran Pandiyan addfb() uAPI has supported four planes for a while now, make format_info compatible with that. Cc: Ville Syrjälä Cc: Matt Roper Cc: Mika Kahola Cc: dri-devel@lists.freedesktop.org Signed-off-by: Dhinakaran Pandiyan Signed-off-by: Imre Deak Reviewed-by: Mika Kahola

[PATCH 11/15] drm/framebuffer: Format modifier for Intel Gen-12 media compression

2019-12-20 Thread Imre Deak
From: Dhinakaran Pandiyan Gen-12 display can decompress surfaces compressed by the media engine, add a new modifier as the driver needs to know the surface was compressed by the media or render engine. v2: Update code comment describing the color plane order for YUV semiplanar formats. Cc:

[PATCH 14/15] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2019-12-20 Thread Imre Deak
From: Radhakrishna Sripada Gen12 display can decompress surfaces compressed by render engine with Clear Color, add a new modifier as the driver needs to know the surface was compressed by render engine. V2: Description changes as suggested by Rafael. V3: Mention the Clear Color size of 64 bits i

[PATCH 01/15] drm/framebuffer: Format modifier for Intel Gen-12 render compression

2019-12-20 Thread Imre Deak
From: Dhinakaran Pandiyan Gen-12 has a new compression format, add a new modifier to indicate that. Cc: Ville Syrjälä Cc: Matt Roper Cc: Nanley G Chery Cc: Jason Ekstrand Cc: Mika Kahola Cc: dri-devel@lists.freedesktop.org Signed-off-by: Dhinakaran Pandiyan Signed-off-by: Lucas De Marchi

Re: [1/5] drm/i915: Fix eDP DPCD aux max backlight calculations

2019-12-20 Thread Perr Yuan
On 11/22/19 6:15 PM, Lyude Paul wrote: Max backlight value for the panel was being calculated using byte count i.e. 0x if 2 bytes are supported for backlight brightness and 0xff if 1 byte is supported. However, EDP_PWMGEN_BIT_COUNT determines the number of active control bits used for the bri

Re: [PATCH 5/5] drm/msm/a6xx: Add support for using system cache(LLC)

2019-12-20 Thread smasetty
On 2019-12-20 01:28, Jordan Crouse wrote: On Thu, Dec 19, 2019 at 06:44:46PM +0530, Sharat Masetty wrote: The last level system cache can be partitioned to 32 different slices of which GPU has two slices preallocated. One slice is used for caching GPU buffers and the other slice is used for cac

Re: [PATCH v11 00/25] mm/gup: track dma-pinned pages: FOLL_PIN

2019-12-20 Thread Jan Kara
On Thu 19-12-19 12:30:31, John Hubbard wrote: > On 12/19/19 5:26 AM, Leon Romanovsky wrote: > > On Mon, Dec 16, 2019 at 02:25:12PM -0800, John Hubbard wrote: > > > Hi, > > > > > > This implements an API naming change (put_user_page*() --> > > > unpin_user_page*()), and also implements tracking of

Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-20 Thread Nicolas Boichat
On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra wrote: > > From: Jitao Shi > > This patch adds drm_bridge driver for parade DSI to eDP bridge chip. > > Signed-off-by: Jitao Shi > Reviewed-by: Daniel Kurtz > Reviewed-by: Enric Balletbo i Serra > [uli: followed API changes, removed FW upd

Re: [PATCH v5 0/7] drm/mediatek: fix cursor issue and apply CMDQ in MTK DRM

2019-12-20 Thread CK Hu
Hi, Bibby: For this series, applied to mediatek-drm-next-5.6 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-5.6 Regards, CK On Tue, 2019-12-10 at 13:05 +0800, Bibby Hsieh wrote: > The CMDQ (Command Queue) in MT8183 is used to help update all > relevan

Re: [PATCH v4 1/2] mm: Add a vmf_insert_mixed_prot() function

2019-12-20 Thread Michal Hocko
On Thu 12-12-19 09:47:40, Thomas Hellström (VMware) wrote: > From: Thomas Hellstrom > > The TTM module today uses a hack to be able to set a different page > protection than struct vm_area_struct::vm_page_prot. To be able to do > this properly, add the needed vm functionality as vmf_insert_mixed_

Ack to merge through DRM tree? WAS [PATCH v4 0/2] mm, drm/ttm: Fix pte insertion with customized protection

2019-12-20 Thread VMware
Andrew, On 12/12/19 9:47 AM, Thomas Hellström (VMware) wrote: From: Thomas Hellstrom The drm/ttm module is using a modified on-stack copy of the struct vm_area_struct to be able to set a page protection with customized caching. Fix that by adding a vmf_insert_mixed_prot() function similar to t