Re: [PATCH v6 1/4] dt-bindings: display: mediatek: add property to control mipi tx drive current

2020-04-18 Thread Chun-Kuang Hu
Hi, Rob: How do you think about this patch? This patch looks good to me. Regards, Chun-Kuang. Jitao Shi 於 2020年4月11日 週六 下午3:44寫道: > > Add a property to control mipi tx drive current: > "drive-strength-microamp" > > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Jitao Shi > --- >

Re: [PATCH v15 3/3] drm/mediatek: set dpi pin mode to gpio low to avoid leakage current

2020-04-18 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年4月15日 週三 上午9:13寫道: > > Config dpi pins mode to output and pull low when dpi is disabled. > Aovid leakage current from some dpi pins (Hsync Vsync DE ... ). Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v15 1/3] dt-bindings: display: mediatek: control dpi pins mode to avoid leakage

2020-04-18 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年4月15日 週三 上午9:13寫道: > > Add property "pinctrl-names" to swap pin mode between gpio and dpi mode. Set > the dpi pins to gpio mode and output-low to avoid leakage current when dpi > disabled. Applied to mediatek-drm-next [1], thanks. [1]

Re: [git pull] drm fixes for 5.7-rc2

2020-04-18 Thread pr-tracker-bot
The pull request you sent on Sat, 18 Apr 2020 14:24:32 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2020-04-18 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fecca68997833ef75f338fbbb76dd12fae7ca3b5 Thank you! -- Deet-doot-dot, I am a bot.

Re: [git pull] drm fixes for 5.7-rc2

2020-04-18 Thread Linus Torvalds
On Fri, Apr 17, 2020 at 9:24 PM Dave Airlie wrote: > > amdgpu: > - Fix a regression in a previous s/r fix Side note: if I hadn't been cc'd on the problem, I'd never have had a clue what s/r stood for. I'd have assumed that it's some special amdgpu term. And the language in the actual commit

[PATCH v2 7/9] PM: sleep: core: Rename DPM_FLAG_NEVER_SKIP

2020-04-18 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Rename DPM_FLAG_NEVER_SKIP to DPM_FLAG_NO_DIRECT_COMPLETE which matches its purpose more closely. No functional impact. Signed-off-by: Rafael J. Wysocki Acked-by: Bjorn Helgaas # for PCI parts Acked-by: Jeff Kirsher --- -> v2: * Rebased. * Added tags

Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref'

2020-04-18 Thread Jonathan Cameron
On Wed, 15 Apr 2020 19:55:49 -0500 Rob Herring wrote: > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref' under an 'allOf'. This behavior is now changed > in the 2019-09

Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

2020-04-18 Thread Jonathan Cameron
On Wed, 15 Apr 2020 19:55:48 -0500 Rob Herring wrote: > Fix various inconsistencies in schema indentation. Most of these are > list indentation which should be 2 spaces more than the start of the > enclosing keyword. This doesn't matter functionally, but affects running > scripts which do

Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers

2020-04-18 Thread Jonathan Cameron
On Thu, 16 Apr 2020 12:49:03 +0300 Hadar Gat wrote: > Both of_platform.h and of_device.h were included each other. > In of_device.h, removed unneeded #include to of_platform.h > and added include to of_platform.h in the files that needs it. > > Signed-off-by: Hadar Gat Hmm. I guess the

Re: [PATCH trivial 4/6] iio: Fix misspellings of "Analog Devices"

2020-04-18 Thread Jonathan Cameron
On Thu, 16 Apr 2020 12:30:56 +0200 Geert Uytterhoeven wrote: > According to https://www.analog.com/, the company name is spelled > "Analog Devices". > > Signed-off-by: Geert Uytterhoeven Applied to the togreg branch of iio.git and pushed out as testing as there are other things in that tree

[PATCH AUTOSEL 4.14 17/28] drm/amdkfd: kfree the wrong pointer

2020-04-18 Thread Sasha Levin
From: Jack Zhang [ Upstream commit 3148a6a0ef3cf93570f30a477292768f7eb5d3c3 ] Originally, it kfrees the wrong pointer for mem_obj. It would cause memory leak under stress test. Signed-off-by: Jack Zhang Acked-by: Nirmoy Das Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 4.19 40/47] drm/amd/display: Not doing optimize bandwidth if flip pending.

2020-04-18 Thread Sasha Levin
From: Yongqiang Sun [ Upstream commit 9941b8129030c9202aaf39114477a0e58c0d6ffc ] [Why] In some scenario like 1366x768 VSR enabled connected with a 4K monitor and playing 4K video in clone mode, underflow will be observed due to decrease dppclk when previouse surface scan isn't finished [How]

[PATCH AUTOSEL 4.19 26/47] drm/vc4: Fix HDMI mode validation

2020-04-18 Thread Sasha Levin
From: Nicolas Saenz Julienne [ Upstream commit b1e7396a1d0e6af6806337fdaaa44098d6b3343c ] Current mode validation impedes setting up some video modes which should be supported otherwise. Namely 1920x1200@60Hz. Fix this by lowering the minimum HDMI state machine clock to pixel clock ratio

[PATCH AUTOSEL 4.19 23/47] drm/amdkfd: kfree the wrong pointer

2020-04-18 Thread Sasha Levin
From: Jack Zhang [ Upstream commit 3148a6a0ef3cf93570f30a477292768f7eb5d3c3 ] Originally, it kfrees the wrong pointer for mem_obj. It would cause memory leak under stress test. Signed-off-by: Jack Zhang Acked-by: Nirmoy Das Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.4 41/78] drm/vc4: Fix HDMI mode validation

2020-04-18 Thread Sasha Levin
From: Nicolas Saenz Julienne [ Upstream commit b1e7396a1d0e6af6806337fdaaa44098d6b3343c ] Current mode validation impedes setting up some video modes which should be supported otherwise. Namely 1920x1200@60Hz. Fix this by lowering the minimum HDMI state machine clock to pixel clock ratio

[PATCH AUTOSEL 5.4 52/78] drm/amd/display: Calculate scaling ratios on every medium/full update

2020-04-18 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit 3bae20137cae6c03f58f96c0bc9f3d46f0bc17d4 ] [Why] If a plane isn't being actively enabled or disabled then DC won't always recalculate scaling rects and ratios for the primary plane. This results in only a partial or corrupted rect being displayed on

[PATCH AUTOSEL 5.4 30/78] drm/nouveau: workaround runpm fail by disabling PCI power management on certain intel bridges

2020-04-18 Thread Sasha Levin
From: Karol Herbst [ Upstream commit 434fdb51513bf3057ac144d152e6f2f2b509e857 ] Fixes the infamous 'runtime PM' bug many users are facing on Laptops with Nvidia Pascal GPUs by skipping said PCI power state changes on the GPU. Depending on the used kernel there might be messages like those in

[PATCH AUTOSEL 5.4 64/78] drm/amd/display: Not doing optimize bandwidth if flip pending.

2020-04-18 Thread Sasha Levin
From: Yongqiang Sun [ Upstream commit 9941b8129030c9202aaf39114477a0e58c0d6ffc ] [Why] In some scenario like 1366x768 VSR enabled connected with a 4K monitor and playing 4K video in clone mode, underflow will be observed due to decrease dppclk when previouse surface scan isn't finished [How]

[PATCH AUTOSEL 5.4 37/78] drm/amdkfd: kfree the wrong pointer

2020-04-18 Thread Sasha Levin
From: Jack Zhang [ Upstream commit 3148a6a0ef3cf93570f30a477292768f7eb5d3c3 ] Originally, it kfrees the wrong pointer for mem_obj. It would cause memory leak under stress test. Signed-off-by: Jack Zhang Acked-by: Nirmoy Das Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.4 21/78] drm/amd/display: Update stream adjust in dc_stream_adjust_vmin_vmax

2020-04-18 Thread Sasha Levin
From: Isabel Zhang [ Upstream commit 346d8a0a3c91888a412c2735d69daa09c00f0203 ] [Why] After v_total_min and max are updated in vrr structure, the changes are not reflected in stream adjust. When these values are read from stream adjust it does not reflect the actual state of the system. [How]

[PATCH AUTOSEL 5.5 69/75] drm/amd/display: Not doing optimize bandwidth if flip pending.

2020-04-18 Thread Sasha Levin
From: Yongqiang Sun [ Upstream commit 9941b8129030c9202aaf39114477a0e58c0d6ffc ] [Why] In some scenario like 1366x768 VSR enabled connected with a 4K monitor and playing 4K video in clone mode, underflow will be observed due to decrease dppclk when previouse surface scan isn't finished [How]

[PATCH AUTOSEL 5.5 22/75] drm/amd/display: Update stream adjust in dc_stream_adjust_vmin_vmax

2020-04-18 Thread Sasha Levin
From: Isabel Zhang [ Upstream commit 346d8a0a3c91888a412c2735d69daa09c00f0203 ] [Why] After v_total_min and max are updated in vrr structure, the changes are not reflected in stream adjust. When these values are read from stream adjust it does not reflect the actual state of the system. [How]

[PATCH AUTOSEL 5.5 39/75] drm/amdkfd: kfree the wrong pointer

2020-04-18 Thread Sasha Levin
From: Jack Zhang [ Upstream commit 3148a6a0ef3cf93570f30a477292768f7eb5d3c3 ] Originally, it kfrees the wrong pointer for mem_obj. It would cause memory leak under stress test. Signed-off-by: Jack Zhang Acked-by: Nirmoy Das Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.5 57/75] drm/amd/display: Calculate scaling ratios on every medium/full update

2020-04-18 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit 3bae20137cae6c03f58f96c0bc9f3d46f0bc17d4 ] [Why] If a plane isn't being actively enabled or disabled then DC won't always recalculate scaling rects and ratios for the primary plane. This results in only a partial or corrupted rect being displayed on

[PATCH AUTOSEL 5.5 32/75] drm/nouveau: workaround runpm fail by disabling PCI power management on certain intel bridges

2020-04-18 Thread Sasha Levin
From: Karol Herbst [ Upstream commit 434fdb51513bf3057ac144d152e6f2f2b509e857 ] Fixes the infamous 'runtime PM' bug many users are facing on Laptops with Nvidia Pascal GPUs by skipping said PCI power state changes on the GPU. Depending on the used kernel there might be messages like those in

[PATCH AUTOSEL 5.5 44/75] drm/vc4: Fix HDMI mode validation

2020-04-18 Thread Sasha Levin
From: Nicolas Saenz Julienne [ Upstream commit b1e7396a1d0e6af6806337fdaaa44098d6b3343c ] Current mode validation impedes setting up some video modes which should be supported otherwise. Namely 1920x1200@60Hz. Fix this by lowering the minimum HDMI state machine clock to pixel clock ratio

[PATCH AUTOSEL 5.6 61/73] drm/amd/display: Calculate scaling ratios on every medium/full update

2020-04-18 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit 3bae20137cae6c03f58f96c0bc9f3d46f0bc17d4 ] [Why] If a plane isn't being actively enabled or disabled then DC won't always recalculate scaling rects and ratios for the primary plane. This results in only a partial or corrupted rect being displayed on

[PATCH AUTOSEL 5.6 47/73] drm/vc4: Fix HDMI mode validation

2020-04-18 Thread Sasha Levin
From: Nicolas Saenz Julienne [ Upstream commit b1e7396a1d0e6af6806337fdaaa44098d6b3343c ] Current mode validation impedes setting up some video modes which should be supported otherwise. Namely 1920x1200@60Hz. Fix this by lowering the minimum HDMI state machine clock to pixel clock ratio

[PATCH AUTOSEL 5.6 34/73] drm/nouveau: workaround runpm fail by disabling PCI power management on certain intel bridges

2020-04-18 Thread Sasha Levin
From: Karol Herbst [ Upstream commit 434fdb51513bf3057ac144d152e6f2f2b509e857 ] Fixes the infamous 'runtime PM' bug many users are facing on Laptops with Nvidia Pascal GPUs by skipping said PCI power state changes on the GPU. Depending on the used kernel there might be messages like those in

[PATCH AUTOSEL 5.6 41/73] drm/amdkfd: kfree the wrong pointer

2020-04-18 Thread Sasha Levin
From: Jack Zhang [ Upstream commit 3148a6a0ef3cf93570f30a477292768f7eb5d3c3 ] Originally, it kfrees the wrong pointer for mem_obj. It would cause memory leak under stress test. Signed-off-by: Jack Zhang Acked-by: Nirmoy Das Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.6 24/73] drm/amd/display: Update stream adjust in dc_stream_adjust_vmin_vmax

2020-04-18 Thread Sasha Levin
From: Isabel Zhang [ Upstream commit 346d8a0a3c91888a412c2735d69daa09c00f0203 ] [Why] After v_total_min and max are updated in vrr structure, the changes are not reflected in stream adjust. When these values are read from stream adjust it does not reflect the actual state of the system. [How]

[Bug 206987] [drm] [amdgpu] Whole system crashes when the driver is in mode_support_and_system_configuration

2020-04-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206987 --- Comment #6 from Cyrax (ev...@hotmail.com) --- Created attachment 288595 --> https://bugzilla.kernel.org/attachment.cgi?id=288595=edit dmesg output And another one. It seems that switching between virtual consoles causes this bug to happen

[Bug 206987] [drm] [amdgpu] Whole system crashes when the driver is in mode_support_and_system_configuration

2020-04-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206987 Cyrax (ev...@hotmail.com) changed: What|Removed |Added Kernel Version|5.5.13 |5.6.4 -- You are receiving

[Bug 207331] commit "drm/amdgpu: fix gfx hang during suspend with video playback" breaks reboot/shutdown

2020-04-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207331 --- Comment #3 from Grzegorz Kowal (custos.men...@gmail.com) --- Thanks! I applied the patch and the problem is gone. Both reboot and shutdown work again. -- You are receiving this mail because: You are watching the assignee of the bug.

Re: BUG: kernel NULL pointer dereference, address: 0000000000000026 after switching to 5.7 kernel

2020-04-18 Thread Mikhail Gavrilov
On Sat, 11 Apr 2020 at 14:56, Christian König wrote: > > Yeah, that is a known issue. > > You could try the attached patch, but please be aware that it is not > even compile tested because of the Easter holidays here. > Looks good to me, so it's pity that this patch did not exist in the pull

Re: [PATCH 1/8] fbdev: w100fb: clean up mach-pxa compile-time dependency

2020-04-18 Thread Arnd Bergmann
On Sat, Apr 18, 2020 at 12:11 PM Robert Jarzmik wrote: > > Arnd Bergmann writes: > > Hi Arnd, > > > diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig > > index f60bc29aef68..8444d40df1b3 100644 > > --- a/arch/arm/mach-pxa/Kconfig > > +++ b/arch/arm/mach-pxa/Kconfig > > @@ -549,9

[PATCH] amdgpu_connector_set_property, fix error branch not return errno

2020-04-18 Thread Bernard Zhao
The "if(!encoder)" branch return the same value 0 of the success branch, maybe return -EINVAL is more better. Signed-off-by: Bernard Zhao w --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH] drm/etnaviv: Omit superfluous error message in etnaviv_gpu_platform_probe()

2020-04-18 Thread Tang Bin
In the function etnaviv_gpu_platform_probe(), when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Signed-off-by: Tang Bin --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v3 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-04-18 Thread Enric Balletbo i Serra
Convert mtk_dsi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - Add the bridge.type. (Laurent Pinchart) Changes in v2: None drivers/gpu/drm/mediatek/mtk_dsi.c | 93

[PATCH v4 1/3] drm/tegra: output: Don't leak OF node on error

2020-04-18 Thread Dmitry Osipenko
The OF node should be put before returning error in tegra_output_probe(), otherwise node's refcount will be leaked. Reviewed-by: Laurent Pinchart Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/output.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[PATCH v4 3/3] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-18 Thread Dmitry Osipenko
Newer Tegra device-trees will specify a video output graph, which involves LVDS encoder bridge. This patch adds support for the LVDS encoder bridge to the RGB output, allowing us to model the display hardware properly. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/rgb.c | 58

Re: [PATCH v4 3/3] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-18 Thread Dmitry Osipenko
17.04.2020 22:24, Laurent Pinchart пишет: ... > As I tried to explain before, if you wrap the panel in a bridge with > drm_panel_bridge_add() (or the devm_ variant), you will always have a > bridge associated with the output, and will be able to remove your > custom connector implementation. I

[PATCH v3 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API

2020-04-18 Thread Enric Balletbo i Serra
Replace the manual panel handling code by a drm_panel_bridge. This simplifies the driver and allows all components in the display pipeline to be treated as bridges, paving the way to generic connector handling. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart --- Changes in

[PATCH 1/1] drm/qxl: add mutex_lock/mutex_unlock to ensure the order in which resources are released.

2020-04-18 Thread Caicai
When a qxl resource is released, the list that needs to be released is fetched from the linked list ring and cleared. When you empty the list, instead of trying to determine whether the ttm buffer object for each qxl in the list is locked, you release the qxl object and remove the element from the

Re: [PATCH v4 2/3] drm/tegra: output: Support DRM bridges

2020-04-18 Thread Dmitry Osipenko
Hello Laurent, 17.04.2020 22:30, Laurent Pinchart пишет: ... >> #include >> +#include > > You could add a forward declaration of struct drm_bridge instead, that > can lower the compilation time a little bit. This include is not only for the struct, but also for the drm_bridge_attach(). It

[PATCH] amdgpu_amdkfd_gpuvm_free_memory_of_gpu, reduce noneed mutex_lock area

2020-04-18 Thread Bernard Zhao
Maybe we could reduce the mutex_lock(>lock)`s protected code area, and noneed to protect pr_debug. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH v3 1/7] drm/bridge: ps8640: Get the EDID from eDP control

2020-04-18 Thread Enric Balletbo i Serra
The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the .get_edid callback and set the flag to indicate the core to use it. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart --- Changes in v3: None Changes in v2: None drivers/gpu/drm/bridge/parade-ps8640.c | 12

[PATCH v3 2/7] drm/bridge_connector: Set default status connected for eDP connectors

2020-04-18 Thread Enric Balletbo i Serra
In an eDP application, HPD is not required and on most bridge chips useless. If HPD is not used, we need to set initial status as connected, otherwise the connector created by the drm_bridge_connector API remains in an unknown state. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent

Re: [PATCH v4 2/3] drm/tegra: output: Support DRM bridges

2020-04-18 Thread Dmitry Osipenko
17.04.2020 23:31, Laurent Pinchart пишет: > Hi Dmitry, > > On Fri, Apr 17, 2020 at 10:41:59PM +0300, Dmitry Osipenko wrote: >> 17.04.2020 22:30, Laurent Pinchart пишет: >> ... #include +#include >>> >>> You could add a forward declaration of struct drm_bridge instead, that >>> can

Re: [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional!

2020-04-18 Thread H. Nikolaus Schaller
Hi Laurent, > Am 17.04.2020 um 14:58 schrieb Laurent Pinchart > : > > Hello, > > On Fri, Apr 17, 2020 at 02:44:22PM +0200, Maxime Ripard wrote: >> On Fri, Apr 17, 2020 at 02:18:11PM +0200, H. Nikolaus Schaller wrote: >>> Hi Maxime, >>> I have started to test v5.7-rc1 and can't fully boot the

[PATCH v3 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-04-18 Thread Enric Balletbo i Serra
Use the drm_bridge_connector helper to create a connector for pipelines that use drm_bridge. This allows splitting connector operations across multiple bridges when necessary, instead of having the last bridge in the chain creating the connector and handling all connector operations internally.

[PATCH] reserve_bo_and_cond_vms: Remove unnecessary condition check

2020-04-18 Thread Bernard Zhao
There is no need to if check again, maybe we could merge into the above else branch. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c

Re: [PATCH v2 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge

2020-04-18 Thread Enric Balletbo i Serra
Hi Laurent, On 16/4/20 19:24, Laurent Pinchart wrote: > Hi Enric, > > Thank you for the patch. > > On Thu, Apr 16, 2020 at 05:57:15PM +0200, Enric Balletbo i Serra wrote: >> This is really a cosmetic change just to make a bit more readable the >> code after convert the driver to drm_bridge. The

[PATCH -next] drm/gma500: remove unused variable 'hdmi_ids'

2020-04-18 Thread YueHaibing
drivers/gpu/drm/gma500/oaktrail_hdmi.c:676:35: warning: ‘hdmi_ids’ defined but not used [-Wunused-const-variable=] static const struct pci_device_id hdmi_ids[] = { ^~~~ It is never used, remove it. Reported-by: Hulk Robot Signed-off-by: YueHaibing ---

[PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-04-18 Thread Kalyan Thota
"The PM core always increments the runtime usage counter before calling the ->suspend() callback and decrements it after calling the ->resume() callback" DPU and DSI are managed as runtime devices. When suspend is triggered, PM core adds a refcount on all the devices and calls device suspend,

[PATCH v3 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-04-18 Thread Enric Balletbo i Serra
The PS8640 dsi-to-eDP bridge driver is using the panel bridge API, however, not all the components in the chain have been ported to the drm_bridge API. Actually, when a panel is attached the default panel's mode is used, but in some cases we can't get display up if mode getting from eDP control

[PATCH] video: fbdev: aty128fb: remove unused 'sdr_64'

2020-04-18 Thread Jason Yan
Fix the following gcc warning: drivers/video/fbdev/aty/aty128fb.c:337:36: warning: ‘sdr_64’ defined but not used [-Wunused-const-variable=] static const struct aty128_meminfo sdr_64 = { ^~ Reported-by: Hulk Robot Signed-off-by: Jason Yan ---

[drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional!

2020-04-18 Thread H . Nikolaus Schaller
Hi Maxime, I have started to test v5.7-rc1 and can't fully boot the GTA04 device any more. What I see in the log is: [ 28.567840] [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional! [ 28.567871] omapdrm omapdrm.0: unable to attach bridge

[PATCH] drm/v3d: remove unused 'v3d_v3d_pm_ops '

2020-04-18 Thread Jason Yan
Fix the following gcc warning: drivers/gpu/drm/v3d/v3d_drv.c:73:32: warning: ‘v3d_v3d_pm_ops’ defined but not used [-Wunused-const-variable=] static const struct dev_pm_ops v3d_v3d_pm_ops = { ^~ Reported-by: Hulk Robot Signed-off-by: Jason Yan ---

[PATCH] drm/amd/powerplay: remove defined but not used variables

2020-04-18 Thread Jason Yan
Fix the following gcc warning: drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:710:46: warning: ‘PSMGCEDCThresholdConfig_vega10’ defined but not used [-Wunused-const-variable=] static const struct vega10_didt_config_reg PSMGCEDCThresholdConfig_vega10[] =

Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

2020-04-18 Thread H. Nikolaus Schaller
Hi Maxime, > Am 17.04.2020 um 12:25 schrieb Maxime Ripard : > > Hi, > > On Wed, Apr 15, 2020 at 06:42:18PM +0200, H. Nikolaus Schaller wrote: >>> Am 15.04.2020 um 18:21 schrieb Maxime Ripard : >>> >>> On Wed, Apr 15, 2020 at 05:09:45PM +0200, H. Nikolaus Schaller wrote: Hi Maxime,

Re: Multiple regulators for one device [was drm/panfrost: add devfreq regulator support]

2020-04-18 Thread Clément Péron
Hi Robin, On Fri, 17 Apr 2020 at 13:10, Robin Murphy wrote: > > On 2020-04-16 2:42 pm, Steven Price wrote: > [...] > > Perhaps a better approach would be for Panfrost to hand over the struct > > regulator objects it has already got to the OPP framework. I.e. open > > code

Re: [PATCH v4 3/3] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-18 Thread Dmitry Osipenko
17.04.2020 23:34, Laurent Pinchart пишет: > On Fri, Apr 17, 2020 at 11:11:06PM +0300, Dmitry Osipenko wrote: >> 17.04.2020 22:24, Laurent Pinchart пишет: >> ... >>> As I tried to explain before, if you wrap the panel in a bridge with >>> drm_panel_bridge_add() (or the devm_ variant), you will

[PATCH v3 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge

2020-04-18 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent

Re: [PATCH 0/8] drm, fbdev: rework dependencies

2020-04-18 Thread Jason Gunthorpe
On Fri, Apr 17, 2020 at 07:14:53PM +0200, Daniel Vetter wrote: > On Fri, Apr 17, 2020 at 05:55:45PM +0200, Arnd Bergmann wrote: > > I tried to fix up some dependencies after the sii8620 "imply EXTCON" > > statementn broke, trying a few things but in the backing out a > > change that would

Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

2020-04-18 Thread Maxime Ripard
Hi, On Wed, Apr 15, 2020 at 06:42:18PM +0200, H. Nikolaus Schaller wrote: > > Am 15.04.2020 um 18:21 schrieb Maxime Ripard : > > > > On Wed, Apr 15, 2020 at 05:09:45PM +0200, H. Nikolaus Schaller wrote: > >> Hi Maxime, > >> > >> Hm. Yes. We know that there likely are clocks and maybe reset > >>

[PATCH] backlight: qcom-wled: remove 'wled4_string_cfg' and 'wled3_string_cfg'

2020-04-18 Thread Jason Yan
Fix the following gcc warning: drivers/video/backlight/qcom-wled.c:939:34: warning: ‘wled4_string_cfg’ defined but not used [-Wunused-const-variable=] static const struct wled_var_cfg wled4_string_cfg = { ^~~~

Re: [PATCH V5 3/4] backlight: qcom-wled: Add WLED5 bindings

2020-04-18 Thread kgunda
On 2020-04-15 20:42, Rob Herring wrote: On Tue, Apr 07, 2020 at 09:17:09PM +0530, Kiran Gunda wrote: Add WLED5 specific bindings. checkpatch.pl complains about some trailing whitespace. The previous patch too. Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy ---

Re: [PATCH v2 1/7] drm/bridge: ps8640: Get the EDID from eDP control

2020-04-18 Thread Enric Balletbo i Serra
Hi Laurent, On 16/4/20 19:22, Laurent Pinchart wrote: > Hi Enric, > > Thank you for the patch. > > On Thu, Apr 16, 2020 at 05:57:13PM +0200, Enric Balletbo i Serra wrote: >> The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the >> .get_edid callback and set the flag to indicate

[PATCH -next] drm/amd/dc: remove unused variable 'video_optimized_pixel_rates'

2020-04-18 Thread YueHaibing
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:1017:50: warning: ‘video_optimized_pixel_rates’ defined but not used [-Wunused-const-variable=] static const struct pixel_rate_range_table_entry video_optimized_pixel_rates[] = {

[PATCH v4 2/3] drm/tegra: output: Support DRM bridges

2020-04-18 Thread Dmitry Osipenko
Newer Tegra device-trees will specify a video output graph which involves a bridge. This patch adds initial support for the DRM bridges to the Tegra's DRM output. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/drm.h| 2 ++ drivers/gpu/drm/tegra/output.c | 13 - 2

Re: [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional!

2020-04-18 Thread Maxime Ripard
Hi, Cc'ing Laurent On Fri, Apr 17, 2020 at 02:18:11PM +0200, H. Nikolaus Schaller wrote: > Hi Maxime, > I have started to test v5.7-rc1 and can't fully boot the GTA04 > device any more. > > What I see in the log is: > > [ 28.567840] [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix

Re: [PATCH V5 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format

2020-04-18 Thread kgunda
On 2020-04-15 20:39, Rob Herring wrote: On Tue, Apr 07, 2020 at 09:17:07PM +0530, Kiran Gunda wrote: Convert the qcom-wled bindings from .txt to .yaml format. Also replace PM8941 to WLED3 and PMI8998 to WLED4. Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy Acked-by:

[PATCH] backlight: lms501kf03: remove unused 'seq_sleep_in' and 'seq_up_dn'

2020-04-18 Thread Jason Yan
Fix the following gcc warning: drivers/video/backlight/lms501kf03.c:96:28: warning: ‘seq_sleep_in’ defined but not used [-Wunused-const-variable=] static const unsigned char seq_sleep_in[] = { ^~~~ drivers/video/backlight/lms501kf03.c:92:28: warning:

Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

2020-04-18 Thread H . Nikolaus Schaller
Hi Rob, > Am 16.04.2020 um 22:41 schrieb Rob Herring : > > On Wed, 15 Apr 2020 10:35:08 +0200, "H. Nikolaus Schaller" wrote: >> The Imagination PVR/SGX GPU is part of several SoC from >> multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo, >> Allwinner A83 and others. >> >> With this

[PATCH v3 5/7] drm/mediatek: mtk_dsi: Use simple encoder

2020-04-18 Thread Enric Balletbo i Serra
The mtk_dsi driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart --- Changes in v3: None Changes in v2: None drivers/gpu/drm/mediatek/mtk_dsi.c | 14 +++--- 1 file

[PATCH v4 0/3] Support DRM bridges on NVIDIA Tegra

2020-04-18 Thread Dmitry Osipenko
Hello, This small series adds initial support for the DRM bridges to NVIDIA Tegra DRM driver. This is required by newer device-trees where we model the LVDS encoder bridge properly. Changelog: v4: - Following review comments that were made by Laurent Pinchart to the v3, we now create and

Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node

2020-04-18 Thread H. Nikolaus Schaller
Hi Jonathan, > Am 15.04.2020 um 20:17 schrieb Jonathan Bakker : > > Hi Nikolaus, > > On 2020-04-15 5:50 a.m., H. Nikolaus Schaller wrote: >> >>> Am 15.04.2020 um 13:49 schrieb Krzysztof Kozlowski : >>> >>> On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller >>> wrote: From:

[PATCH -next] drm/panel: remove set but not used variable 'config'

2020-04-18 Thread YueHaibing
drivers/gpu/drm/panel/panel-truly-nt35597.c:493:31: warning: variable ‘config’ set but not used [-Wunused-but-set-variable] const struct nt35597_config *config; ^~ Signed-off-by: YueHaibing --- drivers/gpu/drm/panel/panel-truly-nt35597.c | 2 -- 1 file

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-18 Thread Philipp Rossak
Hi all, On 15.04.20 15:04, H. Nikolaus Schaller wrote: Am 15.04.2020 um 15:02 schrieb Maxime Ripard : On Wed, Apr 15, 2020 at 02:41:52PM +0200, H. Nikolaus Schaller wrote: The kernel modules built from this project have successfully demonstrated to work with the DTS definitions from this

Re: [PATCH v2 05/17] drm/msm/dpu: Use OPP API to set clk/perf state

2020-04-18 Thread Rajendra Nayak
On 4/17/2020 11:47 PM, Matthias Kaehlcke wrote: Hi Rajendra, I have essentially the same comments as for "tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state" (https://patchwork.kernel.org/patch/11495209/). about error handling of 'dev_pm_opp_of_add_table' and misleading struct

Re: [PATCH][next] drm/i915: remove redundant assignment to variable test_result

2020-04-18 Thread Chris Wilson
Quoting Colin King (2020-04-17 17:08:29) > From: Colin Ian King > > The variable test_result is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value") >