Re: [PATCH] drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show

2020-04-28 Thread Chris Wilson
Quoting Nathan Chancellor (2020-04-29 04:00:52) > When building with clang + -Wuninitialized: > > drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:407:7: warning: variable > 'rpcurupei' is uninitialized when used here [-Wuninitialized] >rpcurupei, >^~

Re: [PATCH 2/8] dt-bindings: intc: Convert ingenic,intc.txt to YAML

2020-04-28 Thread Paul Cercueil
Hi Sergei, Le lun. 27 avril 2020 à 12:11, Sergei Shtylyov a écrit : Hello! On 26.04.2020 21:58, Paul Cercueil wrote: Convert the ingenic,intc.txt doc file to ingenic,intc.yaml. Some compatible strings now require a fallback, as the controller generally works the same across the SoCs famili

Re: [PATCH v2 91/91] ARM: dts: bcm2711: Enable the display pipeline

2020-04-28 Thread Maxime Ripard
Hi Stefan, On Sat, Apr 25, 2020 at 10:54:22PM +0200, Stefan Wahren wrote: > Hi Maxime, > > Am 24.04.20 um 17:35 schrieb Maxime Ripard: > > Now that all the drivers have been adjusted for it, let's bring in the > > necessary device tree changes. > > > > Signed-off-by: Maxime Ripard > > --- > > a

Re: [PATCH] drm/mcde: dsi: Fix a return value check in mcde_dsi_bind()

2020-04-28 Thread Markus Elfring
> In case of error, the function of_drm_find_bridge() returns NULL pointer > not ERR_PTR(). Such information is helpful. > The IS_ERR() test in the return value check should be > replaced with NULL test. * Would you like to convert this description into an imperative wording? * Please fix the

[PATCH -next] drm/mcde: dsi: Fix return value check in dev_err()

2020-04-28 Thread Wei Yongjun
In case of error, the function of_drm_find_bridge() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/mcde/mcde_dsi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff

Re: [PATCH v2 1/2] dt-bindings: display: simple: Add IVO M133NWF4 R0

2020-04-28 Thread Bjorn Andersson
On Tue 28 Apr 10:05 PDT 2020, Sam Ravnborg wrote: > Hi Rob. > > On Tue, Apr 28, 2020 at 09:27:51AM -0500, Rob Herring wrote: > > On Sat, Apr 25, 2020 at 12:58 PM Sam Ravnborg wrote: > > > > > > Hi Björn. > > > > > > On Mon, Apr 20, 2020 at 02:57:27PM -0700, Bjorn Andersson wrote: > > > > Define

[PATCH] drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show

2020-04-28 Thread Nathan Chancellor
When building with clang + -Wuninitialized: drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:407:7: warning: variable 'rpcurupei' is uninitialized when used here [-Wuninitialized] rpcurupei, ^ drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:304:16: note

Re: [PATCH 1/1] drm/qxl: add mutex_lock/mutex_unlock to ensure the order in which resources are rele

2020-04-28 Thread Vasily Averin
On 4/21/20 11:43 AM, Gerd Hoffmann wrote: > On Sat, Apr 18, 2020 at 02:39:17PM +0800, Caicai wrote: >> When a qxl resource is released, the list that needs to be released is >> fetched from the linked list ring and cleared. When you empty the list, >> instead of trying to determine whether the t

Re: [PATCH v2] drm/meson: add mode selection limits against specific SoC revisions

2020-04-28 Thread Martin Blumenstingl
Hi Neil, On Tue, Apr 28, 2020 at 11:21 AM Neil Armstrong wrote: > > The Amlogic S805X/Y uses the same die as the S905X, but with more > limited graphics capabilities. > > This adds a soc version detection adding specific limitations on the HDMI > mode selections. > > Here, we limit to HDMI 1.3a m

Re: Msg "PM: pci_pm_suspend(): ast_pm_suspend+0x0/0x40 [ast] returns -22" after migrating to V5.6.7 kernel from v5.5.10.

2020-04-28 Thread Cary Garrett
Hello Dave, Generating & booting v5.5.19 kernel, system will successfully enter suspend state. Generating & booting v5.6.0 kernel, system fails to enter suspend state. v5.5.19 "lspci - -s 00:04:00" output: 04:00.0 VGA compatible controller: ASPEED Technology, Inc. ASPEED Graphics Family

[PATCH] video: fbdev: pxa3xx_gcu: Fix some resource leak in an error handling path in 'pxa3xx_gcu_probe()'

2020-04-28 Thread Christophe JAILLET
If an error occurs in the loop where we call 'pxa3xx_gcu_add_buffer()', any resource already allocated should be freed. In order to fix it, add a call to 'pxa3xx_gcu_free_buffers()' in the error handling path, as already done in the remove function. Fixes: 364dbdf3b6c3 ("video: add driver for PXA

Re: [PATCH v2 04/91] firmware: rpi: Only create clocks device if we don't have a node for it

2020-04-28 Thread Maxime Ripard
Hi Nicolas, On Mon, Apr 27, 2020 at 01:24:14PM +0200, Nicolas Saenz Julienne wrote: > Hi Maxime, > > On Fri, 2020-04-24 at 17:33 +0200, Maxime Ripard wrote: > > The firmware clocks driver was previously probed through a platform_device > > created by the firmware driver. > > > > Since we will no

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

2020-04-28 Thread Maxime Ripard
Hi, On Mon, Apr 27, 2020 at 03:23:42PM +0800, Jian-Hong Pan wrote: > Hi Maxime, > > Thanks for your V2 patch series! I'm testing it. > > This patch series is applied upon mainline kernel 5.7-rc2 cleanly and built. > System can boot into console text mode, but no graphic UI. > > Get the error i

Re: [PATCH v2 79/91] drm/vc4: hdmi: Deal with multiple debugfs files

2020-04-28 Thread Maxime Ripard
Hi Stefan, On Sat, Apr 25, 2020 at 11:26:31PM +0200, Stefan Wahren wrote: > Am 24.04.20 um 17:35 schrieb Maxime Ripard: > > The HDMI driver was registering a single debugfs file so far with the name > > hdmi_regs. > > > > Obviously, this is not going to work anymore when will have multiple HDMI >

Re: [PATCH] drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume __maybe_unused

2020-04-28 Thread Enric Balletbo i Serra
Hi Arnd, On 28/4/20 23:31, Arnd Bergmann wrote: > With the new static annotation, the compiler warns when the functions > are actually unused: > Right, thank you for the patch. > drivers/gpu/drm/rockchip/cdn-dp-core.c:1123:12: error: 'cdn_dp_resume' > defined but not used [-Werror=unused-funct

Re: [PATCH v7 08/12] arm: dts: s5pv210: Add node for SGX 540

2020-04-28 Thread Jonathan Bakker
Hi all, On 2020-04-28 2:39 p.m., Jonathan Bakker wrote: > Hi Krzysztof, > > On 2020-04-27 8:46 a.m., Krzysztof Kozlowski wrote: >> On Sun, Apr 26, 2020 at 07:57:12AM -0700, Jonathan Bakker wrote: >>> Hi Paul, >>> >>> On 2020-04-26 5:56 a.m., Paul Cercueil wrote: Le ven. 24 avril 20

[PATCH 1/1] drm/mm: optimize rb_hole_addr rbtree search in high addr mode

2020-04-28 Thread Nirmoy Das
Userspace can severely fragment rb_hole_addr rbtree by manipulating alignment while allocating buffers. Fragmented rb_hole_addr rbtree would result in large delays while allocating buffer object for a userspace application. It takes long time to find suitable hole because if we fail to find a suita

[PATCH] drm/meson: pm resume add return errno branch

2020-04-28 Thread Bernard Zhao
pm_resump api did not handle drm_mode_config_helper_resume error. This change add handle to return drm_mode_config_helper_resume`s error number. This code logic is aligned with api pm_suspend. After this change, the code maybe a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/meson

[PATCH v12 0/2] Add support for rm69299 Visionox panel driver and add devicetree bindings for visionox panel

2020-04-28 Thread Harigovindan P
Adding support for visionox rm69299 panel driver and adding bindings for the same panel. https://patchwork.kernel.org/patch/11461943/ has already been added to drm-misc-next. Harigovindan P (2): drm/panel: add support for rm69299 visionox panel driver dt-bindings: documenting compatible stri

[PATCH -next] drm/rcar-du: Fix return value check in rcar_du_cmm_init()

2020-04-28 Thread Wei Yongjun
In case of error, the function of_parse_phandle()/of_find_device_by_node() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test Fixes: 8de707aeb452 ("drm: rcar-du: kms: Initialize CMM instances") Signed-off-by: Wei Yongjun --- drivers/

[PATCH v12 2/2] dt-bindings: documenting compatible string vendor "visionox"

2020-04-28 Thread Harigovindan P
Documenting compatible string vendor "visionox" in vendor-prefix yaml file. Signed-off-by: Harigovindan P --- Changes in v11: - Added compatible string in vendor-prefix yaml file Changes in v12: - Fixed the string to clear dt_binding_check errors. Documentation/devicetree/bindi

Re: [PATCH v7 08/12] arm: dts: s5pv210: Add node for SGX 540

2020-04-28 Thread Jonathan Bakker
Hi Krzysztof, On 2020-04-27 8:46 a.m., Krzysztof Kozlowski wrote: > On Sun, Apr 26, 2020 at 07:57:12AM -0700, Jonathan Bakker wrote: >> Hi Paul, >> >> On 2020-04-26 5:56 a.m., Paul Cercueil wrote: >>> >>> >>> Le ven. 24 avril 2020 à 22:34, H. Nikolaus Schaller a >>> écrit : From: Jonathan B

[PATCH] drm/bridge: tc358764: fix ptr_ret.cocci warnings

2020-04-28 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Sam-Ravnborg/drm-bridge-support-drm-bridge-connector-helper-panel-updates/20200428-060830 base: git://anongit.freedesktop.org/drm-intel for-linux-next tc358764.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/gpu/drm/bridge/tc358764.c

Re: [PATCH v2 04/21] drm/bridge: tc358764: add drm_panel_bridge support

2020-04-28 Thread kbuild test robot
Hi Sam, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.7-rc3 next-20200428] [cannot apply to drm/drm-next] [if your patch

Re: [PATCH] backlight: l4f00242t03: Convert to GPIO descriptors

2020-04-28 Thread Shawn Guo
On Wed, Apr 15, 2020 at 02:14:49PM +0200, Linus Walleij wrote: > This converts the l4f00242t03 backlight driver to use GPIO > descriptors and switches the two Freescale i.MX boards over > to passing descriptors instead of global GPIO numbers. > > We use the typical names "enable" and "reset" as fo

Re: [PATCH v8 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2020-04-28 Thread Nicolas Boichat
On Mon, Apr 27, 2020 at 2:18 PM Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. > > The ANX7625 can support both USB Type-C PD feature and MIPI DSI/DPI > to DP feature. This driver only ena

Re: [PATCH v3 1/6] drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux

2020-04-28 Thread Doug Anderson
Hi, On Tue, Apr 28, 2020 at 5:44 AM Linus Walleij wrote: > > On Thu, Apr 23, 2020 at 6:26 PM Douglas Anderson > wrote: > > > The ti-sn65dsi86 MIPI DSI to eDP bridge chip has 4 pins on it that can > > be used as GPIOs in a system. Each pin can be configured as input, > > output, or a special fu

Re: [PATCH] amdgpu: fix gcc-4.8 build warnings

2020-04-28 Thread Rodrigo Siqueira
Thanks for your patch. Reviewed-by: Rodrigo Siqueira On 04/28, Arnd Bergmann wrote: > Older compilers warn about initializers with incorrect curly > braces: > > drivers/gpu/drm/drm_dp_mst_topology.c: In function > 'drm_dp_mst_dsc_aux_for_port': > drivers/gpu/drm/drm_dp_mst_topology.c:5497:9: e

Re: [PATCH v3 05/17] drm/msm/dpu: Use OPP API to set clk/perf state

2020-04-28 Thread Matthias Kaehlcke
On Tue, Apr 28, 2020 at 07:02:53PM +0530, Rajendra Nayak wrote: > On some qualcomm platforms DPU needs to express a perforamnce state > requirement on a power domain depennding on the clock rates. > Use OPP table from DT to register with OPP framework and use > dev_pm_opp_set_rate() to set the clk/

Re: linux-next: build failure after merge of the drm-misc tree

2020-04-28 Thread Stephen Rothwell
Hi all, On Mon, 20 Apr 2020 13:01:18 +1000 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/video/fbdev/controlfb.c: In function 'controlfb_mmap': > drivers/video/fbdev/controlfb.c:756:23: error: implici

Re: [PATCH] dt-bindings: arm-smmu: Add a new compatible string and a clock

2020-04-28 Thread Doug Anderson
Hi, On Tue, Apr 28, 2020 at 4:39 AM Sharat Masetty wrote: > > This patch adds a new compatible string for sc7180 and also an > additional clock listing needed to power the TBUs and the TCU. > > Signed-off-by: Sharat Masetty > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 7 +

[PATCH] amdgpu: fix gcc-4.8 build warnings

2020-04-28 Thread Arnd Bergmann
Older compilers warn about initializers with incorrect curly braces: drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_dp_mst_dsc_aux_for_port': drivers/gpu/drm/drm_dp_mst_topology.c:5497:9: error: missing braces around initializer [-Werror=missing-braces] struct drm_dp_desc desc = { 0 }

[PATCH] drm/bridge: fix stack usage warning on old gcc

2020-04-28 Thread Arnd Bergmann
Some older versions of gcc badly optimize code that passes an inline function argument into another function by reference, causing huge stack usage: drivers/gpu/drm/bridge/tc358768.c: In function 'tc358768_bridge_pre_enable': drivers/gpu/drm/bridge/tc358768.c:840:1: error: the frame size of 2256 b

[PATCH] sun6i: dsi: fix gcc-4.8

2020-04-28 Thread Arnd Bergmann
Older compilers warn about initializers with incorrect curly braces: drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function 'sun6i_dsi_encoder_enable': drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: missing braces around initializer [-Werror=missing-braces] union phy_configure_opts opts = {

[PATCH] drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume __maybe_unused

2020-04-28 Thread Arnd Bergmann
With the new static annotation, the compiler warns when the functions are actually unused: drivers/gpu/drm/rockchip/cdn-dp-core.c:1123:12: error: 'cdn_dp_resume' defined but not used [-Werror=unused-function] 1123 | static int cdn_dp_resume(struct device *dev) |^ M

[PATCH] drm/i915: avoid unused scale_user_to_hw() warning

2020-04-28 Thread Arnd Bergmann
After the function is no longer marked 'inline', there is now a new warning pointing out that the only caller is inside of an #ifdef: drivers/gpu/drm/i915/display/intel_panel.c:493:12: warning: 'scale_user_to_hw' defined but not used [-Wunused-function] 493 | static u32 scale_user_to_hw(struct

Re: Msg "PM: pci_pm_suspend(): ast_pm_suspend+0x0/0x40 [ast] returns -22" after migrating to V5.6.7 kernel from v5.5.10.

2020-04-28 Thread David Airlie
On Wed, Apr 29, 2020 at 6:38 AM Cary Garrett wrote: > > Hello Dave, > > Generating & booting v5.5.19 kernel, system will successfully enter suspend > state. > > Generating & booting v5.6.0 kernel, system fails to enter suspend state. > Thomas, do you have ast hw, care to help track it down, I s

Re: [RFC PATCH] dt-bindings: display: ti,tfp410.txt: convert to yaml

2020-04-28 Thread Sam Ravnborg
Hi Ricardo. Thanks for looking into this bridge binding. Some comments in the following. Sam On Tue, Apr 28, 2020 at 11:20:48AM +0200, Ricardo Cañuelo wrote: > Convert the DT binding documentation for the TI TFP410 DPI-to-DVI > encoder to json-schema. > > Signed-off-by: Ricardo Cañuelo

Re: [PATCH v7 4/8] drm: imx: Add i.MX 6 MIPI DSI host platform driver

2020-04-28 Thread Adrian Ratiu
Hi Daniel, On Tue, 28 Apr 2020, Daniel Vetter wrote: On Wed, Apr 22, 2020 at 04:07:27AM +0300, Laurent Pinchart wrote: Hi Adrian, On Tue, Apr 21, 2020 at 07:16:06PM +0300, Adrian Ratiu wrote: > This adds support for the Synopsis DesignWare MIPI DSI v1.01 > host controller which is embedded

Re: [PATCH v1] staging: fbtft: fb_st7789v: Initialize the Display

2020-04-28 Thread Dan Carpenter
On Mon, Apr 27, 2020 at 02:36:25PM +0200, Oliver Graute wrote: > On 27/04/20, Dan Carpenter wrote: > > On Mon, Apr 27, 2020 at 10:36:42AM +0200, Oliver Graute wrote: > > > On 09/04/20, Dan Carpenter wrote: > > > > On Thu, Apr 09, 2020 at 11:25:32AM +0200, Oliver Graute wrote: > > > > > From: Oliver

Re: [PATCH 3/5] drm/i915/dmabuf: Add LMEM knowledge to dmabuf map handler

2020-04-28 Thread Daniel Vetter
On Tue, Apr 28, 2020 at 05:36:03PM +, Ruhl, Michael J wrote: > >-Original Message- > >From: Daniel Vetter > >Sent: Tuesday, April 28, 2020 11:02 AM > >To: Ruhl, Michael J > >Cc: dri-devel@lists.freedesktop.org; dan...@ffwll.ch; Xiong, Jianxin > > > >Subject: Re: [PATCH 3/5] drm/i915/d

Re: [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion

2020-04-28 Thread Dan Carpenter
On Mon, Apr 27, 2020 at 10:29:39AM +0200, Oliver Graute wrote: > On 09/04/20, Dan Carpenter wrote: > > On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote: > > > From: Oliver Graute > > > > > > Enable inversion mode > > > > What the heck is an inversion mode and why would you want it?

Re: [PATCH] drm/managed: Cleanup of unused functions and polishing docs

2020-04-28 Thread Sam Ravnborg
On Tue, Apr 28, 2020 at 08:51:01PM +0200, Daniel Vetter wrote: > Following functions are only used internally, not by drivers: > - devm_drm_dev_init > > Also, now that we have a very slick and polished way to allocate a > drm_device with devm_drm_dev_alloc, update all the docs to reflect the > new

Re: [PATCH 38/59] drm/i915: Use devm_drm_dev_alloc

2020-04-28 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 09:40:13AM +0200, Daniel Vetter wrote: > Luckily we're already well set up in the main driver, with > drm_dev_put() being the last thing in both the unload error case and > the pci remove function. > > Signed-off-by: Daniel Vetter Pushed to drm-misc-next with Jani's irc-a

[Bug 207483] New: PowerColor AMD RX580 much higher power usage on idle than Windows 10

2020-04-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207483 Bug ID: 207483 Summary: PowerColor AMD RX580 much higher power usage on idle than Windows 10 Product: Drivers Version: 2.5 Kernel Version: 5.5.2-050502-generic Hardware

[PATCH] drm/managed: Cleanup of unused functions and polishing docs

2020-04-28 Thread Daniel Vetter
Following functions are only used internally, not by drivers: - devm_drm_dev_init Also, now that we have a very slick and polished way to allocate a drm_device with devm_drm_dev_alloc, update all the docs to reflect the new reality. Mostly this consists of deleting old and misleading hints. Two ma

Re: KASAN: use-after-free Read in vkms_dumb_create

2020-04-28 Thread Ezequiel Garcia
On Tue, 28 Apr 2020 at 09:47, Hillf Danton wrote: > > > Sun, 26 Apr 2020 20:48:12 -0700 > > syzbot found the following crash on: > > > > HEAD commit:c578ddb3 Merge tag 'linux-kselftest-5.7-rc3' of git://git... > > git tree: upstream > > console output: https://syzkaller.appspot.com/x/log

Re: [PATCH 1/3] drm/db9000: Add Digital Blocks DB9000 LCD Controller

2020-04-28 Thread Daniel Vetter
On Tue, Apr 28, 2020 at 8:18 PM Sam Ravnborg wrote: > > Hi Gareth. > > On Mon, Apr 27, 2020 at 09:21:47AM +0100, Gareth Williams wrote: > > Add DRM support for the Digital Blocks DB9000 LCD Controller > > with the Renesas RZ/N1 specific changes. > > > > Signed-off-by: Gareth Williams > > --- > >

Re: [PATCH 1/3] drm/db9000: Add Digital Blocks DB9000 LCD Controller

2020-04-28 Thread Sam Ravnborg
Hi Gareth. On Mon, Apr 27, 2020 at 09:21:47AM +0100, Gareth Williams wrote: > Add DRM support for the Digital Blocks DB9000 LCD Controller > with the Renesas RZ/N1 specific changes. > > Signed-off-by: Gareth Williams > --- > drivers/gpu/drm/Kconfig| 2 + > drivers/gpu/drm/

Re: [PATCH 26/59] drm/qxl: Use devm_drm_dev_alloc

2020-04-28 Thread Daniel Vetter
On Tue, Apr 28, 2020 at 07:00:26PM +0200, Sam Ravnborg wrote: > On Tue, Apr 28, 2020 at 04:00:11PM +0200, Daniel Vetter wrote: > > On Fri, Apr 24, 2020 at 05:09:11PM +0200, Sam Ravnborg wrote: > > > Hi Daniel > > > > > > On Wed, Apr 15, 2020 at 09:40:01AM +0200, Daniel Vetter wrote: > > > > Also n

RE: [PATCH 3/5] drm/i915/dmabuf: Add LMEM knowledge to dmabuf map handler

2020-04-28 Thread Ruhl, Michael J
>-Original Message- >From: Daniel Vetter >Sent: Tuesday, April 28, 2020 11:02 AM >To: Ruhl, Michael J >Cc: dri-devel@lists.freedesktop.org; dan...@ffwll.ch; Xiong, Jianxin > >Subject: Re: [PATCH 3/5] drm/i915/dmabuf: Add LMEM knowledge to dmabuf >map handler > >On Wed, Apr 22, 2020 at 05:

[PATCH v3 13/16] drm/i915: Replace I915_MODE_FLAG_INHERITED with a boolean

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä There's no reason for I915_MODE_FLAG_INHERITED to exist as a flag anymore. Just make it a boolean. CC: Sam Ravnborg Cc: Daniel Vetter Cc: Emil Velikov Reviewed-by: Daniel Vetter Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic.c | 2 +-

[PATCH v3 14/16] drm/gma500: Stop using mode->private_flags

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä gma500 only uses mode->private_flags to convey the sdvo pixel multiplier from the encoder .mode_fixup() hook to the encoder .mode_set() hook. Those always seems get called as a pair so let's just stuff the pixel multiplier into the encoder itself as there are no state objects

[PATCH v3 09/16] drm: Flatten drm_mode_vrefresh()

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Remove the pointless whole-function indentation. Also don't need to worry about negative values anymore since we switched everything to u16. Reviewed-by: Sam Ravnborg Reviewed-by: Emil Velikov Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_modes.c | 26 -

[PATCH v3 15/16] drm: Nuke mode->private_flags

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä The last two uses of mode->private_flags (in i915 and gma500) are now gone. So let's remove mode->private_flags entirely. v2: Drop the earlier int->u8 conversion CC: Sam Ravnborg Cc: Daniel Vetter Cc: Emil Velikov Reviewed-by: Sam Ravnborg Signed-off-by: Ville Syrjälä -

[PATCH v3 16/16] drm: Replace mode->export_head with a boolean

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä In order to shrink drm_display_mode below the magic two cacheline mark in 64bit we need to shrink it by another 8 bytes. The easiest thing to eliminate is the 'export_head' list head which is only used during the getconnector ioctl to temporarly track which modes on the connec

[PATCH v3 10/16] drm: pahole struct drm_display_mode

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Reorganize drm_display_mode to eliminate all the holes. We'll put all the actual timings to the start of the struct and all the extra junk to the end. Gets the size down to 136 bytes on 64bit and 120 bytes on 32bit. With a bit more work we should be able to get this below the

[PATCH v3 12/16] drm/i915: Stop using mode->private_flags

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Replace the use of mode->private_flags with a truly private bitmaks in our own crtc state. We also need a copy in the crtc itself so the vblank code can get at it. We already have scanline_offset in there for a similar reason, as well as the vblank->hwmode which is assigned vi

[PATCH v3 08/16] drm: Shrink drm_display_mode timings

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Store the timings (apart from the clock) as u16. The uapi mode struct already uses u16 for everything so using something bigger internally doesn't really help us. Reviewed-by: Sam Ravnborg Reviewed-by: Emil Velikov Reviewed-by: Daniel Vetter Signed-off-by: Ville Syrjälä -

[PATCH v3 11/16] drm/mcde: Use mode->clock instead of reverse calculating it from the vrefresh

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä htotal*vtotal*vrefresh ~= clock. So just say "clock" when we mean it. Cc: Linus Walleij Cc: Sam Ravnborg Reviewed-by: Daniel Vetter Reviewed-by: Sam Ravnborg Reviewed-by: Linus Walleij Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/mcde/mcde_dsi.c | 3 +-- 1 file cha

[PATCH v3 04/16] drm/msm/dpu: Stop copying around mode->private_flags

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä The driver never sets mode->private_flags so copying it back and forth is entirely pointless. Stop doing it. Also drop private_flags from the tracepoint. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Reviewed-by: Emil Vel

[PATCH v3 07/16] drm: Make mode->flags u32

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä The mode flags are direclty exposed in the uapi as u32. Use the same size type to store them internally. Reviewed-by: Sam Ravnborg Reviewed-by: Emil Velikov Signed-off-by: Ville Syrjälä --- include/drm/drm_modes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH v3 06/16] drm: Shrink mode->type to u8

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä We only have 7 bits defined for mode->type. Shrink the storage to u8. Reviewed-by: Sam Ravnborg Reviewed-by: Emil Velikov Reviewed-by: Daniel Vetter Signed-off-by: Ville Syrjälä --- include/drm/drm_modes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 02/16] drm/i915: Introduce some local intel_dp variables

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä The drrs code dereferences mode->vrefresh via some really long chain of structures/pointers. Couldn't get coccinelle to see through all that so let's add some local variables to help it. Reviewed-by: Emil Velikov Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/displa

[PATCH v3 00/16] drm: Put drm_display_mode on diet

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Rebased mode dieting series. Hopefully will get this past ci finally. Changes from v2: - rebase - dropped the int->u8 private_flags patch Only the last patch remains unreviewed. Ville Syrjälä (16): drm: Nuke mode->hsync drm/i915: Introduce some local intel_dp variables

[PATCH v3 05/16] drm: Shrink {width,height}_mm to u16

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Instead of supporting ~2000km wide displayes let's limit ourselves to ~65m. That seems plenty big enough to me. Even with EDID_QUIRK_DETAILED_IN_CM EDIDs seem to be limited to 10*0xfff which fits into the 16 bits. Reviewed-by: Sam Ravnborg Reviewed-by: Emil Velikov Signed-

[PATCH v3 01/16] drm: Nuke mode->hsync

2020-04-28 Thread Ville Syrjala
From: Ville Syrjälä Let's just calculate the hsync rate on demand. No point in wasting space storing it and risking the cached value getting out of sync with reality. v2: Move drm_mode_hsync() next to its only users Drop the TODO Reviewed-by: Sam Ravnborg Reviewed-by: Emil Velikov #v1 Sig

Re: [PATCH] drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

2020-04-28 Thread Michał Orzeł
Patch resubmitted with intel-gfx mailing list added. Thanks, Michal wt., 28 kwi 2020 o 17:15 Daniel Vetter napisał(a): > On Sun, Apr 26, 2020 at 12:01:22PM +0200, Michal Orzel wrote: > > As suggested by the TODO list for the kernel DRM subsystem, replace > > the deprecated functions that take/d

[PATCH] drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

2020-04-28 Thread Michal Orzel
As suggested by the TODO list for the kernel DRM subsystem, replace the deprecated functions that take/drop modeset locks with new helpers. Signed-off-by: Michal Orzel --- drivers/gpu/drm/drm_mode_object.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu

Re: [PATCH v2 1/2] dt-bindings: display: simple: Add IVO M133NWF4 R0

2020-04-28 Thread Sam Ravnborg
Hi Rob. On Tue, Apr 28, 2020 at 09:27:51AM -0500, Rob Herring wrote: > On Sat, Apr 25, 2020 at 12:58 PM Sam Ravnborg wrote: > > > > Hi Björn. > > > > On Mon, Apr 20, 2020 at 02:57:27PM -0700, Bjorn Andersson wrote: > > > Define the vendor prefix for InfoVision Optoelectronics and add their > > >

Re: [PATCH 56/59] drm/aspeed: Use managed drmm_mode_config_cleanup

2020-04-28 Thread Sam Ravnborg
On Tue, Apr 28, 2020 at 04:12:21PM +0200, Daniel Vetter wrote: > On Fri, Apr 24, 2020 at 08:10:02PM +0200, Sam Ravnborg wrote: > > On Wed, Apr 15, 2020 at 09:40:31AM +0200, Daniel Vetter wrote: > > > Since aspeed doesn't use devm_kzalloc anymore we can use the managed > > > mode config cleanup. > >

Re: [PATCH 1/1] drm/mm: optimize rb_hole_addr rbtree search in high addr mode

2020-04-28 Thread Nirmoy
On 4/28/20 6:18 PM, Chris Wilson wrote: Quoting Nirmoy Das (2020-04-28 17:04:23) Userspace can severely fragment rb_hole_addr rbtree by manipulating alignment while allocating buffers. Fragmented rb_hole_addr rbtree would result in large delays while allocating buffer object for a userspace app

Re: [PATCH 26/59] drm/qxl: Use devm_drm_dev_alloc

2020-04-28 Thread Sam Ravnborg
On Tue, Apr 28, 2020 at 04:00:11PM +0200, Daniel Vetter wrote: > On Fri, Apr 24, 2020 at 05:09:11PM +0200, Sam Ravnborg wrote: > > Hi Daniel > > > > On Wed, Apr 15, 2020 at 09:40:01AM +0200, Daniel Vetter wrote: > > > Also need to remove the drm_dev_put from the remove hook. > > > > > > Acked-by:

Re: [PATCH] drm/mediatek: stop iterating dma addresses when sg_dma_len() == 0

2020-04-28 Thread Chun-Kuang Hu
Hi, Anand, Anand K. Mistry 於 2020年4月28日 週二 上午9:54寫道: > > On Sun, 26 Apr 2020 at 18:04, Chun-Kuang Hu wrote: > > > > Hi, Anand: > > > > Anand K Mistry 於 2020年4月20日 週一 下午2:09寫道: > > > > > > If dma_map_sg() merges pages when creating the mapping, only the first > > > entries will have a valid sg_d

Re: [PATCH v3 05/17] drm/msm/dpu: Use OPP API to set clk/perf state

2020-04-28 Thread Rob Clark
On Tue, Apr 28, 2020 at 6:39 AM Rajendra Nayak wrote: > > On some qualcomm platforms DPU needs to express a perforamnce state s/perforamnce/performance/ > requirement on a power domain depennding on the clock rates. s/depennding/depending/ > Use OPP table from DT to register with OPP framework

Re: [PATCH v2 79/91] drm/vc4: hdmi: Deal with multiple debugfs files

2020-04-28 Thread Dave Stevenson
Hi Stefan and Maxime On Tue, 28 Apr 2020 at 16:57, Maxime Ripard wrote: > > Hi Stefan, > > On Sat, Apr 25, 2020 at 11:26:31PM +0200, Stefan Wahren wrote: > > Am 24.04.20 um 17:35 schrieb Maxime Ripard: > > > The HDMI driver was registering a single debugfs file so far with the name > > > hdmi_reg

Re: [PATCH 1/1] drm/mm: optimize rb_hole_addr rbtree search in high addr mode

2020-04-28 Thread Chris Wilson
Quoting Nirmoy Das (2020-04-28 17:04:23) > Userspace can severely fragment rb_hole_addr rbtree by manipulating > alignment while allocating buffers. Fragmented rb_hole_addr rbtree would > result in large delays while allocating buffer object for a userspace > application. It takes long time to find

Re: [PATCH -next] drm/mediatek: Fix Kconfig warning

2020-04-28 Thread Chun-Kuang Hu
Daniel Vetter 於 2020年4月28日 週二 下午10:55寫道: > > On Sun, Apr 26, 2020 at 04:20:39PM +0800, Chun-Kuang Hu wrote: > > Hi, YueHaibing: > > > > YueHaibing 於 2020年4月20日 週一 下午10:04寫道: > > > > > > WARNING: unmet direct dependencies detected for MTK_MMSYS > > > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPIL

Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse

2020-04-28 Thread Robin Murphy
On 2020-04-28 4:32 pm, Daniel Vetter wrote: On Tue, Apr 28, 2020 at 04:02:57PM +0200, Christoph Hellwig wrote: On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use a proper sg_table entries and call respecti

Re: [PATCH] Remove drm_display_mode.hsync

2020-04-28 Thread Ville Syrjälä
On Tue, Apr 28, 2020 at 05:18:13PM +0200, Daniel Vetter wrote: > On Mon, Apr 27, 2020 at 10:05:17AM +0200, Michal Orzel wrote: > > As suggested by the TODO list of DRM subsystem: > > -remove the member hsync of drm_display_mode > > -convert code using hsync member to use drm_mode_hsync() > > > > S

Re: [RFC 00/17] DRM: fix struct sg_table nents vs. orig_nents misuse

2020-04-28 Thread Daniel Vetter
On Tue, Apr 28, 2020 at 04:02:57PM +0200, Christoph Hellwig wrote: > On Tue, Apr 28, 2020 at 03:19:48PM +0200, Marek Szyprowski wrote: > > 1. introduce a dma_{map,sync,unmap}_sgtable() wrappers, which will use > >a proper sg_table entries and call respective DMA-mapping functions > >and ada

Re: [PATCH v3 3/4] drm: ipk: Add extensions for DW MIPI DSI Host driver

2020-04-28 Thread Daniel Vetter
On Mon, Apr 27, 2020 at 04:00:35PM +0200, Angelo Ribeiro wrote: > Add Synopsys DesignWare IPK specific extensions for Synopsys DesignWare > MIPI DSI Host driver. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sam Ravnborg > Cc: Gustavo Pimentel > C

Re: [PATCH] Remove drm_display_mode.hsync

2020-04-28 Thread Daniel Vetter
On Mon, Apr 27, 2020 at 10:05:17AM +0200, Michal Orzel wrote: > As suggested by the TODO list of DRM subsystem: > -remove the member hsync of drm_display_mode > -convert code using hsync member to use drm_mode_hsync() > > Signed-off-by: Michal Orzel I think Ville has a bunch of patches doing thi

Re: [PATCH 2/2] drm/vram-helper: Alternate between bottom-up and top-down placement

2020-04-28 Thread Thomas Zimmermann
Hi Gerd Am 24.04.20 um 11:38 schrieb Gerd Hoffmann: > Hi, > >> At some point one has to choose to switch to top-down, and then back >> again at one of the next BOs. So the current patch effectively splits >> vram into a lower half and an upper half and puts BOs in alternating halves. > > Hmm,

Re: [RFC 10/17] drm: radeon: fix sg_table nents vs. orig_nents misuse

2020-04-28 Thread Christian König
Am 28.04.20 um 15:19 schrieb Marek Szyprowski: The Documentation/DMA-API-HOWTO.txt states that dma_map_sg returns the numer of the created entries in the DMA address space. However the subsequent calls to dma_sync_sg_for_{device,cpu} and dma_unmap_sg must be called with the original number of ent

Re: [PATCH] drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

2020-04-28 Thread Daniel Vetter
On Sun, Apr 26, 2020 at 12:01:22PM +0200, Michal Orzel wrote: > As suggested by the TODO list for the kernel DRM subsystem, replace > the deprecated functions that take/drop modeset locks with new helpers. > > Signed-off-by: Michal Orzel Hm can you pls resubmit with intel-gfx mailing list cc'ed?

Re: [RFC 02/17] drm: amdgpu: fix sg_table nents vs. orig_nents misuse

2020-04-28 Thread Christian König
Am 28.04.20 um 15:19 schrieb Marek Szyprowski: The Documentation/DMA-API-HOWTO.txt states that dma_map_sg returns the numer of the created entries in the DMA address space. However the subsequent calls to dma_sync_sg_for_{device,cpu} and dma_unmap_sg must be called with the original number of ent

Re: [PATCH v2] drm: make drm_file use keyed wakeups

2020-04-28 Thread Daniel Vetter
On Fri, Apr 24, 2020 at 06:26:15PM +0200, Kenny Levinsen wrote: > Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP. > As drm_file uses unkeyed wakeups, such a poll can receive many spurious > wakeups from uninteresting events if, for example, the file description > is subscri

Re: [PATCH] drm: make drm_file use keyed wakeups

2020-04-28 Thread Daniel Vetter
On Fri, Apr 24, 2020 at 04:51:03PM +0200, Kenny Levinsen wrote: > Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP. > As drm_file uses unkeyed wakeups, such a poll receives many spurious > wakeups from uninteresting events. > > Use keyed wakeups to allow the wakeup target to

Re: [PATCH] drm: pl111: enable render node

2020-04-28 Thread Daniel Vetter
On Mon, Apr 27, 2020 at 09:47:57AM -0700, Eric Anholt wrote: > On Mon, Apr 27, 2020 at 7:45 AM Emil Velikov wrote: > > > > On Fri, 24 Apr 2020 at 19:54, Peter Collingbourne wrote: > > > > > > On Fri, Apr 24, 2020 at 4:11 AM Emil Velikov > > > wrote: > > > > > > > > On Thu, 23 Apr 2020 at 23:51,

Re: [PATCH 3/5] drm/i915/dmabuf: Add LMEM knowledge to dmabuf map handler

2020-04-28 Thread Daniel Vetter
On Wed, Apr 22, 2020 at 05:25:17PM -0400, Michael J. Ruhl wrote: > LMEM backed buffer objects do not have struct page information. > Instead the dma_address of the struct sg is used to store the > LMEM address information (relative to the device, this is not > the CPU physical address). > > The dm

Re: [PATCH -next] drm/mediatek: Fix Kconfig warning

2020-04-28 Thread Daniel Vetter
On Sun, Apr 26, 2020 at 04:20:39PM +0800, Chun-Kuang Hu wrote: > Hi, YueHaibing: > > YueHaibing 於 2020年4月20日 週一 下午10:04寫道: > > > > WARNING: unmet direct dependencies detected for MTK_MMSYS > > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && > > COMMON_CLK_MT8173_MMSYS [=n] > > S

Re: [PATCH -next] drm/rcar-du: Fix return value check in rcar_du_cmm_init()

2020-04-28 Thread Jacopo Mondi
Hello Wei, On Tue, Apr 28, 2020 at 02:17:16PM +, Wei Yongjun wrote: > In case of error, the function of_parse_phandle()/of_find_device_by_node() > returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test > > Fixes: 8de707aeb452 ("drm:

Re: Operating KMS UAPI (Re: RFC: Drm-connector properties managed by another driver / privacy screen support)

2020-04-28 Thread Daniel Vetter
On Fri, Apr 24, 2020 at 11:32:16AM +0300, Pekka Paalanen wrote: > On Thu, 23 Apr 2020 17:01:49 +0200 > Daniel Vetter wrote: > > > On Tue, Apr 21, 2020 at 4:33 PM Pekka Paalanen wrote: > > > > > > On Tue, 21 Apr 2020 14:15:52 +0200 > > > Daniel Vetter wrote: > > > > > ... > > > > > Note that

Re: [PATCH -next] drm/rcar-du: Fix return value check in rcar_du_cmm_init()

2020-04-28 Thread Geert Uytterhoeven
On Tue, Apr 28, 2020 at 4:16 PM Wei Yongjun wrote: > In case of error, the function of_parse_phandle()/of_find_device_by_node() > returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test > > Fixes: 8de707aeb452 ("drm: rcar-du: kms: Initial

Re: [PATCH] drm: drm_fourcc: Add uncompressed AFBC modifier

2020-04-28 Thread Daniel Vetter
On Wed, Apr 22, 2020 at 12:17:58PM +0100, Ben Davis wrote: > AFBC has a mode that allows use of AFBC with an uncompressed buffer, > we add a new modifier to support this mode. > > Signed-off-by: Ben Davis > --- > include/uapi/drm/drm_fourcc.h | 6 ++ > 1 file changed, 6 insertions(+) > > di

Re: [PATCH v7 4/8] drm: imx: Add i.MX 6 MIPI DSI host platform driver

2020-04-28 Thread Daniel Vetter
On Wed, Apr 22, 2020 at 04:07:27AM +0300, Laurent Pinchart wrote: > Hi Adrian, > > On Tue, Apr 21, 2020 at 07:16:06PM +0300, Adrian Ratiu wrote: > > This adds support for the Synopsis DesignWare MIPI DSI v1.01 host > > controller which is embedded in i.MX 6 SoCs. > > > > Based on following patche

Re: [PATCH v2 1/2] dt-bindings: display: simple: Add IVO M133NWF4 R0

2020-04-28 Thread Rob Herring
On Sat, Apr 25, 2020 at 12:58 PM Sam Ravnborg wrote: > > Hi Björn. > > On Mon, Apr 20, 2020 at 02:57:27PM -0700, Bjorn Andersson wrote: > > Define the vendor prefix for InfoVision Optoelectronics and add their > > M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel to the compatible list > > of panel-

Re: [Intel-gfx] [RFC 06/17] drm: i915: fix sg_table nents vs. orig_nents misuse

2020-04-28 Thread Tvrtko Ursulin
On 28/04/2020 14:19, Marek Szyprowski wrote: The Documentation/DMA-API-HOWTO.txt states that dma_map_sg returns the numer of the created entries in the DMA address space. However the subsequent calls to dma_sync_sg_for_{device,cpu} and dma_unmap_sg must be called with the original number of ent

Re: [PATCH 56/59] drm/aspeed: Use managed drmm_mode_config_cleanup

2020-04-28 Thread Daniel Vetter
On Fri, Apr 24, 2020 at 08:10:02PM +0200, Sam Ravnborg wrote: > On Wed, Apr 15, 2020 at 09:40:31AM +0200, Daniel Vetter wrote: > > Since aspeed doesn't use devm_kzalloc anymore we can use the managed > > mode config cleanup. > > > > Signed-off-by: Daniel Vetter > > Cc: Joel Stanley > > Cc: Andre

  1   2   3   >