Re: [PATCH] drm/mediatek: cleanup coding style in mediatek a bit

2020-04-30 Thread kbuild test robot
Hi Bernard, Thank you for the patch! Yet something to improve: [auto build test ERROR on pza/reset/next] [also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip linus/master v5.7-rc3 next-20200430] [if your patch is applied to the wrong git tree, please drop us a note to help improve

linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2020-04-30 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: include/linux/dma-buf.h between commit: 6f49c2515e22 ("dma-buf: fix documentation build warnings") from the drm-misc-fixes tree and commit: 09606b5446c2 ("dma-buf: add peer2peer flag") from the drm tree. I fixed it

Re: [PATCH net-next] dpaa2-eth: fix error return code in setup_dpni()

2020-04-30 Thread David Miller
From: Wei Yongjun Date: Mon, 27 Apr 2020 10:43:22 + > Fix to return negative error code -ENOMEM from the error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Applied, thanks. ___ dri-devel

Re: [PATCH net-next] net: lpc-enet: fix error return code in lpc_mii_init()

2020-04-30 Thread David Miller
From: Wei Yongjun Date: Mon, 27 Apr 2020 12:15:07 + > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: b7370112f519 ("lpc32xx: Added ethernet driver") > Signed-off-by: Wei Yongjun Applied.

[git pull] drm fixes for 5.7-rc4

2020-04-30 Thread Dave Airlie
Hi Linus, Regular scheduled fixes pull for graphics. Nothing to extreme bunch of amdgpu fixes, i915 and qxl fixes, along with some misc ones. All seems to be progressing normally. Dave. drm-fixes-2020-05-01: drm fixes for 5.7-rc4 core: - EDID off by one DTD fix - DP mst write return code fix

Re: [PATCH 1/1] drm/dp_mst: Kill the second sideband tx slot, save the world

2020-04-30 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: ad7f8a1f9ced ("drm/helper: add Displayport multi-stream helper (v0.6)"). The bot has tested the following trees: v5.6.7, v5.4.35, v4.19.118, v4.14.177, v4.9.220, v4.4.220. v5.6.7:

Re: [PATCH v6 02/16] drm/i915: Clear the repeater bit on HDCP disable

2020-04-30 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: ee5e5e7a5e0f ("drm/i915: Add HDCP framework + base implementation"). The bot has tested the following trees: v5.6.7, v5.4.35, v4.19.118. v5.6.7: Build failed! Errors:

Re: [PATCH v6 01/16] drm/i915: Fix sha_text population code

2020-04-30 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: ee5e5e7a5e0f ("drm/i915: Add HDCP framework + base implementation"). The bot has tested the following trees: v5.6.7, v5.4.35, v4.19.118. v5.6.7: Failed to apply! Possible

Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc

2020-04-30 Thread John Dorminy
>> On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: >> > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove >> > it. Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change

Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc

2020-04-30 Thread John Dorminy
Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks

[pull] amdgpu, amdkfd drm-next-5.8

2020-04-30 Thread Alex Deucher
Hi Dave, Daniel, More new stuff for 5.8. The following changes since commit e748f07d00c1c4a9106acafac52df7ea4ecf6264: drm/amdgpu: retire legacy vega10 sos version check (2020-04-23 15:41:06 -0400) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux

Re: [Nouveau] [PATCH] drm/nouveau/dispnv04: Remove dead code

2020-04-30 Thread Ilia Mirkin
Interesting. I do remember seeing some snow on NV5's overlay at high resolutions. Wonder if it was because of this missing code... On Thu, Apr 30, 2020 at 4:19 PM Souptick Joarder wrote: > > These are dead code since 3.10. If there is no plan to use > it further, these can be removed forever. >

[PATCH V1 04/10] arch/kunmap: Remove duplicate kunmap implementations

2020-04-30 Thread ira . weiny
From: Ira Weiny All architectures do exactly the same thing for kunmap(); remove all the duplicate definitions and lift the call to the core. This also has the benefit of changing kmap_unmap() on a number of architectures to be an inline call rather than an actual function. Signed-off-by: Ira

[PATCH V1 05/10] arch/kmap_atomic: Consolidate duplicate code

2020-04-30 Thread ira . weiny
From: Ira Weiny Every arch has the same code to ensure atomic operations and a check for !HIGHMEM page. Remove the duplicate code by defining a core kmap_atomic() which only calls the arch specific kmap_atomic_high() when the page is high memory. Signed-off-by: Ira Weiny --- Changes from V0:

[PATCH V1 08/10] arch/kmap: Don't hard code kmap_prot values

2020-04-30 Thread ira . weiny
From: Ira Weiny To support kmap_atomic_prot() on all architectures each arch must support protections passed in to them. Change csky, mips, nds32 and xtensa to use their global kmap_prot value rather than a hard coded value which was equal. Signed-off-by: Ira Weiny --- arch/csky/mm/highmem.c

[PATCH V1 07/10] arch/kmap: Ensure kmap_prot visibility

2020-04-30 Thread ira . weiny
From: Ira Weiny We want to support kmap_atomic_prot() on all architectures and it makes sense to define kmap_atomic() to use the default kmap_prot. So we ensure all arch's have a globally available kmap_prot either as a define or exported symbol. Signed-off-by: Ira Weiny ---

[PATCH V1 02/10] arch/xtensa: Move kmap build bug out of the way

2020-04-30 Thread ira . weiny
From: Ira Weiny Move the kmap() build bug to kmap_init() to facilitate patches to lift kmap() to the core. Signed-off-by: Ira Weiny --- arch/xtensa/include/asm/highmem.h | 5 - arch/xtensa/mm/highmem.c | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH V1 00/10] Remove duplicated kmap code

2020-04-30 Thread ira . weiny
From: Ira Weiny The kmap infrastructure has been copied almost verbatim to every architecture. This series consolidates obvious duplicated code by defining core functions which call into the architectures only when needed. Some of the k[un]map_atomic() implementations have some similarities but

[PATCH V1 03/10] arch/kmap: Remove redundant arch specific kmaps

2020-04-30 Thread ira . weiny
From: Ira Weiny The kmap code for all the architectures is almost 100% identical. Lift the common code to the core. Use ARCH_HAS_KMAP_FLUSH_TLB to indicate if an arch defines kmap_flush_tlb() and call if if needed. This also has the benefit of changing kmap() on a number of architectures to

[PATCH V1 09/10] arch/kmap: Define kmap_atomic_prot() for all arch's

2020-04-30 Thread ira . weiny
From: Ira Weiny To support kmap_atomic_prot(), all architectures need to support protections passed to their kmap_atomic_high() function. Pass protections into kmap_atomic_high() and change the name to kmap_atomic_high_prot() to match. Then define kmap_atomic_prot() as a core function which

[PATCH V1 10/10] drm: Remove drm specific kmap_atomic code

2020-04-30 Thread ira . weiny
From: Ira Weiny kmap_atomic_prot() is now exported by all architectures. Use this function rather than open coding a driver specific kmap_atomic. Signed-off-by: Ira Weiny --- drivers/gpu/drm/ttm/ttm_bo_util.c| 56 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 16

[PATCH V1 01/10] arch/kmap: Remove BUG_ON()

2020-04-30 Thread ira . weiny
From: Ira Weiny Replace the use of BUG_ON(in_interrupt()) in the kmap() and kunmap() in favor of might_sleep(). Besides the benefits of might_sleep(), this normalizes the implementations such that they can be made generic in subsequent patches. Reviewed-by: Dan Williams Signed-off-by: Ira

[PATCH V1 06/10] arch/kunmap_atomic: Consolidate duplicate code

2020-04-30 Thread ira . weiny
From: Ira Weiny Every single architecture (including !CONFIG_HIGHMEM) calls... pagefault_enable(); preempt_enable(); ... before returning from __kunmap_atomic(). Lift this code into the kunmap_atomic() macro. While we are at it rename __kunmap_atomic() to kunmap_atomic_high()

Re: [PATCH] drm: enable render nodes wherever buffer sharing is supported

2020-04-30 Thread Eric Anholt
On Thu, Apr 30, 2020 at 3:44 AM Daniel Vetter wrote: > > On Tue, Apr 28, 2020 at 2:46 PM Peter Collingbourne wrote: > > > > Render nodes are not just useful for devices supporting GPU hardware > > acceleration. Even on devices that only support dumb frame buffers, > > they are useful in

[PATCH v4 5/6] dt-bindings: drm/bridge: ti-sn65dsi86: Document no-hpd

2020-04-30 Thread Douglas Anderson
The ti-sn65dsi86 MIPI DSI to eDP bridge chip has a dedicated hardware HPD (Hot Plug Detect) pin on it, but it's mostly useless for eDP because of excessive debouncing in hardware. Specifically there is no way to disable the debouncing and for eDP debouncing hurts you because HPD is just used for

[PATCH v4 6/6] arm64: dts: sdm845: Add "no-hpd" to sn65dsi86 on cheza

2020-04-30 Thread Douglas Anderson
We don't have the HPD line hooked up to the bridge chip. Add it as suggested in the patch ("dt-bindings: drm/bridge: ti-sn65dsi86: Document no-hpd"). NOTE: this patch isn't expected to have any effect but just keeps us cleaner for the future. Currently the driver in Linux just assumes that

[PATCH v4 1/6] drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux

2020-04-30 Thread Douglas Anderson
The ti-sn65dsi86 MIPI DSI to eDP bridge chip has 4 pins on it that can be used as GPIOs in a system. Each pin can be configured as input, output, or a special function for the bridge chip. These are: - GPIO1: SUSPEND Input - GPIO2: DSIA VSYNC - GPIO3: DSIA HSYNC or VSYNC - GPIO4: PWM Let's

[PATCH v4 3/6] drm/panel-simple: Support hpd-gpios for delaying prepare()

2020-04-30 Thread Douglas Anderson
People use panel-simple when they have panels that are builtin to their device. In these cases the HPD (Hot Plug Detect) signal isn't really used for hotplugging devices but instead is used for power sequencing. Panel timing diagrams (especially for eDP panels) usually have the HPD signal in

[PATCH v4 2/6] dt-bindings: display: Add hpd-gpios to panel-common bindings

2020-04-30 Thread Douglas Anderson
In the cases where there is no connector in a system there's no great place to put "hpd-gpios". As per discussion [1] the best place to put it is in the panel. Add this to the device tree bindings. [1] https://lore.kernel.org/r/20200417180819.ge5...@pendragon.ideasonboard.com Signed-off-by:

[PATCH v4 0/6] drm: Prepare to use a GPIO on ti-sn65dsi86 for Hot Plug Detect

2020-04-30 Thread Douglas Anderson
As talked about in commit c2bfc223882d ("drm/bridge: ti-sn65dsi86: Remove the mystery delay"), the normal HPD pin on ti-sn65dsi86 is kinda useless, at least for embedded DisplayPort (eDP). However, despite the fact that the actual HPD pin on the bridge is mostly useless for eDP, the concept of

[PATCH v4 4/6] dt-bindings: drm/bridge: ti-sn65dsi86: Convert to yaml

2020-04-30 Thread Douglas Anderson
This moves the bindings over, based a lot on toshiba,tc358768.yaml. Unless there's someone known to be better, I've set the maintainer in the yaml as the first person to submit bindings. Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd --- Changes in v4: None Changes in v3: None

[PATCH v6 2/3] drm: Add support for the LogiCVC display controller

2020-04-30 Thread Paul Kocialkowski
Introduces a driver for the LogiCVC display controller, a programmable logic controller optimized for use in Xilinx Zynq-7000 SoCs and other Xilinx FPGAs. The controller is mostly configured at logic synthesis time so only a subset of configuration is left for the driver to handle. The following

[PATCH v6 0/3] drm: LogiCVC display controller support

2020-04-30 Thread Paul Kocialkowski
This series introduces support for the LogiCVC display controller. The controller is a bit unusual since it is usually loaded as programmable logic on Xilinx FPGAs or Zynq-7000 SoCs. More details are presented on the main commit for the driver. More information about the controller is available

[PATCH v6 3/3] NOTFORMERGE: drm/logicvc: Add plane colorkey support

2020-04-30 Thread Paul Kocialkowski
--- drivers/gpu/drm/logicvc/logicvc_drm.h | 3 + drivers/gpu/drm/logicvc/logicvc_layer.c | 143 +++- drivers/gpu/drm/logicvc/logicvc_layer.h | 7 ++ 3 files changed, 149 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.h

[PATCH v6 1/3] dt-bindings: display: Document the Xylon LogiCVC display controller

2020-04-30 Thread Paul Kocialkowski
The Xylon LogiCVC is a display controller implemented as programmable logic in Xilinx FPGAs. Signed-off-by: Paul Kocialkowski Acked-by: Rob Herring --- .../display/xylon,logicvc-display.yaml| 313 ++ 1 file changed, 313 insertions(+) create mode 100644

Re: [PATCH v5 2/2] drm: Add support for the LogiCVC display controller

2020-04-30 Thread Paul Kocialkowski
Hi Daniel, On Fri 03 Apr 20, 13:04, Daniel Vetter wrote: > On Fri, Apr 03, 2020 at 11:36:17AM +0200, Paul Kocialkowski wrote: > > Introduces a driver for the LogiCVC display controller, a programmable > > logic controller optimized for use in Xilinx Zynq-7000 SoCs and other > > Xilinx FPGAs. The

RE: [RFC PATCH 1/2] dt-bindings: display: xlnx: Add Xilinx DSI TX subsystem bindings

2020-04-30 Thread Venkateshwar Rao Gannavarapu
Hi Sam, thanks for your comments. >-Original Message- >From: Sam Ravnborg >Sent: Sunday, April 26, 2020 1:59 AM >To: Venkateshwar Rao Gannavarapu >Cc: Hyun Kwon ; laurent.pinch...@ideasonboard.com; dri- >de...@lists.freedesktop.org; Sandip Kothari ; >airl...@linux.ie;

Re: [PATCH] drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

2020-04-30 Thread Daniel Vetter
On Thu, Apr 30, 2020 at 5:38 PM Sean Paul wrote: > > On Wed, Apr 29, 2020 at 4:57 AM Jani Nikula > wrote: > > > > On Tue, 28 Apr 2020, Michal Orzel wrote: > > > As suggested by the TODO list for the kernel DRM subsystem, replace > > > the deprecated functions that take/drop modeset locks with

Re: [PATCH v2] dt-bindings: arm-smmu: Add sc7180 compatible string and mem_iface clock

2020-04-30 Thread Doug Anderson
Hi, On Thu, Apr 30, 2020 at 11:12 AM Jordan Crouse wrote: > > On Thu, Apr 30, 2020 at 09:29:47AM +0530, Sharat Masetty wrote: > > This patch adds a new compatible string for sc7180 and also an > > additional clock listing needed to power the TBUs and the TCU. > > > > Signed-off-by: Sharat

Re: [PATCH v2] dt-bindings: arm-smmu: Add sc7180 compatible string and mem_iface clock

2020-04-30 Thread Jordan Crouse
On Thu, Apr 30, 2020 at 09:29:47AM +0530, Sharat Masetty wrote: > This patch adds a new compatible string for sc7180 and also an > additional clock listing needed to power the TBUs and the TCU. > > Signed-off-by: Sharat Masetty > --- > v2: Addressed review comments from Doug > >

Re: [PATCH -next] drm/amd/display: Fix unsigned comparison to zero

2020-04-30 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Apr 30, 2020 at 3:33 AM Zou Wei wrote: > > Fixes coccicheck warning: > > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c:1398:60-61: > WARNING: Unsigned expression compared with zero: j >= 0 > > Fixes: 238387774232 ("drm/amd/display: fix rn soc bb update") >

Re: [PATCH -next] drm/amdgpu: Fix warning Comparison to bool

2020-04-30 Thread Alex Deucher
On Thu, Apr 30, 2020 at 3:32 AM Zou Wei wrote: > > fix below warnings reported by coccicheck > > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:630:5-11: WARNING: Comparison to bool This seems incorrect. enable is a bool. Alex > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei > --- >

Re: [PATCH 0/4] drm/amd/display: remove set but not used variables

2020-04-30 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Apr 30, 2020 at 3:32 AM Zheng Bin wrote: > > Zheng Bin (4): > drm/amd/display: remove set but not used variable 'dc' > drm/amd/display: remove set but not used variable 'pixel_width' > drm/amd/display: remove set but not used variable 'speakers' in >

Re: [PATCH 0/3] drm/amdgpu: remove set but not used variables

2020-04-30 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Apr 30, 2020 at 9:07 AM Christian König wrote: > > Reviewed-by: Christian König for the series. > > Am 30.04.20 um 04:26 schrieb Zheng Bin: > > Zheng Bin (3): > >drm/amdgpu: remove set but not used variable 'priority' > >drm/amdgpu: remove set but not

Re: [RFC PATCH 1/4] drm/etnaviv: Prevent IRQ triggering at probe time on i.MX8MM

2020-04-30 Thread Adam Ford
On Thu, Apr 30, 2020 at 10:31 AM Schrempf Frieder wrote: > > Hi Lucas, > > On 30.04.20 16:32, Lucas Stach wrote: > > Hi Frieder, > > > > Am Donnerstag, den 30.04.2020, 12:46 + schrieb Schrempf Frieder: > >> From: Frieder Schrempf > >> > >> On i.MX8MM there is an interrupt getting triggered

Re: Re: [PATCH] drm/mediatek: cleanup coding style in mediatek a bit

2020-04-30 Thread Chun-Kuang Hu
Hi, Bernard: Bernard 於 2020年4月30日 週四 下午2:32寫道: > > > > 发件人:Chun-Kuang Hu > 发送日期:2020-04-29 22:22:50 > 收件人:Bernard Zhao > 抄送人:Chun-Kuang Hu ,Philipp Zabel > ,David Airlie ,Daniel Vetter > ,Matthias Brugger ,DRI Development > ,Linux ARM > ,"moderated list:ARM/Mediatek SoC > support"

Re: [PATCH v2] drm/bridge: adv7511: Fix cec clock EPROBE_DEFER handling

2020-04-30 Thread Laurent Pinchart
Hi Vincent, Thank you for the patch. On Thu, Apr 30, 2020 at 01:54:39PM +0200, Vincent Whitchurch wrote: > If adv7511's devm_clk_get() for the cec clock returns -EPROBE_DEFER, we > end up in an infinite probe loop. This happens: > > (1) adv7511's probe is called. > > (2) adv7511's probe

Re: [RESEND 2/2] drm/format_helper: Dual licence the header in GPL-2 and MIT

2020-04-30 Thread Emmanuel Vadot
On Thu, 30 Apr 2020 17:06:34 +0200 Maxime Ripard wrote: > On Thu, Apr 30, 2020 at 04:55:37PM +0200, Emmanuel Vadot wrote: > > Source file was dual licenced but the header was omitted, fix that. > > Contributors for this file are: > > Noralf Trønnes > > Gerd Hoffmann > > Thomas Gleixner > > >

Re: [PATCH] drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

2020-04-30 Thread Sean Paul
On Wed, Apr 29, 2020 at 4:57 AM Jani Nikula wrote: > > On Tue, 28 Apr 2020, Michal Orzel wrote: > > As suggested by the TODO list for the kernel DRM subsystem, replace > > the deprecated functions that take/drop modeset locks with new helpers. > > > > Signed-off-by: Michal Orzel > > --- > >

Re: [PATCH 02/10] drm: Add backlight helper

2020-04-30 Thread Hans de Goede
Hi, On 4/29/20 8:40 PM, Noralf Trønnes wrote: Den 29.04.2020 16.13, skrev Hans de Goede: Hi Noralf, On 4/29/20 2:48 PM, Noralf Trønnes wrote: This adds a function that creates a backlight device for a connector. It does not deal with the KMS backlight ABI proposition[1] to add a connector

Re: [RESEND 1/2] drm/client: Dual licence the header in GPL-2 and MIT

2020-04-30 Thread Thomas Zimmermann
Am 30.04.20 um 16:54 schrieb Emmanuel Vadot: > Source file was dual licenced but the header was omitted, fix that. > Contributors for this file are: > Daniel Vetter > Matt Roper > Maxime Ripard > Noralf Trønnes > Thomas Zimmermann > > Acked-by: Noralf Trønnes > Acked-by: Matt Roper >

Re: [RESEND 1/2] drm/client: Dual licence the header in GPL-2 and MIT

2020-04-30 Thread Daniel Vetter
On Thu, Apr 30, 2020 at 4:54 PM Emmanuel Vadot wrote: > > Source file was dual licenced but the header was omitted, fix that. > Contributors for this file are: > Daniel Vetter > Matt Roper > Maxime Ripard > Noralf Trønnes > Thomas Zimmermann > > Acked-by: Noralf Trønnes > Acked-by: Matt

Re: [PATCH resend] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument

2020-04-30 Thread Hans de Goede
Hi, On 4/30/20 4:52 PM, Ville Syrjälä wrote: On Thu, Apr 30, 2020 at 02:47:00PM +0100, Emil Velikov wrote: Hi Hans, On Fri, 21 Feb 2020 at 17:33, Hans de Goede wrote: drm_helper_probe_add_cmdline_mode() prefers using a probed mode matching a video= argument over calculating our own timings

Re: [PATCH] drm/radeon: cleanup coding style a bit

2020-04-30 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Apr 26, 2020 at 9:18 AM Christian König wrote: > > Am 26.04.20 um 15:12 schrieb Bernard Zhao: > > Maybe no need to check ws before kmalloc, kmalloc will check > > itself, kmalloc`s logic is if ptr is NULL, kmalloc will just > > return > > > > Signed-off-by:

Re: [PATCH resend] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument

2020-04-30 Thread Ville Syrjälä
On Thu, Apr 30, 2020 at 02:47:00PM +0100, Emil Velikov wrote: > Hi Hans, > > On Fri, 21 Feb 2020 at 17:33, Hans de Goede wrote: > > > > drm_helper_probe_add_cmdline_mode() prefers using a probed mode matching > > a video= argument over calculating our own timings for the user specified > > mode

Re: [RFC PATCH 3/4] drm/etnaviv: Change order of enabling clocks to fix boot on i.MX8MM

2020-04-30 Thread Lucas Stach
Am Donnerstag, den 30.04.2020, 12:46 + schrieb Schrempf Frieder: > From: Frieder Schrempf > > On some i.MX8MM devices the boot hangs when enabling the GPU clocks. > Changing the order of clock initalization to > > core -> shader -> bus -> reg > > fixes the issue. This is the same order

Re: [RFC PATCH 1/4] drm/etnaviv: Prevent IRQ triggering at probe time on i.MX8MM

2020-04-30 Thread Lucas Stach
Hi Frieder, Am Donnerstag, den 30.04.2020, 12:46 + schrieb Schrempf Frieder: > From: Frieder Schrempf > > On i.MX8MM there is an interrupt getting triggered immediately after > requesting the IRQ, which leads to a stall as the handler accesses > the GPU registers whithout the clock being

Re: [PATCH] dma-buf: Documentation: fix: `make htmldocs` warnings

2020-04-30 Thread Sumit Semwal
Hello Everyone, On Thu, 30 Apr 2020 at 10:07, Sam Ravnborg wrote: > > On Wed, Apr 29, 2020 at 11:27:22PM -0300, Vitor Massaru Iha wrote: > > On Wed, 2020-04-29 at 19:06 -0700, Randy Dunlap wrote: > > > On 4/29/20 6:59 PM, Vitor Massaru Iha wrote: > > > > Add missed ":" on kernel-doc function

Re: [Intel-gfx] [RFC 06/17] drm: i915: fix sg_table nents vs. orig_nents misuse

2020-04-30 Thread Marek Szyprowski
Hi On 28.04.2020 16:27, Tvrtko Ursulin wrote: > > On 28/04/2020 14:19, Marek Szyprowski wrote: >> The Documentation/DMA-API-HOWTO.txt states that dma_map_sg returns the >> numer of the created entries in the DMA address space. However the >> subsequent calls to dma_sync_sg_for_{device,cpu} and

Re: [PATCH v5 1/6] of_graph: add of_graph_get_local_port()

2020-04-30 Thread Rob Herring
On Sat, 18 Apr 2020 20:06:58 +0300, Dmitry Osipenko wrote: > In some case, like a DRM display code for example, it's useful to silently > check whether port node exists at all in a device-tree before proceeding > with parsing the graph. > > This patch adds of_graph_get_local_port() which returns

Re: [PATCH v2] drm: make drm_file use keyed wakeups

2020-04-30 Thread Daniel Vetter
On Wed, Apr 29, 2020 at 11:19:07AM +, k...@kl.wtf wrote: > April 28, 2020 5:14 PM, "Daniel Vetter" wrote: > > > On Fri, Apr 24, 2020 at 06:26:15PM +0200, Kenny Levinsen wrote: > > > >> Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP. > >> As drm_file uses unkeyed

Re: [PATCH 01/10] backlight: Add backlight_device_get_by_name()

2020-04-30 Thread Daniel Vetter
On Thu, Apr 30, 2020 at 11:15:29AM +0100, Lee Jones wrote: > On Thu, 30 Apr 2020, Noralf Trønnes wrote: > > > > > > > Den 30.04.2020 10.32, skrev Lee Jones: > > > On Wed, 29 Apr 2020, Noralf Trønnes wrote: > > > > > >> Add a way to lookup a backlight device based on its name. > > >> Will be

[PULL] drm-intel-fixes

2020-04-30 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2020-04-30: - Fix selftest refcnt leak (Xiyu) - Fix gem vma lock (Chris) - Fix gt's i915_request.timeline acquire by checking if cacheline is valid (Chris) - Fix IRQ postinistall fault masks (Matt) Thanks, Rodrigo. The following changes since

Re: [PATCH v7 4/8] drm: imx: Add i.MX 6 MIPI DSI host platform driver

2020-04-30 Thread Daniel Vetter
On Tue, Apr 28, 2020 at 10:08:04PM +0300, Adrian Ratiu wrote: > Hi Daniel, > > On Tue, 28 Apr 2020, Daniel Vetter wrote: > > On Wed, Apr 22, 2020 at 04:07:27AM +0300, Laurent Pinchart wrote: > > > Hi Adrian, On Tue, Apr 21, 2020 at 07:16:06PM +0300, Adrian Ratiu > > > wrote: > This adds support

Re: [PATCH v7 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2020-04-30 Thread Daniel Vetter
On Thu, Apr 30, 2020 at 09:47:46PM +0800, Xin Ji wrote: > Hi Daniel, > > On Thu, Apr 30, 2020 at 03:38:39PM +0200, Daniel Vetter wrote: > > On Thu, Apr 30, 2020 at 03:37:31PM +0200, Daniel Vetter wrote: > > > On Thu, Apr 30, 2020 at 11:36:14AM +0800, Xin Ji wrote: > > > > On Tue, Apr 28, 2020 at

[PATCH AUTOSEL 4.19 14/30] drm/amdgpu: Correctly initialize thermal controller for GPUs with Powerplay table v0 (e.g Hawaii)

2020-04-30 Thread Sasha Levin
From: Sandeep Raghuraman [ Upstream commit bbc25dadc7ed19f9d6b2e30980f0eb4c741bb8bf ] Initialize thermal controller fields in the PowerPlay table for Hawaii GPUs, so that fan speeds are reported. Signed-off-by: Sandeep Raghuraman Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

Re: Operating KMS UAPI (Re: RFC: Drm-connector properties managed by another driver / privacy screen support)

2020-04-30 Thread Daniel Vetter
On Wed, Apr 29, 2020 at 01:07:54PM +0300, Pekka Paalanen wrote: > On Tue, 28 Apr 2020 16:51:57 +0200 > Daniel Vetter wrote: > > > On Fri, Apr 24, 2020 at 11:32:16AM +0300, Pekka Paalanen wrote: > > > On Thu, 23 Apr 2020 17:01:49 +0200 > > > Daniel Vetter wrote: > > > > > > > On Tue, Apr 21,

[PATCH AUTOSEL 5.4 25/57] drm/amdgpu: Correctly initialize thermal controller for GPUs with Powerplay table v0 (e.g Hawaii)

2020-04-30 Thread Sasha Levin
From: Sandeep Raghuraman [ Upstream commit bbc25dadc7ed19f9d6b2e30980f0eb4c741bb8bf ] Initialize thermal controller fields in the PowerPlay table for Hawaii GPUs, so that fan speeds are reported. Signed-off-by: Sandeep Raghuraman Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

Re: [PATCH v3 16/16] drm: Replace mode->export_head with a boolean

2020-04-30 Thread Emil Velikov
Hi Ville I don't fully grok the i915 changes to provide meaningful review. There are couple of small comments below, but regardless of those Patches 01-11 and 14-16 are: Reviewed-by: Emil Velikov On Tue, 28 Apr 2020 at 18:20, Ville Syrjala wrote: > The downside is that

[PATCH AUTOSEL 5.4 01/57] drm/bridge: analogix_dp: Split bind() into probe() and real bind()

2020-04-30 Thread Sasha Levin
From: Marek Szyprowski [ Upstream commit 83a196773b8bc6702f49df1eddc848180e350340 ] Analogix_dp driver acquires all its resources in the ->bind() callback, what is a bit against the component driver based approach, where the driver initialization is split into a probe(), where all resources are

[PATCH AUTOSEL 5.6 39/79] drm/amdgpu: Correctly initialize thermal controller for GPUs with Powerplay table v0 (e.g Hawaii)

2020-04-30 Thread Sasha Levin
From: Sandeep Raghuraman [ Upstream commit bbc25dadc7ed19f9d6b2e30980f0eb4c741bb8bf ] Initialize thermal controller fields in the PowerPlay table for Hawaii GPUs, so that fan speeds are reported. Signed-off-by: Sandeep Raghuraman Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.6 38/79] drm/amd/powerplay: fix resume failed as smu table initialize early exit

2020-04-30 Thread Sasha Levin
From: Prike Liang [ Upstream commit 45a5e639548c459a5accebad340078e4e6e0e512 ] When the amdgpu in the suspend/resume loop need notify the dpm disabled, otherwise the smu table will be uninitialize and result in resume failed. Signed-off-by: Prike Liang Tested-by: Mengbing Wang Reviewed-by:

[PATCH AUTOSEL 5.6 23/79] drm/scheduler: fix drm_sched_get_cleanup_job

2020-04-30 Thread Sasha Levin
From: Christian König [ Upstream commit 8623b5255ae7ccaf276aac3920787bf575fa6b37 ] We are racing to initialize sched->thread here, just always check the current thread. Signed-off-by: Christian König Reviewed-by: Andrey Grodzovsky Reviewed-by: Kent Russell Link:

[PATCH AUTOSEL 5.6 20/79] drm/bridge: anx6345: set correct BPC for display_info of connector

2020-04-30 Thread Sasha Levin
From: Vasily Khoruzhick [ Upstream commit 1e8a6ce9186dbf342eebc07cf14cae5e82164e03 ] Some drivers (e.g. sun4i-drm) need this info to decide whether they need to enable dithering. Currently driver reports what panel supports and if panel supports 8 we don't get dithering enabled. Hardcode BPC

[PATCH AUTOSEL 5.6 02/79] drm/bridge: analogix_dp: Split bind() into probe() and real bind()

2020-04-30 Thread Sasha Levin
From: Marek Szyprowski [ Upstream commit 83a196773b8bc6702f49df1eddc848180e350340 ] Analogix_dp driver acquires all its resources in the ->bind() callback, what is a bit against the component driver based approach, where the driver initialization is split into a probe(), where all resources are

Re: [PATCH resend] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument

2020-04-30 Thread Emil Velikov
Hi Hans, On Fri, 21 Feb 2020 at 17:33, Hans de Goede wrote: > > drm_helper_probe_add_cmdline_mode() prefers using a probed mode matching > a video= argument over calculating our own timings for the user specified > mode using CVT or GTF. > > But userspace code which is auto-configuring the mode

Re: [PATCH v7 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2020-04-30 Thread Daniel Vetter
On Thu, Apr 30, 2020 at 03:37:31PM +0200, Daniel Vetter wrote: > On Thu, Apr 30, 2020 at 11:36:14AM +0800, Xin Ji wrote: > > On Tue, Apr 28, 2020 at 12:05:08PM +0200, Daniel Vetter wrote: > > > On Fri, Apr 24, 2020 at 08:12:04PM +0800, Nicolas Boichat wrote: > > > > On Fri, Apr 24, 2020 at 2:51 PM

Re: [PATCH v7 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2020-04-30 Thread Daniel Vetter
On Thu, Apr 30, 2020 at 11:36:14AM +0800, Xin Ji wrote: > On Tue, Apr 28, 2020 at 12:05:08PM +0200, Daniel Vetter wrote: > > On Fri, Apr 24, 2020 at 08:12:04PM +0800, Nicolas Boichat wrote: > > > On Fri, Apr 24, 2020 at 2:51 PM Xin Ji wrote: > > > > > > > > On Thu, Apr 23, 2020 at 07:55:15PM

Re: [PATCH] drm/radeon: cleanup coding style a bit

2020-04-30 Thread Christian König
Am 30.04.20 um 13:00 schrieb Bernard: 发件人:Joe Perches 发送日期:2020-04-27 01:53:06 收件人:"Christian König" ,Bernard Zhao ,Alex Deucher ,"David (ChunMing) Zhou" ,David Airlie ,Daniel Vetter ,amd-...@lists.freedesktop.org,dri-devel@lists.freedesktop.org,linux-ker...@vger.kernel.org

Re: [PATCH] drm/radeon: drm/amdgpu: Disable [1002:6611] in radeon

2020-04-30 Thread Alex Deucher
On Thu, Apr 30, 2020 at 9:08 AM Jian-Hong Pan wrote: > > The AMD/ATI Oland [1002:6611]'s HDMI output status is not synchronous > as shown on UI after hot re-plug the HDMI cable, if it is radeon in > used. The amdgpu module does not hit this issue. > > This patch disables [1002:6611] in radeon and

Re: [PATCH 0/3] drm/amdgpu: remove set but not used variables

2020-04-30 Thread Christian König
Reviewed-by: Christian König for the series. Am 30.04.20 um 04:26 schrieb Zheng Bin: Zheng Bin (3): drm/amdgpu: remove set but not used variable 'priority' drm/amdgpu: remove set but not used variable 'direct_poll' in vcn_v2_0.c drm/amdgpu: remove set but not used variable

[PULL] drm-intel-next

2020-04-30 Thread Joonas Lahtinen
915: Update DRIVER_DATE to 20200417 (2020-04-17 09:35:00 +0300) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-next-2020-04-30 for you to fetch changes up to 230982d8d8df7f9d9aa216840ea2db1df6ad5d37: drm/i915: Update DRIVER_DATE to 20200430 (20

Re: [PATCH v2] drm: drm_fourcc: Add uncompressed AFBC modifier

2020-04-30 Thread Liviu Dudau
On Thu, Apr 30, 2020 at 09:32:20AM +0100, Ben Davis wrote: > AFBC has a mode that guarantees use of AFBC with an uncompressed > payloads, we add a new modifier to support this mode. > > V2: updated modifier comment > > Signed-off-by: Ben Davis Acked-by: Liviu Dudau Best regards, Liviu > ---

Re: [PATCH] drm: pl111: enable render node

2020-04-30 Thread Emil Velikov
On Mon, 27 Apr 2020 at 16:58, Peter Collingbourne wrote: > > On Mon, Apr 27, 2020 at 7:45 AM Emil Velikov wrote: > > > > On Fri, 24 Apr 2020 at 19:54, Peter Collingbourne wrote: > > > > > > On Fri, Apr 24, 2020 at 4:11 AM Emil Velikov > > > wrote: > > > > > > > > On Thu, 23 Apr 2020 at 23:51,

Re: [PATCH] drm: pl111: enable render node

2020-04-30 Thread Emil Velikov
On Mon, 27 Apr 2020 at 17:48, Eric Anholt wrote: > > On Mon, Apr 27, 2020 at 7:45 AM Emil Velikov wrote: > > > > On Fri, 24 Apr 2020 at 19:54, Peter Collingbourne wrote: > > > > > > On Fri, Apr 24, 2020 at 4:11 AM Emil Velikov > > > wrote: > > > > > > > > On Thu, 23 Apr 2020 at 23:51, Peter

Re: [PATCH] drm: enable render nodes wherever buffer sharing is supported

2020-04-30 Thread Daniel Vetter
On Tue, Apr 28, 2020 at 2:46 PM Peter Collingbourne wrote: > > Render nodes are not just useful for devices supporting GPU hardware > acceleration. Even on devices that only support dumb frame buffers, > they are useful in situations where composition (using software > rasterization) and KMS are

Re: [PATCH] drm: enable render nodes wherever buffer sharing is supported

2020-04-30 Thread Daniel Vetter
On Thu, Apr 30, 2020 at 12:30 PM Brian Starkey wrote: > > On Wed, Apr 29, 2020 at 06:31:01PM +0100, Liviu Dudau wrote: > > On Wed, Apr 29, 2020 at 09:51:19AM -0700, Peter Collingbourne wrote: > > > On Wed, Apr 29, 2020 at 9:17 AM Brian Starkey > > > wrote: > > > > > > > > Hi Peter, > > > > > >

Re: [PATCH 01/10] backlight: Add backlight_device_get_by_name()

2020-04-30 Thread Noralf Trønnes
Den 30.04.2020 12.15, skrev Lee Jones: > On Thu, 30 Apr 2020, Noralf Trønnes wrote: > >> >> >> Den 30.04.2020 10.32, skrev Lee Jones: >>> On Wed, 29 Apr 2020, Noralf Trønnes wrote: >>> Add a way to lookup a backlight device based on its name. Will be used by a USB display gadget

Re: [PATCH] drm: enable render nodes wherever buffer sharing is supported

2020-04-30 Thread Brian Starkey
On Wed, Apr 29, 2020 at 06:31:01PM +0100, Liviu Dudau wrote: > On Wed, Apr 29, 2020 at 09:51:19AM -0700, Peter Collingbourne wrote: > > On Wed, Apr 29, 2020 at 9:17 AM Brian Starkey wrote: > > > > > > Hi Peter, > > > > > > On Mon, Apr 27, 2020 at 01:05:13PM -0700, Peter Collingbourne wrote: > > >

Re: [PATCH v2 1/1] drm/mm: optimize rb_hole_addr rbtree search

2020-04-30 Thread Nirmoy
On 4/30/20 12:15 PM, Chris Wilson wrote: Quoting Nirmoy Das (2020-04-30 10:58:39) +void insert_hole_addr(struct rb_root *root, struct drm_mm_node *node) ^ static Ah I forgot! (sparse [make C=1] or make W=1 will spot this) Thanks for the tip :) Nirmoy Looks good, I'll check more

Re: [PATCH 01/10] backlight: Add backlight_device_get_by_name()

2020-04-30 Thread Lee Jones
On Thu, 30 Apr 2020, Noralf Trønnes wrote: > > > Den 30.04.2020 10.32, skrev Lee Jones: > > On Wed, 29 Apr 2020, Noralf Trønnes wrote: > > > >> Add a way to lookup a backlight device based on its name. > >> Will be used by a USB display gadget getting the name from configfs. > >> > >> Cc: Lee

Re: [PATCH v2 1/1] drm/mm: optimize rb_hole_addr rbtree search

2020-04-30 Thread Chris Wilson
Quoting Nirmoy Das (2020-04-30 10:58:39) > +void insert_hole_addr(struct rb_root *root, struct drm_mm_node *node) ^ static (sparse [make C=1] or make W=1 will spot this) Looks good, I'll check more carefully later. -Chris ___ dri-devel mailing list

Re: [PATCH] drm/ast: Don't check new mode if CRTC is being disabled

2020-04-30 Thread Thomas Zimmermann
Hi Am 30.04.20 um 11:22 schrieb Sam Ravnborg: > Hi Thomas. > > On Thu, Apr 30, 2020 at 11:13:30AM +0200, Thomas Zimmermann wrote: >> Suspending failed because there's no mode if the CRTC is being >> disabled. Early-out in this case. This fixes runtime PM for ast. >> >> Signed-off-by: Thomas

Re: [PATCH] drm/ast: Don't check new mode if CRTC is being disabled

2020-04-30 Thread Sam Ravnborg
Hi Thomas. On Thu, Apr 30, 2020 at 11:13:30AM +0200, Thomas Zimmermann wrote: > Suspending failed because there's no mode if the CRTC is being > disabled. Early-out in this case. This fixes runtime PM for ast. > > Signed-off-by: Thomas Zimmermann Don't you miss: Reported-by: Tested-by: Fixes:

Re: [PATCH 01/10] backlight: Add backlight_device_get_by_name()

2020-04-30 Thread Noralf Trønnes
Den 30.04.2020 10.32, skrev Lee Jones: > On Wed, 29 Apr 2020, Noralf Trønnes wrote: > >> Add a way to lookup a backlight device based on its name. >> Will be used by a USB display gadget getting the name from configfs. >> >> Cc: Lee Jones >> Cc: Daniel Thompson >> Cc: Jingoo Han >>

Re: [PATCH 01/17] drm/mgag200: Remove HW cursor

2020-04-30 Thread Sam Ravnborg
Hi Thomas. On Thu, Apr 30, 2020 at 10:10:53AM +0200, Thomas Zimmermann wrote: > Hi Sam > > Am 29.04.20 um 19:51 schrieb Sam Ravnborg: > > On Wed, Apr 29, 2020 at 04:32:22PM +0200, Thomas Zimmermann wrote: > >> The HW cursor of Matrox G200 cards only supports a 16-color palette > >> format.

[PATCH] drm/ast: Don't check new mode if CRTC is being disabled

2020-04-30 Thread Thomas Zimmermann
Suspending failed because there's no mode if the CRTC is being disabled. Early-out in this case. This fixes runtime PM for ast. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/ast/ast_mode.c

Re: Msg "PM: pci_pm_suspend(): ast_pm_suspend+0x0/0x40 [ast] returns -22" after migrating to V5.6.7 kernel from v5.5.10.

2020-04-30 Thread Thomas Zimmermann
Hi Cary Am 29.04.20 um 20:26 schrieb Cary Garrett: > Hello Thomas, > > Good news! After applying the patch and regenerating the ast kernel module, > the system will > successfully go into suspend state. > > Thanks for the fast turnaround. Glad I could help. Great. Can I add your Reported-by

[PATCH v2] drm: drm_fourcc: Add uncompressed AFBC modifier

2020-04-30 Thread Ben Davis
AFBC has a mode that guarantees use of AFBC with an uncompressed payloads, we add a new modifier to support this mode. V2: updated modifier comment Signed-off-by: Ben Davis --- include/uapi/drm/drm_fourcc.h | 12 1 file changed, 12 insertions(+) diff --git

Re: [PATCH 01/10] backlight: Add backlight_device_get_by_name()

2020-04-30 Thread Lee Jones
On Wed, 29 Apr 2020, Noralf Trønnes wrote: > Add a way to lookup a backlight device based on its name. > Will be used by a USB display gadget getting the name from configfs. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Signed-off-by: Noralf Trønnes > --- >

  1   2   >