[PATCH v3 12/25] drm: rockchip: fix common struct sg_table related issues

2020-05-05 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that dma_map_sg returns the numer of the created entries in the DMA address space. However the subsequent calls to dma_sync_sg_for_{device,cpu} and dma_unmap_sg must be called with the original number of the entries passed to dma_map_sg. The

[PATCH v3 21/25] staging: tegra-vde: fix common struct sg_table related issues

2020-05-05 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that dma_map_sg returns the numer of the created entries in the DMA address space. However the subsequent calls to dma_sync_sg_for_{device,cpu} and dma_unmap_sg must be called with the original number of the entries passed to dma_map_sg. The

[PATCH v3 00/25] DRM: fix struct sg_table nents vs. orig_nents misuse

2020-05-05 Thread Marek Szyprowski
Dear All, During the Exynos DRM GEM rework and fixing the issues in the drm_prime_sg_to_page_addr_arrays() function [1] I've noticed that most drivers in DRM framework incorrectly use nents and orig_nents entries of the struct sg_table. In case of the most DMA-mapping implementations exchanging

Re: [PATCH v2] drm/meson: add mode selection limits against specific SoC revisions

2020-05-05 Thread Neil Armstrong
On 28/04/2020 11:21, Neil Armstrong wrote: > The Amlogic S805X/Y uses the same die as the S905X, but with more > limited graphics capabilities. > > This adds a soc version detection adding specific limitations on the HDMI > mode selections. > > Here, we limit to HDMI 1.3a max HDMI PHY clock

Re: [PATCH] drm/msm: fix link error without CONFIG_DEBUG_FS

2020-05-05 Thread Linus Walleij
On Wed, Apr 8, 2020 at 9:15 PM Arnd Bergmann wrote: > I ran into a randconfig link error with debugfs disabled: > > arm-linux-gnueabi-ld: > drivers/gpu/drm/msm/msm_gpu.o: in function `should_dump': > msm_gpu.c:(.text+0x1cc): undefined reference to `rd_full' > > Change the helper to only look at

Re: [PATCH] drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity

2020-05-05 Thread Laurent Pinchart
Hi Douglas, Thank you for the patch. On Mon, May 04, 2020 at 09:36:31PM -0700, Douglas Anderson wrote: > The ti-sn65dsi86 MIPI DSI to eDP bridge chip supports arbitrary > remapping of eDP lanes and also polarity inversion. Both of these > features have been described in the device tree bindings

Re: [PATCH v5 0/3] drm: Add support for Chrontel CH7033 VGA/DVI Encoder

2020-05-05 Thread Neil Armstrong
On 24/04/2020 23:35, Lubomir Rintel wrote: > Hi, > > chained to this message is another spin of a driver for CH7033. > > Compared to the previous submission, the integration with device > component framework and creation of an encoder on component bind has > been removed. This means that until

Re: [PATCH v5 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-05-05 Thread Neil Armstrong
On 04/05/2020 22:06, Sam Ravnborg wrote: > Hi Lubomir. > > Drivers looks good. I look forward to the day we have moved > connector stuff to the displaydriver - this will simplify this driver > even more. > > One Q in the following. > > Sam > > On Fri, Apr 24, 2020 at 11:35:39PM +0200,

[PATCH] drm/msm/dpu: make _dpu_core_perf_crtc_update_bus() void

2020-05-05 Thread Jason Yan
This function does not need to return an error so make it return void. This fixes the following coccicheck warning: drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:178:5-8: Unneeded variable: "ret". Return "0" on line 193 Signed-off-by: Jason Yan --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c

[PATCH] drm/amd/display: remove unused variable 'ret' in dm_suspend()

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:1574:5-8: Unneeded variable: "ret". Return "0" on line 1586 Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 0/3] Convert mtk-dpi to drm_bridge API

2020-05-05 Thread Enric Balletbo i Serra
The mtk-dpi driver still uses the drm_encoder API which is now somehow deprecated. We started to move all the Mediatek drivers to the drm_bridge API, like we did for the mtk-dsi driver [1], this is another small step to be able to fully convert the DRM Mediatek drivers to the drm_bridge API. A

Re: [PATCH] drm: ingenic-drm: add MODULE_DEVICE_TABLE

2020-05-05 Thread Paul Cercueil
Hi Nikolaus, Le lun. 4 mai 2020 à 8:35, H. Nikolaus Schaller a écrit : so that the driver can load by matching the device tree if compiled as module. Cc: sta...@vger.kernel.org # v5.3+ Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs") Signed-off-by: H. Nikolaus

Re: [PATCH] nand: brcmnand: correctly verify erased pages

2020-05-05 Thread Florian Fainelli
On 5/4/2020 2:29 AM, Álvaro Fernández Rojas wrote: > The current code checks that the whole OOB area is erased. > This is a problem when JFFS2 cleanmarkers are added to the OOB, since it will > fail due to the usable OOB bytes not being 0xff. > Correct this by only checking that the ECC aren't

[PATCH 1/3] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-05-05 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra ---

[v3 PATCH 1/2] drivers: drm: panel: Add ASUS TM5P5 NT35596 panel driver

2020-05-05 Thread Konrad Dybcio
This adds support for TMP5P5 NT35596 1080x1920 video mode panel that can be found on some Asus Zenfone 2 Laser (Z00T) devices. This panel seems to only be found in this device and we have no straightforward way of actually getting the correct model number, as no schematics are released publicly.

[v2 PATCH 2/2] dt-bindings: display: Document ASUS Z00T TM5P5 NT35596 panel compatible

2020-05-05 Thread Konrad Dybcio
Signed-off-by: Konrad Dybcio --- .../display/panel/asus,z00t-tm5p5-n35596.yaml | 56 +++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/asus,z00t-tm5p5-n35596.yaml diff --git

[PATCH 2/3] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-05-05 Thread Enric Balletbo i Serra
Convert mtk_dpi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_dpi.c | 66 +++--- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git

Re: [PATCH V2 00/11] Subject: Remove duplicated kmap code

2020-05-05 Thread Al Viro
On Mon, May 04, 2020 at 01:17:41PM -0700, Ira Weiny wrote: > > || * arm: much, much worse. We have several files that pull > > linux/highmem.h: > > || arch/arm/mm/cache-feroceon-l2.c, arch/arm/mm/cache-xsc3l2.c, > > || arch/arm/mm/copypage-*.c, arch/arm/mm/dma-mapping.c, arch/arm/mm/flush.c, >

Re: [PATCH v2 20/91] clk: bcm: rpi: Discover the firmware clocks

2020-05-05 Thread Nicolas Saenz Julienne
Hi Maxime, as always, thanks for the series! Some extra context, and comments below. On Fri, 2020-04-24 at 17:34 +0200, Maxime Ripard wrote: > The RaspberryPi4 firmware actually exposes more clocks than are currently > handled by the driver and we will need to change some of them directly > based

[v2 PATCH 0/2] Add support for ASUS Z00T TM5P5 NT35596 panel

2020-05-05 Thread Konrad Dybcio
changes since v1: - make `backlight_properties props` constant - a couple of line breaks - change name and compatible to reflect ASUS being the vendor - remove a redundant TODO Konrad Dybcio (2): drivers: drm: panel: Add ASUS TM5P5 NT35596 panel driver dt-bindings: display: Document ASUS Z00T

linux-5.7-rc4/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c:1393: bad loop termination condition ?

2020-05-05 Thread David Binderman
Hello there, linux-5.7-rc4/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c:1393:63: style: Unsigned expression 'j' can't be negative so it is unnecessary to test it. [unsignedPositive] Source code is for (closest_clk_lvl = 0, j = dcn2_1_soc.num_states - 1; j >= 0; j--) {

[PATCH] nand: brcmnand: correctly verify erased pages

2020-05-05 Thread Álvaro Fernández Rojas
The current code checks that the whole OOB area is erased. This is a problem when JFFS2 cleanmarkers are added to the OOB, since it will fail due to the usable OOB bytes not being 0xff. Correct this by only checking that the ECC aren't 0xff. Signed-off-by: Álvaro Fernández Rojas ---

[PATCH 2/2] nand: brcmnand: fix BBI in hamming oob layout

2020-05-05 Thread Álvaro Fernández Rojas
Small Page NAND uses byte 6 for BBI and Large Page NAND uses first 2 bytes. Signed-off-by: Álvaro Fernández Rojas --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c

Re: [PATCH] drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity

2020-05-05 Thread Stephen Boyd
Quoting Douglas Anderson (2020-05-04 21:36:31) > The ti-sn65dsi86 MIPI DSI to eDP bridge chip supports arbitrary > remapping of eDP lanes and also polarity inversion. Both of these > features have been described in the device tree bindings for the > device since the beginning but were never

RE: [PATCH] drm/i915: check to see if SIMD registers are available before using SIMD

2020-05-05 Thread David Laight
From: Christoph Hellwig > Sent: 04 May 2020 17:03 > > On Sun, May 03, 2020 at 09:20:19PM +0100, Chris Wilson wrote: > > > Err, why does i915 implements its own uncached memcpy instead of relying > > > on core functionality to start with? > > > > What is this core functionality that provides

Re: [v2 PATCH 1/2] drivers: drm: panel: Add ASUS TM5P5 NT35596 panel driver

2020-05-05 Thread Randy Dunlap
On 5/4/20 12:38 PM, Konrad Dybcio wrote: > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index a1723c1b5fbf8..3aa57a927c4bd 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -18,6 +18,16 @@ config DRM_PANEL_ARM_VERSATILE >

Re: [PATCH 00/17] drm/mgag200: Convert to atomic modesetting

2020-05-05 Thread John Donnelly
> On May 4, 2020, at 8:39 AM, Thomas Zimmermann wrote: > > Hi John > > Am 30.04.20 um 02:11 schrieb John Donnelly: >> On 4/29/20 9:32 AM, Thomas Zimmermann wrote: >>> This patchset converts mgag200 to atomic modesetting. It uses simple >>> KMS helpers and SHMEM. >>> >>> Patches 1 to 4

[v3 PATCH 0/2] Add support for ASUS Z00T TM5P5 NT35596 panel

2020-05-05 Thread Konrad Dybcio
changes since v2: - fix Kconfig indentation changes since v1: - make `backlight_properties props` constant - a couple of line breaks - change name and compatible to reflect ASUS being the vendor - remove a redundant TODO Konrad Dybcio (2): drivers: drm: panel: Add ASUS TM5P5 NT35596 panel

[v1] drm/msm/dpu: update bandwidth threshold check

2020-05-05 Thread Krishna Manikandan
Maximum allowed bandwidth has no dependency on the type of panel used. Hence, cleanup the code to use max_bw_high as the threshold value for bandwidth checks. Update the maximum allowed bandwidth as 6.8Gbps for SC7180 target. Signed-off-by: Krishna Manikandan ---

[PATCH 3/3] drm/mediatek: mtk_dpi: Use simple encoder

2020-05-05 Thread Enric Balletbo i Serra
The mtk_dpi driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_dpi.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git

[PATCH v2 1/2] nand: brcmnand: improve hamming oob layout

2020-05-05 Thread Álvaro Fernández Rojas
The current code generates 8 oob sections: S1 1-5 ECC 6-8 S2 9-15 S3 16-21 ECC 22-24 S4 25-31 S5 32-37 ECC 38-40 S6 41-47 S7 48-53 ECC 54-56 S8 57-63 Change it by merging continuous sections: S1 1-5 ECC 6-8 S2 9-21 ECC

Re: [PATCH] sun6i: dsi: fix gcc-4.8

2020-05-05 Thread Maxime Ripard
On Tue, Apr 28, 2020 at 11:50:51PM +0200, Arnd Bergmann wrote: > Older compilers warn about initializers with incorrect curly > braces: > > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function > 'sun6i_dsi_encoder_enable': > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: missing braces

[PATCH] drm/vc4: make vc4_queue_seqno_cb() return void

2020-05-05 Thread Jason Yan
No one uses the return value of this function, so make it return void. This fixes the following coccicheck warning: drivers/gpu/drm/vc4/vc4_gem.c:1029:5-8: Unneeded variable: "ret". Return "0" on line 1044 Signed-off-by: Jason Yan --- drivers/gpu/drm/vc4/vc4_drv.h | 6 +++---

[PATCH -next] drm/radeon: fix unsigned comparison with 0

2020-05-05 Thread ChenTao
Fixes warning because pipe is unsigned long and can never be negtative vers/gpu/drm/radeon/radeon_kms.c:831:11: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] if (pipe < 0 || pipe >= rdev->num_crtc) { drivers/gpu/drm/radeon/radeon_kms.c:857:11: warning:

[PATCH] drm/zte: remove unneeded semicolon

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/gpu/drm/zte/zx_vga.c:158:2-3: Unneeded semicolon drivers/gpu/drm/zte/zx_vga.c:171:2-3: Unneeded semicolon drivers/gpu/drm/zte/zx_vga.c:179:2-3: Unneeded semicolon Signed-off-by: Jason Yan --- drivers/gpu/drm/zte/zx_vga.c | 6 +++--- 1 file changed,

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix off-by-one error in clock choice

2020-05-05 Thread Stephen Boyd
Quoting Douglas Anderson (2020-05-04 21:32:29) > If the rate in our table is _equal_ to the rate we want then it's OK > to pick it. It doesn't need to be greater than the one we want. > > Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver") > Signed-off-by: Douglas

[v2 PATCH 1/2] drivers: drm: panel: Add ASUS TM5P5 NT35596 panel driver

2020-05-05 Thread Konrad Dybcio
This adds support for TMP5P5 NT35596 1080x1920 video mode panel that can be found on some Asus Zenfone 2 Laser (Z00T) devices. This panel seems to only be found in this device and we have no straightforward way of actually getting the correct model number, as no schematics are released publicly.

[v3 PATCH 2/2] dt-bindings: display: Document ASUS Z00T TM5P5 NT35596 panel compatible

2020-05-05 Thread Konrad Dybcio
Signed-off-by: Konrad Dybcio --- .../display/panel/asus,z00t-tm5p5-n35596.yaml | 56 +++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/asus,z00t-tm5p5-n35596.yaml diff --git

[PATCH 1/2] nand: brcmnand: improve hamming oob layout

2020-05-05 Thread Álvaro Fernández Rojas
The current code generates 8 oob sections: S1 1-5 ECC 6-8 S2 9-15 S3 16-21 ECC 22-24 S4 25-31 S5 32-37 ECC 38-40 S6 41-47 S7 48-53 ECC 54-56 S8 57-63 Change it by merging continuous sections: S1 1-5 ECC 6-8 S2 9-21 ECC

Re: [v2 PATCH 1/2] drivers: drm: panel: Add ASUS TM5P5 NT35596 panel driver

2020-05-05 Thread Konrad Dybcio
I just sent out a v3. Hope it solves the issue. Konrad ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/nouveau/mmu: remove unneeded semicolon

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h:307:2-3: Unneeded semicolon drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:583:2-3: Unneeded semicolon Signed-off-by: Jason Yan --- drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c | 2 +-

Re: [PATCH] drm/i915/gem: Fix inconsistent IS_ERR and PTR_ERR

2020-05-05 Thread Markus Elfring
… > The proper pointer to be passed as argument is ce. > > This bug was detected with the help of Coccinelle. My software development attention was caught also by your commit message. … > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > @@ -1325,7 +1325,7 @@ static int

[PATCH v2 2/2] nand: brcmnand: fix hamming oob layout

2020-05-05 Thread Álvaro Fernández Rojas
First 2 bytes are used in large-page nand. Signed-off-by: Álvaro Fernández Rojas --- v2: extend original comment drivers/mtd/nand/raw/brcmnand/brcmnand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c

<    1   2