Re: [PATCH] drm: vmwgfx: include linux/highmem.h

2020-05-08 Thread Stephen Rothwell
Hi Arnd, On Sat, 9 May 2020 00:01:31 +0200 Arnd Bergmann wrote: > > In order to call kmap_atomic() etc, we need to include linux/highmem.h: > > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_bo_cpu_blit_line': > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:377:4: error: implicit declaration of

[PATCH] drm/bridge: ti-sn65dsi86: Clear old error bits before AUX transfers

2020-05-08 Thread Douglas Anderson
The AUX channel transfer error bits in the status register are latched and need to be cleared. Clear them before doing our transfer so we don't see old bits and get confused. Without this patch having a single failure would mean that all future transfers would look like they failed. Fixes: b814e

[PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61

2020-05-08 Thread Douglas Anderson
The BOE NV133FHM-N61 is documented in the original commit to be a 13.3" panel, but the size listed in our struct doesn't match. Specifically: math.sqrt(30.0 * 30.0 + 18.7 * 18.7) / 2.54 ==> 13.92 Searching around on the Internet shows that the size that was in the structure was the "Outline Siz

[PATCH 3/3] panel: simple: Add BOE NV133FHM-N62

2020-05-08 Thread Douglas Anderson
All info I could find about this panel show that it behaves the same as the BOE NV133FHM-N61. However, it definitely appears to be a unique panel because reading the EDID shows "NV133FHM-N62". We'll add a string match for the new panel but until we find something unique about it we'll just point

[PATCH 2/3] dt-bindings: display: simple: Add BOE NV133FHM-N62

2020-05-08 Thread Douglas Anderson
This panel appears to be the same or nearly the same as the BOE NV133FHM-N61, but since (in the very least) it identifies itself as a different model in the EDID we should add a new compatible string for it. Signed-off-by: Douglas Anderson --- .../devicetree/bindings/display/panel/panel-simple.

[PATCH] drm: vmwgfx: include linux/highmem.h

2020-05-08 Thread Arnd Bergmann
In order to call kmap_atomic() etc, we need to include linux/highmem.h: drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_bo_cpu_blit_line': drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:377:4: error: implicit declaration of function 'kunmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-funct

Re: [RFC v4 03/12] drm/vblank: Register drmm cleanup action once per drm_vblank_crtc

2020-05-08 Thread Daniel Vetter
On Fri, May 8, 2020 at 10:48 PM Lyude Paul wrote: > > Since we'll be allocating resources for kthread_create_worker() in the > next commit (which could fail and require us to clean up the mess), > let's simplify the cleanup process a bit by registering a > drm_vblank_init_release() action for each

[RFC v4 12/12] drm/nouveau/kms/nvd9-: Add CRC support

2020-05-08 Thread Lyude Paul
This introduces support for CRC readback on gf119+, using the documentation generously provided to us by Nvidia: https://github.com/NVIDIA/open-gpu-doc/blob/master/Display-CRC/display-crc.txt We expose all available CRC sources. SF, SOR, PIOR, and DAC are exposed through a single set of "outp" so

[RFC v4 11/12] drm/nouveau/kms/nv50-: Move hard-coded object handles into header

2020-05-08 Thread Lyude Paul
While most of the functionality on Nvidia GPUs doesn't require using an explicit handle instead of the main VRAM handle + offset, there are a couple of places that do require explicit handles, such as CRC functionality. Since this means we're about to add another nouveau-chosen handle, let's just g

[RFC v4 08/12] drm/nouveau/kms/nv50-: s/harm/armh/g

2020-05-08 Thread Lyude Paul
We refer to the armed hardware assembly as armh elsewhere in nouveau, so fix the naming here to make it consistent. This patch contains no functional changes. Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[RFC v4 10/12] drm/nouveau/kms/nv50-: Expose nv50_outp_atom in disp.h

2020-05-08 Thread Lyude Paul
In order to make sure that we flush disable updates at the right time when disabling CRCs, we'll need to be able to look at the outp state to see if we're changing it at the same time that we're disabling CRCs. So, expose the struct in disp.h. Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouve

[RFC v4 07/12] drm/nouveau/kms/nv50-: Fix disabling dithering

2020-05-08 Thread Lyude Paul
While we expose the ability to turn off hardware dithering for nouveau, we actually make the mistake of turning it on anyway, due to dithering_depth containing a non-zero value if our dithering depth isn't also set to 6 bpc. So, fix it by never enabling dithering when it's disabled. Signed-off-by

[RFC v4 09/12] drm/nouveau/kms/nv140-: Track wndw mappings in nv50_head_atom

2020-05-08 Thread Lyude Paul
While we're not quite ready yet to add support for flexible wndw mappings, we are going to need to at least keep track of the static wndw mappings we're currently using in each head's atomic state. We'll likely use this in the future to implement real flexible window mapping, but the primary reason

[RFC v4 02/12] kthread: Add kthread_(un)block_work_queuing() and kthread_work_queuable()

2020-05-08 Thread Lyude Paul
Add some simple wrappers around incrementing/decrementing kthread_work.cancelling under lock, along with checking whether queuing is currently allowed on a given kthread_work, which we'll use want to implement work cancelling with DRM's vblank work helpers. Cc: Daniel Vetter Cc: Tejun Heo Cc: Vi

[RFC v4 03/12] drm/vblank: Register drmm cleanup action once per drm_vblank_crtc

2020-05-08 Thread Lyude Paul
Since we'll be allocating resources for kthread_create_worker() in the next commit (which could fail and require us to clean up the mess), let's simplify the cleanup process a bit by registering a drm_vblank_init_release() action for each drm_vblank_crtc so they're still cleaned up if we fail to in

[RFC v4 00/12] drm/nouveau: Introduce CRC support for gf119+

2020-05-08 Thread Lyude Paul
Nvidia released some documentation on how CRC support works on their GPUs, hooray! So: this patch series implements said CRC support in nouveau, along with adding some special debugfs interfaces for some relevant igt-gpu-tools tests (already on the ML). First - we add some new functionality to kt

[RFC v4 01/12] kthread: Add kthread_queue_flush_work()

2020-05-08 Thread Lyude Paul
Currently, it's only possible to flush on a kthread_work in contexts where it's possible to block. This can be kind of painful though when trying to implement new types of delayed work which use kthread_work, since it means we'd need to drop any spinlocks for new delayed work implementations before

[RFC v4 04/12] drm/vblank: Add vblank works

2020-05-08 Thread Lyude Paul
Add some kind of vblank workers. The interface is similar to regular delayed works, and is mostly based off kthread_work. It allows for scheduling delayed works that execute once a particular vblank sequence has passed. It also allows for accurate flushing of scheduled vblank works - in that flushi

[RFC v4 05/12] drm/nouveau/kms/nv50-: Unroll error cleanup in nv50_head_create()

2020-05-08 Thread Lyude Paul
We'll be rolling back more things in this function, and the way it's structured is a bit confusing. So, let's clean this up a bit and just unroll in the event of failure. Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/head.c | 33 + 1 file changed, 23 inse

[RFC v4 06/12] drm/nouveau/kms/nv140-: Don't modify depth in state during atomic commit

2020-05-08 Thread Lyude Paul
Currently, we modify the depth value stored in the atomic state when performing a commit in order to workaround the fact we haven't implemented support for depths higher then 10 yet. This isn't idempotent though, as it will happen every atomic commit where we modify the OR state even if the head's

Re: [PATCH 2/2] nouveau: fix dependencies for DEVICE_PRIVATE

2020-05-08 Thread Arnd Bergmann
On Fri, May 8, 2020 at 9:04 PM Jason Gunthorpe wrote: > > On Fri, May 08, 2020 at 05:05:03PM +0200, Arnd Bergmann wrote: > > On Fri, May 8, 2020 at 5:00 PM Jason Gunthorpe wrote: > > > > > > On Fri, May 08, 2020 at 04:40:09PM +0200, Arnd Bergmann wrote: > > > > CONFIG_DEVICE_PRIVATE cannot be sel

[Bug 207595] [amdgpu] Displayport MST not functional on AMD Stoney

2020-05-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207595 --- Comment #7 from Johannes Braun (jjo.br...@gmail.com) --- Yes, the plan was to use three displays in total. I was not aware that this is not possible with Stoney. Thank you for the clarification. -- You are receiving this mail because: You ar

[Bug 200695] Blank screen on RX 580 with amdgpu.dc=1 enabled (no displays detected)

2020-05-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200695 --- Comment #41 from Meric07 (mericsaka...@gmail.com) --- (In reply to Alex Deucher from comment #40) > (In reply to Meric07 from comment #39) > > I experience the same problem with a R9 380X. Still can't boot into any > > distro with DC enabled.

Re: [PATCH 53/59] drm/arc: Move to drm/tiny

2020-05-08 Thread Daniel Vetter
On Fri, May 8, 2020 at 3:56 PM Alexey Brodkin wrote: > > Hi Daniel, > > > > Looking at this patch series, feels a bit like hand-rolling of bridge > > > code, badly. We should get away from that. > > > > > > Once you have that I think the end result is tiny enough that it can > > > stay, bridges in

Re: [PATCH] drm: Fix page flip ioctl format check

2020-05-08 Thread Rodrigo Vivi
On Fri, Apr 17, 2020 at 09:28:34PM +0300, Ville Syrjälä wrote: > On Fri, Apr 17, 2020 at 08:10:26PM +0200, Daniel Vetter wrote: > > On Fri, Apr 17, 2020 at 5:43 PM Ville Syrjälä > > wrote: > > > > > > On Fri, Apr 17, 2020 at 05:23:10PM +0200, Daniel Vetter wrote: > > > > On Thu, Apr 16, 2020 at 08

Re: [git pull] drm fixes for 5.7-rc5

2020-05-08 Thread pr-tracker-bot
The pull request you sent on Fri, 8 May 2020 15:23:50 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2020-05-08 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/775a8e0316bd5443a0f3faf771b1bdfb8f8e8342 Thank you! -- Deet-doot-dot, I am a bot. https://ko

[Bug 207595] [amdgpu] Displayport MST not functional on AMD Stoney

2020-05-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207595 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH 08/12] vfio: use __anon_inode_getfd

2020-05-08 Thread Alex Williamson
On Fri, 8 May 2020 17:36:30 +0200 Christoph Hellwig wrote: > Use __anon_inode_getfd instead of opencoding the logic using > get_unused_fd_flags + anon_inode_getfile. > > Signed-off-by: Christoph Hellwig > --- > drivers/vfio/vfio.c | 37 - > 1 file changed,

Re: [PATCH] drm/amd/display: Fix pageflip event race condition for DCN. (v2)

2020-05-08 Thread Matt Coffin
Just to follow up on this, I decided not to file the report, since Nick's latest patch that "Fixes:" this has fixed my issue. Thanks for the good work on that one Nick. Might want to make sure that makes it in to the 5.7 fixes :) Thanks again guys. ~Matt On 5/5/20 11:59 AM, Kazlauskas, Nicholas

RE: [PATCH v2] drm/amd/amdgpu: cleanup coding style a bit

2020-05-08 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Bernard Zhao >Sent: Thursday, May 7, 2020 5:13 AM >To: Alex Deucher ; Christian König >; David (ChunMing) Zhou >; David Airlie ; Daniel Vetter >; Tom St Denis ; Sam Ravnborg >; Ori Messinger ; Bernard >Zhao ; amd-...@lists.freedesktop.org;

[Bug 200695] Blank screen on RX 580 with amdgpu.dc=1 enabled (no displays detected)

2020-05-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200695 --- Comment #40 from Alex Deucher (alexdeuc...@gmail.com) --- (In reply to Meric07 from comment #39) > I experience the same problem with a R9 380X. Still can't boot into any > distro with DC enabled. My monitor doesn't offer any other connection

Re: [PATCH 2/2] nouveau: fix dependencies for DEVICE_PRIVATE

2020-05-08 Thread Arnd Bergmann
On Fri, May 8, 2020 at 5:00 PM Jason Gunthorpe wrote: > > On Fri, May 08, 2020 at 04:40:09PM +0200, Arnd Bergmann wrote: > > CONFIG_DEVICE_PRIVATE cannot be selected in configurations > > without ZONE_DEVICE: > > It is kind of unfortunate to lift dependencies from DEVICE_PRIVATE > into the users,

RE: [PATCH 03/36] drm/todo: mention i915 in the struct_mutex section

2020-05-08 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of Emil >Velikov >Sent: Thursday, May 7, 2020 11:08 AM >To: dri-devel@lists.freedesktop.org >Cc: emil.l.veli...@gmail.com >Subject: [PATCH 03/36] drm/todo: mention i915 in the struct_mutex section > >From: Emil Velikov > >Signed-off-by: Emil

[PATCH 2/2] nouveau: fix dependencies for DEVICE_PRIVATE

2020-05-08 Thread Arnd Bergmann
CONFIG_DEVICE_PRIVATE cannot be selected in configurations without ZONE_DEVICE: WARNING: unmet direct dependencies detected for DEVICE_PRIVATE Depends on [n]: ZONE_DEVICE [=n] Selected by [y]: - DRM_NOUVEAU_SVM [=y] && HAS_IOMEM [=y] && DRM_NOUVEAU [=y] && MMU [=y] && STAGING [=y] kernel/re

Re: linux-next: manual merge of the amdgpu tree with the pm tree

2020-05-08 Thread Rafael J. Wysocki
On Friday, May 8, 2020 6:34:57 AM CEST Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the amdgpu tree got a conflict in: > > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > > between commit: > > e07515563d01 ("PM: sleep: core: Rename DPM_FLAG_NEVER_SKIP") > > from the pm tree

Re: [PATCH] drivers: gpu: drm: Add MDP5 configuration for MSM8x36 and its derivatives, such as MSM8939.

2020-05-08 Thread Shawn Guo
Hi Konrad, On Fri, May 01, 2020 at 10:51:59PM +0200, Konrad Dybcio wrote: > Signed-off-by: Konrad Dybcio Please write up some commit log. Since this is based on msm8x16_config, maybe document the differences from it in commit log? > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 70

Re: [bug report] drm/xen-front: Add support for Xen PV display frontend

2020-05-08 Thread Oleksandr Andrushchenko
On 4/21/20 2:51 PM, Dan Carpenter wrote: > It turns out there aren't that many of these in xen. > > $ grep IS_ERR_OR_NULL drivers/gpu/drm/xen/ -Rn > drivers/gpu/drm/xen/xen_drm_front_kms.c:63: if (IS_ERR_OR_NULL(fb)) > drivers/gpu/drm/xen/xen_drm_front_gem.c:86: if (IS_ERR_OR_NULL(xen_obj

Re: [PATCH] drm/atomic: Take the atomic toys away from X

2020-05-08 Thread Greg KH
On Fri, May 08, 2020 at 01:59:17PM +0200, Yves-Alexis Perez wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On Fri, 2020-05-08 at 11:54 +0200, Greg KH wrote: > > > Hi Daniel and Greg (especially). It seems that this patch was never > > > applied to > > > stable, maybe it fell throug

Re: [PATCH 10/36] drm/gem: add _locked suffix to drm_object_put

2020-05-08 Thread Daniel Vetter
On Fri, May 08, 2020 at 12:00:40PM +0100, Emil Velikov wrote: > On Fri, 8 May 2020 at 07:40, Daniel Vetter wrote: > > > > On Thu, May 07, 2020 at 04:07:56PM +0100, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > Vast majority of DRM (core and drivers) are struct_mutex free. > > > > > > A

RE: [PATCH v2] uapi/drm/drm_fourcc.h: Note on platform specificity for format modifiers

2020-05-08 Thread Kahola, Mika
> -Original Message- > From: Daniel Vetter > Sent: Friday, May 8, 2020 1:13 PM > To: Kahola, Mika > Cc: dri-devel@lists.freedesktop.org; dan...@ffwll.ch > Subject: Re: [PATCH v2] uapi/drm/drm_fourcc.h: Note on platform specificity > for format modifiers > > On Fri, May 08, 2020 at 08:56:

[PATCH] dma-buf: Use atomic_fetch_add() for the context id

2020-05-08 Thread Chris Wilson
Now that atomic64_fetch_add() exists we can use it to return the base context id, rather than the atomic64_add_return(N) - N concoction. Suggested-by: Mika Kuoppala Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/dma-buf/dma-fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH 04/36] drm/doc: drop struct_mutex references

2020-05-08 Thread Sam Ravnborg
Hi Emil. On Fri, May 08, 2020 at 11:01:25AM +0100, Emil Velikov wrote: > Hi Sam, > > On Thu, 7 May 2020 at 19:01, Sam Ravnborg wrote: > > > > Hi Emil. > > > > On Thu, May 07, 2020 at 04:07:50PM +0100, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > There's little point in providing par

Re: [PATCH 06/36] drm/amdgpu: use the unlocked drm_gem_object_put

2020-05-08 Thread Sam Ravnborg
On Fri, May 08, 2020 at 10:55:42AM +0100, Emil Velikov wrote: > On Fri, 8 May 2020 at 09:16, Christian König wrote: > > > > Am 07.05.20 um 20:03 schrieb Sam Ravnborg: > > > Hi Emil. > > > > > > On Thu, May 07, 2020 at 04:07:52PM +0100, Emil Velikov wrote: > > >> From: Emil Velikov > > >> > > >> T

Re: [PATCH 10/36] drm/gem: add _locked suffix to drm_object_put

2020-05-08 Thread Emil Velikov
On Fri, 8 May 2020 at 07:40, Daniel Vetter wrote: > > On Thu, May 07, 2020 at 04:07:56PM +0100, Emil Velikov wrote: > > From: Emil Velikov > > > > Vast majority of DRM (core and drivers) are struct_mutex free. > > > > As such we have only a handful of cases where the locked helper should > > be u

Re: [PATCH 36/36] drm/gem: remove _unlocked suffix in drm_object_put_unlocked

2020-05-08 Thread Sam Ravnborg
Hi Emil. On Fri, May 08, 2020 at 11:15:24AM +0100, Emil Velikov wrote: > On Thu, 7 May 2020 at 19:14, Sam Ravnborg wrote: > > > > Hi Emil. > > > > On Thu, May 07, 2020 at 04:08:22PM +0100, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > Spelling out _unlocked for each and every driver i

Re: [PATCH 09/36] drm/gem: fold drm_gem_object_put_unlocked and __drm_gem_object_put()

2020-05-08 Thread Emil Velikov
On Fri, 8 May 2020 at 07:43, Daniel Vetter wrote: > > On Thu, May 07, 2020 at 04:07:55PM +0100, Emil Velikov wrote: > > From: Emil Velikov > > > > With earlier patch we removed the normal overhead so now we can lift > > the helper to the header, folding it __drm_object_put. > > > > Signed-off-by:

[Bug 200695] Blank screen on RX 580 with amdgpu.dc=1 enabled (no displays detected)

2020-05-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200695 Meric07 (mericsaka...@gmail.com) changed: What|Removed |Added CC||mericsaka...@gmail.com

Re: [PATCH 12/36] drm/amd: remove _unlocked suffix in drm_object_put_unlocked

2020-05-08 Thread Emil Velikov
Hi Christian, On Fri, 8 May 2020 at 10:23, Christian König wrote: > > Am 07.05.20 um 17:07 schrieb Emil Velikov: > > From: Emil Velikov > > > > Spelling out _unlocked for each and every driver is a annoying. > > Especially if we consider how many drivers, do not know (or need to) > > about the h

Re: [PATCH 04/36] drm/doc: drop struct_mutex references

2020-05-08 Thread Daniel Vetter
On Fri, May 08, 2020 at 11:07:00AM +0100, Emil Velikov wrote: > On Fri, 8 May 2020 at 07:27, Daniel Vetter wrote: > > > > On Thu, May 07, 2020 at 04:07:50PM +0100, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > There's little point in providing partial and ancient information about > >

Re: [PATCH 00/36] drm: Fareless gem_free_object

2020-05-08 Thread Emil Velikov
On Thu, 7 May 2020 at 19:17, Sam Ravnborg wrote: > > Hi Emil. > On Thu, May 07, 2020 at 04:07:46PM +0100, Emil Velikov wrote: > > Hi all, > > > > Recently I had a look at the new dmabuf AMDGPU implementation. > > > > Seemingly it was using the wrong drm_gem_object_put API. Namely the > > locked on

Re: [PATCH v6 2/3] drm: Add support for the LogiCVC display controller

2020-05-08 Thread Emil Velikov
On Thu, 7 May 2020 at 21:11, Paul Kocialkowski wrote: > > Hi Emil, > > Thanks for the review! > > On Mon 04 May 20, 14:28, Emil Velikov wrote: > > Just had a casual quick look for custom KMS properties, since new > > drivers made that mistake in the past. > > Thanks for not including any o/ > > Ye

Re: [PATCH] gpu: host1x: Clean up debugfs in error handling path in 'host1x_probe()'

2020-05-08 Thread Thierry Reding
On Sun, Apr 26, 2020 at 09:16:30PM +0200, Christophe JAILLET wrote: > 'host1x_debug_init()' must be reverted in an error handling path. > > This is already fixed in the remove function since commit 44156eee91ba > ("gpu: host1x: Clean up debugfs on removal") > > Signed-off-by: Christophe JAILLET

Re: [PATCH 11/36] drm/gem: add drm_object_put helper

2020-05-08 Thread Emil Velikov
On Fri, 8 May 2020 at 07:33, Jani Nikula wrote: > > On Thu, 07 May 2020, Emil Velikov wrote: > > From: Emil Velikov > > > > Spelling out _unlocked for each and every driver is a annoying. > > Especially if we consider how many drivers, do not know (or need to) > > about the horror stories involv

Re: [PATCH 36/36] drm/gem: remove _unlocked suffix in drm_object_put_unlocked

2020-05-08 Thread Emil Velikov
On Thu, 7 May 2020 at 19:14, Sam Ravnborg wrote: > > Hi Emil. > > On Thu, May 07, 2020 at 04:08:22PM +0100, Emil Velikov wrote: > > From: Emil Velikov > > > > Spelling out _unlocked for each and every driver is a annoying. > > Especially if we consider how many drivers, do not know (or need to) >

[GIT PULL] drm/tegra: Fixes for v5.7

2020-05-08 Thread Thierry Reding
Hi Dave, The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) are available in the Git repository at: git://anongit.freedesktop.org/tegra/linux tags/drm/tegra/for-5.7-fixes for you to fetch changes up to 4010e729349fcab69183

Re: [PATCH v2] uapi/drm/drm_fourcc.h: Note on platform specificity for format modifiers

2020-05-08 Thread Daniel Vetter
On Fri, May 08, 2020 at 08:56:28AM +0200, Daniel Vetter wrote: > On Wed, May 06, 2020 at 03:08:27PM +0300, Mika Kahola wrote: > > Make an additional note on DRM format modifiers for x and y tiling. These > > format modifiers are defined for BDW+ platforms and therefore definition > > is not valid f

Re: [PATCH 04/36] drm/doc: drop struct_mutex references

2020-05-08 Thread Emil Velikov
On Fri, 8 May 2020 at 07:27, Daniel Vetter wrote: > > On Thu, May 07, 2020 at 04:07:50PM +0100, Emil Velikov wrote: > > From: Emil Velikov > > > > There's little point in providing partial and ancient information about > > the struct_mutex. Some drivers are using it, new ones should not. > > > >

Re: [PATCH 04/36] drm/doc: drop struct_mutex references

2020-05-08 Thread Emil Velikov
Hi Sam, On Thu, 7 May 2020 at 19:01, Sam Ravnborg wrote: > > Hi Emil. > > On Thu, May 07, 2020 at 04:07:50PM +0100, Emil Velikov wrote: > > From: Emil Velikov > > > > There's little point in providing partial and ancient information about > > the struct_mutex. Some drivers are using it, new ones

[Bug 207619] Screen corrupt in Wayland and kmscube, like wrong stride / pitch, on Radeon X1400 RV515

2020-05-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207619 --- Comment #1 from Michel Dänzer (mic...@daenzer.net) --- This is probably https://gitlab.freedesktop.org/mesa/mesa/-/issues/2780 . -- You are receiving this mail because: You are watching the assignee of the bug. __

Re: [PATCH 06/36] drm/amdgpu: use the unlocked drm_gem_object_put

2020-05-08 Thread Emil Velikov
On Fri, 8 May 2020 at 09:16, Christian König wrote: > > Am 07.05.20 um 20:03 schrieb Sam Ravnborg: > > Hi Emil. > > > > On Thu, May 07, 2020 at 04:07:52PM +0100, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> The driver does not hold struct_mutex, thus using the locked version of > >> the

Re: [PATCH] drm/atomic: Take the atomic toys away from X

2020-05-08 Thread Greg KH
On Fri, May 08, 2020 at 11:06:56AM +0200, Yves-Alexis Perez wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On Thu, 2019-09-05 at 20:53 +0200, Daniel Vetter wrote: > > The -modesetting ddx has a totally broken idea of how atomic works: > > - doesn't disable old connectors, assuming

Re: [PATCH 12/36] drm/amd: remove _unlocked suffix in drm_object_put_unlocked

2020-05-08 Thread Christian König
Am 07.05.20 um 17:07 schrieb Emil Velikov: From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner.

Re: [PATCH v2 5/5] drm/panel: add panel driver for Ilitek ili9341 panels

2020-05-08 Thread Sam Ravnborg
Hi Dillon. Patch submissions starts to look fine. On Fri, May 08, 2020 at 12:13:14PM +0800, dillon.min...@gmail.com wrote: > From: dillon min > > This is a driver for 320x240 TFT panels, accepting a rgb input > streams that get adapted and scaled to the panel. This driver is, I suppose, prepare

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

2020-05-08 Thread Maxime Ripard
On Mon, May 04, 2020 at 02:35:08PM +0800, Jian-Hong Pan wrote: > Maxime Ripard 於 2020年4月29日 週三 上午12:21寫道: > > > > Hi, > > > > On Mon, Apr 27, 2020 at 03:23:42PM +0800, Jian-Hong Pan wrote: > > > Hi Maxime, > > > > > > Thanks for your V2 patch series! I'm testing it. > > > > > > This patch series

Re: [PATCH 3/3] drm/mipi: use dcs write for mipi_dsi_dcs_set_tear_scanline

2020-05-08 Thread Vinay Simha B N
Emil, Reply inline On Tue, 5 May 2020 at 9:35 PM, Emil Velikov wrote: > From: Emil Velikov > > The helper uses the MIPI_DCS_SET_TEAR_SCANLINE, although it's currently > using the generic write. This does not look right. > > Perhaps some platforms don't distinguish between the two writers? > >

[PATCH -next] drm: panel: add MODULE_LICENSE to panel-visionox-rm69299.c

2020-05-08 Thread Randy Dunlap
From: Randy Dunlap Add MODULE_LICENSE() to the panel-visionox-rm69299 driver to fix a build warning. WARNING: modpost: missing MODULE_LICENSE() in drivers/gpu/drm/panel/panel-visionox-rm69299.o Signed-off-by: Randy Dunlap Cc: Thierry Reding Cc: Sam Ravnborg Cc: dri-devel@lists.freedesktop.o

[PULL] drm-misc-fixes

2020-05-08 Thread Maxime Ripard
Hi! Here is this week drm-misc-fixes PR Maxime drm-misc-fixes-2020-05-07: A few minor fixes for an ordering issue in virtio, an (old) gcc warning in sun4i, a probe issue in ingenic-drm and a regression in the HDCP support. The following changes since commit 6f49c2515e2258f08f2b905c9772dbf7296104

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

2020-05-08 Thread Jian-Hong Pan
Maxime Ripard 於 2020年5月8日 週五 上午1:22寫道: > > On Mon, May 04, 2020 at 02:35:08PM +0800, Jian-Hong Pan wrote: > > Maxime Ripard 於 2020年4月29日 週三 上午12:21寫道: > > > > > > Hi, > > > > > > On Mon, Apr 27, 2020 at 03:23:42PM +0800, Jian-Hong Pan wrote: > > > > Hi Maxime, > > > > > > > > Thanks for your V2 p

[PATCH v2 1/5] ARM: dts: stm32: Add pin map for ltdc, spi5 on stm32f429-disco board

2020-05-08 Thread dillon . minfei
From: dillon min This patch adds the pin configuration for ltdc, spi5 controller on stm32f429-disco board. Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 67 ++ 1 file changed, 67 insertions(+) diff --git a/arch/arm/boot/dts/stm32f4-pinc

Re: [PATCH] drm/mediatek: stop iterating dma addresses when sg_dma_len() == 0

2020-05-08 Thread Anand Mistry
On Wed, May 6, 2020 at 10:59 PM Chun-Kuang Hu wrote: > > Hi, Anand: > > Anand Mistry 於 2020年5月6日 週三 下午7:03寫道: > > > > On Wed, May 6, 2020 at 10:25 AM Chun-Kuang Hu wrote: > > > > > > Hi, Anand, > > > > > > Chun-Kuang Hu 於 2020年4月29日 週三 上午12:37寫道: > > > > > > > > Hi, Anand, > > > > > > > > Anand

[PATCH v2] drm/amd/amdgpu: cleanup coding style a bit

2020-05-08 Thread Bernard Zhao
There is DEVICE_ATTR mechanism in separate attribute define. So this change is to use attr array, also use sysfs_create_files in init function & sysfs_remove_files in fini function. This maybe make the code a bit readable. Signed-off-by: Bernard Zhao Changes since V1: *Use DEVICE_ATTR mechanism

[PATCH] drm/vmwgfx: Return true in function vmw_fence_obj_signaled()

2020-05-08 Thread Jason Yan
Fix the following coccicheck warning: drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:518:9-10: WARNING: return of 0/1 in function 'vmw_fence_obj_signaled' with return type bool Signed-off-by: Jason Yan --- drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2 4/5] clk: stm32: Fix stm32f429 ltdc driver loading hang in clk set rate. keep ltdc clk running after kernel startup

2020-05-08 Thread dillon . minfei
From: dillon min as store stm32f4_rcc_register_pll return to the wrong offset of clks, so ltdc gate clk is null. need change clks[PLL_VCO_SAI] to clks[PLL_SAI] add CLK_IGNORE_UNUSED for ltdc to make sure clk not be freed by clk_disable_unused Signed-off-by: dillon min --- drivers/clk/clk-stm3

[PATCH v2 5/5] drm/panel: add panel driver for Ilitek ili9341 panels

2020-05-08 Thread dillon . minfei
From: dillon min This is a driver for 320x240 TFT panels, accepting a rgb input streams that get adapted and scaled to the panel. Signed-off-by: dillon min --- drivers/gpu/drm/panel/Kconfig| 8 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/pane

Re: [PATCH] drm/mediatek: stop iterating dma addresses when sg_dma_len() == 0

2020-05-08 Thread Anand Mistry
On Wed, May 6, 2020 at 10:59 PM Chun-Kuang Hu wrote: > > Hi, Anand: > > Anand Mistry 於 2020年5月6日 週三 下午7:03寫道: > > > > On Wed, May 6, 2020 at 10:25 AM Chun-Kuang Hu > > wrote: > > > > > > Hi, Anand, > > > > > > Chun-Kuang Hu 於 2020年4月29日 週三 上午12:37寫道: > > > > > > > > Hi, Anand, > > > > > > > >

[PATCH v2 2/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board

2020-05-08 Thread dillon . minfei
From: dillon min Enable the ltdc & ili9341 on stm32429-disco board. Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f429-disco.dts | 40 +++ 1 file changed, 40 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429-disco.dts b/arch/arm/boot/dts/stm32f429-

[PATCH v2 3/5] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2020-05-08 Thread dillon . minfei
From: dillon min Add documentation for "ilitek,ili9341" panel. Signed-off-by: dillon min --- Hi Rob Herring, This patch [PATCH V2 3/5] about ilitek,ili9341.yaml was verifyed with make dt_binding_check thanks. best regards, dillon, .../bindings/display/panel/ilitek,ili9341.yaml | 68 +

[PATCH] drm/amd/display: remove variable "result" in dcn20_patch_unknown_plane_state()

2020-05-08 Thread Jason Yan
Fix the following coccicheck warning: drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c:3216:16-22: Unneeded variable: "result". Return "DC_OK" on line 3229 Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletio

[PATCH v2] dma-buf: fix use-after-free in dmabuffs_dname

2020-05-08 Thread Charan Teja Reddy
The following race occurs while accessing the dmabuf object exported as file: P1 P2 dma_buf_release() dmabuffs_dname() [say lsof reading /proc//fd/] read dmabuf stored in dentry->d_fsdata Free the dmabuf ob

Re:[PATCH] drivers/video: cleanup coding style in video a bit

2020-05-08 Thread Bernard
From: Bernard Zhao Date: 2020-04-27 16:05:23 To: Bartlomiej Zolnierkiewicz ,Uma Shankar ,"Ville Syrjälä" ,Shashank Sharma ,Laurent Pinchart ,Daniel Vetter ,Bernard Zhao ,dri-devel@lists.freedesktop.org,linux-fb...@vger.kernel.org,linux-ker...@vger.kernel.org Cc: opensource.ker...@vivo.com

BUG: unable to handle kernel paging request in vga16fb_imageblit (2)

2020-05-08 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:262f7a6b Merge tag 'for-5.7-rc3-tag' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1278688810 kernel config: https://syzkaller.appspot.com/x/.config?x=5b075813ec8b93cd das

[PATCH -next] drm/amd/display: remove duplicate headers

2020-05-08 Thread Chen Zhou
Remove duplicate headers which are included twice. Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c index 9ef9e50a3

[PATCH] drm/edid: Add Oculus Rift S to non-desktop list

2020-05-08 Thread Jan Schmidt
Add a quirk for the Oculus Rift S OVR0012 display so it shows up as a non-desktop display. Signed-off-by: Jan Schmidt --- drivers/gpu/drm/drm_edid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 116451101426..4

[PATCH v2 0/5] Enable ilitek ili9341 on stm32f429-disco board

2020-05-08 Thread dillon . minfei
From: dillon min This patchset have following changes V2: verify ilitek,ili9341.yaml with make O=../linux-stm32 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml V1: add ili9341 drm panel driver add ltdc, spi5 controller for stm32f429-d

[PATCH -next] drm/amd/dc: Remove a useless comparison

2020-05-08 Thread ChenTao
Fix the following warning: 'en' is uint32_t and can never be negative. drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/hw_hpd.c:132:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] if ((en < GPIO_DDC_LINE_MIN) || (en > GPIO_DDC_LINE_MAX)) { drivers/gpu/drm/amd/am

Re: [PATCH 06/36] drm/amdgpu: use the unlocked drm_gem_object_put

2020-05-08 Thread Christian König
Am 07.05.20 um 20:03 schrieb Sam Ravnborg: Hi Emil. On Thu, May 07, 2020 at 04:07:52PM +0100, Emil Velikov wrote: From: Emil Velikov The driver does not hold struct_mutex, thus using the locked version of the helper is incorrect. Cc: Alex Deucher Cc: Christian König Cc: amd-...@lists.freed

Re: [PATCH 06/36] drm/amdgpu: use the unlocked drm_gem_object_put

2020-05-08 Thread Christian König
Am 07.05.20 um 17:07 schrieb Emil Velikov: From: Emil Velikov The driver does not hold struct_mutex, thus using the locked version of the helper is incorrect. Cc: Alex Deucher Cc: Christian König Cc: amd-...@lists.freedesktop.org Fixes: a39414716ca0 ("drm/amdgpu: add independent DMA-buf impo

Re: [PATCH] drm/exynos: remove no need devm_kfree in probe [re-send, welcome any comments]

2020-05-08 Thread Sam Ravnborg
Hi Bernard. On Wed, May 06, 2020 at 08:49:03PM +0800, Bernard wrote: > Remove no need devm_kfree in probe. > The change is to make the code a bit more readable > > Signed-off-by: Bernard Zhao Could you take a closer look and fix similar patterns in the rest of the driver? For example in exynos_

RE: [PATCH v2 3/9] drm/i915/display/sdvo: Prefer drm_WARN* over WARN*

2020-05-08 Thread Laxminarayan Bharadiya, Pankaj
> -Original Message- > From: Jani Nikula > Sent: 08 May 2020 12:19 > To: Laxminarayan Bharadiya, Pankaj > ; dan...@ffwll.ch; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Joonas Lahtinen > ; Vivi, Rodrigo ; > David Airlie ; Ville Syrjälä > ; Chris > Wilson ; Dea

Re: [PATCH v3 02/25] drm: core: fix common struct sg_table related issues

2020-05-08 Thread Marek Szyprowski
Hi Christoph, On 05.05.2020 13:09, Christoph Hellwig wrote: > On Tue, May 05, 2020 at 12:51:58PM +0200, Marek Szyprowski wrote: >> On 05.05.2020 12:15, Christoph Hellwig wrote: - for_each_sg_page(st->sgl, &sg_iter, st->nents, 0) + for_each_sg_page(st->sgl, &sg_iter, st-

Re: [PATCH] drm/exynos: remove redundant initialization to variable 'start'

2020-05-08 Thread Daniel Vetter
On Thu, May 07, 2020 at 09:22:37PM +0100, Colin King wrote: > From: Colin Ian King > > The variable 'start' is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unus

Re: [PATCH v3] drm/ast: Don't check new mode if CRTC is being disabled

2020-05-08 Thread Daniel Vetter
On Thu, May 07, 2020 at 11:06:40AM +0200, Thomas Zimmermann wrote: > Suspending failed because there's no mode if the CRTC is being > disabled. Early-out in this case. This fixes runtime PM for ast. > > v3: > * fixed commit message > v2: > * added Tested-by/Reported-by tags > * a