[PATCH v3 1/6] dt-bindings: drm/msm/gpu: Document gpu opp table

2020-06-05 Thread Sharat Masetty
Update documentation to list the gpu opp table bindings including the newly added "opp-peak-kBps" needed for GPU-DDR bandwidth scaling. Signed-off-by: Sharat Masetty Acked-by: Rob Herring --- .../devicetree/bindings/display/msm/gpu.txt| 28 ++ 1 file changed, 28

[PATCH v3 3/6] drm: msm: a6xx: use dev_pm_opp_set_bw to scale DDR

2020-06-05 Thread Sharat Masetty
This patches replaces the previously used static DDR vote and uses dev_pm_opp_set_bw() to scale GPU->DDR bandwidth along with scaling GPU frequency. Also since the icc path voting is handled completely in the opp driver, remove the icc_path handle and its usage in the drm driver. Signed-off-by:

[PATCH v3 4/6] arm64: dts: qcom: SDM845: Enable GPU DDR bw scaling

2020-06-05 Thread Sharat Masetty
This patch adds the interconnects property for the gpu node and the opp-peak-kBps property to the opps of the gpu opp table. This should help enable DDR bandwidth scaling dynamically and proportionally to the GPU frequency. Signed-off-by: Sharat Masetty --- arch/arm64/boot/dts/qcom/sdm845.dtsi

[PATCH v3 5/6] arm64: dts: qcom: sc7180: Add interconnects property for GPU

2020-06-05 Thread Sharat Masetty
This patch adds the interconnects property to the GPU node. This enables the GPU->DDR path bandwidth voting. Signed-off-by: Sharat Masetty --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi

[PATCH v3 6/6] arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp

2020-06-05 Thread Sharat Masetty
Add opp-peak-kBps bindings to the GPU opp table, listing the peak GPU -> DDR bandwidth requirement for each opp level. This will be used to scale the DDR bandwidth along with the GPU frequency dynamically. Signed-off-by: Sharat Masetty Reviewed-by: Matthias Kaehlcke ---

[PATCH v3 2/6] drm: msm: a6xx: send opp instead of a frequency

2020-06-05 Thread Sharat Masetty
This patch changes the plumbing to send the devfreq recommended opp rather than the frequency. Also consolidate and rearrange the code in a6xx to set the GPU frequency and the icc vote in preparation for the upcoming changes for GPU->DDR scaling votes. Signed-off-by: Sharat Masetty ---

[PATCH v3 0/6] Add support for GPU DDR BW scaling

2020-06-05 Thread Sharat Masetty
This is a respin of [1]. Incorported review feedback and fixed issues observed during testing. Picked up the Georgi's series from opp/linux-next [2], and this series is also dependent on a helper function needed to set and clear ddr bandwidth vote [3]. Patch number 4 in the series adds support for

[Bug 206987] [drm] [amdgpu] Whole system crashes when the driver is in mode_support_and_system_configuration

2020-06-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206987 --- Comment #27 from yao...@protonmail.com --- Created attachment 289535 --> https://bugzilla.kernel.org/attachment.cgi?id=289535=edit systemd journal from crash Update: got a whole system crash again when I was starting up SteamVR. So I guess

Re: [PATCH 53/59] drm/arc: Move to drm/tiny

2020-06-05 Thread Daniel Vetter
Hi Eugeniy, Thanks for testing. I looked at the second one (I hoped it would just magically disappear) and I still don't understand what's going on there. My patch series isn't touching that area at all, so really confused. I squashed in the bugfix from the previous round into the right patches,

[drm-intel:drm-intel-next-queued 1/7] drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:933:21: error: unused function 'unmask_page'

2020-06-05 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: 84d24cb5247a356a4310a25761f8aa56b8814538 commit: 9e0f9464e2ab36b864359a59b0e9058fdef0ce47 [1/7] drm/i915/gem: Async GPU relocations only config: x86_64-randconfig-a011-20200605 (attached as .config) compiler: clang

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-05 Thread Laurent Pinchart
On Fri, Jun 05, 2020 at 03:29:00PM +0200, Jacopo Mondi wrote: > Hello Eugeniu, >sorry for the late reply > > On Wed, May 27, 2020 at 09:15:55AM +0200, Eugeniu Rosca wrote: > > Hi Jacopo, > > > > On Tue, Oct 15, 2019 at 12:46:13PM +0200, Jacopo Mondi wrote: > > 8<--- > > > > > * Testing >

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-05 Thread Christian König
Am 05.06.20 um 16:29 schrieb Andrey Grodzovsky: On 5/11/20 2:45 AM, Christian König wrote: Am 09.05.20 um 20:51 schrieb Andrey Grodzovsky: Signed-off-by: Andrey Grodzovsky ---   drivers/gpu/drm/ttm/ttm_bo.c    | 22 +-   include/drm/ttm/ttm_bo_driver.h |  2 ++   2 files

Re: [PATCH v3] drm: document how user-space should use link-status

2020-06-05 Thread Pekka Paalanen
> > > > I'm not 100% sure the paragraph about not resetting link-status or not > > using ALLOW_MODESET is accurate. Just like the previous version, this > > is just an attempt at documenting the current kernel behaviour. > > > > drivers/gpu/drm/drm_connector.c | 20 > > 1

Re: [PATCH v3 004/105] clk: bcm: Add BCM2711 DVP driver

2020-06-05 Thread Eric Anholt
On Wed, May 27, 2020 at 8:49 AM Maxime Ripard wrote: > > The HDMI block has a block that controls clocks and reset signals to the > HDMI0 and HDMI1 controllers. > > Let's expose that through a clock driver implementing a clock and reset > provider. > > Cc: Michael Turquette > Cc: Stephen Boyd >

Re: [PATCH 1/3] drm/dsi: use stack buffer in mipi_dsi_dcs_write()

2020-06-05 Thread Thierry Reding
On Thu, May 28, 2020 at 05:47:41PM +0100, Emil Velikov wrote: > On Tue, 5 May 2020 at 17:05, Emil Velikov wrote: > > > > Currently the function heap allocates when we have any payload. Where in > > many case the payload is 1 byte - ouch. > > > > From casual observation, vast majority of the

Re: [PATCH 3/3] drm/mipi: use dcs write for mipi_dsi_dcs_set_tear_scanline

2020-06-05 Thread Thierry Reding
On Tue, May 05, 2020 at 05:03:29PM +0100, Emil Velikov wrote: > From: Emil Velikov > > The helper uses the MIPI_DCS_SET_TEAR_SCANLINE, although it's currently > using the generic write. This does not look right. > > Perhaps some platforms don't distinguish between the two writers? I don't

Re: [PATCH 1/3] drm/dsi: use stack buffer in mipi_dsi_dcs_write()

2020-06-05 Thread Thierry Reding
On Tue, May 05, 2020 at 05:03:27PM +0100, Emil Velikov wrote: > Currently the function heap allocates when we have any payload. Where in > many case the payload is 1 byte - ouch. > > From casual observation, vast majority of the payloads are smaller than > 8 bytes - so use a stack array tx[8] to

Re: [PATCH 10/14] drm/mgag200: Move device init and cleanup to mgag200_drv.c

2020-06-05 Thread Thomas Zimmermann
Hi Sam Am 05.06.20 um 16:45 schrieb Sam Ravnborg: > On Fri, Jun 05, 2020 at 03:57:59PM +0200, Thomas Zimmermann wrote: >> Moving the initializer and cleanup functions for device instances >> to mgag200_drv.c prepares for the conversion to managed code. No >> functional changes are made. Remove

Re: [PATCH v1 4/6] drm: panel-simple: add Hitachi 3.5" QVGA panel

2020-06-05 Thread Sam Ravnborg
Hi Doug. On Mon, Jun 01, 2020 at 05:30:53PM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jun 1, 2020 at 1:33 AM Sam Ravnborg wrote: > > > > This panel is used on evaluation boards for Atmel at91sam9261 and > > at91sam6263. > > > > Signed-off-by: Sam Ravnborg > > Cc: Thierry Reding > > Cc:

Re: [PATCH v1 2/6] drm: panel-simple: add Seiko 70WVW2T 7" simple panel

2020-06-05 Thread Sam Ravnborg
Hi Doug. On Mon, Jun 01, 2020 at 05:31:06PM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jun 1, 2020 at 1:33 AM Sam Ravnborg wrote: > > > > The Seiko 70WVW2T is a discontinued product, but may be used somewhere. > > Tested on a proprietary product. > > > > Signed-off-by: Sam Ravnborg > > Cc:

Re: [PATCH 07/14] drm/mgag200: Switch to managed MM

2020-06-05 Thread Daniel Vetter
On Fri, Jun 05, 2020 at 03:57:56PM +0200, Thomas Zimmermann wrote: > The memory-management code now cleans up automatically as part of > device destruction. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/mgag200/mgag200_drv.h | 1 - > drivers/gpu/drm/mgag200/mgag200_main.c | 5

Re: [PATCH 2/2] drm/panel: simple: Add support for KOE TX26D202VM0BWA panel

2020-06-05 Thread Sam Ravnborg
Hi Emil. > > + .width = 217, > > + .height = 136, > > + }, > > + .delay = { > > + .prepare = 1000, > > + .enable = 1000, > > + .unprepare = 1000, > > + .disable = 1000, > Ouch 1s for each delay is

Re: [PATCH 0/2] drm/panel: simple: Add a KOE WUXGA 10.1" LVDS panel support

2020-06-05 Thread Sam Ravnborg
On Mon, Jun 01, 2020 at 02:09:35PM +0800, Liu Ying wrote: > This patch set adds a KOE WUXGA 10.1" LVDS panel support. > The panel type is TX26D202VM0BWA. > The panel has dual LVDS channels. > > My panel is manufactured by US Micro Products(USMP). There is a tag at > the back of the panel, which

Re: [PATCH v3 00/43] Convert most CMA-based drivers to GEM object functions

2020-06-05 Thread Emil Velikov
Hi Thomas, On Fri, 5 Jun 2020 at 08:33, Thomas Zimmermann wrote: > > Most of the CMA-based drivers use the default implementation for the > callbacks in struct drm_driver. With this patch, these interfaces are > initialized with a common helper macro and GEM object functions replace > several

Re: [PATCH v2 20/22] drm: mxsfb: Merge mxsfb_set_pixel_fmt() and mxsfb_set_bus_fmt()

2020-06-05 Thread Emil Velikov
Hi Laurent, With the previous disclaimer in mind, the series is: Reviewed-by: Emil Velikov There's a small suggestion inline, for future work. On Sat, 30 May 2020 at 04:11, Laurent Pinchart wrote: > switch (bus_format) { > case MEDIA_BUS_FMT_RGB565_1X16: > - reg

Re: [PATCH 00/14] drm/mgag200: Use managed interfaces for auto-cleanup

2020-06-05 Thread Sam Ravnborg
Hi Thomas. On Fri, Jun 05, 2020 at 03:57:49PM +0200, Thomas Zimmermann wrote: > This patchset cleans up mgag200 device initialization, embeds the > DRM device instance in struct mga_device and finally converts device > initialization to managed interfaces. > > Patches 1 and 2 are actually

Re: [PATCH 10/14] drm/mgag200: Move device init and cleanup to mgag200_drv.c

2020-06-05 Thread Sam Ravnborg
On Fri, Jun 05, 2020 at 03:57:59PM +0200, Thomas Zimmermann wrote: > Moving the initializer and cleanup functions for device instances > to mgag200_drv.c prepares for the conversion to managed code. No > functional changes are made. Remove mgag200_main.c, which is now > empty. The functions are

Re: [PATCH 09/14] drm/mgag200: Prefix global names in mgag200_drv.c with mgag200_

2020-06-05 Thread Sam Ravnborg
On Fri, Jun 05, 2020 at 03:57:58PM +0200, Thomas Zimmermann wrote: > The naming of global symbols in mgag200_drv.c is inconsistent. Fix > that by prefixing all names with mgag200_. Hmm, static symbols are hardly global symbols. Patch is fine, but changelog seems a litte off. Sam > >

Re: [PATCH] dma-fence: basic lockdep annotations

2020-06-05 Thread Intel
On 6/5/20 3:29 PM, Daniel Vetter wrote: Design is similar to the lockdep annotations for workers, but with some twists: - We use a read-lock for the execution/worker/completion side, so that this explicit annotation can be more liberally sprinkled around. With read locks lockdep isn't

Re: [PATCH v3 01/43] drm/cma-helper: Rename symbols from drm_cma_gem_ to drm_gem_cma_

2020-06-05 Thread Thomas Zimmermann
Hi Am 05.06.20 um 16:23 schrieb Sam Ravnborg: > On Fri, Jun 05, 2020 at 04:15:46PM +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 05.06.20 um 10:40 schrieb Laurent Pinchart: >>> Hi Thomas, >>> >>> Thank you for the patch. >>> >>> On Fri, Jun 05, 2020 at 09:32:05AM +0200, Thomas Zimmermann wrote:

Re: [Intel-gfx] [PATCH] drm/i915: Fix comments mentioning typo in IS_ENABLED()

2020-06-05 Thread Chris Wilson
Quoting Kees Cook (2020-06-05 15:19:53) > This has no code changes, but the typo is clearly getting copy/pasted, > so better to avoid this now and fix the typo. IS_ENABLED() takes full > names, and must have the "CONFIG_" prefix. > > Reported-by: Joe Perches > Link: >

Re: [PATCH 06/14] drm/mgag200: Merge VRAM setup into MM initialization

2020-06-05 Thread Sam Ravnborg
Hi Thomas. Some parts I did not understand here. On Fri, Jun 05, 2020 at 03:57:55PM +0200, Thomas Zimmermann wrote: > The VRAM setup in mgag200_drv.c is part of memory management and > should be done in the same place. Merge the code into the memory > management's init function. > >

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-05 Thread Andrey Grodzovsky
On 5/11/20 2:45 AM, Christian König wrote: Am 09.05.20 um 20:51 schrieb Andrey Grodzovsky: Signed-off-by: Andrey Grodzovsky ---   drivers/gpu/drm/ttm/ttm_bo.c    | 22 +-   include/drm/ttm/ttm_bo_driver.h |  2 ++   2 files changed, 23 insertions(+), 1 deletion(-) diff

Re: [PATCH v3 01/43] drm/cma-helper: Rename symbols from drm_cma_gem_ to drm_gem_cma_

2020-06-05 Thread Sam Ravnborg
On Fri, Jun 05, 2020 at 04:15:46PM +0200, Thomas Zimmermann wrote: > Hi > > Am 05.06.20 um 10:40 schrieb Laurent Pinchart: > > Hi Thomas, > > > > Thank you for the patch. > > > > On Fri, Jun 05, 2020 at 09:32:05AM +0200, Thomas Zimmermann wrote: > >> This fixes the naming of several symbols

[PATCH] drm/i915: Fix comments mentioning typo in IS_ENABLED()

2020-06-05 Thread Kees Cook
This has no code changes, but the typo is clearly getting copy/pasted, so better to avoid this now and fix the typo. IS_ENABLED() takes full names, and must have the "CONFIG_" prefix. Reported-by: Joe Perches Link:

Re: [PATCH v3 01/43] drm/cma-helper: Rename symbols from drm_cma_gem_ to drm_gem_cma_

2020-06-05 Thread Thomas Zimmermann
Hi Am 05.06.20 um 10:40 schrieb Laurent Pinchart: > Hi Thomas, > > Thank you for the patch. > > On Fri, Jun 05, 2020 at 09:32:05AM +0200, Thomas Zimmermann wrote: >> This fixes the naming of several symbols within CMA helpers. No functional >> changes are made. >> >> Signed-off-by: Thomas

Re: [v2] drm/msm: add shutdown support for display platform_driver

2020-06-05 Thread Emil Velikov
On Tue, 2 Jun 2020 at 17:10, Sai Prakash Ranjan wrote: > > Hi Emil, > > On 2020-06-02 21:09, Emil Velikov wrote: > > On Tue, 2 Jun 2020 at 15:49, Sai Prakash Ranjan > > wrote: > >> > >> Hi Emil, > >> > >> On 2020-06-02 19:43, Emil Velikov wrote: > >> > Hi Krishna, > >> > > >> > On Tue, 2 Jun

Re: [PATCH v2 1/2] drm: vmwgfx: remove drm_driver::master_set() return typ

2020-06-05 Thread Emil Velikov
On Wed, 3 Jun 2020 at 19:37, Roland Scheidegger wrote: > > Looks like a nice cleanup to me. (No idea if at some point there > actually was a reason for a return value...) > It was required up-to quite recently actually: commit 9c84aeba67cce6514374f134c9ce2c5f35ac3831 Author: Thomas Hellstrom

Re: [PATCH v2 22/22] drm: mxsfb: Support the alpha plane

2020-06-05 Thread Emil Velikov
On Tue, 2 Jun 2020 at 23:43, Laurent Pinchart wrote: > > Hi Emil, > > On Sun, May 31, 2020 at 05:54:04PM +0100, Emil Velikov wrote: > > HI Laurent, > > > > From a quick glance the series looks really good and neat. > > Thank you :-) > > > Then again, I don't know much about the hardware to

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-05 Thread Jacopo Mondi
Hi Eugeniu On Fri, Jun 05, 2020 at 03:41:24PM +0200, Eugeniu Rosca wrote: > Hi Jacopo, > > On Fri, Jun 05, 2020 at 03:29:00PM +0200, Jacopo Mondi wrote: > > On Wed, May 27, 2020 at 09:15:55AM +0200, Eugeniu Rosca wrote: > > > Could you kindly share the cross compilation steps for your kmsxx fork?

[PATCH 01/14] drm/mgag200: Remove declaration of mgag200_mmap() from header file

2020-06-05 Thread Thomas Zimmermann
Commit 94668ac796a5 ("drm/mgag200: Convert mgag200 driver to VRAM MM") removed the implementation of mgag200_mmap(). Also remove the declaration. Signed-off-by: Thomas Zimmermann Fixes: 94668ac796a5 ("drm/mgag200: Convert mgag200 driver to VRAM MM") Cc: Gerd Hoffmann Cc: Dave Airlie Cc:

[PATCH 10/14] drm/mgag200: Move device init and cleanup to mgag200_drv.c

2020-06-05 Thread Thomas Zimmermann
Moving the initializer and cleanup functions for device instances to mgag200_drv.c prepares for the conversion to managed code. No functional changes are made. Remove mgag200_main.c, which is now empty. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/Makefile | 3 +-

[PATCH 09/14] drm/mgag200: Prefix global names in mgag200_drv.c with mgag200_

2020-06-05 Thread Thomas Zimmermann
The naming of global symbols in mgag200_drv.c is inconsistent. Fix that by prefixing all names with mgag200_. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH 14/14] drm/mgag200: Use managed device initialization

2020-06-05 Thread Thomas Zimmermann
The mgag200 driver now uses managed functions for DRM devices. The individual helpers for modesetting and memory managed are already covered, so only device allocation and initialization is left for conversion. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.c | 30

[PATCH 04/14] drm/mgag200: Rename mgag200_ttm.c to mgag200_mm.c

2020-06-05 Thread Thomas Zimmermann
The mgag200 driver does not use TTM any longer. Rename the related file to mgag200_mm.c (as in 'memory management'). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/Makefile| 4 ++-- drivers/gpu/drm/mgag200/mgag200_drv.h | 1 +

[PATCH 11/14] drm/mgag200: Separate device initialization into allocation

2020-06-05 Thread Thomas Zimmermann
Embedding the DRM device instance in struct mga_device will require changes to device allocation. Moving the device initialization into its own functions gets it out of the way. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.c | 32 ++- 1 file

[PATCH 08/14] drm/mgag200: Separate DRM and PCI functionality from each other

2020-06-05 Thread Thomas Zimmermann
Moving the DRM driver structures from the middle of the PCI code to the top of the file makes it more readable. Also remove an obsolete comment. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.c | 42 +-- 1 file changed, 21 insertions(+), 21

[PATCH 13/14] drm/mgag200: Embed instance of struct drm_device in struct mga_device

2020-06-05 Thread Thomas Zimmermann
Following current best practice, the instance of struct drm_device is now embedded in struct mga_device. The respective field has been renamed from 'dev' to 'base' to reflect the relationship. Conversion from DRM device is done via upcast. Using dev_private is no longer possible. The patch also

[PATCH 02/14] drm/mgag200: Remove mgag200_cursor.c

2020-06-05 Thread Thomas Zimmermann
Support for HW cursors got remove by commit 5a77e2bfdd4f ("drm/mgag200: Remove HW cursor") Apparently the source file was not deleted. Removed it now. Signed-off-by: Thomas Zimmermann Fixes: 5a77e2bfdd4f ("drm/mgag200: Remove HW cursor") Cc: Sam Ravnborg Cc: Emil Velikov Cc: Dave Airlie Cc:

[PATCH 05/14] drm/mgag200: Lookup VRAM PCI BAR start and length only once

2020-06-05 Thread Thomas Zimmermann
The MM setup code on mgag200 reads PCI BAR 0's start and length several times. Reusing these values makes the code more readable. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mm.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH 03/14] drm/mgag200: Use pcim_enable_device()

2020-06-05 Thread Thomas Zimmermann
Using the managed function simplifies the error handling. After unloading the driver, the PCI device should now get disabled as well. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git

[PATCH 12/14] drm/mgag200: Allocate device structures in mgag200_driver_load()

2020-06-05 Thread Thomas Zimmermann
Instances of struct drm_device and struct mga_device are now allocated next to each other in mgag200_driver_load(). Yet another preparation before embedding the DRM device instance in struct mga_device. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.c | 38

[PATCH 07/14] drm/mgag200: Switch to managed MM

2020-06-05 Thread Thomas Zimmermann
The memory-management code now cleans up automatically as part of device destruction. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 1 - drivers/gpu/drm/mgag200/mgag200_main.c | 5 + drivers/gpu/drm/mgag200/mgag200_mm.c | 28 ++ 3

[PATCH 06/14] drm/mgag200: Merge VRAM setup into MM initialization

2020-06-05 Thread Thomas Zimmermann
The VRAM setup in mgag200_drv.c is part of memory management and should be done in the same place. Merge the code into the memory management's init function. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_main.c | 75 --

[PATCH 00/14] drm/mgag200: Use managed interfaces for auto-cleanup

2020-06-05 Thread Thomas Zimmermann
This patchset cleans up mgag200 device initialization, embeds the DRM device instance in struct mga_device and finally converts device initialization to managed interfaces. Patches 1 and 2 are actually unrelated. Both remove artifacts that got lost from earlier patch series. We're fixing this

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-05 Thread Jacopo Mondi
Hello Eugeniu, sorry for the late reply On Wed, May 27, 2020 at 09:15:55AM +0200, Eugeniu Rosca wrote: > Hi Jacopo, > > On Tue, Oct 15, 2019 at 12:46:13PM +0200, Jacopo Mondi wrote: > 8<--- > > > * Testing > > I have tested by injecting a color inversion LUT table and > >

[PATCH] dma-fence: basic lockdep annotations

2020-06-05 Thread Daniel Vetter
Design is similar to the lockdep annotations for workers, but with some twists: - We use a read-lock for the execution/worker/completion side, so that this explicit annotation can be more liberally sprinkled around. With read locks lockdep isn't going to complain if the read-side isn't

Re: MIPI DSI, DBI, and tinydrm drivers

2020-06-05 Thread Noralf Trønnes
Hi Emil, Den 03.06.2020 22.25, skrev Emil Velikov: > Hi Noralf, > > On Wed, 3 Jun 2020 at 13:15, Noralf Trønnes wrote: >> >> Den 28.05.2020 17.27, skrev Emil Velikov: >>> On Sun, 24 May 2020 at 19:35, Daniel Vetter wrote: On Sun, May 24, 2020 at 7:46 PM Noralf Trønnes wrote: >

Re: [PATCH 13/18] drm/amdgpu/dc: Stop dma_resv_lock inversion in commit_tail

2020-06-05 Thread Daniel Vetter
On Fri, Jun 5, 2020 at 10:30 AM Pierre-Eric Pelloux-Prayer wrote: > > Hi Daniel, > > On 04/06/2020 10:12, Daniel Vetter wrote: > [...] > > @@ -6910,7 +6910,11 @@ static void amdgpu_dm_commit_planes(struct > > drm_atomic_state *state, > >* explicitly on fences instead > >

[PATCH 1/2] drm: cleanup on drm_mode_object_find

2020-06-05 Thread Ramalingam C
Redundant wrapper for drm_mode_object_find is removed. Signed-off-by: Ramalingam C --- drivers/gpu/drm/drm_crtc_internal.h | 6 ++--- drivers/gpu/drm/drm_framebuffer.c | 2 +- drivers/gpu/drm/drm_mode_object.c | 38 +++-- drivers/gpu/drm/drm_property.c | 6

[PATCH 2/2] drm: Fix kdoc typo for drm_properties

2020-06-05 Thread Ramalingam C
Typo in the KDoc for the DRM_MODE_PROP_SIGNED_RANGE type of drm_properties is fixed. Signed-off-by: Ramalingam C --- include/drm/drm_property.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h index

Re: [PATCH v3 4/6] drm: Add Generic USB Display driver

2020-06-05 Thread Noralf Trønnes
Den 02.06.2020 20.38, skrev Peter Stuge: > Alan Stern wrote: A gadget driver can STALL in response to a control-OUT data packet, but only before it has seen the packet. >>> >>> How can it do that for OUT, and IN if possible there too? >> >> In the way described just above: The gadget

Re: [PATCH v3 09/13] device core: Introduce multiple dma pfn offsets

2020-06-05 Thread Jim Quinlan
Hi Andy, On Thu, Jun 4, 2020 at 11:05 AM Andy Shevchenko wrote: > > On Thu, Jun 04, 2020 at 10:35:12AM -0400, Jim Quinlan wrote: > > On Thu, Jun 4, 2020 at 9:53 AM Nicolas Saenz Julienne > > wrote: > > > On Wed, 2020-06-03 at 15:20 -0400, Jim Quinlan wrote: > > ... > > > > > + phys =

Re: [PATCH v3 09/13] device core: Introduce multiple dma pfn offsets

2020-06-05 Thread Jim Quinlan
Hi Dan, On Thu, Jun 4, 2020 at 7:06 AM Dan Carpenter wrote: > > On Wed, Jun 03, 2020 at 03:20:41PM -0400, Jim Quinlan wrote: > > @@ -786,7 +787,7 @@ static int sun4i_backend_bind(struct device *dev, > > struct device *master, > > const struct sun4i_backend_quirks *quirks; > > struct

Re: [PATCH v3 09/13] device core: Introduce multiple dma pfn offsets

2020-06-05 Thread Jim Quinlan
On Thu, Jun 4, 2020 at 9:53 AM Nicolas Saenz Julienne wrote: > > Hi Jim, > > On Wed, 2020-06-03 at 15:20 -0400, Jim Quinlan wrote: > > The new field in struct device 'dma_pfn_offset_map' is used to facilitate > > the use of multiple pfn offsets between cpu addrs and dma addrs. It > > subsumes

Re: [PATCH v3 09/13] device core: Introduce multiple dma pfn offsets

2020-06-05 Thread Jim Quinlan
Hi Nicolas, On Thu, Jun 4, 2020 at 12:52 PM Nicolas Saenz Julienne wrote: > > Hi Jim, > > On Thu, 2020-06-04 at 10:35 -0400, Jim Quinlan wrote: > > [...] > > > > > --- a/arch/sh/kernel/dma-coherent.c > > > > +++ b/arch/sh/kernel/dma-coherent.c > > > > @@ -14,6 +14,8 @@ void

Re: [PATCH v3 09/13] device core: Introduce multiple dma pfn offsets

2020-06-05 Thread Jim Quinlan
On Thu, Jun 4, 2020 at 10:20 AM Dan Carpenter wrote: > > On Thu, Jun 04, 2020 at 09:48:49AM -0400, Jim Quinlan wrote: > > > > + r = devm_kcalloc(dev, 1, sizeof(struct dma_pfn_offset_region), > > > > + GFP_KERNEL); > > > > > > Use:r = devm_kzalloc(dev, sizeof(*r),

Re: [PATCH v3 01/43] drm/cma-helper: Rename symbols from drm_cma_gem_ to drm_gem_cma_

2020-06-05 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, Jun 05, 2020 at 09:32:05AM +0200, Thomas Zimmermann wrote: > This fixes the naming of several symbols within CMA helpers. No functional > changes are made. > > Signed-off-by: Thomas Zimmermann Thank you for the patch. Speaking of naming, I wish we

Re: [PATCH v2 1/1] drm/mm: add ig_frag selftest

2020-06-05 Thread Christian König
Am 05.06.20 um 10:18 schrieb Nirmoy: On 6/5/20 9:45 AM, Christian König wrote: Am 03.06.20 um 12:32 schrieb Nirmoy Das: This patch introduces fragmentation in the address range and measures time taken by 10k and 20k insertions. ig_frag() will fail if the time taken by 20k insertions takes

Re: [PATCH v3 43/43] drm: Remove struct drm_driver.gem_print_info

2020-06-05 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, Jun 05, 2020 at 09:32:47AM +0200, Thomas Zimmermann wrote: > The .gem_print_info callback in struct drm_driver is obsolete and has > no users left. Remove it. I like code removal :-) Looking forward to the removal of more GEM-related fields from

Re: [PATCH 13/18] drm/amdgpu/dc: Stop dma_resv_lock inversion in commit_tail

2020-06-05 Thread Pierre-Eric Pelloux-Prayer
Hi Daniel, On 04/06/2020 10:12, Daniel Vetter wrote: [...] > @@ -6910,7 +6910,11 @@ static void amdgpu_dm_commit_planes(struct > drm_atomic_state *state, >* explicitly on fences instead >* and in general should be called for >* blocking commit to

Re: [PATCH v3 29/43] drm/rcar-du: Use GEM CMA object functions

2020-06-05 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, Jun 05, 2020 at 09:32:33AM +0200, Thomas Zimmermann wrote: > Create GEM objects with drm_gem_cma_create_object_default_funcs(), which > allocates the object and sets CMA's default object functions. Corresponding > callbacks in struct drm_driver are

Re: [PATCH v3 31/43] drm/shmobile: Use GEM CMA object functions

2020-06-05 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, Jun 05, 2020 at 09:32:35AM +0200, Thomas Zimmermann wrote: > Create GEM objects with drm_gem_cma_create_object_default_funcs(), which > allocates the object and sets CMA's default object functions. Corresponding > callbacks in struct drm_driver are

Re: [PATCH v2 1/1] drm/mm: add ig_frag selftest

2020-06-05 Thread Nirmoy
On 6/5/20 9:45 AM, Christian König wrote: Am 03.06.20 um 12:32 schrieb Nirmoy Das: This patch introduces fragmentation in the address range and measures time taken by 10k and 20k insertions. ig_frag() will fail if the time taken by 20k insertions takes more than 4 times of 10k insertions as we

Re: [PATCH v3 03/43] drm/cma-helper: Add DRM_GEM_CMA_DRIVER_OPS to set default GEM CMA functions

2020-06-05 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, Jun 05, 2020 at 09:32:07AM +0200, Thomas Zimmermann wrote: > The macro to DRM_GEM_CMA_DRIVER_OPS sets GEM callbacks in struct drm_driver > to their defaults for CMA. An variant of the macro is provided for drivers s/An variant/A variant/ > that

Re: [PATCH v3 30/43] drm/rcar-du: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE

2020-06-05 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, Jun 05, 2020 at 09:32:34AM +0200, Thomas Zimmermann wrote: > DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE sets the functions in > struct drm_driver to their defaults. No functional changes are > made. > > v2: > * update for

Re: [PATCH v3 32/43] drm/shmobile: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS

2020-06-05 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, Jun 05, 2020 at 09:32:36AM +0200, Thomas Zimmermann wrote: > DRM_GEM_CMA_DRIVER_OPS sets the functions in struct drm_driver > to their defaults. No functional changes are made. > > Signed-off-by: Thomas Zimmermann > Acked-by: Emil Velikov

Re: Dynamically change enumeration list of DRM enumeration property

2020-06-05 Thread Pekka Paalanen
On Wed, 03 Jun 2020 20:20:44 + (UTC) Jonas Karlman wrote: > Hi, > > On 2020-06-03 11:12, Pekka Paalanen wrote: > > On Wed, 3 Jun 2020 10:50:28 +0530 > > Yogish Kulkarni wrote: > > ... > >> The primary reason for why content producer masters video/gfx content as > >> limited range is

Re: [PATCH v2 1/1] drm/mm: add ig_frag selftest

2020-06-05 Thread Christian König
Am 03.06.20 um 12:32 schrieb Nirmoy Das: This patch introduces fragmentation in the address range and measures time taken by 10k and 20k insertions. ig_frag() will fail if the time taken by 20k insertions takes more than 4 times of 10k insertions as we know that insertions should at most scale

[PATCH v3 30/43] drm/rcar-du: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE

2020-06-05 Thread Thomas Zimmermann
DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE sets the functions in struct drm_driver to their defaults. No functional changes are made. v2: * update for DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE Signed-off-by: Thomas Zimmermann Tested-by: Kieran Bingham Acked-by: Emil Velikov ---

[PATCH v3 27/43] drm/mxsfb: Use GEM CMA object functions

2020-06-05 Thread Thomas Zimmermann
Create GEM objects with drm_gem_cma_create_object_default_funcs(), which allocates the object and sets CMA's default object functions. Corresponding callbacks in struct drm_driver are cleared. No functional changes are made. Driver and object-function instances use the same callback functions,

[PATCH v3 21/43] drm/malidp: Use GEM CMA object functions

2020-06-05 Thread Thomas Zimmermann
Create GEM objects with drm_gem_cma_create_object_default_funcs(), which allocates the object and sets CMA's default object functions. Corresponding callbacks in struct drm_driver are cleared. No functional changes are made. Driver and object-function instances use the same callback functions,

[PATCH v3 20/43] drm/komeda: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE

2020-06-05 Thread Thomas Zimmermann
DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE sets the functions in struct drm_driver to their defaults. No functional changes are made. v2: * update for DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE Signed-off-by: Thomas Zimmermann Acked-by: Liviu Dudau Acked-by: Emil Velikov ---

[PATCH v3 15/43] drm/imx: Use GEM CMA object functions

2020-06-05 Thread Thomas Zimmermann
Create GEM objects with drm_gem_cma_create_object_default_funcs(), which allocates the object and sets CMA's default object functions. Corresponding callbacks in struct drm_driver are cleared. No functional changes are made. Driver and object-function instances use the same callback functions,

[PATCH v3 12/43] drm/hisilicon/kirin: Set .dumb_create to drm_gem_cma_dumb_create()

2020-06-05 Thread Thomas Zimmermann
The kirin drivers uses drm_gem_cma_dumb_create_internal() for its .dumb_create implementation. The function is meant for internal use only by drivers that require additional buffer setup. Kirin does not do an additional setup, so convert it over to drm_gem_cma_dumb_create(). Signed-off-by:

[PATCH v3 17/43] drm/ingenic: Use GEM CMA object functions

2020-06-05 Thread Thomas Zimmermann
Create GEM objects with drm_gem_cma_create_object_default_funcs(), which allocates the object and sets CMA's default object functions. Corresponding callbacks in struct drm_driver are cleared. No functional changes are made. Driver and object-function instances use the same callback functions,

[PATCH v3 14/43] drm/hisilicon/kirin: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS

2020-06-05 Thread Thomas Zimmermann
DRM_GEM_CMA_DRIVER_OPS sets the functions in struct drm_driver to their defaults. No functional changes are made. v2: * use DRM_GEM_CMA_DRIVER_OPS Signed-off-by: Thomas Zimmermann Tested-by: John Stultz Acked-by: Emil Velikov Cc: Xu YiPing Cc: Rongrong Zou Cc: Xinliang Liu ---

[PATCH v3 42/43] drm/zte: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS

2020-06-05 Thread Thomas Zimmermann
DRM_GEM_CMA_DRIVER_OPS sets the functions in struct drm_driver to their defaults. No functional changes are made. Signed-off-by: Thomas Zimmermann Acked-by: Emil Velikov --- drivers/gpu/drm/zte/zx_drm_drv.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH v3 25/43] drm/meson: Use GEM CMA object functions

2020-06-05 Thread Thomas Zimmermann
Create GEM objects with drm_gem_cma_create_object_default_funcs(), which allocates the object and sets CMA's default object functions. Corresponding callbacks in struct drm_driver are cleared. No functional changes are made. Driver and object-function instances use the same callback functions,

[PATCH v3 32/43] drm/shmobile: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS

2020-06-05 Thread Thomas Zimmermann
DRM_GEM_CMA_DRIVER_OPS sets the functions in struct drm_driver to their defaults. No functional changes are made. Signed-off-by: Thomas Zimmermann Acked-by: Emil Velikov --- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH v3 33/43] drm/stm: Use GEM CMA object functions

2020-06-05 Thread Thomas Zimmermann
Create GEM objects with drm_gem_cma_create_object_default_funcs(), which allocates the object and sets CMA's default object functions. Corresponding callbacks in struct drm_driver are cleared. No functional changes are made. Driver and object-function instances use the same callback functions,

[PATCH v3 09/43] drm/atmel-hlcdc: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS

2020-06-05 Thread Thomas Zimmermann
DRM_GEM_CMA_DRIVER_OPS sets the functions in struct drm_driver to their defaults. No functional changes are made. Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg Acked-by: Emil Velikov --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 7 +-- 1 file changed, 1 insertion(+), 6

[PATCH v3 26/43] drm/meson: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE

2020-06-05 Thread Thomas Zimmermann
DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE sets the functions in struct drm_driver to their defaults. No functional changes are made. v2: * update for DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE Signed-off-by: Thomas Zimmermann Acked-by: Emil Velikov Acked-by: Neil Armstrong ---

[PATCH v3 24/43] drm/mcde: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS

2020-06-05 Thread Thomas Zimmermann
DRM_GEM_CMA_DRIVER_OPS sets the functions in struct drm_driver to their defaults. No functional changes are made. Signed-off-by: Thomas Zimmermann Reviewed-by: Linus Walleij Acked-by: Emil Velikov --- drivers/gpu/drm/mcde/mcde_drv.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-)

[PATCH v3 40/43] drm/tve200: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS

2020-06-05 Thread Thomas Zimmermann
DRM_GEM_CMA_DRIVER_OPS sets the functions in struct drm_driver to their defaults. No functional changes are made. Signed-off-by: Thomas Zimmermann Reviewed-by: Linus Walleij Acked-by: Emil Velikov --- drivers/gpu/drm/tve200/tve200_drv.c | 8 +--- 1 file changed, 1 insertion(+), 7

[PATCH v3 23/43] drm/mcde: Use GEM CMA object functions

2020-06-05 Thread Thomas Zimmermann
Create GEM objects with drm_gem_cma_create_object_default_funcs(), which allocates the object and sets CMA's default object functions. Corresponding callbacks in struct drm_driver are cleared. No functional changes are made. Driver and object-function instances use the same callback functions,

[PATCH v3 36/43] drm/sti: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS

2020-06-05 Thread Thomas Zimmermann
DRM_GEM_CMA_DRIVER_OPS sets the functions in struct drm_driver to their defaults. No functional changes are made. Signed-off-by: Thomas Zimmermann Acked-by: Emil Velikov --- drivers/gpu/drm/sti/sti_drv.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

[PATCH v3 28/43] drm/mxsfb: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS

2020-06-05 Thread Thomas Zimmermann
DRM_GEM_CMA_DRIVER_OPS sets the functions in struct drm_driver to their defaults. No functional changes are made. Signed-off-by: Thomas Zimmermann Acked-by: Emil Velikov --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH v3 41/43] drm/zte: Use GEM CMA object functions

2020-06-05 Thread Thomas Zimmermann
Create GEM objects with drm_gem_cma_create_object_default_funcs(), which allocates the object and sets CMA's default object functions. Corresponding callbacks in struct drm_driver are cleared. No functional changes are made. Driver and object-function instances use the same callback functions,

[PATCH v3 39/43] drm/tve200: Use GEM CMA object functions

2020-06-05 Thread Thomas Zimmermann
Create GEM objects with drm_gem_cma_create_object_default_funcs(), which allocates the object and sets CMA's default object functions. Corresponding callbacks in struct drm_driver are cleared. No functional changes are made. Driver and object-function instances use the same callback functions,

  1   2   >