Hi Sam,
On 19-07-20, 19:18, Sam Ravnborg wrote:
> Hi Vinod.
>
> Three trivial points below.
> The rest looks good.
>
> With these fixed you can add:
> Reviewed-by: Sam Ravnborg
Thanks, I will send an update with nits fixed
--
~Vinod
___
dri-devel
On Sun, Jul 19, 2020 at 12:10:08PM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If
https://bugzilla.kernel.org/show_bug.cgi?id=207383
--- Comment #72 from Vinicius (mphant...@yahoo.com.br) ---
Confirming that reverting 3202fa62f, cbfc35a48 and 89b83f282, fixed my
polaris10 too.
Tested with 5.7.8 and 5.7.9, Radeon RX 570.
--
You are receiving this mail because:
You are
Thanks, applied to drm-misc-fixes.
Regards,
Qiang
On Sun, Jul 19, 2020 at 6:41 PM Erico Nunes wrote:
>
> On Sun, Jul 19, 2020 at 9:31 AM Qiang Yu wrote:
> >
> > PP bcast is marked as doing async reset after job is done.
> > When resume after suspend, each PP is reset individually,
> > so no
https://bugzilla.kernel.org/show_bug.cgi?id=208333
--- Comment #11 from Nathan Bryant (nbry...@optonline.net) ---
Applied the patch (from Comment #10 above). Works for me.
--
You are receiving this mail because:
You are watching the assignee of the bug.
https://bugzilla.kernel.org/show_bug.cgi?id=208333
--- Comment #10 from Nathan Bryant (nbry...@optonline.net) ---
Looks like they're working on it
https://lists.freedesktop.org/archives/nouveau/2020-July/036264.html
--
You are receiving this mail because:
You are watching the assignee of the
On Sat, Jul 18, 2020 at 5:43 AM James Jones wrote:
>
> On 7/17/20 12:47 PM, Daniel Vetter wrote:
> > On Fri, Jul 17, 2020 at 11:57:57AM -0700, James Jones wrote:
> >> Accept the DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK()
> >> family of modifiers to handle broken userspace
> >> Xorg modesetting and Mesa
On Fri, Jul 17, 2020 at 9:52 PM Alex Hung wrote:
>
> On 2020-07-17 1:05 p.m., Karol Herbst wrote:
> > It's hard to figure out what systems are actually affected and right now I
> > don't see a good way of removing those...
> >
> > But I'd like to see thos getting removed and drivers fixed instead
Hi Vinod.
Three trivial points below.
The rest looks good.
With these fixed you can add:
Reviewed-by: Sam Ravnborg
Sam
On Wed, Jul 08, 2020 at 04:05:58PM +0530, Vinod Koul wrote:
> Lontium Lt9611 is a DSI to HDMI bridge which supports two DSI ports and
> I2S port as an input and HDMI
Hello,
On 08-07-20, 16:05, Vinod Koul wrote:
> Hi,
>
> This series adds driver and bindings for Lontium LT9611 bridge chip which
> takes MIPI DSI as input and HDMI as output.
>
> This chip can be found in 96boards RB3 platform [1] commonly called DB845c.
Any feedback on this series?
>
> [1]:
https://bugzilla.kernel.org/show_bug.cgi?id=208611
--- Comment #2 from Ivan Molodetskikh (yalt...@gmail.com) ---
(In reply to Alex Deucher from comment #1)
> This is most likely a bug in mesa. The kernel driver is just the messenger.
I have opened a bug report in mesa:
https://bugzilla.kernel.org/show_bug.cgi?id=208611
Alex Deucher (alexdeuc...@gmail.com) changed:
What|Removed |Added
CC|
Hi Steve.
On Thu, Jul 16, 2020 at 10:29:52PM +0200, Sam Ravnborg wrote:
> Hi Steve and others.
>
> On Fri, Jul 10, 2020 at 06:40:26PM -0400, Steve Cohen wrote:
> > BUG: KASAN: use-after-free in drm_gem_open_ioctl
> >
> > There is potential for use-after-free here if the GEM object
> > handle is
Hi Laurent.
On Sat, Jul 11, 2020 at 01:19:35AM +0300, Laurent Pinchart wrote:
> Hi Sam,
>
> Thank you for the patch.
>
> On Fri, Jul 03, 2020 at 09:24:02PM +0200, Sam Ravnborg wrote:
> > Prepare the bridge driver for use in a chained setup by
> > replacing direct use of drm_panel with
[AMD Public Use]
-Original Message-
From: Christian König
Sent: Thursday, July 16, 2020 6:21 PM
To: dri-devel@lists.freedesktop.org
Cc: Chauhan, Madhav
Subject: [PATCH 2/8] drm/radeon: stop using TTM_MEMTYPE_FLAG_MAPPABLE
The driver doesn't expose any not-mapable memory resources.
https://bugzilla.kernel.org/show_bug.cgi?id=208611
Bug ID: 208611
Summary: amdgpu crash on sharing image memory between Vulkan
and OpenGL
Product: Drivers
Version: 2.5
Kernel Version: 5.7.8-200.fc32.x86_64
Hardware:
Hi Guido.
On Sat, Jul 18, 2020 at 08:26:37PM +0200, Guido Günther wrote:
> We don't create a connector but let panel_bridge handle that so there's
> no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR.
>
> Signed-off-by: Guido Günther
Looks good and correct.
Reviewed-by: Sam Ravnborg
If
On Sun, Jul 19, 2020 at 9:31 AM Qiang Yu wrote:
>
> PP bcast is marked as doing async reset after job is done.
> When resume after suspend, each PP is reset individually,
> so no need to reset in PP bcast resume. But I forgot to
> clear the PP bcast async reset mark so call into async wait
>
Hi Paul.
On Sun, Jul 19, 2020 at 11:38:34AM +0200, Paul Cercueil wrote:
> Silence compiler warning about used but uninitialized 'ipu_state'
> variable. In practice, the variable would never be used when
> uninitialized, but the compiler cannot know that 'priv->ipu_plane' will
> always be NULL if
Based on an idea from Emil Velikov
add a helper that checks backlight_is_blank() and return 0 as brightness
if display is blank or the property value if not.
This allows us to simplify the update_status() implementation
in most of the backlight drivers.
Signed-off-by: Sam Ravnborg
Reviewed-by:
Introduce the use of backlight_get_brightness() to simplify
the update_status() operation.
With the simpler implementation drop the gpio_backlight_get_next_brightness()
helper as it was now a one-liner.
Signed-off-by: Sam Ravnborg
Reviewed-by: Daniel Thompson
Cc: Lee Jones
Cc: Daniel Thompson
The backlight support has three properties that express the state:
- power
- state
- fb_blank
It is un-documented and easy to get wrong.
Add backlight_is_blank() helper to make it simpler
for drivers to get the check of the state correct.
A lot of drivers also includes checks for fb_blank.
This
Improve the documentation for backlight_ops and
adapt it to kernel-doc style.
v2:
- Add intro for each field (Daniel)
Signed-off-by: Sam Ravnborg
Reviewed-by: Daniel Thompson
Reviewed-by: Emil Velikov
Cc: Lee Jones
Cc: Daniel Thompson
Cc: Jingoo Han
---
include/linux/backlight.h | 59
The backlight_bl driver required initialization using
struct generic_bl_info. As there are no more references
to this struct there is no users left.
So it is safe to delete the driver.
Signed-off-by: Sam Ravnborg
Reviewed-by: Daniel Thompson
Reviewed-by: Emil Velikov
Cc: Lee Jones
Cc: Daniel
Improve the documentation for backlight_properties and
adapt it to kernel-doc style.
v3:
- Added missing '@' in kernel-doc
v2:
- Added into for each field (Daniel)
- Re-written some parts to explain what to do, rather
than what not to do.
Partly based on suggestions from the review
Use the backlight_is_blank() helper to simplify the code a bit.
The jornada720_bl driver distingush between backlight off
and brightness set to 0.
Thus this driver turn off backlight only when backlight_is_blank()
returns true.
v2:
- Updated changelog (Daniel)
Signed-off-by: Sam Ravnborg
There are no external users of backlight_put().
Drop it and open code the two users in backlight.c.
Signed-off-by: Sam Ravnborg
Reviewed-by: Daniel Thompson
Cc: Lee Jones
Cc: Daniel Thompson
Cc: Jingoo Han
---
drivers/video/backlight/backlight.c | 7 +--
include/linux/backlight.h
cr_bllcd can turn backlight ON or OFF.
Fix semantitics so they equals what we know from gpio-backlight.
brightness == 0 => backlight off
brightness == 1 => backlight on
Use the backlight_get_brightness() helper to simplify the code.
v2:
- reworked to introduce gpio-backlight semantics
There are no external users of of_find_backlight,
as they have all changed to use the managed version.
Make of_find_backlight static to prevent new external users.
v3:
- Move doc for devm_of_find_backlight out of this patch
v2:
- Editorial corrections (Daniel)
- Returns => RETURNS (Daniel)
Add kernel-doc documentation for the backlight enums
v2:
- Add intro to each enum member (Daniel)
Except backlight type as line lenght was too long.
The generated HTML is the same.
Signed-off-by: Sam Ravnborg
Reviewed-by: Daniel Thompson
Reviewed-by: Emil Velikov
Cc: Lee Jones
Cc:
Introduce the backlight_get_brightness() helper in all
video/backlight/* drivers.
This simplifies the code and align the implementation of the
update_status() operation across the different backlight drivers.
Some of the drivers gains a little extra functionality by the change
as they now respect
No need to put "extern" in front of prototypes.
While touching the prototypes adjust indent to follow
the kernel style.
Signed-off-by: Sam Ravnborg
Reviewed-by: Daniel Thompson
Reviewed-by: Emil Velikov
Cc: Lee Jones
Cc: Daniel Thompson
Cc: Jingoo Han
---
include/linux/backlight.h | 35
Improve the documentation for backlight_device and
adapt it to kernel-doc style.
The updated documentation is more strict on how locking is used.
With the update neither update_lock nor ops_lock may be used
outside the backlight core.
This restriction was introduced to keep the locking simple
by
Increase readability of fb_notifier_callback() by removing
a few indent levels.
No functional change.
Signed-off-by: Sam Ravnborg
Reviewed-by: Daniel Thompson
Reviewed-by: Emil Velikov
Cc: Lee Jones
Cc: Daniel Thompson
Cc: Jingoo Han
---
drivers/video/backlight/backlight.c | 43
Replaces the open-coded checks of the state, with the
backlight_get_brightness() helper. This increases readability
of the code and align the functionality across the drivers.
Futhermore drop the debug prints in update_status().
If we need debug printing then we can add it to the backlight core.
Hi all.
Follow-up on v4 - with only a few changes listed below and
in the individual patches.
Thanks for all the reviews and the feedback on the patches!
I am planning a follow-up on this patchset to update the
backlight drivers all over to use backlight_get_brightness()
and backlight_is_blank()
Include backlight so the documentation is now generated
with make htmldocs and friends.
Signed-off-by: Sam Ravnborg
Reviewed-by: Daniel Thompson
Reviewed-by: Emil Velikov
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: David Airlie
Cc: Daniel Vetter
Cc: Jonathan Corbet
Add documentation for the inline functions in backlight.h
v2:
- Fix spelling (Daniel)
Signed-off-by: Sam Ravnborg
Reviewed-by: Daniel Thompson
Reviewed-by: Emil Velikov
Cc: Lee Jones
Cc: Daniel Thompson
Cc: Jingoo Han
---
include/linux/backlight.h | 16
1 file changed,
Add overview chapter to backlight.c.
Update existing kernel-doc to follow a more consistent
style and drop kernel-doc for deprecated functions.
v4:
- Include updated devm_of_find_backlight doc
(was accidently included in a later patch)
v3:
- Updated a few editorial details (Daniel)
v2:
PP bcast is marked as doing async reset after job is done.
When resume after suspend, each PP is reset individually,
so no need to reset in PP bcast resume. But I forgot to
clear the PP bcast async reset mark so call into async wait
before job run and gets timeout.
Fixes: 3446d7e9883d ("drm/lima:
40 matches
Mail list logo
