Re: [PATCH] drm/etnaviv: fix external abort seen on GC600 rev 0x19

2020-08-23 Thread Ing. Josua Mayer
Hi Christian, I have formally tested the patch with 5.7.10 - and it doesn't resolve the issue - sadly :( >From my testing, the reads on VIVS_HI_CHIP_PRODUCT_ID VIVS_HI_CHIP_ECO_ID need to be conditional - while VIVS_HI_CHIP_CUSTOMER_ID seems to be okay. br josau Mayer Am 21.08.20 um 20:17 schri

[PATCH v2 2/6] drm: dsi: Let host and device specify supported bus

2020-08-23 Thread Paul Cercueil
The current MIPI DSI framework can very well be used to support MIPI DBI panels. In order to add support for the various bus types supported by DBI, the DRM panel drivers should specify the bus type they will use, and the DSI host drivers should specify the bus types they are compatible with. The

[PATCH v5 0/2] staging: android: Remove BUG/BUG_ON

2020-08-23 Thread Tomer Samara
Remove BUG/BUG_ON from androind/ion -v5: remove WARN_ON from ion_page_pool_free -v4: some changes based on Dan Carpenter review: - Remove error check at ion_page_pool_remove (conditions are impossible) - Remove error check at opn_page_pool_alloc - restore W

[PATCH v5 2/2] staging: android: Remove BUG from ion_system_heap.c

2020-08-23 Thread Tomer Samara
Remove BUG() from ion_sytem_heap.c this fix the following checkpatch issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

KMSAN: uninit-value in vga16fb_imageblit

2020-08-23 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:ce8056d1 wip: changed copy_from_user where instrumented git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=14fb406190 kernel config: https://syzkaller.appspot.com/x/.

[PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-08-23 Thread Paul Cercueil
This driver is for the Ilitek ILI9341 based YX240QV29-T 2.4" 240x320 TFT LCD panel from Adafruit. v2: - Remove custom handling of backlight - Call drm_panel_disable() / drm_panel_unprepare() on module exit - drm_panel_add() is a void function now Signed-off-by: Paul Cercueil --- drivers

Re: [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

2020-08-23 Thread Randy Dunlap
On 8/22/20 2:34 AM, Tomer Samara wrote: > On Fri, Aug 21, 2020 at 09:25:26AM -0700, Randy Dunlap wrote: >> On 8/21/20 8:28 AM, Tomer Samara wrote: >>> Remove BUG() from ion_sytem_heap.c >>> >>> this fix the following checkpatch issue: >>> Avoid crashing the kernel - try using WARN_ON & >>> recovery

[PATCH] Documentation: fix dma-buf.rst underline length warning

2020-08-23 Thread Randy Dunlap
From: Randy Dunlap /home/rdunlap/lnx/lnx-59-rc2/Documentation/driver-api/dma-buf.rst:182: WARNING: Title underline too short. Indefinite DMA Fences Fixes: 72b6ede73623 ("dma-buf.rst: Document why indefinite fences are a bad idea") Signed-off-by: Randy Dunlap Cc: Daniel Ve

[PATCH v2 0/6] DSI/DBI, panel drivers, & tinyDRM v2

2020-08-23 Thread Paul Cercueil
Hi, Here's a V2 of my patchset that attempts to clean up the current situation with DSI/DBI panels drivers, and tinyDRM. For the record, here is a small sum-up of the current situation: - the current MIPI DBI code (drivers/gpu/drm/drm_mipi_dbi.c) is lagging way behind the MIPI DSI code (driver

Re: [PATCH] drm/bridge/tc358775: Fix for PTR_ERR

2020-08-23 Thread Vinay Simha B N
Thanks Sam. On Sun, Aug 23, 2020 at 8:35 PM Sam Ravnborg wrote: > > On Sun, Aug 16, 2020 at 11:20:41AM +0530, Vinay Simha BN wrote: > > passing zero to 'PTR_ERR' > > > > Reported-by: kernel test robot > > Signed-off-by: Vinay Simha BN > > Applied to drm-misc-next - thanks. > > Sam > > >

[PATCH v4] gpu/drm: ingenic: Add option to mmap GEM buffers cached

2020-08-23 Thread Paul Cercueil
Ingenic SoCs are most notably used in cheap chinese handheld gaming consoles. There, the games and applications generally render in software directly into GEM buffers. Traditionally, GEM buffers are mapped write-combine. Writes to the buffer are accelerated, and reads are slow. Application doing l

Re: [PATCH 12/18] iommu/tegra-gart: Add IOMMU_DOMAIN_DMA support

2020-08-23 Thread Dmitry Osipenko
21.08.2020 03:28, Robin Murphy пишет: ... >> Will a returned NULL tell to IOMMU core that implicit domain shouldn't >> be used? Is it possible to leave this driver as-is? > > The aim of this patch was just to make the conversion without functional > changes wherever possible, i.e. maintain an equi

Re: [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

2020-08-23 Thread Tomer Samara
On Fri, Aug 21, 2020 at 09:25:26AM -0700, Randy Dunlap wrote: > On 8/21/20 8:28 AM, Tomer Samara wrote: > > Remove BUG() from ion_sytem_heap.c > > > > this fix the following checkpatch issue: > > Avoid crashing the kernel - try using WARN_ON & > > recovery code ratherthan BUG() or BUG_ON(). > > >

[PATCH v2 5/6] drm/panel: Add panel driver for NewVision NV3052C based LCDs

2020-08-23 Thread Paul Cercueil
This driver supports the NewVision NV3052C based LCDs. Right now, it only supports the LeadTek LTK035C5444T 2.4" 640x480 TFT LCD panel, which can be found in the Anbernic RG-350M handheld console. v2: - Remove custom backlight handling - Use drm_panel_{disable,unprepare} instead of nv305

[PATCH v2 3/6] drm: Add SPI DBI host driver

2020-08-23 Thread Paul Cercueil
This driver will register a DBI host driver for panels connected over SPI. DBI types c1 and c3 are supported. C1 is a SPI protocol with 9 bits per word, with the data/command information in the 9th (MSB) bit. C3 is a SPI protocol with 8 bits per word, with the data/command information carried by a

Re: [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api

2020-08-23 Thread Tom Murphy
Hi Logan/All, I have added a check for the sg_dma_len == 0 : """ } __sgt_iter(struct scatterlist *sgl, bool dma) { struct sgt_iter s = { .sgp = sgl }; + if (sgl && sg_dma_len(sgl) == 0) + s.sgp = NULL; if (s.sgp) { . """ at location [1]. but it do

Re: [PATCH v12 09/13] drm/msm: Add support to create a local pagetable

2020-08-23 Thread Guenter Roeck
On Mon, Aug 10, 2020 at 04:26:53PM -0600, Jordan Crouse wrote: > Add support to create a io-pgtable for use by targets that support > per-instance pagetables. In order to support per-instance pagetables the > GPU SMMU device needs to have the qcom,adreno-smmu compatible string and > split pagetable

[PATCH v2 4/6] drm/tiny: Add TinyDRM for DSI/DBI panels

2020-08-23 Thread Paul Cercueil
The new API function mipi_dsi_maybe_register_tiny_driver() is supposed to be called by DSI/DBI panel drivers at the end of their probe. If it is detected that the panel is not connected to any controller, because it has no port #0 node in Device Tree that points back to it, then a TinyDRM driver i

[PATCH v5 1/2] staging: android: Remove BUG_ON from ion_page_pool.c

2020-08-23 Thread Tomer Samara
BUG_ON() is removed at ion_page_pool.c Fixes the following issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_page_pool.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/dri

[PATCH -next] amdgpu: fix Documentation builds for pm/ file movement

2020-08-23 Thread Randy Dunlap
From: Randy Dunlap Fix Documentation errors for amdgpu.rst due to file rename (moved to another subdirectory). Error: Cannot open file ../drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c WARNING: kernel-doc '../scripts/kernel-doc -rst -enable-lineno -function hwmon ../drivers/gpu/drm/amd/amdgpu/amdgpu_pm

Re: [PATCH 16/18] staging/media/tegra-vde: Clean up IOMMU workaround

2020-08-23 Thread Dmitry Osipenko
21.08.2020 03:11, Robin Murphy пишет: ... >> Hello, Robin! Thank you for yours work! >> >> Some drivers, like this Tegra VDE (Video Decoder Engine) driver for >> example, do not want to use implicit IOMMU domain. > > That isn't (intentionally) changing here - the only difference should be > that i

[PATCH v2 1/6] dt-bindings: display: Document NewVision NV3052C DT node

2020-08-23 Thread Paul Cercueil
Add documentation for the Device Tree node for LCD panels based on the NewVision NV3052C controller. v2: - Support backlight property - Add *-supply properties for the 5 different power supplies. Either they must all be present, or 'power-supply' must be present. - Reword descr

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-23 Thread Mauro Carvalho Chehab
Hi John, Em Wed, 19 Aug 2020 20:28:44 -0700 John Stultz escreveu: > That said even with the patches I've got on top of your series, I > still see a few issues: > 1) I'm seeing red-blue swap with your driver. I need to dig a bit to > see what the difference is, I know gralloc has a config optio

[Bug 209019] New: [drm:dpcd_set_source_specific_data [amdgpu]] *ERROR* Error in DP aux read transaction, not writing source specific data

2020-08-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209019 Bug ID: 209019 Summary: [drm:dpcd_set_source_specific_data [amdgpu]] *ERROR* Error in DP aux read transaction, not writing source specific data Product: Drivers V

RE: [PATCH -next] amdgpu: fix Documentation builds for pm/ file movement

2020-08-23 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Thanks for fixing this. The patch is reviewed-by: Evan Quan BR Evan -Original Message- From: Randy Dunlap Sent: Monday, August 24, 2020 6:36 AM To: dri-devel ; LKML ; amd-...@lists.freedesktop.org; Deucher, Alexander Cc: Quan, Evan

Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-23 Thread Laurent Pinchart
Hi Tomi, On Fri, Aug 14, 2020 at 12:29:35PM +0300, Tomi Valkeinen wrote: > On 11/08/2020 05:36, Laurent Pinchart wrote: > > >> +static int cdns_mhdp_mailbox_write(struct cdns_mhdp_device *mhdp, u8 val) > >> +{ > >> + int ret, full; > >> + > >> + WARN_ON(!mutex_is_locked(&mhdp->mbox_mutex)); > >

Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-23 Thread Laurent Pinchart
Hi Tomi, On Fri, Aug 14, 2020 at 11:22:09AM +0300, Tomi Valkeinen wrote: > On 11/08/2020 05:36, Laurent Pinchart wrote: > > >> +static int cdns_mhdp_connector_init(struct cdns_mhdp_device *mhdp) > >> +{ > >> + u32 bus_format = MEDIA_BUS_FMT_RGB121212_1X36; > >> + struct drm_connector *conn = &m

Re: [PATCH v2] ARM: dts: r8a7742-iwg21d-q7: Add LCD support

2020-08-23 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Thu, Aug 13, 2020 at 03:00:41PM +0100, Lad Prabhakar wrote: > The iwg21d comes with a 7" capacitive touch screen, therefore > add support for it. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Everything seems to match the

[PATCH] drm: panel: Fix bpc for OrtusTech COM43H4M85ULC panel

2020-08-23 Thread Laurent Pinchart
The OrtusTech COM43H4M85ULC panel is a 18-bit RGB panel. Commit f098f168e91c ("drm: panel: Fix bus format for OrtusTech COM43H4M85ULC panel") has fixed the bus formats, but forgot to address the bpc value. Set it to 6. Fixes: f098f168e91c ("drm: panel: Fix bus format for OrtusTech COM43H4M85ULC p

Re: [PATCH 4/8] dt-bindings: display: mxsfb: Rename to fsl, lcdif.yaml

2020-08-23 Thread Laurent Pinchart
Hi Stefan, On Fri, Aug 21, 2020 at 04:55:38PM +0200, Stefan Agner wrote: > On 2020-08-13 03:29, Laurent Pinchart wrote: > > Rename the mxsfb.yaml binding schema to fsl,lcdif.yaml to match the > > usual bindings naming scheme. > > I tend to prefer to just name it fsl,lcdif.yaml from the get-go. >

Re: [PATCH 2/8] dt-bindings: display: mxsfb: Add and fix compatible strings

2020-08-23 Thread Laurent Pinchart
Hi Stefan, On Fri, Aug 21, 2020 at 04:53:56PM +0200, Stefan Agner wrote: > On 2020-08-13 03:29, Laurent Pinchart wrote: > > Additional compatible strings have been added in DT source for the > > i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings. > > Most of the upstream DT source

Re: dt-bindings: display: xlnx: mixer: Inconsistent pixel format terminology in dt docs

2020-08-23 Thread Laurent Pinchart
Hello, On Thu, Aug 20, 2020 at 04:38:18PM -0700, Hyun Kwon wrote: > On Thursday, August 20, 2020 2:18 PM, Kenneth Sloat write: > > Hello, > > > > The Xilinx Video mixer IP uses the DRM fourcc string as a device tree > > binding in > > order to describe the format for a specific DRM layer/plane.

Re: [RFC] Experimental DMA-BUF Device Heaps

2020-08-23 Thread James Jones
On 8/23/20 1:46 PM, Laurent Pinchart wrote: Hi James, On Sun, Aug 23, 2020 at 01:04:43PM -0700, James Jones wrote: On 8/20/20 1:15 AM, Ezequiel Garcia wrote: On Mon, 2020-08-17 at 20:49 -0700, James Jones wrote: On 8/17/20 8:18 AM, Brian Starkey wrote: On Sun, Aug 16, 2020 at 02:22:46PM -030

[Bug 209017] New: [amdgpu] Black screen when unlocking session

2020-08-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209017 Bug ID: 209017 Summary: [amdgpu] Black screen when unlocking session Product: Drivers Version: 2.5 Kernel Version: 5.8.2 Hardware: All OS: Linux Tree: Mainlin

[Bug 209017] [amdgpu] Black screen when unlocking session

2020-08-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209017 Clément Guérin (li...@protonmail.com) changed: What|Removed |Added Regression|No |Yes -- You are r

Re: [PATCH v2] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM

2020-08-23 Thread Laurent Pinchart
Hi Qian, On Fri, Aug 21, 2020 at 09:20:37PM -0400, Qian Cai wrote: > On Mon, Jun 08, 2020 at 06:16:22AM +0300, Laurent Pinchart wrote: > > Hi Qian, > > > > I forgot to mention, I think the subject line should be > > > > drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU > > > > Could yo

Re: [RFC] Experimental DMA-BUF Device Heaps

2020-08-23 Thread Laurent Pinchart
Hi James, On Sun, Aug 23, 2020 at 01:04:43PM -0700, James Jones wrote: > On 8/20/20 1:15 AM, Ezequiel Garcia wrote: > > On Mon, 2020-08-17 at 20:49 -0700, James Jones wrote: > >> On 8/17/20 8:18 AM, Brian Starkey wrote: > >>> On Sun, Aug 16, 2020 at 02:22:46PM -0300, Ezequiel Garcia wrote: >

[Bug 209015] New: Clocks are no longer reported for R9 390 GPU

2020-08-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209015 Bug ID: 209015 Summary: Clocks are no longer reported for R9 390 GPU Product: Drivers Version: 2.5 Kernel Version: 5.8 Hardware: All OS: Linux Tree: Mainline

Re: [RFC] Experimental DMA-BUF Device Heaps

2020-08-23 Thread James Jones
On 8/20/20 1:15 AM, Ezequiel Garcia wrote: On Mon, 2020-08-17 at 20:49 -0700, James Jones wrote: On 8/17/20 8:18 AM, Brian Starkey wrote: Hi Ezequiel, On Sun, Aug 16, 2020 at 02:22:46PM -0300, Ezequiel Garcia wrote: This heap is basically a wrapper around DMA-API dma_alloc_attrs, which will a

Re: [PATCH] drm/etnaviv: fix external abort seen on GC600 rev 0x19

2020-08-23 Thread Russell King - ARM Linux admin
On Sun, Aug 23, 2020 at 09:10:25PM +0200, Christian Gmeiner wrote: > Hi > > > I have formally tested the patch with 5.7.10 - and it doesn't resolve > > the issue - sadly :( > > > > From my testing, the reads on > > VIVS_HI_CHIP_PRODUCT_ID > > VIVS_HI_CHIP_ECO_ID > > need to be conditional - while

Re: [PATCH] drm/etnaviv: fix external abort seen on GC600 rev 0x19

2020-08-23 Thread Christian Gmeiner
Hi > I have formally tested the patch with 5.7.10 - and it doesn't resolve > the issue - sadly :( > > From my testing, the reads on > VIVS_HI_CHIP_PRODUCT_ID > VIVS_HI_CHIP_ECO_ID > need to be conditional - while > VIVS_HI_CHIP_CUSTOMER_ID > seems to be okay. > Uhh.. okay.. just send a V2 - thank

[PATCH v2] drm/etnaviv: fix external abort seen on GC600 rev 0x19

2020-08-23 Thread Christian Gmeiner
It looks like that this GPU core triggers an abort when reading VIVS_HI_CHIP_PRODUCT_ID and/or VIVS_HI_CHIP_ECO_ID. I looked at different versions of Vivante's kernel driver and did not found anything about this issue or what feature flag can be used. So go the simplest route and do not read these

Re: [PATCH] drm/brige/megachips: Add checking if ge_b850v3_lvds_init() is working correctly

2020-08-23 Thread Sam Ravnborg
Hi Nadezda On Wed, Aug 19, 2020 at 05:37:56PM +0300, Nadezda Lutovinova wrote: > If ge_b850v3_lvds_init() does not allocate memory for ge_b850v3_lvds_ptr, > then a null pointer dereference is accessed. > > The patch adds checking of the return value of ge_b850v3_lvds_init(). > > Found by Linux D

Re: [PATCH] drm/bridge/tc358775: Fix for PTR_ERR

2020-08-23 Thread Sam Ravnborg
On Sun, Aug 16, 2020 at 11:20:41AM +0530, Vinay Simha BN wrote: > passing zero to 'PTR_ERR' > > Reported-by: kernel test robot > Signed-off-by: Vinay Simha BN Applied to drm-misc-next - thanks. Sam > --- > drivers/gpu/drm/bridge/tc358775.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH v2 21/24] drm/amdgpu/atom: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use macros for initialization - Replace direct access to backlight_properties with get and set operations Signed-off-by: Sam Ravnborg Cc: Alex Deucher Cc: Christian König Cc: amd-...@lists.freedesktop.org Cc: Sam Ravnborg --- .../gpu/drm/amd/amdgpu/atombios_encoders.c| 19 ++--

[PATCH v2 18/24] drm/bridge: parade-ps8622: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use blacklight_get_brightness() helper - Use devm_ variant to register backlight device and drop explicit unregister - Use macro for initialization Signed-off-by: Sam Ravnborg Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec --- drivers/gpu/

[PATCH v2 22/24] drm/i915: Backlight update

2020-08-23 Thread Sam Ravnborg
Update backlight implementation to utilize newly added backlight functionality. - Use macros for initialization - Replace direct access to backlight_properties with get and set operations - Moved enable/disable after registering backlight device One side-effect of these changes is that the conf

[PATCH v2 20/24] drm/radeon: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use macros for initialization - Replace direct access to backlight_properties with get and set operations Signed-off-by: Sam Ravnborg Cc: Alex Deucher Cc: Christian König Cc: amd-...@lists.freedesktop.org --- drivers/gpu/drm/radeon/atombios_encoders.c| 24 +-- .../gpu/d

[PATCH v2 08/24] drm/panel: asus-z00t-tm5p5-n35596: Backlight update

2020-08-23 Thread Sam Ravnborg
Update backlight to use macro for initialization and the backlight_get_brightness() operation to simply the update operation. Signed-off-by: Sam Ravnborg Cc: Konrad Dybcio Cc: Thierry Reding Cc: Sam Ravnborg --- .../gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c | 15 +++ 1 file ch

[PATCH v2 06/24] backlight: gpio: Use DECLARE_BACKLIGHT_INIT_RAW

2020-08-23 Thread Sam Ravnborg
Introduce use of DECLARE_BACKLIGHT_INIT_RAW when registering the backlight. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/gpio_backlight.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/backlig

[PATCH v2 07/24] drm/gma500: Backlight update

2020-08-23 Thread Sam Ravnborg
The backlight support is updated to utilise newly added macros and functions thus simplifying the code. - Introduced backlight_set_brightness() that can be called with a NULL backlight_device - backlight_update_status() can be called with a NULL backlight_device. Benefit from this by removing

[PATCH v2 14/24] drm/panel: samsung-s6e63j0x03: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use backlight support from drm_panel. This shifts this driver away from manually handling of power state. - Add helper function for registering backlight, like other samsung panel drivers do. - Use devm_ for backlight register thus benefit from automatic unregistering. Drop all explicit unr

[PATCH v2 16/24] drm/panel: sony-acx424akp: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use get method to read brightness - Use drm_panel support for backlight - This drops enable/disable operations as they are no longer needed. The enable/disable operations had some backlight related comments that are no longer valid. The only correct way to enable/disable backlight i

[PATCH v2 09/24] drm/panel: jdi-lt070me05000: Backlight update

2020-08-23 Thread Sam Ravnborg
Update backlight to use macro for initialization and the backlight_get_brightness() operation to simply the update operation. Use the drm_panel backlight functionality, which allowed the deletion of the enable and disable functions. Moved init of backlight device so it comes after drm_panel_init(

[PATCH v2 03/24] backlight: Add get/set operations for brightness properties

2020-08-23 Thread Sam Ravnborg
Add get and set operations to incapsualte access to backlight brightness. One easy win is that the get/set operations can be used when backlight is not included in the configuration, resulting in simpler code with less ifdef's and thus more readable code. The backlight_enable_brightness() update

[PATCH v2 13/24] drm/panel: samsung-s6e63m0: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use drm_panel backlight support - Use macro for backlight initialization Signed-off-by: Sam Ravnborg Cc: Paweł Chmiel Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 25 +++ 1 file changed, 9 insertions(+), 16 deletions(-) diff --git

[PATCH v2 01/24] backlight: Silently fail backlight_update_status() if no device

2020-08-23 Thread Sam Ravnborg
backlight_update_status() may be called from code that does not have any valid backlight device. To avoid ifdeffery and too much conditionals silently fail if the backlight_device is NULL. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight

[PATCH v2 04/24] backlight: gpio: Introduce backlight_{enable, disable}

2020-08-23 Thread Sam Ravnborg
Use backlight_{enable,disable} in the probe function to avoid hardcoding power handling in the driver. Move platform_set_drvdata() up as the enable/disable call will trigger a callback to the driver. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/vid

[PATCH v2 23/24] drm/omap: display: Backlight update

2020-08-23 Thread Sam Ravnborg
- Introduce backlight_{enable/disable) - Use get/set methods for backlight_properties - Drop redundant get_brightness() implementation The default implementation return the current brightness value - Use macro for backlight initialization v2: - Drop backlight_update() call as it is redundant (

[PATCH v2 17/24] drm/panel: sony-acx565akm: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use backlight_get_brightness() helper - Use backlight_is_blank() helper - Use macro for initialization - Drop direct access to backlight properties - Use the devm_ variant for registering backlight device, and drop all explicit unregistering of the backlight device. - Register backligt after dr

[PATCH v2 11/24] drm/panel: orisetech-otm8009a: Backlight update

2020-08-23 Thread Sam Ravnborg
- Replace direct access to backlight_properties with backlight_get_brightness(). - Use brightness and not power to determine if backlight is off - Use the devm_ variant for registering backlight device, and drop all explicit unregistering of the backlight device. Signed-off-by: Sam Ravnborg C

[PATCH v2 02/24] backlight: Add DECLARE_* macro for device registration

2020-08-23 Thread Sam Ravnborg
Device registration almost always uses a struct backlight_properties variable to pass config info. Make it simpler and less error prone by the introduction of a number of macros. There is one macro for each type of backlight {firmware, platform, raw}. All members in struct backlight_properties are

[PATCH v2 05/24] backlight: gpio: Use dev_err_probe()

2020-08-23 Thread Sam Ravnborg
Use dev_err_probe() to make some of the error handling simpler in the probe function. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/gpio_backlight.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/driver

[PATCH v2 12/24] drm/panel: raydium-rm67191: Backlight update

2020-08-23 Thread Sam Ravnborg
- Replace direct access to backlight_properties with backlight_get_brightness(). - Use macro for initialization Signed-off-by: Sam Ravnborg Cc: Robert Chiras Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-raydium-rm67191.c | 11 +++ 1 file changed, 3 insertions(

[PATCH v2 10/24] drm/panel: novatek-nt35510: Backlight update

2020-08-23 Thread Sam Ravnborg
- Replace direct access to backlight_properties with backlight_get_brightness(). - Drop debug printout - Use macro for initialization Signed-off-by: Sam Ravnborg Cc: Linus Walleij Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 9 +++-- 1 file cha

[PATCH v2 19/24] drm/tilcdc: Backlight update

2020-08-23 Thread Sam Ravnborg
Introduce backlight_{enable,disable} to enable/disable backlight. Dropped NULL check as backlight_{enable,disable} handles this. Signed-off-by: Sam Ravnborg Cc: Rob Clark Cc: Ezequiel Garcia Cc: Jyri Sarha Cc: Tomi Valkeinen --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 9 - 1 file cha

[PATCH v2 0/24] backlight: add init macros and accessors

2020-08-23 Thread Sam Ravnborg
The first patch trims backlight_update_status() so it can be called with a NULL backlight_device. Then the caller do not need to add this check just to avoid a NULL reference. The backlight drivers uses several different patterns when registering a backlight: - Register backlight and assign prope

[PATCH v2 24/24] drm/shmobile: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use get/set methods for backlight_properties - Use macro for backlight initialization Signed-off-by: Sam Ravnborg Cc: Laurent Pinchart Cc: Kieran Bingham Cc: linux-renesas-...@vger.kernel.org --- .../gpu/drm/shmobile/shmob_drm_backlight.c| 20 +++ 1 file changed, 7 insert

[PATCH v2 15/24] drm/panel: samsung-s6e3ha2: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use backlight support from drm_panel. This shifts this driver away from manually handling of power state. - Add helper function for registering backlight, like other samsung panel drivers do. - Register backlight driver after drm_panel_init - Use devm_ for backlight register thus benefit from

[Bug 208909] amdgpu Ryzen 7 4700U NULL pointer dereference multi monitor with rotation

2020-08-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208909 --- Comment #11 from ker...@890.at --- Created attachment 292063 --> https://bugzilla.kernel.org/attachment.cgi?id=292063&action=edit 5.8.3 backtrace -- You are receiving this mail because: You are watching the assignee of the bug. ___

[Bug 208909] amdgpu Ryzen 7 4700U NULL pointer dereference multi monitor with rotation

2020-08-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208909 --- Comment #10 from ker...@890.at --- just tried the 5.8.3 kernel with the same result, backtrace is attached. This time I tried to rotate the display on the DisplayPort/USB-C, it does not seem to be related to the port. -- You are receiving t