Re: [PATCH 4/4] dt-bindings: Explicitly allow additional properties in common schemas

2020-10-05 Thread Lee Jones
On Mon, 05 Oct 2020, Rob Herring wrote: > In order to add meta-schema checks for additional/unevaluatedProperties > being present, all schema need to make this explicit. As common/shared > schema are included by other schemas, they should always allow for > additionalProperties. Acked-by: Lee Jon

[git pull] drm fbdev fixes for 5.9 final

2020-10-05 Thread Dave Airlie
Hi Linus, Daniel queued these up last week and I took a long weekend so didn't get them out, but fixing the OOB access on get font seems like something we should land and it's cc'ed stable as well. The other big change is a partial revert for a regression on android on the clcd fbdev driver, and o

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-05 Thread Daniel Vetter
On Tue, Oct 6, 2020 at 1:41 AM Jason Gunthorpe wrote: > > On Tue, Oct 06, 2020 at 12:43:31AM +0200, Daniel Vetter wrote: > > > > iow I think I can outright delete the frame vector stuff. > > > > Ok this doesn't work, because dma_mmap always uses a remap_pfn_range, > > which is a VM_IO | VM_PFNMAP

Re: [PATCH 4/4] dt-bindings: Explicitly allow additional properties in common schemas

2020-10-05 Thread Vinod Koul
On 05-10-20, 13:38, Rob Herring wrote: > In order to add meta-schema checks for additional/unevaluatedProperties > being present, all schema need to make this explicit. As common/shared > schema are included by other schemas, they should always allow for > additionalProperties. Acked-By: Vinod Kou

Re: [PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties'

2020-10-05 Thread Vinod Koul
On 05-10-20, 13:38, Rob Herring wrote: > This doesn't yet do anything in the tools, but make it explicit so we can > check either 'unevaluatedProperties' or 'additionalProperties' is present > in schemas. > > 'unevaluatedProperties' is appropriate when including another schema (via > '$ref') and a

Re: [RFC PATCH] DRM: amd: powerplay: don't undef pr_warn() {causes ARC build errors}

2020-10-05 Thread Joe Perches
On Mon, 2020-10-05 at 21:50 -0700, Randy Dunlap wrote: > From: Randy Dunlap > > arch/arc/ implements BUG_ON() with BUG(). ARC has its own BUG() > function and that function uses pr_warn() as part of its implementation. > > Several (8) files in amd/powerplay/ #undef various pr_xyz() functions so

Re: [PATCH] Revert "gpu/drm: ingenic: Add option to mmap GEM buffers cached"

2020-10-05 Thread Stephen Rothwell
Hi all, On Mon, 5 Oct 2020 23:01:50 +1100 Stephen Rothwell wrote: > > On Sun, 04 Oct 2020 22:11:23 +0200 Paul Cercueil wrote: > > > > Pushed to drm-misc-next with the changelog fix, thanks. > > > > Stephen: > > Now it should build fine again. Could you remove the BROKEN flag? > > Thanks for

Re: [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-05 Thread Rob Clark
On Mon, Oct 5, 2020 at 5:44 PM Hillf Danton wrote: > > > On Mon, 5 Oct 2020 18:17:01 Kristian H. Kristensen wrote: > > On Mon, Oct 5, 2020 at 4:02 PM Daniel Vetter wrote: > > > > > > On Mon, Oct 05, 2020 at 05:24:19PM +0800, Hillf Danton wrote: > > > > > > > > On Sun, 4 Oct 2020 12:21:45 > > > >

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-05 Thread Andrew Morton
On Mon, 5 Oct 2020 14:47:47 -0300 Jason Gunthorpe wrote: > Andrew please let me know if you need a resend Andrew is rather confused. Can we please identify the minimal patch(es) which are needed for 5.9 and -stable? ___ dri-devel mailing list dri-dev

Re: [Freedreno] [PATCH 00/14] drm/msm: de-struct_mutex-ification

2020-10-05 Thread Rob Clark
On Mon, Oct 5, 2020 at 11:20 AM Daniel Vetter wrote: > > On Mon, Oct 5, 2020 at 6:24 PM Kristian Høgsberg wrote: > > > > On Sun, Oct 4, 2020 at 9:21 PM Rob Clark wrote: > > > > > > From: Rob Clark > > > > > > This doesn't remove *all* the struct_mutex, but it covers the worst > > > of it, ie. s

drm: Supporting new connector model in tidss

2020-10-05 Thread Nikhil Devshatwar
Hi all, I am trying to convert the upstream tidss drm driver to new connector model. The connector is getting created by the tidss driver and bridges are attached with flag DRM_BRIDGE_ATTACH_NO_CONNECTOR Here are some questions, regarding this: 1) Most of the info regarding bus_format and bus fla

Re: [PATCH 4/4] dt-bindings: Explicitly allow additional properties in common schemas

2020-10-05 Thread Chanwoo Choi
On 10/6/20 3:38 AM, Rob Herring wrote: > In order to add meta-schema checks for additional/unevaluatedProperties > being present, all schema need to make this explicit. As common/shared > schema are included by other schemas, they should always allow for > additionalProperties. > > Signed-off-by:

RE: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-10-05 Thread Chrisanthus, Anitha
> -Original Message- > From: Daniel Vetter > Sent: Monday, October 5, 2020 6:49 AM > To: Chrisanthus, Anitha > Cc: Daniel Vetter ; dri-devel@lists.freedesktop.org; > Paauwe, Bob J ; Dea, Edmund J > ; Vetter, Daniel > Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

[PATCH 5/5] drm/ttm: make move callback compulstory

2020-10-05 Thread Dave Airlie
From: Dave Airlie All drivers should have a move callback now so make it compulsory. Reviewed-by: Ben Skeggs Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu

[PATCH 1/5] drm/qxl: drop unused code (v2)

2020-10-05 Thread Dave Airlie
From: Dave Airlie v2: drop the wrapper struct Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index 2c35ca4270c6..669bceb

[PATCH 3/5] drm/vmwgfx: add a move callback.

2020-10-05 Thread Dave Airlie
From: Dave Airlie This just copies the fallback to vmwgfx, I'm going to iterate on this a bit until it's not the same as the fallback path. Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff

[PATCH 4/5] drm/vram_helper: implement a ttm move callback.

2020-10-05 Thread Dave Airlie
From: Dave Airlie This will always do memcpy moves. Acked-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_h

[PATCH 0/5] ttm make move callback compulsory

2020-10-05 Thread Dave Airlie
I've just pulled out the few bits for making the move callback compulsory from my previous series. The vmwgfx ones need acks/r-bs, I've booted them in vmplayer and they seem to work fine. Dave. ___ dri-devel mailing list dri-devel@lists.freedesktop.or

[PATCH 2/5] drm/vmwgfx: move null mem checks outside move notifies

2020-10-05 Thread Dave Airlie
From: Dave Airlie Both fns checked mem == NULL, just move the check outside. Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 3 --- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 2 ++ 3 files changed, 3 insertions(+)

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-05 Thread Rob Clark
On Mon, Oct 5, 2020 at 8:00 AM Qais Yousef wrote: > > +CC Steve and Peter - they might be interested. > > On 10/02/20 11:07, Rob Clark wrote: > > On Fri, Oct 2, 2020 at 4:01 AM Qais Yousef wrote: > > > > > > On 09/30/20 14:17, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > The android

Re: [PATCH] drm/ttm: nuke ttm_bo_evict_mm and rename mgr function v2

2020-10-05 Thread Dave Airlie
On Tue, 6 Oct 2020 at 01:38, Daniel Vetter wrote: > > On Mon, Oct 5, 2020 at 4:27 PM Christian König > wrote: > > > > Make it more clear what the resource manager function > > does and nuke the wrapper function. > > > > v2: nuke the wrapper > > > > Signed-off-by: Christian König > > Reviewed-by:

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-05 Thread Rob Clark
On Mon, Oct 5, 2020 at 7:15 AM Daniel Vetter wrote: > > On Mon, Oct 05, 2020 at 03:15:24PM +0300, Ville Syrjälä wrote: > > On Fri, Oct 02, 2020 at 10:55:52AM -0700, Rob Clark wrote: > > > On Fri, Oct 2, 2020 at 4:05 AM Ville Syrjälä > > > wrote: > > > > > > > > On Fri, Oct 02, 2020 at 01:52:56PM

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-05 Thread Daniel Vetter
On Mon, Oct 5, 2020 at 8:54 PM Daniel Vetter wrote: > > On Mon, Oct 5, 2020 at 8:37 PM Jason Gunthorpe wrote: > > > > On Mon, Oct 05, 2020 at 08:16:33PM +0200, Daniel Vetter wrote: > > > > > > kvm is some similar hack added for P2P DMA, see commit > > > > add6a0cd1c5ba51b201e1361b05a5df817083618.

Re: [PATCH] Revert "gpu/drm: ingenic: Add option to mmap GEM buffers cached"

2020-10-05 Thread Daniel Vetter
On Mon, Oct 5, 2020 at 4:47 PM Paul Cercueil wrote: > > Hi, > > Le lun. 5 oct. 2020 à 16:05, Daniel Vetter a écrit : > > On Mon, Oct 05, 2020 at 11:01:50PM +1100, Stephen Rothwell wrote: > >> Hi Paul, > >> > >> On Sun, 04 Oct 2020 22:11:23 +0200 Paul Cercueil > >> wrote: > >> > > >> > Pushed

Re: drm: Supporting new connector model in tidss

2020-10-05 Thread Daniel Vetter
On Mon, Oct 5, 2020 at 11:43 PM Nikhil Devshatwar wrote: > > Hi all, > > I am trying to convert the upstream tidss drm driver to new > connector model. > The connector is getting created by the tidss driver and bridges are > attached with flag DRM_BRIDGE_ATTACH_NO_CONNECTOR > Here are some questio

Re: [PATCH 4/4] dt-bindings: Explicitly allow additional properties in common schemas

2020-10-05 Thread Sebastian Reichel
Hi, On Mon, Oct 05, 2020 at 01:38:30PM -0500, Rob Herring wrote: > In order to add meta-schema checks for additional/unevaluatedProperties > being present, all schema need to make this explicit. As common/shared > schema are included by other schemas, they should always allow for > additionalPrope

Re: [PATCH 4/4] dt-bindings: Explicitly allow additional properties in common schemas

2020-10-05 Thread Krzysztof Kozlowski
On Mon, Oct 05, 2020 at 01:38:30PM -0500, Rob Herring wrote: > In order to add meta-schema checks for additional/unevaluatedProperties > being present, all schema need to make this explicit. As common/shared > schema are included by other schemas, they should always allow for > additionalProperties

Re: [PATCH 3/4] dt-bindings: Explicitly allow additional properties in board/SoC schemas

2020-10-05 Thread Krzysztof Kozlowski
On Mon, Oct 05, 2020 at 01:38:29PM -0500, Rob Herring wrote: > In order to add meta-schema checks for additional/unevaluatedProperties > being present, all schema need to make this explicit. As the top-level > board/SoC schemas always have additional properties, add > 'additionalProperties: true'.

Re: [PATCH 2/4] dt-bindings: Use 'additionalProperties' instead of 'unevaluatedProperties'

2020-10-05 Thread Krzysztof Kozlowski
On Mon, Oct 05, 2020 at 01:38:28PM -0500, Rob Herring wrote: > In cases where we don't reference another schema, 'additionalProperties' > can be used instead. This is preferred for now as 'unevaluatedProperties' > support isn't implemented yet. > > In a few cases, this means adding some missing pr

Re: [PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties'

2020-10-05 Thread Krzysztof Kozlowski
On Mon, Oct 05, 2020 at 01:38:27PM -0500, Rob Herring wrote: > This doesn't yet do anything in the tools, but make it explicit so we can > check either 'unevaluatedProperties' or 'additionalProperties' is present > in schemas. > > 'unevaluatedProperties' is appropriate when including another schem

Re: [PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties'

2020-10-05 Thread Wolfram Sang
On Mon, Oct 05, 2020 at 01:38:27PM -0500, Rob Herring wrote: > This doesn't yet do anything in the tools, but make it explicit so we can > check either 'unevaluatedProperties' or 'additionalProperties' is present > in schemas. > > 'unevaluatedProperties' is appropriate when including another schem

RE: [RFC PATCH v3 1/4] RDMA/umem: Support importing dma-buf as user memory region

2020-10-05 Thread Xiong, Jianxin
> -Original Message- > From: Jason Gunthorpe > Sent: Monday, October 05, 2020 9:33 AM > To: Xiong, Jianxin > Cc: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford > ; Leon Romanovsky > ; Sumit Semwal ; Christian Koenig > ; Vetter, Daniel > > Subject: Re: [RFC

Re: [PATCH 4/4] dt-bindings: Explicitly allow additional properties in common schemas

2020-10-05 Thread Mark Brown
On Mon, Oct 05, 2020 at 01:38:30PM -0500, Rob Herring wrote: > In order to add meta-schema checks for additional/unevaluatedProperties > being present, all schema need to make this explicit. As common/shared > schema are included by other schemas, they should always allow for > additionalProperties

Re: [PATCH 2/4] dt-bindings: Use 'additionalProperties' instead of 'unevaluatedProperties'

2020-10-05 Thread Mark Brown
On Mon, Oct 05, 2020 at 01:38:28PM -0500, Rob Herring wrote: > In cases where we don't reference another schema, 'additionalProperties' > can be used instead. This is preferred for now as 'unevaluatedProperties' > support isn't implemented yet. Acked-by: Mark Brown signature.asc Description: PG

Re: [PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties'

2020-10-05 Thread Mark Brown
On Mon, Oct 05, 2020 at 01:38:27PM -0500, Rob Herring wrote: > This doesn't yet do anything in the tools, but make it explicit so we can > check either 'unevaluatedProperties' or 'additionalProperties' is present > in schemas. Acked-by: Mark Brown signature.asc Description: PGP signature __

RE: [RFC PATCH v3 1/4] RDMA/umem: Support importing dma-buf as user memory region

2020-10-05 Thread Xiong, Jianxin
> -Original Message- > From: Christian König > Sent: Monday, October 05, 2020 3:55 AM > To: Xiong, Jianxin ; linux-r...@vger.kernel.org; > dri-devel@lists.freedesktop.org > Cc: Doug Ledford ; Jason Gunthorpe ; Leon > Romanovsky ; Sumit Semwal > ; Vetter, Daniel > Subject: Re: [RFC PATCH

RE: [PATCH 5/8] drm/ttm: set the tt caching state at creation time

2020-10-05 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Thursday, October 1, 2020 7:28 AM >To: dri-devel@lists.freedesktop.org; ray.hu...@amd.com; >airl...@gmail.com; dan...@ffwll.ch >Subject: [PATCH 5/8] drm/ttm: set the tt caching state at creation time > >All drivers c

Re: [PATCH] drm/amdgpu: remove unintended executable mode

2020-10-05 Thread Alex Deucher
On Mon, Oct 5, 2020 at 3:22 AM Lukas Bulwahn wrote: > > Besides the intended change, commit 3437f5f6c979 ("drm/amdgpu: add gfx > support for van gogh (v2)") also set the source files gfx_v10_0.c to be > executable, i.e., changed from old mode 644 to new mode 755. > > Set to the usual mode for sour

RE: [PATCH 4/8] drm/ttm: rename TTM caching enum

2020-10-05 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Thursday, October 1, 2020 7:28 AM >To: dri-devel@lists.freedesktop.org; ray.hu...@amd.com; >airl...@gmail.com; dan...@ffwll.ch >Subject: [PATCH 4/8] drm/ttm: rename TTM caching enum > >Cleanup the enum name and its v

[PATCH v4 0/2] drm/i915/jsl: Update JSL Voltage swing table

2020-10-05 Thread Tejas Upadhyay
Patch series covers following thigns: 1. Split and differentiate between EHL and JSL platfrom 2. Update voltage swing table for eDP on JSL platform Changes since V3 : - Changed IS_EHL_JSL to IS_JSL_EHL - Renamed IS_EHL_REVID to IS_JSL_EHL_REVID - Reverted removal of IS_ELK

[PATCH v4 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-10-05 Thread Tejas Upadhyay
JSL has update in vswing table for eDP. BSpec: 21257 Changes since V3 : - Changed IS_EHL_JSL to IS_JSL_EH - Reverted removal of IS_ELKHARTLAKE and also added IS_JASPERLAKE - Corrected mistake of using IS_ELKHARTLAKE twice and missing IS_JASPERLAKE

[PATCH v4 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-10-05 Thread Tejas Upadhyay
Split the basic platform definition, macros, and PCI IDs to differentiate between EHL and JSL platforms. Changes since V3 : - Changed IS_EHL_JSL to IS_JSL_EHL - Renamed IS_EHL_REVID to IS_JSL_EHL_REVID - Reverted removal of IS_ELKHARTLAKE and also added IS_JASPERL

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-05 Thread Daniel Vetter
On Mon, Oct 5, 2020 at 8:37 PM Jason Gunthorpe wrote: > > On Mon, Oct 05, 2020 at 08:16:33PM +0200, Daniel Vetter wrote: > > > > kvm is some similar hack added for P2P DMA, see commit > > > add6a0cd1c5ba51b201e1361b05a5df817083618. It might be protected by > > > notifiers.. > > > > Yeah my thinki

[PATCH v4 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-10-05 Thread Tejas Upadhyay
JSL has update in vswing table for eDP. BSpec: 21257 Changes since V3 : - Changed IS_EHL_JSL to IS_JSL_EH - Reverted removal of IS_ELKHARTLAKE and also added IS_JASPERLAKE - Corrected mistake of using IS_ELKHARTLAKE twice and missing IS_JASPERLAKE

[PATCH v4 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-10-05 Thread Tejas Upadhyay
Split the basic platform definition, macros, and PCI IDs to differentiate between EHL and JSL platforms. Changes since V3 : - Changed IS_EHL_JSL to IS_JSL_EHL - Renamed IS_EHL_REVID to IS_JSL_EHL_REVID - Reverted removal of IS_ELKHARTLAKE and also added IS_JASPERL

[PATCH v4 0/2] drm/i915/jsl: Update JSL Voltage swing table

2020-10-05 Thread Tejas Upadhyay
Patch series covers following thigns: 1. Split and differentiate between EHL and JSL platfrom 2. Update voltage swing table for eDP on JSL platform Changes since V3 : - Changed IS_EHL_JSL to IS_JSL_EHL - Renamed IS_EHL_REVID to IS_JSL_EHL_REVID - Reverted removal of IS_ELK

RE: [PATCH 8/8] drm/ttm: nuke caching placement flags

2020-10-05 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Thursday, October 1, 2020 7:28 AM >To: dri-devel@lists.freedesktop.org; ray.hu...@amd.com; >airl...@gmail.com; dan...@ffwll.ch >Subject: [PATCH 8/8] drm/ttm: nuke caching placement flags > >Changing the caching on th

[PATCH 4/4] dt-bindings: Explicitly allow additional properties in common schemas

2020-10-05 Thread Rob Herring
In order to add meta-schema checks for additional/unevaluatedProperties being present, all schema need to make this explicit. As common/shared schema are included by other schemas, they should always allow for additionalProperties. Signed-off-by: Rob Herring --- Documentation/devicetree/bindings

[PATCH 2/4] dt-bindings: Use 'additionalProperties' instead of 'unevaluatedProperties'

2020-10-05 Thread Rob Herring
In cases where we don't reference another schema, 'additionalProperties' can be used instead. This is preferred for now as 'unevaluatedProperties' support isn't implemented yet. In a few cases, this means adding some missing property definitions of which most are for SPI bus properties. 'unevaluat

[PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties'

2020-10-05 Thread Rob Herring
This doesn't yet do anything in the tools, but make it explicit so we can check either 'unevaluatedProperties' or 'additionalProperties' is present in schemas. 'unevaluatedProperties' is appropriate when including another schema (via '$ref') and all possible properties and/or child nodes are not e

[PATCH 3/4] dt-bindings: Explicitly allow additional properties in board/SoC schemas

2020-10-05 Thread Rob Herring
In order to add meta-schema checks for additional/unevaluatedProperties being present, all schema need to make this explicit. As the top-level board/SoC schemas always have additional properties, add 'additionalProperties: true'. Signed-off-by: Rob Herring --- Documentation/devicetree/bindings/a

[PATCH 0/4] dt-bindings: additional/unevaluatedProperties clean-ups

2020-10-05 Thread Rob Herring
The default behavior for json-schema is any unknown property is allowed. That is generally not the behavior we want for DT. In order to disallow extra properties, schemas need to define 'additionalProperties: false' typically. Ideally, we'd just add that automatically with the tools, but there are

RE: [PATCH 7/8] drm/ttm: use caching instead of placement for ttm_io_prot

2020-10-05 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Thursday, October 1, 2020 7:28 AM >To: dri-devel@lists.freedesktop.org; ray.hu...@amd.com; >airl...@gmail.com; dan...@ffwll.ch >Subject: [PATCH 7/8] drm/ttm: use caching instead of placement for >ttm_io_prot > >Inste

Re: [Freedreno] [PATCH 00/14] drm/msm: de-struct_mutex-ification

2020-10-05 Thread Daniel Vetter
On Mon, Oct 5, 2020 at 6:24 PM Kristian Høgsberg wrote: > > On Sun, Oct 4, 2020 at 9:21 PM Rob Clark wrote: > > > > From: Rob Clark > > > > This doesn't remove *all* the struct_mutex, but it covers the worst > > of it, ie. shrinker/madvise/free/retire. The submit path still uses > > struct_mute

Re: [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-05 Thread Daniel Vetter
On Mon, Oct 5, 2020 at 6:49 PM Rob Clark wrote: > > On Mon, Oct 5, 2020 at 7:02 AM Daniel Vetter wrote: > > > > On Mon, Oct 05, 2020 at 05:24:19PM +0800, Hillf Danton wrote: > > > > > > On Sun, 4 Oct 2020 12:21:45 > > > > From: Rob Clark > > > > > > > > Now that the inactive_list is protected b

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-05 Thread Daniel Vetter
On Mon, Oct 5, 2020 at 7:58 PM Jason Gunthorpe wrote: > > On Mon, Oct 05, 2020 at 07:53:08PM +0200, Jan Kara wrote: > > On Mon 05-10-20 14:38:54, Jason Gunthorpe wrote: > > > When get_vaddr_frames() does its hacky follow_pfn() loop it should never > > > be allowed to extract a struct page from a n

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-05 Thread Daniel Vetter
On Mon, Oct 5, 2020 at 7:28 PM Jason Gunthorpe wrote: > > On Sun, Oct 04, 2020 at 06:09:29PM +0200, Daniel Vetter wrote: > > On Sun, Oct 4, 2020 at 2:51 PM Jason Gunthorpe wrote: > > > > > > On Sat, Oct 03, 2020 at 11:40:22AM +0200, Daniel Vetter wrote: > > > > > > > > That leaves the only intere

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-05 Thread Jan Kara
On Mon 05-10-20 14:38:54, Jason Gunthorpe wrote: > When get_vaddr_frames() does its hacky follow_pfn() loop it should never > be allowed to extract a struct page from a normal VMA. This could allow a > serious use-after-free problem on any kernel memory. > > Restrict this to only work on VMA's wit

Re: [PATCH] Revert "gpu/drm: ingenic: Add option to mmap GEM buffers cached"

2020-10-05 Thread Daniel Vetter
On Mon, Oct 5, 2020 at 4:47 PM Paul Cercueil wrote: > > Hi, > > Le lun. 5 oct. 2020 à 16:05, Daniel Vetter a écrit : > > On Mon, Oct 05, 2020 at 11:01:50PM +1100, Stephen Rothwell wrote: > >> Hi Paul, > >> > >> On Sun, 04 Oct 2020 22:11:23 +0200 Paul Cercueil > >> wrote: > >> > > >> > Pushed

RE: [PATCH 6/8] drm/ttm: add caching state to ttm_bus_placement

2020-10-05 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Thursday, October 1, 2020 7:28 AM >To: dri-devel@lists.freedesktop.org; ray.hu...@amd.com; >airl...@gmail.com; dan...@ffwll.ch >Subject: [PATCH 6/8] drm/ttm: add caching state to ttm_bus_placement > >And implement se

Re: [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-05 Thread Rob Clark
On Mon, Oct 5, 2020 at 7:02 AM Daniel Vetter wrote: > > On Mon, Oct 05, 2020 at 05:24:19PM +0800, Hillf Danton wrote: > > > > On Sun, 4 Oct 2020 12:21:45 > > > From: Rob Clark > > > > > > Now that the inactive_list is protected by mm_lock, and everything > > > else on per-obj basis is protected

Re: [Freedreno] [PATCH 00/14] drm/msm: de-struct_mutex-ification

2020-10-05 Thread Kristian Høgsberg
On Sun, Oct 4, 2020 at 9:21 PM Rob Clark wrote: > > From: Rob Clark > > This doesn't remove *all* the struct_mutex, but it covers the worst > of it, ie. shrinker/madvise/free/retire. The submit path still uses > struct_mutex, but it still needs *something* serialize a portion of > the submit pat

Re: [PATCH 07/14] drm/msm: Refcount submits

2020-10-05 Thread Rob Clark
On Mon, Oct 5, 2020 at 6:56 AM Daniel Vetter wrote: > > On Sun, Oct 04, 2020 at 12:21:39PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Before we remove dev->struct_mutex from the retire path, we have to deal > > with the situation of a submit retiring before the submit ioctl returns. > >

RE: [RFC PATCH v3 1/4] RDMA/umem: Support importing dma-buf as user memory region

2020-10-05 Thread Xiong, Jianxin
> -Original Message- > From: Jason Gunthorpe > Sent: Monday, October 05, 2020 6:13 AM > To: Xiong, Jianxin > Cc: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford > ; Leon Romanovsky > ; Sumit Semwal ; Christian Koenig > ; Vetter, Daniel > > Subject: Re: [RFC PA

Re: [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-05 Thread Kristian Høgsberg
On Mon, Oct 5, 2020 at 4:02 PM Daniel Vetter wrote: > > On Mon, Oct 05, 2020 at 05:24:19PM +0800, Hillf Danton wrote: > > > > On Sun, 4 Oct 2020 12:21:45 > > > From: Rob Clark > > > > > > Now that the inactive_list is protected by mm_lock, and everything > > > else on per-obj basis is protected

Re: [PATCH AUTOSEL 5.8 10/12] drm/vmwgfx: Fix error handling in get_node

2020-10-05 Thread Roland Scheidegger
Not entirely sure how the patches for autosel were selected, but this patch is no good for 5.8, since the patch which introduced the breakage in the first place is only in 5.9 (in particular it was 58e4d686d456c3e356439ae160ff4a0728940b8e, drm/ttm: cleanup ttm_mem_type_manager_func.get_node interfa

Re: [PATCH v2 1/3] iommu/io-pgtable-arm: Support coherency for Mali LPAE

2020-10-05 Thread Boris Brezillon
On Mon, 5 Oct 2020 16:16:32 +0100 Steven Price wrote: > On 05/10/2020 15:50, Boris Brezillon wrote: > > On Tue, 22 Sep 2020 15:16:48 +0100 > > Robin Murphy wrote: > > > >> Midgard GPUs have ACE-Lite master interfaces which allows systems to > >> integrate them in an I/O-coherent manner. It se

Re: [PATCH] dt-bindings: Another round of adding missing 'additionalProperties'

2020-10-05 Thread Sebastian Reichel
On Fri, Oct 02, 2020 at 06:41:43PM -0500, Rob Herring wrote: > Another round of wack-a-mole. The json-schema default is additional > unknown properties are allowed, but for DT all properties should be > defined. > > Signed-off-by: Rob Herring > --- > > I'll take this thru the DT tree. > > [...

Re: [PATCH] drm/ttm: nuke ttm_bo_evict_mm and rename mgr function v2

2020-10-05 Thread Daniel Vetter
On Mon, Oct 5, 2020 at 4:27 PM Christian König wrote: > > Make it more clear what the resource manager function > does and nuke the wrapper function. > > v2: nuke the wrapper > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter I think adding a bdev back pointer to res_man would be ni

Re: [PATCH v2 1/3] iommu/io-pgtable-arm: Support coherency for Mali LPAE

2020-10-05 Thread Steven Price
On 05/10/2020 15:50, Boris Brezillon wrote: On Tue, 22 Sep 2020 15:16:48 +0100 Robin Murphy wrote: Midgard GPUs have ACE-Lite master interfaces which allows systems to integrate them in an I/O-coherent manner. It seems that from the GPU's viewpoint, the rest of the system is its outer shareabl

RE: [PATCH 3/8] drm/ttm: cleanup ttm_handle_caching_state_failure

2020-10-05 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Thursday, October 1, 2020 7:28 AM >To: dri-devel@lists.freedesktop.org; ray.hu...@amd.com; >airl...@gmail.com; dan...@ffwll.ch >Subject: [PATCH 3/8] drm/ttm: cleanup ttm_handle_caching_state_failure > >Remove unuse

RE: [PATCH 2/8] drm/ttm: move ttm_set_memory.h out of include

2020-10-05 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Thursday, October 1, 2020 7:28 AM >To: dri-devel@lists.freedesktop.org; ray.hu...@amd.com; >airl...@gmail.com; dan...@ffwll.ch >Subject: [PATCH 2/8] drm/ttm: move ttm_set_memory.h out of include > >This is not someth

RE: [PATCH 1/8] drm/ttm: remove TTM_PAGE_FLAG_WRITE

2020-10-05 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Thursday, October 1, 2020 7:28 AM >To: dri-devel@lists.freedesktop.org; ray.hu...@amd.com; >airl...@gmail.com; dan...@ffwll.ch >Subject: [PATCH 1/8] drm/ttm: remove TTM_PAGE_FLAG_WRITE > >Not used any more. Reviewe

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-05 Thread Jan Kara
Hi! On Fri 02-10-20 15:06:03, Jason Gunthorpe wrote: > This get_vaddr_frames() thing looks impossible to use properly. How on > earth does a driver guarentee > > "If @start belongs to VM_IO | VM_PFNMAP vma, we don't touch page > structures and the caller must make sure pfns aren't reused for >

Re: [PATCH 2/2] drm/ttm: remove no_retry flag

2020-10-05 Thread Daniel Vetter
On Mon, Oct 5, 2020 at 4:37 PM Christian König wrote: > > Am 02.10.20 um 14:31 schrieb Daniel Vetter: > > On Fri, Oct 2, 2020 at 1:31 PM Christian König > > wrote: > >> Amdgpu was the only user of this. > >> > >> Signed-off-by: Christian König > > Uh this smells like a fishy band-aid. And the or

Re: [PATCH v2 1/3] iommu/io-pgtable-arm: Support coherency for Mali LPAE

2020-10-05 Thread Boris Brezillon
On Tue, 22 Sep 2020 15:16:48 +0100 Robin Murphy wrote: > Midgard GPUs have ACE-Lite master interfaces which allows systems to > integrate them in an I/O-coherent manner. It seems that from the GPU's > viewpoint, the rest of the system is its outer shareable domain, and so > even when snoop signal

[PATCH AUTOSEL 5.4 2/4] drm/amdgpu: prevent double kfree ttm->sg

2020-10-05 Thread Sasha Levin
From: Philip Yang [ Upstream commit 1d0e16ac1a9e800598dcfa5b6bc53b704a103390 ] Set ttm->sg to NULL after kfree, to avoid memory corruption backtrace: [ 420.932812] kernel BUG at /build/linux-do9eLF/linux-4.15.0/mm/slub.c:295! [ 420.934182] invalid opcode: [#1] SMP NOPTI [ 420.935445] Mo

[PATCH AUTOSEL 4.14 2/2] drm/amdgpu: prevent double kfree ttm->sg

2020-10-05 Thread Sasha Levin
From: Philip Yang [ Upstream commit 1d0e16ac1a9e800598dcfa5b6bc53b704a103390 ] Set ttm->sg to NULL after kfree, to avoid memory corruption backtrace: [ 420.932812] kernel BUG at /build/linux-do9eLF/linux-4.15.0/mm/slub.c:295! [ 420.934182] invalid opcode: [#1] SMP NOPTI [ 420.935445] Mo

[PATCH AUTOSEL 4.19 2/2] drm/amdgpu: prevent double kfree ttm->sg

2020-10-05 Thread Sasha Levin
From: Philip Yang [ Upstream commit 1d0e16ac1a9e800598dcfa5b6bc53b704a103390 ] Set ttm->sg to NULL after kfree, to avoid memory corruption backtrace: [ 420.932812] kernel BUG at /build/linux-do9eLF/linux-4.15.0/mm/slub.c:295! [ 420.934182] invalid opcode: [#1] SMP NOPTI [ 420.935445] Mo

[PATCH AUTOSEL 5.8 09/12] drm/amd/display: fix return value check for hdcp_work

2020-10-05 Thread Sasha Levin
From: Flora Cui [ Upstream commit 898c7302f4de1d91065e80fc46552b3ec70894ff ] max_caps might be 0, thus hdcp_work might be ZERO_SIZE_PTR Signed-off-by: Flora Cui Reviewed-by: Feifei Xu Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm

[PATCH AUTOSEL 5.8 10/12] drm/vmwgfx: Fix error handling in get_node

2020-10-05 Thread Sasha Levin
From: Zack Rusin [ Upstream commit f54c4442893b8dfbd3aff8e903c54dfff1aef990 ] ttm_mem_type_manager_func.get_node was changed to return -ENOSPC instead of setting the node pointer to NULL. Unfortunately vmwgfx still had two places where it was explicitly converting -ENOSPC to 0 causing regression

[PATCH AUTOSEL 4.9 2/2] drm/amdgpu: prevent double kfree ttm->sg

2020-10-05 Thread Sasha Levin
From: Philip Yang [ Upstream commit 1d0e16ac1a9e800598dcfa5b6bc53b704a103390 ] Set ttm->sg to NULL after kfree, to avoid memory corruption backtrace: [ 420.932812] kernel BUG at /build/linux-do9eLF/linux-4.15.0/mm/slub.c:295! [ 420.934182] invalid opcode: [#1] SMP NOPTI [ 420.935445] Mo

[PATCH AUTOSEL 5.8 08/12] drm/amd/pm: Removed fixed clock in auto mode DPM

2020-10-05 Thread Sasha Levin
From: Sudheesh Mavila [ Upstream commit 97cf32996c46d9935cc133d910a75fb687dd6144 ] SMU10_UMD_PSTATE_PEAK_FCLK value should not be used to set the DPM. Suggested-by: Evan Quan Reviewed-by: Evan Quan Signed-off-by: Sudheesh Mavila Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- d

[PATCH AUTOSEL 5.8 04/12] drm/amdgpu: prevent double kfree ttm->sg

2020-10-05 Thread Sasha Levin
From: Philip Yang [ Upstream commit 1d0e16ac1a9e800598dcfa5b6bc53b704a103390 ] Set ttm->sg to NULL after kfree, to avoid memory corruption backtrace: [ 420.932812] kernel BUG at /build/linux-do9eLF/linux-4.15.0/mm/slub.c:295! [ 420.934182] invalid opcode: [#1] SMP NOPTI [ 420.935445] Mo

Re: [PATCH 2/2] drm/ttm: remove no_retry flag

2020-10-05 Thread Christian König
Am 02.10.20 um 14:31 schrieb Daniel Vetter: On Fri, Oct 2, 2020 at 1:31 PM Christian König wrote: Amdgpu was the only user of this. Signed-off-by: Christian König Uh this smells like a fishy band-aid. And the original commit introducing this also doesn't sched any light on why this should ha

Re: [Freedreno] [PATCH 09/14] drm/msm: Drop struct_mutex from the retire path

2020-10-05 Thread Jordan Crouse
On Sun, Oct 04, 2020 at 12:21:41PM -0700, Rob Clark wrote: > From: Rob Clark > > Now that we are not relying on dev->struct_mutex to protect the > ring->submits lists, drop the struct_mutex lock. Reviewed-by: Jordan Crouse > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpu.c | 8

Re: [PATCH v2 2/4] drm/sun4i: tcon: Refactor the LVDS and panel probing

2020-10-05 Thread Chen-Yu Tsai
On Mon, Oct 5, 2020 at 10:19 PM Maxime Ripard wrote: > > Hi Chen-Yu, > > Sorry for the delay > > On Sat, Aug 29, 2020 at 02:43:53PM +0800, Chen-Yu Tsai wrote: > > > +static int sun4i_tcon_register_panel(struct drm_device *drm, > > > +struct sun4i_tcon *tcon) > >

Re: [Freedreno] [PATCH 08/14] drm/msm: Remove obj->gpu

2020-10-05 Thread Jordan Crouse
On Sun, Oct 04, 2020 at 12:21:40PM -0700, Rob Clark wrote: > From: Rob Clark > > It cannot be atomically updated with obj->active_count, and the only > purpose is a useless WARN_ON() (which becomes a buggy WARN_ON() once > retire_submits() is not serialized with incoming submits via > struct_mute

Re: [Freedreno] [PATCH 07/14] drm/msm: Refcount submits

2020-10-05 Thread Jordan Crouse
On Sun, Oct 04, 2020 at 12:21:39PM -0700, Rob Clark wrote: > From: Rob Clark > > Before we remove dev->struct_mutex from the retire path, we have to deal > with the situation of a submit retiring before the submit ioctl returns. > > To deal with this, ring->submits will hold a reference to the s

Re: [PATCH RESEND] drm/bridge: tc358764: restore connector support

2020-10-05 Thread Andrzej Hajda
W dniu 04.10.2020 o 21:14, Sam Ravnborg pisze: > Hi Marek. > > On Wed, Sep 30, 2020 at 01:40:42PM +0200, Marek Szyprowski wrote: >> This patch restores DRM connector registration in the TC358764 bridge >> driver and restores usage of the old drm_panel_* API, thus allows dynamic >> panel registrati

[PATCH] drm/ttm: nuke ttm_bo_evict_mm and rename mgr function v2

2020-10-05 Thread Christian König
Make it more clear what the resource manager function does and nuke the wrapper function. v2: nuke the wrapper Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 5 - drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ob

Re: [Freedreno] [PATCH 06/14] drm/msm: Protect ring->submits with it's own lock

2020-10-05 Thread Jordan Crouse
On Sun, Oct 04, 2020 at 12:21:38PM -0700, Rob Clark wrote: > From: Rob Clark > > One less place to rely on dev->struct_mutex. > Reviewed-by: Jordan Crouse > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gem_submit.c | 2 ++ > drivers/gpu/drm/msm/msm_gpu.c| 37 +++

Re: [PATCH 05/14] drm/msm: Document and rename preempt_lock

2020-10-05 Thread Jordan Crouse
On Sun, Oct 04, 2020 at 12:21:37PM -0700, Rob Clark wrote: > From: Rob Clark > > Before adding another lock, give ring->lock a more descriptive name. Reviewed-by: Jordan Crouse > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 ++-- > drivers/gpu/drm/msm/adren

Re: [Freedreno] [PATCH 04/14] drm/msm: Add priv->mm_lock to protect active/inactive lists

2020-10-05 Thread Jordan Crouse
On Sun, Oct 04, 2020 at 12:21:36PM -0700, Rob Clark wrote: > From: Rob Clark > > Rather than relying on the big dev->struct_mutex hammer, introduce a > more specific lock for protecting the bo lists. Most excellent. Reviewed-by: Jordan Crouse > Signed-off-by: Rob Clark > --- > drivers/gpu/d

Re: [Freedreno] [PATCH 03/14] drm/msm: Move update_fences()

2020-10-05 Thread Jordan Crouse
On Sun, Oct 04, 2020 at 12:21:35PM -0700, Rob Clark wrote: > From: Rob Clark > > Small cleanup, update_fences() is used in the hangcheck path, but also > in the normal retire path. Reviewed-by: Jordan Crouse > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpu.c | 28 ++

Re: [Freedreno] [PATCH 02/14] drm/msm: Drop chatty trace

2020-10-05 Thread Jordan Crouse
On Sun, Oct 04, 2020 at 12:21:34PM -0700, Rob Clark wrote: > From: Rob Clark > > It is somewhat redundant with the gpu tracepoints, and anyways not too > useful to justify spamming the log when debug traces are enabled. Reviewed-by: Jordan Crouse > Signed-off-by: Rob Clark > --- > drivers/gp

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-05 Thread Daniel Vetter
On Mon, Oct 05, 2020 at 03:15:24PM +0300, Ville Syrjälä wrote: > On Fri, Oct 02, 2020 at 10:55:52AM -0700, Rob Clark wrote: > > On Fri, Oct 2, 2020 at 4:05 AM Ville Syrjälä > > wrote: > > > > > > On Fri, Oct 02, 2020 at 01:52:56PM +0300, Ville Syrjälä wrote: > > > > On Thu, Oct 01, 2020 at 05:25:5

Re: [PATCH] drm: bridge: dw-hdmi: Constify dw_hdmi_i2s_ops

2020-10-05 Thread Daniel Vetter
On Sun, Oct 04, 2020 at 10:06:53PM +0200, Rikard Falkeborn wrote: > The only usage of dw_hdmi_i2s_ops is to assign its address to the ops > field in the hdmi_codec_pdata struct, which is a const pointer. Make it > const to allow the compiler to put it in read-only memory. > > Signed-off-by: Rikard

Re: [PATCH] Revert "gpu/drm: ingenic: Add option to mmap GEM buffers cached"

2020-10-05 Thread Daniel Vetter
On Mon, Oct 05, 2020 at 11:01:50PM +1100, Stephen Rothwell wrote: > Hi Paul, > > On Sun, 04 Oct 2020 22:11:23 +0200 Paul Cercueil wrote: > > > > Pushed to drm-misc-next with the changelog fix, thanks. > > > > Stephen: > > Now it should build fine again. Could you remove the BROKEN flag? > > Tha

Re: [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-05 Thread Daniel Vetter
On Mon, Oct 05, 2020 at 05:24:19PM +0800, Hillf Danton wrote: > > On Sun, 4 Oct 2020 12:21:45 > > From: Rob Clark > > > > Now that the inactive_list is protected by mm_lock, and everything > > else on per-obj basis is protected by obj->lock, we no longer depend > > on struct_mutex. > > > > Sig

  1   2   >