Re: [PATCH RFC PKS/PMEM 09/58] drivers/gpu: Utilize new kmap_thread()

2020-10-10 Thread Ira Weiny
On Sat, Oct 10, 2020 at 12:03:49AM +0200, Daniel Vetter wrote: > On Fri, Oct 09, 2020 at 12:49:44PM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > These kmap() calls in the gpu stack are localized to a single thread. > > To avoid the over head of global PKRS updates use the new

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Daniel Vetter
On Sat, Oct 10, 2020 at 11:36 PM Laurent Pinchart wrote: > > Hi Tomasz, > > On Sat, Oct 10, 2020 at 07:22:48PM +0200, Tomasz Figa wrote: > > On Fri, Oct 9, 2020 at 7:52 PM Daniel Vetter wrote: > > > On Fri, Oct 9, 2020 at 2:48 PM Jason Gunthorpe wrote: > > > > On Fri, Oct 09, 2020 at 02:37:23PM

Re: [PATCH v2 03/17] misc/habana: Stop using frame_vector helpers

2020-10-10 Thread Oded Gabbay
On Sun, Oct 11, 2020 at 12:41 AM Daniel Vetter wrote: > > On Sat, Oct 10, 2020 at 11:32 PM Daniel Vetter wrote: > > > > On Sat, Oct 10, 2020 at 10:27 PM Oded Gabbay wrote: > > > > > > On Fri, Oct 9, 2020 at 10:59 AM Daniel Vetter > > > wrote: > > > > > > > > All we need are a pages array,

Re: [PATCH v2 03/17] misc/habana: Stop using frame_vector helpers

2020-10-10 Thread Daniel Vetter
On Sat, Oct 10, 2020 at 11:32 PM Daniel Vetter wrote: > > On Sat, Oct 10, 2020 at 10:27 PM Oded Gabbay wrote: > > > > On Fri, Oct 9, 2020 at 10:59 AM Daniel Vetter > > wrote: > > > > > > All we need are a pages array, pin_user_pages_fast can give us that > > > directly. Plus this avoids the

Re: [PATCH] ARM: davinci_all_defconfig: Add CONFIG_DRM_DISPLAY_CONNECTOR=m

2020-10-10 Thread Laurent Pinchart
Hi Jyri, Thank you for the patch. On Sat, Oct 10, 2020 at 07:08:50PM +0300, Jyri Sarha wrote: > Current dumb-vga-dac driver requires CONFIG_DRM_DISPLAY_CONNECTOR > for it to work. > > Signed-off-by: Jyri Sarha Reviewed-by: Laurent Pinchart > --- > An alternative would be selecting

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Laurent Pinchart
Hi Tomasz, On Sat, Oct 10, 2020 at 07:22:48PM +0200, Tomasz Figa wrote: > On Fri, Oct 9, 2020 at 7:52 PM Daniel Vetter wrote: > > On Fri, Oct 9, 2020 at 2:48 PM Jason Gunthorpe wrote: > > > On Fri, Oct 09, 2020 at 02:37:23PM +0200, Mauro Carvalho Chehab wrote: > > > > > > > I'm not a mm/

Re: [PATCH v2 03/17] misc/habana: Stop using frame_vector helpers

2020-10-10 Thread Daniel Vetter
On Sat, Oct 10, 2020 at 10:27 PM Oded Gabbay wrote: > > On Fri, Oct 9, 2020 at 10:59 AM Daniel Vetter wrote: > > > > All we need are a pages array, pin_user_pages_fast can give us that > > directly. Plus this avoids the entire raw pfn side of get_vaddr_frames. > > > Thanks for the patch Daniel.

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Laurent Pinchart
Hi Daniel, On Fri, Oct 09, 2020 at 07:52:05PM +0200, Daniel Vetter wrote: > On Fri, Oct 9, 2020 at 2:48 PM Jason Gunthorpe wrote: > > On Fri, Oct 09, 2020 at 02:37:23PM +0200, Mauro Carvalho Chehab wrote: > > > > > I'm not a mm/ expert, but, from what I understood from Daniel's patch > > >

[PATCH v3 0/2] drm/tilcdc: Couple of minor feature improvements

2020-10-10 Thread Jyri Sarha
Since v2: - "drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data" - Add reviewed-by tag - fix: -:106: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #106: FILE: drivers/gpu/drm/tilcdc/tilcdc_drv.c:289: + if (of_property_read_u32(node,

[PATCH v3 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data

2020-10-10 Thread Jyri Sarha
We already have a private data member for maximum display width so let's use it and get rid of the redundant tilcdc_crtc_max_width(). The LCDC version probing is moved to before reading the device tree properties so that the version information is available when private data maximum width is

[PATCH v3 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time

2020-10-10 Thread Jyri Sarha
END_OF_FRAME interrupts have been enabled all the time since the beginning of this driver. It is about time to add this feature. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 36 +--- 1

Re: [PATCH v2 03/17] misc/habana: Stop using frame_vector helpers

2020-10-10 Thread Oded Gabbay
On Fri, Oct 9, 2020 at 10:59 AM Daniel Vetter wrote: > > All we need are a pages array, pin_user_pages_fast can give us that > directly. Plus this avoids the entire raw pfn side of get_vaddr_frames. > Thanks for the patch Daniel. > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc:

[PATCH] ARM: davinci_all_defconfig: Add CONFIG_DRM_DISPLAY_CONNECTOR=m

2020-10-10 Thread Jyri Sarha
Current dumb-vga-dac driver requires CONFIG_DRM_DISPLAY_CONNECTOR for it to work. Signed-off-by: Jyri Sarha --- An alternative would be selecting CONFIG_DRM_DISPLAY_CONNECTOR from all bridges requiring DRM connector. arch/arm/configs/davinci_all_defconfig | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Tomasz Figa
Hi Mauro, On Fri, Oct 9, 2020 at 2:37 PM Mauro Carvalho Chehab wrote: > > Em Fri, 9 Oct 2020 09:21:11 -0300 > Jason Gunthorpe escreveu: > > > On Fri, Oct 09, 2020 at 12:34:21PM +0200, Mauro Carvalho Chehab wrote: > > > Hi, > > > > > > Em Fri, 9 Oct 2020 09:59:26 +0200 > > > Daniel Vetter

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Tomasz Figa
Hi Daniel, On Fri, Oct 9, 2020 at 7:52 PM Daniel Vetter wrote: > > On Fri, Oct 9, 2020 at 2:48 PM Jason Gunthorpe wrote: > > > > On Fri, Oct 09, 2020 at 02:37:23PM +0200, Mauro Carvalho Chehab wrote: > > > > > I'm not a mm/ expert, but, from what I understood from Daniel's patch > > >

[Bug 205649] Daisy Chain (MST) Session Crash after Screen Lock Resume

2020-10-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205649 Michael Rauch (mich...@rauch.be) changed: What|Removed |Added Kernel Version|5.3, 5.4, 5.5-rc3 |5.3, 5.4, 5.5-rc3,

[Bug 205649] Daisy Chain (MST) Session Crash after Screen Lock Resume

2020-10-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205649 --- Comment #3 from Michael Rauch (mich...@rauch.be) --- Same behavior with Kernel 5.9.0-050900rc7-generic and Mesa 20.0.8. -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Daniel Vetter
On Sat, Oct 10, 2020 at 1:39 PM Mauro Carvalho Chehab wrote: > > Em Sat, 10 Oct 2020 12:53:49 +0200 > Daniel Vetter escreveu: > > > Hi Mauro, > > > > You might want to read the patches more carefully, because what you're > > demanding is what my patches do. Short summary: > > > > - if

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Mauro Carvalho Chehab
Em Sat, 10 Oct 2020 12:53:49 +0200 Daniel Vetter escreveu: > Hi Mauro, > > You might want to read the patches more carefully, because what you're > demanding is what my patches do. Short summary: > > - if STRICT_FOLLOW_PFN is set: > a) normal memory is handled as-is (i.e. your example works)

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Daniel Vetter
Hi Mauro, You might want to read the patches more carefully, because what you're demanding is what my patches do. Short summary: - if STRICT_FOLLOW_PFN is set: a) normal memory is handled as-is (i.e. your example works) through the addition of FOLL_LONGTERM. This is the "pin the pages correctly"

[PATCH] drm/amd/display: remove no need return value

2020-10-10 Thread Bernard Zhao
Functions (disable_all_writeback_pipes_for_stream & dc_enable_stereo & dc_post_update_surfaces_to_stream) always return true, there is no need to keep the return value. This change is to make the code a bit more readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/core/dc.c

[PULL] drm-misc-next-fixes

2020-10-10 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week PR for drm-misc-next-fixes Maxime drm-misc-next-fixes-2020-10-09: One MAINTAINERS change and a revert for a compilation breakage in next for ingenic The following changes since commit 089d83418914abd4d908db117d9a3eca7f51a68c: drm/vc4: hvs: Pull the state of

Re: [PATCH 1/6] mm: mmap: fix fput in error path

2020-10-10 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 05:03:37PM +0200, Christian König wrote: > Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." > adds a workaround for a bug in mmap_region. > > As the comment states ->mmap() callback can change > vma->vm_file and so we might call fput() on the wrong file. > > Revert

Re: [PATCH 1/4] mm: introduce vma_set_file function v2

2020-10-10 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 09:39:00AM +0200, Daniel Vetter wrote: > I just noticed this here in the patch because everyone else does not do > this. But looking at the mmap_region() code in mmap.c we seem to indeed > have this problem for the error path: > > unmap_and_free_vma: > vma->vm_file =

[PATCH 2/2] drm/i915: Force DPCD backlight mode for BOE 2270 panel

2020-10-10 Thread Aaron Ma
BOE 2270 panel failed to control backlight brightness. Add it in edid quirks to force using DPCD backlight control. Then the brightness can be controlled. Signed-off-by: Aaron Ma --- drivers/gpu/drm/drm_dp_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v2 3/7] dt-bindings: display: mxsfb: Add a bus-width endpoint property

2020-10-10 Thread Marek Vasut
On 10/10/20 1:58 AM, Laurent Pinchart wrote: > Hi Marek, Hi, > On Wed, Oct 07, 2020 at 10:40:26AM +0200, Marek Vasut wrote: >> On 10/7/20 3:24 AM, Laurent Pinchart wrote: >> >> [...] >> >>> + bus-width: >>> +enum: [16, 18, 24] >>> +description: | >>> +

Re: [PATCH RFC PKS/PMEM 51/58] kernel: Utilize new kmap_thread()

2020-10-10 Thread Eric W. Biederman
ira.we...@intel.com writes: > From: Ira Weiny > > This kmap() call is localized to a single thread. To avoid the over > head of global PKRS updates use the new kmap_thread() call. Acked-by: "Eric W. Biederman" > > Cc: Eric Biederman > Signed-off-by: Ira Weiny > --- > kernel/kexec_core.c |

Re: [Nouveau] nouveau broken on Riva TNT2 in 5.9.0-rc8: GPU not supported on big-endian

2020-10-10 Thread Ondrej Zary
On Saturday 10 October 2020 00:23:38 Ilia Mirkin wrote: > On Fri, Oct 9, 2020 at 5:54 PM Karol Herbst wrote: > > > > On Fri, Oct 9, 2020 at 11:35 PM Ondrej Zary wrote: > > > > > > Hello, > > > I'm testing 5.9.0-rc8 and found that Riva TNT2 stopped working: > > > [0.00] Linux version

Re: [PATCH v2 14/17] resource: Move devmem revoke code to resource framework

2020-10-10 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 04:24:45PM +0200, Daniel Vetter wrote: > On Fri, Oct 9, 2020 at 2:31 PM Jason Gunthorpe wrote: > > > > On Fri, Oct 09, 2020 at 09:59:31AM +0200, Daniel Vetter wrote: > > > > > +struct address_space *iomem_get_mapping(void) > > > +{ > > > + return

[PATCH] drm/nouveau/kms: Fix NULL pointer dereference in nouveau_connector_detect_depth

2020-10-10 Thread Alexander Kapshuk
This oops manifests itself on the following hardware: 01:00.0 VGA compatible controller: NVIDIA Corporation G98M [GeForce G 103M] (rev a1) Oct 09 14:17:46 lp-sasha kernel: BUG: kernel NULL pointer dereference, address: Oct 09 14:17:46 lp-sasha kernel: #PF: supervisor read

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 02:37:23PM +0200, Mauro Carvalho Chehab wrote: > I'm not a mm/ expert, but, from what I understood from Daniel's patch > description is that this is unsafe *only if* __GFP_MOVABLE is used. No, it is unconditionally unsafe. The CMA movable mappings are specific VMAs that

Re: [PATCH 2/6] mm: introduce vma_set_file function v3

2020-10-10 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 05:03:38PM +0200, Christian König wrote: > +/* > + * Change backing file, only valid to use during initial VMA setup. > + */ > +void vma_set_file(struct vm_area_struct *vma, struct file *file) > +{ > + if (file) > + get_file(file); > + > +

[PATCH] MAINTAINERS: Add myself as a maintainer for vc4

2020-10-10 Thread Maxime Ripard
Eric isn't working on vc4 anymore and I've been working on it, as well as merging patches for it, recently so let's make it official so I don't miss patches. Signed-off-by: Maxime Ripard --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH 1/6] mm: mmap: fix fput in error path

2020-10-10 Thread linmiaohe
Jason Gunthorpe wrote: > On Fri, Oct 09, 2020 at 03:04:20PM -0700, Andrew Morton wrote: >> On Fri, 9 Oct 2020 17:03:37 +0200 "Christian König" >> wrote: >> >> > Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." >> > adds a workaround for a bug in mmap_region. >> > >> > As the comment

nouveau broken on Riva TNT2 in 5.9.0-rc8: GPU not supported on big-endian

2020-10-10 Thread Ondrej Zary
Hello, I'm testing 5.9.0-rc8 and found that Riva TNT2 stopped working: [0.00] Linux version 5.9.0-rc8+ (zary@gsql) (gcc (Debian 8.3.0-6) 8.3.0, GNU ld (GNU Binutils for Debian) 2.31.1) #326 SMP Fri Oct 9 22:31:40 CEST 2020 ... [ 14.771464] nouveau :01:00.0: GPU not supported on

[PATCH] drm/msm/disp: add error value record in for circle`s error index

2020-10-10 Thread Bernard Zhao
In function dpu_core_irq_enable & dpu_core_irq_disable, when some index enable or disable failed, return value will be covered by next success index. Upper call function will not catch this error, this maybe does not meet the expectation. This change is to make the code a bit more readable.

[tip: core/rcu] drm/i915: Cleanup PREEMPT_COUNT leftovers

2020-10-10 Thread tip-bot2 for Thomas Gleixner
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 5d35c1c982ffaaccd1ec974e96e7a5244bbadaa1 Gitweb: https://git.kernel.org/tip/5d35c1c982ffaaccd1ec974e96e7a5244bbadaa1 Author:Thomas Gleixner AuthorDate:Mon, 14 Sep 2020 19:35:03 +02:00

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 12:34:21PM +0200, Mauro Carvalho Chehab wrote: > Hi, > > Em Fri, 9 Oct 2020 09:59:26 +0200 > Daniel Vetter escreveu: > > > Way back it was a reasonable assumptions that iomem mappings never > > change the pfn range they point at. But this has changed: > > > > - gpu

Re: [PATCH RFC PKS/PMEM 48/58] drivers/md: Utilize new kmap_thread()

2020-10-10 Thread Coly Li
On 2020/10/10 03:50, ira.we...@intel.com wrote: > From: Ira Weiny > > These kmap() calls are localized to a single thread. To avoid the over > head of global PKRS updates use the new kmap_thread() call. > Hi Ira, There were a number of options considered. 1) Attempt to change all the thread

Re: [PATCH v2 14/17] resource: Move devmem revoke code to resource framework

2020-10-10 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 09:59:31AM +0200, Daniel Vetter wrote: > +struct address_space *iomem_get_mapping(void) > +{ > + return iomem_inode->i_mapping; This should pair an acquire with the release below > + /* > + * Publish /dev/mem initialized. > + * Pairs with

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 07:52:05PM +0200, Daniel Vetter wrote: > > > If this is the case, the proper fix seems to have a GFP_NOT_MOVABLE > > > flag that it would be denying the core mm code to set __GFP_MOVABLE. > > > > We can't tell from the VMA these kinds of details.. > > > > It has to go the

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-10 Thread Matthew Wilcox
On Fri, Oct 09, 2020 at 02:34:34PM -0700, Eric Biggers wrote: > On Fri, Oct 09, 2020 at 12:49:57PM -0700, ira.we...@intel.com wrote: > > The kmap() calls in this FS are localized to a single thread. To avoid > > the over head of global PKRS updates use the new kmap_thread() call. > > > > @@

Re: [PATCH 1/6] mm: mmap: fix fput in error path

2020-10-10 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 03:04:20PM -0700, Andrew Morton wrote: > On Fri, 9 Oct 2020 17:03:37 +0200 "Christian König" > wrote: > > > Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." > > adds a workaround for a bug in mmap_region. > > > > As the comment states ->mmap() callback can

[PATCH 1/2] drm/i915/dpcd_bl: uncheck PWM_PIN_CAP when detect eDP backlight capabilities

2020-10-10 Thread Aaron Ma
BOE panel with ID 2270 claims both PWM_PIN_CAP and AUX_SET_CAP backlight control bits, but default chip backlight failed to control brightness. Check AUX_SET_CAP and proceed to check quirks or VBT backlight type. DPCD can control the brightness of this pannel. Signed-off-by: Aaron Ma ---

Re: [PATCH v2 10/17] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-10-10 Thread Mauro Carvalho Chehab
Em Fri, 9 Oct 2020 09:59:27 +0200 Daniel Vetter escreveu: > The media model assumes that buffers are all preallocated, so that > when a media pipeline is running we never miss a deadline because the > buffers aren't allocated or available. > > This means we cannot fix the v4l follow_pfn usage

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Mauro Carvalho Chehab
Em Fri, 9 Oct 2020 19:52:05 +0200 Daniel Vetter escreveu: > On Fri, Oct 9, 2020 at 2:48 PM Jason Gunthorpe wrote: > > > > On Fri, Oct 09, 2020 at 02:37:23PM +0200, Mauro Carvalho Chehab wrote: > > > > > I'm not a mm/ expert, but, from what I understood from Daniel's patch > > > description is

Re: [PATCH v8 3/4] drm/kmb: Mipi DSI part of the display driver

2020-10-10 Thread Daniel Vetter
On Fri, Oct 02, 2020 at 07:17:01PM -0700, Anitha Chrisanthus wrote: > Initializes Mipi DSI and sets up connects to ADV bridge > > v2: removed license text > upclassed dev_private, removed HAVE_IRQ. (Sam) > > v3: Squashed all 59 commits to one > > v4: review changes from Sam Ravnborg >

Re: [PATCH v1 1/4] drm: Add Keem Bay VPU codec DRM

2020-10-10 Thread Ezequiel Garcia
Hello everyone, (Adding some Hantro developers) On Fri, 9 Oct 2020 at 19:15, Daniel Vetter wrote: > > On Fri, Oct 09, 2020 at 07:57:52PM +0800, kuhanh.murugasen.krish...@intel.com > wrote: > > From: "Murugasen Krishnan, Kuhanh" > > > > This is a new DRM media codec driver for Intel's Keem Bay

[PATCH v4 2/2] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-10-10 Thread Jitao Shi
Replace horizontal_backporch_byte with vm->hback_porch * bpp to aovid flowing judgement negative number. if ((vm->hfront_porch * dsi_tmp_buf_bpp + horizontal_backporch_byte) > data_phy_cycles * dsi->lanes + delta) Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dsi.c | 54

[PATCH v4 1/2] Revert "drm/mediatek: dsi: Fix scrolling of panel with small hfp or hbp"

2020-10-10 Thread Jitao Shi
This reverts commit 35bf948f1edbf507f6e57e0879fa6ea36d2d2930. Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dsi.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index

[v4 PATCH 0/2] fix scrolling of panel with small hfp or hbp

2020-10-10 Thread Jitao Shi
Changes since v3: - Revert v2, for v2 will cause some bridge ic no output. the cause the video linetime doesn't match display mode from get mode. - Make sure the horizontal_frontporch_byte and horizontal_backporch_byte are > 0. Jitao Shi (2): Revert "drm/mediatek: dsi: Fix scrolling of