[PATCH v3 26/56] drm/omap: dsi: drop custom enable_te() API

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Instead of using the custon enable_te() API, this automatically enables/disables TE core support when a matching packet is send to the panel. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 3 --

Re: [PATCH v4 10/16] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:12:02 +0530, Anshuman Gupta wrote: > Fix the size of WIRED_REPEATER_AUTH_STREAM_REQ cmd buffer size. > It is based upon the actual number of MST streams and size > of wired_cmd_repeater_auth_stream_req_in. > Excluding the size of hdcp_cmd_header. > > v2: > hdcp_cmd_header size

[PATCH v3 33/56] drm/omap: dsi: convert to drm_panel

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This converts the DSI module to expect common drm_panel display drivers instead of dssdev based ones. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 204 +++---

[PATCH v3 44/56] drm/omap: simplify omap_display_id

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel We no longer need to check for the DSS API, since all encoders, panels and connectors have been converted to the bridge API. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_drv.c | 9 + 1 file changed, 1

[PATCH v3 50/56] drm/omap: dsi: simplify pin config

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify DSI pin config, which always originates from DT nowadays. With the code being fully contained in the DSI encoder, we can drop the public structure. Since the function is no longer exposed, it now directly takes the private DSI data pointer. This drop a pointless

[PATCH v3 32/56] drm/omap: dsi: drop custom panel capability support

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Due to previous changes the DSI encoder gets the capabilities via DSI client's mode_flags and no longer needs the omapdss specific caps. The core code now checks if the DSI encoder is actually configured into command mode instead of just checking the panel capabilities.

[PATCH v3 37/56] drm/omap: panel-dsi-cm: support unbinding

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Now, that the driver implements the common DRM panel API the unbind no longer needs to be suppressed. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH v3 36/56] drm/omap: panel-dsi-cm: use DEVICE_ATTR_RO

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 8 1 file changed, 4

[PATCH v3 47/56] drm/omap: drop DSS ops_flags

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The omapdss device's ops_flags field is no longer used and can be dropped. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 9 - drivers/gpu/drm/omapdrm/dss/venc.c| 1 - 2 files changed, 10

[PATCH v3 45/56] drm/omap: drop unused DSS next pointer

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Since all encoders and panels are using the bridge API now, we next pointer is no longer useful and can be dropped. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c | 2 +- drivers/gpu/drm/omapdrm/dss/omapdss.h

[PATCH v3 34/56] drm/omap: drop omapdss-boot-init

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The table of compatible values needed to be prefixed with "omapdss," is empty, so all of this code is doing nothing now. Let's drop it. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/Kconfig | 4 -

[PATCH v3 46/56] drm/omap: drop empty omap_encoder helper functions

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Cleanup empty functions for encoder enable, disable and atomic check. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_encoder.c | 28 -- 1 file changed, 28 deletions(-) diff --git

[PATCH v3 52/56] drm/omap: squash omapdrm sub-modules into one

2020-11-05 Thread Tomi Valkeinen
At the moment we have three different modules: omapdss-base, omapdss, omapdrm. This setup is finally obsolete, as the last omapdrm specific panel has been converted to DRM panel. We can thus remove omapdss-base and omapdss, and just compile everything into omapdrm.ko. Signed-off-by: Tomi

[PATCH v3 41/56] drm/omap: dsi: Register a drm_bridge

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel In order to integrate with a chain of drm_bridge, the internal DSI output has to expose its operations through the drm_bridge API. Register a bridge at initialisation time to do so and remove the omap_dss_device operations that are now unused. Signed-off-by: Sebastian

[PATCH v3 38/56] drm/omap: panel-dsi-cm: fix remove()

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Do not try to reset the panel after DSI has been detached, since the DSI clocks may have been disabled at this point. The panel will be disabled and unprepared before being removed and a reset will be done when being probed again. Signed-off-by: Sebastian Reichel

[PATCH v3 48/56] drm/omap: drop dssdev display field

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel All displays are using drm_panel instead off dssdev now, so this field is always 0 and can be dropped. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c| 2 +- drivers/gpu/drm/omapdrm/dss/omapdss.h | 6 -- 2

[PATCH v3 42/56] drm/omap: remove legacy DSS device operations

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel All DSS devices have been converted to bridge API, so the device operations are always NULL. This removes the device ops function pointers and all code using it. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c

[PATCH v3 43/56] drm/omap: remove unused omap_connector

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Remove unused code. Connectors are now created via drm_bridge_connector_init() and no longer OMAP specific. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/Makefile | 1 - drivers/gpu/drm/omapdrm/omap_connector.c |

[PATCH v3 39/56] drm/omap: remove global dss_device variable

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel We can simply provide the device to the omapdrm driver via pdata. omapdss_is_initialized() is no longer required (even before this patch), since omapdrm device is only registered after the pointer is initialized. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi

[PATCH v3 31/56] drm/omap: dsi: Reverse direction of the DSS device enable/disable operations

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Complete the direction reversal of the DSS device enable/disable operations started by 19b4200d8f4b ("drm/omap: Reverse direction of the DSS device enable/disable operations"). This effectively drops the requirement of calling DSS specific code from the DSI panel driver

[PATCH v3 10/56] drm/omap: dsi: simplify write function

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify the write related messages handling by using the functionality provided by CONFIG_DRM_MIPI_DSI. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/Kconfig | 1 + drivers/gpu/drm/omapdrm/dss/dsi.c | 146

[PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-05 Thread Tomi Valkeinen
Hi, This is third version of the series sent by Sebastian in February: https://www.spinics.net/lists/linux-omap/msg153465.html I took the patches from his git tree, and rebased on 5.10-rc2. There were some conflicts and compilation errors, and one bug that made dsi to not work (videomode

[PATCH v3 24/56] drm/omap: dsi: lp/hs switching support for transfer()

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Integrate low-power / high-speed bus switching into transfer function and drop the omapdrm specific enable_hs() callback. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 6 +++---

[PATCH v3 06/56] drm/omap: dsi: add generic transfer function

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This prepares the driver for becoming a mipi_dsi_host implementation, which provides a generic transfer function instead of all kind of different read/write functions. The implementation will become more elegant after unexporting the specific functions in the following

[PATCH v3 08/56] drm/omap: dsi: unexport specific data transfer functions

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel After converting all DSI drivers, unexport the specific transfer functions. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 12 drivers/gpu/drm/omapdrm/dss/omapdss.h | 20 2

[PATCH v3 07/56] drm/omap: panel-dsi-cm: convert to transfer API

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This converts the panel-dsi-cm driver to use the transfer API instead of specific functions, so that the specific functions can be unexported and squashed into the generic transfer function. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen ---

[PATCH v3 11/56] drm/omap: dsi: simplify read functions

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify the read related message handling by using the functionality provided by CONFIG_DRM_MIPI_DSI. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 110 +- 1 file changed, 34

[PATCH v3 16/56] drm/omap: panel-dsi-cm: drop hardcoded VC

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Use dsi->channel everywhere, which originates from DT. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 20 +++ 1 file changed, 7 insertions(+), 13 deletions(-) diff --git

[PATCH v3 02/56] Revert "drm/omap: dss: Remove unused omap_dss_device operations"

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This reverts commit 4ff8e98879e6eeae9d125dfcf3b642075d00089d. This is still needed by DSI. E.g. unloading modules without this will cause a crash. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c | 26

[PATCH v3 01/56] drm/dsi: add MIPI_DSI_MODE_ULPS_IDLE

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel DSI command mode panels are self-refreshing displays, that can be updated very rarely for static images. For this kind of scenario some panels support, that the DSI bus switches into ULPS mode until the panel needs to be refreshed. This is problematic on some panels, so

[PATCH v3 22/56] drm/omap: dsi: use pixel-format and mode from attach

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel In order to reduce the amount of custom functionality, this moves handling of pixel format and DSI mode from set_config() to dsi attach. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 2 --

[PATCH v3 14/56] drm/omap: panel-dsi-cm: use DSI helpers

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel After converting the driver to mipi_dsi_device we can use the generic message helpers to simplify the driver a lot. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 125 +++--- 1 file

Re: [drm-drm-misc:for-linux-next 2/2] drivers/dma-buf/dma-buf.c:1186: undefined reference to `vma_set_file'

2020-11-05 Thread Christian König
um 16:26 schrieb kernel test robot: tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 2b5b95b1ff3d70a95013a45e3b5b90f1daf42348 commit: 2b5b95b1ff3d70a95013a45e3b5b90f1daf42348 [2/2] mm: introduce vma_set_file function v4 config: h8300-randconfig-r031-20201105 (attached

[PATCH v3 09/56] drm/omap: dsi: drop virtual channel logic

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This drops the virtual channel logic. Afterwards DSI clients request their channel number and get the virtual channel with the same number or -EBUSY if already in use. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen ---

[PATCH v3 25/56] drm/omap: dsi: move TE GPIO handling into core

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel In preparation for removing custom DSS calls from the DSI panel driver, this moves support for external tearing event GPIOs into the DSI host driver. This way tearing events are always handled in the core resulting in simplification of the panel drivers. The TE GPIO

[PATCH v3 04/56] drm/omap: dsi: use MIPI_DSI_FMT_* instead of OMAP_DSS_DSI_FMT_*

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This replaces OMAP specific enum for pixel format with common implementation. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 2 +- drivers/gpu/drm/omapdrm/dss/dsi.c | 55

[PATCH v3 18/56] drm/omap: dsi: drop unused memory_read()

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel memory_read is not used, so we can drop the code. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 93 --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 4 - 2 files changed, 97

[PATCH v3 13/56] drm/omap: dsi: introduce mipi_dsi_host

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This moves from custom platform driver infrastructure to mipi_dsi_host and mipi_dsi_device. Note, that this is a graduate step and the driver only uses the devices types and transfer function, but not yet the new device binding style or drm_panel. Signed-off-by:

[PATCH v3 12/56] drm/omap: dsi: switch dsi_vc_send_long/short to mipi_dsi_msg

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify the DSI encoder by using mipi_dsi_msg for dsi_vc_send_long and dsi_vc_send_short. Further improvements require cleaning up the channel allocation code first. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c

[PATCH v3 15/56] drm/omap: dsi: request VC via mipi_dsi_attach

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Drop custom request_vc/release_vc callbacks by using the generic mipi_dsi_attach/mipi_dsi_detach functions. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 24 +---

[PATCH v3 03/56] drm/omap: drop unused dsi.configure_pins

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The panel-dsi-cm's ddata->pin_config is always NULL, so this callback is never called. Instead the DSI encoder gets the pin configuration directly from DT. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen ---

[PATCH v3 19/56] drm/omap: dsi: drop unused get_te()

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The get_te() callback is not used, so we can drop the custom API. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 13 - drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 - 2 files

[PATCH v3 21/56] drm/omap: dsi: drop useless sync()

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The DSI sync() function only locks the bus and then releases it again. Currently the only invocation is directly before update(), which locks the bus anyways. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen ---

[PATCH v3 20/56] drm/omap: dsi: drop unused enable_te()

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel enable_te() is not used, so the custom API can be dropped. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 39 --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 - 2 files changed,

[PATCH v3 05/56] drm/omap: constify write buffers

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The write buffers are not modified, so they can be constant. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 24 drivers/gpu/drm/omapdrm/dss/omapdss.h | 10 +- 2 files changed,

[PATCH v3 17/56] drm/omap: panel-dsi-cm: use common MIPI DCS 1.3 defines

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Drop local definition of common MIPI DCS 1.3 defines. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH v3 23/56] drm/omap: panel-dsi-cm: use bulk regulator API

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Use bulk regulator API to simplify the code. This also switches from _optional variant to normal variant, which will provide a dummy regulator (i.e. if some always-enabled regulator is not described in DT). Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen

Re: [drm-drm-misc:for-linux-next 2/2] drivers/dma-buf/dma-buf.c:1186: undefined reference to `vma_set_file'

2020-11-05 Thread Daniel Vetter
> > > Am 05.11.20 um 16:26 schrieb kernel test robot: > > > tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next > > > head: 2b5b95b1ff3d70a95013a45e3b5b90f1daf42348 > > > commit: 2b5b95b1ff3d70a95013a45e3b5b90f1daf42348 [2/2] mm: introduce >

Re: [drm-drm-misc:for-linux-next 2/2] drivers/dma-buf/dma-buf.c:1186: undefined reference to `vma_set_file'

2020-11-05 Thread Daniel Vetter
reedesktop.org/drm/drm-misc for-linux-next > > head: 2b5b95b1ff3d70a95013a45e3b5b90f1daf42348 > > commit: 2b5b95b1ff3d70a95013a45e3b5b90f1daf42348 [2/2] mm: introduce > > vma_set_file function v4 > > config: h8300-randconfig-r031-20201105 (attached as .config) > > compi

Re: [drm-drm-misc:for-linux-next 2/2] drivers/dma-buf/dma-buf.c:1186: undefined reference to `vma_set_file'

2020-11-05 Thread Christian König
: 2b5b95b1ff3d70a95013a45e3b5b90f1daf42348 [2/2] mm: introduce vma_set_file function v4 config: h8300-randconfig-r031-20201105 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F

Re: [PATCH v4 07/16] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:11:59 +0530, Anshuman Gupta wrote: > Enable HDCP 1.4 over DP MST for Gen12. > This also enable the stream encryption support for > older generations, which was missing earlier. It will be nice to have them in separate patches. -Ram > > v2: > - Added debug print for stream

Re: [PATCH 6/6] drm/amdgpu: Make struct drm_driver const

2020-11-05 Thread Daniel Vetter
On Wed, Nov 04, 2020 at 11:04:25AM +0100, Daniel Vetter wrote: > From: Luben Tuikov > > Make the definition of struct drm_driver > a constant, to follow the latest developments > in the DRM layer. > > Signed-off-by: Luben Tuikov > [danvet: Rebase onto devm_drm_dev_alloc patch and drop the

Re: [PATCH v4 06/16] drm/i915/hdcp: HDCP stream encryption support

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:11:58 +0530, Anshuman Gupta wrote: > Both HDCP_{1.x,2.x} requires to select/deselect Multistream HDCP bit > in TRANS_DDI_FUNC_CTL in order to enable/disable stream HDCP > encryption over DP MST Transport Link. > > HDCP 1.4 stream encryption requires to validate the stream

Re: [PATCH v5] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-05 Thread Steven Price
On 05/11/2020 15:17, Boris Brezillon wrote: We've fixed many races in panfrost_job_timedout() but some remain. Instead of trying to fix it again, let's simplify the logic and move the reset bits to a separate work scheduled when one of the queue reports a timeout. v5: - Simplify

[PATCH v5] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-05 Thread Boris Brezillon
We've fixed many races in panfrost_job_timedout() but some remain. Instead of trying to fix it again, let's simplify the logic and move the reset bits to a separate work scheduled when one of the queue reports a timeout. v5: - Simplify panfrost_scheduler_stop() (Steven Price) - Always restart the

Re: [PATCH v3 40/56] drm/panel: Move OMAP's DSI command mode panel driver

2020-11-05 Thread Sam Ravnborg
On Thu, Nov 05, 2020 at 02:03:17PM +0200, Tomi Valkeinen wrote: > From: Sebastian Reichel > > The panel driver is no longer using any OMAP specific APIs, so > let's move it into the generic panel directory. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Tomi Valkeinen > Cc: Thierry

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-05 Thread Christian König
Am 05.11.20 um 15:38 schrieb Daniel Vetter: On Thu, Nov 5, 2020 at 3:31 PM Daniel Vetter wrote: On Thu, Nov 5, 2020 at 2:22 PM Christian König wrote: Am 05.11.20 um 14:20 schrieb Daniel Vetter: On Thu, Nov 05, 2020 at 01:56:22PM +0100, Christian König wrote: Am 05.11.20 um 13:50 schrieb

[PATCH 18/19] gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused

2020-11-05 Thread Lee Jones
These 3 variables are used in *some* sourcefiles which include amdgpu.h, but not *all*. This leads to a flurry of build warnings. Fixes the following W=1 kernel build warning(s): from drivers/gpu/drm/amd/amdgpu/amdgpu.h:67, drivers/gpu/drm/amd/amdgpu/amdgpu.h:198:19: warning:

[PATCH 13/19] gpu: drm: ttm: ttm_tt: Demote kernel-doc header format abuses

2020-11-05 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_tt.c:45: warning: Function parameter or member 'bo' not described in 'ttm_tt_create' drivers/gpu/drm/ttm/ttm_tt.c:45: warning: Function parameter or member 'zero_alloc' not described in 'ttm_tt_create'

[PATCH 17/19] gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc misdemeanours

2020-11-05 Thread Lee Jones
- Demote non-conformant headers - Fix misnaming issues - Rename labels with identical names - Remove incorrect descriptions Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous prototype for ‘radeon_device_is_virtual’

[PATCH 19/19] gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_start_aux_transaction'

2020-11-05 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c:527:12: warning: ‘analogix_dp_start_aux_transaction’ defined but not used [-Wunused-function] Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec

[PATCH 15/19] gpu: drm: radeon: radeon_drv: Remove unused variable 'ret'

2020-11-05 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_drv.c: In function ‘radeon_pmops_runtime_suspend’: drivers/gpu/drm/radeon/radeon_drv.c:455:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: David

[PATCH 16/19] gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant kernel-doc header

2020-11-05 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_SRGB_THROUGH' not described in enum 'ili9322_input' drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_SRGB_ALIGNED' not

[PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap

2020-11-05 Thread Lee Jones
The stack is too full. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function ‘sideband_msg_req_encode_decode’: drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:161:1: warning: the frame size of 1176 bytes is larger than 1024 bytes

[PATCH 12/19] gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_write_byte_to_dpcd'

2020-11-05 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c:571:5: warning: no previous prototype for ‘analogix_dp_write_byte_to_dpcd’ [-Wmissing-prototypes] Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej

[PATCH 02/19] gpu: ipu-v3: ipu-di: Strip out 2 unused 'di_sync_config' entries

2020-11-05 Thread Lee Jones
They're taking up too much space on the stack. Fixes the following W=1 kernel build warning(s): drivers/gpu/ipu-v3/ipu-di.c: In function ‘ipu_di_sync_config_noninterlaced’: drivers/gpu/ipu-v3/ipu-di.c:391:1: warning: the frame size of 1064 bytes is larger than 1024 bytes

[PATCH 00/19] [Set 1] Rid W=1 warnings from GPU

2020-11-05 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. There are 5000 warnings to work through. It will take a couple more sets. Lee Jones (19): gpu: host1x: bus: Add missing description for

[PATCH 01/19] gpu: host1x: bus: Add missing description for 'driver'

2020-11-05 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/host1x/bus.c:40: warning: Function parameter or member 'driver' not described in 'host1x_subdev_add' Cc: Thierry Reding Cc: dri-devel@lists.freedesktop.org Cc: linux-te...@vger.kernel.org Signed-off-by: Lee Jones ---

[PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables

2020-11-05 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘_dsi_print_reset_status’: drivers/gpu/drm/omapdrm/dss/dsi.c:1131:6: warning: variable ‘l’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘dsi_update’:

[PATCH 09/19] gpu: drm: selftests: test-drm_framebuffer: Remove set but unused variable 'fb'

2020-11-05 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/selftests/test-drm_framebuffer.c: In function ‘execute_drm_mode_fb_cmd2’: drivers/gpu/drm/selftests/test-drm_framebuffer.c:333:26: warning: variable ‘fb’ set but not used [-Wunused-but-set-variable] Cc: David Airlie Cc: Daniel

[PATCH 05/19] gpu: drm: selftests: test-drm_mm: Mark 'hole_end' as always_unused

2020-11-05 Thread Lee Jones
In the macro drm_mm_for_each_hole() 'hole_end' is provided as a container for 'hole_start + pos->hole_size', but is not utilised in this use-case. We cannot simply delete the variable, so here we tell the compiler that we're intentionally discarding the read value. Fixes the following W=1 kernel

[PATCH 11/19] gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header

2020-11-05 Thread Lee Jones
Struct headers should start with 'struct ' Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/panel/panel-simple.c:42: warning: Cannot understand * @modes: Pointer to array of fixed modes appropriate for this panel. If Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie

[PATCH 10/19] gpu: drm: ttm: ttm_bo: Fix one function header - demote lots of kernel-doc abuses

2020-11-05 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_bo.c:51: warning: Function parameter or member 'ttm_global_mutex' not described in 'DEFINE_MUTEX' drivers/gpu/drm/ttm/ttm_bo.c:286: warning: Function parameter or member 'bo' not described in 'ttm_bo_cleanup_memtype_use'

[PATCH 06/19] gpu: drm: scheduler: sched_main: Provide missing description for 'sched' paramter

2020-11-05 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/scheduler/sched_main.c:74: warning: Function parameter or member 'sched' not described in 'drm_sched_rq_init' Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: dri-devel@lists.freedesktop.org Cc:

[PATCH 07/19] gpu: drm: scheduler: sched_entity: Demote non-conformant kernel-doc headers

2020-11-05 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/scheduler/sched_entity.c:316: warning: Function parameter or member 'f' not described in 'drm_sched_entity_clear_dep' drivers/gpu/drm/scheduler/sched_entity.c:316: warning: Function parameter or member 'cb' not described in

[PATCH 04/19] gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues

2020-11-05 Thread Lee Jones
The API has been updated, but the header was not. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/omapdrm/omap_irq.c:115: warning: Function parameter or member 'crtc' not described in 'omap_irq_enable_vblank' drivers/gpu/drm/omapdrm/omap_irq.c:115: warning: Excess function

[PATCH 03/19] gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused

2020-11-05 Thread Lee Jones
In the macro for_each_oldnew_crtc_in_state() 'crtc_state' is provided as a container for state->crtcs[i].new_state, but is not utilised in this use-case. We cannot simply delete the variable, so here we tell the compiler that we're intentionally discarding the read value. Fixes the following W=1

[PATCH] drm/imx/dcss: allow using nearest neighbor interpolation scaling

2020-11-05 Thread Laurentiu Palcu
This patch adds support for using NN interpolation scaling by setting the SCALING_FILTER plane property to 1. Otherwise, the default method is used. Signed-off-by: Laurentiu Palcu --- I had no retro pixel art games to test this with, so I used modetest to see the results: To test, I used a

Re: [PATCH v7] backlight: lms283gf05: Convert to GPIO descriptors

2020-11-05 Thread Linus Walleij
On Fri, Oct 30, 2020 at 9:13 AM Marek Vasut wrote: > On 10/30/20 1:20 AM, Linus Walleij wrote: > > Marek: I saw this was written by you, are you regularly > > testing the Z2 device? > > No, it has been a very long time since I last used this device. OK then I suggest the maintainers just apply

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-05 Thread Daniel Vetter
On Thu, Nov 5, 2020 at 3:31 PM Daniel Vetter wrote: > > On Thu, Nov 5, 2020 at 2:22 PM Christian König > wrote: > > > > Am 05.11.20 um 14:20 schrieb Daniel Vetter: > > > On Thu, Nov 05, 2020 at 01:56:22PM +0100, Christian König wrote: > > >> Am 05.11.20 um 13:50 schrieb Daniel Vetter: > > >>>

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-05 Thread Daniel Vetter
On Thu, Nov 5, 2020 at 2:22 PM Christian König wrote: > > Am 05.11.20 um 14:20 schrieb Daniel Vetter: > > On Thu, Nov 05, 2020 at 01:56:22PM +0100, Christian König wrote: > >> Am 05.11.20 um 13:50 schrieb Daniel Vetter: > >>> On Thu, Nov 05, 2020 at 01:29:50PM +0100, Christian König wrote: >

[PATCH 2/2] drm/imx/dcss: fix coccinelle warning

2020-11-05 Thread Laurentiu Palcu
This small patch fixes a warning that I got while running coccinelle: CHECK drivers/gpu/drm/imx/dcss/dcss-plane.c drivers/gpu/drm/imx/dcss/dcss-plane.c:107:21-23: WARNING !A || A && B is equivalent to !A || B Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")

[PATCH 0/2] drm/imx/dcss: a couple of fixes

2020-11-05 Thread Laurentiu Palcu
Hi, This patchset fixes 90/270 rotations for Vivante tiled and super-tiled formats and a Coccinelle warning. Thanks, laurentiu Laurentiu Palcu (2): drm/imx/dcss: fix rotations for Vivante tiled formats drm/imx/dcss: fix coccinelle warning drivers/gpu/drm/imx/dcss/dcss-plane.c | 14

[PATCH 1/2] drm/imx/dcss: fix rotations for Vivante tiled formats

2020-11-05 Thread Laurentiu Palcu
DCSS supports 90/180/270 degree rotations for Vivante tiled and super-tiled formats. Unfortunately, with the current code, they didn't work properly. This simple patch makes the rotations work by fixing the way the scaler is set up for 90/270 degree rotations. In this particular case, the source

Re: [PATCH v4 05/16] drm/i915/hdcp: Move HDCP enc status timeout to header

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:11:57 +0530, Anshuman Gupta wrote: > DP MST stream encryption status requires time of a link frame > in order to change its status, but as there were some HDCP > encryption timeout observed earlier, it is safer to use > ENCRYPT_STATUS_CHANGE_TIMEOUT_MS timeout for stream status

Re: [PATCH v4 04/16] drm/i915/hdcp: DP MST transcoder for link and stream

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:11:56 +0530, Anshuman Gupta wrote: > Gen12 has H/W delta with respect to HDCP{1.x,2.x} display engine > instances lies in Transcoder instead of DDI as in Gen11. > > This requires hdcp driver to use mst_master_transcoder for link > authentication and stream transcoder for

Re: [PATCH v4] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-05 Thread Boris Brezillon
On Thu, 5 Nov 2020 13:27:04 + Steven Price wrote: > > + old_status = atomic_xchg(>status, > > +PANFROST_QUEUE_STATUS_STOPPED); > > + WARN_ON(old_status != PANFROST_QUEUE_STATUS_ACTIVE && > > + old_status != PANFROST_QUEUE_STATUS_STOPPED); > > + if

Re: [PATCH v4] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-05 Thread Steven Price
On 04/11/2020 17:07, Boris Brezillon wrote: We've fixed many races in panfrost_job_timedout() but some remain. Instead of trying to fix it again, let's simplify the logic and move the reset bits to a separate work scheduled when one of the queue reports a timeout. v4: - Rework the logic to

Re: [Intel-gfx] [PATCH v4 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-11-05 Thread Ramalingam C
On 2020-11-05 at 18:51:57 +0530, Ramalingam C wrote: > On 2020-11-05 at 18:48:02 +0530, Ramalingam C wrote: > > On 2020-10-27 at 22:11:53 +0530, Anshuman Gupta wrote: > > > When crtc state need_modeset is true it is not necessary > > > it is going to be a real modeset, it can turns to be a > > >

Re: [PATCH v4 02/16] drm/i915/hdcp: Get conn while content_type changed

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:11:54 +0530, Anshuman Gupta wrote: > Get DRM connector reference count while scheduling a prop work > to avoid any possible destroy of DRM connector when it is in > DRM_CONNECTOR_REGISTERED state. > > Fixes: a6597faa2d59 ("drm/i915: Protect workers against disappearing >

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-05 Thread Christian König
Am 05.11.20 um 14:20 schrieb Daniel Vetter: On Thu, Nov 05, 2020 at 01:56:22PM +0100, Christian König wrote: Am 05.11.20 um 13:50 schrieb Daniel Vetter: On Thu, Nov 05, 2020 at 01:29:50PM +0100, Christian König wrote: Am 05.11.20 um 10:11 schrieb Daniel Vetter: On Thu, Nov 5, 2020 at 9:00 AM

Re: [Intel-gfx] [PATCH v4 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-11-05 Thread Ramalingam C
On 2020-11-05 at 18:48:02 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:11:53 +0530, Anshuman Gupta wrote: > > When crtc state need_modeset is true it is not necessary > > it is going to be a real modeset, it can turns to be a > > fastset instead of modeset. > > This turns content protection

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-05 Thread Daniel Vetter
On Thu, Nov 05, 2020 at 01:56:22PM +0100, Christian König wrote: > Am 05.11.20 um 13:50 schrieb Daniel Vetter: > > On Thu, Nov 05, 2020 at 01:29:50PM +0100, Christian König wrote: > > > Am 05.11.20 um 10:11 schrieb Daniel Vetter: > > > > On Thu, Nov 5, 2020 at 9:00 AM Christian König > > > >

Re: [PATCH v4 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:11:53 +0530, Anshuman Gupta wrote: > When crtc state need_modeset is true it is not necessary > it is going to be a real modeset, it can turns to be a > fastset instead of modeset. > This turns content protection property to be DESIRED and hdcp > update_pipe left with property

Re: [PATCH 1/4] drm/radeon: stop using pages with drm_prime_sg_to_page_addr_arrays

2020-11-05 Thread Daniel Vetter
On Thu, Nov 5, 2020 at 2:01 PM Daniel Vetter wrote: > > On Thu, Nov 5, 2020 at 1:12 PM Christian König > wrote: > > > > Am 04.11.20 um 18:38 schrieb Daniel Vetter: > > > On Wed, Nov 04, 2020 at 02:00:21PM +0100, Christian König wrote: > > >> This is deprecated. > > >> > > >> Signed-off-by:

Re: [PATCH 1/4] drm/radeon: stop using pages with drm_prime_sg_to_page_addr_arrays

2020-11-05 Thread Daniel Vetter
On Thu, Nov 5, 2020 at 1:12 PM Christian König wrote: > > Am 04.11.20 um 18:38 schrieb Daniel Vetter: > > On Wed, Nov 04, 2020 at 02:00:21PM +0100, Christian König wrote: > >> This is deprecated. > >> > >> Signed-off-by: Christian König > > So I tried to prove to myself that ttm doesn't access

Re: [PATCH 2/4] drm/amdgpu: stop using pages with drm_prime_sg_to_page_addr_arrays

2020-11-05 Thread Daniel Vetter
On Wed, Nov 04, 2020 at 02:00:22PM +0100, Christian König wrote: > This is deprecated. > > Signed-off-by: Christian König Ok you convinced me that amdgpu is safe. Maybe for completeness paste the explanation you put into the other mail into the commit message here (just the entire thing seems

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-05 Thread Christian König
Am 05.11.20 um 13:50 schrieb Daniel Vetter: On Thu, Nov 05, 2020 at 01:29:50PM +0100, Christian König wrote: Am 05.11.20 um 10:11 schrieb Daniel Vetter: On Thu, Nov 5, 2020 at 9:00 AM Christian König wrote: Am 04.11.20 um 17:50 schrieb Daniel Vetter: Random observation while trying to

Re: [PATCH v5 09/10] dma-buf-map: Add memcpy and pointer-increment interfaces

2020-11-05 Thread Daniel Vetter
On Thu, Nov 05, 2020 at 11:37:08AM +0100, Thomas Zimmermann wrote: > Hi > > Am 05.11.20 um 11:07 schrieb Linus Walleij: > > Overall I like this, just an inline question: > > > > On Tue, Oct 20, 2020 at 2:20 PM Thomas Zimmermann > > wrote: > > > >> To do framebuffer updates, one needs memcpy

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-05 Thread Daniel Vetter
On Thu, Nov 05, 2020 at 01:29:50PM +0100, Christian König wrote: > Am 05.11.20 um 10:11 schrieb Daniel Vetter: > > On Thu, Nov 5, 2020 at 9:00 AM Christian König > > wrote: > > > Am 04.11.20 um 17:50 schrieb Daniel Vetter: > > > > Random observation while trying to review Christian's patch

<    1   2   3   4   >