Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1639:
warning: Function parameter or member 'dc' not described in
'dce110_enable_accelerated_mode'
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1639:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c: In
function ‘dce110_timing_generator_tear_down_global_swap_lock’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1354:12:
warning: variable
This file uses a complex abstracted set of hierarchical macros to
setup its applicable register lists within constant structures.
However in the case of TMDS_CNTL we wish to mark it as not applicable
for this use-case.
One method would be to de-const all of the definitions and users, then
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_resource.c:426:32:
warning: no previous prototype for ‘dce120_opp_create’ [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_resource.c:440:17:
warning: no
Fixes the following W=1 kernel build warning(s):
In file included from
drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59:
drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10014:58:
warning: initialized field overwritten [-Woverride-init]
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function
‘bw_calcs_init’:
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2726:1: warning:
the frame size of 1336 bytes is larger than 1024 bytes [-Wframe-larger-than=]
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:602:13:
warning: ‘dce120_timing_generator_get_position’ defined but not used
[-Wunused-function]
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function
‘calculate_bandwidth’:
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2016:1: warning:
the frame size of 1216 bytes is larger than 1024 bytes
This file uses a complex abstracted set of hierarchical macros to
setup its applicable register lists within constant structures.
However in the case of TMDS_CNTL we wish to mark it as not applicable
for this use-case.
One method would be to de-const all of the definitions and users, then
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:101:6:
warning: no previous prototype for ‘dce120_timing_generator_validate_timing’
[-Wmissing-prototypes]
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:43:
warning: ‘struct hw_factory’ declared inside parameter list will not be
visible outside of this definition or declaration
Ideally someone should strip-out all these garbage 'if 0's.
Tempted to carry out the work myself on principle!
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_hw_sequencer.c:53:47:
warning: ‘reg_offsets’ defined but not used
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.c:50:6:
warning: no previous prototype for ‘dal_hw_factory_diag_fpga_init’
[-Wmissing-prototypes]
Cc: Harry Wentland
Cc: Leo Li
Cc: Alex Deucher
Cc: "Christian König"
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/irq_service.c:82:31: warning: no
previous prototype for ‘find_irq_source_info’ [-Wmissing-prototypes]
Cc: Harry Wentland
Cc: Leo Li
Cc: Alex Deucher
Cc: "Christian König"
Cc: David Airlie
Cc:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_translate_diag.c:37:6:
warning: no previous prototype for ‘dal_hw_translate_diag_fpga_init’
[-Wmissing-prototypes]
Cc: Harry Wentland
Cc: Leo Li
Cc: Alex Deucher
Cc: "Christian
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/hw_ddc.c: In function
‘set_config’:
drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/hw_ddc.c:110:13: warning:
variable ‘reg2’ set but not used [-Wunused-but-set-variable]
Cc: Harry Wentland
Cc: Leo
The header doesn't provide any additional parameter descriptions.
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c:1104: warning:
Cannot understand
*
Cc:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:109: warning: Function
parameter or member 'opp110' not described in 'set_truncation'
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:109: warning: Function
parameter or member
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c: In function
‘dce110_link_encoder_update_mst_stream_allocation_table’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c:1506:11:
warning: variable ‘value0’ set but
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c: In function
‘dce_aux_transfer_raw’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c:579:7: warning:
variable ‘bytes_replied’ set but not used [-Wunused-but-set-variable]
Cc: Harry
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (40):
drm/amd/display/dc/dce/dce_aux: Mark
On Mon, 11 Jan 2021, Jani Nikula wrote:
> On Thu, 07 Jan 2021, Lyude Paul wrote:
>> This reverts commit 0883ce8146ed6074c76399f4e70dbed788582e12. Originally
>> these quirks were added because of the issues with using the eDP
>> backlight interfaces on certain laptop panels, which made it
Update vkms documentation to contain usage of `modinfo`
command and steps to load vkms with module options enabled.
Signed-off-by: Sumera Priyadarsini
---
Documentation/gpu/vkms.rst | 12
1 file changed, 12 insertions(+)
diff --git a/Documentation/gpu/vkms.rst
On Thu, 07 Jan 2021, Lyude Paul wrote:
> This reverts commit 0883ce8146ed6074c76399f4e70dbed788582e12. Originally
> these quirks were added because of the issues with using the eDP
> backlight interfaces on certain laptop panels, which made it impossible
> to properly probe for DPCD backlight
On Thu, 07 Jan 2021, Lyude Paul wrote:
> Since we now support controlling panel backlights through DPCD using
> both the standard VESA interface, and Intel's proprietary HDR backlight
> interface, we should allow the user to be able to explicitly choose
> between one or the other in the event
Add enable_writeback feature to vkms_config as a module.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/vkms/vkms_drv.c| 5 +
drivers/gpu/drm/vkms/vkms_drv.h| 1 +
drivers/gpu/drm/vkms/vkms_output.c | 9 ++---
3 files changed, 12 insertions(+), 3 deletions(-)
diff --git
Currently, data for the device instance is held by vkms_device.
Add a separate type, vkms_config to contain configuration details
for the device and various modes to be later used by configfs.
This config data stays constant once the device is created.
Accordingly, add vkms_create and
On Thu, 07 Jan 2021, Lyude Paul wrote:
> So-recently a bunch of laptops on the market have started using DPCD
> backlight controls instead of the traditional DDI backlight controls.
> Originally we thought we had this handled by adding VESA backlight
> control support to i915, but the story ended
This patchset aims to lay down some prep work before configfs can be
implemented for the vkms driver. The first patch in the series adds a
new type vkms_config to track device configuration. The second and third
patch add module testing support for writeback operations.
The first patch is
On Thu, 07 Jan 2021, Lyude Paul wrote:
> Currently, every different type of backlight hook that i915 supports is
> pretty straight forward - you have a backlight, probably through PWM
> (but maybe DPCD), with a single set of platform-specific hooks that are
> used for controlling it.
>
> HDR
On 1/11/21 12:41 PM, Andrey Grodzovsky wrote:
On 1/11/21 11:15 AM, Daniel Vetter wrote:
On Mon, Jan 11, 2021 at 05:13:56PM +0100, Daniel Vetter wrote:
On Fri, Jan 08, 2021 at 04:49:55PM +, Grodzovsky, Andrey wrote:
Ok then, I guess I will proceed with the dummy pages list implementation
This release brings updated kernel headers and converts man pages to
reStructuredText.
Antonin Décimo (1):
headers: drm: Sync with drm-next
Emmanuel Vadot (1):
tests/amdgpu: Fix on FreeBSD
Luben Tuikov (1):
tests/amdgpu: Fix a typo
Lubomir Rintel (3):
Hi Geert,
On Mon, Jan 11, 2021 at 10:02 AM Geert Uytterhoeven
wrote:
>
> As nwl_dsi.lanes is u32, and NSEC_PER_SEC is 10L, the second
> multiplication in
>
> dsi->lanes * 8 * NSEC_PER_SEC
>
> will overflow on a 32-bit platform. Fix this by making the constant
> unsigned long long,
> -Original Message-
> From: Alex Deucher
> Sent: Monday, January 11, 2021 9:47 AM
> To: Xiong, Jianxin
> Cc: Jason Gunthorpe ; Leon Romanovsky ;
> linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org;
> Doug Ledford ; Vetter, Daniel ;
> Christian Koenig
> Subject: Re: [PATCH
Does this series look fine now? I would like to try resolving any remaining
issues so we
Can catch the window for kernel 5.12.
Edward, do you have more opinions on the pyverbs related changes?
Thanks,
Jianxin
> -Original Message-
> From: Xiong, Jianxin
> Sent: Wednesday, December 02,
On Mon, Jan 11, 2021 at 12:44 PM Xiong, Jianxin wrote:
>
> > -Original Message-
> > From: Jason Gunthorpe
> > Sent: Monday, January 11, 2021 7:43 AM
> > To: Xiong, Jianxin
> > Cc: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug
> > Ledford ; Leon Romanovsky
> > ;
> -Original Message-
> From: Jason Gunthorpe
> Sent: Monday, January 11, 2021 7:43 AM
> To: Xiong, Jianxin
> Cc: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford
> ; Leon Romanovsky
> ; Sumit Semwal ; Christian Koenig
> ; Vetter, Daniel
>
> Subject: Re: [PATCH
On 1/11/21 11:15 AM, Daniel Vetter wrote:
On Mon, Jan 11, 2021 at 05:13:56PM +0100, Daniel Vetter wrote:
On Fri, Jan 08, 2021 at 04:49:55PM +, Grodzovsky, Andrey wrote:
Ok then, I guess I will proceed with the dummy pages list implementation then.
Andrey
Hi Mikko,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20210111]
[cannot apply to tegra-drm/drm/tegra/for-next tegra/for-next linus/master
v5.11-rc3 v5.11-rc2 v5.11-rc1 v5.11-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note
On Fri, Jan 08, 2021 at 10:43:38AM +0100, Thomas Zimmermann wrote:
> Cursor updates in vboxvideo require a short-term mapping of the
> source BO. Use drm_gem_vram_vmap_local() and avoid the pinning
> operations.
>
> Signed-off-by: Thomas Zimmermann
All these drivers patches break the
On Mon, Jan 11, 2021 at 06:00:42PM +0100, Daniel Vetter wrote:
> On Fri, Jan 08, 2021 at 10:43:33AM +0100, Thomas Zimmermann wrote:
> > Damage handling in cirrus requires a short-term mapping of the source
> > BO. Use drm_gem_shmem_vmap_local().
> >
> > Signed-off-by: Thomas Zimmermann
>
> Hm
On Fri, Jan 08, 2021 at 10:43:33AM +0100, Thomas Zimmermann wrote:
> Damage handling in cirrus requires a short-term mapping of the source
> BO. Use drm_gem_shmem_vmap_local().
>
> Signed-off-by: Thomas Zimmermann
Hm more possible errors that we don't report to userspace ... Why don't we
On Fri, Jan 08, 2021 at 10:43:34AM +0100, Thomas Zimmermann wrote:
> Damage handling in gm12u320 requires a short-term mapping of the source
> BO. Use drm_gem_shmem_vmap_local().
>
> Signed-off-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/tiny/gm12u320.c | 14 +++---
> 1 file changed,
https://bugzilla.kernel.org/show_bug.cgi?id=211033
--- Comment #13 from Andreas (icedragon...@web.de) ---
Wrong channel above, but the trigger was the same - simply 1) switch monitor
off, 2) wakeup the system from standby/suspend and then 3) switch the monitor
on -> (blank screen - no signal).
On Mon, Jan 11, 2021 at 05:53:41PM +0100, Daniel Vetter wrote:
> On Fri, Jan 08, 2021 at 10:43:32AM +0100, Thomas Zimmermann wrote:
> > Damage handling in mgag200 requires a short-term mapping of the source
> > BO. Use drm_gem_shmem_vmap_local().
> >
> > Signed-off-by: Thomas Zimmermann
>
>
https://bugzilla.kernel.org/show_bug.cgi?id=211033
--- Comment #12 from Andreas (icedragon...@web.de) ---
Sorry wrong BUG channel. How can I remove my last comment above?
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the
On Fri, Jan 08, 2021 at 10:43:32AM +0100, Thomas Zimmermann wrote:
> Damage handling in mgag200 requires a short-term mapping of the source
> BO. Use drm_gem_shmem_vmap_local().
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/mgag200/mgag200_mode.c |
On Fri, Jan 08, 2021 at 10:43:40AM +0100, Thomas Zimmermann wrote:
> VRAM-helper BO's cannot be exported, so calls for vmap and vunmap
> can only come from the BO's drivers or a kernel client. These are
> supposed use vmap_local functionality.
^to
>
> The vmap and vunmap operations in
https://bugzilla.kernel.org/show_bug.cgi?id=211033
Andreas (icedragon...@web.de) changed:
What|Removed |Added
CC||icedragon...@web.de
---
On Fri, Jan 08, 2021 at 10:43:31AM +0100, Thomas Zimmermann wrote:
> Implementations of the vmap/vunmap GEM callbacks may perform pinning
> of the BO and may acquire the associated reservation object's lock.
> Callers that only require a mapping of the contained memory can thus
> interfere with
On Fri, Jan 08, 2021 at 11:45:30PM +0530, Akhil P Oommen wrote:
> Some GPUs support different max frequencies depending on the platform.
> To identify the correct variant, we should check the gpu speedbin
> fuse value. Add support for this speedbin detection to a6xx family
> along with the
check_unmap() is producing a warning about a missing map error check.
The return value from dma_map_page() should be checked for an error, not
the caller-provided dma_addr.
Fixes: d099fc8f540a ("drm/ttm: new TT backend allocation pool v3")
Signed-off-by: Jeremy Cline
---
On Mon, Jan 11, 2021 at 4:02 PM Alex Deucher wrote:
>
> On Sat, Jan 9, 2021 at 9:11 PM Bas Nieuwenhuizen
> wrote:
> >
> > With modifiers one can actually have different format_info structs
> > for the same format, which now matters for AMDGPU since we convert
> > implicit modifiers to explicit
On Mon, Jan 11, 2021 at 09:53:56AM +0100, Christian König wrote:
> Am 08.01.21 um 22:58 schrieb Jeremy Cline:
> > dcn20_resource_construct() includes a number of kzalloc(GFP_KERNEL)
> > calls which can sleep, but kernel_fpu_begin() disables preemption and
> > sleeping in this context is invalid.
>
On Fri, Jan 08, 2021 at 12:56:24PM -0500, Felix Kuehling wrote:
>
> Am 2021-01-08 um 11:53 a.m. schrieb Daniel Vetter:
> > On Fri, Jan 8, 2021 at 5:36 PM Felix Kuehling
> > wrote:
> >>
> >> Am 2021-01-08 um 11:06 a.m. schrieb Daniel Vetter:
> >>> On Fri, Jan 8, 2021 at 4:58 PM Felix Kuehling
On Mon, Jan 11, 2021 at 6:46 AM Colin King wrote:
>
> From: Colin Ian King
>
> A recent change added a new BOOTUP_DEFAULT power profile mode
> to the PP_SMC_POWER_PROFILE enum but omitted updating the
> corresponding profile_name array. Fix this by adding in the
> missing BOOTUP_DEFAULT to
On Sun, 10 Jan 2021, Linus Walleij wrote:
> This converts the lms283gf05 backlight driver to use GPIO
> descriptors and switches the single PXA Palm Z2 device
> over to defining these.
>
> Since the platform data was only used to convey GPIO
> information we can delete the platform data header.
Hi,
On Sat, Jan 9, 2021 at 5:10 AM Heiko Stuebner wrote:
>
> From: Heiko Stuebner
>
> The Innolux n116bge panel has an eDP connector and 3*6 bits bus format.
>
> Signed-off-by: Heiko Stuebner
> ---
> drivers/gpu/drm/panel/panel-simple.c | 2 ++
> 1 file changed, 2 insertions(+)
This looks
On Mon, Jan 11, 2021 at 11:16:13AM +0100, Christian König wrote:
> Am 08.01.21 um 16:53 schrieb Daniel Vetter:
> > On Fri, Jan 8, 2021 at 3:36 PM Christian König
> > wrote:
> > > Am 08.01.21 um 15:31 schrieb Daniel Vetter:
> > > > On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
On Mon, Jan 11, 2021 at 05:13:56PM +0100, Daniel Vetter wrote:
> On Fri, Jan 08, 2021 at 04:49:55PM +, Grodzovsky, Andrey wrote:
> > Ok then, I guess I will proceed with the dummy pages list implementation
> > then.
> >
> > Andrey
> >
> >
> > From: Koenig,
On Fri, Jan 08, 2021 at 04:49:55PM +, Grodzovsky, Andrey wrote:
> Ok then, I guess I will proceed with the dummy pages list implementation then.
>
> Andrey
>
>
> From: Koenig, Christian
> Sent: 08 January 2021 09:52
> To: Grodzovsky, Andrey ; Daniel Vetter
On Mon, Jan 11, 2021 at 09:54:12AM +0530, Sai Prakash Ranjan wrote:
> Hi Rob,
>
> On 2021-01-08 22:16, Rob Clark wrote:
> >On Fri, Jan 8, 2021 at 6:05 AM Sai Prakash Ranjan
> > wrote:
> >>
> >>On 2021-01-08 19:09, Konrad Dybcio wrote:
> Konrad, can you please test this below change without
k_irq_count
> 379: warning: Function parameter or member 'active_vblank_irq_count' not
> described in 'amdgpu_display_manager'
>
> Tweak the kerneldoc for active_vblank_irq_count.
>
> Signed-off-by: Lukas Bulwahn
> ---
> applies on amdgpu's -next and next-20210111
>
t and next-20210111
Bhawanpreet, Nick, please review and ack.
Alex, Christian, please pick on top of the commit above.
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
b/drivers/g
On Tue, Dec 15, 2020 at 9:44 PM Laurent Pinchart
wrote:
>
> The AMD DRM drivers uAPI headers are licensed under the MIT license,
> and carry copies of the license with slight variations. Replace them
> with SPDX headers.
>
> Signed-off-by: Laurent Pinchart
Acked-by: Alex Deucher
> ---
>
Hi,
On Mon, Jan 11, 2021 at 09:53:56AM +0100, Christian König wrote:
> Am 08.01.21 um 22:58 schrieb Jeremy Cline:
> > dcn20_resource_construct() includes a number of kzalloc(GFP_KERNEL)
> > calls which can sleep, but kernel_fpu_begin() disables preemption and
> > sleeping in this context is
Hi Dan,
On Mon, Jan 11, 2021 at 05:18:08PM +0300, Dan Carpenter wrote:
> This error path should return a negative error code instead of success.
>
> Fixes: c92724de6db1 ("drm/i915/selftests: Try to detect rollback during
> batchbuffer preemption")
> Signed-off-by: Dan Carpenter
> Reviewed-by:
Jason, will this series be able to get into 5.12?
> -Original Message-
> From: Xiong, Jianxin
> Sent: Tuesday, December 15, 2020 1:27 PM
> To: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org
> Cc: Xiong, Jianxin ; Doug Ledford
> ; Jason Gunthorpe ; Leon Romanovsky
> ; Sumit
On Sat, Jan 9, 2021 at 9:11 PM Bas Nieuwenhuizen
wrote:
>
> With modifiers one can actually have different format_info structs
> for the same format, which now matters for AMDGPU since we convert
> implicit modifiers to explicit modifiers with multiple planes.
>
> I checked other drivers and it
This error path should return a negative error code instead of success.
Fixes: c92724de6db1 ("drm/i915/selftests: Try to detect rollback during
batchbuffer preemption")
Signed-off-by: Dan Carpenter
Reviewed-by: Chris Wilson
---
v2: The first version of the patch fixed some other error paths
Am 11.01.21 um 10:03 schrieb Christian König:
Hi Mikhail
Am 10.01.21 um 23:26 schrieb Mikhail Gavrilov:
Hi folks,
today I joined to testing Kernel 5.11 and saw that the kernel log was
flooded with BUG messages:
BUG: sleeping function called from invalid context at mm/vmalloc.c:1756
set_pages_wb() might sleep and so we can't do this in an atomic context.
Signed-off-by: Christian König
Reported-by: Mikhail Gavrilov
Fixes: d099fc8f540a ("drm/ttm: new TT backend allocation pool v3")
---
drivers/gpu/drm/ttm/ttm_pool.c | 20 ++--
1 file changed, 10
Hi,
On 10/01/2021 13:51, Simon Ser wrote:
> The comment says the layout and options use 8 bits, and the shift
> uses 8 bits. However the mask is 0xf, ie. 0b (4 bits).
>
> This could be surprising when introducing new layouts or options
> that take more than 4 bits, as this would silently
As nwl_dsi.lanes is u32, and NSEC_PER_SEC is 10L, the second
multiplication in
dsi->lanes * 8 * NSEC_PER_SEC
will overflow on a 32-bit platform. Fix this by making the constant
unsigned long long, forcing 64-bit arithmetic.
While iMX8 is arm64, this driver is currently used on
Add reference counting for allocated syncpoints to allow keeping
them allocated while jobs are referencing them. Additionally,
clean up various places using syncpoint IDs to use host1x_syncpt
pointers instead.
Signed-off-by: Mikko Perttunen
---
v5:
- Remove host1x_syncpt_put in submit code, as
Add the userspace interface header, specifying interfaces
for allocating and accessing syncpoints from userspace,
and for creating sync_file based fences based on syncpoint
thresholds.
Signed-off-by: Mikko Perttunen
---
include/uapi/linux/host1x.h | 134
1
With job recovery becoming optional, syncpoints may have a mismatch
between their value and max value when freed. As such, when freeing,
set the max value to the current value of the syncpoint so that it
is in a sane state for the next user.
Signed-off-by: Mikko Perttunen
---
v3:
* Use
Add support for inserting syncpoint waits in the CDMA pushbuffer.
These waits need to be done in HOST1X class, while gather submitted
by the application execute in engine class.
Support is added by converting the gather list of job into a command
list that can include both gathers and waits. When
To allow sharing of implicit fences when exporting/importing dma_buf
objects, set the 'resv' fields when importing or exporting GEM
objects.
Signed-off-by: Mikko Perttunen
---
drivers/gpu/drm/tegra/gem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/tegra/gem.c
Add a firewall that validates jobs before submission to ensure
they don't do anything they aren't allowed to do, like accessing
memory they should not access.
The firewall is functionality-wise a copy of the firewall already
implemented in gpu/host1x. It is copied here as it makes more
sense for
To avoid duplication, allocate the per-engine shared channel in the
core code instead. Once MLOCKs are implemented on Host1x side, we
can also update this to avoid allocating a shared channel when
MLOCKs are enabled.
Signed-off-by: Mikko Perttunen
---
drivers/gpu/drm/tegra/drm.c | 11
Show the number of pending waiters in the debugfs status file.
This is useful for testing to verify that waiters do not leak
or accumulate incorrectly.
Signed-off-by: Mikko Perttunen
---
drivers/gpu/host1x/debug.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git
To avoid false lockdep warnings, give each client lock a different
lock class, passed from the initialization site by macro.
Signed-off-by: Mikko Perttunen
---
drivers/gpu/host1x/bus.c | 7 ---
include/linux/host1x.h | 9 -
2 files changed, 12 insertions(+), 4 deletions(-)
diff
Add the /dev/host1x device node, implementing the following
functionality:
- Reading syncpoint values
- Allocating syncpoints (providing syncpoint FDs)
- Incrementing syncpoints (based on syncpoint FD)
Signed-off-by: Mikko Perttunen
---
v4:
* Put UAPI under CONFIG_DRM_TEGRA_STAGING
v3:
* Pass
With the new UAPI implementation, engines are powered on and off
when there are active jobs, and the core code handles channel
allocation. To accommodate that, boot the engine as part of
runtime PM instead of using the open_channel callback, which is
not used by the new submit path.
Implement the job submission IOCTL with a minimum feature set.
Signed-off-by: Mikko Perttunen
---
v5:
* Add 16K size limit to copies from userspace.
* Guard RELOC_BLOCKLINEAR flag handling to only exist in ARM64
to prevent oversized shift on 32-bit platforms.
v4:
* Remove all features that are
Update the tegra_drm.h UAPI header, adding the new proposed UAPI.
The old staging UAPI is left in for now, with minor modification
to avoid name collisions.
Signed-off-by: Mikko Perttunen
---
v4:
* Remove features that are not strictly necessary
* Remove padding/reserved fields in IOCTL structs
On T20-T148 chips, the bootloader can set up a boot splash
screen with DC configured to increment syncpoint 26/27
at VBLANK. Because of this we shouldn't allow these syncpoints
to be allocated until DC has been reset and will no longer
increment them in the background.
As such, on these chips,
Hi all,
here's the fifth revision of the Host1x/TegraDRM UAPI proposal,
containing primarily small bug fixes. It has also been
rebased on top of recent linux-next.
vaapi-tegra-driver has been updated to support the new UAPI
as well as Tegra186:
https://github.com/cyndis/vaapi-tegra-driver
Add an implementation of dma_fences based on syncpoints. Syncpoint
interrupts are used to signal fences. Additionally, after
software signaling has been enabled, a 30 second timeout is started.
If the syncpoint threshold is not reached within this period,
the fence is signalled with an -ETIMEDOUT
Implement the non-submission parts of the new UAPI, including
channel management and memory mapping. The UAPI is under the
CONFIG_DRM_TEGRA_STAGING config flag for now.
Signed-off-by: Mikko Perttunen
---
v5:
* Set iova_end in both mapping paths
v4:
* New patch, split out from combined UAPI +
Add a callback field to the job structure, to be called just before
the job is to be freed. This allows the job's submitter to clean
up any of its own state, like decrement runtime PM refcounts.
Signed-off-by: Mikko Perttunen
---
drivers/gpu/host1x/job.c | 3 +++
include/linux/host1x.h | 4
Syncpoints don't need to be associated with any client,
so remove the property, and expose host1x_syncpt_alloc.
This will allow allocating syncpoints without prior knowledge
of the engine that it will be used with.
Signed-off-by: Mikko Perttunen
---
v3:
* Clean up host1x_syncpt_alloc signature
Add a new property for jobs to enable or disable recovery i.e.
CPU increments of syncpoints to max value on job timeout. This
allows for a more solid model for hanged jobs, where userspace
doesn't need to guess if a syncpoint increment happened because
the job completed, or because job timeout was
Before this patch, cancelled waiters would only be cleaned up
once their threshold value was reached. Make host1x_intr_put_ref
process the cancellation immediately to fix this.
Signed-off-by: Mikko Perttunen
---
v5:
* Add parameter to flush, i.e. wait for all pending waiters to
complete before
Make syncpoint expiration checks always use the same logic used by
the hardware. This ensures that there are no race conditions that
could occur because of the hardware triggering a syncpoint interrupt
and then the driver disagreeing.
One situation where this could occur is if a job incremented a
From: Colin Ian King
A recent change added a new BOOTUP_DEFAULT power profile mode
to the PP_SMC_POWER_PROFILE enum but omitted updating the
corresponding profile_name array. Fix this by adding in the
missing BOOTUP_DEFAULT to profile_name[].
Addresses-Coverity: ("Out-of-bounds read")
Fixes:
Am 08.01.21 um 16:53 schrieb Daniel Vetter:
On Fri, Jan 8, 2021 at 3:36 PM Christian König wrote:
Am 08.01.21 um 15:31 schrieb Daniel Vetter:
On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
Am 07.01.21 um 19:07 schrieb Daniel Vetter:
On Tue, Jan 05, 2021 at 07:23:08PM
Am 08.01.21 um 19:49 schrieb Mike Lothian:
Hi
This breaks things for me on my Prime system
https://gitlab.freedesktop.org/drm/misc/-/issues/23
This is most likely not correct.
The patch just fixes another bug which would break prime before it hits
the issue in the i915 driver.
Christian.
On Sun, Jan 10, 2021 at 07:35:41PM +0530, Sumera Priyadarsini wrote:
> Update vkms documentation to contain usage of `modinfo`
> command and steps to load vkms with module options enabled.
>
> Signed-off-by: Sumera Priyadarsini
> ---
> Documentation/gpu/vkms.rst | 10 ++
> 1 file
101 - 200 of 250 matches
Mail list logo