Re: [BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot

2021-01-14 Thread Jani Nikula
On Thu, 14 Jan 2021, Steven Rostedt wrote: > [ Forgot to add those on the commit itself ] > > -- Steve > > > On Thu, 14 Jan 2021 16:32:06 -0500 > Steven Rostedt wrote: > >> On reboot, one of my test boxes now triggers the following warning: >> >> [ cut here ] >> RPM

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 22:13 schrieb Felix Kuehling: Am 2021-01-14 um 11:51 a.m. schrieb Jerome Glisse: On Thu, Jan 14, 2021 at 02:37:36PM +0100, Christian König wrote: Am 14.01.21 um 12:52 schrieb Daniel Vetter: [SNIP] I had a new idea, i wanted to think more about it but have not yet, anyway here

Re: [pull] amdgpu drm-next-5.12

2021-01-14 Thread Dave Airlie
On Fri, 15 Jan 2021 at 07:22, Alex Deucher wrote: > > Hi Dave, Daniel, > > More new stuff for 5.12. > > The following changes since commit 044a48f420b9d3c19a135b821c34de5b2bee4075: > > drm/amdgpu: fix DRM_INFO flood if display core is not supported (bug > 210921) (2021-01-08 15:18:57 -0500) >

Re: [PATCH 2/2] drm/amdgpu/display: buffer INTERRUPT_LOW_IRQ_CONTEXT interrupt work

2021-01-14 Thread Chen, Xiaogang
On 1/14/2021 1:24 AM, Grodzovsky, Andrey wrote: > > > On 1/14/21 12:11 AM, Chen, Xiaogang wrote: >> On 1/12/2021 10:54 PM, Grodzovsky, Andrey wrote: >>> >>> On 1/4/21 1:01 AM, Xiaogang.Chen wrote: From: Xiaogang Chen amdgpu DM handles INTERRUPT_LOW_IRQ_CONTEXT interrupt(hpd,

[git pull] drm nouveau ampere modesetting support

2021-01-14 Thread Dave Airlie
Hi Linus, As mentioned in the previous pull, Ben has requested if we can include Ampere modesetting support under fixes, it's for new GPUs and shouldn't affect existing hardware. It's a bit bigger than just adding a PCI ID, and I'm fine if you think we should hold it off until later. Dave.

Re: [Intel-gfx] [BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot

2021-01-14 Thread Linus Torvalds
On Thu, Jan 14, 2021 at 2:01 PM Steven Rostedt wrote: > > Thanks, I take it, it will be going into mainline soon. Just got merged - it might be a good idea to verify that your problem is solved. Linus ___ dri-devel mailing list

Re: [git pull] drm fixes for 5.11-rc4

2021-01-14 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Jan 2021 14:01:12 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2021-01-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/5ee88057889bbca5f5bb96031b62b3756b33e164 Thank you! -- Deet-doot-dot, I am a bot.

[git pull] drm fixes for 5.11-rc4

2021-01-14 Thread Dave Airlie
Hey Linus, Back to mostly regular scheduling for me. Big thanks to Daniel for stepping into my duties for the last few turns. Regular fixes for rc4, a bunch of fixes across i915, amdgpu and nouveau here, along with a couple of TTM fixes, and dma-buf and one core pageflip/modifier interaction

linux-next: build warnings after merge of the drm-misc tree

2021-01-14 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/gpu/drm/amd/amdgpu/amdgpu_display.c: In function 'amdgpu_display_user_framebuffer_create': drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:929:24: warning: unused variable 'adev'

[PATCH] drm/panel-simple: Undo enable if HPD never asserts

2021-01-14 Thread Douglas Anderson
If the HPD signal never asserts in panel_simple_prepare() and we return an error, we should unset the enable GPIO and disable the regulator to make it consistent for the caller. At the moment I have some hardware where HPD sometimes doesn't assert. Obviously that needs to be debugged, but this

[PULL] nouveau: ampere modesetting

2021-01-14 Thread Ben Skeggs
Hey Dave, This series of patches to add modesetting support for Ampere has been pulled out of a larger, more invasive series. As there's currently no firmware available for us to use, the rest of it isn't important right now, and it'd be nice to have something non-invasive to provide what

[PULL] nouveau-fixes 5.11

2021-01-14 Thread Ben Skeggs
Hey Dave, As requested, here's a tree with the non-Ampere-specific fixes split out, as most of them are potentially relevant to already-supported GPUs. I'll send another pull request with bare-bones GA102/GA104 support shortly. Ben. The following changes since commit

Re: [PATCH v9, 05/11] drm/mediatek: add fifo_size into rdma private data

2021-01-14 Thread Chun-Kuang Hu
Hi, Yongqiang: Chun-Kuang Hu 於 2021年1月7日 週四 下午6:05寫道: > > Hi, Yongqiang: > > Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道: > > > > Get the fifo size from device tree > > because each rdma in the same SoC may have different fifo size > > Reviewed-by: Chun-Kuang Hu Applied to mediatek-drm-next [1],

Re: [PATCH v3, 11/15] drm/mediatek: fix aal size config

2021-01-14 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道: > > the orginal setting is not correct, fix it follow hardware data sheet. > if keep this error setting, mt8173/mt8183 display ok > but mt8192 display abnormal. > Applied to mediatek-drm-next [1], thanks. [1]

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-14 Thread Mikhail Gavrilov
On Thu, 14 Jan 2021 at 18:56, Christian König wrote: > Unfortunately not of hand. > > I also don't see any bug reports from other people and can't reproduce > the last backtrace you send out TTM here. Because only the most desperate will install kernels with enabled debug flags and then load the

Re: [PATCH v3, 01/15] dt-bindings: mediatek: add description for postmask

2021-01-14 Thread Chun-Kuang Hu
Rob Herring 於 2021年1月15日 週五 上午3:11寫道: > > On Mon, 11 Jan 2021 15:43:37 +0800, Yongqiang Niu wrote: > > add description for postmask > > postmask is used control round corner for display frame > > > > Signed-off-by: Yongqiang Niu > > --- > >

Re: [PATCH v3 7/7] drm/msm/a5xx: Disable UCHE global filter

2021-01-14 Thread Jordan Crouse
On Wed, Jan 13, 2021 at 07:33:39PM +0100, AngeloGioacchino Del Regno wrote: > From: Konrad Dybcio > > Port over the command from downstream to prevent undefined > behaviour. Reviewed-by: Jordan Crouse > Signed-off-by: Konrad Dybcio > Signed-off-by: AngeloGioacchino Del Regno > > --- >

Re: [PATCH v3 6/7] drm/msm/a5xx: Disable flat shading optimization

2021-01-14 Thread Jordan Crouse
On Wed, Jan 13, 2021 at 07:33:38PM +0100, AngeloGioacchino Del Regno wrote: > From: Konrad Dybcio > > Port over the command from downstream to prevent undefined > behaviour. Reviewed-by: Jordan Crouse > Signed-off-by: Konrad Dybcio > Signed-off-by: AngeloGioacchino Del Regno > > --- >

Re: [PATCH v3 5/7] drm/msm/a5xx: Fix VPC protect value in gpu_write()

2021-01-14 Thread Jordan Crouse
On Wed, Jan 13, 2021 at 07:33:37PM +0100, AngeloGioacchino Del Regno wrote: > From: Konrad Dybcio > > The upstream API for some reason uses logbase2 instead of > just passing the argument as-is, whereas downstream CAF > kernel does the latter. > > Hence, a mistake has been made when porting: >

[PATCH v7 5/5] drm/dp: Revert "drm/dp: Introduce EDID-based quirks"

2021-01-14 Thread Lyude Paul
This reverts commit 0883ce8146ed6074c76399f4e70dbed788582e12. Originally these quirks were added because of the issues with using the eDP backlight interfaces on certain laptop panels, which made it impossible to properly probe for DPCD backlight support without having a whitelist for panels that

[PATCH v7 4/5] drm/i915/dp: Allow forcing specific interfaces through enable_dpcd_backlight

2021-01-14 Thread Lyude Paul
Since we now support controlling panel backlights through DPCD using both the standard VESA interface, and Intel's proprietary HDR backlight interface, we should allow the user to be able to explicitly choose between one or the other in the event that we're wrong about panels reliably reporting

[PATCH v7 3/5] drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)

2021-01-14 Thread Lyude Paul
So-recently a bunch of laptops on the market have started using DPCD backlight controls instead of the traditional DDI backlight controls. Originally we thought we had this handled by adding VESA backlight control support to i915, but the story ended up being a lot more complicated then that.

[PATCH v7 2/5] drm/i915: Keep track of pwm-related backlight hooks separately

2021-01-14 Thread Lyude Paul
Currently, every different type of backlight hook that i915 supports is pretty straight forward - you have a backlight, probably through PWM (but maybe DPCD), with a single set of platform-specific hooks that are used for controlling it. HDR backlights, in particular VESA and Intel's HDR

[PATCH v7 1/5] drm/i915: Pass port to intel_panel_bl_funcs.get()

2021-01-14 Thread Lyude Paul
In the next commit where we split PWM related backlight functions from higher-level backlight functions, we'll want to be able to retrieve the backlight level for the current display panel from the intel_panel_bl_funcs->setup() function using pwm_funcs->get(). Since intel_panel_bl_funcs->setup()

[PATCH v7 0/5] drm/i915: Add support for Intel's eDP backlight controls

2021-01-14 Thread Lyude Paul
A while ago we ran into issues while trying to enable the eDP backlight control interface as defined by VESA, in order to make the DPCD backlight controls on newer laptop panels work. The issue ended up being much more complicated however, as we also apparently needed to add support for an

Re: [Intel-gfx] [BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot

2021-01-14 Thread Steven Rostedt
On Thu, 14 Jan 2021 21:35:53 + Chris Wilson wrote: > Quoting Steven Rostedt (2021-01-14 21:32:06) > > On reboot, one of my test boxes now triggers the following warning: > > 057fe3535eb3 ("drm/i915: Disable RPM wakeref assertions during driver > shutdown") > is included with the

Re: [Intel-gfx] [BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot

2021-01-14 Thread Chris Wilson
Quoting Steven Rostedt (2021-01-14 21:32:06) > On reboot, one of my test boxes now triggers the following warning: 057fe3535eb3 ("drm/i915: Disable RPM wakeref assertions during driver shutdown") is included with the drm-intel-fixes PR. -Chris ___

Re: [BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot

2021-01-14 Thread Steven Rostedt
[ Forgot to add those on the commit itself ] -- Steve On Thu, 14 Jan 2021 16:32:06 -0500 Steven Rostedt wrote: > On reboot, one of my test boxes now triggers the following warning: > > [ cut here ] > RPM raw-wakeref not held > WARNING: CPU: 4 PID: 1 at

[BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot

2021-01-14 Thread Steven Rostedt
On reboot, one of my test boxes now triggers the following warning: [ cut here ] RPM raw-wakeref not held WARNING: CPU: 4 PID: 1 at drivers/gpu/drm/i915/intel_runtime_pm.h:106 gen6_write32+0x1bc/0x2a0 [i915] Modules linked in: ebtable_filter ebtables bridge stp llc

[pull] amdgpu drm-next-5.12

2021-01-14 Thread Alex Deucher
Hi Dave, Daniel, More new stuff for 5.12. The following changes since commit 044a48f420b9d3c19a135b821c34de5b2bee4075: drm/amdgpu: fix DRM_INFO flood if display core is not supported (bug 210921) (2021-01-08 15:18:57 -0500) are available in the Git repository at:

[PATCH rdma-core v5 3/6] mlx5: Support dma-buf based memory region

2021-01-14 Thread Jianxin Xiong
Implement the new provider method for registering dma-buf based memory regions. Signed-off-by: Jianxin Xiong --- providers/mlx5/mlx5.c | 2 ++ providers/mlx5/mlx5.h | 3 +++ providers/mlx5/verbs.c | 22 ++ 3 files changed, 27 insertions(+) diff --git

[PATCH rdma-core v5 0/6] Add user space dma-buf support

2021-01-14 Thread Jianxin Xiong
This is the fifth version of the patch series. Change log: v5: * Use a different mr_type for dmabuf so that ibv_dofork_range() is not called inside ibv_dereg_mr() for dmabuf based mr v4: https://www.spinics.net/lists/linux-rdma/msg98135.html * Rework the cmake funciton rdma_cython_module to

[PATCH rdma-core v5 6/6] tests: Bug fix for get_access_flags()

2021-01-14 Thread Jianxin Xiong
The filter definition is wrong and causes get_access_flags() always returning empty list. As the result the MR tests using this function are effectively skipped (but report success). Signed-off-by: Jianxin Xiong --- tests/utils.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH rdma-core v5 4/6] pyverbs: Add dma-buf based MR support

2021-01-14 Thread Jianxin Xiong
Define a new sub-class of 'MR' that uses dma-buf object for the memory region. Define a new class 'DmaBuf' as a wrapper for dma-buf allocation mechanism implemented in C. Update the cmake function for cython modules to allow building modules with mixed cython and c source files. Signed-off-by:

[PATCH rdma-core v5 2/6] verbs: Support dma-buf based memory region

2021-01-14 Thread Jianxin Xiong
Add new API function and new provider method for registering dma-buf based memory region. Update the man page and bump the API version. Signed-off-by: Jianxin Xiong --- debian/libibverbs1.symbols | 2 ++ libibverbs/CMakeLists.txt| 2 +- libibverbs/cmd_mr.c | 38

[PATCH rdma-core v5 5/6] tests: Add tests for dma-buf based memory regions

2021-01-14 Thread Jianxin Xiong
Define a set of unit tests similar to regular MR tests and a set of tests for send/recv and rdma traffic using dma-buf MRs. Add a utility function to generate access flags for dma-buf based MRs because the set of supported flags is smaller. Signed-off-by: Jianxin Xiong --- tests/args_parser.py

[PATCH rdma-core v5 1/6] Update kernel headers

2021-01-14 Thread Jianxin Xiong
To commit 2eef437c4669 ("RDMA/uverbs: Add uverbs command for dma-buf based MR registration"). Signed-off-by: Jianxin Xiong --- kernel-headers/rdma/ib_user_ioctl_cmds.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/kernel-headers/rdma/ib_user_ioctl_cmds.h

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Felix Kuehling
Am 2021-01-14 um 11:51 a.m. schrieb Jerome Glisse: > On Thu, Jan 14, 2021 at 02:37:36PM +0100, Christian König wrote: >> Am 14.01.21 um 12:52 schrieb Daniel Vetter: >>> [SNIP] > I had a new idea, i wanted to think more about it but have not yet, > anyway here it is. Adding a new callback

Re: [PATCH v4 1/2] dt-bindings: Add DT schema for Arm Mali Valhall GPU

2021-01-14 Thread Rob Herring
On Tue, Jan 12, 2021 at 02:49:32PM +0800, Nick Fan wrote: > Add devicetree schema for Arm Mali Valhall GPU > > Define a compatible string for the Mali Valhall GPU > for Mediatek's SoC platform. > > Signed-off-by: Nick Fan > --- > .../bindings/gpu/arm,mali-valhall.yaml| 252

[pull] amdgpu, amdkfd drm-fixes-5.11

2021-01-14 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.11. The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837: Linux 5.11-rc3 (2021-01-10 14:34:50 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.11-2021-01-14 for you to

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 08:08:06PM +0100, Christian König wrote: > Am 14.01.21 um 17:36 schrieb Daniel Vetter: > > On Thu, Jan 14, 2021 at 5:01 PM Christian König > > wrote: > > > Am 14.01.21 um 16:40 schrieb Daniel Vetter: > > > > [SNIP] > > > > > So I think we have to somehow solve this in the

[Bug 211189] vgaarb overrides boot device unexpectedly with Intel and discrete AMDGPU

2021-01-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211189 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [Bug 211189] New: vgaarb overrides boot device unexpectedly with Intel and discrete AMDGPU

2021-01-14 Thread Bjorn Helgaas
[cc'd efifb and vgaarb maintainers on bugzilla, but not sure whether people pay attention to that] On Thu, Jan 14, 2021 at 10:42:53AM +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=211189 > > Bug ID: 211189 >Summary:

[Bug 211189] vgaarb overrides boot device unexpectedly with Intel and discrete AMDGPU

2021-01-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211189 Bjorn Helgaas (bj...@helgaas.com) changed: What|Removed |Added CC||airl...@linux.ie,

Re: [PATCH v3, 01/15] dt-bindings: mediatek: add description for postmask

2021-01-14 Thread Rob Herring
On Mon, 11 Jan 2021 15:43:37 +0800, Yongqiang Niu wrote: > add description for postmask > postmask is used control round corner for display frame > > Signed-off-by: Yongqiang Niu > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 1 + > 1 file changed, 1 insertion(+)

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 17:36 schrieb Daniel Vetter: On Thu, Jan 14, 2021 at 5:01 PM Christian König wrote: Am 14.01.21 um 16:40 schrieb Daniel Vetter: [SNIP] So I think we have to somehow solve this in the kernel or we will go in circles all the time. So from that pov I think the kernel should at

Re: [PATCH v6 1/4] drm/i915: Keep track of pwm-related backlight hooks separately

2021-01-14 Thread Lyude Paul
On Thu, 2021-01-14 at 09:12 +0200, Jani Nikula wrote: > On Wed, 13 Jan 2021, Lyude Paul wrote: > > Currently, every different type of backlight hook that i915 supports is > > pretty straight forward - you have a backlight, probably through PWM > > (but maybe DPCD), with a single set of

Re: [PATCH] drm/amd/display: Simplify bool comparison

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 8:51 AM Yang Li wrote: > > Fix the following coccicheck warning: > ./drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20.c:3141:30-39: > WARNING: Comparison to bool > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Applied all 4 patches. Thanks! Alex >

Re: [PATCH] drm/amdgpu: Repeat assignment to max_slave_planes

2021-01-14 Thread Alex Deucher
On Thu, Jan 14, 2021 at 4:29 AM ZhiJie.Zhang wrote: > > Signed-off-by: ZhiJie.Zhang Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c >

Re: [PATCH 06/10] drm: amd: amdgpu_dm.h: fix a wrong kernel-doc markup

2021-01-14 Thread Alex Deucher
On Thu, Jan 14, 2021 at 2:53 AM Mauro Carvalho Chehab wrote: > > There's a missing colon, causing the markup to be ignored, > solving those warnings: > > ../drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:340: warning: > Incorrect use of kernel-doc format: *

Re: [PATCH 22/30] drm/amd/display/dc/core/dc_link: Fix a couple of function documentation issues

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:214: warning: > Function parameter or member 'link' not described in 'dc_link_detect_sink' >

Re: [PATCH 21/30] drm/amd/display/dc/core/dc_resource: Demote some kernel-doc abuses

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1710: warning: > Function parameter or member 'old_stream' not described in > 'dc_is_stream_unchanged' >

Re: [PATCH 20/30] drm/amd/display/dc/core/dc: Fix a bunch of documentation misdemeanours

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:287: warning: Cannot > understand > * >

Re: [PATCH 19/30] drm/amd/display/dc/core/dc_link_dp: Mark 'result_write_min_hblank' as __maybe_unused

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > It looks like it could be used inside the DC_TRACE_LEVEL_MESSAGE() macro. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c: In function > ‘dpcd_set_source_specific_data’: >

Re: [PATCH 2/2] drm/cma-helper: Implement mmap as GEM CMA object functions

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 02:26:41PM +0100, Thomas Zimmermann wrote: > From d0583fe22cd0cd29749ff679e46e13b58de325cb Mon Sep 17 00:00:00 2001 > From: Thomas Zimmermann > Date: Thu, 14 Jan 2021 14:21:51 +0100 > Subject: [PATCH] drm/cma: Set vma ops in mmap function > > Signed-off-by: Thomas

Re: [PATCH 18/30] drm/amd/display/dc/core/dc_link: Move some local data from the stack to the heap

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c: In function > ‘dc_link_construct’: > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:1588:1: warning: the > frame size of

Re: [PATCH 17/30] drm/amd/display/dc/dce60/dce60_resource: Include our own header containing prototypes

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:1115:23: > warning: no previous prototype for ‘dce60_create_resource_pool’ > [-Wmissing-prototypes] >

Re: [PATCH 15/30] drm/amd/display/dc/dce80/dce80_resource: Include our own header containing prototypes

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:1126:23: > warning: no previous prototype for ‘dce80_create_resource_pool’ > [-Wmissing-prototypes] >

Re: [PATCH 14/30] drm/amd/display/dc/dce80/Makefile: Ignore -Woverride-init warning

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:29: > > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_8_0_sh_mask.h:9546:58: > warning:

Re: [PATCH 13/30] drm/amd/display/dc/dce60/Makefile: Ignore -Woverride-init warning

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:28: > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:568:43: > warning: initialized

Re: [PATCH 12/30] drm/amd/display/dc/dce100/dce100_resource: Include our own header containing prototypes

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:54: > drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:537:3: > note: in

Re: [PATCH 11/30] drm/amd/display/dc/dce100/Makefile: Ignore -Woverride-init warning

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:54: > > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_10_0_sh_mask.h:5084:45: >

Re: [PATCH 10/30] drm/amd/display/dc/core/dc: Staticise local function 'apply_ctx_interdependent_lock'

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:806:6: warning: no > previous prototype for ‘apply_ctx_interdependent_lock’ [-Wmissing-prototypes] > > Cc: Harry Wentland > Cc: Leo Li >

Re: [PATCH 09/30] drm/amd/display/dc/dce112/dce112_resource: Include our own header file containing prototypes

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:883:6: > warning: no previous prototype for ‘dce112_validate_bandwidth’ > [-Wmissing-prototypes] >

Re: [PATCH 08/30] drm/amd/display/dc/core/dc_link_dp: Staticify local function 'linkRateInKHzToLinkRateMultiplier'

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3710:19: warning: > no previous prototype for ‘linkRateInKHzToLinkRateMultiplier’ > [-Wmissing-prototypes] >

Re: [PATCH 07/30] drm/amd/display/dc/core/dc_link: Remove unused variable 'status'

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c: In function > ‘query_hdcp_capability’: > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:599:28: warning: > variable

Re: [PATCH 06/30] drm/amd/display/dc/core/dc_resource: Staticify local functions

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1120:5: warning: > no previous prototype for ‘shift_border_left_to_dst’ [-Wmissing-prototypes] >

Re: [PATCH 05/30] drm/amd/display/modules/info_packet/info_packet: Correct kernel-doc formatting

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/modules/info_packet/info_packet.c:412: > warning: Cannot understand > * >

Re: [PATCH 04/30] drm/amd/display/modules/power/power_helpers: Staticify local functions

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:281:6: > warning: no previous prototype for ‘fill_iram_v_2’ [-Wmissing-prototypes] >

Re: [PATCH 03/30] drm/amd/display/dmub/src/dmub_dcn30: Include our own header containing prototypes

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn30.c:83:6: warning: > no previous prototype for ‘dmub_dcn30_backdoor_load’ [-Wmissing-prototypes] >

Re: [PATCH 02/30] drm/amd/include/renoir_ip_offset: Mark top-level IP_BASE as __maybe_unused

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../include/renoir_ip_offset.h:226:29: warning: > ‘UVD0_BASE’ defined but not used [-Wunused-const-variable=] >

Re: [PATCH 01/30] drm/amd/display/dc/dc_helper: Include our own header, containing prototypes

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dc_helper.c:299:10: warning: no > previous prototype for ‘generic_reg_get’ [-Wmissing-prototypes] >

Re: [PATCH 28/40] drm/amd/display/dc/calcs/dce_calcs: Demote non-conformant kernel-doc function headers

2021-01-14 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2753: warning: > Function parameter or member 'vbios' not described in > 'is_display_configuration_supported' >

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Jerome Glisse
On Thu, Jan 14, 2021 at 02:37:36PM +0100, Christian König wrote: > Am 14.01.21 um 12:52 schrieb Daniel Vetter: > > [SNIP] > > > > I had a new idea, i wanted to think more about it but have not yet, > > > > anyway here it is. Adding a new callback to dma fence which ask the > > > > question can it

Re: [PATCH 21/40] drm/amd/display/dc/calcs/dce_calcs: Remove unused variables 'v_filter_init_mode' and 'sclk_lvl'

2021-01-14 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Jan 8, 2021 at 3:15 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function > ‘calculate_bandwidth’: >

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 5:01 PM Christian König wrote: > > Am 14.01.21 um 16:40 schrieb Daniel Vetter: > > [SNIP] > >> So I think we have to somehow solve this in the kernel or we will go in > >> circles all the time. > >> > >>> So from that pov I think the kernel should at most deal with an >

Re: [PATCH 2/2] drm/cma-helper: Implement mmap as GEM CMA object functions

2021-01-14 Thread Kieran Bingham
Hi Thomas, On 14/01/2021 15:15, Thomas Zimmermann wrote: On 23/11/2020 11:56, Thomas Zimmermann wrote: > The new GEM object function drm_gem_cma_mmap() sets the VMA flags > and offset as in the old implementation and immediately maps in the > buffer's memory pages. > >

[PATCH v4 06/10] drm: rcar-du: Handle CRTC configuration from commit tail handler

2021-01-14 Thread Kieran Bingham
The CRTC mode setting and routing configuration are performed at the earliest of atomic enable and atomic begin, to ensure that a valid configuration is applied to the hardware before the CRTC gets enabled and before planes are setup (the latter being required in particular by the VSP). This

[PATCH v4 08/10] drm: rcar-du: Create a group state object

2021-01-14 Thread Kieran Bingham
Create a new private state object for the DU groups, and move the initialisation of a group object to a new function rcar_du_group_init(). Reviewed-by: Ulrich Hecht Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- Changes since v3: - Rebase to v5.11 - Fix pointer passing for

[PATCH v4 02/10] media: vsp1: drm: Don't configure hardware when the pipeline is disabled

2021-01-14 Thread Kieran Bingham
From: Laurent Pinchart The vsp1_du_atomic_flush() function calls vsp1_du_pipeline_configure() to configure the hardware pipeline. The function is currently guaranteed to be called with the pipeline enabled, but this will change by future rework of the DU driver. Guard the hardware configuration

[PATCH v4 10/10] drm: rcar-du: Centralise routing configuration in commit tail handler

2021-01-14 Thread Kieran Bingham
From: Laurent Pinchart Routing configuration for the DU is complex. Depending on the SoC generation various routing options are available: - The VSP to DU routing is not available on Gen1, is configurable on Gen2 and is fixed on Gen3. When configurable, the routing affects both CRTC groups

[PATCH v4 09/10] drm: rcar-du: Perform group setup from the atomic tail handler

2021-01-14 Thread Kieran Bingham
Create rcar_du_group_atomic_check() and rcar_du_group_atomic_setup() functions to track and apply group state through the DRM atomic state. The use_count field is moved from the rcar_du_group structure to an enabled field in the rcar_du_group_state structure. This allows separating group setup

[PATCH v4 07/10] drm: rcar-du: Provide for_each_group helper

2021-01-14 Thread Kieran Bingham
Refactoring of the group control code will soon require more iteration over the available groups. Simplify this process by introducing a group iteration helper. Reviewed-by: Ulrich Hecht Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- Changes since v2: - Don't assign __group

[PATCH v4 05/10] drm: rcar-du: Handle CRTC standby from commit tail handler

2021-01-14 Thread Kieran Bingham
Manage the power state, and initial configuration of the CRTC from the commit tail handler. CRTCs which need to be activated are taken out of standby, and any deactivated CRTCs are put into standby. This aims at removing CRTC state tracking from the rcar_du_crtc structure. The initial

[PATCH v4 04/10] media: vsp1: drm: Remove vsp1_du_setup_lif()

2021-01-14 Thread Kieran Bingham
The vsp1_du_setup_lif() function is deprecated, and the users have been removed. Remove the implementation and the associated configuration structure. Reviewed-by: Ulrich Hecht Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- drivers/media/platform/vsp1/vsp1_drm.c | 46

[PATCH v4 03/10] drm: rcar-du: Convert to the new VSP atomic API

2021-01-14 Thread Kieran Bingham
The configuration API between the VSP and the DU has been updated to provide finer grain control over modesetting, and enablement. Split rcar_du_vsp_enable() into rcar_du_vsp_modeset() and rcar_du_vsp_enable() accordingly, and update each function to use the new VSP API. There are no further

[PATCH v4 00/10] drm: rcar-du: Rework CRTC and groups for atomic commits

2021-01-14 Thread Kieran Bingham
This patch series refactors atomic commit tail handling in the R-Car DU driver to simplify the code flow, and open the door to further optimisations. It rebases the series posted by Laurent "[PATCH v3 00/10] drm: rcar-du: Rework CRTC and groups for atomic commits", which was itself based upon work

[PATCH v4 01/10] media: vsp1: drm: Split vsp1_du_setup_lif()

2021-01-14 Thread Kieran Bingham
Break vsp1_du_setup_lif() into components more suited to the DRM Atomic API. The existing vsp1_du_setup_lif() API call is maintained as it is still used from the DU. Reviewed-by: Ulrich Hecht Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- Changes since v3: - Minor formatting

Re: fbcon: remove soft scrollback code (missing Doc. patch)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 4:56 PM Geert Uytterhoeven wrote: > > Hi Daniel, > > CC linux-fbdev > > On Tue, Jan 12, 2021 at 5:00 PM Daniel Vetter wrote: > > On Sat, Jan 9, 2021 at 12:11 AM Linus Torvalds > > wrote: > > > On Fri, Jan 8, 2021 at 11:13 AM Phillip Susi wrote: > > > > > Could we pause

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 16:40 schrieb Daniel Vetter: [SNIP] So I think we have to somehow solve this in the kernel or we will go in circles all the time. So from that pov I think the kernel should at most deal with an hmm_fence for cross-process communication and maybe some standard wait primitives

Re: fbcon: remove soft scrollback code (missing Doc. patch)

2021-01-14 Thread Geert Uytterhoeven
Hi Daniel, CC linux-fbdev On Tue, Jan 12, 2021 at 5:00 PM Daniel Vetter wrote: > On Sat, Jan 9, 2021 at 12:11 AM Linus Torvalds > wrote: > > On Fri, Jan 8, 2021 at 11:13 AM Phillip Susi wrote: > > > > Could we pause this madness? Scrollback is still useful. I needed it > > > > today... it was

Re: [PATCH 1/3] drm/vmwgfx: Drop svga_lock

2021-01-14 Thread Roland Scheidegger
Hi, looking at it, seems alright. Not sure why the lock was supposedly needed, maybe it was at some point (it seems like all usage of this lock was introduced way back in 2015, commit 153b3d5b037ee). For the series: Reviewed-by: Roland Scheidegger Roland Am 12.01.21 um 09:49 schrieb Daniel

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 4:08 PM Christian König wrote: > Am 14.01.21 um 15:23 schrieb Daniel Vetter: > > On Thu, Jan 14, 2021 at 3:13 PM Christian König > > wrote: > >> Am 14.01.21 um 14:57 schrieb Daniel Vetter: > >>> On Thu, Jan 14, 2021 at 2:37 PM Christian König > >>> wrote: > Am

Re: [PATCH 1/3] drm/vmwgfx: Drop svga_lock

2021-01-14 Thread Zack Rusin
Looks good. Thanks! Reviewed-by: Zack Rusin > On Jan 12, 2021, at 03:49, Daniel Vetter wrote: > > Hi Roland, > > Hopefully you had a nice start into the new year! Ping for some > review/testing on this series. > > Thanks, Daniel > > On Fri, Dec 11, 2020 at 5:29 PM Daniel Vetter wrote: >>

[PULL] drm-intel-gt-next

2021-01-14 Thread Joonas Lahtinen
Hi Dave & Daniel, Here is the first PR for v5.12. There are quite a few patches accumulated after the holidays as usual: Most importantly there are fixes to the clear residual security mitigations to avoid GPU hangs caused by them. Further there is option to allow the user to decide to disable

Re: [PATCH 2/2] drm/cma-helper: Implement mmap as GEM CMA object functions

2021-01-14 Thread Thomas Zimmermann
Hi Am 14.01.21 um 15:34 schrieb Kieran Bingham: Hi Thomas, On 14/01/2021 13:26, Thomas Zimmermann wrote: Hi Kieran Am 14.01.21 um 13:51 schrieb Kieran Bingham: Hi Thomas, On 23/11/2020 11:56, Thomas Zimmermann wrote: The new GEM object function drm_gem_cma_mmap() sets the VMA flags and

Re: [PATCH v10 4/4] drm/panfrost: Add mt8183-mali compatible string

2021-01-14 Thread Steven Price
On 13/01/2021 06:07, Nicolas Boichat wrote: Add support for MT8183's G72 Bifrost. Signed-off-by: Nicolas Boichat Reviewed-by: Tomeu Vizoso LGTM Reviewed-by: Steven Price --- (no changes since v7) Changes in v7: - Fix GPU ID in commit message Changes in v6: - Context conflicts,

Re: [PATCH v10 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-14 Thread Steven Price
On 13/01/2021 06:07, Nicolas Boichat wrote: GPUs with more than a single regulator (e.g. G72 on MT8183) will require platform-specific handling for devfreq, for 2 reasons: 1. The opp core (drivers/opp/core.c:_generic_set_opp_regulator) does not support multiple regulators, so we'll need

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 15:23 schrieb Daniel Vetter: On Thu, Jan 14, 2021 at 3:13 PM Christian König wrote: Am 14.01.21 um 14:57 schrieb Daniel Vetter: On Thu, Jan 14, 2021 at 2:37 PM Christian König wrote: Am 14.01.21 um 12:52 schrieb Daniel Vetter: [SNIP] I had a new idea, i wanted to think more

Re: [PATCH] drm/vblank: Fix typo in docs

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 07:52:45PM +0530, Sumera Priyadarsini wrote: > Fix typo in intro chapter in drm_vblank.c. > Change 'sacn' to 'scan'. > > Signed-off-by: Sumera Priyadarsini Nice catch, applied. -Daniel > --- > drivers/gpu/drm/drm_vblank.c | 2 +- > 1 file changed, 1 insertion(+), 1

  1   2   >