Re: [PATCH v2 3/5] drm/mediatek: Change disp/ddp term to mutex in mtk mutex driver

2021-01-21 Thread Matthias Brugger
On Thu, Jan 21, 2021 at 07:46:44AM +0800, Chun-Kuang Hu wrote: > Hi, Matthias: > > Matthias Brugger 於 2021年1月21日 週四 上午2:27寫道: > > > > On Thu, Jan 07, 2021 at 07:17:27AM +0800, Chun-Kuang Hu wrote: > > > From: CK Hu > > > > > > mtk mutex is used by both drm and mdp driver, so change disp/ddp term

Re: [PATCH 08/13] drm: remove drm_fb_helper_modinit

2021-01-21 Thread Daniel Vetter
On Thu, Jan 21, 2021 at 8:55 AM Christoph Hellwig wrote: > > drm_fb_helper_modinit has a lot of boilerplate for what is not very > simple functionality. Just open code it in the only caller using > IS_ENABLED and IS_MODULE. > > Signed-off-by: Christoph Hellwig I didn't spot any dependencies wit

Re: [PATCH v4 1/3] drm/uapi: Add USB connector type

2021-01-21 Thread Daniel Vetter
On Thu, Jan 21, 2021 at 8:45 AM Thomas Zimmermann wrote: > > Hi Noralf, > > glad to hear from you! Welcome back! > > Am 20.01.21 um 18:42 schrieb Daniel Vetter: > > On Wed, Jan 20, 2021 at 6:10 PM Noralf Trønnes wrote: > >> > >> Add a connector type for USB connected display panels. > >> > >> Sig

Re: linux-next: build warning after merge of the amdgpu tree

2021-01-21 Thread Daniel Vetter
On Thu, Jan 21, 2021 at 4:07 AM Alex Deucher wrote: > > On Wed, Jan 20, 2021 at 7:53 PM Stephen Rothwell > wrote: > > > > Hi all, > > > > On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell > > wrote: > > > > > > On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell > > > wrote: > > > > > > >

Re: [PATCH v5 00/21] Host1x/TegraDRM UAPI

2021-01-21 Thread Dmitry Osipenko
11.01.2021 15:59, Mikko Perttunen пишет: > Hi all, > > here's the fifth revision of the Host1x/TegraDRM UAPI proposal, > containing primarily small bug fixes. It has also been > rebased on top of recent linux-next. > > vaapi-tegra-driver has been updated to support the new UAPI > as well as Tegra

Re: [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-01-21 Thread Sai Prakash Ranjan
On 2021-01-11 19:45, Sai Prakash Ranjan wrote: commit ecd7274fb4cd ("iommu: Remove unused IOMMU_SYS_CACHE_ONLY flag") removed unused IOMMU_SYS_CACHE_ONLY prot flag and along with it went the memory type setting required for the non-coherent masters to use system cache. Now that system cache suppo

Re: [PATCH v5 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-21 Thread Liu Ying
Hi Laurentiu, On Fri, 2021-01-15 at 19:27 +0200, Laurentiu Palcu wrote: > Hi Liu Ying, > > I promised I would have a second, more in-depth, look at this and I finally > managed to do it. Thanks. > > I have to admit it was a challenge. Partially because I'm not very familiar > with DPU but most

[PATCH v3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip

2021-01-21 Thread Chenyang Li
This patch adds an initial DRM driver for the Loongson LS7A1000 bridge chip(LS7A). The LS7A bridge chip contains two display controllers, support dual display output. The maximum support for each channel display is to 1920x1080@60Hz. At present, DC device detection and DRM driver registration are c

[PATCH 1/1] drm/atomic: put state on error path

2021-01-21 Thread Pan Bian
Put the state before returning error code. Fixes: 44596b8c4750 ("drm/atomic: Unify conflicting encoder handling.") Signed-off-by: Pan Bian --- drivers/gpu/drm/drm_atomic_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/g

[PATCH] drm/amdgpu: Assign boolean values to a bool variable

2021-01-21 Thread Jiapeng Zhong
Fix the following coccicheck warnings: ./drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c: 1009:6-16: WARNING: Assignment of 0/1 to bool variable. ./drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c: 200:2-10: WARNING: Assignment of 0/1 to bool variable. Reported

Re: [PATCH 08/13] drm: remove drm_fb_helper_modinit

2021-01-21 Thread Daniel Vetter
On Thu, Jan 21, 2021 at 9:28 AM Christoph Hellwig wrote: > > On Thu, Jan 21, 2021 at 09:25:40AM +0100, Daniel Vetter wrote: > > On Thu, Jan 21, 2021 at 8:55 AM Christoph Hellwig wrote: > > > > > > drm_fb_helper_modinit has a lot of boilerplate for what is not very > > > simple functionality. Jus

Re: [PATCH v4 1/3] drm/uapi: Add USB connector type

2021-01-21 Thread Simon Ser
On Thursday, January 21st, 2021 at 9:27 AM, Daniel Vetter wrote: > > I would not call it USB. I could imagine that at some point a generic > > USB protocol could serve simple displays (i.e. in the sense of USB HID > > or data or imaging). (Maybe Thunderbold already counts.) Anyway, USB > > shoul

RE: [PATCH] drm/ast: Update the sequence of Clearing Fast-reset

2021-01-21 Thread Kuo-Hsiang Chou
-Original Message- From: Thomas Zimmermann [mailto:tzimmerm...@suse.de] Sent: Thursday, January 21, 2021 3:56 PM To: Kuo-Hsiang Chou ; dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH] drm/ast: Update the sequence of Clearing Fast-reset Hi Am 18.01.21 um

Re: [PATCH 2/2] drm: bridge: Add SN65DSI84 DSI to LVDS bridge

2021-01-21 Thread Michael Nazzareno Trimarchi
Hi Jagan On Wed, Jan 20, 2021 at 12:22 PM Jagan Teki wrote: > > SN65DSI84 is a Single Channel DSI to Dual-link LVDS bridge from > Texas Instruments. > > SN65DSI83, SN65DSI85 are variants of the same family of bridge > controllers. > > Right now the bridge driver is supporting a single link, dual-

Re: [PATCH 00/31] Introduce devm_pm_opp_* API

2021-01-21 Thread Dmitry Osipenko
01.01.2021 19:54, Yangtao Li пишет: > Hi, > > This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, > devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, > devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and > devm_pm_opp_register_notifier. Hello Yangtao, Thank you for y

[PATCH v6 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2021-01-21 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Processing Unit. Signed-off-by: Liu Ying --- v5->v6: * Use graph schema. So, drop Rob's R-b tag as review is needed. v4->v5: * No change. v3->v4: * Improve compatible property by using enum instead of oneOf+const. (Rob) * Add Rob's R-b tag. v2->

[PATCH v2 0/3] Fixes to bridge/panel and ingenic-drm

2021-01-21 Thread Paul Cercueil
Hi, Here are three independent fixes. The first one addresses a use-after-free in bridge/panel.c; the second one addresses a use-after-free in the ingenic-drm driver; finally, the third one makes the ingenic-drm driver work again on older Ingenic SoCs. Changes from v1: - patch [1/3]: the connecto

[PATCH v2 3/3] drm/ingenic: Fix non-OSD mode

2021-01-21 Thread Paul Cercueil
Even though the JZ4740 did not have the OSD mode, it had (according to the documentation) two DMA channels, but there is absolutely no information about how to select the second DMA channel. Make the ingenic-drm driver work in non-OSD mode by using the foreground0 plane (which is bound to the DMA0

Re: [PATCH 03/31] opp: Add devres wrapper for dev_pm_opp_set_supported_hw

2021-01-21 Thread Dmitry Osipenko
01.01.2021 19:54, Yangtao Li пишет: > Add devres wrapper for dev_pm_opp_set_supported_hw() to simplify driver > code. > > Signed-off-by: Yangtao Li > --- > drivers/opp/core.c | 38 ++ > include/linux/pm_opp.h | 8 > 2 files changed, 46 insertions

[PATCH v1 5/7] ARM: dts: imx6dl-prtvt7: Remove backlight enable gpio

2021-01-21 Thread Oleksij Rempel
The backlight power is controlled through the reg_bl_12v0 regulator. Co-Developed-by: Robin van der Gracht Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/arm/boot/dts/imx

Re: [PATCH 2/2] drm: bridge: Add SN65DSI84 DSI to LVDS bridge

2021-01-21 Thread Michael Nazzareno Trimarchi
On Wed, Jan 20, 2021 at 12:29 PM Jagan Teki wrote: > > On Wed, Jan 20, 2021 at 4:55 PM Michael Nazzareno Trimarchi > wrote: > > > > Hi Jagan > > > > On Wed, Jan 20, 2021 at 12:22 PM Jagan Teki > > wrote: > > > > > > SN65DSI84 is a Single Channel DSI to Dual-link LVDS bridge from > > > Texas Ins

[PATCH v2 4/7] ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node

2021-01-21 Thread Oleksij Rempel
Add touchscreen support to the Protonic VT7 board. Co-Developed-by: Robin van der Gracht Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl-prtvt

[PATCH v1 0/7] devicetree fixes for Protonic and Plymovent boards

2021-01-21 Thread Oleksij Rempel
Oleksij Rempel (7): dt-bindings: display: simple: add Innolux G070Y2-T02 panel drm: panel-simple: Add support for the Innolux G070Y2-T02 panel ARM: dts: imx6dl-prtvt7: Add display and panel nodes ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node ARM: dts: imx6dl-prtvt7: Remove backlig

Re: [PATCH 10/10] drm: Use state helper instead of the plane state pointer

2021-01-21 Thread Maxime Ripard
Hi Laurent, On Fri, Jan 15, 2021 at 11:20:21PM +0200, Laurent Pinchart wrote: > Hi Maxime, > > Thank you for the patch. > > On Fri, Jan 15, 2021 at 01:57:02PM +0100, Maxime Ripard wrote: > > Many drivers reference the plane->state pointer in order to get the > > current plane state in their atom

Re: [PATCH v1 4/7] ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node

2021-01-21 Thread robin
On 2021-01-20 15:22, Oleksij Rempel wrote: Add touchscreen support to the Protonic VT7 board. Co-Developed-by: Robin van der Gracht Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 20 1 file changed, 20 insertio

[PATCH v6 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2021-01-21 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINER

[PATCH v1 7/7] ARM: dts: imx6dl-plym2m: remove touchscreen-size-* properties

2021-01-21 Thread Oleksij Rempel
Remove touchscreen-size-* properties. This values are not correct, event if it works with ts_test tool, it fails to work properly with weston. And the real range of values reported by the driver (or measured by the controller) is close to max values and may change with time on resistive panels. So

[PATCH v1 6/7] ARM: dts: imx6dl-prtvt7: fix PWM cell count for the backlight node.

2021-01-21 Thread Oleksij Rempel
At some point PWM cell count was changed, but it didn't triggered any error, since this DT was overwriting "#pwm-cells". To make sure, we are in sync with the kernel driver, remove this property and fix the pwm consumer. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 3 +

[PATCH v6 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-21 Thread Liu Ying
Hi, This is the v6 series to introduce i.MX8qm/qxp Display Processing Unit(DPU) DRM support. DPU is comprised of a blit engine for 2D graphics, a display controller and a command sequencer. Outside of DPU, optional prefetch engines can fetch data from memory prior to some DPU fetchunits of blit

[PATCH] dt-bindings: dp-connector: Drop maxItems from -supply

2021-01-21 Thread Bjorn Andersson
The meta-schema recently gained a definition for the common -supply$ property, which denotes that maxItems is not a valid property. Drop this to clear up the binding validation error. Fixes: a46c112512de ("dt-bindings: dp-connector: add binding for DisplayPort connector") Signed-off-by: Bjorn And

[PATCH v2 2/3] drm/ingenic: Register devm action to cleanup encoders

2021-01-21 Thread Paul Cercueil
Since the encoders have been devm-allocated, they will be freed way before drm_mode_config_cleanup() is called. To avoid use-after-free conditions, we then must ensure that drm_encoder_cleanup() is called before the encoders are freed. v2: Use the new __drmm_simple_encoder_alloc() function Fixes:

[PATCH] drm/imx: fix memory leak when fails to init

2021-01-21 Thread Pan Bian
Put DRM device on initialization failure path rather than directly return error code. Fixes: a67d5088ceb8 ("drm/imx: drop explicit drm_mode_config_cleanup") Signed-off-by: Pan Bian --- drivers/gpu/drm/imx/imx-drm-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

Re: [PATCH v5 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-21 Thread Liu Ying
On Wed, 2021-01-20 at 11:27 +0200, Laurentiu Palcu wrote: > Hi Liu Ying, > > On Wed, Jan 20, 2021 at 04:42:50PM +0800, Liu Ying wrote: > > Hi Laurentiu, > > > > On Fri, 2021-01-15 at 19:27 +0200, Laurentiu Palcu wrote: > > > Hi Liu Ying, > > > > > > I promised I would have a second, more in-dept

[PATCH v2 2/7] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

2021-01-21 Thread Oleksij Rempel
Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7" WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit. Co-Developed-by: Robin van der Gracht Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- drivers/gpu/drm/panel/panel-simple.c | 16

Re: [PATCH 1/1] drm/scheduler: Job timeout handler returns status (v3)

2021-01-21 Thread Alyssa Rosenzweig
Panfrost hunks Acked-by: Alyssa Rosenzweig signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 7/7] ARM: dts: imx6dl-plym2m: remove touchscreen-size-* properties

2021-01-21 Thread Oleksij Rempel
Remove touchscreen-size-* properties. This values are not correct, event if it works with ts_test tool, it fails to work properly with weston. And the real range of values reported by the driver (or measured by the controller) is close to max values and may change with time on resistive panels. So

[PATCH v2 0/7] devicetree fixes for Protonic and Plymovent boards

2021-01-21 Thread Oleksij Rempel
changes v2: - imx6dl-prtvt7: remove touchscreen-inverted-* Oleksij Rempel (7): dt-bindings: display: simple: add Innolux G070Y2-T02 panel drm: panel-simple: Add support for the Innolux G070Y2-T02 panel ARM: dts: imx6dl-prtvt7: Add display and panel nodes ARM: dts: imx6dl-prtvt7: add TSC204

[PATCH v2 1/3] drm: bridge/panel: Cleanup connector on bridge detach

2021-01-21 Thread Paul Cercueil
If we don't call drm_connector_cleanup() manually in panel_bridge_detach(), the connector will be cleaned up with the other DRM objects in the call to drm_mode_config_cleanup(). However, since our drm_connector is devm-allocated, by the time drm_mode_config_cleanup() will be called, our connector w

[PATCH v1 2/7] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

2021-01-21 Thread Oleksij Rempel
Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7" WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit. Co-Developed-by: Robin van der Gracht Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- drivers/gpu/drm/panel/panel-simple.c | 16

[PATCH v6 2/6] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding

2021-01-21 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Improve compatible property by using enum instead of oneOf+const. (Rob) * Add Rob's R-b tag. v2->v3: * No change.

[PATCH v1 1/7] dt-bindings: display: simple: add Innolux G070Y2-T02 panel

2021-01-21 Thread Oleksij Rempel
Add binding for the Innolux G070Y2-T02 panel. It is 7" WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit. Signed-off-by: Oleksij Rempel --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devic

Re: [PATCH 04/31] opp: Add devres wrapper for dev_pm_opp_of_add_table

2021-01-21 Thread Dmitry Osipenko
01.01.2021 19:54, Yangtao Li пишет: > Add devres wrapper for dev_pm_opp_of_add_table() to simplify driver > code. > > Signed-off-by: Yangtao Li > --- > drivers/opp/of.c | 36 > include/linux/pm_opp.h | 6 ++ > 2 files changed, 42 insertions(+) Rev

Re: [PATCH 02/31] opp: Add devres wrapper for dev_pm_opp_set_regulators and dev_pm_opp_put_regulators

2021-01-21 Thread Dmitry Osipenko
01.01.2021 19:54, Yangtao Li пишет: > Add devres wrapper for dev_pm_opp_set_regulators() > dev_pm_opp_put_regulators () to simplify driver code. > > Signed-off-by: Yangtao Li > --- > drivers/opp/core.c | 50 ++ > include/linux/pm_opp.h | 9 >

[PATCH v2 3/7] ARM: dts: imx6dl-prtvt7: Add display and panel nodes

2021-01-21 Thread Oleksij Rempel
Add Innolux G070Y2-T02 panel to the Protonic VT7 board. Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 47 + 1 file changed, 47 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/bo

Re: [PATCH v2 1/3] drm: bridge/panel: Cleanup connector on bridge detach

2021-01-21 Thread Paul Cercueil
Le mer. 20 janv. 2021 à 17:03, Daniel Vetter a écrit : On Wed, Jan 20, 2021 at 1:35 PM Paul Cercueil wrote: If we don't call drm_connector_cleanup() manually in panel_bridge_detach(), the connector will be cleaned up with the other DRM objects in the call to drm_mode_config_cleanup().

[PATCH v1 3/7] ARM: dts: imx6dl-prtvt7: Add display and panel nodes

2021-01-21 Thread Oleksij Rempel
Add Innolux G070Y2-T02 panel to the Protonic VT7 board. Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 47 + 1 file changed, 47 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/bo

Re: [PATCH v4, 03/10] soc: mediatek: mmsys: move register operation into mmsys path select function

2021-01-21 Thread Yongqiang Niu
On Wed, 2021-01-20 at 20:38 +0100, Matthias Brugger wrote: > On Tue, Jan 05, 2021 at 11:06:26AM +0800, Yongqiang Niu wrote: > > move register operation into mmsys path select function > > Why do you want to do that. It seems the register access pattern is the > same for all SoCs so far supported,

[PATCH v6 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2021-01-21 Thread Liu Ying
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Acked-by: Daniel Vetter Signed-off-by: Liu Ying --- v5->v6: * Fix commit message typo - s/Artifically/Artificially/ v4->v5: * No change. v3->v4: * Ad

[PATCH v1 4/7] ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node

2021-01-21 Thread Oleksij Rempel
Add touchscreen support to the Protonic VT7 board. Co-Developed-by: Robin van der Gracht Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl-

[PATCH v6 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2021-01-21 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Improve compatible property by using enum instead of oneOf+const. (Rob) * Add Rob's R-b tag. v2->v3: * No change.

[PATCH v2 1/7] dt-bindings: display: simple: add Innolux G070Y2-T02 panel

2021-01-21 Thread Oleksij Rempel
Add binding for the Innolux G070Y2-T02 panel. It is 7" WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit. Signed-off-by: Oleksij Rempel --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devic

[PATCH v2 5/7] ARM: dts: imx6dl-prtvt7: Remove backlight enable gpio

2021-01-21 Thread Oleksij Rempel
The backlight power is controlled through the reg_bl_12v0 regulator. Co-Developed-by: Robin van der Gracht Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/arm/boot/dts/imx

Re: [PATCH v2 2/3] drm/ingenic: Register devm action to cleanup encoders

2021-01-21 Thread Paul Cercueil
Le mer. 20 janv. 2021 à 14:01, Daniel Vetter a écrit : On Wed, Jan 20, 2021 at 1:36 PM Paul Cercueil wrote: Since the encoders have been devm-allocated, they will be freed way before drm_mode_config_cleanup() is called. To avoid use-after-free conditions, we then must ensure that drm_e

[PATCH v2 6/7] ARM: dts: imx6dl-prtvt7: fix PWM cell count for the backlight node.

2021-01-21 Thread Oleksij Rempel
At some point PWM cell count was changed, but it didn't triggered any error, since this DT was overwriting "#pwm-cells". To make sure, we are in sync with the kernel driver, remove this property and fix the pwm consumer. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 3 +

Re: [PATCH v2 2/3] drm/ingenic: Register devm action to cleanup encoders

2021-01-21 Thread Paul Cercueil
Le mer. 20 janv. 2021 à 15:04, Daniel Vetter a écrit : On Wed, Jan 20, 2021 at 2:21 PM Paul Cercueil wrote: Le mer. 20 janv. 2021 à 14:01, Daniel Vetter a écrit : > On Wed, Jan 20, 2021 at 1:36 PM Paul Cercueil > wrote: >> >> Since the encoders have been devm-allocated, they

Re: [PATCH 24/31] memory: tegra20: convert to use devm_pm_opp_* API

2021-01-21 Thread Dmitry Osipenko
01.01.2021 19:55, Yangtao Li пишет: > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/memory/tegra/tegra20-emc.c | 29 + > 1 file changed, 9 insertions(+), 20 deletions(-) There are also tegra30-emc.c and tegra124-emc.c with a si

Re: [PATCH v2] drm/virtio: Track total GPU memory for virtio driver

2021-01-21 Thread Gerd Hoffmann
On Wed, Jan 20, 2021 at 10:52:11AM -0800, Yiwei Zhang wrote: > On Wed, Jan 20, 2021 at 5:33 AM Gerd Hoffmann wrote: > > > > Hi, > > > > > > > > > + select TRACE_GPU_MEM > > > > > > > > > +#ifdef CONFIG_TRACE_GPU_MEM > > > > That doesn't make sense btw. > > Do you recommend we just select

Re: [PATCH v4 0/3] Generic USB Display driver

2021-01-21 Thread Thomas Zimmermann
Hi Am 20.01.21 um 18:00 schrieb Noralf Trønnes: Hi, A while back I had the idea to turn a Raspberry Pi Zero into a $5 USB to HDMI/SDTV/DSI/DPI display adapter. The reason for calling it 'Generic' is so anyone can make a USB display/adapter against this driver, all that's needed is to add a USB

Re: [PATCH v4 1/3] drm/uapi: Add USB connector type

2021-01-21 Thread Thomas Zimmermann
Hi Am 21.01.21 um 09:27 schrieb Daniel Vetter: On Thu, Jan 21, 2021 at 8:45 AM Thomas Zimmermann wrote: Hi Noralf, glad to hear from you! Welcome back! Am 20.01.21 um 18:42 schrieb Daniel Vetter: On Wed, Jan 20, 2021 at 6:10 PM Noralf Trønnes wrote: Add a connector type for USB connecte

Re: [PATCH v4 0/3] Generic USB Display driver

2021-01-21 Thread Simon Ser
On Thursday, January 21st, 2021 at 10:59 AM, Thomas Zimmermann wrote: > Well, I'd strongly ask to not call it "generic", because it isn't. We > have other USB drivers and anyone can make a USB display with these > protocols as well. That doesn't make them generic. A USB-standardized > protocol w

Re: [PATCH v4 07/14] drm/amdgpu: Register IOMMU topology notifier per device.

2021-01-21 Thread Christian König
Am 20.01.21 um 20:38 schrieb Andrey Grodzovsky: Ping Andrey On 1/20/21 12:01 AM, Andrey Grodzovsky wrote: On 1/19/21 3:48 AM, Christian König wrote: Am 18.01.21 um 22:01 schrieb Andrey Grodzovsky: Handle all DMA IOMMU gropup related dependencies before the group is removed. Signed-off-by:

Re: [PATCH 1/1] drm/scheduler: Job timeout handler returns status (v3)

2021-01-21 Thread Christian König
Am 20.01.21 um 21:09 schrieb Luben Tuikov: This patch does not change current behaviour. The driver's job timeout handler now returns status indicating back to the DRM layer whether the device (GPU) is no longer available, such as after it's been unplugged, or whether all is normal, i.e. current

Re: [PATCH v4 07/14] drm/amdgpu: Register IOMMU topology notifier per device.

2021-01-21 Thread Daniel Vetter
On Wed, Jan 20, 2021 at 8:16 PM Andrey Grodzovsky wrote: > > > On 1/20/21 3:38 AM, Daniel Vetter wrote: > > On Wed, Jan 20, 2021 at 5:21 AM Andrey Grodzovsky > > wrote: > >> > >> On 1/19/21 5:01 PM, Daniel Vetter wrote: > >>> On Tue, Jan 19, 2021 at 10:22 PM Andrey Grodzovsky > >>> wrote: >

Re: [RESEND PATCH] drm/rockchip: dsi: move all lane config except LCDC mux to bind()

2021-01-21 Thread aleksandr . o . makarov
В Вс, 13/12/2020 в 12:58 -0800, Thomas Hebb пишет: > When we first enable the DSI encoder, we currently program some per-chip > configuration that we look up in rk3399_chip_data based on the device > tree compatible we match. This data configures various parameters of the > MIPI lanes, including on

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Jani Nikula
On Wed, 20 Jan 2021, Lyude Paul wrote: > Reviewed-by: Lyude Paul Thanks for the review. Sean, Rob, or anyone with an arm toolchain for msm available, could I trouble you to build test this please? BR, Jani. > > On Wed, 2021-01-20 at 13:07 +0200, Jani Nikula wrote: >> Commit 7c553f8b5a7d ("d

Re: [PATCH v4] drm: Improve the output_poll_changed description

2021-01-21 Thread Daniel Vetter
On Thu, Jan 21, 2021 at 4:09 AM ZhiJie.Zhang wrote: > > From: zhangzhijie > > this callback was used by drm_kms_helper_hotplug_event() > > V2: (Thanks for Daniel's suggestions) > - remove the FIXME below.since with the drm_client > - infrastructure and the generic fbdev emulation we've > - resolv

[PATCH] drm: Update todo.rst

2021-01-21 Thread Daniel Vetter
Interrnship season is starting, let's review this. One thing that's pending is Maxime's work to roll out drm_atomic_state pointers to all callbacks, he said he'll remove that entry once it's all done. Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Fabio Estevam
Hi Jani, On Thu, Jan 21, 2021 at 8:22 AM Jani Nikula wrote: > Sean, Rob, or anyone with an arm toolchain for msm available, could I > trouble you to build test this please? I tried to build after applying your patch: CC drivers/gpu/drm/msm/dp/dp_ctrl.o drivers/gpu/drm/msm/dp/dp_ctrl.c:

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Jani Nikula
On Thu, 21 Jan 2021, Fabio Estevam wrote: > Hi Jani, > > On Thu, Jan 21, 2021 at 8:22 AM Jani Nikula wrote: > >> Sean, Rob, or anyone with an arm toolchain for msm available, could I >> trouble you to build test this please? > > I tried to build after applying your patch: On top of what? Current

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Fabio Estevam
On Thu, Jan 21, 2021 at 8:41 AM Jani Nikula wrote: > On top of what? Current drm-tip? It was on top of next-20210121. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 3/3] drm/bridge/lontium-lt9611uxc: move HPD notification out of IRQ handler

2021-01-21 Thread Andrzej Hajda
Hi Dmitry, W dniu 17.01.2021 o 01:23, Dmitry Baryshkov pisze: > drm hotplug handling code (drm_client_dev_hotplug()) can wait on mutex, > thus delaying further lt9611uxc IRQ events processing. It was observed > occasionally during bootups, when drm_client_modeset_probe() was waiting > for EDID re

[PATCH] drm/ttm: device naming cleanup

2021-01-21 Thread Christian König
Rename ttm_bo_device to ttm_device. Rename ttm_bo_driver to ttm_device_funcs. Rename ttm_bo_global to ttm_global. Move global and device related functions to ttm_device.[ch]. No functional change. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- .../gp

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Jani Nikula
On Thu, 21 Jan 2021, Fabio Estevam wrote: > On Thu, Jan 21, 2021 at 8:41 AM Jani Nikula wrote: > >> On top of what? Current drm-tip? > > It was on top of next-20210121. Kinda catch-22 because next has dropped current drm-intel-next because it doesn't build because of the

Re: [PATCH] drm/komeda: Fix bit check to import to value of proper type

2021-01-21 Thread Carsten Haitzler
On 1/20/21 3:44 PM, Steven Price wrote: On 18/01/2021 14:20, carsten.haitz...@foss.arm.com wrote: From: Carsten Haitzler Another issue found by KASAN. The bit finding is bueried inside the NIT: s/bueried/buried/ Yup. typo not spotted by me. Thanks. Also - i spotted an accidental whitespac

[PATCH v2] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-01-21 Thread Hridya Valsaraju
This patch allows statistics to be enabled for each DMA-BUF in sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS. The following stats will be exposed by the interface: /sys/kernel/dmabuf/buffers//exporter_name /sys/kernel/dmabuf/buffers//size /sys/kernel/dmabuf/buffers//attachments//device /

Re: [PATCH v2] drm/virtio: Track total GPU memory for virtio driver

2021-01-21 Thread Yiwei Zhang‎
On Mon, Jan 18, 2021 at 11:03 PM Daniel Vetter wrote: > > On Tue, Jan 19, 2021 at 12:41 AM Yiwei Zhang wrote: > > > > On the success of virtio_gpu_object_create, add size of newly allocated > > bo to the tracled total_mem. In drm_gem_object_funcs.free, after the gem > > bo lost its last refcount,

Re: [PATCH v2] drm/virtio: Track total GPU memory for virtio driver

2021-01-21 Thread Yiwei Zhang‎
On Wed, Jan 20, 2021 at 1:11 AM Daniel Vetter wrote: > > On Tue, Jan 19, 2021 at 11:08:12AM -0800, Yiwei Zhang wrote: > > On Mon, Jan 18, 2021 at 11:03 PM Daniel Vetter wrote: > > > > > > On Tue, Jan 19, 2021 at 12:41 AM Yiwei Zhang wrote: > > > > > > > > On the success of virtio_gpu_object_crea

[PATCH] drm: Added orientation quirk for OneGX1 Pro

2021-01-21 Thread Jared Baldridge
The OneGX1 Pro has a fairly unique combination of generic strings, but we additionally match on the BIOS date just to be safe. Signed-off-by: Jared Baldridge --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Fabio Estevam
On Thu, Jan 21, 2021 at 9:10 AM Jani Nikula wrote: > Kinda catch-22 because next has dropped current drm-intel-next because > it doesn't build because of the issue this patch fixes. ;) Ok, so I built drm-intel-next and I was able to reproduce the buid error as reported by Stephen. Applied this

Re: [Linaro-mm-sig] [PATCH v2] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-01-21 Thread Hridya Valsaraju
On Wed, Jan 20, 2021 at 4:22 AM Christian König wrote: > > Am 19.01.21 um 23:57 schrieb Hridya Valsaraju: > > This patch allows statistics to be enabled for each DMA-BUF in > > sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS. > > > > The following stats will be exposed by the interface: > >

Re: [Linaro-mm-sig] [PATCH v2] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-01-21 Thread Hridya Valsaraju
On Wed, Jan 20, 2021 at 4:42 AM Daniel Vetter wrote: > > On Wed, Jan 20, 2021 at 1:22 PM Christian König > wrote: > > > > Am 19.01.21 um 23:57 schrieb Hridya Valsaraju: > > > This patch allows statistics to be enabled for each DMA-BUF in > > > sysfs by enabling the config CONFIG_DMABUF_SYSFS_STAT

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Jani Nikula
On Thu, 21 Jan 2021, Fabio Estevam wrote: > On Thu, Jan 21, 2021 at 9:10 AM Jani Nikula wrote: > >> Kinda catch-22 because next has dropped current drm-intel-next because >> it doesn't build because of the issue this patch fixes. ;) > > Ok, so I built drm-intel-next and I was able to reproduce th

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-21 Thread Christian König
I still have no idea what's going on here. The KASAN messages from the DC code are completely unrelated. Please add the full dmesg to your bug report. Christian. Am 20.01.21 um 01:59 schrieb Mikhail Gavrilov: On Fri, 15 Jan 2021 at 03:43, Mikhail Gavrilov wrote: In rc4, the number of warning

Re: [RESEND][PATCH 1/3] dma-buf: system_heap: Make sure to return an error if we abort

2021-01-21 Thread Sumit Semwal
Hi John, On Wed, 20 Jan 2021 at 02:15, John Stultz wrote: > > If we abort from the allocation due to a fatal_signal_pending(), > be sure we report an error so any return code paths don't trip > over the fact that the allocation didn't succeed. Thanks for the patch; LGTM, will push into drm-misc-

Re: [RESEND][PATCH 3/3] dma-buf: heaps: Rework heep allocation hooks to return struct dma_buf instead of fd

2021-01-21 Thread Sumit Semwal
Hi John, On Wed, 20 Jan 2021 at 02:15, John Stultz wrote: > > Every heap needs to create a dmabuf and then export it to a fd > via dma_buf_fd(), so to consolidate things a bit, have the heaps > just return a struct dmabuf * and let the top level > dma_heap_buffer_alloc() call handle creating the

Re: [PATCH v4 1/2] dma-fence: allow signaling drivers to set fence timestamp

2021-01-21 Thread Sumit Semwal
Hi Veera, On Wed, 20 Jan 2021 at 02:00, John Stultz wrote: > > On Fri, Jan 15, 2021 at 4:31 PM Veera Sundaram Sankaran > wrote: > > > > Some drivers have hardware capability to get the precise HW timestamp > > of certain events based on which the fences are triggered. The delta > > between the e

Re: [PATCH 1/1] drm/scheduler: Job timeout handler returns status (v3)

2021-01-21 Thread Steven Price
On 20/01/2021 20:09, Luben Tuikov wrote: This patch does not change current behaviour. The driver's job timeout handler now returns status indicating back to the DRM layer whether the device (GPU) is no longer available, such as after it's been unplugged, or whether all is normal, i.e. current b

Re: [PATCH v2 6/7] ARM: dts: imx6dl-prtvt7: fix PWM cell count for the backlight node.

2021-01-21 Thread Fabio Estevam
Hi Oleksij, On Thu, Jan 21, 2021 at 3:12 AM Oleksij Rempel wrote: > > At some point PWM cell count was changed, but it didn't triggered any It changed in this commit: commit fa28d8212ede9c533ae87a737571a9d3b3eebb29 Author: Uwe Kleine-König Date: Fri Jul 10 07:19:37 2020 +0200 ARM: dts:

Re: [PATCH] drm: Update todo.rst

2021-01-21 Thread Thomas Zimmermann
Hi we talked about making dma_resv the default lock for GEM objects. Could you add an entry for this? Some interns might feel adventurous. :) Best regards Thomas Am 21.01.21 um 12:29 schrieb Daniel Vetter: Interrnship season is starting, let's review this. One thing that's pending is Maxime'

Re: [PATCH] drm: Update todo.rst

2021-01-21 Thread Daniel Vetter
On Thu, Jan 21, 2021 at 3:31 PM Thomas Zimmermann wrote: > > Hi > > we talked about making dma_resv the default lock for GEM objects. Could > you add an entry for this? Some interns might feel adventurous. :) Level: Too hard for Daniel Not sure that's a great internship tasks :-P But yeah I'll

Re: possible IO map leak in drm/gem

2021-01-21 Thread Thomas Zimmermann
(cc'ing dri-devel) Hi, thanks for reporting the bug. Am 21.01.21 um 15:35 schrieb Chuck Lever: Hi Thomas- I was not able to find an appropriate mailing list entry in MAINTAINERS, That would be dri-devel@lists.freedesktop.org so I'm mailing you directly as committer of record for: 4367660

[PULL] drm-intel-gt-next

2021-01-21 Thread Joonas Lahtinen
Hi Dave & Daniel, Here is the final PR for v5.12. One more fix for the clear residuals security mitigation. Per-engine reset for Gen7 to avoid collateral damage when some workloads misbehave, flip priority boosting when using explicit fences (sync_file), improving suspend/freeze speed and avoidi

[PATCH 00/11] dma_fence critical sections annotations for atomic

2021-01-21 Thread Daniel Vetter
Hi all, Finally gotten around to refreshing all the various fence anntotions I've hast last summer. Or well parts of it: - entire amdgpu and drm/scheduler annotations postponed for now, because there's way too many splats in there that need some work - in recent patches I've seen quite a few d

[PATCH 02/11] drm/vkms: Annotate vblank timer

2021-01-21 Thread Daniel Vetter
This is needed to signal the fences from page flips, annotate it accordingly. We need to annotate entire timer callback since if we get stuck anywhere in there, then the timer stops, and hence fences stop. Just annotating the top part that does the vblank handling isn't enough. Tested-by: Melissa

[PATCH 01/11] drm/atomic-helper: Add dma-fence annotations

2021-01-21 Thread Daniel Vetter
This is a bit disappointing since we need to split the annotations over all the different parts. I was considering just leaking the critical section into the ->atomic_commit_tail callback of each driver. But that would mean we need to pass the fence_cookie into each driver (there's a total of 13 i

[PATCH 03/11] drm/vblank: Annotate with dma-fence signalling section

2021-01-21 Thread Daniel Vetter
This is rather overkill since currently all drivers call this from hardirq (or at least timers). But maybe in the future we're going to have thread irq handlers and what not, doesn't hurt to be prepared. Plus this is an easy start for sprinkling these fence annotations into shared code. Cc: linux-

[PATCH 05/11] drm/malidp: Annotate dma-fence critical section in commit path

2021-01-21 Thread Daniel Vetter
Again needs to be put right after the call to drm_atomic_helper_commit_hw_done(), since that's the last thing which can hold up a subsequent atomic commit. No surprises here. Acked-by: Liviu Dudau Signed-off-by: Daniel Vetter Cc: "James (Qian) Wang" Cc: Liviu Dudau Cc: Mihail Atanassov ---

[PATCH 06/11] drm/atmel: Use drm_atomic_helper_commit

2021-01-21 Thread Daniel Vetter
One of these drivers that predates the nonblocking support in helpers, and hand-rolled its own thing. Entirely not anything specific here, we can just delete it all and replace it with the helper version. Could also perhaps use the drm_mode_config_helper_suspend/resume stuff, for another few lines

[PATCH 07/11] drm/imx: Annotate dma-fence critical section in commit path

2021-01-21 Thread Daniel Vetter
drm_atomic_helper_commit_hw_done() is the last thing (no plane cleanup apparrently), so it's the entire function. And a nice comment explaining why thw wait_for_flip_done is ahead, unlike the usual sequence. Aside, I think since the atomic helpers do track plane disabling now separately this might

[PATCH 04/11] drm/komeda: Annotate dma-fence critical section in commit path

2021-01-21 Thread Daniel Vetter
Like the helpers, nothing special. Well except not, because we the critical section extends until after hw_done(), since that's the last thing which could hold up a subsequent atomic commit. That means the wait_for_flip_done is included, but that's not a problem, we're allowed to call dma_fence_wai

  1   2   >