Re: [PATCH] drm/ttm: Use __GFP_NOWARN for huge pages in ttm_pool_alloc_page

On Thu, 28 Jan 2021, Michel Dänzer wrote: > From: Michel Dänzer > > Without __GFP_NOWARN, attempts at allocating huge pages can trigger > dmesg splats like below (which are essentially noise, since TTM falls > back to normal pages if it can't get a huge one). > > [ 9556.710241] clinfo: page

Re: [PATCH v4 5/8] drm/mediatek: separate ccorr module

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午3:35寫道： > > From: Yongqiang Niu > > ccorr ctm matrix bits will be different in mt8192 > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/Makefile | 3 +- >

Re: [PATCH v4 4/8] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

Hi, Hsin-Yi: CK Hu 於 2021年1月29日 週五 下午4:21寫道： > > Hi, Hsin-Yi: > > On Fri, 2021-01-29 at 15:34 +0800, Hsin-Yi Wang wrote: > > From: Yongqiang Niu > > > > enable OVL_LAYER_SMI_ID_EN for multi-layer usecase, without this patch, > > ovl will hang up when more than 1 layer enabled. > > Reviewed-by:

Re: [PATCH v13 6/8] drm/mediatek: enable dither function

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道： > > From: Yongqiang Niu > > Enable dither function to improve the display quality for dither > supported bpc 4, 6, 8. For not supported bpc, use relay mode. > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- >

Re: [PATCH 09/29] drm/gma500: Avoid comma separated statements

On Sat, Jan 30, 2021 at 7:47 PM Joe Perches wrote: > > On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > > Use semicolons and braces. > > Ping? This entire file is going away so perhaps just drop the patch to avoid a conflict. -Patrik > > > Signed-off-by: Joe Perches > > --- > >

intel gpu hang solved in fedora

Hello everybody, After 6 month Intel gpu hang on fedora (drm), with the introduction of 5.11 kernel this problem was solved. Now you can update to 5.11 kernel for Liberation. -- مجله کامیون سلطان جاده Persian Trucking Mag

Re: [PATCH 10/29] drm/i915: Avoid comma separated statements

On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > Use semicolons and braces. Ping? > Signed-off-by: Joe Perches > --- >  drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 8 +--- >  drivers/gpu/drm/i915/gt/intel_gt_requests.c| 6 -- >  

Re: [PATCH 09/29] drm/gma500: Avoid comma separated statements

On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > Use semicolons and braces. Ping? > Signed-off-by: Joe Perches > --- >  drivers/gpu/drm/gma500/mdfld_intel_display.c | 44 +--- >  1 file changed, 28 insertions(+), 16 deletions(-) > > diff --git

Re: [PATCH 08/29] dma-buf: Avoid comma separated statements

On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > Use semicolons and braces. Ping? > Signed-off-by: Joe Perches > --- >  drivers/dma-buf/st-dma-fence.c | 7 +-- >  1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma-buf/st-dma-fence.c

[PATCH 1/2] vgaarb: Fix return value of notifier callback

If it's not a vga device, just don't care (NOTIFY_DONE). Otherwise return NOTIFY_OK after processing done. Signed-off-by: Abel Wu --- drivers/gpu/vga/vgaarb.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/vga/vgaarb.c

Re: [PATCH] drm/msm/dsi: save PLL registers across first PHY reset

On 10/30/20 6:55 AM, Dmitry Baryshkov wrote: > Hello, > > On 07/10/2020 03:10, benl-kernelpatc...@squareup.com wrote: >> From: Benjamin Li >> >> Take advantage of previously-added support for persisting PLL >> registers across DSI PHY disable/enable cycles (see 328e1a6 >> 'drm/msm/dsi:

[PATCH 2/2] vgaarb: Make initcall always return success

Returning error usually implies failure, in which case anything that has done should be properly reverted. Thus if failed in registering /dev/vga_arbiter, it is better to just throw out a warning than returning error without unregistering pci_notifier. Signed-off-by: Abel Wu ---

[PATCH 0/2] vgaarb: minor fixes on return value

Two minor fixes on return value, of which one for the pci notifer and the other for initcall. Abel Wu (2): vgaarb: Fix return value of notifier callback vgaarb: Make initcall always return success drivers/gpu/vga/vgaarb.c | 39 +++ 1 file changed, 23

Re: [PATCH v2] drm/lima: add governor data with pre-defined thresholds

This patch gets minor improvement on glmark2 (160->162). Seems there's no way for user to change this value, do we? Or there's work pending to expose it to sysfs? Regards, Qiang On Thu, Jan 28, 2021 at 3:40 AM Christian Hewitt wrote: > > This patch adapts the panfrost pre-defined thresholds

Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

Thanks for the patch. But I can't observe any difference on glmark2 with or without this patch. Maybe you can provide other test which can benefit from it. Considering it will wake up CPU more frequently, and user may choose to change this by sysfs, I'd like to not apply it. Regards, Qiang On

Re: [PATCH] drm/i915: Remove unreachable code

Quoting Vinicius Tinti (2021-01-30 12:34:11) > On Fri, Jan 29, 2021 at 08:55:54PM +, Chris Wilson wrote: > > Quoting Vinicius Tinti (2021-01-29 18:15:19) > > > By enabling -Wunreachable-code-aggressive on Clang the following code > > > paths are unreachable. > > > > That code exists as

[PATCH] drm/msm/dp/dp_ctrl: Remove unneeded semicolon

fix semicolon.cocci warnings: drivers/gpu/drm/msm/dp/dp_ctrl.c:1161:2-3: Unneeded semicolon Signed-off-by: Xu Wang --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index

Re: [PATCH v12] staging: fbtft: add tearing signal detect

On Fri, 29 Jan 2021 12:23:08 +0200 Andy Shevchenko wrote: > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote: > > On Thu, 28 Jan 2021 16:33:02 +0200 > > Andy Shevchenko wrote: > > > On Thu, Jan 28, 2021 at 2:58 PM Carlis > > > wrote: > > > > > > Thanks for your contribution, my comments below.

Re: [PATCH v4 2/8] drm/mediatek: add component POSTMASK

On Fri, 2021-01-29 at 16:35 +0800, CK Hu wrote: > On Fri, 2021-01-29 at 16:32 +0800, Yongqiang Niu wrote: > > On Fri, 2021-01-29 at 16:18 +0800, CK Hu wrote: > > > Hi, Hsin-Yi: > > > > > > On Fri, 2021-01-29 at 15:34 +0800, Hsin-Yi Wang wrote: > > > > From: Yongqiang Niu > > > > > > > > This

[PATCH v13 6/8] drm/mediatek: enable dither function

From: Yongqiang Niu Enable dither function to improve the display quality for dither supported bpc 4, 6, 8. For not supported bpc, use relay mode. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 15 --- 1 file changed, 12

[PATCH v13 7/8] soc: mediatek: add mtk mutex support for MT8183

From: Yongqiang Niu Add mtk mutex support for MT8183 SoC. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/soc/mediatek/mtk-mutex.c | 50 1 file changed, 50 insertions(+) diff --git a/drivers/soc/mediatek/mtk-mutex.c

Re: [PATCH v4 2/8] drm/mediatek: add component POSTMASK

On Fri, 2021-01-29 at 16:18 +0800, CK Hu wrote: > Hi, Hsin-Yi: > > On Fri, 2021-01-29 at 15:34 +0800, Hsin-Yi Wang wrote: > > From: Yongqiang Niu > > > > This patch add component POSTMASK, > > > > Signed-off-by: Yongqiang Niu > > Signed-off-by: Hsin-Yi Wang > > --- > >

[PATCH] drm/kmb: Remove unneeded semicolon

fix semicolon.cocci warnings: drivers/gpu/drm/kmb/kmb_dsi.c:284:3-4: Unneeded semicolon drivers/gpu/drm/kmb/kmb_dsi.c:304:3-4: Unneeded semicolon drivers/gpu/drm/kmb/kmb_dsi.c:321:3-4: Unneeded semicolon drivers/gpu/drm/kmb/kmb_dsi.c:340:3-4: Unneeded semicolon

Re: [PATCH v4 6/8] drm/mediatek: add matrix bits private data for ccorr

On Fri, 2021-01-29 at 16:40 +0800, CK Hu wrote: > Hi, Hsin-Yi: > > On Fri, 2021-01-29 at 15:34 +0800, Hsin-Yi Wang wrote: > > From: Yongqiang Niu > > > > matrix bits of mt8183 is 12 > > matrix bits of mt8192 is 13 > > > > Signed-off-by: Yongqiang Niu > > Signed-off-by: Hsin-Yi Wang > > --- >

[PATCH v13 4/8] drm/mediatek: separate gamma module

From: Yongqiang Niu mt8183 gamma module will different with mt8173 separate gamma for add private data Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_disp_drv.h | 10 +

[PATCH] drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c: Remove unneeded semicolon

fix semicolon.cocci warnings: drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:752:2-3: Unneeded semicolon Signed-off-by: Xu Wang --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c

Re: [PATCH v12] staging: fbtft: add tearing signal detect

On Fri, 29 Jan 2021 12:23:08 +0200 Andy Shevchenko wrote: > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote: > > On Thu, 28 Jan 2021 16:33:02 +0200 > > Andy Shevchenko wrote: > > > On Thu, Jan 28, 2021 at 2:58 PM Carlis > > > wrote: > > > > > > Thanks for your contribution, my comments below.

Re: [PATCH v12] staging: fbtft: add tearing signal detect

On Fri, 29 Jan 2021 12:23:08 +0200 Andy Shevchenko wrote: > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote: > > On Thu, 28 Jan 2021 16:33:02 +0200 > > Andy Shevchenko wrote: > > > On Thu, Jan 28, 2021 at 2:58 PM Carlis > > > wrote: > > > > > > Thanks for your contribution, my comments below.

Re: [PATCH v12] staging: fbtft: add tearing signal detect

On Fri, 29 Jan 2021 16:26:12 +0200 Andy Shevchenko wrote: > On Fri, Jan 29, 2021 at 3:56 PM carlis wrote: > > On Fri, 29 Jan 2021 12:23:08 +0200 > > Andy Shevchenko wrote: > > We are almost there, I have no idea what Noralf or others are going to > say though. > > ... > > > Hi, I

[PATCH v2] drm/panel: simple: add SGD GKTW70SDAD1SD

Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD to panel-simple. The panel spec from Variscite can be found at: https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdf Signed-off-by: Oliver Graute Cc: Marco Felsch Cc: Fabio Estevam --- v2: - changed bpc

[PATCH v13 3/8] drm/mediatek: add mtk_dither_set_common() function

Current implementation of mtk_dither_set() cast dev data to struct mtk_ddp_comp_dev. But other devices with different dev data would also call this function. Separate necessary parameters out so other device components (dither, gamma) can call this function. Signed-off-by: Hsin-Yi Wang

Re: [PATCH v4 2/8] drm/mediatek: add component POSTMASK

On Fri, Jan 29, 2021 at 4:49 PM Yongqiang Niu wrote: > > On Fri, 2021-01-29 at 16:35 +0800, CK Hu wrote: > > On Fri, 2021-01-29 at 16:32 +0800, Yongqiang Niu wrote: > > > On Fri, 2021-01-29 at 16:18 +0800, CK Hu wrote: > > > > Hi, Hsin-Yi: > > > > > > > > On Fri, 2021-01-29 at 15:34 +0800,

[PATCH v2] drm/msm/dp: trigger unplug event in msm_dp_display_disable

From: Judy Hsiao 1. Trigger the unplug event in msm_dp_display_disable() to shutdown audio properly. 2. Reset the completion before signal the disconnect event. Fixes: 158b9aa74479 ("drm/msm/dp: wait for audio notification before disabling clocks") Reviewed-by: Stephen Boyd Tested-by:

[PATCH] drm/vc4: hvs: Fix buffer overflow with the dlist handling

Commit 0a038c1c29a7 ("drm/vc4: Move LBM creation out of vc4_plane_mode_set()") changed the LBM allocation logic from first allocating the LBM memory for the plane to running mode_set, adding a gap in the LBM, and then running the dlist allocation filling that gap. The gap was introduced by

[PATCH] drm/i915: Remove unreachable code

By enabling -Wunreachable-code-aggressive on Clang the following code paths are unreachable. Commit ce22c320b8ca ("drm/i915/sdvo: convert to encoder disable/enable") Commit 19f1f627b333 ("drm/i915/gt: Move ivb GT workarounds from init_clock_gating to workarounds") Commit 0a97015d45ee ("drm/i915:

Re: [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

On 2021-01-20 10:48, Sai Prakash Ranjan wrote: On 2021-01-11 19:45, Sai Prakash Ranjan wrote: commit ecd7274fb4cd ("iommu: Remove unused IOMMU_SYS_CACHE_ONLY flag") removed unused IOMMU_SYS_CACHE_ONLY prot flag and along with it went the memory type setting required for the non-coherent masters

[PATCH v13 5/8] drm/mediatek: add has_dither private data for gamma

From: Yongqiang Niu Not all SoC has dither function in gamma module. Add private data to control this function setting. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 14 ++ 1 file changed, 10

[PATCH v13 8/8] drm/mediatek: add support for mediatek SOC MT8183

From: Yongqiang Niu 1. add ovl private data 2. add rdma private data 3. add gamma privte data 4. add main and external path module for crtc create Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 1 +

Re: [PATCH v5 00/21] Host1x sync point UAPI should not be used for tracking DRM jobs

28.01.2021 19:58, Thierry Reding пишет: > On Thu, Jan 28, 2021 at 01:08:54PM +0200, Mikko Perttunen wrote: >> On 1/27/21 11:20 PM, Dmitry Osipenko wrote: >>> 26.01.2021 05:45, Mikko Perttunen пишет: > 2. We will probably need a dedicated drm_tegra_submit_cmd for sync point > increments. 

Re: [PATCH 2/3] iommu/io-pgtable-arm: Add IOMMU_LLC page protection flag

On 2021-01-29 14:35, Will Deacon wrote: On Mon, Jan 11, 2021 at 07:45:04PM +0530, Sai Prakash Ranjan wrote: Add a new page protection flag IOMMU_LLC which can be used by non-coherent masters to set cacheable memory attributes for an outer level of cache called as last-level cache or system

[PATCH v13 1/8] arm64: dts: mt8183: rename rdma fifo size

From: Yongqiang Niu property name must include only lowercase and '-' Fixes: 91f9c963ce79 ("arm64: dts: mt8183: Add display nodes for MT8183") Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: Chun-Kuang Hu Reviewed-by: Enric Balletbo i Serra ---

[PATCH v13 2/8] arm64: dts: mt8183: refine gamma compatible name

From: Yongqiang Niu mt8183 gamma is different with mt8173 remove mt8173 compatible name for mt8183 gamma Fixes: 91f9c963ce79 ("arm64: dts: mt8183: Add display nodes for MT8183") Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: Enric Balletbo i Serra ---

[PATCH v13 0/8] drm/mediatek: add support for mediatek SOC MT8183

This series is based on kernel/git/chunkuang.hu/linux.git mediatek-drm-next The series is tested on a mt8183 krane device. Change since v12 - fix mtk_dither_config Change since v10, v11 - fix review comments in v9 Change since v9 - change several function to rebase to mediatek-drm-next Change

[PATCH] efifb: Ensure graphics device for efifb stays at PCI D0

We are seeing root ports on some desktop boards support D3cold for discrete graphics card. So when efifb is in use while graphics device isn't bound to a driver, PCI and ACPI will put the graphics to D3cold when runtime suspend kicks in, makes efifb stop working. So ensure the graphics device

Re: [PATCH v13 8/8] drm/mediatek: add support for mediatek SOC MT8183

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道： > > From: Yongqiang Niu > > 1. add ovl private data > 2. add rdma private data > 3. add gamma privte data > 4. add main and external path module for crtc create Applied to mediatek-drm-next [1], thanks. [1]

[Bug 211277] sometimes crash at s2ram-wake (Ryzen 3500U): amdgpu, drm, commit_tail, amdgpu_dm_atomic_commit_tail

https://bugzilla.kernel.org/show_bug.cgi?id=211277 --- Comment #7 from Jerome C (m...@jeromec.com) --- ok, you have it turned off already Weird thing happened this morning... I woke my laptop up and it was slow screen updates... I just closed my laptop lid, frustrated... I noticed it suspended

[Bug 211277] sometimes crash at s2ram-wake (Ryzen 3500U): amdgpu, drm, commit_tail, amdgpu_dm_atomic_commit_tail

https://bugzilla.kernel.org/show_bug.cgi?id=211277 --- Comment #6 from kolAflash (kolafl...@kolahilft.de) --- (In reply to Jerome C from comment #4) > [...] > Do you have kernel parameter set "init_on_free=1" or in your kernel config > "CONFIG_INIT_ON_FREE_DEFAULT_ON=y", [...] I'm using the

Re: [PATCH v13 5/8] drm/mediatek: add has_dither private data for gamma

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道： > > From: Yongqiang Niu > > Not all SoC has dither function in gamma module. > Add private data to control this function setting. Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v13 4/8] drm/mediatek: separate gamma module

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道： > > From: Yongqiang Niu > > mt8183 gamma module will different with mt8173 > separate gamma for add private data After I clean up all checkpatch error, applied to mediatek-drm-next [1]. Remember to clean up all checkpatch error before send

Re: [PATCH v13 3/8] drm/mediatek: add mtk_dither_set_common() function

Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道： > > Current implementation of mtk_dither_set() cast dev data to > struct mtk_ddp_comp_dev. But other devices with different dev data > would also call this function. > > Separate necessary parameters out so other device components (dither, >

Re: [PATCH] soc: mediatek: cmdq: Remove cmdq_pkt_flush()

Hi, Matthias: Chun-Kuang Hu 於 2021年1月10日 週日 上午6:59寫道： > > Hi, Matthias: > > Chun-Kuang Hu 於 2020年12月3日 週四 上午7:59寫道： > > > > rx_callback is a standard mailbox callback mechanism and could > > cover the function of proprietary cmdq_task_cb, so it is better > > to use the standard one instead of