Re: [PATCH v6 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-03-22 Thread Liu Ying
Hi Marcel, On Tue, 2021-03-23 at 00:38 +, Marcel Ziswiler wrote: > On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp display pixel link. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Liu Ying > > --- > > v5->v6: > > * No change. > > > > v

Re: [PATCH v6 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-03-22 Thread Liu Ying
Hi Marcel, On Tue, 2021-03-23 at 00:34 +, Marcel Ziswiler wrote: > On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp pixel combiner. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Liu Ying > > --- > > v5->v6: > > * No change. > > > > v4->v

Re: [PATCH] drm/msm/dp: Fixed couple of typos

2021-03-22 Thread Stephen Boyd
Quoting Bhaskar Chowdhury (2021-03-17 23:26:50) > s/modueles/modules/ two different places > > Signed-off-by: Bhaskar Chowdhury > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.or

Re: [PATCH v3 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

2021-03-22 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-17 17:20:43) > Hi Stephen, > > Reviving a bit of an old thread, for a question. > > On Mon, Nov 02, 2020 at 10:11:43AM -0800, Stephen Boyd wrote: > > @@ -265,6 +267,23 @@ connector_to_ti_sn_bridge(struct drm_connector > > *connector) > > static int ti_sn_bridge

[PATCH] drm/bridge/lontium-lt9611uxc: Convert sysfs sprintf/snprintf family to sysfs_emit

2021-03-22 Thread Tian Tao
Fix the following coccicheck warning: drivers/gpu//drm/bridge/lontium-lt9611uxc.c:858:8-16: WARNING: use scnprintf or sprintf Signed-off-by: Tian Tao --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/lontium-

Re: [PATCH v6 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-22 Thread Liu Ying
Hi Marcel, On Tue, 2021-03-23 at 00:23 +, Marcel Ziswiler wrote: > On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > > This patch adds RGB666_1X30_CPADLO, RGB888_1X30_CPADLO, RGB666_1X36_CPADLO > > and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp pixel combiner. > > The RGB pixels wit

[V2][PATCH] drm: xlnx: zynqmp: release reset to DP controller before accessing DP registers

2021-03-22 Thread quanyang . wang
From: Quanyang Wang When insmod zynqmp-dpsub.ko after rmmod it, system will hang with the error log as below: root@xilinx-zynqmp:~# insmod zynqmp-dpsub.ko [ 88.391289] [drm] Initialized zynqmp-dpsub 1.0.0 20130509 for fd4a.display on minor 0 [ 88.529906] Console: switching to colour fra

[PATCH] drm/etnaviv: Remove redundant NULL check

2021-03-22 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:622:2-8: WARNING: NULL check before some freeing functions is not needed. ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:618:2-8: WARNING: NULL check before some freeing functions is not needed. ./drivers/gpu/d

Re: [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume

2021-03-22 Thread Rob Clark
On Mon, Mar 22, 2021 at 5:44 PM Matthias Kaehlcke wrote: > > On Mon, Mar 22, 2021 at 02:17:12AM -0700, Kalyan Thota wrote: > > From: Kalyan Thota > > > > DPU runtime resume will request for a min vote on the AXI bus as > > it is a necessary step before turning ON the AXI clock. > > > > The change

[PATCH v3 0/3] drm/tilcdc: fix LCD pixel clock setting

2021-03-22 Thread Dario Binacchi
The series was born from a patch to fix the LCD pixel clock setting. Two additional patches have been added to this. One renames a misleading variable name that was probably the cause of the bug and the other fixes a warning message. Changes in v3: - Replace calculated with requested in the war

[PATCH v3 3/3] drm/tilcdc: fix pixel clock setting warning message

2021-03-22 Thread Dario Binacchi
The warning message did not printed the LCD pixel clock rate but the LCD clock divisor input rate. As a consequence, the required and real pixel clock rates are now passed to the tilcdc_pclk_diff(). Signed-off-by: Dario Binacchi --- Changes in v3: - Replace calculated with requested in the warn

[PATCH v3 1/3] drm/tilcdc: rename req_rate to pclk_rate

2021-03-22 Thread Dario Binacchi
The req_rate name is a little misleading, so let's rename to pclk_rate (pixel clock rate). Signed-off-by: Dario Binacchi --- (no changes since v2) Changes in v2: - The patch has been added in version 2. drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 12 ++-- 1 file changed, 6 insertions(+),

[PATCH v3 2/3] drm/tilcdc: fix LCD pixel clock setting

2021-03-22 Thread Dario Binacchi
The tilcdc_pclk_diff() compares the requested pixel clock rate to the real one, so passing it clk_rate instead of clk_rate / clkdiv caused it to fail even if the clk_rate was properly set. Adding the real_pclk_rate variable makes the code more readable. Signed-off-by: Dario Binacchi --- (no cha

[PATCH] gpu: drm: amd: Remove duplicate includes

2021-03-22 Thread Wan Jiabing
../hw_ddc.h, ../hw_gpio.h and ../hw_hpd.h have been included at line 32, so remove them. Signed-off-by: Wan Jiabing --- .../gpu/drm/amd/display/dc/gpio/dce110/hw_factory_dce110.c| 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/gpio/dce110/hw_factory_dce1

[PATCH] drm/i915: A typo fix

2021-03-22 Thread Bhaskar Chowdhury
s/nothign/nothing/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c index f6ad257a260e..14d784a6f

[PATCH] gpu: drm: amd: Remove duplicate include of dce110_resource.h

2021-03-22 Thread Wan Jiabing
dce110/dce110_resource.h has been included at line 58, so remove the duplicate include at line 64. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/driv

[PATCH 2/2] drm: rcar-du: Shutdown the display on remove

2021-03-22 Thread Laurent Pinchart
When the device is unbound from the driver (the DU being a platform device, this occurs either when removing the DU module, or when unbinding the device manually through sysfs), the display may be active. Make sure it gets shut down. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rc

[PATCH 1/2] drm: rcar-du: Don't put reference to drm_device in rcar_du_remove()

2021-03-22 Thread Laurent Pinchart
The reference to the drm_device that was acquired by devm_drm_dev_alloc() is released automatically by the devres infrastructure. It must not be released manually, as that causes a reference underflow.. Fixes: ea6aae151887 ("drm: rcar-du: Embed drm_device in rcar_du_device") Signed-off-by: Laurent

Re: [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume

2021-03-22 Thread Matthias Kaehlcke
On Mon, Mar 22, 2021 at 02:17:12AM -0700, Kalyan Thota wrote: > From: Kalyan Thota > > DPU runtime resume will request for a min vote on the AXI bus as > it is a necessary step before turning ON the AXI clock. > > The change does below > 1) Move the icc path set before requesting runtime get_syn

[PATCH] drm: rcar-du: Shutdown the display on system shutdown

2021-03-22 Thread Laurent Pinchart
When the system shuts down or warm reboots, the display may be active, with the hardware accessing system memory. Upon reboot, the DDR will not be accessible, which may cause issues. Implement the platform_driver .shutdown() operation and shut down the display to fix this. Signed-off-by: Laurent

Re: [PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2021-03-22 Thread Laurent Pinchart
Hi Stephen, On Mon, Nov 02, 2020 at 05:15:24PM -0800, Stephen Boyd wrote: > Quoting Sam Ravnborg (2020-11-01 09:37:41) > > Hi Stephen. > > > > On Thu, Oct 29, 2020 at 06:17:34PM -0700, Stephen Boyd wrote: > > > This patch series cleans up the DDC code a little bit so that > > > it is more efficie

Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Ingo Molnar
* Martin Sebor wrote: > > I.e. the real workaround might be to turn off the > > -Wstringop-overread-warning, > > until GCC-11 gets fixed? > > In GCC 10 -Wstringop-overread is a subset of -Wstringop-overflow. > GCC 11 breaks it out as a separate warning to make it easier to > control. Both wa

Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Arnd Bergmann
On Mon, Mar 22, 2021 at 11:09 PM Martin Sebor wrote: > On 3/22/21 2:29 PM, Ingo Molnar wrote: > > * Arnd Bergmann wrote: > > > > I.e. the real workaround might be to turn off the > > -Wstringop-overread-warning, > > until GCC-11 gets fixed? > > In GCC 10 -Wstringop-overread is a subset of -Wstri

Re: [PATCH] drm/amd: Fix a typo in two different sentences

2021-03-22 Thread Randy Dunlap
On 3/22/21 2:06 PM, Bhaskar Chowdhury wrote: > > s/defintion/definition/ .two different places. > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/amd/include/atombios.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers

Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Martin Sebor
On 3/22/21 2:29 PM, Ingo Molnar wrote: * Arnd Bergmann wrote: From: Arnd Bergmann gcc-11 warns about using string operations on pointers that are defined at compile time as offsets from a NULL pointer. Unfortunately that also happens on the result of fix_to_virt(), which is a compile-time c

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-22 Thread Ville Syrjälä
On Mon, Mar 22, 2021 at 10:28:06PM +0100, Hans de Goede wrote: > Hi, > > On 3/22/21 9:59 PM, Ville Syrjälä wrote: > > On Mon, Mar 22, 2021 at 04:51:47PM -0400, Rodrigo Vivi wrote: > >> On Fri, Mar 19, 2021 at 04:45:32PM +0100, Hans de Goede wrote: > >>> Hi, > >>> > >>> On 3/1/21 4:43 PM, Hans de G

Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Arnd Bergmann
On Mon, Mar 22, 2021 at 9:29 PM Ingo Molnar wrote: > * Arnd Bergmann wrote: > > From: Arnd Bergmann > This is indeed rather ugly - and the other patch that removes a debug > check seems counterproductive as well. > > Do we know how many genuine bugs -Wstringop-overread-warning has > caught or i

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-22 Thread Hans de Goede
Hi, On 3/22/21 9:59 PM, Ville Syrjälä wrote: > On Mon, Mar 22, 2021 at 04:51:47PM -0400, Rodrigo Vivi wrote: >> On Fri, Mar 19, 2021 at 04:45:32PM +0100, Hans de Goede wrote: >>> Hi, >>> >>> On 3/1/21 4:43 PM, Hans de Goede wrote: After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut

[PATCH] drm/amd: Fix a typo in two different sentences

2021-03-22 Thread Bhaskar Chowdhury
s/defintion/definition/ .two different places. Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/amd/include/atombios.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/include/atombios.h b/drivers/gpu/drm/amd/include/atombios.h index c1d7b1d0

[Bug 212397] New: Resume from suspend (S3) does not bring back video anymore

2021-03-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212397 Bug ID: 212397 Summary: Resume from suspend (S3) does not bring back video anymore Product: Drivers Version: 2.5 Kernel Version: 5.11.7 Hardware: All OS

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-22 Thread Ville Syrjälä
On Mon, Mar 22, 2021 at 04:51:47PM -0400, Rodrigo Vivi wrote: > On Fri, Mar 19, 2021 at 04:45:32PM +0100, Hans de Goede wrote: > > Hi, > > > > On 3/1/21 4:43 PM, Hans de Goede wrote: > > > After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down > > > displays gracefully on reboot"), the

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-22 Thread Rodrigo Vivi
On Fri, Mar 19, 2021 at 04:45:32PM +0100, Hans de Goede wrote: > Hi, > > On 3/1/21 4:43 PM, Hans de Goede wrote: > > After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down > > displays gracefully on reboot"), the DSI panel on a Cherry Trail based > > Predia Basic tablet would no longer

Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Ingo Molnar
* Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns about using string operations on pointers that are > defined at compile time as offsets from a NULL pointer. Unfortunately > that also happens on the result of fix_to_virt(), which is a > compile-time constant for a constantn input

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-22 Thread Michal Hocko
On Mon 22-03-21 14:05:48, Matthew Wilcox wrote: > On Mon, Mar 22, 2021 at 02:49:27PM +0100, Daniel Vetter wrote: > > On Sun, Mar 21, 2021 at 03:18:28PM +0100, Christian König wrote: > > > Am 20.03.21 um 14:17 schrieb Daniel Vetter: > > > > On Sat, Mar 20, 2021 at 10:04 AM Christian König > > > > w

Re: [PATCH] video: mmp: Few typo fixes

2021-03-22 Thread Randy Dunlap
On 3/22/21 6:02 AM, Bhaskar Chowdhury wrote: > > s/configed/configured/ > s/registed/registered/ > s/defintions/definitions/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > include/video/mmp_disp.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-22 Thread Christian König
Am 22.03.21 um 18:02 schrieb Daniel Vetter: On Mon, Mar 22, 2021 at 5:06 PM Michal Hocko wrote: On Mon 22-03-21 14:05:48, Matthew Wilcox wrote: On Mon, Mar 22, 2021 at 02:49:27PM +0100, Daniel Vetter wrote: On Sun, Mar 21, 2021 at 03:18:28PM +0100, Christian König wrote: Am 20.03.21 um 14:17

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

2021-03-22 Thread Jason Ekstrand
On Mon, Mar 22, 2021 at 11:59 AM Daniel Vetter wrote: > > On Fri, Mar 19, 2021 at 05:38:56PM -0500, Jason Ekstrand wrote: > > I'd love to delete the SINGLE_TIMELINE API because it leaks an > > implementation detail of contexts through to the API and is something > > that userspace can do itself, t

Re: [PATCH] drm/msm/dpu: Fix a typo

2021-03-22 Thread Randy Dunlap
On 3/21/21 11:27 PM, Bhaskar Chowdhury wrote: > > s/struture/structure/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_

Re: [PATCH] drm/msm/dpu: Fix a typo

2021-03-22 Thread Randy Dunlap
On 3/22/21 5:06 AM, Bhaskar Chowdhury wrote: > > s/poiner/pointer/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h >

[PATCH v4 2/2] drm/tiny: add driver for newhaven,1.8-128160EF

2021-03-22 Thread Daniel Mack
This patch adds support for Newhaven's NHD-1.8-128160EF display, featuring an Ilitek ILI9163 controller. Signed-off-by: Daniel Mack Acked-by: Daniel Vetter --- drivers/gpu/drm/tiny/Kconfig | 13 ++ drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/ili9163.c | 224 +

[PATCH v4 1/2] dt-bindings: display: add bindings for newhaven, 1.8-128160EF

2021-03-22 Thread Daniel Mack
This adds documentation for a new ILI9163 based, SPI connected display. Signed-off-by: Daniel Mack --- .../bindings/display/ilitek,ili9163.yaml | 70 +++ 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9163.yaml diff

[PATCH v4 0/2] gpu: drm: add driver for ili9361 panel

2021-03-22 Thread Daniel Mack
This is v3 of the series. Changelog: v2 -> v3: * Turn Documentation into yaml format v3 -> v4: * Fix reference error in yaml file Daniel Mack (2): dt-bindings: display: add bindings for newhaven,1.8-128160EF drm/tiny: add driver for newhaven,1.8-128160EF .../bindings/displ

Re: [PATCH v6 2/5] drm: rockchip: add sound support to rk3066 hdmi driver

2021-03-22 Thread Johan Jonker
ping On 12/6/20 2:33 PM, Johan Jonker wrote: > From: Zheng Yang > > Add sound support to the rk3066 HDMI driver. > > The I2S input of the HDMI TX allows transmission of > DVD-Audio and decoded Dolby Digital > to A/V Receivers and high-end displays. > The interface supports 2 to 8 channels audio

Re: [PATCH 03/11] security: commoncap: fix -Wstringop-overread warning

2021-03-22 Thread Christian Brauner
On Mon, Mar 22, 2021 at 05:02:41PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 introdces a harmless warning for cap_inode_getsecurity: > > security/commoncap.c: In function ‘cap_inode_getsecurity’: > security/commoncap.c:440:33: error: ‘memcpy’ reading 16 bytes from a region >

Re: [PATCH 1/2] vfio/pci: remove vfio_pci_nvlink2

2021-03-22 Thread Alex Williamson
On Mon, 22 Mar 2021 16:01:54 +0100 Christoph Hellwig wrote: > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > index 8ce36c1d53ca11..db7e782419d5d9 100644 > --- a/include/uapi/linux/vfio.h > +++ b/include/uapi/linux/vfio.h > @@ -332,19 +332,6 @@ struct vfio_region_info_cap_type

[PATCH 2/2] drm/gud: Remove unneeded semicolon

2021-03-22 Thread Noralf Trønnes
From: kernel test robot drivers/gpu/drm/gud/gud_connector.c:658:2-3: Unneeded semicolon drivers/gpu/drm/gud/gud_connector.c:186:2-3: Unneeded semicolon drivers/gpu/drm/gud/gud_drv.c:511:3-4: Unneeded semicolon drivers/gpu/drm/gud/gud_pipe.c:127:4-5: Unneeded semicolon Remove unneeded semicolon.

[PATCH 1/2] drm/gud: fix sizeof use

2021-03-22 Thread Noralf Trønnes
From: kernel test robot drivers/gpu/drm/gud/gud_connector.c:710:37-43: ERROR: application of sizeof to pointer sizeof when applied to a pointer typed expression gives the size of the pointer Generated by: scripts/coccinelle/misc/noderef.cocci Fixes: 40e1a70b4aed ("drm: Add GUD USB Display d

Re: [PATCH v3 1/2] dt-bindings: display: add bindings for newhaven, 1.8-128160EF

2021-03-22 Thread Rob Herring
On Mon, 22 Mar 2021 10:52:22 +0100, Daniel Mack wrote: > This adds documentation for a new ILI9163 based, SPI connected display. > > Signed-off-by: Daniel Mack > --- > .../bindings/display/ilitek,ili9163.yaml | 70 +++ > 1 file changed, 70 insertions(+) > create mode 100644

Re: [PATCH V5 1/2] backlight: qcom-wled: Fix FSC update issue for WLED5

2021-03-22 Thread Lee Jones
On Thu, 18 Mar 2021, Kiran Gunda wrote: > Currently, for WLED5, the FSC (Full scale current) setting is not > updated properly due to driver toggling the wrong register after > an FSC update. > > On WLED5 we should only toggle the MOD_SYNC bit after a brightness > update. For an FSC update we nee

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Restrict sentinel requests further

2021-03-22 Thread Matthew Auld
On Thu, 18 Mar 2021 at 17:04, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Disallow sentinel requests follow previous sentinels to make request > cancellation work better when faced with a chain of requests which have > all been marked as in error. Could you elaborate some more on why this

Re: [PATCH 00/44] Add HMM-based SVM memory manager to KFD v2

2021-03-22 Thread Daniel Vetter
On Mon, Mar 22, 2021 at 5:07 PM Felix Kuehling wrote: > > Am 2021-03-22 um 10:15 a.m. schrieb Daniel Vetter: > > On Mon, Mar 22, 2021 at 06:58:16AM -0400, Felix Kuehling wrote: > >> Since the last patch series I sent on Jan 6 a lot has changed. Patches 1-33 > >> are the cleaned up, rebased on amd-

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-22 Thread Daniel Vetter
On Mon, Mar 22, 2021 at 5:06 PM Michal Hocko wrote: > > On Mon 22-03-21 14:05:48, Matthew Wilcox wrote: > > On Mon, Mar 22, 2021 at 02:49:27PM +0100, Daniel Vetter wrote: > > > On Sun, Mar 21, 2021 at 03:18:28PM +0100, Christian König wrote: > > > > Am 20.03.21 um 14:17 schrieb Daniel Vetter: > >

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

2021-03-22 Thread Daniel Vetter
On Fri, Mar 19, 2021 at 05:38:56PM -0500, Jason Ekstrand wrote: > I'd love to delete the SINGLE_TIMELINE API because it leaks an > implementation detail of contexts through to the API and is something > that userspace can do itself, trivially. Unfortunately, it's used by > the media driver so we c

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

2021-03-22 Thread Daniel Vetter
On Mon, Mar 22, 2021 at 4:31 PM Tvrtko Ursulin wrote: > > > On 22/03/2021 14:57, Daniel Vetter wrote: > > On Mon, Mar 22, 2021 at 3:33 PM Tvrtko Ursulin > > wrote: > >> > >> > >> On 22/03/2021 14:09, Daniel Vetter wrote: > >>> On Mon, Mar 22, 2021 at 11:22:01AM +, Tvrtko Ursulin wrote: >

[PATCH] drm/omap: fix misleading indentation in pixinc()

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann An old patch added a 'return' statement after each BUG() in this driver, which was necessary at the time, but has become redundant after the BUG() definition was updated to handle this properly. gcc-11 now warns about one such instance, where the 'return' statement was incorr

[PATCH] backlight: journada720: fix Wmisleading-indentation warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann With gcc-11, we get a warning about code that looks correct but badly indented: drivers/video/backlight/jornada720_bl.c: In function ‘jornada_bl_update_status’: drivers/video/backlight/jornada720_bl.c:66:11: error: this ‘else’ clause does not guard... [-Werror=misleading-ind

[PATCH v5 07/10] drm: rcar-du: Provide for_each_group helper

2021-03-22 Thread Kieran Bingham
Refactoring of the group control code will soon require more iteration over the available groups. Simplify this process by introducing a group iteration helper. Reviewed-by: Ulrich Hecht Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- Changes since v2: - Don't assign __group

[PATCH v5 09/10] drm: rcar-du: Perform group setup from the atomic tail handler

2021-03-22 Thread Kieran Bingham
Create rcar_du_group_atomic_check() and rcar_du_group_atomic_setup() functions to track and apply group state through the DRM atomic state. The use_count field is moved from the rcar_du_group structure to an enabled field in the rcar_du_group_state structure. This allows separating group setup fro

[PATCH v5 10/10] drm: rcar-du: Centralise routing configuration in commit tail handler

2021-03-22 Thread Kieran Bingham
From: Laurent Pinchart Routing configuration for the DU is complex. Depending on the SoC generation various routing options are available: - The VSP to DU routing is not available on Gen1, is configurable on Gen2 and is fixed on Gen3. When configurable, the routing affects both CRTC groups b

[PATCH v5 06/10] drm: rcar-du: Handle CRTC configuration from commit tail handler

2021-03-22 Thread Kieran Bingham
The CRTC mode setting and routing configuration are performed at the earliest of atomic enable and atomic begin, to ensure that a valid configuration is applied to the hardware before the CRTC gets enabled and before planes are setup (the latter being required in particular by the VSP). This requir

[PATCH v5 08/10] drm: rcar-du: Create a group state object

2021-03-22 Thread Kieran Bingham
Create a new private state object for the DU groups, and move the initialisation of a group object to a new function rcar_du_group_init(). Reviewed-by: Ulrich Hecht Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- Changes since v3: - Rebase to v5.11 - Fix pointer passing for dr

[PATCH v5 04/10] media: vsp1: drm: Remove vsp1_du_setup_lif()

2021-03-22 Thread Kieran Bingham
The vsp1_du_setup_lif() function is deprecated, and the users have been removed. Remove the implementation and the associated configuration structure. Reviewed-by: Ulrich Hecht Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- drivers/media/platform/vsp1/vsp1_drm.c | 46 ---

[PATCH v5 05/10] drm: rcar-du: Handle CRTC standby from commit tail handler

2021-03-22 Thread Kieran Bingham
Manage the power state, and initial configuration of the CRTC from the commit tail handler. CRTCs which need to be activated are taken out of standby, and any deactivated CRTCs are put into standby. This aims at removing CRTC state tracking from the rcar_du_crtc structure. The initial configuratio

[PATCH v5 02/10] media: vsp1: drm: Don't configure hardware when the pipeline is disabled

2021-03-22 Thread Kieran Bingham
From: Laurent Pinchart The vsp1_du_atomic_flush() function calls vsp1_du_pipeline_configure() to configure the hardware pipeline. The function is currently guaranteed to be called with the pipeline enabled, but this will change by future rework of the DU driver. Guard the hardware configuration t

[PATCH v5 03/10] drm: rcar-du: Convert to the new VSP atomic API

2021-03-22 Thread Kieran Bingham
The configuration API between the VSP and the DU has been updated to provide finer grain control over modesetting, and enablement. Split rcar_du_vsp_enable() into rcar_du_vsp_modeset() and rcar_du_vsp_enable() accordingly, and update each function to use the new VSP API. There are no further user

[PATCH v5 01/10] media: vsp1: drm: Split vsp1_du_setup_lif()

2021-03-22 Thread Kieran Bingham
Break vsp1_du_setup_lif() into components more suited to the DRM Atomic API. The existing vsp1_du_setup_lif() API call is maintained as it is still used from the DU. Reviewed-by: Ulrich Hecht Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- Changes since v3: - Minor formatting

[PATCH v5 00/10] drm: rcar-du: Rework CRTC and groups for atomic commits

2021-03-22 Thread Kieran Bingham
This patch series refactors atomic commit tail handling in the R-Car DU driver to simplify the code flow, and open the door to further optimisations. This iteration rebases the previous work and fixes a bug reported by the build bots. The R-Car DU is a bit of a strange beast, with support for up t

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

2021-03-22 Thread Daniel Vetter
On Mon, Mar 22, 2021 at 5:01 PM Jason Ekstrand wrote: > > On Mon, Mar 22, 2021 at 7:01 AM Jani Nikula > wrote: > > > > On Sat, 20 Mar 2021, Jason Ekstrand wrote: > > > This reverts commit 88be76cdafc7e60e2e4ed883bfe7e8dd7f35fa3a. This > > > API > > > > Small nit, I think it would be usefu

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

2021-03-22 Thread Jason Ekstrand
Ugh... timezones. On Mon, Mar 22, 2021 at 10:31 AM Tvrtko Ursulin wrote: > > > On 22/03/2021 14:57, Daniel Vetter wrote: > > On Mon, Mar 22, 2021 at 3:33 PM Tvrtko Ursulin > > wrote: > >> > >> > >> On 22/03/2021 14:09, Daniel Vetter wrote: > >>> On Mon, Mar 22, 2021 at 11:22:01AM +, Tvrtko U

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

2021-03-22 Thread Daniel Thompson
On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > Signed-off-by: Konrad Dybcio Reviewed-by: Daniel Thompson Daniel. > --- > drivers/video/backlight/qcom-wled.c | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [PATCH 1/2] dt-bindings: leds: backlight: qcom-wled: Add PMI8994 compatible

2021-03-22 Thread Daniel Thompson
On Sun, Feb 28, 2021 at 01:41:04PM +0100, Konrad Dybcio wrote: > Document the newly added PMI8994 compatible. > > Signed-off-by: Konrad Dybcio (For Lee) Acked-by: Daniel Thompson Daniel. > --- > Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml | 1 + > 1 file changed, 1 inse

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

2021-03-22 Thread Jason Ekstrand
On Mon, Mar 22, 2021 at 7:28 AM Tvrtko Ursulin wrote: > > > On 19/03/2021 22:38, Jason Ekstrand wrote: > > I'd love to delete the SINGLE_TIMELINE API because it leaks an > > implementation detail of contexts through to the API and is something > > that userspace can do itself, trivially. Unfortun

Re: [PATCH 00/44] Add HMM-based SVM memory manager to KFD v2

2021-03-22 Thread Felix Kuehling
Am 2021-03-22 um 10:15 a.m. schrieb Daniel Vetter: > On Mon, Mar 22, 2021 at 06:58:16AM -0400, Felix Kuehling wrote: >> Since the last patch series I sent on Jan 6 a lot has changed. Patches 1-33 >> are the cleaned up, rebased on amd-staging-drm-next 5.11 version from about >> a week ago. The remai

[PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 warns that intel_dp_check_mst_status() has a local array of fourteen bytes and passes the last four bytes into a function that expects a six-byte array: drivers/gpu/drm/i915/display/intel_dp.c: In function ‘intel_dp_check_mst_status’: drivers/gpu/drm/i915/display/inte

[PATCH 10/11] drm/i915: avoid stringop-overread warning on pri_latency

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 warns about what appears to be an out-of-range array access: In function ‘snb_wm_latency_quirk’, inlined from ‘ilk_setup_wm_latency’ at drivers/gpu/drm/i915/intel_pm.c:3108:3: drivers/gpu/drm/i915/intel_pm.c:3057:9: error: ‘intel_print_wm_latency’ reading 16 byte

[PATCH 09/11] scsi: lpfc: fix gcc -Wstringop-overread warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 warns about an strnlen with a length larger than the size of the passed buffer: drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_nvme_info_show': drivers/scsi/lpfc/lpfc_attr.c:518:25: error: 'strnlen' specified bound 4095 exceeds source size 24 [-Werror=stringop-overr

[PATCH 08/11] atmel: avoid gcc -Wstringop-overflow warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 notices that the fields as defined in the ass_req_format structure do not match the actual use of that structure: cc1: error: writing 4 bytes into a region of size between 18446744073709551613 and 2 [-Werror=stringop-overflow=] drivers/net/wireless/atmel/atmel.c:2884:

[PATCH 07/11] ARM: sharpsl_param: work around -Wstringop-overread warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc warns that accessing a pointer based on a numeric constant may be an offset into a NULL pointer, and would therefore has zero accessible bytes: arch/arm/common/sharpsl_param.c: In function ‘sharpsl_save_param’: arch/arm/common/sharpsl_param.c:43:9: error: ‘memcpy’ reading

[PATCH 06/11] cgroup: fix -Wzero-length-bounds warnings

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann When cgroups are enabled, but every single subsystem is turned off, CGROUP_SUBSYS_COUNT is zero, and the cgrp->subsys[] array has no members. gcc-11 points out that this leads to an invalid access in any function that might access this array: kernel/cgroup/cgroup.c: In funct

[PATCH 05/11] qnx: avoid -Wstringop-overread warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 warns that the size of the link name is longer than the di_fname field: fs/qnx4/dir.c: In function ‘qnx4_readdir’: fs/qnx4/dir.c:51:32: error: ‘strnlen’ specified bound 48 exceeds source size 16 [-Werror=stringop-overread] 51 | size = strnle

[PATCH 04/11] ath11: Wstringop-overread warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 with the kernel address sanitizer prints a warning for this driver: In function 'ath11k_peer_assoc_h_vht', inlined from 'ath11k_peer_assoc_prepare' at drivers/net/wireless/ath/ath11k/mac.c:1632:2: drivers/net/wireless/ath/ath11k/mac.c:1164:13: error: 'ath11k_peer

[PATCH 03/11] security: commoncap: fix -Wstringop-overread warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 introdces a harmless warning for cap_inode_getsecurity: security/commoncap.c: In function ‘cap_inode_getsecurity’: security/commoncap.c:440:33: error: ‘memcpy’ reading 16 bytes from a region of size 0 [-Werror=stringop-overread] 440 |

[PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 warns about using string operations on pointers that are defined at compile time as offsets from a NULL pointer. Unfortunately that also happens on the result of fix_to_virt(), which is a compile-time constant for a constantn input: arch/x86/kernel/tboot.c: In function

[PATCH 01/11] x86: compressed: avoid gcc-11 -Wstringop-overread warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc gets confused by the comparison of a pointer to an integer listeral, with the assumption that this is an offset from a NULL pointer and that dereferencing it is invalid: In file included from arch/x86/boot/compressed/misc.c:18: In function ‘parse_elf’, inlined from ‘e

[PATCH 00/11] treewide: address gcc-11 -Wstringop-overread warnings

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann The coming gcc release introduces a new warning for string operations reading beyond the end of a fixed-length object. After testing randconfig kernels for a while, think I have patches for any such warnings that came up on x86, arm and arm64. Most of these warnings are false

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

2021-03-22 Thread Jason Ekstrand
On Mon, Mar 22, 2021 at 7:01 AM Jani Nikula wrote: > > On Sat, 20 Mar 2021, Jason Ekstrand wrote: > > This reverts commit 88be76cdafc7e60e2e4ed883bfe7e8dd7f35fa3a. This API > > Small nit, I think it would be useful to reference commits with the > citation style: > > 88be76cdafc7 ("drm/i915:

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-22 Thread Dmitry Osipenko
22.03.2021 18:19, Mikko Perttunen пишет: > On 22.3.2021 16.48, Dmitry Osipenko wrote: >> 22.03.2021 17:46, Thierry Reding пишет: >>> On Mon, Jan 11, 2021 at 02:59:59PM +0200, Mikko Perttunen wrote: To avoid false lockdep warnings, give each client lock a different lock class, passed from

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

2021-03-22 Thread Jason Ekstrand
On Mon, Mar 22, 2021 at 5:52 AM Matthew Auld wrote: > > On Sat, 20 Mar 2021 at 14:48, Jason Ekstrand wrote: > > > > On Fri, Mar 19, 2021 at 5:39 PM Jason Ekstrand wrote: > > > > > > This reverts commit 88be76cdafc7e60e2e4ed883bfe7e8dd7f35fa3a. This API > > > has never been used by any real user

Re: 16 bpc fixed point (RGBA16) framebuffer support for core and AMD.

2021-03-22 Thread Ville Syrjälä
On Fri, Mar 19, 2021 at 10:03:12PM +0100, Mario Kleiner wrote: > Hi, > > this patch series adds the fourcc's for 16 bit fixed point unorm > framebuffers to the core, and then an implementation for AMD gpu's > with DisplayCore. > > This is intended to allow for pageflipping to, and direct scanout

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Individual request cancellation

2021-03-22 Thread Matthew Auld
On Thu, 18 Mar 2021 at 17:04, Tvrtko Ursulin wrote: > > From: Chris Wilson > > Currently, we cancel outstanding requests within a context when the > context is closed. We may also want to cancel individual requests using > the same graceful preemption mechanism. > > v2 (Tvrtko): > * Cancel waite

Latest i915 / TTM repo?

2021-03-22 Thread Thomas Hellström
Hi, Dave! I was wondering whether you code share the latest status and location of your latest i915/TTM code? Thanks, Thomas ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drivers: gpu: Remove duplicate include of amdgpu_hdp.h

2021-03-22 Thread Wan Jiabing
amdgpu_hdp.h has been included at line 91, so remove the duplicate include. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index 49267eb64302..68836c2

[PATCH] drivers: gpu: Remove duplicate include of if000c.h

2021-03-22 Thread Wan Jiabing
nvif/if000c.h has been included at line 33, so remove the duplicate include at line 36. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/nouveau/nouveau_dmem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c index

[PATCH] drivers: gpu: priv.h is included twice

2021-03-22 Thread Wan Jiabing
priv.h has been included at line 22, so remove the duplicate include at line 24. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c b/drivers/gpu/drm/nouveau/nvkm/e

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

2021-03-22 Thread Tvrtko Ursulin
On 22/03/2021 14:57, Daniel Vetter wrote: On Mon, Mar 22, 2021 at 3:33 PM Tvrtko Ursulin wrote: On 22/03/2021 14:09, Daniel Vetter wrote: On Mon, Mar 22, 2021 at 11:22:01AM +, Tvrtko Ursulin wrote: On 19/03/2021 22:38, Jason Ekstrand wrote: This API allows one context to grab bits o

Re: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-22 Thread Steven Price
On 15/03/2021 05:23, Zhang, Jack (Jian) wrote: [AMD Public Use] Hi, Rob/Tomeu/Steven, Would you please help to review this patch for panfrost driver? Thanks, Jack Zhang -Original Message- From: Jack Zhang Sent: Monday, March 15, 2021 1:21 PM To: dri-devel@lists.freedesktop.org; amd-.

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-22 Thread Mikko Perttunen
On 22.3.2021 16.48, Dmitry Osipenko wrote: 22.03.2021 17:46, Thierry Reding пишет: On Mon, Jan 11, 2021 at 02:59:59PM +0200, Mikko Perttunen wrote: To avoid false lockdep warnings, give each client lock a different lock class, passed from the initialization site by macro. Signed-off-by: Mikko

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-22 Thread Mark Yacoub
"friendly ping" On Wed, Mar 10, 2021 at 11:14 AM Mark Yacoub wrote: > From: Mark Yacoub > > On initializing the framebuffer, call drm_any_plane_has_format to do a > check if the modifier is supported. drm_any_plane_has_format calls > dm_plane_format_mod_supported which is extended to validate t

Re: remove the nvlink2 pci_vfio subdriver

2021-03-22 Thread Greg Kroah-Hartman
On Mon, Mar 22, 2021 at 04:01:53PM +0100, Christoph Hellwig wrote: > Hi all, > > the nvlink2 vfio subdriver is a weird beast. It supports a hardware > feature without any open source component - what would normally be > the normal open source userspace that we require for kernel drivers, > althou

Re: [PATCH v4, 08/10] soc: mediatek: mmsys: add component RDMA4

2021-03-22 Thread Chun-Kuang Hu
Hi, Matthias: Yongqiang Niu 於 2021年1月5日 週二 上午11:07寫道: > > This patch add component RDMA4 > > Signed-off-by: Yongqiang Niu > Reviewed-by: Chun-Kuang Hu How do you think about this patch? One drm patch [1] depends on this patch. [1] https://patchwork.kernel.org/project/linux-mediatek/patch/202

  1   2   3   >