Re: [PATCH v3, 4/8] soc: mediatek: mmsys: add component OVL_2L2

2021-03-22 Thread Chun-Kuang Hu
Hi, Matthias: Chun-Kuang Hu 於 2020年12月29日 週二 下午11:23寫道: > > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月28日 週一 下午4:37寫道: > > > > This patch add component OVL_2L2 > > Reviewed-by: Chun-Kuang Hu How do you think about this patch? One drm patch [1] depends on this patch. [1]

Re: [PATCH 1/2] fbdev: omapfb: avoid -Wempty-body warning

2021-03-22 Thread Geert Uytterhoeven
On Mon, Mar 22, 2021 at 11:54 AM Arnd Bergmann wrote: > From: Arnd Bergmann > > Building with 'make W=1' shows a few harmless warnings: > > drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function > 'omapfb_calc_addr': > drivers/video/fbdev/omap2/omapfb/omapfb-main.c:823:56: error: suggest

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

2021-03-22 Thread Daniel Vetter
On Mon, Mar 22, 2021 at 3:33 PM Tvrtko Ursulin wrote: > > > On 22/03/2021 14:09, Daniel Vetter wrote: > > On Mon, Mar 22, 2021 at 11:22:01AM +, Tvrtko Ursulin wrote: > >> > >> On 19/03/2021 22:38, Jason Ekstrand wrote: > >>> This API allows one context to grab bits out of another context upon

Re: [PATCH] drm/amd/display: Set AMDGPU_DM_DEFAULT_MIN_BACKLIGHT to 0

2021-03-22 Thread Alex Deucher
On Sun, Mar 21, 2021 at 8:12 PM Evan Benn wrote: > > On Sat, Mar 20, 2021 at 8:36 AM Alex Deucher wrote: > > > > On Fri, Mar 19, 2021 at 5:31 PM Evan Benn wrote: > > > > > > On Sat, 20 Mar 2021 at 02:10, Harry Wentland > > > wrote: > > > > On 2021-03-19 10:22 a.m., Alex Deucher wrote: > > > >

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-22 Thread Dmitry Osipenko
22.03.2021 17:46, Thierry Reding пишет: > On Mon, Jan 11, 2021 at 02:59:59PM +0200, Mikko Perttunen wrote: >> To avoid false lockdep warnings, give each client lock a different >> lock class, passed from the initialization site by macro. >> >> Signed-off-by: Mikko Perttunen >> --- >>

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-22 Thread Thierry Reding
On Mon, Jan 11, 2021 at 02:59:59PM +0200, Mikko Perttunen wrote: > To avoid false lockdep warnings, give each client lock a different > lock class, passed from the initialization site by macro. > > Signed-off-by: Mikko Perttunen > --- > drivers/gpu/host1x/bus.c | 7 --- >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

2021-03-22 Thread Tvrtko Ursulin
On 22/03/2021 14:09, Daniel Vetter wrote: On Mon, Mar 22, 2021 at 11:22:01AM +, Tvrtko Ursulin wrote: On 19/03/2021 22:38, Jason Ekstrand wrote: This API allows one context to grab bits out of another context upon creation. It can be used as a short-cut for setparam(getparam()) for

Re: [PATCH 1/2] dt-bindings: backlight: Add Kinetic KTD259 bindings

2021-03-22 Thread Lee Jones
On Sun, 21 Mar 2021, Linus Walleij wrote: > The KTD259 is just a newer version of the KTD253 and works > all the same. > > Signed-off-by: Linus Walleij > --- > .../bindings/leds/backlight/kinetic,ktd253.yaml | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Applied,

Re: [PATCH 2/2] backlight: ktd253: Support KTD259

2021-03-22 Thread Lee Jones
On Sun, 21 Mar 2021, Linus Walleij wrote: > The KTD259 works just like KTD253 so add this compatible > to the driver. > > Signed-off-by: Linus Walleij > --- > drivers/video/backlight/ktd253-backlight.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. -- Lee Jones [李琼斯] Senior

Re: [PATCH][next] drm/amd/display: Fix sizeof arguments in bw_calcs_init()

2021-03-22 Thread Gustavo A. R. Silva
On 3/22/21 09:04, Chen, Guchun wrote: > [AMD Public Use] > > Thanks for your patch, Silva. The issue has been fixed by " a5c6007e20e1 > drm/amd/display: fix modprobe failure on vega series". Great. :) Good to know this is already fixed. Thanks! -- Gustavo

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-22 Thread Daniel Vetter
On Mon, Mar 22, 2021 at 02:05:48PM +, Matthew Wilcox wrote: > On Mon, Mar 22, 2021 at 02:49:27PM +0100, Daniel Vetter wrote: > > On Sun, Mar 21, 2021 at 03:18:28PM +0100, Christian König wrote: > > > Am 20.03.21 um 14:17 schrieb Daniel Vetter: > > > > On Sat, Mar 20, 2021 at 10:04 AM Christian

Re: [PATCH 00/44] Add HMM-based SVM memory manager to KFD v2

2021-03-22 Thread Daniel Vetter
On Mon, Mar 22, 2021 at 06:58:16AM -0400, Felix Kuehling wrote: > Since the last patch series I sent on Jan 6 a lot has changed. Patches 1-33 > are the cleaned up, rebased on amd-staging-drm-next 5.11 version from about > a week ago. The remaining 11 patches are current work-in-progress with >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

2021-03-22 Thread Daniel Vetter
On Mon, Mar 22, 2021 at 11:22:01AM +, Tvrtko Ursulin wrote: > > On 19/03/2021 22:38, Jason Ekstrand wrote: > > This API allows one context to grab bits out of another context upon > > creation. It can be used as a short-cut for setparam(getparam()) for > > things like I915_CONTEXT_PARAM_VM.

Re: [PATCH] amdgpu: avoid incorrect %hu format string

2021-03-22 Thread Tom Rix
On 3/22/21 4:54 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang points out that the %hu format string does not match the type > of the variables here: > > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:263:7: warning: format specifies type > 'unsigned short' but the argument has type

Re: [PATCH 1/2] dt-bindings: backlight: Add Kinetic KTD259 bindings

2021-03-22 Thread Daniel Thompson
On Sun, Mar 21, 2021 at 12:43:40PM +0100, Linus Walleij wrote: > The KTD259 is just a newer version of the KTD253 and works > all the same. > > Signed-off-by: Linus Walleij (For Lee) Acked-by: Daniel Thompson Daniel. > --- > .../bindings/leds/backlight/kinetic,ktd253.yaml | 9

Re: [PATCH 2/2] backlight: ktd253: Support KTD259

2021-03-22 Thread Daniel Thompson
On Sun, Mar 21, 2021 at 12:43:41PM +0100, Linus Walleij wrote: > The KTD259 works just like KTD253 so add this compatible > to the driver. > > Signed-off-by: Linus Walleij Oh no... there's more of them ;-) . Reviewed-by: Daniel Thompson Daniel. > --- >

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-22 Thread Matthew Wilcox
On Mon, Mar 22, 2021 at 02:49:27PM +0100, Daniel Vetter wrote: > On Sun, Mar 21, 2021 at 03:18:28PM +0100, Christian König wrote: > > Am 20.03.21 um 14:17 schrieb Daniel Vetter: > > > On Sat, Mar 20, 2021 at 10:04 AM Christian König > > > wrote: > > > > Am 19.03.21 um 20:06 schrieb Daniel Vetter:

RE: [PATCH][next] drm/amd/display: Fix sizeof arguments in bw_calcs_init()

2021-03-22 Thread Chen, Guchun
[AMD Public Use] Thanks for your patch, Silva. The issue has been fixed by " a5c6007e20e1 drm/amd/display: fix modprobe failure on vega series". Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Gustavo A. R. Silva Sent: Monday, March 22, 2021 8:51 PM To: Lee Jones ;

[PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge

2021-03-22 Thread Jagan Teki
Replace of_drm_find_panel with drm_of_find_panel_or_bridge for finding panel, this indeed help to find the bridge if bridge support added. Added NULL in bridge argument, same will replace with bridge parameter once bridge supported. Signed-off-by: Jagan Teki --- Changes for v4, v3: - none

[PATCH v4 3/4] drm: sun4i: dsi: Convert to bridge driver

2021-03-22 Thread Jagan Teki
DRM bridge drivers have build-in handling of treating all display pipeline components as bridges. So, convert the existing to a drm bridge driver with a built-in encoder support for compatibility with existing component drivers. Signed-off-by: Jagan Teki --- Changes for v4: - none Changes for

[DO NOT MERGE] [PATCH v4 4/4] ARM: dts: sun8i: bananapi-m2m: Enable S070WV20-CT16 panel

2021-03-22 Thread Jagan Teki
This patch add support for Bananapi S070WV20-CT16 panel to BPI-M2M board. Bananapi S070WV20-CT16 is a pure RGB output panel with ICN6211 DSI/RGB converter bridge, so enable bridge along with associated panel. DSI panel connected via board DSI port with, - DCDC1 as VCC-DSI supply - PL5 gpio for

[PATCH v4 0/4] drm: sun4i: dsi: Convert drm bridge

2021-03-22 Thread Jagan Teki
This series convert Allwinner DSI controller to full functional drm bridge driver for supporting slave panel, bridges. Here, are the previous version changes[1]. Patch 1: use drm_of_find_panel_or_bridge API Patch 2: Adding DRM Bridge support Patch 3: Convert to bridge driver, that indeed drop

[PATCH v4 2/4] drm: sun4i: dsi: Add bridge support

2021-03-22 Thread Jagan Teki
Some display panels would come up with a non-DSI output which can have an option to connect DSI interface by means of bridge converter. This DSI to non-DSI bridge converter would require a bridge driver that would communicate the DSI controller for bridge functionalities. So, add support for

Re: [PATCH 2/2] vgaarb: avoid -Wempty-body warnings

2021-03-22 Thread Daniel Vetter
On Mon, Mar 22, 2021 at 11:53:00AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Building with W=1 shows a few warnings for an empty macro: > > drivers/gpu/drm/qxl/qxl_drv.c: In function 'qxl_pci_probe': > drivers/gpu/drm/qxl/qxl_drv.c:131:50: error: suggest braces around empty body >

Re: [PATCH V2] drm/amdgpu: Fix a typo

2021-03-22 Thread Alex Deucher
On Sat, Mar 20, 2021 at 3:52 AM Randy Dunlap wrote: > > > > On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote: > > > s/traing/training/ > > > > ...Plus the entire sentence construction for better readability. > > > > Signed-off-by: Bhaskar Chowdhury > > --- > > Changes from V1: > > Alex and Randy's

Re: [PATCH] drm/sysfs: Convert sysfs sprintf/snprintf family to sysfs_emit

2021-03-22 Thread Daniel Vetter
On Mon, Mar 22, 2021 at 09:19:38AM +0800, Tian Tao wrote: > Fix the following coccicheck warning: > drivers/gpu/drm/drm_sysfs.c:172:8-16: WARNING: use scnprintf or sprintf > drivers/gpu/drm/drm_sysfs.c:185:8-16: WARNING: use scnprintf or sprintf > drivers/gpu/drm/drm_sysfs.c:159:8-16: WARNING: use

Re: [PATCH] drm/fourcc: add Vivante TS modifiers

2021-03-22 Thread Daniel Vetter
On Mon, Mar 22, 2021 at 10:20:45AM +0100, Lucas Stach wrote: > Hi Christian, > > Am Montag, dem 22.03.2021 um 09:54 +0100 schrieb Christian Gmeiner: > > Am Sa., 20. März 2021 um 20:11 Uhr schrieb Daniel Vetter : > > > > > > On Sat, Mar 20, 2021 at 10:28 AM Christian Gmeiner > > > wrote: > > > >

[PATCH][next] drm/amd/display: Fix sizeof arguments in bw_calcs_init()

2021-03-22 Thread Gustavo A. R. Silva
The wrong sizeof values are currently being used as arguments to kzalloc(). Fix this by using the right arguments *dceip and *vbios, correspondingly. Addresses-Coverity-ID: 1502901 ("Wrong sizeof argument") Fixes: fca1e079055e ("drm/amd/display/dc/calcs/dce_calcs: Remove some large variables

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-22 Thread Daniel Vetter
On Sun, Mar 21, 2021 at 03:18:28PM +0100, Christian König wrote: > Am 20.03.21 um 14:17 schrieb Daniel Vetter: > > On Sat, Mar 20, 2021 at 10:04 AM Christian König > > wrote: > > > Am 19.03.21 um 20:06 schrieb Daniel Vetter: > > > > On Fri, Mar 19, 2021 at 07:53:48PM +0100, Christian König wrote:

Re: ✗ Fi.CI.IGT: failure for Default request/fence expiry + watchdog (rev3)

2021-03-22 Thread Daniel Vetter
On Mon, Mar 22, 2021 at 01:37:58PM +, Tvrtko Ursulin wrote: > > On 19/03/2021 01:17, Patchwork wrote: > > Okay with 20s default expiration the hangcheck tests on Tigerlake pass and > we are left with these failures: > > > IGT changes > > > > > > Possible regressions > > > >

Re: ✗ Fi.CI.IGT: failure for Default request/fence expiry + watchdog (rev3)

2021-03-22 Thread Tvrtko Ursulin
On 19/03/2021 01:17, Patchwork wrote: Okay with 20s default expiration the hangcheck tests on Tigerlake pass and we are left with these failures: IGT changes Possible regressions * igt@gem_ctx_ringsize@idle@bcs0: o shard-skl: PASS

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure v2

2021-03-22 Thread Daniel Vetter
On Mon, Mar 22, 2021 at 12:22 PM Christian König wrote: > > Don't print a warning when we fail to allocate a page for swapping things out. > > v2: only stop the warning > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter It is kinda surprising that page allocator warns here even

Re: [PATCH 29/44] drm/amdgpu: reserve fence slot to update page table

2021-03-22 Thread Christian König
Am 22.03.21 um 11:58 schrieb Felix Kuehling: From: Philip Yang Forgot to reserve a fence slot to use sdma to update page table, cause below kernel BUG backtrace to handle vm retry fault while application is exiting. [ 133.048143] kernel BUG at

[PATCH v3 4/6] drm/i915: Request watchdog infrastructure

2021-03-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Prepares the plumbing for setting request/fence expiration time. All code is put in place but is never activeted due yet missing ability to actually configure the timer. Outline of the basic operation: A timer is started when request is ready for execution. If the request

[PATCH] video: mmp: Few typo fixes

2021-03-22 Thread Bhaskar Chowdhury
s/configed/configured/ s/registed/registered/ s/defintions/definitions/ Signed-off-by: Bhaskar Chowdhury --- include/video/mmp_disp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/video/mmp_disp.h b/include/video/mmp_disp.h index 77252cb46361..ea8b4331b7a1

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

2021-03-22 Thread Tvrtko Ursulin
On 19/03/2021 22:38, Jason Ekstrand wrote: I'd love to delete the SINGLE_TIMELINE API because it leaks an implementation detail of contexts through to the API and is something that userspace can do itself, trivially. Unfortunately, it's used by the media driver so we can't do that. We can,

Re: [PATCH] drivers: gpu: Remove duplicate include of amdgpu_hdp.h

2021-03-22 Thread Christian König
Am 22.03.21 um 13:02 schrieb Wan Jiabing: amdgpu_hdp.h has been included at line 91, so remove the duplicate include. Signed-off-by: Wan Jiabing Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] drm/msm/dpu: Fix a typo

2021-03-22 Thread Bhaskar Chowdhury
s/poiner/pointer/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h index d6717d6672f7..a448eb039334 100644 ---

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

2021-03-22 Thread Jani Nikula
On Sat, 20 Mar 2021, Jason Ekstrand wrote: > This reverts commit 88be76cdafc7e60e2e4ed883bfe7e8dd7f35fa3a. This API Small nit, I think it would be useful to reference commits with the citation style: 88be76cdafc7 ("drm/i915: Allow userspace to specify ringsize on construction") I use this

Re: [PATCH] amdgpu: avoid incorrect %hu format string

2021-03-22 Thread Christian König
Am 22.03.21 um 12:54 schrieb Arnd Bergmann: From: Arnd Bergmann clang points out that the %hu format string does not match the type of the variables here: drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:263:7: warning: format specifies type 'unsigned short' but the argument has type 'unsigned int'

[PATCH] amdgpu: avoid incorrect %hu format string

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann clang points out that the %hu format string does not match the type of the variables here: drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:263:7: warning: format specifies type 'unsigned short' but the argument has type 'unsigned int' [-Wformat]

Re: [PATCH] drm/fourcc: add Vivante TS modifiers

2021-03-22 Thread Lucas Stach
Hi Simon, Am Freitag, dem 19.03.2021 um 19:52 + schrieb Simon Ser: > On Friday, March 19th, 2021 at 8:06 PM, Lucas Stach > wrote: > > > +/* > > + * Vivante TS (tile-status) buffer modifiers. They can be combined with > > all of > > + * the color buffer tiling modifiers defined above. When

[PATCH] drm/ttm: stop warning on TT shrinker failure v2

2021-03-22 Thread Christian König
Don't print a warning when we fail to allocate a page for swapping things out. v2: only stop the warning Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_tt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

2021-03-22 Thread Tvrtko Ursulin
On 19/03/2021 22:38, Jason Ekstrand wrote: This API allows one context to grab bits out of another context upon creation. It can be used as a short-cut for setparam(getparam()) for things like I915_CONTEXT_PARAM_VM. However, it's never been used by any real userspace. It's used by a few IGT

[PATCH 34/44] drm/amdkfd: Fix dma unmapping

2021-03-22 Thread Felix Kuehling
Don't dma_unmap in unmap_from_gpu. The dma_addr arrays are protected by the migrate_mutex, which we cannot hold when unmapping in MMU notifiers. Instead dma_unmap and free dma_addr arrays whenever the pages_array is invalidated: when migrating to VRAM and when re-validating RAM. Freeing dma_addr

[PATCH 44/44] drm/amdkfd: Nested locking and invalidation of child ranges

2021-03-22 Thread Felix Kuehling
This allows validation of child ranges, so the GPU page fault handler can be more light-weight. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 8 + drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 40 +--- 2 files changed, 37 insertions(+), 11

[PATCH 33/44] drm/amdkfd: Add SVM API support capability bits

2021-03-22 Thread Felix Kuehling
From: Philip Yang SVMAPISupported property added to HSA_CAPABILITY, the value match HSA_CAPABILITY defined in Thunk spec: SVMAPISupported: it will not be supported on older kernels that don't have HMM or on systems with GFXv8 or older GPUs without support for 48-bit virtual addresses.

[PATCH 43/44] drm/amdkfd: Correct locking during migration and mapping

2021-03-22 Thread Felix Kuehling
This fixes potential race conditions between any code that validates and maps SVM ranges and MMU notifiers. The whole sequence is encapsulated in svm_range_validate_and_map. The page_addr and hmm_range structures are not useful outside that function, so they were removed from struct svm_range.

[PATCH 35/44] drm/amdkfd: Call mutex_destroy

2021-03-22 Thread Felix Kuehling
Destroy SVM-related mutexes correctly. Change-Id: I85da30b1b0dce72433e6d3b507cb0b55b83b433c Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c

[PATCH 32/44] drm/amdkfd: multiple gpu migrate vram to vram

2021-03-22 Thread Felix Kuehling
If prefetch range to gpu with acutal location is another gpu, or GPU retry fault restore pages to migrate the range with acutal location is gpu, then migrate from one gpu to another gpu. Use system memory as bridge because sdma engine may not able to access another gpu vram, use sdma of source

[PATCH 39/44] drm/amdkfd: Point out several race conditions

2021-03-22 Thread Felix Kuehling
There are several race conditions with XNACK enabled. For now just some FIXME comments with ideas how to fix it. Change-Id: If0abab6dcb8f4e95c9d8820f6c569263eda29a89 Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 5 + drivers/gpu/drm/amd/amdkfd/kfd_svm.c |

[PATCH 42/44] drm/amdkfd: Allow invalid pages in migration.src

2021-03-22 Thread Felix Kuehling
This can happen when syste memory page were never allocated. Skip them during the migration. 0-initialize the BO. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 50 ++-- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git

[PATCH 38/44] drm/amdkfd: Simplify split_by_granularity

2021-03-22 Thread Felix Kuehling
svm_range_split_by_granularity always added the parent range and only the parent range to the update list for the caller to add it to the deferred work list. So just do that in the caller unconditionally and eliminate the update_list parameter. Split the range so that the original prange is

[PATCH 41/44] drm/amdkfd: Remove broken deferred mapping

2021-03-22 Thread Felix Kuehling
Mapping without validation is broken. Also removed saving the pages from the last migration. They may be invalidated without an MMU notifier to catch it, so let the next proper validation take care of it. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 14

[PATCH 40/44] drm/amdkfd: Return pdd from kfd_process_device_from_gduid

2021-03-22 Thread Felix Kuehling
This saves callers from looking up the pdd with a linear search later. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 8 +++- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 10 - drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 51 +++- 3 files

[PATCH 36/44] drm/amdkfd: Fix spurious restore failures

2021-03-22 Thread Felix Kuehling
Restore can appear to fail if the svms->evicted counter changes before the function can acquire the necessary locks. Re-read the counter after acquiring the lock to minimize the chances of having to reschedule the worker. Change-Id: I236b912bddf106583be264abde2f6bd1a5d5a083 Signed-off-by: Felix

[PATCH 37/44] drm/amdkfd: Fix svm_bo_list locking in eviction worker

2021-03-22 Thread Felix Kuehling
Take the svm_bo_list spin lock when iterating of the range list during eviction. Change-Id: I979d959e06c32e114cea8d151933b8ee7455627e Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git

[PATCH 31/44] drm/amdkfd: add svm range validate timestamp

2021-03-22 Thread Felix Kuehling
With xnack on, add validate timestamp in order to handle GPU vm fault from multiple GPUs. If GPU retry fault need migrate the range to the best restore location, use range validate timestamp to record system timestamp after range is restored to update GPU page table. Because multiple pages of

[PATCH 30/44] drm/amdkfd: refine migration policy with xnack on

2021-03-22 Thread Felix Kuehling
With xnack on, GPU vm fault handler decide the best restore location, then migrate range to the best restore location and update GPU mapping to recover the GPU vm fault. Signed-off-by: Philip Yang Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling ---

[PATCH 22/44] drm/amdkfd: page table restore through svm API

2021-03-22 Thread Felix Kuehling
Page table restore implementation in SVM API. This is called from the fault handler at amdgpu_vm. To update page tables through the page fault retry IH. Signed-off-by: Alex Sierra Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 69

[PATCH 19/44] drm/amdkfd: HMM migrate vram to ram

2021-03-22 Thread Felix Kuehling
If CPU page fault happens, HMM pgmap_ops callback migrate_to_ram start migrate memory from vram to ram in steps: 1. migrate_vma_pages get vram pages, and notify HMM to invalidate the pages, HMM interval notifier callback evict process queues 2. Allocate system memory pages 3. Use svm copy memory

[PATCH 11/44] drm/amdkfd: svm range eviction and restore

2021-03-22 Thread Felix Kuehling
HMM interval notifier callback notify CPU page table will be updated, stop process queues if the updated address belongs to svm range registered in process svms objects tree. Scheduled restore work to update GPU page table using new pages address in the updated svm range. The restore worker

[PATCH 29/44] drm/amdgpu: reserve fence slot to update page table

2021-03-22 Thread Felix Kuehling
From: Philip Yang Forgot to reserve a fence slot to use sdma to update page table, cause below kernel BUG backtrace to handle vm retry fault while application is exiting. [ 133.048143] kernel BUG at /home/yangp/git/compute_staging/kernel/drivers/dma-buf/dma-resv.c:281! [ 133.048487]

[PATCH 28/44] drm/amdgpu: add svm_bo eviction to enable_signal cb

2021-03-22 Thread Felix Kuehling
From: Alex Sierra Add to amdgpu_amdkfd_fence.enable_signal callback, support for svm_bo fence eviction. Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH 25/44] drm/amdgpu: add param bit flag to create SVM BOs

2021-03-22 Thread Felix Kuehling
From: Alex Sierra Add CREATE_SVM_BO define bit for SVM BOs. Another define flag was moved to concentrate these KFD type flags in one include file. Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 7 ++-

[PATCH 20/44] drm/amdkfd: invalidate tables on page retry fault

2021-03-22 Thread Felix Kuehling
GPU page tables are invalidated by unmapping prange directly at the mmu notifier, when page fault retry is enabled through amdgpu_noretry global parameter. The restore page table is performed at the page fault handler. If xnack is on, we update GPU mappings after migration to avoid unnecessary

[PATCH 24/44] drm/amdkfd: add svm_bo reference for eviction fence

2021-03-22 Thread Felix Kuehling
From: Alex Sierra [why] As part of the SVM functionality, the eviction mechanism used for SVM_BOs is different. This mechanism uses one eviction fence per prange, instead of one fence per kfd_process. [how] A svm_bo reference to amdgpu_amdkfd_fence to allow differentiate between SVM_BO or

[PATCH 27/44] drm/amdgpu: svm bo enable_signal call condition

2021-03-22 Thread Felix Kuehling
From: Alex Sierra [why] To support svm bo eviction mechanism. [how] If the BO crated has AMDGPU_AMDKFD_CREATE_SVM_BO flag set, enable_signal callback will be called inside amdgpu_evict_flags. This also causes gutting of the BO by removing all placements, so that TTM won't actually do an

[PATCH 16/44] drm/amdkfd: support xgmi same hive mapping

2021-03-22 Thread Felix Kuehling
From: Philip Yang amdgpu_gmc_get_vm_pte use bo_va->is_xgmi same hive information to set pte flags to update GPU mapping. Add local structure variable bo_va, and update bo_va.is_xgmi, pass it to mapping->bo_va while mapping to GPU. Assuming xgmi pstate is hi after boot. Signed-off-by: Philip

[PATCH 26/44] drm/amdkfd: add svm_bo eviction mechanism support

2021-03-22 Thread Felix Kuehling
svm_bo eviction mechanism is different from regular BOs. Every SVM_BO created contains one eviction fence and one worker item for eviction process. SVM_BOs can be attached to one or more pranges. For SVM_BO eviction mechanism, TTM will start to call enable_signal callback for every SVM_BO until

[PATCH 14/44] drm/amdkfd: register HMM device private zone

2021-03-22 Thread Felix Kuehling
From: Philip Yang Register vram memory as MEMORY_DEVICE_PRIVATE type resource, to allocate vram backing pages for page migration. Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 4 + drivers/gpu/drm/amd/amdkfd/Kconfig | 1

[PATCH 21/44] drm/amdgpu: enable 48-bit IH timestamp counter

2021-03-22 Thread Felix Kuehling
From: Alex Sierra By default this timestamp is 32 bit counter. It gets overflowed in around 10 minutes. Change-Id: I7c46604b0272dcfd1ce24351437c16fe53dca0ab Signed-off-by: Alex Sierra Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 1 + 1 file changed, 1 insertion(+)

[PATCH 18/44] drm/amdkfd: HMM migrate ram to vram

2021-03-22 Thread Felix Kuehling
Register svm range with same address and size but perferred_location is changed from CPU to GPU or from GPU to CPU, trigger migration the svm range from ram to vram or from vram to ram. If svm range prefetch location is GPU with flags KFD_IOCTL_SVM_FLAG_HOST_ACCESS, validate the svm range on ram

[PATCH 23/44] drm/amdkfd: SVM API call to restore page tables

2021-03-22 Thread Felix Kuehling
From: Alex Sierra Use SVM API to restore page tables when retry fault and compute context are enabled. Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git

[PATCH 02/44] drm/amdkfd: helper to convert gpu id and idx

2021-03-22 Thread Felix Kuehling
From: Alex Sierra svm range uses gpu bitmap to store which GPU svm range maps to. Application pass driver gpu id to specify GPU, the helper is needed to convert gpu id to gpu bitmap idx. Access through kfd_process_device pointers array from kfd_process. Signed-off-by: Alex Sierra

[PATCH 13/44] drm/amdkfd: add ioctl to configure and query xnack retries

2021-03-22 Thread Felix Kuehling
From: Alex Sierra Xnack retries are used for page fault recovery. Some AMD chip families support continuously retry while page table entries are invalid. The driver must handle the page fault interrupt and fill in a valid entry for the GPU to continue. This ioctl allows to enable/disable XNACK

[PATCH 15/44] drm/amdkfd: validate vram svm range from TTM

2021-03-22 Thread Felix Kuehling
If svm range perfetch location is not zero, use TTM to alloc amdgpu_bo vram nodes to validate svm range, then map vram nodes to GPUs. Use offset to sub allocate from the same amdgpu_bo to handle overlap vram range while adding new range or unmapping range. svm_bo has ref count to trace the

[PATCH 03/44] drm/amdkfd: add svm ioctl API

2021-03-22 Thread Felix Kuehling
From: Philip Yang Add svm (shared virtual memory) ioctl data structure and API definition. The svm ioctl API is designed to be extensible in the future. All operations are provided by a single IOCTL to preserve ioctl number space. The arguments structure ends with a variable size array of

[PATCH 05/44] drm/amdkfd: add svm ioctl GET_ATTR op

2021-03-22 Thread Felix Kuehling
From: Philip Yang Get the intersection of attributes over all memory in the given range Signed-off-by: Philip Yang Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 164 +++ 1 file changed, 164 insertions(+) diff

[PATCH 17/44] drm/amdkfd: copy memory through gart table

2021-03-22 Thread Felix Kuehling
From: Philip Yang Use sdma linear copy to migrate data between ram and vram. The sdma linear copy command uses kernel buffer function queue to access system memory through gart table. Use reserved gart table window 0 to map system page address, and vram page address is direct mapping. Use the

[PATCH 09/44] drm/amdgpu: export vm update mapping interface

2021-03-22 Thread Felix Kuehling
From: Philip Yang It will be used by kfd to map svm range to GPU, because svm range does not have amdgpu_bo and bo_va, cannot use amdgpu_bo_update interface, use amdgpu vm update interface directly. Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling ---

[PATCH 08/44] drm/amdkfd: deregister svm range

2021-03-22 Thread Felix Kuehling
From: Philip Yang When application explicitly call unmap or unmap from mmput when application exit, driver will receive MMU_NOTIFY_UNMAP event to remove svm range from process svms object tree and list first, unmap from GPUs (in the following patch). Split the svm ranges to handle partial

[PATCH 04/44] drm/amdkfd: register svm range

2021-03-22 Thread Felix Kuehling
From: Philip Yang svm range structure stores the range start address, size, attributes, flags, prefetch location and gpu bitmap which indicates which GPU this range maps to. Same virtual address is shared by CPU and GPUs. Process has svm range list which uses both interval tree and list to

[PATCH 10/44] drm/amdkfd: map svm range to GPUs

2021-03-22 Thread Felix Kuehling
Use amdgpu_vm_bo_update_mapping to update GPU page table to map or unmap svm range system memory pages address to GPUs. Signed-off-by: Philip Yang Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 395 +--

[PATCH 06/44] drm/amdgpu: add common HMM get pages function

2021-03-22 Thread Felix Kuehling
From: Philip Yang Move the HMM get pages function from amdgpu_ttm and to amdgpu_mn. This common function will be used by new svm APIs. Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 83 +

[PATCH 12/44] drm/amdkfd: add xnack enabled flag to kfd_process

2021-03-22 Thread Felix Kuehling
From: Alex Sierra This flag is useful at cpu invalidation page table decision. Between select queue eviction or page fault. Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 4 +++ drivers/gpu/drm/amd/amdkfd/kfd_process.c | 36

[PATCH 07/44] drm/amdkfd: validate svm range system memory

2021-03-22 Thread Felix Kuehling
From: Philip Yang Use HMM to get system memory pages address, which will be used to map to GPUs or migrate to vram. Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 103 ++- drivers/gpu/drm/amd/amdkfd/kfd_svm.h | 4

[PATCH 00/44] Add HMM-based SVM memory manager to KFD v2

2021-03-22 Thread Felix Kuehling
Since the last patch series I sent on Jan 6 a lot has changed. Patches 1-33 are the cleaned up, rebased on amd-staging-drm-next 5.11 version from about a week ago. The remaining 11 patches are current work-in-progress with further cleanup and fixes. MMU notifiers and CPU page faults now can split

[PATCH 01/44] drm/amdgpu: replace per_device_list by array

2021-03-22 Thread Felix Kuehling
From: Alex Sierra Remove per_device_list from kfd_process and replace it with a kfd_process_device pointers array of MAX_GPU_INSTANCES size. This helps to manage the kfd_process_devices binded to a specific kfd_process. Also, functions used by kfd_chardev to iterate over the list were removed,

[PATCH 2/2] vgaarb: avoid -Wempty-body warnings

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann Building with W=1 shows a few warnings for an empty macro: drivers/gpu/drm/qxl/qxl_drv.c: In function 'qxl_pci_probe': drivers/gpu/drm/qxl/qxl_drv.c:131:50: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] 131 |

[PATCH 1/2] fbdev: omapfb: avoid -Wempty-body warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann Building with 'make W=1' shows a few harmless warnings: drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_calc_addr': drivers/video/fbdev/omap2/omapfb/omapfb-main.c:823:56: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

2021-03-22 Thread Matthew Auld
On Sat, 20 Mar 2021 at 14:48, Jason Ekstrand wrote: > > On Fri, Mar 19, 2021 at 5:39 PM Jason Ekstrand wrote: > > > > This reverts commit 88be76cdafc7e60e2e4ed883bfe7e8dd7f35fa3a. This API > > has never been used by any real userspace. > > After further digging, there is a compute-runtime PR

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-03-22 Thread Daniel Gomez
On Mon, 22 Mar 2021 at 11:34, Christian König wrote: > > Hi Daniel, > > Am 22.03.21 um 10:38 schrieb Daniel Gomez: > > On Fri, 19 Mar 2021 at 21:29, Felix Kuehling wrote: > >> This caused a regression in kfdtest in a large-buffer stress test after > >> memory allocation for user pages fails: > >

Re: [PATCH V2] drm/bridge: lvds-codec: Add support for pixel data sampling edge select

2021-03-22 Thread Laurent Pinchart
Hi Marek, (CC'ing Ron and the DT mailing list for the DT discussion) On Mon, Mar 22, 2021 at 11:29:04AM +0100, Marek Vasut wrote: > On 3/22/21 2:14 AM, Laurent Pinchart wrote: > > Hi Marek, > > Hi, > > [...] > > >> diff --git > >>

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-03-22 Thread Christian König
Hi Daniel, Am 22.03.21 um 10:38 schrieb Daniel Gomez: On Fri, 19 Mar 2021 at 21:29, Felix Kuehling wrote: This caused a regression in kfdtest in a large-buffer stress test after memory allocation for user pages fails: I'm sorry to hear that. BTW, I guess you meant amdgpu leak patch and not

[PATCH v5 2/2] drm: bridge: Add Chipone ICN6211 MIPI-DSI to RGB bridge

2021-03-22 Thread Jagan Teki
ICN6211 is MIPI-DSI to RGB Converter bridge from Chipone. It has a flexible configuration of MIPI DSI signal input and produce RGB565, RGB666, RGB888 output format. Add bridge driver for it. Signed-off-by: Jagan Teki Reviewed-by: Robert Foss --- Changes for v5: - rebase drm-misc-next -

[PATCH v5 1/2] dt-bindings: display: bridge: Add Chipone ICN6211 bindings

2021-03-22 Thread Jagan Teki
ICN6211 is MIPI-DSI to RGB Converter bridge from Chipone. It has a flexible configuration of MIPI DSI signal input and produces RGB565, RGB666, RGB888 output format. Add dt-bingings for it. Signed-off-by: Jagan Teki Reviewed-by: Robert Foss Reviewed-by: Rob Herring --- Changes for v5: -

Re: [RFC PATCH 01/11] dt-bindings: drm/bridge: ti-sn65dsi8: Make enable GPIO optional

2021-03-22 Thread Jagan Teki
On Mon, Mar 22, 2021 at 8:32 AM Laurent Pinchart wrote: > > The SN65DSI86 EN pin can be hardwired to a high level, or connected to a > global reset signal, not controllable by the kernel. Make it optional in > those cases. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Jagan Teki

Re: [RFC PATCH 02/11] drm/bridge: ti-sn65dsi86: Make enable GPIO optional

2021-03-22 Thread Jagan Teki
On Mon, Mar 22, 2021 at 8:32 AM Laurent Pinchart wrote: > > The enable signal may not be controllable by the kernel. Make it > optional. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Jagan Teki ___ dri-devel mailing list

Re: [PATCH V2] drm/bridge: lvds-codec: Add support for pixel data sampling edge select

2021-03-22 Thread Marek Vasut
On 3/22/21 2:14 AM, Laurent Pinchart wrote: Hi Marek, Hi, [...] diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml index e5e3c72630cf..399a6528780a 100644 ---

<    1   2   3   >