Re: [PATCH v3 2/3] drm/msm/dpu: add support to dump dpu registers

2021-04-08 Thread kernel test robot
Hi Abhinav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.12-rc6 next-20210408] [cannot apply to drm/drm-next] [If

Linux Kernel build bug with AMD_IOMMU_V2=M and HSA_AMD=Y

2021-04-08 Thread David Niklas
Hello, (There are so many maintainers for kfd_iommu.c I feel like I'm spamming.) When compiling for Linux version 5.11.12 using the AMDGPU GPU driver with HSA_AMD enabled, I get the below set of errors. To work around this, I need to change AMD_IOMMU_V2 from M to Y. This bug doesn't affect linux k

Re: [PATCH v2 -next] phy: phy-mtk-hdmi: Remove redundant dev_err call in mtk_hdmi_phy_probe()

2021-04-08 Thread Chunfeng Yun
On Thu, 2021-04-08 at 07:55 -0400, He Ying wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot > Signed-off-by: He Ying > --- > v2: > - Use 'return PTR_ERR()' instead of 'ret = PTR_ER

[PATCH] drm/vc4: Fix PM reference leak in vc4_vec_encoder_enable()

2021-04-08 Thread Bixuan Cui
The pm_runtime_get_sync will increment pm usage counter even it failed.Thus a pairing decrement is needed. Change pm_runtime_get_sync to pm_runtime_resume_and_get for keeping usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Bixuan Cui --- drivers/gpu/drm/vc4/vc4_vec.c | 2 +- 1 f

[PATCH 1/1] drm/bridge: anx7625: send DPCD command to downstream

2021-04-08 Thread Xin Ji
Send DPCD command to downstream before anx7625 power down, tell downstream into standby mode. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 75 +++ 1 file changed, 75 insertions(+) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/

[PATCH 2/2] arm64: dts: mt8183: Add panel rotation

2021-04-08 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi inde

[PATCH 1/2] drm/mediatek: set panel orientation before drm_dev_register().

2021-04-08 Thread Hsin-Yi Wang
drm_dev_register() sets connector->registration_state to DRM_CONNECTOR_REGISTERED and dev->registered to true. If drm_connector_set_panel_orientation() is first called after drm_dev_register(), it will fail several checks and results in following warning. So set panel orientation in dsi before drm_

Re: Linux Kernel build bug with AMD_IOMMU_V2=M and HSA_AMD=Y

2021-04-08 Thread Felix Kuehling
This should have been fixed by this commit in amd-staging-drm-next: https://lore.kernel.org/patchwork/patch/1392368/ commit b8aff1f3a0b3d8434f8ccf5d3017137c29aca77b Author: Felix Kuehling Date: Mon Mar 8 22:15:42 2021 -0500 drm/amdkfd: fix build error with AMD_IOMMU_V2=m Using '

linux-next: build failure after merge of the drm tree

2021-04-08 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/i915/display/intel_dp_link_training.c:43:13: error: redefinition of 'intel_dp_reset_lttpr_common_caps' 43 | static void intel_dp_reset_lttpr_common_caps(struct intel_dp *intel_

linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2021-04-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/vc4/vc4_plane.c between commit: 35d65ab3fdba ("drm/vc4: plane: Remove redundant assignment") from the drm-misc-fixes tree and commit: 5ddb0bd4ddc3 ("drm/atomic: Pass the full state to planes async atomic

[PATCH v3 3/3] drm/msm/dpu: add dpu_dbg points across dpu driver

2021-04-08 Thread Abhinav Kumar
Add dpu_dbg points across dpu driver to trigger dumps when critical errors are hit. changes in v3: - change the callers to also pass the drm device while triggering the dump Change-Id: I351514afe2f1c85232a1562253e5671588075197 Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/d

[PATCH v3 1/3] drm: allow drm_atomic_print_state() to accept any drm_printer

2021-04-08 Thread Abhinav Kumar
Currently drm_atomic_print_state() internally allocates and uses a drm_info printer. Allow it to accept any drm_printer type so that the API can be leveraged even for taking drm snapshot. Rename the drm_atomic_print_state() to drm_atomic_print_new_state() so that it reflects its functionality bett

[PATCH v3 2/3] drm/msm/dpu: add support to dump dpu registers

2021-04-08 Thread Abhinav Kumar
Add the dpu_dbg module which adds supports to dump dpu registers which can be used in case of error conditions. changes in v3: - Get rid of registration mechanism for sub-modules and instead get this information from the dpu catalog itself - Get rid of global dpu_dbg struct and instead store

[PATCH v3 0/3] Add devcoredump support for DPU

2021-04-08 Thread Abhinav Kumar
This series adds support to use devcoredump for DPU driver. It introduces the dpu_dbg module which assists in the capturing of register dumps during error scenarios. When a display related error happens, the dpu_dbg module captures all the relevant register dumps along with the snapshot of the drm

[PATCH v1] drm/amd/dc: Fix a missing check bug in dm_dp_mst_detect()

2021-04-08 Thread wangyingjie55
From: Yingjie Wang In dm_dp_mst_detect(), We should check whether or not @connector has been unregistered from userspace. If the connector is unregistered, we should return disconnected status. Fixes: 4562236b3bc0 ("drm/amd/dc: Add dc display driver (v2)") Signed-off-by: Yingjie Wang --- drive

Re: [PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v2)

2021-04-08 Thread Gurchetan Singh
On Thu, Apr 8, 2021 at 2:27 AM Gerd Hoffmann wrote: > > > + > > > + if (vgdev->has_resource_blob) { > > > + params.blob_mem = VIRTGPU_BLOB_MEM_GUEST; > > > + params.blob_flags = VIRTGPU_BLOB_FLAG_USE_SHAREABLE; > > > > > > > This creates some log spam with crosvm

Re: [Freedreno] [PATCH 1/3] drm/msm/mdp5: Configure PP_SYNC_HEIGHT to double the vtotal

2021-04-08 Thread Rob Clark
On Thu, Apr 8, 2021 at 4:16 PM AngeloGioacchino Del Regno wrote: > > > Il gio 8 apr 2021, 21:05 Rob Clark ha scritto: >> >> On Wed, Apr 7, 2021 at 12:11 PM AngeloGioacchino Del Regno >> wrote: >> > >> > Il 07/04/21 20:19, abhin...@codeaurora.org ha scritto: >> > > Hi Marijn >> > > >> > > On 2021

Re: [Freedreno] [PATCH 1/3] drm/msm/mdp5: Configure PP_SYNC_HEIGHT to double the vtotal

2021-04-08 Thread AngeloGioacchino Del Regno
Il gio 8 apr 2021, 21:05 Rob Clark ha scritto: > On Wed, Apr 7, 2021 at 12:11 PM AngeloGioacchino Del Regno > wrote: > > > > Il 07/04/21 20:19, abhin...@codeaurora.org ha scritto: > > > Hi Marijn > > > > > > On 2021-04-06 14:47, Marijn Suijten wrote: > > >> Leaving this at a close-to-maximum reg

Re: [PATCH 0/2] Document how userspace should use plane format list and IN_FORMATS

2021-04-08 Thread Leandro Ribeiro
On 4/8/21 8:35 AM, Daniel Vetter wrote: > On Tue, Apr 06, 2021 at 04:21:16PM -0300, Leandro Ribeiro wrote: >> This patch is to emphasize how userspace should use the plane format list and >> the IN_FORMATS blob. The plane format list contains the formats that do not >> require modifiers, and the

[Bug 211875] CPU frequency scaling lost after "WARNING: CPU: 2 PID: 2358578 at smu8_send_msg_to_smc_with_parameter+0xfe/0x140 [amdgpu]"

2021-04-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211875 --- Comment #9 from Erhard F. (erhar...@mailbox.org) --- (In reply to Alex Deucher from comment #4) > If this is a regression, can you bisect? > https://www.kernel.org/doc/html/latest/admin-guide/bug-bisect.html Sorry but my bisecting efforts cam

[PATCH -next] drm/mediatek: Remove redundant dev_err calls

2021-04-08 Thread Chen Hui
There is a error message within devm_ioremap_resource already, so remove the dev_err calls to avoid redundant error messages. Signed-off-by: Chen Hui --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 4 +--- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 4 +--- 2 files changed, 2 insertions(+), 6 de

Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv

2021-04-08 Thread Linus Walleij
On Thu, Apr 8, 2021 at 6:44 PM David Hildenbrand wrote: > > drivers/gpu/drm/mcde/Kconfig > > drivers/gpu/drm/pl111/Kconfig > > drivers/gpu/drm/tve200/Kconfig > > I was assuming these are "real" dependencies. Will it also work without > DMA_CMA? It will mostly work but that is only because the re

Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv

2021-04-08 Thread Arnd Bergmann
On Thu, Apr 8, 2021 at 6:45 PM David Hildenbrand wrote: > On 08.04.21 14:49, Linus Walleij wrote: > > On Thu, Apr 8, 2021 at 2:01 PM David Hildenbrand wrote: > > > >>> This is something you could do using a hidden helper symbol like > >>> > >>> config DRMA_ASPEED_GFX > >>> bool "Aspeed d

Re: [PATCH v3 2/9] dt-bindings: display/panel: add Jenson JT60245-01

2021-04-08 Thread Rob Herring
On Fri, 02 Apr 2021 01:17:13 +0200, Giulio Benetti wrote: > Add DT binding for "jenson,jt60245-01". > > Signed-off-by: Giulio Benetti > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring _

Re: [PATCH v1] drm/radeon: Fix a missing check bug in radeon_dp_mst_detect()

2021-04-08 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Apr 7, 2021 at 2:23 AM wrote: > > From: Yingjie Wang > > In radeon_dp_mst_detect(), We should check whether or not @connector > has been unregistered from userspace. If the connector is unregistered, > we should return disconnected status. > > Fixes: 9843ead08f18

Re: [PATCH -next] drm/amd/display: Fix the Wunused-function warning

2021-04-08 Thread Alex Deucher
Applied. Thanks. Alex On Thu, Apr 8, 2021 at 11:09 AM Harry Wentland wrote: > > On 2021-04-08 8:41 a.m., Shaokun Zhang wrote: > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:941:13: > > warning: ‘dm_dmub_trace_high_irq’ defined but not used [-Wunused-function] > >941 | stat

Re: [PATCH] drm/radeon/r600: Fix variables that are not used after assignment

2021-04-08 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Apr 8, 2021 at 8:13 AM Tian Tao wrote: > > err was not used after being assigned -EINVAL and was given a new value, > so here add goto to handle the error case. > > Signed-off-by: Tian Tao > --- > drivers/gpu/drm/radeon/r600.c | 2 ++ > 1 file changed, 2 insertio

[PATCH] drm/amdgpu: Report the Frame number at beginning of CRC calculation

2021-04-08 Thread Mark Yacoub
From: Mark Yacoub On reporting back the frame number of the CRCs through drm_crtc_add_crc_entry(), send back the vblank count at the time the frame CRC starts calculating rather than when the CRCs are ready to be reported. Tested by running IGT module: kms_plane::capture_crc() Cc: Harry Wentlan

Re: [PATCH 1/2] drm/doc: document drm_mode_get_plane

2021-04-08 Thread Leandro Ribeiro
On 4/7/21 10:45 AM, Ville Syrjälä wrote: > On Tue, Apr 06, 2021 at 04:21:17PM -0300, Leandro Ribeiro wrote: >> Add a small description and document struct fields of >> drm_mode_get_plane. >> >> Signed-off-by: Leandro Ribeiro >> --- >> include/uapi/drm/drm_mode.h | 19 +++ >> 1 f

Re: [Freedreno] [PATCH 1/3] drm/msm/mdp5: Configure PP_SYNC_HEIGHT to double the vtotal

2021-04-08 Thread Rob Clark
On Wed, Apr 7, 2021 at 12:11 PM AngeloGioacchino Del Regno wrote: > > Il 07/04/21 20:19, abhin...@codeaurora.org ha scritto: > > Hi Marijn > > > > On 2021-04-06 14:47, Marijn Suijten wrote: > >> Leaving this at a close-to-maximum register value 0xFFF0 means it takes > >> very long for the MDSS to

Re: [Intel-gfx] [PATCH v2 00/20] drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers

2021-04-08 Thread Lyude Paul
JFYI too - there was a legitimate looking CI failure on intel with this series, so don't be surprised if I have to respin a patch or two (I should be able to get it asap as I finally just cleared most of the stuff on my plate off for a while) On Thu, 2021-04-08 at 14:13 +0300, Jani Nikula wrote: >

[Bug 212077] AMD GPU discrete card memory at highest frequency even while not in use

2021-04-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212077 --- Comment #16 from Bat Malin (bat_ma...@abv.bg) --- After reboot even better - amdgpu-pci-0100 Adapter: PCI adapter vddgfx: 756.00 mV edge: +35.0°C (crit = +94.0°C, hyst = -273.1°C) power1:6.22 W (cap = 60.00 W) -- Yo

[PATCH 2/2] drm/vmwgfx: Make sure unpinning handles reservations

2021-04-08 Thread Zack Rusin
Quite often it's a little hard to tell if reservations are already held in code paths that unpin bo's. While our pinning/unpinning code should be more explicit that requires a substential amount of work so instead we can avoid the issues by making sure we try to reserve before unpinning. Because we

[PATCH 1/2] drm/vmwgfx: Fix the lockdep breakage

2021-04-08 Thread Zack Rusin
Thomas has noticed that the lockdep was broken in vmwgfx. It was broken during the pci initialization rework. This fixes the breakage by making sure we initialize the locking code before doing anything else. This was independently spotted and fixed by Tetsuo Handa as well. Reviewed-by: Martin Kras

Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv

2021-04-08 Thread Jason Gunthorpe
On Thu, Apr 08, 2021 at 01:38:17PM +0200, Daniel Vetter wrote: > If you want to change this, we need automatic conflict resolution like apt > and other package managers have, with suggestions how to fix the config if > you want to enable a driver, but some of its requirements are missing. The > cu

Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv

2021-04-08 Thread David Hildenbrand
On 08.04.21 14:49, Linus Walleij wrote: On Thu, Apr 8, 2021 at 2:01 PM David Hildenbrand wrote: This is something you could do using a hidden helper symbol like config DRMA_ASPEED_GFX bool "Aspeed display driver" select DRM_WANT_CMA config DRM_WANT_CMA bool

Re: Call for an EDID parsing library

2021-04-08 Thread Simon Ser
On Thursday, April 8th, 2021 at 5:28 PM, Jani Nikula wrote: > On Thu, 08 Apr 2021, Simon Ser cont...@emersion.fr wrote: > > > On Thursday, April 8th, 2021 at 4:58 PM, Jani Nikula > > jani.nik...@linux.intel.com wrote: > > > > > Perhaps that should be the takeaway; try to minimize parsed data >

Re: Call for an EDID parsing library

2021-04-08 Thread Jani Nikula
On Thu, 08 Apr 2021, Simon Ser wrote: > On Thursday, April 8th, 2021 at 4:58 PM, Jani Nikula > wrote: > >> Perhaps that should be the takeaway; try to minimize parsed data >> where the consumer needs to know whether it originated from DisplayID or >> EDID? > > So an EDID/DisplayID abstraction la

Re: linux-next: build warning after merge of the drm-intel-fixes tree

2021-04-08 Thread Imre Deak
On Thu, Apr 08, 2021 at 12:38:52PM +0200, Daniel Vetter wrote: > On Mon, Mar 29, 2021 at 09:23:35PM +0300, Imre Deak wrote: > > Hi Stephen, > > > > thanks for the report. > > > > On Mon, Mar 29, 2021 at 09:01:17AM +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > On Fri, 26 Mar 2021 19:58

Re: [PATCH 0/8] drm/msm: Swappable GEM objects

2021-04-08 Thread Rob Clark
On Thu, Apr 8, 2021 at 4:15 AM Daniel Vetter wrote: > > On Mon, Apr 05, 2021 at 10:45:23AM -0700, Rob Clark wrote: > > From: Rob Clark > > > > One would normally hope not to be under enough memory pressure to need > > to swap GEM objects to disk backed swap. But memory backed zram swap > > (as e

Re: [PATCH 00/34] Add HMM-based SVM memory manager to KFD v4

2021-04-08 Thread Felix Kuehling
Am 2021-04-08 um 11:02 a.m. schrieb Jason Gunthorpe: > On Mon, Apr 05, 2021 at 09:45:55PM -0400, Felix Kuehling wrote: >> Rebased on upstream. Dropped already upstream patch >> "drm/amdgpu: reserve fence slot to update page table". >> >> Added more fixes: >> - Fixed kernel test robot warnings about

Re: Call for an EDID parsing library

2021-04-08 Thread Simon Ser
On Thursday, April 8th, 2021 at 4:58 PM, Jani Nikula wrote: > Perhaps that should be the takeaway; try to minimize parsed data > where the consumer needs to know whether it originated from DisplayID or > EDID? So an EDID/DisplayID abstraction layer? It sounds like only an EDID and DisplayID ex

Re: [PATCH -next] drm/amd/display: Fix the Wunused-function warning

2021-04-08 Thread Harry Wentland
On 2021-04-08 8:41 a.m., Shaokun Zhang wrote: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:941:13: warning: ‘dm_dmub_trace_high_irq’ defined but not used [-Wunused-function] 941 | static void dm_dmub_trace_high_irq(void *interrupt_params) | ^~

Re: [PATCH v15 4/4] dt-bindings: msm/dp: Add bindings of MSM DisplayPort controller

2021-04-08 Thread Rob Herring
On Mon, Apr 05, 2021 at 04:36:10PM +0530, Krishna Manikandan wrote: > Add bindings for Snapdragon DisplayPort controller driver. > > Signed-off-by: Chandan Uddaraju > Signed-off-by: Vara Reddy > Signed-off-by: Tanmay Shah > Signed-off-by: Kuogee Hsieh > Signed-off-by: Krishna Manikandan > >

Re: [PATCH v15 2/4] dt-bindings: msm: dsi: add yaml schemas for DSI bindings

2021-04-08 Thread Rob Herring
On Mon, Apr 05, 2021 at 04:36:08PM +0530, Krishna Manikandan wrote: > Add YAML schema for the device tree bindings for DSI > > Signed-off-by: Krishna Manikandan > > Changes in v1: > - Separate dsi controller bindings to a separate patch (Stephen Boyd) > - Merge dsi-common-controller.yaml

Re: [PATCH 00/34] Add HMM-based SVM memory manager to KFD v4

2021-04-08 Thread Jason Gunthorpe
On Mon, Apr 05, 2021 at 09:45:55PM -0400, Felix Kuehling wrote: > Rebased on upstream. Dropped already upstream patch > "drm/amdgpu: reserve fence slot to update page table". > > Added more fixes: > - Fixed kernel test robot warnings about static functions > - Fixed a kernel test robot warning abo

Re: Call for an EDID parsing library

2021-04-08 Thread Jani Nikula
On Thu, 08 Apr 2021, Pekka Paalanen wrote: > On Thu, 08 Apr 2021 16:49:37 +0300 > Jani Nikula wrote: > >> Anyway, this is only tangentially related to the library. I just think >> we need to take DisplayID better into account also in the *users* of the >> library, as they shouldn't really even lo

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for SN65DSI83/84/85

2021-04-08 Thread Jagan Teki
On Wed, Mar 24, 2021 at 7:26 PM Claudius Heine wrote: > > Hi Jagan, > > On 2021-02-14 18:44, Jagan Teki wrote: > > SN65DSI83/84/85 devices are MIPI DSI to LVDS based bridge > > controller IC's from Texas Instruments. > > > > SN65DSI83 - Single Channel DSI to Single-link LVDS bridge > > SN65DSI84 -

Re: [PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-08 Thread Ville Syrjälä
On Thu, Apr 08, 2021 at 04:57:51PM +0300, Pekka Paalanen wrote: > On Thu, 8 Apr 2021 13:30:16 +0200 > Daniel Vetter wrote: > > > On Thu, Apr 08, 2021 at 12:59:19PM +0300, Pekka Paalanen wrote: > > > > The point of these documentation patches is to establish the convention > > > that: > > > > >

Re: [PATCH v15 1/4] dt-bindings: msm: disp: add yaml schemas for DPU bindings

2021-04-08 Thread Rob Herring
On Mon, Apr 05, 2021 at 04:36:07PM +0530, Krishna Manikandan wrote: > MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema > for DPU device tree bindings. > > Signed-off-by: Krishna Manikandan > > Changes in v2: > - Changed dpu to

Re: Call for an EDID parsing library

2021-04-08 Thread Pekka Paalanen
On Thu, 08 Apr 2021 16:49:37 +0300 Jani Nikula wrote: > Anyway, this is only tangentially related to the library. I just think > we need to take DisplayID better into account also in the *users* of the > library, as they shouldn't really even look at the EDID if the plain > DisplayID is there, pe

[PATCH v2 3/4] drm/nouveau: Use drm_gem_ttm_dumb_map_offset()

2021-04-08 Thread Thomas Zimmermann
Nouveau now uses drm_gem_ttm_dumb_map_offset() to implement struct drm_driver.dumb_map_offset. Signed-off-by: Thomas Zimmermann Acked-by: Maxime Ripard --- drivers/gpu/drm/nouveau/nouveau_display.c | 18 -- drivers/gpu/drm/nouveau/nouveau_display.h | 2 -- drivers/gpu/drm/nouve

[PATCH v2 4/4] drm/qxl: Use drm_gem_ttm_dumb_map_offset()

2021-04-08 Thread Thomas Zimmermann
Qxl now uses drm_gem_ttm_dumb_map_offset() to implement struct drm_driver.dumb_map_offset. Signed-off-by: Thomas Zimmermann Acked-by: Maxime Ripard --- drivers/gpu/drm/qxl/qxl_drv.c| 3 ++- drivers/gpu/drm/qxl/qxl_drv.h| 3 --- drivers/gpu/drm/qxl/qxl_dumb.c | 17 -

[PATCH v2 2/4] drm/vram-helper: Use drm_gem_ttm_dumb_map_offset()

2021-04-08 Thread Thomas Zimmermann
VRAM helpers now use drm_gem_ttm_dumb_map_offset() to implement struct drm_driver.dumb_map_offset. v2: * update hibmc as well (kernel test robot) Signed-off-by: Thomas Zimmermann Acked-by: Maxime Ripard --- drivers/gpu/drm/drm_gem_vram_helper.c | 48 --- .../gpu

[PATCH v2 1/4] drm/gem-ttm-helper: Provide helper for struct drm_driver.dumb_map_offset

2021-04-08 Thread Thomas Zimmermann
Provides an implementation of struct drm_driver.dumb_map_offset that can be used by TTM-based GEM drivers. Signed-off-by: Thomas Zimmermann Acked-by: Maxime Ripard --- drivers/gpu/drm/drm_gem_ttm_helper.c | 33 include/drm/drm_gem_ttm_helper.h | 5 - 2 file

[PATCH v2 0/4] drm: Generic dumb_map_offset for TTM-based drivers

2021-04-08 Thread Thomas Zimmermann
The implementation of drm_driver.dumb_map_offset is the same for several TTM-based drivers. Provide a common function in GEM-TTM helpers. v2: * update hibmc as well (kernel test robot) Thomas Zimmermann (4): drm/gem-ttm-helper: Provide helper for struct drm_driver.dumb_map_offset

Re: [PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-08 Thread Pekka Paalanen
On Thu, 8 Apr 2021 13:30:16 +0200 Daniel Vetter wrote: > On Thu, Apr 08, 2021 at 12:59:19PM +0300, Pekka Paalanen wrote: > > The point of these documentation patches is to establish the convention > > that: > > > > - drm_mode_get_plane::format_type_ptr is the list of pixel formats that > > ca

Re: Call for an EDID parsing library

2021-04-08 Thread Jani Nikula
On Wed, 07 Apr 2021, Hans Verkuil wrote: > On 07/04/2021 12:31, Jani Nikula wrote: >> On Wed, 07 Apr 2021, Hans Verkuil wrote: >>> It is the most complete EDID parser I know based on the various standards. >> >> Does it support pure DisplayID in addition to DisplayID blocks embedded >> to EDID e

Re: [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer

2021-04-08 Thread Maxime Ripard
Hi Stephen, On Tue, Mar 30, 2021 at 11:56:15AM -0700, Stephen Boyd wrote: > Quoting Maxime Ripard (2021-03-30 08:35:27) > > Hi Stephen, > > > > On Mon, Mar 29, 2021 at 06:52:01PM -0700, Stephen Boyd wrote: > > > Trimming Cc list way down, sorry if that's too much. > > > > > > Quoting Maxime Ripa

Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv

2021-04-08 Thread Arnd Bergmann
On Thu, Apr 8, 2021 at 2:50 PM Linus Walleij wrote: > > On Thu, Apr 8, 2021 at 2:01 PM David Hildenbrand wrote: > > > > This is something you could do using a hidden helper symbol like > > > > > > config DRMA_ASPEED_GFX > > > bool "Aspeed display driver" > > > select DRM_WANT_CMA

Re: [PATCH] drm/panel: tpo-td043mtea1: convert sysfs snprintf to sysfs_emit

2021-04-08 Thread Thierry Reding
On Thu, Apr 08, 2021 at 08:31:18AM +, Carlis wrote: > From: Xuezhi Zhang > > Fix the following coccicheck warning: > drivers/gpu/drm//panel/panel-tpo-td043mtea1.c:217:8-16: > WARNING: use scnprintf or sprintf > drivers/gpu/drm//panel/panel-tpo-td043mtea1.c:189:8-16: > WARNING: use scnprintf

Re: [PATCH v2] drm/panel: panel-dsi-cm: convert sysfs snprintf to sysfs_emit

2021-04-08 Thread Thierry Reding
On Thu, Apr 08, 2021 at 08:52:57AM +, Carlis wrote: > From: Xuezhi Zhang > > Fix the following coccicheck warning: > drivers/gpu/drm//panel/panel-dsi-cm.c:271:8-16: > WARNING: use scnprintf or sprintf > drivers/gpu/drm//panel/panel-dsi-cm.c:251:8-16: > WARNING: use scnprintf or sprintf > >

Re: [pull] amdgpu, amdkfd, radeon drm-next-5.12

2021-04-08 Thread Alex Deucher
On Thu, Apr 8, 2021 at 6:03 AM Daniel Vetter wrote: > > On Thu, Apr 01, 2021 at 06:56:09AM +1000, Dave Airlie wrote: > > I think this is due to this pull, on arm32. > > > > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv.c: > > In function ‘dmub_srv_hw_in

[PATCH v2] drm/bridge/sii8620: fix dependency on extcon

2021-04-08 Thread Robert Foss
The DRM_SIL_SII8620 kconfig has a weak `imply` dependency on EXTCON, which causes issues when sii8620 is built as a builtin and EXTCON is built as a module. The symptoms are 'undefined reference' errors caused by the symbols in EXTCON not being available to the sii8620 driver. Signed-off-by: Robe

[PATCH v2 -next] phy: phy-mtk-mipi-dsi: Remove redundant dev_err call in mtk_mipi_tx_probe()

2021-04-08 Thread He Ying
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reviewed-by: Chunfeng Yun Reported-by: Hulk Robot Signed-off-by: He Ying --- v2: - Use 'return PTR_ERR();' instead of 'ret = PTR_ERR();return ret;'. drivers/phy/mediatek

[PATCH -next] drm/amd/display: Fix the Wunused-function warning

2021-04-08 Thread Shaokun Zhang
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:941:13: warning: ‘dm_dmub_trace_high_irq’ defined but not used [-Wunused-function] 941 | static void dm_dmub_trace_high_irq(void *interrupt_params) | ^~ Fixes: 83b39e1fc3ea ("drm/amd/display: Log D

[PATCH v2 -next] phy: phy-mtk-hdmi: Remove redundant dev_err call in mtk_hdmi_phy_probe()

2021-04-08 Thread He Ying
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: He Ying --- v2: - Use 'return PTR_ERR()' instead of 'ret = PTR_ERR();return ret;'. drivers/phy/mediatek/phy-mtk-hdmi.c | 4 +--- 1

Re: [pull] amdgpu, radeon, ttm, sched drm-next-5.13

2021-04-08 Thread Alex Deucher
On Thu, Apr 8, 2021 at 6:28 AM Christian König wrote: > > Am 08.04.21 um 09:13 schrieb Christian König: > > Am 07.04.21 um 21:04 schrieb Alex Deucher: > >> On Wed, Apr 7, 2021 at 3:23 AM Dave Airlie wrote: > >>> On Wed, 7 Apr 2021 at 06:54, Alex Deucher > >>> wrote: > On Fri, Apr 2, 2021 at

Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv

2021-04-08 Thread Linus Walleij
On Thu, Apr 8, 2021 at 2:01 PM David Hildenbrand wrote: > > This is something you could do using a hidden helper symbol like > > > > config DRMA_ASPEED_GFX > > bool "Aspeed display driver" > > select DRM_WANT_CMA > > > > config DRM_WANT_CMA > > bool > > help > >

Re: [PATCH] drm/ttm: optimize the pool shrinker a bit

2021-04-08 Thread Christian König
Am 08.04.21 um 13:31 schrieb Daniel Vetter: On Thu, Apr 08, 2021 at 01:17:32PM +0200, Christian König wrote: Am 08.04.21 um 13:08 schrieb Daniel Vetter: On Thu, Apr 01, 2021 at 03:54:13PM +0200, Christian König wrote: [SNIP] EXPORT_SYMBOL(unregister_shrinker); +/** + * sync_shrinker - Wait

Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv

2021-04-08 Thread Arnd Bergmann
On Thu, Apr 8, 2021 at 2:00 PM David Hildenbrand wrote: > > On 08.04.21 13:44, Arnd Bergmann wrote: > > On Thu, Apr 8, 2021 at 1:00 PM David Hildenbrand wrote: > >>> > >>> It is a somewhat awkward way to say "prevent this symbol from > >>> being =y if the dependency is =m". > >> > >> What would b

[PATCH] drm/radeon/r600: Fix variables that are not used after assignment

2021-04-08 Thread Tian Tao
err was not used after being assigned -EINVAL and was given a new value, so here add goto to handle the error case. Signed-off-by: Tian Tao --- drivers/gpu/drm/radeon/r600.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index

Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv

2021-04-08 Thread David Hildenbrand
On 08.04.21 13:44, Arnd Bergmann wrote: On Thu, Apr 8, 2021 at 1:00 PM David Hildenbrand wrote: It is a somewhat awkward way to say "prevent this symbol from being =y if the dependency is =m". What would be the right thing to do in the case here then to achieve the "if DRMA_ASPEED_GFX is ena

Re: [PATCH v5 03/21] gpu: host1x: Show number of pending waiters in debugfs

2021-04-08 Thread Mikko Perttunen
On 4/8/21 7:25 AM, Michał Mirosław wrote: On Thu, Apr 08, 2021 at 06:13:44AM +0200, Michał Mirosław wrote: On Fri, Apr 02, 2021 at 07:02:32PM +0300, Dmitry Osipenko wrote: 02.04.2021 00:19, Michał Mirosław пишет: On Fri, Mar 26, 2021 at 04:34:13PM +0200, Mikko Perttunen wrote: On 3/23/21 12:1

Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv

2021-04-08 Thread Arnd Bergmann
On Thu, Apr 8, 2021 at 1:00 PM David Hildenbrand wrote: > > > > It is a somewhat awkward way to say "prevent this symbol from > > being =y if the dependency is =m". > > What would be the right thing to do in the case here then to achieve the > "if DRMA_ASPEED_GFX is enabled, also enable DMA_CMA id

Re: [RESEND 00/25] Rid W=1 warnings from HID

2021-04-08 Thread Benjamin Tissoires
On Thu, Apr 8, 2021 at 9:06 AM Lee Jones wrote: > > On Wed, 07 Apr 2021, Benjamin Tissoires wrote: > > > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones wrote: > > > > > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel b

Re: [PATCH 3/3] mm: unexport follow_pfn

2021-04-08 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 01:40:59PM +0200, Paolo Bonzini wrote: > On 08/04/21 12:05, Daniel Vetter wrote: > > On Mon, Mar 29, 2021 at 10:31:01AM -0300, Jason Gunthorpe wrote: > > > On Tue, Mar 16, 2021 at 04:33:03PM +0100, Daniel Vetter wrote: > > > > Both kvm (in bd2fae8da794 ("KVM: do not assume P

Re: [PATCH 0/8] drm: Clean up mmap for TTM-based GEM drivers

2021-04-08 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 01:38:59PM +0200, Thomas Zimmermann wrote: > Hi > > Am 08.04.21 um 13:19 schrieb Daniel Vetter: > > On Tue, Apr 06, 2021 at 11:08:55AM +0200, Thomas Zimmermann wrote: > > > Implement mmap via struct drm_gem_object_functions.mmap for amdgpu, > > > radeon and nouveau. This al

Re: [PATCH 3/3] mm: unexport follow_pfn

2021-04-08 Thread Paolo Bonzini
On 08/04/21 12:05, Daniel Vetter wrote: On Mon, Mar 29, 2021 at 10:31:01AM -0300, Jason Gunthorpe wrote: On Tue, Mar 16, 2021 at 04:33:03PM +0100, Daniel Vetter wrote: Both kvm (in bd2fae8da794 ("KVM: do not assume PTE is writable after follow_pfn")) and vfio (in 07956b6269d3 ("vfio/type1: Use

Re: [PATCH] drm/syncobj: use newly allocated stub fences

2021-04-08 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 06:34:48PM +0900, David Stevens wrote: > From: David Stevens > > Allocate a new private stub fence in drm_syncobj_assign_null_handle, > instead of using a static stub fence. > > When userspace creates a fence with DRM_SYNCOBJ_CREATE_SIGNALED or when > userspace signals a

Re: [PATCH 0/4] drm: Generic dumb_map_offset for TTM-based drivers

2021-04-08 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 01:34:03PM +0200, Thomas Zimmermann wrote: > Hi > > Am 08.04.21 um 13:16 schrieb Daniel Vetter: > > On Tue, Apr 06, 2021 at 10:29:38AM +0200, Thomas Zimmermann wrote: > > > The implementation of drm_driver.dumb_map_offset is the same for several > > > TTM-based drivers. Pro

Re: [PATCH 0/8] drm: Clean up mmap for TTM-based GEM drivers

2021-04-08 Thread Thomas Zimmermann
Hi Am 08.04.21 um 13:19 schrieb Daniel Vetter: On Tue, Apr 06, 2021 at 11:08:55AM +0200, Thomas Zimmermann wrote: Implement mmap via struct drm_gem_object_functions.mmap for amdgpu, radeon and nouveau. This allows for using common DRM helpers for the mmap-related callbacks in struct file_operat

Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv

2021-04-08 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 12:20:50PM +0200, Arnd Bergmann wrote: > On Thu, Apr 8, 2021 at 11:22 AM David Hildenbrand wrote: > > > > Random drivers should not override a user configuration of core knobs > > (e.g., CONFIG_DMA_CMA=n). Use "imply" instead, to still respect > > dependencies and manual ov

Re: [PATCH 0/2] Document how userspace should use plane format list and IN_FORMATS

2021-04-08 Thread Daniel Vetter
On Tue, Apr 06, 2021 at 04:21:16PM -0300, Leandro Ribeiro wrote: > This patch is to emphasize how userspace should use the plane format list and > the IN_FORMATS blob. The plane format list contains the formats that do not > require modifiers, and the blob property has the formats that support > mo

Re: [PATCH 0/4] drm: Generic dumb_map_offset for TTM-based drivers

2021-04-08 Thread Thomas Zimmermann
Hi Am 08.04.21 um 13:16 schrieb Daniel Vetter: On Tue, Apr 06, 2021 at 10:29:38AM +0200, Thomas Zimmermann wrote: The implementation of drm_driver.dumb_map_offset is the same for several TTM-based drivers. Provide a common function in GEM-TTM helpers. Out of curiosity, why does this not fit f

Re: [PATCH] drm/ttm: optimize the pool shrinker a bit

2021-04-08 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 01:17:32PM +0200, Christian König wrote: > Am 08.04.21 um 13:08 schrieb Daniel Vetter: > > On Thu, Apr 01, 2021 at 03:54:13PM +0200, Christian König wrote: > > > Switch back to using a spinlock again by moving the IOMMU unmap outside > > > of the locked region. > > > > > >

Re: [PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-08 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 12:59:19PM +0300, Pekka Paalanen wrote: > On Thu, 08 Apr 2021 08:39:10 + > Simon Ser wrote: > > > On Wednesday, April 7th, 2021 at 3:51 PM, Ville Syrjälä > > wrote: > > > > > > +* To find out the list of formats that support modifiers, > > > > userspace > >

Re: [PATCH -next] gma500: Use DEFINE_SPINLOCK() for spinlock

2021-04-08 Thread Daniel Vetter
On Tue, Apr 06, 2021 at 07:55:14PM +0800, Huang Guobin wrote: > From: Guobin Huang > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Reported-by: Hulk Robot > Signed-off-by: Guobin Huang Applied to drm-misc-next, thanks

Re: [PATCH 0/8] drm: Clean up mmap for TTM-based GEM drivers

2021-04-08 Thread Daniel Vetter
On Tue, Apr 06, 2021 at 11:08:55AM +0200, Thomas Zimmermann wrote: > Implement mmap via struct drm_gem_object_functions.mmap for amdgpu, > radeon and nouveau. This allows for using common DRM helpers for > the mmap-related callbacks in struct file_operations and struct > drm_driver. The drivers hav

Re: [PATCH] drm/ttm: optimize the pool shrinker a bit

2021-04-08 Thread Christian König
Am 08.04.21 um 13:08 schrieb Daniel Vetter: On Thu, Apr 01, 2021 at 03:54:13PM +0200, Christian König wrote: Switch back to using a spinlock again by moving the IOMMU unmap outside of the locked region. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_pool.c | 40 +++---

Re: [PATCH 0/4] drm: Generic dumb_map_offset for TTM-based drivers

2021-04-08 Thread Daniel Vetter
On Tue, Apr 06, 2021 at 10:29:38AM +0200, Thomas Zimmermann wrote: > The implementation of drm_driver.dumb_map_offset is the same for several > TTM-based drivers. Provide a common function in GEM-TTM helpers. Out of curiosity, why does this not fit for radeon/amdgpu? -Daniel > > Thomas Zimmerman

Re: [PATCH 0/8] drm/msm: Swappable GEM objects

2021-04-08 Thread Daniel Vetter
On Mon, Apr 05, 2021 at 10:45:23AM -0700, Rob Clark wrote: > From: Rob Clark > > One would normally hope not to be under enough memory pressure to need > to swap GEM objects to disk backed swap. But memory backed zram swap > (as enabled on chromebooks, for example) can actually be quite fast > a

[PATCH] drm/nouveau/hwmon: convert sysfs snprintf to sysfs_emit

2021-04-08 Thread Carlis
From: Xuezhi Zhang Fix the following coccicheck warning: drivers/gpu/drm//nouveau/nouveau_hwmon.c:44:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm//nouveau/nouveau_hwmon.c:57:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm//nouveau/nouveau_hwmon.c:90:8-16: WARNING: use scnpri

Re: [Intel-gfx] [PATCH v2 00/20] drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers

2021-04-08 Thread Jani Nikula
On Thu, 08 Apr 2021, Daniel Vetter wrote: > I think Dave caught up on pulls to drm-next, so after a backmerge of that > to drm-misc-next I think should be all fine to apply directly, no need for > topic branch. Yup. We've done the backmerges to drm-intel-next and drm-intel-gt-next, and are all in

Re: [PATCH v8 2/2] drm/tiny: add driver for newhaven,1.8-128160EF

2021-04-08 Thread Thomas Zimmermann
Hi, just trivial points below. In any case Acked-by: Thomas Zimmermann Am 31.03.21 um 11:21 schrieb Daniel Mack: This patch adds support for Newhaven's NHD-1.8-128160EF display, featuring an Ilitek ILI9163 controller. Signed-off-by: Daniel Mack Acked-by: Daniel Vetter --- drivers/gpu/drm

Re: [PATCH] drm/ttm: optimize the pool shrinker a bit

2021-04-08 Thread Daniel Vetter
On Thu, Apr 01, 2021 at 03:54:13PM +0200, Christian König wrote: > Switch back to using a spinlock again by moving the IOMMU unmap outside > of the locked region. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/ttm/ttm_pool.c | 40 +++--- > include/linux/sh

Re: [PATCH] drm/drm_internal.h: Remove repeated struct declaration

2021-04-08 Thread Daniel Vetter
On Thu, Apr 01, 2021 at 04:17:03PM +0800, Wan Jiabing wrote: > struct drm_gem_object is declared twice. One is declared > at 40th line. The blew one is not needed. Remove the duplicate. > > Signed-off-by: Wan Jiabing Pushed to drm-misc-next, thanks for your patch. -Daniel > --- > drivers/gpu/d

Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv

2021-04-08 Thread David Hildenbrand
In particular, it does not prevent a configuration with 'DRM_CMA=m' I assume you meant "DRM_CMA=n" ? DRM_CMA cannot be built as a module. Ok, at least that makes it easier. and 'DRMA_ASPEED_GFX=y', or any build failures from such a configuration. I don't follow. "DRM_CMA=n" and 'DRMA_ASPEE

Re: [PATCH] drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()

2021-04-08 Thread Daniel Vetter
On Wed, Apr 07, 2021 at 12:17:49PM +0200, Michal Simek wrote: > > > On 3/30/21 11:31 AM, Dan Carpenter wrote: > > The dp->train_set[] for this driver is only two characters, not four so > > this memsets too much. Fortunately, this ends up corrupting a struct > > hole and not anything important.

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-08 Thread Thomas Zimmermann
Hi, please see my comments below. Best regards Thomas Am 22.02.21 um 14:28 schrieb Kevin Tang: Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-

  1   2   >