Re: [PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-28 Thread Kenneth Graunke
On Monday, April 26, 2021 2:38:53 AM PDT Matthew Auld wrote: > Add an entry for the new uAPI needed for DG1. Also add the overall > upstream plan, including some notes for the TTM conversion. > > v2(Daniel): > - include the overall upstreaming plan > - add a note for mmap, there are

TGL: : No video output on external monitor after unplug and re-plug the cable

2021-04-28 Thread Chris Chiu
We found another bug after the fix of https://gitlab.freedesktop.org/drm/intel/-/issues/2538. The external monitor is also connected via WD19's HDMI/DisplayPort just as #2538. However, the display monitor can only be detected and show output at the very first time we power on the WD19 dock. If we

Re: [PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-28 Thread Kenneth Graunke
On Wednesday, April 28, 2021 9:56:25 AM PDT Jason Ekstrand wrote: > On Wed, Apr 28, 2021 at 11:41 AM Matthew Auld wrote: [snip] > > Slightly orthogonal: what does Mesa do here for snooped vs LLC > > platforms? Does it make such a distinction? Just curious. > > In Vulkan on non-LLC platforms, we

Re: [PATCH 6/9] drm/i915/uapi: implement object placement extension

2021-04-28 Thread Kenneth Graunke
On Monday, April 26, 2021 2:38:58 AM PDT Matthew Auld wrote: > Add new extension to support setting an immutable-priority-list of > potential placements, at creation time. > > If we use the normal gem_create or gem_create_ext without the > extensions/placements then we still get the old behaviour

Re: [PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-28 Thread Kenneth Graunke
On Monday, April 26, 2021 2:38:53 AM PDT Matthew Auld wrote: > +Existing uAPI issues > + > +Some potential issues we still need to resolve. > + > +I915 MMAP > +- > +In i915 there are multiple ways to MMAP GEM object, including mapping the > same > +object using

Re: [PATCHv2] drm/omap: Fix issue with clocks left on after resume

2021-04-28 Thread Tony Lindgren
Hi, * Laurent Pinchart [210428 14:10]: > Based on my experience on the camera and display side with devices that > are made of multiple components, suspend and resume are best handled in > a controlled way by the top-level driver. Otherwise you end up having > different components suspending and

[PATCH v6 1/3] gpu: drm: separate panel orientation property creating and value setting

2021-04-28 Thread Hsin-Yi Wang
drm_dev_register() sets connector->registration_state to DRM_CONNECTOR_REGISTERED and dev->registered to true. If drm_connector_set_panel_orientation() is first called after drm_dev_register(), it will fail several checks and results in following warning. Add a function to create panel

[PATCH v6 3/3] arm64: dts: mt8183: Add panel rotation

2021-04-28 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

[PATCH v6 2/3] drm/mediatek: init panel orientation property

2021-04-28 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c

[PATCH] drm/amd/display: Remove duplicate declaration of dc_state

2021-04-28 Thread Wan Jiabing
There are two declarations of struct dc_state here. The later one is closer to its user. Remove the former duplicate. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/amd/display/dc/dc.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h

[PATCH] drm/amd/display: Remove duplicate include of hubp.h

2021-04-28 Thread Wan Jiabing
In commit 482812d56698e ("drm/amd/display: Set max TTU on DPG enable"), "hubp.h" was added which caused the duplicate include. To be on the safe side, remove the later duplicate include. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/amd/display/dc/core/dc.c | 1 - 1 file changed, 1 deletion(-)

[PATCH] drm/i915: Use might_alloc()

2021-04-28 Thread Bernard Zhao
This maybe used lockdep through the fs_reclaim annotations. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/i915/i915_sw_fence.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_sw_fence.c b/drivers/gpu/drm/i915/i915_sw_fence.c index

Re: [PATCH v5 3/4] drm/i915: init panel orientation property

2021-04-28 Thread kernel test robot
Hi Hsin-Yi, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.12 next-20210428] [cannot apply to drm/drm-next] [If your patch

[PATCH] drm/i915: Use might_alloc()

2021-04-28 Thread Bernard Zhao
This maybe uses lockdep through the fs_reclaim annotations. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/i915/i915_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index

Re: [git pull] drm for 5.13-rc1

2021-04-28 Thread Alex Deucher
On Wed, Apr 28, 2021 at 8:14 PM Mikita Lipski wrote: > > Hi Linus, > > The patch to fix the warning is here > (https://www.spinics.net/lists/amd-gfx/msg61614.html) > > I guess it just didn't propagate all the way to the release. > Can it still be pulled into 5.13-rc1 release? I'll include it in

[PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-28 Thread Umesh Nerlige Ramappa
Perf measurements rely on CPU and engine timestamps to correlate events of interest across these time domains. Current mechanisms get these timestamps separately and the calculated delta between these timestamps lack enough accuracy. To improve the accuracy of these time measurements to within a

[PATCH 0/1] Add support for querying engine cycles

2021-04-28 Thread Umesh Nerlige Ramappa
This is just a refresh of the earlier patch along with cover letter for the IGT testing. The query provides the engine cs cycles counter. v2: Use GRAPHICS_VER() instead of IG_GEN() v3: Add R-b to the patch v4: Split cpu timestamp array into timestamp and delta for cleaner API Signed-off-by:

Re: [git pull] drm for 5.13-rc1

2021-04-28 Thread Mikita Lipski
Hi Linus, The patch to fix the warning is here (https://www.spinics.net/lists/amd-gfx/msg61614.html) I guess it just didn't propagate all the way to the release. Can it still be pulled into 5.13-rc1 release? From: Mikita Lipski [why] Previous statement would always evaluate to true making

[PATCH v8 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-28 Thread Nikola Cornij
[why] DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is set, Extended Base Receiver Capability DPCD space must be used. Without doing that, the three DPCD values that differ will be wrong, leading to incorrect or limited functionality. MST link rate, for example, could have a

[PATCH v8 0/1] drm/drm_mst: Use Extended Base Receiver Capability

2021-04-28 Thread Nikola Cornij
Change history: v8: - Chaged link lanes and rate parameters to u8 v7: - Fixed formatting - Fixed 'unused variable' compile warning - Fixed comment format v6: - Submited from (hopefully) the correct repo to fix build error v5: - Fixed min_t() macro arguments v4: - Fixed drm/radeon/

[PATCH v7 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-28 Thread Nikola Cornij
[why] DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is set, Extended Base Receiver Capability DPCD space must be used. Without doing that, the three DPCD values that differ will be wrong, leading to incorrect or limited functionality. MST link rate, for example, could have a

[PATCH v7 0/1] drm/drm_mst: Use Extended Base Receiver Capability

2021-04-28 Thread Nikola Cornij
Change history: v7: - Fixed formatting in drm_dp_mst_topology.c - Fixed 'unused variable' compile warning - Fixed comment format v6: - Submited from (hopefully) the correct repo to fix build error v5: - Fixed min_t() macro arguments v4: - Fixed drm/radeon/ lane count and rate v3: -

[PATCHv2 0/5] Support for GE B1x5v2 and B1x5Pv2

2021-04-28 Thread Sebastian Reichel
Hi, This series adds support for another General Electric patient monitor series (similar to existing Bx50v3), which is based on i.MX6DL using Congatec's QMX6 module. The module uses an I2C RTC to provide the i.MX6 32768 Hz clock, so it's important to keep it enabled. Not doing so results in

[PATCHv2 5/5] ARM: dts: imx6: Add GE B1x5v2

2021-04-28 Thread Sebastian Reichel
This adds device tree files for the General Electric Healthcare (GEHC) B1x5v2 series. All models make use of Congatec's QMX6 module, which is described in its own device tree include, so that it can also be used by other boards. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/Makefile

[PATCHv2 1/5] rtc: m41t80: add support for fixed clock

2021-04-28 Thread Sebastian Reichel
Congatec's QMX6 system on module (SoM) uses a m41t62 as RTC. The modules SQW clock output defaults to 32768 Hz. This behaviour is used to provide the i.MX6 CKIL clock. Once the RTC driver is probed, the clock is disabled and all i.MX6 functionality depending on the 32 KHz clock has undefined

[PATCHv2 2/5] drm/imx: Add 8 pixel alignment fix

2021-04-28 Thread Sebastian Reichel
Some standard resolutions like 1366x768 do not work properly with i.MX6 SoCs, since the horizontal resolution needs to be aligned to 8 pixels (so 1360x768 or 1368x768 would work). This patch allocates framebuffers allocated to 8 pixels. The extra time required to send the extra pixels are removed

[PATCHv2 3/5] dt-bindings: vendor-prefixes: add congatec

2021-04-28 Thread Sebastian Reichel
Document binding for congatec. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index

[PATCHv2 4/5] dt-bindings: arm: fsl: add GE B1x5pv2 boards

2021-04-28 Thread Sebastian Reichel
Document the compatible for GE B1x5pv2 boards. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/arm/fsl.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml

Re: [git pull] drm for 5.13-rc1

2021-04-28 Thread Linus Torvalds
On Tue, Apr 27, 2021 at 8:32 PM Dave Airlie wrote: > > This is the main drm pull request for 5.13. The usual lots of work all > over the place. [...] > > Mikita Lipski: > drm/amd/display: Add MST capability to trigger_hotplug interface Hmm. I've already merged this, but my clang build

Re: [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification

2021-04-28 Thread Hans de Goede
Hi, On 4/28/21 11:52 PM, Hans de Goede wrote: > Hi All, > > Here is a new attempt to make DP over Type-C work on devices where the > Type-C controller does not drive the HPD pin on the GPU, but instead > we need to forward HPD events from the Type-C controller to the DRM driver. > > For anyone

[PATCH 9/9] platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference

2021-04-28 Thread Hans de Goede
The Type-C connector on these devices is connected to DP-2 not DP-1, so the reference must be to the DD04 child-node of the GPU, rather then the DD02 child-node. Signed-off-by: Hans de Goede --- drivers/platform/x86/intel_cht_int33fe_typec.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 8/9] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2021-04-28 Thread Hans de Goede
Use the new drm_connector_find_by_fwnode() and drm_connector_oob_hotplug_event() functions to let drm/kms drivers know about DisplayPort over Type-C hotplug events. Signed-off-by: Hans de Goede --- drivers/usb/typec/altmodes/displayport.c | 45 +++- 1 file changed, 44

[PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries

2021-04-28 Thread Hans de Goede
From: Heikki Krogerus On Intel platforms we know that the ACPI connector device node order will follow the order the driver (i915) decides. The decision is made using the custom Intel ACPI OpRegion (intel_opregion.c), though the driver does not actually know that the values it sends to ACPI

[PATCH 6/9] drm/i915/dp: Add support for out-of-bound hotplug events

2021-04-28 Thread Hans de Goede
On some Cherry Trail devices, DisplayPort over Type-C is supported through a USB-PD microcontroller (e.g. a fusb302) + a mux to switch the superspeed datalines between USB-3 and DP (e.g. a pi3usb30532). The kernel in this case does the PD/alt-mode negotiation itself, rather then everything being

[PATCH 7/9] usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic

2021-04-28 Thread Hans de Goede
Make dp_altmode_notify() handle the dp->data.conf == 0 case too, rather then having separate code-paths for this in various places which call it. Signed-off-by: Hans de Goede --- drivers/usb/typec/altmodes/displayport.c | 35 +--- 1 file changed, 13 insertions(+), 22

[PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification

2021-04-28 Thread Hans de Goede
Add a new drm_connector_oob_hotplug_event() function and oob_hotplug_event drm_connector_funcs member. On some hardware a hotplug event notification may come from outside the display driver / device. An example of this is some USB Type-C setups where the hardware muxes the DisplayPort data and

[PATCH 3/9] drm/connector: Add drm_connector_find_by_fwnode() function

2021-04-28 Thread Hans de Goede
Add a function which allows other subsystems to find a connector based on a fwnode. This will be used by the USB-Type-C code to be able to find the DP connector to which to send hotplug events received by a Type-C port in DP-alternate-mode. Note this function is defined in

[PATCH 2/9] drm/connector: Add a fwnode pointer to drm_connector and register with ACPI

2021-04-28 Thread Hans de Goede
Add a fwnode pointer to struct drm_connector and register an acpi_bus_type for the connectors with the ACPI subsystem (when CONFIG_ACPI is enabled). The adding of the fwnode pointer allows drivers to associate a fwnode that represents a connector with that connector. When the new fwnode pointer

[PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-28 Thread Hans de Goede
Userspace could hold open a reference to the connector->kdev device, through e.g. holding a sysfs-atrtribute open after drm_sysfs_connector_remove() has been called. In this case the connector could be free-ed while the connector->kdev device's drvdata is still pointing to it. Give drm_connector

[PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification

2021-04-28 Thread Hans de Goede
Hi All, Here is a new attempt to make DP over Type-C work on devices where the Type-C controller does not drive the HPD pin on the GPU, but instead we need to forward HPD events from the Type-C controller to the DRM driver. For anyone interested here are the old (2019!) patches for this:

Re: [PATCH v2 1/1] drm/doc: document drm_mode_get_plane

2021-04-28 Thread Leandro Ribeiro
On 4/27/21 6:00 AM, Daniel Vetter wrote: > On Tue, Apr 27, 2021 at 10:40:24AM +0300, Pekka Paalanen wrote: >> On Mon, 26 Apr 2021 14:30:53 -0300 >> Leandro Ribeiro wrote: >> >>> On 4/26/21 7:58 AM, Simon Ser wrote: On Monday, April 26th, 2021 at 9:36 AM, Pekka Paalanen wrote:

[PATCH 1/2] drm/doc: document how userspace should find out CRTC index

2021-04-28 Thread Leandro Ribeiro
In this patch we add a section to document what userspace should do to find out the CRTC index. This is important as there are multiple places in the documentation that need this, so it's better to just point to this section and avoid repetition. Signed-off-by: Leandro Ribeiro ---

[PATCH 2/2] drm/doc: document drm_mode_get_plane

2021-04-28 Thread Leandro Ribeiro
Add a small description and document struct fields of drm_mode_get_plane. Signed-off-by: Leandro Ribeiro --- include/uapi/drm/drm_mode.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index

[PATCH v3 0/2] Document drm_mode_get_plane

2021-04-28 Thread Leandro Ribeiro
v2: possible_crtcs field is a bitmask, not a pointer. Suggested by Ville Syrjälä v3: document how userspace should find out CRTC index. Also, document that field 'gamma_size' represents the number of entries in the lookup table. Suggested by Pekka Paalanen and Daniel Vetter Leandro Ribeiro

Re: 16 bpc fixed point (RGBA16) framebuffer support for core and AMD.

2021-04-28 Thread Alex Deucher
On Tue, Apr 20, 2021 at 5:25 PM Alex Deucher wrote: > > On Fri, Apr 16, 2021 at 12:29 PM Mario Kleiner > wrote: > > > > Friendly ping to the AMD people. Nicholas, Harry, Alex, any feedback? > > Would be great to get this in sooner than later. > > > > No objections from me. > I don't have any

Re: [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-28 Thread Lionel Landwerlin
On 28/04/2021 23:45, Jason Ekstrand wrote: On Wed, Apr 28, 2021 at 3:14 PM Lionel Landwerlin wrote: On 28/04/2021 22:54, Jason Ekstrand wrote: On Wed, Apr 28, 2021 at 2:50 PM Lionel Landwerlin wrote: On 28/04/2021 22:24, Jason Ekstrand wrote: On Wed, Apr 28, 2021 at 3:43 AM Jani Nikula

Re: [PATCH] drm/amd/display: Fix build warnings

2021-04-28 Thread Alex Deucher
On Wed, Apr 21, 2021 at 12:18 PM Guenter Roeck wrote: > > Fix the following build warnings. > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: > In function ‘dm_update_mst_vcpi_slots_for_dsc’: > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6242:46: >

Re: [PATCH] drm/amd/amdgpu: Fix errors in documentation of function parameters

2021-04-28 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Apr 23, 2021 at 7:38 AM Fabio M. De Francesco wrote: > > In the function documentation, I removed the excess parameters, > described the undocumented ones, and fixed the syntax errors. > > Signed-off-by: Fabio M. De Francesco > --- >

Re: [PATCH] drm/amd/display: Remove condition which is always set to True

2021-04-28 Thread Alex Deucher
On Fri, Apr 23, 2021 at 4:57 PM Souptick Joarder wrote: > > Kernel test robot throws below warning -> > > >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:3015:53: > >> warning: address of 'aconnector->mst_port->mst_mgr' will always > >> evaluate to 'true'

Re: [PATCH v2] drm/amd/pm/powerplay/hwmgr: Fix kernel-doc syntax in documentation

2021-04-28 Thread Alex Deucher
On Sat, Apr 24, 2021 at 6:19 PM Fabio M. De Francesco wrote: > > Fixed kernel-doc syntax errors in documentation of functions. > > Signed-off-by: Fabio M. De Francesco Applied. Thanks! Alex > --- > > Changes from v1: Reword both the subject and the log message > >

Re: [PULL] drm-misc-next-fixes

2021-04-28 Thread Alex Deucher
On Mon, Apr 26, 2021 at 3:35 AM Maxime Ripard wrote: > > Hi Alex, > > On Thu, Apr 22, 2021 at 12:40:10PM -0400, Alex Deucher wrote: > > On Thu, Apr 22, 2021 at 12:33 PM Maxime Ripard wrote: > > > > > > Hi Dave, Daniel, > > > > > > Here's this week drm-misc-next-fixes PR, for the next merge

Re: [PATCH v2] drm/amdgpu: Register VGA clients after init can no longer fail

2021-04-28 Thread Alex Deucher
On Mon, Apr 26, 2021 at 6:50 AM Kai-Heng Feng wrote: > > When an amdgpu device fails to init, it makes another VGA device cause > kernel splat: > kernel: amdgpu :08:00.0: amdgpu: amdgpu_device_ip_init failed > kernel: amdgpu :08:00.0: amdgpu: Fatal error during GPU init > kernel: amdgpu:

Re: [PATCH v6 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-28 Thread Alex Deucher
+ dri-devel as well. On Wed, Apr 28, 2021 at 4:44 PM Nikola Cornij wrote: > > [why] > DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is > set, Extended Base Receiver Capability DPCD space must be used. Without > doing that, the three DPCD values that differ will be wrong,

Re: [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-28 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 3:14 PM Lionel Landwerlin wrote: > > On 28/04/2021 22:54, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 2:50 PM Lionel Landwerlin > > wrote: > >> On 28/04/2021 22:24, Jason Ekstrand wrote: > >> > >> On Wed, Apr 28, 2021 at 3:43 AM Jani Nikula > >> wrote: > >> > >>

Re: [Mesa-dev] [RFC] Linux Graphics Next: Explicit fences everywhere and no BO fences - initial proposal

2021-04-28 Thread Alex Deucher
On Wed, Apr 28, 2021 at 10:35 AM Daniel Vetter wrote: > > On Wed, Apr 28, 2021 at 03:37:49PM +0200, Christian König wrote: > > Am 28.04.21 um 15:34 schrieb Daniel Vetter: > > > On Wed, Apr 28, 2021 at 03:11:27PM +0200, Christian König wrote: > > > > Am 28.04.21 um 14:26 schrieb Daniel Vetter: > >

Re: [PATCH v5 3/4] drm/i915: init panel orientation property

2021-04-28 Thread Sean Paul
On Wed, Apr 28, 2021 at 1:04 PM Hsin-Yi Wang wrote: > > Creating the panel orientation property first since we separate the > property creating and value setting. This should probably be included in patch 1 so you don't regress i915 in between patches. Sean > > Signed-off-by: Hsin-Yi Wang >

Re: [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-28 Thread Lionel Landwerlin
On 28/04/2021 23:14, Lionel Landwerlin wrote: On 28/04/2021 22:54, Jason Ekstrand wrote: On Wed, Apr 28, 2021 at 2:50 PM Lionel Landwerlin wrote: On 28/04/2021 22:24, Jason Ekstrand wrote: On Wed, Apr 28, 2021 at 3:43 AM Jani Nikula wrote: On Tue, 27 Apr 2021, Umesh Nerlige Ramappa

Re: [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-28 Thread Lionel Landwerlin
On 28/04/2021 22:54, Jason Ekstrand wrote: On Wed, Apr 28, 2021 at 2:50 PM Lionel Landwerlin wrote: On 28/04/2021 22:24, Jason Ekstrand wrote: On Wed, Apr 28, 2021 at 3:43 AM Jani Nikula wrote: On Tue, 27 Apr 2021, Umesh Nerlige Ramappa wrote: Perf measurements rely on CPU and engine

Re: [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-28 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 2:50 PM Lionel Landwerlin wrote: > > On 28/04/2021 22:24, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 3:43 AM Jani Nikula > wrote: > > On Tue, 27 Apr 2021, Umesh Nerlige Ramappa > wrote: > > Perf measurements rely on CPU and engine timestamps to correlate >

Re: [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-28 Thread Lionel Landwerlin
On 28/04/2021 22:24, Jason Ekstrand wrote: On Wed, Apr 28, 2021 at 3:43 AM Jani Nikula wrote: On Tue, 27 Apr 2021, Umesh Nerlige Ramappa wrote: Perf measurements rely on CPU and engine timestamps to correlate events of interest across these time domains. Current mechanisms get these

[PATCH 2/2] drm/msm: Periodically update RPTR shadow

2021-04-28 Thread Rob Clark
From: Rob Clark On a5xx and a6xx devices that are using CP_WHERE_AM_I to update a ringbuffer read-ptr shadow value, periodically emit a CP_WHERE_AM_I every 32 commands, so that a later submit waiting for ringbuffer space to become available sees partial progress, rather than not seeing rptr

[PATCH 1/2] drm/msm: Handle ringbuffer overflow

2021-04-28 Thread Rob Clark
From: Rob Clark Currently if userspace manages to fill up the ring faster than the GPU can consume we (a) spin for up to 1sec, and then (b) overwrite the ringbuffer contents from previous submits that the GPU is still busy executing. Which predictably goes rather badly. Instead, just skip

[PATCH 0/2] drm/msm: Smooth out ringbuffer-full handling

2021-04-28 Thread Rob Clark
From: Rob Clark With some recent userspace work to allow more rendering to be merged into a single SUBMIT ioctl, I realized we have some sharp edges around running out of free ringbuffer space. 1) Currently we only flush once all the cmds (or rather IBs to the cmd buffer) are written into

Re: [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-28 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 3:43 AM Jani Nikula wrote: > > On Tue, 27 Apr 2021, Umesh Nerlige Ramappa > wrote: > > Perf measurements rely on CPU and engine timestamps to correlate > > events of interest across these time domains. Current mechanisms get > > these timestamps separately and the

Re: [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-28 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 12:18 PM Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 5:13 AM Daniel Vetter wrote: > > > > On Tue, Apr 27, 2021 at 08:51:08AM -0500, Jason Ekstrand wrote: > > > I sent a v2 of this patch because it turns out I deleted a bit too > > > much code. This function in

Re: [PATCH 11/21] drm/i915: Stop manually RCU banging in reset_stats_ioctl

2021-04-28 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 5:27 AM Daniel Vetter wrote: > > On Fri, Apr 23, 2021 at 05:31:21PM -0500, Jason Ekstrand wrote: > > As far as I can tell, the only real reason for this is to avoid taking a > > reference to the i915_gem_context. The cost of those two atomics > > probably pales in

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-28 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 1:02 PM Matthew Brost wrote: > > On Wed, Apr 28, 2021 at 12:46:07PM -0500, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 12:26 PM Matthew Brost > > wrote: > > > > > > On Wed, Apr 28, 2021 at 12:18:29PM -0500, Jason Ekstrand wrote: > > > > On Wed, Apr 28, 2021 at 5:13

Re: [git pull] drm for 5.13-rc1

2021-04-28 Thread Linus Torvalds
On Wed, Apr 28, 2021 at 11:14 AM Daniel Vetter wrote: > > Maybe we're overdoing it a bit, but we're trying to not backmerge all > the time for no reason at all. Oh, I'm not complaining. I think it's reasonable if some particular issue doesn't hold up further development. So my email was more a

Re: [git pull] drm for 5.13-rc1

2021-04-28 Thread Daniel Vetter
On Wed, Apr 28, 2021 at 7:07 PM Linus Torvalds wrote: > On Tue, Apr 27, 2021 at 8:32 PM Dave Airlie wrote: > > > > There aren't a massive amount of conflicts, only with vmwgfx when I > > did a test merge into your master yesterday, I think you should be > > able to handle them yourself, but let

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-28 Thread Matthew Brost
On Wed, Apr 28, 2021 at 12:46:07PM -0500, Jason Ekstrand wrote: > On Wed, Apr 28, 2021 at 12:26 PM Matthew Brost > wrote: > > > > On Wed, Apr 28, 2021 at 12:18:29PM -0500, Jason Ekstrand wrote: > > > On Wed, Apr 28, 2021 at 5:13 AM Daniel Vetter wrote: > > > > > > > > On Tue, Apr 27, 2021 at

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-28 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 12:26 PM Matthew Brost wrote: > > On Wed, Apr 28, 2021 at 12:18:29PM -0500, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 5:13 AM Daniel Vetter wrote: > > > > > > On Tue, Apr 27, 2021 at 08:51:08AM -0500, Jason Ekstrand wrote: > > > > On Fri, Apr 23, 2021 at 5:31 PM

RE: [PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-28 Thread Bloomfield, Jon
> -Original Message- > From: Auld, Matthew > Sent: Monday, April 26, 2021 2:39 AM > To: intel-...@lists.freedesktop.org > Cc: Joonas Lahtinen ; Thomas Hellström > ; Ceraolo Spurio, Daniele > ; Lionel Landwerlin > ; Bloomfield, Jon > ; Justen, Jordan L ; > Vetter, Daniel ; Kenneth Graunke

Re: [Intel-gfx] [PATCH 05/21] drm/i915: Drop the CONTEXT_CLONE API

2021-04-28 Thread Jason Ekstrand
On Tue, Apr 27, 2021 at 4:49 AM Daniel Vetter wrote: > > On Fri, Apr 23, 2021 at 05:31:15PM -0500, Jason Ekstrand wrote: > > This API allows one context to grab bits out of another context upon > > creation. It can be used as a short-cut for setparam(getparam()) for > > things like

[PATCH] drm/i915/display Try YCbCr420 color when RGB fails

2021-04-28 Thread Werner Sembach
When encoder validation of a display mode fails, retry with less bandwidth heavy YCbCr420 color mode, if available. This enables some HDMI 1.4 setups to support 4k60Hz output, which previously failed silently. AMDGPU had nearly the exact same issue. This problem description is therefore copied

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-28 Thread khsieh
On 2021-04-27 17:00, Stephen Boyd wrote: Quoting aravi...@codeaurora.org (2021-04-21 11:55:21) On 2021-04-21 10:26, khs...@codeaurora.org wrote: >> >>> + >>> mutex_unlock(>event_mutex); >>> >>> return 0; >>> @@ -1496,6 +1502,9 @@ int msm_dp_display_disable(struct msm_dp *dp, >>>

Re: [git pull] drm for 5.13-rc1

2021-04-28 Thread pr-tracker-bot
The pull request you sent on Wed, 28 Apr 2021 13:31:59 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2021-04-28 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/68a32ba14177d4a21c4a9a941cf1d7aea86d436f Thank you! -- Deet-doot-dot, I am a bot.

[PATCH] drm/i915: Add relocation exceptions for two other platforms

2021-04-28 Thread Zbigniew Kempczyński
We have established previously we stop using relocations starting from gen12 platforms with Tigerlake as an exception. Unfortunately we need extend transition period and support relocations for two other igfx platforms - Rocketlake and Alderlake. As Alderlake is coming in two variants - S and P

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-28 Thread Matthew Brost
On Wed, Apr 28, 2021 at 12:18:29PM -0500, Jason Ekstrand wrote: > On Wed, Apr 28, 2021 at 5:13 AM Daniel Vetter wrote: > > > > On Tue, Apr 27, 2021 at 08:51:08AM -0500, Jason Ekstrand wrote: > > > On Fri, Apr 23, 2021 at 5:31 PM Jason Ekstrand > > > wrote: > > > > > > > > This adds a bunch of

Re: [Intel-gfx] [PATCH 06/21] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v3)

2021-04-28 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 10:49 AM Tvrtko Ursulin wrote: > > > On 23/04/2021 23:31, Jason Ekstrand wrote: > > This API is entirely unnecessary and I'd love to get rid of it. If > > userspace wants a single timeline across multiple contexts, they can > > either use implicit synchronization or a

Re: [Intel-gfx] [PATCH 03/21] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem

2021-04-28 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 10:55 AM Tvrtko Ursulin wrote: > On 23/04/2021 23:31, Jason Ekstrand wrote: > > Instead of handling it like a context param, unconditionally set it when > > intel_contexts are created. This doesn't fix anything but does simplify > > the code a bit. > > > > Signed-off-by:

Re: [PATCH v5 09/27] dmr/amdgpu: Move some sysfs attrs creation to default_attr

2021-04-28 Thread Bjorn Helgaas
In subject, s/dmr/drm/ s/Move some/Move/ ("some" consumes space without adding meaning) Or maybe something like: drm/amdgpu: Convert driver sysfs attributes to static attributes On Wed, Apr 28, 2021 at 11:11:49AM -0400, Andrey Grodzovsky wrote: > This allows to remove explicit creation and

Re: [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-28 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 5:13 AM Daniel Vetter wrote: > > On Tue, Apr 27, 2021 at 08:51:08AM -0500, Jason Ekstrand wrote: > > On Fri, Apr 23, 2021 at 5:31 PM Jason Ekstrand wrote: > > > > > > This adds a bunch of complexity which the media driver has never > > > actually used. The media driver

Re: [Intel-gfx] [PATCH 09/21] drm/i915/gem: Disallow creating contexts with too many engines

2021-04-28 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 9:26 AM Tvrtko Ursulin wrote: > On 28/04/2021 15:02, Daniel Vetter wrote: > > On Wed, Apr 28, 2021 at 11:42:31AM +0100, Tvrtko Ursulin wrote: > >> > >> On 28/04/2021 11:16, Daniel Vetter wrote: > >>> On Fri, Apr 23, 2021 at 05:31:19PM -0500, Jason Ekstrand wrote: >

Re: [PATCH v5 00/27] RFC Support hot device unplug in amdgpu

2021-04-28 Thread Bjorn Helgaas
On Wed, Apr 28, 2021 at 11:11:40AM -0400, Andrey Grodzovsky wrote: > Until now extracting a card either by physical extraction (e.g. eGPU with > thunderbolt connection or by emulation through syfs -> > /sys/bus/pci/devices/device_id/remove) > would cause random crashes in user apps. The random

Re: [git pull] drm for 5.13-rc1

2021-04-28 Thread Linus Torvalds
On Tue, Apr 27, 2021 at 8:32 PM Dave Airlie wrote: > > There aren't a massive amount of conflicts, only with vmwgfx when I > did a test merge into your master yesterday, I think you should be > able to handle them yourself, but let me know if you want me to push a > merged tree somewhere (or if I

[PATCH v5 2/4] drm/mediatek: init panel orientation property

2021-04-28 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c

[PATCH v5 4/4] arm64: dts: mt8183: Add panel rotation

2021-04-28 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

[PATCH v5 3/4] drm/i915: init panel orientation property

2021-04-28 Thread Hsin-Yi Wang
Creating the panel orientation property first since we separate the property creating and value setting. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/i915/display/icl_dsi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + drivers/gpu/drm/i915/display/vlv_dsi.c | 1 + 3 files changed,

[PATCH v5 1/4] gpu: drm: separate panel orientation property creating and value setting

2021-04-28 Thread Hsin-Yi Wang
drm_dev_register() sets connector->registration_state to DRM_CONNECTOR_REGISTERED and dev->registered to true. If drm_connector_set_panel_orientation() is first called after drm_dev_register(), it will fail several checks and results in following warning. Add a function to create panel

Re: [PATCH 1/2] drm/ttm: Don't evict SG BOs

2021-04-28 Thread Felix Kuehling
Am 2021-04-28 um 12:58 p.m. schrieb Christian König: > Am 28.04.21 um 18:49 schrieb Felix Kuehling: >> Am 2021-04-28 um 12:33 p.m. schrieb Christian König: >>> Am 28.04.21 um 17:19 schrieb Felix Kuehling: >>> [SNIP] >> Failing that, I'd probably have to abandon userptr BOs altogether >>

Re: [PATCH 1/2] drm/ttm: Don't evict SG BOs

2021-04-28 Thread Christian König
Am 28.04.21 um 18:49 schrieb Felix Kuehling: Am 2021-04-28 um 12:33 p.m. schrieb Christian König: Am 28.04.21 um 17:19 schrieb Felix Kuehling: [SNIP] Failing that, I'd probably have to abandon userptr BOs altogether and switch system memory mappings over to using the new SVM API on systems

Re: [PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-28 Thread Jason Ekstrand
On Wed, Apr 28, 2021 at 11:41 AM Matthew Auld wrote: > > On 28/04/2021 16:51, Jason Ekstrand wrote: > > On Mon, Apr 26, 2021 at 4:42 AM Matthew Auld wrote: > >> > >> Add an entry for the new uAPI needed for DG1. Also add the overall > >> upstream plan, including some notes for the TTM

Re: [PATCH v5 08/27] PCI: add support for dev_groups to struct pci_device_driver

2021-04-28 Thread Bjorn Helgaas
In subject: s/PCI: add support/PCI: Add support/ to match convention ("git log --oneline drivers/pci/pci-driver.c" to learn this). On Wed, Apr 28, 2021 at 11:11:48AM -0400, Andrey Grodzovsky wrote: > This is exact copy of 'USB: add support for dev_groups to > struct usb_device_driver' patch by

Re: [PATCH v5 18/20] drm/panel: panel-simple: Cache the EDID as long as we retain power

2021-04-28 Thread Sean Paul
On Fri, Apr 23, 2021 at 1:00 PM Douglas Anderson wrote: > > It doesn't make sense to go out to the bus and read the EDID over and > over again. Let's cache it and throw away the cache when we turn power > off from the panel. Autosuspend means that even if there are several > calls to read the

Re: [PATCH 1/2] drm/ttm: Don't evict SG BOs

2021-04-28 Thread Felix Kuehling
Am 2021-04-28 um 12:33 p.m. schrieb Christian König: > Am 28.04.21 um 17:19 schrieb Felix Kuehling: >> Am 2021-04-28 um 5:05 a.m. schrieb Christian König: >> [SNIP] >> Hmm, I was missing something. The amdgpu_gtt_mgr doesn't actually >> allocate space for many BOs: >> >> if (!place->lpfn)

Re: [PATCH v5 17/20] drm/panel: panel-simple: Power the panel when reading the EDID

2021-04-28 Thread Sean Paul
On Fri, Apr 23, 2021 at 1:00 PM Douglas Anderson wrote: > > I don't believe that it ever makes sense to read the EDID when a panel > is not powered and the powering on of the panel is the job of > prepare(). Let's make sure that this happens before we try to read the > EDID. We use the pm_runtime

Re: [PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-28 Thread Matthew Auld
On 28/04/2021 16:51, Jason Ekstrand wrote: On Mon, Apr 26, 2021 at 4:42 AM Matthew Auld wrote: Add an entry for the new uAPI needed for DG1. Also add the overall upstream plan, including some notes for the TTM conversion. v2(Daniel): - include the overall upstreaming plan - add a note

Re: [PATCH v5 16/20] drm/panel: panel-simple: Remove extra call: drm_connector_update_edid_property()

2021-04-28 Thread Sean Paul
On Fri, Apr 23, 2021 at 1:00 PM Douglas Anderson wrote: > > As of commit 5186421cbfe2 ("drm: Introduce epoch counter to > drm_connector") the drm_get_edid() function calls > drm_connector_update_edid_property() for us. There's no reason for us > to call it again. > > Signed-off-by: Douglas

Re: [PATCH v5 10/20] drm/panel: panel-simple: Get rid of hacky HPD chicken-and-egg code

2021-04-28 Thread Sean Paul
On Fri, Apr 23, 2021 at 1:00 PM Douglas Anderson wrote: > > When I added support for the hpd-gpio to simple-panel in commit > 48834e6084f1 ("drm/panel-simple: Support hpd-gpios for delaying > prepare()"), I added a special case to handle a circular dependency I > was running into on the

Re: [PATCH 1/2] drm/ttm: Don't evict SG BOs

2021-04-28 Thread Christian König
Am 28.04.21 um 17:19 schrieb Felix Kuehling: Am 2021-04-28 um 5:05 a.m. schrieb Christian König: [SNIP] Hmm, I was missing something. The amdgpu_gtt_mgr doesn't actually allocate space for many BOs: if (!place->lpfn) { mem->mm_node = NULL; mem->start =

  1   2   3   >