Re: [PATCH] drm/meson: fix shutdown crash when component not probed

2021-05-02 Thread Martin Blumenstingl
On Fri, Apr 30, 2021 at 10:28 AM Neil Armstrong wrote: > > When main component is not probed, by example when the dw-hdmi module is > not loaded yet or in probe defer, the following crash appears on shutdown: > > Unable to handle kernel NULL pointer dereference at virtual address > 00

[PATCH 0/2] drm/radeon: Fix off-by-one power_state index heap overwrite

2021-05-02 Thread Kees Cook
Hi, This is an attempt at fixing a bug[1] uncovered by the relocation of the slab freelist pointer offset, as well as some related clean-ups. I don't have hardware to do runtime testing, but it builds. ;) -Kees [1] https://bugzilla.kernel.org/show_bug.cgi?id=211537 Kees Cook (2): drm/radeon:

[PATCH 1/2] drm/radeon: Fix off-by-one power_state index heap overwrite

2021-05-02 Thread Kees Cook
An out of bounds write happens when setting the default power state. KASAN sees this as: [drm] radeon: 512M of GTT memory ready. [drm] GART: num cpu pages 131072, num gpu pages 131072 == BUG: KASAN: slab-out-of-bounds in radeon_atombi

[PATCH 2/2] drm/radeon: Avoid power table parsing memory leaks

2021-05-02 Thread Kees Cook
Avoid leaving a hanging pre-allocated clock_info if last mode is invalid, and avoid heap corruption if no valid modes are found. Fixes: 6991b8f2a319 ("drm/radeon/kms: fix segfault in pm rework") Signed-off-by: Kees Cook --- drivers/gpu/drm/radeon/radeon_atombios.c | 20 +++- 1 fi

Re: [PATCH 1/2] drm/dp: Handle zeroed port counts in drm_dp_read_downstream_info()

2021-05-02 Thread Ville Syrjälä
On Fri, Apr 30, 2021 at 06:34:27PM -0400, Lyude Paul wrote: > While the DP specification isn't entirely clear on if this should be > allowed or not, some branch devices report having downstream ports present > while also reporting a downstream port count of 0. So to avoid breaking > those devices,

Re: [Intel-gfx] [PATCH 2/2] drm/dp: Drop open-coded drm_dp_is_branch() in drm_dp_read_downstream_info()

2021-05-02 Thread Ville Syrjälä
On Fri, Apr 30, 2021 at 06:34:28PM -0400, Lyude Paul wrote: > Noticed this while fixing another issue in drm_dp_read_downstream_info(), > the open coded DP_DOWNSTREAMPORT_PRESENT check here just duplicates what we > already do in drm_dp_is_branch(), so just get rid of it. > > Signed-off-by: Lyude

Re: [PATCH v3 0/9] Add 4 Jenson simple panels

2021-05-02 Thread Giulio Benetti
Hello Thierry, I've seen that this patchset [1] in DRI Patchwork has been archived, but it's not been applied and all patches result as "New", so I've set them as un-archived. Hope it's correct. [1]: https://patchwork.kernel.org/project/dri-devel/list/?series=459931 [2]: https://patchwork.ker

Re: [Freedreno] [PATCH 5/5] drm/msm: deprecate MSM_BO_UNCACHED (map as writecombine instead)

2021-05-02 Thread Jordan Crouse
On Fri, Apr 23, 2021 at 03:08:21PM -0400, Jonathan Marek wrote: > There shouldn't be any reason to ever use uncached over writecombine, > so just use writecombine for MSM_BO_UNCACHED. Extremely correct. > > Note: userspace never used MSM_BO_UNCACHED anyway > Acked-by: Jordan Crouse > Signed-

Re: [PATCH 3/5] drm/msm: use the right pgprot when mapping BOs in the kernel

2021-05-02 Thread Jordan Crouse
On Fri, Apr 23, 2021 at 03:08:19PM -0400, Jonathan Marek wrote: > Use the same logic as the userspace mapping. > > This fixes msm_rd with cached BOs. > Acked-by: Jordan Crouse > Signed-off-by: Jonathan Marek > --- > drivers/gpu/drm/msm/msm_gem.c | 19 +++ > 1 file changed, 11

Re: [PATCH 2/5] drm/msm: replace MSM_BO_UNCACHED with MSM_BO_WC for internal objects

2021-05-02 Thread Jordan Crouse
On Fri, Apr 23, 2021 at 03:08:18PM -0400, Jonathan Marek wrote: > msm_gem_get_vaddr() currently always maps as writecombine, so use the right > flag instead of relying on broken behavior (things don't actually work if > they are mapped as uncached). Ugh - I can't believe this was stil in there. A

Re: [PATCH 1/5] drm/msm: remove unnecessary mmap logic for cached BOs

2021-05-02 Thread Jordan Crouse
On Fri, Apr 23, 2021 at 03:08:17PM -0400, Jonathan Marek wrote: > No one knows what this is for anymore, so just remove it. Acked-by: Jordan Crouse > Signed-off-by: Jonathan Marek > --- > drivers/gpu/drm/msm/msm_gem.c | 15 +++ > 1 file changed, 3 insertions(+), 12 deletions(-) >

Re: [PATCH 2/2] drm/msm: Periodically update RPTR shadow

2021-05-02 Thread Jordan Crouse
On Wed, Apr 28, 2021 at 12:36:49PM -0700, Rob Clark wrote: > From: Rob Clark > > On a5xx and a6xx devices that are using CP_WHERE_AM_I to update a > ringbuffer read-ptr shadow value, periodically emit a CP_WHERE_AM_I > every 32 commands, so that a later submit waiting for ringbuffer > space to be

[PATCH 6/7] drm/via: Remove references to drm_device.pdev

2021-05-02 Thread Thomas Zimmermann
Replace all references to struct drm_device's pdev field with an upcast from dev. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/via/via_dmablit.c | 15 +-- drivers/gpu/drm/via/via_map.c | 3 ++- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/d

[PATCH 2/7] drm/mga: Remove references to struct drm_device.pdev

2021-05-02 Thread Thomas Zimmermann
Replace all references to struct drm_device's pdev field with an upcast from dev. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mga/mga_dma.c | 13 +++-- drivers/gpu/drm/mga/mga_state.c | 3 ++- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/mga/

[PATCH 5/7] drm/sis: Remove references to struct drm_device.pdev

2021-05-02 Thread Thomas Zimmermann
Replace all references to struct drm_device's pdev field with an upcast from dev. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/sis/sis_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sis/sis_drv.c b/drivers/gpu/drm/sis/sis_drv.c index 2c54b33ab

[PATCH 7/7] drm: Remove pdev field from struct drm_device

2021-05-02 Thread Thomas Zimmermann
The field pdev in struct drm_device is unused. Remove it. The value can be obtained by upcasting from the structure's dev field. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_pci.c | 1 - include/drm/drm_device.h | 3 --- 2 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH 0/7] drm: Completely remove struct drm_device.pdev

2021-05-02 Thread Thomas Zimmermann
The pdev field in struct drm_device was recently moved into the legacy section. Remove it entirely. References are replaced with upcasts from the structure's dev field. This change only affects legacy drivers for userspace modesetting. Thomas Zimmermann (7): drm/i810: Remove references to struct

[PATCH 4/7] drm/savage: Remove references to struct drm_device.pdev

2021-05-02 Thread Thomas Zimmermann
Replace all references to struct drm_device's pdev field with an upcast from dev. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/savage/savage_bci.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drive

[PATCH 3/7] drm/r128: Remove references to struct drm_device.pdev

2021-05-02 Thread Thomas Zimmermann
Replace all references to struct drm_device's pdev field with an upcast from dev. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/r128/ati_pcigart.c | 11 ++- drivers/gpu/drm/r128/r128_drv.c| 4 +++- drivers/gpu/drm/r128/r128_state.c | 3 ++- 3 files changed, 11 insertions(+)

[PATCH 1/7] drm/i810: Remove references to struct drm_device.pdev

2021-05-02 Thread Thomas Zimmermann
Replace all references to struct drm_device's pdev field with an upcast from dev. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i810/i810_dma.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c ind

Re: [syzbot] BUG: unable to handle kernel paging request in vga16fb_imageblit (2)

2021-05-02 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:d2b6f8a1 Merge tag 'xfs-5.13-merge-3' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11d80be1d0 kernel config: https://syzkaller.appspot.com/x/.config?x=53fdf14

Re: [syzbot] BUG: unable to handle kernel paging request in vga16fb_imageblit (2)

2021-05-02 Thread syzbot
syzbot has bisected this issue to: commit 988d0763361bb65690d60e2bc53a6b72777040c3 Author: Tetsuo Handa Date: Sun Sep 27 11:46:30 2020 + vt_ioctl: make VT_RESIZEX behave like VT_RESIZE bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15633759d0 start commit: d2b6f8a1

[Bug 212107] Temperature increase by 15°C on radeon gpu

2021-05-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212107 --- Comment #10 from Martin (martin...@gmx.com) --- (In reply to Martin from comment #9) > > I'm running 5.11.17 currently and temperature on the GPU gets to 70°C but > fan is at like 300rpm. > This isn't always reproducible. I thought it may b