Re: [PATCH -next] drm/radeon/radeon_pm: use DEVICE_ATTR_RW macro

Am 02.06.21 um 03:53 schrieb Alex Deucher: On Fri, May 28, 2021 at 3:18 AM YueHaibing wrote: Use DEVICE_ATTR_RW() helper instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Signed-off-by: YueHaibing I'm not convinced this really buys us anything other th

Re: [PATCH -next] drm/radeon/radeon_pm: use DEVICE_ATTR_RW macro

Am 02.06.21 um 03:53 schrieb Alex Deucher: On Fri, May 28, 2021 at 3:18 AM YueHaibing wrote: Use DEVICE_ATTR_RW() helper instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Signed-off-by: YueHaibing I'm not convinced this really buys us anything other th

Re: [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

On 02-06-2021 03:50, Lyude Paul wrote: oh-looks like my patches just got reviewed, so hopefully I should get a chance to get a look at this in the next day or two :) Hi Lyude, That's great! I have updated v5 [1] of this series addressing Doug's review comments on v4 [2].  Please review the

Re: [PULL] drm-intel-gt-next

On Wed, 2 Jun 2021 at 14:17, Dave Airlie wrote: > > On Wed, 2 Jun 2021 at 10:28, Dave Airlie wrote: > > > > This has these two patches applied, and it doesn't build. > > > > drm/i915: drop the __i915_active_call pointer packing > > drm/i915: Fix crash in auto_retire > > > > The latter patch s

Re: [PULL] drm-intel-gt-next

On Wed, 2 Jun 2021 at 10:28, Dave Airlie wrote: > > This has these two patches applied, and it doesn't build. > > drm/i915: drop the __i915_active_call pointer packing > drm/i915: Fix crash in auto_retire > > The latter patch shouldn't be necessary after the former, please fix > that up and re

[PATCH] video: fbdev: kyro: STG4000OverlayDevice.c: Fix a typo

From: lijian Change 'thses' to 'these'. Signed-off-by: lijian --- drivers/video/fbdev/kyro/STG4000OverlayDevice.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/kyro/STG4000OverlayDevice.c b/drivers/video/fbdev/kyro/STG4000OverlayDevice.c index 7a0

Re: [PATCH 5/9] drm: Add Client Cap for advance gamma mode

Hi Uma, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13-rc4 next-20210601] [cannot apply to drm/drm-next] [If your

[PATCH] video: fbdev: kyro: STG4000OverlayDevice.c: deleted the repeated word

From: lijian deleted the repeated word 'number' in the comments Signed-off-by: lijian --- drivers/video/fbdev/kyro/STG4000OverlayDevice.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/kyro/STG4000OverlayDevice.c b/drivers/video/fbdev/kyro/STG4000Ov

[PATCH 1/1] video: fbdev: sm501fb: use DEVICE_ATTR_RO macro

Use DEVICE_ATTR_RO macro helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read. Signed-off-by: Zhen Lei --- drivers/video/fbdev/sm501fb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/

[PATCH 1/1] video: fbdev: w100fb: use DEVICE_ATTR_WO macro

Use DEVICE_ATTR_WO macro helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read. Signed-off-by: Zhen Lei --- drivers/video/fbdev/w100fb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/w100fb.c b/drivers/video/f

Re: [PATCH -next] drm/amdgpu: Remove unneeded semicolon

Applied. Thanks! On Tue, Jun 1, 2021 at 10:07 AM Zheng Yongjun wrote: > > Remove unneeded semicolon. > > Signed-off-by: Zheng Yongjun > --- > drivers/gpu/drm/amd/amdgpu/aldebaran.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/aldebaran.c

Re: [PATCH -next] drm/amd/display: fix warning: ‘update_dsc_caps’ and ‘apply_dsc_policy_for_stream’ defined but not used

Applied. Thanks! On Tue, Jun 1, 2021 at 4:04 AM Baokun Li wrote: > > Fixes gcc '-Wunused-function' warning: > > ‘update_dsc_caps’ and ‘apply_dsc_policy_for_stream’ are only used > if 'CONFIG_DRM_AMD_DC_DCN' is defined, > > however, it's defined even if 'CONFIG_DRM_AMD_DC_DCN' is not defined. > T

Re: [PATCH] drm/amd/display: Remove the redundant initialization of local variable

Applied. Thanks! Alex On Mon, May 31, 2021 at 5:30 AM Shaokun Zhang wrote: > > Local variable 'i' and 'j' will be initialized in the for loop, so > remove the redundant initialization. > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Signed-off-by: Shaokun Zhang > --- > drivers/gpu

Re: [PATCH] drm/amd/display: fix gcc set but not used warning of variable 'old_plane_state'

Applied. Thanks! Alex On Sat, May 29, 2021 at 5:19 AM Yu Kuai wrote: > > define a new macro for_each_new_plane_in_state_reverse to replace > for_each_oldnew_plane_in_state_reverse, so that the unused variable > 'old_plane_state' can be removed. > > Fix gcc warning: > drivers/gpu/drm/amd/amdgpu/

Re: [PATCH] drm/amd/display: Avoid HDCP over-read and corruption

On Fri, May 28, 2021 at 1:54 PM Kees Cook wrote: > > Instead of reading the desired 5 bytes of the actual target field, > the code was reading 8. This could result in a corrupted value if the > trailing 3 bytes were non-zero, so instead use an appropriately sized > and zero-initialized bounce buff

Re: [PATCH v3] drm/msm/dp: power off DP phy at suspend

Please add dri-devel@lists.freedesktop.org next time Quoting Kuogee Hsieh (2021-06-01 16:50:08) > Normal DP suspend operation contains two steps, display off followed > by dp suspend, to complete system wide suspending cycle if display is > up at that time. In this case, DP phy will be powered off

Re: [PATCH v3] amdgpu: remove unreachable code

Applied. Thanks! On Fri, May 28, 2021 at 8:18 AM Christian König wrote: > > Am 28.05.21 um 11:29 schrieb Jiapeng Chong: > > In the function amdgpu_uvd_cs_msg(), every branch in the switch > > statement will have a return, so the code below the switch statement > > will not be executed. > > > > E

Re: [PATCH -next] drm/radeon/radeon_pm: use DEVICE_ATTR_RW macro

On Fri, May 28, 2021 at 3:18 AM YueHaibing wrote: > > Use DEVICE_ATTR_RW() helper instead of plain DEVICE_ATTR(), > which makes the code a bit shorter and easier to read. > > Signed-off-by: YueHaibing I'm not convinced this really buys us anything other than code churn, but I don't have a partic

RE: [PATCH 3/4] drm/amdgpu: always allow evicting to SYSTEM domain

>-Original Message- >From: Christian König >Sent: Tuesday, June 1, 2021 8:25 PM >To: Yu, Lang ; thomas...@shipmail.org >Cc: dri-devel@lists.freedesktop.org >Subject: [PATCH 3/4] drm/amdgpu: always allow evicting to SYSTEM domain > >When we run out of GTT we should still be able to evict

Re: [Intel-gfx] [RFC PATCH 60/97] drm/i915: Track 'serial' counts for virtual engines

On 6/1/2021 02:31, Tvrtko Ursulin wrote: On 27/05/2021 18:01, John Harrison wrote: On 5/27/2021 01:53, Tvrtko Ursulin wrote: On 26/05/2021 19:45, John Harrison wrote: On 5/26/2021 01:40, Tvrtko Ursulin wrote: On 25/05/2021 18:52, Matthew Brost wrote: On Tue, May 25, 2021 at 11:16:12AM +0100,

Re: [PATCH v4 1/1] drm/i915/dg1: Add HWMON power sensor support

On 2021-06-01 14:39:11, Sundaresan, Sujaritha wrote: > Date: Tue, 1 Jun 2021 14:39:11 -0700 > From: "Sundaresan, Sujaritha" > To: Dale B Stimson , > intel-...@lists.freedesktop.org, dri-devel@lists.freedesktop.org > CC: Jon Ewins , Jani Nikula > > Subject: Re: [PATCH v4 1/1] drm/i915/dg1: Add H

Re: [PULL] drm-intel-gt-next

This has these two patches applied, and it doesn't build. drm/i915: drop the __i915_active_call pointer packing drm/i915: Fix crash in auto_retire The latter patch shouldn't be necessary after the former, please fix that up and resend and please build test trees before I get them in future.

Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang

all three nouveau patches are Reviewed-by: Karol Herbst and I don't think anybody would mind if those get into through other trees, but maybe drm-mist would be a good place for it if other patches involve other drm drivers? On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva wrote: > > Hi, > >

Re: [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang

Hi, Friendly second ping: who can take this? I can add this to my -next branch for 5.14 if you don't mind. JFYI: We had thousands of these sorts of warnings and now we are down to just 23 in linux-next. This is one of those last remaining warnings. Thanks -- Gustavo On 4/20/21 15:13, Gustavo A

Re: [PATCH RESEND][next] drm/nouveau/clk: Fix fall-through warnings for Clang

Hi, Friendly second ping: who can take this? I can add this to my -next branch for 5.14 if you don't mind. JFYI: We had thousands of these sorts of warnings and now we are down to just 23 in linux-next. This is one of those last remaining warnings. Thanks -- Gustavo On 4/20/21 15:13, Gustavo A

Re: [PATCH RESEND][next] drm/nouveau/therm: Fix fall-through warnings for Clang

Hi, Friendly second ping: who can take this? I can add this to my -next branch for 5.14 if you don't mind. JFYI: We had thousands of these sorts of warnings and now we are down to just 23 in linux-next. This is one of those last remaining warnings. Thanks -- Gustavo On 4/20/21 15:13, Gustavo A

[PATCH v4 6/6] drm/msm: devcoredump iommu fault support

From: Rob Clark Wire up support to stall the SMMU on iova fault, and collect a devcore- dump snapshot for easier debugging of faults. Currently this is a6xx-only, but mostly only because so far it is the only one using adreno-smmu-priv. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/

[PATCH v4 5/6] drm/msm: Add crashdump support for stalled SMMU

From: Rob Clark For collecting devcoredumps with the SMMU stalled after an iova fault, we need to skip the parts of the GPU state which are normally collected with the hw crashdumper, since with the SMMU stalled the hw would be unable to write out the requested state to memory. Signed-off-by: Ro

[PATCH v4 4/6] iommu/arm-smmu-qcom: Add stall support

From: Rob Clark Add, via the adreno-smmu-priv interface, a way for the GPU to request the SMMU to stall translation on faults, and then later resume the translation, either retrying or terminating the current translation. This will be used on the GPU side to "freeze" the GPU while we snapshot us

[PATCH v4 3/6] drm/msm: Improve the a6xx page fault handler

From: Jordan Crouse Use the new adreno-smmu-priv fault info function to get more SMMU debug registers and print the current TTBR0 to debug per-instance pagetables and figure out which GPU block generated the request. Signed-off-by: Jordan Crouse Signed-off-by: Rob Clark --- drivers/gpu/drm/ms

[PATCH v4 2/6] iommu/arm-smmu-qcom: Add an adreno-smmu-priv callback to get pagefault info

From: Jordan Crouse Add a callback in adreno-smmu-priv to read interesting SMMU registers to provide an opportunity for a richer debug experience in the GPU driver. Signed-off-by: Jordan Crouse Signed-off-by: Rob Clark --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 17 drivers/

[PATCH v4 1/6] iommu/arm-smmu: Add support for driver IOMMU fault handlers

From: Jordan Crouse Call report_iommu_fault() to allow upper-level drivers to register their own fault handlers. Signed-off-by: Jordan Crouse Signed-off-by: Rob Clark --- drivers/iommu/arm/arm-smmu/arm-smmu.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] drm/msm/dpu: Delete bonkers code

From: Rob Clark dpu_crtc_atomic_flush() was directly poking it's attached planes in a code path that ended up in dpu_plane_atomic_update(), even if the plane was not involved in the current atomic update. While a bit dubious, this worked before because plane->state would always point to somethin

[PATCH v4 0/6] iommu/arm-smmu: adreno-smmu page fault handling

From: Rob Clark This picks up an earlier series[1] from Jordan, and adds additional support needed to generate GPU devcore dumps on iova faults. Original description: This is a stack to add an Adreno GPU specific handler for pagefaults. The first patch starts by wiring up report_iommu_fault for

Re: [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID

Le Tue, Jun 01, 2021 at 06:50:24PM +0300, Ville Syrj?l? a ?crit : > On Mon, May 31, 2021 at 10:46:41PM +0200, Anisse Astier wrote: > > The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be > > used for the embedded display. Add support for using it via by adding > > the EDID to the

Re: [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

oh-looks like my patches just got reviewed, so hopefully I should get a chance to get a look at this in the next day or two :) On Tue, 2021-05-25 at 13:00 +0530, Rajeev Nandan wrote: > Add basic support of panel backlight control over eDP aux channel > using VESA's standard backlight control inter

Re: [PATCH v4 1/1] drm/i915/dg1: Add HWMON power sensor support

On 5/27/2021 5:44 PM, Dale B Stimson wrote: As part of the System Managemenent Interface (SMI), use the HWMON subsystem to display power utilization. The following standard HWMON power sensors are currently supported (and appropriately scaled): /sys/class/drm/card0/device/hwmon/hwmon

Re: [PATCH v2] drm/panel: db7430: Add driver for Samsung DB7430

Hi, On Mon, May 31, 2021 at 3:30 AM Linus Walleij wrote: > > +/** > + * struct db7430 - state container for the Db7430 panel super nitty: s/Db7430/DB7430/ Also, it's not technically "the DB7430 panel" but instead "a panel controlled by the DB7430 controller". > +static int db7430_dcs_write(st

Re: [PATCH v4 04/17] drm/i915/gt: Export the pinned context constructor and destructor

On 6/1/2021 1:20 PM, Rodrigo Vivi wrote: On Mon, May 24, 2021 at 10:47:50PM -0700, Daniele Ceraolo Spurio wrote: From: Chris Wilson Allow internal clients to create a pinned context. v2 (Daniele): export destructor as well, allow optional usage of custom vm for maximum flexibility. Signed

Re: [v1 1/3] dt-bindings: msm/dsi: Add yaml schema for 7nm DSI PHY

On Mon, May 31, 2021 at 07:03:53PM +0530, Rajeev Nandan wrote: > Add YAML schema for the device tree bindings for MSM 7nm DSI PHY driver. > > Cc: Jonathan Marek > Signed-off-by: Rajeev Nandan > --- > .../bindings/display/msm/dsi-phy-7nm.yaml | 68 > ++ > 1 file cha

Re: [PATCH v4 08/17] drm/i915/pxp: Create the arbitrary session after boot

On Mon, May 24, 2021 at 10:47:54PM -0700, Daniele Ceraolo Spurio wrote: > From: "Huang, Sean Z" > > Create the arbitrary session, with the fixed session id 0xf, after > system boot, We will have to change this and only create on-demand. Then delete when no one is using... but this will be a foll

Re: [PATCH v4 06/17] drm/i915/pxp: Implement funcs to create the TEE channel

On Mon, May 24, 2021 at 10:47:52PM -0700, Daniele Ceraolo Spurio wrote: > From: "Huang, Sean Z" > > Implement the funcs to create the TEE channel, so kernel can > send the TEE commands directly to TEE for creating the arbitrary > (default) session. > > v2: fix locking, don't pollute dev_priv (Ch

Re: [Intel-gfx] [PATCH v4 05/17] drm/i915/pxp: allocate a vcs context for pxp usage

On Mon, May 24, 2021 at 10:47:51PM -0700, Daniele Ceraolo Spurio wrote: > The context is required to send the session termination commands to the > VCS, which will be implemented in a follow-up patch. We can also use the > presence of the context as a check of pxp initialization completion. > > v2

[Bug 209457] AMDGPU resume fail with RX 580 GPU

https://bugzilla.kernel.org/show_bug.cgi?id=209457 --- Comment #24 from Leandro Jacques (ls...@yahoo.com) --- I forgot to mention the kernel version I was using when it crashed. It was 5.10.x (In reply to Leandro Jacques from comment #23) > I'm facing exactly the same issue with a Ryzen 7 Vega 10

Re: [PATCH v4 04/17] drm/i915/gt: Export the pinned context constructor and destructor

On Mon, May 24, 2021 at 10:47:50PM -0700, Daniele Ceraolo Spurio wrote: > From: Chris Wilson > > Allow internal clients to create a pinned context. > > v2 (Daniele): export destructor as well, allow optional usage of custom > vm for maximum flexibility. > > Signed-off-by: Chris Wilson > Signed

[PATCH 7/7] tests/amdgpu/hotunplug: Add hotunplug with exported bo test

Disconnect device while BO is exported. Signed-off-by: Andrey Grodzovsky --- tests/amdgpu/hotunplug_tests.c | 46 -- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/tests/amdgpu/hotunplug_tests.c b/tests/amdgpu/hotunplug_tests.c index 6e133a07..01ac

[PATCH 6/7] tests/amdgpu/hotunplug: Add unplug with cs test.

Same as simple test but while doing cs Signed-off-by: Andrey Grodzovsky --- tests/amdgpu/hotunplug_tests.c | 128 - 1 file changed, 126 insertions(+), 2 deletions(-) diff --git a/tests/amdgpu/hotunplug_tests.c b/tests/amdgpu/hotunplug_tests.c index c2bc1cf2..6e13

[PATCH 5/7] test/amdgpu/hotunplug: Add basic test

Add plug/unplug device and open/close device file infrastrucutre. Add basic test - unplug device while device file still open. Close device file afterwards and replug the device. Signed-off-by: Andrey Grodzovsky --- tests/amdgpu/hotunplug_tests.c | 135 + 1 file c

[PATCH 4/7] test/amdgpu/hotunplug: Add test suite for GPU unplug

Add just the test suite skeleton. Signed-off-by: Andrey Grodzovsky --- tests/amdgpu/amdgpu_test.c | 11 tests/amdgpu/amdgpu_test.h | 23 +++ tests/amdgpu/hotunplug_tests.c | 116 + tests/amdgpu/meson.build | 1 + 4 files changed, 151 ins

[PATCH 3/7] test/amdgpu: Add helper functions for hot unplug

Expose close device and add open device wich preserves test index. Signed-off-by: Andrey Grodzovsky --- tests/amdgpu/amdgpu_test.c | 31 --- tests/amdgpu/amdgpu_test.h | 3 +++ 2 files changed, 31 insertions(+), 3 deletions(-) diff --git a/tests/amdgpu/amdgpu_test.c

[PATCH 2/7] xf86drm: Add function to retrieve char device path

Used to access device controls Signed-off-by: Andrey Grodzovsky --- xf86drm.c | 23 +++ xf86drm.h | 1 + 2 files changed, 24 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index edfeb347..a5ecd323 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -4361,6 +4361,29 @@ drm_public ch

[PATCH 1/7] tests/amdgpu: Fix valgrind warning

Struct access after free Signed-off-by: Andrey Grodzovsky --- tests/amdgpu/basic_tests.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/amdgpu/basic_tests.c b/tests/amdgpu/basic_tests.c index 8e7c4916..8b7fd0f6 100644 --- a/tests/amdgpu/basic_tests.c +++ b/tests/a

[PATCH 0/7] libdrm tests for hot-unplug feature

Adding some tests to acompany the recently added hot-unplug feature. For now the test suite is disabled until the feature propagates from drm-misc-next to drm-next. Andrey Grodzovsky (7): tests/amdgpu: Fix valgrind warning xf86drm: Add function to retrieve char device path test/amdgpu: Add h

Re: [PATCH v6 1/9] drm/i915/dpcd_bl: Remove redundant AUX backlight frequency calculations

On Fri, 21 May 2021, Rodrigo Vivi wrote: > On Fri, May 14, 2021 at 02:14:55PM -0400, Lyude Paul wrote: >> Noticed this while moving all of the VESA backlight code in i915 over to >> DRM helpers: it would appear that we calculate the frequency value we want >> to write to DP_EDP_BACKLIGHT_FREQ_SET

Re: [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

Sorry-I've been waiting to review this, but the DPCD backlight support helper series is -still- blocked on getting reviews upstream :\ On Tue, 2021-05-25 at 13:00 +0530, Rajeev Nandan wrote: > Add basic support of panel backlight control over eDP aux channel > using VESA's standard backlight contr

Re: [PATCH] vgaarb: Call vga_arb_device_init() after PCI enumeration

On Tue, Jun 01, 2021 at 07:12:27PM +0200, Greg KH wrote: > On Tue, Jun 01, 2021 at 05:56:40PM +0200, Daniel Vetter wrote: > > On Fri, May 28, 2021 at 04:26:07PM +0800, Huacai Chen wrote: > > > We should call vga_arb_device_init() after PCI enumeration, otherwise it > > > may fail to select the defa

[Bug 209457] AMDGPU resume fail with RX 580 GPU

https://bugzilla.kernel.org/show_bug.cgi?id=209457 Leandro Jacques (ls...@yahoo.com) changed: What|Removed |Added CC||ls...@yahoo.com --- C

Re: [Mesa-dev] Linux Graphics Next: Userspace submission update

Hi, On Tue, 1 Jun 2021 at 14:18, Michel Dänzer wrote: > On 2021-06-01 2:10 p.m., Christian König wrote: > > Am 01.06.21 um 12:49 schrieb Michel Dänzer: > >> There isn't a choice for Wayland compositors in general, since there can > >> be arbitrary other state which needs to be applied atomically

Re: [Mesa-dev] Linux Graphics Next: Userspace submission update

On 2021-06-01 3:18 p.m., Michel Dänzer wrote: > On 2021-06-01 2:10 p.m., Christian König wrote: >> Am 01.06.21 um 12:49 schrieb Michel Dänzer: >>> On 2021-06-01 12:21 p.m., Christian König wrote: Am 01.06.21 um 11:02 schrieb Michel Dänzer: > On 2021-05-27 11:51 p.m., Marek Olšák wrote: >>>

Re: [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

Ack on all naming. -Daniel BTW As long as Jason nor you object I will prepare patches for the rename of the functions. Regards, Christian.

Re: [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

Am 01.06.21 um 16:34 schrieb Daniel Vetter: On Thu, May 27, 2021 at 03:41:02PM +0200, Christian König wrote: Am 27.05.21 um 15:25 schrieb Daniel Vetter: On Thu, May 27, 2021 at 1:59 PM Christian König wrote: Am 27.05.21 um 12:39 schrieb Daniel Vetter: On Wed, May 26, 2021 at 12:57:40PM +0200

Re: [PATCH] vgaarb: Call vga_arb_device_init() after PCI enumeration

On Tue, Jun 01, 2021 at 05:56:40PM +0200, Daniel Vetter wrote: > On Fri, May 28, 2021 at 04:26:07PM +0800, Huacai Chen wrote: > > We should call vga_arb_device_init() after PCI enumeration, otherwise it > > may fail to select the default VGA device. Since vga_arb_device_init() > > and PCI enumerati

Re: [Intel-gfx] [PATCH v2 2/9] drm: Add privacy-screen class (v2)

Hi Emil, On giu 1 2021, at 5:31 pm, Emil Velikov wrote: > Hi Hans, > > What happened with this series, did it fall through the cracks? It's mostly waiting me to finish to propose the changes to GNOME, unfortunately I've been busy in the past weeks with downstream work, so I couldn't finish it,

Re: [PATCH] drm: Fix misleading documentation of drm_gem_cma_create()

On Tue, Jun 01, 2021 at 10:54:05AM +0100, Paul Cercueil wrote: > The backing memory does not necessarily have the writecombine attribute > set, since commit cf8ccbc72d61 ("drm: Add support for GEM buffers backed > by non-coherent memory"). > > Fixes: cf8ccbc72d61 ("drm: Add support for GEM buffers

Re: [PATCH 1/1] video: fbdev: mb862xx: use DEVICE_ATTR_RO macro

On Tue, Jun 01, 2021 at 05:08:52PM +0800, Zhen Lei wrote: > Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR, which makes the > code a bit shorter and easier to read. > > Signed-off-by: Zhen Lei Applied to drm-misc-next, thanks. -Daniel > --- > drivers/video/fbdev/mb862xx/mb862xxfbdrv.c

Re: [RFC 2/3] drm/atomic: Call dma_fence_boost() when we've missed a vblank

On Tue, Jun 01, 2021 at 08:46:14AM -0700, Rob Clark wrote: > On Tue, Jun 1, 2021 at 7:18 AM Daniel Vetter wrote: > > > > On Sun, May 30, 2021 at 07:33:57AM -0700, Rob Clark wrote: > > > On Thu, May 20, 2021 at 9:29 AM Daniel Vetter wrote: > > > > > > > > On Wed, May 19, 2021 at 11:38:53AM -0700,

Re: [PATCH] video: fbdev: atyfb: mach64_cursor.c: deleted the repeated word

On Tue, Jun 01, 2021 at 09:27:47AM +0800, lijian_8010...@163.com wrote: > From: lijian > > deleted the repeated word 'be' in the comments. > > Signed-off-by: lijian Applied to drm-misc-next, thanks for your patch. -Daniel > --- > drivers/video/fbdev/aty/mach64_cursor.c | 2 +- > 1 file chang

Re: [PATCH] drm/sched: Fix inverted comment for hang_limit

On Fri, May 28, 2021 at 07:51:52PM -0400, Alyssa Rosenzweig wrote: > The hang_limit is the threshold after which the kernel no longer > attempts to schedule a job. Its documentation stated the opposite due to > a typo. Correct the wording to indicate the actual purpose of the field. > > Signed-off

Re: [PATCH] vgaarb: Call vga_arb_device_init() after PCI enumeration

On Fri, May 28, 2021 at 04:26:07PM +0800, Huacai Chen wrote: > We should call vga_arb_device_init() after PCI enumeration, otherwise it > may fail to select the default VGA device. Since vga_arb_device_init() > and PCI enumeration function (i.e., pcibios_init() or acpi_init()) are > both wrapped by

Re: [PATCH 10/11] drm/ingenic: Add doublescan feature

On Fri, May 28, 2021 at 12:22:05AM +0100, Paul Cercueil wrote: > A lot of devices with an Ingenic SoC have a weird LCD panel attached, > where the pixels are not square. For instance, the AUO A030JTN01 and > Innolux EJ030NA panels have a resolution of 320x480 with a 4:3 aspect > ratio. > > All use

Re: [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID

On Mon, May 31, 2021 at 10:46:41PM +0200, Anisse Astier wrote: > The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be > used for the embedded display. Add support for using it via by adding > the EDID to the list of available modes on the connector, and use it for > eDP when availa

Re: [PATCH 04/11] drm/ingenic: Move no_vblank to private state

On Fri, May 28, 2021 at 12:20:58AM +0100, Paul Cercueil wrote: > This information is carried from the ".atomic_check" to the > ".atomic_commit_tail"; as such it is state-specific, and should be moved > to the private state structure. > > Signed-off-by: Paul Cercueil Not sure this applies to your

Re: [RFC 2/3] drm/atomic: Call dma_fence_boost() when we've missed a vblank

On Tue, Jun 1, 2021 at 7:18 AM Daniel Vetter wrote: > > On Sun, May 30, 2021 at 07:33:57AM -0700, Rob Clark wrote: > > On Thu, May 20, 2021 at 9:29 AM Daniel Vetter wrote: > > > > > > On Wed, May 19, 2021 at 11:38:53AM -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > Signed-off-by

Re: [PATCH v2] fb_defio: Remove custom address_space_operations

On Tue, Jun 01, 2021 at 03:30:30PM +0100, Matthew Wilcox wrote: > On Tue, Jun 01, 2021 at 04:10:32PM +0200, Daniel Vetter wrote: > > On Sun, May 30, 2021 at 10:14:22PM +0100, Matthew Wilcox wrote: > > > On Sun, May 30, 2021 at 12:13:05PM -0700, Nathan Chancellor wrote: > > > > Hi Matthew, > > > >

Re: [Intel-gfx] [PATCH v2 2/9] drm: Add privacy-screen class (v2)

Hi Hans, What happened with this series, did it fall through the cracks? On Wed, 21 Apr 2021 at 21:48, Hans de Goede wrote: > --- /dev/null > +++ b/drivers/gpu/drm/drm_privacy_screen.c > +#include "drm_internal.h" I think we don't need this include, do we? > --- /dev/null > +++ b/include/dr

[PULL] drm-misc-next

Hi Dave and Daniel, here's this week's PR for drm-misc-next. It also contains last week's tag because last week's email somehow went wrong. Each tag has it's individual description, but the overview below contains the sum of both. Some highlights from both weeks are * amdgpu hot-unplug support,

[PATCH v2 2/2] drivers/firmware: consolidate EFI framebuffer setup for all arches

The register_gop_device() function registers an "efi-framebuffer" platform device to match against the efifb driver, to have an early framebuffer for EFI platforms. But there is already support to do exactly the same by the Generic System Framebuffers (sysfb) driver. This used to be only for X86 b

[PATCH v2 1/2] drivers/firmware: move x86 Generic System Framebuffers support

The x86 architecture has generic support to register a system framebuffer platform device. It either registers a "simple-framebuffer" if the config option CONFIG_X86_SYSFB is enabled, or a legacy VGA/VBE/EFI FB device. But the code is generic enough to be reused by other architectures and can be m

[PATCH v2 0/2] allow simple{fb, drm} drivers to be used on non-x86 EFI platforms

The simplefb and simpledrm drivers match against a "simple-framebuffer" device, but for aarch64 this is only registered when using Device Trees and there's a node with a "simple-framebuffer" compatible string. There is no code to register a "simple-framebuffer" platform device when using EFI inste

Re: [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

On Thu, May 27, 2021 at 03:41:02PM +0200, Christian König wrote: > Am 27.05.21 um 15:25 schrieb Daniel Vetter: > > On Thu, May 27, 2021 at 1:59 PM Christian König > > wrote: > > > Am 27.05.21 um 12:39 schrieb Daniel Vetter: > > > > On Wed, May 26, 2021 at 12:57:40PM +0200, Christian König wrote: >

Re: [PATCH v2] fb_defio: Remove custom address_space_operations

On Tue, Jun 01, 2021 at 04:10:32PM +0200, Daniel Vetter wrote: > On Sun, May 30, 2021 at 10:14:22PM +0100, Matthew Wilcox wrote: > > On Sun, May 30, 2021 at 12:13:05PM -0700, Nathan Chancellor wrote: > > > Hi Matthew, > > > > > > On Wed, Mar 10, 2021 at 06:55:30PM +, Matthew Wilcox (Oracle) wr

Re: [Intel-gfx] [PATCH 1/1] Let userspace know if they can trust timeslicing by including it as part of the I915_PARAM_HAS_SCHEDULER::I915_SCHEDULER_CAP_TIMESLICING

On Tue, Jun 01, 2021 at 11:09:47AM +0100, Tvrtko Ursulin wrote: > > On 27/05/2021 11:27, Daniel Vetter wrote: > > On Thu, May 27, 2021 at 11:22:16AM +0100, Tvrtko Ursulin wrote: > > > > > > On 27/05/2021 11:13, Daniel Vetter wrote: > > > > On Wed, May 26, 2021 at 11:20:13AM +0100, Tvrtko Ursulin

[PATCH] drm/i915: Add relocation exceptions for two other platforms

We have established previously we stop using relocations starting from gen12 platforms with Tigerlake as an exception. We keep this statement but we want to enable relocations conditionally for Rocketlake and Alderlake under require_force_probe flag set. Keeping relocations under require_force_pro

Re: [PATCH v2 09/12] drm/vc4: hdmi: Remove firmware logic for MAI threshold setting

On Tue, 1 Jun 2021 at 09:52, nicolas saenz julienne wrote: > What's to expect sound wise on older RPis? I'd say 8 channel 48kHz is good. 2 channel 192KHz is good. Higher than that and we start to lose samples in the HDMI MAI bus fifo. The firmware workaround made 4 channel 192kHz somewhat more

[PATCH -next] drm/etnaviv: Remove unneeded if-null-free check

Eliminate the following coccicheck warning: drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c:84:2-8: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Zheng Yongjun --- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [RFC 2/3] drm/atomic: Call dma_fence_boost() when we've missed a vblank

On Sun, May 30, 2021 at 07:33:57AM -0700, Rob Clark wrote: > On Thu, May 20, 2021 at 9:29 AM Daniel Vetter wrote: > > > > On Wed, May 19, 2021 at 11:38:53AM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Signed-off-by: Rob Clark > > > --- > > > drivers/gpu/drm/drm_atomic_helper.c | 1

Re: [PATCH v2] fb_defio: Remove custom address_space_operations

On Sun, May 30, 2021 at 10:14:22PM +0100, Matthew Wilcox wrote: > On Sun, May 30, 2021 at 12:13:05PM -0700, Nathan Chancellor wrote: > > Hi Matthew, > > > > On Wed, Mar 10, 2021 at 06:55:30PM +, Matthew Wilcox (Oracle) wrote: > > > There's no need to give the page an address_space. Leaving th

[PATCH -next] drm/amdgpu: Remove unneeded semicolon

Remove unneeded semicolon. Signed-off-by: Zheng Yongjun --- drivers/gpu/drm/amd/amdgpu/aldebaran.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/aldebaran.c b/drivers/gpu/drm/amd/amdgpu/aldebaran.c index 65b1dca4b02e..148f6c3343ab 100644 --- a/dr

Re: [v1 1/3] dt-bindings: msm/dsi: Add yaml schema for 7nm DSI PHY

On Mon, 31 May 2021 19:03:53 +0530, Rajeev Nandan wrote: > Add YAML schema for the device tree bindings for MSM 7nm DSI PHY driver. > > Cc: Jonathan Marek > Signed-off-by: Rajeev Nandan > --- > .../bindings/display/msm/dsi-phy-7nm.yaml | 68 > ++ > 1 file changed,

Re: [Mesa-dev] Linux Graphics Next: Userspace submission update

On 2021-06-01 3:01 p.m., Marek Olšák wrote: > > > On Tue., Jun. 1, 2021, 08:51 Christian König, > mailto:ckoenig.leichtzumer...@gmail.com>> > wrote: > > Am 01.06.21 um 14:30 schrieb Daniel Vetter: > > On Tue, Jun 1, 2021 at 2:10 PM Christian König > >

Re: [Mesa-dev] Linux Graphics Next: Userspace submission update

On 2021-06-01 2:10 p.m., Christian König wrote: > Am 01.06.21 um 12:49 schrieb Michel Dänzer: >> On 2021-06-01 12:21 p.m., Christian König wrote: >>> Am 01.06.21 um 11:02 schrieb Michel Dänzer: On 2021-05-27 11:51 p.m., Marek Olšák wrote: > 3) Compositors (and other privileged processes, a

Re: [Mesa-dev] Linux Graphics Next: Userspace submission update

On Tue., Jun. 1, 2021, 08:51 Christian König, < ckoenig.leichtzumer...@gmail.com> wrote: > Am 01.06.21 um 14:30 schrieb Daniel Vetter: > > On Tue, Jun 1, 2021 at 2:10 PM Christian König > > wrote: > >> Am 01.06.21 um 12:49 schrieb Michel Dänzer: > >>> On 2021-06-01 12:21 p.m., Christian König wro

Re: [PATCH 4/4] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after kernel startup

Hi Dillon On 5/14/21 1:02 PM, dillon.min...@gmail.com wrote: > From: Dillon Min > > stm32's clk driver register two ltdc gate clk to clk core by > clk_hw_register_gate() and clk_hw_register_composite() > > first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use. > second: 'stm32f42

Re: [Mesa-dev] Linux Graphics Next: Userspace submission update

Am 01.06.21 um 14:30 schrieb Daniel Vetter: On Tue, Jun 1, 2021 at 2:10 PM Christian König wrote: Am 01.06.21 um 12:49 schrieb Michel Dänzer: On 2021-06-01 12:21 p.m., Christian König wrote: Am 01.06.21 um 11:02 schrieb Michel Dänzer: On 2021-05-27 11:51 p.m., Marek Olšák wrote: 3) Composit

Re: [PATCH 3/4] clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate

Hi Dillon On 5/14/21 1:02 PM, dillon.min...@gmail.com wrote: > From: Dillon Min > > This is due to misuse ‘PLL_VCO_SAI' and'PLL_SAI' in clk-stm32f4.c > 'PLL_SAI' is 2, 'PLL_VCO_SAI' is 7(defined in > include/dt-bindings/clock/stm32fx-clock.h). > > 'post_div' point to 'post_div_data[]', 'post_di

Re: [PATCH v2] backlight: Kconfig whitespace and indentation cleanups

On Wed, 19 May 2021, Juerg Haefliger wrote: > Remove leading whitespaces, replace multi spaces with tabs, and fix help > text indentation. > > Signed-off-by: Juerg Haefliger > --- > drivers/video/backlight/Kconfig | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-)

Re: [PATCH v2 05/12] ASoC: hdmi-codec: Add a prepare hook

On Mon, May 31, 2021 at 01:12:17PM +0200, Takashi Iwai wrote: > Maxime Ripard wrote: > > There's a build dependency between the DRM bits and the new hook > > introduced in hdmi-codec, would you be ok with merging it through the > > drm tree? > Speaking of ALSA core changes, I'm fine with that. Y

Re: [Mesa-dev] Linux Graphics Next: Userspace submission update

On Tue, Jun 1, 2021 at 2:10 PM Christian König wrote: > > Am 01.06.21 um 12:49 schrieb Michel Dänzer: > > On 2021-06-01 12:21 p.m., Christian König wrote: > >> Am 01.06.21 um 11:02 schrieb Michel Dänzer: > >>> On 2021-05-27 11:51 p.m., Marek Olšák wrote: > 3) Compositors (and other privileged

Re: [PATCH v9 07/15] drm: Add a prefetching memcpy_from_wc

On Tue, 01 Jun 2021, Thomas Hellström wrote: > Reading out of write-combining mapped memory is typically very slow > since the CPU doesn't prefetch. However some archs have special > instructions to do this. > > So add a best-effort memcpy_from_wc taking dma-buf-map pointer > arguments that attemp

Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

On Tue, 01 Jun 2021, Zbigniew Kempczyński wrote: > We have established previously we stop using relocations starting > from gen12 platforms with Tigerlake as an exception. We keep this > statement but we want to enable relocations conditionally for > Rocketlake and Alderlake under require_force_p

  1   2   >