[PATCH v5 1/1] drm/i915/dg1: Add HWMON power sensor support

2021-06-16 Thread Dale B Stimson
As part of the System Managemenent Interface (SMI), use the HWMON subsystem to display power utilization. The following standard HWMON power sensors are currently supported (and appropriately scaled): /sys/class/drm/card0/device/hwmon/hwmon - energy1_input - power1_cap -

[PATCH v5 0/1] drm/i915/dg1: Add HWMON power sensor support

2021-06-16 Thread Dale B Stimson
drm/i915/dg1: Add HWMON power support As part of the System Managemenent Interface (SMI), use the HWMON subsystem to display power utilization. The following standard HWMON entries are currently supported (and appropriately scaled): /sys/class/drm/card0/device/hwmon/hwmon - energy1_input

Re: [PATCH v12 00/12] Restricted DMA

2021-06-16 Thread Claire Chang
v13: https://lore.kernel.org/patchwork/cover/1448001/

Re: [PATCH v13 00/12] Restricted DMA

2021-06-16 Thread Claire Chang
v13: https://lore.kernel.org/patchwork/cover/1448001/

[PATCH v5 01/12] drm/i915: Reference objects on the ww object list

2021-06-16 Thread Thomas Hellström
Since the ww transaction endpoint easily end up far out-of-scope of the objects on the ww object list, particularly for contending lock objects, make sure we reference objects on the list so they don't disappear under us. This comes with a performance penalty so it's been debated whether this is r

[PATCH v5 11/12] drm/i915/gem: Zap the client blt code

2021-06-16 Thread Thomas Hellström
It's not used anywhere. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- v4: - Add back the igt_client_tiled_blits selftest (Suggested by Matthew Auld) --- drivers/gpu/drm/i915/Makefile | 2 +- .../gpu/drm/i915/gem/i915_gem_client_blt.c| 355 --

[PATCH v5 04/12] drm/i915/gt: Add an insert_entry for gen8_ppgtt

2021-06-16 Thread Thomas Hellström
From: Chris Wilson In the next patch, we will want to write a PTE for an explicit dma address, outside of the usual vma. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/driv

[PATCH v5 06/12] drm/i915/gt: Export the pinned context constructor and destructor

2021-06-16 Thread Thomas Hellström
From: Chris Wilson Allow internal clients to create and destroy a pinned context. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- v2: - (Thomas) Export also the pinned context destructor --- drivers/gpu/drm/i915/gt/intel_engine.h| 11 + drivers/gpu/drm/i915/gt/intel_engi

[PATCH v5 12/12] drm/i915/gem: Zap the i915_gem_object_blt code

2021-06-16 Thread Thomas Hellström
It's unused with the exception of selftest. Replace a call in the memory_region live selftest with a call into a corresponding function in the new migrate code. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 1 - .../gpu/drm/i915/

[PATCH v5 10/12] drm/i915/ttm: accelerated move implementation

2021-06-16 Thread Thomas Hellström
From: Ramalingam C Invokes the pipelined page migration through blt, for i915_ttm_move requests of eviction and also obj clear. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellström --- v2: - subfunction for accel_move (Thomas) - engine_pm_get/put around context_move/clear (Thomas) - In

[PATCH v5 02/12] drm/i915: Break out dma_resv ww locking utilities to separate files

2021-06-16 Thread Thomas Hellström
As we're about to add more ww-related functionality, break out the dma_resv ww locking utilities to their own files Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- v2: - Make sure filenames are sorted in include file lists and Makefile (Reported by Matthew Auld) --- drivers/gpu/

[PATCH v5 09/12] drm/i915/gt: Setup a default migration context on the GT

2021-06-16 Thread Thomas Hellström
From: Chris Wilson Set up a default migration context on the GT and use it from the selftests. Add a perf selftest and make sure we exercise LMEM if available. Signed-off-by: Chris Wilson Co-developed-by: Thomas Hellström Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- v3: - Sk

[PATCH v5 07/12] drm/i915/gt: Pipelined page migration

2021-06-16 Thread Thomas Hellström
From: Chris Wilson If we pipeline the PTE updates and then do the copy of those pages within a single unpreemptible command packet, we can submit the copies and leave them to be scheduled without having to synchronously wait under a global lock. In order to manage migration, we need to preallocat

[PATCH v5 03/12] drm/i915: Introduce a ww transaction helper

2021-06-16 Thread Thomas Hellström
Introduce a for_i915_gem_ww(){} utility to help make the code around a ww transaction more readable. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_ww.h | 31 +- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git

[PATCH v5 00/12] i915 TTM sync accelerated migration and clear

2021-06-16 Thread Thomas Hellström
This patchset implements synchronous accelerated migration and clearing for i915 on TTM. We plan to follow up with these operations made asynchronous to the extent of TTM support for that: A couple of patches from Chris which implement pipelined migration and clears by atomically writing the PTEs

[PATCH v5 08/12] drm/i915/gt: Pipelined clear

2021-06-16 Thread Thomas Hellström
From: Chris Wilson Update the PTE and emit a clear within a single unpreemptible packet such that we can schedule and pipeline clears. Signed-off-by: Chris Wilson Co-developed-by: Thomas Hellström Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- v3: - Handle engine instances cor

[PATCH v5 05/12] drm/i915/gt: Add a routine to iterate over the pagetables of a GTT

2021-06-16 Thread Thomas Hellström
From: Chris Wilson In the next patch, we will want to look at the dma addresses of individual page tables, so add a routine to iterate over them. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 49 drivers/gpu/drm/i

[PATCH v13 12/12] of: Add plumbing for restricted DMA pool

2021-06-16 Thread Claire Chang
If a device is not behind an IOMMU, we look up the device node and set up the restricted DMA when the restricted-dma-pool is presented. Signed-off-by: Claire Chang Tested-by: Stefano Stabellini Tested-by: Will Deacon --- drivers/of/address.c| 33 + drivers/o

[PATCH v13 11/12] dt-bindings: of: Add restricted DMA pool

2021-06-16 Thread Claire Chang
Introduce the new compatible string, restricted-dma-pool, for restricted DMA. One can specify the address and length of the restricted DMA memory region by restricted-dma-pool in the reserved-memory node. Signed-off-by: Claire Chang Tested-by: Stefano Stabellini Tested-by: Will Deacon --- .../

[PATCH v13 10/12] swiotlb: Add restricted DMA pool initialization

2021-06-16 Thread Claire Chang
Add the initialization function to create restricted DMA pools from matching reserved-memory nodes. Regardless of swiotlb setting, the restricted DMA pool is preferred if available. The restricted DMA pools provide a basic level of protection against the DMA overwriting buffer contents at unexpec

[PATCH v13 09/12] swiotlb: Add restricted DMA alloc/free support

2021-06-16 Thread Claire Chang
Add the functions, swiotlb_{alloc,free} and is_swiotlb_for_alloc to support the memory allocation from restricted DMA pool. The restricted DMA pool is preferred if available. Note that since coherent allocation needs remapping, one must set up another device coherent pool by shared-dma-pool and u

[PATCH v13 08/12] swiotlb: Refactor swiotlb_tbl_unmap_single

2021-06-16 Thread Claire Chang
Add a new function, swiotlb_release_slots, to make the code reusable for supporting different bounce buffer pools. Signed-off-by: Claire Chang Reviewed-by: Christoph Hellwig Tested-by: Stefano Stabellini Tested-by: Will Deacon --- kernel/dma/swiotlb.c | 35 ---

[PATCH v13 07/12] swiotlb: Move alloc_size to swiotlb_find_slots

2021-06-16 Thread Claire Chang
Rename find_slots to swiotlb_find_slots and move the maintenance of alloc_size to it for better code reusability later. Signed-off-by: Claire Chang Reviewed-by: Christoph Hellwig Tested-by: Stefano Stabellini Tested-by: Will Deacon --- kernel/dma/swiotlb.c | 16 1 file change

[PATCH v13 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing

2021-06-16 Thread Claire Chang
Propagate the swiotlb_force into io_tlb_default_mem->force_bounce and use it to determine whether to bounce the data or not. This will be useful later to allow for different pools. Signed-off-by: Claire Chang Reviewed-by: Christoph Hellwig Tested-by: Stefano Stabellini Tested-by: Will Deacon -

[PATCH v13 05/12] swiotlb: Update is_swiotlb_active to add a struct device argument

2021-06-16 Thread Claire Chang
Update is_swiotlb_active to add a struct device argument. This will be useful later to allow for different pools. Signed-off-by: Claire Chang Reviewed-by: Christoph Hellwig Tested-by: Stefano Stabellini Tested-by: Will Deacon --- drivers/gpu/drm/i915/gem/i915_gem_internal.c | 2 +- drivers/gp

[PATCH v13 04/12] swiotlb: Update is_swiotlb_buffer to add a struct device argument

2021-06-16 Thread Claire Chang
Update is_swiotlb_buffer to add a struct device argument. This will be useful later to allow for different pools. Signed-off-by: Claire Chang Reviewed-by: Christoph Hellwig Tested-by: Stefano Stabellini Tested-by: Will Deacon --- drivers/iommu/dma-iommu.c | 12 ++-- drivers/xen/swiotl

[PATCH v13 03/12] swiotlb: Set dev->dma_io_tlb_mem to the swiotlb pool used

2021-06-16 Thread Claire Chang
Always have the pointer to the swiotlb pool used in struct device. This could help simplify the code for other pools. Signed-off-by: Claire Chang Reviewed-by: Christoph Hellwig Tested-by: Stefano Stabellini Tested-by: Will Deacon --- drivers/base/core.c| 4 include/linux/device.h | 4

[PATCH v13 02/12] swiotlb: Refactor swiotlb_create_debugfs

2021-06-16 Thread Claire Chang
Split the debugfs creation to make the code reusable for supporting different bounce buffer pools. Signed-off-by: Claire Chang Reviewed-by: Christoph Hellwig Tested-by: Stefano Stabellini Tested-by: Will Deacon --- kernel/dma/swiotlb.c | 21 ++--- 1 file changed, 14 insertions

[PATCH v13 01/12] swiotlb: Refactor swiotlb init functions

2021-06-16 Thread Claire Chang
Add a new function, swiotlb_init_io_tlb_mem, for the io_tlb_mem struct initialization to make the code reusable. Signed-off-by: Claire Chang Reviewed-by: Christoph Hellwig Tested-by: Stefano Stabellini Tested-by: Will Deacon --- kernel/dma/swiotlb.c | 50 ++

[PATCH v13 00/12] Restricted DMA

2021-06-16 Thread Claire Chang
This series implements mitigations for lack of DMA access control on systems without an IOMMU, which could result in the DMA accessing the system memory at unexpected times and/or unexpected addresses, possibly leading to data leakage or corruption. For example, we plan to use the PCI-e bus for Wi

Re: [PATCH v2 2/2] drm/bridge: ti-sn65dsi86: Implement the pwm_chip

2021-06-16 Thread Uwe Kleine-König
Hello Bjorn, On Wed, Jun 16, 2021 at 10:22:17PM -0500, Bjorn Andersson wrote: > > > +static int ti_sn_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, > > > +const struct pwm_state *state) > > > +{ > > > + struct ti_sn65dsi86 *pdata = pwm_chip_to_ti_sn_bridge(chip); > >

Re: [PATCH 2/3] drm/i915/guc: Update firmware to v62.0.0

2021-06-16 Thread Michal Wajdeczko
On 17.06.2021 03:41, Daniele Ceraolo Spurio wrote: > > > On 6/15/2021 5:13 PM, Matthew Brost wrote: >> From: Michal Wajdeczko >> >> Most of the changes to the 62.0.0 firmware revolved around CTB >> communication channel. Conform to the new (stable) CTB protocol. >> >> v2: >>   (Michal) >>   

[PATCH v2] drm/panfrost:report the full raw fault information instead

2021-06-16 Thread ChunyouTang
From: ChunyouTang of the low 8 bits. Signed-off-by: ChunyouTang --- drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c index 1fffb6a0b24f..d2d287bbf4e7 10

Re: [PATCH v2 2/2] drm/bridge: ti-sn65dsi86: Implement the pwm_chip

2021-06-16 Thread Bjorn Andersson
On Wed 16 Jun 02:56 CDT 2021, Uwe Kleine-K?nig wrote: > Hello Bjorn, > > On Tue, Jun 15, 2021 at 06:18:28PM -0500, Bjorn Andersson wrote: > > The SN65DSI86 provides the ability to supply a PWM signal on GPIO 4, > > with the primary purpose of controlling the backlight of the attached > > panel. A

[pull] amdgpu, amdkfd drm-next-5.14

2021-06-16 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.14. The following changes since commit c707b73f0cfb1acc94a20389aecde65e6385349b: Merge tag 'amd-drm-next-5.14-2021-06-09' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2021-06-10 13:47:13 +1000) are available in the Git repository at: https://g

[PATCH -next] drm/amd/display: Fix gcc unused variable warning

2021-06-16 Thread Pu Lehui
GCC reports the following warning with W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3635:17: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] 3635 | enum dc_status status = DC_ERROR_UNEXPECTED; | ^~ The variable should be us

Re: [PATCH] dt-bindings: display: renesas,du: Make resets optional on R-Car H1

2021-06-16 Thread Laurent Pinchart
Hi Geert, On Thu, Apr 29, 2021 at 06:47:06PM +0300, Laurent Pinchart wrote: > On Thu, Apr 29, 2021 at 02:47:31PM +0200, Geert Uytterhoeven wrote: > > The "resets" property is not present on R-Car Gen1 SoCs. > > Supporting it would require migrating from renesas,cpg-clocks to > > renesas,cpg-mssr.

linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2021-06-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/vc4/vc4_hdmi.c between commit: 9984d6664ce9 ("drm/vc4: hdmi: Make sure the controller is powered in detect") from the drm-misc-fixes tree and commit: 6800234ceee0 ("drm/vc4: hdmi: Convert to gpiod") fro

Re: [PATCH 2/3] drm/i915/guc: Update firmware to v62.0.0

2021-06-16 Thread Daniele Ceraolo Spurio
On 6/15/2021 5:13 PM, Matthew Brost wrote: From: Michal Wajdeczko Most of the changes to the 62.0.0 firmware revolved around CTB communication channel. Conform to the new (stable) CTB protocol. v2: (Michal) Add values back to kernel DOC for actions (Docs) Add 'CT buffer' back in t

Re: [PATCH 8/8] drm/i915: Move submission tasklet to i915_sched_engine

2021-06-16 Thread Daniele Ceraolo Spurio
On 6/15/2021 3:43 PM, Matthew Brost wrote: The submission tasklet operates on i915_sched_engine, thus it is the correct place for it. v3: (Jason Ekstrand) Change sched_engine->engine to a void* private data pointer Add kernel doc v4: (Daniele) Update private_data comment Set q

Re: [PATCH v11 00/10] Add support for SVM atomics in Nouveau

2021-06-16 Thread Alistair Popple
On Thursday, 17 June 2021 9:35:29 AM AEST Andrew Morton wrote: > On Wed, 16 Jun 2021 20:59:27 +1000 Alistair Popple wrote: > > > This is my series to add support for SVM atomics in Nouveau > > Can we please have a nice [0/n] overview for this patchset? > Sorry, I forgot to include that this t

Update: [PATCH v11 00/10] Add support for SVM atomics in Nouveau

2021-06-16 Thread Alistair Popple
Introduction Some devices have features such as atomic PTE bits that can be used to implement atomic access to system memory. To support atomic operations to a shared virtual memory page such a device needs access to that page which is exclusive of the CPU. This series introduces a me

[PATCH -next] drm/amd/display: remove unused variable 'dc'

2021-06-16 Thread Pu Lehui
GCC reports the following warning with W=1: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13: warning: variable ‘dc’ set but not used [-Wunused-but-set-variable] 70 | struct dc *dc = NULL; | ^~ This variable is not used in function, this commit remove

[PATCH] drm/msm/dp: add logs across DP driver for ease of debugging

2021-06-16 Thread maitreye
From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Signed-off-by: Maitreyee Rao --- drivers/gpu/drm/msm/dp/dp_aux.c | 5 +++-- drivers/gpu/drm/msm/dp/dp_catalog.c | 4 drivers/gpu/drm/msm/dp/dp_ctrl.c| 7 +++ drivers/gpu/drm/msm/dp/d

Re: [PATCH v12 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing

2021-06-16 Thread Stefano Stabellini
On Wed, 16 Jun 2021, Claire Chang wrote: > Propagate the swiotlb_force into io_tlb_default_mem->force_bounce and > use it to determine whether to bounce the data or not. This will be > useful later to allow for different pools. > > Signed-off-by: Claire Chang > --- > include/linux/swiotlb.h | 11

Re: [PATCH v12 11/12] dt-bindings: of: Add restricted DMA pool

2021-06-16 Thread Stefano Stabellini
On Wed, 16 Jun 2021, Claire Chang wrote: > Introduce the new compatible string, restricted-dma-pool, for restricted > DMA. One can specify the address and length of the restricted DMA memory > region by restricted-dma-pool in the reserved-memory node. > > Signed-off-by: Claire Chang > --- > .../

Re: [PATCH v2 1/2] dt-bindings: Add SONY Synaptics JDI panel

2021-06-16 Thread Rob Herring
On Sat, Jun 05, 2021 at 12:49:40PM +0200, Konrad Dybcio wrote: > Add bindings for the SONY Synaptics JDI panel used in > Xperia X, X Performance, X Compact, XZ and XZs smartphones. > > Due to the nature of phone manufacturing and lack of any docs > whatsoever, replacement names have been used to i

Re: [PATCH v11 00/10] Add support for SVM atomics in Nouveau

2021-06-16 Thread Andrew Morton
On Wed, 16 Jun 2021 20:59:27 +1000 Alistair Popple wrote: > This is my series to add support for SVM atomics in Nouveau Can we please have a nice [0/n] overview for this patchset?

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-16 Thread Laurent Pinchart
On Tue, Jun 15, 2021 at 01:16:56PM +0300, Pekka Paalanen wrote: > On Tue, 15 Jun 2021 12:45:57 +0300 Laurent Pinchart wrote: > > On Tue, Jun 15, 2021 at 07:15:18AM +, Simon Ser wrote: > > > On Tuesday, June 15th, 2021 at 09:03, Pekka Paalanen wrote: > > > > > > > indeed it will, but what els

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2021-06-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 --- Comment #27 from Leandro Jacques (ls...@yahoo.com) --- Comment on attachment 297415 --> https://bugzilla.kernel.org/attachment.cgi?id=297415 Kernel crash log for kernel 5.10.x I had to downgrade to kernel 5.4 LTS to get rid of any problems

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2021-06-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 --- Comment #26 from Leandro Jacques (ls...@yahoo.com) --- Created attachment 297415 --> https://bugzilla.kernel.org/attachment.cgi?id=297415&action=edit Kernel crash log for kernel 5.10.x -- You may reply to this email to add a comment. You

[Bug 213391] AMDGPU retries page fault with some specific processes amdgpu and sometimes followed [gfxhub0] retry page fault until *ERROR* ring gfx timeout, but soft recovered

2021-06-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213391 Leandro Jacques (ls...@yahoo.com) changed: What|Removed |Added CC||ls...@yahoo.com --- C

[PATCH][next] drm/amd/display: Fix fall-through warning for Clang

2021-06-16 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix the following warning by replacing a /* fall through */ comment with the new pseudo-keyword macro fallthrough: rivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c:672:4: warning: unannotated fall-through between switch labels [-Wimp

[pull] amdgpu drm-fixes-5.13

2021-06-16 Thread Alex Deucher
Hi Dave, Daniel, Just a couple of small fixes for 5.13. The following changes since commit 7de5c0d70c779454785dd2431707df5b841eaeaf: Merge tag 'amd-drm-fixes-5.13-2021-06-09' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2021-06-11 11:17:10 +1000) are available in the Git re

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-16 Thread Daniel Vetter
On Tue, Jun 15, 2021 at 2:09 PM Simon Ser wrote: > > On Tuesday, June 15th, 2021 at 12:16, Pekka Paalanen > wrote: > > > Good reminder about CRCs. CRCs have zero tolerance, so they are not > > useful for testing properties that have any leeway, are they? > > IIRC, IGT's alpha blending test curre

Re: [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev()

2021-06-16 Thread Kirti Wankhede
-static int mtty_reset(struct mdev_device *mdev) +static int mtty_reset(struct mdev_state *mdev_stte) Nit pick: s/mdev_stte/mdev_state +static const struct vfio_device_ops mtty_dev_ops = { + .name = "vfio-mdev", I think name should be different that 'vfio-mdev', probably 'vfio-m

Re: [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind

2021-06-16 Thread Kirti Wankhede
On 6/15/2021 7:05 PM, Christoph Hellwig wrote: From: Jason Gunthorpe This allows a mdev driver to opt out of using vfio_mdev.c, instead the driver will provide a 'struct mdev_driver' and register directly with the driver core. Much of mdev_parent_ops becomes unused in this mode: - create()/

Re: [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE

2021-06-16 Thread Kirti Wankhede
On 6/15/2021 7:05 PM, Christoph Hellwig wrote: From: Jason Gunthorpe For some reason the vfio_mdev shim mdev_driver has its own module and kconfig. As the next patch requires access to it from mdev.ko merge the two modules together and remove VFIO_MDEV_DEVICE. A later patch deletes this dri

Re: [PATCH 02/10] driver core: Better distinguish probe errors in really_probe

2021-06-16 Thread Kirti Wankhede
On 6/15/2021 7:05 PM, Christoph Hellwig wrote: really_probe tries to special case errors from ->probe, but due to all other initialization added to the function over time now a lot of internal errors hit that code path as well. Untangle that by adding a new probe_err local variable and apply

Re: [PATCH 29/31] drm/i915/gem: Roll all of context creation together

2021-06-16 Thread kernel test robot
Hi Jason, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next next-20210616] [cannot apply to tegra-drm/drm/tegra/for-next drm/drm-next v5.13-rc6] [If your patch is

Re: [PATCH v2 1/2] drm/dp_mst: Do not set proposed vcpi directly

2021-06-16 Thread Harry Wentland
On 2021-06-15 11:55 p.m., Wayne Lin wrote: > [Why] > When we receive CSN message to notify one port is disconnected, we will > implicitly set its corresponding num_slots to 0. Later on, we will > eventually call drm_dp_update_payload_part1() to arrange down streams. > > In drm_dp_update_payload

Re: [PATCH] drm/dp_mst: Add missing drm parameters to recently added call to drm_dbg_kms()

2021-06-16 Thread Lyude Paul
Reviewed-by: Lyude Paul Will go ahead and push this to drm-misc-next-fixes, thanks On Wed, 2021-06-16 at 12:44 -0700, José Roberto de Souza wrote: > Commit 3769e4c0af5b ("drm/dp_mst: Avoid to mess up payload table by > ports in stale topology") added to calls to drm_dbg_kms() but it > missed the

[PATCH] drm/dp_mst: Add missing drm parameters to recently added call to drm_dbg_kms()

2021-06-16 Thread José Roberto de Souza
Commit 3769e4c0af5b ("drm/dp_mst: Avoid to mess up payload table by ports in stale topology") added to calls to drm_dbg_kms() but it missed the first parameter, the drm device breaking the build. Fixes: 3769e4c0af5b ("drm/dp_mst: Avoid to mess up payload table by ports in stale topology") Cc: Way

Re: [PATCH v2 2/2] drm/dp_mst: Avoid to mess up payload table by ports in stale topology

2021-06-16 Thread Souza, Jose
On Wed, 2021-06-16 at 11:55 +0800, Wayne Lin wrote: > [Why] > After unplug/hotplug hub from the system, userspace might start to > clear stale payloads gradually. If we call drm_dp_mst_deallocate_vcpi() > to release stale VCPI of those ports which are not relating to current > topology, we have cha

Re: [v6 1/5] drm/panel: add basic DP AUX backlight support

2021-06-16 Thread Lyude Paul
Reviewed-by: Lyude Paul On Sat, 2021-06-12 at 17:37 +0530, Rajeev Nandan wrote: > Some panels support backlight control over DP AUX channel using > VESA's standard backlight control interface. > Using new DRM eDP backlight helpers, add support to create and > register a backlight for those panels

Re: [PATCH] drm/ttm: fix error handling in ttm_bo_handle_move_mem()

2021-06-16 Thread Dan Carpenter
On Wed, Jun 16, 2021 at 01:00:38PM +0200, Christian König wrote: > > > Am 16.06.21 um 11:36 schrieb Dan Carpenter: > > On Wed, Jun 16, 2021 at 10:47:14AM +0200, Christian König wrote: > > > > > > Am 16.06.21 um 10:37 schrieb Dan Carpenter: > > > > On Wed, Jun 16, 2021 at 08:46:33AM +0200, Christ

Re: [PATCH 4/7] dma-buf: add dma_fence_chain_garbage_collect

2021-06-16 Thread kernel test robot
Hi "Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13-rc6 next-20210616] [cannot apply to drm-tip/drm-tip drm/drm-next] [If

Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems

2021-06-16 Thread Wolfram Sang
On Tue, Jun 15, 2021 at 01:15:43PM -0600, Rob Herring wrote: > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fi

[PULL] drm-misc-next-fixes

2021-06-16 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-next-fixes. Best regards Thomas drm-misc-next-fixes-2021-06-16: Short summary of fixes pull: * hyperv: advertise the correct formatmodifiers for its primary plane * dp_mst: VCPI fixes to make it work with StarTech hub The following chang

Re: [Mesa-dev] [PATCH 0/6] dma-buf: Add an API for exporting sync files (v12)

2021-06-16 Thread Jason Ekstrand
On Tue, Jun 15, 2021 at 3:41 AM Christian König wrote: > > Hi Jason & Daniel, > > maybe I should explain once more where the problem with this approach is > and why I think we need to get that fixed before we can do something > like this here. > > To summarize what this patch here does is that it

Re: [PATCH 4/7] dma-buf: add dma_fence_chain_garbage_collect

2021-06-16 Thread kernel test robot
Hi "Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13-rc6 next-20210616] [cannot apply to drm-tip/drm-tip drm/drm-next] [If

Re: [Intel-gfx] [PATCH 5/5] DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe

2021-06-16 Thread kernel test robot
Hi Jason, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13-rc6 next-20210616] [cannot apply to drm/drm-next] [If

Re: [Intel-gfx] [PATCH 06/31] drm/i915: Drop the CONTEXT_CLONE API (v2)

2021-06-16 Thread kernel test robot
the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v6/20210616-151016 b

[PATCH v5 4/7] drm/i915/ttm: pass along the I915_BO_ALLOC_CONTIGUOUS

2021-06-16 Thread Matthew Auld
Currently we just ignore the I915_BO_ALLOC_CONTIGUOUS flag, which is fine since everything is already contiguous with the ttm range manager. However in the next patch we want to switch over to the ttm buddy manager, where allocations are by default not contiguous. v2(Thomas): - Forward ALLOC_C

[PATCH v5 3/7] drm/i915/ttm: Calculate the object placement at get_pages time

2021-06-16 Thread Matthew Auld
From: Thomas Hellström Instead of relying on a static placement, calculate at get_pages() time. This should work for LMEM regions and system for now. For stolen we need to take preallocated range into account. That will if needed be added later. Signed-off-by: Thomas Hellström Reviewed-by: Matt

[PATCH v5 2/7] drm/i915/ttm: add i915_sg_from_buddy_resource

2021-06-16 Thread Matthew Auld
We need to be able to build an sg table from our list of buddy blocks, so that we can later plug this into our ttm backend, and replace our use of the range manager. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_scatterlist.c | 80

[PATCH v5 7/7] drm/i915/ttm: restore min_page_size behaviour

2021-06-16 Thread Matthew Auld
We now have bo->page_alignment which perfectly describes what we need if we have min page size restrictions for lmem. We can also drop the flag here, since this is the default behaviour for all objects. v2(Thomas): - bo->page_alignment is in page units Signed-off-by: Matthew Auld Cc: Thomas

[PATCH v5 5/7] drm/i915/ttm: remove node usage in our naming

2021-06-16 Thread Matthew Auld
Now that ttm_resource_manager just returns a generic ttm_resource we don't need to reference the mm_node stuff anymore which mostly only makes sense for drm_mm_node. In the next few patches we want switch over to the ttm_buddy_man which is just another type of ttm_resource so reflect that in the na

[PATCH v5 6/7] drm/i915/ttm: switch over to ttm_buddy_man

2021-06-16 Thread Matthew Auld
Move back to the buddy allocator for managing device local memory, and restore the lost mock selftests. Keep around the range manager related bits, since we likely need this for managing stolen at some point. For stolen we also don't need to reserve anything so no need to support a generic reserve

[PATCH v5 1/7] drm/i915/ttm: add ttm_buddy_man

2021-06-16 Thread Matthew Auld
Add back our standalone i915_buddy allocator and integrate it into a ttm_resource_manager. This will plug into our ttm backend for managing device local-memory in the next couple of patches. v2(Thomas): - Return -ENOSPC from the buddy; ttm expects this in order to trigger eviction -

Re: [Intel-gfx] [PATCH 0/3] Update firmware to v62.0.0

2021-06-16 Thread Mike Lothian
Hi Is there a place where we can download these new firmware images? Cheers Mike On Wed, 16 Jun 2021 at 00:55, Matthew Brost wrote: > As part of enabling GuC submission [1] we need to update to the latest > and greatest firmware. This series does that. All backwards > compatibility breaking c

[GIT PULL] mediatek drm next for 5.14

2021-06-16 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Add MT8167 HDMI support 2. Fix PM reference leak 3. Add MT8183 DPI dual edge support Regards, Chun-Kuang. The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) are available in the Git rep

Re: [v6 5/5] drm/panel-simple: Add Samsung ATNA33XC20

2021-06-16 Thread Doug Anderson
Hi, On Sat, Jun 12, 2021 at 5:09 AM Rajeev Nandan wrote: > > +static const struct panel_desc samsung_atna33xc20 = { > + .modes = &samsung_atna33xc20_mode, > + .num_modes = 1, > + .bpc = 10, > + .size = { > + .width = 294, > + .height = 165, > +

[PATCH v4 7/7] drm/i915/ttm: restore min_page_size behaviour

2021-06-16 Thread Matthew Auld
We now have bo->page_alignment which perfectly describes what we need if we have min page size restrictions for lmem. We can also drop the flag here, since this is the default behaviour for all objects. v2(Thomas): - bo->page_alignment is in page units Signed-off-by: Matthew Auld Cc: Thomas

[PATCH v4 6/7] drm/i915/ttm: switch over to ttm_buddy_man

2021-06-16 Thread Matthew Auld
Move back to the buddy allocator for managing device local memory, and restore the lost mock selftests. Keep around the range manager related bits, since we likely need this for managing stolen at some point. For stolen we also don't need to reserve anything so no need to support a generic reserve

[PATCH v4 5/7] drm/i915/ttm: remove node usage in our naming

2021-06-16 Thread Matthew Auld
Now that ttm_resource_manager just returns a generic ttm_resource we don't need to reference the mm_node stuff anymore which mostly only makes sense for drm_mm_node. In the next few patches we want switch over to the ttm_buddy_man which is just another type of ttm_resource so reflect that in the na

[PATCH v4 4/7] drm/i915/ttm: pass along the I915_BO_ALLOC_CONTIGUOUS

2021-06-16 Thread Matthew Auld
Currently we just ignore the I915_BO_ALLOC_CONTIGUOUS flag, which is fine since everything is already contiguous with the ttm range manager. However in the next patch we want to switch over to the ttm buddy manager, where allocations are by default not contiguous. v2(Thomas): - Forward ALLOC_C

[PATCH v4 3/7] drm/i915/ttm: Calculate the object placement at get_pages time

2021-06-16 Thread Matthew Auld
From: Thomas Hellström Instead of relying on a static placement, calculate at get_pages() time. This should work for LMEM regions and system for now. For stolen we need to take preallocated range into account. That well be added later. Instead of relying on a static placement, calculate at get_p

[PATCH v4 1/7] drm/i915/ttm: add ttm_buddy_man

2021-06-16 Thread Matthew Auld
Add back our standalone i915_buddy allocator and integrate it into a ttm_resource_manager. This will plug into our ttm backend for managing device local-memory in the next couple of patches. v2(Thomas): - Return -ENOSPC from the buddy; ttm expects this in order to trigger eviction -

[PATCH v4 2/7] drm/i915/ttm: add i915_sg_from_buddy_resource

2021-06-16 Thread Matthew Auld
We need to be able to build an sg table from our list of buddy blocks, so that we can later plug this into our ttm backend, and replace our use of the range manager. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_scatterlist.c | 80

[PATCH] drm/display: Fix duplicated argument

2021-06-16 Thread Wan Jiabing
Fix coccicheck warning: ./drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c: 55:12-42: duplicated argument to && or || Signed-off-by: Wan Jiabing --- .../gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4] Documentation: gpu: Mention the requirements for new properties

2021-06-16 Thread Maxime Ripard
New KMS properties come with a bunch of requirements to avoid each driver from running their own, inconsistent, set of properties, eventually leading to issues like property conflicts, inconsistencies between drivers and semantics, etc. Let's document what we expect. Cc: Alexandre Belloni Cc: Al

Re: [PATCH 1/3] drm/i915/guc: Add fetch of hwconfig table

2021-06-16 Thread kernel test robot
use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/John-C-Harrison-Intel-com/Add-support-for-querying-hw-info-that-UMDs-need/20210616-141805 base: git://anongit.freedesktop.org/drm-intel for-linux-next conf

Re: [PATCH] drm/i915: allow DG1 autoprobe for CONFIG_BROKEN

2021-06-16 Thread Matthew Auld
On Mon, 14 Jun 2021 at 10:22, Matthew Auld wrote: > > Purely for CI so we can get some pre-merge results for DG1. This is > especially useful for cross driver TTM changes where CI can hopefully > catch regressions. This is similar to how we already handle the DG1 > specific uAPI, which are also hi

[PATCH v2 3/3] drm: Mention the power state requirement on side-channel operations

2021-06-16 Thread Maxime Ripard
The drm_connector detect, drm_dp_aux transfer and mipi_dsi_host operations typically require to access their underlying device to perform what is expected of them. However, there's no guarantee on the fact that the device has been enabled through atomic_enable or similar that will usually power th

[PATCH v2 2/3] drm/dp_helper: Mention the concurrency requirement hw_mutex

2021-06-16 Thread Maxime Ripard
Drivers that allow concurrent access over multiple DP channels need to provide additional locking, even though the hw_mutex field might indicate otherwise. Clarify it in the documentation. Suggested-by: Daniel Vetter Signed-off-by: Maxime Ripard --- Changes from v1: - New patch --- include/

[PATCH v2 1/3] drm/dp_helper: Rework the drm_dp_aux documentation

2021-06-16 Thread Maxime Ripard
Split the existing documentation to move the comments on particular fields next to them. Suggested-by: Daniel Vetter Signed-off-by: Maxime Ripard --- Changes from v1: - New patch --- include/drm/drm_dp_helper.h | 84 + 1 file changed, 57 insertions(+), 27

Re: Allow mdev drivers to directly create the vfio_device (v3)

2021-06-16 Thread Jason Gunthorpe
On Wed, Jun 16, 2021 at 05:13:13AM +0200, Christoph Hellwig wrote: > On Tue, Jun 15, 2021 at 05:35:15PM -0300, Jason Gunthorpe wrote: > > Yes, the rest of the drivers will get converted eventually too. There > > is no reason to hold things back. Depending on timelines we might be > > able to get AP

Re: [PATCH] drm/i915: return DRIVER_NAME for the fence driver name

2021-06-16 Thread Daniel Vetter
On Wed, Jun 16, 2021 at 01:28:33PM +0100, Matthew Auld wrote: > The first tracepoint for a request is trace_dma_fence_init which is > called in the ctor before we have properly setup the request->engine. So > if it's a non-recycled request the rq->engine might be NULL, or some > garbage value, whic

Re: [Intel-gfx] [PATCH 4/5] dma-buf: Stop using SLAB_TYPESAFE_BY_RCU in selftests

2021-06-16 Thread kernel test robot
BY_RCU-for-dma_fence/20210616-154432 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: sparc-randconfig-s032-20210615 (attached as .config) compiler: sparc-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross

  1   2   >