Re: [PATCH 2/2] drm/i915/gem: Migrate to system at dma-buf attach time (v5)

2021-07-14 Thread Daniel Vetter
On Wed, Jul 14, 2021 at 11:01 PM Jason Ekstrand wrote: > > On Tue, Jul 13, 2021 at 10:23 AM Daniel Vetter wrote: > > > > On Tue, Jul 13, 2021 at 04:06:13PM +0100, Matthew Auld wrote: > > > On Tue, 13 Jul 2021 at 15:44, Daniel Vetter wrote: > > > > > > > > On Mon, Jul 12, 2021 at 06:12:34PM

Re: [pull] amdgpu, amdkfd drm-fixes-5.14

2021-07-14 Thread Sam Ravnborg
Hi Alex, On Wed, Jul 14, 2021 at 06:08:58PM -0400, Alex Deucher wrote: > Hi Dave, Daniel, > > Fixes for 5.14. The big change here is unifying the SMU13 code. This was > new code added in 5.14 to support Yellow Carp, but we've since cleaned it > up and removed a lot of duplication, so better to

[tegra-drm:drm/tegra/for-next 9/14] drivers/gpu/drm/tegra/uapi.c:278:5: warning: no previous prototype for function 'tegra_drm_ioctl_gem_create'

2021-07-14 Thread kernel test robot
tree: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next head: b19502d1a683c11f6f2c92ad63c61288b0fbe1a1 commit: cdf631031f3e574b76afed51bda0ccc9d71d4a4e [9/14] drm/tegra: Implement new UAPI config: arm64-randconfig-r025-20210714 (attached as .config) compiler: clang version

[PATCH 11/13] vfio/ap, ccw: Fix open/close when multiple device FDs are open

2021-07-14 Thread Jason Gunthorpe
The user can open multiple device FDs if it likes, however these open() functions call vfio_register_notifier() on some device global state. Calling vfio_register_notifier() twice in will trigger a WARN_ON from notifier_chain_register() and the first close will wrongly delete the notifier and

linux-next: Signed-off-by missing for commit in the drm-intel tree

2021-07-14 Thread Stephen Rothwell
Hi all, Commit db47fe727e1f ("drm/i915/step: s/_revid_tbl/_revids") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpLlySaYdecR.pgp Description: OpenPGP digital signature

[tegra-drm:drm/tegra/for-next 1/14] drivers/gpu/host1x/fence.c:168:5: warning: no previous prototype for function 'host1x_fence_create_fd'

2021-07-14 Thread kernel test robot
tree: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next head: b19502d1a683c11f6f2c92ad63c61288b0fbe1a1 commit: ad0529424defbbe0b6a154cc100e82c1a9f91400 [1/14] gpu: host1x: Add DMA fence implementation config: arm64-randconfig-r025-20210714 (attached as .config) compiler: clang

Re: [PATCH 2/2 v4] drm/panel: ws2401: Add driver for WideChips WS2401

2021-07-14 Thread Doug Anderson
Hi, On Wed, Jul 14, 2021 at 3:52 PM Linus Walleij wrote: > > This adds a driver for panels based on the WideChips WS2401 display > controller. This display controller is used in the Samsung LMS380KF01 > display found in the Samsung GT-I8160 (Codina) mobile phone and > possibly others. > > As is

[PATCH -next v2] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()

2021-07-14 Thread Yang Yingliang
Replace pci_enable_device() with pcim_enable_device(), pci_disable_device() will be called in release automatically. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- v2: use pcim_enable_device() --- drivers/gpu/drm/tiny/bochs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Intel-gfx] [PATCH 07/16] drm/i915/guc/slpc: Enable slpc and add related H2G events

2021-07-14 Thread Belgaumkar, Vinay
On 7/10/2021 10:37 AM, Michal Wajdeczko wrote: On 10.07.2021 03:20, Vinay Belgaumkar wrote: Add methods for interacting with guc for enabling SLPC. Enable SLPC after guc submission has been established. GuC load will s/guc/GuC fail if SLPC cannot be successfully initialized. Add

Re: [PATCH 19/47] drm/i915/guc: Ensure request ordering via completion fences

2021-07-14 Thread Daniele Ceraolo Spurio
On 6/24/2021 12:04 AM, Matthew Brost wrote: If two requests are on the same ring, they are explicitly ordered by the HW. So, a submission fence is sufficient to ensure ordering when using the new GuC submission interface. Conversely, if two requests share a timeline and are on the same

Re: [PATCH 26/47] drm/i915/guc: GuC virtual engines

2021-07-14 Thread Daniele Ceraolo Spurio
On 6/24/2021 12:04 AM, Matthew Brost wrote: Implement GuC virtual engines. Rather simple implementation, basically just allocate an engine, setup context enter / exit function to virtual engine specific functions, set all other variables / functions to guc versions, and set the engine mask to

Re: [PATCH 31/47] drm/i915/guc: Reset implementation for new GuC interface

2021-07-14 Thread Matthew Brost
On Mon, Jul 12, 2021 at 12:58:45PM -0700, John Harrison wrote: > On 6/24/2021 00:05, Matthew Brost wrote: > > Reset implementation for new GuC interface. This is the legacy reset > > implementation which is called when the i915 owns the engine hang check. > > Future patches will offload the engine

Re: [Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+

2021-07-14 Thread Matthew Brost
On Thu, Jun 24, 2021 at 12:05:16AM -0700, Matthew Brost wrote: > From: Daniele Ceraolo Spurio > > Unblock GuC submission on Gen11+ platforms. > > Signed-off-by: Michal Wajdeczko > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Matthew Brost Updating debug message per feedback, with

Re: [Intel-gfx] [PATCH 42/47] drm/i915/guc: Fix for error capture after full GPU reset with GuC

2021-07-14 Thread Matthew Brost
On Thu, Jun 24, 2021 at 12:05:11AM -0700, Matthew Brost wrote: > From: John Harrison > > In the case of a full GPU reset (e.g. because GuC has died or because > GuC's hang detection has been disabled), the driver can't rely on GuC > reporting the guilty context. Instead, the driver needs to scan

Re: [PATCH 35/47] drm/i915/guc: Handle context reset notification

2021-07-14 Thread Matthew Brost
On Mon, Jul 12, 2021 at 03:58:12PM -0700, John Harrison wrote: > On 6/24/2021 00:05, Matthew Brost wrote: > > GuC will issue a reset on detecting an engine hang and will notify > > the driver via a G2H message. The driver will service the notification > > by resetting the guilty context to a

[PATCH 09/13] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set

2021-07-14 Thread Jason Gunthorpe
Like vfio_pci_try_bus_reset() this code wants to reset all of the devices in the "reset group" which is the same membership as the device set. Instead of trying to reconstruct the device set from the PCI list go directly from the device set's device list to execute the reset. The same basic

[PATCH 08/13] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set

2021-07-14 Thread Jason Gunthorpe
Keep track of all the vfio_devices that have been added to the device set and use this list in vfio_pci_try_bus_reset() instead of trying to work backwards from the pci_device. The dev_set->lock directly prevents devices from joining/leaving the set, which further implies the pci_device cannot

[PATCH 07/13] vfio/pci: Move to the device set infrastructure

2021-07-14 Thread Jason Gunthorpe
From: Yishai Hadas PCI wants to have the usual open/close_device() logic with the slight twist that the open/close_device() must be done under a singelton lock shared by all of the vfio_devices that are in the PCI "reset group". The reset group, and thus the device set, is determined by what

[PATCH 05/13] vfio/fsl: Move to the device set infrastructure

2021-07-14 Thread Jason Gunthorpe
FSL uses the internal reflck to implement the open_device() functionality, conversion to the core code is straightforward. The decision on which set to be part of is trivially based on the is_fsl_mc_bus_dprc() and we use a 'struct device *' pointer as the set_id. It isn't entirely clear what the

[PATCH 13/13] vfio: Remove struct vfio_device_ops open/release

2021-07-14 Thread Jason Gunthorpe
Nothing uses this anymore, delete it. Signed-off-by: Yishai Hadas Signed-off-by: Jason Gunthorpe --- drivers/vfio/mdev/vfio_mdev.c | 22 -- drivers/vfio/vfio.c | 14 +- include/linux/mdev.h | 7 --- include/linux/vfio.h | 4

[PATCH 10/13] vfio/mbochs: Fix close when multiple device FDs are open

2021-07-14 Thread Jason Gunthorpe
mbochs_close() iterates over global device state and frees it. Currently this is done every time a device FD is closed, but if multiple device FDs are open this could corrupt other still active FDs. Change this to use close_device() so it only runs on the last close. Signed-off-by: Jason

[PATCH 12/13] vfio/gvt: Fix open/close when multiple device FDs are open

2021-07-14 Thread Jason Gunthorpe
The user can open multiple device FDs if it likes, however the open function calls vfio_register_notifier() on device global state. Calling vfio_register_notifier() twice will trigger a WARN_ON from notifier_chain_register() and the first close will wrongly delete the notifier and more. Since

[PATCH 03/13] vfio: Provide better generic support for open/release vfio_device_ops

2021-07-14 Thread Jason Gunthorpe
Currently the driver ops have an open/release pair that is called once each time a device FD is opened or closed. Add an additional set of open/close_device() ops which are called when the device FD is opened for the first time and closed for the last time. An analysis shows that all of the

[PATCH 01/13] vfio/samples: Remove module get/put

2021-07-14 Thread Jason Gunthorpe
The patch to move the get/put to core and the patch to convert the samples to use vfio_device crossed in a way that this was missed. When both patches are together the samples do not need their own get/put. Fixes: 437e41368c01 ("vfio/mdpy: Convert to use vfio_register_group_dev()") Fixes:

[PATCH 06/13] vfio/platform: Use open_device() instead of open coding a refcnt scheme

2021-07-14 Thread Jason Gunthorpe
Platform simply wants to run some code when the device is first opened/last closed. Use the core framework and locking for this. Aside from removing a bit of code this narrows the locking scope from a global lock. Signed-off-by: Yishai Hadas Signed-off-by: Jason Gunthorpe ---

[PATCH 04/13] vfio/samples: Delete useless open/close

2021-07-14 Thread Jason Gunthorpe
The core code no longer requires these ops to be defined, so delete these empty functions and leave the op as NULL. mtty's functions only log a pointless message, delete that entirely. Signed-off-by: Yishai Hadas Signed-off-by: Jason Gunthorpe --- samples/vfio-mdev/mbochs.c | 6 --

[PATCH 00/13] Provide core infrastructure for managing open/release

2021-07-14 Thread Jason Gunthorpe
Prologue: This is the first series of three to send the "mlx5_vfio_pci" driver that has been discussed on the list for a while now. - Reorganize reflck to support splitting vfio_pci - Split vfio_pci into vfio_pci/vfio_pci_core and provide infrastructure for non-generic VFIO PCI drivers -

[PATCH 02/13] vfio: Introduce a vfio_uninit_group_dev() API call

2021-07-14 Thread Jason Gunthorpe
From: Max Gurtovoy This pairs with vfio_init_group_dev() and allows undoing any state that is stored in the vfio_device unrelated to registration. Add appropriately placed calls to all the drivers. The following patch will use this to add pre-registration state for the device set.

Re: [PATCH 21/47] drm/i915/guc: Ensure G2H response has space in buffer

2021-07-14 Thread John Harrison
On 7/14/2021 17:06, Matthew Brost wrote: On Tue, Jul 13, 2021 at 11:36:05AM -0700, John Harrison wrote: On 6/24/2021 00:04, Matthew Brost wrote: Ensure G2H response has space in the buffer before sending H2G CTB as the GuC can't handle any backpressure on the G2H interface. Signed-off-by:

Re: [PATCH 20/47] drm/i915/guc: Disable semaphores when using GuC scheduling

2021-07-14 Thread Matthew Brost
On Fri, Jul 09, 2021 at 04:53:37PM -0700, John Harrison wrote: > On 6/24/2021 00:04, Matthew Brost wrote: > > Semaphores are an optimization and not required for basic GuC submission > > to work properly. Disable until we have time to do the implementation to > > enable semaphores and tune them

Re: [PATCH 21/47] drm/i915/guc: Ensure G2H response has space in buffer

2021-07-14 Thread Matthew Brost
On Tue, Jul 13, 2021 at 11:36:05AM -0700, John Harrison wrote: > On 6/24/2021 00:04, Matthew Brost wrote: > > Ensure G2H response has space in the buffer before sending H2G CTB as > > the GuC can't handle any backpressure on the G2H interface. > > > > Signed-off-by: John Harrison > >

Re: [PATCH 23/47] drm/i915/guc: Update GuC debugfs to support new GuC

2021-07-14 Thread Matthew Brost
On Tue, Jul 13, 2021 at 10:51:35AM +0200, Michal Wajdeczko wrote: > > > On 24.06.2021 09:04, Matthew Brost wrote: > > Update GuC debugfs to support the new GuC structures. > > > > Signed-off-by: John Harrison > > Signed-off-by: Matthew Brost > > --- > >

Re: [RFC PATCH 12/17] dt-bindings: display: bridge: samsung,mipi-dsim: Add i.MX8MM support

2021-07-14 Thread Rob Herring
On Sun, Jul 04, 2021 at 02:32:25PM +0530, Jagan Teki wrote: > Samsung MIPI DSIM bridge can also be found in i.MX8MM SoC. > > Add dt-bingings for it. > > Cc: Rob Herring > Signed-off-by: Jagan Teki > --- > .../display/bridge/samsung,mipi-dsim.yaml | 84 ++- > 1 file

[PATCH 2/2 v4] drm/panel: ws2401: Add driver for WideChips WS2401

2021-07-14 Thread Linus Walleij
This adds a driver for panels based on the WideChips WS2401 display controller. This display controller is used in the Samsung LMS380KF01 display found in the Samsung GT-I8160 (Codina) mobile phone and possibly others. As is common with Samsung displays manufacturer commands are necessary to

[PATCH 1/2 v4] drm/panel: Add DT bindings for Samsung LMS380KF01

2021-07-14 Thread Linus Walleij
This adds device tree bindings for the Samsung Mobile Displays LMS380KF01 RGB DPI display panel. Cc: devicet...@vger.kernel.org Cc: phone-de...@vger.kernel.org Cc: Noralf Trønnes Reviewed-by: Sam Ravnborg Reviewed-by: Douglas Anderson Reviewed-by: Rob Herring Signed-off-by: Linus Walleij ---

Re: [Freedreno] [PATCH] drm/msm/dp: Initialize dp->aux->drm_dev before registration

2021-07-14 Thread abhinavk
On 2021-07-14 08:28, Sean Paul wrote: From: Sean Paul Avoids the following WARN: [3.009556] [ cut here ] [3.014306] WARNING: CPU: 7 PID: 109 at drivers/gpu/drm/drm_dp_helper.c:1796 drm_dp_aux_register+0xa4/0xac [3.024209] Modules linked in: [3.027351]

Re: [PATCH v4 02/18] drm/sched: Barriers are needed for entity->last_scheduled

2021-07-14 Thread Andrey Grodzovsky
On 2021-07-13 12:45 p.m., Daniel Vetter wrote: On Tue, Jul 13, 2021 at 6:11 PM Andrey Grodzovsky wrote: On 2021-07-13 5:10 a.m., Daniel Vetter wrote: On Tue, Jul 13, 2021 at 9:25 AM Christian König wrote: Am 13.07.21 um 08:50 schrieb Daniel Vetter: On Tue, Jul 13, 2021 at 8:35 AM

[pull] amdgpu, amdkfd drm-fixes-5.14

2021-07-14 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.14. The big change here is unifying the SMU13 code. This was new code added in 5.14 to support Yellow Carp, but we've since cleaned it up and removed a lot of duplication, so better to merge it now to facilitate any bug fixes in the future that need to go back to

[tegra-drm:drm/tegra/for-next 9/14] drivers/gpu/drm/tegra/uapi.c:278:5: warning: no previous prototype for 'tegra_drm_ioctl_gem_create'

2021-07-14 Thread kernel test robot
tree: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next head: b19502d1a683c11f6f2c92ad63c61288b0fbe1a1 commit: cdf631031f3e574b76afed51bda0ccc9d71d4a4e [9/14] drm/tegra: Implement new UAPI config: arm-defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0

Re: [PATCH] drm/msm/dp: Remove unused variable

2021-07-14 Thread Stephen Boyd
Quoting Souptick Joarder (2021-07-08 19:48:34) > Kernel test roobot throws below warning -> > > drivers/gpu/drm/msm/dp/dp_display.c:1017:21: > warning: variable 'drm' set but not used [-Wunused-but-set-variable] > > Removed unused variable drm. > > Reported-by: kernel test robot > Signed-off-by:

Re: [PATCH 2/2] drm/i915/gem: Migrate to system at dma-buf attach time (v5)

2021-07-14 Thread Jason Ekstrand
On Tue, Jul 13, 2021 at 10:23 AM Daniel Vetter wrote: > > On Tue, Jul 13, 2021 at 04:06:13PM +0100, Matthew Auld wrote: > > On Tue, 13 Jul 2021 at 15:44, Daniel Vetter wrote: > > > > > > On Mon, Jul 12, 2021 at 06:12:34PM -0500, Jason Ekstrand wrote: > > > > From: Thomas Hellström > > > > > > >

Re: [PATCH 2/2] drm/panel: Add Innolux EJ030NA 3.0" 320x480 panel

2021-07-14 Thread Paul Cercueil
Hi Sam, Le sam., juil. 10 2021 at 08:18:44 +0200, Sam Ravnborg a écrit : Hi Paul, Christophe, On Fri, Jun 25, 2021 at 01:10:45PM +0100, Paul Cercueil wrote: From: Christophe Branchereau Add support for the Innolux/Chimei EJ030NA 3.0" 320x480 TFT panel. This panel can be found in the

[PATCH] drm/i915: Check object_can_migrate from object_migrate

2021-07-14 Thread Jason Ekstrand
We don't roll them together entirely because there are still a couple cases where we want a separate can_migrate check. For instance, the display code checks that you can migrate a buffer to LMEM before it accepts it in fb_create. The dma-buf import code also uses it to do an early check and

Re: [PATCH 1/2] dt-bindings: display/panel: Add Innolux EJ030NA

2021-07-14 Thread Paul Cercueil
Hi Rob, Le mer., juil. 14 2021 at 14:30:13 -0600, Rob Herring a écrit : On Sat, Jul 10, 2021 at 11:21:56AM +0100, Paul Cercueil wrote: [...] > > I am not sure; the doc states that this (additionalProperties: > > false) "can't > > be used in case where another schema is referenced",

Help needed for EVoC/GSoC/Outreachy

2021-07-14 Thread Lyude Paul
Hi! As some of you might already be aware, after helping out X.org project the previous years with regards to student outreach, Trevor decided to retire from this position in hopes that someone else will be able to step up and take on these responsibilities. As such, we're trying to find people

Re: [PATCH 1/2] dt-bindings: display/panel: Add Innolux EJ030NA

2021-07-14 Thread Rob Herring
On Fri, 25 Jun 2021 13:10:44 +0100, Paul Cercueil wrote: > Add binding for the Innolux EJ030NA panel, which is a 320x480 3.0" 4:3 > 24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit > interface. > > Signed-off-by: Paul Cercueil > --- > .../display/panel/innolux,ej030na.yaml

Re: [PATCH 1/2] dt-bindings: display/panel: Add Innolux EJ030NA

2021-07-14 Thread Rob Herring
On Sat, Jul 10, 2021 at 11:21:56AM +0100, Paul Cercueil wrote: > > [...] > > > > I am not sure; the doc states that this (additionalProperties: > > > false) "can't > > > be used in case where another schema is referenced", which is the > > > case here, > > > as we include "panel-common.yaml".

[tegra-drm:drm/tegra/for-next 1/14] drivers/gpu/host1x/fence.c:168:5: warning: no previous prototype for 'host1x_fence_create_fd'

2021-07-14 Thread kernel test robot
tree: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next head: b19502d1a683c11f6f2c92ad63c61288b0fbe1a1 commit: ad0529424defbbe0b6a154cc100e82c1a9f91400 [1/14] gpu: host1x: Add DMA fence implementation config: arm-defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc

[PATCH 5/5] Revert "drm/i915: Skip over MI_NOOP when parsing"

2021-07-14 Thread Jason Ekstrand
This reverts a6c5e2aea704 ("drm/i915: Skip over MI_NOOP when parsing"). It complicates the batch parsing code a bit and increases indentation for no reason other than fast-skipping a command that userspace uses only rarely. Sure, there may be IGT tests that fill batches with NOOPs but that's not

[PATCH 3/5] drm/i915: Remove allow_alloc from i915_gem_object_get_sg*

2021-07-14 Thread Jason Ekstrand
This reverts the rest of 0edbb9ba1bfe ("drm/i915: Move cmd parser pinning to execbuffer"). Now that the only user of i915_gem_object_get_sg without allow_alloc has been removed, we can drop the parameter. This portion of the revert was broken into its own patch to aid review. Signed-off-by:

[PATCH 4/5] drm/i915: Drop error handling from dma_fence_work

2021-07-14 Thread Jason Ekstrand
Asynchronous command parsing was the only thing which ever returned a non-zero error. With that gone, we can drop the error handling from dma_fence_work. Signed-off-by: Jason Ekstrand Reviewed-by: Jon Bloomfield Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_clflush.c | 4 +---

[PATCH 2/5] Revert "drm/i915: Propagate errors on awaiting already signaled fences"

2021-07-14 Thread Jason Ekstrand
This reverts commit 9e31c1fe45d555a948ff66f1f0e3fe1f83ca63f7. Ever since that commit, we've been having issues where a hang in one client can propagate to another. In particular, a hang in an app can propagate to the X server which causes the whole desktop to lock up. Error propagation along

[PATCH 1/5] drm/i915: Revert "drm/i915/gem: Asynchronous cmdparser"

2021-07-14 Thread Jason Ekstrand
This reverts 686c7c35abc2 ("drm/i915/gem: Asynchronous cmdparser"). The justification for this commit in the git history was a vague comment about getting it out from under the struct_mutex. While this may improve perf for some workloads on Gen7 platforms where we rely on the command parser for

[PATCH 0/5] drm/i915: Get rid of fence error propagation (v4)

2021-07-14 Thread Jason Ekstrand
Fence error propagation is sketchy at best. Instead of explicitly handling fences which might have errors set in the code which is aware of errors, we just kick them down the line and hope that userspace knows what to do when a wait eventually fails. This is sketchy at best because most

Re: [PATCH] drm/panel-simple: Power the panel when probing DP AUX backlight

2021-07-14 Thread Lyude Paul
Reviewed-by: Lyude Paul On Wed, 2021-07-14 at 09:33 -0700, Douglas Anderson wrote: > When I tried booting up a device that needed the DP AUX backlight, I > found an error in the logs: >   panel-simple-dp-aux: probe of aux-ti_sn65dsi86.aux.0 failed with error - > 110 > > The aux transfers were

Re: [PATCH] drm/dp: For drm_panel_dp_aux_backlight(), init backlight as disabled

2021-07-14 Thread Lyude Paul
Reviewed-by: Lyude Paul On Wed, 2021-07-14 at 10:17 -0700, Douglas Anderson wrote: > Even after the DP AUX backlight on my board worked OK after applying > the patch ("drm/panel-simple: Power the panel when probing DP AUX > backlight") [1], I still noticed some strange timeouts being reported >

Re: [PATCH] drm/dp: For drm_panel_dp_aux_backlight(), init backlight as disabled

2021-07-14 Thread Lyude Paul
Reviewed-by: Lyude Paul On Wed, 2021-07-14 at 10:17 -0700, Douglas Anderson wrote: > Even after the DP AUX backlight on my board worked OK after applying > the patch ("drm/panel-simple: Power the panel when probing DP AUX > backlight") [1], I still noticed some strange timeouts being reported >

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2021-07-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 --- Comment #38 from Alex Deucher (alexdeuc...@gmail.com) --- (In reply to Leandro Jacques from comment #37) > (In reply to Alex Deucher from comment #32) > As you asked about the firmware version details, I upgraded my > linux-firmware package

Re: [PATCH v5 17/17] drm/amd/display: Add handling for new "Broadcast RGB" property

2021-07-14 Thread Werner Sembach
Am 30.06.21 um 17:10 schrieb Werner Sembach: This commit implements the "Broadcast RGB" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +++--- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 4

Re: [PATCH v4 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-07-14 Thread Werner Sembach
Am 01.07.21 um 13:30 schrieb Werner Sembach: Am 01.07.21 um 09:42 schrieb Pekka Paalanen: On Wed, 30 Jun 2021 11:42:10 +0200 Werner Sembach wrote: Am 30.06.21 um 10:21 schrieb Pekka Paalanen: On Tue, 29 Jun 2021 13:02:05 +0200 Werner Sembach wrote: Am 28.06.21 um 19:03 schrieb Werner

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-07-14 Thread Werner Sembach
Am 06.07.21 um 09:09 schrieb Pekka Paalanen: On Mon, 5 Jul 2021 17:49:42 +0200 Werner Sembach wrote: Am 01.07.21 um 15:24 schrieb Pekka Paalanen: On Thu, 1 Jul 2021 14:50:13 +0200 Werner Sembach wrote: Am 01.07.21 um 10:07 schrieb Pekka Paalanen: On Wed, 30 Jun 2021 11:20:18 +0200

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2021-07-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 --- Comment #37 from Leandro Jacques (ls...@yahoo.com) --- (In reply to Alex Deucher from comment #32) As you asked about the firmware version details, I upgraded my linux-firmware package to see if the problem would come back and it came back.

[PATCH v3 5/5] i915: map gvt pr_debug categories to bits in parameters/debug_gvt

2021-07-14 Thread Jim Cromie
The gvt component of this driver has ~120 pr_debugs, in 9 "classes". Following the interface model of drm.debug, add a parameter to map bits to these classes. If CONFIG_DRM_USE_DYNAMIC_DEBUG=y (and CONFIG_DYNAMIC_DEBUG_CORE), add -DDYNAMIC_DEBUG_MODULE into Makefile. TBD: maybe add a separate

[PATCH v3 4/5] drm/print: move conditional deref into macro defn

2021-07-14 Thread Jim Cromie
commit 7911902129a8 ("drm/print: Handle potentially NULL drm_devices in drm_dbg_*") added a maybe(deref) to 6 macro invocations of drm_dev_dbg(). Commit 01ff672190bd("drm: RFC add choice to use dynamic debug in drm-debug") then renamed that fn to _drm_dev_dbg(), and redefined drm_dev_dbg() as a

[PATCH v3 3/5] drm/print: RFC add choice to use dynamic debug in drm-debug

2021-07-14 Thread Jim Cromie
drm's debug system uses distinct categories of debug messages, encoded in an enum (DRM_UT_), which are mapped to bits in drm.debug. drm_debug_enabled() does a lot of unlikely bit-mask checks on drm.debug; we can use dynamic debug instead, and get all that static_key/jump_label goodness. Dynamic

[PATCH v3 2/5] drm_print.h: rewrap __DRM_DEFINE_DBG_RATELIMITED macro

2021-07-14 Thread Jim Cromie
whitespace only, to minimize the diff of a later commit. no functional changes Signed-off-by: Jim Cromie --- include/drm/drm_print.h | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index

[PATCH v3 1/5] drm/print: fixup spelling in a comment

2021-07-14 Thread Jim Cromie
s/prink/printk/ - no functional changes Signed-off-by: Jim Cromie --- include/drm/drm_print.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index 9b66be54dd16..15a089a87c22 100644 --- a/include/drm/drm_print.h +++

[PATCH v3 0/5] drm: use dyndbg in drm_print

2021-07-14 Thread Jim Cromie
hi dri-devel, Im pretty new in this particular playground. Im using this to send, is it too spammy ? too --to ? git send-email --dry-run \ --to-cmd='scripts/get_maintainer.pl --no-rolestats v3-000*.patch' \ --to=jba...@akamai.com v3-000*.patch drm_debug_enabled() is called a lot (by

Re: [v2 1/3] dt-bindings: msm/dsi: Add sc7280 7nm dsi phy

2021-07-14 Thread Rob Herring
On Tue, 22 Jun 2021 18:12:26 +0530, Rajeev Nandan wrote: > The SC7280 SoC uses the 7nm (V4.1) DSI PHY driver. > > Signed-off-by: Rajeev Nandan > --- > > Changes in v2: > - New > This patch depends on [1] (dt-bindings: msm: dsi: add missing 7nm bindings) > > [1] >

[PATCH] drm/dp: For drm_panel_dp_aux_backlight(), init backlight as disabled

2021-07-14 Thread Douglas Anderson
Even after the DP AUX backlight on my board worked OK after applying the patch ("drm/panel-simple: Power the panel when probing DP AUX backlight") [1], I still noticed some strange timeouts being reported by ti_sn_aux_transfer(). Digging, I realized the problem was this: * Even though `enabled` in

[PATCH -next] drm: nouveau: fix disp.c build when NOUVEAU_BACKLIGHT is not enabled

2021-07-14 Thread Randy Dunlap
: Ben Skeggs Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Cc: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- linux-next-20210714.orig/drivers/gpu/drm/nouveau/dispnv50/disp.c +++ linux-next-20210

[PATCH] drm/amd/powerplay: remove redundant assignment to usTMax

2021-07-14 Thread Colin King
From: Colin Ian King Struct element usTMax is being assigned a hard coded value that is never read and it is being re-assigned a new value immediately afterwards. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH AUTOSEL 4.4 08/31] drm/virtio: Fixes a potential NULL pointer dereference on probe failure

2021-07-14 Thread Sasha Levin
On Mon, Jul 12, 2021 at 11:59:37PM +0200, Pavel Machek wrote: Hi! From: Xie Yongji [ Upstream commit 17f46f488a5d82c5568e6e786cd760bba1c2ee09 ] The dev->dev_private might not be allocated if virtio_gpu_pci_quirk() or virtio_gpu_init() failed. In this case, we should avoid the cleanup in

Re: [PATCH AUTOSEL 5.13 001/189] drm/etnaviv: fix NULL check before some freeing functions is not needed

2021-07-14 Thread Sasha Levin
On Wed, Jul 07, 2021 at 01:50:21PM +0200, Christian König wrote: Am 07.07.21 um 12:52 schrieb Lucas Stach: Am Dienstag, dem 06.07.2021 um 07:11 -0400 schrieb Sasha Levin: From: Tian Tao [ Upstream commit 7d614ab2f20503ed8766363d41f8607337571adf ] fixed the below warning:

Re: [PATCH v2 3/4] dt-bindings: arm: fsl: add SKOV imx6q and imx6dl based boards

2021-07-14 Thread Rob Herring
On Wed, 14 Jul 2021 06:53:48 +0200, Oleksij Rempel wrote: > Add SKOV imx6q/dl LT2, LT6 and mi1010ait-1cp1 boards. > > Signed-off-by: Oleksij Rempel > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 5 + > 1 file changed, 5 insertions(+) > Please add Acked-by/Reviewed-by tags when

Re: [PATCH v2 2/4] dt-bindings: vendor-prefixes: Add an entry for SKOV A/S

2021-07-14 Thread Rob Herring
On Wed, 14 Jul 2021 06:53:47 +0200, Oleksij Rempel wrote: > Add "skov" entry for the SKOV A/S: https://www.skov.com/en/ > > Signed-off-by: Oleksij Rempel > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Please add Acked-by/Reviewed-by

Re: [PATCH v2 1/4] dt-bindings: display: simple: add some Logic Technologies and Multi-Inno panels

2021-07-14 Thread Rob Herring
On Wed, 14 Jul 2021 06:53:46 +0200, Oleksij Rempel wrote: > Add Logictechno and Multi-Inno panels: > - Logic Technologies LTTD800x480 L2RT 7" 800x480 TFT Resistive Touch Module > - Logic Technologies LTTD800480070-L6WH-RT 7” 800x480 TFT Resistive Touch > Module > - Multi-Inno Technology Co.,Ltd

[PATCH] drm/panel-simple: Power the panel when probing DP AUX backlight

2021-07-14 Thread Douglas Anderson
When I tried booting up a device that needed the DP AUX backlight, I found an error in the logs: panel-simple-dp-aux: probe of aux-ti_sn65dsi86.aux.0 failed with error -110 The aux transfers were failing because the panel wasn't powered. Just like when reading the EDID we need to power the

Re: [PATCH v4 3/4] drm/shmem-helpers: Allocate wc pages on x86

2021-07-14 Thread Daniel Vetter
On Wed, Jul 14, 2021 at 02:58:26PM +0200, Christian König wrote: > Am 14.07.21 um 14:48 schrieb Daniel Vetter: > > On Wed, Jul 14, 2021 at 01:54:50PM +0200, Christian König wrote: > > > Am 13.07.21 um 22:51 schrieb Daniel Vetter: > > > > intel-gfx-ci realized that something is not quite coherent

Re: [PATCH 1/2] drm: add crtc background color property

2021-07-14 Thread Harry Wentland
On 2021-07-14 3:35 a.m., Pekka Paalanen wrote: > On Tue, 13 Jul 2021 09:54:35 -0400 > Harry Wentland wrote: > >> On 2021-07-13 3:52 a.m., Pekka Paalanen wrote: >>> On Mon, 12 Jul 2021 12:15:59 -0400 >>> Harry Wentland wrote: >>> On 2021-07-12 4:03 a.m., Pekka Paalanen wrote: >

Re: [PATCH v3 1/1] drm/ttm: Fix COW check

2021-07-14 Thread Felix Kuehling
Am 2021-07-14 um 6:51 a.m. schrieb Christian König: > Am 14.07.21 um 12:44 schrieb Daniel Vetter: >> On Mon, Jul 12, 2021 at 06:06:36PM -0400, Felix Kuehling wrote: >>> KFD Thunk maps invisible VRAM BOs with PROT_NONE, MAP_PRIVATE. >>> is_cow_mapping returns true for these mappings. Add a check

[PATCH] drm/msm/dp: Initialize dp->aux->drm_dev before registration

2021-07-14 Thread Sean Paul
From: Sean Paul Avoids the following WARN: [3.009556] [ cut here ] [3.014306] WARNING: CPU: 7 PID: 109 at drivers/gpu/drm/drm_dp_helper.c:1796 drm_dp_aux_register+0xa4/0xac [3.024209] Modules linked in: [3.027351] CPU: 7 PID: 109 Comm: kworker/7:8 Not

Re: [PATCH resend 0/5] video: fbdev: ssd1307fb: Optimizations and improvements

2021-07-14 Thread Sam Ravnborg
Hi Geert, On Wed, Jul 14, 2021 at 04:57:59PM +0200, Geert Uytterhoeven wrote: > Hi all, > > This patch series optimizes console operations on ssd1307fb, after the > customary fixes and cleanups. What is required to to have a drm driver that could do the same? Note: I will take a look at

Re: [PATCH v2] drm/of: free the iterator object on failure

2021-07-14 Thread Laurent Pinchart
Hi Steven, Thank you for the patch. On Wed, Jul 14, 2021 at 03:33:00PM +0100, Steven Price wrote: > When bailing out due to the sanity check the iterator value needs to be > freed because the early return prevents for_each_child_of_node() from > doing the dereference itself. > > Fixes:

Re: [PATCH v8 00/14] drm/tegra: Introduce a modern UABI

2021-07-14 Thread Mikko Perttunen
On 7/14/21 5:50 PM, Dmitry Osipenko wrote: 14.07.2021 11:30, Thierry Reding пишет: On Sat, Jul 10, 2021 at 12:16:28AM +0300, Dmitry Osipenko wrote: Hello Thierry, 09.07.2021 22:31, Thierry Reding пишет: From: Thierry Reding Hi all, Mikko has been away for a few weeks, so I've been testing

Re: [PATCH] drm/ttm: add a check against null pointer dereference

2021-07-14 Thread Christian König
Am 14.07.21 um 16:54 schrieb Zheyu Ma: When calling ttm_range_man_fini(), 'man' may be uninitialized, which may cause a null pointer dereference bug. Fix this by checking if it is a null pointer. It would be better if the driver doesn't try to fini a manager which was never initialized, but

Re: nouveau: failed to initialise sync

2021-07-14 Thread Daniel Vetter
On Wed, Jul 14, 2021 at 03:02:21PM +0200, Christian König wrote: > Am 14.07.21 um 14:56 schrieb Kirill A. Shutemov: > > On Tue, Jul 06, 2021 at 08:58:37AM +0200, Christian König wrote: > > > Hi guys, > > > > > > yes nouveau was using the same functionality for internal BOs without > > > noticing

[PATCH resend 2/5] video: fbdev: ssd1307fb: Simplify ssd1307fb_update_display()

2021-07-14 Thread Geert Uytterhoeven
Simplify the nested loops to handle conversion from linear frame buffer to ssd1307 page layout: 1. Move last page handling one level up, as the value of "m" is the same inside a page, 2. array->data[] is filled linearly, so there is no need to recalculate array_idx over and over

[PATCH resend 5/5] video: fbdev: ssd1307fb: Cache address ranges

2021-07-14 Thread Geert Uytterhoeven
Cache the column and page ranges, to avoid doing unneeded I2C transfers when the values haven't changed. Signed-off-by: Geert Uytterhoeven --- drivers/video/fbdev/ssd1307fb.c | 52 +++-- 1 file changed, 36 insertions(+), 16 deletions(-) diff --git

[PATCH resend 0/5] video: fbdev: ssd1307fb: Optimizations and improvements

2021-07-14 Thread Geert Uytterhoeven
Hi all, This patch series optimizes console operations on ssd1307fb, after the customary fixes and cleanups. Currently, each screen update triggers an I2C transfer of all screen data, up to 1 KiB of data for a 128x64 display, which takes at least 20 ms in Fast mode. While many displays

[PATCH resend 4/5] video: fbdev: ssd1307fb: Optimize screen updates

2021-07-14 Thread Geert Uytterhoeven
Currently, each screen update triggers an I2C transfer of all screen data, up to 1 KiB of data for a 128x64 display, which takes at least 20 ms in Fast mode. Reduce the amount of transferred data by only updating the rectangle that changed. Remove the call to ssd1307fb_set_address_range() during

[PATCH resend 3/5] video: fbdev: ssd1307fb: Extract ssd1307fb_set_address_range()

2021-07-14 Thread Geert Uytterhoeven
Extract the code to set the column and page ranges into a helper function. Signed-off-by: Geert Uytterhoeven --- drivers/video/fbdev/ssd1307fb.c | 61 +++-- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/drivers/video/fbdev/ssd1307fb.c

[PATCH resend 1/5] video: fbdev: ssd1307fb: Propagate errors via ssd1307fb_update_display()

2021-07-14 Thread Geert Uytterhoeven
Make ssd1307fb_update_display() return an error code, so callers that can handle failures can propagate it. Signed-off-by: Geert Uytterhoeven --- drivers/video/fbdev/ssd1307fb.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[PATCH resend v2] dt-bindings: display: ssd1307fb: Convert to json-schema

2021-07-14 Thread Geert Uytterhoeven
Convert the Solomon SSD1307 Framebuffer Device Tree binding documentation to json-schema. Fix the spelling of the "pwms" property. Document default values. Make properties with default values not required. Signed-off-by: Geert Uytterhoeven Reviewed-by: Rob Herring --- v2: - Add Reviewed-by,

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2021-07-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 --- Comment #36 from Leandro Jacques (ls...@yahoo.com) --- Created attachment 297855 --> https://bugzilla.kernel.org/attachment.cgi?id=297855=edit Kernel crash log for linux firmware version 20210511.7685cf4 Kernel log when crashed. -- You

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2021-07-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 Leandro Jacques (ls...@yahoo.com) changed: What|Removed |Added Attachment #297851|0 |1 is

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2021-07-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 --- Comment #34 from Leandro Jacques (ls...@yahoo.com) --- Created attachment 297851 --> https://bugzilla.kernel.org/attachment.cgi?id=297851=edit Linux Firmware version info 20210511.7685cf4 -- You may reply to this email to add a comment.

Re: [PATCH v8 00/14] drm/tegra: Introduce a modern UABI

2021-07-14 Thread Dmitry Osipenko
14.07.2021 11:30, Thierry Reding пишет: > On Sat, Jul 10, 2021 at 12:16:28AM +0300, Dmitry Osipenko wrote: >> Hello Thierry, >> >> 09.07.2021 22:31, Thierry Reding пишет: >>> From: Thierry Reding >>> >>> Hi all, >>> >>> Mikko has been away for a few weeks, so I've been testing and revising >>>

[PATCH v2] drm/of: free the iterator object on failure

2021-07-14 Thread Steven Price
When bailing out due to the sanity check the iterator value needs to be freed because the early return prevents for_each_child_of_node() from doing the dereference itself. Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order") Signed-off-by: Steven Price ---

Re: [PATCH] drm: mxsfb: Clear FIFO_CLEAR bit

2021-07-14 Thread Lucas Stach
Am Donnerstag, dem 01.07.2021 um 00:50 +0200 schrieb Marek Vasut: > On 6/29/21 10:02 AM, Lucas Stach wrote: > > Am Dienstag, dem 29.06.2021 um 05:04 +0200 schrieb Marek Vasut: > > > On 6/28/21 10:09 AM, Lucas Stach wrote: > > > > Am Samstag, dem 26.06.2021 um 20:15 +0200 schrieb Marek Vasut: > > >

  1   2   >