Re: [PATCH v2] drm/i915: Flush buffer pools on driver remove

2021-09-24 Thread Matt Roper
On Fri, Sep 24, 2021 at 06:38:25PM +0200, Janusz Krzysztofik wrote: > We currently do an explicit flush of the buffer pools within the call path > of drm_driver.release(); this removes all buffers, regardless of their age, > freeing the buffers' associated resources (objects, adress space areas).

Re: [PATCH v11 07/16] dt-bindings: arm: mediatek: move common module from display folder

2021-09-24 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年9月21日 週二 下午11:52寫道: > > AAL, COLOR, CCORR, MUTEX, WDMA could be used by other modules, > such as MDP, so move their binding document into the common folder. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: jason-jh.lin > --- > .../{display =>

Re: [PATCH v11 06/16] dt-bindings: display: mediatek: add mt8195 SoC binding for vdosys0

2021-09-24 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年9月21日 週二 下午11:52寫道: > > Add mt8195 SoC binding to AAL, CCORR, COLOR, DITHER, GAMMA, MERGE, > MUTEX, OVL and RDMA yaml schema for vdosys0. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: jason-jh.lin > --- >

Re: [PATCH v11 05/16] dt-bindings: display: mediatek: merge: add additional prop for mt8195

2021-09-24 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年9月21日 週二 下午11:52寫道: > > add MERGE additional properties description for mt8195: > 1. async clock > 2. fifo setting enable > 3. reset controller > > Signed-off-by: jason-jh.lin > --- > .../display/mediatek/mediatek,merge.yaml | 31 +++ > 1

Re: [PATCH v11 04/16] dt-bindings: display: mediatek: dsc: add yaml for mt8195 SoC binding

2021-09-24 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年9月21日 週二 下午11:52寫道: > > 1. Add mediatek,dsc.yaml to describe DSC module in details. > 2. Add mt8195 SoC binding to mediatek,dsc.yaml. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: jason-jh.lin > --- > .../display/mediatek/mediatek,dsc.yaml| 71

Re: [PATCH net-next 3/5] net: bcmasp: Add support for ASP2.0 Ethernet controller

2021-09-24 Thread Jakub Kicinski
On Fri, 24 Sep 2021 14:44:49 -0700 Justin Chen wrote: > Add support for the Broadcom ASP 2.0 Ethernet controller which is first > introduced with 72165. This controller features two distinct Ethernet > ports that can be independently operated. > > This patch supports: > > - Wake-on-LAN using

Re: [PATCH v11 03/16] dt-bindings: display: mediatek: disp: split each block to individual yaml

2021-09-24 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年9月21日 週二 下午11:52寫道: > > 1. Remove mediatek,dislpay.txt > 2. Split each display function block to individual yaml file. Acked-by: Chun-Kuang Hu > > Signed-off-by: jason-jh.lin > --- > .../display/mediatek/mediatek,aal.yaml| 79 +++ >

Re: [PATCH 8/8] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2021-09-24 Thread Stephen Boyd
(Sorry for the slow reply) Quoting Hans de Goede (2021-09-16 06:17:56) > Hi, > > On 9/16/21 5:20 AM, Stephen Boyd wrote: > > Quoting Hans de Goede (2021-08-17 14:52:01) > >> diff --git a/drivers/usb/typec/altmodes/displayport.c > >> b/drivers/usb/typec/altmodes/displayport.c > >> index

[PATCH 2/2] drm/rockchip: dsi: Fix unbalanced clock on probe error

2021-09-24 Thread Brian Norris
Our probe() function never enabled this clock, so we shouldn't disable it if we fail to probe the bridge. Noted by inspection. Fixes: 2d4f7bdafd70 ("drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver") Signed-off-by: Brian Norris --- drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c |

[PATCH 1/2] drm/rockchip: dsi: hold pm-runtime across bind/unbind

2021-09-24 Thread Brian Norris
In commit 59eb7193bef2, we moved most HW configuration to bind(), but we didn't move the runtime PM management. Therefore, depending on initial boot state, runtime-PM workqueue delays, and other timing factors, we may disable our power domain in between the hardware configuration (bind()) and when

[PATCH] drm/i915/gvt: Fix spelling mistake "Unsupport" -> "Unsupported"

2021-09-24 Thread Colin King
From: Colin Ian King There is a spelling mistake in a gvt_vgpu_err error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gvt/handlers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/handlers.c

Re: Regression with mainline kernel on rpi4

2021-09-24 Thread Daniel Vetter
On Fri, Sep 24, 2021 at 3:30 PM Maxime Ripard wrote: > > On Wed, Sep 22, 2021 at 01:25:21PM -0700, Linus Torvalds wrote: > > On Wed, Sep 22, 2021 at 1:19 PM Sudip Mukherjee > > wrote: > > > > > > I added some debugs to print the addresses, and I am getting: > > > [ 38.813809] sudip crtc

[PATCH] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

2021-09-24 Thread Umesh Nerlige Ramappa
With GuC handling scheduling, i915 is not aware of the time that a context is scheduled in and out of the engine. Since i915 pmu relies on this info to provide engine busyness to the user, GuC shares this info with i915 for all engines using shared memory. For each engine, this info contains: -

[PATCH] video: fbdev: via: Fix spelling mistake "bellow" -> "below"

2021-09-24 Thread Colin King
From: Colin Ian King There is a spelling mistake in a debug message. Fix it. Signed-off-by: Colin Ian King --- drivers/video/fbdev/via/lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/via/lcd.c b/drivers/video/fbdev/via/lcd.c index

Re: [PATCH v5 2/2] drm/bridge: ti-sn65dsi86: Implement the pwm_chip

2021-09-24 Thread Bjorn Andersson
On Fri 24 Sep 02:54 CDT 2021, Uwe Kleine-K?nig wrote: > Hello, > > On Thu, Sep 23, 2021 at 09:12:25PM -0500, Bjorn Andersson wrote: > > The SN65DSI86 provides the ability to supply a PWM signal on GPIO 4, > > with the primary purpose of controlling the backlight of the attached > > panel. Add an

Re: [RFC PATCH] drm/print: Add deprecation notes to DRM_...() functions

2021-09-24 Thread Doug Anderson
Hi, On Tue, Sep 21, 2021 at 8:28 AM Douglas Anderson wrote: > > It's hard for someone (like me) who's not following closely to know > what the suggested best practices are for error printing in DRM > drivers. Add some hints to the header file. > > In general, my understanding is that: > * When

Re: [PATCH] drm/edid: Fix EDID quirk compile error on older compilers

2021-09-24 Thread Doug Anderson
Hi, On Fri, Sep 24, 2021 at 7:53 AM Douglas Anderson wrote: > > Apparently some compilers [1] cannot handle doing math on dereferenced > string constants at compile time. This has led to reports [2] of > compile errors like: > > In file included from drivers/gpu/drm/drm_edid.c:42:0: >

Re: [PATCH 1/4] dma-buf: add dma_fence_describe and dma_resv_describe

2021-09-24 Thread Rob Clark
On Fri, Sep 24, 2021 at 12:18 AM Christian König wrote: > > Add functions to dump dma_fence and dma_resv objects into a seq_file and > use them for printing the debugfs informations. > > Signed-off-by: Christian König for the series, Reviewed-by: Rob Clark > --- > drivers/dma-buf/dma-buf.c

Re: [PATCH v2 7/9] vfio/ccw: Remove private->mdev

2021-09-24 Thread Eric Farman
On Thu, 2021-09-09 at 16:38 -0300, Jason Gunthorpe wrote: > Having a mdev pointer floating about in addition to a struct > vfio_device > is confusing. It is only used for three things: > > - Getting the mdev 'struct device *' - this is the same as > private->vdev.dev > > - Printing the uuid

Re: [PATCH v2 3/9] vfio/ccw: Convert to use vfio_register_group_dev()

2021-09-24 Thread Eric Farman
On Thu, 2021-09-09 at 16:38 -0300, Jason Gunthorpe wrote: > This is a more complicated conversion because vfio_ccw is sharing the > vfio_device between both the mdev_device, its vfio_device and the > css_driver. > > The mdev is a singleton, and the reason for this sharing is so the > extra >

[PATCH v13 00/17] drm/i915: Introduce Intel PXP

2021-09-24 Thread Alan Previn
PXP (Protected Xe Path) is an i915 component, available on GEN12 and newer platforms, that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. changes from v12: - Patch #4: Fixed for loop pointer dereference (Vinay). -

[Bug 85421] radeon stalled, GPU lockup, reset and failed on resume; crashed by firefox.

2021-09-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=85421 Paul Dufresne (dufres...@zoho.com) changed: What|Removed |Added CC||dufres...@zoho.com

Re: drm: simpledrm: fbdev emulation error with CONFIG_DRM_SIMPLEDRM enabled

2021-09-24 Thread Thomas Zimmermann
Hi, thanks for the feedback. Am 24.09.21 um 20:03 schrieb Zoltán Kővágó: Hi, Did anything happen with this issue? I've updated linux kernel to 5.14.7 from 5.13 today, and I've been hit with a very similar problem (even inside qemu), except in my case the height reported in "bad framebuffer

Re: [RFC PATCH] drm/print: Add deprecation notes to DRM_...() functions

2021-09-24 Thread Lyude Paul
Acked-by: Lyude Paul On Wed, 2021-09-22 at 09:12 +0200, Thomas Zimmermann wrote: > Hi > > Am 21.09.21 um 17:28 schrieb Douglas Anderson: > > It's hard for someone (like me) who's not following closely to know > > what the suggested best practices are for error printing in DRM > > drivers. Add

Re: (subset) [PATCH v4 03/24] drm/mipi-dsi: Create devm device registration

2021-09-24 Thread Maxime Ripard
On Fri, 10 Sep 2021 12:11:57 +0200, Maxime Ripard wrote: > Devices that take their data through the MIPI-DSI bus but are controlled > through a secondary bus like I2C have to register a secondary device on > the MIPI-DSI bus through the mipi_dsi_device_register_full() function. > > At removal or

Re: (subset) [PATCH v4 04/24] drm/mipi-dsi: Create devm device attachment

2021-09-24 Thread Maxime Ripard
On Fri, 10 Sep 2021 12:11:58 +0200, Maxime Ripard wrote: > MIPI-DSI devices need to call mipi_dsi_attach() when their probe is done > to attach against their host. > > However, at removal or when an error occurs, that attachment needs to be > undone through a call to mipi_dsi_detach(). > > Let's

Re: (subset) [PATCH v4 01/24] drm/bridge: Add documentation sections

2021-09-24 Thread Maxime Ripard
On Fri, 10 Sep 2021 12:11:55 +0200, Maxime Ripard wrote: > The bridge documentation overview is quite packed already, and we'll add > some more documentation that isn't part of an overview at all. > > Let's add some sections to the documentation to separate each bits. > > Applied to

Re: (subset) [PATCH v4 02/24] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-09-24 Thread Maxime Ripard
On Fri, 10 Sep 2021 12:11:56 +0200, Maxime Ripard wrote: > Interactions between bridges, panels, MIPI-DSI host and the component > framework are not trivial and can lead to probing issues when > implementing a display driver. Let's document the various cases we need > too consider, and the

Re: [git pull] drm fixes for 5.15-rc3

2021-09-24 Thread pr-tracker-bot
The pull request you sent on Fri, 24 Sep 2021 13:18:05 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2021-09-24 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e61b2ad3e1914b70c657a8fd7524078ae37a7da4 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH] drm/edid: Fix EDID quirk compile error on older compilers

2021-09-24 Thread Sam Ravnborg
On Fri, Sep 24, 2021 at 07:53:21AM -0700, Douglas Anderson wrote: > Apparently some compilers [1] cannot handle doing math on dereferenced > string constants at compile time. This has led to reports [2] of > compile errors like: > > In file included from drivers/gpu/drm/drm_edid.c:42:0: >

[PATCH v2] drm/i915: Flush buffer pools on driver remove

2021-09-24 Thread Janusz Krzysztofik
We currently do an explicit flush of the buffer pools within the call path of drm_driver.release(); this removes all buffers, regardless of their age, freeing the buffers' associated resources (objects, adress space areas). However there is other code that runs within the drm_driver.release() call

Re: [PATCH] drm/bridge: parade-ps8640: check return values in ps8640_aux_transfer()

2021-09-24 Thread Tim Gardner
%d\n", ret); I forgot to mention this patch is for linux-next next-20210924. --- Tim Gardner Canonical, Inc

[Bug 211425] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting

2021-09-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211425 Daniel Roschka (danielroschka+ker...@phoenitydawn.de) changed: What|Removed |Added CC|

Re: [PATCH] drm/i915: remember to call i915_sw_fence_fini

2021-09-24 Thread Matthew Brost
On Fri, Sep 24, 2021 at 03:46:46PM +0100, Matthew Auld wrote: > Seems to fix some object-debug splat which appeared while debugging > something unrelated. > > v2: s/guc_blocked/guc_state.blocked/ > > Signed-off-by: Matthew Auld > Cc: Ville Syrjälä > Cc: Matthew Brost Reviewed-by: Matthew

Re: [PATCH] drm/i915: remember to call i915_sw_fence_fini

2021-09-24 Thread Ville Syrjälä
On Fri, Sep 24, 2021 at 03:46:46PM +0100, Matthew Auld wrote: > Seems to fix some object-debug splat which appeared while debugging > something unrelated. > > v2: s/guc_blocked/guc_state.blocked/ > > Signed-off-by: Matthew Auld > Cc: Ville Syrjälä > Cc: Matthew Brost Seems to help.

[PATCH 09/27] drm/ttm: use the new iterator in ttm_bo_flush_all_fences

2021-09-24 Thread Christian König
This is probably a fix since we didn't even grabed a reference to the fences. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/ttm/ttm_bo.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 25/27] drm/nouveau: use the new interator in nv50_wndw_prepare_fb

2021-09-24 Thread Christian König
Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c

[PATCH 27/27] drm/etnaviv: replace dma_resv_get_excl_unlocked

2021-09-24 Thread Christian König
We certainly hold the reservation lock here, no need for the RCU dance. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c

[PATCH 19/27] drm/i915: use new iterator in i915_gem_object_wait_reservation

2021-09-24 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 51 +--- 1 file changed, 9 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index

[PATCH 14/27] drm/radeon: use new iterator in radeon_sync_resv

2021-09-24 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_sync.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_sync.c b/drivers/gpu/drm/radeon/radeon_sync.c index

[PATCH 20/27] drm/i915: use new iterator in i915_gem_object_wait_priority

2021-09-24 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 31 +--- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index

[PATCH 26/27] drm/etnaviv: use new iterator in etnaviv_gem_describe

2021-09-24 Thread Christian König
Instead of hand rolling the logic. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 31 ++- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c index

[PATCH 15/27] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

2021-09-24 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/scheduler/sched_main.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git

[PATCH 16/27] drm/i915: use the new iterator in i915_gem_busy_ioctl v2

2021-09-24 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 35 ++-- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git

[PATCH 11/27] drm/amdgpu: use new iterator in amdgpu_ttm_bo_eviction_valuable

2021-09-24 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index

[PATCH 10/27] drm/amdgpu: use the new iterator in amdgpu_sync_resv

2021-09-24 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 44 1 file changed, 14 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c index

[PATCH 24/27] drm/nouveau: use the new iterator in nouveau_fence_sync

2021-09-24 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_fence.c | 48 +++-- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index

[PATCH 18/27] drm/i915: use the new iterator in i915_request_await_object v2

2021-09-24 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/rcu_read_unlock() v3: use dma_resv_for_each_fence instead Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_request.c | 34 + 1 file changed, 5 insertions(+), 29

[PATCH 23/27] drm: use new iterator in drm_gem_plane_helper_prepare_fb

2021-09-24 Thread Christian König
Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_atomic_helper.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_atomic_helper.c

[PATCH 22/27] drm: use new iterator in drm_gem_fence_array_add_implicit v3

2021-09-24 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() v3: switch to locked version Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c

[PATCH 17/27] drm/i915: use the new iterator in i915_sw_fence_await_reservation v3

2021-09-24 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence instead, according to Tvrtko the lock is held here anyway. v3: back to using dma_resv_for_each_fence_unlocked. Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_sw_fence.c | 53 ++-- 1 file

[PATCH 21/27] drm/i915: use new cursor in intel_prepare_plane_fb

2021-09-24 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/display/intel_display.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index

[PATCH 13/27] drm/msm: use new iterator in msm_gem_describe

2021-09-24 Thread Christian König
Simplifying the code a bit. Also drop the RCU read side lock since the object is locked anyway. Untested since I can't get the driver to compile on !ARM. Signed-off-by: Christian König --- drivers/gpu/drm/msm/msm_gem.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-)

[PATCH 12/27] drm/amdgpu: use new iterator in amdgpu_vm_prt_fini

2021-09-24 Thread Christian König
No need to actually allocate an array of fences here. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 06/27] dma-buf: use new iterator in dma_resv_wait_timeout

2021-09-24 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 69 +- 1 file changed, 8 insertions(+), 61 deletions(-) diff --git

[PATCH 07/27] dma-buf: use new iterator in dma_resv_test_signaled

2021-09-24 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 57 +- 1 file changed, 7 insertions(+), 50 deletions(-) diff --git

[PATCH 08/27] dma-buf: use the new iterator in dma_buf_debug_show

2021-09-24 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 474de2d988ca..d35c71743ccb 100644 ---

[PATCH 03/27] dma-buf: add dma_resv selftest

2021-09-24 Thread Christian König
Just exercising a very minor subset of the functionality, but already proven useful. Signed-off-by: Christian König --- drivers/dma-buf/Makefile | 3 +- drivers/dma-buf/selftests.h | 1 + drivers/dma-buf/st-dma-resv.c | 164 ++ 3 files changed, 167

[PATCH 05/27] dma-buf: use new iterator in dma_resv_get_fences v3

2021-09-24 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. v2: use sizeof(void*) instead v3: fix rebase bug Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 108 - 1 file changed,

[PATCH 04/27] dma-buf: use new iterator in dma_resv_copy_fences

2021-09-24 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 84 +++--- 1 file changed, 32 insertions(+), 52 deletions(-) diff --git

[PATCH 02/27] dma-buf: add dma_resv_for_each_fence

2021-09-24 Thread Christian König
A simpler version of the iterator to be used when the dma_resv object is locked. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 46 ++ include/linux/dma-resv.h | 19 2 files changed, 65 insertions(+) diff --git

[PATCH 01/27] dma-buf: add dma_resv_for_each_fence_unlocked v6

2021-09-24 Thread Christian König
Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. v2: fix accessing the shared fences while they might be freed, improve kerneldoc, rename

[PATCH] drm/bridge: parade-ps8640: check return values in ps8640_aux_transfer()

2021-09-24 Thread Tim Gardner
Coverity complains of an unused return code: CID 120459 (#1 of 1): Unchecked return value (CHECKED_RETURN) 7. check_return: Calling regmap_bulk_write without checking return value (as is done elsewhere 199 out of 291 times). 204regmap_bulk_write(map, PAGE0_SWAUX_ADDR_7_0, addr_len, 205

Re: [PATCH] drm/edid: Fix EDID quirk compile error on older compilers

2021-09-24 Thread Randy Dunlap
On 9/24/21 7:53 AM, Douglas Anderson wrote: Apparently some compilers [1] cannot handle doing math on dereferenced string constants at compile time. This has led to reports [2] of compile errors like: In file included from drivers/gpu/drm/drm_edid.c:42:0: ./include/drm/drm_edid.h:525:2:

Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding

2021-09-24 Thread Doug Anderson
Hi, On Fri, Sep 24, 2021 at 6:59 AM Doug Anderson wrote: > > Hi, > > On Fri, Sep 24, 2021 at 2:10 AM Andrzej Hajda wrote: > > > > Hi > > > > removed most cc, due to server limitation > > > > > > W dniu 24.09.2021 o 10:03, Jani Nikula pisze: > > > On Mon, 20 Sep 2021, Doug Anderson wrote: > >

[PATCH] drm/edid: Fix EDID quirk compile error on older compilers

2021-09-24 Thread Douglas Anderson
Apparently some compilers [1] cannot handle doing math on dereferenced string constants at compile time. This has led to reports [2] of compile errors like: In file included from drivers/gpu/drm/drm_edid.c:42:0: ./include/drm/drm_edid.h:525:2: error: initializer element is not constant

[PATCH] drm/i915: remember to call i915_sw_fence_fini

2021-09-24 Thread Matthew Auld
Seems to fix some object-debug splat which appeared while debugging something unrelated. v2: s/guc_blocked/guc_state.blocked/ Signed-off-by: Matthew Auld Cc: Ville Syrjälä Cc: Matthew Brost --- drivers/gpu/drm/i915/gt/intel_context.c | 1 + 1 file changed, 1 insertion(+) diff --git

[GIT PULL] drm/tegra: Fixes for v5.15-rc3

2021-09-24 Thread Thierry Reding
Hi Dave, The following changes since commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f: Linux 5.15-rc1 (2021-09-12 16:28:37 -0700) are available in the Git repository at: ssh://git.freedesktop.org/git/tegra/linux.git tags/drm/tegra/for-5.15-rc3 for you to fetch changes up to

Re: [PATCH v5 1/2] pwm: Introduce single-PWM of_xlate function

2021-09-24 Thread Bjorn Andersson
On Fri 24 Sep 00:16 PDT 2021, Uwe Kleine-K?nig wrote: > On Thu, Sep 23, 2021 at 09:12:24PM -0500, Bjorn Andersson wrote: > > The existing pxa driver and the upcoming addition of PWM support in the > > TI sn565dsi86 DSI/eDP bridge driver both has a single PWM channel and > > thereby a need for a

Re: [PATCH] dt-bindings: drm/bridge: ti-sn65dsi86: Fix reg value

2021-09-24 Thread Kieran Bingham
On 24/09/2021 13:35, Geert Uytterhoeven wrote: > make dtbs_check: > > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml: bridge@2c: > reg:0:0: 45 was expected > > According to the datasheet, the I2C address can be either 0x2c or 0x2d, > depending on the ADDR control input. > >

Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding

2021-09-24 Thread Doug Anderson
Hi, On Fri, Sep 24, 2021 at 2:10 AM Andrzej Hajda wrote: > > Hi > > removed most cc, due to server limitation > > > W dniu 24.09.2021 o 10:03, Jani Nikula pisze: > > On Mon, 20 Sep 2021, Doug Anderson wrote: > >> Pushed all 15 to drm-misc-next. > > ... > >> e8de4d55c259 drm/edid: Use new

[PATCH 1/2] drm/vc4: hdmi: Check the device state in prepare()

2021-09-24 Thread Maxime Ripard
Even though we already check that the encoder->crtc pointer is there during in startup(), which is part of the open() path in ASoC, nothing guarantees that our encoder state won't change between the time when we open the device and the time we prepare it. Move the sanity checks we do in startup()

[PATCH 2/2] drm/vc4: hdmi: Remove drm_encoder->crtc usage

2021-09-24 Thread Maxime Ripard
The drm_encoder crtc pointer isn't really fit for an atomic driver, let's rely on the connector state instead. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 50 -- 1 file changed, 36 insertions(+), 14 deletions(-) diff --git

[PATCH 0/2] drm/vc4: hdmi: Get rid of encoder->crtc, take 2

2021-09-24 Thread Maxime Ripard
Hi, Following the report from Sudip Mukherjee, the previous version of that patch got reverted until a fix was found. While it's not clear yet why we end up in that situation, the culprit is that the original patch in its ASoC prepare hook was calling the vc4_hdmi_set_n_cts function that in

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-24 Thread Tom Lendacky
On 9/24/21 4:51 AM, Borislav Petkov wrote: On Fri, Sep 24, 2021 at 12:41:32PM +0300, Kirill A. Shutemov wrote: On Thu, Sep 23, 2021 at 08:21:03PM +0200, Borislav Petkov wrote: On Thu, Sep 23, 2021 at 12:05:58AM +0300, Kirill A. Shutemov wrote: Unless we find other way to guarantee

Re: Regression with mainline kernel on rpi4

2021-09-24 Thread Maxime Ripard
On Wed, Sep 22, 2021 at 01:25:21PM -0700, Linus Torvalds wrote: > On Wed, Sep 22, 2021 at 1:19 PM Sudip Mukherjee > wrote: > > > > I added some debugs to print the addresses, and I am getting: > > [ 38.813809] sudip crtc > > > > This is from struct drm_crtc *crtc =

Re: [PATCH] dt-bindings: drm/bridge: ti-sn65dsi86: Fix reg value

2021-09-24 Thread Geert Uytterhoeven
On Fri, Sep 24, 2021 at 2:35 PM Geert Uytterhoeven wrote: > make dtbs_check: > > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml: bridge@2c: > reg:0:0: 45 was expected > > According to the datasheet, the I2C address can be either 0x2c or 0x2d, > depending on the ADDR control input.

[PATCH] dt-bindings: drm/bridge: ti-sn65dsi86: Fix reg value

2021-09-24 Thread Geert Uytterhoeven
make dtbs_check: arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml: bridge@2c: reg:0:0: 45 was expected According to the datasheet, the I2C address can be either 0x2c or 0x2d, depending on the ADDR control input. Fixes: e3896e6dddf0b821 ("dt-bindings: drm/bridge: Document sn65dsi86

Re: [PATCH] drm/i915: fix blank screen booting crashes

2021-09-24 Thread Ville Syrjälä
On Tue, Sep 21, 2021 at 06:50:39PM -0700, Matthew Brost wrote: > From: Hugh Dickins > > 5.15-rc1 crashes with blank screen when booting up on two ThinkPads > using i915. Bisections converge convincingly, but arrive at different > and surprising "culprits", none of them the actual culprit. > >

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-24 Thread H. Nikolaus Schaller
Hi Paul, > Am 23.09.2021 um 22:23 schrieb H. Nikolaus Schaller : > > >> Because your "it doesn't work" arguments have zero weight otherwise. > > I hope I still can find it. So I can't promise anything. > We have had it complete in DTS and added code to parse it. > It may have been wiped out by

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-24 Thread Borislav Petkov
On Fri, Sep 24, 2021 at 12:41:32PM +0300, Kirill A. Shutemov wrote: > On Thu, Sep 23, 2021 at 08:21:03PM +0200, Borislav Petkov wrote: > > On Thu, Sep 23, 2021 at 12:05:58AM +0300, Kirill A. Shutemov wrote: > > > Unless we find other way to guarantee RIP-relative access, we must use > > >

Re: [PATCH -next] drm/gma500: Fix wrong pointer passed to PTR_ERR()

2021-09-24 Thread Thomas Zimmermann
Hi Am 24.09.21 um 11:40 schrieb Yang Yingliang: PTR_ERR() should access the value just tested by IS_ERR(), otherwise the wrong error code will be returned. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: Thomas Zimmermann Indeed, thanks for the patch. I'll add the fix

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-24 Thread Kirill A. Shutemov
On Thu, Sep 23, 2021 at 08:21:03PM +0200, Borislav Petkov wrote: > On Thu, Sep 23, 2021 at 12:05:58AM +0300, Kirill A. Shutemov wrote: > > Unless we find other way to guarantee RIP-relative access, we must use > > fixup_pointer() to access any global variables. > > Yah, I've asked compiler folks

[PATCH -next] drm/gma500: Fix wrong pointer passed to PTR_ERR()

2021-09-24 Thread Yang Yingliang
PTR_ERR() should access the value just tested by IS_ERR(), otherwise the wrong error code will be returned. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/gpu/drm/gma500/psb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding

2021-09-24 Thread Andrzej Hajda
Hi removed most cc, due to server limitation W dniu 24.09.2021 o 10:03, Jani Nikula pisze: > On Mon, 20 Sep 2021, Doug Anderson wrote: >> Pushed all 15 to drm-misc-next. > ... >> e8de4d55c259 drm/edid: Use new encoded panel id style for quirks matching >> d9f91a10c3e8 drm/edid: Allow

Re: [Intel-gfx] [patch 07/11] drm/i915/pmu: Use hrtimer_forward_now()

2021-09-24 Thread Tvrtko Ursulin
On 23/09/2021 17:04, Thomas Gleixner wrote: hrtimer_forward() is about to be removed from the public interfaces. Replace it with hrtimer_forward_now() which provides the same functionality. Signed-off-by: Thomas Gleixner Cc: David Airlie Cc: intel-...@lists.freedesktop.org Cc: Joonas

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-24 Thread Paul Cercueil
Hi Paul, Le ven., sept. 24 2021 at 00:51:39 +0200, Paul Boddie a écrit : On Thursday, 23 September 2021 22:23:28 CEST H. Nikolaus Schaller wrote: > Am 23.09.2021 um 21:39 schrieb Paul Cercueil : > > Start by wiring things properly, like in my previously linked DTS, and > *test*. If

Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding

2021-09-24 Thread Jani Nikula
On Mon, 20 Sep 2021, Doug Anderson wrote: > Pushed all 15 to drm-misc-next. ... > e8de4d55c259 drm/edid: Use new encoded panel id style for quirks matching > d9f91a10c3e8 drm/edid: Allow querying/working with the panel ID from the EDID Hi Doug, Stan's reporting "initializer element is not

Re: [PATCH v5 2/2] drm/bridge: ti-sn65dsi86: Implement the pwm_chip

2021-09-24 Thread Uwe Kleine-König
Hello, On Thu, Sep 23, 2021 at 09:12:25PM -0500, Bjorn Andersson wrote: > The SN65DSI86 provides the ability to supply a PWM signal on GPIO 4, > with the primary purpose of controlling the backlight of the attached > panel. Add an implementation that exposes this using the standard PWM >

[PATCH 2/4] drm/msm: allow compile_test on !ARM

2021-09-24 Thread Christian König
MSM is one of the few drivers which won't even compile test on !ARM platforms. Looking into this a bit more it turned out that there is actually not that much missing to at least let the driver compile on x86 as well. So this patch replaces the use of phys_to_page() with the open coded version

[PATCH 4/4] drm/etnaviv: use dma_resv_describe

2021-09-24 Thread Christian König
Instead of dumping the fence info manually. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c

[PATCH 3/4] drm/msm: use the new dma_resv_describe

2021-09-24 Thread Christian König
Instead of hand rolling pretty much the same code. Signed-off-by: Christian König --- drivers/gpu/drm/msm/msm_gem.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index

[PATCH 1/4] dma-buf: add dma_fence_describe and dma_resv_describe

2021-09-24 Thread Christian König
Add functions to dump dma_fence and dma_resv objects into a seq_file and use them for printing the debugfs informations. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 11 +-- drivers/dma-buf/dma-fence.c | 16 drivers/dma-buf/dma-resv.c | 23

Re: [PATCH v5 1/2] pwm: Introduce single-PWM of_xlate function

2021-09-24 Thread Uwe Kleine-König
On Thu, Sep 23, 2021 at 09:12:24PM -0500, Bjorn Andersson wrote: > The existing pxa driver and the upcoming addition of PWM support in the > TI sn565dsi86 DSI/eDP bridge driver both has a single PWM channel and > thereby a need for a of_xlate function with the period as its single > argument. > >

[PATCH v2 04/17] drm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-24 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/drm_client_modeset.c | 5 +++--

[PATCH v2 03/17] drm/msm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-24 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace the boilerplate code surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul Reported-by: kernel test robot ---

[PATCH v2 06/17] drm/tegra: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-24 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul Reported-by: kernel test robot --- drivers/gpu/drm/tegra/dsi.c | 6 --

[PATCH v2 12/17] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-24 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/i915/display/intel_audio.c| 16 --- drivers/gpu/drm/i915/display/intel_display.c

[PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible

2021-09-24 Thread Fernando Ramos
Hi all, One of the things in the DRM TODO list ("Documentation/gpu/todo.rst") was to "use DRM_MODESET_LOCAL_ALL_* helpers instead of boilerplate". That's what this patch series is about. You will find two types of changes here: - Replacing "drm_modeset_lock_all_ctx()" (and surrounding

[PATCH v2 13/17] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() part 2

2021-09-24 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() While the previous commit was a simple "search and replace", this time I had to do a bit of refactoring as only one call to

  1   2   >