Re: [PATCH v2, 1/1] mailbox: cmdq: add instruction time-out interrupt support

2021-11-16 Thread yongqiang . niu
On Fri, 2021-10-08 at 22:55 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > yongqiang.niu 於 2021年10月8日 週五 上午9:49寫道: > > > > On Tue, 2021-10-05 at 07:41 +0800, Chun-Kuang Hu wrote: > > > Hi, Yongqiang: > > > > > > Yongqiang Niu 於 2021年9月30日 週四 > > > 下午9:18寫道: > > > > > > > > add time-out cycl

Re: [PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies harder

2021-11-16 Thread Christian König
Am 16.11.21 um 19:30 schrieb Amit Pundir: On Tue, 16 Nov 2021 at 21:21, Rob Clark wrote: From: Rob Clark drm_sched_job_add_dependency() could drop the last ref, so we need to do the dma_fence_get() first. It fixed the splats I saw on RB5 (sm8250 | A650). Thanks. Tested-by: Amit Pundir I

[Bug 201957] amdgpu: ring gfx timeout

2021-11-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 Fusion Future (qydwhotm...@gmail.com) changed: What|Removed |Added CC||qydwhotm...@gmail.

Re: [PATCH v7 20/20] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195

2021-11-16 Thread Nancy . Lin
Hi Chun-Kuang, Thanks for the review. On Fri, 2021-11-12 at 07:30 +0800, Chun-Kuang Hu wrote: > Hi, Nancy: > > Nancy.Lin 於 2021年10月29日 週五 下午3:52寫道: > > > > Add driver data of mt8195 vdosys1 to mediatek-drm and the sub > > driver. > > > > Signed-off-by: Nancy.Lin > > --- > > drivers/gpu/drm/

[Bug 214991] VC4 DRM waiting for flip down makes UI freeze a while with kernel 5.15

2021-11-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214991 --- Comment #1 from Jian-Hong Pan (j...@endlessos.org) --- Created attachment 299603 --> https://bugzilla.kernel.org/attachment.cgi?id=299603&action=edit Full dmesg log with the patch series "drm/vc4: kms: Misc fixes for HVS commits" Thanks to

RE: [PATCH v3 0/4] Add Aspeed AST2600 soc display support

2021-11-16 Thread Tommy Huang
Hi Joel, Got it. I will change user name for next patch send. The ast2600 is tested on my platform. And I will try this on the ast2500. Below is testing steps: 1. Apply the patch into project. 2. Add below config for VT and LOGO on. CONFIG

Re: [PATCH v1 3/3] phy: qcom: Program SSC only if supported by sink

2021-11-16 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-11-15 23:07:38) > Some legacy eDP sinks may not support SSC. The support for SSC is > indicated through an opts flag from the controller driver. This > change will enable SSC only if the sink supports it. > > Signed-off-by: Sankeerth Billakanti > --- I suppose a

Re: [PATCH v1 2/3] phy: qcom: Add support for eDP PHY on sc7280

2021-11-16 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-11-15 23:07:37) > The sc7280 platform supports native eDP controller and PHY. > This change will add support for the eDP PHY on sc7280. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Re: [PATCH v1 1/3] dt-bindings: phy: Add eDP PHY compatible for sc7280

2021-11-16 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-11-15 23:07:36) > Add compatible string for the supported eDP PHY on sc7280 platform. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Fix drm suspend and resume issue

2021-11-16 Thread jason-jh . lin
Subject: [PATCH 0/3] Fix drm suspend and resume issue 1. When the hardwire components on crtc is using GCE to configure their register, cmdq_suspend may be called. So add cmdq_mbox_flush to clear all tasks and release GCE clocks before cmdq_suspend. 2. The suspend and resume order of com

[PATCH 2/3] mailbox: add cmdq_mbox_flush to clear all task before suspend

2021-11-16 Thread jason-jh . lin
CMDQ driver will occupy GCE clock to execute the task in GCE thread. So call cmdq_mbox_flush to clear all task in GCE thread before CMDQ suspend. Signed-off-by: jason-jh.lin --- drivers/mailbox/mtk-cmdq-mailbox.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drive

[PATCH 3/3] drm/mediatek: add devlink to cmdq dev

2021-11-16 Thread jason-jh . lin
Add devlink to cmdq to make sure the order of suspend and resume is correct. Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc

[PATCH 1/3] mialbox: move cmdq suspend, resume and remove after cmdq_mbox_flush

2021-11-16 Thread jason-jh . lin
Move the function order to make sure cmdq_mbox_flush is declared before cmdq_suspend calling it. Signed-off-by: jason-jh.lin --- drivers/mailbox/mtk-cmdq-mailbox.c | 84 +++--- 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbo

[PATCH] drm/panel-edp: modify Kconfig to prevent build error

2021-11-16 Thread Randy Dunlap
When CONFIG_DRM_KMS_HELPER=m and CONFIG_DRM_PANEL_EDP=y, there is a build error in gpu/drm/panel/panel-edp.o: arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-edp.o: in function `panel_edp_probe': panel-edp.c:(.text+0xf38): undefined reference to `drm_panel_dp_aux_backlight' Fix this by limitin

Re: [PATCH 2/2] drm/sched: fix dropping the last fence ref

2021-11-16 Thread Christian König
Am 16.11.21 um 19:07 schrieb Rob Clark: On Tue, Nov 16, 2021 at 8:37 AM Daniel Vetter wrote: On Tue, Nov 16, 2021 at 10:25:19AM +0100, Christian König wrote: We need to grab another ref before trying to add the fence to the sched job and not after. Signed-off-by: Christian König Reviewed

Re: [PATCH v3 0/4] Add Aspeed AST2600 soc display support

2021-11-16 Thread Joel Stanley
On Wed, 17 Nov 2021 at 05:45, tommy-huang wrote: > > v3: > Refine the patch for clear separate purpose. > Skip to send devicetree patch Thanks Tommy. A few things: - Set up your authorship in git: git config --global user.name "Tommy Haung" - The "Add AST2600 chip support" patch is the s

Re: [PATCH v7 19/20] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support

2021-11-16 Thread Nancy . Lin
Hi Chun-Kuang, Thanks for the review. On Thu, 2021-11-11 at 07:44 +0800, Chun-Kuang Hu wrote: > Hi, Nancy: > > Nancy.Lin 於 2021年10月29日 週五 下午3:52寫道: > > > > MT8195 have two mmsys. Modify drm for MT8195 multi-mmsys support. > > The two mmsys (vdosys0 and vdosys1) will bring up two drm drivers, >

[PATCH v3 1/4] ARM: dts: aspeed: Add GFX node to AST2600

2021-11-16 Thread tommy-huang
From: Joel Stanley The GFX device is present in the AST2600 SoC. Signed-off-by: Joel Stanley Signed-off-by: tommy-huang --- arch/arm/boot/dts/aspeed-g6.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi ind

[PATCH v3 4/4] drm/aspeed: Add AST2600 chip support

2021-11-16 Thread tommy-huang
Add AST2600 chip support and setting. Signed-off-by: tommy-huang --- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c index d4b56b3c7597..d10246b1d1c2 100644 ---

[PATCH v3 3/4] drm/aspeed: Update INTR_STS handling

2021-11-16 Thread tommy-huang
Add interrupt clear register define for further chip support. Signed-off-by: tommy-huang --- drivers/gpu/drm/aspeed/aspeed_gfx.h | 1 + drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h b/dri

[PATCH v3 0/4] Add Aspeed AST2600 soc display support

2021-11-16 Thread tommy-huang
v3: Refine the patch for clear separate purpose. Skip to send devicetree patch v2: Remove some unnecessary patch. Refine for reviwer request. v1: First add patch. Joel Stanley (2): ARM: dts: aspeed: Add GFX node to AST2600 ARM: dts: aspeed: ast2600-evb: Enable GFX device tommy-hua

[PATCH v3 2/4] ARM: dts: aspeed: ast2600-evb: Enable GFX device

2021-11-16 Thread tommy-huang
From: Joel Stanley Enable the GFX device with a framebuffer memory region. Signed-off-by: Joel Stanley Signed-off-by: tommy-huang --- arch/arm/boot/dts/aspeed-ast2600-evb.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/ar

Re: [PATCH] lontium-lt9611: check a different register bit for HDMI sensing

2021-11-16 Thread Vinod Koul
Hi John, On 16-11-21, 20:47, John Stultz wrote: > On Tue, Nov 16, 2021 at 6:07 PM Peter Collingbourne wrote: > > > > It has been observed that with certain monitors such as the HP Z27n, > > the register 0x825e reads a value of 0x79 when the HDMI cable is > > connected and 0x78 when it is disconne

Re: [PATCH] lontium-lt9611: check a different register bit for HDMI sensing

2021-11-16 Thread Vinod Koul
On 16-11-21, 22:49, Anibal Limon wrote: > Dmitry, > > May be this is the reason of my HP monitor not working in RB5. Rb5 has Lt9611UXC > > Regards, > Anibal > > El mar., 16 de noviembre de 2021 20:07, Peter Collingbourne > escribió: > > > It has been observed that with certain monitors such

Re: [PATCH] lontium-lt9611: check a different register bit for HDMI sensing

2021-11-16 Thread John Stultz
On Tue, Nov 16, 2021 at 6:07 PM Peter Collingbourne wrote: > > It has been observed that with certain monitors such as the HP Z27n, > the register 0x825e reads a value of 0x79 when the HDMI cable is > connected and 0x78 when it is disconnected, i.e. bit 0 appears > to correspond to the HDMI connec

Re: [PATCH v7 18/20] drm/mediatek: add ovl_adaptor support for MT8195

2021-11-16 Thread Nancy . Lin
Hi Chun-Kuang, Thanks for the review. On Fri, 2021-11-05 at 08:29 +0800, Chun-Kuang Hu wrote: > Hi, Nancy: > > Nancy.Lin 於 2021年10月29日 週五 下午3:52寫道: > > > > Add ovl_adaptor driver for MT8195. > > Ovl_adaptor is an encapsulated module and designed for simplified > > DRM control flow. This module

Re: [PATCH v7 16/20] drm/mediatek: add ETHDR support for MT8195

2021-11-16 Thread Nancy . Lin
Hi Chun-Kuang, Thanks for the review. On Fri, 2021-11-05 at 07:59 +0800, Chun-Kuang Hu wrote: > Hi, Nancy: > > Nancy.Lin 於 2021年10月29日 週五 下午3:52寫道: > > > > ETHDR is a part of ovl_adaptor. > > ETHDR is designed for HDR video and graphics conversion in the > > external > > display path. It hand

Re: [PATCH 12/13] sysctl: add helper to register empty subdir

2021-11-16 Thread Luis Chamberlain
On Fri, May 29, 2020 at 08:03:02AM -0500, Eric W. Biederman wrote: > Luis Chamberlain writes: > > > The way to create a subdirectory from the base set of directories > > is a bit obscure, so provide a helper which makes this clear, and > > also helps remove boiler plate code required to do this w

linux-next: build warning after merge of the drm-misc tree

2021-11-16 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: include/drm/gpu_scheduler.h:316: warning: Function parameter or member 'work' not described in 'drm_sched_job' Introduced by commit 542cff7893a3 ("drm/sched: Avoid lockdep spalt on killing a p

Re: [PATCH v3 11/12] drm/virtio: implement context init: add virtio_gpu_fence_event

2021-11-16 Thread Gurchetan Singh
On Tue, Nov 16, 2021 at 7:43 AM Daniel Vetter wrote: > On Mon, Nov 15, 2021 at 07:26:14PM +, Kasireddy, Vivek wrote: > > Hi Daniel, Greg, > > > > If it is the same or a similar crash reported here: > > > https://lists.freedesktop.org/archives/dri-devel/2021-November/330018.html > > and here:

Re: [PATCH 2/2] dt-bindings: panel: Introduce a panel-lvds binding

2021-11-16 Thread Rob Herring
On Tue, 16 Nov 2021 15:35:03 +0100, Maxime Ripard wrote: > Following the previous patch, let's introduce a generic panel-lvds > binding that documents the panels that don't have any particular > constraint documented. > > Signed-off-by: Maxime Ripard > --- > .../bindings/display/panel/panel-lvds

Re: [PATCH v4 3/3] MAINTAINERS: Mark VMware mailing list entries as email aliases

2021-11-16 Thread Zack Rusin
> On Nov 16, 2021, at 17:41, Srivatsa S. Bhat wrote: > > From: Srivatsa S. Bhat (VMware) > > VMware mailing lists in the MAINTAINERS file are private lists meant > for VMware-internal review/notification for patches to the respective > subsystems. Anyone can post to these addresses, but ther

Re: Build regressions/improvements in v5.16-rc1

2021-11-16 Thread Randy Dunlap
On 11/16/21 5:59 PM, Nick Terrell wrote: On Nov 15, 2021, at 8:44 AM, Helge Deller wrote: On 11/15/21 17:12, Geert Uytterhoeven wrote: On Mon, Nov 15, 2021 at 4:54 PM Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v5.16-rc1[1] compared to v5

[PATCH] drm/selftest: fix potential memleak in error branch

2021-11-16 Thread Bernard Zhao
This patch try to fix the potential memleak in error branch. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c b/drivers/gpu/drm/selftest

[PATCH] drm/aspeed: Fix vga_pw sysfs output

2021-11-16 Thread Joel Stanley
Before the drm driver had support for this file there was a driver that exposed the contents of the vga password register to userspace. It would present the entire register instead of interpreting it. The drm implementation chose to mask of the lower bit, without explaining why. This breaks the ex

Re: [PATCH v4 3/3] MAINTAINERS: Mark VMware mailing list entries as email aliases

2021-11-16 Thread Joe Perches
On Tue, 2021-11-16 at 14:41 -0800, Srivatsa S. Bhat wrote: > From: Srivatsa S. Bhat (VMware) > > VMware mailing lists in the MAINTAINERS file are private lists meant > for VMware-internal review/notification for patches to the respective > subsystems. Anyone can post to these addresses, but there

[PATCH v4 3/3] MAINTAINERS: Mark VMware mailing list entries as email aliases

2021-11-16 Thread Srivatsa S. Bhat
From: Srivatsa S. Bhat (VMware) VMware mailing lists in the MAINTAINERS file are private lists meant for VMware-internal review/notification for patches to the respective subsystems. Anyone can post to these addresses, but there is no public read access like open mailing lists, which makes them m

[PATCH v4 0/3] Update VMware maintainer entries

2021-11-16 Thread Srivatsa S. Bhat
This series updates a few maintainer entries for VMware-maintained subsystems and cleans up references to VMware's private mailing lists to make it clear that they are effectively email-aliases to reach out to reviewers. Changes from v3->v4: - Remove Cc: sta...@vger.kernel.org from patches 1 and 2

linux-next: manual merge of the drm-misc tree with Linus' tree

2021-11-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/nouveau/dispnv50/disp.c between commit: d6c6a76f80a1 ("drm: Update MST First Link Slot Information Based on Encoding Format") from Linus' tree and commit: 606be062c2e5 ("drm/nouveau/kms/nv50-: Remo

Re: [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-16 Thread Kuogee Hsieh
On 11/15/2021 12:23 PM, khs...@codeaurora.org wrote: On 2021-11-09 13:38, Kuogee Hsieh wrote: From: Kuogee Hsieh Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a symmetric manner. This increase difficulty of code maintenance

Re: [PATCH] In function nvkm_ioctl_map(), the variable "type" could be uninitialized if "nvkm_object_map()" returns error code, however, it does not check the return value and directly use the "type"

2021-11-16 Thread Lyude Paul
This is a very long patch name, it should probably be shorter and the details in the patch title moved into the actual commit description instead. Also a couple of things aren't formatted correctly: * Cc tag for stable is missing, see https://www.kernel.org/doc/html/latest/process/stable-kernel-

[PATCH v3 6/6] drm/amdgpu: add drm buddy support to amdgpu

2021-11-16 Thread Arunpravin
- Remove drm_mm references and replace with drm buddy functionalities - Add res cursor support for drm buddy v2(Matthew Auld): - replace spinlock with mutex as we call kmem_cache_zalloc(..., GFP_KERNEL) in drm_buddy_alloc() function - lock drm_buddy_block_trim() function as it calls mark_f

[PATCH v3 5/6] drm/amdgpu: move vram inline functions into a header

2021-11-16 Thread Arunpravin
Move shared vram inline functions and structs into a header file Signed-off-by: Arunpravin --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 51 1 file changed, 51 insertions(+) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h diff --git a/drivers/gpu/drm/a

[PATCH v3 4/6] drm: implement a method to free unused pages

2021-11-16 Thread Arunpravin
On contiguous allocation, we round up the size to the *next* power of 2, implement a function to free the unused pages after the newly allocate block. v2(Matthew Auld): - replace function name 'drm_buddy_free_unused_pages' with drm_buddy_block_trim - replace input argument name 'actual_siz

[PATCH v3 3/6] drm: implement top-down allocation method

2021-11-16 Thread Arunpravin
Implemented a function which walk through the order list, compares the offset and returns the maximum offset block, this method is unpredictable in obtaining the high range address blocks which depends on allocation and deallocation. for instance, if driver requests address at a low specific range,

[PATCH v3 2/6] drm: improve drm_buddy_alloc function

2021-11-16 Thread Arunpravin
- Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which allocates the requested power-of-two block comply with range limitations - Moved order computation and memory alignment logic from i915 drive

[PATCH v3 1/6] drm: move the buddy allocator from i915 into common drm

2021-11-16 Thread Arunpravin
Move the base i915 buddy allocator code into drm - Move i915_buddy.h to include/drm - Move i915_buddy.c to drm root folder - Rename "i915" string with "drm" string wherever applicable - Rename "I915" string with "DRM" string wherever applicable - Fix header file dependencies - Fix alignment issues

[PATCH] drm/i915: Check return value of i915_request_mark_eio before calling put

2021-11-16 Thread Matthew Brost
i915_request_mark_eio can return NULL and in some cases this return value was unconditionally passed to i915_request_put. i915_request_put in turn calls dma_fence_put on &rq->fence. dma_fence_put checks for NULL and short circuits. This all just happens to work because rq->fence is first member in

[PATCH] drm/i915: Drop stealing of bits from i915_sw_fence function pointer

2021-11-16 Thread Matthew Brost
Rather than stealing bits from i915_sw_fence function pointer use seperate fields for function pointer and flags. If using two different fields, the 4 byte alignment for the i915_sw_fence function pointer can also be dropped. v2: (CI) - Set new function field rather than flags in __i915_sw_fenc

Re: [PATCH v3 1/5] drm/i915/dg2: s/DISP_STEPPING/DISPLAY_STEPPING/

2021-11-16 Thread Jani Nikula
On Tue, 16 Nov 2021, Matt Roper wrote: > Commit cd0fcf5af791 ("drm/i915: rename DISP_STEPPING->DISPLAY_STEP and > GT_STEPPING->GT_STEP") renamed all platforms' display stepping tests, > but the DG2 patches were still in-flight at that time and did not > incorporate the new naming scheme. Rename D

[PATCH AUTOSEL 5.15 08/65] drm/virtio: fix the missed drm_gem_object_put() in virtio_gpu_user_framebuffer_create()

2021-11-16 Thread Sasha Levin
From: Jing Xiangfeng [ Upstream commit a63f393dd7e1ebee707c9dee1d197fdc33d6486b ] virtio_gpu_user_framebuffer_create() misses to call drm_gem_object_put() in an error path. Add the missed function call to fix it. Signed-off-by: Jing Xiangfeng Link: http://patchwork.freedesktop.org/patch/msgid

[PATCH AUTOSEL 5.15 07/65] fbdev: fbmem: Fix double free of 'fb_info->pixmap.addr'

2021-11-16 Thread Sasha Levin
From: Zheyu Ma [ Upstream commit 2c0c19b681d5a331b53aab0d170f72a87c7bff12 ] savagefb and some other drivers call kfree to free 'info->pixmap.addr' even after calling unregister_framebuffer, which may cause double free. Fix this by setting 'fb_info->pixmap.addr' to NULL after kfree in unregister

[PATCH AUTOSEL 5.15 03/65] backlight: Propagate errors from get_brightness()

2021-11-16 Thread Sasha Levin
From: Thomas Weißschuh [ Upstream commit 563edf85ce18a90dd0a7b39e279a691d937205f6 ] backlight.h documents "struct backlight_ops->get_brightness()" to return a negative errno on failure. So far these errors have not been handled in the backlight core. This leads to negative values being exposed

[PATCH AUTOSEL 5.15 08/65] drm/virtio: fix the missed drm_gem_object_put() in virtio_gpu_user_framebuffer_create()

2021-11-16 Thread Sasha Levin
From: Jing Xiangfeng [ Upstream commit a63f393dd7e1ebee707c9dee1d197fdc33d6486b ] virtio_gpu_user_framebuffer_create() misses to call drm_gem_object_put() in an error path. Add the missed function call to fix it. Signed-off-by: Jing Xiangfeng Link: http://patchwork.freedesktop.org/patch/msgid

[PATCH AUTOSEL 5.15 07/65] fbdev: fbmem: Fix double free of 'fb_info->pixmap.addr'

2021-11-16 Thread Sasha Levin
From: Zheyu Ma [ Upstream commit 2c0c19b681d5a331b53aab0d170f72a87c7bff12 ] savagefb and some other drivers call kfree to free 'info->pixmap.addr' even after calling unregister_framebuffer, which may cause double free. Fix this by setting 'fb_info->pixmap.addr' to NULL after kfree in unregister

[PATCH AUTOSEL 5.15 03/65] backlight: Propagate errors from get_brightness()

2021-11-16 Thread Sasha Levin
From: Thomas Weißschuh [ Upstream commit 563edf85ce18a90dd0a7b39e279a691d937205f6 ] backlight.h documents "struct backlight_ops->get_brightness()" to return a negative errno on failure. So far these errors have not been handled in the backlight core. This leads to negative values being exposed

Re: [PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies harder

2021-11-16 Thread Amit Pundir
On Tue, 16 Nov 2021 at 21:21, Rob Clark wrote: > > From: Rob Clark > > drm_sched_job_add_dependency() could drop the last ref, so we need to do > the dma_fence_get() first. > It fixed the splats I saw on RB5 (sm8250 | A650). Thanks. Tested-by: Amit Pundir > Cc: Christian König > Fixes: 9c2ba

Re: [PATCH 2/2] drm/sched: fix dropping the last fence ref

2021-11-16 Thread Rob Clark
On Tue, Nov 16, 2021 at 8:37 AM Daniel Vetter wrote: > > On Tue, Nov 16, 2021 at 10:25:19AM +0100, Christian König wrote: > > We need to grab another ref before trying to add the fence to the sched > > job and not after. > > > > Signed-off-by: Christian König > > Reviewed-by: Daniel Vetter > > I

[PATCH v3 5/5] drm/i915/dg2: extend Wa_1409120013 to DG2

2021-11-16 Thread Matt Roper
From: Matt Atwood Extend existing workaround 1409120013 to DG2. Cc: José Roberto de Souza Signed-off-by: Matt Atwood Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers

[PATCH v3 2/5] drm/i915/dg2: Add Wa_14010547955

2021-11-16 Thread Matt Roper
This workaround is documented a bit strangely in the bspec; it's listed as an A0 workaround, but the description clarifies that the workaround is implicitly handled by the hardware and what the driver really needs to do is program a chicken bit to reenable some internal behavior. Signed-off-by: Ma

[PATCH v3 3/5] drm/i915/dg2: Add Wa_16011777198

2021-11-16 Thread Matt Roper
Coarse power gating for render should not be enabled on some DG2 steppings. Bspec: 52698 Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_rc6.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i

[PATCH v3 4/5] drm/i915/dg2: Add Wa_16013000631

2021-11-16 Thread Matt Roper
From: Ramalingam C Invalidate IC cache through pipe control command as part of the ctx restore flow through indirect ctx pointer. v2: - Move pipe control from xcs indirect context to the rcs indirect context. We'll eventually need this on the CCS engines too, but support for those hasn't

[PATCH v3 0/5] i915: Additional DG2 workarounds

2021-11-16 Thread Matt Roper
We have a few more DG2 workarounds that weren't included in the initial batch. v2: - Apply pipe control workaround to rcs indirect context rather than xcs indirect context. v3: - s/IS_DG2_DISP_STEP/IS_DG2_DISPLAY_STEPPING/ for consistency with other platforms. Matt Atwood (1): drm/i91

[PATCH v3 1/5] drm/i915/dg2: s/DISP_STEPPING/DISPLAY_STEPPING/

2021-11-16 Thread Matt Roper
Commit cd0fcf5af791 ("drm/i915: rename DISP_STEPPING->DISPLAY_STEP and GT_STEPPING->GT_STEP") renamed all platforms' display stepping tests, but the DG2 patches were still in-flight at that time and did not incorporate the new naming scheme. Rename DG2's macro now for consistency with other platfo

[PATCH v4] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-11-16 Thread Kuogee Hsieh
Currently the msm_dp_*** functions implement the same sequence which would happen when drm_bridge is used. hence get rid of this intermediate layer and align with the drm_bridge usage to avoid customized implementation. Signed-off-by: Kuogee Hsieh Changes in v2: -- revise commit text -- rename d

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-16 Thread Claudio Suarez
On Mon, Nov 15, 2021 at 10:17:58PM +0200, Jani Nikula wrote: > On Mon, 15 Nov 2021, Claudio Suarez wrote: > > On Mon, Nov 15, 2021 at 12:24:26PM +0200, Jani Nikula wrote: > >> On Sun, 14 Nov 2021, Claudio Suarez wrote: > >> > On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: > >> >> H

Re: [PATCH] drm/i915: Fix error pointer dereference in i915_gem_do_execbuffer()

2021-11-16 Thread Matthew Brost
On Tue, Nov 16, 2021 at 02:48:17PM +0300, Dan Carpenter wrote: > Originally "out_fence" was set using out_fence = sync_file_create() but > which returns NULL, but now it is set with out_fence = eb_requests_create() > which returns error pointers. The error path needs to be modified to > avoid an O

Re: [PATCH 2/2] drm/sched: fix dropping the last fence ref

2021-11-16 Thread Daniel Vetter
On Tue, Nov 16, 2021 at 10:25:19AM +0100, Christian König wrote: > We need to grab another ref before trying to add the fence to the sched > job and not after. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter I wondered first why this goes boom, but then I realized that in some ca

Re: [PATCH 00/15] iio: buffer-dma: write() and new DMABUF based API

2021-11-16 Thread Laurent Pinchart
On Tue, Nov 16, 2021 at 05:02:25PM +0100, Daniel Vetter wrote: > On Mon, Nov 15, 2021 at 02:57:37PM +, Paul Cercueil wrote: > > Le lun., nov. 15 2021 at 15:37:16 +0100, Daniel Vetter a écrit : > > > On Mon, Nov 15, 2021 at 02:19:10PM +, Paul Cercueil wrote: > > > > Hi Jonathan, > > > > >

Re: [PATCH 00/15] iio: buffer-dma: write() and new DMABUF based API

2021-11-16 Thread Daniel Vetter
On Mon, Nov 15, 2021 at 02:57:37PM +, Paul Cercueil wrote: > Hi Daniel, > > Le lun., nov. 15 2021 at 15:37:16 +0100, Daniel Vetter a > écrit : > > On Mon, Nov 15, 2021 at 02:19:10PM +, Paul Cercueil wrote: > > > Hi Jonathan, > > > > > > This patchset introduces a new userspace interfac

Re: [PATCH v4] drm/ttm: Clarify that the TTM_PL_SYSTEM is under TTMs control

2021-11-16 Thread Zack Rusin
> On Nov 16, 2021, at 03:20, Christian König wrote: > > Am 16.11.21 um 08:43 schrieb Thomas Hellström: >> On 11/16/21 08:19, Christian König wrote: >>> Am 13.11.21 um 12:26 schrieb Thomas Hellström: Hi, Zack, On 11/11/21 17:44, Zack Rusin wrote: > On Wed, 2021-11-10 at 09:50

[PATCH v3] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-16 Thread Tilak Tangudu
v1: Enable runtime pm autosuspend by default for Gen12 and later versions. v2: Enable runtime pm autosuspend by default for all platforms(Syrjala Ville) v3: Change commit message(Nikula Jani) Let's enable runtime pm autosuspend by default everywhere. So, we can allow D3hot and bigger power saving

[PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies harder

2021-11-16 Thread Rob Clark
From: Rob Clark drm_sched_job_add_dependency() could drop the last ref, so we need to do the dma_fence_get() first. Cc: Christian König Fixes: 9c2ba265352a drm/scheduler: ("use new iterator in drm_sched_job_add_implicit_dependencies v2") Signed-off-by: Rob Clark --- Applies on top of "drm/sch

Re: [PATCH v4] drm/ttm: Clarify that the TTM_PL_SYSTEM is under TTMs control

2021-11-16 Thread Daniel Vetter
On Tue, Nov 16, 2021 at 10:09:44AM +0100, Christian König wrote: > Am 16.11.21 um 10:00 schrieb Thomas Hellström: > > On 11/16/21 09:54, Christian König wrote: > > > Am 16.11.21 um 09:33 schrieb Thomas Hellström: > > > > On 11/16/21 09:20, Christian König wrote: > > > > > Am 16.11.21 um 08:43 schri

Re: [PATCH v3 11/12] drm/virtio: implement context init: add virtio_gpu_fence_event

2021-11-16 Thread Daniel Vetter
On Mon, Nov 15, 2021 at 07:26:14PM +, Kasireddy, Vivek wrote: > Hi Daniel, Greg, > > If it is the same or a similar crash reported here: > https://lists.freedesktop.org/archives/dri-devel/2021-November/330018.html > and here: > https://lists.freedesktop.org/archives/dri-devel/2021-November/33

Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings

2021-11-16 Thread Lee Jones
On Tue, 16 Nov 2021, Daniel Thompson wrote: > Hi Lee > > On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote: > > This patchset fixes WLED's handling of enabled-strings: besides some > > cleanup it is now actually possible to specify a non-contiguous array of > > enabled strings (not n

Re: [PATCH] omapfb: add one more "fallthrough" statement

2021-11-16 Thread Nathan Chancellor
On Tue, Nov 16, 2021 at 10:21:54AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang warns about one missing fallthrough that gcc ignores: > > drivers/video/fbdev/omap/omapfb_main.c:1558:2: error: unannotated > fall-through between switch labels [-Werror,-Wimplicit-fallthrough] > > A

Re: [Intel-gfx] [PATCH] drm/i915/guc: fix NULL vs IS_ERR() checking

2021-11-16 Thread Rodrigo Vivi
On Tue, Nov 16, 2021 at 02:49:16PM +0300, Dan Carpenter wrote: > The intel_engine_create_virtual() function does not return NULL. It > returns error pointers. > > Fixes: e5e32171a2cf ("drm/i915/guc: Connect UAPI to GuC multi-lrc interface") > Signed-off-by: Dan Carpenter Reviewed-by: Rodrigo Vi

Re: [PATCH v6 7/7] drm/mediatek: Add mt8195 DisplayPort driver

2021-11-16 Thread Maxime Ripard
Hi, On Mon, Nov 15, 2021 at 09:33:52AM -0500, Guillaume Ranquet wrote: > Quoting Maxime Ripard (2021-11-15 11:11:29) > > > The driver creates a child device for the phy. The child device will > > > never exist without the parent being active. As they are sharing a > > > register range, the parent

Re: Questions about KMS flip

2021-11-16 Thread Michel Dänzer
On 2021-11-16 15:10, Alex Deucher wrote: > On Tue, Nov 16, 2021 at 3:09 AM Christian König > wrote: >> >> Am 16.11.21 um 09:00 schrieb Lang Yu: >>> On Tue, Nov 16, 2021 at 08:14:08AM +0100, Christian KKKnig wrote: Am 16.11.21 um 04:27 schrieb Lang Yu: > On Mon, Nov 15, 2021 at 01:04:15PM

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-16 Thread Rodrigo Vivi
On Mon, Nov 15, 2021 at 09:58:56AM -0500, Rodrigo Vivi wrote: > On Mon, Nov 15, 2021 at 01:44:57PM +0200, Jani Nikula wrote: > > On Mon, 15 Nov 2021, Tilak Tangudu wrote: > > > > The actual commit message with explanations why it will work now and > > didn't work before go here. > > The truth is

Re: [Intel-gfx] [PATCH] drm/i915: Disable D3Cold in s2idle and runtime pm

2021-11-16 Thread Rodrigo Vivi
On Mon, Nov 15, 2021 at 02:20:36PM -0500, Rodrigo Vivi wrote: > On Mon, Nov 15, 2021 at 09:10:54PM +0530, Tilak Tangudu wrote: > > s2idle and runtime pm puts the pci gfx device in D3Hot, ACPI runtime > > monitors the pci tree,if it sees complete tree as D3Hot,it transitions > > the device to D3Cold

[PATCH 1/2] dt-bindings: display: Turn lvds.yaml into a generic schema

2021-11-16 Thread Maxime Ripard
The lvds.yaml file so far was both defining the generic LVDS properties (such as data-mapping) that could be used for any LVDS sink, but also the panel-lvds binding. That last binding was to describe LVDS panels simple enough, and had a number of other bindings using it as a base to specialise it

[PATCH 2/2] dt-bindings: panel: Introduce a panel-lvds binding

2021-11-16 Thread Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented. Signed-off-by: Maxime Ripard --- .../bindings/display/panel/panel-lvds.yaml| 56 +++ 1 file changed, 56 insertions(+) cr

Re: Questions about KMS flip

2021-11-16 Thread Alex Deucher
On Tue, Nov 16, 2021 at 3:09 AM Christian König wrote: > > Am 16.11.21 um 09:00 schrieb Lang Yu: > > On Tue, Nov 16, 2021 at 08:14:08AM +0100, Christian KKKnig wrote: > >> Am 16.11.21 um 04:27 schrieb Lang Yu: > >>> On Mon, Nov 15, 2021 at 01:04:15PM +0100, Michel DDDnzer wrote: > [SNIP] > >>

Re: [PATCH v2] fbdev: Prevent probing generic drivers if a FB is already registered

2021-11-16 Thread Javier Martinez Canillas
On 11/16/21 11:01, Javier Martinez Canillas wrote: > Hello Geert, > > On 11/16/21 10:43, Geert Uytterhoeven wrote: > > [snip] > >>> >>> So this is already a fragile solution and $SUBJECT doesn't make things worse >>> IMO. Since not having something like this can lead to issues as reported by: >>

[PATCH] drm/bridge: megachips: Ensure both bridges are probed before registration

2021-11-16 Thread Martyn Welch
In the configuration used by the b850v3, the STDP2690 is used to read EDID data whilst it's the STDP4028 which can detect when monitors are connected. This can result in problems at boot with monitors connected when the STDP4028 is probed first, a monitor is detected and an attempt is made to read

Re: [PATCH 08/15] iio: buffer-dma: split iio_dma_buffer_fileio_free() function

2021-11-16 Thread Alexandru Ardelean
On Mon, Nov 15, 2021 at 4:20 PM Paul Cercueil wrote: > > From: Alexandru Ardelean > > A part of the logic in the iio_dma_buffer_exit() is required for the change > to add mmap support to IIO buffers. > This change splits the logic into a separate function, which will be > re-used later. > Not su

Re: [PATCH 14/15] iio: buffer-dmaengine: Add support for cyclic buffers

2021-11-16 Thread Alexandru Ardelean
On Mon, Nov 15, 2021 at 4:23 PM Paul Cercueil wrote: > > Handle the IIO_BUFFER_DMABUF_CYCLIC flag to support cyclic buffers. > Reviewed-by: Alexandru Ardelean > Signed-off-by: Paul Cercueil > --- > drivers/iio/buffer/industrialio-buffer-dma.c | 1 + > .../iio/buffer/industrialio-buffer-

Re: [PATCH 13/15] iio: core: Add support for cyclic buffers

2021-11-16 Thread Alexandru Ardelean
On Mon, Nov 15, 2021 at 4:22 PM Paul Cercueil wrote: > > Introduce a new flag IIO_BUFFER_DMABUF_CYCLIC in the "flags" field of > the iio_dmabuf uapi structure. > > When set, the DMABUF enqueued with the enqueue ioctl will be endlessly > repeated on the TX output, until the buffer is disabled. > R

[syzbot] KASAN: use-after-free Read in drm_gem_object_release_handle

2021-11-16 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:8ab774587903 Merge tag 'trace-v5.16-5' of git://git.kernel.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1174ace6b0 kernel config: https://syzkaller.appspot.com/x/.config?x=6d3b8fd1977c1e73 das

Re: Backlight control broken on UM325 (OLED) on 5.15 (bisected)

2021-11-16 Thread Samuel Čavoj
Hi Alex, thank you for your response. On 15.11.2021 10:43, Alex Deucher wrote: > [...] > > That patch adds support for systems with multiple backlights. Do you > have multiple backlight devices now? If so, does the other one work? No, there is still only one backlight device -- amdgpu_bl0. >

[PATCH] gpu/drm: fix potential memleak in error branch

2021-11-16 Thread Bernard Zhao
This patch try to fix potential memleak in error branch. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/drm_dp_mst_topology.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.

Re: [PATCH v10, 00/19] Support multi hardware decode using of_platform_populate

2021-11-16 Thread yunfei.d...@mediatek.com
Hi Ezequiel, On Tue, 2021-11-16 at 09:06 -0300, Ezequiel Garcia wrote: > Hi Yunfei, > > On Tue, 16 Nov 2021 at 08:42, yunfei.d...@mediatek.com > wrote: > > > > Hi Ezequiel, > > > > Thanks for you suggestion. > > On Sun, 2021-11-14 at 19:04 -0300, Ezequiel Garcia wrote: > > > Hi Yunfei, > > >

[bug report] drm/msm/dpu: merge struct dpu_irq into struct dpu_hw_intr

2021-11-16 Thread Dan Carpenter
Hello Dmitry Baryshkov, The patch f25f656608e3: "drm/msm/dpu: merge struct dpu_irq into struct dpu_hw_intr" from Jun 18, 2021, leads to the following Smatch static checker warnings: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:569 dpu_core_irq_preinstall() error: potential null dereference '

Re: [PATCH v10, 00/19] Support multi hardware decode using of_platform_populate

2021-11-16 Thread Ezequiel Garcia
Hi Yunfei, On Tue, 16 Nov 2021 at 08:42, yunfei.d...@mediatek.com wrote: > > Hi Ezequiel, > > Thanks for you suggestion. > On Sun, 2021-11-14 at 19:04 -0300, Ezequiel Garcia wrote: > > Hi Yunfei, > > > > On Thu, 11 Nov 2021 at 01:15, Yunfei Dong > > wrote: > > > > > > This series adds support fo

Re: [PATCH v10, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192

2021-11-16 Thread yunfei.d...@mediatek.com
Hi Ezequiel, Thanks for your suggestion. On Sun, 2021-11-14 at 18:56 -0300, Ezequiel Garcia wrote: > Yunfei, > > On Thu, 11 Nov 2021 at 01:15, Yunfei Dong > wrote: > > > > Adds decoder dt-bindings for mt8192. > > > > Signed-off-by: Yunfei Dong > > --- > > .../media/mediatek,vcodec-subdev-dec

Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings

2021-11-16 Thread Daniel Thompson
Hi Lee On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote: > This patchset fixes WLED's handling of enabled-strings: besides some > cleanup it is now actually possible to specify a non-contiguous array of > enabled strings (not necessarily starting at zero) and the values from > DT are

Re: [PATCH v3 5/9] backlight: qcom-wled: Override default length with qcom,enabled-strings

2021-11-16 Thread Daniel Thompson
On Mon, Nov 15, 2021 at 09:34:55PM +0100, Marijn Suijten wrote: > The length of qcom,enabled-strings as property array is enough to > determine the number of strings to be enabled, without needing to set > qcom,num-strings to override the default number of strings when less > than the default (whic

Re: [PATCH v3 4/9] backlight: qcom-wled: Fix off-by-one maximum with default num_strings

2021-11-16 Thread Daniel Thompson
On Mon, Nov 15, 2021 at 09:34:54PM +0100, Marijn Suijten wrote: > When not specifying num-strings in the DT the default is used, but +1 is > added to it which turns WLED3 into 4 and WLED4/5 into 5 strings instead > of 3 and 4 respectively, causing out-of-bounds reads and register > read/writes. Th

  1   2   >