[PATCH v4 2/2] drm/mediatek: add devlink to cmdq dev

2021-12-01 Thread jason-jh . lin
Add devlink to cmdq to make sure the order of suspend and resume is correct. Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 43 ++--- 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/

[PATCH v4 0/2] Fix mediatek-drm suspend and resume issue

2021-12-01 Thread jason-jh . lin
Change in v4: - change completment function to wait_for_event. - release the mbox channel when device_link_add fail with cmdq and still return 0 because drm can configure register by cpu. Change in v3: - fix return typo: modify -NOEDV to -ENODEV. - add missing complete function in ddp_cmdq_cb.

[PATCH v4 1/2] drm/mediatek: add wait_for_event for crtc disable by cmdq

2021-12-01 Thread jason-jh . lin
mtk_drm_crtc_atomic_disable will send an async cmd to cmdq driver, so it may not finish when cmdq_suspend is called sometimes. Add wait_for_event after sending async disable plane cmd to make sure the lastest cmd is done before cmdq_suspend. Signed-off-by: jason-jh.lin --- drivers/gpu/drm/media

[PATCH] drm/i915: Fix error pointer dereference in i915_gem_do_execbuffer()

2021-12-01 Thread Matthew Brost
From: Dan Carpenter Originally "out_fence" was set using out_fence = sync_file_create() but which returns NULL, but now it is set with out_fence = eb_requests_create() which returns error pointers. The error path needs to be modified to avoid an Oops in the "goto err_request;" path. Fixes: 5444

Re: [PATCH v4 1/6] drm: move the buddy allocator from i915 into common drm

2021-12-01 Thread kernel test robot
Hi Arunpravin, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.16-rc3] [cannot apply to drm/drm-next drm-tip/drm-tip next-20211201] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH v12, 18/19] media: mtk-vcodec: Remove mtk_vcodec_release_dec_pm

2021-12-01 Thread Yunfei Dong
There are only two lines in mtk_vcodec_release_dec_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_init_dec_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_dec_pm to *_clk since it only has clock operations now. Re

[PATCH v12, 19/19] media: mtk-vcodec: Remove mtk_vcodec_release_enc_pm

2021-12-01 Thread Yunfei Dong
There are only two lines in mtk_vcodec_release_enc_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_release_enc_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_enc_pm to *_clk since it only has clock operations now.

[PATCH v12, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192

2021-12-01 Thread Yunfei Dong
Adds decoder dt-bindings for mt8192. Signed-off-by: Yunfei Dong --- .../media/mediatek,vcodec-subdev-decoder.yaml | 266 ++ 1 file changed, 266 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml diff --git a/Documentat

[PATCH v12, 17/19] media: mtk-vcodec: Use codec type to separate different hardware

2021-12-01 Thread Yunfei Dong
There is just one core thread, in order to separate different hardware, using codec type to separeate it in scp driver. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 12 --- .../media/platform/mtk-vcodec/vdec_vpu_if.c

[PATCH v12, 16/19] media: mtk-vcodec: Add core dec and dec end ipi msg

2021-12-01 Thread Yunfei Dong
Add core dec and dec end ipi msg: AP_IPIMSG_DEC_CORE/AP_IPIMSG_DEC_CORE_END. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 4 .../media/platform/mtk-vcodec/vdec_vpu_if.c| 12 .../media/platform/mtk

[PATCH v12, 14/19] media: mtk-vcodec: Support 34bits dma address for vdec

2021-12-01 Thread Yunfei Dong
Use the dma_set_mask_and_coherent helper to set vdec DMA bit mask to support 34bits iova space(16GB) that the mt8192 iommu HW support. Whole the iova range separate to 0~4G/4G~8G/8G~12G/12G~16G, regarding which iova range VDEC actually locate, it depends on the dma-ranges property of vdec dtsi nod

[PATCH v12, 12/19] media: mtk-vcodec: Add new interface to lock different hardware

2021-12-01 Thread Yunfei Dong
For add new hardware, not only need to lock lat hardware, also need to lock core hardware in case of different instance start to decoder at the same time. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 4 ++-- dri

[PATCH v12, 10/19] media: mtk-vcodec: Add msg queue feature for lat and core architecture

2021-12-01 Thread Yunfei Dong
For lat and core architecture, lat thread will send message to core thread when lat decode done. Core hardware will use the message from lat to decode, then free message to lat thread when decode done. Signed-off-by: Yunfei Dong --- fix comments from Reviewed-by: AngeloGioacchino Del Regno ---

[PATCH v12, 13/19] media: mtk-vcodec: Add work queue for core hardware decode

2021-12-01 Thread Yunfei Dong
Add work queue to process core hardware information. First, get lat_buf from message queue, then call core hardware of each codec(H264/VP9/AV1) to decode, finally puts lat_buf back to the message. Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 16 +++- .../pla

[PATCH v12, 09/19] media: mtk-vcodec: Add irq interface for multi hardware

2021-12-01 Thread Yunfei Dong
Adds irq interface for multi hardware. Signed-off-by: Yunfei Dong --- fix comments from Reviewed-by: AngeloGioacchino Del Regno --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 32 --- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/mtk-vcodec/mtk_vcodec_

[PATCH v12, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces

2021-12-01 Thread Yunfei Dong
Generalizes power and clock on/off interfaces to support different hardware. Signed-off-by: Yunfei Dong --- fix comments from Reviewed-by: AngeloGioacchino Del Regno --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 +- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/m

[PATCH v12, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface

2021-12-01 Thread Yunfei Dong
Vdec and venc can use the same function to wake up interrupt event. Reviewed-by: Tzung-Bi Shih Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steve Cho Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 + drivers/media/platform/mtk-vcodec

[PATCH v12, 07/19] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings

2021-12-01 Thread Yunfei Dong
Separate decoder and encoder document for the dts are big difference. Reviewed-by: Rob Herring Signed-off-by: Yunfei Dong --- .../media/mediatek,vcodec-decoder.yaml| 176 + .../media/mediatek,vcodec-encoder.yaml| 187 ++ .../bindings/media/mediatek

[PATCH v12, 08/19] media: mtk-vcodec: Use pure single core for MT8183

2021-12-01 Thread Yunfei Dong
Separates different architecture for hardware: pure_sin_core and lat_sin_core. MT8183 is pure single core. Uses .hw_arch to distinguish. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_stateful.c | 1 + .../platform/mtk-vcodec

[PATCH v12, 06/19] media: mtk-vcodec: Add to support multi hardware decode

2021-12-01 Thread Yunfei Dong
There are more than two hardwares for decoder: LAT0, LAT1 and CORE. In order to manage these hardwares, register each hardware as independent platform device for the larbs are different. Each hardware module controls its own information which includes interrupt/power/ clocks/registers. Calling o

[PATCH v12, 03/19] media: mtk-vcodec: Refactor vcodec pm interface

2021-12-01 Thread Yunfei Dong
Using the needed params for pm init/release function and remove unused param mtkdev in 'struct mtk_vcodec_pm'. Reviewed-by: Tzung-Bi Shih Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steve Cho Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 ++--- ..

[PATCH v12, 05/19] media: mtk-vcodec: Support MT8192

2021-12-01 Thread Yunfei Dong
From: Yunfei Dong Adds MT8192's compatible "mediatek,mt8192-vcodec-dec". Adds MT8192's device private data mtk_lat_sig_core_pdata. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Yunfei Dong --- .../media/platform/mtk-vcodec/mtk_vcodec_dec.h | 1 + .../platform/mtk-vcodec/mtk_vcode

[PATCH v12, 04/19] media: mtk-vcodec: export decoder pm functions

2021-12-01 Thread Yunfei Dong
When mtk vcodec decoder is build as a module, we need to export mtk-vcodec-dec pm functions to make them visible by the other components. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Benjamin Gaignard Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c

[PATCH v12, 00/19] Support multi hardware decode using of_platform_populate

2021-12-01 Thread Yunfei Dong
This series adds support for multi hardware decode into mtk-vcodec, by first adding use of_platform_populate to manage each hardware information: interrupt, clock, register bases and power. Secondly add core work queue to deal with core hardware message, at the same time, add msg queue for diffe

[PATCH v12, 01/19] media: mtk-vcodec: Get numbers of register bases from DT

2021-12-01 Thread Yunfei Dong
Different platforms may have different numbers of register bases. Gets the numbers of register bases from dts (sizeof(u32) * 4 bytes for each). Reviewed-by: Tzung-Bi Shih Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 37 ++- 1 file changed, 28 ins

Re: [PATCH v11, 01/19] media: mtk-vcodec: Get numbers of register bases from DT

2021-12-01 Thread yunfei.d...@mediatek.com
Hi Steve, Thanks for your suggestion.On Wed, 2021-12-01 at 15:36 -0800, Steve Cho wrote: > LGTM with few nits. > > Thanks,Steve > > On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong > wrote: > > Different platform may has different numbers of register bases. > > Gets the > > > > numbers of register

Re: [PATCH v11, 01/19] media: mtk-vcodec: Get numbers of register bases from DT

2021-12-01 Thread yunfei.d...@mediatek.com
Hi Benjamin, Thanks for your suggestion. On Tue, 2021-11-30 at 14:20 +0100, Benjamin Gaignard wrote: > Le 29/11/2021 à 04:41, Yunfei Dong a écrit : > > Different platform may has different numbers of register bases. > > Gets the > > numbers of register bases from DT (sizeof(u32) * 4 bytes for each

Re: [PATCH v4 1/6] drm: move the buddy allocator from i915 into common drm

2021-12-01 Thread kernel test robot
Hi Arunpravin, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.16-rc3] [cannot apply to drm/drm-next drm-tip/drm-tip next-20211201] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

linux-next: manual merge of the drm-intel-gt tree with the drm-intel tree

2021-12-01 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel-gt tree got a conflict in: drivers/gpu/drm/i915/display/intel_fbc.c between commit: d06188234427 ("drm/i915/fbc: s/dev_priv/i915/") from the drm-intel tree and commit: cca084692394 ("drm/i915: Use per device iommu check") from the drm-i

[PATCH] drm/i915: replace X86_FEATURE_PAT with pat_enabled()

2021-12-01 Thread Lucas De Marchi
PAT can be disabled on boot with "nopat" in the command line. Replace one x86-ism with another, which is slightly more correct to prepare for supporting other architectures. Cc: Matt Roper Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 8 drivers/gpu/drm

Re: [PATCH v11, 03/19] media: mtk-vcodec: Refactor vcodec pm interface

2021-12-01 Thread Steve Cho
Reviewed-by: Steve Cho On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > Using the needed param for pm init/release function and remove unused > param mtkdev in 'struct mtk_vcodec_pm'. nit: How about s/needed param/needed params |pdev| and |pm|/ ? > Reviewed-by: Tzung-Bi Shih > Reviewed

Re: [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions

2021-12-01 Thread Steve Cho
Reviewed-by: Steve Cho On Wed, Dec 1, 2021 at 4:09 AM AngeloGioacchino Del Regno wrote: > > Il 29/11/21 04:41, Yunfei Dong ha scritto: > > Register each hardware as platform device, need to call pm functions > > to open/close power and clock from module mtk-vcodec-dec, export these > > functions

Re: [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface

2021-12-01 Thread Steve Cho
Reviewed-by: Steve Cho On Wed, Dec 1, 2021 at 3:55 PM Steve Cho wrote: > > LGTM. > > On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > > > Vdec and venc can use the same function to wake up interrupt event. > > > > Reviewed-by: Tzung-Bi Shih > > Reviewed-by: AngeloGioacchino Del Regno >

Re: [PATCH v11, 05/19] media: mtk-vcodec: Support MT8192

2021-12-01 Thread Steve Cho
Reviewed-by: Steve Cho On Wed, Dec 1, 2021 at 4:10 AM AngeloGioacchino Del Regno wrote: > > Il 29/11/21 04:41, Yunfei Dong ha scritto: > > From: Yunfei Dong > > > > Adds MT8192's compatible "mediatek,mt8192-vcodec-dec". > > Adds MT8192's device private data mtk_lat_sig_core_pdata. > > > > Signe

Re: [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface

2021-12-01 Thread Steve Cho
LGTM. On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > Vdec and venc can use the same function to wake up interrupt event. > > Reviewed-by: Tzung-Bi Shih > Reviewed-by: AngeloGioacchino Del Regno > > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_dr

Re: [PATCH v2 04/20] dt-bindings: host1x: Document optional HDMI sound-dai-cells

2021-12-01 Thread Rob Herring
On Fri, 26 Nov 2021 19:17:51 +0300, Dmitry Osipenko wrote: > Document new optional sound-dai-cells property of HDMI node. This node will > be used as endpoint of HDMI sound DAI graph. > > Signed-off-by: Dmitry Osipenko > --- > .../devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt | 1

Re: [PATCH v2 03/20] ASoC: dt-bindings: tegra20-i2s: Document new nvidia,fixed-parent-rate property

2021-12-01 Thread Rob Herring
On Fri, 26 Nov 2021 19:17:50 +0300, Dmitry Osipenko wrote: > Document new nvidia,fixed-parent-rate property which instructs that this > board wants parent clock to stay at a fixed rate. It allows to prevent > conflicts between audio components that share same parent PLL. For > instance, this proper

Re: [PATCH v2 02/20] ASoC: dt-bindings: tegra20-i2s: Convert to schema

2021-12-01 Thread Rob Herring
On Fri, 26 Nov 2021 19:17:49 +0300, Dmitry Osipenko wrote: > Convert NVIDIA Tegra20 I2S binding to schema. > > Signed-off-by: Dmitry Osipenko > --- > .../bindings/sound/nvidia,tegra20-i2s.txt | 30 > .../bindings/sound/nvidia,tegra20-i2s.yaml| 70 +++ > 2 files c

Re: [PATCH v2 01/20] ASoC: dt-bindings: Add binding for Tegra20 S/PDIF

2021-12-01 Thread Rob Herring
On Fri, Nov 26, 2021 at 07:17:48PM +0300, Dmitry Osipenko wrote: > Add device-tree binding for Tegra20 S/PDIF controller. > > Signed-off-by: Dmitry Osipenko > --- > .../bindings/sound/nvidia,tegra20-spdif.yaml | 85 +++ > 1 file changed, 85 insertions(+) > create mode 100644 >

[pull] amdgpu, amdkfd drm-fixes-5.16

2021-12-01 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.16. The following changes since commit d58071a8a76d779eedab38033ae4c821c30295a5: Linux 5.16-rc3 (2021-11-28 14:09:19 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.16-2021-12-01 for you to fe

[PATCH v2 4/4] drm/msm/dpu: fix CDP setup to account for multirect index

2021-12-01 Thread Dmitry Baryshkov
Client driven prefetch (CDP) is properly setup only for SSPP REC0 currently. Enable client driven prefetch also for SSPP REC1. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 12 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 4 +++- drivers/gpu/drm

[PATCH v2 3/4] drm/msm/dpu: simplify DPU_SSPP features checks

2021-12-01 Thread Dmitry Baryshkov
Add DPU_SSPP_CSC_ANY denoting any CSC block. As we are at it, rewrite DPU_SSPP_SCALER (any scaler) to use BIT(x) instead of hand-coded bitshifts. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 16 +++- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c |

[PATCH v2 2/4] drm/msm/dpu: drop pe argument from _dpu_hw_sspp_setup_scaler3

2021-12-01 Thread Dmitry Baryshkov
The _dpu_hw_sspp_setup_scaler3 (hw_sspp->setup_scaler) does not use pe argument. Let's remove it while we are cleaning scaled configuration. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 2 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 -- drivers/gpu/drm

[PATCH v2 1/4] drm/msm/dpu: drop scaler config from plane state

2021-12-01 Thread Dmitry Baryshkov
Scaler and pixel_ext configuration does not contain a long living state, it is used only during plane update, so remove these two fiels from dpu_plane_state and allocate them on stack. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 59 ++- dri

[PATCH v2 0/4] drm/msm/dpu: cleanup plane state

2021-12-01 Thread Dmitry Baryshkov
This is a cleanup part of the DPU multirect patchset [1], split away to ease review and merging per Abhinav's request. Changes in v2: - Drop patches that were accepted - Removed pe argument from _dpu_hw_sspp_setup_scaler3 - Add CDP setup and DPU_SSPP features checks patches that were left from the

[PATCH v1 8/8] drm/msm/dpu: move SSPP debugfs support from plane to SSPP code

2021-12-01 Thread Dmitry Baryshkov
We are preparing to change DPU plane implementation. Move SSPP debugfs code from dpu_plane.c to dpu_hw_sspp.c, where it belongs. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 67 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 4 + drivers/gpu

[PATCH v1 7/8] drm/msm/dpu: simplify DPU's regset32 code

2021-12-01 Thread Dmitry Baryshkov
Squash dpu_debugfs_setup_regset32() into dpu_debugfs_create_regset32(). it makes little sense to have separate function to just setup the structure. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 32 --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h |

[PATCH v1 6/8] drm/msm/dpu: stop manually removing debugfs files for the DPU CRTC

2021-12-01 Thread Dmitry Baryshkov
DRM code handles removing all debugfs recursively. Drop CRTC-specific code to perform that. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 3 --- 2 files changed, 4 insertions(+), 14 deletions(-) dif

[PATCH v1 5/8] drm/msm/dpu: stop manually removing debugfs files for the DPU plane

2021-12-01 Thread Dmitry Baryshkov
DRM code handles removing all debugfs recursively. Drop plane-specific code to perform that. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 28 --- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/d

[PATCH v1 4/8] drm/msm/dpu: drop plane's default_scaling debugfs file

2021-12-01 Thread Dmitry Baryshkov
Proper support for the 'default_scaling' debugfs file was removed during DPU driver pre-merge cleanup. Remove leftover file. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_pla

[PATCH v1 3/8] drm/msm/dpu: make danger_status/safe_status readable

2021-12-01 Thread Dmitry Baryshkov
Change \t to \n in the print format to stop putting all SSPP status in a single line. Splitting it to one SSPP per line is much more readable. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/g

[PATCH v1 2/8] drm/msm/dpu: fix safe status debugfs file

2021-12-01 Thread Dmitry Baryshkov
Make safe_status debugfs fs file actually return safe status rather than danger status data. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v1 0/8] drm/msm/dpu: cleanup debugfs code

2021-12-01 Thread Dmitry Baryshkov
This patchset provides a partial rework/cleanup/fixup of debugfs code in DPU driver. It started as a single patch removing (and then just moving) SSPP debugfs code from the plane (as planes are going to be less connected with SSPP blocks soon). However the more I touched this code, the more patches

[PATCH v1 1/8] drm/msm/dpu: move disable_danger out of plane subdir

2021-12-01 Thread Dmitry Baryshkov
The disable_danger debugfs file is not related to a single plane. Instead it is used by all registered planes. Move it from plane subtree to the global subtree next to danger_status and safe_status files, so that the new file supplements them. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/

Re: [PATCH 4/6] dt-bindings: display: sitronix,st7735r: Add initialization properties

2021-12-01 Thread Rob Herring
On Wed, Nov 24, 2021 at 04:07:55PM +0100, Noralf Trønnes wrote: > Add initialization properties that are commonly used to initialize the > controller for a specific display panel. It is common for displays to have > a datasheet listing the necessary controller settings or some example code > doing

Re: [PATCH v3 2/2] drm: rcar-du: Add R-Car DSI driver

2021-12-01 Thread Laurent Pinchart
Hi Kieran, On Wed, Dec 01, 2021 at 10:40:07AM +, Kieran Bingham wrote: > Quoting Laurent Pinchart (2021-12-01 05:24:06) > > From: LUU HOAI > > > > The driver supports the MIPI DSI/CSI-2 TX encoder found in the R-Car V3U > > SoC. It currently supports DSI mode only. > > > > Signed-off-by: LU

[PATCH v3.1 2/2] drm: rcar-du: Add R-Car DSI driver

2021-12-01 Thread Laurent Pinchart
From: LUU HOAI The driver supports the MIPI DSI/CSI-2 TX encoder found in the R-Car V3U SoC. It currently supports DSI mode only. Signed-off-by: LUU HOAI Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Tested-by: Kieran Bingham Acked-by: Sam Ravnborg --- Changes since v3: - Use

Re: [PATCH 3/6] dt-bindings: display: sitronix,st7735r: Remove spi-max-frequency limit

2021-12-01 Thread Rob Herring
On Wed, 24 Nov 2021 16:07:54 +0100, Noralf Trønnes wrote: > The datasheet lists the minimum Serial clock cycle (Write) as 66ns which is > 15MHz. Mostly it can do much better than that and is in fact often run at > 32MHz. With a clever driver that runs configuration commands at a low speed > and onl

Re: [PATCH 2/6] dt-bindings: display: sitronix,st7735r: Make reset-gpios optional

2021-12-01 Thread Rob Herring
On Wed, 24 Nov 2021 16:07:53 +0100, Noralf Trønnes wrote: > There are other ways than using a gpio to reset the controller so make > this property optional. > > Signed-off-by: Noralf Trønnes > --- > Documentation/devicetree/bindings/display/sitronix,st7735r.yaml | 1 - > 1 file changed, 1 deleti

Re: [PATCH 1/6] dt-bindings: display: sitronix,st7735r: Fix backlight in example

2021-12-01 Thread Rob Herring
On Wed, 24 Nov 2021 16:07:52 +0100, Noralf Trønnes wrote: > The backlight property was lost during conversion to yaml in commit > abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema"). > Put it back. > > Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert

Re: [PATCH] drm/komeda: Fix an undefined behavior bug in komeda_plane_add()

2021-12-01 Thread Liviu Dudau
On Wed, Dec 01, 2021 at 03:44:03PM +, Steven Price wrote: > On 30/11/2021 14:25, Zhou Qingyang wrote: > > In komeda_plane_add(), komeda_get_layer_fourcc_list() is assigned to > > formats and used in drm_universal_plane_init(). > > drm_universal_plane_init() passes formats to > > __drm_universal

[PATCH v2 2/2] staging: fbtft: sh1106: use new macro FBTFT_REGISTER_SPI_DRIVER

2021-12-01 Thread Heiner Kallweit
Make fb_sh1106 the first user of new macro FBTFT_REGISTER_SPI_DRIVER. In addition the MODULE_ALIASes can be removed. Module auto-loading was successfully tested with a SH1106-based OLED module connected to an Odroid C2. Signed-off-by: Heiner Kallweit --- drivers/staging/fbtft/fb_sh1106.c | 7 +--

[PATCH v2 1/2] staging: fbtft: add macro FBTFT_REGISTER_SPI_DRIVER

2021-12-01 Thread Heiner Kallweit
After 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible") we need to add spi id_tables. Changing existing macro FBTFT_REGISTER_DRIVER would have meant to change arguments and therefore adjust all fbtft drivers. This patch adds a new and simplified macro FBTFT_REGISTER_SPI_DR

[PATCH v2 0/2] staging: fbtft: add and use macro FBTFT_REGISTER_SPI_DRIVER

2021-12-01 Thread Heiner Kallweit
After 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible") we need to add spi id_tables. Changing existing macro FBTFT_REGISTER_DRIVER would have meant to change arguments and therefore adjust all fbtft drivers. This series adds a new and simplified macro FBTFT_REGISTER_SPI_D

Re: [PATCH v4 4/4] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2021-12-01 Thread khsieh
On 2021-11-24 23:32, Dmitry Baryshkov wrote: On 04/05/2021 07:35, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-04-21 16:37:38) Add checking aux read/write status at both dp_link_parse_sink_count() and dp_link_parse_sink_status_filed() to avoid long timeout delay if s/filed/field/ dp aux r

[PATCH] drm/msm: Initialize MDSS irq domain at probe time

2021-12-01 Thread Dmitry Baryshkov
Since commit 8f59ee9a570c ("drm/msm/dsi: Adjust probe order"), the DSI host gets initialized earlier, but this caused unability to probe the entire stack of components because they all depend on interrupts coming from the main `mdss` node (mdp5, or dpu1). To fix this issue, move mdss device initia

Re: [PATCH] drm/radeon/radeon_connectors: Fix a NULL pointer dereference in radeon_fp_native_mode()

2021-12-01 Thread Alex Deucher
On Tue, Nov 30, 2021 at 9:49 AM Zhou Qingyang wrote: > > In radeon_fp_native_mode(), the return value of drm_mode_duplicate() is > assigned to mode and there is a dereference of it in > radeon_fp_native_mode(), which could lead to a NULL pointer > dereference on failure of drm_mode_duplicate(). >

Re: [PATCH] fix a NULL pointer dereference in amdgpu_connector_lcd_native_mode()

2021-12-01 Thread Alex Deucher
On Tue, Nov 30, 2021 at 6:24 AM Zhou Qingyang wrote: > > In amdgpu_connector_lcd_native_mode(), the return value of > drm_mode_duplicate() is assigned to mode, and there is a dereference > of it in amdgpu_connector_lcd_native_mode(), which will lead to a NULL > pointer dereference on failure of dr

Re: [PATCH v2 2/3] drm/etnaviv: add pci device driver support

2021-12-01 Thread Lucas Stach
Hi Sui, Am Mittwoch, dem 01.12.2021 um 19:35 +0800 schrieb Sui Jingfeng: > From: suijingfeng > > v2: update commits and provide more material. > > There is a Vivante GC1000 V5037 in LS2K1000 and LS7A1000, > the gpu in those chip is a PCI device not platform one. > This GPU have 2D and 3

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Mark Brown
On Wed, Dec 01, 2021 at 05:53:03PM +0100, H. Nikolaus Schaller wrote: > > Am 01.12.2021 um 16:10 schrieb Mark Brown : > > Again, if the supply can be physically absent that is a sensible use > > case but that means completely absent, not just not software > > controllable. We can represent fixed

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread H. Nikolaus Schaller
Hi Mark, > Am 01.12.2021 um 16:10 schrieb Mark Brown : > > On Wed, Dec 01, 2021 at 03:33:24PM +0100, H. Nikolaus Schaller wrote: >>> Am 01.12.2021 um 15:03 schrieb Paul Cercueil : > >>> Please make it mandatory in DTS then, and use devm_regulator_get() in the >>> driver. > >> Well, I just won

[PATCH v4 5/6] drm/amdgpu: move vram inline functions into a header

2021-12-01 Thread Arunpravin
Move shared vram inline functions and structs into a header file Signed-off-by: Arunpravin --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 51 1 file changed, 51 insertions(+) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h diff --git a/drivers/gpu/drm/a

[PATCH v4 6/6] drm/amdgpu: add drm buddy support to amdgpu

2021-12-01 Thread Arunpravin
- Remove drm_mm references and replace with drm buddy functionalities - Add res cursor support for drm buddy v2(Matthew Auld): - replace spinlock with mutex as we call kmem_cache_zalloc (..., GFP_KERNEL) in drm_buddy_alloc() function - lock drm_buddy_block_trim() function as it calls

[PATCH v4 4/6] drm: implement a method to free unused pages

2021-12-01 Thread Arunpravin
On contiguous allocation, we round up the size to the *next* power of 2, implement a function to free the unused pages after the newly allocate block. v2(Matthew Auld): - replace function name 'drm_buddy_free_unused_pages' with drm_buddy_block_trim - replace input argument name 'actual_siz

[PATCH v4 1/6] drm: move the buddy allocator from i915 into common drm

2021-12-01 Thread Arunpravin
Move the base i915 buddy allocator code into drm - Move i915_buddy.h to include/drm - Move i915_buddy.c to drm root folder - Rename "i915" string with "drm" string wherever applicable - Rename "I915" string with "DRM" string wherever applicable - Fix header file dependencies - Fix alignment issues

[PATCH v4 3/6] drm: implement top-down allocation method

2021-12-01 Thread Arunpravin
Implemented a function which walk through the order list, compares the offset and returns the maximum offset block, this method is unpredictable in obtaining the high range address blocks which depends on allocation and deallocation. for instance, if driver requests address at a low specific range,

[PATCH v4 2/6] drm: improve drm_buddy_alloc function

2021-12-01 Thread Arunpravin
- Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which allocates the requested power-of-two block comply with range limitations - Moved order computation and memory alignment logic from i915 drive

Re: [PATCH 09/12] arm64: dts: rockchip: rk356x: Add HDMI nodes

2021-12-01 Thread Sascha Hauer
On Wed, Nov 17, 2021 at 09:13:33AM -0600, Rob Herring wrote: > On Wed, Nov 17, 2021 at 8:34 AM Sascha Hauer wrote: > > > > Add support for the HDMI port found on RK3568. > > > > Signed-off-by: Sascha Hauer > > --- > > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 65 > > 1

Re: [PATCH v2] drm/gma500/cdv: Fix a wild pointer dereference in cdv_intel_dp_get_modes()

2021-12-01 Thread Patrik Jakobsson
On Wed, Dec 1, 2021 at 4:29 PM Zhou Qingyang wrote: > > In cdv_intel_dp_get_modes(), the third return value of > drm_mode_duplicate() is assigned to mode and used in > drm_mode_probed_add(). drm_mode_probed_add() passes mode->head to > list_add_tail(). list_add_tail() will further call __list_add(

Re: [PATCH] drm/komeda: Fix an undefined behavior bug in komeda_plane_add()

2021-12-01 Thread Steven Price
On 30/11/2021 14:25, Zhou Qingyang wrote: > In komeda_plane_add(), komeda_get_layer_fourcc_list() is assigned to > formats and used in drm_universal_plane_init(). > drm_universal_plane_init() passes formats to > __drm_universal_plane_init(). __drm_universal_plane_init() further > passes formats to

Re: [PATCH v4 3/4] arm64: dts: qcom: sc7280: add edp display dt nodes

2021-12-01 Thread Bjorn Andersson
On Mon 22 Nov 05:26 CST 2021, Sankeerth Billakanti wrote: > Add edp controller and phy DT nodes for sc7280. > > Signed-off-by: Krishna Manikandan If Krishna authored the patch (he certified its origin first), then he should be From: as well. > Reviewed-by: Stephen Boyd > Signed-off-by: Sankee

[PATCH 3/3] drm/ast: Fail if connector initialization fails

2021-12-01 Thread Thomas Zimmermann
Update the connector code to fail if the connector could not be initialized. The current code just ignored the error and failed later when the connector was supposed to be used. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 13 - 1 file changed, 8 insertions(+

[PATCH 0/3] ast: Fix I2C corner cases wrt init/cleanup

2021-12-01 Thread Thomas Zimmermann
The VGA connector in ast is supposed to work without I2C. Currently, this isn't correctly implemented in several places. Fix this. Also add managed cleanup of the I2C code, and fail if the connector setup fail. Tested on AST2100 hardware. Thomas Zimmermann (3): drm/ast: Handle failed I2C initia

[PATCH 2/3] drm/ast: Convert I2C code to managed cleanup

2021-12-01 Thread Thomas Zimmermann
Release the I2C adapter as part of the DRM device cleanup. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 36 +++--- 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c

[PATCH 1/3] drm/ast: Handle failed I2C initialization gracefully

2021-12-01 Thread Thomas Zimmermann
I2C initialization is allowed to fail. In this case, create a connector without DDC adapter. The current code would dereference a NULL pointer. Reading the modes from the connector is supposed to work without I2C adapter. Add the respective test. Signed-off-by: Thomas Zimmermann --- drivers/gpu

Re: [PATCH v4 2/4] arm64: dts: qcom: sc7280: Add DSI display nodes

2021-12-01 Thread Bjorn Andersson
On Mon 22 Nov 05:26 CST 2021, Sankeerth Billakanti wrote: > From: Krishna Manikandan > > Add DSI controller and PHY nodes for sc7280. > > Signed-off-by: Rajeev Nandan > Signed-off-by: Krishna Manikandan > Reviewed-by: Matthias Kaehlcke > Reviewed-by: Stephen Boyd > Signed-off-by: Sankeerth

Re: [PATCH v4 1/4] arm64: dts: qcom: sc7280: add display dt nodes

2021-12-01 Thread Bjorn Andersson
On Mon 22 Nov 05:26 CST 2021, Sankeerth Billakanti wrote: > From: Krishna Manikandan > > Add mdss and mdp DT nodes for sc7280. > > Signed-off-by: Krishna Manikandan > Reported-by: kernel test robot Sorry, missed this one before sending my reply. "kernel test robot" did not report the lack o

Re: [PATCH v4 1/4] arm64: dts: qcom: sc7280: add display dt nodes

2021-12-01 Thread Bjorn Andersson
On Mon 22 Nov 05:26 CST 2021, Sankeerth Billakanti wrote: > From: Krishna Manikandan > > Add mdss and mdp DT nodes for sc7280. > > Signed-off-by: Krishna Manikandan > Reported-by: kernel test robot > Reviewed-by: Stephen Boyd > Reported-by: kernel test robot > Signed-off-by: Sankeerth Billa

Re: [PATCH v4 4/4] arm64: dts: qcom: sc7280: Add Display Port node

2021-12-01 Thread Bjorn Andersson
On Mon 22 Nov 05:29 CST 2021, Sankeerth Billakanti wrote: > From: Kuogee Hsieh > > Signed-off-by: Kuogee Hsieh > Reviewed-by: Stephen Boyd > Signed-off-by: Sankeerth Billakanti Can you please update this to make From: and Signed-off-by: match. Also I don't know how you prepared this patch

Re: [PATCH] drm: Return error codes from struct drm_driver.gem_create_object

2021-12-01 Thread Steven Price
On 30/11/2021 09:52, Thomas Zimmermann wrote: > GEM helper libraries use struct drm_driver.gem_create_object to let > drivers override GEM object allocation. On failure, the call returns > NULL. > > Change the semantics to make the calls return a pointer-encoded error. > This aligns the callback w

Re: [PATCH v5] drm/radeon/radeon_kms: Fix a NULL pointer dereference in radeon_driver_open_kms()

2021-12-01 Thread Christian König
Am 01.12.21 um 16:13 schrieb Zhou Qingyang: In radeon_driver_open_kms(), radeon_vm_bo_add() is assigned to vm->ib_bo_va and passes and used in radeon_vm_bo_set_addr(). In radeon_vm_bo_set_addr(), there is a dereference of vm->ib_bo_va, which could lead to a NULL pointer dereference on failure of

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Mark Brown
On Wed, Dec 01, 2021 at 03:33:24PM +0100, H. Nikolaus Schaller wrote: > > Am 01.12.2021 um 15:03 schrieb Paul Cercueil : > > Please make it mandatory in DTS then, and use devm_regulator_get() in the > > driver. > Well, I just wonder why the elegant devm_regulator_get_optional() exists at > all

Re: [PATCH] drm/i915: Force ww lock for i915_gem_object_ggtt_pin_ww, v2.

2021-12-01 Thread Matthew Auld
On Tue, 30 Nov 2021 at 09:21, Maarten Lankhorst wrote: > > We will need the lock to unbind the vma, and wait for bind to complete. > Remove the special casing for the !ww path, and force ww locking for all. > > Changes since v1: > - Pass err to for_i915_gem_ww handling for -EDEADLK handling. > > S

Re: [PATCH] drm: Return error codes from struct drm_driver.gem_create_object

2021-12-01 Thread Maxime Ripard
On Tue, Nov 30, 2021 at 10:52:55AM +0100, Thomas Zimmermann wrote: > GEM helper libraries use struct drm_driver.gem_create_object to let > drivers override GEM object allocation. On failure, the call returns > NULL. > > Change the semantics to make the calls return a pointer-encoded error. > This

Re: [PATCH 0/6] drm/tiny/st7735r: Match up with staging/fbtft driver

2021-12-01 Thread Maxime Ripard
Hi Noralf, On Tue, Nov 30, 2021 at 03:30:11PM +0100, Noralf Trønnes wrote: > Den 29.11.2021 10.39, skrev Maxime Ripard: > > On Wed, Nov 24, 2021 at 04:03:07PM -0600, David Lechner wrote: > >> On 11/24/21 9:07 AM, Noralf Trønnes wrote: > > I agree that it doesn't really fit in the DT either though.

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread H. Nikolaus Schaller
Hi Paul, > Am 01.12.2021 um 15:03 schrieb Paul Cercueil : > > Hi Nikolaus, Mark, > > Le mer., déc. 1 2021 at 14:51:51 +0100, H. Nikolaus Schaller > a écrit : >> Hi, >>> Am 01.12.2021 um 14:39 schrieb Mark Brown : >>> On Wed, Dec 01, 2021 at 01:02:45PM +, Paul Cercueil wrote: Le mar.,

Re: [PATCH v2 3/3] drm/etnaviv: use a 32 bit mask as coherent DMA mask

2021-12-01 Thread Robin Murphy
On 2021-12-01 13:41, Lucas Stach wrote: Hi Robin, Am Mittwoch, dem 01.12.2021 um 12:50 + schrieb Robin Murphy: Sorry I missed this earlier... On 2021-09-07 17:49, Michael Walle wrote: The STLB and the first command buffer (which is used to set up the TLBs) has a 32 bit size restriction in

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Paul Cercueil
Hi Nikolaus, Mark, Le mer., déc. 1 2021 at 14:51:51 +0100, H. Nikolaus Schaller a écrit : Hi, Am 01.12.2021 um 14:39 schrieb Mark Brown : On Wed, Dec 01, 2021 at 01:02:45PM +, Paul Cercueil wrote: Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller + regulator = d

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread H. Nikolaus Schaller
Hi, > Am 01.12.2021 um 14:39 schrieb Mark Brown : > > On Wed, Dec 01, 2021 at 01:02:45PM +, Paul Cercueil wrote: >> Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller > >>> + regulator = devm_regulator_get_optional(&pdev->dev, "hdmi-5v"); >>> + if (IS_ERR(regulator)) { >>> +

Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-12-01 Thread Mark Brown
On Wed, Dec 01, 2021 at 01:02:45PM +, Paul Cercueil wrote: > Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller > > + regulator = devm_regulator_get_optional(&pdev->dev, "hdmi-5v"); > > + if (IS_ERR(regulator)) { > > + ret = PTR_ERR(regulator); Why is this using _opti

  1   2   >