[PATCH] drm/amd/display: Fix warning comparing pointer to 0

2021-12-15 Thread Jiapeng Chong
Fix the following coccicheck warning: ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c:744:35-36: WARNING comparing pointer to 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c | 2 +- 1 file changed, 1

[PATCH] drm/amdgpu: fix mismatch warning between the prototype and function name

2021-12-15 Thread Huang Rui
Fix the typo to align with the prototype and function name. All warnings (new ones prefixed by >>): >> drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:631: warning: expecting prototype for amdgpu_fence_clear_job_fences(). Prototype was for amdgpu_fence_driver_clear_job_fences() instead Reported-by:

Re: [PATCH v3] drm/amdgpu: introduce new amdgpu_fence object to indicate the job embedded fence

2021-12-15 Thread Huang Rui
ang-Rui/drm-amdgpu-introduce-new-amdgpu_fence-object-to-indicate-the-job-embedded-fence/20211215-143731 > git checkout a47becf231b123760625c45242e89f5e5b5b4915 > # save the config file to linux build tree > mkdir build_dir > make W=1 O=build_dir ARCH=x86_64

[pull] amdgpu drm-fixes-5.16

2021-12-15 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.16. The following changes since commit 2585cf9dfaaddf00b069673f27bb3f8530e2039c: Linux 5.16-rc5 (2021-12-12 14:53:01 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.16-2021-12-15 for you to

回复: Re: [PATCH] drm/amdgpu: fixup bad vram size on gmc v8

2021-12-15 Thread 周宗敏
the problematic boards that I have tested is [AMD/ATI] Lexa PRO [Radeon RX 550/550X] ;  and the vbios version : 113-RXF9310-C09-BTWhen an exception occurs I can see the following changes in the values of vram size get from RREG32(mmCONFIG_MEMSIZE) ,it seems to have garbage in the upper 16 bits and

[PATCH -next] drm/msm: remove variable set but not used

2021-12-15 Thread Yang Li
The code that uses variable mdss has been removed, So the declaration and assignment of the variable can be removed. Eliminate the following clang warning: drivers/gpu/drm/msm/msm_drv.c:513:19: warning: variable 'mdss' set but not used [-Wunused-but-set-variable] Reported-by: Abaci Robot

[PATCH] drm/msm/dpu: add layer mixer register dump to dpu snapshot

2021-12-15 Thread Abhinav Kumar
Add the missing layer mixer register dump information to dpu snapshot to assist debugging. Reviewed-by: Dmitry Baryshkov Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c

[PATCH] drm/nouveau/acr: potential dereference of null pointer

2021-12-15 Thread Jiasheng Jiang
The return value of kmalloc() needs to be checked. To avoid use in memcpy() in case of the failure of alloc. Fixes: 22dcda45a3d1 ("drm/nouveau/acr: implement new subdev to replace "secure boot"") Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c | 3 +++ 1 file

Re: [PATCH v2 2/3] drm/msm/disp: Export helper for capturing snapshot

2021-12-15 Thread Dmitry Baryshkov
On 15/12/2021 20:45, Rob Clark wrote: From: Rob Clark We'll re-use this for debugfs. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/msm_disp_snapshot.c | 28 +++- drivers/gpu/drm/msm/disp/msm_disp_snapshot.h | 10 +++ 2 files changed, 31 insertions(+), 7

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Flag an error if an engine reset fails

2021-12-15 Thread Daniele Ceraolo Spurio
On 12/10/2021 10:58 PM, john.c.harri...@intel.com wrote: From: John Harrison If GuC encounters an error during engine reset, the i915 driver promotes to full GT reset. This includes an info message about why the reset is happening. However, that is not treated as a failure by any of the CI

Re: [Freedreno] [PATCH v1 8/8] drm/msm/dpu: move SSPP debugfs support from plane to SSPP code

2021-12-15 Thread Abhinav Kumar
On 12/9/2021 4:19 PM, Dmitry Baryshkov wrote: On 10/12/2021 01:27, Abhinav Kumar wrote: On 12/9/2021 2:18 PM, Abhinav Kumar wrote: On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote: We are preparing to change DPU plane implementation. Move SSPP debugfs code from dpu_plane.c to

Re: [Freedreno] [PATCH 2/2] drm/msm/dpu: add dpu_plane_atomic_print_state

2021-12-15 Thread Abhinav Kumar
On 12/15/2021 8:09 AM, Dmitry Baryshkov wrote: Implement plane's atomic_print_state() callback, printing DPU-specific plane state: blending stage, SSPP and multirect mode and index. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

Re: [Freedreno] [PATCH 1/2] drm/msm/dpu: add dpu_crtc_atomic_print_state

2021-12-15 Thread Abhinav Kumar
On 12/15/2021 8:09 AM, Dmitry Baryshkov wrote: Implement CRTC's atomic_print_state() callback, printing DPU-specific CRTC state (LM, CTL and DSPP ids). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 +++ 1 file

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Improve long running OCL w/a for GuC submission

2021-12-15 Thread Daniele Ceraolo Spurio
On 12/10/2021 10:58 PM, john.c.harri...@intel.com wrote: From: John Harrison A workaround was added to the driver to allow OpenCL workloads to run 'forever' by disabling pre-emption on the RCS engine for Gen12. It is not totally unbound as the heartbeat will kick in eventually and cause a

Re: [Intel-gfx] [PATCH] drm/i915/guc: Check for wedged before doing stuff

2021-12-15 Thread Matthew Brost
On Wed, Dec 15, 2021 at 02:45:56PM -0800, john.c.harri...@intel.com wrote: > From: John Harrison > > A fault injection probe test hit a BUG_ON in a GuC error path. It > showed that the GuC code could potentially attempt to do many things > when the device is actually wedged. So, add a check in

Re: [PATCH v3 0/2] Use "ref" clocks from firmware for DSI PLL VCO parent

2021-12-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-12-15 12:02:37) > On 14/12/2021 22:46, Marijn Suijten wrote: > > Hi all, > > > > On 2021-09-18 16:40:38, Marijn Suijten wrote: > >> On 2021-09-14 14:44:01, Stephen Boyd wrote: > >>> Quoting Marijn Suijten (2021-09-11 06:19:19) > All DSI PHY/PLL drivers were

Re: [PATCH 00/60] drm: Make all drivers to honour the nomodeset parameter

2021-12-15 Thread Javier Martinez Canillas
On 12/16/21 01:24, Laurent Pinchart wrote: > Hi Javier, > > On Thu, Dec 16, 2021 at 01:13:56AM +0100, Javier Martinez Canillas wrote: >> Hello Laurent, >> >> On 12/16/21 00:35, Laurent Pinchart wrote: >> >> [snip] >> I've built tested with 'make allmodconfig && make M=drivers/gpu/drm/',

Re: [PATCH 00/60] drm: Make all drivers to honour the nomodeset parameter

2021-12-15 Thread Laurent Pinchart
Hi Javier, On Thu, Dec 16, 2021 at 01:13:56AM +0100, Javier Martinez Canillas wrote: > Hello Laurent, > > On 12/16/21 00:35, Laurent Pinchart wrote: > > [snip] > > >> > >> I've built tested with 'make allmodconfig && make M=drivers/gpu/drm/', but > >> only booted in a few devices with and

Re: [PATCH 00/60] drm: Make all drivers to honour the nomodeset parameter

2021-12-15 Thread Javier Martinez Canillas
Hello Laurent, On 12/16/21 00:35, Laurent Pinchart wrote: [snip] >> >> I've built tested with 'make allmodconfig && make M=drivers/gpu/drm/', but >> only booted in a few devices with and without nomodeset in the cmdline. So >> testing and reviewing for all the drivers would be highly

Re: [PATCH 00/60] drm: Make all drivers to honour the nomodeset parameter

2021-12-15 Thread Laurent Pinchart
Hi Javier, Thank you for the patches. On Wed, Dec 15, 2021 at 01:59:08AM +0100, Javier Martinez Canillas wrote: > The nomodeset kernel command line parameter is used to prevent the KMS/DRM > drivers to be registered/probed. But only a few drivers implement support > for this parameter and most

Re: [PATCH 00/60] drm: Make all drivers to honour the nomodeset parameter

2021-12-15 Thread Javier Martinez Canillas
On 12/15/21 10:10, Thomas Zimmermann wrote: [snip] > > An extra pointer sounds indeed like over-engineering. If we take ast for > example, I'd just do something like this: > >static ast_pci_register_driver(struct pci_driver *pci) >{ > if (drm_firmware_drivers_only() &&

[PATCH] drm/i915/guc: Check for wedged before doing stuff

2021-12-15 Thread John . C . Harrison
From: John Harrison A fault injection probe test hit a BUG_ON in a GuC error path. It showed that the GuC code could potentially attempt to do many things when the device is actually wedged. So, add a check in to prevent that. Signed-off-by: John Harrison ---

Re: [Nouveau] [PATCH] drm/nouveau: wait for the exclusive fence after the shared ones v2

2021-12-15 Thread Ben Skeggs
On Tue, 14 Dec 2021 at 19:19, Christian König wrote: > > Am 11.12.21 um 10:59 schrieb Stefan Fritsch: > > On 09.12.21 11:23, Christian König wrote: > >> Always waiting for the exclusive fence resulted on some performance > >> regressions. So try to wait for the shared fences first, then the > >>

Re: (subset) [PATCH 00/10] dt-binding patches for sm6350

2021-12-15 Thread Bjorn Andersson
On Mon, 13 Dec 2021 09:26:01 +0100, Luca Weiss wrote: > This series adds compatibles to the dt-bindings documentation where it > was missed before. > > Finally, the last patch solves some further dtbs_check errors by > modifying the sm6350.dtsi to match the binding docs more closely. > > Please

Re: [PATCH] dt-bindings: display: bridge: document Toshiba TC358768 cells and panel node

2021-12-15 Thread Rob Herring
On Wed, 15 Dec 2021 16:27:12 +0100, David Heidelberg wrote: > Properties #address-cells and #size-cells are valid. > The bridge node can also contains panel node. > > Signed-off-by: David Heidelberg > --- > .../bindings/display/bridge/toshiba,tc358768.yaml | 10 ++ > 1 file

Re: [PATCH] drm/dp: Fix off-by-one in register cache size

2021-12-15 Thread Kees Cook
On Mon, Dec 13, 2021 at 06:18:49PM -0600, Gustavo A. R. Silva wrote: > On Fri, Dec 03, 2021 at 12:43:33AM -0800, Kees Cook wrote: > > The pcon_dsc_dpcd array holds 13 registers (0x92 through 0x9E). Fix the > > math to calculate the max size. Found from a -Warray-bounds build: > > > >

Re: [PATCH 11/60] drm/gud: Add support for the nomodeset kernel parameter

2021-12-15 Thread Javier Martinez Canillas
Hello Noralf, On 12/15/21 22:37, Noralf Trønnes wrote: > > > Den 15.12.2021 01.59, skrev Javier Martinez Canillas: >> According to disable Documentation/admin-guide/kernel-parameters.txt, this >> parameter can be used to disable kernel modesetting. >> >> DRM drivers will not perform

[PATCH 5/5] drm/stm: ltdc: add support of ycbcr pixel formats

2021-12-15 Thread Yannick Fertre
This patch adds the following YCbCr input pixel formats on the latest LTDC hardware version: 1 plane (co-planar) : YUYV, YVYU, UYVY, VYUY 2 planes (semi-planar): NV12, NV21 3 planes (full-planar): YU12=I420=DRM YUV420, YV12=DRM YVU420 Signed-off-by: Yannick Fertre ---

[PATCH 4/5] drm/stm: ltdc: add support of flexible pixel formats

2021-12-15 Thread Yannick Fertre
This feature allows the generation of any RGB pixel format. The list of supported formats is no longer linked to the register LXPFCR_PF, that the reason why a list of drm formats is defined for each display controller version. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 196

[PATCH 3/5] drm/stm: ltdc: add per plane update support

2021-12-15 Thread Yannick Fertre
Recent ltdc hardware versions offer the ability to update a plane independently of others planes. This is could be useful especially if a plane is assigned to another OS. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 26 +++--- drivers/gpu/drm/stm/ltdc.h |

[PATCH 2/5] drm/stm: ltdc: add YCbCr 422 output support

2021-12-15 Thread Yannick Fertre
LTDC 40100 hw version supports the YCbCr 422 output, reducing the output pins from 24 to 16. This feature is useful for some external devices like HDMI bridges. Both ITU-R BT.601 & ITU-R BT.709 are supported. It is also possible to choose the chrominance order between * Cb is output first (Y0Cb,

[PATCH 1/5] drm/stm: ltdc: switch to regmap

2021-12-15 Thread Yannick Fertre
Replace the legacy register access by regmap API. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 138 ++--- drivers/gpu/drm/stm/ltdc.h | 1 + 2 files changed, 68 insertions(+), 71 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c

[PATCH 0/5] drm/stm: new features to display controller

2021-12-15 Thread Yannick Fertre
Hello, List of new feature: * Replace the legacy register access by regmap API. * Support of YCbCr 422 output * Update layer shadow registers per plane. * Support of YCbCr output (planar, semiplanar & coplanar) These featues are available only with last hardware version of ltdc (0x401000) link to

Re: [PATCH 11/60] drm/gud: Add support for the nomodeset kernel parameter

2021-12-15 Thread Noralf Trønnes
Den 15.12.2021 01.59, skrev Javier Martinez Canillas: > According to disable Documentation/admin-guide/kernel-parameters.txt, this > parameter can be used to disable kernel modesetting. > > DRM drivers will not perform display-mode changes or accelerated rendering > and only the systewm system

Re: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

2021-12-15 Thread Ira Weiny
On Tue, Dec 14, 2021 at 08:09:29AM +0100, Christian König wrote: > Am 14.12.21 um 04:37 schrieb Ira Weiny: > > On Mon, Dec 13, 2021 at 09:37:32PM +0100, Christian König wrote: > > > Am 11.12.21 um 00:24 schrieb ira.we...@intel.com: > > > > From: Ira Weiny > > > > > > > > The default case leaves

[PATCH] drm/omapdrm: Remove a useless bitmap_clear() call

2021-12-15 Thread Christophe JAILLET
The 'tcm->bitmap' is kzalloc'ed just a few lines above, at the same time as 'tcm'. There is no need to initialize it another time here. Remove the useless bitmap_clear() call. Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/omapdrm/tcm-sita.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH v2 1/3] drm/msm/disp: Tweak display snapshot to match gpu snapshot

2021-12-15 Thread Dmitry Baryshkov
On Wed, 15 Dec 2021 at 23:09, Rob Clark wrote: > > On Wed, Dec 15, 2021 at 11:17 AM Dmitry Baryshkov > wrote: > > > > On Wed, 15 Dec 2021 at 20:49, Rob Clark wrote: > > > > > > From: Rob Clark > > > > > > Add UTS_RELEASE and show timestamp the same way for consistency. > > > > > >

Re: [PATCH v4 4/6] drm: implement a method to free unused pages

2021-12-15 Thread Arunpravin
On 14/12/21 12:10 am, Matthew Auld wrote: > On 01/12/2021 16:39, Arunpravin wrote: >> On contiguous allocation, we round up the size >> to the *next* power of 2, implement a function >> to free the unused pages after the newly allocate block. >> >> v2(Matthew Auld): >>- replace function

Re: [PATCH v4 2/6] drm: improve drm_buddy_alloc function

2021-12-15 Thread Arunpravin
On 14/12/21 12:29 am, Matthew Auld wrote: > On 09/12/2021 15:47, Paneer Selvam, Arunpravin wrote: >> [AMD Official Use Only] >> >> Hi Matthew, >> >> Ping on this? > > No new comments from me :) I guess just a question of what we should do > with the selftests, and then ofc at some point being

Re: [PATCH] drm/tilcdc: add const to of_device_id

2021-12-15 Thread kernel test robot
Hi Xiang, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v5.16-rc5 next-20211214] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in

Re: [PATCH] drm/amdgpu: fixup bad vram size on gmc v8

2021-12-15 Thread Alex Deucher
On Wed, Dec 15, 2021 at 10:31 AM Zongmin Zhou wrote: > > Some boards(like RX550) seem to have garbage in the upper > 16 bits of the vram size register. Check for > this and clamp the size properly. Fixes > boards reporting bogus amounts of vram. > > after add this patch,the maximum GPU VRAM

Re: [PATCH v6 5/7] drm/mediatek: dpi: Add dpintf support

2021-12-15 Thread Matthias Brugger
On 10/11/2021 14:06, Guillaume Ranquet wrote: From: Markus Schneider-Pargmann dpintf is the displayport interface hardware unit. This unit is similar to dpi and can reuse most of the code. This patch adds support for mt8195-dpintf to this dpi driver. Main differences are: - Some

Re: [PATCH 09/10] dt-bindings: simple-framebuffer: allow standalone compatible

2021-12-15 Thread Rob Herring
On Mon, 13 Dec 2021 09:26:10 +0100, Luca Weiss wrote: > Qualcomm platforms use "simple-framebuffer" without a more specific > compatible. Allow that in the binding doc. > > Signed-off-by: Luca Weiss > --- > .../bindings/display/simple-framebuffer.yaml | 12 +++- > 1 file

Re: [PATCH] drm/msm: drop dbgname argument from msm_ioremap*()

2021-12-15 Thread Rob Clark
On Wed, Dec 15, 2021 at 8:45 AM Dmitry Baryshkov wrote: > > Hi, > > On 09/12/2021 00:23, Rob Clark wrote: > > On Wed, Dec 8, 2021 at 10:01 AM Dmitry Baryshkov > > wrote: > >> > >> msm_ioremap() functions take additional argument dbgname used to output > >> single debug line telling IO range.

Re: [PATCH v2 1/3] drm/msm/disp: Tweak display snapshot to match gpu snapshot

2021-12-15 Thread Rob Clark
On Wed, Dec 15, 2021 at 11:17 AM Dmitry Baryshkov wrote: > > On Wed, 15 Dec 2021 at 20:49, Rob Clark wrote: > > > > From: Rob Clark > > > > Add UTS_RELEASE and show timestamp the same way for consistency. > > > > Signed-off-by: Rob Clark > > Reviewed-by: Dmitry Baryshkov > > > --- > >

Re: [PATCH] drm/msm: Don't use autosuspend for display

2021-12-15 Thread Rob Clark
On Wed, Dec 15, 2021 at 11:10 AM Stephen Boyd wrote: > > Quoting Rob Clark (2021-12-15 09:59:02) > > From: Rob Clark > > > > No functional change, as we only actually enable autosuspend for the GPU > > device. But lets not encourage thinking that autosuspend is a good idea > > for anything

Re: [PATCH v3 0/2] Use "ref" clocks from firmware for DSI PLL VCO parent

2021-12-15 Thread Dmitry Baryshkov
On 14/12/2021 22:46, Marijn Suijten wrote: Hi all, On 2021-09-18 16:40:38, Marijn Suijten wrote: On 2021-09-14 14:44:01, Stephen Boyd wrote: Quoting Marijn Suijten (2021-09-11 06:19:19) All DSI PHY/PLL drivers were referencing their VCO parent clock by a global name, most of which don't

[PATCH] drm/vmwgfx: Fix possible usage of an uninitialized variable

2021-12-15 Thread Zack Rusin
From: Zack Rusin vmw_user_bo_lookup can fail to lookup user buffers, especially because the buffer handles come from the userspace. The return value has to be checked before the buffers are put back. This was spotted by Dan's Smatch statick checker: drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:574

Re: [PATCH v4 00/22] Support HDMI audio on NVIDIA Tegra20

2021-12-15 Thread Mark Brown
On Wed, Dec 15, 2021 at 10:19:07PM +0300, Dmitry Osipenko wrote: > 15.12.2021 21:57, Mark Brown пишет: > > Please include human readable descriptions of things like commits and > > issues being discussed in e-mail in your mails, this makes them much > > easier for humans to read especially when

Re: [PATCH v3 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-12-15 Thread Dmitry Baryshkov
On 11/09/2021 16:19, Marijn Suijten wrote: All DSI PHY/PLL drivers were referencing their VCO parent clock by a global name, most of which don't exist or have been renamed. These clock drivers seem to function fine without that except the 14nm driver for sdm6xx [1]. At the same time all DTs

Re: [PATCH v2 1/3] dt-bindings: sharp,lq101r1sx01: Add compatible for LQ101R1SX03

2021-12-15 Thread Rob Herring
On Sun, 12 Dec 2021 00:36:51 +0300, Dmitry Osipenko wrote: > From: Anton Bambura > > LQ101R1SX03 is compatible with LQ101R1SX01 from software perspective, > document it. The LQ101R1SX03 is a newer revision of LQ101R1SX01, it has > minor differences in hardware pins in comparison to the older

[PATCH] drm/amdgpu: fixup bad vram size on gmc v8

2021-12-15 Thread Zongmin Zhou
Some boards(like RX550) seem to have garbage in the upper 16 bits of the vram size register. Check for this and clamp the size properly. Fixes boards reporting bogus amounts of vram. after add this patch,the maximum GPU VRAM size is 64GB, otherwise only 64GB vram size will be used.

Re: [PATCH v2 3/3] drm/msm/debugfs: Add display/kms state snapshot

2021-12-15 Thread Dmitry Baryshkov
On 15/12/2021 20:45, Rob Clark wrote: From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- v2: Drop unneeded msm_kms_show_priv [Dmitry B] drivers/gpu/drm/msm/msm_debugfs.c | 75 +++ 1 file changed, 75 insertions(+)-- With best

Re: [PATCH] drm/msm/dp: remove unneeded variable

2021-12-15 Thread Stephen Boyd
Quoting cgel@gmail.com (2021-12-15 00:55:54) > From: Changcheng Deng > > Remove unneeded variable used to store return value. > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/2] drm/msm/dpu: add dpu_plane_atomic_print_state

2021-12-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-12-15 08:09:12) > Implement plane's atomic_print_state() callback, printing DPU-specific > plane state: blending stage, SSPP and multirect mode and index. > > Signed-off-by: Dmitry Baryshkov > --- Same const comment applies here Reviewed-by: Stephen Boyd

Re: [PATCH 1/2] drm/msm/dpu: add dpu_crtc_atomic_print_state

2021-12-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-12-15 08:09:11) > Implement CRTC's atomic_print_state() callback, printing DPU-specific > CRTC state (LM, CTL and DSPP ids). > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 +++ > 1 file changed, 15

Re: [PATCH v4 00/22] Support HDMI audio on NVIDIA Tegra20

2021-12-15 Thread Dmitry Osipenko
15.12.2021 21:57, Mark Brown пишет: > On Sat, Dec 04, 2021 at 05:37:03PM +0300, Dmitry Osipenko wrote: > >> I based S/PDIF patches on Arnd's Bergmann patch from a separate series [1] >> that removes obsolete slave_id. This eases merging of the patches by >> removing the merge conflict. This is a

Re: [PATCH v2 2/3] drm/msm/disp: Export helper for capturing snapshot

2021-12-15 Thread Dmitry Baryshkov
On Wed, 15 Dec 2021 at 20:49, Rob Clark wrote: > > From: Rob Clark > > We'll re-use this for debugfs. > > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/msm_disp_snapshot.c | 28 +++- > drivers/gpu/drm/msm/disp/msm_disp_snapshot.h |

Re: [PATCH v2 1/3] drm/msm/disp: Tweak display snapshot to match gpu snapshot

2021-12-15 Thread Dmitry Baryshkov
On Wed, 15 Dec 2021 at 20:49, Rob Clark wrote: > > From: Rob Clark > > Add UTS_RELEASE and show timestamp the same way for consistency. > > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/msm_disp_snapshot.h | 4 ++-- >

Re: [PATCH] drm/msm: Don't use autosuspend for display

2021-12-15 Thread Dmitry Baryshkov
On Wed, 15 Dec 2021 at 22:10, Stephen Boyd wrote: > > Quoting Rob Clark (2021-12-15 09:59:02) > > From: Rob Clark > > > > No functional change, as we only actually enable autosuspend for the GPU > > device. But lets not encourage thinking that autosuspend is a good idea > > for anything display

Re: [PATCH] drm/msm: Don't use autosuspend for display

2021-12-15 Thread Stephen Boyd
Quoting Rob Clark (2021-12-15 09:59:02) > From: Rob Clark > > No functional change, as we only actually enable autosuspend for the GPU > device. But lets not encourage thinking that autosuspend is a good idea > for anything display related. I'd prefer to see a small blurb about why it's not a

Re: [PATCH v4 00/22] Support HDMI audio on NVIDIA Tegra20

2021-12-15 Thread Mark Brown
On Sat, Dec 04, 2021 at 05:37:03PM +0300, Dmitry Osipenko wrote: > I based S/PDIF patches on Arnd's Bergmann patch from a separate series [1] > that removes obsolete slave_id. This eases merging of the patches by > removing the merge conflict. This is a note for Mark Brown. That's not in my tree

Re: [PATCH 7/7] drm/i915: Use struct vma_resource instead of struct vma_snapshot

2021-12-15 Thread kernel test robot
tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unbinding/20211215-183859 base: git://anongit.freedesktop.or

Re: [PATCH 0/2] Add SMBus features to Tegra I2C

2021-12-15 Thread Rob Herring
On Fri, Dec 10, 2021 at 09:56:28AM +0100, Thierry Reding wrote: > On Thu, Dec 09, 2021 at 07:04:30PM +0300, Dmitry Osipenko wrote: > > 09.12.2021 18:05, Akhil R пишет: > > > Add support for SMBus Alert and SMBus block read functions to > > > i2c-tegra driver > > > > > > Akhil R (2): > > >

[PATCH 2/3] drm/vmwgfx: Remove explicit transparent hugepages support

2021-12-15 Thread Zack Rusin
From: Zack Rusin Old versions of the svga device used to export virtual vram, handling of which was optimized on top of transparent hugepages support. Only very old devices (OpenGL 2.1 support and earlier) used this code and at this point performance differences are negligible. Because the code

[PATCH 3/3] drm/vmwgfx: Remove unused compile options

2021-12-15 Thread Zack Rusin
From: Zack Rusin Before the driver had screen targets support we had to disable explicit bringup of its infrastructure because it was breaking screen objects support. Since the implementation of screen targets landed there hasn't been a reason to explicitly disable it and the options were never

[PATCH 1/3] drm/vmwgfx: Fix a size_t/long int format specifier mismatch

2021-12-15 Thread Zack Rusin
From: Zack Rusin On i386 size_t is of course 32bits and using long int throws warnings, trivially fix it by using the dedicated size_t format. This is enough to fix the following warning found by the kernel test robot: drivers/gpu/drm/vmwgfx/vmwgfx_gem.c: In function 'vmw_bo_print_info': >>

Re: [PATCH 1/2] dt-bindings: i2c: tegra: Add SMBus feature properties

2021-12-15 Thread Rob Herring
On Thu, Dec 09, 2021 at 08:35:20PM +0530, Akhil R wrote: > Tegra I2C can use a gpio as an smbus-alert. Document the usage of > the same. > > Signed-off-by: Akhil R > --- > Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt | 4 > 1 file changed, 4 insertions(+) > > diff --git

[PATCH] drm/rockchip: vop: implement atomic_print_state

2021-12-15 Thread John Keeping
Rockchip VOP subclasses drm_crtc_state so implementing the atomic_print_state hook allows printing the additional Rockchip-specific fields of the CRTC state. Signed-off-by: John Keeping --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 14 ++ 1 file changed, 14 insertions(+) diff

[PATCH] drm/rockchip: vop: duplicate subclassed state variables

2021-12-15 Thread John Keeping
Duplicating the CRTC state should copy all of the fields in the subclassed state as well as the base state. Switch to kmemdup to cover all of these (which are all simple variables). Most of the state variables are only used for .atomic_enable where they will have been set in the initial check,

[PATCH] drm/msm: Don't use autosuspend for display

2021-12-15 Thread Rob Clark
From: Rob Clark No functional change, as we only actually enable autosuspend for the GPU device. But lets not encourage thinking that autosuspend is a good idea for anything display related. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/dsi/dsi_host.c | 8

Re: [PATCH 1/7] drm/i915: Avoid using the i915_fence_array when collecting dependencies

2021-12-15 Thread kernel test robot
6-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unbinding/202

[PATCH v2 3/3] drm/msm/debugfs: Add display/kms state snapshot

2021-12-15 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- v2: Drop unneeded msm_kms_show_priv [Dmitry B] drivers/gpu/drm/msm/msm_debugfs.c | 75 +++ 1 file changed, 75 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm/msm_debugfs.c index

[PATCH v2 2/3] drm/msm/disp: Export helper for capturing snapshot

2021-12-15 Thread Rob Clark
From: Rob Clark We'll re-use this for debugfs. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/msm_disp_snapshot.c | 28 +++- drivers/gpu/drm/msm/disp/msm_disp_snapshot.h | 10 +++ 2 files changed, 31 insertions(+), 7 deletions(-) diff --git

[PATCH v2 1/3] drm/msm/disp: Tweak display snapshot to match gpu snapshot

2021-12-15 Thread Rob Clark
From: Rob Clark Add UTS_RELEASE and show timestamp the same way for consistency. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/msm_disp_snapshot.h | 4 ++-- drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 9 ++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff

[PATCH v2 0/3] drm/msm: Add display snapshot debugfs

2021-12-15 Thread Rob Clark
From: Rob Clark This series adds a "kms" debugfs file to dump display register + atomic state, which is useful for debugging issues that don't trigger a display error irq (such as dsi phy misconfiguration). Rob Clark (3): drm/msm/disp: Tweak display snapshot to match gpu snapshot

Re: [PATCH] dt-bindings: display: bridge: document Toshiba TC358768 cells and panel node

2021-12-15 Thread Dmitry Osipenko
15.12.2021 18:27, David Heidelberg пишет: > Properties #address-cells and #size-cells are valid. > The bridge node can also contains panel node. > > Signed-off-by: David Heidelberg > --- > .../bindings/display/bridge/toshiba,tc358768.yaml | 10 ++ > 1 file changed, 10 insertions(+)

Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop.

2021-12-15 Thread Mark Yacoub
On Wed, Dec 15, 2021 at 11:14 AM Chun-Kuang Hu wrote: > > Hi, Mark: > > Mark Yacoub 於 2021年12月14日 週二 下午11:13寫道: > > > > Hey CK, can we have this merged? > > Thank you! > > > > On Mon, Oct 25, 2021 at 9:13 PM Sean Paul wrote: > > > > > > On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub

Re: [PATCH] drm/vkms: set plane modifiers

2021-12-15 Thread Simon Ser
You'll need to set the format_mod_supported hook as well, otherwise the kernel will expose a bogus IN_FORMATS prop with one modifier and zero formats.

Re: [PATCH 1/7] drm/i915: Avoid using the i915_fence_array when collecting dependencies

2021-12-15 Thread kernel test robot
tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unbinding/20211215-183859 base: git://anongit.freedesktop.or

Re: [Intel-gfx] [PATCH v4 06/16] drm/i915/gt: Clear compress metadata for Xe_HP platforms

2021-12-15 Thread Robert Beckett
The fixes below fix gem_lmem_swapping@basic igt test On 09/12/2021 15:45, Ramalingam C wrote: From: Ayaz A Siddiqui Xe-HP and latest devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also

Re: [PATCH] drm/msm/dp: Fix double free on error in msm_dp_bridge_init()

2021-12-15 Thread Dmitry Baryshkov
On 15/12/2021 14:49, Dan Carpenter wrote: The "dp_bridge" pointer is allocated with devm_kzalloc() so it will be freed automatically. Kfreeing it here will only lead to a double free. Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable") Signed-off-by: Dan

Re: IMX6Q DRM - Framebuffer update rate with LVDS

2021-12-15 Thread Lucas Stach
Hi Chris, Am Mittwoch, dem 15.12.2021 um 16:33 + schrieb Chris Pringle: > Hi, >   > I’m looking for some advice/guidance on an issue I’ve run into with > the IMX DRM implementation with LVDS. I’m using an imx6q with an > 1080p LVDS display on kernel 5.10.73-rt. When running Qt applications >

Re: [PATCH] drm/msm: drop dbgname argument from msm_ioremap*()

2021-12-15 Thread Dmitry Baryshkov
Hi, On 09/12/2021 00:23, Rob Clark wrote: On Wed, Dec 8, 2021 at 10:01 AM Dmitry Baryshkov wrote: msm_ioremap() functions take additional argument dbgname used to output single debug line telling IO range. Drop that extra argument, use resource name instead. For some history, the dbgname

[PATCH] drm/vkms: set plane modifiers

2021-12-15 Thread José Expósito
Where no modifiers are exposed, usually linear modifier is assumed. However, userspace code is starting to expect IN_FORMATS even when the only supported modifiers are linear [1]. To avoid possible issues, explicitly set the DRM_FORMAT_MOD_LINEAR modifier. [1]

Re: [PATCH 10/18] dt-bindings: display: rockchip: Add binding for VOP2

2021-12-15 Thread Rob Herring
On Wed, Dec 08, 2021 at 04:12:22PM +0100, Sascha Hauer wrote: > The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. > The binding differs slightly from the existing VOP binding, so add a new > binding file for it. > > Signed-off-by: Sascha Hauer > --- >

IMX6Q DRM - Framebuffer update rate with LVDS

2021-12-15 Thread Chris Pringle
Hi, I'm looking for some advice/guidance on an issue I've run into with the IMX DRM implementation with LVDS. I'm using an imx6q with an 1080p LVDS display on kernel 5.10.73-rt. When running Qt applications (EGLFS) with this platform, I've run into a strange issue where the framebuffer flip

Re: [PATCH 06/18] dt-bindings: display: rockchip: dw-hdmi: Make unwedge pinctrl optional

2021-12-15 Thread Rob Herring
On Wed, 08 Dec 2021 16:12:18 +0100, Sascha Hauer wrote: > None of the upstream device tree files has a "unwedge" pinctrl > specified. Make it optional. > > Signed-off-by: Sascha Hauer > --- > .../devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml | 1 + > 1 file changed, 1

[PATCH] drm/tilcdc: add const to of_device_id

2021-12-15 Thread Xiang wangx
struct of_device_id should normally be const. Signed-off-by: Xiang wangx --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 3ddb7c710a3d..d23ed0e2e87b 100644

Re: [PATCH v2] drm/plane: add alpha and blend_mode to atomic_print_state

2021-12-15 Thread Simon Ser
v2 looks good to me. A little bit sad about the stringifier duplicating code with drm_plane_create_blend_mode_property but it's not that of a big deal. Reviewed-by: Simon Ser

Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop.

2021-12-15 Thread Chun-Kuang Hu
Hi, Mark: Mark Yacoub 於 2021年12月14日 週二 下午11:13寫道: > > Hey CK, can we have this merged? > Thank you! > > On Mon, Oct 25, 2021 at 9:13 PM Sean Paul wrote: > > > > On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote: > > > From: Mark Yacoub > > > > > > [Why] > > > Creating the prop uses

Re: [PATCH v16 00/40] NVIDIA Tegra power management patches for 5.17

2021-12-15 Thread Dmitry Osipenko
15.12.2021 18:55, Thierry Reding пишет: > On Wed, Dec 01, 2021 at 02:23:07AM +0300, Dmitry Osipenko wrote: >> This series adds runtime PM support to Tegra drivers and enables core >> voltage scaling for Tegra20/30 SoCs, resolving overheating troubles. >> >> All patches in this series are

[PATCH 2/2] drm/msm/dpu: add dpu_plane_atomic_print_state

2021-12-15 Thread Dmitry Baryshkov
Implement plane's atomic_print_state() callback, printing DPU-specific plane state: blending stage, SSPP and multirect mode and index. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 41 +++ 1 file changed, 41 insertions(+) diff --git

[PATCH 1/2] drm/msm/dpu: add dpu_crtc_atomic_print_state

2021-12-15 Thread Dmitry Baryshkov
Implement CRTC's atomic_print_state() callback, printing DPU-specific CRTC state (LM, CTL and DSPP ids). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

Re: [PATCH 2/2] drm/i915: clean up shrinker_release_pages

2021-12-15 Thread Matthew Auld
On 15/12/2021 15:55, Tvrtko Ursulin wrote: On 15/12/2021 11:07, Matthew Auld wrote: Add some proper flags for the different modes, and shorten the name to something more snappy. Looks good to me - but since it touches TTM I leave for Thomas to approve. Regards, Tvrtko P.S. I hope writing

[PATCH v2] drm/plane: add alpha and blend_mode to atomic_print_state

2021-12-15 Thread Dmitry Baryshkov
When dumping plane state also output plane's alpha and blending mode values to ease debugging of complex composition cases. Signed-off-by: Dmitry Baryshkov --- Changes since v1: - Changed alpha property format to pad with zeroes --- drivers/gpu/drm/drm_atomic.c| 3 +++

Re: [PATCH v6 7/7] drm/mediatek: Add mt8195 DisplayPort driver

2021-12-15 Thread Maxime Ripard
On Wed, Dec 15, 2021 at 10:02:22AM -0600, Guillaume Ranquet wrote: > Quoting Maxime Ripard (2021-12-15 16:15:08) > > Hi, > > > > On Wed, Dec 15, 2021 at 09:03:01AM -0600, Guillaume Ranquet wrote: > > > Quoting Maxime Ripard (2021-12-13 17:54:22) > > > > On Thu, Dec 02, 2021 at 06:48:12AM -0800,

Re: [Intel-gfx] [PATCH v4 12/16] uapi/drm/dg2: Introduce format modifier for DG2 clear color

2021-12-15 Thread Lionel Landwerlin
On 09/12/2021 17:45, Ramalingam C wrote: From: Mika Kahola DG2 clear color render compression uses Tile4 layout. Therefore, we need to define a new format modifier for uAPI to support clear color rendering. Signed-off-by: Mika Kahola cc: Anshuman Gupta Signed-off-by: Juha-Pekka Heikkilä

Re: [PATCH v6 7/7] drm/mediatek: Add mt8195 DisplayPort driver

2021-12-15 Thread Guillaume Ranquet
Quoting Maxime Ripard (2021-12-15 16:15:08) > Hi, > > On Wed, Dec 15, 2021 at 09:03:01AM -0600, Guillaume Ranquet wrote: > > Quoting Maxime Ripard (2021-12-13 17:54:22) > > > On Thu, Dec 02, 2021 at 06:48:12AM -0800, Guillaume Ranquet wrote: > > > > Hi, > > > > > > > > Quoting Maxime Ripard

Re: [PATCH 7/7] drm/i915: Use struct vma_resource instead of struct vma_snapshot

2021-12-15 Thread kernel test robot
your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unbinding/20211215-1

  1   2   3   >