Re: [PATCH v4 12/22] ASoC: tegra20: spdif: Filter out unsupported rates

2021-12-16 Thread Thierry Reding
On Sat, Dec 04, 2021 at 05:37:15PM +0300, Dmitry Osipenko wrote: > SPDIF and other SoC components share audio PLL on Tegra, thus only one > component may set the desired base clock rate. This creates problem for > HDMI audio because it uses SPDIF and audio may not work if SPDIF's clock > doesn't ex

Re: Re: 回复: Re: [PATCH] drm/amdgpu: fixup bad vram size on gmc v8

2021-12-16 Thread Alex Deucher
Is the issue reproducible with the same board in bare metal on x86? Or does it only happen with passthrough on ARM? Looking through the archives, the SI patch I made was for an x86 laptop. It would be nice to root cause this, but there weren't any gfx8 boards with more than 64G of vram, so I thi

Re: [PATCH v11 0/8] MIPS: JZ4780 and CI20 HDMI

2021-12-16 Thread Paul Cercueil
Hi, Patches 1 and 2 added to drm-misc-next. I'll pick the rest when the regulator situation is sorted out. Cheers, -Paul Le jeu., déc. 2 2021 at 19:39:45 +0100, H. Nikolaus Schaller a écrit : PATCH V11 2021-12-02 19:39:52: - patch 4/8: change devm_regulator_get_optional to devm_regulator_g

Re: [PATCH v4 11/22] ASoC: tegra20: spdif: Support system suspend

2021-12-16 Thread Thierry Reding
On Sat, Dec 04, 2021 at 05:37:14PM +0300, Dmitry Osipenko wrote: > Support system suspend by enforcing runtime PM suspend/resume. > Now there is no doubt that h/w is indeed stopped during suspend > and that h/w state will be properly restored after resume. > > Signed-off-by: Dmitry Osipenko > ---

Re: [PATCH v4 10/22] ASoC: tegra20: spdif: Reset hardware

2021-12-16 Thread Thierry Reding
On Sat, Dec 04, 2021 at 05:37:13PM +0300, Dmitry Osipenko wrote: > Reset S/PDIF controller on runtime PM suspend/resume to ensure that we > always have a consistent hardware state. > > Signed-off-by: Dmitry Osipenko > --- > sound/soc/tegra/tegra20_spdif.c | 32 >

Re: [PATCH v4 09/22] ASoC: tegra20: spdif: Use more resource-managed helpers

2021-12-16 Thread Thierry Reding
On Sat, Dec 04, 2021 at 05:37:12PM +0300, Dmitry Osipenko wrote: > Use resource-managed helpers to make code cleaner. Driver's remove callback > isn't needed anymore since driver is completely resource-managed now. > > Signed-off-by: Dmitry Osipenko > --- > sound/soc/tegra/tegra20_spdif.c | 33 +

Re: [PATCH] drm/amd/display: Fix warning comparing pointer to 0

2021-12-16 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Dec 16, 2021 at 2:50 AM Jiapeng Chong wrote: > > Fix the following coccicheck warning: > > ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c:744:35-36: > WARNING comparing pointer to 0. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > ---

Re: [PATCH v4 08/22] ASoC: tegra20: spdif: Improve driver's code

2021-12-16 Thread Thierry Reding
On Sat, Dec 04, 2021 at 05:37:11PM +0300, Dmitry Osipenko wrote: > - Clean up whitespaces, defines and variables. > > - Remove obsolete code. > > - Adhere to upstream coding style. > > - Don't override returned error code. > > - Replace pr_err with dev_err. > > No functional changes are made b

Re: [PATCH v4 07/22] ASoC: tegra20: spdif: Support device-tree

2021-12-16 Thread Thierry Reding
On Sat, Dec 04, 2021 at 05:37:10PM +0300, Dmitry Osipenko wrote: > Tegra20 S/PDIF driver was added in a pre-DT era and was never used since > that time. Revive driver by adding device-tree support. > > Signed-off-by: Dmitry Osipenko > --- > sound/soc/tegra/tegra20_spdif.c | 11 +-- > 1 f

Re: [PATCH v4 06/22] ASoC: tegra20-spdif: stop setting slave_id

2021-12-16 Thread Thierry Reding
On Sat, Dec 04, 2021 at 05:37:09PM +0300, Dmitry Osipenko wrote: > From: Arnd Bergmann > > The DMA resource is never set up anywhere, and passing this as slave_id > has not been the proper procedure in a long time. > > As a preparation for removing all slave_id references from the ALSA code, > r

Re: [PATCH v4 05/22] ASoC: tegra20: spdif: Set FIFO trigger level

2021-12-16 Thread Thierry Reding
On Sat, Dec 04, 2021 at 05:37:08PM +0300, Dmitry Osipenko wrote: > FIFO trigger level must be not less than the size of DMA burst, otherwise "must be bigger than or equal to"? > audio will be played x4 faster that it should be because part of the DMA "faster than" > data will be dropped on FIFO

Re: [PATCH 1/2] drm/i915/backlight: Drop duplicate intel_panel_actually_set_backlight()

2021-12-16 Thread Hans de Goede
Hi, On 11/21/21 12:00, Hans de Goede wrote: > After the recent refactoring of the backlight code the contents of > intel_panel_actually_set_backlight() is exactly the same (minus a > small wording difference in the drm_dbg_kms() as the contents if the > more widely used intel_backlight_set_pwm_lev

Re: [PATCH] dt-bindings: display: bridge: document Toshiba TC358768 cells and panel node

2021-12-16 Thread Rob Herring
On Wed, Dec 15, 2021 at 9:38 AM David Heidelberg wrote: > > Properties #address-cells and #size-cells are valid. > The bridge node can also contains panel node. > > Signed-off-by: David Heidelberg > --- > .../bindings/display/bridge/toshiba,tc358768.yaml | 10 ++ > 1 file changed, 1

Re: [PATCH v4 00/22] Support HDMI audio on NVIDIA Tegra20

2021-12-16 Thread Dmitry Osipenko
16.12.2021 16:55, Thierry Reding пишет: > On Wed, Dec 15, 2021 at 10:19:07PM +0300, Dmitry Osipenko wrote: >> 15.12.2021 21:57, Mark Brown пишет: >>> On Sat, Dec 04, 2021 at 05:37:03PM +0300, Dmitry Osipenko wrote: >>> I based S/PDIF patches on Arnd's Bergmann patch from a separate series [1]

Re: [PATCH v3 7/8] drm/i915/migrate: add acceleration support for DG2

2021-12-16 Thread Ramalingam C
On 2021-12-14 at 12:32:57 +, Matthew Auld wrote: > On 14/12/2021 10:56, Ramalingam C wrote: > > On 2021-12-06 at 13:31:39 +, Matthew Auld wrote: > > > This is all kinds of awkward since we now have to contend with using 64K > > > GTT pages when mapping anything in LMEM(including the page-ta

Re: [PATCH] drm/amdkfd: use max() and min() to make code cleaner

2021-12-16 Thread philip yang
On 2021-12-15 3:52 a.m., cgel@gmail.com wrote: From: Changcheng Deng Use max() and min() in order to make code cleaner. Reported-by: Zeal Robot Signed-off-by: Changcheng Deng Reviewed-by: Philip Yang Applied, thanks. --

Re: [PATCH v3] dt-bindings: display: tegra: Convert to json-schema

2021-12-16 Thread Dmitry Osipenko
16.12.2021 17:48, Dmitry Osipenko пишет: > 16.12.2021 17:20, Thierry Reding пишет: >> + resets: >> +description: Must contain an entry for each entry in reset-names. See >> + ../reset/reset.txt for details. >> + >> + reset-names: >> +items: >> + - const: host1x > > Could you pl

Re: [PATCH v3] dt-bindings: display: tegra: Convert to json-schema

2021-12-16 Thread Dmitry Osipenko
16.12.2021 17:20, Thierry Reding пишет: > + resets: > +description: Must contain an entry for each entry in reset-names. See > + ../reset/reset.txt for details. > + > + reset-names: > +items: > + - const: host1x Could you please add the optional memory controller reset to all b

[PATCH] drm/tegra: Add missing DMA API includes

2021-12-16 Thread Robin Murphy
Include dma-mapping.h directly in the remaining places that touch the DMA API, to avoid imminent breakage from refactoring other headers. Signed-off-by: Robin Murphy --- This makes arm64 allmodconfig build cleanly for me with the IOVA series, so hopefully is the last of it... drivers/gpu/drm/t

[PULL] drm-misc-next

2021-12-16 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-next for what will become Linux 5.17. Every single patchset in this PR is awesome: vmwgfx now supports GL 4.3 userspace and GEM (yeah!), simpledrm added support for Apple M1 firmware framebuffers, the SPRD drivers finally got merged, vc4 adde

Re: [PATCH v4 00/22] Support HDMI audio on NVIDIA Tegra20

2021-12-16 Thread Dmitry Osipenko
15.12.2021 22:19, Dmitry Osipenko пишет: > 15.12.2021 21:57, Mark Brown пишет: >> On Sat, Dec 04, 2021 at 05:37:03PM +0300, Dmitry Osipenko wrote: >> >>> I based S/PDIF patches on Arnd's Bergmann patch from a separate series [1] >>> that removes obsolete slave_id. This eases merging of the patches

[PATCH v3 11/17] drm/i915: Add ww ctx to i915_gem_object_trylock

2021-12-16 Thread Maarten Lankhorst
This is required for i915_gem_evict_vm, to be able to evict the entire VM, including objects that are already locked to the current ww ctx. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 8 ++-- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 4 ++-- drive

[PATCH v3 16/17] drm/i915: Remove support for unlocked i915_vma unbind

2021-12-16 Thread Maarten Lankhorst
Now that we require the object lock for all ops, some code handling race conditions can be removed. This is required to not take short-term pins inside execbuf. Signed-off-by: Maarten Lankhorst Acked-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_vma.c | 55 +--

[PATCH v3 14/17] drm/i915: Add i915_vma_unbind_unlocked, and take obj lock for i915_vma_unbind, v2.

2021-12-16 Thread Maarten Lankhorst
We want to remove more members of i915_vma, which requires the locking to be held more often. Start requiring gem object lock for i915_vma_unbind, as it's one of the callers that may unpin pages. Some special care is needed when evicting, because the last reference to the object may be held by th

[PATCH v3 10/17] drm/i915: Require object lock when freeing pages during destruction

2021-12-16 Thread Maarten Lankhorst
TTM already requires this, and we require it for delayed destroy. Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915

[PATCH v3 13/17] drm/i915: Add object locking to i915_gem_evict_for_node and i915_gem_evict_something

2021-12-16 Thread Maarten Lankhorst
Because we will start to require the obj->resv lock for unbinding, ensure these shrinker functions also take the lock. This requires some function signature changes, to ensure that the ww context is passed around, but is mostly straightforward. Previously this was split up into several patches, b

[PATCH v3 12/17] drm/i915: Add locking to i915_gem_evict_vm()

2021-12-16 Thread Maarten Lankhorst
i915_gem_evict_vm will need to be able to evict objects that are locked by the current ctx. By testing if the current context already locked the object, we can do this correctly. This allows us to evict the entire vm even if we already hold some objects' locks. Previously, this was spread over sev

[PATCH v3 15/17] drm/i915: Remove assert_object_held_shared

2021-12-16 Thread Maarten Lankhorst
This duck tape workaround is no longer required, unbind and destroy are fixed to take the obj->resv mutex before destroying and obj->mm.lock has been removed, always requiring obj->resv as well. Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_obj

[PATCH v3 17/17] drm/i915: Remove short-term pins from execbuf, v5.

2021-12-16 Thread Maarten Lankhorst
Add a flag PIN_VALIDATE, to indicate we don't need to pin and only protected by the object lock. This removes the need to unpin, which is done by just releasing the lock. eb_reserve is slightly reworked for readability, but the same steps are still done: - First pass pins with NONBLOCK. - Second

[PATCH v3 07/17] drm/i915: Ensure i915_vma tests do not get -ENOSPC with the locking changes.

2021-12-16 Thread Maarten Lankhorst
Now that we require locking to evict, multiple vmas from the same object might not be evicted. This is expected and required, because execbuf will move to short-term pinning by using the lock only. This will cause these tests to fail, because they create a ton of vma's for the same object. Unbind

[PATCH v3 04/17] drm/i915: Take object lock in i915_ggtt_pin if ww is not set

2021-12-16 Thread Maarten Lankhorst
i915_vma_wait_for_bind needs the vma lock held, fix the caller. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_vma.c | 40 +++-- 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915

[PATCH v3 03/17] drm/i915: Remove pages_mutex and intel_gtt->vma_ops.set/clear_pages members, v3.

2021-12-16 Thread Maarten Lankhorst
Big delta, but boils down to moving set_pages to i915_vma.c, and removing the special handling, all callers use the defaults anyway. We only remap in ggtt, so default case will fall through. Because we still don't require locking in i915_vma_unpin(), handle this by using xchg in get_pages(), as it

[PATCH v3 06/17] drm/i915: Ensure gem_contexts selftests work with unbind changes, v2.

2021-12-16 Thread Maarten Lankhorst
In the next commits, we may not evict when refcount = 0. igt_vm_isolation() continuously tries to pin/unpin at same address, but also calls put() on the object, which means the object may not be unpinned in time. Instead of this, re-use the same object over and over, so they can be unbound as req

[PATCH v3 09/17] drm/i915: Trylock the object when shrinking

2021-12-16 Thread Maarten Lankhorst
We're working on requiring the obj->resv lock during unbind, fix the shrinker to take the objectl ock. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c b/drive

[PATCH v3 05/17] drm/i915: Force ww lock for i915_gem_object_ggtt_pin_ww, v2.

2021-12-16 Thread Maarten Lankhorst
We will need the lock to unbind the vma, and wait for bind to complete. Remove the special casing for the !ww path, and force ww locking for all. Changes since v1: - Pass err to for_i915_gem_ww handling for -EDEADLK handling. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_drv.h

[PATCH v3 00/17] drm/i915: Remove short term pins from execbuf by requiring lock to unbind.

2021-12-16 Thread Maarten Lankhorst
Previously, short term pinning in execbuf was required because i915_vma was effectively independent from objects, and has its own refcount, locking, lifetime rules and pinning. This series removes the separate locking, by requiring vma->obj->resv to be held when pinning and unbinding. This will al

[PATCH v3 01/17] drm/i915: Remove unused bits of i915_vma/active api

2021-12-16 Thread Maarten Lankhorst
When reworking the code to move the eviction fence to the object, the best code is removed code. Remove some functions that are unused, and change the function definition if it's only used in 1 place. Signed-off-by: Maarten Lankhorst Reviewed-by: Niranjana Vishwanathapura [mlankhorst: Remove ne

[PATCH v3 08/17] drm/i915: Call i915_gem_evict_vm in vm_fault_gtt to prevent new ENOSPC errors

2021-12-16 Thread Maarten Lankhorst
Now that we cannot unbind kill the currently locked object directly because we're removing short term pinning, we may have to unbind the object from gtt manually, using a i915_gem_evict_vm() call. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 18

[PATCH v3 02/17] drm/i915: Change shrink ordering to use locking around unbinding.

2021-12-16 Thread Maarten Lankhorst
Call drop_pages with the gem object lock held, instead of the other way around. This will allow us to drop the vma bindings with the gem object lock held. We plan to require the object lock for unpinning in the future, and this is an easy target. Signed-off-by: Maarten Lankhorst Reviewed-by: Nir

Re: [PATCH v4 20/22] ARM: tegra: Add HDMI audio graph to Tegra20 device-tree

2021-12-16 Thread Dmitry Osipenko
16.12.2021 16:46, Thierry Reding пишет: > On Sat, Dec 04, 2021 at 05:37:23PM +0300, Dmitry Osipenko wrote: >> Add HDMI audio graph to Tegra20 device-tree to enable HDMI audio on >> Tegra20 devices. >> >> Signed-off-by: Dmitry Osipenko >> --- >> arch/arm/boot/dts/tegra20.dtsi | 22

Re: [bug report] new kvmalloc() WARN() triggered by DRM ioctls tracking

2021-12-16 Thread Steven Price
On 16/12/2021 14:15, Boris Brezillon wrote: > Hi Steve, > > On Thu, 16 Dec 2021 14:02:25 + > Steven Price wrote: > >> + Boris >> >> On 16/12/2021 12:08, Dan Carpenter wrote: >>> Hi DRM Devs, >>> >>> In commit 7661809d493b ("mm: don't allow oversized kvmalloc() calls") >>> from July, Linus ad

Re: [PATCH v4 04/22] dt-bindings: host1x: Document optional HDMI sound-dai-cells

2021-12-16 Thread Thierry Reding
On Sat, Dec 04, 2021 at 05:37:07PM +0300, Dmitry Osipenko wrote: > Document new optional sound-dai-cells property of HDMI node. This node will > be used as endpoint of HDMI sound DAI graph. > > Acked-by: Rob Herring > Signed-off-by: Dmitry Osipenko > --- > .../devicetree/bindings/display/tegra/

[PATCH v3] dt-bindings: display: tegra: Convert to json-schema

2021-12-16 Thread Thierry Reding
From: Thierry Reding Convert the Tegra host1x controller bindings from the free-form text format to json-schema. This also adds the missing display-hub DT bindings that were not previously documented. Signed-off-by: Thierry Reding --- Sorry Rob for making you look at this again. However, I thi

Re: [PATCH v16 00/40] NVIDIA Tegra power management patches for 5.17

2021-12-16 Thread Dmitry Osipenko
16.12.2021 16:14, Thierry Reding пишет: > On Wed, Dec 15, 2021 at 07:11:53PM +0300, Dmitry Osipenko wrote: >> 15.12.2021 18:55, Thierry Reding пишет: >>> On Wed, Dec 01, 2021 at 02:23:07AM +0300, Dmitry Osipenko wrote: This series adds runtime PM support to Tegra drivers and enables core

Re: [bug report] new kvmalloc() WARN() triggered by DRM ioctls tracking

2021-12-16 Thread Boris Brezillon
Hi Steve, On Thu, 16 Dec 2021 14:02:25 + Steven Price wrote: > + Boris > > On 16/12/2021 12:08, Dan Carpenter wrote: > > Hi DRM Devs, > > > > In commit 7661809d493b ("mm: don't allow oversized kvmalloc() calls") > > from July, Linus added a WARN_ONCE() for "crazy" allocations over 2GB. > >

Re: [bug report] new kvmalloc() WARN() triggered by DRM ioctls tracking

2021-12-16 Thread Steven Price
+ Boris On 16/12/2021 12:08, Dan Carpenter wrote: > Hi DRM Devs, > > In commit 7661809d493b ("mm: don't allow oversized kvmalloc() calls") > from July, Linus added a WARN_ONCE() for "crazy" allocations over 2GB. > I have a static checker warning for this and most of the warnings are > from DRM io

RE: [PATCH v3 0/3] Add Mali-G31 GPU support for RZ/G2L SoC

2021-12-16 Thread Biju Das
Hi Daniel Stone, Thanks for the feedback. > Subject: Re: [PATCH v3 0/3] Add Mali-G31 GPU support for RZ/G2L SoC > > Hi Biju, > > On Wed, 8 Dec 2021 at 10:40, Biju Das wrote: > > RZ/G2L SoC embeds Mali-G31 bifrost GPU. > > This patch series aims to add support for the same > > > > It is tested

Re: [PATCH v3 0/3] Add Mali-G31 GPU support for RZ/G2L SoC

2021-12-16 Thread Daniel Stone
Hi Biju, On Wed, 8 Dec 2021 at 10:40, Biju Das wrote: > RZ/G2L SoC embeds Mali-G31 bifrost GPU. > This patch series aims to add support for the same > > It is tested with latest drm-misc-next + mesa 21.3.0 + > out of tree patch for (du + DSI) + > platform specific mesa configuration for RZ/G2L.

Re: [PATCH v4 02/22] ASoC: dt-bindings: tegra20-i2s: Convert to schema

2021-12-16 Thread Thierry Reding
On Sat, Dec 04, 2021 at 05:37:05PM +0300, Dmitry Osipenko wrote: > Convert NVIDIA Tegra20 I2S binding to schema. > > Reviewed-by: Rob Herring > Signed-off-by: Dmitry Osipenko > --- > .../bindings/sound/nvidia,tegra20-i2s.txt | 30 > .../bindings/sound/nvidia,tegra20-i2s.yaml| 7

Re: [PATCH v4 01/22] ASoC: dt-bindings: Add binding for Tegra20 S/PDIF

2021-12-16 Thread Thierry Reding
On Sat, Dec 04, 2021 at 05:37:04PM +0300, Dmitry Osipenko wrote: > Add device-tree binding for Tegra20 S/PDIF controller. > > Reviewed-by: Rob Herring > Signed-off-by: Dmitry Osipenko > --- > .../bindings/sound/nvidia,tegra20-spdif.yaml | 85 +++ > 1 file changed, 85 insertions

Re: [PATCH v4 00/22] Support HDMI audio on NVIDIA Tegra20

2021-12-16 Thread Thierry Reding
On Wed, Dec 15, 2021 at 10:19:07PM +0300, Dmitry Osipenko wrote: > 15.12.2021 21:57, Mark Brown пишет: > > On Sat, Dec 04, 2021 at 05:37:03PM +0300, Dmitry Osipenko wrote: > > > >> I based S/PDIF patches on Arnd's Bergmann patch from a separate series [1] > >> that removes obsolete slave_id. This

Re: [PATCH v3 0/3] Add Mali-G31 GPU support for RZ/G2L SoC

2021-12-16 Thread Geert Uytterhoeven
On Thu, Dec 16, 2021 at 2:44 PM Geert Uytterhoeven wrote: > From: Biju Das > > RZ/G2L SoC embeds Mali-G31 bifrost GPU. > This patch series aims to add support for the same Oops, please ignore this email. Sorry for the noise. Gr{oetje,eeting}s, Geert -- Geert Uytterhoev

Re: [PATCH v3 0/3] Add Mali-G31 GPU support for RZ/G2L SoC

2021-12-16 Thread Geert Uytterhoeven
On Thu, Dec 16, 2021 at 2:41 PM Geert Uytterhoeven wrote: > From: Biju Das > > RZ/G2L SoC embeds Mali-G31 bifrost GPU. > This patch series aims to add support for the same Oops, please ignore this email. Sorry for the noise. Gr{oetje,eeting}s, Geert -- Geert Uytterhoev

Re: [PATCH v3 0/3] Add Mali-G31 GPU support for RZ/G2L SoC

2021-12-16 Thread Geert Uytterhoeven
On Thu, Dec 16, 2021 at 2:37 PM Geert Uytterhoeven wrote: > From: Biju Das > > RZ/G2L SoC embeds Mali-G31 bifrost GPU. > This patch series aims to add support for the same Oops, please ignore this email. Sorry for the noise. Gr{oetje,eeting}s, Geert -- Geert Uytterhoev

Re: [PATCH v4 20/22] ARM: tegra: Add HDMI audio graph to Tegra20 device-tree

2021-12-16 Thread Thierry Reding
On Sat, Dec 04, 2021 at 05:37:23PM +0300, Dmitry Osipenko wrote: > Add HDMI audio graph to Tegra20 device-tree to enable HDMI audio on > Tegra20 devices. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/boot/dts/tegra20.dtsi | 22 +- > 1 file changed, 21 insertions(+), 1 d

Re: [PATCH v16 00/40] NVIDIA Tegra power management patches for 5.17

2021-12-16 Thread Thierry Reding
On Wed, Dec 15, 2021 at 07:11:53PM +0300, Dmitry Osipenko wrote: > 15.12.2021 18:55, Thierry Reding пишет: > > On Wed, Dec 01, 2021 at 02:23:07AM +0300, Dmitry Osipenko wrote: > >> This series adds runtime PM support to Tegra drivers and enables core > >> voltage scaling for Tegra20/30 SoCs, resolv

Re: [PATCH v16 29/40] soc/tegra: fuse: Use resource-managed helpers

2021-12-16 Thread Thierry Reding
On Wed, Dec 01, 2021 at 02:23:36AM +0300, Dmitry Osipenko wrote: > Use resource-managed helpers to make code cleaner and more correct, > properly releasing all resources in case of driver probe error. > > Signed-off-by: Dmitry Osipenko > --- > drivers/soc/tegra/fuse/fuse-tegra.c | 32 +

Re: [PATCH] drm/i915: remove circ_buf.h includes

2021-12-16 Thread Jani Nikula
On Thu, 16 Dec 2021, Jiri Slaby wrote: > The last user of macros from that include was removed in 2018 by the > commit below. > > Fixes: 6cc42152b02b ("drm/i915: Remove support for legacy debugfs crc > interface") > Signed-off-by: Jiri Slaby > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrig

[bug report] new kvmalloc() WARN() triggered by DRM ioctls tracking

2021-12-16 Thread Dan Carpenter
Hi DRM Devs, In commit 7661809d493b ("mm: don't allow oversized kvmalloc() calls") from July, Linus added a WARN_ONCE() for "crazy" allocations over 2GB. I have a static checker warning for this and most of the warnings are from DRM ioctls. drivers/gpu/drm/lima/lima_drv.c:124 lima_ioctl_gem_submi

Re: [PATCH] drm/bridge: ti-sn65dsi86: Set max register for regmap

2021-12-16 Thread Robert Foss
Hi Stephen, Thanks for submitting this fix. On Wed, 15 Dec 2021 at 01:25, Stephen Boyd wrote: > > Set the maximum register to 0xff so we can dump the registers for this > device in debugfs. > > Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver") > Cc: Rob Clark > Cc: Dou

[PATCH] drm/i915: remove circ_buf.h includes

2021-12-16 Thread Jiri Slaby
The last user of macros from that include was removed in 2018 by the commit below. Fixes: 6cc42152b02b ("drm/i915: Remove support for legacy debugfs crc interface") Signed-off-by: Jiri Slaby Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel

Re: [PATCH v4 2/6] drm: improve drm_buddy_alloc function

2021-12-16 Thread Thomas Zimmermann
Hi Am 01.12.21 um 17:39 schrieb Arunpravin: - Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which allocates the requested power-of-two block comply with range limitations - Moved order computa

Re: [PATCH 1/7] drm/i915: Avoid using the i915_fence_array when collecting dependencies

2021-12-16 Thread kernel test robot
inding/20211215-183859 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: x86_64-rhel-8.3-kselftests (https://download.01.org/0day-ci/archive/20211216/202112161943.cppzejzk-...@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse

[RFC PATCH] drm/i915: prev_deps() can be static

2021-12-16 Thread kernel test robot
drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c:634:5: warning: symbol 'prev_deps' was not declared. Should it be static? Reported-by: kernel test robot Signed-off-by: kernel test robot --- i915_gem_ttm_move.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/

Re: [PATCH v4 2/6] drm: improve drm_buddy_alloc function

2021-12-16 Thread Matthew Auld
On 15/12/2021 20:46, Arunpravin wrote: On 14/12/21 12:29 am, Matthew Auld wrote: On 09/12/2021 15:47, Paneer Selvam, Arunpravin wrote: [AMD Official Use Only] Hi Matthew, Ping on this? No new comments from me :) I guess just a question of what we should do with the selftests, and then ofc

Re: [PATCH v2 3/3] drm/ast: Move I2C code into separate source file

2021-12-16 Thread Thomas Zimmermann
Am 06.12.21 um 10:11 schrieb Thomas Zimmermann: Move I2C code into its own source file. Makes the mode-setting code a little less convoluted. Signed-off-by: Thomas Zimmermann A-b Maxime via irc --- drivers/gpu/drm/ast/Makefile | 2 +- drivers/gpu/drm/ast/ast_drv.h | 3 + driver

Re: [PATCH v3] drm/tilcdc: add const to of_device_id

2021-12-16 Thread Jyri Sarha
On 2021-12-16 11:55, Xiang wangx wrote: struct of_device_id should normally be const. Signed-off-by: Xiang wangx Reviewed-by: Jyri Sarha Thanks, Jyri --- Changes since v1 * add const in line 63 Changes since v2 * removed line 63 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +--- 1 file cha

Re: [PATCH v2] drm/tilcdc: add const to of_device_id

2021-12-16 Thread Jyri Sarha
On 2021-12-16 11:44, Joe Perches wrote: On Thu, 2021-12-16 at 17:26 +0800, Xiang wangx wrote: struct of_device_id should normally be const. [] diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c [] @@ -60,7 +60,7 @@ void tilcdc_module_cleanup(struct tilcdc_m

Re: [PATCH v3 0/3] drm/simpledrm: Apple M1 / DT platform support fixes

2021-12-16 Thread Thomas Zimmermann
Hi Am 15.12.21 um 14:29 schrieb Thomas Zimmermann: Hi Am 12.12.21 um 07:24 schrieb Hector Martin: Hi DRM folks, This short series makes simpledrm work on Apple M1 (including Pro/Max) platforms the way simplefb already does, by adding XRGB2101010 support and making it bind to framebuffers in /

[PATCH v3] drm/tilcdc: add const to of_device_id

2021-12-16 Thread Xiang wangx
struct of_device_id should normally be const. Signed-off-by: Xiang wangx --- Changes since v1 * add const in line 63 Changes since v2 * removed line 63 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.

Re: [PATCH v2] drm/tilcdc: add const to of_device_id

2021-12-16 Thread Joe Perches
On Thu, 2021-12-16 at 17:26 +0800, Xiang wangx wrote: > struct of_device_id should normally be const. [] > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > b/drivers/gpu/drm/tilcdc/tilcdc_drv.c [] > @@ -60,7 +60,7 @@ void tilcdc_module_cleanup(struct tilcdc_module *mod) > list_del(&mod->li

Re: [PATCH] drm/vmwgfx: Fix possible usage of an uninitialized variable

2021-12-16 Thread Martin Krastev
On Wed, 2021-12-15 at 15:02 -0500, Zack Rusin wrote: > From: Zack Rusin > > vmw_user_bo_lookup can fail to lookup user buffers, especially because > the buffer handles come from the userspace. The return value has > to be checked before the buffers are put back. > > This was spotted by Dan's Sma

[PATCH v16, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192

2021-12-16 Thread Yunfei Dong
Adds decoder dt-bindings for mt8192. Signed-off-by: Yunfei Dong Reviewed-by: Rob Herring --- .../media/mediatek,vcodec-subdev-decoder.yaml | 265 ++ 1 file changed, 265 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml

[PATCH v16, 17/19] media: mtk-vcodec: Use codec type to separate different hardware

2021-12-16 Thread Yunfei Dong
There is just one core thread, in order to separate different hardware, using codec type to separeate it in scp driver. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 12 --- .../media/platform/mtk-vcodec/vdec_vpu_if.c

[PATCH v16, 12/19] media: mtk-vcodec: Add new interface to lock different hardware

2021-12-16 Thread Yunfei Dong
For add new hardware, not only need to lock lat hardware, also need to lock core hardware in case of different instance start to decoder at the same time. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 4 ++-- dri

[PATCH v16, 18/19] media: mtk-vcodec: Remove mtk_vcodec_release_dec_pm

2021-12-16 Thread Yunfei Dong
There are only two lines in mtk_vcodec_release_dec_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_init_dec_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_dec_pm to *_clk since it only has clock operations now. Si

[PATCH v16, 16/19] media: mtk-vcodec: Add core dec and dec end ipi msg

2021-12-16 Thread Yunfei Dong
Add core dec and dec end ipi msg: AP_IPIMSG_DEC_CORE/AP_IPIMSG_DEC_CORE_END. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 4 .../media/platform/mtk-vcodec/vdec_vpu_if.c| 12 .../media/platform/mtk

[PATCH v16, 19/19] media: mtk-vcodec: Remove mtk_vcodec_release_enc_pm

2021-12-16 Thread Yunfei Dong
There are only two lines in mtk_vcodec_release_enc_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_release_enc_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_enc_pm to *_clk since it only has clock operations now.

[PATCH v16, 14/19] media: mtk-vcodec: Support 34bits dma address for vdec

2021-12-16 Thread Yunfei Dong
Use the dma_set_mask_and_coherent helper to set vdec DMA bit mask to support 34bits iova space(16GB) that the mt8192 iommu HW support. Whole the iova range separate to 0~4G/4G~8G/8G~12G/12G~16G, regarding which iova range VDEC actually locate, it depends on the dma-ranges property of vdec dtsi nod

[PATCH v16, 13/19] media: mtk-vcodec: Add work queue for core hardware decode

2021-12-16 Thread Yunfei Dong
Add work queue to process core hardware information. First, get lat_buf from message queue, then call core hardware of each codec(H264/VP9/AV1) to decode, finally puts lat_buf back to the message. Signed-off-by: Yunfei Dong Reviewed-by: Steve Cho --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c

[PATCH v16, 06/19] media: mtk-vcodec: Add to support multi hardware decode

2021-12-16 Thread Yunfei Dong
There are more than two hardwares for decoder: LAT0, LAT1 and CORE. In order to manage these hardwares, register each hardware as independent platform device for the larbs are different. Each hardware module controls its own information which includes interrupt/power/ clocks/registers. Calling o

[PATCH v16, 09/19] media: mtk-vcodec: Add irq interface for multi hardware

2021-12-16 Thread Yunfei Dong
Adds irq interface for multi hardware. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 33 --- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/mtk-vcodec/mtk_vcodec_drv.h | 25 ++

[PATCH v16, 08/19] media: mtk-vcodec: Use pure single core for MT8183

2021-12-16 Thread Yunfei Dong
Separates different architecture for hardware: pure_sin_core and lat_sin_core. MT8183 is pure single core. Uses .hw_arch to distinguish. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../platform/mtk-vcodec/mtk_vcodec_dec_stateful.c | 1 + .../platform/mtk-vcodec

[PATCH v16, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces

2021-12-16 Thread Yunfei Dong
Generalizes power and clock on/off interfaces to support different hardware. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 +- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/mtk-vcodec/mtk_vcodec_d

[PATCH v16, 05/19] media: mtk-vcodec: Support MT8192

2021-12-16 Thread Yunfei Dong
From: Yunfei Dong Adds MT8192's compatible "mediatek,mt8192-vcodec-dec". Adds MT8192's device private data mtk_lat_sig_core_pdata. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../media/platform/mtk-vcodec/mtk_vcodec_dec.h | 1 + .../platform/mtk-vcodec/mtk_vcode

[PATCH v16, 04/19] media: mtk-vcodec: export decoder pm functions

2021-12-16 Thread Yunfei Dong
When mtk vcodec decoder is build as a module, we need to export mtk-vcodec-dec pm functions to make them visible by the other components. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Benjamin Gaignard --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c

[PATCH v16, 10/19] media: mtk-vcodec: Add msg queue feature for lat and core architecture

2021-12-16 Thread Yunfei Dong
For lat and core architecture, lat thread will send message to core thread when lat decode done. Core hardware will use the message from lat to decode, then free message to lat thread when decode done. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- drivers/media/platfor

[PATCH v16, 07/19] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings

2021-12-16 Thread Yunfei Dong
Separate decoder and encoder document for the dts are big difference. Signed-off-by: Yunfei Dong Reviewed-by: Rob Herring --- .../media/mediatek,vcodec-decoder.yaml| 176 + .../media/mediatek,vcodec-encoder.yaml| 187 ++ .../bindings/media/mediate

[PATCH v16, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface

2021-12-16 Thread Yunfei Dong
Vdec and venc can use the same function to wake up interrupt event. Signed-off-by: Yunfei Dong Reviewed-by: Tzung-Bi Shih Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steve Cho --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 + drivers/media/platform/mtk-vcodec

[PATCH v16, 03/19] media: mtk-vcodec: Refactor vcodec pm interface

2021-12-16 Thread Yunfei Dong
Using the needed params for pm init/release function and remove unused param mtkdev in 'struct mtk_vcodec_pm'. Signed-off-by: Yunfei Dong Reviewed-by: Tzung-Bi Shih Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steve Cho --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 ++--- ..

[PATCH v16, 01/19] media: mtk-vcodec: Get numbers of register bases from DT

2021-12-16 Thread Yunfei Dong
Different platforms may have different numbers of register bases. Gets the numbers of register bases from dts (sizeof(u32) * 4 bytes for each). Signed-off-by: Yunfei Dong Reviewed-by: Tzung-Bi Shih --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 37 ++- 1 file changed, 28 in

[PATCH v16, 00/19] Support multi hardware decode using of_platform_populate

2021-12-16 Thread Yunfei Dong
This series adds support for multi hardware decode into mtk-vcodec, by first adding use of_platform_populate to manage each hardware information: interrupt, clock, register bases and power. Secondly add core work queue to deal with core hardware message, at the same time, add msg queue for diffe

回复: Re: 回复: Re: [PATCH] drm/amdgpu: fixup bad vram size on gmc v8

2021-12-16 Thread 周宗敏
Hi  Christian,I'm  testing for GPU passthrough feature, so I pass through this GPU to  virtual machine to use. It  based on arm64 system.As far as i know, Alex had dealt with a similar problems on dri/radeon/si.c .  Maybe they have a same reason to cause it?the history commit message is below:https

RE: – EXTERNAL:Re: IMX6Q DRM - Framebuffer update rate with LVDS

2021-12-16 Thread Chris Pringle
From: Lucas Stach Sent: 15 December 2021 16:46 > Am Mittwoch, dem 15.12.2021 um 16:33 + schrieb Chris Pringle: > > I’m looking for some advice/guidance on an issue I’ve run into with > > the IMX DRM implementation with LVDS. I’m using an imx6q with an 1080p > > LVDS display on kernel 5.10.73-r

[PATCH v2] drm/tilcdc: add const to of_device_id

2021-12-16 Thread Xiang wangx
struct of_device_id should normally be const. Signed-off-by: Xiang wangx --- Changes since v1 * add const in line 63 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_

Re: [PATCH] drm/tilcdc: add const to of_device_id

2021-12-16 Thread Jyri Sarha
m/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xiang-wangx/drm-tilcdc-add-const-to-of_device_id/20211216-002326 base: git://anongit.freedesktop.org/drm/drm drm-next config: arm-randconfig-c002-20211214 (https://download.01.org/0day-ci/archive/20211216/202112160411.snrselay-...

Re: [PATCH v15, 10/19] media: mtk-vcodec: Add msg queue feature for lat and core architecture

2021-12-16 Thread AngeloGioacchino Del Regno
Il 16/12/21 09:57, Yunfei Dong ha scritto: For lat and core architecture, lat thread will send message to core thread when lat decode done. Core hardware will use the message from lat to decode, then free message to lat thread when decode done. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGi

[PATCH v15, 19/19] media: mtk-vcodec: Remove mtk_vcodec_release_enc_pm

2021-12-16 Thread Yunfei Dong
There are only two lines in mtk_vcodec_release_enc_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_release_enc_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_enc_pm to *_clk since it only has clock operations now.

[PATCH v15, 16/19] media: mtk-vcodec: Add core dec and dec end ipi msg

2021-12-16 Thread Yunfei Dong
Add core dec and dec end ipi msg: AP_IPIMSG_DEC_CORE/AP_IPIMSG_DEC_CORE_END. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 4 .../media/platform/mtk-vcodec/vdec_vpu_if.c| 12 .../media/platform/mtk

[PATCH v15, 18/19] media: mtk-vcodec: Remove mtk_vcodec_release_dec_pm

2021-12-16 Thread Yunfei Dong
There are only two lines in mtk_vcodec_release_dec_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_init_dec_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_dec_pm to *_clk since it only has clock operations now. Re

<    1   2   3   >