Re: Re: Empty IN_FORMATS in sun4i-drm

2021-12-23 Thread Jernej Škrabec
Hi! Dne četrtek, 23. december 2021 ob 10:59:23 CET je Emmanuel Gil Peyrot napisal(a): > On Tue, Dec 14, 2021 at 06:58:56PM +0100, Jernej Škrabec wrote: > > Dne torek, 14. december 2021 ob 13:02:48 CET je Emmanuel Gil Peyrot > > napisal(a): > > > Hi, > > > > > > After updating Weston from 9f8561

Re: [git pull] drm fixes for 5.16-rc7

2021-12-23 Thread pr-tracker-bot
The pull request you sent on Fri, 24 Dec 2021 08:14:51 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2021-12-24 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/95b40115a97bda99485267ca2b3b7566f965b5b4 Thank you! -- Deet-doot-dot, I am a bot. https://k

[git pull] drm fixes for 5.16-rc7

2021-12-23 Thread Dave Airlie
Hi Linus. Happy Xmas, pull request. Nothing major, one mediatek and a couple of i915 locking fixes. There might be a few stragglers over next week or so but I don't expect much before next release. Dave. drm-fixes-2021-12-24: drm fixes for 5.16-rc7 mediatek: - NULL pointer check i915: - guc su

Re: [PATCH] drm/i915: Increment composite fence seqno

2021-12-23 Thread John Harrison
On 12/14/2021 11:59, Matthew Brost wrote: Increment composite fence seqno on each fence creation. Fixes: 544460c33821 ("drm/i915: Multi-BB execbuf") Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [PATCH 0/3] drm/vkms: add support for multiple overlay planes

2021-12-23 Thread Melissa Wen
On 12/13, José Expósito wrote: > Hi all, > > First of all, let me quickly introduce myself. I'm José Expósito and > I'm a hobbyist open source developer. > My contributions are usually in the kernel input/HID subsystems and > in its userspace library (libinput) as well as other projects. > > I'm

Re: [PATCH 2/3] drm/vkms: add support for multiple overlay planes

2021-12-23 Thread Melissa Wen
On 12/13, José Expósito wrote: > Add a new module parameter to allow to set the number of overlay planes > to create. Set it to 1 by default in order to keep the "enable_overlay" > backwards compatible. > Hi José, in general, lgtm. However, I think we need some limits for this number of planes. I

[GIT PULL] etnaviv-next for 5.17

2021-12-23 Thread Lucas Stach
Hi Dave, hi Daniel, please pull the following etnaviv changes for the next merge window: - make etnaviv work on IOMMU enabled systems - fix mapping of command buffers on systems with more than 4GB RAM - close a DoS vector - fix spurious GPU resets Regards, Lucas The following changes since commi

[RFC v3 5/8] drm/amd/virt: For SRIOV send GPU reset directly to TDR queue.

2021-12-23 Thread Andrey Grodzovsky
No need to to trigger another work queue inside the work queue. v3: Problem: Extra reset caused by host side FLR notification following guest side triggered reset. Fix: Preven qeuing flr_work from mailbox irq if guest already executing a reset. Suggested-by: Liu Shaoyun Signed-off-by: Andrey Gr

Re: [Intel-gfx] [PATCH] drm/i915/guc: Use lockless list for destroyed contexts

2021-12-23 Thread Matthew Brost
On Thu, Dec 23, 2021 at 10:01:42AM +, Tvrtko Ursulin wrote: > > On 22/12/2021 23:29, Matthew Brost wrote: > > Use a lockless list structure for destroyed contexts to avoid hammering > > on global submission spin lock. > > Thanks for looking into it quickly! > > On the topic of "lockless" yes

RE: [RFC v2 8/8] drm/amd/virt: Drop concurrent GPU reset protection for SRIOV

2021-12-23 Thread Liu, Shaoyun
[AMD Official Use Only] I have a discussion with Andrey about this offline. It seems dangerous to remove the in_gpu_reset and reset_semm directly inside the flr_work. In the case when the reset is triggered from host side , gpu need to be locked while host perform reset after flr_work

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Check for wedged before doing stuff

2021-12-23 Thread Matthew Brost
On Tue, Dec 21, 2021 at 01:02:12PM -0800, john.c.harri...@intel.com wrote: > From: John Harrison > > A fault injection probe test hit a BUG_ON in a GuC error path. It > showed that the GuC code could potentially attempt to do many things > when the device is actually wedged. So, add a check in to

Re: [Intel-gfx] [PATCH] drm/i915/guc: Report error on invalid reset notification

2021-12-23 Thread Matthew Brost
On Wed, Dec 22, 2021 at 05:31:28PM -0800, john.c.harri...@intel.com wrote: > From: John Harrison > > Don't silently drop reset notifications from the GuC. It might not be > safe to do an error capture but we still want some kind of report that > the reset happened. > > Signed-off-by: John Harris

Re: [Intel-gfx] [PATCH] drm/i915/guc: Log engine resets

2021-12-23 Thread John Harrison
On 12/23/2021 02:23, Tvrtko Ursulin wrote: On 22/12/2021 21:58, John Harrison wrote: On 12/22/2021 08:21, Tvrtko Ursulin wrote: On 21/12/2021 22:14, John Harrison wrote: On 12/21/2021 05:37, Tvrtko Ursulin wrote: On 20/12/2021 18:34, John Harrison wrote: On 12/20/2021 07:00, Tvrtko Ursulin w

Re: (subset) [PATCH 0/3] More amlogic sound-name-prefix DT fixes

2021-12-23 Thread Mark Brown
On Thu, 23 Dec 2021 13:24:31 +0100, Alexander Stein wrote: > Following up [1] here are more fix for missing sound-name-prefix properties in > the arch/arm64/boot/dts/amlogic/ subtree. > > [1] https://www.spinics.net/lists/devicetree/msg466125.html > > Alexander Stein (3): > dt-bindings: display

Re: [PATCH v2 1/6] drm/plane: Make format_mod_supported truly optional

2021-12-23 Thread José Expósito
Thanks for your reviews :) I'll wait a couple of days to see if somebody else wants to comment and I'll send v3 adding the reviewed by tags and fixing the compiler warning. On Thu, Dec 23, 2021 at 05:03:19PM +0200, Ville Syrjälä wrote: > Another related thing that might be worth checking is whethe

Re: [PATCH] drm/amd/display: fix dereference before NULL check

2021-12-23 Thread Harry Wentland
On 2021-12-16 13:14, José Expósito wrote: > The "plane_state" pointer was access before checking if it was NULL. > > Avoid a possible NULL pointer dereference by accessing the plane > address after the check. > > Addresses-Coverity-ID: 1474582 ("Dereference before null check") > Fixes: 3f68c01be9

Re: [PATCH v2 1/6] drm/plane: Make format_mod_supported truly optional

2021-12-23 Thread Ville Syrjälä
On Thu, Dec 23, 2021 at 01:42:32PM +, Simon Ser wrote: > On Thursday, December 23rd, 2021 at 12:56, Ville Syrjälä > wrote: > > > > - /* If we can't determine support, just bail */ > > > - if (!plane->funcs->format_mod_supported) > > > - goto done; > > > - > > > mod = modifiers_ptr(

[PATCH v1] gpu: host1x: Fix hang on Tegra186+

2021-12-23 Thread Dmitry Osipenko
Tegra186+ hangs if host1x hardware is disabled at a kernel boot time because we touch hardware before runtime PM is resumed. Move sync point assignment initialization to the RPM-resume callback. Older SoCs were unaffected because they skip that sync point initialization. Tested-by: Jon Hunter # T

RE: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-23 Thread Lee, Shawn C
On Thursday, December 23, 2021 1:02 PM, Ville Syrjälä wrote: >On Sun, Dec 12, 2021 at 11:33:31PM +0800, Lee Shawn C wrote: >> According to CEA-861-F chapter 7.5.4. It says "The VSDB shall contain >> the >> 3 bytes of the IEEE OUI as well as any additional payload bytes needed." >> Now DRM driver c

Re: [PATCH 0/2] drm/panfrost: partial support of T628 GPUs

2021-12-23 Thread Alyssa Rosenzweig
> With these patches panfrost is able to drive mali T628 (r1p0) GPU > on some armv8 SoCs (in particular BE-M1000). > r0 GPUs are still not supported [yet] (tested with Exynos 5422). What's needed for r0?

Re: [PATCH 2/2] drm/panfrost: adjusted job affinity for dual core group GPUs

2021-12-23 Thread Alyssa Rosenzweig
> The kernel driver itself can't guess which jobs need a such a strict > affinity, so setting proper requirements is the responsibility of > the userspace (Mesa). However the userspace is not smart enough [yet]. > Therefore this patch applies the above affinity rule to all jobs on > dual core group

Re: [PATCH v2 1/6] drm/plane: Make format_mod_supported truly optional

2021-12-23 Thread Simon Ser
On Thursday, December 23rd, 2021 at 12:56, Ville Syrjälä wrote: > > - /* If we can't determine support, just bail */ > > - if (!plane->funcs->format_mod_supported) > > - goto done; > > - > > mod = modifiers_ptr(blob_data); > > for (i = 0; i < plane->modifier_count; i++) { >

Re: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-23 Thread Ville Syrjälä
On Sun, Dec 12, 2021 at 11:33:31PM +0800, Lee Shawn C wrote: > According to CEA-861-F chapter 7.5.4. It says "The VSDB shall contain the > 3 bytes of the IEEE OUI as well as any additional payload bytes needed." > Now DRM driver check HDMI OUI but VSDB payload size at least five bytes. > That may c

[PULL] drm-intel-gt-next

2021-12-23 Thread Tvrtko Ursulin
Hi Dave, Daniel, Here goes the final PR towards 5.17. Effectively two largest logical items in this pull request are bugfixes, mainly in the GuC submission backend, and continuation of the locking refactoring being done to make both VMA and backing store handling use dma_resv locking. This is n

Re: [PATCH v2 1/6] drm/plane: Make format_mod_supported truly optional

2021-12-23 Thread Ville Syrjälä
On Wed, Dec 22, 2021 at 10:05:47AM +0100, José Expósito wrote: > The documentation for "drm_plane_funcs.format_mod_supported" reads: > > This *optional* hook is used for the DRM to determine if the given > format/modifier combination is valid for the plane. This allows the > DRM to generate

Re: [Intel-gfx] [PATCH] drm/i915: Use trylock instead of blocking lock for __i915_gem_free_objects.

2021-12-23 Thread Maarten Lankhorst
On 2021-12-22 20:43, Thomas Hellström (Intel) wrote: > > On 12/22/21 16:56, Maarten Lankhorst wrote: >> Convert free_work into delayed_work, similar to ttm to allow converting the >> blocking lock in __i915_gem_free_objects to a trylock. >> >> Unlike ttm, the object should already be idle, as it's

Re: [Intel-gfx] [PATCH] drm/i915/guc: Log engine resets

2021-12-23 Thread Tvrtko Ursulin
On 22/12/2021 21:58, John Harrison wrote: On 12/22/2021 08:21, Tvrtko Ursulin wrote: On 21/12/2021 22:14, John Harrison wrote: On 12/21/2021 05:37, Tvrtko Ursulin wrote: On 20/12/2021 18:34, John Harrison wrote: On 12/20/2021 07:00, Tvrtko Ursulin wrote: On 17/12/2021 16:22, Matthew Brost

RE: [RFC v2 8/8] drm/amd/virt: Drop concurrent GPU reset protection for SRIOV

2021-12-23 Thread Liu, Monk
[AMD Official Use Only] @Chen, Horace @Chen, JingWen @Deng, Emily Please take a review on Andrey's patch Thanks --- Monk Liu | Cloud GPU & Virtualization Solution | AMD -

Re: [PATCH v2 1/6] drm/plane: Make format_mod_supported truly optional

2021-12-23 Thread Simon Ser
On Wednesday, December 22nd, 2021 at 10:05, José Expósito wrote: > Make "create_in_format_blob" behave as documented. LGTM, nice! Reviewed-by: Simon Ser CC Ville just in case

Re: [PATCH v2 2/6] drm/plane: Fix typo in format_mod_supported documentation

2021-12-23 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [Intel-gfx] [PATCH] drm/i915/guc: Use lockless list for destroyed contexts

2021-12-23 Thread Tvrtko Ursulin
On 22/12/2021 23:29, Matthew Brost wrote: Use a lockless list structure for destroyed contexts to avoid hammering on global submission spin lock. Thanks for looking into it quickly! On the topic of "lockless" yes I agree the llist in principle is not a concern. That part looks fine to me. O

Re: Empty IN_FORMATS in sun4i-drm

2021-12-23 Thread Emmanuel Gil Peyrot
On Tue, Dec 14, 2021 at 06:58:56PM +0100, Jernej Škrabec wrote: > Dne torek, 14. december 2021 ob 13:02:48 CET je Emmanuel Gil Peyrot > napisal(a): > > Hi, > > > > After updating Weston from 9f8561e9 to 07326040 (latest master), it > > fails to run on my PinePhone saying “format 0x34325258 not su

[PULL] drm-misc-next-fixes

2021-12-23 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the PR for drm-misc-next-fixes for what will become Linux 5.17. There are several fixes for vmwgfx's recent conversion to GEM and a fix for bridge DT bindinds. Besides the fixes, a backmerge updated drm-misc-next-fixes to the state of drm-next before the feature freeze.

Re: [PATCH v4 0/6] drm: exynos: dsi: Convert drm bridge

2021-12-23 Thread Marek Szyprowski
Hi Jagan, On 18.12.2021 00:16, Marek Szyprowski wrote: > On 15.12.2021 15:56, Jagan Teki wrote: >> On Wed, Dec 15, 2021 at 7:49 PM Marek Szyprowski >> wrote: >>> On 15.12.2021 13:57, Jagan Teki wrote: On Wed, Dec 15, 2021 at 5:31 PM Marek Szyprowski wrote: > On 15.12.2021 11:15, Ja

Re: completely rework the dma_resv semantic

2021-12-23 Thread Christian König
Am 22.12.21 um 23:17 schrieb Daniel Vetter: On Fri, Dec 17, 2021 at 03:39:52PM +0100, Christian König wrote: Hi Daniel, looks like this is going nowhere and you don't seem to have time to review. What can we do? cc more people, you didn't cc any of the driver folks :-) Well I've CCed more p

Re: [RFC v2 8/8] drm/amd/virt: Drop concurrent GPU reset protection for SRIOV

2021-12-23 Thread Christian König
Am 22.12.21 um 23:14 schrieb Andrey Grodzovsky: Since now flr work is serialized against GPU resets there is no need for this. Signed-off-by: Andrey Grodzovsky Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c | 11 --- drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c |

Re: [RFC v2 4/8] drm/amdgpu: Serialize non TDR gpu recovery with TDRs

2021-12-23 Thread Christian König
Am 22.12.21 um 23:05 schrieb Andrey Grodzovsky: Use reset domain wq also for non TDR gpu recovery trigers such as sysfs and RAS. We must serialize all possible GPU recoveries to gurantee no concurrency there. For TDR call the original recovery function directly since it's already executed from wi

Re: [RFC v2 3/8] drm/amdgpu: Fix crash on modprobe

2021-12-23 Thread Christian König
Am 22.12.21 um 23:05 schrieb Andrey Grodzovsky: Restrict jobs resubmission to suspend case only since schedulers not initialised yet on probe. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [RFC v2 2/8] drm/amdgpu: Move scheduler init to after XGMI is ready

2021-12-23 Thread Christian König
Am 22.12.21 um 23:05 schrieb Andrey Grodzovsky: Before we initialize schedulers we must know which reset domain are we in - for single device there iis a single domain per device and so single wq per device. For XGMI the reset domain spans the entire XGMI hive and so the reset wq is per hive. Si

[PATCH 1/1] drm/vkms: add zpos plane property

2021-12-23 Thread José Expósito
Add support for the zpos plane property. Depending on the plane type: - Primary and cursor planes: Create an immutable zpos property. The primary plane is always at the bottom and the cursor plane is always on the top. - Overlay planes: Create a mutable zpos property allowing to change their

[PATCH 0/1] drm/vkms: zpos

2021-12-23 Thread José Expósito
Hi all, This patch adds support for the zpos plane prop in the VKMS driver. It should be applied after the "drm/vkms: add support for multiple overlay planes" series [1] because this new patch takes advantage of the "num_overlay_planes" module parameter to set the maximum and minimum overlay plan