Re: [PATCH v2] dma-buf: dma-heap: Add a size check for allocation

2022-01-03 Thread Christian König
Am 03.01.22 um 19:57 schrieb John Stultz: On Mon, Dec 27, 2021 at 1:52 AM wrote: From: Guangming Thanks for submitting this! Add a size check for allcation since the allocation size is nit: "allocation" above. always less than the total DRAM size. In general, it might be good to add

Re: [PATCH] dma-buf: cma_heap: Fix mutex locking section

2022-01-03 Thread John Stultz
On Mon, Jan 3, 2022 at 11:36 PM Weizhao Ouyang wrote: > > Fix cma_heap_buffer mutex locking critical section to protect vmap_cnt > and vaddr. > > Fixes: a5d2d29e24be ("dma-buf: heaps: Move heap-helper logic into the > cma_heap implementation") > Signed-off-by: Weizhao Ouyang Looks good to me!

Re: [PATCH v4] drm/mediatek: Fix mtk_cec_mask()

2022-01-03 Thread Chun-Kuang Hu
Hi, Miles: Miles Chen 於 2022年1月3日 週一 下午1:47寫道: > > In current implementation, mtk_cec_mask() writes val into target register > and ignores the mask. After talking to our hdmi experts, mtk_cec_mask() > should read a register, clean only mask bits, and update (val | mask) bits > to the register.

RE: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2022-01-03 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Thomas Hellström > Sent: January 3, 2022 1:58 PM > To: Zeng, Oak ; intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org > Cc: Auld, Matthew > Subject: Re: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the vma resource as > argument

Re: [PATCH v9 2/6] drm/i915: Use to_gt() helper for GGTT accesses

2022-01-03 Thread Matt Roper
On Tue, Dec 21, 2021 at 09:46:29PM +0200, Andi Shyti wrote: > Hi Matt, > > > > diff --git a/drivers/gpu/drm/i915/i915_perf.c > > > b/drivers/gpu/drm/i915/i915_perf.c > > > index 170bba913c30..128315aec517 100644 > > > --- a/drivers/gpu/drm/i915/i915_perf.c > > > +++

Re: softlockup in v5.15.12 in dcn20_post_unlock_program_front_end

2022-01-03 Thread Jeff Layton
On Sun, 2022-01-02 at 09:30 -0500, Jeff Layton wrote: > I'm seeing a reproducible softlockup on amdgpu on v5.15.12: > > [ 861.656146] [drm:dc_dmub_srv_wait_idle [amdgpu]] *ERROR* Error waiting for > DMUB idle: status=3 > [ 861.914848] [drm:dc_dmub_srv_wait_idle [amdgpu]] *ERROR* Error waiting

Re: [PATCH v2 08/11] lib: add support for device coherent type in test_hmm

2022-01-03 Thread Liam Howlett
* Alex Sierra [211206 14:00]: > Device Coherent type uses device memory that is coherently accesible by > the CPU. This could be shown as SP (special purpose) memory range > at the BIOS-e820 memory enumeration. If no SP memory is supported in > system, this could be faked by setting

Re: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2022-01-03 Thread Thomas Hellström
Hi, Oak. On 1/3/22 19:17, Zeng, Oak wrote: Regards, Oak -Original Message- From: Intel-gfx On Behalf Of Thomas Hellström Sent: January 3, 2022 7:00 AM To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: Thomas Hellström ; Auld, Matthew Subject: [Intel-gfx]

Re: [PATCH v2] dma-buf: dma-heap: Add a size check for allocation

2022-01-03 Thread John Stultz
On Mon, Dec 27, 2021 at 1:52 AM wrote: > > From: Guangming > Thanks for submitting this! > Add a size check for allcation since the allocation size is nit: "allocation" above. > always less than the total DRAM size. In general, it might be good to add more context to the commit message to

Re: [PATCH RESEND] dma-buf: heaps: Fix mutex lock area and generalize struct dma_heap_attachment

2022-01-03 Thread John Stultz
On Tue, Dec 28, 2021 at 11:09 PM Weizhao Ouyang wrote: > > Fix cma_heap_buffer mutex lock area to protect vmap_cnt and vaddr. And > move struct dma_heap_attachment to dma-heap.h so that vendor dma heaps > can use it, the same behaviour as struct dma_buf_attachment. > Hey! Thanks for submitting

RE: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2022-01-03 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Intel-gfx On Behalf Of Thomas > Hellström > Sent: January 3, 2022 7:00 AM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Thomas Hellström ; Auld, Matthew > > Subject: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the

[Bug 215436] admgpu: suspend and resuming from suspend don't work

2022-01-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215436 --- Comment #18 from spassw...@web.de --- The problem seems to be that rn_update_clocks tries to call rn_vbios_smu_set_dcn_low power before adev->in_s0ix is set to 1 in amdpgu_pmops_suspend: Changes to rn_update_clocks: dev_info(adev->dev,

[Bug 215436] admgpu: suspend and resuming from suspend don't work

2022-01-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215436 mario.limoncie...@amd.com changed: What|Removed |Added Attachment #300214|0 |1 is obsolete|

[PATCH 5/5] drm/vc4: dpi: Support DPI interface in mode3 for RGB565

2022-01-03 Thread Chris Morgan
From: Chris Morgan Add support for the VC4 DPI driver to utilize DPI mode 3. This is defined here as xxxRxxGGxxxB: https://www.raspberrypi.com/documentation/computers/raspberry-pi.html#parallel-display-interface-dpi This mode is required to use the Geekworm MZP280 DPI display.

[PATCH 4/5] drm/panel: simple: add Geekworm MZP280 Panel

2022-01-03 Thread Chris Morgan
From: Chris Morgan Add support for the Geekworm MZP280 Panel Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/panel-simple.c | 29 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c

[PATCH 3/5] dt-bindings: display: simple: add Geekworm MZP280 Panel

2022-01-03 Thread Chris Morgan
From: Chris Morgan The Geekworm MZP280 panel is a 480x640 (portrait) panel with a capacitive touch interface and a 40 pin header meant to interface directly with the Raspberry Pi. The screen is 2.8 inches diagonally, and there appear to be at least 4 distinct versions all with the same panel

[PATCH 2/5] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI

2022-01-03 Thread Chris Morgan
From: Chris Morgan Add the MEDIA_BUS_FMT_RGB565_1X24_CPADHI format used by the Geekworm MZP280 panel for the Raspberry Pi. Signed-off-by: Chris Morgan --- include/uapi/linux/media-bus-format.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 1/5] media: uapi: Document format MEDIA_BUS_FMT_RGB565_1X24_CPADHI

2022-01-03 Thread Chris Morgan
From: Chris Morgan Add support for MEDIA_BUS_FMT_RGB565_1X24_CPADHI. This format is used by the Geekworm MZP280 panel which interfaces with the Raspberry Pi. Signed-off-by: Chris Morgan --- .../media/v4l/subdev-formats.rst | 37 +++ 1 file changed, 37

[PATCH 0/5] Support Geekworm MZP280 Panel for Raspberry Pi

2022-01-03 Thread Chris Morgan
From: Chris Morgan This patch series is to add support for the MZP280 panel for the Raspberry Pi. This panel requires adding support for Mode 3 of the Raspberry Pi DPI connector, which necessitates a new media bus format. This patch series has been tested on my Raspberry Pi 4 with version 1 of

[PATCH AUTOSEL 5.10 7/8] drm/amd/display: Added power down for DCN10

2022-01-03 Thread Sasha Levin
From: "Lai, Derek" [ Upstream commit d97e631af2db84c8c9d63abf68d487d0bb559e4c ] [Why] The change of setting a timer callback on boot for 10 seconds is still working, just lacked power down for DCN10. [How] Added power down for DCN10. Tested-by: Daniel Wheeler Reviewed-by: Anthony Koo

[PATCH AUTOSEL 5.15 14/16] drm/amd/display: Added power down for DCN10

2022-01-03 Thread Sasha Levin
From: "Lai, Derek" [ Upstream commit d97e631af2db84c8c9d63abf68d487d0bb559e4c ] [Why] The change of setting a timer callback on boot for 10 seconds is still working, just lacked power down for DCN10. [How] Added power down for DCN10. Tested-by: Daniel Wheeler Reviewed-by: Anthony Koo

[PATCH AUTOSEL 5.15 13/16] drm/amd/display: fix B0 TMDS deepcolor no dislay issue

2022-01-03 Thread Sasha Levin
From: Charlene Liu [ Upstream commit 2eb82577a16d4c8eb31e4ed520649850bb95b223 ] [why] B0 PHY C map to F, D map to G driver use logic instance, dmub does the remap. Driver still need use the right PHY instance to access right HW. [how] use phyical instance when program PHY register. [note]

[PATCH AUTOSEL 5.15 11/16] drm/amdgpu: put SMU into proper state on runpm suspending for BOCO capable platform

2022-01-03 Thread Sasha Levin
From: Evan Quan [ Upstream commit 7be3be2b027c12e84833b3dc9597d3bb7e4c5464 ] By setting mp1_state as PP_MP1_STATE_UNLOAD, MP1 will do some proper cleanups and put itself into a state ready for PNP. That can workaround some random resuming failure observed on BOCO capable platforms.

[PATCH AUTOSEL 5.15 10/16] drm/amdgpu: always reset the asic in suspend (v2)

2022-01-03 Thread Sasha Levin
From: Alex Deucher [ Upstream commit daf8de0874ab5b74b38a38726fdd3d07ef98a7ee ] If the platform suspend happens to fail and the power rail is not turned off, the GPU will be in an unknown state on resume, so reset the asic so that it will be in a known good state on resume even if the platform

[PATCH AUTOSEL 5.15 09/16] drm/amd/pm: skip setting gfx cgpg in the s0ix suspend-resume

2022-01-03 Thread Sasha Levin
From: Prike Liang [ Upstream commit 8c45096c60d6ce6341c374636100ed1b2c1c33a1 ] In the s0ix entry need retain gfx in the gfxoff state,so here need't set gfx cgpg in the S0ix suspend-resume process. Moreover move the S0ix check into SMU12 can simplify the code condition check. Bug:

[PATCH AUTOSEL 5.15 03/16] drm/amd/pm: Fix xgmi link control on aldebaran

2022-01-03 Thread Sasha Levin
From: Lijo Lazar [ Upstream commit 19e66d512e4182a0461530fa3159638e0f55d97e ] Fix the message argument. 0: Allow power down 1: Disallow power down Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.15 02/16] drm/amdgpu: fix dropped backing store handling in amdgpu_dma_buf_move_notify

2022-01-03 Thread Sasha Levin
From: Christian König [ Upstream commit fc74881c28d314b10efac016ef49df4ff40b8b97 ] bo->tbo.resource can now be NULL. Signed-off-by: Christian König Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1811 Acked-by: Alex Deucher Link:

[Bug 215436] admgpu: suspend and resuming from suspend don't work

2022-01-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215436 --- Comment #16 from spassw...@web.de --- Added a dev_info: dev_info(adev->dev, "adev->in_s0ix = %d\n", adev->in_s0ix); if (display_count == 0 && (adev->in_s0ix || !hpd_state)) { with the result: It seems that adev->in_s0ix = 0 during suspend.

[Bug 215436] admgpu: suspend and resuming from suspend don't work

2022-01-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215436 mario.limoncie...@amd.com changed: What|Removed |Added CC||mario.limoncie...@amd.com

[PATCH 3/4] phy: mediatek: phy-mtk-hdmi: Reorder and stop implicit header inclusion

2022-01-03 Thread AngeloGioacchino Del Regno
All the headers for phy-mtk-{hdmi,hdmi-mt2701,hdmi-mt8183}.c were included from phy-mtk-mipi-dsi.h, but this isn't optimal: in order to increase readability and sensibly reduce build times, the inclusions should be done per-file, also avoiding to include unused headers and should not be implicit.

[PATCH 4/4] phy: mediatek: phy-mtk-hdmi: Simplify with dev_err_probe()

2022-01-03 Thread AngeloGioacchino Del Regno
Use the dev_err_probe() helper to simplify error handling during probe. Signed-off-by: AngeloGioacchino Del Regno --- drivers/phy/mediatek/phy-mtk-hdmi.c | 50 +++-- 1 file changed, 19 insertions(+), 31 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c

[PATCH 2/4] phy: mediatek: phy-mtk-hdmi: Reorder to remove forward declarations

2022-01-03 Thread AngeloGioacchino Del Regno
Forward declarations for mtk_hdmi_power_{on,off} aren't necessary: move mtk_hdmi_phy_dev_ops down to remove forward declarations. Signed-off-by: AngeloGioacchino Del Regno --- drivers/phy/mediatek/phy-mtk-hdmi.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git

[PATCH 1/4] phy: mediatek: phy-mtk-hdmi: Switch to regmap for mmio access

2022-01-03 Thread AngeloGioacchino Del Regno
Switch to using the generic regmap API instead of calls to readl/writel for MMIO register access, removing custom crafted update/set/clear_bits functions and also allowing us to reduce code size. Signed-off-by: AngeloGioacchino Del Regno --- drivers/phy/mediatek/phy-mtk-hdmi-mt2701.c | 165

[Bug 215443] [radeon] BUG: Unable to handle kernel data access on read at 0xc007ffffffff9130, Oops: Kernel access of bad area, sig: 11 [#1]

2022-01-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215443 --- Comment #3 from Erhard F. (erhar...@mailbox.org) --- (In reply to Alex Deucher from comment #2) > does appending amdgpu.runpm=0 on the kernel command line help? I doubt it as amdgpu is not even built (# CONFIG_DRM_AMDGPU is not set, see

[Bug 215443] [radeon] BUG: Unable to handle kernel data access on read at 0xc007ffffffff9130, Oops: Kernel access of bad area, sig: 11 [#1]

2022-01-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215443 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH 22/22] drm: rockchip: Add VOP2 driver

2022-01-03 Thread Sascha Hauer
Hi Nicolas, Thanks for the review. I have changed the points I don't comment on here according to your suggestions. > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > Alphabetically sort these includes? Not

[PATCH 3/3] phy: mediatek: phy-mtk-mipi-dsi: Simplify with dev_err_probe()

2022-01-03 Thread AngeloGioacchino Del Regno
Use the dev_err_probe() helper to simplify error handling during probe. Signed-off-by: AngeloGioacchino Del Regno --- drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 29 + 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c

[PATCH 2/3] phy: mediatek: phy-mtk-mipi-dsi: Reorder and stop implicit header inclusion

2022-01-03 Thread AngeloGioacchino Del Regno
All the headers for phy-mtk-mipi-{dsi,dsi-mt8173,dsi-mt8183}.c were included from phy-mtk-mipi-dsi.h, but this isn't optimal: in order to increase readability and sensibly reduce build times, the inclusions should be done per-file, also avoiding to include unused headers and should not be

[PATCH 1/3] phy: mediatek: phy-mtk-mipi-dsi: Switch to regmap for mmio access

2022-01-03 Thread AngeloGioacchino Del Regno
Switch to using the generic regmap API instead of calls to readl/writel for MMIO register access, removing custom crafted update/set/clear_bits functions and also allowing us to reduce code size. Signed-off-by: AngeloGioacchino Del Regno --- .../phy/mediatek/phy-mtk-mipi-dsi-mt8173.c| 45

Re: [PATCH v2] drm/mediatek: Set default value for Panel Orientation connector prop.

2022-01-03 Thread Chun-Kuang Hu
Hi, Mark: Mark Yacoub 於 2021年12月30日 週四 上午2:44寫道: > > [Why] > Creating the prop uses UNKNOWN as the initial value, which is not a > supported value if the prop is to be supported. > > [How] > Set the panel orientation default value to NORMAL right after creating > the prop if no DSI panel exists.

Re: [PATCH 1/2] drm/i2c/tda998x: Switch to atomic operations

2022-01-03 Thread Fabio Estevam
Hi Laurent, On Mon, Jan 3, 2022 at 8:48 AM Laurent Pinchart wrote: > With the comment from 2/2 taken into account, > > Reviewed-by: Laurent Pinchart Thanks for the review. I addressed your feedback and sent v2. I noticed a problem when removing/inserting the HDMI cable. If I boot the board

[PATCH v2 2/2] drm/i2c/tda998x: Implement atomic_get_input_bus_fmts

2022-01-03 Thread Fabio Estevam
Implement the .atomic_get_input_bus_fmts callback to let the bridge indicate the pixel format it requires on the parallel bus to the LCDIF. Based on Marek's commit db8b7ca5b232 ("drm/bridge: ti-sn65dsi83: Replace connector format patching with atomic_get_input_bus_fmts"). Tested on a

[PATCH v2 1/2] drm/i2c/tda998x: Switch to atomic operations

2022-01-03 Thread Fabio Estevam
Use the atomic version of the enable/disable operations to continue the transition to the atomic API, started with the introduction of .atomic_get_input_bus_fmts(). This will be needed to access the mode from the atomic state. Based on Laurent's commit a6ea7d268a63("drm: bridge: ti-sn65dsi83:

Re: [PATCH 11/24] drm/amdgpu: use dma_resv_for_each_fence for CS workaround

2022-01-03 Thread Christian König
Am 22.12.21 um 22:37 schrieb Daniel Vetter: On Tue, Dec 07, 2021 at 01:33:58PM +0100, Christian König wrote: Get the write fence using dma_resv_for_each_fence instead of accessing it manually. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 9 ++--- 1

[PATCH v4 4/4] drm/i915: Use struct vma_resource instead of struct vma_snapshot

2022-01-03 Thread Thomas Hellström
There is always a struct vma_resource guaranteed to be alive when we access a corresponding struct vma_snapshot. So ditch the latter and instead of allocating vma_snapshots, reference the already existning vma_resource. This requires a couple of extra members in struct vma_resource but that's a

[PATCH v4 3/4] drm/i915: Use vma resources for async unbinding

2022-01-03 Thread Thomas Hellström
Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration code. Ideally these unbind fences should be coalesced with the migration blit fence to

[PATCH v4 2/4] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2022-01-03 Thread Thomas Hellström
When introducing asynchronous unbinding, the vma itself may no longer be alive when the actual binding or unbinding takes place. Update the gtt i915_vma_ops accordingly to take a struct i915_vma_resource instead of a struct i915_vma for the bind_vma() and unbind_vma() ops. Similarly change the

[PATCH v4 1/4] drm/i915: Initial introduction of vma resources

2022-01-03 Thread Thomas Hellström
Introduce vma resources, sort of similar to TTM resources, needed for asynchronous bind management. Initially we will use them to hold completion of unbinding when we capture data from a vma, but they will be used extensively in upcoming patches for asynchronous vma unbinding. Signed-off-by:

[PATCH v4 0/4] drm/i915: Asynchronous vma unbinding

2022-01-03 Thread Thomas Hellström
This patch series introduces infrastructure for asynchronous vma unbinding. The single enabled use-case is initially at buffer object migration where we otherwise sync when unbinding vmas before migration. This in theory allows us to pipeline any number of migrations, but in practice the number is

Re: [PATCH 1/3] dt-bindings: display: meson-dw-hdmi: add missing sound-name-prefix property

2022-01-03 Thread Neil Armstrong
On 03/01/2022 12:32, Neil Armstrong wrote: > On 23/12/2021 13:24, Alexander Stein wrote: >> This is used in meson-gx and meson-g12. Add the property to the binding. >> This fixes the dtschema warning: >> hdmi-tx@c883a000: 'sound-name-prefix' does not match any of the >> regexes: 'pinctrl-[0-9]+'

Re: [PATCH 1/2] drm/i2c/tda998x: Switch to atomic operations

2022-01-03 Thread Laurent Pinchart
Hi Fabio, Thank you for the patch. On Thu, Dec 30, 2021 at 10:39:29PM -0300, Fabio Estevam wrote: > Use the atomic version of the enable/disable operations to continue the > transition to the atomic API, started with the introduction of > .atomic_get_input_bus_fmts(). This will be needed to

Re: [PATCH 2/2] drm/i2c/tda998x: Implement atomic_get_input_bus_fmts

2022-01-03 Thread Laurent Pinchart
Hi Fabio, Thank you for the patch. On Thu, Dec 30, 2021 at 10:39:30PM -0300, Fabio Estevam wrote: > Implement the .atomic_get_input_bus_fmts callback to let the bridge > indicate the pixel format it requires on the parallel bus to the LCDIF. > > Based on Marek's commit db8b7ca5b232

[PATCH 3/3] drm/panel: nt35560: Support also ACX424AKM

2022-01-03 Thread Linus Walleij
Add some code and config to also support the ACX424AKM used in some Sony (Ericsson) Mobile phones. Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-novatek-nt35560.c | 72 ++- 1 file changed, 69 insertions(+), 3 deletions(-) diff --git

[PATCH 2/3] drm/panel: nt35560: Support more panel IDs

2022-01-03 Thread Linus Walleij
These IDs were found in the wild in a Sony Xperia vendor tree. Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-novatek-nt35560.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35560.c

[PATCH 1/3] drm/panel: Rename Sony ACX424 to Novatek NT35560

2022-01-03 Thread Linus Walleij
A code drop from Sony Mobile reveals that the ACX424 panels are built around the Novatek NT35560 panel controllers so just bite the bullet and rename the driver and all basic symbols so that we can modify this driver to cover any other panels also using the Novatek NT35560 display controller.

Re: [PATCH 1/3] dt-bindings: display: meson-dw-hdmi: add missing sound-name-prefix property

2022-01-03 Thread Neil Armstrong
On 23/12/2021 13:24, Alexander Stein wrote: > This is used in meson-gx and meson-g12. Add the property to the binding. > This fixes the dtschema warning: > hdmi-tx@c883a000: 'sound-name-prefix' does not match any of the > regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Alexander Stein > --- >

Re: [PATCH 1/2] drm/meson: osd_afbcd: Add an exit callback to struct meson_afbcd_ops

2022-01-03 Thread Neil Armstrong
On 31/12/2021 00:55, Martin Blumenstingl wrote: > Use this to simplify the driver shutdown. It will also come handy when > fixing the error handling in meson_drv_bind_master(). > > Signed-off-by: Martin Blumenstingl > --- > drivers/gpu/drm/meson/meson_drv.c | 6 ++-- >

Re: [PATCH 2/2] drm/meson: Fix error handling when afbcd.ops->init fails

2022-01-03 Thread Neil Armstrong
On 31/12/2021 00:55, Martin Blumenstingl wrote: > When afbcd.ops->init fails we need to free the struct drm_device. Also > all errors which come after afbcd.ops->init was successful need to exit > the AFBCD, just like meson_drv_unbind() does. > > Fixes: d1b5e41e13a7e9 ("drm/meson: Add AFBCD

Re: [PATCH 04/24] dma-buf: add dma_resv_get_singleton v2

2022-01-03 Thread Christian König
Am 22.12.21 um 22:21 schrieb Daniel Vetter: On Tue, Dec 07, 2021 at 01:33:51PM +0100, Christian König wrote: Add a function to simplify getting a single fence for all the fences in the dma_resv object. v2: fix ref leak in error handling Signed-off-by: Christian König ---

Re: [PATCH 01/24] dma-buf: add dma_resv_replace_fences

2022-01-03 Thread Christian König
Am 22.12.21 um 22:05 schrieb Daniel Vetter: On Tue, Dec 07, 2021 at 01:33:48PM +0100, Christian König wrote: This function allows to replace fences from the shared fence list when we can gurantee that the operation represented by the original fence has finished or no accesses to the resources

Re: [PATCH v2] drm/bridge: sn65dsi83: Fix an error handling path in sn65dsi83_probe()

2022-01-03 Thread Robert Foss
Applied to drm-misc-next

[Bug 215436] admgpu: suspend and resuming from suspend don't work

2022-01-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215436 --- Comment #14 from spassw...@web.de --- Created attachment 300212 --> https://bugzilla.kernel.org/attachment.cgi?id=300212=edit dmesg with linux-5.16-rc8 while ignoring adev->in_s0ix Simply ignoring the value of adev->in_s0ix and calling

Re: [PATCH] radeon: add a force flush to delay work when radeon suspend

2022-01-03 Thread Christian König
Am 25.12.21 um 03:56 schrieb 周雪梅: Although radeon card fence and wait for gpu to finish processing current batch rings, there is still a corner case that radeon lockup work queue may not be fully flushed, and meanwhile the radeon_suspend_kms() function has called pci_set_power_state() to put

[Bug 215436] admgpu: suspend and resuming from suspend don't work

2022-01-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215436 --- Comment #13 from spassw...@web.de --- I added a some dev_info calls: static int amdgpu_pmops_suspend(struct device *dev) { struct drm_device *drm_dev = dev_get_drvdata(dev); struct amdgpu_device *adev = drm_to_adev(drm_dev);

Re: [RFC v2 8/8] drm/amd/virt: Drop concurrent GPU reset protection for SRIOV

2022-01-03 Thread Christian König
Please don't. This patch is vital to the cleanup of the reset procedure. If SRIOV doesn't work with that we need to change SRIOV and not the driver. Christian. Am 30.12.21 um 19:45 schrieb Andrey Grodzovsky: Sure, I guess i can drop this patch then. Andrey On 2021-12-24 4:57 a.m., JingWen

[PATCH] drm/panel: Extend ACX424AKP bindings to ACX424AKM

2022-01-03 Thread Linus Walleij
The panel ACX424AKP seems to only be used in prototypes, whereas real products use the 10 pixels shorter ACX424AKM. Extend the ACX424AKP bindings to also cover the ACX424AKM. The ACX424AKM was used in a few different mobile phones from Sony Mobile. Cc: devicet...@vger.kernel.org Cc:

[Bug 215436] admgpu: suspend and resuming from suspend don't work

2022-01-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215436 spassw...@web.de changed: What|Removed |Added Kernel Version|5.16-rc{1-7}|5.16-rc{1-8} -- You may reply to

[Bug 215436] admgpu: suspend and resuming from suspend don't work

2022-01-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215436 --- Comment #12 from spassw...@web.de --- Suspend works again if I ignore hpd_state in rn_update_clocks. // if (display_count == 0 && !hpd_state) { if (display_count == 0) { -- You may reply to this email to add a comment. You

[Bug 215436] admgpu: suspend and resuming from suspend don't work

2022-01-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215436 --- Comment #11 from spassw...@web.de --- Created attachment 300211 --> https://bugzilla.kernel.org/attachment.cgi?id=300211=edit dmesg with linux-5.16-rc8 With linux-5.16-rc8, suspend does still not work properly (fan stays on). Resume seemed

Re: [PATCH v10 19/22] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support

2022-01-03 Thread CK Hu
Hi, Nancy: On Wed, 2021-12-08 at 10:44 +0800, Nancy.Lin wrote: > MT8195 have two mmsys. Modify drm for MT8195 multi-mmsys support. > The two mmsys (vdosys0 and vdosys1) will bring up two drm drivers, > only one drm driver register as the drm device. > Each drm driver binds its own component. The

回复: Re: [PATCH] gpu/drm/radeon:Fix null pointer risk

2022-01-03 Thread 温志伟
   Then the judgment in line 944 is needed. Are the possibilities of these two positions consistent.Why keep this judgment?Regards,Wen Zhiwei.           主 题:Re: [PATCH] gpu/drm/radeon:Fix null pointer risk            日 期:2021-12-31 00:36            发件人:Christian König            收件人:Wen

Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning

2022-01-03 Thread miles.chen
> I'm still not happy with the commit subject, I think it is misleading. Clang > only helped to find the bug, but the we are fixing something else, that's not > just a clang warning. But I don't want to nit-pick too much so: > > Reviewed-by: Matthias Brugger thanks. I think you are right. I

[PATCH v4] drm/mediatek: Fix mtk_cec_mask()

2022-01-03 Thread Miles Chen
In current implementation, mtk_cec_mask() writes val into target register and ignores the mask. After talking to our hdmi experts, mtk_cec_mask() should read a register, clean only mask bits, and update (val | mask) bits to the register. Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") Cc: