[PATCH] drm/i915: Clarify vma lifetime

2022-02-09 Thread Thomas Hellström
It's unclear what reference the initial vma kref refernce refers to. A vma can have multiple weak references, the object vma list, the vm's bound list and the GT's closed_list, and the initial vma reference can be put from lookups of all these lists. With the current implementation this means that

Re: [PATCH] drm/amdgpu: Fix compile error.

2022-02-09 Thread Christian König
Am 10.02.22 um 04:17 schrieb Andrey Grodzovsky: Seems I forgot to add this to the relevant commit when submitting. Rebase/merge issue? Looks like it. Signed-off-by: Andrey Grodzovsky Reported-by: kernel test robot Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_re

Re: [PATCH v5 22/23] drm: rockchip: Add VOP2 driver

2022-02-09 Thread Michael Riesch
Hello Sascha, On 2/9/22 10:53, Sascha Hauer wrote: > From: Andy Yan > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > It replaces the VOP unit found in the older Rockchip SoCs. > > This driver has been derived from the downstream Rockchip Kernel and > heavily modified:

[PATCH v4 03/13] drm/msm/disp/dpu1: Add support for DSC

2022-02-09 Thread Vinod Koul
Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Reviewed-by: Dmitry Baryshkov Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/Makefile | 1 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 13 ++ drivers/gpu/drm/

[PATCH v4 02/13] drm/msm/dsi: Pass DSC params to drm_panel

2022-02-09 Thread Vinod Koul
When DSC is enabled, we need to pass the DSC parameters to panel driver as well, so add a dsc parameter in panel and set it when DSC is enabled Also, fetch and pass DSC configuration for DSI panels to DPU encoder, which will enable and configure DSC hardware blocks accordingly. Signed-off-by: Dmi

[PATCH v4 01/13] drm/msm/dsi: add support for dsc data

2022-02-09 Thread Vinod Koul
Display Stream Compression (DSC) parameters need to be calculated. Add helpers and struct msm_display_dsc_config in msm_drv for this msm_display_dsc_config uses drm_dsc_config for DSC parameters. Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 132 +

[PATCH v4 00/13] drm/msm: Add Display Stream Compression Support

2022-02-09 Thread Vinod Koul
Display Stream Compression (DSC) compresses the display stream in host which is later decoded by panel. This series enables this for Qualcomm msm driver. This was tested on Google Pixel3 phone which use LGE SW43408 panel. The changes include DSC data and hardware block enabling for DPU1 then supp

Re: [PATCH] [RFC] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-02-09 Thread Liu Ying
On Tue, 2022-02-08 at 11:02 +0100, Marek Vasut wrote: > On 2/8/22 03:41, Liu Ying wrote: > > Hello everyone, > > > > > > There are many blank areas which are undocumented, this LCDIF > > > > > CRC32 > > > > > feature, i.MX8M Mini Arteris NOC at 0x3270 , the ARM GPV > > > > > NIC- > > > > > 30

Re: [PATCH] [RFC] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-02-09 Thread Liu Ying
Hello Laurent, On Tue, 2022-02-08 at 05:03 +0200, Laurent Pinchart wrote: > Hello Liu Ying, > > On Tue, Feb 08, 2022 at 10:41:59AM +0800, Liu Ying wrote: > > On Mon, 2022-02-07 at 11:43 +0100, Marek Vasut wrote: > > > On 2/7/22 10:18, Liu Ying wrote: > > > > > > On Sun, 2022-02-06 at 19:56 +0100,

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-09 Thread Laurent Pinchart
Hi Abhinav, On Wed, Feb 09, 2022 at 05:40:29PM -0800, Abhinav Kumar wrote: > Hi Laurent > > Gentle reminder on this. I won't have time before next week I'm afraid. > On 2/6/2022 11:20 PM, Abhinav Kumar wrote: > > Hi Laurent > > > > On 2/6/2022 3:32 PM, Dmitry Baryshkov wrote: > >> On Wed, 2 Fe

[pull] amdgpu drm-fixes-5.17

2022-02-09 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.17. The following changes since commit dfd42facf1e4ada021b939b4e19c935dcdd55566: Linux 5.17-rc3 (2022-02-06 12:20:50 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.17-2022-02-09 for you to fe

Re: [PATCH v6 0/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Sui Jingfeng
On 2022/2/9 20:00, Jiaxun Yang wrote: Hi Jingfeng, Could you please keep me CCed for the for the whole thread when you respin the patch? Cuz I'm maintain MIPS/LOONGSON64 stuff and I believe this series is partially based on my work at Lemote. I will help with reviewing and explain some Loo

Re: [PATCH] drm/amdgpu: Fix compile error.

2022-02-09 Thread Alex Deucher
On Wed, Feb 9, 2022 at 10:17 PM Andrey Grodzovsky wrote: > > Seems I forgot to add this to the relevant commit > when submitting. > > Signed-off-by: Andrey Grodzovsky > Reported-by: kernel test robot Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h | 3 +-- > 1 file c

[PATCH] drm/amdgpu: Fix compile error.

2022-02-09 Thread Andrey Grodzovsky
Seems I forgot to add this to the relevant commit when submitting. Signed-off-by: Andrey Grodzovsky Reported-by: kernel test robot --- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h b/dri

Re: [PATCH 6/8] mm: don't include in

2022-02-09 Thread Alistair Popple
On Thursday, 10 February 2022 4:48:36 AM AEDT Christoph Hellwig wrote: > On Mon, Feb 07, 2022 at 04:19:29PM -0500, Felix Kuehling wrote: > > > > Am 2022-02-07 um 01:32 schrieb Christoph Hellwig: > >> Move the check for the actual pgmap types that need the free at refcount > >> one behavior into the

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-09 Thread Abhinav Kumar
Hi Laurent Gentle reminder on this. Thanks Abhinav On 2/6/2022 11:20 PM, Abhinav Kumar wrote: Hi Laurent On 2/6/2022 3:32 PM, Dmitry Baryshkov wrote: On Wed, 2 Feb 2022 at 16:26, Laurent Pinchart wrote: Hi Jani, On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: On Wed, 02 Fe

[PATCH v9 6/6] drm/i915/gt: replace cache_clflush_range

2022-02-09 Thread Michael Cheng
Replace all occurance of cache_clflush_range with drm_clflush_virt_range. This will prevent compile errors on non-x86 platforms. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 12 ++-- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 2 +-

[PATCH v9 3/6] drm/i915/gt: Drop invalidate_csb_entries

2022-02-09 Thread Michael Cheng
Drop invalidate_csb_entries and directly call drm_clflush_virt_range. This allows for one less function call, and prevent complier errors when building for non-x86 architectures. v2(Michael Cheng): Drop invalidate_csb_entries function and directly invoke drm_clflush_virt_range.

[PATCH v9 4/6] drm/i915/gt: Re-work reset_csb

2022-02-09 Thread Michael Cheng
Use drm_clflush_virt_range instead of directly invoking clflush. This will prevent compiler errors when building for non-x86 architectures. v2(Michael Cheng): Remove extra clflush v3(Michael Cheng): Remove memory barrier since drm_clflush_virt_range takes care of it. Signed-of

[PATCH v9 5/6] drm/i915/: Re-work clflush_write32

2022-02-09 Thread Michael Cheng
Use drm_clflush_virt_range instead of clflushopt and remove the memory barrier, since drm_clflush_virt_range takes care of that. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu

[PATCH v9 0/6] Use drm_clflush* instead of clflush

2022-02-09 Thread Michael Cheng
This patch series re-work a few i915 functions to use drm_clflush_virt_range instead of calling clflush or clflushopt directly. This will prevent errors when building for non-x86 architectures.

[PATCH v9 2/6] drm/i915/gt: Re-work intel_write_status_page

2022-02-09 Thread Michael Cheng
Re-work intel_write_status_page to use drm_clflush_virt_range. This will prevent compiler errors when building for non-x86 architectures. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gt/intel_engine.h | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/driv

[PATCH v9 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-02-09 Thread Michael Cheng
Add arm64 support for drm_clflush_virt_range. dcache_clean_inval_poc performs a flush by first performing a clean, follow by an invalidation operation. v2 (Michael Cheng): Use correct macro for cleaning and invalidation the dcache. v3 (Michael Cheng): Remove ifdef for asm/cach

Re: [PATCH v3 4/4] drm/msm/dp: Add driver support to utilize drm panel

2022-02-09 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-02-09 00:55:32) > Add support in the DP driver to utilize the custom eDP panels > from drm/panels. > > An eDP panel is always connected to the platform. So, the eDP > connector can be reported as always connected. The display mode > will be sourced from the panel.

Re: [PATCH v3 3/4] drm/panel-edp: Add eDP sharp panel support

2022-02-09 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-02-09 00:55:31) > Add support for the 14" sharp,lq140m1jw46 eDP panel. > > Signed-off-by: Sankeerth Billakanti > --- Can you share the edid-decode for this panel here under the cut "---"? It would help to see the timings and make sure everything matches.

Re: [PATCH v3 2/4] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-02-09 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-02-09 00:55:30) > Enable the eDP display panel support without HPD on sc7280 platform. > > Signed-off-by: Sankeerth Billakanti > --- > > Changes in v3: > - Sort the nodes alphabetically > - Use - instead of _ as node names > - Place the backlight and panel

Re: [PATCH v3 1/4] dt-bindings: display: simple: Add sharp LQ140M1JW46 panel

2022-02-09 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-02-09 00:55:29) > Add support for sharp LQ140M1JW46 display panel. It is a 14" eDP panel > with 1920x1080 display resolution. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

[PATCH v8 3/6] drm/i915/gt: Drop invalidate_csb_entries

2022-02-09 Thread Michael Cheng
Drop invalidate_csb_entries and directly call drm_clflush_virt_range. This allows for one less function call, and prevent complier errors when building for non-x86 architectures. v2(Michael Cheng): Drop invalidate_csb_entries function and directly invoke drm_clflush_virt_range.

[PATCH v8 5/6] drm/i915/: Re-work clflush_write32

2022-02-09 Thread Michael Cheng
Use drm_clflush_virt_range instead of clflushopt and remove the memory barrier, since drm_clflush_virt_range takes care of that. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu

Re: [PATCH] dt-bindings: ltk050h3146w: replace Heiko Stuebner by myself as maintainer

2022-02-09 Thread Rob Herring
On Mon, 31 Jan 2022 17:54:39 +0100, quentin.sch...@theobroma-systems.com wrote: > From: Quentin Schulz > > Heiko does not work at Theobroma Systems anymore and the boards using > those panels are downstream, maintained internally by the company, so > let's relieve Heiko of maintainership duties.

[PATCH v8 4/6] drm/i915/gt: Re-work reset_csb

2022-02-09 Thread Michael Cheng
Use drm_clflush_virt_range instead of directly invoking clflush. This will prevent compiler errors when building for non-x86 architectures. v2(Michael Cheng): Remove extra clflush v3(Michael Cheng): Remove memory barrier since drm_clflush_virt_range takes care of it. Signed-of

[PATCH v8 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-02-09 Thread Michael Cheng
Add arm64 support for drm_clflush_virt_range. dcache_clean_inval_poc performs a flush by first performing a clean, follow by an invalidation operation. v2 (Michael Cheng): Use correct macro for cleaning and invalidation the dcache. v3 (Michael Cheng): Remove ifdef for asm/cach

[PATCH v8 6/6] drm/i915/gt: replace cache_clflush_range

2022-02-09 Thread Michael Cheng
Replace all occurance of cache_clflush_range with drm_clflush_virt_range. This will prevent compile errors on non-x86 platforms. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 12 ++-- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 2 +-

[PATCH v8 2/6] drm/i915/gt: Re-work intel_write_status_page

2022-02-09 Thread Michael Cheng
Re-work intel_write_status_page to use drm_clflush_virt_range. This will prevent compiler errors when building for non-x86 architectures. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gt/intel_engine.h | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/driv

[PATCH v8 0/6] Use drm_clflush* instead of clflush

2022-02-09 Thread Michael Cheng
This patch series re-work a few i915 functions to use drm_clflush_virt_range instead of calling clflush or clflushopt directly. This will prevent errors when building for non-x86 architectures.

Re: [PATCH v5 3/6] drm/msm/dpu: get INTF blocks directly rather than through RM

2022-02-09 Thread Abhinav Kumar
On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: INTF blocks are not really handled by resource manager, they are assigned at dpu_encoder_setup_display using dpu_encoder_get_intf(). Then this allocation is passed to RM and then returned to then dpu_encoder. So allocate them outside of RM and use

Re: [PATCH v5 19/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2022-02-09 Thread Johan Jonker
Hi Sascha, Something with port and endpoint gives notifications. Somehow with the conversion of rockchip,dw-hdmi.txt to YAML not all SoC options were checked/covered (see rk3328 and rk3568). Allow multiple vop: port or port@0 1x vop -> endpoint 2x vop -> endpoint@0 -> endpoint@1 Also all

Re: [PATCH v5 2/6] drm/msm/dpu: add DSPP blocks teardown

2022-02-09 Thread Abhinav Kumar
On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: Add missing calls to dpu_hw_dspp_destroy() to free resources allocated for DSPP hardware blocks. Fixes: e47616df008b ("drm/msm/dpu: add support for color processing blocks in dpu driver") Signed-off-by: Dmitry Baryshkov Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v5 1/6] drm/msm/dpu: drop unused lm_max_width from RM

2022-02-09 Thread Abhinav Kumar
On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: No code uses lm_max_width from resource manager, so drop it. Instead of calculating the lm_max_width, code can use max_mixer_width field from the hw catalog. Signed-off-by: Dmitry Baryshkov Reviewed-by: Stephen Boyd Reviewed-by: Abhinav Kumar

Re: [PATCH 10/10] dt-bindings: display: samsung, exynos-fimd: convert to dtschema

2022-02-09 Thread Rob Herring
On Tue, 08 Feb 2022 18:18:23 +0100, Krzysztof Kozlowski wrote: > Convert the S3C/S5P/Exynos FIMD bindings to DT schema format. > > The conversion includes also updates to the bindings, matching the > current DTS and Linux driver: adding optional iommus and power-domains. > > Signed-off-by: Krzysz

Re: [PATCH 09/10] dt-bindings: display: samsung,exynos5433-mic: convert to dtschema

2022-02-09 Thread Rob Herring
On Tue, 08 Feb 2022 18:18:22 +0100, Krzysztof Kozlowski wrote: > Convert the Exynos5433 MIC bindings to DT schema format. > > The conversion includes also updates to the bindings, matching the > current DTS and Linux driver: adding optional power-domains. > > Signed-off-by: Krzysztof Kozlowski >

Re: [PATCH 08/10] dt-bindings: display: samsung, exynos-hdmi: convert to dtschema

2022-02-09 Thread Rob Herring
On Tue, 08 Feb 2022 18:18:21 +0100, Krzysztof Kozlowski wrote: > Convert the Exynos HDMI bindings to DT schema format. > > The conversion includes also updates to the bindings, matching the > current DTS and Linux driver: > 1. Add required properties: VDD supplies, power-domains. > 2. Add optional

Re: [PATCH 07/10] dt-bindings: display: samsung,exynos-mixer: convert to dtschema

2022-02-09 Thread Rob Herring
On Tue, 08 Feb 2022 18:18:20 +0100, Krzysztof Kozlowski wrote: > Convert the Exynos Mixer bindings to DT schema format. > > The conversion includes also updates to the bindings, matching the > current DTS and Linux driver: > 1. Add clocks required on Exynos4210 and Exynos4212 types of Mixer. > 2.

Re: [PATCH 06/10] dt-bindings: display: samsung,exynos-hdmi-ddc: convert to dtschema

2022-02-09 Thread Rob Herring
On Tue, 08 Feb 2022 18:18:19 +0100, Krzysztof Kozlowski wrote: > Convert the Exynos HDMI DDC bindings to DT schema format. > > Signed-off-by: Krzysztof Kozlowski > --- > .../display/exynos/exynos_hdmiddc.txt | 15 --- > .../samsung/samsung,exynos-hdmi-ddc.yaml | 42 +

[PATCH v4 4/4] drm/i915/guc: Verify hwconfig blob matches supported format

2022-02-09 Thread Jordan Justen
i915_drm.h now defines the format of the returned DRM_I915_QUERY_HWCONFIG_BLOB query item. Since i915 receives this from the black box GuC software, it should verify that the data matches that format before sending it to user-space. The verification makes a single simple pass through the blob cont

[PATCH v4 3/4] drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item

2022-02-09 Thread Jordan Justen
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct. v3: * Add various changes suggested by Tvrtko Cc: Daniel Vetter Signed-off-by: Jordan Justen Acked-by: Jon Bloomfield --- include/uapi/drm/i915_drm.h | 35 +++ 1 file changed, 35 insertions(+) diff

[PATCH v4 2/4] drm/i915/uapi: Add query for hwconfig blob

2022-02-09 Thread Jordan Justen
From: Rodrigo Vivi The DRM_I915_QUERY_HWCONFIG_BLOB query item returns a blob of data which it receives from the GuC software. This blob provides some useful data about the hardware for drivers. Although the blob is not fully documented at this time, the basic format is an array of u32 values. T

[PATCH v4 1/4] drm/i915/guc: Add fetch of hwconfig table

2022-02-09 Thread Jordan Justen
From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. Note that the table is only available on ADL-P and later platforms. Cc: Mich

[PATCH v4 0/4] GuC HWCONFIG with documentation

2022-02-09 Thread Jordan Justen
This is John/Rodrigo's 2 patches with some minor changes, and I added 2 patches. "drm/i915/uapi: Add query for hwconfig blob" was changed: * Rename DRM_I915_QUERY_HWCONFIG_TABLE to DRM_I915_QUERY_HWCONFIG_BLOB as requested by Joonas. * Reword commit message * I added Acked-by to this patc

Re: [PATCH 05/10] dt-bindings: display: samsung,exynos7-decon: convert to dtschema

2022-02-09 Thread Rob Herring
On Tue, 08 Feb 2022 18:18:18 +0100, Krzysztof Kozlowski wrote: > Convert the Exynos7 DECON display controller bindings to DT schema > format. > > Signed-off-by: Krzysztof Kozlowski > --- > .../bindings/display/exynos/exynos7-decon.txt | 65 -- > .../samsung/samsung,exynos7-decon.yaml

Re: [PATCH 04/10] dt-bindings: display: samsung,exynos5433-decon: convert to dtschema

2022-02-09 Thread Rob Herring
On Tue, 08 Feb 2022 18:18:17 +0100, Krzysztof Kozlowski wrote: > Convert the Exynos5433 DECON display controller bindings to DT schema > format. > > The conversion includes also updates to the bindings, matching the > current DTS and Linux driver: > 1. Require "fifo" interrupt. > 2. Add "dsd" as a

Re: [PATCH 03/10] dt-bindings: phy: samsung, exynos-hdmi-phy: convert to dtschema

2022-02-09 Thread Rob Herring
On Tue, 08 Feb 2022 18:18:16 +0100, Krzysztof Kozlowski wrote: > Convert the Exynos HDMI PHY bindings to DT schema format and put them > next to other PHYs. > > Signed-off-by: Krzysztof Kozlowski > --- > .../display/exynos/exynos_hdmiphy.txt | 15 --- > .../bindings/phy/samsung,exyno

Re: [PATCH] drm/msm/rd: Add chip-id

2022-02-09 Thread Dmitry Baryshkov
On 14/01/2022 21:57, Rob Clark wrote: From: Rob Clark For newer devices which deprecate gpu-id and do matching based on chip-id, we need this information in cmdstream dumps so that the decoding tools know how to decode them. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- dr

Re: [PATCH] drm/msm: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2022-02-09 Thread Dmitry Baryshkov
On 21/12/2021 17:42, cgel@gmail.com wrote: From: Changcheng Deng Fix the following coccicheck warning: ./drivers/gpu/drm/msm/msm_debugfs.c: 132: 0-23: WARNING: shrink_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for d

Re: gpu: drm: msm: use div64_u64() instead of do_div()

2022-02-09 Thread Dmitry Baryshkov
On 09/02/2022 11:37, Qing Wang wrote: From: Wang Qing do_div() does a 64-by-32 division. When the divisor is u64, do_div() truncates it to 32 bits, this means it can test non-zero and be truncated to zero for division. fix do_div.cocci warning: do_div() does a 64-by-32 division, please conside

Re: [PATCH v2 4/4] dt-bindings: display: ssd1307fb: Add myself as binding co-maintainer

2022-02-09 Thread Rob Herring
On Fri, 04 Feb 2022 14:43:47 +0100, Javier Martinez Canillas wrote: > The ssd130x DRM driver also makes use of this Device Tree binding to allow > existing users of the fbdev driver to migrate without the need to change > their Device Trees. > > Add myself as another maintainer of the binding, to

Re: [PATCH v2 2/2] drm/msm/hdmi: Remove spurious IRQF_ONESHOT flag

2022-02-09 Thread Dmitry Baryshkov
On 01/02/2022 20:47, Daniel Thompson wrote: Quoting the header comments, IRQF_ONESHOT is "Used by threaded interrupts which need to keep the irq line disabled until the threaded handler has been run.". When applied to an interrupt that doesn't request a threaded irq then IRQF_ONESHOT has a lesser

Re: [PATCH v2 1/2] drm/msm/dsi: Remove spurious IRQF_ONESHOT flag

2022-02-09 Thread Dmitry Baryshkov
On 01/02/2022 20:47, Daniel Thompson wrote: Quoting the header comments, IRQF_ONESHOT is "Used by threaded interrupts which need to keep the irq line disabled until the threaded handler has been run.". When applied to an interrupt that doesn't request a threaded irq then IRQF_ONESHOT has a lesser

Re: [PATCH 2/3] drm/msm/dpu1: Add MSM8998 to hw catalog

2022-02-09 Thread Dmitry Baryshkov
On 13/01/2022 17:51, Jami Kettunen wrote: From: AngeloGioacchino Del Regno Bringup functionality for MSM8998 in the DPU, driver which is mostly the same as SDM845 (just a few variations). Signed-off-by: AngeloGioacchino Del Regno Signed-off-by: Jami Kettunen Reviewed-by: Dmitry Baryshkov

[PATCH v6 3/5] arm64: dts: rockchip: add cooling map and trip points for gpu to rk356x

2022-02-09 Thread Michael Riesch
From: Alex Bee RK356x SoCs have a second thermal sensor for the GPU. This adds the cooling map and trip points for it to make use of its contribution as a cooling device. Signed-off-by: Alex Bee Signed-off-by: Michael Riesch --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 27 ++

[PATCH v6 5/5] arm64: dts: rockchip: enable the gpu on rk3568-evb1-v10

2022-02-09 Thread Michael Riesch
Enable the GPU core on the Rockchip RK3568 EVB1. Signed-off-by: Michael Riesch --- arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dt

[PATCH v6 4/5] arm64: dts: rockchip: enable the gpu on quartz64-a

2022-02-09 Thread Michael Riesch
From: Ezequiel Garcia Enable the GPU core on the Pine64 Quartz64 Model A. Signed-off-by: Ezequiel Garcia Signed-off-by: Alex Bee Signed-off-by: Michael Riesch --- arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/r

[PATCH v6 0/5] Add GPU for RK356x SoCs

2022-02-09 Thread Michael Riesch
Hi all, This series aims to bring the GPU support for the RK356x mainline. In conjunction with the VOP2/HDMI TX patches v4 [0]) it has been tested successfully on a RK3568 EVB1 with weston and glmark2-es2-wayland. It should be noted that on the RK3568 EVB1 the supply of the GPU power domain needs

[PATCH v6 2/5] arm64: dts: rockchip: add gpu node to rk356x

2022-02-09 Thread Michael Riesch
From: Ezequiel Garcia Rockchip SoCs RK3566 and RK3568 have a Mali Gondul core which is based on the Bifrost architecture. It has one shader core and two execution engines. Quoting the datasheet: Mali-G52 1-Core-2EE * Support 1600Mpix/s fill rate when 800MHz clock frequency * Support 38.4GLOPs w

[PATCH v6 1/5] dt-bindings: gpu: mali-bifrost: describe clocks for the rk356x gpu

2022-02-09 Thread Michael Riesch
From: Alex Bee The Bifrost GPU in Rockchip RK356x SoCs has a core and a bus clock. Reflect this in the SoC specific part of the binding. Signed-off-by: Alex Bee [move the changes to the SoC section] Signed-off-by: Michael Riesch --- .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 15 +

Re: [PATCH v4 7/9] drm: vkms: Refactor the plane composer to accept new formats

2022-02-09 Thread Melissa Wen
On 02/08, Igor Torrente wrote: > Hi Melissa, > > On 2/8/22 07:40, Melissa Wen wrote: > > On 01/21, Igor Torrente wrote: > > > Currently the blend function only accepts XRGB_ and ARGB_ > > > as a color input. > > > > > > This patch refactors all the functions related to the plane compositi

Re: [PATCH v4 14/14] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2022-02-09 Thread Dmitry Baryshkov
On 05/11/2021 06:04, Sean Paul wrote: From: Sean Paul This patch adds HDCP 1.x support to msm DP connectors using the new HDCP helpers. Sean, is this something that you'd like to pursue further? We have picked up patches 8-11, which were independent from the rest of the changes. The rest see

Re: [PATCH 5/9] drm/amdgpu: remove GTT accounting

2022-02-09 Thread Felix Kuehling
On 2022-02-09 03:40, Christian König wrote: This is provided by TTM now. Also switch man->size to bytes instead of pages and fix the double printing of size and usage in debugfs. Signed-off-by: Christian König Tested-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c |

Re: [PATCH] fbcon: use min() to make code cleaner

2022-02-09 Thread Helge Deller
On 2/9/22 19:54, Sam Ravnborg wrote: > On Wed, Feb 09, 2022 at 08:48:10AM +, cgel@gmail.com wrote: >> From: Changcheng Deng >> >> Use min() in order to make code cleaner. >> >> Reported-by: Zeal Robot >> Signed-off-by: Changcheng Deng > Reviewed-by: Sam Ravnborg > > I had preferred in m

Re: [PATCH -next] drm/amdkfd: Fix NULL but dereferenced coccicheck error

2022-02-09 Thread Felix Kuehling
On 2022-02-08 20:39, Yang Li wrote: Eliminate the following coccicheck warning: ./drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:2087:27-38: ERROR: bo_buckets is NULL but dereferenced. Reported-by: Abaci Robot Signed-off-by: Yang Li Thank you. I already picket up Tom Rix's patch for the same iss

Re: [PATCH v2, 3/7] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8195

2022-02-09 Thread Rob Herring
On Fri, 28 Jan 2022 11:54:36 +0800, Yunfei Dong wrote: > Adds decoder dt-bindings for mt8195. > > Signed-off-by: Yunfei Dong > Reviewed-by: Macpaul Lin > --- > .../bindings/media/mediatek,vcodec-subdev-decoder.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring

Re: [PATCH v2, 1/7] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for lat soc

2022-02-09 Thread Rob Herring
On Fri, Jan 28, 2022 at 11:54:34AM +0800, Yunfei Dong wrote: > Adds decoder dt-bindings for compatible "mediatek,mtk-vcodec-lat-soc". What's lat soc? How does this relate to what's already there in this binding. The subject space is limited, avoid saying the same thing twice (dt-bindings). >

Re: [PATCH] drm/amdkfd: fix freeing an unset pointer

2022-02-09 Thread Felix Kuehling
On 2022-02-09 09:52, t...@redhat.com wrote: From: Tom Rix clang static analysis reports this problem kfd_chardev.c:2092:2: warning: 1st function call argument is an uninitialized value kvfree(bo_privs); ^~~~ When bo_buckets alloc fails, it jumps to an error h

Re: [PATCH] drm/amdkfd: CRIU return -EFAULT for copy_to_user() failure

2022-02-09 Thread Felix Kuehling
On 2022-02-09 13:09, Dan Carpenter wrote: If copy_to_user() fails, it returns the number of bytes remaining to be copied but we want to return a negative error code (-EFAULT) to the user. Fixes: 9d5dabfeff3c ("drm/amdkfd: CRIU Save Shared Virtual Memory ranges") Signed-off-by: Dan Carpenter

Aw: [PATCH v5 22/23] drm: rockchip: Add VOP2 driver

2022-02-09 Thread Frank Wunderlich
Hi Sascha tested full v5 Series + 3 clk-Patches from v4 on 5.17-rc2 on my rk3568 based Bananapi R2 Pro 1280x720-32@60Hz 1920x1080-32@60Hz 3840x2160-32@60Hz with fb console Tested-by: Frank Wunderlich regards Frank

Re: [PATCH v6 1/3] i915/gvt: Introduce the mmio table to support VFIO new mdev API

2022-02-09 Thread Wang, Zhi A
On 2/9/22 9:04 AM, Jani Nikula wrote: > On Wed, 09 Feb 2022, Christoph Hellwig wrote: >> On Tue, Feb 08, 2022 at 05:15:00PM +0200, Jani Nikula wrote: #ifdef CONFIG_DRM_I915_GVT + +#define D_BDW (1 << 0) +#define D_SKL (1 << 1) +#define D_KBL (1 << 2) +#defi

Re: [PATCH v6 1/3] i915/gvt: Introduce the mmio table to support VFIO new mdev API

2022-02-09 Thread Wang, Zhi A
On 2/9/22 7:28 AM, Christoph Hellwig wrote: > On Tue, Feb 08, 2022 at 05:15:00PM +0200, Jani Nikula wrote: >>> #ifdef CONFIG_DRM_I915_GVT >>> + >>> +#define D_BDW (1 << 0) >>> +#define D_SKL (1 << 1) >>> +#define D_KBL (1 << 2) >>> +#define D_BXT (1 << 3) >>> +#define D_CFL (

Re: [PATCH v6 2/3] i915/gvt: Save the initial HW state snapshot in i915

2022-02-09 Thread Wang, Zhi A
On 2/9/22 7:32 AM, Christoph Hellwig wrote: > On Tue, Feb 08, 2022 at 06:11:50AM -0500, Zhi Wang wrote: >> +struct drm_i915_private *dev_priv = iter->i915; >> +u32 *mmio, i; >> + >> +for (i = offset; i < offset + size; i += 4) { >> +mmio = iter->data + i; >> +*mm

RE: [Intel-gfx] [PATCH v3 0/4] GuC HWCONFIG with documentation

2022-02-09 Thread Bloomfield, Jon
Acked-by: Jon Bloomfield > -Original Message- > From: Intel-gfx On Behalf Of > Jordan Justen > Sent: Tuesday, February 8, 2022 1:05 PM > To: intel-gfx > Cc: dri-devel > Subject: [Intel-gfx] [PATCH v3 0/4] GuC HWCONFIG with documentation > > This is John/Rodrigo's 2 patches with some m

Re: [PATCH v3 1/4] dt-bindings: display: simple: Add sharp LQ140M1JW46 panel

2022-02-09 Thread Rob Herring
On Wed, 09 Feb 2022 14:25:29 +0530, Sankeerth Billakanti wrote: > Add support for sharp LQ140M1JW46 display panel. It is a 14" eDP panel > with 1920x1080 display resolution. > > Signed-off-by: Sankeerth Billakanti > --- > > Changes in v3: > None > > Documentation/devicetree/bindings/display/

Re: [PATCH v5 23/23] dt-bindings: display: rockchip: Add binding for VOP2

2022-02-09 Thread Rob Herring
On Wed, 09 Feb 2022 10:53:50 +0100, Sascha Hauer wrote: > The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. > The binding differs slightly from the existing VOP binding, so add a new > binding file for it. > > Signed-off-by: Sascha Hauer > --- > > Notes: > Changes since

Re: [PATCH] fbcon: use min() to make code cleaner

2022-02-09 Thread Sam Ravnborg
On Wed, Feb 09, 2022 at 08:48:10AM +, cgel@gmail.com wrote: > From: Changcheng Deng > > Use min() in order to make code cleaner. > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng Reviewed-by: Sam Ravnborg I had preferred in minmax.h was included, but it has an indirect inc

[PATCH AUTOSEL 5.4 14/15] drm/amdgpu: fix logic inversion in check

2022-02-09 Thread Sasha Levin
From: Christian König [ Upstream commit e8ae38720e1a685fd98cfa5ae118c9d07b45ca79 ] We probably never trigger this, but the logic inside the check is inverted. Signed-off-by: Christian König Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/d

[PATCH AUTOSEL 5.10 23/27] drm/amdgpu: fix logic inversion in check

2022-02-09 Thread Sasha Levin
From: Christian König [ Upstream commit e8ae38720e1a685fd98cfa5ae118c9d07b45ca79 ] We probably never trigger this, but the logic inside the check is inverted. Signed-off-by: Christian König Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/d

[PATCH AUTOSEL 5.15 32/36] drm/amdgpu: fix logic inversion in check

2022-02-09 Thread Sasha Levin
From: Christian König [ Upstream commit e8ae38720e1a685fd98cfa5ae118c9d07b45ca79 ] We probably never trigger this, but the logic inside the check is inverted. Signed-off-by: Christian König Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/d

[PATCH AUTOSEL 5.15 31/36] drm/amd: Only run s3 or s0ix if system is configured properly

2022-02-09 Thread Sasha Levin
From: Mario Limonciello [ Upstream commit 04ef860469fda6a646dc841190d05b31fae68e8c ] This will cause misconfigured systems to not run the GPU suspend routines. * In APUs that are properly configured system will go into s2idle. * In APUs that are intended to be S3 but user selects s2idle the G

[PATCH AUTOSEL 5.15 30/36] drm/amd: add support to check whether the system is set to s3

2022-02-09 Thread Sasha Levin
From: Mario Limonciello [ Upstream commit f52a2b8badbd24faf73a13c9c07fdb9d07352944 ] This will be used to help make decisions on what to do in misconfigured systems. v2: squash in semicolon fix from Stephen Rothwell Signed-off-by: Mario Limonciello Reviewed-by: Alex Deucher Signed-off-by: Al

[PATCH AUTOSEL 5.15 25/36] drm/amd: Warn users about potential s0ix problems

2022-02-09 Thread Sasha Levin
From: Mario Limonciello [ Upstream commit a6ed2035878e5ad2e43ed175d8812ac9399d6c40 ] On some OEM setups users can configure the BIOS for S3 or S2idle. When configured to S3 users can still choose 's2idle' in the kernel by using `/sys/power/mem_sleep`. Before commit 6dc8265f9803 ("drm/amdgpu: al

[PATCH AUTOSEL 5.16 38/42] drm/amdgpu: fix logic inversion in check

2022-02-09 Thread Sasha Levin
From: Christian König [ Upstream commit e8ae38720e1a685fd98cfa5ae118c9d07b45ca79 ] We probably never trigger this, but the logic inside the check is inverted. Signed-off-by: Christian König Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/d

[PATCH AUTOSEL 5.16 37/42] drm/amd: Only run s3 or s0ix if system is configured properly

2022-02-09 Thread Sasha Levin
From: Mario Limonciello [ Upstream commit 04ef860469fda6a646dc841190d05b31fae68e8c ] This will cause misconfigured systems to not run the GPU suspend routines. * In APUs that are properly configured system will go into s2idle. * In APUs that are intended to be S3 but user selects s2idle the G

[PATCH AUTOSEL 5.16 36/42] drm/amd: add support to check whether the system is set to s3

2022-02-09 Thread Sasha Levin
From: Mario Limonciello [ Upstream commit f52a2b8badbd24faf73a13c9c07fdb9d07352944 ] This will be used to help make decisions on what to do in misconfigured systems. v2: squash in semicolon fix from Stephen Rothwell Signed-off-by: Mario Limonciello Reviewed-by: Alex Deucher Signed-off-by: Al

[PATCH AUTOSEL 5.16 30/42] drm/amd: Warn users about potential s0ix problems

2022-02-09 Thread Sasha Levin
From: Mario Limonciello [ Upstream commit a6ed2035878e5ad2e43ed175d8812ac9399d6c40 ] On some OEM setups users can configure the BIOS for S3 or S2idle. When configured to S3 users can still choose 's2idle' in the kernel by using `/sys/power/mem_sleep`. Before commit 6dc8265f9803 ("drm/amdgpu: al

[PATCH] drm/syncobj: flatten dma_fence_chains on transfer

2022-02-09 Thread Christian König
It is illegal to add a dma_fence_chain as timeline point. Flatten out the fences into a dma_fence_array instead. Signed-off-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 61 --- 1 file changed, 56 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/d

[PATCH] drm/amdkfd: CRIU return -EFAULT for copy_to_user() failure

2022-02-09 Thread Dan Carpenter
If copy_to_user() fails, it returns the number of bytes remaining to be copied but we want to return a negative error code (-EFAULT) to the user. Fixes: 9d5dabfeff3c ("drm/amdkfd: CRIU Save Shared Virtual Memory ranges") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 6 +

[PATCH] drm/amdkfd: CRIU fix a NULL vs IS_ERR() check

2022-02-09 Thread Dan Carpenter
The kfd_process_device_data_by_id() does not return error pointers, it returns NULL. Fixes: bef153b70c6e ("drm/amdkfd: CRIU implement gpu_id remapping") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: [RFC v4 02/11] drm/amdgpu: Move scheduler init to after XGMI is ready

2022-02-09 Thread Andrey Grodzovsky
All comments are fixed and code pushed. Thanks for everyone who helped reviewing. Andrey On 2022-02-09 02:53, Christian König wrote: Am 09.02.22 um 01:23 schrieb Andrey Grodzovsky: Before we initialize schedulers we must know which reset domain are we in - for single device there iis a single

Re: [PATCH v5 1/5] dt-bindings: gpu: mali-bifrost: describe clocks for the rk356x gpu

2022-02-09 Thread Rob Herring
On Wed, Feb 09, 2022 at 09:51:06AM +0100, Michael Riesch wrote: > From: Alex Bee > > The Bifrost GPU in Rockchip RK356x SoCs has a core and a bus clock. > Reflect this in the SoC specific part of the binding. > > Signed-off-by: Alex Bee > [move the changes to the SoC section] > Signed-off-by: M

Aw: [PATCH v5 00/23] drm/rockchip: RK356x VOP2 support

2022-02-09 Thread Frank Wunderlich
Hi Sascha tested full v5 Series + 3 clk-Patches from v4 on 5.17-rc2 on my rk3568 based Bananapi R2 Pro 1280x720-32@60Hz 1920x1080-32@60Hz 3840x2160-32@60Hz with fb console Tested-by: Frank Wunderlich regards Frank

Re: [PATCH v5 1/5] dt-bindings: gpu: mali-bifrost: describe clocks for the rk356x gpu

2022-02-09 Thread Rob Herring
On Wed, Feb 09, 2022 at 05:28:05PM +0100, Heiko Stübner wrote: > Hi Michael, > > Am Mittwoch, 9. Februar 2022, 16:46:28 CET schrieb Michael Riesch: > > Hi Rob, > > > > On 2/9/22 16:35, Rob Herring wrote: > > > On Wed, 09 Feb 2022 09:51:06 +0100, Michael Riesch wrote: > > >> From: Alex Bee > > >>

Re: [PATCH] drm/bridge: anx7625: Fix overflow issue on reading EDID

2022-02-09 Thread Jernej Škrabec
Hi! Dne sreda, 09. februar 2022 ob 06:53:27 CET je Pin-Yen Lin napisal(a): > The length of EDID block can be longer than 256 bytes, so we should use > `int` instead of `u8` for the `edid_pos` variable. > > Signed-off-by: Pin-Yen Lin Please add "Fixes" tag. With that: Reviewed-by: Jernej Skrabec

  1   2   3   4   >