Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-10 Thread Dan Carpenter
On Thu, Feb 10, 2022 at 10:16:45PM +0100, Sam Ravnborg wrote: > > diff --git a/drivers/video/fbdev/core/fb_defio.c > > b/drivers/video/fbdev/core/fb_defio.c > > index 3727b1ca87b1..1f672cf253b2 100644 > > --- a/drivers/video/fbdev/core/fb_defio.c > > +++ b/drivers/video/fbdev/core/fb_defio.c > >

Re: [PATCH] drm/panel: simple: Initialize bpc in RK101II01D-CT panel descriptor

2022-02-10 Thread Tomi Valkeinen
On 10/02/2022 16:03, Rahul T R wrote: Initialize bpc while creating panel_desc structure for RK101II01D-CT Below warning is triggered since bpc is not being initialized WARNING: CPU: 2 PID: 47 at drivers/gpu/drm/panel/panel-simple.c:614 panel_simple_probe+0x1b0/0x3c8 Signed-off-by: Rahul T R

Patch for fbcon not letting to read console font if it's width is 17-24 (3 bytes pitch)

2022-02-10 Thread Sokalski, Marcin
staging: drivers: video: fbdev: core: fbcon: Fix getting font from fbcon The patch fixes the problem of getting fonts from fbcon when the font's width spans over 3 bytes. The bug can be reproduced inside linux console running fbcon in following way: Set font with width in range 17-24, ie:

Re: [Intel-gfx] [PATCH v2 00/15] Initial support for small BAR recovery

2022-02-10 Thread Das, Nirmoy
Patches: 1, 2, 3, 5, 6, 11 are Acked-by: Nirmoy Das Patches: 5,6 are Reviewed-by: Nirmoy Das Sorry for partial reviews, I still need to go through more i915 code. Regards, Nirmoy On 10/02/2022 13:12, Matthew Auld wrote: Starting from DG2 we will have resizable BAR support for device

Re: [PATCH 17/23] drm/sti: plane: Remove redundant zpos initialisation

2022-02-10 Thread Alain Volmat
Hi, thanks for the patch. Reviewed-by: Alain Volmat Alain On Mon, Feb 07, 2022 at 05:35:09PM +0100, Maxime Ripard wrote: > The sti KMS driver will call drm_plane_create_zpos_property() with an > init value depending on the plane type. > > Since the initial value wasn't carried over in the

RE: [PATCH v3 3/4] drm/panel-edp: Add eDP sharp panel support

2022-02-10 Thread Sankeerth Billakanti
Hi Dmitry, As discussed over a separate email, we will be exploring using the generic panel edp and aux bus after implementing the basic PSR feature. We are using a non-generic compatible string now because we enabled PSR with this. The changes from aux-bus and generic-edp may be intrusive for

[PATCH v2] drm/bridge: anx7625: Fix overflow issue on reading EDID

2022-02-10 Thread Pin-Yen Lin
The length of EDID block can be longer than 256 bytes, so we should use `int` instead of `u8` for the `edid_pos` variable. Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP") Signed-off-by: Pin-Yen Lin Reviewed-by: Jernej Skrabec --- Changes in v2: - add "Fixes" tag -

Re: [PATCH v2 1/5] dt-bindings: reserved-memory: Document memory region specifier

2022-02-10 Thread Janne Grunau
On 2022-02-09 17:31:16 +0100, Thierry Reding wrote: > On Sun, Feb 06, 2022 at 11:27:00PM +0100, Janne Grunau wrote: > > On 2021-09-15 17:19:39 +0200, Thierry Reding wrote: > > > On Tue, Sep 07, 2021 at 07:44:44PM +0200, Thierry Reding wrote: > > > > On Tue, Sep 07, 2021 at 10:33:24AM -0500, Rob

[PATCH v2] drm/mediatek: allow commands to be sent during video mode

2022-02-10 Thread Julien STEPHAN
Mipi dsi panel drivers can use mipi_dsi_dcs_{set,get}_display_brightness() to request backlight changes. This can be done during panel initialization (dsi is in command mode) or afterwards (dsi is in Video Mode). When the DSI is in Video Mode, all commands are rejected. Detect current DSI mode

[PATCH] drm/i915/dg2: Don't try to process TBT interrupts

2022-02-10 Thread Ramalingam C
From: Matt Roper DG2 is the first platform, that supports TC but not TBT. interrupt code is updated to avoid trying to process TBT-specific bits and registers. Cc: Swathi Dhanavanthri Signed-off-by: Matt Roper Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/i915_drv.h | 1 +

[git pull] drm fixes for 5.17-rc4

2022-02-10 Thread Dave Airlie
Hi Linus, Regular fixes pull, mostly i915 and amd fixes, along with a maintainers update for fbdev core. Otherwise just some build fixes and vc4 HDMI fixes. drm-fixes-2022-02-11: drm fixes for 5.17-rc4 fbdev: - MAINTAINERS: add Daniel as fbdev core module maintainer - build warning fix -

[PATCH] video: s3c-fb: Use platform_get_irq() to get the interrupt

2022-02-10 Thread zhaoxiao
platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static allocation of IRQ resources in DT core code, this causes an issue when using hierarchical interrupt domains using "interrupts" property in the node as this bypassed the hierarchical setup and messed up the irq chaining. In

[PATCH V2 13/13] media: vivid: use time_is_after_jiffies() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/media/test-drivers/vivid/vivid-kthread-cap.c | 3 ++- drivers/media/test-drivers/vivid/vivid-kthread-out.c | 3 ++-

[PATCH V2 12/13] media: wl128x: use time_is_before_jiffies() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/media/radio/wl128x/fmdrv_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/radio/wl128x/fmdrv_common.c

[PATCH V2 11/13] media: tda8083: use time_is_after_jiffies() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/media/dvb-frontends/tda8083.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/tda8083.c

[PATCH V2 10/13] media: stv0299: use time_is_before_jiffies() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/media/dvb-frontends/stv0299.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0299.c

[PATCH V2 9/13] media: si21xx: use time_is_before_jiffies() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/media/dvb-frontends/si21xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/si21xx.c

[PATCH V2 10/13] md: use time_is_before_eq_jiffies() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/md/dm-writecache.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c index

[PATCH V2 7/13] md: use time_is_before_jiffies(() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/md/dm-thin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index f4234d6..dced764 ---

[PATCH V2 6/13] input: serio: use time_is_before_jiffies() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/input/serio/ps2-gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/serio/ps2-gpio.c

[PATCH V2 5/13] hid: use time_is_after_jiffies() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c

[PATCH V2 4/13] gpu: drm: radeon: use time_is_before_jiffies() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/gpu/drm/radeon/radeon_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_pm.c

[PATCH V2 3/13] gpu: drm: i915: use time_is_after_jiffies() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c

[PATCH V2 2/13] clk: mvebu: use time_is_before_eq_jiffies() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/clk/mvebu/armada-37xx-periph.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/mvebu/armada-37xx-periph.c

[PATCH V2 1/13] block: xen: use time_is_before_eq_jiffies() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/block/xen-blkback/blkback.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c

[PATCH V2 00/13] use time_is_xxx() instead of jiffies judgment

2022-02-10 Thread Qing Wang
From: Wang Qing It is better to use time_is_xxx() directly instead of jiffies judgment for understanding. Batch them in a series suggested by Joe. Wang Qing (14): block: xen: use time_is_before_eq_jiffies() instead of jiffies judgment clk: mvebu: use time_is_before_eq_jiffies() instead of

Re: [PATCH 3/3] drm/msm/dpu: Update function parameter documentation

2022-02-10 Thread Abhinav Kumar
On 2/10/2022 3:41 AM, Vinod Koul wrote: dpu_core_irq_callback_handler() function comments seem to have become stale and emit a warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147: warning: Function parameter or member 'dpu_kms' not described in 'dpu_core_irq_callback_handler'

Re: [PATCH 2/3] drm/msm/dpu: Update the comment style

2022-02-10 Thread Abhinav Kumar
On 2/10/2022 3:41 AM, Vinod Koul wrote: The multi line comment style is wrongly used as kernel-doc comment. This gives a warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Remove set but unused variables

2022-02-10 Thread Abhinav Kumar
On 2/10/2022 3:41 AM, Vinod Koul wrote: We get warning: In function ‘dpu_encoder_virt_enable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1145:33: warning: variable ‘priv’ set but not used [-Wunused-but-set-variable] 1145 | struct msm_drm_private *priv; In function

Re: [PATCH 08/49] drm: replace bitmap_weight with bitmap_empty where appropriate

2022-02-10 Thread Dmitry Baryshkov
On Fri, 11 Feb 2022 at 02:09, Yury Norov wrote: > > smp_request_block() in drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c calls > bitmap_weight() to check if any bit of a given bitmap is set. It's > better to use bitmap_empty() in that case because bitmap_empty() stops > traversing the bitmap as soon

linux-next: manual merge of the drm-intel tree with the drm tree

2022-02-10 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/i915_module.c between commit: 6387a3c4b0c4 ("drm: move the buddy allocator from i915 into common drm") from the drm tree and commit: 24524e3f43cf ("drm/i915: move the DRIVER_* macros to

Re: [PATCH v6 02/35] component: Introduce the aggregate bus_type

2022-02-10 Thread Stephen Boyd
Quoting Daniel Vetter (2022-02-08 04:53:59) > On Mon, Jan 31, 2022 at 05:34:26PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Jan 31, 2022 at 04:15:09PM +0100, Daniel Vetter wrote: > > > On Mon, Jan 31, 2022 at 2:48 PM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Thu, Jan 27, 2022 at

Re: [PATCH 3/3] drm/msm/dpu: Update function parameter documentation

2022-02-10 Thread Dmitry Baryshkov
On 10/02/2022 14:41, Vinod Koul wrote: dpu_core_irq_callback_handler() function comments seem to have become stale and emit a warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147: warning: Function parameter or member 'dpu_kms' not described in 'dpu_core_irq_callback_handler'

Re: [PATCH 2/3] drm/msm/dpu: Update the comment style

2022-02-10 Thread Dmitry Baryshkov
On 10/02/2022 14:41, Vinod Koul wrote: The multi line comment style is wrongly used as kernel-doc comment. This gives a warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer

Re: [PATCH 1/3] drm/msm/dpu: Remove set but unused variables

2022-02-10 Thread Dmitry Baryshkov
On 10/02/2022 14:41, Vinod Koul wrote: We get warning: In function ‘dpu_encoder_virt_enable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1145:33: warning: variable ‘priv’ set but not used [-Wunused-but-set-variable] 1145 | struct msm_drm_private *priv; In function

Re: [PATCH linux-next] video: fbdev: fbmem: fix pointer reference to null device field

2022-02-10 Thread Paul E. McKenney
On Thu, Feb 10, 2022 at 02:58:24PM +0800, Zhouyi Zhou wrote: > In function do_remove_conflicting_framebuffers, if device is NULL, there > will be null pointer reference. The patch add a check to the if expression. > > Signed-off-by: Zhouyi Zhou > --- > Dear Linux folks > > I discover this bug

Re: [Freedreno] [PATCH 1/7] drm/msm: move struct msm_display_info to dpu driver

2022-02-10 Thread Abhinav Kumar
On 2/3/2022 12:26 AM, Dmitry Baryshkov wrote: The msm_display_info structure is not used by the rest of msm driver, so move it into the dpu1 (dpu_encoder.h to be precise). Signed-off-by: Dmitry Baryshkov Yes, this is true. Its not used by rest of msm driver. Reviewed-by: Abhinav Kumar

Re: [PATCH v4 3/5] arm64: dts: qcom: sc7280: rename edp_out label to mdss_edp_out

2022-02-10 Thread Bjorn Andersson
On Thu 10 Feb 05:57 CST 2022, Sankeerth Billakanti wrote: > Rename the edp_out label in the sc7280 platform to mdss_edp_out. Next week, or in the next product, it might not be obvious why we did this change. So please continue this sentence with something like "so that the nodes are grouped

Re: [PATCH v4 2/5] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-02-10 Thread Bjorn Andersson
On Thu 10 Feb 05:57 CST 2022, Sankeerth Billakanti wrote: > Enable the eDP display panel support without HPD on sc7280 platform. > > Signed-off-by: Sankeerth Billakanti > --- > > Changes in v4: > - Create new patch for name changes > - Remove output-low > > Changes in v3: > - Sort the

Re: [Intel-gfx] [PATCH v2 07/18] drm/i915/guc: Convert policies update to iosys_map

2022-02-10 Thread Matt Atwood
On Tue, Feb 08, 2022 at 02:45:13AM -0800, Lucas De Marchi wrote: > Use iosys_map to write the policies update so access to IO and system > memory is abstracted away. > > Cc: Matt Roper > Cc: Thomas Hellström > Cc: Daniel Vetter > Cc: John Harrison > Cc: Matthew Brost > Cc: Daniele Ceraolo

Re: [PATCH v10 3/6] gpio: logicvc: Support compatible with major version only

2022-02-10 Thread Linus Walleij
On Tue, Feb 8, 2022 at 10:55 AM Bartosz Golaszewski wrote: > On Sun, Jan 30, 2022 at 1:43 AM Linus Walleij > wrote: > > > > On Thu, Jan 20, 2022 at 4:00 PM Paul Kocialkowski > > wrote: > > > > > Support the newly-introduced common compatible for version 3. > > > > > > Signed-off-by: Paul

Re: [PATCH v2 0/2] drm/gem-shmem: Various improvements

2022-02-10 Thread Chia-I Wu
On Wed, Feb 9, 2022 at 7:56 AM Thomas Zimmermann wrote: > > Two patches for GEM's SHMEM-backed implementation. > > v2: > * update drivers after vm_ops change > > Thomas Zimmermann (2): > drm/gem-shmem: Set vm_ops in static initializer > drm/gem-shmem: Don't store mmap'ed buffers in

Re: [PATCH v2 2/3] mm/gup.c: Migrate device coherent pages when pinning instead of failing

2022-02-10 Thread Alistair Popple
On Thursday, 10 February 2022 10:47:35 PM AEDT David Hildenbrand wrote: > On 10.02.22 12:39, Alistair Popple wrote: > > On Thursday, 10 February 2022 9:53:38 PM AEDT David Hildenbrand wrote: > >> On 07.02.22 05:26, Alistair Popple wrote: > >>> Currently any attempts to pin a device coherent page

Re: [Freedreno] [PATCH v5 3/6] drm/msm/dpu: get INTF blocks directly rather than through RM

2022-02-10 Thread Abhinav Kumar
On 2/10/2022 1:32 AM, Dmitry Baryshkov wrote: On 10/02/2022 03:25, Abhinav Kumar wrote: On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: INTF blocks are not really handled by resource manager, they are assigned at dpu_encoder_setup_display using dpu_encoder_get_intf(). Then this allocation

[PATCH 18/49] drm/i915/pmu: replace cpumask_weight with cpumask_empty where appropriate

2022-02-10 Thread Yury Norov
i915_pmu_cpu_online() calls cpumask_weight() to check if any bit of a given cpumask is set. We can do it more efficiently with cpumask_empty() because cpumask_empty() stops traversing the cpumask as soon as it finds first set bit, while cpumask_weight() counts all bits unconditionally.

Re: [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-10 Thread Bjorn Andersson
On Thu 10 Feb 13:12 PST 2022, Dmitry Baryshkov wrote: > On Thu, 10 Feb 2022 at 23:54, Bjorn Andersson > wrote: > > > > On Tue 08 Feb 02:39 PST 2022, Greg Kroah-Hartman wrote: > > > > > On Mon, Feb 07, 2022 at 08:43:27PM -0800, Bjorn Andersson wrote: > > > > In some implementations, such as the

[PATCH 08/49] drm: replace bitmap_weight with bitmap_empty where appropriate

2022-02-10 Thread Yury Norov
smp_request_block() in drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c calls bitmap_weight() to check if any bit of a given bitmap is set. It's better to use bitmap_empty() in that case because bitmap_empty() stops traversing the bitmap as soon as it finds first set bit, while bitmap_weight() counts all

Re: [Intel-gfx] [PATCH v2 05/18] drm/i915/guc: Add read/write helpers for ADS blob

2022-02-10 Thread Matt Atwood
On Tue, Feb 08, 2022 at 02:45:11AM -0800, Lucas De Marchi wrote: > Add helpers on top of iosys_map_read_field() / > iosys_map_write_field() functions so they always use the right > arguments and make code easier to read. > > Cc: Matt Roper > Cc: Thomas Hellström > Cc: Daniel Vetter > Cc: John

Re: [Intel-gfx] [PATCH v2 04/18] drm/i915/guc: Keep iosys_map of ads_blob around

2022-02-10 Thread Matt Atwood
On Tue, Feb 08, 2022 at 02:45:10AM -0800, Lucas De Marchi wrote: > Convert intel_guc_ads_create() and initialization to use iosys_map > rather than plain pointer and save it in the guc struct. This will help > with additional updates to the ads_blob after the > creation/initialization by

[PATCH v2 7/9] drm/radeon: drop the use of `pci_is_thunderbolt_attached`

2022-02-10 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/radeon/radeon_device.c | 4 ++--

[PATCH v2 6/9] drm/nouveau: drop the use of `pci_is_thunderbolt_attached`

2022-02-10 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/nouveau/nouveau_vga.c | 4 ++-- 1 file changed, 2

[PATCH v2 8/9] platform/x86: amd-gmux: drop the use of `pci_is_thunderbolt_attached`

2022-02-10 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Signed-off-by: Mario Limonciello --- drivers/platform/x86/apple-gmux.c | 2 +- 1 file changed, 1

[PATCH v2 9/9] PCI: drop `pci_is_thunderbolt_attached`

2022-02-10 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. As all drivers now look at the removable attribute, drop this function. Signed-off-by: Mario Limonciello --- include/linux/pci.h | 22 -- 1 file changed, 22 deletions(-) diff

[PATCH v2 5/9] drm/amd: drop the use of `pci_is_thunderbolt_attached`

2022-02-10 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-

[PATCH v2 1/9] thunderbolt: move definition of PCI_CLASS_SERIAL_USB_USB4

2022-02-10 Thread Mario Limonciello
This PCI class definition of the USB4 device is currently located only in the thunderbolt driver. It will be needed by a few other drivers for upcoming changes. Move it into the common include file. Acked-by: Alex Deucher Signed-off-by: Mario Limonciello --- drivers/thunderbolt/nhi.h | 2 --

[PATCH v2 4/9] PCI: mark USB4 devices as removable

2022-02-10 Thread Mario Limonciello
USB4 class devices are also removable like Intel Thunderbolt devices. Drivers of downstream devices use this information to declare functional differences in how the drivers perform by knowing that they are connected to an upstream TBT/USB4 port. Signed-off-by: Mario Limonciello ---

[PATCH v2 2/9] PCI: Move `is_thunderbolt` check for lack of command completed to a quirk

2022-02-10 Thread Mario Limonciello
The `is_thunderbolt` check is currently used to indicate the lack of command completed support for a number of older Thunderbolt devices. This however is heavy handed and should have been done via a quirk. Move the affected devices outlined in commit 493fb50e958c ("PCI: pciehp: Assume NoCompl+

[PATCH v2 3/9] PCI: drop `is_thunderbolt` attribute

2022-02-10 Thread Mario Limonciello
The `is_thunderbolt` attribute is currently a dumping ground for a variety of things. Instead use the driver core removable attribute to indicate the detail a device is attached to a thunderbolt or USB4 chain. Signed-off-by: Mario Limonciello --- drivers/pci/pci.c | 2 +-

[PATCH v2 0/9] Overhaul is_thunderbolt

2022-02-10 Thread Mario Limonciello
Various drivers in the kernel use `is_thunderbolt` or `pci_is_thunderbolt_attached` to designate behaving differently from a device that is internally in the machine. This relies upon checks for a specific capability only set on Intel controllers. Non-Intel USB4 designs should also match this

Re: [PATCH 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-02-10 Thread Bjorn Andersson
On Mon 07 Feb 23:40 PST 2022, Greg Kroah-Hartman wrote: > On Mon, Feb 07, 2022 at 08:43:28PM -0800, Bjorn Andersson wrote: > > The Qualcomm DisplayPort driver contains traces of the necessary > > plumbing to hook up USB HPD, in the form of the dp_hpd module and the > > dp_usbpd_cb struct. Use

[PATCH] drm/i915/guc: Do not complain about stale reset notifications

2022-02-10 Thread John . C . Harrison
From: John Harrison It is possible for reset notifications to arrive for a context that is in the process of being banned. So don't flag these as an error, just report it as informational (because it is still useful to know that resets are happening even if they are being ignored).

[PATCH v1 1/1] drm/i915/gt: Move wbvind_on_all_cpus #define

2022-02-10 Thread Michael Cheng
Move wbvind_on_all_cpus to intel_gt.h. This will allow other wbind_on_all_cpus calls to benefit from the #define logic, and prevent compiler errors when building for non-x86 architectures. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gem/i915_gem_pm.c | 7 ---

[PATCH v1 0/1] Move #define wbvind_on_all_cpus

2022-02-10 Thread Michael Cheng
This series moves the #define wbvind_on_all_cpus logic to intel_gt.h. This way all calls to wbvind_on_all_cpus benefit from the logic, and fixes compile errors on non-x86 platforms. Michael Cheng (1): drm/i915/gt: Move wbvind_on_all_cpus #define drivers/gpu/drm/i915/gem/i915_gem_pm.c | 7

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-10 Thread Sam Ravnborg
Hi Thomas, On Thu, Feb 10, 2022 at 03:11:13PM +0100, Thomas Zimmermann wrote: > Fbdev's deferred I/O sorts all dirty pages by default, which incurs a > significant overhead. Make the sorting step optional and update the few > drivers that require it. Use a FIFO list by default. > > Sorting pages

Re: [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-10 Thread Dmitry Baryshkov
On Thu, 10 Feb 2022 at 23:54, Bjorn Andersson wrote: > > On Tue 08 Feb 02:39 PST 2022, Greg Kroah-Hartman wrote: > > > On Mon, Feb 07, 2022 at 08:43:27PM -0800, Bjorn Andersson wrote: > > > In some implementations, such as the Qualcomm platforms, the display > > > driver has no way to query the

Re: [PATCH 1/2] fbdev/defio: Early-out if page is already enlisted

2022-02-10 Thread Sam Ravnborg
Hi Thomas, On Thu, Feb 10, 2022 at 03:11:11PM +0100, Thomas Zimmermann wrote: > Return early if a page is already in the list of dirty pages for > deferred I/O. This can be detected if the page's list head is not > empty. Keep the list head initialized while the page is not enlisted > to make

Re: [PATCH 6/8] mm: don't include in

2022-02-10 Thread Felix Kuehling
Am 2022-02-09 um 12:48 schrieb Christoph Hellwig: On Mon, Feb 07, 2022 at 04:19:29PM -0500, Felix Kuehling wrote: Am 2022-02-07 um 01:32 schrieb Christoph Hellwig: Move the check for the actual pgmap types that need the free at refcount one behavior into the out of line helper, and thus

Re: [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-10 Thread Bjorn Andersson
On Tue 08 Feb 02:39 PST 2022, Greg Kroah-Hartman wrote: > On Mon, Feb 07, 2022 at 08:43:27PM -0800, Bjorn Andersson wrote: > > In some implementations, such as the Qualcomm platforms, the display > > driver has no way to query the current HPD state and as such it's > > impossible to distinguish

Re: [PATCH] drm/amdkfd: fix loop error handling

2022-02-10 Thread Felix Kuehling
Am 2022-02-10 um 12:04 schrieb t...@redhat.com: From: Tom Rix Clang static analysis reports this problem kfd_chardev.c:2594:16: warning: The expression is an uninitialized value. The computed value will also be garbage while (ret && i--) { ^~~ i is a loop

Re: [PATCH] drm/ast: fix using freed memory

2022-02-10 Thread Thomas Zimmermann
Hi Am 03.02.22 um 16:23 schrieb t...@redhat.com: From: Tom Rix clang static analysis reports this problem ast_mode.c:1235:3: warning: Use of memory after it is freed drm_connector_update_edid_property(_connector->base, edid);

[PATCH v10 3/6] drm/i915/gt: Drop invalidate_csb_entries

2022-02-10 Thread Michael Cheng
Drop invalidate_csb_entries and directly call drm_clflush_virt_range. This allows for one less function call, and prevent complier errors when building for non-x86 architectures. v2(Michael Cheng): Drop invalidate_csb_entries function and directly invoke drm_clflush_virt_range.

[PATCH v10 5/6] drm/i915/: Re-work clflush_write32

2022-02-10 Thread Michael Cheng
Use drm_clflush_virt_range instead of clflushopt and remove the memory barrier, since drm_clflush_virt_range takes care of that. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v10 0/6] Use drm_clflush* instead of clflush

2022-02-10 Thread Michael Cheng
This patch series re-work a few i915 functions to use drm_clflush_virt_range instead of calling clflush or clflushopt directly. This will prevent errors when building for non-x86 architectures.

[PATCH v10 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-02-10 Thread Michael Cheng
Add arm64 support for drm_clflush_virt_range. dcache_clean_inval_poc performs a flush by first performing a clean, follow by an invalidation operation. v2 (Michael Cheng): Use correct macro for cleaning and invalidation the dcache. v3 (Michael Cheng): Remove ifdef for

[PATCH v10 2/6] drm/i915/gt: Re-work intel_write_status_page

2022-02-10 Thread Michael Cheng
Re-work intel_write_status_page to use drm_clflush_virt_range. This will prevent compiler errors when building for non-x86 architectures. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gt/intel_engine.h | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git

[PATCH v10 6/6] drm/i915/gt: replace cache_clflush_range

2022-02-10 Thread Michael Cheng
Replace all occurrence of cache_clflush_range with drm_clflush_virt_range. This will prevent compile errors on non-x86 platforms. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 12 ++-- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 2 +-

[PATCH v10 4/6] drm/i915/gt: Re-work reset_csb

2022-02-10 Thread Michael Cheng
Use drm_clflush_virt_range instead of directly invoking clflush. This will prevent compiler errors when building for non-x86 architectures. v2(Michael Cheng): Remove extra clflush v3(Michael Cheng): Remove memory barrier since drm_clflush_virt_range takes care of it.

Re: [PATCH v3 0/7] drm: Add driver for Solomon SSD130X OLED displays

2022-02-10 Thread Javier Martinez Canillas
Hello Geert, On 2/10/22 18:06, Geert Uytterhoeven wrote: > On Wed, Feb 9, 2022 at 1:19 PM Geert Uytterhoeven > wrote: >> On Wed, Feb 9, 2022 at 10:03 AM Javier Martinez Canillas >> wrote: >>> This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, >>> SSD1307 and SSD1309

Re: [PATCH 1/2] dt-bindings: display: imx: Add fsl,imx21-lcdc docs

2022-02-10 Thread Lucas Stach
Hi Rob, Am Dienstag, dem 01.02.2022 um 11:35 -0600 schrieb Rob Herring: > On Fri, Jan 28, 2022 at 06:58:29PM +0100, Uwe Kleine-König wrote: > > Hello Rob, > > > > On Fri, Jan 28, 2022 at 07:04:10AM -0600, Rob Herring wrote: > > > On Fri, Jan 28, 2022 at 4:59 AM Uwe Kleine-König > > > wrote: > >

Re: [PATCH v11 5/5] drm/amdgpu: add drm buddy support to amdgpu

2022-02-10 Thread Matthew Auld
On 08/02/2022 11:20, Arunpravin wrote: On 04/02/22 6:53 pm, Christian König wrote: Am 04.02.22 um 12:22 schrieb Arunpravin: On 28/01/22 7:48 pm, Matthew Auld wrote: On Thu, 27 Jan 2022 at 14:11, Arunpravin wrote: - Remove drm_mm references and replace with drm buddy functionalities - Add

Re: start sorting out the ZONE_DEVICE refcount mess v2

2022-02-10 Thread Sierra Guiza, Alejandro (Alex)
Christoph, Thanks a lot for rebase our patches. I just ran our amdgpu hmm-tests with this series and all passed. Regards, Alex Sierra On 2/10/2022 1:28 AM, Christoph Hellwig wrote: Hi all, this series removes the offset by one refcount for ZONE_DEVICE pages that are freed back to the driver

Re: [PATCH v3 0/7] drm: Add driver for Solomon SSD130X OLED displays

2022-02-10 Thread Geert Uytterhoeven
On Wed, Feb 9, 2022 at 1:19 PM Geert Uytterhoeven wrote: > On Wed, Feb 9, 2022 at 10:03 AM Javier Martinez Canillas > wrote: > > This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, > > SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. > > [...] >

[PATCH] drm/amdkfd: fix loop error handling

2022-02-10 Thread trix
From: Tom Rix Clang static analysis reports this problem kfd_chardev.c:2594:16: warning: The expression is an uninitialized value. The computed value will also be garbage while (ret && i--) { ^~~ i is a loop variable and this block unwinds a problem in the loop.

Re: [PATCH v2] drm/mediatek: allow commands to be sent during video mode

2022-02-10 Thread AngeloGioacchino Del Regno
Il 10/02/22 13:46, Julien STEPHAN ha scritto: Mipi dsi panel drivers can use mipi_dsi_dcs_{set,get}_display_brightness() to request backlight changes. This can be done during panel initialization (dsi is in command mode) or afterwards (dsi is in Video Mode). When the DSI is in Video Mode, all

Re: [PATCH] drm/dp_mst: fix drm_dp_dpcd_read return value checks

2022-02-10 Thread Jani Nikula
On Thu, 10 Feb 2022, Simon Ser wrote: > drm_dp_dpcd_read returns the number of bytes read. The previous code > would print garbage on DPCD error, and would exit with on error on > success. Reviewed-by: Jani Nikula I do wish we'd just made dpcd access return 0 when the number of bytes

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-10 Thread Andy Shevchenko
On Thu, Feb 10, 2022 at 03:11:13PM +0100, Thomas Zimmermann wrote: > Fbdev's deferred I/O sorts all dirty pages by default, which incurs a > significant overhead. Make the sorting step optional and update the few > drivers that require it. Use a FIFO list by default. > > Sorting pages by memory

Re: [PATCH v11 1/5] drm: improve drm_buddy_alloc function

2022-02-10 Thread Matthew Auld
On 27/01/2022 14:11, Arunpravin wrote: - Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which allocates the requested power-of-two block comply with range limitations - Moved order computation

Re: [PATCH v2 1/2] drm/gem-shmem: Set vm_ops in static initializer

2022-02-10 Thread Steven Price
On 09/02/2022 15:56, Thomas Zimmermann wrote: > Initialize default vm_ops in static initialization of the GEM SHMEM funcs, > instead of the mmap code. It's simply better style. GEM helpers will later > set a VMA's vm_ops from the default automatically. > > v2: > * also update the drivers

[PATCH] drm/dp_mst: fix drm_dp_dpcd_read return value checks

2022-02-10 Thread Simon Ser
drm_dp_dpcd_read returns the number of bytes read. The previous code would print garbage on DPCD error, and would exit with on error on success. Signed-off-by: Simon Ser Fixes: cb897542c6d2 ("drm/dp_mst: Fix W=1 warnings") Cc: Lyude Paul Cc: Benjamin Gaignard ---

Re: [PATCH v5 01/23] drm/encoder: Add of_graph port to struct drm_encoder

2022-02-10 Thread Sascha Hauer
On Thu, Feb 10, 2022 at 12:52:32PM +0100, Sascha Hauer wrote: > On Wed, Feb 09, 2022 at 01:12:45PM +0200, Jani Nikula wrote: > > On Wed, 09 Feb 2022, Sascha Hauer wrote: > > > David, Daniel, > > > > > > I'll need a word from you regarding this patch. It's needed in patch > > > 22/23 in this

Re: [PATCH v2] drm/mediatek: allow commands to be sent during video mode

2022-02-10 Thread Chun-Kuang Hu
Hi, Julien: Julien STEPHAN 於 2022年2月10日 週四 下午8:47寫道: > > Mipi dsi panel drivers can use mipi_dsi_dcs_{set,get}_display_brightness() > to request backlight changes. > > This can be done during panel initialization (dsi is in command mode) > or afterwards (dsi is in Video Mode). > > When the DSI

Re: [PATCH 05/23] drm/amd/display: Fix color encoding mismatch

2022-02-10 Thread Harry Wentland
On 2022-02-10 03:42, Maxime Ripard wrote: > Hi Harry, > > On Mon, Feb 07, 2022 at 01:59:38PM -0500, Harry Wentland wrote: >> On 2022-02-07 13:57, Harry Wentland wrote: >>> On 2022-02-07 11:34, Maxime Ripard wrote: The amdgpu KMS driver calls drm_plane_create_color_properties() with a

Re: [PATCH] drm/amdgpu: Fix compile error.

2022-02-10 Thread Andrey Grodzovsky
On 2022-02-10 02:06, Christian König wrote: Am 10.02.22 um 04:17 schrieb Andrey Grodzovsky: Seems I forgot to add this to the relevant commit when submitting. Rebase/merge issue? Looks like it. It looks more like I forgot to add the header file change to the commit after updating with

Re: [PATCH v2 11/19] fbcon: move more common code into fb_open()

2022-02-10 Thread Thomas Zimmermann
Am 08.02.22 um 22:08 schrieb Daniel Vetter: No idea why con2fb_acquire_newinfo() initializes much less than fbcon_startup(), but so be it. From a quick look most of the un-initialized stuff should be fairly harmless, but who knows. Note that the error handling for the con2fb_acquire_newinfo()

Re: [PATCH v2 10/19] fbcon: Ditch error handling for con2fb_release_oldinfo

2022-02-10 Thread Thomas Zimmermann
Am 08.02.22 um 22:08 schrieb Daniel Vetter: It doesn't ever fail anymore. Acked-by: Sam Ravnborg Signed-off-by: Daniel Vetter Cc: Daniel Vetter Cc: Thomas Zimmermann Cc: Greg Kroah-Hartman Cc: Claudio Suarez Cc: Du Cheng Cc: Tetsuo Handa Acked-by: Thomas Zimmermann ---

[PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-10 Thread Thomas Zimmermann
Fbdev's deferred I/O sorts all dirty pages by default, which incurs a significant overhead. Make the sorting step optional and update the few drivers that require it. Use a FIFO list by default. Sorting pages by memory offset for deferred I/O performs an implicit bubble-sort step on the list of

[PATCH 1/2] fbdev/defio: Early-out if page is already enlisted

2022-02-10 Thread Thomas Zimmermann
Return early if a page is already in the list of dirty pages for deferred I/O. This can be detected if the page's list head is not empty. Keep the list head initialized while the page is not enlisted to make this work reliably. Signed-off-by: Thomas Zimmermann ---

[PATCH 0/2] fbdev: Significantly improve performance of fbdefio mmap

2022-02-10 Thread Thomas Zimmermann
Remove the bubble sort from fbdev defered I/O page tracking. Most drivers only want to know which pages have been written to. The exact order is not important. Tested on simpledrm. Thomas Zimmermann (2): fbdev/defio: Early-out if page is already enlisted fbdev: Don't sorting deferred-I/O

Re: [PATCH v5 19/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2022-02-10 Thread Heiko Stübner
Am Donnerstag, 10. Februar 2022, 14:37:59 CET schrieb Sascha Hauer: > On Thu, Feb 10, 2022 at 02:15:17PM +0100, Johan Jonker wrote: > > > > > > On 2/10/22 12:47, Sascha Hauer wrote: > > > On Thu, Feb 10, 2022 at 01:10:32AM +0100, Johan Jonker wrote: > > >> Hi Sascha, > > >> > > >> Something with

Re: [PATCH v5 19/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2022-02-10 Thread Sascha Hauer
On Thu, Feb 10, 2022 at 02:15:17PM +0100, Johan Jonker wrote: > > > On 2/10/22 12:47, Sascha Hauer wrote: > > On Thu, Feb 10, 2022 at 01:10:32AM +0100, Johan Jonker wrote: > >> Hi Sascha, > >> > >> Something with port and endpoint gives notifications. > >> Somehow with the conversion of

  1   2   3   >