[PATCH] tda9950: Slightly simplify tda9950_devm_glue_init()

2022-02-12 Thread Christophe JAILLET
Use devm_add_action_or_reset() instead of hand writing it. This is more straightforward and saves a few lines of code. Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/i2c/tda9950.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i2c/tda9950.c

[PATCH] backlight: backlight: Slighly simplify devm_of_find_backlight()

2022-02-12 Thread Christophe JAILLET
Use devm_add_action_or_reset() instead of devm_add_action()+hand writing what is done in the release function, should an error occur. This is more straightforward and saves a few lines of code. While at it, remove a useless test in devm_backlight_release(). 'data' is known to be not NULL when

[PATCH] drm/i915: fix build issue when using clang

2022-02-12 Thread Tong Zhang
drm/i915 target adds some extra cflags, especially it does re-apply -Wall. In clang this will override -Wno-format-security and cause the build to fail when CONFIG_DRM_I915_WERROR=y. While with GCC this does not happen. We reapply -Wno-format-security here to get around this issue.

[PATCH v3 2/2] dt-bindings: display: Add STARRY 2081101QFH032011-53G

2022-02-12 Thread Hsin-Yi Wang
From: xiazhengqiao Add dt-bindings for 10.1" TFT LCD module called STARRY 2081101 QFH032011-53G. Signed-off-by: xiazhengqiao Reviewed-by: Rob Herring --- v2->v3: rebase to next-20220211 --- .../display/panel/innolux,himax8279d.yaml | 72 +++ 1 file changed, 72

[PATCH v3 1/2] drm/panel: Add inx Himax8279d MIPI-DSI LCD panel driver

2022-02-12 Thread Hsin-Yi Wang
From: xiazhengqiao Add STARRY 2081101QFH032011-53G 10.1" WUXGA TFT LCD panel Signed-off-by: xiazhengqiao Signed-off-by: Hsin-Yi Wang --- v2->v3: rebase to next-20220211 --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1 +

Re: [PATCH v3 3/5] ARM: dts: imx6qdl-vicut1: add CAN termination support

2022-02-12 Thread Shawn Guo
On Fri, Feb 11, 2022 at 02:30:33PM +0100, Oleksij Rempel wrote: > The gpio1 0 pin is controlling CAN termination, not USB H1 VBUS. So, > remove wrong regulator and assign this gpio to new DT CAN termnation Sigh, the typo is still there with a new version. Fixed it up and applied the series.

[PATCH][RESEND] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2022-02-12 Thread Marek Vasut
In rare cases, the bridge may not start up correctly, which usually leads to no display output. In case this happens, warn about it in the kernel log. Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Laurent Pinchart Cc: Linus Walleij Cc: Robert Foss Cc: Sam Ravnborg Cc:

[PATCH 1/2] drm/bridge: lt9611: Switch to atomic operations

2022-02-12 Thread Marek Vasut
Use the atomic version of the enable/disable operations to continue the transition to the atomic API. This will be needed to access the mode from the atomic state. Signed-off-by: Marek Vasut Cc: Dave Airlie Cc: John Stultz Cc: Maxime Ripard Cc: Sam Ravnborg Cc: Thomas Zimmermann ---

[PATCH 2/2] drm/bridge: lt9611: Add atomic_get_input_bus_fmts

2022-02-12 Thread Marek Vasut
Implement .atomic_get_input_bus_fmts callback, which sets up the input (scanout-engine-end) formats, so that those formats can then be used in pipeline format negotiation between this bridge and the scanout engine. Signed-off-by: Marek Vasut Cc: Dave Airlie Cc: John Stultz Cc: Maxime Ripard

Re: [PATCH v1 1/9] drm/bridge: add DRM_BRIDGE_STATE_OPS macro

2022-02-12 Thread Sam Ravnborg
Hi Laurent, On Tue, Feb 08, 2022 at 02:30:42AM +0200, Laurent Pinchart wrote: > Hi Sam, > > Thank you for the patch. > > On Sun, Feb 06, 2022 at 04:43:57PM +0100, Sam Ravnborg wrote: > > The DRM_BRIDGE_STATE_OPS can be used as shortcut for bridge drivers that > > do not subclass

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-12 Thread Ilia Mirkin
On Wed, Feb 9, 2022 at 11:16 AM Maxime Ripard wrote: > > On Wed, Feb 09, 2022 at 10:38:41PM +0800, Sui Jingfeng wrote: > > On 2022/2/9 16:49, Maxime Ripard wrote: > > > On Fri, Feb 04, 2022 at 12:04:19AM +0800, Sui Jingfeng wrote: > > > > > > +/* Get the simple EDID data from the device tree > >

Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-02-12 Thread Salvatore Bonaccorso
Hi Alex, hi all In Debian we got a regression report from Dominique Dumont, CC'ed in https://bugs.debian.org/1005005 that afer an update to 5.15.15 based kernel, his machine noe longer suspends correctly, after screen going black as usual it comes back. The Debian bug above contians a trace.

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-12 Thread Sui Jingfeng
On 2022/2/10 00:16, Maxime Ripard wrote: On Wed, Feb 09, 2022 at 10:38:41PM +0800, Sui Jingfeng wrote: On 2022/2/9 16:49, Maxime Ripard wrote: On Fri, Feb 04, 2022 at 12:04:19AM +0800, Sui Jingfeng wrote: +/* Get the simple EDID data from the device tree + * the length must be EDID_LENGTH,

Re: [PATCH V2 00/13] use time_is_xxx() instead of jiffies judgment

2022-02-12 Thread Theodore Ts'o
On Thu, Feb 10, 2022 at 06:30:23PM -0800, Qing Wang wrote: > From: Wang Qing > > It is better to use time_is_xxx() directly instead of jiffies judgment > for understanding. Hi Wang, "judgement" doesn't really make sense as a description to an English speaker. The following a commit desription

Re: (subset) [PATCH 02/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5420

2022-02-12 Thread Krzysztof Kozlowski
On Tue, 8 Feb 2022 18:18:15 +0100, Krzysztof Kozlowski wrote: > Add required VDD supplies to HDMI block on SMDK5420. Without them, the > HDMI driver won't probe. Because of lack of schematics, use same > supplies as on Arndale Octa and Odroid XU3 boards (voltage matches). > > Applied, thanks!

Re: (subset) [PATCH 01/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5250

2022-02-12 Thread Krzysztof Kozlowski
On Tue, 8 Feb 2022 18:18:14 +0100, Krzysztof Kozlowski wrote: > Add required VDD supplies to HDMI block on SMDK5250. Without them, the > HDMI driver won't probe. Because of lack of schematics, use same > supplies as on Arndale 5250 board (voltage matches). > > Applied, thanks! [01/10] ARM:

Re: [PATCH] drm/msm: populate intf_audio_select() base on hardware capability

2022-02-12 Thread Dmitry Baryshkov
On Sat, 12 Feb 2022 at 03:59, Abhinav Kumar wrote: > On 2/11/2022 4:08 PM, Dmitry Baryshkov wrote: > > On 12/02/2022 02:23, Kuogee Hsieh wrote: > >> intf_audio_select() callback function use to configure > >> HDMI_DP_CORE_SELECT to decide audio output routes to HDMI or DP > >> interface. HDMI is

Re: [PATCH v5 2/6] drm/format-helper: Add drm_fb_xrgb8888_to_mono_reversed()

2022-02-12 Thread Geert Uytterhoeven
Hi Javier, On Fri, Feb 11, 2022 at 3:34 PM Javier Martinez Canillas wrote: > Add support to convert from XR24 to reversed monochrome for drivers that > control monochromatic display panels, that only have 1 bit per pixel. > > The function does a line-by-line conversion doing an intermediate step

[PATCH v15 1/7] drm/ingenic: Fix support for JZ4780 HDMI output

2022-02-12 Thread H. Nikolaus Schaller
From: Paul Boddie We have to make sure that - JZ_LCD_OSDC_ALPHAEN is set - plane f0 is disabled and not seen from user-space Tested on MIPS Creator CI20 board. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller ---

[PATCH v15 4/7] drm/bridge: dw-hdmi: repair interworking with hdmi-connector for jz4780

2022-02-12 Thread H. Nikolaus Schaller
Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts callbacks") introduced a new mechanism to negotiate bus formats between hdmi connector and the synopsys hdmi driver inside the jz4780. By this, the dw-hdmi is no longer the only bridge and sets up a list of formats in

[PATCH v15 3/7] drm/bridge: display-connector: add ddc-en gpio support

2022-02-12 Thread H. Nikolaus Schaller
"hdmi-connector.yaml" bindings defines an optional property "ddc-en-gpios" for a single gpio to enable DDC operation. Usually this controls +5V power on the HDMI connector. This +5V may also be needed for HPD. This was not reflected in code. Now, the driver activates the ddc gpio after probe

[PATCH v15 7/7] [RFC] drm/ingenic: add some more features specific to jz4780

2022-02-12 Thread H. Nikolaus Schaller
From: Paul Boddie The jz4780 has some more features which should be initialized according to the vendor kernel. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 34 +++ 1 file changed, 34 insertions(+) diff

[PATCH v15 5/7] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-02-12 Thread H. Nikolaus Schaller
so that specialization drivers like ingenic-dw-hdmi can enable polling. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9 + include/drm/bridge/dw_hdmi.h | 1 + 2 files changed, 10 insertions(+) diff --git

[PATCH v15 2/7] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-12 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add Kconfig DRM_INGENIC_DW_HDMI, Makefile and driver code. Signed-off-by: Paul Boddie

[PATCH v15 6/7] drm/ingenic: dw-hdmi: make hot plug detection work for CI20

2022-02-12 Thread H. Nikolaus Schaller
There is no hpd-gpio installed on the CI20 board HDMI connector. Hence there is no hpd detection by the connector driver and we have to enable polling by the dw-hdmi driver. We need to set .poll_enabled but that struct component can only be accessed in the core code. Hence we use the public

[PATCH v15 0/7] MIPS: JZ4780 and CI20 HDMI

2022-02-12 Thread H. Nikolaus Schaller
PATCH V15 2022-02-12 16:50:54: * remove already (elsewhere) merged commits (suggested by p...@crapouillou.net) * clarify commit message for (now) 1/7 ((suggested by p...@crapouillou.net)) PATCH V14 2022-02-12 15:19:25: * make compatible to c03d0b52ff71d5 ("drm/connector: Fix typo in output

Re: [PATCH v14 8/9] [already applied to mips-fixes] MIPS: DTS: CI20: fix how ddc power is enabled

2022-02-12 Thread H. Nikolaus Schaller
> Am 12.02.2022 um 15:58 schrieb Paul Cercueil : > > Hi, > > Le sam., févr. 12 2022 at 15:19:26 +0100, H. Nikolaus Schaller > a écrit : >> Originally we proposed a new hdmi-5v-supply regulator reference >> for CI20 device tree but that was superseded by a better idea to use >> the already

Re: [PATCH v14 5/9] drm/bridge: dw-hdmi: repair interworking with hdmi-connector for jz4780

2022-02-12 Thread H. Nikolaus Schaller
> Am 12.02.2022 um 16:06 schrieb Paul Cercueil : > > Hi Nikolaus, > > > Le sam., févr. 12 2022 at 15:19:23 +0100, H. Nikolaus Schaller > a écrit : >> Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts >> callbacks") >> introduced a new mechanism to negotiate bus

Re: [PATCH v14 1/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-12 Thread H. Nikolaus Schaller
Hi Paul, > Am 12.02.2022 um 15:44 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le sam., févr. 12 2022 at 15:19:19 +0100, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> Add support for the LCD controller present on JZ4780 SoCs. >> This SoC uses 8-byte descriptors which extend the

Re: [PATCH v14 5/9] drm/bridge: dw-hdmi: repair interworking with hdmi-connector for jz4780

2022-02-12 Thread Paul Cercueil
Hi Nikolaus, Le sam., févr. 12 2022 at 15:19:23 +0100, H. Nikolaus Schaller a écrit : Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts callbacks") introduced a new mechanism to negotiate bus formats between hdmi connector and the synopsys hdmi driver inside the

Re: [PATCH v14 8/9] [already applied to mips-fixes] MIPS: DTS: CI20: fix how ddc power is enabled

2022-02-12 Thread Paul Cercueil
Hi, Le sam., févr. 12 2022 at 15:19:26 +0100, H. Nikolaus Schaller a écrit : Originally we proposed a new hdmi-5v-supply regulator reference for CI20 device tree but that was superseded by a better idea to use the already defined "ddc-en-gpios" property of the "hdmi-connector". Since "MIPS:

Re: [PATCH v14 2/9] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2022-02-12 Thread Paul Cercueil
Hi, Le sam., févr. 12 2022 at 15:19:20 +0100, H. Nikolaus Schaller a écrit : From: Sam Ravnborg Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel Signed-off-by: Sam Ravnborg Signed-off-by: H. Nikolaus Schaller Cc: Rob

Re: [PATCH v14 1/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-12 Thread Paul Cercueil
Hi Nikolaus, Le sam., févr. 12 2022 at 15:19:19 +0100, H. Nikolaus Schaller a écrit : From: Paul Boddie Add support for the LCD controller present on JZ4780 SoCs. This SoC uses 8-byte descriptors which extend the current 4-byte descriptors used for other Ingenic SoCs. Note that plane f0 is

[PATCH v14 9/9] [RFC] drm/ingenic: add some more features specific to jz4780

2022-02-12 Thread H. Nikolaus Schaller
From: Paul Boddie The jz4780 has some more features which should be initialized according to the vendor kernel. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 34 +++ 1 file changed, 34 insertions(+) diff

[PATCH v14 7/9] drm/ingenic: dw-hdmi: make hot plug detection work for CI20

2022-02-12 Thread H. Nikolaus Schaller
There is no hpd-gpio installed on the CI20 board HDMI connector. Hence there is no hpd detection by the connector driver and we have to enable polling by the dw-hdmi driver. We need to set .poll_enabled but that struct component can only be accessed in the core code. Hence we use the public

[PATCH v14 8/9] [already applied to mips-fixes] MIPS: DTS: CI20: fix how ddc power is enabled

2022-02-12 Thread H. Nikolaus Schaller
Originally we proposed a new hdmi-5v-supply regulator reference for CI20 device tree but that was superseded by a better idea to use the already defined "ddc-en-gpios" property of the "hdmi-connector". Since "MIPS: DTS: CI20: Add DT nodes for HDMI setup" has already been applied to v5.17-rc1, we

[PATCH v14 5/9] drm/bridge: dw-hdmi: repair interworking with hdmi-connector for jz4780

2022-02-12 Thread H. Nikolaus Schaller
Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts callbacks") introduced a new mechanism to negotiate bus formats between hdmi connector and the synopsys hdmi driver inside the jz4780. By this, the dw-hdmi is no longer the only bridge and sets up a list of formats in

[PATCH v14 4/9] drm/bridge: display-connector: add ddc-en gpio support

2022-02-12 Thread H. Nikolaus Schaller
"hdmi-connector.yaml" bindings defines an optional property "ddc-en-gpios" for a single gpio to enable DDC operation. Usually this controls +5V power on the HDMI connector. This +5V may also be needed for HPD. This was not reflected in code. Now, the driver activates the ddc gpio after probe

[PATCH v14 6/9] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-02-12 Thread H. Nikolaus Schaller
so that specialization drivers like ingenic-dw-hdmi can enable polling. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9 + include/drm/bridge/dw_hdmi.h | 1 + 2 files changed, 10 insertions(+) diff --git

[PATCH v14 1/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-12 Thread H. Nikolaus Schaller
From: Paul Boddie Add support for the LCD controller present on JZ4780 SoCs. This SoC uses 8-byte descriptors which extend the current 4-byte descriptors used for other Ingenic SoCs. Note that plane f0 is not working and disabled to be seen from user-space. Tested on MIPS Creator CI20 board.

[PATCH v14 2/9] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2022-02-12 Thread H. Nikolaus Schaller
From: Sam Ravnborg Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel Signed-off-by: Sam Ravnborg Signed-off-by: H. Nikolaus Schaller Cc: Rob Herring Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring ---

[PATCH v14 3/9] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-12 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add Kconfig DRM_INGENIC_DW_HDMI, Makefile and driver code. Signed-off-by: Paul Boddie

[PATCH v14 0/9] MIPS: JZ4780 and CI20 HDMI

2022-02-12 Thread H. Nikolaus Schaller
PATCH V14 2022-02-12 15:19:25: * make compatible to c03d0b52ff71d5 ("drm/connector: Fix typo in output format") * move "dw-hdmi/ingenic-dw-hdmi: repair interworking with hdmi-connector" before drm/ingenic: Add dw-hdmi driver specialization for jz4780 (by p...@crapouillou.net) * split

Re: [v1 2/2] drm/msm/disp/dpu1: Add PSR support for eDP interface in dpu driver

2022-02-12 Thread Dmitry Baryshkov
On Sat, 12 Feb 2022 at 15:52, Vinod Polimera wrote: > > Enable PSR on eDP interface using drm self-refresh librabry. > This patch uses a trigger from self-refresh library to enter/exit > into PSR, when there are no updates from framework. > > Signed-off-by: Vinod Polimera > Signed-off-by: Kalyan

Re: [PATCH v13 0/9] MIPS: JZ4780 and CI20 HDMI

2022-02-12 Thread H. Nikolaus Schaller
Hi, > Am 09.02.2022 um 15:02 schrieb Paul Cercueil : > > Hi, > > Le mer., févr. 9 2022 at 14:51:12 +0100, H. Nikolaus Schaller > a écrit : >> Paul, >>> Am 09.02.2022 um 12:52 schrieb Paul Cercueil : >>> Hi Nikolaus, >>> I tried applying patches 1-2, but they don't apply cleanly on top of >>>

Re: [v1 1/2] drm/msm/dp: Add basic PSR support for eDP

2022-02-12 Thread Dmitry Baryshkov
On Sat, 12 Feb 2022 at 15:52, Vinod Polimera wrote: > > Add support for basic panel self refresh (PSR) feature for eDP. > Add a new interface to set PSR state in the sink from DPU. > Program the eDP controller to issue PSR enter and exit SDP to > the sink. > > Signed-off-by: Sankeerth Billakanti

Re: [PATCH v5 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-02-12 Thread Javier Martinez Canillas
On 2/11/22 20:19, Javier Martinez Canillas wrote: [snip] >> I would put GENMASK() directly into FIELD(), but it's up to you >> (and I haven't checked the use of *_MASK anyway). >> > > Same. I also considered just using GENMASK() directly, but since I was > already reworking these, I thought

Re: [PATCH] devcoredump: increase the device delete timeout to 10 mins

2022-02-12 Thread Abhinav Kumar
Hi Johannes On 2/12/2022 12:24 AM, Johannes Berg wrote: On Fri, 2022-02-11 at 23:52 -0800, Abhinav Kumar wrote: The thread is writing the data to a file in local storage. From our profiling, the read is the one taking the time not the write. That seems kind of hard to believe, let's say

Re: [PATCH] devcoredump: increase the device delete timeout to 10 mins

2022-02-12 Thread Abhinav Kumar
Hi Greg On 2/12/2022 12:29 AM, Greg KH wrote: On Fri, Feb 11, 2022 at 11:52:41PM -0800, Abhinav Kumar wrote: Hi Greg On 2/11/2022 11:04 PM, Greg KH wrote: On Fri, Feb 11, 2022 at 10:59:39AM -0800, Abhinav Kumar wrote: Hi Greg Thanks for the response. On 2/11/2022 3:09 AM, Greg KH wrote:

Re: [PATCH] devcoredump: increase the device delete timeout to 10 mins

2022-02-12 Thread Greg KH
On Fri, Feb 11, 2022 at 11:52:41PM -0800, Abhinav Kumar wrote: > Hi Greg > > On 2/11/2022 11:04 PM, Greg KH wrote: > > On Fri, Feb 11, 2022 at 10:59:39AM -0800, Abhinav Kumar wrote: > > > Hi Greg > > > > > > Thanks for the response. > > > > > > On 2/11/2022 3:09 AM, Greg KH wrote: > > > > On

Re: [PATCH] devcoredump: increase the device delete timeout to 10 mins

2022-02-12 Thread Johannes Berg
On Fri, 2022-02-11 at 23:52 -0800, Abhinav Kumar wrote: > > The thread is writing the data to a file in local storage. From our > profiling, the read is the one taking the time not the write. > That seems kind of hard to believe, let's say it's a 4/3 split (4 minutes reading, 3 minutes