Re: [PATCH 0/2] drm/mm: Add an iterator to optimally walk over holes suitable for an allocation

2022-02-14 Thread Christian König
Am 15.02.22 um 00:56 schrieb Vivek Kasireddy: The first patch is a drm core patch that replaces the for loop in drm_mm_insert_node_in_range() with the iterator and would not cause any functional changes. The second patch is a i915 driver specific patch that also uses the iterator but solves a

Re: [RFC v2 6/6] android: binder: Add a buffer flag to relinquish ownership of fds

2022-02-14 Thread Greg Kroah-Hartman
On Mon, Feb 14, 2022 at 11:19:35PM -0800, Suren Baghdasaryan wrote: > On Mon, Feb 14, 2022 at 11:01 PM Greg Kroah-Hartman > wrote: > > > > On Mon, Feb 14, 2022 at 02:25:47PM -0800, T.J. Mercier wrote: > > > On Fri, Feb 11, 2022 at 11:19 PM Greg Kroah-Hartman > > > > > ---

Re: [PATCH v4 00/10] Overhaul `is_thunderbolt`

2022-02-14 Thread Lukas Wunner
On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote: > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- > drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 2 +- > drivers/gpu/drm/nouveau/nouveau_vga.c | 4 +- > drivers/gpu/drm/radeon/radeon_device.c | 4 +- >

Re: [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-14 Thread Gabriel Krisman Bertazi
Hsin-Yi Wang writes: > On Tue, Feb 15, 2022 at 9:17 AM Gabriel Krisman Bertazi > wrote: >> >> Hsin-Yi Wang writes: >> >> > drm_dev_register() sets connector->registration_state to >> > DRM_CONNECTOR_REGISTERED and dev->registered to true. If >> > drm_connector_set_panel_orientation() is first

Re: [PATCH 09/27] mm: generalize the pgmap based page_free infrastructure

2022-02-14 Thread Logan Gunthorpe
On 2022-02-10 12:28 a.m., Christoph Hellwig wrote: > Key off on the existence of ->page_free to prepare for adding support for > more pgmap types that are device managed and thus need the free callback. > > Signed-off-by: Christoph Hellwig Great! This makes my patch simpler. Reviewed-by:

Re: [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-14 Thread Gabriel Krisman Bertazi
Hsin-Yi Wang writes: > drm_dev_register() sets connector->registration_state to > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > drm_connector_set_panel_orientation() is first called after > drm_dev_register(), it will fail several checks and results in following > warning. Hi, I

Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC

2022-02-14 Thread Andreas Kemnade
Hi Rob, On Fri, 11 Feb 2022 09:46:27 -0600 Rob Herring wrote: > On Sun, Feb 06, 2022 at 09:00:11AM +0100, Andreas Kemnade wrote: > > Add a binding for the Electrophoretic Display Controller found at least > > in the i.MX6. > > The first version was in i.MX50 (I helped design the register >

Re: [RFC v2 6/6] android: binder: Add a buffer flag to relinquish ownership of fds

2022-02-14 Thread Greg Kroah-Hartman
On Mon, Feb 14, 2022 at 02:25:47PM -0800, T.J. Mercier wrote: > On Fri, Feb 11, 2022 at 11:19 PM Greg Kroah-Hartman > > > --- a/include/uapi/linux/android/binder.h > > > +++ b/include/uapi/linux/android/binder.h > > > @@ -137,6 +137,7 @@ struct binder_buffer_object { > > > > > > enum { > > >

[PATCH 3/3] drm/i915: Fix for PHY_MISC_TC1 offset

2022-02-14 Thread Ramalingam C
From: Jouni Högander Currently ICL_PHY_MISC macro is returning offset 0x64C10 for PHY_E port. Correct offset is 0x64C14. Fix this by handling PHY_E port seprately. Signed-off-by: Matt Roper Signed-off-by: Jouni Högander Signed-off-by: Ramalingam C ---

[PATCH 2/3] drm/i915/dg2: Drop 38.4 MHz MPLLB tables

2022-02-14 Thread Ramalingam C
From: Matt Roper Our early understanding of DG2 was incorrect; since the 5th display isn't actually a Type-C output, 38.4 MHz input clocks are never used on this platform and we can drop the corresponding MPLLB tables. Cc: Anusha Srivatsa Cc: José Roberto de Souza Signed-off-by: Matt Roper

[PATCH 1/3] drm/i915/dg2: Enable 5th display

2022-02-14 Thread Ramalingam C
From: Matt Roper DG2 supports a 5th display output which the hardware refers to as "TC1," even though it isn't a Type-C output. This behaves similarly to the TC1 on past platforms with just a couple minor differences: * DG2's TC1 bit in SDEISR is at bit 25 rather than 24 as it is on

[PATCH 0/3] drm/i915/dg2: 5th Display output

2022-02-14 Thread Ramalingam C
Fixing the 5th Display output for DG2. Jouni Högander (1): drm/i915: Fix for PHY_MISC_TC1 offset Matt Roper (2): drm/i915/dg2: Enable 5th display drm/i915/dg2: Drop 38.4 MHz MPLLB tables drivers/gpu/drm/i915/display/intel_gmbus.c| 16 +- drivers/gpu/drm/i915/display/intel_snps_phy.c

[PATCH] drm/i915/perf: Skip the i915_perf_init for dg2

2022-02-14 Thread Ramalingam C
i915_perf is not enabled for dg2 yet, hence skip the feature initialization. Signed-off-by: Ramalingam C cc: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c

[PATCH] drm/msm/dpu: Disable boot loader configured data paths

2022-02-14 Thread Bjorn Andersson
It's typical for the bootloader to configure CTL_0 for the boot splash or EFIFB, but for non-DSI use cases the DPU driver tend to pick another CTL and the system might end up with two configured data paths producing data on the same INTF. In particular as the IOMMU configuration isn't retained

[PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-14 Thread Bjorn Andersson
From: Rob Clark Add SC8180x to the hardware catalog, for initial support for the platform. Due to limitations in the DP driver only one of the four DP interfaces is left enabled. The SC8180x platform supports the newly added DPU_INTF_WIDEBUS flag and the Windows-on-Snapdragon bootloader leaves

[PATCH v2 1/2] drm/msm/dpu: Add INTF_5 interrupts

2022-02-14 Thread Bjorn Andersson
SC8180x has the eDP controller wired up to INTF_5, so add the interrupt register block for this interface to the list. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 6 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h |

Re: [PATCH v4 2/2] drm/msm/dp: enable widebus feature for display port

2022-02-14 Thread Bjorn Andersson
On Mon 14 Feb 16:39 CST 2022, Kuogee Hsieh wrote: > Widebus feature will transmit two pixel data per pixel clock to interface. > This feature now is required to be enabled to easy migrant to higher > resolution applications in future. However since some legacy chipsets > does not support this

Re: [PATCH v4 1/2] drm/msm/dp: revise timing engine programming to support widebus feature

2022-02-14 Thread Bjorn Andersson
On Mon 14 Feb 16:39 CST 2022, Kuogee Hsieh wrote: > Widebus feature will transmit two pixel data per pixel clock to interface. > Timing engine provides driving force for this purpose. This patch base > on HPG (Hardware Programming Guide) to revise timing engine register > setting to accommodate

Re: [PATCH v7 1/7] drm/lsdc: add drm driver for loongson display controller

2022-02-14 Thread Sui Jingfeng
On 2022/2/14 18:10, Maxime Ripard wrote: On Sun, Feb 13, 2022 at 10:16:43PM +0800, Sui Jingfeng wrote: From: suijingfeng There is a display controller in loongson's LS2K1000 SoC and LS7A1000 bridge chip, the DC is a PCI device in those chips. It has two display pipes but with only one

Re: [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-14 Thread Hsin-Yi Wang
On Tue, Feb 15, 2022 at 9:17 AM Gabriel Krisman Bertazi wrote: > > Hsin-Yi Wang writes: > > > drm_dev_register() sets connector->registration_state to > > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > > drm_connector_set_panel_orientation() is first called after > >

RE: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-02-14 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Salvatore Bonaccorso On Behalf > Of Salvatore Bonaccorso > Sent: Sunday, February 13, 2022 2:24 AM > To: Deucher, Alexander > Cc: Dominique Dumont ; 1005...@bugs.debian.org; > Tuikov, Luben ; Quan, Evan > ; Sasha Levin ; Koenig,

[PATCH] amdgpu: assign adev after null check

2022-02-14 Thread Qing Wang
From: Wang Qing adev should be assigned after a null check Signed-off-by: Wang Qing --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c index

[PATCH V3 13/13] media: vivid: use time_is_after_jiffies() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing --- drivers/media/test-drivers/vivid/vivid-kthread-cap.c | 3 ++- drivers/media/test-drivers/vivid/vivid-kthread-out.c | 3 ++-

[PATCH V3 12/13] media: wl128x: use time_is_before_jiffies() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing --- drivers/media/radio/wl128x/fmdrv_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/radio/wl128x/fmdrv_common.c

[PATCH V3 11/13] media: tda8083: use time_is_after_jiffies() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing --- drivers/media/dvb-frontends/tda8083.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/tda8083.c

[PATCH V3 10/13] md: use time_is_before_eq_jiffies() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing --- drivers/md/dm-writecache.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c index

[PATCH V3 10/13] media: stv0299: use time_is_before_jiffies() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing --- drivers/media/dvb-frontends/stv0299.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0299.c

[PATCH V3 9/13] media: si21xx: use time_is_before_jiffies() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing --- drivers/media/dvb-frontends/si21xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/si21xx.c

[PATCH V3 7/13] md: use time_is_before_jiffies(() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing --- drivers/md/dm-thin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index f4234d6..dced764 ---

[PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing --- drivers/input/serio/ps2-gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/serio/ps2-gpio.c

[PATCH V3 5/13] hid: use time_is_after_jiffies() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH V3 4/13] gpu: drm: radeon: use time_is_before_jiffies() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing --- drivers/gpu/drm/radeon/radeon_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_pm.c

[PATCH V3 3/13] gpu: drm: i915: use time_is_after_jiffies() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing --- drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c

[PATCH V3 2/13] clk: mvebu: use time_is_before_eq_jiffies() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing --- drivers/clk/mvebu/armada-37xx-periph.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/mvebu/armada-37xx-periph.c

[PATCH V3 1/13] block: xen: use time_is_before_eq_jiffies() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing --- drivers/block/xen-blkback/blkback.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c

[PATCH V3 00/13] use time_is_{before, after}_jiffies() instead of open coding it

2022-02-14 Thread Qing Wang
From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. V2: Batch them in a series suggested by Joe. Use time_xxx_jiffies() instead of time_xxx() suggested by Kieran. V3: Fix subject and description suggested by Ted. Wang Qing (14): block: xen:

[PATCH] drm/i915/guc: Initialize GuC submission locks and queues early

2022-02-14 Thread Daniele Ceraolo Spurio
Move initialization of submission-related spinlock, lists and workers to init_early. This fixes an issue where if the GuC init fails we might still try to get the lock in the context cleanup code. Note that it is safe to call the GuC context cleanup code even if the init failed because all

linux-next: build failure after merge of the drm-intel tree

2022-02-14 Thread Stephen Rothwell
f you guys run stuff through your CI before relasing to linux-next. Especially important when removing #include statements from include files :-) I have used the drm-intel tree from next-20220214 for today. -- Cheers, Stephen Rothwell pgpL5IiK2RgCC.pgp Description: OpenPGP digital signature

[PATCH 2/2] drm/i915/gem: Don't try to map and fence large scanout buffers (v7)

2022-02-14 Thread Vivek Kasireddy
On platforms capable of allowing 8K (7680 x 4320) modes, pinning 2 or more framebuffers/scanout buffers results in only one that is mappable/ fenceable. Therefore, pageflipping between these 2 FBs where only one is mappable/fenceable creates latencies large enough to miss alternate vblanks thereby

[PATCH 0/2] drm/mm: Add an iterator to optimally walk over holes suitable for an allocation

2022-02-14 Thread Vivek Kasireddy
The first patch is a drm core patch that replaces the for loop in drm_mm_insert_node_in_range() with the iterator and would not cause any functional changes. The second patch is a i915 driver specific patch that also uses the iterator but solves a different problem. Cc: Tvrtko Ursulin Cc: Nirmoy

[PATCH 1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation (v3)

2022-02-14 Thread Vivek Kasireddy
This iterator relies on drm_mm_first_hole() and drm_mm_next_hole() functions to identify suitable holes for an allocation of a given size by efficiently traversing the rbtree associated with the given allocator. It replaces the for loop in drm_mm_insert_node_in_range() and can also be used by drm

[PATCH v4 07/10] drm/amd: drop the use of `pci_is_thunderbolt_attached`

2022-02-14 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Reviewed-by: Macpaul Lin Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2

[PATCH v4 06/10] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-14 Thread Mario Limonciello
The `is_thunderbolt` attribute originally had a well defined list of quirks that it existed for, but it has been overloaded with more meaning. Instead use the driver core removable attribute to indicate the detail a device is attached to a thunderbolt or USB4 chain. Signed-off-by: Mario

[PATCH v4 10/10] PCI: drop `pci_is_thunderbolt_attached`

2022-02-14 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. As all drivers now look at the removable attribute, drop this function. Signed-off-by: Mario Limonciello --- include/linux/pci.h | 22 -- 1 file changed, 22 deletions(-) diff

[PATCH v4 09/10] drm/radeon: drop the use of `pci_is_thunderbolt_attached`

2022-02-14 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/radeon/radeon_device.c | 4 ++--

[PATCH v4 08/10] drm/nouveau: drop the use of `pci_is_thunderbolt_attached`

2022-02-14 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/nouveau/nouveau_vga.c | 4 ++-- 1 file changed, 2

[PATCH v4 02/10] PCI: Move `is_thunderbolt` check for lack of command completed to a quirk

2022-02-14 Thread Mario Limonciello
The `is_thunderbolt` check is currently used to indicate the lack of command completed support for a number of older Thunderbolt devices. This however is heavy handed and should have been done via a quirk. Move the affected devices outlined in commit 493fb50e958c ("PCI: pciehp: Assume NoCompl+

[PATCH v4 04/10] PCI: Detect PCIe root ports for discrete USB4 controllers

2022-02-14 Thread Mario Limonciello
Discrete USB4 controllers won't have ACPI nodes specifying which root ports they are linked with when the software connection manager creates tunnels. These PCIe root ports should be marked as external so that existing logic will mark tunneled devices as removable. In order to set the external

[PATCH v4 05/10] PCI: Move check for old Apple Thunderbolt controllers into a quirk

2022-02-14 Thread Mario Limonciello
`pci_bridge_d3_possible` currently checks explicitly for a Thunderbolt controller to indicate that D3 is possible. This is used solely for older Apple systems, due to a variety of factors: * Apple used SW connection manager from the beginning, other manufacturers used a FW connection manager

[PATCH v4 03/10] PCI: Detect root port of internal USB4 controllers

2022-02-14 Thread Mario Limonciello
The root port used for PCIe tunneling is the root of the hierarchy used for all PCIe devices that are connected downstream. Tunnels are created and destroyed by the USB4 SW CM. So this port should be marked as external meaning all devices connected to it are appropriately marked as removable for

[PATCH v4 01/10] PCI: Add USB4 class definition

2022-02-14 Thread Mario Limonciello
This PCI class definition of the USB4 device is currently located only in the thunderbolt driver. It will be needed by a few other drivers for upcoming changes. Move it into the common include file. Acked-by: Bjorn Helgaas Acked-by: Alex Deucher Acked-by: Mika Westerberg Signed-off-by: Mario

[PATCH v4 00/10] Overhaul `is_thunderbolt`

2022-02-14 Thread Mario Limonciello
Various drivers in the kernel use `is_thunderbolt` or `pci_is_thunderbolt_attached` to designate behaving differently from a device that is internally in the machine. This relies upon checks for a specific capability only set on Intel controllers. Non-Intel USB4 designs should also match this

Re: [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-14 Thread Bjorn Andersson
On Mon 14 Feb 09:59 PST 2022, Imre Deak wrote: > On Mon, Feb 07, 2022 at 08:43:27PM -0800, Bjorn Andersson wrote: > > In some implementations, such as the Qualcomm platforms, the display > > driver has no way to query the current HPD state and as such it's > > impossible to distinguish between

Re: [Freedreno] [PATCH v5 6/6] drm/msm/dpu: move VBIF blocks handling to dpu_rm

2022-02-14 Thread Abhinav Kumar
On 2/14/2022 2:39 PM, Dmitry Baryshkov wrote: On 15/02/2022 01:04, Abhinav Kumar wrote: On 2/14/2022 12:56 PM, Dmitry Baryshkov wrote: On 14/02/2022 22:53, Abhinav Kumar wrote: On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: Move handling of VBIF blocks into dpu_rm. This serves the

Re: [Freedreno] [PATCH v5 6/6] drm/msm/dpu: move VBIF blocks handling to dpu_rm

2022-02-14 Thread Dmitry Baryshkov
On 15/02/2022 01:04, Abhinav Kumar wrote: On 2/14/2022 12:56 PM, Dmitry Baryshkov wrote: On 14/02/2022 22:53, Abhinav Kumar wrote: On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: Move handling of VBIF blocks into dpu_rm. This serves the purpose of unification of handling of all hardware

[PATCH v4 2/2] drm/msm/dp: enable widebus feature for display port

2022-02-14 Thread Kuogee Hsieh
Widebus feature will transmit two pixel data per pixel clock to interface. This feature now is required to be enabled to easy migrant to higher resolution applications in future. However since some legacy chipsets does not support this feature, this feature is enabled base on chip's hardware

[PATCH v4 1/2] drm/msm/dp: revise timing engine programming to support widebus feature

2022-02-14 Thread Kuogee Hsieh
Widebus feature will transmit two pixel data per pixel clock to interface. Timing engine provides driving force for this purpose. This patch base on HPG (Hardware Programming Guide) to revise timing engine register setting to accommodate both widebus and non widebus application. Also horizontal

[PATCH v4 0/2] enable widebus feature base on chip hardware revision

2022-02-14 Thread Kuogee Hsieh
split into 2 patches 1) widebus timing engine programming 2) enable widebus feature base on chip hardware revision Kuogee Hsieh (2): drm/msm/dp: revise timing engine programming to support widebus feature drm/msm/dp: enable widebus feature for display port

Re: [Freedreno] [PATCH v5 6/6] drm/msm/dpu: move VBIF blocks handling to dpu_rm

2022-02-14 Thread Abhinav Kumar
On 2/14/2022 12:56 PM, Dmitry Baryshkov wrote: On 14/02/2022 22:53, Abhinav Kumar wrote: On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: Move handling of VBIF blocks into dpu_rm. This serves the purpose of unification of handling of all hardware blocks inside the DPU driver. This removes

Re: [PATCH v2] drm/msm: populate intf_audio_select() base on hardware capability

2022-02-14 Thread Dmitry Baryshkov
On 15/02/2022 00:46, Kuogee Hsieh wrote: intf_audio_select() callback function use to configure HDMI_DP_CORE_SELECT to decide audio output routes to HDMI or DP interface. HDMI is obsoleted at newer chipset. To keep supporting legacy hdmi application, intf_audio_select call back function have to

Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-02-14 Thread Alex Deucher
On Sat, Feb 12, 2022 at 1:23 PM Salvatore Bonaccorso wrote: > > Hi Alex, hi all > > In Debian we got a regression report from Dominique Dumont, CC'ed in > https://bugs.debian.org/1005005 that afer an update to 5.15.15 based > kernel, his machine noe longer suspends correctly, after screen going >

[PATCH v2] drm/msm: populate intf_audio_select() base on hardware capability

2022-02-14 Thread Kuogee Hsieh
intf_audio_select() callback function use to configure HDMI_DP_CORE_SELECT to decide audio output routes to HDMI or DP interface. HDMI is obsoleted at newer chipset. To keep supporting legacy hdmi application, intf_audio_select call back function have to be populated base on hardware chip

Re: [PATCH v5 5/6] drm/msm/dpu: fix error handling in dpu_rm_init

2022-02-14 Thread Abhinav Kumar
On 2/14/2022 12:43 PM, Dmitry Baryshkov wrote: On 14/02/2022 22:15, Abhinav Kumar wrote: On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: Using IS_ERR_OR_NULL() together with PTR_ERR() is a typical mistake. If the value is NULL, then the function will return 0 instead of a proper return

Re: [PATCH] drm/msm: populate intf_audio_select() base on hardware capability

2022-02-14 Thread Dmitry Baryshkov
On 14/02/2022 20:55, Kuogee Hsieh wrote: On 2/11/2022 3:36 PM, Dmitry Baryshkov wrote: On Sat, 12 Feb 2022 at 02:23, Kuogee Hsieh wrote: intf_audio_select() callback function use to configure HDMI_DP_CORE_SELECT to decide audio output routes to HDMI or DP interface. HDMI is obsoleted at

Re: [PATCH v5 6/6] drm/msm/dpu: move VBIF blocks handling to dpu_rm

2022-02-14 Thread Dmitry Baryshkov
On 14/02/2022 22:53, Abhinav Kumar wrote: On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: Move handling of VBIF blocks into dpu_rm. This serves the purpose of unification of handling of all hardware blocks inside the DPU driver. This removes hand-coded loops in dpu_vbif (which look for

Re: [PATCH] drm/panfrost: Dynamically allocate pm_domains

2022-02-14 Thread Alyssa Rosenzweig
mali_kbase hardcodes MAX_PM_DOMAINS (=5 for the mt8192 kernel). I have no real objection to it but Angelo did. Maybe should've marked this RFC. On Mon, Feb 14, 2022 at 03:31:32PM -0500, Alyssa Rosenzweig wrote: > MT8192 requires 5 power domains. Rather than bump MAX_PM_DOMAINS and > waste memory

Re: [PATCH v5 5/6] drm/msm/dpu: fix error handling in dpu_rm_init

2022-02-14 Thread Dmitry Baryshkov
On 14/02/2022 22:15, Abhinav Kumar wrote: On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: Using IS_ERR_OR_NULL() together with PTR_ERR() is a typical mistake. If the value is NULL, then the function will return 0 instead of a proper return code. Moreover none of dpu_hw_*_init() functions can

Re: [RFC v2 6/6] android: binder: Add a buffer flag to relinquish ownership of fds

2022-02-14 Thread John Stultz
On Mon, Feb 14, 2022 at 12:19 PM Todd Kjos wrote: > On Mon, Feb 14, 2022 at 11:29 AM Suren Baghdasaryan wrote: > > On Mon, Feb 14, 2022 at 10:33 AM Todd Kjos wrote: > > > > > > Since we are creating a new gpu cgroup abstraction, couldn't this > > > "transfer" be done in userspace by the target

[PATCH] drm/panfrost: Dynamically allocate pm_domains

2022-02-14 Thread Alyssa Rosenzweig
MT8192 requires 5 power domains. Rather than bump MAX_PM_DOMAINS and waste memory on every supported Panfrost chip, instead dynamically allocate pm_domain_devs and pm_domain_links. This adds some flexibility; it seems inevitable a new MediaTek device will require more than 5 domains. On

[PATCH v2] drm/i915: fix build issue when using clang

2022-02-14 Thread Tong Zhang
drm/i915 adds some extra cflags, namely -Wall, which causes instances of -Wformat-security to appear when building with clang, even though this warning is turned off kernel-wide in the main Makefile: > drivers/gpu/drm/i915/gt/intel_gt.c:983:2: error: format string is not a > string literal

Re: [PATCH] drm/i915: fix build issue when using clang

2022-02-14 Thread Tong Zhang
On Sun, Feb 13, 2022 at 10:39 AM Nathan Chancellor wrote: > > On Sat, Feb 12, 2022 at 10:51:06PM -0800, Tong Zhang wrote: > > drm/i915 target adds some extra cflags, especially it does re-apply -Wall. > > In clang this will override -Wno-format-security and cause the build to > > fail when

Re: [PATCH v5 6/6] drm/msm/dpu: move VBIF blocks handling to dpu_rm

2022-02-14 Thread Abhinav Kumar
On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: Move handling of VBIF blocks into dpu_rm. This serves the purpose of unification of handling of all hardware blocks inside the DPU driver. This removes hand-coded loops in dpu_vbif (which look for necessary VBIF instance by looping through the

Re: [RFC v2 0/6] Proposal for a GPU cgroup controller

2022-02-14 Thread Tejun Heo
Hello, On Fri, Feb 11, 2022 at 04:18:23PM +, T.J. Mercier wrote: > The GPU/DRM cgroup controller came into being when a consensus[1] > was reached that the resources it tracked were unsuitable to be integrated > into memcg. Originally, the proposed controller was specific to the DRM >

Re: [PATCH v5 5/6] drm/msm/dpu: fix error handling in dpu_rm_init

2022-02-14 Thread Abhinav Kumar
On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: Using IS_ERR_OR_NULL() together with PTR_ERR() is a typical mistake. If the value is NULL, then the function will return 0 instead of a proper return code. Moreover none of dpu_hw_*_init() functions can return NULL. So, replace all dpu_rm_init()'s

Re: [PATCH v5 4/6] drm/msm/dpu: stop embedding dpu_hw_blk into dpu_hw_intf

2022-02-14 Thread Abhinav Kumar
On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: Now as dpu_hw_intf is not hanled by dpu_rm_get_assigned_resources, there is no point in embedding the (empty) struct dpu_hw_blk into dpu_hw_intf (and using typecasts between dpu_hw_blk and dpu_hw_intf). Drop it and use dpu_hw_intf directly.

[PATCH] drm/i915: Depend on !PREEMPT_RT.

2022-02-14 Thread Sebastian Andrzej Siewior
There are a few sections in the driver which are not compatible with PREEMPT_RT. They trigger warnings and can lead to deadlocks at runtime. Disable the i915 driver on a PREEMPT_RT enabled kernel. This way PREEMPT_RT itself can be enabled without needing to address the i915 issues first. The RT

Re: [PATCH 4/8] drm/i915: Use preempt_disable/enable_rt() where recommended

2022-02-14 Thread Mario Kleiner
On Fri, Feb 11, 2022 at 9:44 AM Sebastian Andrzej Siewior wrote: > > On 2022-01-27 00:29:37 [+0100], Mario Kleiner wrote: > > Hi, first thank you for implementing these preempt disables according to > Hi Mario, > > > the markers i left long ago. And sorry for the rather late reply. > > > > I had

Re: [PATCH] drm/amdgpu: check return status before using stable_pstate

2022-02-14 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Feb 14, 2022 at 1:22 PM wrote: > > From: Tom Rix > > Clang static analysis reports this problem > amdgpu_ctx.c:616:26: warning: Assigned value is garbage > or undefined > args->out.pstate.flags = stable_pstate; > ^ ~ >

[PATCH] drm/amdgpu: check return status before using stable_pstate

2022-02-14 Thread trix
From: Tom Rix Clang static analysis reports this problem amdgpu_ctx.c:616:26: warning: Assigned value is garbage or undefined args->out.pstate.flags = stable_pstate; ^ ~ amdgpu_ctx_stable_pstate can fail without setting stable_pstate. So check. Fixes:

Re: [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-14 Thread Imre Deak
On Mon, Feb 07, 2022 at 08:43:27PM -0800, Bjorn Andersson wrote: > In some implementations, such as the Qualcomm platforms, the display > driver has no way to query the current HPD state and as such it's > impossible to distinguish between disconnect and attention events. > > Add a parameter to

Re: [PATCH] drm/msm: populate intf_audio_select() base on hardware capability

2022-02-14 Thread Kuogee Hsieh
On 2/11/2022 3:36 PM, Dmitry Baryshkov wrote: On Sat, 12 Feb 2022 at 02:23, Kuogee Hsieh wrote: intf_audio_select() callback function use to configure HDMI_DP_CORE_SELECT to decide audio output routes to HDMI or DP interface. HDMI is obsoleted at newer chipset. To keep supporting legacy hdmi

Re: [PATCH 1/9] dt-bindings: Add arm,mali-valhall compatible

2022-02-14 Thread Daniel Stone
On Mon, 14 Feb 2022 at 16:23, Steven Price wrote: > On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > > From the kernel's perspective, pre-CSF Valhall is more or less > > compatible with Bifrost, although they differ to userspace. Add a > > compatible for Valhall to the existing

Re: [PATCH] gpu: ipu-v3: Fix dev_dbg frequency output

2022-02-14 Thread Lucas Stach
Am Montag, dem 14.02.2022 um 16:44 + schrieb Jonas Mark (BT-FIR/ENG1-Grb): > Hi, > > > From: Leo Ruan > > > > This commit corrects the printing of the IPU clock error percentage if it is > > between -0.1% to -0.9%. For example, if the pixel clock requested is 27.2 > > MHz but only 27.0 MHz

Re: [PATCH 5/9] drm/panfrost: Add HW_ISSUE_TTRX_3485 quirk

2022-02-14 Thread Alyssa Rosenzweig
> > TTRX_3485 requires the infamous "dummy job" workaround. I have this > > workaround implemented in a local branch, but I have not yet hit a case > > that requires it so I cannot test whether the implementation is correct. > > In the mean time, add the quirk bit so we can document which

Re: [PATCH 4/9] drm/panfrost: Handle HW_ISSUE_TTRX_3076

2022-02-14 Thread Alyssa Rosenzweig
On Mon, Feb 14, 2022 at 04:23:18PM +, Steven Price wrote: > On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > > From: Alyssa Rosenzweig > > > > Some Valhall GPUs require resets when encountering bus faults due to > > occlusion query writes. Add the issue bit for this and handle

Re: [PATCH 8/9] drm/panfrost: Add Mali-G57 "Natt" support

2022-02-14 Thread Alyssa Rosenzweig
> > index b8865fc9efce..1a0dc7f7f857 100644 > > --- a/drivers/gpu/drm/panfrost/panfrost_issues.h > > +++ b/drivers/gpu/drm/panfrost/panfrost_issues.h > > @@ -258,6 +258,11 @@ enum panfrost_hw_issue { > > > > #define hw_issues_g76 0 > > > > +#define hw_issues_g57 (\ > > +

Re: [PATCH 6/9] drm/panfrost: Add "clean only safe" feature bit

2022-02-14 Thread Alyssa Rosenzweig
> > Add the HW_FEATURE_CLEAN_ONLY_SAFE bit based on kbase. When I actually > > tried to port the logic from kbase, trivial jobs raised Data Invalid > > Faults, so this may depend on other coherency details. It's still useful > > to have the bit to record the feature bit when adding new models. > >

Re: [PATCH 1/9] dt-bindings: Add arm,mali-valhall compatible

2022-02-14 Thread Alyssa Rosenzweig
> > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > index 63a08f3f321d..48aeabd2ed68 100644 > > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > +++

Re: [PATCH v3 0/3] Add connector_type to debug info to differentiate between eDP and DP

2022-02-14 Thread Kuogee Hsieh
Hi Stephen, Can you please review this serial patches. On 2/2/2022 10:56 AM, Kuogee Hsieh wrote: 1) Add connector_type to debug info to differentiate between eDP and DP 2) add more debug info to cover dp Phy 3) repalce DRM_DEBUG_DP with drm_debug_dp Kuogee Hsieh (3): drm/msm/dp: add

AW: [PATCH] gpu: ipu-v3: Fix dev_dbg frequency output

2022-02-14 Thread Jonas Mark (BT-FIR/ENG1-Grb)
Hi, > From: Leo Ruan > > This commit corrects the printing of the IPU clock error percentage if it is > between -0.1% to -0.9%. For example, if the pixel clock requested is 27.2 > MHz but only 27.0 MHz can be achieved the deviation is -0.8%. > But the fixed point math had a flaw and calculated

Re: [PATCH v2] drm/msm/dp: always add fail-safe mode into connector mode list

2022-02-14 Thread Kuogee Hsieh
Hi Stephen, Are you have more comments? On 1/24/2022 3:17 PM, Kuogee Hsieh wrote: Some of DP link compliant test expects to return fail-safe mode if prefer detailed timing mode can not be supported by mainlink's lane and rate after link training. Therefore add fail-safe mode into connector

Re: [PATCH] drm/nouveau/bios: Use HWSQ entry 1 for PowerBook6,1

2022-02-14 Thread Icenowy Zheng
在 2022-02-14星期一的 11:07 -0500,Ilia Mirkin写道: > I'm not saying this is wrong, but could you file a bug at > gitlab.freedesktop.org/drm/nouveau/-/issues and include the VBIOS > (/sys/kernel/debug/dri/0/vbios.rom)? That would make it easier to > review the full situation. Created at

Re: [PATCH 9/9] drm/panfrost: Handle arm,mali-valhall compatible

2022-02-14 Thread Steven Price
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > From: Alyssa Rosenzweig > > The most important Valhall-specific quirks have been handled, so add the > Valhall compatible and probe. > > Signed-off-by: Alyssa Rosenzweig Reviewed-by: Steven Price > --- >

Re: [PATCH 8/9] drm/panfrost: Add Mali-G57 "Natt" support

2022-02-14 Thread Steven Price
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > From: Alyssa Rosenzweig > > Add the features, issues, and GPU ID for Mali-G57, a first-generation > Valhall GPU. Other first- and second-generation Valhall GPUs should be > similar. > > Signed-off-by: Alyssa Rosenzweig > --- >

Re: [PATCH 7/9] drm/panfrost: Don't set L2_MMU_CONFIG quirks

2022-02-14 Thread Steven Price
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > From: Alyssa Rosenzweig > > L2_MMU_CONFIG is an implementation-defined register. Different Mali GPUs > define slightly different MAX_READS and MAX_WRITES fields, which > throttle outstanding reads and writes when set to non-zero

Re: [PATCH 6/9] drm/panfrost: Add "clean only safe" feature bit

2022-02-14 Thread Steven Price
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > From: Alyssa Rosenzweig > > Add the HW_FEATURE_CLEAN_ONLY_SAFE bit based on kbase. When I actually > tried to port the logic from kbase, trivial jobs raised Data Invalid > Faults, so this may depend on other coherency details. It's

Re: [PATCH 5/9] drm/panfrost: Add HW_ISSUE_TTRX_3485 quirk

2022-02-14 Thread Steven Price
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > From: Alyssa Rosenzweig > > TTRX_3485 requires the infamous "dummy job" workaround. I have this > workaround implemented in a local branch, but I have not yet hit a case > that requires it so I cannot test whether the implementation

Re: [PATCH 4/9] drm/panfrost: Handle HW_ISSUE_TTRX_3076

2022-02-14 Thread Steven Price
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > From: Alyssa Rosenzweig > > Some Valhall GPUs require resets when encountering bus faults due to > occlusion query writes. Add the issue bit for this and handle it. > > Signed-off-by: Alyssa Rosenzweig Reviewed-by: Steven Price

Re: [PATCH 3/9] drm/panfrost: Constify argument to has_hw_issue

2022-02-14 Thread Steven Price
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > From: Alyssa Rosenzweig > > Logically, this function is free of side effects, so any pointers it > takes should be const. Needed to avoid a warning in the next patch. > > Signed-off-by: Alyssa Rosenzweig Reviewed-by: Steven Price

Re: [PATCH 2/9] drm/panfrost: Handle HW_ISSUE_TTRX_2968_TTRX_3162

2022-02-14 Thread Steven Price
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote: > From: Alyssa Rosenzweig > > Add handling for the HW_ISSUE_TTRX_2968_TTRX_3162 quirk. Logic ported > from kbase. kbase lists this workaround as used on Mali-G57. > > Signed-off-by: Alyssa Rosenzweig Reviewed-by: Steven Price > ---

  1   2   >