Re: drm/bridge: anx7625: Set downstream sink into normal status

2022-03-02 Thread Pin-yen Lin
Reviewed-by: Pin-Yen Lin On Wed, Mar 2, 2022 at 8:09 PM Xin Ji wrote: > > As downstream sink was set into standby mode while bridge disabled, > this patch used for setting downstream sink into normal status > while enable bridge. > > Signed-off-by: Xin Ji > --- >

[PULL] drm-intel-gt-next

2022-03-02 Thread Joonas Lahtinen
Hi Dave & Daniel, Here is the last feature PR for v5.18. For new platforms we have got more DG2 enabling: small BAR foundations, 64K page support and accelerated migration. For XeHP SDV we've got flat CCS detection and compute command streamer being added. Disabling i915 build on PREEMPT_RT for

Re: [PATCH v2 1/4] drm/i915/gt: Clear compress metadata for Xe_HP platforms

2022-03-02 Thread Hellstrom, Thomas
On Wed, 2022-03-02 at 03:23 +0530, Ramalingam C wrote: > From: Ayaz A Siddiqui > > Xe-HP and latest devices support Flat CCS which reserved a portion of > the device memory to store compression metadata, during the clearing > of > device memory buffer object we also need to clear the associated

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-02 Thread Jakob Koschel
> On 3. Mar 2022, at 05:58, David Laight wrote: > > From: Xiaomeng Tong >> Sent: 03 March 2022 02:27 >> >> On Wed, 2 Mar 2022 14:04:06 +, David Laight >> wrote: >>> I think that it would be better to make any alternate loop macro >>> just set the variable to NULL on the loop exit. >>>

Re: linux-next: build failure after merge of the kspp tree

2022-03-02 Thread Stephen Rothwell
Hi all, ok, today I used the current kspp tree and added three patches as merge fixups: https://lore.kernel.org/all/20220228081421.1504213-1-hsi...@chromium.org/ https://cgit.freedesktop.org/drm/drm-misc/commit/?id=d4da1f27396fb1dde079447a3612f4f512caed07

Re: [PATCH -next] drm/amdgpu: clean up some inconsistent indenting

2022-03-02 Thread Christian König
Am 03.03.22 um 02:52 schrieb Yang Li: Eliminate the follow smatch warning: drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:413 amdgpu_get_xgmi_hive() warn: inconsistent indenting Reported-by: Abaci Robot Signed-off-by: Yang Li Reviewed-by: Christian König ---

Re: [PATCH] drm/msm/gpu: Fix crash on devices without devfreq support

2022-03-02 Thread Dmitry Baryshkov
On Wed, 23 Feb 2022 at 18:46, Rob Clark wrote: > > On Tue, Feb 22, 2022 at 7:11 PM Dmitry Baryshkov > wrote: > > > > On 19/02/2022 21:33, Rob Clark wrote: > > > From: Rob Clark > > > > > > Avoid going down devfreq paths on devices where devfreq is not > > > initialized. > > > > > > Reported-by:

Re: [PATCH v2 2/3] drm/i915: Remove the vma refcount

2022-03-02 Thread Thomas Hellström
On Wed, 2022-03-02 at 14:01 -0800, Niranjana Vishwanathapura wrote: > On Wed, Mar 02, 2022 at 11:21:59AM +0100, Thomas Hellström wrote: > > Now that i915_vma_parked() is taking the object lock on vma > > destruction, > > and the only user of the vma refcount, i915_gem_object_unbind() > > also

Re: [PATCH] drm: Fix no previous prototype error in drm_nomodeset.c

2022-03-02 Thread Guenter Roeck
On Wed, Mar 02, 2022 at 10:39:02PM +0530, Aashish Sharma wrote: > Fix this kernel test robot error: > > drivers/gpu/drm/drm_nomodeset.c:8:6: error: > no previous prototype for 'drm_firmware_drivers_only' > > Including drm_drv.h in drm_nomodeset.c which contains > drm_firmware_drivers_only's

Re: [PATCH 15/15] drm/i915/gt: Clear compress metadata for Xe_HP platforms

2022-03-02 Thread Matt Roper
On Sun, Feb 27, 2022 at 10:22:20PM +0530, Ramalingam C wrote: > Matt, > > Thanks for the review. > > On 2022-02-18 at 17:47:22 -0800, Matt Roper wrote: > > On Sat, Feb 19, 2022 at 12:17:52AM +0530, Ramalingam C wrote: > > > From: Ayaz A Siddiqui > > > > > > Xe-HP and latest devices support

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-02 Thread Byungchul Park
Ted wrote: > On Thu, Mar 03, 2022 at 10:00:33AM +0900, Byungchul Park wrote: > > > > Unfortunately, it's neither perfect nor safe without another wakeup > > source - rescue wakeup source. > > > >consumer producer > > > > lock L > >

RE: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-02 Thread David Laight
From: Xiaomeng Tong > Sent: 03 March 2022 02:27 > > On Wed, 2 Mar 2022 14:04:06 +, David Laight > wrote: > > I think that it would be better to make any alternate loop macro > > just set the variable to NULL on the loop exit. > > That is easier to code for and the compiler might be persuaded

[pull] amdgpu drm-fixes-5.17

2022-03-02 Thread Alex Deucher
Hi Dave, Daniel, Just one small fix for 5.17. The following changes since commit e7c470a4b543375d50d88a4c5abd4b9e0f5adcea: Merge tag 'exynos-drm-fixes-v5.17-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-fixes (2022-02-28 14:05:44 +1000) are available in

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Marek Vasut
On 3/3/22 03:54, Liu Ying wrote: On Wed, 2022-03-02 at 12:57 +0100, Lucas Stach wrote: Am Mittwoch, dem 02.03.2022 um 17:41 +0800 schrieb Liu Ying: On Wed, 2022-03-02 at 10:23 +0100, Lucas Stach wrote: Am Mittwoch, dem 02.03.2022 um 03:54 +0100 schrieb Marek Vasut: On 3/1/22 14:18, Lucas

RE: [intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv (rev3)

2022-03-02 Thread Yang, Fei
Hi Chris, for some reason I didn't receive the review email, so I copied your comments from patchwork and faked this email. >> static void execlists_dequeue(struct intel_engine_cs *engine) >> { >> struct intel_engine_execlists * const execlists = >execlists; >> @@ -1538,6 +1566,16 @@

Re: [EXT] Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Marek Vasut
On 3/2/22 14:14, Robby Cai wrote: Hi [...] LCDIF on i.MX8MP is a different IP which is borrowed from non-iMX series, although it's also called 'LCDIF'. We prefer not mix these two series of IPs in one driver for ease of maintenance and extension. Where does the MX8MP LCDIF come from then,

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Marek Vasut
On 3/2/22 10:23, Lucas Stach wrote: [...] I tend to agree with Marek on this one. We have an instance where the blk-ctrl and the GPC driver between 8m, mini, nano, plus are close, but different enough where each SoC has it's own set of tables and some checks. Lucas created the framework,

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Liu Ying
On Wed, 2022-03-02 at 12:57 +0100, Lucas Stach wrote: > Am Mittwoch, dem 02.03.2022 um 17:41 +0800 schrieb Liu Ying: > > On Wed, 2022-03-02 at 10:23 +0100, Lucas Stach wrote: > > > Am Mittwoch, dem 02.03.2022 um 03:54 +0100 schrieb Marek Vasut: > > > > On 3/1/22 14:18, Lucas Stach wrote: > > > > >

[Bug 215652] kernel 5.17-rc fail to load radeon DRM "modprobe: ERROR: could not insert 'radeon': Unknown symbol in module, or unknown parameter (see dmesg)"

2022-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215652 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-02 Thread Theodore Ts'o
On Thu, Mar 03, 2022 at 10:00:33AM +0900, Byungchul Park wrote: > > Unfortunately, it's neither perfect nor safe without another wakeup > source - rescue wakeup source. > >consumer producer > > lock L > (too much

[PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err()

2022-03-02 Thread Yang Li
The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:277:2-9: line 277 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot

Re: [PATCH v3 00/21] DEPT(Dependency Tracker)

2022-03-02 Thread Byungchul Park
On Wed, Mar 02, 2022 at 04:36:38AM +, Hyeonggon Yoo wrote: > On Mon, Feb 28, 2022 at 06:56:39PM +0900, Byungchul Park wrote: > > I didn't want to bother you so I was planning to send the next spin > > after making more progress. However, PATCH v2 reports too many false > > positives because

[PATCH -next] drm/amdgpu: clean up some inconsistent indenting

2022-03-02 Thread Yang Li
Eliminate the follow smatch warning: drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:413 amdgpu_get_xgmi_hive() warn: inconsistent indenting Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 16 1 file changed, 8 insertions(+), 8

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-02 Thread Byungchul Park
On Mon, Feb 28, 2022 at 04:25:04PM -0500, Theodore Ts'o wrote: > On Mon, Feb 28, 2022 at 11:14:44AM +0100, Jan Kara wrote: > > > case 1. Code with an actual circular dependency, but not deadlock. > > > > > >A circular dependency can be broken by a rescue wakeup source e.g. > > >timeout.

Re: [PATCH] video: fbdev: sm712fb: Fix crash in smtcfb_write()

2022-03-02 Thread Zheyu Ma
Hi, On Thu, Mar 3, 2022 at 12:49 AM Helge Deller wrote: > > On 3/2/22 15:33, Zheyu Ma wrote: > > When the sm712fb driver writes three bytes to the framebuffer, the > > driver will crash: > > > > BUG: unable to handle page fault for address: c90001ff > > RIP:

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-02 Thread Byungchul Park
On Mon, Feb 28, 2022 at 11:14:44AM +0100, Jan Kara wrote: > On Mon 28-02-22 18:28:26, Byungchul Park wrote: > > case 1. Code with an actual circular dependency, but not deadlock. > > > >A circular dependency can be broken by a rescue wakeup source e.g. > >timeout. It's not a deadlock. If

Re: [PATCH 7/8] drm/vmwgfx: Implement MSI/MSI-X support for IRQs

2022-03-02 Thread kernel test robot
Hi Zack, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc6 next-20220302] [cannot apply to airlied/drm-next] [If your

Re: [PATCH v3 00/21] DEPT(Dependency Tracker)

2022-03-02 Thread Byungchul Park
On Wed, Mar 02, 2022 at 04:53:41AM +, Hyeonggon Yoo wrote: > On Wed, Mar 02, 2022 at 04:36:38AM +, Hyeonggon Yoo wrote: > > On Mon, Feb 28, 2022 at 06:56:39PM +0900, Byungchul Park wrote: > > > I didn't want to bother you so I was planning to send the next spin > > > after making more

[PATCH] drm/selftest: plane_helper: Put test structures in static storage

2022-03-02 Thread Nathan Chancellor
Clang warns on certain 32-bit architectures: drivers/gpu/drm/selftests/test-drm_plane_helper.c:76:5: warning: stack frame size (1064) exceeds limit (1024) in 'igt_check_plane_state' [-Wframe-larger-than] int igt_check_plane_state(void *ignored) ^ 1 warning generated. The structures

[Bug 215652] kernel 5.17-rc fail to load radeon DRM "modprobe: ERROR: could not insert 'radeon': Unknown symbol in module, or unknown parameter (see dmesg)"

2022-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215652 --- Comment #2 from Erhard F. (erhar...@mailbox.org) --- Created attachment 300522 --> https://bugzilla.kernel.org/attachment.cgi?id=300522=edit kernel .config (kernel 5.17-rc5, CONFIG_DRM_RADEON=m, Talos II) -- You may reply to this email to

[Bug 215652] kernel 5.17-rc fail to load radeon DRM "modprobe: ERROR: could not insert 'radeon': Unknown symbol in module, or unknown parameter (see dmesg)"

2022-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215652 --- Comment #1 from Erhard F. (erhar...@mailbox.org) --- Created attachment 300521 --> https://bugzilla.kernel.org/attachment.cgi?id=300521=edit kernel dmesg (kernel 5.17-rc5, CONFIG_DRM_RADEON=y, Talos II) -- You may reply to this email to

[Bug 215652] New: kernel 5.17-rc fail to load radeon DRM "modprobe: ERROR: could not insert 'radeon': Unknown symbol in module, or unknown parameter (see dmesg)"

2022-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215652 Bug ID: 215652 Summary: kernel 5.17-rc fail to load radeon DRM "modprobe: ERROR: could not insert 'radeon': Unknown symbol in module, or unknown parameter (see dmesg)"

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-02 Thread H. Nikolaus Schaller
Hi Neil, > Am 02.03.2022 um 15:34 schrieb Neil Armstrong : > > Hi, > >> (cross-checked: RGB mode still works if I force hdmi->sink_is_hdmi = false) > > I don't understand what's wrong, can you try to make the logic select > MEDIA_BUS_FMT_YUV8_1X24 instead of DRM_COLOR_FORMAT_YCBCR422 ? I

Re: [next] arm64: db410c: Internal error: Oops: 96000004 - msm_gpu_pm_suspend

2022-03-02 Thread Rob Clark
Should be fixed by: https://patchwork.freedesktop.org/patch/475238/?series=100448=1 t-b's welcome On Wed, Mar 2, 2022 at 12:35 PM Naresh Kamboju wrote: > > [Please ignore this email if it is already reported] > > Linux next-20220302 running on Qcom db410c the following kernel cras

Re: [PATCH v2 2/3] drm/i915: Remove the vma refcount

2022-03-02 Thread Niranjana Vishwanathapura
On Wed, Mar 02, 2022 at 11:21:59AM +0100, Thomas Hellström wrote: Now that i915_vma_parked() is taking the object lock on vma destruction, and the only user of the vma refcount, i915_gem_object_unbind() also takes the object lock, remove the vma refcount. Signed-off-by: Thomas Hellström ---

Re: [Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-02 Thread Chris Wilson
Quoting fei.y...@intel.com (2022-03-02 18:26:57) > From: Fei Yang > > GPU hangs have been observed when multiple engines write to the > same aux_inv register at the same time. To avoid this each engine > should only invalidate its own auxiliary table. The function > gen12_emit_flush_xcs()

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-02 Thread Kees Cook
On Wed, Mar 02, 2022 at 12:18:45PM -0800, Linus Torvalds wrote: > On Wed, Mar 2, 2022 at 12:07 PM Kees Cook wrote: > > > > I've long wanted to change kfree() to explicitly set pointers to NULL on > > free. https://github.com/KSPP/linux/issues/87 > > We've had this discussion with the gcc people

[next] arm64: db410c: Internal error: Oops: 96000004 - msm_gpu_pm_suspend

2022-03-02 Thread Naresh Kamboju
[Please ignore this email if it is already reported] Linux next-20220302 running on Qcom db410c the following kernel crash reported [1]. metadata: git_ref: master git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next git_sha: adaedcf826dccf01b69d9a1f1997c9446c6b2c54

Re: [PATCH v2 1/3] drm/i915: Remove the vm open count

2022-03-02 Thread Niranjana Vishwanathapura
On Wed, Mar 02, 2022 at 11:21:58AM +0100, Thomas Hellström wrote: vms are not getting properly closed. Rather than fixing that, Remove the vm open count and instead rely on the vm refcount. The vm open count existed solely to break the strong references the vmas had on the vms. Now instead make

Re: [PATCH v2 3/3] drm/i915/gem: Remove some unnecessary code

2022-03-02 Thread Niranjana Vishwanathapura
On Wed, Mar 02, 2022 at 11:22:00AM +0100, Thomas Hellström wrote: The test for vma should always return true, and when assigning -EBUSY to ret, the variable should already have that value. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_gem.c | 32 ++--

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-02 Thread Linus Torvalds
On Wed, Mar 2, 2022 at 12:07 PM Kees Cook wrote: > > I've long wanted to change kfree() to explicitly set pointers to NULL on > free. https://github.com/KSPP/linux/issues/87 We've had this discussion with the gcc people in the past, and gcc actually has some support for it, but it's sadly tied

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-02 Thread Kees Cook
On Wed, Mar 02, 2022 at 10:29:31AM +0100, Rasmus Villemoes wrote: > This won't help the current issue (because it doesn't exist and might > never), but just in case some compiler people are listening, I'd like to > have some sort of way to tell the compiler "treat this variable as > uninitialized

Re: [PATCH] simpldrm: Enable boot time VESA graphic mode selection.

2022-03-02 Thread Javier Martinez Canillas
Hello, On 3/2/22 20:38, Michal Suchánek wrote: > Hello, > > On Wed, Mar 02, 2022 at 08:31:25PM +0100, Thomas Zimmermann wrote: >> Hi, >> >> is this ready to be merged? > > The objections raised so far have been addressed in v4. > > I think this is good to merge. > The v4 patches looks good to

Re: [PATCH] simpldrm: Enable boot time VESA graphic mode selection.

2022-03-02 Thread Michal Suchánek
Hello, On Wed, Mar 02, 2022 at 08:31:25PM +0100, Thomas Zimmermann wrote: > Hi, > > is this ready to be merged? The objections raised so far have been addressed in v4. I think this is good to merge. Thanks Michal > > Best regards > Thomas > > Am 18.02.22 um 10:33 schrieb Michal Suchanek:

Re: [PATCH] simpldrm: Enable boot time VESA graphic mode selection.

2022-03-02 Thread Thomas Zimmermann
Hi, is this ready to be merged? Best regards Thomas Am 18.02.22 um 10:33 schrieb Michal Suchanek: Since switch to simpledrm VESA graphic modes are no longer available with legacy BIOS. The x86 realmode boot code enables the VESA graphic modes when option FB_BOOT_VESA_SUPPORT is enabled. To

Re: [PATCH v3 0/5] fbdev: Improve performance of fbdev console

2022-03-02 Thread Thomas Zimmermann
Hi, merged with fixes for the typoes in the final patch. Thanks for reviewing. Best regards Thomas Am 23.02.22 um 20:37 schrieb Thomas Zimmermann: Optimize performance of the fbdev console for the common case of software-based clearing and image blitting. The commit descripton of each patch

Re: [PATCH v12 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-03-02 Thread Robin Murphy
On 2022-03-02 15:55, Michael Cheng wrote: Thanks for the feedback Robin! Sorry my choices of word weren't that great, but what I meant is to understand how ARM flushes a range of dcache for device drivers, and not an equal to x86 clflush. I believe the concern is if the CPU writes an

Re: [PATCH 0/2] DSI host and peripheral initialisation ordering

2022-03-02 Thread Doug Anderson
Hi, On Wed, Mar 2, 2022 at 9:20 AM Dave Stevenson wrote: > > Hi Doug > > On Wed, 2 Mar 2022 at 00:13, Doug Anderson wrote: > > > > Hi, > > > > On Wed, Feb 16, 2022 at 9:00 AM Dave Stevenson > > wrote: > > > > > > Hi All > > > > > > Hopefully I've cc'ed all those that have bashed this problem

[PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-02 Thread fei . yang
From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-02 Thread Laurent Pinchart
Hi Abhinav, On Wed, Mar 02, 2022 at 10:28:03AM -0800, Abhinav Kumar wrote: > On 2/28/2022 5:42 AM, Laurent Pinchart wrote: > > On Mon, Feb 28, 2022 at 02:28:27PM +0200, Laurent Pinchart wrote: > >> On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula wrote: > >>> On Mon, 28 Feb 2022, Laurent

Re: [PATCH][next] drm: ssd130x: remove redundant initialization of pointer mode

2022-03-02 Thread Javier Martinez Canillas
Hello Colin, Thanks for the patch. On Wed, Mar 2, 2022 at 6:53 PM Colin Ian King wrote: > > Pointer mode is being assigned a value that is never read, it is > being re-assigned later with a new value. The initialization is > redundant and can be removed. > Indeed. Acked-by: Javier Martinez

Re: [PATCH V5 3/6] dt-bindings: display: mediatek: revise enum to const

2022-03-02 Thread Rob Herring
On Tue, Mar 01, 2022 at 04:01:02PM +0800, Rex-BC Chen wrote: > There won't be more than 1 fallback for these bindings, so we modify > them to use const instead of enum. > > Signed-off-by: Rex-BC Chen > --- > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml| 2 +- >

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-02 Thread Abhinav Kumar
On 2/28/2022 5:42 AM, Laurent Pinchart wrote: Hello, On Mon, Feb 28, 2022 at 02:28:27PM +0200, Laurent Pinchart wrote: On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula wrote: On Mon, 28 Feb 2022, Laurent Pinchart wrote: On Sat, Feb 26, 2022 at 10:27:59AM -0800, Rob Clark wrote: On

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-03-02 Thread John Harrison
On 3/2/2022 01:49, Tvrtko Ursulin wrote: On 25/02/2022 20:41, john.c.harri...@intel.com wrote: From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point of 32bit overflow. On current platforms, worst

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-03-02 Thread John Harrison
On 3/2/2022 01:20, Tvrtko Ursulin wrote: On 01/03/2022 19:57, John Harrison wrote: On 3/1/2022 02:50, Tvrtko Ursulin wrote: On 28/02/2022 18:32, John Harrison wrote: On 2/28/2022 08:11, Tvrtko Ursulin wrote: On 25/02/2022 17:39, John Harrison wrote: On 2/25/2022 09:06, Tvrtko Ursulin wrote:

Re: [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml

2022-03-02 Thread Rob Herring
On Wed, Mar 02, 2022 at 03:14:10AM +0300, Dmitry Baryshkov wrote: > Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix > indentation for another brace, so it matches the corresponding line. > > Reported-by: Rob Herring > Cc: Loic Poulain > Reviewed-by: Bjorn Andersson >

Re: [PATCH v2 1/2] dt-bindings: display: msm: Add optional resets

2022-03-02 Thread Rob Herring
On Tue, Mar 01, 2022 at 05:29:30PM -0800, Bjorn Andersson wrote: > Add an optional reference to the MDSS_CORE reset, which when specified > can be used by the implementation to reset the hardware blocks. > > Signed-off-by: Bjorn Andersson > --- > > Changes since v1: > - New approach/patch > >

Re: [PATCH] dt-bindings: gpu: Convert aspeed-gfx bindings to yaml

2022-03-02 Thread Rob Herring
On Wed, Mar 02, 2022 at 03:40:56PM +1030, Joel Stanley wrote: > Convert the bindings to yaml and add the ast2600 compatible string. > > Signed-off-by: Joel Stanley > --- > .../devicetree/bindings/gpu/aspeed,gfx.yaml | 69 +++ > .../devicetree/bindings/gpu/aspeed-gfx.txt|

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

2022-03-02 Thread John Harrison
On 3/2/2022 03:07, Tvrtko Ursulin wrote: On 01/03/2022 20:59, John Harrison wrote: On 3/1/2022 04:09, Tvrtko Ursulin wrote: I'll trim it a bit again.. On 28/02/2022 18:55, John Harrison wrote: On 2/28/2022 09:12, Tvrtko Ursulin wrote: On 25/02/2022 18:48, John Harrison wrote: On 2/25/2022

[PATCH][next] drm: ssd130x: remove redundant initialization of pointer mode

2022-03-02 Thread Colin Ian King
Pointer mode is being assigned a value that is never read, it is being re-assigned later with a new value. The initialization is redundant and can be removed. Cleans up clang scan build warning: drivers/gpu/drm/solomon/ssd130x.c:582:27: warning: Value stored to 'mode' during its initialization is

Re: [Intel-gfx] [PATCH 0/3] Improve anti-pre-emption w/a for compute workloads

2022-03-02 Thread John Harrison
On 3/2/2022 03:21, Tvrtko Ursulin wrote: On 28/02/2022 19:17, John Harrison wrote: On 2/28/2022 07:32, Tvrtko Ursulin wrote: On 25/02/2022 19:03, John Harrison wrote: On 2/25/2022 10:29, Tvrtko Ursulin wrote: On 25/02/2022 18:01, John Harrison wrote: On 2/25/2022 09:39, Tvrtko Ursulin

[PATCH v1 06/10] drm/msm/a6xx: Propagate OOB set error

2022-03-02 Thread Akhil P Oommen
Propagate OOB set error to higher level so that a coredump is captured followed by recovery sequence. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 33 - drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 19 ---

[PATCH v1 10/10] drm/msm/a6xx: Free gmu_debug crashstate bo

2022-03-02 Thread Akhil P Oommen
Free gmu_debug bo while destroying the gpu crashstate. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c index

[PATCH v1 09/10] drm/msm: Remove pm_runtime_get() from msm_job_run()

2022-03-02 Thread Akhil P Oommen
We do pm_runtime_get() within msm_gpu_submit(). So remove the redundant pm_runtime_get/put from msm_job_run(). Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/msm_ringbuffer.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_ringbuffer.c

[PATCH v1 08/10] drm/msm/a6xx: Remove clk votes on failure

2022-03-02 Thread Akhil P Oommen
Remove vote on clks on gpu resume failure. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c index 66ae509..e90359f 100644 ---

[PATCH v1 07/10] drm/msm/adreno: Retry on gpu resume failure

2022-03-02 Thread Akhil P Oommen
Retry infinitely on resume failure because there is nothing much we can do if GPU is not ON. Also, this helps us to avoid checking for the return value of pm_runtime_get() to see if GPU is ON. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_device.c | 10 +- 1 file

[PATCH v1 05/10] drm/msm: Do recovery on hw_init failure

2022-03-02 Thread Akhil P Oommen
Schedule the recover worker when there is hw init failure in msm_gpu_submit(). The recover worker will take care of capturing coredump, gpu recovery and resubmission of pending IBs. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/msm_gpu.c | 5 - 1 file changed, 4 insertions(+), 1

[PATCH v1 03/10] drm/msm/a6xx: Avoid gmu lock in pm ops

2022-03-02 Thread Akhil P Oommen
We don't really need gmu lock in runtime pm ops because these operations are serialized anyway and also with other paths where we take this lock. This patch will help to simplify the locking order when we introduce crashstate_lock in the upcoming patch. Signed-off-by: Akhil P Oommen ---

[PATCH v1 04/10] drm/msm/a6xx: Enhance debugging of gmu faults

2022-03-02 Thread Akhil P Oommen
Add support for inline capture of gmu coredump in gmu resume/suspend path to help debug gmu error/faults. This is sort of a lite version of gpu coredump with just gmu states. And we can't use recover_worker in these scenarios because gmu is collapsed after a failure in this path. Hence we need to

[PATCH v1 02/10] drm/msm/a6xx: Send NMI to gmu when it is hung

2022-03-02 Thread Akhil P Oommen
While capturing gmu state, first send an NMI to gmu when it is hung. This helps to move gmu to a safe state. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 37 + drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 1 +

[PATCH v1 01/10] drm/msm/a6xx: Add helper to check smmu is stalled

2022-03-02 Thread Akhil P Oommen
Add a helper function to check for stalled smmu and also avoid reading RBBM_STATUS3 register which is in GX domain before ensuring GX is ON. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 +++- drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 +

[PATCH v1 00/10] Support for GMU coredump and some related improvements

2022-03-02 Thread Akhil P Oommen
Major enhancement in this series is the support for a minimal gmu coredump which can be captured inline instead of through our usual recover worker. It is helpful in the case of gmu errors during gpu wake-up/suspend path and helps to capture a snapshot of gmu before we do a suspend. I had to

Re: [PATCH 0/2] DSI host and peripheral initialisation ordering

2022-03-02 Thread Dave Stevenson
Hi Doug On Wed, 2 Mar 2022 at 00:13, Doug Anderson wrote: > > Hi, > > On Wed, Feb 16, 2022 at 9:00 AM Dave Stevenson > wrote: > > > > Hi All > > > > Hopefully I've cc'ed all those that have bashed this problem around > > previously, > > or are otherwise linked to DRM bridges. > > > > There

Re: [Intel-gfx] [PATCH 6/6] treewide: remove check of list iterator against head past the loop body

2022-03-02 Thread Tvrtko Ursulin
On 28/02/2022 11:08, Jakob Koschel wrote: When list_for_each_entry() completes the iteration over the whole list without breaking the loop, the iterator value will be a bogus pointer computed based on the head element. While it is safe to use the pointer to determine if it was computed based

Re: [PATCH v12 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-03-02 Thread Alex Deucher
On Wed, Mar 2, 2022 at 10:55 AM Michael Cheng wrote: > > Thanks for the feedback Robin! > > Sorry my choices of word weren't that great, but what I meant is to > understand how ARM flushes a range of dcache for device drivers, and not > an equal to x86 clflush. > > I believe the concern is if the

Re: [PATCH] ASoC: qcom: Fix error code in lpass_platform_copy()

2022-03-02 Thread Mark Brown
On Tue, 1 Mar 2022 11:11:04 +0300, Dan Carpenter wrote: > The copy_to/from_user() functions return the number of bytes remaining > to be copied. This function needs to return negative error codes > because snd_soc_pcm_component_copy_user() treats positive returns as > success in

Re: [PATCH 3/3] dt-bindings: display: bridge: renesas, lvds: Document r8a77961 bindings

2022-03-02 Thread Geert Uytterhoeven
Hi Laurent, On Wed, Dec 29, 2021 at 5:47 PM Laurent Pinchart wrote: > On Fri, Dec 24, 2021 at 08:23:09AM +0300, Nikita Yushchenko wrote: > > Document the R-Car M3-W+ (R8A77961) SoC in the R-Car LVDS encoder > > bindings. > > > > Signed-off-by: Nikita Yushchenko > > --- > >

Re: [PATCH v5 4/7] drm/i915/gt: create per-tile sysfs interface

2022-03-02 Thread Andrzej Hajda
On 17.02.2022 15:41, Andi Shyti wrote: Now that we have tiles we want each of them to have its own interface. A directory "gt/" is created under "cardN/" that will contain as many diroctories as the tiles. In the coming patches tile related interfaces will be added. For now the sysfs gt

Re: [PATCH] video: fbdev: sm712fb: Fix crash in smtcfb_write()

2022-03-02 Thread Helge Deller
On 3/2/22 15:33, Zheyu Ma wrote: > When the sm712fb driver writes three bytes to the framebuffer, the > driver will crash: > > BUG: unable to handle page fault for address: c90001ff > RIP: 0010:smtcfb_write+0x454/0x5b0 > Call Trace: > vfs_write+0x291/0xd60 > ?

Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format

2022-03-02 Thread Marek Vasut
On 3/2/22 15:21, Maxime Ripard wrote: Hi, Hi, Please try to avoid top posting On Wed, Feb 23, 2022 at 04:25:19PM +0100, Max Krummenacher wrote: The goal here is to set the element bus_format in the struct panel_desc. This is an enum with the possible values defined in

Re: [PATCH v12 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-03-02 Thread Michael Cheng
Thanks for the feedback Robin! Sorry my choices of word weren't that great, but what I meant is to understand how ARM flushes a range of dcache for device drivers, and not an equal to x86 clflush. I believe the concern is if the CPU writes an update, that update might only be sitting in the

[PATCH 8/8] drm/vmwgfx: Stop using surface dma commands on most configurations

2022-03-02 Thread Zack Rusin
From: Zack Rusin Initial version of guest backed objects in the host had some performance issues that made using surface-dma's instead of direct copies faster. Surface dma's force a migration to vram which at best is slow and at worst is impossible (e.g. on svga3 where there's not enough vram to

[PATCH 6/8] drm/vmwgfx: Initialize drm_mode_fb_cmd2

2022-03-02 Thread Zack Rusin
From: Zack Rusin Transition to drm_mode_fb_cmd2 from drm_mode_fb_cmd left the structure unitialized. drm_mode_fb_cmd2 adds a few additional members, e.g. flags and modifiers which were never initialized. Garbage in those members can cause random failures during the bringup of the fbcon.

[PATCH 5/8] drm/vmwgfx: Allow querying of the SVGA PCI id from the userspace

2022-03-02 Thread Zack Rusin
From: Zack Rusin Mesa3D loaders require knowledge of the devices PCI id. SVGAv2 and v3 have different PCI id's, but the same driver is used to handle them both. To allow Mesa3D svga driver to be loaded automatically for both SVGAv2 and SVGAv3 make the kernel return the PCI id of the currently

[PATCH 7/8] drm/vmwgfx: Implement MSI/MSI-X support for IRQs

2022-03-02 Thread Zack Rusin
From: Zack Rusin SVGAv3 deprecates legacy interrupts and adds support for MSI/MSI-X. With MSI the driver visible side remains largely unchanged but with MSI-X each interrupt gets delivered on its own vector. Add support for MSI/MSI-X while preserving the old functionality for SVGAv2. Code

[PATCH 1/8] drm/vmwgfx: Add support for CursorMob and CursorBypass 4

2022-03-02 Thread Zack Rusin
From: Martin Krastev * Add support for CursorMob * Add support for CursorBypass 4 * Refactor vmw_du_cursor_plane_atomic_update to be kms-helper-atomic -- move BO mappings to vmw_du_cursor_plane_prepare_fb -- move BO unmappings to vmw_du_cursor_plane_cleanup_fb Cursor mobs are a new svga

[PATCH 4/8] drm/vmwgfx: Fix fencing on SVGAv3

2022-03-02 Thread Zack Rusin
From: Zack Rusin Port of the vmwgfx to SVGAv3 lacked support for fencing. SVGAv3 removed FIFO's and replaced them with command buffers and extra registers. The initial version of SVGAv3 lacked support for most advanced features (e.g. 3D) which made fences unnecessary. That is no longer the case,

[PATCH 2/8] drm/vmwgfx: Cleanup multimon initialization code

2022-03-02 Thread Zack Rusin
From: Zack Rusin The results of the legacy display unit initialization were being silently ignored. Unifying the selection of number of display units based on whether the underlying device supports multimon makes it easier to add error checking to all paths. This makes the driver report the

[PATCH 3/8] drm/vmwgfx: Print capabilities early during the initialization

2022-03-02 Thread Zack Rusin
From: Zack Rusin Capabilities were logged at the end of initialization so any early errors would make them not appear in the logs. Which is also when they're needed the most. Print the the capabilities right after fetching them, before the init code starts using them to make sure they always

[PATCH 0/8] drm/vmwgfx: 3D on arm64 and large cursor support

2022-03-02 Thread Zack Rusin
From: Zack Rusin Series finishes 3D support on arm64 with vmwgfx. With this and changes that add svga3 pci id's to Mesa3D - OpenGL 4.3 and GLES 3.1 work smoothly on arm64. Most changes are not svga3 specific but rather

Re: [PATCH V2 04/12] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-02 Thread Marek Vasut
On 3/2/22 11:01, Maxime Ripard wrote: On Thu, Feb 17, 2022 at 01:25:22AM +0100, Marek Vasut wrote: The driver currently hard-codes DSI lane count to two, however the chip is capable of operating in 1..4 DSI lanes mode. Parse 'data-lanes' DT property and program the result into DSI_CTRL

Re: [PATCH V2 03/12] drm: bridge: icn6211: Add HS/VS/DE polarity handling

2022-03-02 Thread Marek Vasut
On 3/2/22 10:59, Maxime Ripard wrote: On Thu, Feb 17, 2022 at 01:25:21AM +0100, Marek Vasut wrote: The driver currently hard-codes HS/VS polarity to active-low and DE to active-high, which is not correct for a lot of supported DPI panels. Add the missing mode flag handling for HS/VS/DE

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-02 Thread Neil Armstrong
Hi, On 02/03/2022 12:15, H. Nikolaus Schaller wrote: Hi Neil, Am 02.03.2022 um 11:25 schrieb Neil Armstrong : I added a printk for hdmi->sink_is_hdmi. This returns 1. Which IMHO is to be expected since I am using a HDMI connector and panel... So your patch will still add the UYVY formats.

[PATCH] video: fbdev: sm712fb: Fix crash in smtcfb_write()

2022-03-02 Thread Zheyu Ma
When the sm712fb driver writes three bytes to the framebuffer, the driver will crash: BUG: unable to handle page fault for address: c90001ff RIP: 0010:smtcfb_write+0x454/0x5b0 Call Trace: vfs_write+0x291/0xd60 ? do_sys_openat2+0x27d/0x350 ?

Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format

2022-03-02 Thread Maxime Ripard
Hi, Please try to avoid top posting On Wed, Feb 23, 2022 at 04:25:19PM +0100, Max Krummenacher wrote: > The goal here is to set the element bus_format in the struct > panel_desc. This is an enum with the possible values defined in > include/uapi/linux/media-bus-format.h. > > The enum values are

[Bug 215648] amdgpu: Changing monitor configuration (plug/unplug/wake from DPMS) causes kernel panic

2022-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215648 --- Comment #5 from Philipp Riederer (pr_ker...@tum.fail) --- Hey, Thank you for working on this! I added the dmesg as attachment to the bug. Please note that this is from the working kernel (commit 94ba5b0fb52d6dbf1f200351876a839afb74aedd) as

[Bug 215648] amdgpu: Changing monitor configuration (plug/unplug/wake from DPMS) causes kernel panic

2022-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215648 --- Comment #4 from Philipp Riederer (pr_ker...@tum.fail) --- Created attachment 300517 --> https://bugzilla.kernel.org/attachment.cgi?id=300517=edit dmesg from boot using kernel 5.15.12@94ba5b0fb52d6dbf1f200351876a839afb74aedd -- You may

[Bug 215648] amdgpu: Changing monitor configuration (plug/unplug/wake from DPMS) causes kernel panic

2022-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215648 --- Comment #3 from Alex Deucher (alexdeuc...@gmail.com) --- Thanks. Can you get the dmesg output from boot prior to the hang? -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee

RE: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-02 Thread David Laight
From: Xiaomeng Tong > Sent: 02 March 2022 09:31 > > On Mon, 28 Feb 2022 16:41:04 -0800, Linus Torvalds > wrote: > > > > But basically to _me_, the important part is that the end result is > > maintainable longer-term. > > I couldn't agree more. And because of that, I stick with the following >

Re: [PATCH 1/2] drm: Introduce DRM_BRIDGE_OP_UPSTREAM_FIRST to alter bridge init order

2022-03-02 Thread Dave Stevenson
Hi Andrzej On Mon, 28 Feb 2022 at 15:36, Andrzej Hajda wrote: > > > > On 22.02.2022 09:43, Dave Stevenson wrote: > > Hi Laurent. > > > > Thanks for the review. > > > > On Tue, 22 Feb 2022 at 06:34, Laurent Pinchart > > wrote: > >> Hi Dave, > >> > >> Thank you for the patch. > >> > >> On Wed,

  1   2   >