Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread H. Nikolaus Schaller
Hi Paul, > Am 04.03.2022 um 19:41 schrieb H. Nikolaus Schaller : > > > >> Am 04.03.2022 um 19:33 schrieb Paul Cercueil : >> >> >> >> Le ven., mars 4 2022 at 19:15:13 +0100, H. Nikolaus Schaller >> a écrit : >>> Hi Paul, Am 04.03.2022 um 19:04 schrieb Paul Cercueil : Le ven., mars

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-04 Thread Christophe Leroy
Le 04/03/2022 à 21:24, Lyude Paul a écrit : > This mostly looks good to me. Just one question (and one comment down below > that needs addressing). Is this with ppc32? (I ask because ppc64le doesn't > seem to hit this compilation error). That's with PPC64, see http://kisskb.ellerman.id.au/kissk

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-04 Thread Theodore Ts'o
On Fri, Mar 04, 2022 at 12:20:02PM +0900, Byungchul Park wrote: > > I found a point that the two wait channels don't lead a deadlock in > some cases thanks to Jan Kara. I will fix it so that Dept won't > complain it. I sent my last (admittedly cranky) message before you sent this. I'm glad you f

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-04 Thread Theodore Ts'o
On Fri, Mar 04, 2022 at 09:42:37AM +0900, Byungchul Park wrote: > > All contexts waiting for any of the events in the circular dependency > chain will be definitely stuck if there is a circular dependency as I > explained. So we need another wakeup source to break the circle. In > ext4 code, you m

Re: [PATCH v3 3/5] drm/msm: split the main platform driver

2022-03-04 Thread Abhinav Kumar
On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: Currently the msm platform driver is a multiplex handling several cases: - headless GPU-only driver, - MDP4 with flat device nodes, - MDP5/DPU MDSS with all the nodes being children of MDSS node. This results in not-so-perfect code, checking the ha

Re: [PATCH v3 2/5] drm/msm: remove extra indirection for msm_mdss

2022-03-04 Thread Abhinav Kumar
On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: Since now there is just one mdss subdriver, drop all the indirection, make msm_mdss struct completely opaque (and defined inside msm_mdss.c) and call mdss functions directly. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- driv

Re: [PATCH v3 1/5] drm/msm: unify MDSS drivers

2022-03-04 Thread Abhinav Kumar
On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: MDP5 and DPU1 both provide the driver handling the MDSS region, which handles the irq domain and (incase of DPU1) adds some init for the UBWC controller. Unify those two pieces of code into a common driver. Signed-off-by: Dmitry Baryshkov Reviewe

Re: [PATCH v7 10/24] drm/rockchip: dw_hdmi: Add support for hclk

2022-03-04 Thread Dmitry Osipenko
On 3/4/22 17:22, Sascha Hauer wrote: > On Wed, Mar 02, 2022 at 12:25:28PM +0100, Sascha Hauer wrote: >> On Tue, Mar 01, 2022 at 01:39:31PM +, Robin Murphy wrote: >>> On 2022-02-28 14:19, Sascha Hauer wrote: On Fri, Feb 25, 2022 at 02:11:54PM +0100, Sascha Hauer wrote: > On Fri, Feb 25,

Re: [PATCH 0/3] Fix MediaTek display dt-bindings issues

2022-03-04 Thread Chun-Kuang Hu
Hi, Rob: Would you like to take this series into your tree, or I take this series into my tree? Regards, Chun-Kuang. AngeloGioacchino Del Regno 於 2022年3月4日 週五 下午5:55寫道: > > The vdosys0 series carried a nice dt-bindings conversion of the old > txt documentation for the entire mediatek-drm driver

Re: [PATCH 3/3] dt-bindings: display: mediatek: Fix examples on new bindings

2022-03-04 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2022年3月4日 週五 下午5:55寫道: > > To avoid failure of dt_binding_check perform a slight refactoring > of the examples: the main block is kept, but that required fixing > the address and size cells, plus the inclusion of missing dt-bindings > headers, required to

[PATCH v2 2/2] drm/i915/dg2: Add debugfs to control global preemption setting

2022-03-04 Thread Matt Roper
From: Akeem G Abodunrin Since DG2 and beyond only support global preemption enable/disable (see Wa_14015141709), userspace no longer has a way to control preemption on a per-context basis. Preemption is globally enabled by default, but the UMD teams have requested that we provide a debugfs inter

[PATCH v2 1/2] drm/i915/dg2: Add preemption changes for Wa_14015141709

2022-03-04 Thread Matt Roper
From: Akeem G Abodunrin Starting with DG2, preemption can no longer be controlled using userspace on a per-context basis. Instead, the hardware only allows us to enable or disable preemption in a global, system-wide basis. Also, we lose the ability to specify the preemption granularity (such as

Re: [PATCH 2/3] dt-bindings: display: mediatek,ovl: Fix 'iommu' required property typo

2022-03-04 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2022年3月4日 週五 下午5:55寫道: > > The property is called 'iommus' and not 'iommu'. Fix this typo. Acked-by: Chun-Kuang Hu > > Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block > to individual yaml") > Signed-off-by: AngeloGioacchino

Re: [PATCH 1/3] dt-bindings: display: mediatek, mutex: Fix mediatek, gce-events type

2022-03-04 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2022年3月4日 週五 下午5:55寫道: > > The mediatek,gce-events property needs as value an array of uint32 > corresponding to the CMDQ events to listen to, and not any phandle. Acked-by: Chun-Kuang Hu > > Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: s

Re: [PATCH v4 22/24] dept: Don't create dependencies between different depths in any case

2022-03-04 Thread Byungchul Park
On Fri, Mar 04, 2022 at 11:39:29AM +, Hyeonggon Yoo wrote: > Works as expected, Thanks! > I would report if there is anything else interesting. Thanks a lot! What you have done is helpful. Thanks, Byungchul > Tested-by: Hyeonggon Yoo <42.hye...@gmail.com> > > -- > Thank you, You are awesom

Re: [PATCH v4 16/24] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2022-03-04 Thread Byungchul Park
On Fri, Mar 04, 2022 at 10:28:57PM +0300, Sergei Shtylyov wrote: > On 3/4/22 10:06 AM, Byungchul Park wrote: > > > cb92173d1f0 (locking/lockdep, cpu/hotplug: Annotate AP thread) was > >You need to enclose the commit summary in (""), not just (). :-) Thank you! I will! > > introduced to make

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Add preemption changes for Wa_14015141709

2022-03-04 Thread Matt Roper
On Fri, Mar 04, 2022 at 12:13:12PM +0200, Jani Nikula wrote: > On Thu, 03 Mar 2022, Matt Roper wrote: > > From: Akeem G Abodunrin > > > > Starting with DG2, preemption can no longer be controlled using userspace > > on a per-context basis. Instead, the hardware only allows us to enable or > > dis

[pull] amdgpu, amdkfd drm-next-5.18

2022-03-04 Thread Alex Deucher
Hi Dave, Daniel, A few things for 5.18, mostly bug fixes. The following changes since commit 38a15ad9488e21cad8f42d3befca20f91e5b2874: Merge tag 'amd-drm-next-5.18-2022-02-25' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2022-03-01 16:19:02 +1000) are available in the Git re

[PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-04 Thread fei . yang
From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because the

Re: [PATCH v4 4/4] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-04 Thread Dmitry Baryshkov
On Sat, 5 Mar 2022 at 00:49, Doug Anderson wrote: > On Thu, Mar 3, 2022 at 4:16 PM Dmitry Baryshkov > wrote: > > > > On Fri, 4 Mar 2022 at 02:56, Stephen Boyd wrote: > > > > > > Quoting Dmitry Baryshkov (2022-03-03 15:50:50) > > > > On Thu, 3 Mar 2022 at 12:40, Vinod Polimera > > > > wrote: >

[PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-04 Thread fei . yang
From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because the

Re: [PATCH v3 5/5] drm/msm: allow compile time selection of driver components

2022-03-04 Thread Rob Clark
On Thu, Mar 3, 2022 at 7:21 PM Dmitry Baryshkov wrote: > > MSM DRM driver already allows one to compile out the DP or DSI support. > Add support for disabling other features like MDP4/MDP5/DPU drivers or > direct HDMI output support. > > Suggested-by: Stephen Boyd > Signed-off-by: Dmitry Baryshko

Re: [PATCH] drm/msm/a6xx: Fix missing ARRAY_SIZE() check

2022-03-04 Thread Rob Clark
On Fri, Mar 4, 2022 at 1:47 PM Dmitry Baryshkov wrote: > > On Fri, 4 Mar 2022 at 23:23, Rob Clark wrote: > > > > From: Rob Clark > > > > Fixes: f6d62d091cfd ("drm/msm/a6xx: add support for Adreno 660 GPU") > > Signed-off-by: Rob Clark > > Reviewed-by: Dmitry Baryshkov > However see the comment

Re: ✗ Fi.CI.CHECKPATCH: warning for use dynamic-debug under drm.debug api (rev2)

2022-03-04 Thread jim . cromie
On Tue, Mar 1, 2022 at 1:57 PM Patchwork wrote: > > == Series Details == > > Series: use dynamic-debug under drm.debug api (rev2) > URL : https://patchwork.freedesktop.org/series/100289/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > c2ed9cc02d9c dyndbg: fix static_bra

Re: [PATCH v4 4/4] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-04 Thread Doug Anderson
Hi, On Thu, Mar 3, 2022 at 4:16 PM Dmitry Baryshkov wrote: > > On Fri, 4 Mar 2022 at 02:56, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2022-03-03 15:50:50) > > > On Thu, 3 Mar 2022 at 12:40, Vinod Polimera > > > wrote: > > > > > > > > Kernel clock driver assumes that initial rate is

Re: [PATCH] drm/msm/a6xx: Fix missing ARRAY_SIZE() check

2022-03-04 Thread Dmitry Baryshkov
On Fri, 4 Mar 2022 at 23:23, Rob Clark wrote: > > From: Rob Clark > > Fixes: f6d62d091cfd ("drm/msm/a6xx: add support for Adreno 660 GPU") > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov However see the comment below. > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + > 1 file cha

Re: [PATCH] drm/i915: rework the error handling in *_dpll_params

2022-03-04 Thread Ville Syrjälä
On Fri, Mar 04, 2022 at 11:11:54PM +0200, Ville Syrjälä wrote: > On Fri, Mar 04, 2022 at 01:03:55PM -0800, t...@redhat.com wrote: > > From: Tom Rix > > > > Clang static analysis reports this issue > > intel_dpll.c:472:31: warning: The left operand of '-' > > is a garbage value [core.UndefinedBi

Re: [PATCH] drm/i915: rework the error handling in *_dpll_params

2022-03-04 Thread Ville Syrjälä
On Fri, Mar 04, 2022 at 01:03:55PM -0800, t...@redhat.com wrote: > From: Tom Rix > > Clang static analysis reports this issue > intel_dpll.c:472:31: warning: The left operand of '-' > is a garbage value [core.UndefinedBinaryOperatorResult] > this_err = abs(clock.dot - target); >

[PATCH] drm/i915: rework the error handling in *_dpll_params

2022-03-04 Thread trix
From: Tom Rix Clang static analysis reports this issue intel_dpll.c:472:31: warning: The left operand of '-' is a garbage value [core.UndefinedBinaryOperatorResult] this_err = abs(clock.dot - target); ~ ^ In a loop clock.dot is set on successful call to i9xx_calc_dpl

Re: [PATCH] simpldrm: Enable boot time VESA graphic mode selection.

2022-03-04 Thread Javier Martinez Canillas
Hello Thomas, On 3/4/22 21:00, Thomas Zimmermann wrote: > Hi, > > I've merged the patches into drm-misc-fixes. Thanks a lot to both of you. > Ard already picked these through the efi tree: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/log/ > Best regards > Thomas > -- Best reg

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Abhinav Kumar
Hi Suraj On 3/4/2022 6:16 AM, Kandpal, Suraj wrote: Hi, Hi, Hi Abhinav, Hi Laurent Ok sure, I can take this up but I need to understand the proposal a little bit more before proceeding on this. So we will discuss this in another email where we specifically talk about the connector changes.

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-04 Thread Lyude Paul
This mostly looks good to me. Just one question (and one comment down below that needs addressing). Is this with ppc32? (I ask because ppc64le doesn't seem to hit this compilation error). On Fri, 2022-03-04 at 18:20 +0100, Christophe Leroy wrote: > While working on powerpc headers, I ended up with

[PATCH] drm/msm/a6xx: Fix missing ARRAY_SIZE() check

2022-03-04 Thread Rob Clark
From: Rob Clark Fixes: f6d62d091cfd ("drm/msm/a6xx: add support for Adreno 660 GPU") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 02b479

Re: [git pull] drm fixes for 5.17-rc7

2022-03-04 Thread pr-tracker-bot
The pull request you sent on Fri, 4 Mar 2022 13:34:36 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-03-04 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c4fc118ae26f9d4e5885d151f9b0f96467a136da Thank you! -- Deet-doot-dot, I am a bot. https://ko

[PATCH] drm/msm: Fix dirtyfb refcounting

2022-03-04 Thread Rob Clark
From: Rob Clark refcount_t complains about 0->1 transitions, which isn't *quite* what we wanted. So use dirtyfb==1 to mean that the fb is not connected to any output that requires dirtyfb flushing, so that we can keep the underflow and overflow checking. Fixes: 9e4dde28e9cd ("drm/msm: Avoid dir

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915/guc: Do not conflate lrc_desc with GuC id for registration

2022-03-04 Thread John Harrison
On 3/4/2022 03:59, Jani Nikula wrote: On Thu, 24 Feb 2022, john.c.harri...@intel.com wrote: From: John Harrison The LRC descriptor pool is going away. So, stop using it as a check for context registration, use the GuC id instead (being the thing that actually gets registered with the GuC). Al

Re: [PATCH] simpldrm: Enable boot time VESA graphic mode selection.

2022-03-04 Thread Thomas Zimmermann
Hi, I've merged the patches into drm-misc-fixes. Thanks a lot to both of you. Best regards Thomas Am 02.03.22 um 20:47 schrieb Javier Martinez Canillas: Hello, On 3/2/22 20:38, Michal Suchánek wrote: Hello, On Wed, Mar 02, 2022 at 08:31:25PM +0100, Thomas Zimmermann wrote: Hi, is this rea

Re: [PATCH] drm/bridge_connector: enable HPD by default if supported

2022-03-04 Thread Paul Cercueil
Hi Nikita, Le sam., déc. 25 2021 at 09:31:51 +0300, Nikita Yushchenko a écrit : Hotplug events reported by bridge drivers over drm_bridge_hpd_notify() get ignored unless somebody calls drm_bridge_hpd_enable(). When the connector for the bridge is bridge_connector, such a call is done from drm_

[PATCH v1 1/1] staging: fbtft: Consider type of init sequence values in fbtft_init_display()

2022-03-04 Thread Andy Shevchenko
In the fbtft_init_display() the init sequence is printed for the debug purposes. Unfortunately the current code doesn't take into account that values in the buffer are of the s16 type. Consider that and replace the printing code with fbtft_par_dbg_hex() call. Fixes: b97014a9 ("staging/fbtft:

Re: [PATCH 7/8] drm/i915: fixup the initial fb base on DG1

2022-03-04 Thread Ville Syrjälä
On Fri, Mar 04, 2022 at 05:23:32PM +, Matthew Auld wrote: > The offset we get looks to be the exact start of DSM, but the > inital_plane_vma expects the address to be relative. > > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > --- > .../drm/i915/display/intel_plane_initial.c| 22

Re: [PATCH v4 16/24] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2022-03-04 Thread Sergei Shtylyov
On 3/4/22 10:06 AM, Byungchul Park wrote: > cb92173d1f0 (locking/lockdep, cpu/hotplug: Annotate AP thread) was You need to enclose the commit summary in (""), not just (). :-) > introduced to make lockdep_assert_cpus_held() work in AP thread. > > However, the annotation is too strong for tha

Re: [PATCH v1 07/10] drm/msm/adreno: Retry on gpu resume failure

2022-03-04 Thread Akhil P Oommen
On 3/3/2022 2:51 PM, AngeloGioacchino Del Regno wrote: Il 02/03/22 18:27, Akhil P Oommen ha scritto: Retry infinitely on resume failure because there is nothing much we can do if GPU is not ON. Also, this helps us to avoid checking for the return value of pm_runtime_get() to see if GPU is ON. S

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread H. Nikolaus Schaller
> Am 04.03.2022 um 19:33 schrieb Paul Cercueil : > > > > Le ven., mars 4 2022 at 19:15:13 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 04.03.2022 um 19:04 schrieb Paul Cercueil : >>> Le ven., mars 4 2022 at 18:51:14 +0100, H. Nikolaus Schaller >>> a écrit : Hi Paul, Nei

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread Paul Cercueil
Le ven., mars 4 2022 at 19:15:13 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 04.03.2022 um 19:04 schrieb Paul Cercueil : Le ven., mars 4 2022 at 18:51:14 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Neil, Am 04.03.2022 um 17:47 schrieb Paul Cercueil : From what I unders

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread H. Nikolaus Schaller
Hi Paul, > Am 04.03.2022 um 19:04 schrieb Paul Cercueil : > > > > Le ven., mars 4 2022 at 18:51:14 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, Neil, >>> Am 04.03.2022 um 17:47 schrieb Paul Cercueil : >>> From what I understood in Nikolaus' last message, HDMI hotplug is actually >>> c

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread Paul Cercueil
Le ven., mars 4 2022 at 18:51:14 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Neil, Am 04.03.2022 um 17:47 schrieb Paul Cercueil : From what I understood in Nikolaus' last message, HDMI hotplug is actually correctly detected, so there's no need for polling. What is missing is the ca

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread H. Nikolaus Schaller
Hi Paul, Neil, > Am 04.03.2022 um 17:47 schrieb Paul Cercueil : > > From what I understood in Nikolaus' last message, HDMI hotplug is actually > correctly detected, so there's no need for polling. What is missing is the > call to drm_kms_helper_hotplug_event *somewhere*, so that the information

[PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-04 Thread Christophe Leroy
While working on powerpc headers, I ended up with the following error. drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowrom.c:48:1: error: conflicting types for 'prom_init'; have 'void *(struct nvkm_bios *, const char *)' make[5]: *** [scripts/Makefile.build:288: drivers/gpu/drm/n

Re: [PATCH] drm/i915: stop checking for NULL vma->obj

2022-03-04 Thread Thomas Hellström
On Fri, 2022-03-04 at 17:42 +, Matthew Auld wrote: > This is no longer possible since e6e1a304d759 ("drm/i915: vma is > always > backed by an object."). > > Signed-off-by: Matthew Auld > Cc: Thomas Hellström LGTM.  Reviewed-by: Thomas Hellström > --- >  drivers/gpu/drm/i915/i915_vma.c | 1

[PATCH] drm/i915: stop checking for NULL vma->obj

2022-03-04 Thread Matthew Auld
This is no longer possible since e6e1a304d759 ("drm/i915: vma is always backed by an object."). Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/i915_vma.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_v

Re: [Intel-gfx] [PATCH] drm/i915/gtt: reduce overzealous alignment constraints for GGTT

2022-03-04 Thread Intel
On 3/3/22 11:02, Matthew Auld wrote: Currently this will enforce both 2M alignment and padding for any LMEM pages inserted into the GGTT. However, this was only meant to be applied to the compact-pt layout with the ppGTT. For the GGTT we can reduce the alignment and padding to 64K. Bspec: 4501

[PATCH 8/8] drm/i915: fixup the initial fb on DG2

2022-03-04 Thread Matthew Auld
On DG2+ the initial fb shouldn't be placed anywhere close to DSM, and so should just be allocated directly from LMEM. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/display/intel_plane_initial.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --

[PATCH 7/8] drm/i915: fixup the initial fb base on DG1

2022-03-04 Thread Matthew Auld
The offset we get looks to be the exact start of DSM, but the inital_plane_vma expects the address to be relative. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- .../drm/i915/display/intel_plane_initial.c| 22 +++ 1 file changed, 18 insertions(+), 4 deletions(-) diff

[PATCH 6/8] drm/i915/display: Check mappable aperture when pinning preallocated vma

2022-03-04 Thread Matthew Auld
From: CQ Tang When system does not have mappable aperture, ggtt->mappable_end=0. In this case if we pass PIN_MAPPABLE when pinning vma, the pinning code will return -ENOSPC. So conditionally set PIN_MAPPABLE if HAS_GMCH(). Suggested-by: Chris P Wilson Signed-off-by: CQ Tang Cc: Radhakrishna Sr

[PATCH 4/8] drm/i915/buddy: tweak CONTIGUOUS rounding

2022-03-04 Thread Matthew Auld
If this is an actual range allocation, and not some bias thing then the resultant allocation will already be naturally contiguous without needing any power-of-two rounding. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | 3 ++- 1 file changed

[PATCH 5/8] drm/i915/ttm: wire up the object offset

2022-03-04 Thread Matthew Auld
For the ttm backend we can use existing placements fpfn and lpfn to force the allocator to place the object at the requested offset, potentially evicting stuff if the spot is currently occupied. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- .../gpu/drm/i915/gem/i915_gem_object_types.h

[PATCH 3/8] drm/i915: add i915_gem_object_create_region_at()

2022-03-04 Thread Matthew Auld
Add a generic interface for allocating an object at some specific offset, and convert stolen over. Later we will want to hook this up to different backends. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- .../drm/i915/display/intel_plane_initial.c| 4 +- drivers/gpu/drm/i915/gem/i915_

[PATCH 2/8] drm/i915/stolen: don't treat small BAR as an error

2022-03-04 Thread Matthew Auld
From: Akeem G Abodunrin On client platforms with reduced LMEM BAR, we should be able to continue with driver load with reduced io_size. Instead of using the BAR size to determine the how large stolen should be, we should instead use the ADDR_RANGE register to figure this out(at least on platforms

[PATCH 1/8] drm/i915/lmem: don't treat small BAR as an error

2022-03-04 Thread Matthew Auld
Just pass along the probed io_size. The backend should be able to utilize the entire range here, even if some of it is non-mappable. It does leave open with what to do with stolen local-memory. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- drivers/gpu/drm/

[PATCH 0/8] Some more bits for small BAR enabling

2022-03-04 Thread Matthew Auld
The leftover bits around dealing with stolen-local memory + small BAR, plus some related fixes. -- 2.34.1

Re: [PATCH][next] drm/amd/display: Fix Wstringop-overflow warnings in dc_link_dp.c

2022-03-04 Thread Alex Deucher
On Thu, Mar 3, 2022 at 3:37 PM Gustavo A. R. Silva wrote: > > On Thu, Mar 03, 2022 at 12:19:57PM -0600, Gustavo A. R. Silva wrote: > > On Thu, Mar 03, 2022 at 09:43:28AM -0800, Kees Cook wrote: > > > On Thu, Mar 03, 2022 at 11:25:03AM -0600, Gustavo A. R. Silva wrote: > > > > Fix the following Wst

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread Paul Cercueil
Hi Neil, Le ven., mars 4 2022 at 14:30:46 +0100, Neil Armstrong a écrit : Hi, On 03/03/2022 18:59, H. Nikolaus Schaller wrote: Hi Paul, Neil, Am 03.03.2022 um 18:20 schrieb Paul Cercueil : Hi Nikolaus, [snip] Well he said "the Ingenic DRM core" aka ingenic-drm-drv.c. You do have access

Re: [RFC PATCH 11/11] drm/bridge: ti-sn65dsi86: Support hotplug detection

2022-03-04 Thread Doug Anderson
Hi, On Fri, Mar 4, 2022 at 7:46 AM Kieran Bingham wrote: > > > > What about: > > > > > > pdata->no_hpd = of_property_read_bool(np, "no-hpd"); > > > if (panel && !pdata->no_hpd) { > > > DRM_ERROR("Panels will not function with HPD. Enforcing > > > no-hpd\n"); > > >

Re: [RFC PATCH 10/11] drm/bridge: ti-sn65dsi86: Support DisplayPort (non-eDP) mode

2022-03-04 Thread Laurent Pinchart
On Wed, Feb 23, 2022 at 10:20:18AM -0800, Doug Anderson wrote: > On Wed, Feb 23, 2022 at 10:05 AM Kieran Bingham wrote: > > > > > > > + /* For DisplayPort, disable scrambling mode. */ > > > > > + if (pdata->bridge.type == DRM_MODE_CONNECTOR_DisplayPort) > > > > > + regmap_

Re: [RFC PATCH 11/11] drm/bridge: ti-sn65dsi86: Support hotplug detection

2022-03-04 Thread Kieran Bingham
Hi Doug, Quoting Doug Anderson (2022-02-23 18:25:13) > Hi, > > On Wed, Feb 23, 2022 at 9:43 AM Kieran Bingham > wrote: > > > > Hi All, > > > > I'm working to respin the remainder of these patches, now that I have > > IRQ based HPD working on the SN65DSI86, and the (non-eDP) mode is used > > for

Re: [PATCH 3/3] dt-bindings: display: mediatek: Fix examples on new bindings

2022-03-04 Thread Rob Herring
On Fri, 04 Mar 2022 10:54:58 +0100, AngeloGioacchino Del Regno wrote: > To avoid failure of dt_binding_check perform a slight refactoring > of the examples: the main block is kept, but that required fixing > the address and size cells, plus the inclusion of missing dt-bindings > headers, required t

Re: [PATCH 2/3] dt-bindings: display: mediatek,ovl: Fix 'iommu' required property typo

2022-03-04 Thread Rob Herring
On Fri, 04 Mar 2022 10:54:57 +0100, AngeloGioacchino Del Regno wrote: > The property is called 'iommus' and not 'iommu'. Fix this typo. > > Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block > to individual yaml") > Signed-off-by: AngeloGioacchino Del Regno > > --- >

Re: [PATCH 1/3] dt-bindings: display: mediatek,mutex: Fix mediatek,gce-events type

2022-03-04 Thread Rob Herring
On Fri, 04 Mar 2022 10:54:56 +0100, AngeloGioacchino Del Regno wrote: > The mediatek,gce-events property needs as value an array of uint32 > corresponding to the CMDQ events to listen to, and not any phandle. > > Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block > to in

Re: [PATCH v2 2/2] dt-bindings: gpu: Convert aspeed-gfx bindings to yaml

2022-03-04 Thread Rob Herring
On Fri, 04 Mar 2022 10:33:11 +1030, Joel Stanley wrote: > Convert the bindings to yaml and add the ast2600 compatible string. > > The legacy mfd description was put in place before the gfx bindings > existed, to document the compatible that is used in the pinctrl > bindings. > > Signed-off-by: Jo

[PATCH V2 4/4] drm/bridge: Document the expected behaviour of DSI host controllers

2022-03-04 Thread Dave Stevenson
The exact behaviour of DSI host controllers is not specified, therefore define it. Signed-off-by: Dave Stevenson Reviewed-by: Laurent Pinchart --- Documentation/gpu/drm-kms-helpers.rst | 7 +++ drivers/gpu/drm/drm_bridge.c | 39 +++ 2 files changed,

[PATCH V2 3/4] drm/panel: Add prepare_upstream_first flag to drm_panel

2022-03-04 Thread Dave Stevenson
Mapping to the drm_bridge flag pre_enable_upstream_first, add a new flag prepare_upstream_first to drm_panel to allow the panel driver to request that the upstream bridge should be pre_enabled before the panel prepare. Signed-off-by: Dave Stevenson --- drivers/gpu/drm/bridge/panel.c | 3 +++ in

[PATCH V2 2/4] drm/bridge: Introduce pre_enable_upstream_first to alter bridge init order

2022-03-04 Thread Dave Stevenson
DSI sink devices typically want the DSI host powered up and configured before they are powered up. pre_enable is the place this would normally happen, but they are called in reverse order from panel/connector towards the encoder, which is the "wrong" order. Add a new flag pre_enable_upstream_first

[PATCH V2 1/4] drm/bridge: Remove duplication from drm_bridge and drm_atomic_bridge chains

2022-03-04 Thread Dave Stevenson
drm_bridge_chain_pre_enable is a subset of drm_atomic_bridge_chain_pre_enable, and drm_bridge_chain_post_disable is a subset of drm_atomic_bridge_chain_post_disable. Change drm_bridge_chain_pre_enable and drm_bridge_chain_post_disable to call the atomic versions with a NULL state, and ensure that

[PATCH V2 0/3] DSI host and peripheral initialisation ordering

2022-03-04 Thread Dave Stevenson
Hi All Changes from v1: - New patch to refactor drm_bridge_chain_post_disable and drm_bridge_chain_pre_enable to reuse drm_atomic_bridge_chain_post_disable / drm_atomic_bridge_chain_pre_enable but with a NULL state. - New patch that adds a pre_enable_upstream_first to drm_panel. - changed fr

Writeback Assumptions for XRGB

2022-03-04 Thread Maxime Ripard
Hi, The writeback-check-output is currently broken on vc4. It's in part due to a bug in the kernel driver that results in a page flip timeout, but once that's fixed the test is still broken, and I'm not sure how to solve this one. Indeed, the frame comparison is done between the (XRGB) buffe

Re: [PATCH v7 10/24] drm/rockchip: dw_hdmi: Add support for hclk

2022-03-04 Thread Sascha Hauer
On Wed, Mar 02, 2022 at 12:25:28PM +0100, Sascha Hauer wrote: > On Tue, Mar 01, 2022 at 01:39:31PM +, Robin Murphy wrote: > > On 2022-02-28 14:19, Sascha Hauer wrote: > > > On Fri, Feb 25, 2022 at 02:11:54PM +0100, Sascha Hauer wrote: > > > > On Fri, Feb 25, 2022 at 12:41:23PM +, Robin Murp

RE: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Kandpal, Suraj
Hi, > > Hi, > > > > Hi Abhinav, > > > > > Hi Laurent > > > > > > > > > > Ok sure, I can take this up but I need to understand the > > > > > proposal a little bit more before proceeding on this. So we will > > > > > discuss this in another email where we specifically talk about the > connector chan

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread Neil Armstrong
Hi, On 03/03/2022 18:59, H. Nikolaus Schaller wrote: Hi Paul, Neil, Am 03.03.2022 um 18:20 schrieb Paul Cercueil : Hi Nikolaus, [snip] Well he said "the Ingenic DRM core" aka ingenic-drm-drv.c. You do have access to the main drm_device in the ingenic_drm_bind() function, so you can add it

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

2022-03-04 Thread Tvrtko Ursulin
On 03/03/2022 19:09, John Harrison wrote: Actions: 1) Get a number from compute/OpenCL people for what they say is minimum preempt timeout for default out of the box Linux desktop experience. That would be the one that has been agreed upon by both linux software arch and all UMD teams and h

Re: [PATCH 3/3] dt-bindings: display: bridge: renesas, lvds: Document r8a77961 bindings

2022-03-04 Thread Laurent Pinchart
On Thu, Mar 03, 2022 at 11:14:24AM +0200, Laurent Pinchart wrote: > On Wed, Mar 02, 2022 at 06:00:08PM +0100, Geert Uytterhoeven wrote: > > On Wed, Dec 29, 2021 at 5:47 PM Laurent Pinchart wrote: > > > On Fri, Dec 24, 2021 at 08:23:09AM +0300, Nikita Yushchenko wrote: > > > > Document the R-Car M3-

Re: [PATCH] drm/bridge: ti-sn65dsi86: switch to devm_drm_of_get_bridge

2022-03-04 Thread Kieran Bingham
Hi José Quoting Kieran Bingham (2022-03-03 21:59:26) > Quoting José Expósito (2022-03-03 18:37:20) > > On Mon, Feb 28, 2022 at 11:24:36PM +, Kieran Bingham wrote: > > > Hi José > > > > > > Quoting José Expósito (2022-02-28 18:39:54) > > > > The function "drm_of_find_panel_or_bridge" has been

Re: [PATCH v2,3/3] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c

2022-03-04 Thread AngeloGioacchino Del Regno
Il 18/02/22 11:07, xinlei@mediatek.com ha scritto: From: Xinlei Lee Add the compatible because use different cmdq addresses in mt8186. Signed-off-by: Xinlei Lee Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 1 file changed, 8 insertio

Re: [PATCH v2, 2/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8186

2022-03-04 Thread AngeloGioacchino Del Regno
Il 18/02/22 11:07, xinlei@mediatek.com ha scritto: From: Xinlei Lee Add dt-binding documentation of dsi for MediaTek MT8186 SoC. Signed-off-by: Xinlei Lee Reviewed-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/display/mediatek/mediatek,dsi.yaml | 1 + 1 file ch

Re: [PATCH v2, 1/3] dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml

2022-03-04 Thread AngeloGioacchino Del Regno
Il 18/02/22 11:07, xinlei@mediatek.com ha scritto: From: Xinlei Lee Convert mediatek,dsi.txt to mediatek,dsi.yaml format Signed-off-by: Xinlei Lee --- .../display/mediatek/mediatek,dsi.txt | 62 -- .../display/mediatek/mediatek,dsi.yaml| 85 +

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915/guc: Do not conflate lrc_desc with GuC id for registration

2022-03-04 Thread Jani Nikula
On Thu, 24 Feb 2022, john.c.harri...@intel.com wrote: > From: John Harrison > > The LRC descriptor pool is going away. So, stop using it as a check for > context registration, use the GuC id instead (being the thing that > actually gets registered with the GuC). > > Also, rename the set/clear/quer

Re: [PATCH v2, 0/4] Cooperate with DSI RX devices to modify dsi funcs and delay mipi high to cooperate with panel sequence

2022-03-04 Thread Jani Nikula
Please also prefix cover letters with drm/mediatek if that's the only place you're touching. BR, Jani. On Fri, 04 Mar 2022, wrote: > From: Xinlei Lee > > In upstream-v5.8, dsi_enable will operate panel_enable, but this > modification has been moved in v5.9. In order to ensure the timing of >

Re: [PATCH v4 22/24] dept: Don't create dependencies between different depths in any case

2022-03-04 Thread Hyeonggon Yoo
On Fri, Mar 04, 2022 at 04:06:41PM +0900, Byungchul Park wrote: > Dept already prevents creating dependencies between different depths of > the class indicated by *_lock_nested() when the lock acquisitions happen > consecutively. > >lock A0 with depth >lock_nested A1 with depth + 1 >..

Re: [PATCH v4] drm: of: Lookup if child node has panel or bridge

2022-03-04 Thread Maxime Ripard
On Fri, Mar 04, 2022 at 12:05:14PM +0100, Paul Kocialkowski wrote: > On Fri 04 Mar 22, 12:00, Paul Kocialkowski wrote: > > Hi Maxime, > > > > On Fri 04 Mar 22, 09:54, Maxime Ripard wrote: > > > Hi Paul, > > > > > > On Thu, Mar 03, 2022 at 09:26:30PM +0100, Paul Kocialkowski wrote: > > > > On Wed

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Add preemption changes for Wa_14015141709

2022-03-04 Thread Tvrtko Ursulin
On 03/03/2022 22:42, Matt Roper wrote: From: Akeem G Abodunrin Starting with DG2, preemption can no longer be controlled using userspace on a per-context basis. Instead, the hardware only allows us to enable or disable preemption in a global, system-wide basis. Also, we lose the ability to sp

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Dmitry Baryshkov
On Fri, 4 Mar 2022 at 13:47, Kandpal, Suraj wrote: > > Hi, > > > Hi Abhinav, > > > > Hi Laurent > > > > > > > > Ok sure, I can take this up but I need to understand the proposal a > > > > little bit more before proceeding on this. So we will discuss this > > > > in another email where we specifica

Re: [PATCH v2, 0/4] Cooperate with DSI RX devices to modify dsi funcs and delay mipi high to cooperate with panel sequence

2022-03-04 Thread Benjamin Gaignard
Le 04/03/2022 à 11:15, xinlei@mediatek.com a écrit : From: Xinlei Lee In upstream-v5.8, dsi_enable will operate panel_enable, but this modification has been moved in v5.9. In order to ensure the timing of dsi_power_on/off and the timing of pulling up/down the MIPI signal, the modification

RE: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Kandpal, Suraj
Hi, > > Hi Abhinav, > > > Hi Laurent > > > > > > Ok sure, I can take this up but I need to understand the proposal a > > > little bit more before proceeding on this. So we will discuss this > > > in another email where we specifically talk about the connector changes. > > > > > > Also, I am willing

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Dmitry Baryshkov
Hi, On Fri, 4 Mar 2022 at 12:56, Kandpal, Suraj wrote: > > Hi Abhinav, > > Hi Laurent > > > > Ok sure, I can take this up but I need to understand the proposal a little > > bit > > more before proceeding on this. So we will discuss this in another email > > where we specifically talk about the c

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Add preemption changes for Wa_14015141709

2022-03-04 Thread Jani Nikula
On Thu, 03 Mar 2022, Matt Roper wrote: > From: Akeem G Abodunrin > > Starting with DG2, preemption can no longer be controlled using userspace > on a per-context basis. Instead, the hardware only allows us to enable or > disable preemption in a global, system-wide basis. Also, we lose the > abili

RE: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-04 Thread Kandpal, Suraj
Hi Abhinav, > Hi Laurent > > Ok sure, I can take this up but I need to understand the proposal a little bit > more before proceeding on this. So we will discuss this in another email > where we specifically talk about the connector changes. > > Also, I am willing to take this up once the encoder

[PATCH 3/3] dt-bindings: display: mediatek: Fix examples on new bindings

2022-03-04 Thread AngeloGioacchino Del Regno
To avoid failure of dt_binding_check perform a slight refactoring of the examples: the main block is kept, but that required fixing the address and size cells, plus the inclusion of missing dt-bindings headers, required to parse some of the values assigned to various properties. Fixes: 4ed545e7d10

[PATCH 2/3] dt-bindings: display: mediatek, ovl: Fix 'iommu' required property typo

2022-03-04 Thread AngeloGioacchino Del Regno
The property is called 'iommus' and not 'iommu'. Fix this typo. Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block to individual yaml") Signed-off-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/display/mediatek/mediatek,ovl.yaml | 2 +- 1 file changed

[PATCH 1/3] dt-bindings: display: mediatek, mutex: Fix mediatek, gce-events type

2022-03-04 Thread AngeloGioacchino Del Regno
The mediatek,gce-events property needs as value an array of uint32 corresponding to the CMDQ events to listen to, and not any phandle. Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block to individual yaml") Signed-off-by: AngeloGioacchino Del Regno --- .../devicetree/

[PATCH 0/3] Fix MediaTek display dt-bindings issues

2022-03-04 Thread AngeloGioacchino Del Regno
The vdosys0 series carried a nice dt-bindings conversion of the old txt documentation for the entire mediatek-drm driver, but some of the issues in there weren't seen. This series is fixing all of the issues pointed out by a `dt_binding_check` run, followed by `dtbs_check`. AngeloGioacchino Del R

Re: [PATCH v4] drm: of: Lookup if child node has panel or bridge

2022-03-04 Thread Maxime Ripard
Hi Paul, On Thu, Mar 03, 2022 at 09:26:30PM +0100, Paul Kocialkowski wrote: > On Wed 02 Feb 22, 21:34, Jagan Teki wrote: > > Devices can also be child nodes when we also control that device > > through the upstream device (ie, MIPI-DCS for a MIPI-DSI device). > > > > drm_of_find_panel_or_bridge c

  1   2   >