[v3] drm/edid: check basic audio support on CEA extension block

From: Cooper Chiou Tag code stored in bit7:5 for CTA block byte[3] is not the same as CEA extension block definition. Only check CEA block has basic audio support. v3: update commit message. Cc: sta...@vger.kernel.org Cc: Jani Nikula Cc: Shawn C Lee Cc: intel-gfx Signed-off-by: Cooper Chiou

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

On 2022/3/23 21:11, Rob Herring wrote: On Wed, Mar 23, 2022 at 12:12:43PM +0800, Sui Jingfeng wrote: On 2022/3/23 04:49, Rob Herring wrote: +/* + * mainly for dc in ls7a1000 which have builtin gpio emulated i2c + * + * @index : output channel index, 0 for DVO0, 1 for DVO1 + */ +struct

Re: [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board

On 2022/3/23 20:53, Rob Herring wrote: On Wed, Mar 23, 2022 at 09:53:14AM +0800, Sui Jingfeng wrote: On 2022/3/23 00:06, Jiaxun Yang wrote: 在 2022/3/22 13:38, Sui Jingfeng 写道: On 2022/3/22 21:05, Jiaxun Yang wrote: 在 2022/3/21 16:29, Sui Jingfeng 写道: From: suijingfeng The board name

Re: [PATCH v11 5/7] dt-bindings: display: Add Loongson display controller

On 2022/3/23 21:03, Rob Herring wrote: On Wed, Mar 23, 2022 at 11:38:55AM +0800, Sui Jingfeng wrote: On 2022/3/23 04:55, Rob Herring wrote: On Tue, Mar 22, 2022 at 10:33:45AM +0800, Sui Jingfeng wrote: On 2022/3/22 07:20, Rob Herring wrote: On Tue, Mar 22, 2022 at 12:29:14AM +0800, Sui

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

On 2022/3/23 04:49, Rob Herring wrote: On Tue, Mar 22, 2022 at 12:29:16AM +0800, Sui Jingfeng wrote: From: suijingfeng There is a display controller in loongson's LS2K1000 SoC and LS7A1000 bridge chip, the display controller is a PCI device in those chips. It has two display pipes but with

[PATCH] drm/i915/guc: Correctly free guc capture struct on error

On error the "new" allocation is not freed, so add the required kfree. Fixes: 247f8071d5893 ("drm/i915/guc: Pre-allocate output nodes for extraction") Signed-off-by: Daniele Ceraolo Spurio Cc: Alan Previn Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 1 + 1 file

RE: [Intel-gfx] [PATCH v5 13/19] drm/i915: Introduce new Tile 4 format

Hi all, Found an error in this description.. > From: Stanislav Lisovskiy > stanislav.lisovs...@intel.com > > This tiling layout uses 4KB tiles in a row-major layout. It has the same > shape as Tile Y at two granularities: 4KB (128B x 32) and 64B (16B x 4).

RE: [Intel-gfx] [PATCH v5 16/19] uapi/drm/dg2: Introduce format modifier for DG2 clear color

> -Original Message- > From: Deak, Imre > Sent: Monday, March 21, 2022 6:20 AM > To: Chery, Nanley G ; Juha-Pekka Heikkila > > Cc: Nanley Chery ; C, Ramalingam > ; intel-gfx ; > Auld, Matthew ; dri-devel > > Subject: Re: [Intel-gfx] [PATCH v5 16/19] uapi/drm/dg2: Introduce format

RE: [Intel-gfx] [PATCH v5 15/19] drm/i915/dg2: Add DG2 unified compression

> -Original Message- > From: Deak, Imre > Sent: Friday, March 18, 2022 10:40 AM > To: Chery, Nanley G > Cc: juhapekka.heikk...@gmail.com; Nanley Chery ; C, > Ramalingam ; intel-gfx g...@lists.freedesktop.org>; Auld, Matthew ; > dri-devel > Subject: Re: [Intel-gfx] [PATCH v5 15/19]

Re: [GIT PULL] fbdev updates & fixes for v5.18-rc1

The pull request you sent on Tue, 22 Mar 2022 20:31:55 +0100: > http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git > tags/for-5.18/fbdev-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9c4b86ebf5bfdaceba4bedbaf76e4ff745db17ef Thank you! --

Re: [PATCH v6 0/6] drm: exynos: dsi: Convert drm bridge

On Wed, Mar 9, 2022 at 6:01 AM Jagan Teki wrote: > > Hi Frieder, > > On Wed, Mar 9, 2022 at 6:54 PM Frieder Schrempf > wrote: > > > > Hi Jagan, > > > > Am 03.03.22 um 17:36 schrieb Jagan Teki: > > > Updated series about drm bridge conversion of exynos dsi. > > > > > > Previous version can be

Re: [PATCH v4 3/3] drm/bridge: ti-sn65dsi86: Support hotplug detection

Quoting Doug Anderson (2022-03-23 21:47:17) > Hi, > > On Thu, Mar 17, 2022 at 6:13 AM Kieran Bingham > wrote: > > > > @@ -1241,9 +1350,32 @@ static int ti_sn_bridge_probe(struct > > auxiliary_device *adev, > > pdata->bridge.type = pdata->next_bridge->type == > >

Re: [PATCH v4 2/3] drm/bridge: ti-sn65dsi86: Implement bridge connector operations

Hi, On Thu, Mar 17, 2022 at 6:13 AM Kieran Bingham wrote: > > From: Laurent Pinchart > > Implement the bridge connector-related .get_edid() operation, and report > the related bridge capabilities and type. > > Signed-off-by: Laurent Pinchart > Signed-off-by: Kieran Bingham > Reviewed-by:

Re: [PATCH v4 3/3] drm/bridge: ti-sn65dsi86: Support hotplug detection

Hi, On Thu, Mar 17, 2022 at 6:13 AM Kieran Bingham wrote: > > @@ -1241,9 +1350,32 @@ static int ti_sn_bridge_probe(struct auxiliary_device > *adev, > pdata->bridge.type = pdata->next_bridge->type == > DRM_MODE_CONNECTOR_DisplayPort >?

Re: [PATCH 1/2] dt-bindings: display: bridge: Document RZ/G2L MIPI DSI TX bindings

On Wed, Mar 23, 2022 at 06:26:31PM +, Biju Das wrote: > Hi Rob, > > Thanks for the feedback. > > > Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: Document RZ/G2L > > MIPI DSI TX bindings > > > > On Mon, Mar 14, 2022 at 04:10:02PM +, Biju Das wrote: > > > The RZ/G2L MIPI DSI TX

Re: [PATCH] drm/amd/display: use NULL instead of using plain integer as pointer

Thanks for the patches. I've already applied fixes from others for these issues. Alex On Tue, Mar 22, 2022 at 9:05 AM Haowen Bai wrote: > > This fixes the following sparse warnings: > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dsc/rc_calc_fpu.c:71:40: > warning: Using > plain integer as

Re: [PATCH 1/3] drm/msm/dp: drop dp_mode argument from dp_panel_get_modes()

On 3/23/2022 3:35 AM, Dmitry Baryshkov wrote: Since the commit ab205927592b ("drm/msm/dp: remove mode hard-coding in case of DP CTS") the function dp_panel_get_modes() doesn't use (or fill) the dp_mode argument. Drop it completely. Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Kuogee

Re: [PATCH 00/22] drm: Review of mode copies

On 3/23/2022 3:39 AM, Dmitry Baryshkov wrote: On 22/03/2022 01:37, Ville Syrjälä wrote: On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä wrote: On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote:    drm: Add

Re: [PATCH 0/3] drm/msm/dp: simplify dp_connector_get_modes()

On 3/23/2022 3:35 AM, Dmitry Baryshkov wrote: As noted by Ville Syrjälä [1] the dp_connector_get_modes() has weird on-stack interim copy of the mode. When reviewing the mentioned patch I noticed that the rest of the code in dp_connector_get_modes() is weird, unused since September of 2020 and

Re: [PATCH 1/3] drm/msm/dp: drop dp_mode argument from dp_panel_get_modes()

On 23/03/2022 23:46, Kuogee Hsieh wrote: On 3/23/2022 3:35 AM, Dmitry Baryshkov wrote: Since the commit ab205927592b ("drm/msm/dp: remove mode hard-coding in case of DP CTS") the function dp_panel_get_modes() doesn't use (or fill) the dp_mode argument. Drop it completely. Signed-off-by:

Re: [PATCH 3/3] drm/msm/dp: remove max_pclk_khz field from dp_panel/dp_display

On 3/23/2022 3:35 AM, Dmitry Baryshkov wrote: Since the last commit, the max_pclk_khz became constant, it's set to DP_MAX_PIXEL_CLK_KHZ and never changed afterwards. Remove it completely and use DP_MAX_PIXEL_CLK_KHZ directly. Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Kuogee Hsieh

Re: [PATCH 2/3] drm/msm/dp: simplify dp_connector_get_modes()

On 3/23/2022 3:35 AM, Dmitry Baryshkov wrote: Since dp_panel_get_modes() handling for dp_mode was removed, dp_display_get_modes also doesn't change the passed dp_mode, drop the unused dp_mode variable being allocated unused and then freed. Signed-off-by: Dmitry Baryshkov --- Reviewed-by:

Re: [PATCH 1/3] drm/msm/dp: drop dp_mode argument from dp_panel_get_modes()

On 3/23/2022 3:35 AM, Dmitry Baryshkov wrote: Since the commit ab205927592b ("drm/msm/dp: remove mode hard-coding in case of DP CTS") the function dp_panel_get_modes() doesn't use (or fill) the dp_mode argument. Drop it completely. Signed-off-by: Dmitry Baryshkov Reviewed-by: Kuogee Hsieh

Re: [PATCH] dt-bindings: display: bridge: Drop requirement on input port for DSI devices

Hi Maxime, (CC'ing Sakari) Thank you for the patch. On Wed, Mar 23, 2022 at 04:48:23PM +0100, Maxime Ripard wrote: > MIPI-DSI devices, if they are controlled through the bus itself, have to > be described as a child node of the controller they are attached to. > > Thus, there's no requirement

Re: [PATCH 12/22] drm/msm: Use drm_mode_copy()

On 2/18/2022 2:03 AM, Ville Syrjala wrote: From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of

Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format

Am Mittwoch, den 23.03.2022, 16:58 +0100 schrieb Maxime Ripard: > On Wed, Mar 23, 2022 at 09:42:11AM +0100, Max Krummenacher wrote: > > Am Freitag, den 18.03.2022, 17:53 + schrieb Dave Stevenson: > > > On Fri, 18 Mar 2022 at 17:16, Maxime Ripard wrote: > > > > On Fri, Mar 18, 2022 at

Re: [PATCH 1/3] dt-bindings: display: bridge: it66121: Add audio support

On Wed, 16 Mar 2022 14:57:31 +0100, Nicolas Belin wrote: > Update the ITE bridge HDMI it66121 bindings in order to > support audio. > > Signed-off-by: Nicolas Belin > --- > .../devicetree/bindings/display/bridge/ite,it66121.yaml| 3 +++ > 1 file changed, 3 insertions(+) > Acked-by:

Re: [PATCH v2 1/7] dt-bindings: display: renesas,du: Document r9a07g044l bindings

On Wed, 16 Mar 2022 13:10:54 +, Biju Das wrote: > Extend the Renesas DU display bindings to support the r9a07g044l > DU module found on RZ/G2L LCDC. > > Signed-off-by: Biju Das > --- > v1->v2: > * Updated commit description. > * Removed LCDC references > * Changed clock name from

Re: [PATCH 11/22] drm/msm: Use drm_mode_init() for on-stack modes

On 2/18/2022 2:03 AM, Ville Syrjala wrote: From: Ville Syrjälä Initialize on-stack modes with drm_mode_init() to guarantee no stack garbage in the list head, or that we aren't copying over another mode's list head. Based on the following cocci script, with manual fixups: @decl@ identifier

Re: [PATCH 1/1] drm/amdkfd: Protect the Client whilst it is being operated on

Am 2022-03-23 um 08:46 schrieb Lee Jones: On Thu, 17 Mar 2022, Lee Jones wrote: On Thu, 17 Mar 2022, philip yang wrote: On 2022-03-17 11:13 a.m., Lee Jones wrote: On Thu, 17 Mar 2022, Felix Kuehling wrote: Am 2022-03-17 um 11:00 schrieb Lee Jones: Good afternoon Felix, Thanks for

RE: [PATCH 1/2] dt-bindings: display: bridge: Document RZ/G2L MIPI DSI TX bindings

Hi Rob, > Subject: RE: [PATCH 1/2] dt-bindings: display: bridge: Document RZ/G2L > MIPI DSI TX bindings > > Hi Rob, > > Thanks for the feedback. > > > Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: Document RZ/G2L > > MIPI DSI TX bindings > > > > On Mon, Mar 14, 2022 at 04:10:02PM

Re: Parallel modesets and private state objects broken, where to go with MST?

On Wed, 2022-03-23 at 11:25 +0100, Daniel Vetter wrote: > On Tue, Mar 22, 2022 at 05:37:40PM -0400, Lyude Paul wrote: > > OK so - this has become a bit of a larger rabbit hole. I've been putting > > quite > > a bit of work into this and I think I'm starting to make some progress - > > although on

Re: [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

Hi Liviu Thanks for the review. On 3/23/2022 9:46 AM, Liviu Dudau wrote: On Mon, Mar 21, 2022 at 04:56:43PM -0700, Abhinav Kumar wrote: For vendors drivers which pass an already allocated and initialized encoder especially for cases where the encoder hardware is shared OR the writeback

RE: [PATCH 1/2] dt-bindings: display: bridge: Document RZ/G2L MIPI DSI TX bindings

Hi Rob, Thanks for the feedback. > Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: Document RZ/G2L > MIPI DSI TX bindings > > On Mon, Mar 14, 2022 at 04:10:02PM +, Biju Das wrote: > > The RZ/G2L MIPI DSI TX is embedded in the Renesas RZ/G2L family SoC's. > > It can operate in DSI

Re: [PATCH 1/2] dt-bindings: display: bridge: Document RZ/G2L MIPI DSI TX bindings

On Mon, Mar 14, 2022 at 04:10:02PM +, Biju Das wrote: > The RZ/G2L MIPI DSI TX is embedded in the Renesas RZ/G2L family SoC's. It > can operate in DSI mode, with up to four data lanes. > > Signed-off-by: Biju Das > --- > RFC->v1: > * Added a ref to dsi-controller.yaml. > RFC:- > * >

Re: [PATCH 04/23] RDMA: use dma_resv_wait() instead of extracting the fence

On Wed, 23 Mar 2022 at 17:32, Jason Gunthorpe wrote: > > On Wed, Mar 23, 2022 at 02:22:01PM +0100, Daniel Vetter wrote: > > On Mon, Mar 21, 2022 at 02:58:37PM +0100, Christian König wrote: > > > Use dma_resv_wait() instead of extracting the exclusive fence and > > > waiting on it manually. > > >

Re: [Intel-gfx] [RFC 06/19] drm/edid: clean up cea_db_is_*() functions

On Wed, 23 Mar 2022, Ville Syrjälä wrote: > On Tue, Mar 22, 2022 at 11:40:35PM +0200, Jani Nikula wrote: >> Abstract helpers for matching vendor data blocks and extended tags, and >> use them to simplify all the cea_db_is_*() functions. >> >> Take void pointer as parameter to allow transitional

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

On Wed, Mar 23, 2022 at 8:14 AM Daniel Vetter wrote: > > On Wed, 23 Mar 2022 at 15:07, Daniel Stone wrote: > > > > Hi, > > > > On Mon, 21 Mar 2022 at 16:02, Rob Clark wrote: > > > On Mon, Mar 21, 2022 at 2:30 AM Christian König > > > wrote: > > > > Well you can, it just means that their

Re: [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

On Mon, Mar 21, 2022 at 04:56:43PM -0700, Abhinav Kumar wrote: > For vendors drivers which pass an already allocated and > initialized encoder especially for cases where the encoder > hardware is shared OR the writeback encoder shares the resources > with the rest of the display pipeline introduce

Re: [RFC 00/19] drm/edid: overhaul CEA data block iteration

On Tue, Mar 22, 2022 at 11:40:29PM +0200, Jani Nikula wrote: > Add iterators for EDID blocks and CEA data blocks, to iterate through > all data blocks across all CEA extensions and CTA blocks in DisplayID > data blocks. Fix all code assuming only one CEA extension. Fix code > assuming CTA blocks

Re: [RFC 19/19] drm/edid: sunset drm_find_cea_extension()

On Tue, Mar 22, 2022 at 11:40:48PM +0200, Jani Nikula wrote: > Convert drm_find_cea_extension() to a predicate function to check if the > EDID has a CEA extension or a DisplayID CTA data block. This is mainly > to avoid adding new users that only find the first CEA extension. > > Signed-off-by:

Re: [PATCH 04/23] RDMA: use dma_resv_wait() instead of extracting the fence

On Wed, Mar 23, 2022 at 02:22:01PM +0100, Daniel Vetter wrote: > On Mon, Mar 21, 2022 at 02:58:37PM +0100, Christian König wrote: > > Use dma_resv_wait() instead of extracting the exclusive fence and > > waiting on it manually. > > > > Signed-off-by: Christian König > > Reviewed-by: Daniel

Re: [Intel-gfx] [RFC 09/19] drm/edid: convert drm_edid_to_sad() to use cea db iter

On Tue, Mar 22, 2022 at 11:40:38PM +0200, Jani Nikula wrote: > Use the cea db iterator for short audio descriptors. We'll still stop at > the first audio data block, but not at the first CEA extension if that > doesn't have the info. This stuff should probably be converted over to the

Re: [RFC 05/19] drm/edid: add iterator for CEA data blocks

On Tue, Mar 22, 2022 at 11:40:34PM +0200, Jani Nikula wrote: > Add an iterator for CEA Data Blocks across CEA extensions and CTA > DisplayID Data Blocks. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 198 ++--- > 1 file changed, 186

[PATCH 2/4] drm/etnaviv: move MMU context ref/unref into map/unmap_gem

This makes it a little more clear that the mapping holds a reference to the context once the buffer has been successfully mapped into that context and simplifies the error handling a bit. Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 11 +++

[PATCH 1/4] drm/etnaviv: check for reaped mapping in etnaviv_iommu_unmap_gem

When the mapping is already reaped the unmap must be a no-op, as we would otherwise try to remove the mapping twice, corrupting the involved data structures. Cc: sta...@vger.kernel.org # 5.4 Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 6 ++ 1 file changed, 6

[PATCH 4/4] drm/etnaviv: reap idle softpin mappings when necessary

Right now the only point where softpin mappings get removed from the MMU context is when the mapped GEM object is destroyed. However, userspace might want to reuse that address space before the object is destroyed, which is a valid usage, as long as all mapping in that region of the address space

[PATCH 3/4] drm/etnaviv: move flush_seq increment into etnaviv_iommu_map/unmap

The flush sequence is a marker that the page tables have been changed and any affected TLBs need to be flushed. Move the flush_seq increment a little further down the call stack to place it next to the actual page table manipulation. Not functional change. Signed-off-by: Lucas Stach ---

Re: [PATCH 05/23] drm/etnaviv: stop using dma_resv_excl_fence

Am Montag, dem 21.03.2022 um 14:58 +0100 schrieb Christian König: > We can get the excl fence together with the shared ones as well. > > Signed-off-by: Christian König > Reviewed-by: Daniel Vetter > Cc: Lucas Stach > Cc: Russell King > Cc: Christian Gmeiner > Cc:

Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format

On Wed, Mar 23, 2022 at 09:42:11AM +0100, Max Krummenacher wrote: > Am Freitag, den 18.03.2022, 17:53 + schrieb Dave Stevenson: > > On Fri, 18 Mar 2022 at 17:16, Maxime Ripard wrote: > > > On Fri, Mar 18, 2022 at 05:05:11PM +, Dave Stevenson wrote: > > > > Hi Maxime > > > > > > > > On

Re: [PATCH 01/23] dma-buf: add dma_resv_replace_fences v2

Am 23.03.22 um 16:55 schrieb Felix Kuehling: Am 2022-03-21 um 09:58 schrieb Christian König: This function allows to replace fences from the shared fence list when we can gurantee that the operation represented by the original fence has finished or no accesses to the resources protected by the

Re: [PATCH 01/23] dma-buf: add dma_resv_replace_fences v2

Am 2022-03-21 um 09:58 schrieb Christian König: This function allows to replace fences from the shared fence list when we can gurantee that the operation represented by the original fence has finished or no accesses to the resources protected by the dma_resv object any more when the new fence

[PATCH] dt-bindings: display: bridge: Drop requirement on input port for DSI devices

MIPI-DSI devices, if they are controlled through the bus itself, have to be described as a child node of the controller they are attached to. Thus, there's no requirement on the controller having an OF-Graph output port to model the data stream: it's assumed that it would go from the parent to

Re: [Intel-gfx] [RFC 06/19] drm/edid: clean up cea_db_is_*() functions

On Tue, Mar 22, 2022 at 11:40:35PM +0200, Jani Nikula wrote: > Abstract helpers for matching vendor data blocks and extended tags, and > use them to simplify all the cea_db_is_*() functions. > > Take void pointer as parameter to allow transitional use for both u8 * > and struct cea_db *. > >

Re: [PATCH v5 09/11] drm: bridge: icn6211: Add I2C configuration support

On Fri, Mar 18, 2022 at 07:47:53PM +0100, Marek Vasut wrote: > The ICN6211 chip starts in I2C configuration mode after cold boot. > Implement support for configuring the chip via I2C in addition to > the current DSI LP command mode configuration support. The later > seems to be available only on

Re: [Intel-gfx] [RFC 03/19] drm/edid: clean up CEA data block tag definitions

On Tue, Mar 22, 2022 at 11:40:32PM +0200, Jani Nikula wrote: > Add prefixed names, group, sort, add references. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 59 +- > 1 file changed, 32 insertions(+), 27 deletions(-) > > diff --git

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

Am 23.03.22 um 16:24 schrieb Daniel Stone: On Wed, 23 Mar 2022 at 15:14, Alex Deucher wrote: On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: That's not what anyone's saying here ... No-one's demanding AMD publish RTL, or internal design docs, or hardware specs, or URLs to JIRA tickets

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

[Adding Marek and Andrey as well] Am 23.03.22 um 16:14 schrieb Daniel Vetter: On Wed, 23 Mar 2022 at 15:07, Daniel Stone wrote: Hi, On Mon, 21 Mar 2022 at 16:02, Rob Clark wrote: On Mon, Mar 21, 2022 at 2:30 AM Christian König wrote: Well you can, it just means that their contexts are

Re: [RFC 02/19] drm: use drm_edid_extension_block_count() and drm_edid_size()

On Tue, Mar 22, 2022 at 11:40:31PM +0200, Jani Nikula wrote: > Use the block count and size helpers in all drm core code. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_connector.c | 2 +- > drivers/gpu/drm/drm_debugfs.c | 3 +-- > drivers/gpu/drm/drm_edid.c | 14

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

On Wed, 23 Mar 2022 at 15:14, Alex Deucher wrote: > On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: > > That's not what anyone's saying here ... > > > > No-one's demanding AMD publish RTL, or internal design docs, or > > hardware specs, or URLs to JIRA tickets no-one can access. > > > >

Re: [PATCH 1/6] drm/ttm: move the LRU into resource handling v4

On Wed, Mar 23, 2022 at 02:44:17PM +0100, Christian König wrote: > Am 23.03.22 um 14:36 schrieb Daniel Vetter: > > On Wed, 23 Mar 2022 at 13:20, Christian König > > wrote: > > > Am 23.03.22 um 12:59 schrieb Daniel Vetter: > > > > On Mon, Mar 21, 2022 at 02:25:56PM +0100, Christian König wrote: >

Re: [Intel-gfx] [RFC 01/19] drm/edid: add drm_edid_extension_block_count() and drm_edid_size()

On Tue, Mar 22, 2022 at 11:40:30PM +0200, Jani Nikula wrote: > Add abstractions for getting the number of EDID extension blocks and the > total EDID size in bytes. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 18 ++ > include/drm/drm_edid.h | 2 ++ >

Re: [PATCH] drm/edid: fix CEA extension byte #3 parsing

On Wed, 23 Mar 2022, Ville Syrjälä wrote: > On Wed, Mar 23, 2022 at 12:04:38PM +0200, Jani Nikula wrote: >> Only an EDID CEA extension has byte #3, while the CTA DisplayID Data >> Block does not. Don't interpret bogus data for color formats. > > I think what we might want eventually is a cleaner

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

Am 23.03.22 um 15:00 schrieb Daniel Stone: On Wed, 23 Mar 2022 at 08:19, Christian König wrote: Am 23.03.22 um 09:10 schrieb Paul Menzel: Sorry, I disagree. The motivation needs to be part of the commit message. For example see recent discussion on the LWN article *Donenfeld: Random number

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: > > Hi Alex, > > On Wed, 23 Mar 2022 at 14:42, Alex Deucher wrote: > > On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > > On Wed, 23 Mar 2022 at 08:19, Christian König > > > wrote: > > > > Well the key point is it's not about you to

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

On Wed, 23 Mar 2022 at 15:07, Daniel Stone wrote: > > Hi, > > On Mon, 21 Mar 2022 at 16:02, Rob Clark wrote: > > On Mon, Mar 21, 2022 at 2:30 AM Christian König > > wrote: > > > Well you can, it just means that their contexts are lost as well. > > > > Which is rather inconvenient when deqp-egl

Re: [PATCH 00/22] drm: Review of mode copies

On Wed, Mar 23, 2022 at 01:39:44PM +0300, Dmitry Baryshkov wrote: > On 22/03/2022 01:37, Ville Syrjälä wrote: > > On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: > >> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä > >> wrote: > >>> > >>> On Fri, Feb 18, 2022 at 12:03:41PM +0200,

Re: [PATCH] drm/edid: fix CEA extension byte #3 parsing

On Wed, Mar 23, 2022 at 12:04:38PM +0200, Jani Nikula wrote: > Only an EDID CEA extension has byte #3, while the CTA DisplayID Data > Block does not. Don't interpret bogus data for color formats. I think what we might want eventually is a cleaner split between the CTA data blocks vs. the rest of

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

Hi Alex, On Wed, 23 Mar 2022 at 14:42, Alex Deucher wrote: > On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > On Wed, 23 Mar 2022 at 08:19, Christian König > > wrote: > > > Well the key point is it's not about you to judge that. > > > > > > If you want to complain about the commit

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > On Wed, 23 Mar 2022 at 08:19, Christian König > wrote: > > Am 23.03.22 um 09:10 schrieb Paul Menzel: > > > Sorry, I disagree. The motivation needs to be part of the commit > > > message. For example see recent discussion on the LWN

Re: [REPOST PATCH v4 07/13] drm/msm/disp/dpu1: Add support for DSC in encoder

On 17-02-22, 23:32, Marijn Suijten wrote: > On 2022-02-10 16:04:17, Vinod Koul wrote: > > We need to configure the encoder for DSC configuration and calculate DSC > > parameters for the given timing so this patch adds that support by > > adding dpu_encoder_prep_dsc() which is invoked when DSC is

Re: [v8 3/5] drm/edid: read HF-EEODB ext block

On Wed, Mar 23, 2022 at 12:11:50PM +0200, Jani Nikula wrote: > On Thu, 17 Mar 2022, Lee Shawn C wrote: > > According to HDMI 2.1 spec. > > > > "The HDMI Forum EDID Extension Override Data Block (HF-EEODB) > > is utilized by Sink Devices to provide an alternate method to > > indicate an EDID

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

Hi, On Mon, 21 Mar 2022 at 16:02, Rob Clark wrote: > On Mon, Mar 21, 2022 at 2:30 AM Christian König > wrote: > > Well you can, it just means that their contexts are lost as well. > > Which is rather inconvenient when deqp-egl reset tests, for example, > take down your compositor ;-) Yeah. Or

Re: [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml

On Tue, Mar 8, 2022 at 1:36 PM Rob Herring wrote: > > On Tue, Mar 1, 2022 at 6:14 PM Dmitry Baryshkov > wrote: > > > > Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix > > indentation for another brace, so it matches the corresponding line. > > > > Reported-by: Rob Herring >

Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

On Wed, 23 Mar 2022 at 08:19, Christian König wrote: > Am 23.03.22 um 09:10 schrieb Paul Menzel: > > Sorry, I disagree. The motivation needs to be part of the commit > > message. For example see recent discussion on the LWN article > > *Donenfeld: Random number generator enhancements for Linux

Re: [PATCH 1/6] drm/ttm: move the LRU into resource handling v4

Am 23.03.22 um 14:36 schrieb Daniel Vetter: On Wed, 23 Mar 2022 at 13:20, Christian König wrote: Am 23.03.22 um 12:59 schrieb Daniel Vetter: On Mon, Mar 21, 2022 at 02:25:56PM +0100, Christian König wrote: This way we finally fix the problem that new resource are not immediately evict-able

Re: [PATCH 11/23] dma-buf: drop the DAG approach for the dma_resv object v2

On Mon, Mar 21, 2022 at 02:58:44PM +0100, Christian König wrote: > So far we had the approach of using a directed acyclic > graph with the dma_resv obj. > > This turned out to have many downsides, especially it means > that every single driver and user of this interface needs > to be aware of

Re: [PATCH v3 3/6] drm/msm: split the main platform driver

Hi Dmitry, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [cannot apply to v5.17 next-20220323] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git

Re: [PATCH 10/23] dma-buf: finally make dma_resv_excl_fence private v2

On Mon, Mar 21, 2022 at 02:58:43PM +0100, Christian König wrote: > Drivers should never touch this directly. > > v2: fix rebase clash > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter I guess as soon as we have the rdma ack you can land up to this patch? -Daniel > --- >

Re: [PATCH 1/6] drm/ttm: move the LRU into resource handling v4

On Wed, 23 Mar 2022 at 13:20, Christian König wrote: > > Am 23.03.22 um 12:59 schrieb Daniel Vetter: > > On Mon, Mar 21, 2022 at 02:25:56PM +0100, Christian König wrote: > >> This way we finally fix the problem that new resource are > >> not immediately evict-able after allocation. > >> > >> That

Re: [PATCH 04/23] RDMA: use dma_resv_wait() instead of extracting the fence

On Mon, Mar 21, 2022 at 02:58:37PM +0100, Christian König wrote: > Use dma_resv_wait() instead of extracting the exclusive fence and > waiting on it manually. > > Signed-off-by: Christian König > Reviewed-by: Daniel Vetter > Cc: Jason Gunthorpe Jason, can you ack this for merging through drm

Re: [PATCH v13 00/13] Add GuC Error Capture Support

Hi, On 21/03/2022 16:45, Alan Previn wrote: This series: 1. Enables support of GuC to report error-state-capture using a list of MMIO registers the driver registers and GuC will dump, log and notify right before a GuC triggered engine-reset event. 2. Updates the ADS

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

On Wed, Mar 23, 2022 at 12:12:43PM +0800, Sui Jingfeng wrote: > > On 2022/3/23 04:49, Rob Herring wrote: > > > +/* > > > + * mainly for dc in ls7a1000 which have builtin gpio emulated i2c > > > + * > > > + * @index : output channel index, 0 for DVO0, 1 for DVO1 > > > + */ > > > +struct lsdc_i2c

Re: [PATCH 01/23] dma-buf: add dma_resv_replace_fences v2

On Mon, Mar 21, 2022 at 02:58:34PM +0100, Christian König wrote: > This function allows to replace fences from the shared fence list when > we can gurantee that the operation represented by the original fence has > finished or no accesses to the resources protected by the dma_resv > object any

Re: [PATCH v11 5/7] dt-bindings: display: Add Loongson display controller

On Wed, Mar 23, 2022 at 11:38:55AM +0800, Sui Jingfeng wrote: > > On 2022/3/23 04:55, Rob Herring wrote: > > On Tue, Mar 22, 2022 at 10:33:45AM +0800, Sui Jingfeng wrote: > > > On 2022/3/22 07:20, Rob Herring wrote: > > > > On Tue, Mar 22, 2022 at 12:29:14AM +0800, Sui Jingfeng wrote: > > > > >

Re: [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board

On Wed, Mar 23, 2022 at 09:53:14AM +0800, Sui Jingfeng wrote: > > On 2022/3/23 00:06, Jiaxun Yang wrote: > > > > > > 在 2022/3/22 13:38, Sui Jingfeng 写道: > > > > > > On 2022/3/22 21:05, Jiaxun Yang wrote: > > > > > > > > > > > > 在 2022/3/21 16:29, Sui Jingfeng 写道: > > > > > From: suijingfeng

Re: [PATCH 1/1] drm/amdkfd: Protect the Client whilst it is being operated on

On Thu, 17 Mar 2022, Lee Jones wrote: > On Thu, 17 Mar 2022, philip yang wrote: > > >On 2022-03-17 11:13 a.m., Lee Jones wrote: > > > > On Thu, 17 Mar 2022, Felix Kuehling wrote: > > > > > > Am 2022-03-17 um 11:00 schrieb Lee Jones: > > > > Good afternoon Felix, > > > > Thanks for your

Re: [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board

在2022年3月23日三月 上午7:07，Sui Jingfeng写道： > On 2022/3/23 10:29, Jiaxun Yang wrote: >> If you want to blame somebody for the problem then please don't >> blame us. We tried very hard to fit all those stuff into kernel's model >> of devices. You should blame those who did the initial design of >>

Re: [PATCH 1/6] drm/ttm: move the LRU into resource handling v4

Am 23.03.22 um 12:59 schrieb Daniel Vetter: On Mon, Mar 21, 2022 at 02:25:56PM +0100, Christian König wrote: This way we finally fix the problem that new resource are not immediately evict-able after allocation. That has caused numerous problems including OOM on GDS handling and not being able

Re: [v8 3/5] drm/edid: read HF-EEODB ext block

On Wed, 23 Mar 2022, Simon Ser wrote: > On Wednesday, March 23rd, 2022 at 13:02, Jani Nikula > wrote: > >> Simon and Daniel also tell me on IRC we can't just modify the base block >> extension count to match HF-EEODB to dodge the problem, because the EDID >> gets exposed to userspace. > > I'm

Re: [v8 3/5] drm/edid: read HF-EEODB ext block

On Wednesday, March 23rd, 2022 at 13:02, Jani Nikula wrote: > Simon and Daniel also tell me on IRC we can't just modify the base block > extension count to match HF-EEODB to dodge the problem, because the EDID > gets exposed to userspace. I'm not familiar how the EDID blob gets exposed to

Re: [v8 3/5] drm/edid: read HF-EEODB ext block

On Wed, 23 Mar 2022, Jani Nikula wrote: > On Thu, 17 Mar 2022, Lee Shawn C wrote: >> According to HDMI 2.1 spec. >> >> "The HDMI Forum EDID Extension Override Data Block (HF-EEODB) >> is utilized by Sink Devices to provide an alternate method to >> indicate an EDID Extension Block count larger

Re: [PATCH 1/6] drm/ttm: move the LRU into resource handling v4

On Mon, Mar 21, 2022 at 02:25:56PM +0100, Christian König wrote: > This way we finally fix the problem that new resource are > not immediately evict-able after allocation. > > That has caused numerous problems including OOM on GDS handling > and not being able to use TTM as general resource

Re: [REPOST PATCH v4 10/13] drm/msm/disp/dpu1: Add support for DSC in topology

On 17-02-22, 23:37, Marijn Suijten wrote: > On 2022-02-10 16:04:20, Vinod Koul wrote: > > For DSC to work we typically need a 2,2,1 configuration. This should > > suffice for resolutions up to 4k. For more resolutions like 8k this won't > > work. > > > > Also, it is better to use 2 LMs and DSC

Re: [Freedreno] [REPOST PATCH v4 10/13] drm/msm/disp/dpu1: Add support for DSC in topology

On 17-02-22, 22:44, Marijn Suijten wrote: > On 2022-02-10 16:04:20, Vinod Koul wrote: > > For DSC to work we typically need a 2,2,1 configuration. This should > > suffice for resolutions up to 4k. For more resolutions like 8k this won't > > work. > > > > Also, it is better to use 2 LMs and DSC

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

Hi Arunpravin, Thank you for the patch! Yet something to improve: [auto build test ERROR on a678f97326454b60ffbbde6abf52d23997d71a27] url: https://github.com/0day-ci/linux/commits/Arunpravin-Paneer-Selvam/drm-amdgpu-add-drm-buddy-support-to-amdgpu/20220323-142749 base

Re: [PATCH 6/6] RFC: dma-buf: Add an API for importing sync files (v7)

On 6/11/21 04:09, Jason Ekstrand wrote: This patch is analogous to the previous sync file export patch in that it allows you to import a sync_file into a dma-buf. Unlike the previous patch, however, this does add genuinely new functionality to dma-buf. Without this, the only way to attach a

[PATCH] drm/amd/display: use NULL instead of using plain integer as pointer

This fixes the following sparse warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:865:16: warning: Using plain integer as NULL pointer Signed-off-by: Haowen Bai --- drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2] drm/nouveau/bios: Rename prom_init() and friends functions

On Sat, Mar 19, 2022 at 11:27:51AM +0100, Christophe Leroy wrote: > While working at fixing powerpc headers, I ended up with the > following error. > > drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowrom.c:48:1: error: > conflicting types for 'prom_init'; have 'void *(struct nvkm_bios *,

[PATCH] gpu: drm: Fix duplicate included linux/module.h

Clean up the following includecheck warning: drivers/gpu/drm/drm_gem_shmem_helper.c: linux/module.h is included more than once. No functional change. Signed-off-by: Haowen Bai --- drivers/gpu/drm/drm_gem_shmem_helper.c | 1 - 1 file changed, 1 deletion(-) diff --git

  1   2   >