Dear Haowen,
Thank you for your patch.
Am 31.03.22 um 07:56 schrieb Haowen Bai:
In the commit message summary, please use:
Remove unneeded semicolon
report by coccicheck:
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:1951:2-3: Unneeded semicolon
fixed c543dcb ("drm/amdgpu/vcn: Add VCN ras error qu
Dear David,
Thank you for your patch.
Am 31.03.22 um 19:26 schrieb David Zhang:
[why & how]
In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU
support.
You could be specific by using the exact number two. Maybe:
As per eDP 1.5 specification, add the two DPCD bit fields below f
On Tue 29 Mar 06:27 PDT 2022, Paul Kocialkowski wrote:
> While bridge/panel detection was initially relying on the usual
> port/ports-based of graph detection, it was recently changed to
> perform the lookup on any child node that is not port/ports
> instead when such a node is available, with no
Replace `if (!ret)` with `else` for simplification.
Signed-off-by: Guo Zhengkui
---
drivers/gpu/drm/radeon/radeon_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_pm.c
b/drivers/gpu/drm/radeon/radeon_pm.c
index c67b6ddb29a4..e765abcb3b01 100
Since this driver has been changed to use the resource managed
devm_drm_of_get_bridge() to get bridge from ->attach(), it's
unnecessary to call drm_of_panel_bridge_remove() to remove the
bridge from ->detach(). So, let's drop the drm_of_panel_bridge_remove()
function call. As nwl_dsi_bridge_detac
Hi Piotr:
On 3/31/22 22:53, Piotr Oniszczuk wrote:
Wiadomość napisana przez Andy Yan w dniu 31.03.2022,
o godz. 14:13:
Piotr:
What soc is on you board? rk3566 or rk3568?
it is rk3566 in x96-x6 tvbox
RK3566? Maybe that is the problem.
plane[43]: Esmart1-win0
crtc=(null)
fb=0
crtc-po
On 4/1/22 01:52, Rob Herring wrote:
On Wed, 23 Mar 2022 16:48:23 +0100, Maxime Ripard wrote:
MIPI-DSI devices, if they are controlled through the bus itself, have to
be described as a child node of the controller they are attached to.
Thus, there's no requirement on the controller having an OF-
On Mon, 28 Mar 2022 07:49:30 +0100, Biju Das wrote:
> The RZ/G2L MIPI DSI TX is embedded in the Renesas RZ/G2L family SoC's. It
> can operate in DSI mode, with up to four data lanes.
>
> Signed-off-by: Biju Das
> ---
> v1->v2:
> * Added full path for dsi-controller.yaml
> * Modeled DSI + D-PHY
Xiaomi Poco F1 uses the QCOM WLED driver for backlight control.
Enable and link it to the panel to use it.
Signed-off-by: Joel Selvaraj
---
Changes in v2:
- Remove qcom,enabled-strings property as either it or qcom,num-strings
should be present. qcom,num-strings is specified and sufficient.
Add backlight property and update example to include it.
Signed-off-by: Joel Selvaraj
---
.../devicetree/bindings/display/panel/novatek,nt36672a.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git
a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
b/Documentation/
Add support for backlight. This panel supports backlight control
through the QCOM WLED driver in Xiaomi Poco F1 device.
Signed-off-by: Joel Selvaraj
---
drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36
Changes in v2:
- Remove qcom,enabled-strings property as either it or qcom,num-strings
should be present. qcom,num-strings is specified and sufficient.
(Marijn Suijten's Suggestion)
Joel Selvaraj (3):
drm/panel: nt36672a: add backlight support
dt-bindings: display: novatek,nt36672a: add
For vendors drivers which pass an already allocated and
initialized encoder especially for cases where the encoder
hardware is shared OR the writeback encoder shares the resources
with the rest of the display pipeline introduce a new API,
drm_writeback_connector_init_with_encoder() which expects
an
For some vendor driver implementations, display hardware can
be shared between the encoder used for writeback and the physical
display.
In addition resources such as clocks and interrupts can
also be shared between writeback and the real encoder.
To accommodate such vendor drivers and hardware, a
vc4 driver currently embeds the drm_encoder into struct vc4_txp
and later on uses container_of to retrieve the vc4_txp from
the drm_encoder.
Make vc4 driver use the new API so that the embedded encoder model
can be retained in the driver and there is no change in
functionality.
changes in v6:
Clients of drm_writeback_connector_init() initialize the
possible_crtcs and then invoke the call to this API.
To simplify things, allow passing possible_crtcs as a parameter
to drm_writeback_connector_init() and make changes to the
other drm drivers to make them compatible with this change.
chang
There are some vendor drivers for which the writeback encoder shares
hardware resources such as clocks and interrupts with the rest of the
display pipeline. In addition, there can be use-cases where the
writeback encoder could be a shared encoder between the physical display
path and the writeback
On Wed, 23 Mar 2022 16:48:23 +0100, Maxime Ripard wrote:
> MIPI-DSI devices, if they are controlled through the bus itself, have to
> be described as a child node of the controller they are attached to.
>
> Thus, there's no requirement on the controller having an OF-Graph output
> port to model th
On Tue, 22 Mar 2022 15:28:52 +0100, Marek Vasut wrote:
> Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3
> and is completely different from the LCDIFv3 found in i.MX23 in that it
> has a completely scrambled register layout compared to all previous LCDIF
> variants. The new
Hi,
On Wed, Mar 30, 2022 at 11:02 PM Sankeerth Billakanti (QUIC)
wrote:
>
> Hi Dmitry,
>
> > On Wed, 30 Mar 2022 at 19:04, Sankeerth Billakanti
> > wrote:
> > >
> > > The panel-edp driver modes needs to be validated differently from DP
> > > because the link capabilities are not available for ED
Hi,
On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti
wrote:
>
> Some eDP sinks or platform boards will not support hpd.
> This patch adds support for those cases.
You could say more, like:
If we're not using HPD then _both_ the panel node and the eDP
controller node will have "no-hpd". This
Hi,
On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti
wrote:
>
> @@ -1374,6 +1382,12 @@ static int dp_pm_resume(struct device *dev)
> dp_catalog_ctrl_hpd_config(dp->catalog);
>
>
> + if (dp->dp_display.connector_type == DRM_MODE_CONNECTOR_DisplayPort)
> + dp_catalog
Hi,
On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti
wrote:
>
> Remove the unnecessary delay in executing the EV_HPD_INIT_SETUP event.
Tell me more and put it in the commit message! Why did it used to be
necessary and why is it no longer necessary? Inquiring minds want to
know.
-Doug
Hi,
On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti
wrote:
>
> The aux_bus support with the dp_display driver will enable the dp
> resources during msm_dp_modeset_init. The host_init has to return early
> if the core is already initialized to prevent putting an additional vote
> for the dp c
Hi,
On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti
wrote:
>
> The source device should ensure the sink is ready before proceeding to
> read the sink capability or performing any aux transactions. The sink
s/performing/perform
> will indicate its readiness by asserting the HPD line. The co
Hi,
On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti
wrote:
>
> @@ -1547,6 +1593,10 @@ int msm_dp_modeset_init(struct msm_dp *dp_display,
> struct drm_device *dev,
>
> dp_display->encoder = encoder;
>
> + ret = dp_display_get_next_bridge(dp_display);
> + if (ret)
> +
To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.
To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boole
lgtm, I just have a few nits and questions below:
Regardless, this is
Reviewed-by: Umesh Nerlige Ramappa
Umesh
On Tue, Feb 22, 2022 at 01:55:57PM +, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Use the i915 exported data in /proc//fdinfo to show GPU utilization
per DRM client.
Example o
On 3/31/22 21:58, Rob Clark wrote:
> On Thu, Mar 31, 2022 at 11:27 AM Dmitry Osipenko
> wrote:
>>
>> On 3/30/22 23:47, Rob Clark wrote:
>>> From: Rob Clark
>>>
>>> Combines duplicate vma lookup in the get_and_pin path.
>>>
>>> Signed-off-by: Rob Clark
>>> ---
>>> drivers/gpu/drm/msm/msm_gem.c |
Hi Yunfei,
thanks for the update, I should be testing this really soon.
Le jeudi 31 mars 2022 à 10:47 +0800, Yunfei Dong a écrit :
> This series adds support for mt8192 h264/vp8/vp9 decoder drivers. Firstly,
> refactor
> power/clock/interrupt interfaces for mt8192 is lat and core architecture.
You really need to hold the reservation here or all kinds of funny
things can happen between grabbing the dependencies and inserting the
new fences.
v2: Fix commit summary (Christian)
Acked-by: Melissa Wen
Reviewed-by: "Christian König"
Signed-off-by: Daniel Vetter
Cc: "Christian König"
Cc: D
There's only one exclusive slot, and we must not break the ordering.
Adding a new exclusive fence drops all previous fences from the
dma_resv. To avoid violating the signalling order we err on the side of
over-synchronizing by waiting for the existing fences, even if
userspace asked us to ignore th
We need to pull the drm_sched_job_init much earlier, but that's very
minor surgery.
v2: Actually fix up cleanup paths by calling drm_sched_job_init, which
I wanted to to in the previous round (and did, for all other drivers).
Spotted by Lucas.
v3: Rebase over renamed functions to add dependencies
Integrated into the scheduler now and all users converted over.
v2: Rebased over changes from König.
Signed-off-by: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: David Airlie
Cc: Daniel Vetter
Cc: Sumit Semwal
Cc: "Christian König"
Cc: linux-me...@vger.ke
Hi all,
The only changes compared to the previous version is that the 2nd etnaviv
patch has an improved commit message.
Previous discussion is here:
https://lore.kernel.org/dri-devel/20210706101209.3034092-1-daniel.vet...@ffwll.ch/
Would be great if I can finally stuff these into drm-misc-next
On Thu, Mar 31, 2022 at 10:25:23PM +0200, Daniel Vetter wrote:
> On Thu, Mar 31, 2022 at 11:11:00PM +0300, Ville Syrjälä wrote:
> > On Thu, Mar 31, 2022 at 10:02:53PM +0200, Daniel Vetter wrote:
> > > On Thu, Mar 31, 2022 at 10:52:54PM +0300, Ville Syrjälä wrote:
> > > > On Thu, Mar 31, 2022 at 09:
On 3/30/22 12:45, Daniel Vetter wrote:
> On Tue, Mar 15, 2022 at 12:53:30AM +0300, Dmitry Osipenko wrote:
>> On 3/11/22 17:22, Maxime Ripard wrote:
>>> Hi Dmitry,
>>>
>>> On Thu, Mar 10, 2022 at 03:33:07AM +0300, Dmitry Osipenko wrote:
I was playing/testing SuperTuxKart using VirtIO-GPU driver
On Thu, Mar 31, 2022 at 11:11:00PM +0300, Ville Syrjälä wrote:
> On Thu, Mar 31, 2022 at 10:02:53PM +0200, Daniel Vetter wrote:
> > On Thu, Mar 31, 2022 at 10:52:54PM +0300, Ville Syrjälä wrote:
> > > On Thu, Mar 31, 2022 at 09:11:29PM +0200, Daniel Vetter wrote:
> > > > On Thu, Mar 31, 2022 at 06:
On Thu, Mar 31, 2022 at 10:02:53PM +0200, Daniel Vetter wrote:
> On Thu, Mar 31, 2022 at 10:52:54PM +0300, Ville Syrjälä wrote:
> > On Thu, Mar 31, 2022 at 09:11:29PM +0200, Daniel Vetter wrote:
> > > On Thu, Mar 31, 2022 at 06:48:43PM +0300, Ville Syrjälä wrote:
> > > > On Thu, Mar 31, 2022 at 05:
On Thu, Mar 31, 2022 at 10:52:54PM +0300, Ville Syrjälä wrote:
> On Thu, Mar 31, 2022 at 09:11:29PM +0200, Daniel Vetter wrote:
> > On Thu, Mar 31, 2022 at 06:48:43PM +0300, Ville Syrjälä wrote:
> > > On Thu, Mar 31, 2022 at 05:14:29PM +0200, Daniel Vetter wrote:
> > > > On Thu, Mar 31, 2022 at 04:
On Thu, Mar 31, 2022 at 12:41 PM Dmitry Osipenko
wrote:
>
> On 3/31/22 22:02, Rob Clark wrote:
> > On Thu, Mar 31, 2022 at 11:52 AM Dmitry Osipenko
> > wrote:
> >>
> >> ...
> >>> +/*
> >>> + * Get the requested iova but don't pin it. Fails if the requested iova
> >>> is
> >>> + * not available.
On Thu, Mar 31, 2022 at 09:11:29PM +0200, Daniel Vetter wrote:
> On Thu, Mar 31, 2022 at 06:48:43PM +0300, Ville Syrjälä wrote:
> > On Thu, Mar 31, 2022 at 05:14:29PM +0200, Daniel Vetter wrote:
> > > On Thu, Mar 31, 2022 at 04:25:13PM +0300, Ville Syrjälä wrote:
> > > > On Thu, Mar 31, 2022 at 03:
On 3/31/22 22:02, Rob Clark wrote:
> On Thu, Mar 31, 2022 at 11:52 AM Dmitry Osipenko
> wrote:
>>
>> ...
>>> +/*
>>> + * Get the requested iova but don't pin it. Fails if the requested iova is
>>> + * not available. Doesn't need a put because iovas are currently valid for
>>> + * the life of the
This driver currently rewrites bus_flags based solely on the value of
DT property 'data-mirror' and ignores bus_flags which might have been
set in DT panel-timing node. Specificaly, the 'de-active' DT property
sets DRM_BUS_FLAG_DE_ bus_flags.
Since of_get_drm_panel_display_mode() conveniently pars
The mode parsing is currently implemented in three steps:
of_get_display_timing() - DT panel-timing to struct display_timing
videomode_from_timing() - struct display_timing to struct videomode
drm_display_mode_from_videomode() - struct videomode to struct drm_display_mode
Replace all that with sim
On Thu, Mar 31, 2022 at 06:48:43PM +0300, Ville Syrjälä wrote:
> On Thu, Mar 31, 2022 at 05:14:29PM +0200, Daniel Vetter wrote:
> > On Thu, Mar 31, 2022 at 04:25:13PM +0300, Ville Syrjälä wrote:
> > > On Thu, Mar 31, 2022 at 03:05:45PM +0200, Maxime Ripard wrote:
> > > > From: Daniel Vetter
> > >
On Wed, Mar 30, 2022 at 02:53:11PM -0700, Matt Atwood wrote:
> Newer platforms have DSS that aren't necessarily available for both
> geometry and compute, two queries will need to exist. This introduces
> the first, when passing a valid engine class and engine instance in the
> flags returns a topo
On Thu, Mar 31, 2022 at 11:52 AM Dmitry Osipenko
wrote:
>
> ...
> > +/*
> > + * Get the requested iova but don't pin it. Fails if the requested iova is
> > + * not available. Doesn't need a put because iovas are currently valid for
> > + * the life of the object.
> > + *
> > + * Setting an iova
On Thu, Mar 31, 2022 at 11:27 AM Dmitry Osipenko
wrote:
>
> On 3/30/22 23:47, Rob Clark wrote:
> > From: Rob Clark
> >
> > Combines duplicate vma lookup in the get_and_pin path.
> >
> > Signed-off-by: Rob Clark
> > ---
> > drivers/gpu/drm/msm/msm_gem.c | 50 ++-
>
On 2022-03-31 13:26, David Zhang wrote:
> [why & how]
> In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU
Please fix up the type in "fileds"
> support.
>
> Signed-off-by: David Zhang
With that fixed this patch is
Reviewed-by: Harry Wentland
Btw, you don't need to add a cove
On 3/31/22 21:52, Dmitry Osipenko wrote:
> ...
>> +/*
>> + * Get the requested iova but don't pin it. Fails if the requested iova is
>> + * not available. Doesn't need a put because iovas are currently valid for
>> + * the life of the object.
>> + *
>> + * Setting an iova of zero will clear the
...
> +/*
> + * Get the requested iova but don't pin it. Fails if the requested iova is
> + * not available. Doesn't need a put because iovas are currently valid for
> + * the life of the object.
> + *
> + * Setting an iova of zero will clear the vma.
> + */
> +int msm_gem_set_iova(struct drm_gem
The code modifying the EDID block should not need to do tricks to fix
the checksum. We have a function for computing the checksum, use it.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/drm_edid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
On Wed, 30 Mar 2022, Ville Syrjälä wrote:
> On Tue, Mar 29, 2022 at 09:42:08PM +0300, Jani Nikula wrote:
>> +if (valid_extensions != edid->extensions) {
>> +struct edid *base;
>
> This one points to extension blocks too so using
> struct edid doesn't seem entirely appropriate.
Se
It's such a special case there's no point in keeping it inline in the
happy day scenario, confusing matters.
v2: Rebase on the invalid block filtering fix
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/drm_edid.c | 52 --
Track invalid blocks instead of valid extensions to minimize impact on
the happy day scenario, and hide the details in the separate function.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/drm_edid.c | 17 -
1 file changed, 8 inserti
Simplify, rename, take void pointer. No need for the drm_ prefix for
internal helpers.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/drm_edid.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/drm_ed
There's no need to handle complicated scenarios or debug log when
filtering blocks that have already been identified as invalid. Simplify
by adding an edid_block_valid() helper that operates on const data and
prints nothing.
(Finally, here's the justification for the previously added separate
edid
Just i is a bit terse, clarify what it's about.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/drm_edid.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
in
Add edid_block_check() that only checks the EDID block validity, without
any actions. Turns out it's simple and crystal clear.
Rewrite drm_edid_block_valid() around it, keeping all the functionality
fairly closely the same, warts and all. Turns out it's incredibly
complicated for a function you'd
Give a name to the EDID header fixup instead of having an inline memcpy.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/drm_edid.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm
The extension tag at offset 0 is not present in struct edid, add a
helper for it to reduce the need to use u8 *.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/drm_edid.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --g
Have two clear functions, one to compute the checksum over the EDID, and
another to get the checksum from the EDID. Throw away the diff function.
Ditch the drm_ prefix for static functions, and accept const void * to
help transition to struct edid * usage.
Cc: Ville Syrjälä
Signed-off-by: Jani N
It will be useful to accept a struct edid *, but for compatibility with
existing usage accept void *.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/drm_edid.c | 8 +---
include/drm/drm_edid.h | 2 +-
2 files changed, 6 insertions(+), 4 dele
Mixing u8 * and struct edid * is confusing, switch to the latter.
v2:
- Rebase on the invalid block filtering fix
- Rename struct edid *base to *dest_block for clarity (Ville)
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 35 +--
v2 of https://patchwork.freedesktop.org/series/101931/
Rebased, review comments addressed.
BR,
Jani.
Jani Nikula (12):
drm/edid: use struct edid * in drm_do_get_edid()
drm/edid: clean up EDID block checksum functions
drm/edid: add edid_block_tag() helper to get the EDID extension tag
d
Hi Liviu
Thanks for the response.
Let me fix up and spin a new version.
Abhinav
On 3/31/2022 3:01 AM, Liviu Dudau wrote:
On Fri, Mar 25, 2022 at 09:31:35AM -0700, Abhinav Kumar wrote:
Hi Liviu
Hi Abhinav,
Sorry for the delay, got busy with other things at the beginning of the week.
On
On 3/31/22 21:27, Dmitry Osipenko wrote:
> On 3/30/22 23:47, Rob Clark wrote:
>> From: Rob Clark
>>
>> Combines duplicate vma lookup in the get_and_pin path.
>>
>> Signed-off-by: Rob Clark
>> ---
>> drivers/gpu/drm/msm/msm_gem.c | 50 ++-
>> 1 file changed, 26 ins
On 3/30/22 23:47, Rob Clark wrote:
> From: Rob Clark
>
> Combines duplicate vma lookup in the get_and_pin path.
>
> Signed-off-by: Rob Clark
> ---
> drivers/gpu/drm/msm/msm_gem.c | 50 ++-
> 1 file changed, 26 insertions(+), 24 deletions(-)
>
> diff --git a/dri
Philippe, Chun-Kuang,
I applied this patch without realizing it is outside of my maintainer
domain, and caused conflict in dim-tip, which I've resolved.
Even with the conflict resolved, I think getting an AB after the fact
would be good.
Sorry about the inconvenience.
On 31/03/2022 00:28, Matt Roper wrote:
Historically we've selected and programmed a single MCR group/instance
ID at driver startup that will steer register accesses for GSLICE/DSS
ranges to a non-terminated instance. Any reads of these register ranges
that don't need a specific unicast access
[why & how]
In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU
support.
Signed-off-by: David Zhang
---
include/drm/drm_dp_helper.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 30359e434c3f..ac7b7571ae66 100644
*** BLURB HERE ***
David Zhang (1):
drm: add PSR2 support and capability definition as per eDP 1.5
include/drm/drm_dp_helper.h | 2 ++
1 file changed, 2 insertions(+)
--
2.25.1
On Thu, 31 Mar 2022, Felix Kuehling wrote:
>
> Am 2022-03-31 um 08:21 schrieb Lee Jones:
> > This ensures userspace cannot prematurely clean-up the client before
> > it is fully initialised which has been proven to cause issues in the
> > past.
> >
> > Cc: Felix Kuehling
> > Cc: Alex Deucher
>
On Tue, Mar 29, 2022 at 09:42:07PM +0300, Jani Nikula wrote:
> Another day, another batch of EDID code refactoring.
>
> Mostly the goal was to simplify drm_do_get_edid(), but trying to extract
> a const function for checking a single block validity lead me down a
> rabbit hole...
>
> BR,
> Jani.
On 3/28/22 16:26, Daniel Vetter wrote:
On Mon, Mar 28, 2022 at 12:21:16PM +0200, Alain Volmat wrote:
Hi Randy,
thanks for the patch.
Acked-by: Alain Volmat
Will Philippe apply this one?
Hi,
yes I will (probably early next week).
Many thanks
Philippe
Just trying to make sure this won
On Thu, Mar 31, 2022 at 07:49:10PM +0300, Jani Nikula wrote:
> On Thu, 31 Mar 2022, Ville Syrjälä wrote:
> >> -
> >> - if (edid->revision > 4)
> >> - DRM_DEBUG("EDID minor > 4, assuming backward
> >> compatibility\n");
> >
> > This debug message seems to disappear. Inten
On Thu, 31 Mar 2022, Ville Syrjälä wrote:
>> -
>> -if (edid->revision > 4)
>> -DRM_DEBUG("EDID minor > 4, assuming backward
>> compatibility\n");
>
> This debug message seems to disappear. Intentional?
Intentional, but failed to mention it in the commit message.
On Thu, 31 Mar 2022 at 14:07, Christian König
wrote:
>
> Am 28.03.22 um 19:14 schrieb Daniel Vetter:
> > On Mon, Mar 21, 2022 at 02:58:45PM +0100, Christian König wrote:
> >> [SNIP]
> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> >>
On Fri, Feb 11, 2022 at 12:15:44AM +0100, Janne Grunau wrote:
> On 2022-02-09 17:31:16 +0100, Thierry Reding wrote:
> > On Sun, Feb 06, 2022 at 11:27:00PM +0100, Janne Grunau wrote:
> > > On 2021-09-15 17:19:39 +0200, Thierry Reding wrote:
> > > > On Tue, Sep 07, 2021 at 07:44:44PM +0200, Thierry R
On Thu, Mar 31, 2022 at 09:15:03PM +0530, Jagan Teki wrote:
> devm_drm_of_get_bridge is capable of looking up the downstream
> bridge and panel and trying to add a panel bridge if the panel
> is found.
>
> Replace explicit finding calls with devm_drm_of_get_bridge.
>
> Cc: Linus Walleij
> Signed
Applied to drm-misc-next.
On Thu, 31 Mar 2022 at 17:45, Jagan Teki wrote:
>
> This reverts commit c206c7faeb3263a7cc7b4de443a3877cd7a5e74b.
>
> In order to avoid any probe ordering issues, the I2C based downstream
> bridge drivers now register and attach the DSI devices at the probe
> instead of doing it on drm_bridge_func
On Thu, 31 Mar 2022, Ville Syrjälä wrote:
> On Tue, Mar 29, 2022 at 09:42:14PM +0300, Jani Nikula wrote:
>> Add edid_block_check() that only checks the EDID block validity, without
>> any actions. Turns out it's simple and crystal clear.
>>
>> Rewrite drm_edid_block_valid() around it, keeping all
On Thu, 31 Mar 2022 at 17:45, Jagan Teki wrote:
>
> devm_drm_of_get_bridge is capable of looking up the downstream
> bridge and panel and trying to add a panel bridge if the panel
> is found.
>
> Replace explicit finding calls with devm_drm_of_get_bridge.
>
> Signed-off-by: Jagan Teki
> ---
> Cha
On Thu, Mar 31, 2022 at 4:35 AM Dmitry Baryshkov
wrote:
>
> On Thu, 31 Mar 2022 at 09:05, Vinod Koul wrote:
> >
> > On 29-03-22, 10:52, Rob Herring wrote:
> > > On Tue, Mar 29, 2022 at 12:01:52PM +0530, Vinod Koul wrote:
> > > > On 28-03-22, 13:21, Rob Herring wrote:
> > > > > On Mon, Mar 28, 202
On Thu, 31 Mar 2022 at 17:45, Jagan Teki wrote:
>
> devm_drm_of_get_bridge is capable of looking up the downstream
> bridge and panel and trying to add a panel bridge if the panel
> is found.
>
> Replace explicit finding calls with devm_drm_of_get_bridge.
>
> Cc: Chun-Kuang Hu
> Cc: Philipp Zabel
On Thu, Mar 31, 2022 at 05:14:29PM +0200, Daniel Vetter wrote:
> On Thu, Mar 31, 2022 at 04:25:13PM +0300, Ville Syrjälä wrote:
> > On Thu, Mar 31, 2022 at 03:05:45PM +0200, Maxime Ripard wrote:
> > > From: Daniel Vetter
> > >
> > > The stuff never really worked, and leads to lots of fun because
On Thu, 31 Mar 2022 at 17:43, Robert Foss wrote:
>
> On Thu, 31 Mar 2022 at 17:39, Marek Vasut wrote:
> >
> > Use the atomic version of the enable/disable operations to continue the
> > transition to the atomic API. This will be needed to access the mode
> > from the atomic state.
> >
> > Signed-
devm_drm_of_get_bridge is capable of looking up the downstream
bridge and panel and trying to add a panel bridge if the panel
is found.
Replace explicit finding calls with devm_drm_of_get_bridge.
Cc: Linus Walleij
Signed-off-by: Jagan Teki
Reviewed-by: Linus Walleij
---
Changes for v4:
- colle
devm_drm_of_get_bridge is capable of looking up the downstream
bridge and panel and trying to add a panel bridge if the panel
is found.
Replace explicit finding calls with devm_drm_of_get_bridge.
Signed-off-by: Jagan Teki
---
Changes for v4, v3:
- none
Changes for v2:
- split the patch
driver
devm_drm_of_get_bridge is capable of looking up the downstream
bridge and panel and trying to add a panel bridge if the panel
is found.
Replace explicit finding calls with devm_drm_of_get_bridge.
Cc: Chun-Kuang Hu
Cc: Philipp Zabel
Signed-off-by: Jagan Teki
---
Changes for v4, v3:
- none
Chan
devm_drm_of_get_bridge is capable of looking up the downstream
bridge and panel and trying to add a panel bridge if the panel
is found.
Replace explicit finding calls with devm_drm_of_get_bridge.
Reviewed-by: Guido Günther
Signed-off-by: Jagan Teki
---
Changes for v4:
- none
Changes for v3:
- d
On Thu, 31 Mar 2022 at 17:39, Marek Vasut wrote:
>
> Implement .atomic_get_input_bus_fmts callback, which sets up
> the input (scanout-engine-end) formats, so that those formats
> can then be used in pipeline format negotiation between this
> bridge and the scanout engine.
>
> Signed-off-by: Marek
This reverts commit c206c7faeb3263a7cc7b4de443a3877cd7a5e74b.
In order to avoid any probe ordering issues, the I2C based downstream
bridge drivers now register and attach the DSI devices at the probe
instead of doing it on drm_bridge_function.attach().
Examples of those commits are:
commit <6ef7
On Thu, 31 Mar 2022 at 17:39, Marek Vasut wrote:
>
> Use the atomic version of the enable/disable operations to continue the
> transition to the atomic API. This will be needed to access the mode
> from the atomic state.
>
> Signed-off-by: Marek Vasut
> Cc: Dave Airlie
> Cc: John Stultz
> Cc: M
Use the atomic version of the enable/disable operations to continue the
transition to the atomic API. This will be needed to access the mode
from the atomic state.
Signed-off-by: Marek Vasut
Cc: Dave Airlie
Cc: John Stultz
Cc: Maxime Ripard
Cc: Sam Ravnborg
Cc: Thomas Zimmermann
---
drivers
Implement .atomic_get_input_bus_fmts callback, which sets up
the input (scanout-engine-end) formats, so that those formats
can then be used in pipeline format negotiation between this
bridge and the scanout engine.
Signed-off-by: Marek Vasut
Cc: Dave Airlie
Cc: John Stultz
Cc: Maxime Ripard
Cc
On Thu, 31 Mar 2022 at 17:32, Robert Foss wrote:
>
> On Sun, 13 Feb 2022 at 03:27, Marek Vasut wrote:
> >
> > In rare cases, the bridge may not start up correctly, which usually
> > leads to no display output. In case this happens, warn about it in
> > the kernel log.
> >
> > Signed-off-by: Marek
On Sun, 13 Feb 2022 at 03:27, Marek Vasut wrote:
>
> In rare cases, the bridge may not start up correctly, which usually
> leads to no display output. In case this happens, warn about it in
> the kernel log.
>
> Signed-off-by: Marek Vasut
> Cc: Jagan Teki
> Cc: Laurent Pinchart
> Cc: Linus Wall
1 - 100 of 219 matches
Mail list logo
