[PATCH v2] drm: mxsfb: Obtain bus flags from bridge state

2022-04-16 Thread Marek Vasut
In case the MXSFB is connected to a bridge, attempt to obtain bus flags from that bridge state too. The bus flags may specify e.g. the DE signal polarity. Acked-by: Alexander Stein Signed-off-by: Marek Vasut Cc: Alexander Stein Cc: Laurent Pinchart Cc: Lucas Stach Cc: Peng Fan Cc: Robby Cai

[PATCH v3 3/4] drm: mxsfb: Factor out mxsfb_set_mode()

2022-04-16 Thread Marek Vasut
Pull mode registers programming from mxsfb_enable_controller() into dedicated function mxsfb_set_mode(). This is a clean up. No functional change. Signed-off-by: Marek Vasut Cc: Alexander Stein Cc: Laurent Pinchart Cc: Lucas Stach Cc: Peng Fan Cc: Robby Cai Cc: Sam Ravnborg Cc: Stefan

[PATCH v3 4/4] drm: mxsfb: Reorder mxsfb_crtc_mode_set_nofb()

2022-04-16 Thread Marek Vasut
Reorder mxsfb_crtc_mode_set_nofb() such that all functions which perform register IO are called from one single location in this function. This is a clean up. No functional change. Reviewed-by: Lucas Stach Signed-off-by: Marek Vasut Cc: Alexander Stein Cc: Laurent Pinchart Cc: Lucas Stach

[PATCH v3 2/4] drm: mxsfb: Replace mxsfb_get_fb_paddr() with drm_fb_cma_get_gem_addr()

2022-04-16 Thread Marek Vasut
Replace mxsfb_get_fb_paddr() with drm_fb_cma_get_gem_addr() to correctly handle FB offset. Signed-off-by: Marek Vasut Cc: Alexander Stein Cc: Laurent Pinchart Cc: Lucas Stach Cc: Peng Fan Cc: Robby Cai Cc: Sam Ravnborg Cc: Stefan Agner --- V3: New patch ---

[PATCH v3 1/4] drm: mxsfb: Wrap FIFO reset and comments into mxsfb_reset_block()

2022-04-16 Thread Marek Vasut
Wrap FIFO reset and comments into mxsfb_reset_block(), this is a clean up. No functional change. Reviewed-by: Lucas Stach Signed-off-by: Marek Vasut Cc: Alexander Stein Cc: Laurent Pinchart Cc: Lucas Stach Cc: Peng Fan Cc: Robby Cai Cc: Sam Ravnborg Cc: Stefan Agner --- V2: Add RB from

[PATCH v2 1/2] dt-bindings: lcdif: Add compatible for i.MX8MP

2022-04-16 Thread Marek Vasut
Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 and is completely different from the LCDIFv3 found in i.MX23 in that it has a completely scrambled register layout compared to all previous LCDIF variants. The new LCDIFv3 also supports 36bit address space. However, except for

[PATCH v2 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-04-16 Thread Marek Vasut
Add support for i.MX8MP LCDIF variant. This is called LCDIFv3 and is completely different from the LCDIFv3 found in i.MX23 in that it has a completely scrambled register layout compared to all previous LCDIF variants. The new LCDIFv3 also supports 36bit address space. Add a separate driver which

Re: [PATCH 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-04-16 Thread Marek Vasut
On 4/7/22 10:48, Lucas Stach wrote: [...] +static void lcdif_set_mode(struct lcdif_drm_private *lcdif, u32 bus_flags) +{ + struct drm_display_mode *m = >crtc.state->adjusted_mode; + u32 ctrl = 0; + + if (m->flags & DRM_MODE_FLAG_PHSYNC) + ctrl |= CTRL_INV_HS; +

Re: [PATCH v2 1/7] drm: mxsfb: Simplify LCDIF clock handling

2022-04-16 Thread Marek Vasut
On 4/7/22 09:57, Lucas Stach wrote: Am Mittwoch, dem 06.04.2022 um 23:45 +0200 schrieb Marek Vasut: On 4/6/22 21:32, Lucas Stach wrote: Hi Marek, Hi, Am Freitag, dem 11.03.2022 um 18:05 +0100 schrieb Marek Vasut: The current clock handling in the LCDIF driver is a convoluted mess. Here

Re: [PATCH v2 2/7] drm: mxsfb: Simplify LCDIF IRQ handling

2022-04-16 Thread Marek Vasut
On 4/7/22 10:01, Lucas Stach wrote: Am Donnerstag, dem 07.04.2022 um 00:03 +0200 schrieb Marek Vasut: On 4/6/22 21:41, Lucas Stach wrote: Am Freitag, dem 11.03.2022 um 18:05 +0100 schrieb Marek Vasut: The call to drm_crtc_vblank_off(>crtc); disables IRQ generation from the LCDIF block already

[PATCH v2] drm/i915: change node clearing from memset to initialization

2022-04-16 Thread Tom Rix
In insert_mappable_node(), the parameter node is cleared late in node's use with memset. insert_mappable_node() is a singleton, called only from i915_gem_gtt_prepare() which itself is only called by i915_gem_gtt_pread() and i915_gem_gtt_pwrite_fast() where the definition of node originates.

Re: [PATCH] drm/i915: change node clearing from memset to initialization

2022-04-16 Thread Tom Rix
On 4/16/22 2:04 PM, Joe Perches wrote: On Sat, 2022-04-16 at 13:48 -0700, Tom Rix wrote: On 4/16/22 11:33 AM, Joe Perches wrote: On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote: In insert_mappable_node(), the parameter node is cleared late in node's use with memset. insert_mappable_node()

Re: [PATCH v3] drm: of: Properly try all possible cases for bridge/panel detection

2022-04-16 Thread Paul Cercueil
Hi Paul, This patch breaks the ingenic-drm driver. It calls drm_of_find_panel_or_bridge(np, 0, i, ...) starting for i=0, until -ENODEV is returned, which does not happen anymore. The idea is to probe all the connected panels/bridges, should it be done differently now? Cheers, -Paul

Re: [PATCH] drm/i915: change node clearing from memset to initialization

2022-04-16 Thread Joe Perches
On Sat, 2022-04-16 at 13:48 -0700, Tom Rix wrote: > On 4/16/22 11:33 AM, Joe Perches wrote: > > On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote: > > > In insert_mappable_node(), the parameter node is > > > cleared late in node's use with memset. > > > insert_mappable_node() is a singleton, called

Re: [PATCH] drm/i915: change node clearing from memset to initialization

2022-04-16 Thread Tom Rix
On 4/16/22 11:33 AM, Joe Perches wrote: On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote: In insert_mappable_node(), the parameter node is cleared late in node's use with memset. insert_mappable_node() is a singleton, called only from i915_gem_gtt_prepare() which itself is only called by

[PATCH] drm/radeon/kms: change evergreen_default_state table from global to static

2022-04-16 Thread Tom Rix
evergreen_default_state and evergreen_default_size are only used in evergreen.c. Single file symbols should be static. So move their definitions to evergreen_blit_shaders.h and change their storage-class-specifier to static. Remove unneeded evergreen_blit_shader.c evergreen_ps/vs definitions

Re: [PATCH] drm/i915: change node clearing from memset to initialization

2022-04-16 Thread Joe Perches
On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote: > In insert_mappable_node(), the parameter node is > cleared late in node's use with memset. > insert_mappable_node() is a singleton, called only > from i915_gem_gtt_prepare() which itself is only > called by i915_gem_gtt_pread() and >

Re: drm/msm/dsi: fix error checks and return values for DSI xmit functions

2022-04-16 Thread Dmitry Baryshkov
On Sat, 16 Apr 2022 at 12:12, Marijn Suijten wrote: > > Hi Dmitry, > > On 2022-04-02 02:11:04, Dmitry Baryshkov wrote: > > As noticed by Dan ([1] an the followup thread) there are multiple issues > > with the return values for MSM DSI command transmission callback. In > > the error case it can

[PATCH] drm/i915: change node clearing from memset to initialization

2022-04-16 Thread Tom Rix
In insert_mappable_node(), the parameter node is cleared late in node's use with memset. insert_mappable_node() is a singleton, called only from i915_gem_gtt_prepare() which itself is only called by i915_gem_gtt_pread() and i915_gem_gtt_pwrite_fast() where the definition of node originates.

Re: [PATCH 2/2] MAINTAINERS: add docs entry to AMDGPU

2022-04-16 Thread Tales
Hi Bagas Sanjaya, Em sáb., 16 de abr. de 2022 às 02:47, Bagas Sanjaya escreveu: > On 4/16/22 02:50, Tales Lelo da Aparecida wrote: > > To make sure maintainers of amdgpu drivers are aware of any changes > > in their documentation, add its entry to MAINTAINERS. > > > > Did you mean the

[PATCH] drm/amdgpu/powerplay/vega10: fix minmax.cocci warnings

2022-04-16 Thread Julia Lawall
From: kernel test robot Use max to simplify the code. Generated by: scripts/coccinelle/misc/minmax.cocci CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot Signed-off-by: Julia Lawall --- tree:

[drm-intel:for-linux-next-gt 9/9] drivers/gpu/drm/i915/gt/intel_migrate.c:643:2-3: Unneeded semicolon

2022-04-16 Thread kernel test robot
-ci/archive/20220416/202204162238.whnwriag-...@intel.com/config) compiler: gcc-11 (Debian 11.2.0-19) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot cocci warnings: (new ones prefixed by >>) >> drivers/gpu/drm/i915/gt/intel_migra

[PATCH] drm/i915/migrate: fix semicolon.cocci warnings

2022-04-16 Thread kernel test robot
From: kernel test robot drivers/gpu/drm/i915/gt/intel_migrate.c:643:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: da0595ae91da ("drm/i915/migrate: Evict and restore the flatccs capable lmem obj") Reported-by: kernel test

Re: [PATCH V2 3/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195

2022-04-16 Thread Chun-Kuang Hu
Rob Herring 於 2022年4月14日 週四 上午7:02寫道: > > On Mon, 11 Apr 2022 11:58:43 +0800, Rex-BC Chen wrote: > > Disp_aal of MT8192 and MT8195 are fully compatible with disp_aal of > > MT8183. Therefore, we move the them to item "mediatek,mt8183-disp-aal". > > > > Signed-off-by: Rex-BC Chen > > --- > >

Re: [PATCH V2 1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183

2022-04-16 Thread Chun-Kuang Hu
Rob Herring 於 2022年4月14日 週四 上午7:02寫道: > > On Mon, 11 Apr 2022 11:58:41 +0800, Rex-BC Chen wrote: > > The driver data of MT8183 and MT8173 are different. > > > > For MT8173, the gamma module is inside disp_aal. When we need to adjust > > gamma value, we need to use "has_gamma" to control gamma

Re: [PATCH 0/2] Update AMDGPU glossary and MAINTAINERS

2022-04-16 Thread Christian König
Am 15.04.22 um 21:50 schrieb Tales Lelo da Aparecida: I was handling the request from [0] and then I noticed that some AMD developers were missing from get_maintainers output due to the lack of a reference to their documentation in the MAINTAINERS file. Acked-by: Christian König [0]

[Bug 215839] distorted video playback with hybrid GPU (DRI_PRIME=1, Radeon HD 6470M and Intel-GPU)

2022-04-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215839 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 215842] PC freeze sidn kernel 5.17.x

2022-04-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215842 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: drm/msm/dsi: fix error checks and return values for DSI xmit functions

2022-04-16 Thread Marijn Suijten
Hi Dmitry, On 2022-04-02 02:11:04, Dmitry Baryshkov wrote: > As noticed by Dan ([1] an the followup thread) there are multiple issues > with the return values for MSM DSI command transmission callback. In > the error case it can easily return a positive value when it should > have returned a

Re: [PATCH] drm/mipi-dbi: Fix max_chunk calculation in spi_transfer

2022-04-16 Thread Noralf Trønnes
Den 08.03.2022 02.56, skrev Yunhao Tian: > In __spi_validate, there's a validation that no partial transfers > are accepted (xfer->len % w_size must be zero). When > max_chunk is not a multiple of bpw (e.g.max_chunk = 65535, > bpw = 16), the transfer will be rejected. > > This patch clamps

[PATCH] drm/armada: Fix a potential double free in armada_drm_bind

2022-04-16 Thread Miaoqian Lin
priv is a managed resource allocated with devm_drm_dev_alloc(), so there is no need to call kfree() explicitly or there will be a double free. Fixes: 90ad200b4cbc ("drm/armada: Use devm_drm_dev_alloc") Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/armada/armada_drv.c | 1 - 1 file changed, 1