[PATCH] drm/bridge: simplify the return expression of ps8640_bridge_host_attach

2022-04-28 Thread cgel . zte
From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/bridge/parade-ps8640.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c

[PATCH] omapfb: simplify the return expression of nec_8048_connect()

2022-04-28 Thread cgel . zte
From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- .../fbdev/omap2/omapfb/displays/panel-nec-nl8048hl11.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH] drm/amdgpu: simplify the return expression of navi10_ih_hw_init()

2022-04-28 Thread cgel . zte
From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c

[PATCH] drm/vc4: simplify the return expression of vc4_prepare_fb()

2022-04-28 Thread cgel . zte
From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/vc4/vc4_plane.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c index

[PATCH] drm/virtio: simplify the return expression

2022-04-28 Thread cgel . zte
From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/virtio/virtgpu_prime.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_prime.c

[PATCH] drm/amdgpu: simplify the return expression of iceland_ih_hw_init

2022-04-28 Thread cgel . zte
From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/iceland_ih.c

[PATCH] omapfb: simplify the return expression of dsi_init_pll_data()

2022-04-28 Thread cgel . zte
From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c

[PATCH] drm/i915: remove unnecessary spin_lock_irq

2022-04-28 Thread Zhenneng Li
This code will not be called by interrupt handler, so change it to spin_lock. Signed-off-by: Zhenneng Li --- drivers/gpu/drm/i915/i915_scheduler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_scheduler.c

Re: [PATCH v2 4/4] drm/nvdla/uapi: Add UAPI of NVDLA driver

2022-04-28 Thread Cai Huoqing
On 28 4月 22 16:45:06, Thierry Reding wrote: > On Tue, Apr 26, 2022 at 04:23:41PM +0800, Cai Huoqing wrote: > > On 26 4月 22 08:31:05, Christian König wrote: > > > Am 26.04.22 um 08:08 schrieb Cai Huoqing: > > > > The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP > > > > which is

Re: [PATCH v2 0/4] drm/nvdla: Add driver support for NVDLA

2022-04-28 Thread Cai Huoqing
On 28 4月 22 17:35:56, Jon Hunter wrote: > > On 28/04/2022 16:56, Mikko Perttunen wrote: > > On 4/28/22 17:10, Thierry Reding wrote: > > > On Tue, Apr 26, 2022 at 02:07:57PM +0800, Cai Huoqing wrote: > > > > The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP > > > > which is

Re: [PATCH v2 0/4] drm/nvdla: Add driver support for NVDLA

2022-04-28 Thread Cai Huoqing
On 28 4月 22 18:56:07, Mikko Perttunen wrote: > On 4/28/22 17:10, Thierry Reding wrote: > > On Tue, Apr 26, 2022 at 02:07:57PM +0800, Cai Huoqing wrote: > > > The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP > > > which is integrated into NVIDIA Jetson AGX Xavier, > > > so add

[Bug 201991] amdgpu: clock management is disabled for the 4K resolution with polaris 10

2022-04-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201991 dofficialg...@gmail.com changed: What|Removed |Added CC||dofficialg...@gmail.com ---

Re: [PATCH] gpu: drm: remove redundant dma_fence_put() when drm_sched_job_add_dependency() fails

2022-04-28 Thread Hangyu Hua
On 2022/4/28 23:27, Andrey Grodzovsky wrote: On 2022-04-28 04:56, Hangyu Hua wrote: On 2022/4/27 22:43, Andrey Grodzovsky wrote: On 2022-04-26 22:31, Hangyu Hua wrote: On 2022/4/26 22:55, Andrey Grodzovsky wrote: On 2022-04-25 22:54, Hangyu Hua wrote: On 2022/4/25 23:42, Andrey

Re: [PATCH v5 3/5] drm/msm/dp: set stream_pixel rate directly

2022-04-28 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-16 21:55:27) > The only clock for which we set the rate is the "stream_pixel". Rather > than storing the rate and then setting it by looping over all the > clocks, set the clock rate directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [git pull] drm fixes for 5.18-rc5

2022-04-28 Thread pr-tracker-bot
The pull request you sent on Fri, 29 Apr 2022 10:50:25 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-04-29 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/38d741cb70b30741c0e802cbed7bd9cf4fd15fa4 Thank you! -- Deet-doot-dot, I am a bot.

Re: linux-next: manual merge of the amdgpu tree with the drm-misc tree

2022-04-28 Thread Stephen Rothwell
Hi all, On Wed, 13 Apr 2022 10:10:14 +1000 Stephen Rothwell wrote: > > On Wed, 6 Apr 2022 10:34:05 +1000 Stephen Rothwell > wrote: > > > > Today's linux-next merge of the amdgpu tree got a conflict in: > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > > > > between commit: > > > >

linux-next: manual merge of the amdgpu tree with the drm tree

2022-04-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the amdgpu tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c between commit: 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") from the drm tree and commit: 3da2c38231a4 ("drm/amdgpu: Free user pages if

[git pull] drm fixes for 5.18-rc5

2022-04-28 Thread Dave Airlie
Hi Linus, Another relatively quiet week, amdgpu leads the way, some i915 display fixes, and a single sunxi fix. Regards, Dave. drm-fixes-2022-04-29: drm fixes for 5.18-rc5 amdgpu: - Runtime pm fix - DCN memory leak fix in error path - SI DPM deadlock fix - S0ix fix amdkfd: - GWS fix - GWS

Re: [PATCH 1/4] drm/etnaviv: Use scheduler dependency handling

2022-04-28 Thread Michael Walle
> We need to pull the drm_sched_job_init much earlier, but that's very > minor surgery. This patch breaks the GC7000 on the LS1028A: [ 35.671102] Unable to handle kernel NULL pointer dereference at virtual address 0078 [ 35.680925] Mem abort info: [ 35.685127] ESR =

Re: [PATCH v4] drm/bridge: tc358767: Fix (e)DP bridge endpoint parsing in dedicated function

2022-04-28 Thread Marek Vasut
On 4/28/22 23:31, Marek Vasut wrote: Per toshiba,tc358767.yaml DT binding document, port@2 the output (e)DP port is optional. In case this port is not described in DT, the bridge driver operates in DPI-to-DP mode. The drm_of_find_panel_or_bridge() call in tc_probe_edp_bridge_endpoint() returns

Re: [PATCH 2/2] Revert "drm: of: Lookup if child node has panel or bridge"

2022-04-28 Thread Laurent Pinchart
Hi Jagan, On Thu, Apr 28, 2022 at 02:09:42PM +0530, Jagan Teki wrote: > On Wed, Apr 27, 2022 at 8:04 PM Maxime Ripard wrote: > > On Tue, Apr 26, 2022 at 01:40:31PM +0530, Jagan Teki wrote: > > > On Tue, Apr 26, 2022 at 1:24 PM Paul Kocialkowski wrote: > > > > On Thu 21 Apr 22, 10:59, Paul

Re: [PATCH v5 3/5] drm/msm/dp: set stream_pixel rate directly

2022-04-28 Thread Dmitry Baryshkov
On Fri, 29 Apr 2022 at 00:49, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-04-19 09:34:18) > > On 08/03/2022 23:46, Stephen Boyd wrote: > > > > > > Yes that's my concern. The qmp phy driver has a couple clk_set_rate() > > > calls in the .configure_dp_phy callback. That is called from >

Re: [PATCH v5 3/5] drm/msm/dp: set stream_pixel rate directly

2022-04-28 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-19 09:34:18) > On 08/03/2022 23:46, Stephen Boyd wrote: > > > > Yes that's my concern. The qmp phy driver has a couple clk_set_rate() > > calls in the .configure_dp_phy callback. That is called from > > phy_power_on() (see qcom_qmp_phy_power_on() and

Re: [PULL] gvt-next

2022-04-28 Thread Alex Williamson
On Thu, 28 Apr 2022 15:35:58 -0600 Alex Williamson wrote: > On Tue, 26 Apr 2022 08:52:58 -0300 > Jason Gunthorpe wrote: > > > On Tue, Apr 26, 2022 at 08:42:25AM +, Wang, Zhi A wrote: > > > On 4/26/22 8:37 AM, Jani Nikula wrote: > > > > On Tue, 26 Apr 2022, "Wang, Zhi A" wrote: >

Re: [PULL] gvt-next

2022-04-28 Thread Alex Williamson
On Tue, 26 Apr 2022 08:52:58 -0300 Jason Gunthorpe wrote: > On Tue, Apr 26, 2022 at 08:42:25AM +, Wang, Zhi A wrote: > > On 4/26/22 8:37 AM, Jani Nikula wrote: > > > On Tue, 26 Apr 2022, "Wang, Zhi A" wrote: > > >> Hi folks: > > >> > > >> Here is the pull of gvt-next which fixs the

Re: [PATCH v2] drm/msm/dpu: remove unused refcount for encoder_phys_wb

2022-04-28 Thread Dmitry Baryshkov
On 28/04/2022 21:15, Abhinav Kumar wrote: Remove the unused local variable refcount for encoder_phys_wb as the one part of wb_enc is used directly. changes in v2: - remove usage of ret variable also - remove the if (ret) code as it was dead-code anyway Fixes: 0ce51f19453e

[PATCH v4] drm/bridge: tc358767: Fix (e)DP bridge endpoint parsing in dedicated function

2022-04-28 Thread Marek Vasut
Per toshiba,tc358767.yaml DT binding document, port@2 the output (e)DP port is optional. In case this port is not described in DT, the bridge driver operates in DPI-to-DP mode. The drm_of_find_panel_or_bridge() call in tc_probe_edp_bridge_endpoint() returns -ENODEV in case port@2 is not present in

[PULL] gvt-next-2022-04-29

2022-04-28 Thread Wang, Zhi A
Hi folks: Here is the pull of gvt-next which fixes the compilation error and warnings for the the GVT-g refactor patches: - Fix a compiling warning of non-static function only having one caller. - Fix a potential NULL pointer reference in the code re-factor. - Fix a compiling error when

Re: [PATCH v5 1/4] dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml

2022-04-28 Thread Rob Herring
On Thu, 28 Apr 2022 21:37:50 +0800, Rex-BC Chen wrote: > From: Xinlei Lee > > Convert mediatek,dsi.txt to mediatek,dsi.yaml format > > Signed-off-by: Xinlei Lee > Signed-off-by: Rex-BC Chen > --- > .../display/mediatek/mediatek,dsi.txt | 62 - >

[PATCH v5 6/6] drm/i915: stolen memory use ttm backend

2022-04-28 Thread Robert Beckett
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 +-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 -

[PATCH v5 5/6] drm/i915: allow memory region creators to alloc and free the region

2022-04-28 Thread Robert Beckett
add callbacks for alloc and free. this allows region creators to allocate any extra storage they may require. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/intel_memory_region.c | 16 +--- drivers/gpu/drm/i915/intel_memory_region.h | 2 ++ 2 files changed, 15

[PATCH v5 4/6] drm/i915: ttm backend dont provide mmap_offset for kernel buffers

2022-04-28 Thread Robert Beckett
stolen/kernel buffers should not be mmapable by userland. do not provide callbacks to facilitate this for these buffers. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 32 + 1 file changed, 27 insertions(+), 5 deletions(-) diff --git

[PATCH v5 3/6] drm/i915: ttm move/clear logic fix

2022-04-28 Thread Robert Beckett
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that

[PATCH v5 2/6] drm/i915: sanitize mem_flags for stolen buffers

2022-04-28 Thread Robert Beckett
Stolen regions are not page backed or considered iomem. Prevent flags indicating such. This correctly prevents stolen buffers from attempting to directly map them. See i915_gem_object_has_struct_page() and i915_gem_object_has_iomem() usage for where it would break otherwise. Signed-off-by:

[PATCH v5 1/6] drm/i915: instantiate ttm ranger manager for stolen memory

2022-04-28 Thread Robert Beckett
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31

[PATCH v5 0/6] drm/i915: ttm for stolen region

2022-04-28 Thread Robert Beckett
This series refactors i915's stolen memory region to use ttm. v2: handle disabled stolen similar to legacy version. relying on ttm to fail allocs works fine, but is dmesg noisy and causes testing dmesg warning regressions. v3: rebase to latest drm-tip. fix v2

Re: How should "max bpc" KMS property work?

2022-04-28 Thread Sebastian Wick
On Thu, Apr 28, 2022 at 4:50 PM Ville Syrjälä wrote: > > On Thu, Apr 28, 2022 at 07:52:58AM +, Simon Ser wrote: > > On Thursday, April 28th, 2022 at 09:50, Pekka Paalanen > > wrote: > > > > > > > > Also like Alex said, the kernel does not know if the user prefers > > > > > > high > > > > >

Re: [PATCH v5 01/17] drm/panfrost: Put mapping instead of shmem obj on panfrost_mmu_map_fault_addr() error

2022-04-28 Thread Dmitry Osipenko
28.04.2022 16:19, Steven Price пишет: > On 24/04/2022 20:04, Dmitry Osipenko wrote: >> When panfrost_mmu_map_fault_addr() fails, the BO's mapping should be >> unreferenced and not the shmem object that backs that mapping. >> >> Cc: sta...@vger.kernel.org >> Signed-off-by: Dmitry Osipenko > >

Re: [PATCH v5 15/17] drm/shmem-helper: Make drm_gem_shmem_get_pages() private

2022-04-28 Thread Dmitry Osipenko
28.04.2022 15:33, Daniel Vetter пишет: > On Sun, Apr 24, 2022 at 10:04:22PM +0300, Dmitry Osipenko wrote: >> VirtIO-GPU driver was the only user of drm_gem_shmem_get_pages() >> and it now uses drm_gem_shmem_get_pages_sgt(). Make the get_pages() >> private to drm_gem_shmem_helper. >> >>

Re: [PATCH v4 10/15] drm/shmem-helper: Take reservation lock instead of drm_gem_shmem locks

2022-04-28 Thread Dmitry Osipenko
Hello Daniel, 27.04.2022 17:50, Daniel Vetter пишет: > On Mon, Apr 18, 2022 at 10:18:54PM +0300, Dmitry Osipenko wrote: >> Hello, >> >> On 4/18/22 21:38, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: Replace drm_gem_shmem locks with the reservation

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-04-28 Thread Dmitry Osipenko
27.04.2022 18:03, Daniel Vetter wrote: >> ... @@ -172,6 +172,41 @@ struct drm_gem_object_funcs {    * This is optional but necessary for mmap support.    */   const struct vm_operations_struct *vm_ops; + +    /** + * @purge: + * +

Re: [PATCH] gpu/drm/radeon: Fix spelling typo in comments

2022-04-28 Thread Alex Deucher
On Thu, Apr 28, 2022 at 3:37 AM pengfuyuan wrote: > > Fix spelling typo in comments. > > Signed-off-by: pengfuyuan > --- > drivers/gpu/drm/radeon/atombios.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/atombios.h >

[PATCH v2] drm/msm/dpu: remove unused refcount for encoder_phys_wb

2022-04-28 Thread Abhinav Kumar
Remove the unused local variable refcount for encoder_phys_wb as the one part of wb_enc is used directly. changes in v2: - remove usage of ret variable also - remove the if (ret) code as it was dead-code anyway Fixes: 0ce51f19453e ("drm/msm/dpu: introduce the dpu_encoder_phys_*

Re: [PATCH] drm/bridge: tfp410: Make tfp410_fini() return void

2022-04-28 Thread Laurent Pinchart
Hi Uwe, Thank you for the patch. On Thu, Apr 28, 2022 at 06:28:03PM +0200, Uwe Kleine-König wrote: > tfp410_fini() always returns zero. Make it return no value which makes it > easier to see in the callers that there is no error to handle. > > Also the return value of i2c and platform driver

Re: [PATCH v3] drm/display: Select DP helper for DRM_DP_AUX_CHARDEV and DRM_DP_CEC

2022-04-28 Thread Lyude Paul
Reviewed-by: Lyude Paul On Thu, 2022-04-28 at 10:22 +0200, Javier Martinez Canillas wrote: > The DRM_DP_AUX_CHARDEV and DRM_DP_CEC Kconfig symbols enable code that use > DP helper functions, that are only present if CONFIG_DRM_DISPLAY_DP_HELPER > is also enabled. > > But these don't select the

Re: [PATCH] drm/msm/dpu: remove unused refcount for encoder_phys_wb

2022-04-28 Thread Abhinav Kumar
On 4/28/2022 8:58 AM, Dmitry Baryshkov wrote: On 28/04/2022 18:34, Abhinav Kumar wrote: Remove the unused local variable refcount for encoder_phys_wb as the one part of wb_enc is used directly. Fixes: 0ce51f19453e ("drm/msm/dpu: introduce the dpu_encoder_phys_* for writeback")

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-28 Thread Guenter Roeck
On 4/28/22 06:44, Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 8:48 PM Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 5:28 PM Guenter Roeck wrote: On 4/24/22 01:52, Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 4:09 AM Guenter Roeck wrote: into the defconfig file, otherwise the multiplatform

Re: [PATCH] drm/dp_mst: Lower down debug info level when receive NAK

2022-04-28 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to drm-misc-next in a bit On Thu, 2022-04-28 at 20:49 +0800, Wayne Lin wrote: > [Why] > It's reasonable that we receive NAK while doing DP_REMOTE_DPCD_READ. > Downstream device might reply NAK with the reason and source should > react accordingly. > > e.g. >

Re: [PATCH v2 0/4] drm/nvdla: Add driver support for NVDLA

2022-04-28 Thread Jon Hunter
On 28/04/2022 16:56, Mikko Perttunen wrote: On 4/28/22 17:10, Thierry Reding wrote: On Tue, Apr 26, 2022 at 02:07:57PM +0800, Cai Huoqing wrote: The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP which is integrated into NVIDIA Jetson AGX Xavier, so add driver support for this

[PATCH] drm/bridge: tfp410: Make tfp410_fini() return void

2022-04-28 Thread Uwe Kleine-König
tfp410_fini() always returns zero. Make it return no value which makes it easier to see in the callers that there is no error to handle. Also the return value of i2c and platform driver remove callbacks is ignored anyway. This prepares making i2c and platform remove callbacks return void, too.

Re: [PATCH] drm/msm/dpu: remove unused refcount for encoder_phys_wb

2022-04-28 Thread Dmitry Baryshkov
On 28/04/2022 18:34, Abhinav Kumar wrote: Remove the unused local variable refcount for encoder_phys_wb as the one part of wb_enc is used directly. Fixes: 0ce51f19453e ("drm/msm/dpu: introduce the dpu_encoder_phys_* for writeback") Reported-by: kernel test robot Signed-off-by: Abhinav Kumar

Re: [PATCH] drm/bridge: fix anx6345 power up sequence

2022-04-28 Thread Torsten Duwe
On Mon, 18 Apr 2022 17:25:57 -0700 Vasily Khoruzhick wrote: > On Sun, Apr 17, 2022 at 11:52 AM Vasily Khoruzhick > wrote: > > The change looks good to me, but I'll need some time to actually > > test it. If you don't hear from me for longer than a week please > > ping me. > > Your change

Re: [PATCH v2 0/4] drm/nvdla: Add driver support for NVDLA

2022-04-28 Thread Mikko Perttunen
On 4/28/22 17:10, Thierry Reding wrote: On Tue, Apr 26, 2022 at 02:07:57PM +0800, Cai Huoqing wrote: The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP which is integrated into NVIDIA Jetson AGX Xavier, so add driver support for this accelerator." Hi, nice to see this work

[PATCH] drm/msm/dpu: remove unused refcount for encoder_phys_wb

2022-04-28 Thread Abhinav Kumar
Remove the unused local variable refcount for encoder_phys_wb as the one part of wb_enc is used directly. Fixes: 0ce51f19453e ("drm/msm/dpu: introduce the dpu_encoder_phys_* for writeback") Reported-by: kernel test robot Signed-off-by: Abhinav Kumar ---

Re: [PATCH] gpu: drm: remove redundant dma_fence_put() when drm_sched_job_add_dependency() fails

2022-04-28 Thread Andrey Grodzovsky
On 2022-04-28 04:56, Hangyu Hua wrote: On 2022/4/27 22:43, Andrey Grodzovsky wrote: On 2022-04-26 22:31, Hangyu Hua wrote: On 2022/4/26 22:55, Andrey Grodzovsky wrote: On 2022-04-25 22:54, Hangyu Hua wrote: On 2022/4/25 23:42, Andrey Grodzovsky wrote: On 2022-04-25 04:36, Hangyu Hua

Re: [PATCH v2 2/4] drm/nvdla: Add driver support for NVDLA

2022-04-28 Thread Thierry Reding
On Thu, Apr 28, 2022 at 05:18:13PM +0200, Thierry Reding wrote: > On Tue, Apr 26, 2022 at 02:07:59PM +0800, Cai Huoqing wrote: > [...] > > diff --git a/drivers/gpu/drm/nvdla/nvdla_drv.c > > b/drivers/gpu/drm/nvdla/nvdla_drv.c > > I'll look at this from an architectural level and leave it to

Re: [PATCH v2 2/4] drm/nvdla: Add driver support for NVDLA

2022-04-28 Thread Thierry Reding
On Tue, Apr 26, 2022 at 02:07:59PM +0800, Cai Huoqing wrote: [...] > diff --git a/drivers/gpu/drm/nvdla/nvdla_drv.c > b/drivers/gpu/drm/nvdla/nvdla_drv.c I'll look at this from an architectural level and leave it to other experts to review the more technical things. [...] > +static struct

Re: [PATCH] drm/plane: Move range check for format_count earlier

2022-04-28 Thread Liviu Dudau
On Thu, Apr 28, 2022 at 12:57:52PM +0100, Steven Price wrote: > On 03/12/2021 13:08, Liviu Dudau wrote: > > On Fri, Dec 03, 2021 at 10:28:15AM +, Steven Price wrote: > >> While the check for format_count > 64 in __drm_universal_plane_init() > >> shouldn't be hit (it's a WARN_ON), in its

Re: How should "max bpc" KMS property work?

2022-04-28 Thread Ville Syrjälä
On Thu, Apr 28, 2022 at 07:52:58AM +, Simon Ser wrote: > On Thursday, April 28th, 2022 at 09:50, Pekka Paalanen > wrote: > > > > > > Also like Alex said, the kernel does not know if the user prefers high > > > > > color depth or high refresh rate either. One way to solve that is to > > > >

Re: [PATCH v2 4/4] drm/nvdla/uapi: Add UAPI of NVDLA driver

2022-04-28 Thread Thierry Reding
On Tue, Apr 26, 2022 at 04:23:41PM +0800, Cai Huoqing wrote: > On 26 4月 22 08:31:05, Christian König wrote: > > Am 26.04.22 um 08:08 schrieb Cai Huoqing: > > > The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP > > > which is integrated into NVIDIA Jetson AGX Xavier, > > > so add

Re: [PATCH v2 4/4] drm/nvdla/uapi: Add UAPI of NVDLA driver

2022-04-28 Thread Thierry Reding
On Tue, Apr 26, 2022 at 02:08:01PM +0800, Cai Huoqing wrote: > The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP > which is integrated into NVIDIA Jetson AGX Xavier, > so add UAPI of this driver. > > Signed-off-by: Cai Huoqing > --- > v1->v2: > *Rename nvdla_drm.[ch] to

Re: [PATCH] video: hyperv_fb: Allow resolutions with size > 64 MB for Gen1

2022-04-28 Thread Wei Liu
On Wed, Apr 27, 2022 at 06:47:53AM -0700, Saurabh Sengar wrote: > This patch fixes a bug where GEN1 VMs doesn't allow resolutions greater > than 64 MB size (eg 7680x4320). Unnecessary PCI check limits Gen1 VRAM > to legacy PCI BAR size only (ie 64MB). Thus any, resolution requesting > greater then

Re: [PATCH v2 3/4] drm/nvdla: Add register head file of NVDLA

2022-04-28 Thread Thierry Reding
On Tue, Apr 26, 2022 at 02:08:00PM +0800, Cai Huoqing wrote: > The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP > which is integrated into NVIDIA Jetson AGX Xavier, > so add register head file of this accelerator. > > Signed-off-by: Cai Huoqing > --- >

Re: [PATCH v2 0/4] drm/nvdla: Add driver support for NVDLA

2022-04-28 Thread Thierry Reding
On Tue, Apr 26, 2022 at 02:07:57PM +0800, Cai Huoqing wrote: > The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP > which is integrated into NVIDIA Jetson AGX Xavier, > so add driver support for this accelerator." Hi, nice to see this work going on. For subsequent revisions, can

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-28 Thread Arnd Bergmann
On Sun, Apr 24, 2022 at 8:48 PM Arnd Bergmann wrote: > On Sun, Apr 24, 2022 at 5:28 PM Guenter Roeck wrote: > > On 4/24/22 01:52, Arnd Bergmann wrote: > > > On Sun, Apr 24, 2022 at 4:09 AM Guenter Roeck wrote: > > > into the defconfig file, otherwise the multiplatform target defaults to > > >

Re: [PATCH v4, 1/1] drm/mediatek: add lut diff flag for new gamma hardware support

2022-04-28 Thread AngeloGioacchino Del Regno
Il 28/04/22 10:58, Yongqiang Niu ha scritto: From: Yongqiang Niu mt8183 gamma module usage is different with before soc, gamma odd(index start from 0) lut value set to hardware register should be the difference of current lut value with last lut value. for example, chrome os user space set

Re: [PATCH v5 01/17] drm/panfrost: Put mapping instead of shmem obj on panfrost_mmu_map_fault_addr() error

2022-04-28 Thread Steven Price
On 24/04/2022 20:04, Dmitry Osipenko wrote: > When panfrost_mmu_map_fault_addr() fails, the BO's mapping should be > unreferenced and not the shmem object that backs that mapping. > > Cc: sta...@vger.kernel.org > Signed-off-by: Dmitry Osipenko Fixes: bdefca2d8dc0 ("drm/panfrost: Add the

[PATCH 4/4] MAINTAINERS: Add entries for Toshiba Visconti DNN image processing accelerator

2022-04-28 Thread Yuji Ishikawa
--- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dd36acc87..a2e2bd719 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2796,12 +2796,14 @@ F: Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.yaml F:

[PATCH 3/4] soc: visconti: Add Toshiba Visconti DNN image processing accelerator

2022-04-28 Thread Yuji Ishikawa
Add support to DNN image processing accelerator on Toshiba Visconti ARM SoCs. The accelerator is applicable to DNN inference tasks. Signed-off-by: Yuji Ishikawa Reviewed-by: Nobuhiro Iwamatsu --- drivers/soc/visconti/Kconfig | 6 + drivers/soc/visconti/Makefile | 2 +

[PATCH 2/4] soc: visconti: Add Toshiba Visconti image processing accelerator common source

2022-04-28 Thread Yuji Ishikawa
This commit adds common definitions shared among image processing accelerator drivers for Toshiba Visconti SoCs. Signed-off-by: Yuji Ishikawa Reviewed-by: Nobuhiro Iwamatsu --- drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/visconti/Kconfig

[PATCH 1/4] dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing accelerator bindings

2022-04-28 Thread Yuji Ishikawa
This commit adds the Device Tree binding documentation that allows to describe the DNN image processing accelerator found in Toshiba Visconti SoCs. Signed-off-by: Yuji Ishikawa Reviewed-by: Nobuhiro Iwamatsu --- .../soc/visconti/toshiba,visconti-dnn.yaml| 54 +++ 1 file

[PATCH 0/4] Add Toshiba Visconti DNN image processing accelerator driver

2022-04-28 Thread Yuji Ishikawa
This series is the DNN image processing accelerator driver for Toshiba's ARM SoC, Visconti[0]. This provides DT binding documentation, device driver, MAINTAINER files. The second patch "soc: visconti: Add Toshiba Visconti image processing accelerator common source" and the fourth patch

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/xehp: Add compute engine ABI

2022-04-28 Thread Andi Shyti
Hi Matt, On Wed, Apr 27, 2022 at 09:19:25PM -0700, Matt Roper wrote: > We're now ready to start exposing compute engines to userspace. > > v2: > - Move kerneldoc for other engine classes to a separate patch. (Andi) > > Cc: Daniele Ceraolo Spurio > Cc: Tvrtko Ursulin > Cc: Vinay Belgaumkar

Re: [PATCH v2 1/4] drm/i915/uapi: Add kerneldoc for engine class enum

2022-04-28 Thread Andi Shyti
Hi Matt, On Wed, Apr 27, 2022 at 09:19:23PM -0700, Matt Roper wrote: > We'll be adding a new type of engine soon. Let's document the existing > engine classes first to help make it clear what each type of engine is > used for. > > Cc: Andi Shyti > Signed-off-by: Matt Roper Reviewed-by: Andi

[PATCH] drm/dp_mst: Lower down debug info level when receive NAK

2022-04-28 Thread Wayne Lin
[Why] It's reasonable that we receive NAK while doing DP_REMOTE_DPCD_READ. Downstream device might reply NAK with the reason and source should react accordingly. e.g. 1. When downstream device can't handle corresponding message in time, it then replies NAK as reason been set as DEFER. 2. When

Re: [PATCH v5 15/17] drm/shmem-helper: Make drm_gem_shmem_get_pages() private

2022-04-28 Thread Daniel Vetter
On Sun, Apr 24, 2022 at 10:04:22PM +0300, Dmitry Osipenko wrote: > VirtIO-GPU driver was the only user of drm_gem_shmem_get_pages() > and it now uses drm_gem_shmem_get_pages_sgt(). Make the get_pages() > private to drm_gem_shmem_helper. > > Signed-off-by: Dmitry Osipenko > --- >

Re: [RFC v2 1/2] drm/doc/rfc: VM_BIND feature design document

2022-04-28 Thread Daniel Vetter
On Wed, Apr 27, 2022 at 08:41:35AM -0700, Niranjana Vishwanathapura wrote: > On Wed, Apr 20, 2022 at 03:45:25PM -0700, Niranjana Vishwanathapura wrote: > > On Thu, Mar 31, 2022 at 10:28:48AM +0200, Daniel Vetter wrote: > > > Adding a pile of people who've expressed interest in vm_bind for their >

Re: [PATCH] drm: handle kernel fences in drm_gem_plane_helper_prepare_fb

2022-04-28 Thread Daniel Vetter
On Thu, Apr 28, 2022 at 08:41:28AM +0200, Christian König wrote: > Am 27.04.22 um 18:03 schrieb Daniel Vetter: > > On Thu, Apr 21, 2022 at 09:10:02PM +0200, Christian König wrote: > > > drm_gem_plane_helper_prepare_fb() was using > > > drm_atomic_set_fence_for_plane() which ignores all implicit

[PATCH] drm/sun4i: dsi: delete unnecessary IS_ERR() checks

2022-04-28 Thread Dan Carpenter
The "dsi->bus_clk" pointer cannot be an error pointer at this point. The check is confusing and unnecessary. Delete it. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 5/5] drm/i915/sseu: Disassociate internal subslice mask representation from uapi

2022-04-28 Thread Tvrtko Ursulin
Hi, On 28/04/2022 00:07, Matt Roper wrote: Rather than storing subslice masks internally as u8[] (inside the sseu structure) and u32 (everywhere else), let's move over to using an intel_sseu_ss_mask_t typedef compatible with the operations in linux/bitmap.h. We're soon going to start adding

Re: [PATCH] drm: exynos: dsi: Use child panel or bridge find helpers

2022-04-28 Thread Maxime Ripard
On Thu, Apr 28, 2022 at 03:18:08PM +0530, Jagan Teki wrote: > commit <711c7adc4687> ("drm: exynos: dsi: Use drm panel_bridge API") > added devm_drm_of_get_bridge for looking up if child node has panel > or bridge. > > However commit ("Revert "drm: of: Lookup if child node > has panel or bridge")

Re: [PATCH v2 2/4] drm/i915/xehp: Add register for compute engine's MMIO-based TLB invalidation

2022-04-28 Thread Kumar Valsan, Prathap
On Wed, Apr 27, 2022 at 09:19:24PM -0700, Matt Roper wrote: > Compute engines have a separate register that the driver should use to > perform MMIO-based TLB invalidation. > > Note that the term "context" in this register's bspec description is > used to refer to the engine instance (in the same

Re: dim question: How to revert patches?

2022-04-28 Thread Daniel Vetter
On Wed, Apr 27, 2022 at 09:20:59PM +0200, Helge Deller wrote: > Hi Daniel, > > On 4/27/22 16:21, Daniel Vetter wrote: > > On Thu, Apr 14, 2022 at 10:37:55PM +0200, Helge Deller wrote: > >> Hello dri-devel & dim users, > > > > Apologies for late reply, I'm way behind on stuff. > > > >> I committed

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-28 Thread Daniel Vetter
On Thu, Apr 28, 2022 at 10:08:47AM +0200, Maxime Ripard wrote: > Hi Daniel, > > On Wed, Apr 13, 2022 at 01:20:11PM +0200, Daniel Vetter wrote: > > On Wed, 13 Apr 2022 at 01:36, Abhinav Kumar > > wrote: > > > On 4/8/2022 9:04 PM, Abhinav Kumar wrote: > > > > > > > > > > > > On 4/7/2022 4:12 PM,

Re: [RFC PATCH 0/3] i915 writeback private framework

2022-04-28 Thread Laurent Pinchart
Hi Suraj, On Thu, Apr 28, 2022 at 05:51:47AM +, Kandpal, Suraj wrote: > ++Laurent ,Dmitry, and Abhinav > > Hi, > Can you have a look at the private implementation i915 is currently going > with till > we can figure out how to work with drm core . No, sorry, I barely have time to follow up

Re: [PATCH] drm/plane: Move range check for format_count earlier

2022-04-28 Thread Steven Price
On 03/12/2021 13:08, Liviu Dudau wrote: > On Fri, Dec 03, 2021 at 10:28:15AM +, Steven Price wrote: >> While the check for format_count > 64 in __drm_universal_plane_init() >> shouldn't be hit (it's a WARN_ON), in its current position it will then >> leak the plane->format_types array and fail

Re: [RFC v2 1/2] drm/vrr: Attach vrr_enabled property to the drm crtc

2022-04-28 Thread Modem, Bhanuprakash
On Wed-27-04-2022 03:31 am, Navare, Manasi wrote: On Mon, Apr 25, 2022 at 12:16:11PM +0530, Bhanuprakash Modem wrote: Modern display hardware is capable of supporting variable refresh rates. This patch introduces helpers to attach and set "vrr_enabled" property on the crtc to allow userspace to

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-04-28 Thread Tvrtko Ursulin
On 28/04/2022 11:25, Matthew Auld wrote: On 28/04/2022 09:55, Tvrtko Ursulin wrote: On 27/04/2022 18:36, Matthew Auld wrote: On 27/04/2022 09:36, Tvrtko Ursulin wrote: On 20/04/2022 18:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2:    - Some

Re: [PATCH] drm: exynos: dsi: Use child panel or bridge find helpers

2022-04-28 Thread Marek Szyprowski
On 28.04.2022 11:48, Jagan Teki wrote: > commit <711c7adc4687> ("drm: exynos: dsi: Use drm panel_bridge API") > added devm_drm_of_get_bridge for looking up if child node has panel > or bridge. > > However commit ("Revert "drm: of: Lookup if child node > has panel or bridge") has reverted panel or

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-04-28 Thread Matthew Auld
On 28/04/2022 09:55, Tvrtko Ursulin wrote: On 27/04/2022 18:36, Matthew Auld wrote: On 27/04/2022 09:36, Tvrtko Ursulin wrote: On 20/04/2022 18:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2:    - Some spelling fixes and other small tweaks. (Akeem &

RE: [RFC PATCH 1/3] drm/i915: Creating writeback pipeline to bypass drm_writeback framework

2022-04-28 Thread Kandpal, Suraj
++Laurent ,Dmitry, and Abhinav > Changes to create a i915 private pipeline to enable the WD transcoder > without relying on the current drm_writeback framework. > > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/Makefile | 1 + >

Re: [PATCH] drm: handle kernel fences in drm_gem_plane_helper_prepare_fb v2

2022-04-28 Thread Thomas Zimmermann
Hi Am 28.04.22 um 11:40 schrieb Christian König: drm_gem_plane_helper_prepare_fb() was using drm_atomic_set_fence_for_plane() which ignores all implicit fences when an explicit fence is already set. That's rather unfortunate when the fb still has a kernel fence we need to wait for to avoid

Re: [PATCH v3] drm/display: Select DP helper for DRM_DP_AUX_CHARDEV and DRM_DP_CEC

2022-04-28 Thread Thomas Zimmermann
Hi Am 28.04.22 um 11:11 schrieb Javier Martinez Canillas: On 4/28/22 10:42, Thomas Zimmermann wrote: Hi [snip] drivers/gpu/drm/display/Kconfig | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig

[PATCH] drm: exynos: dsi: Use child panel or bridge find helpers

2022-04-28 Thread Jagan Teki
commit <711c7adc4687> ("drm: exynos: dsi: Use drm panel_bridge API") added devm_drm_of_get_bridge for looking up if child node has panel or bridge. However commit ("Revert "drm: of: Lookup if child node has panel or bridge") has reverted panel or bridge child node lookup from

Re: [PATCH v3 1/5] fbdev: Put mmap for deferred I/O into drivers

2022-04-28 Thread Dan Carpenter
Hi Thomas, url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/fbdev-Decouple-deferred-I-O-from-struct-page/20220426-200655 base: 0e7deff6446a4ba2c75f499a0bfa80cd6a15c129 config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220428/202204280832.sghcydgq

[PATCH] drm: handle kernel fences in drm_gem_plane_helper_prepare_fb v2

2022-04-28 Thread Christian König
drm_gem_plane_helper_prepare_fb() was using drm_atomic_set_fence_for_plane() which ignores all implicit fences when an explicit fence is already set. That's rather unfortunate when the fb still has a kernel fence we need to wait for to avoid presenting garbage on the screen. So instead update the

Re: [PATCH v3] drm/display: Select DP helper for DRM_DP_AUX_CHARDEV and DRM_DP_CEC

2022-04-28 Thread Javier Martinez Canillas
On 4/28/22 10:42, Thomas Zimmermann wrote: > Hi > [snip] >> drivers/gpu/drm/display/Kconfig | 6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/display/Kconfig >> b/drivers/gpu/drm/display/Kconfig >> index f84f1b0cd23f..1b6e6af37546 100644 >>

Re: [PATCH] gpu: drm: remove redundant dma_fence_put() when drm_sched_job_add_dependency() fails

2022-04-28 Thread Hangyu Hua
On 2022/4/27 22:43, Andrey Grodzovsky wrote: On 2022-04-26 22:31, Hangyu Hua wrote: On 2022/4/26 22:55, Andrey Grodzovsky wrote: On 2022-04-25 22:54, Hangyu Hua wrote: On 2022/4/25 23:42, Andrey Grodzovsky wrote: On 2022-04-25 04:36, Hangyu Hua wrote: When drm_sched_job_add_dependency()

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-04-28 Thread Tvrtko Ursulin
On 27/04/2022 18:36, Matthew Auld wrote: On 27/04/2022 09:36, Tvrtko Ursulin wrote: On 20/04/2022 18:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2:    - Some spelling fixes and other small tweaks. (Akeem & Thomas)    - Rework error capture

Re: [PATCH v3] drm/display: Select DP helper for DRM_DP_AUX_CHARDEV and DRM_DP_CEC

2022-04-28 Thread Thomas Zimmermann
Hi Am 28.04.22 um 10:22 schrieb Javier Martinez Canillas: The DRM_DP_AUX_CHARDEV and DRM_DP_CEC Kconfig symbols enable code that use DP helper functions, that are only present if CONFIG_DRM_DISPLAY_DP_HELPER is also enabled. But these don't select the DRM_DISPLAY_DP_HELPER symbol, meaning that

  1   2   >