Re: [PATCH] MAINTAINERS: add Melissa to V3D maintainers

2022-05-01 Thread Iago Toral
Acked-by: Iago Toral Quiroga On Fri, 2022-04-29 at 18:33 -0100, Melissa Wen wrote: > I've been contributing to v3d through improvements, reviews, testing, > debugging, etc. So, I'm adding myself as a co-maintainer of the V3D > driver. > > Signed-off-by: Melissa Wen > --- > MAINTAINERS | 1 + >

[PATCH 3/3] drm/i915: Enabling WD Transcoder

2022-05-01 Thread Suraj Kandpal
Adding support for writeback transcoder to start capturing frames using interrupt mechanism Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_acpi.c | 1 + drivers/gpu/drm/i915/display/intel_display.c | 89 +-

[PATCH 2/3] drm/i915: Define WD trancoder for i915

2022-05-01 Thread Suraj Kandpal
Adding WD Types, WD transcoder to enum list and WD Transcoder offsets Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display.h | 6 ++ drivers/gpu/drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/i915_reg.h| 2 ++ 3 files

[PATCH 1/3] drm/i915: Creating writeback pipeline to bypass drm_writeback framework

2022-05-01 Thread Suraj Kandpal
Changes to create a i915 private pipeline to enable the WD transcoder without relying on the current drm_writeback framework. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/display/intel_display_types.h| 4 +

[PATCH 0/3] i915 private writeback framework

2022-05-01 Thread Suraj Kandpal
A patch series was floated in the drm mailing list which aimed to change the drm_connector and drm_encoder fields to pointer in the drm_connector_writeback structure, this received a huge pushback from the community but since i915 expects each connector present in the drm_device list to be a

[PATCH] drm/msm/dpu: add missing break statement for update_pending_flush_wb()

2022-05-01 Thread Abhinav Kumar
Add missing break statement for dpu_hw_ctl_update_pending_flush_wb(). Otherwise this leads to below build warning. drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c:273:2: warning: unannotated fall-through between switch labels default: ^

Re: [PATCH 0/3] HDR aux backlight range calculation

2022-05-01 Thread Hogander, Jouni
On Fri, 2022-04-29 at 19:34 -0400, Lyude Paul wrote: > Cool! Tested this on three different laptops, and it seems to work > great on > all of them. so, this series is: > > Tested-by: Lyude Paul Thank you all for review/testing support. I will come back with updated patch set later. > > Would

[linux-next:master] BUILD REGRESSION 5469f0c06732a077c70a759a81f2a1f00b277694

2022-05-01 Thread kernel test robot
g:no-previous-prototype-for-function-amdgpu_discovery_get_mall_info | `-- drivers-gpu-drm-amd-amdgpu-soc21.c:warning:no-previous-prototype-for-function-soc21_grbm_select |-- riscv-randconfig-c006-20220501 | `-- mm-page_io.c:warning:Value-stored-to-page-during-its-initialization-is-ne

Re: [Freedreno] [PATCH] drm/msm/disp/dpu1: avoid clearing hw interrupts if hw_intr is null during drm uninit

2022-05-01 Thread Abhinav Kumar
Looks like our new CI has given all the answers we need :) which is a great win for the CI in my opinion. Take a look at this report : https://gitlab.freedesktop.org/drm/msm/-/jobs/22015361 This issue seems to be because this change

Re: [Freedreno] [PULL v3] drm/msm: display pull request for 5.19

2022-05-01 Thread Abhinav Kumar
Adding one more item: On 5/1/2022 4:41 PM, Dmitry Baryshkov wrote: Hi Rob, This is a pull request over the patches accumulated, reviewed and tested for the 5.19 merge window. This pull request contains following changes: - DPU: DSC (Display Stream Compression) support - DPU: Writeback

Re: [Freedreno] [PATCH v2] drm/msm/dsi: use RMW cycles in dsi_update_dsc_timing

2022-05-01 Thread Abhinav Kumar
On 5/1/2022 1:06 PM, Marijn Suijten wrote: On 2022-04-30 12:25:57, Abhinav Kumar wrote: On 4/30/2022 11:58 AM, Marijn Suijten wrote: On 2022-04-30 20:55:33, Dmitry Baryshkov wrote: The downstream uses read-modify-write for updating command mode compression registers. Let's follow this

Re: [PATCH v3] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-05-01 Thread Marek Vasut
On 4/29/22 23:23, Marek Vasut wrote: The LCDIF controller as present in i.MX28/i.MX6SX/i.MX8M Mini/Nano has CRC_STAT register, which contains CRC32 of the frame as it was clocked out of the DPI interface of the LCDIF. This is most likely meant as a functional safety feature. Unfortunately,

[PULL v3] drm/msm: display pull request for 5.19

2022-05-01 Thread Dmitry Baryshkov
Hi Rob, This is a pull request over the patches accumulated, reviewed and tested for the 5.19 merge window. This pull request contains following changes: - DPU: DSC (Display Stream Compression) support - DPU: inline rotation support on SC7280 - DPU: update DP timings to follow vendor

Re: [PATCH v20 8/8] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum

2022-05-01 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2022年4月22日 週五 下午8:42寫道: > > > > On 19/04/2022 11:41, jason-jh.lin wrote: > > After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0, > > mmsys header can remove the useless DDP_COMPONENT_DITHER enum. > > > > Signed-off-by: jason-jh.lin > > Reviewed-by:

Re: [PATCH v2] drm/msm/dsi: use RMW cycles in dsi_update_dsc_timing

2022-05-01 Thread Dmitry Baryshkov
On 01/05/2022 23:41, Marijn Suijten wrote: On 2022-04-30 22:28:42, Dmitry Baryshkov wrote: On 30/04/2022 21:58, Marijn Suijten wrote: On 2022-04-30 20:55:33, Dmitry Baryshkov wrote: The downstream uses read-modify-write for updating command mode compression registers. Let's follow this

Re: [PATCH 25/48] ARM: pxa: zylonite: use gpio lookup instead mfp header

2022-05-01 Thread Linus Walleij
On Tue, Apr 19, 2022 at 6:42 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The mach/mfp.h header is only used by this one driver > for hardcoded gpio numbers. Change that to use a lookup > table instead. > > Cc: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org > Acked-by: Robert Jarzmik

Re: [PATCH 24/48] ARM: pxa: mainstone-wm97xx: use gpio lookup table

2022-05-01 Thread Linus Walleij
On Tue, Apr 19, 2022 at 6:42 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > This driver hardcodes gpio numbers without a header file. > Use lookup tables instead. > > Cc: Marek Vasut > Acked-by: Dmitry Torokhov > Acked-by: Robert Jarzmik > Reviewed-by: Linus Walleij > Cc:

Re: [PATCH 23/48] ARM: pxa: magician: use platform driver for audio

2022-05-01 Thread Linus Walleij
On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The magician audio driver creates a codec device and gets > data from a board specific header file, both of which is > a bit suspicious. Move these into the board file itself, > using a gpio lookup table. > >

Re: [PATCH 22/48] ARM: pxa: z2: use gpio lookup for audio device

2022-05-01 Thread Linus Walleij
On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The audio device is allocated by the audio driver, and it uses a gpio > number from the mach/z2.h header file. > > Change it to use a gpio lookup table for the device allocated by the > driver to keep the header file

Re: [PATCH 21/48] ARM: pxa: eseries: use gpio lookup for audio

2022-05-01 Thread Linus Walleij
On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The three eseries machines have very similar drivers for audio, all > using the mach/eseries-gpio.h header for finding the gpio numbers. > > Change these to use gpio descriptors to avoid the header file > dependency.

Re: [PATCH 20/48] ARM: pxa: spitz: use gpio descriptors for audio

2022-05-01 Thread Linus Walleij
On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The audio driver should not use a hardwired gpio number > from the header. Change it to use a lookup table. > > Acked-by: Mark Brown > Cc: alsa-de...@alsa-project.org > Signed-off-by: Arnd Bergmann Looks good to

Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

2022-05-01 Thread Linus Walleij
On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The audio driver should not use a hardwired gpio number > from the header. Change it to use a lookup table. > > Cc: Philipp Zabel > Cc: Paul Parsons > Acked-by: Mark Brown > Acked-by: Robert Jarzmik > Cc:

Re: [PATCH 17/48] ARM: pxa: corgi: use gpio descriptors for audio

2022-05-01 Thread Linus Walleij
On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The audio driver should not use a hardwired gpio number > from the header. Change it to use a lookup table. > > Acked-by: Mark Brown > Cc: alsa-de...@alsa-project.org > Acked-by: Robert Jarzmik > Signed-off-by:

Re: [PATCH 15/48] ARM: pxa: tosa: use gpio descriptor for audio

2022-05-01 Thread Linus Walleij
On Tue, Apr 19, 2022 at 6:40 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The audio driver should not use a hardwired gpio number > from the header. Change it to use a lookup table. > > Acked-by: Mark Brown > Acked-by: Robert Jarzmik > Cc: alsa-de...@alsa-project.org > Signed-off-by:

Re: [PATCH v2] drm/msm/dsi: use RMW cycles in dsi_update_dsc_timing

2022-05-01 Thread Marijn Suijten
On 2022-04-30 22:28:42, Dmitry Baryshkov wrote: > On 30/04/2022 21:58, Marijn Suijten wrote: > > On 2022-04-30 20:55:33, Dmitry Baryshkov wrote: > >> The downstream uses read-modify-write for updating command mode > >> compression registers. Let's follow this approach. This also fixes the > >>

Re: [Freedreno] [PATCH v2] drm/msm/dsi: use RMW cycles in dsi_update_dsc_timing

2022-05-01 Thread Marijn Suijten
On 2022-04-30 12:25:57, Abhinav Kumar wrote: > > > On 4/30/2022 11:58 AM, Marijn Suijten wrote: > > On 2022-04-30 20:55:33, Dmitry Baryshkov wrote: > >> The downstream uses read-modify-write for updating command mode > >> compression registers. Let's follow this approach. This also fixes the >

[PATCH] drm/msm/dsi: pll_7nm: remove unsupported dividers for DSI pixel clock

2022-05-01 Thread Dmitry Baryshkov
Remove dividers that are not recommended for DSI DPHY mode when setting up the clock tree for the DSI pixel clock. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

[PATCH 3/3] drm/panel: drop DSC pps pointer

2022-05-01 Thread Dmitry Baryshkov
Complete the move of DSC data pointer from struct drm_panel to struct mipi_dsi_device. Signed-off-by: Dmitry Baryshkov --- include/drm/drm_panel.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index d279ee455f01..1ba2d424a53f 100644

[PATCH 2/3] drm/msm/dsi: fetch DSC pps payload from struct mipi_dsi_device

2022-05-01 Thread Dmitry Baryshkov
Now that struct mipi_dsi_device provides DSC data, fetch it from the mentioned struct rather than from the struct drm_panel itself. This would allow supporting MIPI DSI bridges handling DSC on their input side. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 25

[PATCH 1/3] drm/mipi-dsi: pass DSC data through the struct mipi_dsi_device

2022-05-01 Thread Dmitry Baryshkov
The commit 0f40ba48de3b ("drm/msm/dsi: Pass DSC params to drm_panel") added a pointer to the DSC data to the struct drm_panel. However DSC support is not limited to the DSI panels. MIPI DSI bridges can also consume DSC command streams. Thus add struct drm_dsc_config pointer to the struct

[PATCH 0/3] drm: move dsc data pointer from drm_panel to mipi_dsi_device

2022-05-01 Thread Dmitry Baryshkov
To properly support DSC the sink driver (panel) has to pass DSC pps data to the source (DSI host). The commit 0f40ba48de3b ("drm/msm/dsi: Pass DSC params to drm_panel") added a pointer to the DSC data to the struct drm_panel. However this is not the ideal solution. First, this leaves

RE: [PATCH v2 1/2] module: update dependencies at try_module_get()

2022-05-01 Thread David Laight
From: Mauro Carvalho Chehab > Sent: 30 April 2022 14:38 > > Em Sat, 30 Apr 2022 14:04:59 +0200 > Greg KH escreveu: > > > On Sat, Apr 30, 2022 at 11:30:58AM +0100, Mauro Carvalho Chehab wrote: > > > Did you run checkpatch on this? Please do :) > > > > > + > > > + if (mod == this) > > > +

[PATCH 2/3] drm/msm/mdp5: move iommu_domain_alloc() call close to its usage

2022-05-01 Thread Dmitry Baryshkov
Move iommu_domain_alloc() in front of adress space/IOMMU initialization. This allows us to drop final bits of struct mdp5_cfg_platform which remained from the pre-DT days. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 16

[PATCH 1/3] drm/msm/dpu: check both DPU and MDSS devices for the IOMMU

2022-05-01 Thread Dmitry Baryshkov
Follow the lead of MDP5 driver and check both DPU and MDSS devices for the IOMMU specifiers. Historically DPU devices had IOMMU specified in the MDSS device tree node, but as some of MDP5 devices are being converted to the supported by the DPU driver, the driver should adapt and check both

[PATCH 3/3] drm/msm: Stop using iommu_present()

2022-05-01 Thread Dmitry Baryshkov
Even if some IOMMU has registered itself on the platform "bus", that doesn't necessarily mean it provides translation for the device we care about. Replace iommu_present() with a more appropriate check. On Qualcomm platforms the IOMMU can be specified either for the MDP/DPU device or for its

[PATCH 0/3] drm/msm: fixes for KMS iommu handling

2022-05-01 Thread Dmitry Baryshkov
This series started from the applied and then reverted [2] patch by Robin Murphy [1]. After the MDSS rework [3] has landed it is now possible to reapply the extended version of the original patch. While we are at it, also rework the IOMMU init code for DPU and MDP5 drivers. For MDP5 this moves

Re: [PATCHv5] drm/amdgpu: vi: disable ASPM on Intel Alder Lake based systems

2022-05-01 Thread Paul Menzel
Dear Richard, Am 29.04.22 um 18:06 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD Volcanic Islands (VI) GFX cards, such as the WX3200 and RX640, that do not work with ASPM-enabled Intel Alder Lake based systems. Using these

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-05-01 Thread Paul Menzel
Dear Richard, Sorry for the late reply. Am 26.04.22 um 15:53 schrieb Gong, Richard: On 4/21/2022 12:35 AM, Paul Menzel wrote: Am 21.04.22 um 03:12 schrieb Gong, Richard: On 4/20/2022 3:29 PM, Paul Menzel wrote: Am 19.04.22 um 23:46 schrieb Gong, Richard: On 4/14/2022 2:52 AM, Paul