[PATCH] drm/amdgpu: fix drm-next merge fallout

2022-05-02 Thread Christian König
That hunk somehow got missing while solving the conflict between the TTM and AMDGPU changes for drm-next. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.

Re: [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Lucas De Marchi
On Mon, May 02, 2022 at 02:14:02PM -0700, Matt Roper wrote: On Mon, May 02, 2022 at 02:03:28PM -0700, Lucas De Marchi wrote: On Mon, May 02, 2022 at 09:34:09AM -0700, Matt Roper wrote: > From: Ayaz A Siddiqui ... > @@ -2002,11 +2002,18 @@ engine_fake_wa_init(struct intel_engine_cs *engine, s

[PATCH] drm/i915/gem: Make drop_pages() return bool

2022-05-02 Thread Lucas De Marchi
Commit e4e806253003 ("drm/i915: Change shrink ordering to use locking around unbinding.") changed the return type to int without changing the return values or their meaning to "0 is success". Move it back to boolean. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-05-02 Thread Guenter Roeck
On 5/2/22 14:03, Arnd Bergmann wrote: On Mon, May 2, 2022 at 10:35 PM Guenter Roeck wrote: On 5/2/22 12:21, Arnd Bergmann wrote: To boot from initrd: qemu-system-arm -M z2 -kernel \ arch/arm/boot/zImage -no-reboot -initrd \ rootfs-armv5.cpio --append \ "panic=-1 slub_d

RE: [PATCHv5] drm/amdgpu: vi: disable ASPM on Intel Alder Lake based systems

2022-05-02 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Friday, April 29, 2022 11:14 > To: Gong, Richard > Cc: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; Dave > Airlie ; Daniel Vetter ; amd-gfx list g...@lists.freedesktop.org>; kernel test robot ; LKML ker...@vger.ke

Re: [PATCH v2] drm/msm/dp: fix event thread stuck in wait_event after kthread_stop()

2022-05-02 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-05-02 16:04:28) > Event thread supposed to exit from its while loop after kthread_stop(). > However there may has possibility that event thread is pending in the > middle of wait_event due to condition checking never become true. > To make sure event thread exit its loop

Re: [PATCH v2 3/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-02 Thread kernel test robot
Hi Javier, I love your patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on shawnguo/for-next linus/master linux/master v5.18-rc5 next-20220502] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

RE: [PATCH] drm/ast: Atomic CR/SR reg R/W

2022-05-02 Thread Kuo-Hsiang Chou
Hi Thomas, Thanks for your kindly assistance. Regards Kuo-Hsiang Chou -Original Message- From: Thomas Zimmermann [mailto:tzimmerm...@suse.de] Sent: Monday, May 02, 2022 10:33 PM To: Kuo-Hsiang Chou ; dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org Cc: Ryan Chen ;

Re: [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge

2022-05-02 Thread Rob Herring
On Tue, Apr 26, 2022 at 09:36:44PM +0200, Marek Vasut wrote: > The i.MX8MP contains two syscon registers which are responsible > for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding > which represents this serializer as a bridge. > > Acked-by: Sam Ravnborg > Signed-off-by: Marek Vasu

Re: [PATCH 2/2] Revert "drm: of: Lookup if child node has panel or bridge"

2022-05-02 Thread Bjorn Andersson
On Wed, Apr 27, 2022 at 2:34 AM Paul Kocialkowski wrote: > > Hi Bjorn, > > On Tue 26 Apr 22, 14:10, Bjorn Andersson wrote: > > On Tue 26 Apr 06:50 PDT 2022, Paul Kocialkowski wrote: [..] > > > Bjorn, what do you think? > > > > > > > I'm okay with the idea that it's up the driver to check that the

Re: [PATCH] drm/rockchip: vop: fix possible null-ptr-deref in vop_bind()

2022-05-02 Thread Heiko Stuebner
On Fri, 22 Apr 2022 11:28:54 +0800, Yang Yingliang wrote: > It will cause null-ptr-deref in resource_size(), if platform_get_resource() > returns NULL, move calling resource_size() after devm_ioremap_resource() that > will check 'res' to avoid null-ptr-deref. Applied, thanks! [1/1] drm/rockchip:

Re: [PATCH] drm/rockchip: Refactor IOMMU initialisation

2022-05-02 Thread Heiko Stuebner
On Tue, 5 Apr 2022 15:32:50 +0100, Robin Murphy wrote: > Defer the IOMMU domain setup until after successfully binding > components, so we can figure out IOMMU support directly from the VOP > devices themselves, rather than manually inferring it from the DT (which > also fails to account for whethe

Re: [PATCH] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static

2022-05-02 Thread Heiko Stuebner
On Thu, 21 Apr 2022 10:43:04 -0400, Tom Rix wrote: > Smatch reports this issue > cdn-dp-core.c:51:20: warning: symbol 'rk3399_cdn_dp' was not declared. Should > it be static? > > rk3399_cdn_dp is only used in cdn-dp-core.c so change > its storge-class specifier to static. Applied, thanks! [1/1]

Re: [PATCH] drm/rockchip: Support YUV formats with U/V swapped

2022-05-02 Thread Heiko Stuebner
On Fri, 14 Jan 2022 15:40:38 +0800, Chen-Yu Tsai wrote: > The VOP in Rockchip SoCs that support YUV planes also support swapping > of the U and V elements. Supporting the swapped variants, especially > NV21, would be beneficial for multimedia applications, as the hardware > video decoders only outp

Re: (subset) [PATCH 0/5] Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2022-05-02 Thread Heiko Stuebner
On Thu, 21 Apr 2022 19:07:20 +0200, José Expósito wrote: > After implementing a similar change in the VC4 driver [1], as suggested > by Laurent in the ToDo list [2], I noticed that a similar pattern is > used in the Exynos, Rockchip, STI and sun4i drivers. > > This patchset replaces drm_detect_hdm

Re: [PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-02 Thread Bjorn Andersson
On Mon 02 May 15:49 PDT 2022, Kuogee Hsieh wrote: > > On 5/2/2022 3:29 PM, Bjorn Andersson wrote: > > On Mon 02 May 13:59 PDT 2022, Kuogee Hsieh wrote: > > > > > On 5/2/2022 9:53 AM, Bjorn Andersson wrote: > > > > The Qualcomm DisplayPort driver contains traces of the necessary > > > > plumbing

[PATCH v2] drm/msm/dp: fix event thread stuck in wait_event after kthread_stop()

2022-05-02 Thread Kuogee Hsieh
Event thread supposed to exit from its while loop after kthread_stop(). However there may has possibility that event thread is pending in the middle of wait_event due to condition checking never become true. To make sure event thread exit its loop after kthread_stop(), this patch OR kthread_should_

Re: [PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-02 Thread Bjorn Andersson
On Mon 02 May 15:29 PDT 2022, Bjorn Andersson wrote: > On Mon 02 May 13:59 PDT 2022, Kuogee Hsieh wrote: > > > > > On 5/2/2022 9:53 AM, Bjorn Andersson wrote: > > > The Qualcomm DisplayPort driver contains traces of the necessary > > > plumbing to hook up USB HPD, in the form of the dp_hpd modul

Re: [PATCH 10/11] drm/i915/pvc: skip all copy engines from aux table invalidate

2022-05-02 Thread Kumar Valsan, Prathap
On Mon, May 02, 2022 at 09:34:16AM -0700, Matt Roper wrote: > From: Lucas De Marchi > > As we have more copy engines now, mask all of them from aux table > invalidate. > > Cc: Prathap Kumar Valsan > Signed-off-by: Lucas De Marchi > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/ge

Re: [PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-02 Thread Kuogee Hsieh
On 5/2/2022 3:29 PM, Bjorn Andersson wrote: On Mon 02 May 13:59 PDT 2022, Kuogee Hsieh wrote: On 5/2/2022 9:53 AM, Bjorn Andersson wrote: The Qualcomm DisplayPort driver contains traces of the necessary plumbing to hook up USB HPD, in the form of the dp_hpd module and the dp_usbpd_cb struct.

Re: [PATCH 02/11] drm/i915/pvc: Add forcewake support

2022-05-02 Thread Summers, Stuart
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > Add PVC's forcewake ranges. > > Bspec: 67609 > Cc: Daniele Ceraolo Spurio > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/intel_uncore.c | 150 > +- > drivers/gpu/drm/i915/selftests/intel_uncore.c | 2 +

Re: [PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-02 Thread Bjorn Andersson
On Mon 02 May 13:59 PDT 2022, Kuogee Hsieh wrote: > > On 5/2/2022 9:53 AM, Bjorn Andersson wrote: > > The Qualcomm DisplayPort driver contains traces of the necessary > > plumbing to hook up USB HPD, in the form of the dp_hpd module and the > > dp_usbpd_cb struct. Use this as basis for implementi

Re: [PATCH 08/11] drm/i915/pvc: Interrupt support for new copy engines

2022-05-02 Thread Summers, Stuart
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > This patch adds the interrupt handler support for Imperative: Add the interrupt support for... Otherwise: Reviewed-by: Stuart Summers > new copy engines. > > Bspec: 54030 > Original-author: CQ Tang > Signed-off-by: Matt Roper > --- > dri

Re: [Intel-gfx] [PATCH 09/11] drm/i915/pvc: Reset support for new copy engines

2022-05-02 Thread Summers, Stuart
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > This patch adds the reset support for new copy engines > in PVC. > > Bspec: 52549 > Original-author: CQ Tang > Signed-off-by: Matt Roper Reviewed-by: Stuart Summers > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 8 + > drivers/g

Re: [PATCH] drm/msm/dsi: pll_7nm: remove unsupported dividers for DSI pixel clock

2022-05-02 Thread Dmitry Baryshkov
On 03/05/2022 00:42, Marijn Suijten wrote: On 2022-05-02 13:47:51, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-05-01 12:56:20) Remove dividers that are not recommended for DSI DPHY mode when setting Is "DPHY" intentional or just "PHY" should be here? up the clock tree for the DSI pix

Re: [Freedreno] [PATCH v2] drm/msm/dsi: use RMW cycles in dsi_update_dsc_timing

2022-05-02 Thread Marijn Suijten
On 2022-05-02 13:02:09, Dmitry Baryshkov wrote: > [snip] > > How would you represent this in XML? I was hoping for a method that > > allows to construct the value in a generic way, without register names, > > and then simply have a "register macro" that moves (and perhaps masks) > > the preconstru

Re: [PATCH v2] drm/msm/dsi: use RMW cycles in dsi_update_dsc_timing

2022-05-02 Thread Marijn Suijten
On 2022-05-02 12:41:37, Dmitry Baryshkov wrote: > On 02/05/2022 11:43, Marijn Suijten wrote: > > On 2022-05-02 01:44:20, Dmitry Baryshkov wrote: > >> [sni[ > >>> In any case, given that you've already sent this patch and another three > >>> patches [2] fixing/cleaning up the series tells me it's fa

Re: [PATCH] drm/msm/dp: fix event thread stuck in wait_event after kthread_sop()

2022-05-02 Thread Abhinav Kumar
On 5/2/2022 2:50 PM, Kuogee Hsieh wrote: Event thread supposed to exit from its while loop after kthread_stop(). However there may has possibility that event thread is pending in the middle of wait_event due to condition checking never become true. To make sure event thread exit its loop after

[PATCH] drm/msm/dp: fix event thread stuck in wait_event after kthread_sop()

2022-05-02 Thread Kuogee Hsieh
Event thread supposed to exit from its while loop after kthread_stop(). However there may has possibility that event thread is pending in the middle of wait_event due to condition checking never become true. To make sure event thread exit its loop after kthread_stop(), this patch OR kthread_should_

Re: [PATCH] drm/msm/dsi: pll_7nm: remove unsupported dividers for DSI pixel clock

2022-05-02 Thread Marijn Suijten
On 2022-05-02 13:47:51, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2022-05-01 12:56:20) > > Remove dividers that are not recommended for DSI DPHY mode when setting > > Is "DPHY" intentional or just "PHY" should be here? > > > up the clock tree for the DSI pixel clock. > > > > Signed-off-by:

Re: [PATCH v2 3/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-02 Thread kernel test robot
Hi Javier, I love your patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on shawnguo/for-next linus/master linux/master v5.18-rc5 next-20220502] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Matt Roper
On Mon, May 02, 2022 at 02:03:28PM -0700, Lucas De Marchi wrote: > On Mon, May 02, 2022 at 09:34:09AM -0700, Matt Roper wrote: > > From: Ayaz A Siddiqui ... > > @@ -2002,11 +2002,18 @@ engine_fake_wa_init(struct intel_engine_cs *engine, > > struct i915_wa_list *wal) > > * Streamers on Gen12

Re: [PATCH v2 3/4] dt-bindings:drm/bridge:anx7625: add port@0 property

2022-05-02 Thread Rob Herring
On Fri, 22 Apr 2022 16:47:17 +0800, Xin Ji wrote: > Add 'bus-type' and 'data-lanes' define, bus-type 7 for MIPI DPI > input, others for DSI input. > > Signed-off-by: Xin Ji > > --- > V1 -> V2: rebase on the latest code. > --- > .../display/bridge/analogix,anx7625.yaml | 19

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-05-02 Thread Arnd Bergmann
On Mon, May 2, 2022 at 10:35 PM Guenter Roeck wrote: > On 5/2/22 12:21, Arnd Bergmann wrote: > > > > To boot from initrd: > > qemu-system-arm -M z2 -kernel \ > arch/arm/boot/zImage -no-reboot -initrd \ > rootfs-armv5.cpio --append \ > "panic=-1 slub_debug=FZPUA rdinit=/sbin/init

Re: [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Lucas De Marchi
On Mon, May 02, 2022 at 09:34:09AM -0700, Matt Roper wrote: From: Ayaz A Siddiqui Bspec: 45101, 72161 Signed-off-by: Ayaz A Siddiqui Signed-off-by: Fei Yang Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_gt_types.h| 1 + drivers/gpu/drm/i915/gt/intel_mocs.c| 24 +

Re: [PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-02 Thread Kuogee Hsieh
On 5/2/2022 9:53 AM, Bjorn Andersson wrote: The Qualcomm DisplayPort driver contains traces of the necessary plumbing to hook up USB HPD, in the form of the dp_hpd module and the dp_usbpd_cb struct. Use this as basis for implementing the hpd_notify() callback, by amending the dp_hpd module with

Re: [PATCH] drm/msm/dpu: add missing break statement for update_pending_flush_wb()

2022-05-02 Thread Abhinav Kumar
On 5/2/2022 1:45 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2022-05-01 22:39:41) Add missing break statement for dpu_hw_ctl_update_pending_flush_wb(). Otherwise this leads to below build warning. drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c:273:2: warning: unannotated fall-through between

Re: [PATCH] drm/msm/dsi: pll_7nm: remove unsupported dividers for DSI pixel clock

2022-05-02 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-05-01 12:56:20) > Remove dividers that are not recommended for DSI DPHY mode when setting Is "DPHY" intentional or just "PHY" should be here? > up the clock tree for the DSI pixel clock. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd > driv

Re: [PATCH] drm/msm/dpu: add missing break statement for update_pending_flush_wb()

2022-05-02 Thread Stephen Boyd
Quoting Abhinav Kumar (2022-05-01 22:39:41) > Add missing break statement for dpu_hw_ctl_update_pending_flush_wb(). > Otherwise this leads to below build warning. > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c:273:2: > warning: unannotated fall-through between switch labels >default: >

Re: [PATCH 01/11] drm/i915/pvc: add initial Ponte Vecchio definitions

2022-05-02 Thread Lucas De Marchi
On Mon, May 02, 2022 at 09:34:07AM -0700, Matt Roper wrote: From: Stuart Summers Additional blitter and media engines will be enabled later. Bspec: 44481, 44482 Signed-off-by: Stuart Summers Signed-off-by: Matt Roper Reviewed-by: Lucas De Marchi Lucas De Marchi

Re: [PATCH v2] drm/msm/disp/dpu1: avoid clearing hw interrupts if hw_intr is null during drm uninit

2022-05-02 Thread Stephen Boyd
Quoting Vinod Polimera (2022-05-02 09:44:06) > If edp modeset init is failed due to panel being not ready and > probe defers during drm bind, avoid clearing irqs and derefernce s/derefernce/dereference/ > hw_intr when hw_intr is null. > > BUG: Unable to handle kernel NULL pointer dereference at v

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-05-02 Thread Guenter Roeck
On 5/2/22 12:21, Arnd Bergmann wrote: On Mon, May 2, 2022 at 6:26 PM Guenter Roeck wrote: With v5.18-rc1-49-gcb813018b5c1, I still get: [0.797668] RAMDISK: Couldn't find valid RAM disk image starting at 0. [0.805262] /dev/root: Can't open blockdev [0.805487] VFS: Cannot open root

Re: [PATCH v2] drm/msm/dpu: Clean up CRC debug logs

2022-05-02 Thread Stephen Boyd
Quoting Jessica Zhang (2022-04-29 17:52:10) > Currently, dpu_hw_lm_collect_misr returns EINVAL if CRC is disabled. > This causes a lot of spam in the DRM debug logs as it's called for every > vblank. > > Instead of returning EINVAL when CRC is disabled in > dpu_hw_lm_collect_misr, let's return ENOD

Re: [Intel-gfx] [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Matt Roper
On Mon, May 02, 2022 at 12:27:29PM -0700, Lucas De Marchi wrote: > On Mon, May 02, 2022 at 11:50:22AM -0700, Matt Roper wrote: > > On Mon, May 02, 2022 at 11:39:48AM -0700, Lucas De Marchi wrote: > > > On Mon, May 02, 2022 at 09:50:23AM -0700, Matt Roper wrote: > > > > On Mon, May 02, 2022 at 09:34

Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()

2022-05-02 Thread Laurent Pinchart
On Mon, May 02, 2022 at 09:28:45PM +0200, Javier Martinez Canillas wrote: > On 5/2/22 20:36, Laurent Pinchart wrote: > > On Mon, May 02, 2022 at 07:15:16PM +0200, Javier Martinez Canillas wrote: > >> On 5/2/22 18:55, Javier Martinez Canillas wrote: > >> > >> [snip] > >> > drop the depth option

Re: [PATCH v2 3/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-02 Thread Javier Martinez Canillas
Hello Laurent, On 5/2/22 20:01, Laurent Pinchart wrote: > Hi Javier, [snip] + fb_helper->firmware = firmware; >>> >>> I'd get rid of the local variable and write >>> >> >> I actually considered that but then decided to add a local variable to >> have both options set in the same place, sin

Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()

2022-05-02 Thread Javier Martinez Canillas
On 5/2/22 20:36, Laurent Pinchart wrote: > On Mon, May 02, 2022 at 07:15:16PM +0200, Javier Martinez Canillas wrote: >> On 5/2/22 18:55, Javier Martinez Canillas wrote: >> >> [snip] >> drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME comment in drm_fbdev_generic_setup(

Re: [Intel-gfx] [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Lucas De Marchi
On Mon, May 02, 2022 at 11:50:22AM -0700, Matt Roper wrote: On Mon, May 02, 2022 at 11:39:48AM -0700, Lucas De Marchi wrote: On Mon, May 02, 2022 at 09:50:23AM -0700, Matt Roper wrote: > On Mon, May 02, 2022 at 09:34:09AM -0700, Matt Roper wrote: > > From: Ayaz A Siddiqui > > > > Bspec: 45101,

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-05-02 Thread Arnd Bergmann
On Mon, May 2, 2022 at 6:26 PM Guenter Roeck wrote: > > With v5.18-rc1-49-gcb813018b5c1, I still get: > > [0.797668] RAMDISK: Couldn't find valid RAM disk image starting at 0. > [0.805262] /dev/root: Can't open blockdev > [0.805487] VFS: Cannot open root device "(null)" or unknown-bloc

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Harry Wentland
On 2022-05-02 10:29, Harry Wentland wrote: > > > On 2022-05-02 10:27, Modem, Bhanuprakash wrote: >> On Mon-02-05-2022 07:08 pm, Harry Wentland wrote: >>> >>> >>> On 2022-05-02 09:28, Modem, Bhanuprakash wrote: On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote: > > >> -Origi

Re: [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Harry Wentland
On 2022-04-11 05:51, Bhanuprakash Modem wrote: > As drm_connector already have the display_info, instead of creating > "output_bpc" debugfs in vendor specific driver, move the logic to > the drm layer. > > This patch will also move "Current" bpc to the crtc debugfs from > connector debugfs, sin

Re: [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-05-02 Thread Harry Wentland
On 2022-04-11 05:51, Bhanuprakash Modem wrote: > It's useful to know the connector's max supported bpc for IGT > testing. Expose it via a debugfs file on the connector "output_bpc". > > Example: cat /sys/kernel/debug/dri/0/DP-1/output_bpc > > V2: > * Fix typo in comments (Harry) > > Cc: Jani Nik

Re: [Intel-gfx] [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Matt Roper
On Mon, May 02, 2022 at 11:39:48AM -0700, Lucas De Marchi wrote: > On Mon, May 02, 2022 at 09:50:23AM -0700, Matt Roper wrote: > > On Mon, May 02, 2022 at 09:34:09AM -0700, Matt Roper wrote: > > > From: Ayaz A Siddiqui > > > > > > Bspec: 45101, 72161 > > > Signed-off-by: Ayaz A Siddiqui > > > Si

Re: [PATCH 11/11] drm/i915/pvc: read fuses for link copy engines

2022-05-02 Thread Souza, Jose
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > From: Lucas De Marchi > > The new Link Copy engines in PVC may be fused off according to the > mslice_mask. Each bit of the MEML3_EN_MASK we read from the > GEN10_MIRROR_FUSE3 register disables a pair of link copy engines. Reviewed-by: José

Re: [PATCH 06/11] drm/i915/pvc: Reduce stack usage in reset selftest with extra blitter engine

2022-05-02 Thread Souza, Jose
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > From: John Harrison > > PVC adds extra blitter engines (in the following patch). The reset > selftest has a local array on the stack which is sized by the number > of engines. The increase pushes the size of this array to the point > where it

Re: [Intel-gfx] [PATCH 07/11] drm/i915/pvc: Engines definitions for new copy engines

2022-05-02 Thread Souza, Jose
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > This patch adds the basic definitions needed to support > new copy engines. Also updating the cmd_info to accommodate > new engines, as the engine id's of legacy engines have been > changed. Reviewed-by: José Roberto de Souza > > Original-

Re: [Intel-gfx] [PATCH 09/11] drm/i915/pvc: Reset support for new copy engines

2022-05-02 Thread Souza, Jose
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > This patch adds the reset support for new copy engines > in PVC. Reviewed-by: José Roberto de Souza > > Bspec: 52549 > Original-author: CQ Tang > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 8 + > dr

Re: [Intel-gfx] [PATCH 10/11] drm/i915/pvc: skip all copy engines from aux table invalidate

2022-05-02 Thread Souza, Jose
On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote: > From: Lucas De Marchi > > As we have more copy engines now, mask all of them from aux table > invalidate. Reviewed-by: José Roberto de Souza > > Cc: Prathap Kumar Valsan > Signed-off-by: Lucas De Marchi > Signed-off-by: Matt Roper > --

Re: [Intel-gfx] [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Lucas De Marchi
On Mon, May 02, 2022 at 09:50:23AM -0700, Matt Roper wrote: On Mon, May 02, 2022 at 09:34:09AM -0700, Matt Roper wrote: From: Ayaz A Siddiqui Bspec: 45101, 72161 Signed-off-by: Ayaz A Siddiqui Signed-off-by: Fei Yang Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_gt_types.h

Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()

2022-05-02 Thread Laurent Pinchart
On Mon, May 02, 2022 at 07:15:16PM +0200, Javier Martinez Canillas wrote: > On 5/2/22 18:55, Javier Martinez Canillas wrote: > > [snip] > > >> drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME > >> comment in drm_fbdev_generic_setup() that could be related. > > > > A FIXME mak

Re: [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-05-02 Thread Lionel Landwerlin
On 02/05/2022 20:58, Abodunrin, Akeem G wrote: -Original Message- From: Landwerlin, Lionel G Sent: Monday, May 2, 2022 12:55 AM To: Auld, Matthew ; intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Thomas Hellström ; Bloomfield, Jon ; Daniel Vetter ; Justen, Jordan L

Re: [PATCH v2 3/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-02 Thread Laurent Pinchart
Hi Javier, On Mon, May 02, 2022 at 07:09:17PM +0200, Javier Martinez Canillas wrote: > On 5/2/22 18:17, Laurent Pinchart wrote: > > On Mon, May 02, 2022 at 05:39:00PM +0200, Javier Martinez Canillas wrote: > >> Indicate to fbdev subsystem that the registered framebuffer is provided by > >> the sys

RE: [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-05-02 Thread Abodunrin, Akeem G
> -Original Message- > From: Landwerlin, Lionel G > Sent: Monday, May 2, 2022 12:55 AM > To: Auld, Matthew ; intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Thomas Hellström > ; Bloomfield, Jon > ; Daniel Vetter ; Justen, > Jordan L ; Kenneth Graunke > ; Abodunrin,

[PATCH] drm/msm: Limit command submission when no IOMMU

2022-05-02 Thread Rob Clark
From: Rob Clark Running the GPU without an IOMMU is not really a supported (or sane) configuration. Yet it can be useful during SoC bringup (ie. if the iommu driver doesn't work yet). Lets limit it to users who already have /dev/mem access, to avoid the chance that a user accidentially configur

[RESEND PATCH v2 1/2] drm/edid: parse DRM VESA dsc bpp target

2022-05-02 Thread Yaroslav Bolyukin
As per DisplayID v2.0 Errata E9 spec "DSC pass-through timing support" VESA vendor-specific data block may contain target DSC bits per pixel fields Signed-off-by: Yaroslav Bolyukin --- drivers/gpu/drm/drm_edid.c | 33 ++--- include/drm/drm_connector.h | 6 ++ in

[RESEND PATCH v2 2/2] drm/amd: use fixed dsc bits-per-pixel from edid

2022-05-02 Thread Yaroslav Bolyukin
VESA vendor header from DisplayID spec may contain fixed bit per pixel rate, it should be respected by drm driver Signed-off-by: Yaroslav Bolyukin Reviewed-by: Wayne Lin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 ++ drivers/gpu/drm/amd/display/dc/core/dc_stream.c

Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()

2022-05-02 Thread Javier Martinez Canillas
On 5/2/22 18:55, Javier Martinez Canillas wrote: [snip] > >> drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME >> comment in drm_fbdev_generic_setup() that could be related. >> > > A FIXME makes sense, I'll add that to when posting a v3. There's actually a FIXME already in d

Re: [PATCH v2] drm/msm/disp/dpu1: avoid clearing hw interrupts if hw_intr is null during drm uninit

2022-05-02 Thread Dmitry Baryshkov
On 02/05/2022 19:44, Vinod Polimera wrote: If edp modeset init is failed due to panel being not ready and probe defers during drm bind, avoid clearing irqs and derefernce hw_intr when hw_intr is null. BUG: Unable to handle kernel NULL pointer dereference at virtual address Cal

[PATCH 1/4] Drivers: hv: vmbus: Remove support for Hyper-V 2008 and Hyper-V 2008R2/Win7

2022-05-02 Thread Michael Kelley
The VMbus driver has special case code for running on the first released versions of Hyper-V: 2008 and 2008 R2/Windows 7. These versions are now out of support (except for extended security updates) and lack the performance features needed for effective production usage of Linux guests. Simplify t

[PATCH 2/4] scsi: storvsc: Remove support for Hyper-V 2008 and 2008R2/Win7

2022-05-02 Thread Michael Kelley
The storvsc driver has special case code for running on the first released versions of Hyper-V: 2008 and 2008 R2/Windows 7. These versions are now out of support (except for extended security updates) and lack support for performance features like multiple VMbus channels that are needed for effect

[PATCH 3/4] video: hyperv_fb: Remove support for Hyper-V 2008 and 2008R2/Win7

2022-05-02 Thread Michael Kelley
The hyperv_fb driver has special case code for running on the first released versions of Hyper-V: 2008 and 2008 R2/Windows 7. These versions are now out of support (except for extended security updates) and lack support for performance features that are needed for effective production usage of Lin

[PATCH 4/4] drm/hyperv: Remove support for Hyper-V 2008 and 2008R2/Win7

2022-05-02 Thread Michael Kelley
The DRM Hyper-V driver has special case code for running on the first released versions of Hyper-V: 2008 and 2008 R2/Windows 7. These versions are now out of support (except for extended security updates) and lack support for performance features that are needed for effective production usage of L

Re: [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge

2022-05-02 Thread Marek Vasut
On 5/2/22 16:46, Robert Foss wrote: On Tue, 26 Apr 2022 at 21:37, Marek Vasut wrote: The i.MX8MP contains two syscon registers which are responsible for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding which represents this serializer as a bridge. Acked-by: Sam Ravnborg Signed-o

[PATCH 0/4] Remove support for Hyper-V 2008 and 2008R2/Win7

2022-05-02 Thread Michael Kelley
Linux code for running as a Hyper-V guest includes special cases for the first released versions of Hyper-V: 2008 and 2008R2/Windows 7. These versions were very thinly used for running Linux guests when first released more than 12 years ago, and they are now out of support (except for extended secu

Re: [PATCH v2 3/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-02 Thread Javier Martinez Canillas
Hello Laurent, On 5/2/22 18:17, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > > On Mon, May 02, 2022 at 05:39:00PM +0200, Javier Martinez Canillas wrote: >> Indicate to fbdev subsystem that the registered framebuffer is provided by >> the system firmware, so that it can han

Re: [PATCH v2 0/4] drm/nvdla: Add driver support for NVDLA

2022-05-02 Thread Thierry Reding
On Fri, Apr 29, 2022 at 11:28:10AM +0800, Cai Huoqing wrote: > On 28 4月 22 18:56:07, Mikko Perttunen wrote: > > On 4/28/22 17:10, Thierry Reding wrote: > > > On Tue, Apr 26, 2022 at 02:07:57PM +0800, Cai Huoqing wrote: > > > > The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP > > >

Re: [PATCH v2 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter

2022-05-02 Thread Javier Martinez Canillas
On 5/2/22 18:07, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > > On Mon, May 02, 2022 at 05:38:59PM +0200, Javier Martinez Canillas wrote: >> By default the bits per pixel for the emulated framebuffer device is set >> to dev->mode_config.preferred_depth, but some devices nee

Re: [PATCH 04/11] drm/i915/pvc: Read correct RP_STATE_CAP register

2022-05-02 Thread Rodrigo Vivi
On Mon, May 02, 2022 at 09:34:10AM -0700, Matt Roper wrote: > The SoC registers, including RP_STATE_CAP, have moved to a new location > in GTTMMADR on Ponte Vecchio. We need to update the register offset > accordingly. > > Cc: Rodrigo Vivi > Signed-off-by: Matt Roper Reviewed-by: Rodrigo Vivi

Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup()

2022-05-02 Thread Javier Martinez Canillas
Hello Laurent, On 5/2/22 18:06, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > > On Mon, May 02, 2022 at 05:38:58PM +0200, Javier Martinez Canillas wrote: >> The drm_fbdev_generic_setup() function already sets the preferred bits per >> pixel for the device to dev->mode_confi

[PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-02 Thread Bjorn Andersson
The Qualcomm DisplayPort driver contains traces of the necessary plumbing to hook up USB HPD, in the form of the dp_hpd module and the dp_usbpd_cb struct. Use this as basis for implementing the hpd_notify() callback, by amending the dp_hpd module with the missing logic. Overall the solution is sim

[PATCH v4 4/5] drm/msm/dp: remove most of usbpd-related remains

2022-05-02 Thread Bjorn Andersson
From: Dmitry Baryshkov Remove most of remains of downstream usbpd code. Mainline kernel uses different approach for managing Type-C / USB-PD, so this remains unused. Do not touch usbpd callbacks for now, since they look useful enough as an example of how to handle connect/disconnect (to be rewrit

[PATCH v4 2/5] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-05-02 Thread Bjorn Andersson
In some implementations, such as the Qualcomm platforms, the display driver has no way to query the current HPD state and as such it's impossible to distinguish between disconnect and attention events. Add a parameter to drm_connector_oob_hotplug_event() to pass the HPD state. Also push the test

[PATCH v4 3/5] drm/bridge_connector: implement oob_hotplug_event

2022-05-02 Thread Bjorn Andersson
From: Dmitry Baryshkov Implement the oob_hotplug_event() callback. Translate it to the HPD notification sent to the HPD bridge in the chain. Signed-off-by: Dmitry Baryshkov Signed-off-by: Bjorn Andersson --- Changes since v3: - New patch drivers/gpu/drm/drm_bridge_connector.c | 12 +

[PATCH v4 1/5] drm/bridge_connector: stop filtering events in drm_bridge_connector_hpd_cb()

2022-05-02 Thread Bjorn Andersson
From: Dmitry Baryshkov In some cases the bridge drivers would like to receive hotplug events even in the case new status is equal to the old status. In the DP case this is used to deliver "attention" messages to the DP host. Stop filtering the events in the drm_bridge_connector_hpd_cb() and let d

[PATCH v4 0/5] drm/msm/dp: implement HPD notifications handling

2022-05-02 Thread Bjorn Andersson
USB altmodes code would send OOB notifications to the drm_connector specified in the device tree. However as the MSM DP driver uses drm_bridge_connector, there is no way to receive these event directly. Implement a bridge between oob_hotplug_event and drm_bridge's hpd_notify and use it to deliver a

Re: [PATCH 03/11] drm/i915/pvc: Define MOCS table for PVC

2022-05-02 Thread Matt Roper
On Mon, May 02, 2022 at 09:34:09AM -0700, Matt Roper wrote: > From: Ayaz A Siddiqui > > Bspec: 45101, 72161 > Signed-off-by: Ayaz A Siddiqui > Signed-off-by: Fei Yang > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_gt_types.h| 1 + > drivers/gpu/drm/i915/gt/intel_mocs.c

Re: [PATCH v3 1/3] drm/i915/gt: BUG_ON unexpected NULL at scatterlist walking

2022-05-02 Thread Jani Nikula
On Mon, 02 May 2022, Ramalingam C wrote: > While locating the start of ccs scatterlist in smem scatterlist, that has > to be the size of lmem obj size + corresponding ccs data size, report bug > if scatterlist terminate before that length. > > v2: > s/GEM_BUG_ON/BUG_ON with more commenting [Matt

[PATCH v2] drm/msm/disp/dpu1: avoid clearing hw interrupts if hw_intr is null during drm uninit

2022-05-02 Thread Vinod Polimera
If edp modeset init is failed due to panel being not ready and probe defers during drm bind, avoid clearing irqs and derefernce hw_intr when hw_intr is null. BUG: Unable to handle kernel NULL pointer dereference at virtual address Call trace: dpu_core_irq_uninstall+0x50/0xb0 d

[PATCH 15/15] drm/amdgpu: user fence proof of concept

2022-05-02 Thread Christian König
Just some hack to test the functionality, not a real implementation of the interface. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c| 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 28 --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c |

[PATCH 14/15] drm/amdgpu: switch DM to atomic fence helpers

2022-05-02 Thread Christian König
This gives us the standard atomic implicit and explicit fencing rules. Signed-off-by: Christian König Cc: Harry Wentland Cc: Nicholas Kazlauskas Cc: Roman Li Cc: Qingqing Zhuo Cc: Jude Shih Cc: Wayne Lin Cc: Rodrigo Siqueira --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 23 -

[PATCH 13/15] drm: add user fence support to drm_syncobj

2022-05-02 Thread Christian König
For now just filter or wait for user fences. Signed-off-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 15 --- include/drm/drm_syncobj.h | 25 + 2 files changed, 33 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/driver

[PATCH 12/15] drm: add user fence support to drm_gem_plane_helper_prepare_fb

2022-05-02 Thread Christian König
Just handle them the same way as fences with the DMA_RESV_USAGE_WRITE flag when the DRIVER_USER_FENCE flag is set. Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_atomic_helper.c | 68 - 1 file changed, 45 insertions(+), 23 deletions(-) diff --git a/drivers/gp

[PATCH 11/15] drm: add user fence support for atomic in fences

2022-05-02 Thread Christian König
When the DRIVER_USER_FENCE flag is set we grab the user fence from the sync file instead of the normal one. Signed-off-by: Christian König --- drivers/gpu/drm/drm_atomic_uapi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gp

[PATCH 10/15] drm: add user fence support for atomic out fences

2022-05-02 Thread Christian König
Add a new driver flag indicating support for user fences. This flag is then used when creating out fences for atomic mode setting, indicating that the mode set might depend on an user fence. Signed-off-by: Christian König --- drivers/gpu/drm/drm_atomic_uapi.c | 8 include/drm/drm_drv.h

[PATCH 09/15] dma-buf/sync_file: add user fence support

2022-05-02 Thread Christian König
Keep user fences separate from normal fences. Signed-off-by: Christian König --- drivers/dma-buf/sync_file.c | 82 + include/linux/sync_file.h | 4 +- 2 files changed, 76 insertions(+), 10 deletions(-) diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma

[PATCH 08/15] dma-buf: add support for polling on user fences

2022-05-02 Thread Christian König
Just also wait for user fences to signal when we wait for write fences. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 79795857be3e..5558f4e555f8 100644 --- a

[PATCH 07/15] dma-buf: add user fence utility functions

2022-05-02 Thread Christian König
Allows to filter user fences from a dma_fence_chain and wait for user fences in containers. Signed-off-by: Christian König --- drivers/dma-buf/dma-fence-unwrap.c | 47 ++ include/linux/dma-fence-unwrap.h | 3 ++ 2 files changed, 50 insertions(+) diff --git a/drive

[PATCH 06/15] dma-buf: add user fence support to dma_fence_merge()

2022-05-02 Thread Christian König
Just make sure that we forward the user fence status to the output whenever any of the inputs are an user fence. Signed-off-by: Christian König --- drivers/dma-buf/dma-fence-unwrap.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/dma-fence-unwrap.

[PATCH 05/15] dma-buf: add user fence support to dma_resv

2022-05-02 Thread Christian König
This patch adds the new DMA_RESV_USAGE_USER flag to the dma_resv object which must be used with user fence objects. In opposite to the other usage flags this one doesn't automatically return other lower classes. So when user fences are requested from the dma_resv object only user fences are return

[PATCH 04/15] dma-buf: add user fence support to dma_fence_chain

2022-05-02 Thread Christian König
If either the previous fence or the newly chained on is an user fence the dma_fence chain node is considered an user fence as well. This way the user fence status propagates through the chain. Signed-off-by: Christian König --- drivers/dma-buf/dma-fence-chain.c | 4 1 file changed, 4 inser

  1   2   >