Re: [PATCH 2/2] drm/msm/dpu: drop enum msm_display_caps

2022-06-15 Thread Abhinav Kumar
On 5/7/2022 4:59 AM, Dmitry Baryshkov wrote: After the commit c46f0d69039c ("drm/msm: remove unused hotplug and edid macros from msm_drv.h") the msm_display_caps enum contains two bits describing whether the encoder should work in video or command mode. Drop the enum and replace capabilities f

Re: [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Dmitry Baryshkov
On 16/06/2022 09:28, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-06-15 23:21:56) I have more or less the same setup using a longer format and using the git-log instead of git-show. This way I can just do a git fixes drivers/gpu/drm/msm and spot the commit in question. I've long desired

Re: [PATCH 1/2] drm/msm/dpu: dont_use IS_ERR_OR_NULL for encoder phys backends

2022-06-15 Thread Abhinav Kumar
On 5/7/2022 4:59 AM, Dmitry Baryshkov wrote: The functions dpu_encoder_phys_foo_init() can not return NULL. Replace corresponding IS_ERR_OR_NULL() checks with just IS_ERR(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 +

Re: [PATCH 2/2] drm/msm/mdp4: get rid of struct mdp4_platform_config

2022-06-15 Thread Abhinav Kumar
On 5/5/2022 6:50 AM, Dmitry Baryshkov wrote: Struct mdp4_platform_config is a relict from the DT-conversion time. Move the max_clk field to the mdp4_kms_init(), the place where it is used and drop the struct mdp4_platform_config and the mdp4_get_config() function. Signed-off-by: Dmitry Barysh

Re: [PATCH v3 06/14] drm/msm/hdmi: drop unused GPIO support

2022-06-15 Thread Dmitry Baryshkov
On 10/06/2022 23:47, Dmitry Baryshkov wrote: On 10/06/2022 23:46, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-06-09 05:23:42) The HDMI driver has code to configure extra GPIOs, which predates pinctrl support. Nowadays all platforms should use pinctrl instead. Neither of upstreamed Qualco

Re: [PATCH 1/2] drm/msm/mdp4: move iommu_domain_alloc() call close to its usage

2022-06-15 Thread Abhinav Kumar
On 5/5/2022 6:50 AM, Dmitry Baryshkov wrote: Move iommu_domain_alloc() in front of adress space/IOMMU initialization. This allows us to drop it from struct mdp4_cfg_platform which remained from the pre-DT days. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/d

?????? [PATCH 2/5] drm/gma500: Fix spelling typo in comment

2022-06-15 Thread 1064094935
Hi, This is great advice, thanks. I will resubmit this patch again. Best regards, pengfuyuan --  -- ??: "Patrik Jakobsson"

Re: [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-15 23:21:56) > > I have more or less the same setup using a longer format and using the > git-log instead of git-show. This way I can just do a git fixes > drivers/gpu/drm/msm and spot the commit in question. I've long desired to have this be part of checkpatch.pl

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Abhinav Kumar
On 6/15/2022 11:21 PM, Dmitry Baryshkov wrote: On Thu, 16 Jun 2022 at 09:18, Stephen Boyd wrote: Quoting Abhinav Kumar (2022-06-15 22:59:25) Hi Dmitry On 6/15/2022 10:55 PM, Dmitry Baryshkov wrote: On 14/06/2022 22:32, Abhinav Kumar wrote: intf and wb resources are not dependent on the

Re: [PATCH v4 2/7] usb: typec: mux: Add CONFIG guards for functions

2022-06-15 Thread Heikki Krogerus
On Wed, Jun 15, 2022 at 05:20:18PM +, Prashant Malani wrote: > There are some drivers that can use the Type C mux API, but don't have > to. Introduce CONFIG guards for the mux functions so that drivers can > include the header file and not run into compilation errors on systems > which don't ha

Re: [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Dmitry Baryshkov
On Thu, 16 Jun 2022 at 09:18, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2022-06-15 22:59:25) > > Hi Dmitry > > > > On 6/15/2022 10:55 PM, Dmitry Baryshkov wrote: > > > On 14/06/2022 22:32, Abhinav Kumar wrote: > > >> intf and wb resources are not dependent on the rm global > > >> state so nee

Re: [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Stephen Boyd
Quoting Abhinav Kumar (2022-06-15 22:59:25) > Hi Dmitry > > On 6/15/2022 10:55 PM, Dmitry Baryshkov wrote: > > On 14/06/2022 22:32, Abhinav Kumar wrote: > >> intf and wb resources are not dependent on the rm global > >> state so need not be allocated during dpu_encoder_virt_atomic_mode_set(). > >>

Re: [PATCH v2] drm/msm/dp: check core_initialized before disable interrupts at dp_display_unbind()

2022-06-15 Thread Dmitry Baryshkov
On 06/06/2022 20:55, Kuogee Hsieh wrote: During msm initialize phase, dp_display_unbind() will be called to undo initializations had been done by dp_display_bind() previously if there is error happen at msm_drm_bind. In this case, core_initialized flag had to be check to make sure clocks is on be

Re: [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Abhinav Kumar
Hi Dmitry On 6/15/2022 10:55 PM, Dmitry Baryshkov wrote: On 14/06/2022 22:32, Abhinav Kumar wrote: intf and wb resources are not dependent on the rm global state so need not be allocated during dpu_encoder_virt_atomic_mode_set(). Move the allocation of intf and wb resources to dpu_encoder_set

Re: [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Dmitry Baryshkov
On 14/06/2022 22:32, Abhinav Kumar wrote: intf and wb resources are not dependent on the rm global state so need not be allocated during dpu_encoder_virt_atomic_mode_set(). Move the allocation of intf and wb resources to dpu_encoder_setup_display() so that we can utilize the hw caps even during

Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d

2022-06-15 Thread Chen, Rong A
On 5/26/2022 4:32 PM, Arnd Bergmann wrote: On Wed, May 25, 2022 at 11:35 PM kernel test robot wrote: .__mulsi3.o.cmd: No such file or directory Makefile:686: arch/h8300/Makefile: No such file or directory Makefile:765: arch/h8300/Makefile: No such file or directory arch/Kconfig:10: can't ope

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Alex Deucher
Pushed to drm-misc-next. Alex On Wed, Jun 15, 2022 at 7:26 PM Stephen Rothwell wrote: > > Hi all, > > On Wed, 15 Jun 2022 13:52:34 -0700 Nathan Chancellor > wrote: > > > > On Wed, Jun 15, 2022 at 04:45:16PM -0400, Alex Deucher wrote: > > > On Wed, Jun 15, 2022 at 4:24 PM Nathan Chancellor >

Re: [PATCH v2 4/5] drm/msm: move KMS aspace init to the separate helper

2022-06-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-05-04 17:16:04) > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index a37a3bbc04d9..98ae0036ab57 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -262,6 +263,46 @@ static int msm_drm_uninit(struct d

Re: [PATCH v7] drm/msm/dp: force link training for display resolution change

2022-06-15 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-06-15 08:53:57) > Display resolution change is implemented through drm modeset. Older > modeset (resolution) has to be disabled first before newer modeset > (resolution) can be enabled. Display disable will turn off both > pixel clock and main link clock so that main link

Re: [Freedreno] [PATCH v2 1/5] drm/msm/dpu: check both DPU and MDSS devices for the IOMMU

2022-06-15 Thread Abhinav Kumar
On 6/15/2022 11:42 AM, Dmitry Baryshkov wrote: On 15/06/2022 20:55, Abhinav Kumar wrote: On 5/4/2022 5:16 PM, Dmitry Baryshkov wrote: Follow the lead of MDP5 driver and check both DPU and MDSS devices for the IOMMU specifiers. Historically DPU devices had IOMMU specified in the MDSS devic

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Stephen Rothwell
Hi all, On Wed, 15 Jun 2022 13:52:34 -0700 Nathan Chancellor wrote: > > On Wed, Jun 15, 2022 at 04:45:16PM -0400, Alex Deucher wrote: > > On Wed, Jun 15, 2022 at 4:24 PM Nathan Chancellor > > wrote: > > > > > > On Wed, Jun 15, 2022 at 03:28:52PM -0400, Alex Deucher wrote: > > > > On Wed, Ju

[PATCH] drm/msm/dpu: set preferred mode for writeback connector

2022-06-15 Thread Abhinav Kumar
After [1] was merged to IGT, we use either the first supported mode in the list OR the preferred mode to determine the primary plane to use for the sub-test due to the IGT API [2]. Since writeback does not set any preferred mode, this was selecting 4k as that was the first entry in the list. We u

Re: Please add another drm/msm tree to the linux-next

2022-06-15 Thread Stephen Rothwell
Hi Dmitry, On Wed, 15 Jun 2022 17:19:42 +0300 Dmitry Baryshkov wrote: > > I would appreciate if you could add > > https://gitlab.freedesktop.org/lumag/msm.git msm-next-lumag > > to the linux-next tree. > > This tree is a part of drm/msm maintenance structure. As a co-maintainer I > collect a

Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support

2022-06-15 Thread Lee Jones
On Mon, 13 Jun 2022, ChiaEn Wu wrote: > From: ChiYuan Huang > > Add Mediatek MT6370 MFD support. > > Signed-off-by: ChiYuan Huang > --- > drivers/mfd/Kconfig | 13 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/mt6370.c | 349 +++ > 3 files changed,

[PATCH 2/2] drm/bridge/tc358775: Fix DSI clock division for vsync delay calculation

2022-06-15 Thread Jiri Vanek
Use the same PCLK divide option (divide DSI clock to generate pixel clock) which is set to LVDS Configuration Register (LVCFG) also for a VSync delay calculation. Without this change an auxiliary variable could underflow during the calculation for some dual-link LVDS panels and then calculated VSyn

[PATCH 1/2] drm/bridge/tc358775: Return before displaying inappropriate error message

2022-06-15 Thread Jiri Vanek
Function for reading from i2c device register displays error message even if reading ends correctly. Add return to avoid falling through into the fail label. Signed-off-by: Jiri Vanek --- drivers/gpu/drm/bridge/tc358775.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge

[PATCH 0/2] Fixes for TC358775 DSI to LVDS bridge

2022-06-15 Thread Jiri Vanek
This patchset fixes two bugs in the driver for TC358775 DSI to LVDS bridge. Jiri Vanek (2): drm/bridge/tc358775: Return before displaying inappropriate error message drm/bridge/tc358775: Fix DSI clock division for vsync delay calculation drivers/gpu/drm/bridge/tc358775.c | 3 ++- 1 f

[PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros

2022-06-15 Thread Laurent Pinchart
Now that a header exists with macros for the media interface bus-type values, replace hardcoding numerical constants with the corresponding macros in the DT sources. Signed-off-by: Laurent Pinchart --- arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++ .../dts/r8a7742-iwg21d

[PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros

2022-06-15 Thread Laurent Pinchart
Now that a header exists with macros for the media interface bus-type values, replace hardcoding numerical constants with the corresponding macros in the DT sources. Signed-off-by: Laurent Pinchart --- arch/arm/boot/dts/stm32429i-eval.dts | 3 ++- arch/arm/boot/dts/stm32mp157c-ev1.dts | 3 ++-

[PATCH v3 4/6] ARM: dts: omap: Use new media bus type macros

2022-06-15 Thread Laurent Pinchart
Now that a header exists with macros for the media interface bus-type values, replace hardcoding numerical constants with the corresponding macros in the DT sources. Signed-off-by: Laurent Pinchart --- arch/arm/boot/dts/omap3-n900.dts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) d

[PATCH v3 3/6] ARM: dts: freescale: Use new media bus type macros

2022-06-15 Thread Laurent Pinchart
Now that a header exists with macros for the media interface bus-type values, replace hardcoding numerical constants with the corresponding macros in the DT sources. Signed-off-by: Laurent Pinchart --- arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(

[PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples

2022-06-15 Thread Laurent Pinchart
Now that a header exists with macros for the media interface bus-type values, replace hardcoding numerical constants with the corresponding macros in the DT binding examples. Signed-off-by: Laurent Pinchart --- Changes since v2: - Go back to PARALLEL Changes since v1: - Rename PARALLEL to BT60

[PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types

2022-06-15 Thread Laurent Pinchart
Add a new dt-bindings/media/video-interfaces.h header that defines macros corresponding to the bus types from media/video-interfaces.yaml. This allows avoiding hardcoded constants in device tree sources. Signed-off-by: Laurent Pinchart --- Changes since v2: - Go back to PARALLEL Changes since v

[PATCH v3 0/6] dt-bindings: Add macros for video interface bus types

2022-06-15 Thread Laurent Pinchart
Hello, This small patch series is the result of me getting a bus-type numerical value wrong in a device tree file and spending too long debugging the issue. Hopefully there's nothing controversial here. Compared to v2, the PARALLEL bus type came back to replace BT601, as it turned out that BT601

Re: [PATCH v2 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Dmitry Baryshkov
On Thu, 16 Jun 2022 at 00:22, Abhinav Kumar wrote: > > intf and wb resources are not dependent on the rm global > state so need not be allocated during dpu_encoder_virt_atomic_mode_set(). > > Move the allocation of intf and wb resources to dpu_encoder_setup_display() > so that we can utilize the h

Re: [PATCH] drm/amdgpu/display: fix build when CONFIG_DEBUG_FS is not set

2022-06-15 Thread Harry Wentland
On 2022-06-15 17:00, Alex Deucher wrote: > amdgpu_dm_crtc_late_register is only used when CONFIG_DEBUG_FS > so make it dependent on that. > > Fixes: 4cd79f614b50 ("drm/amd/display: Move connector debugfs to drm") > Cc: Bhanuprakash Modem > Cc: Harry Wentland > Cc: Arun R Murthy > Cc: Jani Nikul

[PATCH v2 3/3] drm/msm/dpu: remove hard-coded linewidth limit for writeback

2022-06-15 Thread Abhinav Kumar
Remove the hard-coded limit for writeback and lets start using the one from catalog instead. Fixes: d7d0e73f7de3 ("introduce the dpu_encoder_phys_* for writeback") Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 6 ++ 1 fi

[PATCH v2 2/3] drm/msm/dpu: fix maxlinewidth for writeback block

2022-06-15 Thread Abhinav Kumar
Writeback block for sm8250 was using the default maxlinewidth of 2048. But this is not right as it supports upto 4096. This should have no effect on most resolutions as we are still limiting upto maxlinewidth of SSPP for adding the modes. Fix the maxlinewidth for writeback block on sm8250. Fixes

[PATCH v2 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Abhinav Kumar
intf and wb resources are not dependent on the rm global state so need not be allocated during dpu_encoder_virt_atomic_mode_set(). Move the allocation of intf and wb resources to dpu_encoder_setup_display() so that we can utilize the hw caps even during atomic_check() phase. Since dpu_encoder_set

Re: [PATCH v3 01/14] dt-bindings: display/msm: hdmi: split and convert to yaml

2022-06-15 Thread Krzysztof Kozlowski
On 09/06/2022 05:23, Dmitry Baryshkov wrote: > Convert Qualcomm HDMI binding into HDMI TX and PHY yaml bindings. > > Changes to schema: > HDMI: > - fixed reg-names numbering to match 0..3 instead 0,1,3,4 > - dropped qcom,tx-ddc-* from example, they were not documented > - make phy-names depreca

[PATCH] drm/amdgpu/display: fix build when CONFIG_DEBUG_FS is not set

2022-06-15 Thread Alex Deucher
amdgpu_dm_crtc_late_register is only used when CONFIG_DEBUG_FS so make it dependent on that. Fixes: 4cd79f614b50 ("drm/amd/display: Move connector debugfs to drm") Cc: Bhanuprakash Modem Cc: Harry Wentland Cc: Arun R Murthy Cc: Jani Nikula Reported-by: Randy Dunlap Reported-by: Nathan Chancel

[pull] amdgpu drm-fixes-5.19

2022-06-15 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.19. The following changes since commit 1f192b9e8d8a5c619b33a868fb1af063af65ce5d: Merge tag 'drm-misc-fixes-2022-06-09' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2022-06-10 13:29:22 +1000) are available in the Git repository at: https://git

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Nathan Chancellor
On Wed, Jun 15, 2022 at 04:45:16PM -0400, Alex Deucher wrote: > On Wed, Jun 15, 2022 at 4:24 PM Nathan Chancellor wrote: > > > > On Wed, Jun 15, 2022 at 03:28:52PM -0400, Alex Deucher wrote: > > > On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap > > > wrote: > > > > > > > > > > > > > > > > On 6/14/2

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Alex Deucher
On Wed, Jun 15, 2022 at 4:24 PM Nathan Chancellor wrote: > > On Wed, Jun 15, 2022 at 03:28:52PM -0400, Alex Deucher wrote: > > On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap wrote: > > > > > > > > > > > > On 6/14/22 23:01, Stephen Rothwell wrote: > > > > Hi all, > > > > > > > > Changes since 202206

Re: [Linaro-mm-sig] Re: [PATCH] drivers: tty: serial: Add missing of_node_put() in serial-tegra.c

2022-06-15 Thread Daniel Vetter
On Wed, 15 Jun 2022 at 22:23, Dave Airlie wrote: > > On Wed, 15 Jun 2022 at 20:53, Greg KH wrote: > > > > On Wed, Jun 15, 2022 at 06:48:33PM +0800, heliang wrote: > > > In tegra_uart_init(), of_find_matching_node() will return a node > > > pointer with refcount incremented. We should use of_node_

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Randy Dunlap
Hi-- On 6/15/22 13:13, Alex Deucher wrote: > On Wed, Jun 15, 2022 at 3:44 PM Randy Dunlap wrote: >> >> >> >> On 6/15/22 12:28, Alex Deucher wrote: >>> On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap wrote: On 6/14/22 23:01, Stephen Rothwell wrote: > Hi all, > > Chang

Re: [PATCH] drm/dp/mst: Read the extended DPCD capabilities during system resume

2022-06-15 Thread Lyude Paul
If you add a Cc: to sta...@vger.kernel.org then this is: Reviewed-by: Lyude Paul I assume you have the privileges to push this to drm-misc-next On Tue, 2022-06-14 at 12:45 +0300, Imre Deak wrote: > The WD22TB4 Thunderbolt dock at least will revert its DP_MAX_LINK_RATE > from HBR3 to HBR2 after

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Nathan Chancellor
On Wed, Jun 15, 2022 at 03:28:52PM -0400, Alex Deucher wrote: > On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap wrote: > > > > > > > > On 6/14/22 23:01, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20220614: > > > > > > > on i386: > > # CONFIG_DEBUG_FS is not set > > > > > > ../dri

Re: [Linaro-mm-sig] Re: [PATCH] drivers: tty: serial: Add missing of_node_put() in serial-tegra.c

2022-06-15 Thread Dave Airlie
On Wed, 15 Jun 2022 at 20:53, Greg KH wrote: > > On Wed, Jun 15, 2022 at 06:48:33PM +0800, heliang wrote: > > In tegra_uart_init(), of_find_matching_node() will return a node > > pointer with refcount incremented. We should use of_node_put() > > when it is not used anymore. > > > > Signed-off-by:

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Alex Deucher
On Wed, Jun 15, 2022 at 3:44 PM Randy Dunlap wrote: > > > > On 6/15/22 12:28, Alex Deucher wrote: > > On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap wrote: > >> > >> > >> > >> On 6/14/22 23:01, Stephen Rothwell wrote: > >>> Hi all, > >>> > >>> Changes since 20220614: > >>> > >> > >> on i386: > >> #

Re: [PATCH 0/8] drm: Clean up drm_crtc.h

2022-06-15 Thread Sam Ravnborg
Hi Ville, On Mon, Jun 13, 2022 at 11:03:09PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Eliminate unnecessary includes from drm_crtc.h to avoid > pointless rebuilds of the entire universe when touching > some random header. > > I didn't really feel like splitting this up per-driver s

Re: [PATCH 3/8] drm: Drop drm_blend.h from drm_crtc.h

2022-06-15 Thread Sam Ravnborg
Hi Ville. On Mon, Jun 13, 2022 at 11:03:12PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_crtc.h has no need for drm_blend.h, so don't include it. > Avoids useless rebuilds of the entire universe when > touching drm_blend.h. s/drm_blend.h/drm_crtc.h/ > > Quite a few placs do curren

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Randy Dunlap
On 6/15/22 12:28, Alex Deucher wrote: > On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap wrote: >> >> >> >> On 6/14/22 23:01, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20220614: >>> >> >> on i386: >> # CONFIG_DEBUG_FS is not set >> >> >> ../drivers/gpu/drm/amd/amdgpu/../display/amdg

Re: [PATCH v3 2/8] drm: Drop drm_framebuffer.h from drm_crtc.h

2022-06-15 Thread Sam Ravnborg
On Tue, Jun 14, 2022 at 12:54:49PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_crtc.h has no need for drm_frambuffer.h, so don't include it. > Avoids useless rebuilds of the entire universe when > touching drm_framebuffer.h. > > Quite a few placs do currently depend on drm_framebuf

Re: [PATCH 1/8] drm: Drop drm_edid.h from drm_crtc.h

2022-06-15 Thread Sam Ravnborg
Hi Ville, On Mon, Jun 13, 2022 at 11:03:10PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_crtc.h has no need for drm_edid.h, so don't include it. > Avoids useless rebuilds of the entire universe when > touching drm_edid.h. > > Quite a few placs do currently depend on drm_edid.h wit

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Alex Deucher
On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap wrote: > > > > On 6/14/22 23:01, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20220614: > > > > on i386: > # CONFIG_DEBUG_FS is not set > > > ../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function > ‘amdgpu_dm_crtc_lat

Re: [PATCH 01/19] drm/gma500: Unify *_lvds_get_max_backlight()

2022-06-15 Thread Sam Ravnborg
Hi Patrik, > > > > With or without this change the patch is: > > Reviewed-by: Sam Ravnborg > > Hi Sam, > Thanks for having a look. > > I've intentionally tried to change as little as possible from the > version I copied so that any functional change is easy to spot and the > series becomes easy

Re: [Intel-gfx] [PATCH v7] drm/i915/display: disable HPD workers before display driver unregister

2022-06-15 Thread Ville Syrjälä
On Tue, Jun 14, 2022 at 05:06:40PM +0200, Andrzej Hajda wrote: > On 10.06.2022 20:37, Ville Syrjälä wrote: > > On Fri, Jun 10, 2022 at 06:00:24PM +0200, Andrzej Hajda wrote: > >> Handling HPD during driver removal is pointless, and can cause different > >> use-after-free/concurrency issues: > >> 1.

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Randy Dunlap
On 6/14/22 23:01, Stephen Rothwell wrote: > Hi all, > > Changes since 20220614: > on i386: # CONFIG_DEBUG_FS is not set ../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function ‘amdgpu_dm_crtc_late_register’: ../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:

Re: [Freedreno] [PATCH v2 1/5] drm/msm/dpu: check both DPU and MDSS devices for the IOMMU

2022-06-15 Thread Dmitry Baryshkov
On 15/06/2022 20:55, Abhinav Kumar wrote: On 5/4/2022 5:16 PM, Dmitry Baryshkov wrote: Follow the lead of MDP5 driver and check both DPU and MDSS devices for the IOMMU specifiers. Historically DPU devices had IOMMU specified in the MDSS device tree node, but as some of MDP5 devices are being

Re: [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Abhinav Kumar
On 6/15/2022 11:34 AM, Dmitry Baryshkov wrote: On 15/06/2022 20:11, Abhinav Kumar wrote: On 6/15/2022 10:04 AM, Dmitry Baryshkov wrote: On 15/06/2022 19:40, Abhinav Kumar wrote: On 6/15/2022 5:36 AM, Dmitry Baryshkov wrote: On 14/06/2022 22:32, Abhinav Kumar wrote: intf and wb resourc

[PATCH v2 1/2] dt-bindings: arm: sunxi: Add binding for RenewWorldOutReach R16-Vista-E board

2022-06-15 Thread Suniel Mahesh
Add a binding for the RenewWorldOutReach R16-Vista-E board based on allwinner R16. Signed-off-by: Christopher Vollo Signed-off-by: Jagan Teki Signed-off-by: Suniel Mahesh --- Changes for v2: - Add missing compatible string - insert missing signatures of contributors --- Documentation/devicetre

[PATCH] drivers: tty: serial: Add missing of_node_put() in serial-tegra.c

2022-06-15 Thread Liang He
In tegra_uart_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He --- drivers/tty/serial/serial-tegra.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/serial

[PATCH] drm: check for allocation failure of kstrdup_const()

2022-06-15 Thread Li Qiong
As the possible failure of the kstrdup_const(), it should be better to check it and handle it. Signed-off-by: Li Qiong --- drivers/gpu/drm/drm_managed.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_managed.c b/drivers/gpu/drm/drm_managed.c index 4cf214de50c4..d9bd4

[PATCH] drivers: tty: serial: Add missing of_node_put() in serial-tegra.c

2022-06-15 Thread heliang
In tegra_uart_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: heliang --- drivers/tty/serial/serial-tegra.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/serial-

[PATCH v2 0/2] Add R16 Vista E board from RenewWorldOutreach

2022-06-15 Thread Suniel Mahesh
This patch series adds the R16-Vista-E board from RenewWorldOutreach based on allwinner R16(A33). Patch 1/2 adds the dt-bindings for the board. Patch 2/2 adds the board with the following below features: General features: - 1GB RAM - microSD slot - Realtek Wifi - 1 x USB 2.0 - HDMI IN - HDMI OUT

Re: [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Dmitry Baryshkov
On 15/06/2022 20:11, Abhinav Kumar wrote: On 6/15/2022 10:04 AM, Dmitry Baryshkov wrote: On 15/06/2022 19:40, Abhinav Kumar wrote: On 6/15/2022 5:36 AM, Dmitry Baryshkov wrote: On 14/06/2022 22:32, Abhinav Kumar wrote: intf and wb resources are not dependent on the rm global state so need

Re: [PATCH v2] dma-buf: Move sysfs work out of DMA-BUF export path

2022-06-15 Thread Daniel Vetter
On Wed, 15 Jun 2022 at 19:43, T.J. Mercier wrote: > > On Wed, Jun 1, 2022 at 5:40 AM Daniel Vetter wrote: > > > > On Mon, May 30, 2022 at 08:12:16AM +0200, Christian König wrote: > > > Am 25.05.22 um 23:05 schrieb T.J. Mercier: > > > > On Wed, May 25, 2022 at 7:38 AM Daniel Vetter wrote: > > > >

Re: [PATCH v2 3/5] drm/msm: Stop using iommu_present()

2022-06-15 Thread Abhinav Kumar
On 5/4/2022 5:16 PM, Dmitry Baryshkov wrote: Even if some IOMMU has registered itself on the platform "bus", that doesn't necessarily mean it provides translation for the device we care about. Replace iommu_present() with a more appropriate check. On Qualcomm platforms the IOMMU can be specif

Re: [PATCH v2 2/5] drm/msm/mdp5: move iommu_domain_alloc() call close to its usage

2022-06-15 Thread Abhinav Kumar
On 5/4/2022 5:16 PM, Dmitry Baryshkov wrote: Move iommu_domain_alloc() in front of adress space/IOMMU initialization. This allows us to drop final bits of struct mdp5_cfg_platform which remained from the pre-DT days. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers

Re: [PULL] drm-misc-next

2022-06-15 Thread Daniel Vetter
On Wed, Jun 08, 2022 at 12:34:41PM +0200, Thomas Zimmermann wrote: > Hi Dave and Daniel, > > here's the first PR for drm-misc-next that will go into v5.20. > > Best regards > Thomas > > drm-misc-next-2022-06-08: > drm-misc-next for 5.20: > > UAPI Changes: > > * connector: export bpc limits in

Re: [PATCH v4 0/7] usb: typec: Introduce typec-switch binding

2022-06-15 Thread Prashant Malani
I should add: Series submission suggestions (of course, open to better suggestions too): - Patches 1-3 can go through the USB repo. - Patches 4-7 can: + also go through the USB repo after the maintainer acks have been received + go through the DRM repo (after creating a branch from USB repo

Re: [PATCH 05/10] drm: selftest: convert drm_format selftest to KUnit

2022-06-15 Thread kernel test robot
Hi "Maíra, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on linus/master v5.19-rc2 next-20220615] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest t

Re: [PATCH 2/2] drm/msm: Don't overwrite hw fence in hw_init

2022-06-15 Thread Steev Klimaszewski
On 6/15/22 10:01 AM, Rob Clark wrote: From: Rob Clark Prior to the last commit, this could result in setting the GPU written fence value back to an older value, if we had missed updating completed_fence prior to suspend. This was mostly harmless as the GPU would eventually overwrite it again

Re: [PATCH 1/2] drm/msm: Drop update_fences()

2022-06-15 Thread Steev Klimaszewski
On 6/15/22 10:01 AM, Rob Clark wrote: From: Rob Clark I noticed while looking at some traces, that we could miss calls to msm_update_fence(), as the irq could have raced with retire_submits() which could have already popped the last submit on a ring out of the queue of in-flight submits. But

Re: [Freedreno] [PATCH v2 1/3] drm/msm/dpu: Move LM CRC code into separate method

2022-06-15 Thread Jessica Zhang
On 6/15/2022 9:17 AM, Dmitry Baryshkov wrote: On 15/06/2022 19:11, Jessica Zhang wrote: On 6/15/2022 2:35 AM, Dmitry Baryshkov wrote: On Wed, 15 Jun 2022 at 00:13, Jessica Zhang wrote: Move layer mixer-specific section of dpu_crtc_get_crc() into a separate helper method. This way, we can

Re: [Freedreno] [PATCH v2 1/5] drm/msm/dpu: check both DPU and MDSS devices for the IOMMU

2022-06-15 Thread Abhinav Kumar
On 5/4/2022 5:16 PM, Dmitry Baryshkov wrote: Follow the lead of MDP5 driver and check both DPU and MDSS devices for the IOMMU specifiers. Historically DPU devices had IOMMU specified in the MDSS device tree node, but as some of MDP5 devices are being converted to the supported by the DPU driv

Re: [PATCH v4 4/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support

2022-06-15 Thread Krzysztof Kozlowski
On 15/06/2022 10:20, Prashant Malani wrote: > Analogix 7625 can be used in systems to switch USB Type-C DisplayPort > alternate mode lane traffic between 2 Type-C ports. > > Update the binding to accommodate this usage by introducing a switch > property. > > Reviewed-by: Nícolas F. R. A. Prado >

Re: [PATCH v2] dma-buf: Move sysfs work out of DMA-BUF export path

2022-06-15 Thread T.J. Mercier
On Wed, Jun 1, 2022 at 5:40 AM Daniel Vetter wrote: > > On Mon, May 30, 2022 at 08:12:16AM +0200, Christian König wrote: > > Am 25.05.22 um 23:05 schrieb T.J. Mercier: > > > On Wed, May 25, 2022 at 7:38 AM Daniel Vetter wrote: > > > > On Tue, May 17, 2022 at 08:13:24AM +0200, Greg Kroah-Hartman w

[PATCH v4 7/7] drm/bridge: anx7625: Add typec_mux_set callback function

2022-06-15 Thread Prashant Malani
From: Pin-Yen Lin Add the callback function when the driver receives state changes of the Type-C port. The callback function configures the crosspoint switch of the anx7625 bridge chip, which can change the output pins of the signals according to the port state. Reviewed-by: AngeloGioacchino Del

[PATCH v4 6/7] drm/bridge: anx7625: Register Type-C mode switches

2022-06-15 Thread Prashant Malani
When the DT node has "switches" available, register a Type-C mode-switch for each listed "switch". This allows the driver to receive state information about what operating mode a Type-C port and its connected peripherals are in, as well as status information (like VDOs) related to that state. The

[PATCH v4 5/7] drm/bridge: anx7625: Register number of Type C switches

2022-06-15 Thread Prashant Malani
Parse the "switches" node, if available, and count and store the number of Type-C switches within it. Since we currently don't do anything with this info, no functional changes are expected from this change. This patch sets a foundation for the actual registering of Type-C switches with the Type-C

[PATCH v4 4/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support

2022-06-15 Thread Prashant Malani
Analogix 7625 can be used in systems to switch USB Type-C DisplayPort alternate mode lane traffic between 2 Type-C ports. Update the binding to accommodate this usage by introducing a switch property. Reviewed-by: Nícolas F. R. A. Prado Tested-by: Nícolas F. R. A. Prado Signed-off-by: Prashant

[PATCH v4 3/7] dt-bindings: usb: Add Type-C switch binding

2022-06-15 Thread Prashant Malani
Introduce a binding which represents a component that can control the routing of USB Type-C data lines as well as address data line orientation (based on CC lines' orientation). Reviewed-by: Nícolas F. R. A. Prado Tested-by: Nícolas F. R. A. Prado Signed-off-by: Prashant Malani --- Changes sin

[PATCH v4 2/7] usb: typec: mux: Add CONFIG guards for functions

2022-06-15 Thread Prashant Malani
There are some drivers that can use the Type C mux API, but don't have to. Introduce CONFIG guards for the mux functions so that drivers can include the header file and not run into compilation errors on systems which don't have CONFIG_TYPEC enabled. When CONFIG_TYPEC is not enabled, the Type C mux

[PATCH v4 1/7] usb: typec: mux: Allow muxes to specify mode-switch

2022-06-15 Thread Prashant Malani
Loosen the typec_mux_match() requirements so that searches where an alt mode is not specified, but the target mux device lists the "mode-switch" property, return a success. This is helpful in Type C port drivers which would like to get a pointer to the mux switch associated with a Type C port, but

[PATCH v4 0/7] usb: typec: Introduce typec-switch binding

2022-06-15 Thread Prashant Malani
This series introduces a binding for Type-C data lane switches. These control the routing and operating modes of USB Type-C data lanes based on the PD messaging from the Type-C port driver regarding connected peripherals. The first patch introduces a change to the Type-C mux class mode-switch matc

Re: [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Abhinav Kumar
On 6/15/2022 10:04 AM, Dmitry Baryshkov wrote: On 15/06/2022 19:40, Abhinav Kumar wrote: On 6/15/2022 5:36 AM, Dmitry Baryshkov wrote: On 14/06/2022 22:32, Abhinav Kumar wrote: intf and wb resources are not dependent on the rm global state so need not be allocated during dpu_encoder_virt

Re: [Intel-gfx] [PATCH 2/6] drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations

2022-06-15 Thread Umesh Nerlige Ramappa
On Wed, Jun 15, 2022 at 04:27:36PM +0100, Mauro Carvalho Chehab wrote: From: Chris Wilson On gen12 HW, ensure that the TLB of the OA unit is also invalidated as just invalidating the TLB of an engine is not enough. Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Si

Re: [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Dmitry Baryshkov
On 15/06/2022 19:40, Abhinav Kumar wrote: On 6/15/2022 5:36 AM, Dmitry Baryshkov wrote: On 14/06/2022 22:32, Abhinav Kumar wrote: intf and wb resources are not dependent on the rm global state so need not be allocated during dpu_encoder_virt_atomic_mode_set(). Move the allocation of intf a

Re: [PATCH v2 6/7] drm/bridge: anx7625: Register Type-C mode switches

2022-06-15 Thread Prashant Malani
On Wed, Jun 15, 2022 at 1:45 AM AngeloGioacchino Del Regno wrote: > > Il 14/06/22 18:57, Prashant Malani ha scritto: > > On Tue, Jun 14, 2022 at 1:18 AM AngeloGioacchino Del Regno > > wrote: > >> > >> Il 09/06/22 20:09, Prashant Malani ha scritto: > >>> When the DT node has "switches" available,

Re: [PATCH] drm/radeon: Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2022-06-15 Thread Alex Deucher
On Wed, Jun 15, 2022 at 8:33 AM hongao wrote: > > Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi for more > efficiency > > Tested on "Oland [Radeon HD 8570 / R7 240/340 OEM]" & "Caicos [R5 230]" Can you verify that drm_display_info.is_hdmi has been populated when all of these fun

Re: [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Abhinav Kumar
On 6/15/2022 5:36 AM, Dmitry Baryshkov wrote: On 14/06/2022 22:32, Abhinav Kumar wrote: intf and wb resources are not dependent on the rm global state so need not be allocated during dpu_encoder_virt_atomic_mode_set(). Move the allocation of intf and wb resources to dpu_encoder_setup_displa

[PATCH] drm/msm: Fix %d vs %u

2022-06-15 Thread Rob Clark
From: Rob Clark In debugging fence rollover, I noticed that GPU state capture and devcore dumps were showing me negative fence numbers. Let's fix that and some related signed vs unsigned confusion. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 10 +- 1 file ch

Re: [PATCH -next] drm/bridge: it6505: Add missing CRYPTO_HASH dependency

2022-06-15 Thread Robert Foss
On Mon, 13 Jun 2022 at 16:54, Zheng Bin wrote: > > The driver uses crypto hash functions so it needs to select CRYPTO_HASH. > This fixes build errors: > > drivers/gpu/drm/bridge/ite-it6505.o: in function `it6505_hdcp_wait_ksv_list': > ite-it6505.c:(.text+0x4c26): undefined reference to `crypto_all

[PATCH] drm/msm: Fix fence rollover issue

2022-06-15 Thread Rob Clark
From: Rob Clark And while we are at it, let's start the fence counter close to the rollover point so that if issues slip in, they are more obvious. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_fence.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/dr

Re: [PATCH v2 1/3] drm/msm/dpu: Move LM CRC code into separate method

2022-06-15 Thread Dmitry Baryshkov
On 15/06/2022 19:11, Jessica Zhang wrote: On 6/15/2022 2:35 AM, Dmitry Baryshkov wrote: On Wed, 15 Jun 2022 at 00:13, Jessica Zhang wrote: Move layer mixer-specific section of dpu_crtc_get_crc() into a separate helper method. This way, we can make it easier to get CRCs from other HW blocks by

Re: [PATCH v2 3/3] drm/msm/dpu: Add interface support for CRC debugfs

2022-06-15 Thread Jessica Zhang
On 6/15/2022 2:44 AM, Dmitry Baryshkov wrote: On Wed, 15 Jun 2022 at 00:13, Jessica Zhang wrote: Add support for writing CRC values for the interface block to the debugfs by calling the necessary MISR setup/collect methods. Changes since V1: - Set values_cnt to only include phys with backi

Re: [PATCH v2 1/3] drm/msm/dpu: Move LM CRC code into separate method

2022-06-15 Thread Jessica Zhang
On 6/15/2022 2:35 AM, Dmitry Baryshkov wrote: On Wed, 15 Jun 2022 at 00:13, Jessica Zhang wrote: Move layer mixer-specific section of dpu_crtc_get_crc() into a separate helper method. This way, we can make it easier to get CRCs from other HW blocks by adding other get_crc helper methods. C

[PATCH] drm/arm/hdlcd: Simplify IRQ install/uninstall

2022-06-15 Thread Robin Murphy
Since we no longer need to conform to the structure of the various DRM IRQ callbacks, we can streamline the code by consolidating the piecemeal functions and passing around our private data structure directly. We're also a platform device so should never see IRQ_NOTCONNECTED either. Furthermore we

  1   2   >