Re: DMA-buf and uncached system memory

2022-06-22 Thread Christian König
Am 23.06.22 um 01:34 schrieb Daniel Stone: Hi Nicolas, On Wed, 22 Jun 2022 at 20:39, Nicolas Dufresne wrote: Le mardi 16 février 2021 à 10:25 +0100, Daniel Vetter a écrit : So I think if AMD also guarantees to drop clean cachelines just do the same thing we do right now for intel integrated +

[PULL] drm-misc-fixes

2022-06-22 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2022-06-23: Multiple fixes in sun4i for suspend, DDC, DMA setup; A rework of vc4 to properly split the driver between hardware capabilities that wasn't done properly causing multiple crashes; and a panel quirk for Aya Neo

Re: [PATCH 3/5] drm/amdgpu: Prevent race between late signaled fences and GPU reset.

2022-06-22 Thread Christian König
Am 22.06.22 um 19:31 schrieb Andrey Grodzovsky: Just a ping You need to give me at least some time to look into this. Andrey On 2022-06-21 15:45, Andrey Grodzovsky wrote: On 2022-06-21 03:25, Christian König wrote: Am 21.06.22 um 00:03 schrieb Andrey Grodzovsky: Problem: After we start

Re: [PATCH 5/5] drm/amdgpu: Follow up change to previous drm scheduler change.

2022-06-22 Thread Christian König
Am 22.06.22 um 19:19 schrieb Andrey Grodzovsky: On 2022-06-22 03:17, Christian König wrote: Am 21.06.22 um 22:00 schrieb Andrey Grodzovsky: On 2022-06-21 03:28, Christian König wrote: Am 21.06.22 um 00:03 schrieb Andrey Grodzovsky: Align refcount behaviour for amdgpu_job embedded HW fence w

Re: [PATCH] drm: bridge: sii8620: fix possible off-by-one

2022-06-22 Thread Hangyu Hua
On 2022/5/18 15:57, Andrzej Hajda wrote: On 18.05.2022 08:58, Hangyu Hua wrote: The next call to sii8620_burst_get_tx_buf will result in off-by-one When ctx->burst.tx_count + size == ARRAY_SIZE(ctx->burst.tx_buf). The same thing happens in sii8620_burst_get_rx_buf. This patch also change tx

Re: [PATCH] drm: i915: fix a possible refcount leak in intel_dp_add_mst_connector()

2022-06-22 Thread Hangyu Hua
On 2022/5/16 15:19, Hangyu Hua wrote: If drm_connector_init fails, intel_connector_free will be called to take care of proper free. So it is necessary to drop the refcount of port before intel_connector_free. Fixes: 091a4f91942a ("drm/i915: Handle drm-layer errors in intel_dp_add_mst_connector"

Re: [PATCH] gpu: drm: fix possible memory leak in drm_addmap_core()

2022-06-22 Thread Hangyu Hua
On 2022/5/23 09:57, Hangyu Hua wrote: On 2022/5/9 13:44, Hangyu Hua wrote: map->handle need to be handled correctly when map->type is _DRM_SHM or _DRM_CONSISTENT just like map->type is _DRM_REGISTERS. Fixes: 8d153f7107ff ("drm: update user token hashing and map handles") Signed-off-by: Hangyu H

Re: [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

2022-06-22 Thread Dixit, Ashutosh
On Wed, 22 Jun 2022 17:32:25 -0700, Vinay Belgaumkar wrote: > > @@ -208,12 +232,14 @@ static int slpc_force_min_freq(struct intel_guc_slpc > *slpc, u32 freq) >*/ > > with_intel_runtime_pm(&i915->runtime_pm, wakeref) { > - ret = slpc_set_param(slpc, > -

[PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

2022-06-22 Thread Vinay Belgaumkar
SLPC min/max frequency updates require H2G calls. We are seeing timeouts when GuC channel is backed up and it is unable to respond in a timely fashion causing warnings and affecting CI. This is seen when waitboosting happens during a stress test. this patch updates the waitboost path to use a non-

[PATCH v2 1/3] drm/msm/dp: Reorganize code to avoid forward declaration

2022-06-22 Thread Stephen Boyd
Let's move these functions around to avoid having to forward declare dp_ctrl_on_stream_phy_test_report(). Also remove dp_ctrl_reinitialize_mainlink() forward declaration because we're doing that sort of task. Reviewed-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov Signed-off-by: Stephen Boyd --

[PATCH v2 3/3] drm/msm/dp: Get rid of dp_ctrl_on_stream_phy_test_report()

2022-06-22 Thread Stephen Boyd
This API isn't really more than a couple lines now that we don't store the pixel_rate to the struct member. Inline it into the caller. Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 44 1 file changed, 17 insertions(+), 27 de

[PATCH v2 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-22 Thread Stephen Boyd
This struct member is stored to in the function that calls the function which uses it. That's possible with a function argument instead of storing to a struct member. Pass the pixel_rate as an argument instead to simplify the code. Note that dp_ctrl_link_maintenance() was storing the pixel_rate but

[PATCH v2 0/3] drm/msm/dp: More cleanups for force link train

2022-06-22 Thread Stephen Boyd
These patches do a little cleanup on the v9 patch[1] from Kuogee. Changes from v1: * Reduce code even more in second patch * Pick up tags on first patch Stephen Boyd (3): drm/msm/dp: Reorganize code to avoid forward declaration drm/msm/dp: Remove pixel_rate from struct dp_ctrl drm/msm/dp:

Re: DMA-buf and uncached system memory

2022-06-22 Thread Daniel Stone
Hi Nicolas, On Wed, 22 Jun 2022 at 20:39, Nicolas Dufresne wrote: > Le mardi 16 février 2021 à 10:25 +0100, Daniel Vetter a écrit : > > So I think if AMD also guarantees to drop clean cachelines just do the > > same thing we do right now for intel integrated + discrete amd, but in > > reserve. It

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-22 Thread Sierra Guiza, Alejandro (Alex)
On 6/21/2022 11:16 AM, David Hildenbrand wrote: On 21.06.22 18:08, Sierra Guiza, Alejandro (Alex) wrote: On 6/21/2022 7:25 AM, David Hildenbrand wrote: On 21.06.22 13:55, Alistair Popple wrote: David Hildenbrand writes: On 21.06.22 13:25, Felix Kuehling wrote: Am 6/17/22 um 23:19 schrieb

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-22 Thread Sierra Guiza, Alejandro (Alex)
On 6/21/2022 7:16 PM, Alistair Popple wrote: David Hildenbrand writes: On 21.06.22 18:08, Sierra Guiza, Alejandro (Alex) wrote: On 6/21/2022 7:25 AM, David Hildenbrand wrote: On 21.06.22 13:55, Alistair Popple wrote: David Hildenbrand writes: On 21.06.22 13:25, Felix Kuehling wrote: A

Re: [PATCH v2 1/2] agp/intel: Rename intel-gtt symbols

2022-06-22 Thread Lucas De Marchi
On Fri, Jun 17, 2022 at 04:05:58PM -0700, Lucas De Marchi wrote: Exporting the symbols like intel_gtt_* creates some confusion inside i915 that has symbols named similarly. In an attempt to isolate platforms needing intel-gtt.ko, commit 7a5c922377b4 ("drm/i915/gt: Split intel-gtt functions by arc

Re: [RFC 0/3] drm/amd/display: Introduce KUnit to Display Mode Library

2022-06-22 Thread Rodrigo Siqueira Jordao
Hi, First of all, thanks a lot for exploring the introduction of kunit inside amdgpu. See my inline comments On 2022-06-18 05:08, David Gow wrote: On Sat, Jun 18, 2022 at 4:24 AM Maíra Canal wrote: On 6/17/22 04:55, David Gow wrote: On Fri, Jun 17, 2022 at 6:41 AM Maíra Canal wrote: H

Re: [PATCH V2 2/2] drm: xlnx: dsi: Add Xilinx MIPI DSI-Tx subsystem driver

2022-06-22 Thread Laurent Pinchart
Hi GVRao, Thank you for the patch. On Thu, Jun 16, 2022 at 07:47:36PM +0530, Venkateshwar Rao Gannavarapu wrote: > The Xilinx MIPI DSI Tx Subsystem soft IP is used to display video > data from AXI-4 stream interface. > > It supports upto 4 lanes, optional register interface for the DPHY > and mu

[pull] amdgpu drm-fixes-5.19

2022-06-22 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.19. The following changes since commit a111daf0c53ae91e71fd2bfe7497862d14132e3e: Linux 5.19-rc3 (2022-06-19 15:06:47 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.19-2022-06-22 for you to fe

Re: [v3 5/5] drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver

2022-06-22 Thread kernel test robot
Hi Vinod, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-exynos/exynos-drm-next drm-tip/drm-tip tegra-drm/drm/tegra/for-next linus/master v5.19-rc3 next-20220622] [cannot apply to drm-intel/for-linux-next airlied

Re: [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

2022-06-22 Thread Dixit, Ashutosh
On Wed, 22 Jun 2022 13:30:23 -0700, Belgaumkar, Vinay wrote: > On 6/21/2022 5:26 PM, Dixit, Ashutosh wrote: > > On Sat, 14 May 2022 23:05:06 -0700, Vinay Belgaumkar wrote: > > The issue I have is what happens when we de-boost (restore min freq to its > > previous value in intel_guc_slpc_dec_waiters

[drm-misc:drm-misc-next 2/4] drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:25:48: error: invalid use of undefined type 'struct drm_framebuffer'

2022-06-22 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 009a3a52791f31c57d755a73f6bc66fbdd8bd76c commit: 720cf96d8fecde29b72e1101f8a567a0ce99594f [2/4] drm: Drop drm_framebuffer.h from drm_crtc.h config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220623/202206

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-06-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #19 from Harald Judt (h.j...@gmx.at) --- Yes, I definitely removed the patch from comment 11 before testing the new patch set. I will try the other combinations later this week, I am a bit short on time at the moment. -- You may repl

Re: [PATCH V2 1/2] dt-bindings: display: xlnx: Add DSI 2.0 Tx subsystem documentation

2022-06-22 Thread Laurent Pinchart
Hi GVRao, Thank you for the patch. On Thu, Jun 16, 2022 at 07:47:35PM +0530, Venkateshwar Rao Gannavarapu wrote: > This patch adds dt binding for Xilinx DSI-TX subsystem. > > The Xilinx MIPI DSI (Display serial interface) Transmitter Subsystem > implements the Mobile Industry Processor Interface

Re: [PATCH v15 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-06-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-06-21 10:01:29) > This patch add regulator_set_load() before enable regulator at > eDP phy driver. > > Signed-off-by: Kuogee Hsieh > Reviewed-by: Douglas Anderson > Reviewed-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-22 Thread Dixit, Ashutosh
On Fri, 10 Jun 2022 16:47:12 -0700, Vinay Belgaumkar wrote: > > This test will validate we can achieve actual frequency of RP0. Pcode > grants frequencies based on what GuC is requesting. However, thermal > throttling can limit what is being granted. Add a test to request for > max, but don't fail

Re: [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

2022-06-22 Thread Belgaumkar, Vinay
On 6/21/2022 5:26 PM, Dixit, Ashutosh wrote: On Sat, 14 May 2022 23:05:06 -0700, Vinay Belgaumkar wrote: SLPC min/max frequency updates require H2G calls. We are seeing timeouts when GuC channel is backed up and it is unable to respond in a timely fashion causing warnings and affecting CI. Th

Re: [PATCH v2] drm/msm/dp: reset drm_dev to NULL at dp_display_unbind()

2022-06-22 Thread Kuogee Hsieh
On 6/22/2022 1:06 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-06-22 12:55:31) During msm initialize phase, dp_display_unbind() will be called to undo initializations had been done by dp_display_bind() previously if there is error happen at msm_drm_bind. Under this kind of circumstance,

Re: [PATCH v2] drm/msm/dp: reset drm_dev to NULL at dp_display_unbind()

2022-06-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-06-22 12:55:31) > During msm initialize phase, dp_display_unbind() will be called to undo > initializations had been done by dp_display_bind() previously if there is > error happen at msm_drm_bind. Under this kind of circumstance, drm_device > may not be populated complet

Re: Using generic fbdev helpers breaks hibernation

2022-06-22 Thread Alex Deucher
Thanks Thomas. I think this got me on the right track. Alex On Tue, Jun 21, 2022 at 6:25 AM Thomas Zimmermann wrote: > > Hi > > Am 21.06.22 um 00:02 schrieb Alex Deucher: > > Maybe someone more familiar with the generic drm fbdev helpers can > > help me understand why they don't work with hiber

[PATCH v2] drm/msm/dp: reset drm_dev to NULL at dp_display_unbind()

2022-06-22 Thread Kuogee Hsieh
During msm initialize phase, dp_display_unbind() will be called to undo initializations had been done by dp_display_bind() previously if there is error happen at msm_drm_bind. Under this kind of circumstance, drm_device may not be populated completed which causes system crash at drm_dev_dbg(). This

[PULL] drm-intel-next

2022-06-22 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes the first pull request targeting 5.20. Kudos to Jani and Ville for a good driver clean-up. And many other fixes and improvements from the team. drm-intel-next-2022-06-22: - General driver clean-up (Jani, Ville, Julia) - DG2 enabling (Anusha, Vandita) - Fix sparse wa

Re: [PATCH] drm/amd/pm: Fix a typo in comments

2022-06-22 Thread Alex Deucher
Thanks for the patch. This was already fixed last month. Alex On Wed, Jun 22, 2022 at 1:52 AM Zhang Jiaming wrote: > > There is a spelling mistake in comments. > Replace 'paramater' with 'parameter'. > > Signed-off-by: Zhang Jiaming > --- > drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/arcturus_pp

Re: [PATCH] drm/msm/dp: reset drm_dev to NULL at dp_display_unbind()

2022-06-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-06-22 09:54:05) > During msm initialize phase, dp_display_unbind() will be called to undo > initializations had been done by dp_display_bind() previously if there is > error happen at msm_drm_bind. Under this kind of circumstance, drm_device > may not be populated complet

Re: DMA-buf and uncached system memory

2022-06-22 Thread Nicolas Dufresne
Le mardi 16 février 2021 à 10:25 +0100, Daniel Vetter a écrit : > So I think if AMD also guarantees to drop clean cachelines just do the > same thing we do right now for intel integrated + discrete amd, but in > reserve. It's fragile, but it does work. Sorry to disrupt, but if you pass V4L2 vmallo

Re: [PATCH v2 03/68] drm/encoder: Introduce drmm_encoder_init

2022-06-22 Thread kernel test robot
Hi Maxime, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20220622] [also build test WARNING on v5.19-rc3] [cannot apply to drm-misc/drm-misc-next drm-intel/for-linux-next drm-tip/drm-tip linus/master anholt/for-next v5.19-rc3 v5.19-rc2 v5.19-rc1] [If your

Re: [PATCH] gpu/drm/radeon: Fix typo in comments

2022-06-22 Thread Alex Deucher
Applied. Thanks! On Wed, Jun 22, 2022 at 10:24 AM Jiang Jian wrote: > > Remove the repeated word 'and' from comments > > Signed-off-by: Jiang Jian > --- > drivers/gpu/drm/radeon/r300_reg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/r300_reg.

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-22 Thread Niranjana Vishwanathapura
On Wed, Jun 22, 2022 at 09:44:47AM -0700, Niranjana Vishwanathapura wrote: On Wed, Jun 22, 2022 at 04:57:17PM +0100, Tvrtko Ursulin wrote: On 22/06/2022 16:12, Niranjana Vishwanathapura wrote: On Wed, Jun 22, 2022 at 09:10:07AM +0100, Tvrtko Ursulin wrote: On 22/06/2022 04:56, Niranjana Vish

[PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-22 Thread Niranjana Vishwanathapura
VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add I915_GEM_VM_BIND/UNBIND_FENCE_VALID and I915_GEM_VM_BIND_TLB_FLUSH flags. v4: Remove I915_GEM_VM_BIND_TLB_FLUSH flag and add additional documentation for vm_bin

[PATCH v3 2/3] drm/i915: Update i915 uapi documentation

2022-06-22 Thread Niranjana Vishwanathapura
Add some missing i915 upai documentation which the new i915 VM_BIND feature documentation will be refer to. Signed-off-by: Niranjana Vishwanathapura Reviewed-by: Matthew Auld --- include/uapi/drm/i915_drm.h | 205 1 file changed, 160 insertions(+), 45 deleti

[PATCH v4 0/3] drm/doc/rfc: i915 VM_BIND feature design + uapi

2022-06-22 Thread Niranjana Vishwanathapura
This is the i915 driver VM_BIND feature design RFC patch series along with the required uapi definition and description of intended use cases. v2: Reduce the scope to simple Mesa use case. Remove all compute related uapi, vm_bind/unbind queue support and only support a timeline out fence i

[PATCH v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-22 Thread Niranjana Vishwanathapura
VM_BIND design document with description of intended use cases. v2: Reduce the scope to simple Mesa use case. v3: Expand documentation on dma-resv usage, TLB flushing and execbuf3. v4: Remove vm_bind tlb flush request support. Signed-off-by: Niranjana Vishwanathapura --- Documentation/gpu/r

Re: [PATCH] drm/fourcc: fix integer type usage in uapi header

2022-06-22 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jun 22, 2022 at 3:02 AM Simon Ser wrote: > > On Tuesday, June 21st, 2022 at 22:39, Carlos Llamas > wrote: > > > Kernel uapi headers are supposed to use __[us]{8,16,32,64} types defined > > by as opposed to 'uint32_t' and similar. See [1] for the > > relevant dis

Re: [PATCH v2 02/68] drm/crtc: Introduce drmm_crtc_init_with_planes

2022-06-22 Thread kernel test robot
Hi Maxime, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20220622] [also build test WARNING on v5.19-rc3] [cannot apply to drm-misc/drm-misc-next drm-intel/for-linux-next drm-tip/drm-tip linus/master anholt/for-next v5.19-rc3 v5.19-rc2 v5.19-rc1] [If your

Re: [PATCH] drm/ast: Fix black screen when getting out of suspend

2022-06-22 Thread Lyude Paul
Some small nitpicks: On Wed, 2022-06-22 at 14:48 +0200, Jocelyn Falempe wrote: > With an AST2600, the screen is garbage when going out of suspend. > This is because color settings are lost, and not restored on resume. > Force the color settings on DPMS_ON, to make sure the settings are correct. >

Re: [PATCH] drm/msm/dp: reset drm_dev to NULL at dp_display_unbind()

2022-06-22 Thread Dmitry Baryshkov
On 22/06/2022 19:54, Kuogee Hsieh wrote: During msm initialize phase, dp_display_unbind() will be called to undo initializations had been done by dp_display_bind() previously if there is error happen at msm_drm_bind. Under this kind of circumstance, drm_device may not be populated completed which

Re: How do I gather up new code to be converted as patches?

2022-06-22 Thread Sam Ravnborg
Hi Kevin, On Wed, Jun 22, 2022 at 07:18:58PM +0200, Kevin Brace wrote: > Hi, > > How to I use git to gather up new code to be converted to patches? > Specifically, I have 20+ new files in one location (drivers/gpu/drm/via) > and a small change to DRM main make file (drivers/gpu/drm/Makefile). On

Re: [PATCH v15 0/3] eDP/DP Phy vdda realted function

2022-06-22 Thread Dmitry Baryshkov
On 21/06/2022 20:01, Kuogee Hsieh wrote: 0) rebase on https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree 1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp:

Re: [PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-22 Thread Dmitry Baryshkov
On 22/06/2022 18:22, Kuogee Hsieh wrote: On 6/22/2022 12:24 AM, Dmitry Baryshkov wrote: On 22/06/2022 05:59, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-06-17 16:07:58) On 17/06/2022 23:47, Stephen Boyd wrote: This struct member is stored to in the function that calls the function wh

Re: [PATCH v4 0/7] usb: typec: Introduce typec-switch binding

2022-06-22 Thread Prashant Malani
On Wed, Jun 22, 2022 at 8:11 AM Greg Kroah-Hartman wrote: > > On Wed, Jun 22, 2022 at 04:53:40PM +0200, Krzysztof Kozlowski wrote: > > On 21/06/2022 15:17, Greg Kroah-Hartman wrote: > > > On Wed, Jun 15, 2022 at 11:13:33AM -0700, Prashant Malani wrote: > > >> I should add: > > >> > > >> Series sub

Re: [PATCH v4 4/4] drm/msm/dpu: Add interface support for CRC debugfs

2022-06-22 Thread Dmitry Baryshkov
On 22/06/2022 20:18, Jessica Zhang wrote: Add support for writing CRC values for the interface block to the debugfs by calling the necessary MISR setup/collect methods. Changes since V1: - Set values_cnt to only include phys with backing hw_intf - Loop over all drm_encs connected to crtc Change

[PATCH v5 9/9] drm/bridge: it6505: Add typec_mux_set callback function

2022-06-22 Thread Prashant Malani
From: Pin-Yen Lin Add the callback function when the driver receives state changes of the Type-C ports. The callback function configures the lane_swap state and ends up updating the lane swap registers of it6505 bridge chip. Signed-off-by: Pin-Yen Lin Signed-off-by: Prashant Malani --- v5 is

Re: [PATCH v4 1/4] drm/msm/dpu: Move LM CRC code into separate method

2022-06-22 Thread Dmitry Baryshkov
On 22/06/2022 20:18, Jessica Zhang wrote: Move layer mixer-specific section of dpu_crtc_get_crc() into a separate helper method. This way, we can make it easier to get CRCs from other HW blocks by adding other get_crc helper methods. Changes since V1: - Move common bitmasks to dpu_hw_util.h - Mo

[PATCH v5 8/9] drm/bridge: it6505: Register Type-C mode switches

2022-06-22 Thread Prashant Malani
From: Pin-Yen Lin When the DT node has "switches" available, register a Type-C mode-switch for each listed "switch". This allows the driver to receive state information about what operating mode a Type-C port and its connected peripherals are in, as well as status information (like VDOs) related

[PATCH v5 7/9] drm/bridge: it6505: Register number of Type C switches

2022-06-22 Thread Prashant Malani
From: Pin-Yen Lin Parse the "switches" node, if available, and count and store the number of Type-C switches within it. The extcon registration is still supported, but we don't expect both extcon and typec-switch be registered at the same time. This patch sets a foundation for the actual registe

[PATCH v5 6/9] dt/bindings: drm/bridge: it6505: Add mode-switch support

2022-06-22 Thread Prashant Malani
From: Pin-Yen Lin ITE IT6505 can be used in systems to switch USB Type-C DisplayPort alternate mode lane traffic between 2 Type-C ports. Update the binding to accommodate this usage by introducing a switch property. Signed-off-by: Pin-Yen Lin Signed-off-by: Prashant Malani --- v5 is the firs

Re: [Freedreno] [PATCH] drm/msm/dpu: Increment vsync_cnt before waking up userspace

2022-06-22 Thread Jessica Zhang
On 6/21/2022 7:38 PM, Stephen Boyd wrote: The 'vsync_cnt' is used to count the number of frames for a crtc. Unfortunately, we increment the count after waking up userspace via dpu_crtc_vblank_callback() calling drm_crtc_handle_vblank(). drm_crtc_handle_vblank() wakes up userspace processes tha

[PATCH v5 5/9] drm/bridge: anx7625: Add typec_mux_set callback function

2022-06-22 Thread Prashant Malani
From: Pin-Yen Lin Add the callback function when the driver receives state changes of the Type-C port. The callback function configures the crosspoint switch of the anx7625 bridge chip, which can change the output pins of the signals according to the port state. Reviewed-by: AngeloGioacchino Del

Re: [PATCH] drm/msm/dpu: Increment vsync_cnt before waking up userspace

2022-06-22 Thread Dmitry Baryshkov
On 22/06/2022 20:33, Rob Clark wrote: On Wed, Jun 22, 2022 at 10:24 AM Abhinav Kumar wrote: On 6/21/2022 7:38 PM, Stephen Boyd wrote: The 'vsync_cnt' is used to count the number of frames for a crtc. Unfortunately, we increment the count after waking up userspace via dpu_crtc_vblank_callbac

[PATCH v5 4/9] drm/bridge: anx7625: Register Type-C mode switches

2022-06-22 Thread Prashant Malani
When the DT node has "switches" available, register a Type-C mode-switch for each listed "switch". This allows the driver to receive state information about what operating mode a Type-C port and its connected peripherals are in, as well as status information (like VDOs) related to that state. The

[PATCH v5 3/9] drm/bridge: anx7625: Register number of Type C switches

2022-06-22 Thread Prashant Malani
Parse the "switches" node, if available, and count and store the number of Type-C switches within it. Since we currently don't do anything with this info, no functional changes are expected from this change. This patch sets a foundation for the actual registering of Type-C switches with the Type-C

[PATCH v5 2/9] dt-bindings: drm/bridge: anx7625: Add mode-switch support

2022-06-22 Thread Prashant Malani
Analogix 7625 can be used in systems to switch USB Type-C DisplayPort alternate mode lane traffic between 2 Type-C ports. Update the binding to accommodate this usage by introducing a switch property. Reviewed-by: Krzysztof Kozlowski Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Nícolas

[PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-22 Thread Prashant Malani
Introduce a binding which represents a component that can control the routing of USB Type-C data lines as well as address data line orientation (based on CC lines' orientation). Reviewed-by: Krzysztof Kozlowski Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Nícolas F. R. A. Prado Tested-

[PATCH v5 0/9] usb: typec: Introduce typec-switch binding

2022-06-22 Thread Prashant Malani
This series introduces a binding for Type-C data lane switches. These control the routing and operating modes of USB Type-C data lanes based on the PD messaging from the Type-C port driver regarding connected peripherals. The first 2 patches introduce the new "typec-switch" binding as well as one

Re: [PATCH] drm/msm/dpu: Increment vsync_cnt before waking up userspace

2022-06-22 Thread Rob Clark
On Wed, Jun 22, 2022 at 10:24 AM Abhinav Kumar wrote: > > > > On 6/21/2022 7:38 PM, Stephen Boyd wrote: > > The 'vsync_cnt' is used to count the number of frames for a crtc. > > Unfortunately, we increment the count after waking up userspace via > > dpu_crtc_vblank_callback() calling drm_crtc_hand

Re: How do I gather up new code to be converted as patches?

2022-06-22 Thread Jeffrey Hugo
Generating a patch is "git format-patch". This command operates on commits in your local tree. So you need to commit your changes to your local tree. The command for that is "git commit", and it works on staged changes. To stage changes, you need to "git add" them. "git status" can help you vis

Re: [PATCH 3/5] drm/amdgpu: Prevent race between late signaled fences and GPU reset.

2022-06-22 Thread Andrey Grodzovsky
Just a ping Andrey On 2022-06-21 15:45, Andrey Grodzovsky wrote: On 2022-06-21 03:25, Christian König wrote: Am 21.06.22 um 00:03 schrieb Andrey Grodzovsky: Problem: After we start handling timed out jobs we assume there fences won't be signaled but we cannot be sure and sometimes they fire

Re: [PATCH] drm/msm/dpu: Increment vsync_cnt before waking up userspace

2022-06-22 Thread Abhinav Kumar
On 6/21/2022 7:38 PM, Stephen Boyd wrote: The 'vsync_cnt' is used to count the number of frames for a crtc. Unfortunately, we increment the count after waking up userspace via dpu_crtc_vblank_callback() calling drm_crtc_handle_vblank(). drm_crtc_handle_vblank() wakes up userspace processes tha

Re: [PATCH 5/5] drm/amdgpu: Follow up change to previous drm scheduler change.

2022-06-22 Thread Andrey Grodzovsky
On 2022-06-22 03:17, Christian König wrote: Am 21.06.22 um 22:00 schrieb Andrey Grodzovsky: On 2022-06-21 03:28, Christian König wrote: Am 21.06.22 um 00:03 schrieb Andrey Grodzovsky: Align refcount behaviour for amdgpu_job embedded HW fence with classic pointer style HW fences by increasin

How do I gather up new code to be converted as patches?

2022-06-22 Thread Kevin Brace
Hi, I spent about 2 days trying to figure this out, but I guess not a lot of people do this, so I was not able to find a good example somewhere on the Internet. How to I use git to gather up new code to be converted to patches? Specifically, I have 20+ new files in one location (drivers/gpu/drm/v

[PATCH v4 4/4] drm/msm/dpu: Add interface support for CRC debugfs

2022-06-22 Thread Jessica Zhang
Add support for writing CRC values for the interface block to the debugfs by calling the necessary MISR setup/collect methods. Changes since V1: - Set values_cnt to only include phys with backing hw_intf - Loop over all drm_encs connected to crtc Changes since V2: - Remove vblank.h inclusion - Ch

[PATCH v4 3/4] drm/msm/dpu: Add MISR register support for interface

2022-06-22 Thread Jessica Zhang
Add support for setting MISR registers within the interface Changes since V1: - Replaced dpu_hw_intf collect_misr and setup_misr implementations with calls to dpu_hw_utils helper methods Signed-off-by: Jessica Zhang Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.

[PATCH v4 2/4] drm/msm/dpu: Move MISR methods to dpu_hw_util

2022-06-22 Thread Jessica Zhang
Move layer mixer specific MISR methods to generalized helper methods. This will make it easier to add CRC support for other blocks in the future. Changes since V2: - Reordered parameters so that offsets are after hw_blk_reg_map - Fixed mismatched whitespace in bitmask definitions Signed-off-by: J

[PATCH v4 1/4] drm/msm/dpu: Move LM CRC code into separate method

2022-06-22 Thread Jessica Zhang
Move layer mixer-specific section of dpu_crtc_get_crc() into a separate helper method. This way, we can make it easier to get CRCs from other HW blocks by adding other get_crc helper methods. Changes since V1: - Move common bitmasks to dpu_hw_util.h - Move common CRC methods to dpu_hw_util.c - Upd

[PATCH v4 0/4] Expand CRC to support interface blocks

2022-06-22 Thread Jessica Zhang
Refactor existing CRC code for layer mixer and add CRC support for interface blocks Changes since V1: - Create helper methods for collect_misr and setup_misr in dpu_hw_util.c - Move common bitmasks into dpu_hw_util.h - Update copyrights - Create a dynamically allocated crcs array in dpu_crtc_stat

[PATCH] drm/msm/dp: reset drm_dev to NULL at dp_display_unbind()

2022-06-22 Thread Kuogee Hsieh
During msm initialize phase, dp_display_unbind() will be called to undo initializations had been done by dp_display_bind() previously if there is error happen at msm_drm_bind. Under this kind of circumstance, drm_device may not be populated completed which causes system crash at drm_dev_dbg(). This

Re: [PATCH v1 0/9] drm/bridge: ps8640 and ti-sn65dsi86 updates

2022-06-22 Thread Sam Ravnborg
Hi Kieran, On Wed, Jun 22, 2022 at 11:07:26AM +0100, Kieran Bingham wrote: > Hi Sam, > > Quoting Sam Ravnborg (2022-02-06 19:09:11) > > > > > > The code builds - but needs testing. > > > > Hrmff, no it does not build. The fixes was by accident not included. > > Will wait a bit for feedback befo

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-22 Thread Niranjana Vishwanathapura
On Wed, Jun 22, 2022 at 04:57:17PM +0100, Tvrtko Ursulin wrote: On 22/06/2022 16:12, Niranjana Vishwanathapura wrote: On Wed, Jun 22, 2022 at 09:10:07AM +0100, Tvrtko Ursulin wrote: On 22/06/2022 04:56, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Reduce the sco

[PATCH] drm/i915: tweak the ordering in cpu_write_needs_clflush

2022-06-22 Thread Matthew Auld
For imported dma-buf objects we leave the object as cache_coherent = 0 across all platforms, which is reasonable given that have no clue what the memory underneath is, and its not like the driver can ever manually clflush the pages anyway (like with i915_gem_clflush_object) for such objects. Howeve

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-22 Thread Tvrtko Ursulin
On 22/06/2022 16:12, Niranjana Vishwanathapura wrote: On Wed, Jun 22, 2022 at 09:10:07AM +0100, Tvrtko Ursulin wrote: On 22/06/2022 04:56, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation a

Re: [PATCH v8 01/16] clk: generalize devm_clk_get() a bit

2022-06-22 Thread Jon Hunter
On 21/06/2022 21:49, Uwe Kleine-König wrote: On Tue, Jun 21, 2022 at 08:57:00PM +0100, Jon Hunter wrote: Some of our Tegra boards are not booting with the current -next and bisect is pointing to this commit. Looking at the boot log I am seeing the following panic ... [2.097048] 8<--- cut

Re: [PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-22 Thread Kuogee Hsieh
On 6/22/2022 12:24 AM, Dmitry Baryshkov wrote: On 22/06/2022 05:59, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-06-17 16:07:58) On 17/06/2022 23:47, Stephen Boyd wrote: This struct member is stored to in the function that calls the function which uses it. That's possible with a funct

Re: [PATCH v8 1/2] drm/msm/dp: force link training for display resolution change

2022-06-22 Thread Kuogee Hsieh
On 6/22/2022 12:26 AM, Dmitry Baryshkov wrote: On 16/06/2022 20:09, Kuogee Hsieh wrote: Display resolution change is implemented through drm modeset. Older modeset (resolution) has to be disabled first before newer modeset (resolution) can be enabled. Display disable will turn off both pixel c

Re: [PATCH v3 05/13] drm/edid: add drm_edid_connector_update()

2022-06-22 Thread Ville Syrjälä
On Wed, Jun 22, 2022 at 01:59:19PM +0300, Jani Nikula wrote: > Add a new function drm_edid_connector_update() to replace the > combination of calls drm_connector_update_edid_property() and > drm_add_edid_modes(). Usually they are called in the drivers in this > order, however the former needs infor

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-22 Thread Niranjana Vishwanathapura
On Wed, Jun 22, 2022 at 09:10:07AM +0100, Tvrtko Ursulin wrote: On 22/06/2022 04:56, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add I915_GEM_VM_BIND/UNBIND_FENCE_VALID and I9

Re: [PATCH v4 0/7] usb: typec: Introduce typec-switch binding

2022-06-22 Thread Greg Kroah-Hartman
On Wed, Jun 22, 2022 at 04:53:40PM +0200, Krzysztof Kozlowski wrote: > On 21/06/2022 15:17, Greg Kroah-Hartman wrote: > > On Wed, Jun 15, 2022 at 11:13:33AM -0700, Prashant Malani wrote: > >> I should add: > >> > >> Series submission suggestions (of course, open to better suggestions too): > >> - P

Re: [PATCH v4 1/2] drm/panfrost: Add specific register offset macros for JS and MMU AS

2022-06-22 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig On Wed, Jun 22, 2022 at 03:36:15PM +0100, Adri??n Larumbe wrote: > Each Panfrost job has its own job slot and MMU address space set of > registers, which are selected with a job-specific index. > > Turn the shift and stride used for selection of the right register

Re: [PATCH v3 08/13] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid

2022-06-22 Thread Ville Syrjälä
On Wed, Jun 22, 2022 at 01:59:22PM +0300, Jani Nikula wrote: > @@ -948,27 +948,30 @@ void intel_lvds_init(struct drm_i915_private *dev_priv) >* preferred mode is the right one. >*/ > mutex_lock(&dev->mode_config.mutex); > - if (vga_switcheroo_handler_flags() & VGA_SWITCHER

Re: [PATCH 1/5] drm/amdgpu: Fix possible refcount leak for release of external_hw_fence

2022-06-22 Thread Christian König
Am 22.06.22 um 17:01 schrieb Andrey Grodzovsky: On 2022-06-22 05:00, Christian König wrote: Am 21.06.22 um 21:34 schrieb Andrey Grodzovsky: On 2022-06-21 03:19, Christian König wrote: Am 21.06.22 um 00:02 schrieb Andrey Grodzovsky: Problem: In amdgpu_job_submit_direct - The refcount should

Re: [PATCH 1/5] drm/amdgpu: Fix possible refcount leak for release of external_hw_fence

2022-06-22 Thread Andrey Grodzovsky
On 2022-06-22 05:00, Christian König wrote: Am 21.06.22 um 21:34 schrieb Andrey Grodzovsky: On 2022-06-21 03:19, Christian König wrote: Am 21.06.22 um 00:02 schrieb Andrey Grodzovsky: Problem: In amdgpu_job_submit_direct - The refcount should drop by 2 but it drops only by 1. amdgpu_ib_sch

Re: [PATCH] video: fbdev: omap: Remove duplicate 'the' in two places.

2022-06-22 Thread Helge Deller
On 6/21/22 20:54, Jiang Jian wrote: > file: drivers/video/fbdev/omap/sossi.c > line: 362 > * We set explicitly the the bus_pick_count as well, although > changed to > * We set explicitly the bus_pick_count as well, although > > Signed-off-by: Jiang Jian Both patches applied. Thanks! He

[drm-misc:drm-misc-next 1/4] drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:58:17: error: implicit declaration of function 'drm_add_modes_noedid'

2022-06-22 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 62a4ddcb79e073465f21c5cf84d80a2f22820c39 commit: 255490f9150da7c6dabe468f3a877b92fd0f02c1 [1/4] drm: Drop drm_edid.h from drm_crtc.h config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220622/20220609

Re: [PATCH v4 0/7] usb: typec: Introduce typec-switch binding

2022-06-22 Thread Krzysztof Kozlowski
On 21/06/2022 15:17, Greg Kroah-Hartman wrote: > On Wed, Jun 15, 2022 at 11:13:33AM -0700, Prashant Malani wrote: >> I should add: >> >> Series submission suggestions (of course, open to better suggestions too): >> - Patches 1-3 can go through the USB repo. > > I will take patches 1 and 2 now. >

Re: [PATCH v4 3/7] dt-bindings: usb: Add Type-C switch binding

2022-06-22 Thread Krzysztof Kozlowski
On 15/06/2022 19:20, Prashant Malani wrote: > Introduce a binding which represents a component that can control the > routing of USB Type-C data lines as well as address data line > orientation (based on CC lines' orientation). > > Reviewed-by: Nícolas F. R. A. Prado > Tested-by: Nícolas F. R. A.

Re: (subset) [PATCH] drm/vc4: fix error code in vc4_check_tex_size()

2022-06-22 Thread Maxime Ripard
On Wed, 22 Jun 2022 15:25:15 +0300, Dan Carpenter wrote: > The vc4_check_tex_size() function is supposed to return false on error > but this error path accidentally returns -ENODEV (which means true). > > Applied to drm/drm-misc (drm-misc-fixes). Thanks! Maxime

Re: [PATCH v3 04/13] drm/edid: abstract debugfs override EDID set/reset

2022-06-22 Thread Ville Syrjälä
On Wed, Jun 22, 2022 at 01:59:18PM +0300, Jani Nikula wrote: > Add functions drm_edid_override_set() and drm_edid_override_reset() to > support "edid_override" connector debugfs, and to hide the details about > it in drm_edid.c. No functional changes at this time. > > Also note in the connector.ov

Re: [PATCH v3 03/13] drm/edid: clean up connector update error handling and debug logging

2022-06-22 Thread Ville Syrjälä
On Wed, Jun 22, 2022 at 01:59:17PM +0300, Jani Nikula wrote: > Bail out on all errors, debug log all errors, and convert to drm device > based debug logging. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 41 ++ > 1 file changed, 28 insert

Re: [PATCH v3 02/13] drm/edid: convert drm_connector_update_edid_property() to struct drm_edid

2022-06-22 Thread Ville Syrjälä
On Wed, Jun 22, 2022 at 01:59:16PM +0300, Jani Nikula wrote: > Make drm_connector_update_edid_property() a thin wrapper around a struct > drm_edid based version of the same. > > This lets us remove the legacy drm_update_tile_info() and > drm_add_display_info() functions altogether. > > Signed-off

Re: [PATCH v3 01/13] drm/edid: move drm_connector_update_edid_property() to drm_edid.c

2022-06-22 Thread Ville Syrjälä
On Wed, Jun 22, 2022 at 01:59:15PM +0300, Jani Nikula wrote: > The function needs access to drm_edid.c internals more than > drm_connector.c. We can make drm_reset_display_info(), > drm_add_display_info() and drm_update_tile_info() static. There will be > more benefits with follow-up struct drm_edi

  1   2   3   >