Re: [RESEND PATCH libdrm v3 2/2] tests/modetest: Add support for writeback connector

2022-09-01 Thread Dmitry Baryshkov
On 2 September 2022 02:09:24 GMT+03:00, Jessica Zhang wrote: >From: Rohith Iyer > >Add writeback support to modetest with the below options: > >- Passing in -c will now also show the writeback connector > >- Test a built-in mode on writeback connector > >- Test a custom mode from user input o

Re: [RESEND PATCH libdrm v3 1/2] tests/modetest: Allocate drmModeAtomicReq before setting properties

2022-09-01 Thread Dmitry Baryshkov
On 2 September 2022 02:09:23 GMT+03:00, Jessica Zhang wrote: >From: Rohith Iyer > >Fix null pointer deference caused by drmModeAtomicReq being >allocated before set_property was called when modetest was run >with the atomic flag. ... being allocated _after_ ... Other than that: Reviewed-by

Re: [PATCH v1 3/4] drm/msm/mdp4: move resource allocation to the _probe function

2022-09-01 Thread Dmitry Baryshkov
On 2 September 2022 03:24:17 GMT+03:00, Abhinav Kumar wrote: > > >On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: >> To let the probe function bail early if any of the resources is >> unavailable, move resource allocattion from kms_init directly to the >> probe callback. While we are at it, repl

[PATCH v4 11/11] drm/i915/mtl: Do not update GV point, mask value

2022-09-01 Thread Radhakrishna Sripada
Display 14 and future platforms do not directly communicate to Pcode via mailbox the SAGV bandwidth information. PM Demand registers are used to communicate display power requirements to the PUnit which would include GV point and mask value. Skip programming GV point and mask values through legacy

[PATCH v4 06/11] drm/i915/mtl: Add display power wells

2022-09-01 Thread Radhakrishna Sripada
From: Imre Deak Add support for display power wells on MTL. The differences from XE_LPD: - The AUX HW block is moved to the PICA block, where the registers are on an always-on power well and the functionality needs to be powered on/off via the AUX_CH_CTL register: [1], [2] - The DDI IO power

[PATCH v4 10/11] drm/i915/mtl: Update CHICKEN_TRANS* register addresses

2022-09-01 Thread Radhakrishna Sripada
From: Madhumitha Tolakanahalli Pradeep In Display version 14, Transcoder Chicken Registers have updated address. This patch performs checks to use the right register when required. v2: Omit display version check in i915_reg.h(Jani) Bspec: 34387, 50054 Cc: Jani Nikula Signed-off-by: Madhumitha

[PATCH v4 05/11] drm/i915/mtl: Add gmbus and gpio support

2022-09-01 Thread Radhakrishna Sripada
Add tables to map the GMBUS pin pairs to GPIO registers and port to DDC. >From spec we have registers GPIO_CTL[1-5] mapped to native display phys and GPIO_CTL[9-12] are mapped to TC ports. v2: - Drop unused GPIO pins(MattR) BSpec: 49306 Cc: Matt Roper Original Author: Brian J Lovin Signed-off-

[PATCH v4 03/11] drm/i915: Parse and set stepping for platforms with GMD

2022-09-01 Thread Radhakrishna Sripada
From: José Roberto de Souza The GMD step field do not properly match the current stepping convention that we use(STEP_A0, STEP_A1, STEP_B0...). One platform could have { arch = 12, rel = 70, step = 1 } and the actual stepping is STEP_B0 but without the translation of the step field would mean ST

[PATCH v4 01/11] drm/i915: Move display and media IP version to runtime info

2022-09-01 Thread Radhakrishna Sripada
Future platforms can read the IP version from a register and the IP version numbers need not be hard coded in device info. Move the ip version for media and display to runtime info. On platforms where hard coding of IP version is required, update the IP version in __runtime under device_info. v2:

[PATCH v4 08/11] drm/i915/mtl: Obtain SAGV values from MMIO instead of GT pcode mailbox

2022-09-01 Thread Radhakrishna Sripada
>From Meteorlake, Latency Level, SAGV bloack time are read from LATENCY_SAGV register instead of the GT driver pcode mailbox. DDR type and QGV information are also to be read from Mem SS registers. v2: - Simplify MTL_MEM_SS_INFO_QGV_POINT macro(MattR) - Nit: Rearrange the bit def's from higher t

[PATCH v4 07/11] drm/i915/mtl: Add DP AUX support on TypeC ports

2022-09-01 Thread Radhakrishna Sripada
From: Imre Deak On MTL TypeC ports the AUX_CH_CTL and AUX_CH_DATA addresses have changed wrt. previous platforms, adjust the code accordingly. Signed-off-by: Imre Deak Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 45 - drivers/gpu/d

[PATCH v4 04/11] drm/i915/mtl: Define engine context layouts

2022-09-01 Thread Radhakrishna Sripada
From: Matt Roper The part of the media and blitter engine contexts that we care about for setting up an initial state are the same on MTL as they were on DG2 (and PVC), so we need to update the driver conditions to re-use the DG2 context table. For render/compute engines, the part of the context

[PATCH v4 09/11] drm/i915/mtl: Update MBUS_DBOX credits

2022-09-01 Thread Radhakrishna Sripada
Display version 14 platforms have different credits values compared to ADL-P. Update the credits based on pipe usage. v2: Simplify DBOX BW Credit definition(MattR) Bspec: 49213 Cc: Jose Roberto de Souza Cc: Matt Roper Original Author: Caz Yokoyama Signed-off-by: José Roberto de Souza Signed-o

[PATCH v4 02/11] drm/i915: Read graphics/media/display arch version from hw

2022-09-01 Thread Radhakrishna Sripada
From: Matt Roper Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own architecture major.minor versions and stepping ID's which should be read

[PATCH v4 00/11] Initial Meteorlake Support

2022-09-01 Thread Radhakrishna Sripada
The PCI Id's and platform definition are posted earlier. This series adds handful of early enablement patches including support for display power wells, VBT and AUX Channel mapping, PCH and gmbus support, dbus, mbus, sagv and memory bandwidth support. This series also add the support for a new way

Re: [PATCH v1 2/4] drm/msm/dpu: move resource allocation to the _probe function

2022-09-01 Thread Dmitry Baryshkov
On 2 September 2022 00:37:30 GMT+03:00, Abhinav Kumar wrote: > > >On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: >> To let the probe function bail early if any of the resources is >> unavailable, move resource allocattion from kms_init directly to the > allocation Ack >> probe callback. While

Re: [Intel-gfx] [RFC PATCH v3 10/17] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-09-01 Thread Niranjana Vishwanathapura
On Thu, Sep 01, 2022 at 08:58:57AM +0100, Tvrtko Ursulin wrote: On 01/09/2022 06:09, Niranjana Vishwanathapura wrote: On Wed, Aug 31, 2022 at 08:38:48AM +0100, Tvrtko Ursulin wrote: On 27/08/2022 20:43, Andi Shyti wrote: From: Niranjana Vishwanathapura Implement new execbuf3 ioctl (I915_G

[PATCH 1/2] video: fbdev: gbefb: Convert to use dev_groups

2022-09-01 Thread Jiasheng Jiang
The driver core supports the ability to handle the creation and removal of device-specific sysfs files in a race-free manner. Moreover, it can guarantee the success of creation. Therefore, it should be better to convert to use dev_groups. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Jia

[PATCH 2/2] video: fbdev: gbefb: Remove unproper information

2022-09-01 Thread Jiasheng Jiang
When drivers are working properly, they are quiet. Therefore, the fb_info() should be removed. Signed-off-by: Jiasheng Jiang --- drivers/video/fbdev/gbefb.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c index 1582c718329c..7e39ab

[git pull] drm fixes for 6.0-rc4

2022-09-01 Thread Dave Airlie
Hi Linus, Regular fixes pull. One core dma-buf fix, then two weeks of i915 fixes, a lot of amdgpu fixes mostly for new IP, and a bunch of msm fixes, mostly modesetting ones. Nothing seems too bad at this point. Dave. drm-fixes-2022-09-02: drm fixes for 6.0-rc4 dma-buf/dma-resv: - Fence-handlin

[PATCH v3] drm/ast: add dmabuf/prime buffer sharing support

2022-09-01 Thread oushixiong
This patch adds ast specific codes for DRM prime feature, this is to allow for offloading of rending in one direction and outputs in other. This patch is designed to solve the problem that the AST is not displayed when the server plug in a discrete graphics card at the same time. We call the dirt

Re: [PATCH v1 4/4] drm/msm/mdp5: move resource allocation to the _probe function

2022-09-01 Thread Abhinav Kumar
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: To let the probe function bail early if any of the resources is unavailable, move resource allocattion from kms_init directly to the probe callback. Seems to be the common typo in all the patches of this series allocattion -> allocation Apart f

[PATCH 3/7] drm/i915/gt: Drop a few unused register definitions

2022-09-01 Thread Matt Roper
Let's drop a few register definitions that are unused anywhere in the driver today. Since the referenced offsets are part of what is now considered a multicast register region, the current definitions would not be correct for use on any future platform. Signed-off-by: Matt Roper --- drivers/gpu

[PATCH 5/7] drm/i915: Define MCR registers explicitly

2022-09-01 Thread Matt Roper
Rather than using the same _MMIO() macro to define MCR registers as singleton registers, let's use a new MCR_REG() macro to make it clear that these registers are special and should be handled accordingly. For now MCR_REG() will still generate an i915_reg_t with the given offset, but we'll change

[PATCH 4/7] drm/i915/gt: Correct prefix on a few registers

2022-09-01 Thread Matt Roper
We have a few registers that have existed for several hardware generations, but are only used by the driver on Xe_HP and beyond. In cases where the Xe_HP version of the register is now replicated and uses multicast behavior, but earlier generations were singleton, let's change the register prefix

[PATCH 6/7] drm/i915/gt: Always use MCR functions on multicast registers

2022-09-01 Thread Matt Roper
Rather than relying on the implicit behavior of intel_uncore_*() functions, let's always use the intel_gt_mcr_*() functions to operate on multicast/replicated registers. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 4 +- drivers/gpu/drm/i915/gt/intel_gtt.c | 4

[PATCH 7/7] drm/i915/gt: Add MCR-specific workaround initializers

2022-09-01 Thread Matt Roper
Let's be more explicit about which of our workarounds are updating MCR registers. This will also allow us to record whether a workaround register has MCR behavior or not so that we'll only need to do a steering lookup for the registers that truly need it. Signed-off-by: Matt Roper --- drivers/g

[PATCH 2/7] drm/i915/xehp: Create separate reg definitions for new MCR registers

2022-09-01 Thread Matt Roper
Starting in Xe_HP, several registers our driver works with have been converted from singleton registers into replicated registers with multicast behavior. Although the registers are still located at the same MMIO offsets as on previous platforms, let's duplicate the register definitions in prepara

[PATCH 1/7] drm/i915/gen8: Create separate reg definitions for new MCR registers

2022-09-01 Thread Matt Roper
Gen8 was the first time our hardware had multicast registers (or at least the first time the multicast nature was exposed and MMIO accesses could be steered). There are some registers that transitioned from singleton behavior to multicast during the gen7 -> gen8 transition; let's duplicate the reg

[PATCH 0/7] i915: Prep work for explicit MCR handling

2022-09-01 Thread Matt Roper
Steering of multicast/replicated registers becomes a bit more complicated on Meteor Lake. Whereas previously the control register we used to manage the steering was only used by our driver[*], software's control of steering has now been consolidated with the controls for various other hardware/fir

Re: [PATCH v1 3/4] drm/msm/mdp4: move resource allocation to the _probe function

2022-09-01 Thread Abhinav Kumar
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: To let the probe function bail early if any of the resources is unavailable, move resource allocattion from kms_init directly to the probe callback. While we are at it, replace irq_of_parse_and_map() with platform_get_irq(). Signed-off-by: Dmitry

Re: [PATCH 8/8] drm/i915/mtl: Hook up interrupts for standalone media

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/29/2022 10:02 AM, Matt Roper wrote: Top-level handling of standalone media interrupts will be processed as part of the primary GT's interrupt handler (since primary and media GTs share an MMIO space, unlike remote tile setups). When we get down to the point of handling engine interrupts,

Re: [PATCH 7/8] drm/i915/mtl: Use primary GT's irq lock for media GT

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/29/2022 10:02 AM, Matt Roper wrote: When we hook up interrupts (in the next patch), interrupts for the media GT are still processed as part of the primary GT's interrupt flow. As such, we should share the same IRQ lock with the primary GT. Let's convert gt->irq_lock into a pointer and j

Re: [Intel-gfx] [PATCH 6/8] drm/i915/xelpmp: Expose media as another GT

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/29/2022 10:02 AM, Matt Roper wrote: Xe_LPM+ platforms have "standalone media." I.e., the media unit is designed as an additional GT with its own engine list, GuC, forcewake, etc. Let's allow platforms to include media GTs in their device info. Cc: Aravind Iddamsetty Signed-off-by: Mat

[RESEND PATCH libdrm v3 0/2] Add Writeback Support for Modetest

2022-09-01 Thread Jessica Zhang
Resending to correct typo in email list and adding "Signed-off-by" to Patch [1/2] ("tests/modetest: Allocate drmModeAtomicReq before setting properties" --- Add writeback support to modetest with the below options: - Passing in -c will now also show the writeback connector - Test a built-in mod

[RESEND PATCH libdrm v3 1/2] tests/modetest: Allocate drmModeAtomicReq before setting properties

2022-09-01 Thread Jessica Zhang
From: Rohith Iyer Fix null pointer deference caused by drmModeAtomicReq being allocated before set_property was called when modetest was run with the atomic flag. Reviewed-by: Rob Clark Signed-off-by: Rohith Iyer Signed-off-by: Jessica Zhang --- tests/modetest/modetest.c | 4 +++- 1 file cha

[RESEND PATCH libdrm v3 2/2] tests/modetest: Add support for writeback connector

2022-09-01 Thread Jessica Zhang
From: Rohith Iyer Add writeback support to modetest with the below options: - Passing in -c will now also show the writeback connector - Test a built-in mode on writeback connector - Test a custom mode from user input on writeback connector Usage: "./modetest -M msm -x : -a -P @:

Re: [PATCH v2 20/41] drm/modes: Properly generate a drm_display_mode from a named mode

2022-09-01 Thread Mateusz Kwiatkowski
Hi Maxime, > +        if (!named_mode->tv_mode) > +            continue; As mentioned in the previous email replying to 19/41, this makes it impossible to specify DRM_MODE_TV_MODE_NTSC_443 as currently defined in the named mode successfully. Best regards, Mateusz Kwiatkowski

Re: [PATCH v2 19/41] drm/modes: Introduce the tv_mode property as a command-line option

2022-09-01 Thread Mateusz Kwiatkowski
Hi Maxime, > @@ -2212,20 +2239,22 @@ struct drm_named_mode { >      unsigned int xres; >      unsigned int yres; >      unsigned int flags; > +    unsigned int tv_mode; >  }; Are _all_ named modes supposed to be about analog TV? If so, then probably this structure should be renamed drm_named_ana

Re: [PATCH v2 2/2] drm/tests: Change "igt_" prefix to "test_drm_"

2022-09-01 Thread Maíra Canal
Hi Maxime, On 9/1/22 09:55, Maxime Ripard wrote: > Hi, > > On Thu, Sep 01, 2022 at 09:42:10AM -0300, Maíra Canal wrote: >> With the introduction of KUnit, IGT is no longer the only option to run >> the DRM unit tests, as the tests can be run through kunit-tool or on >> real hardware with CONFIG_K

RE: [Intel-gfx] [PATCH v3 02/11] drm/i915: Read graphics/media/display arch version from hw

2022-09-01 Thread Sripada, Radhakrishna
Hi Jani, > -Original Message- > From: Jani Nikula > Sent: Thursday, September 1, 2022 12:58 AM > To: Sripada, Radhakrishna ; intel- > g...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v3 02/11] drm/i915: Read > graphics/media/display > arc

Re: [PATCH v2 09/41] drm/connector: Add TV standard property

2022-09-01 Thread Mateusz Kwiatkowski
Hi Maxime, W dniu 29.08.2022 o 15:11, Maxime Ripard pisze: > The TV mode property has been around for a while now to select and get the > current TV mode output on an analog TV connector. > > Despite that property name being generic, its content isn't and has been > driver-specific which makes it

Re: [PATCH v1 2/4] drm/msm/dpu: move resource allocation to the _probe function

2022-09-01 Thread Abhinav Kumar
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: To let the probe function bail early if any of the resources is unavailable, move resource allocattion from kms_init directly to the allocation probe callback. While we are at it, replace irq_of_parse_and_map() with platform_get_irq(). Any spec

[linux-next:master] BUILD REGRESSION e47eb90a0a9ae20b82635b9b99a8d0979b757ad8

2022-09-01 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: e47eb90a0a9ae20b82635b9b99a8d0979b757ad8 Add linux-next specific files for 20220901 Error/Warning reports: https://lore.kernel.org/linux-media/202209020437.exeodmfe-...@intel.com https

[PATCH 2/2] drm/msm/dpu: Add support for P010 format

2022-09-01 Thread Jessica Zhang
Add support for P010 color format. This adds support for both linear and compressed formats. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c| 17 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

[PATCH 1/2] drm/msm/dpu: Add support for XR30 format

2022-09-01 Thread Jessica Zhang
Add support for XR30 color format. This supports both linear and compressed formats. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c| 7 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 1 + 3 files c

[PATCH 0/2] Add support for HDR color formats

2022-09-01 Thread Jessica Zhang
Add support for HDR color formats. XR30 linear/compressed format has been validated with null_platform_test on SC7180, and P010 linear has been validated with plane_test (also on SC7180). Jessica Zhang (2): drm/msm/dpu: Add support for XR30 format drm/msm/dpu: Add support for P010 format dr

Re: [PATCH v6 3/6] clk: qcom: gdsc: Add a reset op to poll gdsc collapse

2022-09-01 Thread Akhil P Oommen
On 9/1/2022 3:58 PM, Philipp Zabel wrote: On Wed, Aug 31, 2022 at 10:48:24AM +0530, Akhil P Oommen wrote: Add a reset op compatible function to poll for gdsc collapse. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov --- (no changes since v2) Changes in v2: - Minor update to func

Re: [PATCH 2/9] drm/nouveau: convert to using is_hdmi and has_audio from display info

2022-09-01 Thread Lyude Paul
Reviewed-by: Lyude Paul Also, went ahead and tested this for you on one of my machines: Tested-by: Lyude Paul On Thu, 2022-09-01 at 15:47 +0300, Jani Nikula wrote: > Prefer the parsed results for is_hdmi and has_audio in display info over > calling drm_detect_hdmi_monitor() and drm_detect_moni

Re: [RFC PATCH v3 04/17] drm/i915: Implement bind and unbind of object

2022-09-01 Thread Niranjana Vishwanathapura
On Thu, Sep 01, 2022 at 03:31:13PM +1000, Dave Airlie wrote: On Sun, 28 Aug 2022 at 05:45, Andi Shyti wrote: From: Niranjana Vishwanathapura Implement the bind and unbind of an object at the specified GPU virtual addresses. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Prathap Ku

Re: [Freedreno] [PATCH v6 2/6] clk: qcom: Allow custom reset ops

2022-09-01 Thread Akhil P Oommen
On 9/1/2022 3:47 PM, Philipp Zabel wrote: Hi Akhil, On Wed, Aug 31, 2022 at 10:48:23AM +0530, Akhil P Oommen wrote: Allow soc specific clk drivers to specify a custom reset operation. We will use this in an upcoming patch to allow gpucc driver to specify a differet reset operation for cx_gdsc.

Re: [Freedreno] [PATCH v6 4/6] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-09-01 Thread Akhil P Oommen
On 9/1/2022 4:16 PM, Dmitry Baryshkov wrote: On 01/09/2022 13:34, Philipp Zabel wrote: On Wed, Aug 31, 2022 at 10:48:25AM +0530, Akhil P Oommen wrote: Allow a consumer driver to poll for cx gdsc collapse through Reset framework. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov ---

Re: [PATCH v2 00/41] drm: Analog TV Improvements

2022-09-01 Thread Noralf Trønnes
Den 29.08.2022 15.11, skrev Maxime Ripard: > Hi, > > > > Here's a series aiming at improving the command line named modes support, > > and more importantly how we deal with all the analog TV variants. > > > > The named modes support were initially introduced to allow to specify the > > a

Re: [PATCH] kernel/panic: Drop unblank_screen call

2022-09-01 Thread Daniel Vetter
On Thu, 1 Sept 2022 at 13:35, Petr Mladek wrote: > > On Tue 2022-08-30 16:50:04, Daniel Vetter wrote: > > console_unblank() does this too (called in both places right after), > > and with a lot more confidence inspiring approach to locking. > > > > Reconstructing this story is very strange: > > >

Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-01 Thread Noralf Trønnes
Den 29.08.2022 15.11, skrev Maxime Ripard: > Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and > > 625-lines modes in their drivers. > > > > Since those modes are fairly standard, and that we'll need to use them > > in more places in the future, it makes sense to move thei

[PATCH] drm/i915: Rename ggtt_view as gtt_view

2022-09-01 Thread Niranjana Vishwanathapura
So far, different views (normal, partial, rotated and remapped) into the same object are only supported for GGTT mappings. But with the upcoming VM_BIND feature, PPGTT will also use the partial view mapping. Hence rename ggtt_view to more generic gtt_view. Signed-off-by: Niranjana Vishwanathapura

Re: [PATCH 1/3] drm/i915: audit bo->resource usage

2022-09-01 Thread Thomas Hellström
On Wed, 2022-08-31 at 15:34 +0200, Christian König wrote: > Am 31.08.22 um 14:50 schrieb Matthew Auld: > > On 31/08/2022 13:35, Christian König wrote: > > > Am 31.08.22 um 14:06 schrieb Matthew Auld: > > > > On 31/08/2022 12:03, Christian König wrote: > > > > > Am 31.08.22 um 12:37 schrieb Matthew

Re: [Intel-gfx] [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure

2022-09-01 Thread Das, Nirmoy
On 9/1/2022 5:57 PM, Andrzej Hajda wrote: On 31.08.2022 18:18, Nirmoy Das wrote: On system suspend when system memory is low then i915_gem_obj_copy_ttm() could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough, suspend shouldn't continue if i915_ttm_backup() throws an error. Refer

[PATCH v3] drm/i915/ttm: Abort suspend on i915_ttm_backup failure

2022-09-01 Thread Nirmoy Das
On system suspend when system memory is low then i915_gem_obj_copy_ttm() could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough, suspend shouldn't continue if i915_ttm_backup() throws an error. v2: Keep the fdo issue till we have a igt test(Matt). v3: Use %pe(Andrzej) References: htt

Re: [Intel-gfx] [PATCH] drm/i915: prevent integer overflow in query_engine_info()

2022-09-01 Thread Andrzej Hajda
On 01.09.2022 17:38, Dan Carpenter wrote: This code uses struct_size() but it stores the result in an int so the integer overflow checks are not effective. Record the types as size_t to prevent the size from being truncated. Fixes: bf3c50837506 ("drm/i915/query: Use struct_size() helper") Signe

Re: [Intel-gfx] [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure

2022-09-01 Thread Andrzej Hajda
On 31.08.2022 18:18, Nirmoy Das wrote: On system suspend when system memory is low then i915_gem_obj_copy_ttm() could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough, suspend shouldn't continue if i915_ttm_backup() throws an error. References: https://gitlab.freedesktop.org/drm/int

Re: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()

2022-09-01 Thread Rodrigo Siqueira Jordao
On 2022-09-01 10:15, Hamza Mahfooz wrote: Address the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 3508 | if (update_type != UPDATE_TYPE_FAST) | ^~ drivers/gpu/drm/

[PATCH] drm/i915: prevent integer overflow in query_engine_info()

2022-09-01 Thread Dan Carpenter
This code uses struct_size() but it stores the result in an int so the integer overflow checks are not effective. Record the types as size_t to prevent the size from being truncated. Fixes: bf3c50837506 ("drm/i915/query: Use struct_size() helper") Signed-off-by: Dan Carpenter --- I do not know i

Re: [PATCH v3 02/15] mei: add support to GSC extended header

2022-09-01 Thread Greg Kroah-Hartman
On Fri, Aug 19, 2022 at 03:53:22PM -0700, Daniele Ceraolo Spurio wrote: > --- a/drivers/misc/mei/hw-me.c > +++ b/drivers/misc/mei/hw-me.c > @@ -590,7 +590,10 @@ static int mei_me_hbuf_write(struct mei_device *dev, > u32 dw_cnt; > int empty_slots; > > - if (WARN_ON(!hdr || !data ||

Re: [PATCH] drm: Simplify testing on UML with kunit.py

2022-09-01 Thread Maxime Ripard
On Thu, Sep 01, 2022 at 04:49:09PM +0200, Michał Winiarski wrote: > On Thu, Sep 01, 2022 at 04:02:53PM +0200, Maxime Ripard wrote: > > Hi, > > > > On Thu, Sep 01, 2022 at 03:36:21PM +0200, Michał Winiarski wrote: > > > DRM depends on IOMEM and DMA, introduce an additional Kconfig to pull in > > >

Re: [PATCH] drm: Simplify testing on UML with kunit.py

2022-09-01 Thread Michał Winiarski
On Thu, Sep 01, 2022 at 04:02:53PM +0200, Maxime Ripard wrote: > Hi, > > On Thu, Sep 01, 2022 at 03:36:21PM +0200, Michał Winiarski wrote: > > DRM depends on IOMEM and DMA, introduce an additional Kconfig to pull in > > IOMEM and DMA emulation on UML. > > Since --kconfig_add usage is no longer nee

Re: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()

2022-09-01 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: Mahfooz, Hamza Sent: Thursday, September 1, 2022 10:15 AM To: linux-ker...@vger.kernel.org Cc: Mahfooz, Hamza ; Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Deucher, Alexander ; Koenig, Christian ; Pan, Xin

[PATCH 0/4] RDMA/mlx5: Support DMABUF in umems and enable ATS

2022-09-01 Thread Jason Gunthorpe
This series adds support for DMABUF when creating a devx umem. devx umems are quite similar to MR's execpt they cannot be revoked, so this uses the dmabuf pinned memory flow. Several mlx5dv flows require umem and cannot work with MR. The intended use case is primarily for P2P transfers using dmabu

[PATCH 1/4] net/mlx5: Add IFC bits for mkey ATS

2022-09-01 Thread Jason Gunthorpe
Allows telling a mkey to use PCI ATS for DMA that flows through it. Signed-off-by: Jason Gunthorpe --- include/linux/mlx5/mlx5_ifc.h | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index 4acd5610e96bc0.

[PATCH 4/4] RDMA/mlx5: Enable ATS support for MRs and umems

2022-09-01 Thread Jason Gunthorpe
For mlx5 if ATS is enabled in the PCI config then the device will use ATS requests for only certain DMA operations. This has to be opted in by the SW side based on the mkey or umem settings. ATS slows down the PCI performance, so it should only be set in cases when it is needed. All of these cases

[PATCH 3/4] RDMA/mlx5: Add support for dmabuf to devx umem

2022-09-01 Thread Jason Gunthorpe
This is modeled after the similar EFA enablement in commit 66f4817b5712 ("RDMA/efa: Add support for dmabuf memory regions"). Like EFA there is no support for revocation so we simply call the ib_umem_dmabuf_get_pinned() to obtain a umem instead of the normal ib_umem_get(). Everything else stays th

[PATCH 2/4] RDMA/core: Add UVERBS_ATTR_RAW_FD

2022-09-01 Thread Jason Gunthorpe
This uses the same passing protocol as UVERBS_ATTR_FD (eg len = 0 data_s64 = fd), except that the FD is not required to be a uverbs object and the core code does not covert the FD to an object handle automatically. Access to the int fd is provided by uverbs_get_raw_fd(). Signed-off-by: Jason Gunt

[PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()

2022-09-01 Thread Hamza Mahfooz
Address the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 3508 | if (update_type != UPDATE_TYPE_FAST) | ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note:

RE: [PATCH v4 06/21] drm/i915: Prepare to dynamic dma-buf locking specification

2022-09-01 Thread Ruhl, Michael J
>-Original Message- >From: Dmitry Osipenko >Sent: Wednesday, August 31, 2022 11:38 AM >To: David Airlie ; Gerd Hoffmann ; >Gurchetan Singh ; Chia-I Wu >; Daniel Vetter ; Daniel Almeida >; Gert Wollny ; >Gustavo Padovan ; Daniel Stone >; Tomeu Vizoso ; >Maarten Lankhorst ; Maxime Ripard >;

Re: [PATCH] drm: Simplify testing on UML with kunit.py

2022-09-01 Thread Maxime Ripard
Hi, On Thu, Sep 01, 2022 at 03:36:21PM +0200, Michał Winiarski wrote: > DRM depends on IOMEM and DMA, introduce an additional Kconfig to pull in > IOMEM and DMA emulation on UML. > Since --kconfig_add usage is no longer needed, remove it from > documentation. > > Signed-off-by: Michał Winiarski

[PULL] drm-intel-fixes

2022-09-01 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2022-09-01: - GVT fixes including fix for a CommetLake regression in mmio table and misc doc and typo fixes (Julia, Jiapeng, Colin, Alex) - Fix CCS handling (Matt) - Fix for guc requests after reset (Daniele) - Display DSI related fixes (Jani) - Dis

[PATCH] drm: Simplify testing on UML with kunit.py

2022-09-01 Thread Michał Winiarski
DRM depends on IOMEM and DMA, introduce an additional Kconfig to pull in IOMEM and DMA emulation on UML. Since --kconfig_add usage is no longer needed, remove it from documentation. Signed-off-by: Michał Winiarski --- Documentation/gpu/drm-internals.rst | 7 +-- drivers/video/Kconfig

[PATCH] drm/bridge: tc358775: Do not soft reset i2c-slave controller

2022-09-01 Thread Teresa Remmet
Soft reset during tc_bridge_enable() is triggered by setting all available reset control bits in the SYSRST register. But as noted in the data sheet resetting the i2c-slave controller should be only done over DSI and is only useful for chip debugging. So do not set RSTI2CS (bit0). Signed-off-by: T

Re: [PATCH v2 2/2] drm/tests: Change "igt_" prefix to "test_drm_"

2022-09-01 Thread Javier Martinez Canillas
On 9/1/22 14:55, Maxime Ripard wrote: > Hi, > > On Thu, Sep 01, 2022 at 09:42:10AM -0300, Maíra Canal wrote: >> With the introduction of KUnit, IGT is no longer the only option to run >> the DRM unit tests, as the tests can be run through kunit-tool or on >> real hardware with CONFIG_KUNIT. >> >>

Re: [PATCH v2 2/2] drm/tests: Change "igt_" prefix to "test_drm_"

2022-09-01 Thread Maxime Ripard
Hi, On Thu, Sep 01, 2022 at 09:42:10AM -0300, Maíra Canal wrote: > With the introduction of KUnit, IGT is no longer the only option to run > the DRM unit tests, as the tests can be run through kunit-tool or on > real hardware with CONFIG_KUNIT. > > Therefore, remove the "igt_" prefix from the tes

Re: [PATCH 1/3] drm/i915: audit bo->resource usage

2022-09-01 Thread Matthew Auld
On 01/09/2022 09:00, Christian König wrote: Am 31.08.22 um 18:32 schrieb Matthew Auld: On 31/08/2022 15:53, Matthew Auld wrote: On 31/08/2022 14:34, Christian König wrote: Am 31.08.22 um 14:50 schrieb Matthew Auld: On 31/08/2022 13:35, Christian König wrote: Am 31.08.22 um 14:06 schrieb Matt

[PATCH v2 1/2] drm/tests: Split drm_framebuffer_create_test into parameterized tests

2022-09-01 Thread Maíra Canal
The igt_check_drm_framebuffer_create is based on a loop that executes tests for all createbuffer_tests test cases. This could be better represented by parameterized tests, provided by KUnit. So, convert the igt_check_drm_framebuffer_create into parameterized tests. Signed-off-by: Maíra Canal Rev

[PATCH v2 2/2] drm/tests: Change "igt_" prefix to "test_drm_"

2022-09-01 Thread Maíra Canal
With the introduction of KUnit, IGT is no longer the only option to run the DRM unit tests, as the tests can be run through kunit-tool or on real hardware with CONFIG_KUNIT. Therefore, remove the "igt_" prefix from the tests and replace it with the "test_drm_" prefix, making the tests' names indep

[PATCH 9/9] drm/rockchip: convert to using has_audio from display_info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for has_audio in display info over calling drm_detect_monitor_audio(). Cc: Sandy Huang Cc: Heiko Stübner Signed-off-by: Jani Nikula --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 ++-- drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++- 2 files changed, 4 insertions(+), 3

[PATCH 8/9] drm/rockchip: cdn-dp: call drm_connector_update_edid_property() unconditionally

2022-09-01 Thread Jani Nikula
Calling drm_connector_update_edid_property() should be done unconditionally instead of depending on the number of modes added. Also match the call order in inno_hdmi and rk3066_hdmi. Cc: Sandy Huang Cc: Heiko Stübner Signed-off-by: Jani Nikula --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 5 ++-

[PATCH 7/9] drm/sti/sti_hdmi: convert to using is_hdmi from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi in display info over calling drm_detect_hdmi_monitor(). Remove the now redundant hdmi_monitor member from struct sti_hdmi. Cc: Alain Volmat Signed-off-by: Jani Nikula --- drivers/gpu/drm/sti/sti_hdmi.c | 11 ++- drivers/gpu/drm/sti/sti_hdmi.h | 2 -

[PATCH 6/9] drm/i2c/tda998x: convert to using has_audio from display_info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for has_audio in display info over calling drm_detect_monitor_audio(). Cc: Russell King Signed-off-by: Jani Nikula --- drivers/gpu/drm/i2c/tda998x_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu

[PATCH 5/9] drm/exynos: convert to using is_hdmi from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi in display info over calling drm_detect_hdmi_monitor(). Cc: Inki Dae Cc: Seung-Woo Kim Cc: Kyungmin Park Signed-off-by: Jani Nikula --- drivers/gpu/drm/exynos/exynos_hdmi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/g

[PATCH 4/9] drm/tegra: convert to using is_hdmi from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi in display info over calling drm_detect_hdmi_monitor(). Cc: Thierry Reding Cc: linux-te...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/tegra/hdmi.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/dr

[PATCH 3/9] drm/radeon: convert to using is_hdmi and has_audio from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi and has_audio in display info over calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(), respectively. Cc: Alex Deucher Cc: Christian König Cc: "Pan, Xinhui" Cc: amd-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/rade

[PATCH 2/9] drm/nouveau: convert to using is_hdmi and has_audio from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi and has_audio in display info over calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(), respectively. Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude Paul Cc: nouv...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/nouveau/disp

[PATCH 1/9] drm/edid: parse display info has_audio similar to is_hdmi

2022-09-01 Thread Jani Nikula
Since we already iterate everything that's needed for determining audio, reduce the need to call drm_detect_monitor_audio() by storing has_audio to connector info. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 6 ++ include/drm/drm_connector.h | 8 2 files changed, 14

[PATCH 0/9] drm: convert to using is_hdmi and has_audio from display info

2022-09-01 Thread Jani Nikula
The low-hanging fruit of the drm todo item "Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi", with has_audio changes on top. I'm afraid not all of these have been even build tested, let alone actually tested. BR, Jani. Cc: Laurent Pinchart Cc: Sandy Huang Cc: Heiko Stübner

Re: [PATCH v2 2/2] drm/plane_helper: Split into parameterized test cases

2022-09-01 Thread Maíra Canal
Hi Michał On 8/31/22 17:45, Michał Winiarski wrote: > The test was constructed as a single function (test case) which checks > multiple conditions, calling the function that is tested multiple times > with different arguments. > This usually means that it can be easily converted into multiple test

Re: [PATCH v6 0/3] drm/bridge: ti-sn65dsi86: Basic DP support

2022-09-01 Thread Robert Foss
On Wed, 31 Aug 2022 at 10:27, Tomi Valkeinen wrote: > > Hi, > > v5 of the series can be found from: > > https://lore.kernel.org/all/20220824130034.196041-1-tomi.valkei...@ideasonboard.com/ > > Changes to v5: > - Drop the broken "check AUX errors better" patch > - Fix sync pulse widths in "Reject m

Re: [PATCH v2 1/2] drm/cmdline-parser: Merge negative tests

2022-09-01 Thread Maíra Canal
Hi Michał Applied both patches to drm-misc-next. Best Regards, - Maíra Canal On 8/17/22 18:12, Michał Winiarski wrote: > Negative tests can be expressed as a single parameterized test case, > which highlights that we're following the same test logic (passing > invalid cmdline and expecting drm_m

Re: [PATCH v6 1/3] drm/bridge: ti-sn65dsi86: Reject modes with too large blanking

2022-09-01 Thread Robert Foss
On Wed, 31 Aug 2022 at 10:27, Tomi Valkeinen wrote: > > From: Tomi Valkeinen > > The front and back porch registers are 8 bits, and pulse width registers > are 15 bits, so reject any modes with larger periods. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 23

Re: [PATCH] drm/ttm: update bulk move object of ghost BO

2022-09-01 Thread Christian König
Am 01.09.22 um 13:11 schrieb Christian König: Am 01.09.22 um 11:29 schrieb ZhenGuo Yin: [Why] Ghost BO is released with non-empty bulk move object. There is a warning trace: WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0 [amdttm] Call Trace:    amddma_resv_reserve_fe

Re: [PATCH] drm/ttm: update bulk move object of ghost BO

2022-09-01 Thread Christian König
Am 01.09.22 um 11:29 schrieb ZhenGuo Yin: [Why] Ghost BO is released with non-empty bulk move object. There is a warning trace: WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0 [amdttm] Call Trace: amddma_resv_reserve_fences+0x10d/0x1f0 [amdkcl] amdttm_bo_put+0x28/

Re: [PATCH v17 00/10] Add MT8195 DisplayPort driver

2022-09-01 Thread AngeloGioacchino Del Regno
Il 01/09/22 06:41, Bo-Chen Chen ha scritto: This patch is separated from v10 which is including dp driver, phy driver and dpintf driver. This series is only contained the DisplayPort driver. For the entire series: Tested-by: AngeloGioacchino Del Regno Reviewed-by: AngeloGioacchino Del Regno

  1   2   >