Re: [PATCH 4/5] drm/damage-helper: Do partial updates if framebuffer has not been changed

2022-09-25 Thread Thomas Zimmermann
Hi Am 21.09.22 um 12:18 schrieb Ville Syrjälä: Maybe we have two clearly separate classes of uses case: 1. devices where only damage to the fb contents matter (eg. some kind of shadow fb that is the same size as the real fb). 2. devices where everything about the scanout process matters (eg

Re: [PATCH v4 09/21] drm/etnaviv: Prepare to dynamic dma-buf locking specification

2022-09-25 Thread cco
To whoom it may belong: Deepest sorrow to inform you that my husband Helmut passed by on July 21. This access will be cleared in a view days. Irene Ursprüngliche Nachricht Von: Christian König Datum: 01.09.22 08:50 (GMT+01:00) An: Dmitry Osipenko , David Airlie , Gerd Hoffma

[PATCH 1/2] drm/i915/gvt: Fix kernel-doc

2022-09-25 Thread Jiapeng Chong
drivers/gpu/drm/i915/gvt/vgpu.c:356: warning: expecting prototype for intel_gvt_destroy_vgpu(). Prototype was for intel_gvt_destroy_idle_vgpu() instead. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2276 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/i915/gvt

[PATCH 2/2] drm/i915/gvt: Remove the unused function get_pt_type()

2022-09-25 Thread Jiapeng Chong
The function get_pt_type is defined in the gtt.c file, but not called elsewhere, so delete this unused function. drivers/gpu/drm/i915/gvt/gtt.c:285:19: warning: unused function 'get_pt_type'. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2277 Reported-by: Abaci Robot Signed-off-by: Jiapen

Re: [PATCH v4 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195

2022-09-25 Thread Krzysztof Kozlowski
On 26/09/2022 03:19, Jason-JH Lin (林睿祥) wrote: > Hi Krzysztof, > > Thanks for the reviews. > > On Sun, 2022-09-25 at 09:52 +0200, Krzysztof Kozlowski wrote: >> On 24/09/2022 10:00, Jason-JH.Lin wrote: >>> For previous MediaTek SoCs, such as MT8173, there are 2 display HW >>> pipelines binding to

Re: [PATCH v1 15/17] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195

2022-09-25 Thread Krzysztof Kozlowski
On 26/09/2022 07:24, Chen-Yu Tsai wrote: > On Thu, Sep 22, 2022 at 3:20 PM Krzysztof Kozlowski > wrote: >> >> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>> Add dt-binding documentation of dpi for MediaTek MT8195 SoC. >>> >>> Signed-off-by: Guillaume Ranquet >>> >>> diff --git >>> a/Documenta

Re: [PATCH v10,1/3] soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config func

2022-09-25 Thread 胡俊光

Re: [PATCH] drm/amd/display: Fix mutex lock in dcn10

2022-09-25 Thread Christian König
Am 25.09.22 um 23:53 schrieb Daniel Gomez: Removal of DC_FP_* wrappers from dml (9696679bf7ac) provokes a mutex lock [2] on the amdgpu driver. Re-arrange the dcn10 code to avoid locking the mutex by placing the DC_FP_* wrappers around the proper functions. Of hand that looks correct to me now,

Re: [PATCH v10,2/3] drm: mediatek: Adjust the dpi output format to MT8186

2022-09-25 Thread 胡俊光

Re: [PATCH 01/12] drm/i915/gen8: Create separate reg definitions for new MCR registers

2022-09-25 Thread Balasubramani Vivekanandan
On 19.09.2022 15:32, Matt Roper wrote: > Gen8 was the first time our hardware had multicast registers (or at > least the first time the multicast nature was exposed and MMIO accesses > could be steered). There are some registers that transitioned from > singleton behavior to multicast during the g

[PATCH 6/7] nouveau/dmem: Evict device private memory during release

2022-09-25 Thread Alistair Popple
When the module is unloaded or a GPU is unbound from the module it is possible for device private pages to be left mapped in currently running processes. This leads to a kernel crash when the pages are either freed or accessed from the CPU because the GPU and associated data structures and callback

[PATCH 7/7] hmm-tests: Add test for migrate_device_range()

2022-09-25 Thread Alistair Popple
Signed-off-by: Alistair Popple --- lib/test_hmm.c | 119 +- lib/test_hmm_uapi.h| 1 +- tools/testing/selftests/vm/hmm-tests.c | 49 +++- 3 files changed, 148 insertions(+), 21 deletions(-) diff --git a/lib/test_hmm.c

[PATCH 5/7] nouveau/dmem: Refactor nouveau_dmem_fault_copy_one()

2022-09-25 Thread Alistair Popple
nouveau_dmem_fault_copy_one() is used during handling of CPU faults via the migrate_to_ram() callback and is used to copy data from GPU to CPU memory. It is currently specific to fault handling, however a future patch implementing eviction of data during teardown needs similar functionality. Refac

[PATCH 4/7] mm/migrate_device.c: Add migrate_device_range()

2022-09-25 Thread Alistair Popple
Device drivers can use the migrate_vma family of functions to migrate existing private anonymous mappings to device private pages. These pages are backed by memory on the device with drivers being responsible for copying data to and from device memory. Device private pages are freed via the pgmap-

[PATCH 3/7] mm/migrate_device.c: Refactor migrate_vma and migrate_deivce_coherent_page()

2022-09-25 Thread Alistair Popple
migrate_device_coherent_page() reuses the existing migrate_vma family of functions to migrate a specific page without providing a valid mapping or vma. This looks a bit odd because it means we are calling migrate_vma_*() without setting a valid vma, however it was considered acceptable at the time

[PATCH 2/7] mm: Free device private pages have zero refcount

2022-09-25 Thread Alistair Popple
Since 27674ef6c73f ("mm: remove the extra ZONE_DEVICE struct page refcount") device private pages have no longer had an extra reference count when the page is in use. However before handing them back to the owning device driver we add an extra reference count such that free pages have a reference c

[PATCH 1/7] mm/memory.c: Fix race when faulting a device private page

2022-09-25 Thread Alistair Popple
When the CPU tries to access a device private page the migrate_to_ram() callback associated with the pgmap for the page is called. However no reference is taken on the faulting page. Therefore a concurrent migration of the device private page can free the page and possibly the underlying pgmap. Thi

[PATCH 0/7] Fix several device private page reference counting issues

2022-09-25 Thread Alistair Popple
This series aims to fix a number of page reference counting issues in drivers dealing with device private ZONE_DEVICE pages. These result in use-after-free type bugs, either from accessing a struct page which no longer exists because it has been removed or accessing fields within the struct page wh

Re: [PATCH v1 02/17] clk: mediatek: add VDOSYS1 clock

2022-09-25 Thread Chen-Yu Tsai
On Mon, Sep 26, 2022 at 1:09 PM Chen-Yu Tsai wrote: > > On Tue, Sep 20, 2022 at 12:59 AM Guillaume Ranquet > wrote: > > > > From: Pablo Sun > > > > Add the clock gate definition for the DPI1 hardware > > in VDOSYS1. > > > > The parent clock "hdmi_txpll" is already defined in > > `mt8195.dtsi`. >

Re: [PATCH v1 15/17] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195

2022-09-25 Thread Chen-Yu Tsai
On Thu, Sep 22, 2022 at 3:20 PM Krzysztof Kozlowski wrote: > > On 19/09/2022 18:56, Guillaume Ranquet wrote: > > Add dt-binding documentation of dpi for MediaTek MT8195 SoC. > > > > Signed-off-by: Guillaume Ranquet > > > > diff --git > > a/Documentation/devicetree/bindings/display/mediatek/media

Re: [PATCH v1 02/17] clk: mediatek: add VDOSYS1 clock

2022-09-25 Thread Chen-Yu Tsai
On Tue, Sep 20, 2022 at 12:59 AM Guillaume Ranquet wrote: > > From: Pablo Sun > > Add the clock gate definition for the DPI1 hardware > in VDOSYS1. > > The parent clock "hdmi_txpll" is already defined in > `mt8195.dtsi`. > > Signed-off-by: Pablo Sun > Signed-off-by: Guillaume Ranquet Reviewed-

Re: [PATCH v3] video: fbdev: smscufx: Fix use-after-free in ufx_ops_open()

2022-09-25 Thread Hyunwoo Kim
Thank you for your review. Best Regards, Hyunwoo Kim.

Re: [PATCH] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188

2022-09-25 Thread liangxu . xu
On Fri, 2022-09-23 at 13:16 +0200, Krzysztof Kozlowski wrote: > On 23/09/2022 03:39, liangxu...@mediatek.com wrote: > > From: liangxu xu > > > > Add dt-binding documentation of dp for MediaTek MT8188 SoC. > > > > Signed-off-by: liangxu xu > > --- > > Where is the DTS? Where are driver changes?

Re: [PATCH v4 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195

2022-09-25 Thread 林睿祥

[PATCH -next] drm/vc4: v3d: make render_wait static

2022-09-25 Thread ruanjinjie
The symbol is not used outside of the file, so mark it static. Fixes the following warning: ./drivers/gpu/drm/vc4/vc4_irq.c:60:1: warning: symbol 'render_wait' was not declared. Should it be static? Signed-off-by: ruanjinjie --- drivers/gpu/drm/vc4/vc4_irq.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH 1/2] drm/tests: Split drm_test_dp_mst_calc_pbn_mode into parameterized tests

2022-09-25 Thread Michał Winiarski
On Sun, Sep 25, 2022 at 07:27:18PM -0300, Maíra Canal wrote: > The drm_test_dp_mst_calc_pbn_mode is based on a loop that executes tests > for a couple of test cases. This could be better represented by > parameterized tests, provided by KUnit. > > So, convert the drm_test_dp_mst_calc_pbn_mode into

[PATCH -next] drm/ast: make ast_modeset static

2022-09-25 Thread ruanjinjie
The symbol is not used outside of the file, so mark it static. Fixes the following warning: drivers/gpu/drm/ast/ast_drv.c:42:5: warning: symbol 'ast_modeset' was not declared. Should it be static? Signed-off-by: ruanjinjie --- drivers/gpu/drm/ast/ast_drv.c | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH 2/2] drm/tests: Split drm_test_dp_mst_sideband_msg_req_decode into parameterized tests

2022-09-25 Thread Michał Winiarski
On Sun, Sep 25, 2022 at 07:27:19PM -0300, Maíra Canal wrote: > The drm_test_dp_mst_sideband_msg_req_decode repeats the same test > structure with different parameters. This could be better represented > by parameterized tests, provided by KUnit. > > So, convert drm_test_dp_mst_sideband_msg_req_dec

[PATCH -next] drm/tegra: make gather_bo_ops static

2022-09-25 Thread ruanjinjie
The symbol is not used outside of the file, so mark it static. Fixes the following warning: ./drivers/gpu/drm/tegra/submit.c:136:28: warning: symbol 'gather_bo_ops' was not declared. Should it be static? Signed-off-by: ruanjinjie --- drivers/gpu/drm/tegra/submit.c | 2 +- 1 file changed, 1 ins

[GIT PULL] exynos-drm-next

2022-09-25 Thread Inki Dae
Hi Dave and Daniel, Sorry for late. Just one cleanup and fixup which corrects return type. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 320305923c88258ce50c75bf721e9bf2e420ab27: Merge tag 'du-next-20220907' of git://linuxtv.org/pin

Re: [PATCH -next] video: fbdev: tridentfb: Fix missing pci_disable_device() in probe and remove

2022-09-25 Thread Ruan Jinjie
Thank you very much! On 2022/9/26 0:21, Helge Deller wrote: > On 9/22/22 03:37, ruanjinjie wrote: >> Replace pci_enable_device() with pcim_enable_device(), >> pci_disable_device() and pci_release_regions() will be >> called in release automatically. >> >> Signed-off-by: ruanjinjie > > applied. >

Re: [PATCH v4 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195

2022-09-25 Thread 林睿祥

Re: [PATCH v2 04/16] skbuff: Phase out ksize() fallback for frag_size

2022-09-25 Thread Kees Cook
On Sun, Sep 25, 2022 at 09:17:40AM +0200, Paolo Abeni wrote: > On Fri, 2022-09-23 at 13:28 -0700, Kees Cook wrote: > > All callers of APIs that allowed a 0-sized frag_size appear to be > > passing actual size information already > > AFAICS, not yet: > > drivers/net/ethernet/qlogic/qed/qed_ll2.c:

Re: [PATCH v2 14/16] kasan: Remove ksize()-related tests

2022-09-25 Thread Kees Cook
On Sat, Sep 24, 2022 at 10:15:18AM +0200, Dmitry Vyukov wrote: > On Fri, 23 Sept 2022 at 22:28, Kees Cook wrote: > > > > In preparation for no longer unpoisoning in ksize(), remove the behavioral > > self-tests for ksize(). > > > > [...] > > -/* Check that ksize() makes the whole object accessible

[PATCH v11.5] overflow: Introduce overflows_type() and __castable_to_type()

2022-09-25 Thread Kees Cook
Add overflows_type() to test if a variable or constant value would overflow another variable or type. This can be used as a constant expression for static_assert() (which requires a constant expression[1][2]) when used on constant values. This must be constructed manually, since __builtin_add_overf

Re: [PATCH v11 3/9] compiler_types.h: Add assert_same_type to catch type mis-match while compiling

2022-09-25 Thread Kees Cook
On Fri, Sep 23, 2022 at 11:26:22AM +0300, Gwan-gyeong Mun wrote: > Adds assert_same_type and assert_same_typable macros to catch type > mis-match while compiling. The existing typecheck() macro outputs build > warnings, but the newly added assert_same_type() macro uses the > static_assert macro (wh

Re: [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-09-25 Thread Dmitry Osipenko
25.08.2022 17:36, Hans de Goede пишет: > Before this commit when we want userspace to use the acpi_video backlight > device we register both the GPU's native backlight device and acpi_video's > firmware acpi_video# backlight device. This relies on userspace preferring > firmware type backlight devi

[Bug 216516] s2ram freezes screen (Ryzen-5650U incl. Radeon GPU)

2022-09-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216516 --- Comment #12 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- > Compiled with CONFIG_AMD_PMC. > Going to s2idle two times. > (first time just for a few seconds) It looks better to me now. > After less than 8 hours in s2idle the ba

[PATCH 2/2] drm/tests: Split drm_test_dp_mst_sideband_msg_req_decode into parameterized tests

2022-09-25 Thread Maíra Canal
The drm_test_dp_mst_sideband_msg_req_decode repeats the same test structure with different parameters. This could be better represented by parameterized tests, provided by KUnit. So, convert drm_test_dp_mst_sideband_msg_req_decode into parameterized tests and make the test's allocations and prints

[PATCH 1/2] drm/tests: Split drm_test_dp_mst_calc_pbn_mode into parameterized tests

2022-09-25 Thread Maíra Canal
The drm_test_dp_mst_calc_pbn_mode is based on a loop that executes tests for a couple of test cases. This could be better represented by parameterized tests, provided by KUnit. So, convert the drm_test_dp_mst_calc_pbn_mode into parameterized tests. Signed-off-by: Maíra Canal --- .../gpu/drm/tes

[PATCH] drm/amd/display: Fix mutex lock in dcn10

2022-09-25 Thread Daniel Gomez
Removal of DC_FP_* wrappers from dml (9696679bf7ac) provokes a mutex lock [2] on the amdgpu driver. Re-arrange the dcn10 code to avoid locking the mutex by placing the DC_FP_* wrappers around the proper functions. This fixes the following WARN/stacktrace: BUG: sleeping function called from invali

[Bug 216525] amdgpu VM_L2_PROTECTION_FAULT_STATUS:0x00000000

2022-09-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216525 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH 8/9] arm64: dts: qcom: sdm845: change DSI PHY node name to generic one

2022-09-25 Thread Steev Klimaszewski
On 9/24/22 4:01 AM, Dmitry Baryshkov wrote: Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845

Re: [PATCH -next] video: fbdev: tridentfb: Fix missing pci_disable_device() in probe and remove

2022-09-25 Thread Helge Deller
On 9/22/22 03:37, ruanjinjie wrote: Replace pci_enable_device() with pcim_enable_device(), pci_disable_device() and pci_release_regions() will be called in release automatically. Signed-off-by: ruanjinjie applied. Thanks! Helge --- drivers/video/fbdev/tridentfb.c | 6 +- 1 file chan

[PATCH -next] drm/nouveau/disp: fix cast removes address space of expression warnings

2022-09-25 Thread ruanjinjie
When build Linux kernel with 'make C=2', encounter the following warnings: ./drivers/gpu/drm/nouveau/dispnv50/disp.c:134:34: warning: cast removes address space '__iomem' of expression ./drivers/gpu/drm/nouveau/dispnv50/disp.c:197:34: warning: cast removes address space '__iomem' of expression

[PATCH] video: fbdev: smscufx: Fix use-after-free in ufx_ops_open()

2022-09-25 Thread Hyunwoo Kim
A race condition may occur if the user physically removes the USB device while calling open() for this device node. This is a race condition between the ufx_ops_open() function and the ufx_usb_disconnect() function, which may eventually result in UAF. So, add a mutex to the ufx_ops_open() and ufx

[PATCH v2] video: fbdev: smscufx: Fix use-after-free in ufx_ops_open()

2022-09-25 Thread Hyunwoo Kim
A race condition may occur if the user physically removes the USB device while calling open() for this device node. This is a race condition between the ufx_ops_open() function and the ufx_usb_disconnect() function, which may eventually result in UAF. So, add a mutex to the ufx_ops_open() and ufx

[PATCH 1/2] drivers: gpu: drm: add driver for samsung s6e3fc2x01 cmd mode panel

2022-09-25 Thread Nia Espera
Adds a dedicated driver for the Samsung s6e3fc2x01 panel used in OnePlus 6T smartphones which was previously driven by the sofef00 panel driver Signed-off-by: Nia Espera --- MAINTAINERS | 5 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/

[PATCH 2/2] drivers: gpu: drm: remove support for sofef00 driver on s6e3fc2x01 panel

2022-09-25 Thread Nia Espera
Removes functionality from sofef00 panel driver which allowed it to drive the s6e3fc2x01 panel Signed-off-by: Nia Espera --- drivers/gpu/drm/panel/Kconfig | 6 +++--- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 18 -- 2 files changed, 3 insertions(+), 21 dele

[PATCH -next] drm/nouveau/disp: make gv100_disp_core_mthd_base static

2022-09-25 Thread ruanjinjie
The symbol is not used outside of the file, so mark it static. Fixes the following warning: ./drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c:591:1: warning: symbol 'gv100_disp_core_mthd_base' was not declared. Should it be static? Signed-off-by: ruanjinjie --- drivers/gpu/drm/nouveau/nvkm/en

Re: [PATCH] video: fbdev: smscufx: Fix use-after-free in ufx_ops_open()

2022-09-25 Thread Hyunwoo Kim
On Sun, Sep 25, 2022 at 01:57:46PM +0200, Helge Deller wrote: > On 9/25/22 13:03, Hyunwoo Kim wrote: > > A race condition may occur if the user physically removes the > > USB device while calling open() for this device node. > > > > This is a race condition between the ufx_ops_open() function and

Re: [PATCH v2] video: fbdev: smscufx: Fix use-after-free in ufx_ops_open()

2022-09-25 Thread Hyunwoo Kim
On Sun, Sep 25, 2022 at 03:09:47PM +0200, Helge Deller wrote: > it seems user and console don't need to be protected by the lock. > Does it make sense to move them out of the lock? you're right. Since both variables are not related to a race condition, it is better to get them out of the lock. I

[PATCH v3] video: fbdev: smscufx: Fix use-after-free in ufx_ops_open()

2022-09-25 Thread Hyunwoo Kim
A race condition may occur if the user physically removes the USB device while calling open() for this device node. This is a race condition between the ufx_ops_open() function and the ufx_usb_disconnect() function, which may eventually result in UAF. So, add a mutex to the ufx_ops_open() and ufx

[PATCH 0/2] Samsung s6e3fc2x01 panel driver for OnePlus 6T

2022-09-25 Thread Nia Espera
This patch series adds proper support for the panel used in OnePlus 6T smartphones (s6e3fc2x01). Previously, the panel relied on the driver used by the sofef00 panel which failed to properly initialise it after a reset. Nia Espera (2): drivers: gpu: drm: add driver for samsung s6e3fc2x01 cmd mod

Re: [PATCH v2 00/33] drm: Analog TV Improvements

2022-09-25 Thread Noralf Trønnes
Den 22.09.2022 16.25, skrev Maxime Ripard: > Hi, > > Here's a series aiming at improving the command line named modes support, > and more importantly how we deal with all the analog TV variants. > > The named modes support were initially introduced to allow to specify the > analog TV mode to b

Re: [PATCH v3] video: fbdev: smscufx: Fix use-after-free in ufx_ops_open()

2022-09-25 Thread Helge Deller
On 9/25/22 15:32, Hyunwoo Kim wrote: A race condition may occur if the user physically removes the USB device while calling open() for this device node. This is a race condition between the ufx_ops_open() function and the ufx_usb_disconnect() function, which may eventually result in UAF. So, ad

[PATCH] headers: Remove some left-over license text in include/uapi/drm/

2022-09-25 Thread Christophe JAILLET
There is already a SPDX-License-Identifier tag, so the corresponding license text can be removed. Signed-off-by: Christophe JAILLET --- include/uapi/drm/armada_drm.h | 4 include/uapi/drm/etnaviv_drm.h | 12 include/uapi/drm/exynos_drm.h | 5 - include/uapi/drm/omap_drm

Re: [PATCH v2] video: fbdev: smscufx: Fix use-after-free in ufx_ops_open()

2022-09-25 Thread Helge Deller
On 9/25/22 14:32, Hyunwoo Kim wrote: A race condition may occur if the user physically removes the USB device while calling open() for this device node. This is a race condition between the ufx_ops_open() function and the ufx_usb_disconnect() function, which may eventually result in UAF. So, ad

Re: [PATCH] video: fbdev: smscufx: Fix use-after-free in ufx_ops_open()

2022-09-25 Thread Helge Deller
On 9/25/22 13:03, Hyunwoo Kim wrote: A race condition may occur if the user physically removes the USB device while calling open() for this device node. This is a race condition between the ufx_ops_open() function and the ufx_usb_disconnect() function, which may eventually result in UAF. So, ad

Re: [PATCH 1/2] video: fbdev: gbefb: Convert to use dev_groups

2022-09-25 Thread Helge Deller
On 9/2/22 04:55, Jiasheng Jiang wrote: The driver core supports the ability to handle the creation and removal of device-specific sysfs files in a race-free manner. Moreover, it can guarantee the success of creation. Therefore, it should be better to convert to use dev_groups. applied. Thanks!

Re: [PATCH 2/2] video: fbdev: gbefb: Remove unproper information

2022-09-25 Thread Helge Deller
On 9/2/22 04:56, Jiasheng Jiang wrote: When drivers are working properly, they are quiet. Therefore, the fb_info() should be removed. NAK. This seems to be useful info about the detected card and it's only printed once. Helge Signed-off-by: Jiasheng Jiang --- drivers/video/fbdev/gbefb.c |

Re: [PATCH] fbdev: remove redundant initialization to variable identical

2022-09-25 Thread Helge Deller
On 9/7/22 15:50, Colin Ian King wrote: The variable identical is being initialized with a value that is never read. The variable is being re-assigned later on. The initialization is redundant and can be removed. Cleans up clang scan-build warning: drivers/video/fbdev/udlfb.c:373:6: warning: Valu

Re: [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH()

2022-09-25 Thread Helge Deller
On 9/14/22 12:22, Jiapeng Chong wrote: The function VAR_MATCH is defined in the controlfb.c file, but not called elsewhere, so delete this unused function. drivers/video/fbdev/controlfb.c:111:19: warning: unused function 'VAR_MATCH'. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2153 Rep

Re: [PATCH] video: fbdev: tridentfb: Remove the unused function shadowmode_off()

2022-09-25 Thread Helge Deller
On 9/14/22 12:23, Jiapeng Chong wrote: The function shadowmode_off() is defined in the tridentfb.c file, but not called elsewhere, so delete this unused function. drivers/video/fbdev/tridentfb.c:1131:20: warning: unused function 'shadowmode_off'. Link: https://bugzilla.openanolis.cn/show_bug.c

Re: [PATCH] video: fbdev: arkfb: Remove the unused function dac_read_reg()

2022-09-25 Thread Helge Deller
On 9/14/22 12:23, Jiapeng Chong wrote: The function dac_read_reg() is defined in the arkfb.c file, but not called elsewhere, so delete this unused function. drivers/video/fbdev/arkfb.c:322:18: warning: unused function 'dac_read_reg'. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2155 Rep

Re: [PATCH 2/2] video: fbdev: uvesafb: convert snprintf to scnprintf

2022-09-25 Thread Helge Deller
On 9/18/22 01:44, Jules Irenge wrote: Coccinelle reports a warning WARNING: use scnprintf or sprintf Adding to that, there has also been some slow migration from snprintf to scnprintf This article explains the rationale for this change https: //lwn.net/Articles/69419/ Signed-off-by: Jules Iren

Re: [PATCH -next] video: fbdev: imxfb: Remove redundant dev_err call

2022-09-25 Thread Helge Deller
On 9/23/22 12:20, Shang XiaoJing wrote: devm_ioremap_resource() prints error message in itself. Remove the dev_err call to avoid redundant error message. Signed-off-by: Shang XiaoJing applied. Thanks, Helge --- drivers/video/fbdev/imxfb.c | 1 - 1 file changed, 1 deletion(-) diff --git

[Bug 216516] s2ram freezes screen (Ryzen-5650U incl. Radeon GPU)

2022-09-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216516 --- Comment #11 from kolAflash (kolafl...@kolahilft.de) --- P.S. I think using S3 is somehow intended by the OEM for the HP EliteBook 845 G8. I consider the S3 option just being hidden. You just need to know how to change that MSCE variable witho

[Bug 216516] s2ram freezes screen (Ryzen-5650U incl. Radeon GPU)

2022-09-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216516 --- Comment #10 from kolAflash (kolafl...@kolahilft.de) --- Created attachment 301870 --> https://bugzilla.kernel.org/attachment.cgi?id=301870&action=edit kernel log for s2idle: v6.0-rc6 with CONFIG_AMD_PMC enabled (In reply to Mario Limonciell

Re: [PATCH v4 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195

2022-09-25 Thread Krzysztof Kozlowski
On 24/09/2022 10:00, Jason-JH.Lin wrote: > For previous MediaTek SoCs, such as MT8173, there are 2 display HW > pipelines binding to 1 mmsys with the same power domain, the same > clock driver and the same mediatek-drm driver. > > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding

Re: [PATCH v2 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy

2022-09-25 Thread Krzysztof Kozlowski
On 24/09/2022 11:15, Dmitry Baryshkov wrote: > On 24/09/2022 12:12, Krzysztof Kozlowski wrote: >> On 24/09/2022 10:51, Dmitry Baryshkov wrote: >>> From: Loic Poulain >>> >>> QCM2290 platform uses the 14nm DSI PHY driver. >>> >>> Signed-off-by: Loic Poulain >>> [DB: changed compat to follow the ag

Re: [PATCH v2 04/16] skbuff: Phase out ksize() fallback for frag_size

2022-09-25 Thread Paolo Abeni
On Fri, 2022-09-23 at 13:28 -0700, Kees Cook wrote: > All callers of APIs that allowed a 0-sized frag_size appear to be > passing actual size information already AFAICS, not yet: drivers/net/ethernet/qlogic/qed/qed_ll2.c: skb = build_skb(buffer->data, 0); // -> __build_skb(..., 0)